Contact dialog feature reviewed.

Reviewed by: Katri Kaikkonen

diff --git a/src/engine/contactmanager.h b/src/engine/contactmanager.h
index 1539866..97c1c96 100644 (file)
--- a/src/engine/contactmanager.h
+++ b/src/engine/contactmanager.h
@@ -14,11 +14,6 @@ class ContactManager : public QObject
     Q_OBJECT
 public:
     /**
-    * @brief Friend class for ContactManagerPrivate.
-    */
-    friend class ContactManagerPrivate;
-
-    /**
     * @brief Constructor
     *
     * @param parent QObject
@@ -44,19 +39,6 @@ public:
     */
     void requestContactGuids();
 
-/*******************************************************************************
-* SIGNALS
-******************************************************************************/
-signals:
-    /**
-    * @brief Signal for contacts guids added.
-    *
-    * Contact guids has Facebook ID as key and Guid as value.. Guid is a globally
-    * unique ID of a contact, which can be used with other datastores.
-    * @param contactGuids list of contact guids
-    */
-    void contactsGuidsAdded(const QHash<QString, QString> &contactGuids);
-
 /******************************************************************************
 * DATA MEMBERS
 ******************************************************************************/

diff --git a/src/engine/contactmanagerprivate.cpp b/src/engine/contactmanagerprivate.cpp
index 656e6d8..96ac732 100644 (file)
--- a/src/engine/contactmanagerprivate.cpp
+++ b/src/engine/contactmanagerprivate.cpp
@@ -19,8 +19,6 @@ ContactManagerPrivate::ContactManagerPrivate(QObject *parent)
 {
     qDebug() << __PRETTY_FUNCTION__;
 
-    m_parent = static_cast<ContactManager *>(parent);
-
     const QString MAEMO5_MANAGER_NAME = "maemo5";
 
     QStringList availableManagers = QContactManager::availableManagers();

diff --git a/src/engine/contactmanagerprivate.h b/src/engine/contactmanagerprivate.h
index ba4223a..44f35d4 100644 (file)
--- a/src/engine/contactmanagerprivate.h
+++ b/src/engine/contactmanagerprivate.h
@@ -27,6 +27,7 @@ public:
 /*******************************************************************************
 * MEMBER FUNCTIONS AND SLOTS
 ******************************************************************************/
+public:
     /**
     * @brief Returns contact's guid from contact's facebook ID.
     *
@@ -56,7 +57,6 @@ private:
 * DATA MEMBERS
 ******************************************************************************/
 private:
-    ContactManager *m_parent;               ///< Parent
     QContactManager *m_manager;             ///< Contact manager
     QHash<QString, QString> m_contactGuids; ///< List of contact GUIDS
 };

diff --git a/src/ui/listview.cpp b/src/ui/listview.cpp
index d899f09..c1e8617 100644 (file)
--- a/src/ui/listview.cpp
+++ b/src/ui/listview.cpp
@@ -245,13 +245,6 @@ void ListView::removeLastItem()
     }
 }
 
-QHash<QString, ListItem *> ListView::listItems() const
-{
-    qDebug() << __PRETTY_FUNCTION__;
-
-    return m_listItems;
-}
-
 ListItem *ListView::selectedItem()
 {
     qDebug() << __PRETTY_FUNCTION__;

diff --git a/src/ui/listview.h b/src/ui/listview.h
index 5697c37..eaf32fb 100644 (file)
--- a/src/ui/listview.h
+++ b/src/ui/listview.h
@@ -155,14 +155,6 @@ public:
     ListItem *listItemAt(int index);
 
     /**
-    * @brief Returns all list items.
-    *
-    * Item ID is key.
-    * @return list of ListItems
-    */
-    QHash<QString, ListItem *> listItems() const;
-
-    /**
     * @brief Prepends item to view and item list.
     *
     * @param key user ID