Merge branch 'new_panels' of https://vcs.maemo.org/git/situare into new_panels
authorSami Rämö <sami.ramo@ixonos.com>
Mon, 16 Aug 2010 12:28:20 +0000 (15:28 +0300)
committerSami Rämö <sami.ramo@ixonos.com>
Mon, 16 Aug 2010 12:37:52 +0000 (15:37 +0300)
 - Reviewed by Sami Rämö

 - Made also some small fixes

Conflicts:
src/ui/panelbar.cpp
src/ui/paneltab.h
src/ui/tabbedpanel.cpp

1  2 
src/ui/paneltabbar.cpp
src/ui/tabbedpanel.cpp

@@@ -28,7 -28,7 +28,7 @@@
  
  PanelTabBar::PanelTabBar(QWidget *parent)
      : QWidget(parent),
--      m_activeTab(-1)
++      m_activeTab(-1) ///< @todo magic
  {
      qDebug() << __PRETTY_FUNCTION__;
  
@@@ -63,7 -65,7 +65,7 @@@ int PanelTabBar::insertTab(int index, c
      m_tabButtonGroup->addButton(new PanelTab(this), index);
      m_tabButtonGroup->button(index)->setIcon(icon);
  
--    // [BEGIN]: Purkkaa (to be removed ASAP!!!)
++    ///< @todo  [BEGIN]: Purkkaa (to be removed ASAP!!!)
      if(index > 0)
          verticalStartPoint += 65 * index;
  
@@@ -88,6 -98,6 +98,7 @@@ void PanelTabBar::setCurrentIndex(int i
      qDebug() << __PRETTY_FUNCTION__;
  
      if(m_activeTab == index) {
++        ///< @todo magic
          m_activeTab = -1;
          emit tabCloseRequested(index);
      } else {
@@@ -98,11 -97,12 +97,13 @@@ int TabbedPanel::addTab(QWidget *widget
  {
      qDebug() << __PRETTY_FUNCTION__;
  
-     ///< @todo magic
-     return insertTab(-1, widget, icon);
++
+     const int APPEND_INDEX = -1;
+     return insertTab(APPEND_INDEX, widget, icon);
  }
  
- int TabbedPanel::insertTab(int index, QWidget *widget, const QIcon& icon)
+ void TabbedPanel::closePanel()
  {
      qDebug() << __PRETTY_FUNCTION__;
  
@@@ -131,19 -134,29 +135,28 @@@ void TabbedPanel::resizePanel(const QSi
  {
      qDebug() << __PRETTY_FUNCTION__;
  
-     if(m_isOpen)
-         emit toggleState();
- }
 -    this->resize(PANEL_BAR_TABBED_WIDTH + PANEL_WIDTH,
 -                 size.height() - PANEL_TOP_PADDING - PANEL_BOTTOM_PADDING);
++    resize(PANEL_BAR_TABBED_WIDTH + PANEL_WIDTH,
++           size.height() - PANEL_TOP_PADDING - PANEL_BOTTOM_PADDING);
  
- void TabbedPanel::openPanel()
- {
-     qDebug() << __PRETTY_FUNCTION__;
 -    if (!m_isOpen) {
++    if (!m_isOpen)
+         move(size.width() - PANEL_TAB_WIDTH - PANEL_BAR_WIDTH, PANEL_TOP_PADDING);
 -    } else {
 -        move(size.width() - PANEL_TAB_WIDTH - PANEL_BAR_WIDTH - PANEL_WIDTH,
 -                   PANEL_TOP_PADDING);
 -    }
++    else
++        move(size.width() - PANEL_TAB_WIDTH - PANEL_BAR_WIDTH - PANEL_WIDTH, PANEL_TOP_PADDING);
+     m_panelBar->resizeBar(size);
+     m_panelContent->resizePanelContent(size);
 -    m_panelStateClosed->assignProperty(this, "pos",
 -                        QPoint(size.width() - PANEL_TAB_WIDTH - PANEL_BAR_WIDTH,
 -                               PANEL_TOP_PADDING));
 -    m_panelStateOpened->assignProperty(this, "pos",
 -                        QPoint(size.width() - PANEL_TAB_WIDTH - PANEL_BAR_WIDTH - PANEL_WIDTH,
 -                               PANEL_TOP_PADDING));
++    QPoint closedPosition(size.width() - PANEL_TAB_WIDTH - PANEL_BAR_WIDTH, PANEL_TOP_PADDING);
++    m_panelStateClosed->assignProperty(this, "pos", closedPosition);
++
++    QPoint openedPosition(size.width() - PANEL_TAB_WIDTH - PANEL_BAR_WIDTH - PANEL_WIDTH,
++                          PANEL_TOP_PADDING);
++    m_panelStateOpened->assignProperty(this, "pos", openedPosition);
 +
-     if(!m_isOpen)
-         emit toggleState();
  }
  
- void TabbedPanel::showTab(int index)
+ void TabbedPanel::showPanel(QWidget *widget)
  {
      qDebug() << __PRETTY_FUNCTION__;