kvm: Fix dirty log temporary buffer size
authorJan Kiszka <jan.kiszka@siemens.com>
Fri, 1 May 2009 18:52:47 +0000 (20:52 +0200)
committerAnthony Liguori <aliguori@us.ibm.com>
Fri, 22 May 2009 15:50:33 +0000 (10:50 -0500)
The buffer passed to KVM_GET_DIRTY_LOG requires one bit per page. Fix
the size calculation in kvm_physical_sync_dirty_bitmap accordingly,
avoiding allocation of extremly oversized buffers.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

kvm-all.c

index f4851c0..3b6b5ed 100644 (file)
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -290,7 +290,7 @@ void kvm_physical_sync_dirty_bitmap(target_phys_addr_t start_addr,
             return;
     }
 
-    alloc_size = mem->memory_size >> TARGET_PAGE_BITS / sizeof(d.dirty_bitmap);
+    alloc_size = ((mem->memory_size >> TARGET_PAGE_BITS) + 7) / 8;
     d.dirty_bitmap = qemu_mallocz(alloc_size);
 
     d.slot = mem->slot;