1 ##############################################################################
2 # $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm $
3 # $Date: 2008-07-03 10:19:10 -0500 (Thu, 03 Jul 2008) $
6 ##############################################################################
8 package Perl::Critic::Policy::BuiltinFunctions::ProhibitLvalueSubstr;
15 use Perl::Critic::Utils qw{ :severities :classification };
16 use base 'Perl::Critic::Policy';
18 our $VERSION = '1.088';
20 #-----------------------------------------------------------------------------
22 Readonly::Scalar my $DESC => q{Lvalue form of "substr" used};
23 Readonly::Scalar my $EXPL => [ 165 ];
25 #-----------------------------------------------------------------------------
27 sub supported_parameters { return () }
28 sub default_severity { return $SEVERITY_MEDIUM }
29 sub default_themes { return qw( core maintenance pbp ) }
30 sub applies_to { return 'PPI::Token::Word' }
32 #-----------------------------------------------------------------------------
35 my ($self, $elem, undef) = @_;
37 return if $elem ne 'substr';
38 return if ! is_function_call($elem);
41 while ($sib = $sib->snext_sibling()) {
42 if ( $sib->isa( 'PPI::Token::Operator') && $sib eq q{=} ) {
43 return $self->violation( $DESC, $EXPL, $sib );
51 #-----------------------------------------------------------------------------
59 Perl::Critic::Policy::BuiltinFunctions::ProhibitLvalueSubstr - Use 4-argument C<substr> instead of writing C<substr($foo, 2, 6) = $bar>.
63 This Policy is part of the core L<Perl::Critic> distribution.
68 Conway discourages the use of C<substr()> as an lvalue, instead
69 recommending that the 4-argument version of C<substr()> be used instead.
71 substr($something, 1, 2) = $newvalue; # not ok
72 substr($something, 1, 2, $newvalue); # ok
77 This Policy is not configurable except for the standard options.
82 Graham TerMarsch <graham@howlingfrog.com>
86 Copyright (C) 2005-2007 Graham TerMarsch. All rights reserved.
88 This program is free software; you can redistribute it and/or modify
89 it under the same terms as Perl itself.
95 # cperl-indent-level: 4
97 # indent-tabs-mode: nil
98 # c-indentation-style: bsd
100 # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :