=head1 DESCRIPTION
-Maemian::Command is a thin wrapper around IPC::Run, that catches exception
-and implements a useful default behaviour for input and output redirection.
+Maemian::Command is a thin wrapper around IPC::Run, that catches exceptions
+and implements useful default behaviour for input and output redirection.
Maemian::Command provides a function spawn() which is a wrapper
around IPC::Run::run() resp. IPC::Run::start() (depending on whether a
and !$opts->{success}) {
require Util;
if ($opts->{description}) {
- Util::fail("$opts->{description} failed with error code ".
- $opts->{harness}->result);
+ Util::fail("$opts->{description} failed with error code ".
+ $opts->{harness}->result);
} elsif (@cmds == 1) {
- Util::fail("$cmds[0][0] failed with error code ".
- $opts->{harness}->result);
+ Util::fail("$cmds[0][0] failed with error code ".
+ $opts->{harness}->result);
} else {
- Util::fail("command failed with error code ".
+ Util::fail("command failed with error code ".
$opts->{harness}->result);
}
}
Util::fail("$opts->{description} failed with error code ".
$opts->{harness}->result);
} else {
- Util::fail("command failed with error code ".
+ Util::fail("command failed with error code ".
$opts->{harness}->result);
}
}
=head1
-Maemian is the maemo version of maemian - a policy checker designed to
+Maemian is the maemo version of lintian - a policy checker designed to
assure the quality of a package uploaded into the maemo.org repositories.
The goal of maemian is to improve quality by checking that the maemo
packaging policy is followed. In order to do that it reads files in the
=cut
-use strict;
+use strict; # Warnings turned on via -w
use lib qw(lib/);
use Getopt::Long;
our $OPT_MAEMIAN_LAB = ""; #string for the --lab option
our $OPT_MAEMIAN_ARCHIVEDIR = "";#string for the --archivedir option
our $OPT_MAEMIAN_DIST = ""; #string for the --dist option
-our $OPT_MAEMIAN_ARCH = ""; #string for the --arch option
our $OPT_MAEMIAN_AREA = ""; #string for the --area option
# These options can also be used via default or environment variables
our $MAEMIAN_CFG = ""; #config file to use
our $MAEMIAN_ROOT = "/home/jeremiah/maemian/"; #location of the maemian modules
-our $OPT_MAEMIAN_SECTION = ""; #old name for OPT_MAEMIAN_ARCH
+my $MAEMIAN_ARCH = "any";
my $experimental_output_opts = undef;
our $MAEMIAN_ARCHIVEDIR = undef;
our $MAEMIAN_DIST = undef;
our $MAEMIAN_UNPACK_LEVEL = undef;
-our $MAEMIAN_ARCH = undef;
our $MAEMIAN_SECTION = undef;
our $MAEMIAN_AREA = undef;
"dist=s" => \$OPT_MAEMIAN_DIST,
"area=s" => \$OPT_MAEMIAN_AREA,
"section=s" => \$OPT_MAEMIAN_AREA,
- "arch=s" => \$OPT_MAEMIAN_ARCH,
"root=s" => \$MAEMIAN_ROOT,
# ------------------ package selection options
$$var = $$opt_var if $$opt_var;
}
-# MAEMIAN_ARCH must have a value.
-unless (defined $MAEMIAN_ARCH) {
- if ($MAEMIAN_DIST) {
- chop($MAEMIAN_ARCH=`dpkg --print-architecture`);
- } else {
- $MAEMIAN_ARCH = 'any';
- }
-}
-
# MAEMIAN_SECTION is deprecated in favour of MAEMIAN_AREA
if (defined $MAEMIAN_SECTION) {
print STDERR "warning: MAEMIAN_SECTION has been deprecated in favour of MAEMIAN_AREA.\n";
--- /dev/null
+#!/usr/bin/perl
+
+# Copyright (C) Jeremiah C. Foster 2009, based on:
+# Lintian -- Debian package checker
+# Copyright (C) 1998 Christian Schwarz and Richard Braakman
+
+=head1 NAME
+
+minimae - A small, cuddly version of maemian
+
+=head1 PURPOSE
+
+Maemian is the maemo version of lintian - a policy checker designed to
+assure the quality of a package uploaded into the maemo.org repositories.
+The goal of maemian is to improve quality by checking that the maemo
+packaging policy is followed. In order to do that it reads files in the
+uploaded deb. Currently maemian only looks at the .dsc file and tries to
+ascertain who uploaded it, and if they used the correct email address.
+
+=head1 SYNOPSIS
+
+ # Check a debian description file
+ minimae -i file.dsc
+
+=cut
+
+use strict;
+use warnings;
+use Getopt::Long;
+use Pod::Usage;
+use Carp;
+use lib qw(lib/);
+use Maemian::Output;
+
+# --- Command line options
+my $inputfile; # --- A file passed on the command line
+my ($help, $verbose);
+
+GetOptions
+ (
+ 'help' => \$help,
+ 'verbose' => \$verbose,
+ 'inputfile|i=s' => \$inputfile,
+ );
+
+# --- Process Command line options
+pod2usage() if $help;
+pod2usage() if not $inputfile;
+
+# --- Output settings.
+my $out = new Maemian::Output;
+if ($verbose) {
+ $out->verbose(1);
+ $out->v_msg("Verbose on");
+}
+ # --- If this is set to true, then you only get msgs
+$out->quiet(0);
+$out->msg("Notice on");
+# --- If this is set to true, then you will get verbose messages.
+$out->color("auto");
+
+
+
+
+
+
+
+
+
+
+
+sub file_tests {
+ use File::Basename;
+ my $path = shift;
+ if (-r $path) {
+ my ($filename, $dirs) = fileparse($path);
+ # --- maemo is a trademarked term
+ if ($filename =~ /maemo/) {
+ print "W: Any use of the word \"maemo\" in the package name (not package version) is subject to trademark.\n";
+ }
+ # --- Open file into an array
+ open my $file, '<', $path or die "Cannot open file: $!\n";
+ my @lines = <$file>;
+ close $file;
+
+ my ($field, $maintainer) = map { split /: / } grep /Maintainer/, @lines;
+ chomp($maintainer);
+ if ($maintainer =~ /(ubuntu|debian)/i) {
+ print "W: Maintainer email address ($maintainer) might be the same as upstream.\n";
+ }
+ else {
+ $out->msg("$maintainer");
+ }
+ if (grep /BEGIN PGP SIGNED MESSAGE/, @lines) {
+ $out->v_msg("$filename is signed");
+ }
+ $out->debug_msg(3, "\n$dirs\n$filename\n");
+ }
+ else {
+ croak "File not readable: $!\n";
+ }
+}
+
+if ($inputfile) {
+ file_tests($inputfile);
+} else {
+ croak "No input file found: $!\n";
+}
reap($job);
exit 0;
-
-# Local Variables:
-# indent-tabs-mode: nil
-# cperl-indent-level: 4
-# End:
-# vim: syntax=perl sw=4 sts=4 ts=4 et shiftround