1 ##############################################################################
2 # $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic/lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitEmptyQuotes.pm $
3 # $Date: 2008-07-03 10:19:10 -0500 (Thu, 03 Jul 2008) $
6 ##############################################################################
8 package Perl::Critic::Policy::ValuesAndExpressions::ProhibitEmptyQuotes;
15 use Perl::Critic::Utils qw{ :severities };
16 use base 'Perl::Critic::Policy';
18 our $VERSION = '1.088';
20 #-----------------------------------------------------------------------------
22 Readonly::Scalar my $EMPTY_RX => qr{\A ["|'] \s* ['|"] \z}mx;
23 Readonly::Scalar my $DESC => q{Quotes used with an empty string};
24 Readonly::Scalar my $EXPL => [ 53 ];
26 #-----------------------------------------------------------------------------
28 sub supported_parameters { return () }
29 sub default_severity { return $SEVERITY_LOW }
30 sub default_themes { return qw(core pbp cosmetic) }
31 sub applies_to { return 'PPI::Token::Quote' }
33 #-----------------------------------------------------------------------------
36 my ( $self, $elem, undef ) = @_;
37 if ( $elem =~ $EMPTY_RX ) {
38 return $self->violation( $DESC, $EXPL, $elem );
47 #-----------------------------------------------------------------------------
53 Perl::Critic::Policy::ValuesAndExpressions::ProhibitEmptyQuotes - Write C<q{}> instead of C<''>.
57 This Policy is part of the core L<Perl::Critic> distribution.
62 Don't use quotes for an empty string or any string that is pure whitespace.
63 Instead, use C<q{}> to improve legibility. Better still, created named values
64 like this. Use the C<x> operator to repeat characters.
66 $message = ''; #not ok
67 $message = ""; #not ok
68 $message = " "; #not ok
70 $message = q{}; #better
71 $message = q{ } #better
74 $message = $EMPTY; #best
77 $message = $SPACE x 5; #best
82 This Policy is not configurable except for the standard options.
87 L<Perl::Critic::Policy::ValuesAndExpressions::ProhibitNoisyStrings>
91 Jeffrey Ryan Thalhammer <thaljef@cpan.org>
95 Copyright (c) 2005-2008 Jeffrey Ryan Thalhammer. All rights reserved.
97 This program is free software; you can redistribute it and/or modify
98 it under the same terms as Perl itself. The full text of this license
99 can be found in the LICENSE file included with this module.
105 # cperl-indent-level: 4
107 # indent-tabs-mode: nil
108 # c-indentation-style: bsd
110 # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :