No need to check for loop variable value
authorNikos Ntarmos <ntarmos@cs.uoi.gr>
Thu, 28 May 2009 13:43:15 +0000 (16:43 +0300)
committerBrenden Matthews <brenden@rty.ca>
Fri, 29 May 2009 03:27:55 +0000 (21:27 -0600)
If the first for-loop succedds in finding the desired interface, it will return to its caller. The only way we drop to the second for-loop is if nothing is found thus far, so no need to check for (i == 16).

Signed-off-by: Nikos Ntarmos <ntarmos@cs.uoi.gr>
Signed-off-by: Brenden Matthews <brenden@rty.ca>

src/common.c

index 8430d0c..7c3b017 100644 (file)
@@ -195,12 +195,10 @@ struct net_stat *get_net_stat(const char *dev)
        }
 
        /* wasn't found? add it */
-       if (i == 16) {
-               for (i = 0; i < 16; i++) {
-                       if (netstats[i].dev == 0) {
-                               netstats[i].dev = strndup(dev, text_buffer_size);
-                               return &netstats[i];
-                       }
+       for (i = 0; i < 16; i++) {
+               if (netstats[i].dev == 0) {
+                       netstats[i].dev = strndup(dev, text_buffer_size);
+                       return &netstats[i];
                }
        }