1 ##############################################################################
2 # $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic/lib/Perl/Critic/Policy/ClassHierarchies/ProhibitExplicitISA.pm $
3 # $Date: 2008-07-03 10:19:10 -0500 (Thu, 03 Jul 2008) $
6 ##############################################################################
8 package Perl::Critic::Policy::ClassHierarchies::ProhibitExplicitISA;
15 use Perl::Critic::Utils qw{ :severities };
16 use base 'Perl::Critic::Policy';
18 our $VERSION = '1.088';
20 #-----------------------------------------------------------------------------
22 Readonly::Scalar my $DESC => q{@ISA used instead of "use base"}; ##no critic; #for @ in string
23 Readonly::Scalar my $EXPL => [ 360 ];
25 #-----------------------------------------------------------------------------
27 sub supported_parameters { return () }
28 sub default_severity { return $SEVERITY_MEDIUM }
29 sub default_themes { return qw( core maintenance pbp ) }
30 sub applies_to { return 'PPI::Token::Symbol' }
32 #-----------------------------------------------------------------------------
35 my ($self, $elem, undef) = @_;
37 if( $elem eq q{@ISA} ) { ##no critic; #for @ in string
38 return $self->violation( $DESC, $EXPL, $elem );
45 #-----------------------------------------------------------------------------
53 Perl::Critic::Policy::ClassHierarchies::ProhibitExplicitISA - Employ C<use base> instead of C<@ISA>.
57 This Policy is part of the core L<Perl::Critic> distribution.
62 Conway recommends employing C<use base qw(Foo)> instead of the usual
63 C<our @ISA = qw(Foo)> because the former happens at compile time and
64 the latter at runtime. The C<base> pragma also automatically loads
65 C<Foo> for you so you save a line of easily-forgotten code.
70 This Policy is not configurable except for the standard options.
75 Chris Dolan <cdolan@cpan.org>
79 Copyright (C) 2006 Chris Dolan. All rights reserved.
81 This program is free software; you can redistribute it and/or modify
82 it under the same terms as Perl itself.
88 # cperl-indent-level: 4
90 # indent-tabs-mode: nil
91 # c-indentation-style: bsd
93 # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :