From deccacb2b2f9377fe73297c34caaec456c3c6c0d Mon Sep 17 00:00:00 2001 From: Murray Cumming Date: Fri, 22 Jun 2007 16:13:17 +0000 Subject: [PATCH] 2007-06-22 Murray Cumming * src/modest-tny-account-store.c: (get_password): Restored the call to tny_account_set_user() because Philip seems to have stopped this from crashing (by not using the freed string). It still does not work, but now we can test it. pmo-trunk-r2380 --- ChangeLog | 6 ------ ChangeLog2 | 7 +++++++ src/modest-tny-account-store.c | 5 +---- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/ChangeLog b/ChangeLog index 93fab1b..acb6b92 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,7 +1 @@ -2007-06-22 Murray Cumming,,, - - reviewed by: - - * src/maemo/modest-msg-edit-window.c: (init_window): - * please check the svn log instead diff --git a/ChangeLog2 b/ChangeLog2 index c38f2de..9910c7c 100644 --- a/ChangeLog2 +++ b/ChangeLog2 @@ -1,5 +1,12 @@ 2007-06-22 Murray Cumming + * src/modest-tny-account-store.c: (get_password): + Restored the call to tny_account_set_user() because Philip seems to have + stopped this from crashing (by not using the freed string). It still does + not work, but now we can test it. + +2007-06-22 Murray Cumming + * src/maemo/modest-msg-edit-window.c: (init_window): Comment out use of an uninitialzed GtkScrolledWindow variable, to fix the build and stop a crash. Yet again. diff --git a/src/modest-tny-account-store.c b/src/modest-tny-account-store.c index c98b821..dacd687 100644 --- a/src/modest-tny-account-store.c +++ b/src/modest-tny-account-store.c @@ -440,10 +440,7 @@ get_password (TnyAccount *account, const gchar * prompt_not_used, gboolean *canc if (!*cancel) { /* The password will be returned as the result, * but we need to tell tinymail about the username too: */ - /* TODO: This causes a crash because it frees memory that - * tinymail is already using. tinymail needs to detect the change - * and stop using the old username: - * tny_account_set_user (account, username); */ + tny_account_set_user (account, username); if (remember) { printf ("%s: Storing username=%s, password=%s\n", -- 1.7.9.5