From: Sven Herzberg Date: Mon, 7 Apr 2008 11:33:29 +0000 (+0000) Subject: 2008-04-07 Sven Herzberg X-Git-Tag: 2.1.66-1~751 X-Git-Url: https://vcs.maemo.org/git/?a=commitdiff_plain;h=9bda64c3f45faac8307b71d2f2cd296cd5a50ef0;p=hildon 2008-04-07 Sven Herzberg Fixes: NB#78896: libhildon code inspection/coverity: uninitialised local values in hildon_date_editor_size_allocate * src/hildon-date-editor.c: moved the real allocation code into the if() branch --- diff --git a/ChangeLog b/ChangeLog index fb2a022..b84f13e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,13 @@ 2008-04-07 Sven Herzberg + Fixes: NB#78896: libhildon code inspection/coverity: uninitialised + local values in hildon_date_editor_size_allocate + + * src/hildon-date-editor.c: moved the real allocation code into the + if() branch + +2008-04-07 Sven Herzberg + Prepares: NB#78896: libhildon code inspection/coverity: uninitialised local values in hildon_date_editor_size_allocate diff --git a/src/hildon-date-editor.c b/src/hildon-date-editor.c index 577e658..54f424c 100644 --- a/src/hildon-date-editor.c +++ b/src/hildon-date-editor.c @@ -1320,14 +1320,14 @@ hildon_date_editor_size_allocate (GtkWidget *widget, img_alloc.x = f_alloc.x; f_alloc.x += img_alloc.width + HILDON_MARGIN_DEFAULT; } - } - if (GTK_WIDGET_VISIBLE (priv->d_button_image)) { - gtk_widget_size_allocate (priv->d_button_image, &img_alloc); - } + if (GTK_WIDGET_VISIBLE (priv->d_button_image)) { + gtk_widget_size_allocate (priv->d_button_image, &img_alloc); + } - if (GTK_WIDGET_VISIBLE (priv->frame)) { - gtk_widget_size_allocate (priv->frame, &f_alloc); + if (GTK_WIDGET_VISIBLE (priv->frame)) { + gtk_widget_size_allocate (priv->frame, &f_alloc); + } } /* FIXME: We really should not alloc delimeters by hand (since they