Added missing tr()'s, commented out non-working menu-item test
authorKaj Wallin <kaj.wallin@ixonos.com>
Wed, 14 Apr 2010 06:56:53 +0000 (09:56 +0300)
committerKaj Wallin <kaj.wallin@ixonos.com>
Wed, 14 Apr 2010 06:56:53 +0000 (09:56 +0300)
src/ui/listviewscreen.cpp
src/ui/mainwindow.cpp
src/ui/mapviewscreen.cpp
tests/ui/mainwindow/mainwindow_test.cpp

index 417935d..14b0754 100644 (file)
@@ -28,5 +28,5 @@ ListViewScreen::ListViewScreen(QWidget *parent)
    QHBoxLayout *listViewLayout = new QHBoxLayout;
    listViewLayout->addWidget(listViewButton);
    setLayout(listViewLayout);
-   setObjectName("List view");
+   setObjectName(tr("List view"));
 }
index 8a9ebec..073639e 100644 (file)
@@ -52,15 +52,15 @@ void MainWindow::createMenus()
 {
     qDebug() << __PRETTY_FUNCTION__;
     toListViewAct = new QAction(tr("List"), this);
-    toListViewAct->setObjectName("List");
+    toListViewAct->setObjectName(tr("List"));
     connect(toListViewAct, SIGNAL(triggered()), this, SLOT(toListView()));
     toMapViewAct = new QAction(tr("Map"), this);
-    toMapViewAct->setObjectName("Map");
+    toMapViewAct->setObjectName(tr("Map"));
     connect(toMapViewAct, SIGNAL(triggered()), this, SLOT(toMapView()));
     viewMenu = menuBar()->addMenu(tr("View"));
     viewMenu->addAction(toListViewAct);
     viewMenu->addAction(toMapViewAct);
-    viewMenu->setObjectName("View Menu");
+    viewMenu->setObjectName(tr("View Menu"));
 //    QList<QAction*> actionit = viewMenu->actions();
 //    qDebug() << "AKTIONIT" << actionit;
 
index a411764..c65baf0 100644 (file)
@@ -34,5 +34,5 @@ MapViewScreen::MapViewScreen(QWidget *parent)
    mapView->setScene(mapEngine->scene());
    connect(mapEngine, SIGNAL(zoomLevelChanged(int)), mapView, SLOT(setZoomLevel(int)));
    mapEngine->setViewLocation(QPointF(25.5000, 65.0000));
-   setObjectName("Map view");
+   setObjectName(tr("Map view"));
 }
index 2637416..5edbf1d 100644 (file)
@@ -34,7 +34,7 @@ class testMainWindow : public QObject
 private slots:
     void testViewSwitch();
     void verifyStackItems();
-    void verifyMenuItems();
+//    void verifyMenuItems();  //NON-WORKING
 };
 
 void testMainWindow::testViewSwitch()
@@ -43,16 +43,16 @@ void testMainWindow::testViewSwitch()
     QStackedWidget *testStack = dynamic_cast<QStackedWidget*>(mainwindow.centralWidget());
     mainwindow.toListView();
     QCOMPARE(testStack->currentIndex(), 0);
-    QCOMPARE(mainwindow.windowTitle(),QString("List view"));
+    QCOMPARE(mainwindow.windowTitle(),QString(tr("List view")));
     mainwindow.toMapView();
     QCOMPARE(testStack->currentIndex(), 1);
-    QCOMPARE(mainwindow.windowTitle(),QString("Map view"));
+    QCOMPARE(mainwindow.windowTitle(),QString(tr("Map view")));
     mainwindow.toMapView();
     QCOMPARE(testStack->currentIndex(), 1);
-    QCOMPARE(mainwindow.windowTitle(),QString("Map view"));
+    QCOMPARE(mainwindow.windowTitle(),QString(tr("Map view")));
     mainwindow.toListView();
     QCOMPARE(testStack->currentIndex(), 0);
-    QCOMPARE(mainwindow.windowTitle(),QString("List view"));
+    QCOMPARE(mainwindow.windowTitle(),QString(tr("List view")));
 
 }
 void testMainWindow::verifyStackItems()
@@ -60,19 +60,18 @@ void testMainWindow::verifyStackItems()
     MainWindow mainwindow;
     QStackedWidget *testStack = dynamic_cast<QStackedWidget*>(mainwindow.centralWidget());
     QCOMPARE(testStack->count(), 2);
-    QCOMPARE(testStack->widget(0)->objectName(),QString("List view"));
-    QCOMPARE(testStack->widget(1)->objectName(),QString("Map view"));
+    QCOMPARE(testStack->widget(0)->objectName(),QString(tr("List view")));
+    QCOMPARE(testStack->widget(1)->objectName(),QString(tr("Map view")));
 }
 
+/* NON-WORKING TEST
 void testMainWindow::verifyMenuItems()
 {
     MainWindow mainwindow;
     QWidget *testMenu = mainwindow.menuWidget();
-//    QList<QAction*> menuitems = testMenu->actions();
-//    qDebug() << menuitems;
     qDebug() << testMenu->actions();
-//    mainwindow.
 }
+*/
 
 QTEST_MAIN(testMainWindow)
 #include "mainwindow_test.moc"