-2007-06-20 Murray Cumming <murrayc@murrayc-desktop>
+2007-06-20 Murray Cumming <murrayc@murrayc.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
+ struct item.
+ * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
+ Better debug message when the folder cannot be found.
+ This should help with fixing projects.maemo.org bug #61287.
+ * src/modest-search.c: (add_hit): Do not leak the furl string.
+
+2007-06-20 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c:
(modest_ui_actions_on_folder_selection_changed):
projects.maemo.org bug NB#60955 (The smtp connections dialog was not
shown when the Outbox was selected).
-2007-06-19 Murray Cumming,,, <murrayc@murrayc-desktop>
+2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
* libmodest-dbus-client/libmodest-dbus-client.c:
(_dbus_iter_get_string_or_null): Initialize the string variable in
typedef struct {
- gchar *msgid;
+ gchar *msgid; /* E.g. the URI of the message. */
gchar *subject;
- gchar *folder;
+ gchar *folder; /* The name, not the URI. */
gchar *sender;
guint64 msize;
gboolean has_attachment;
&err);
if (folder == NULL) {
- g_debug ("%s: tny_store_account_find_folder() failed.\n", __FUNCTION__);
+ g_debug ("%s: tny_store_account_find_folder() failed\naccount=%s, uri=%s.\n", __FUNCTION__,
+ tny_account_get_id (TNY_ACCOUNT(account)), uri);
goto out;
}
g_debug ("%s: Found folder. (%s)\n", __FUNCTION__, uri);
hit = g_slice_new0 (ModestSearchHit);
furl = tny_folder_get_url_string (folder);
+ printf ("DEBUG: %s: folder URL=%s\n", __FUNCTION__, furl);
if (!furl) {
g_warning ("%s: tny_folder_get_url_string(): returned NULL for folder. Folder name=%s\n", __FUNCTION__, tny_folder_get_name (folder));
}
}
msg_url = g_strdup_printf ("%s/%s", furl, uid);
+ g_free (furl);
subject = tny_header_get_subject (header);
sender = tny_header_get_from (header);
hit->subject = g_strdup_or_null (subject);
hit->sender = g_strdup_or_null (sender);
hit->folder = g_strdup_or_null (tny_folder_get_name (folder));
- //furl; /* We just provide our new instance instead of copying it and freeing it. */
hit->msize = tny_header_get_message_size (header);
hit->has_attachment = flags & TNY_HEADER_FLAG_ATTACHMENTS;
hit->is_unread = ! (flags & TNY_HEADER_FLAG_SEEN);