Removed review defect comments and fixed few other comments

diff --git a/src/map/mapengine.cpp b/src/map/mapengine.cpp
index 949279c..0d63c34 100644 (file)
--- a/src/map/mapengine.cpp
+++ b/src/map/mapengine.cpp
@@ -43,10 +43,6 @@ MapEngine::MapEngine(QWidget *parent)
             SLOT(mapImageReceived(QUrl, QPixmap)));
 }
 
-/**
-  * @todo DONE Create URL builder method
-  * QUrl buildURL(zoomLevel, QPoint tileNumbers)
-  */
 void MapEngine::setViewLocation(QPointF latLonCoordinate)
 {
     emit zoomLevelChanged(m_zoomLevel);
@@ -68,9 +64,6 @@ QUrl MapEngine::buildURL(int zoomLevel, QPoint tileNumbers)
     return QUrl(url);
 }
 
-/**
-* @todo Create URL parser methor and refactor code (use pointers for returning)
-*/
 void MapEngine::parseURL(const QUrl &url, int &zoom, int &x, int &y)
 {
     QString path = url.path();
@@ -84,10 +77,6 @@ void MapEngine::parseURL(const QUrl &url, int &zoom, int &x, int &y)
 
 }
 
-/**
-* @todo Create URL parser methor and refactor code (use pointers for returning)
-* DONE
-*/
 void MapEngine::mapImageReceived(const QUrl &url, const QPixmap &pixmap)
 {
     int zoom = -1;

diff --git a/src/map/mapengine.h b/src/map/mapengine.h
index 82eca13..f94e1ad 100644 (file)
--- a/src/map/mapengine.h
+++ b/src/map/mapengine.h
@@ -55,9 +55,7 @@ public:
     * @param tileNumber x & y numbers of the tile
     * @return QPoint MapScene coordinate
     */
-    /**
-      * @todo DONE use bit shift instead of pow
-      */
+
     static QPoint convertTileNumberToSceneCoordinate(int zoomLevel, QPoint tileNumber)
     {
         int pow = 1 << (MAX_ZOOM_LEVEL - zoomLevel);
@@ -118,9 +116,9 @@ private:
     * placed in variables given as parameters.
     *
     * @param url url to parse
-    * @param zoom zoom variable
-    * @param x x variable
-    * @param y y variable
+    * @param [out] zoom zoom variable
+    * @param [out] x x variable
+    * @param [out] y y variable
     */
     void parseURL(const QUrl &url, int &zoom, int &x, int &y);
 

diff --git a/src/map/mapfetcher.cpp b/src/map/mapfetcher.cpp
index 306d02c..49cf855 100644 (file)
--- a/src/map/mapfetcher.cpp
+++ b/src/map/mapfetcher.cpp
@@ -59,10 +59,6 @@ void MapFetcher::fetchMapImage(const QUrl &url)
         startNextDownload();
 }
 
-/**
-  * @todo Return false if image can't be read and do not emit signal
-  * DONE
-  */
 bool MapFetcher::loadImageFromCache(const QUrl &url)
 {
     qDebug() << __PRETTY_FUNCTION__;

diff --git a/src/map/mapfetcher.h b/src/map/mapfetcher.h
index 5a313dc..787c3ba 100644 (file)
--- a/src/map/mapfetcher.h
+++ b/src/map/mapfetcher.h
@@ -41,13 +41,9 @@ class MapFetcher : public QObject
 
 public:
     /**
-      * @todo remove fn:s from comment blocks
-      *
-      * DONE
-      */
-    /**
     * @brief Constructor for MapFetcher.
     *
+    * @param manager Network access manager
     * @param parent parent object
     */
     MapFetcher(QNetworkAccessManager *manager, QObject *parent = 0);
@@ -107,11 +103,7 @@ private:
     * @return bool true if image was loaded from cache, false otherwise
     */
     bool loadImageFromCache(const QUrl &url);
-/**
-  * @todo add comments for data members
-  *
-  * DONE
-  */
+
     QNetworkAccessManager *m_manager;       ///< Network access manager
     QList<QNetworkReply*> currentDownloads; ///< List of current downloads
     QQueue<QUrl> downloadQueue;             ///< Queue of pending requests

diff --git a/src/map/maptile.cpp b/src/map/maptile.cpp
index 23c81e7..704d85f 100644 (file)
--- a/src/map/maptile.cpp
+++ b/src/map/maptile.cpp
@@ -42,9 +42,7 @@ void MapTile::setZoomLevel(int zoomLevel)
 {
     m_zoomLevel = zoomLevel;
     setPosition();
-    /**
-      * @todo DONE use bit shifting
-      */
+
     qreal zoomFactor = (qreal)(1 << (MAX_ZOOM_LEVEL - m_zoomLevel));
     setScale(zoomFactor);
 }
@@ -62,9 +60,6 @@ void MapTile::setTileNumber(QPoint tileNumber)
 
 void MapTile::setPosition()
 {
-    /**
-      * @todo DONE use bit shifting
-      */
     const int maxTileNumber = (1 << m_zoomLevel) - 1;
 
     if ((m_zoomLevel >= MIN_ZOOM_LEVEL) && (m_zoomLevel <= MAX_ZOOM_LEVEL) &&

diff --git a/src/map/maptile.h b/src/map/maptile.h
index aa9a47f..07c1327 100644 (file)
--- a/src/map/maptile.h
+++ b/src/map/maptile.h
@@ -35,8 +35,6 @@ class MapTile : public QGraphicsPixmapItem
 public:
     /**
     * @brief Constructor
-    *
-    * @fn MapTile
     */
     MapTile();