Use g_strdup_printf() instead of a fixed size buffer.

* src/hildon-number-editor.c (hildon_number_editor_real_set_value):
Use g_strdup_printf() instead of a fixed size buffer.

diff --git a/ChangeLog b/ChangeLog
index 6ddc1b8..339d324 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2009-04-22  Claudio Saavedra  <csaavedra@igalia.com>
+
+       * src/hildon-number-editor.c (hildon_number_editor_real_set_value):
+       Use g_strdup_printf() instead of a fixed size buffer.
+
 2009-04-21  Alberto Garcia  <agarcia@igalia.com>
 
        * src/hildon-app-menu.c (hildon_app_menu_find_intruder):

diff --git a/src/hildon-number-editor.c b/src/hildon-number-editor.c
index d2acac7..994918e 100644 (file)
--- a/src/hildon-number-editor.c
+++ b/src/hildon-number-editor.c
@@ -459,12 +459,12 @@ static void
 hildon_number_editor_real_set_value             (HildonNumberEditorPrivate *priv, 
                                                  gint value)
 {
-    /* FIXME: That looks REALLY bad */
-    gchar buffer[32];
+    gchar *buffer;
 
     /* Update text in entry to new value */
-    g_snprintf (buffer, sizeof (buffer), "%d", value);
+    buffer = g_strdup_printf ("%d", value);
     gtk_entry_set_text (GTK_ENTRY (priv->num_entry), buffer);
+    g_free (buffer);
 }
 
 static gboolean