2008-04-07 Sven Herzberg <sven@imendio.com>

Fixes: NB#78896: libhildon code inspection/coverity: uninitialised
	local values in hildon_date_editor_size_allocate

	* src/hildon-date-editor.c: moved the real allocation code into the
	if() branch

diff --git a/ChangeLog b/ChangeLog
index fb2a022..b84f13e 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,13 @@
 2008-04-07  Sven Herzberg  <sven@imendio.com>
 
+       Fixes: NB#78896: libhildon code inspection/coverity: uninitialised
+       local values in hildon_date_editor_size_allocate
+
+       * src/hildon-date-editor.c: moved the real allocation code into the
+       if() branch
+
+2008-04-07  Sven Herzberg  <sven@imendio.com>
+
        Prepares: NB#78896: libhildon code inspection/coverity: uninitialised
        local values in hildon_date_editor_size_allocate
 

diff --git a/src/hildon-date-editor.c b/src/hildon-date-editor.c
index 577e658..54f424c 100644 (file)
--- a/src/hildon-date-editor.c
+++ b/src/hildon-date-editor.c
@@ -1320,14 +1320,14 @@ hildon_date_editor_size_allocate                (GtkWidget *widget,
             img_alloc.x = f_alloc.x;
             f_alloc.x  += img_alloc.width + HILDON_MARGIN_DEFAULT;
         }
-    }
 
-    if (GTK_WIDGET_VISIBLE (priv->d_button_image)) {
-        gtk_widget_size_allocate (priv->d_button_image, &img_alloc);
-    }
+        if (GTK_WIDGET_VISIBLE (priv->d_button_image)) {
+            gtk_widget_size_allocate (priv->d_button_image, &img_alloc);
+        }
 
-    if (GTK_WIDGET_VISIBLE (priv->frame)) {
-        gtk_widget_size_allocate (priv->frame, &f_alloc);
+        if (GTK_WIDGET_VISIBLE (priv->frame)) {
+            gtk_widget_size_allocate (priv->frame, &f_alloc);
+        }
     }
 
     /* FIXME: We really should not alloc delimeters by hand (since they