Send signal when service strength changes
[connman] / src / service.c
index 7809918..a799477 100644 (file)
@@ -42,6 +42,8 @@ struct connman_service {
        enum connman_service_state state;
        connman_uint8_t strength;
        connman_bool_t favorite;
+       connman_bool_t hidden;
+       GTimeVal modified;
        unsigned int order;
        char *name;
        char *passphrase;
@@ -71,6 +73,34 @@ void __connman_service_list(DBusMessageIter *iter)
        g_sequence_foreach(service_list, append_path, iter);
 }
 
+struct find_data {
+       const char *path;
+       struct connman_service *service;
+};
+
+static void compare_path(gpointer value, gpointer user_data)
+{
+       struct connman_service *service = value;
+       struct find_data *data = user_data;
+
+       if (data->service != NULL)
+               return;
+
+       if (g_strcmp0(service->path, data->path) == 0)
+               data->service = service;
+}
+
+static struct connman_service *find_service(const char *path)
+{
+       struct find_data data = { .path = path, .service = NULL };
+
+       DBG("path %s", path);
+
+       g_sequence_foreach(service_list, compare_path, &data);
+
+       return data.service;
+}
+
 static const char *type2string(enum connman_service_type type)
 {
        switch (type) {
@@ -112,8 +142,8 @@ static const char *security2string(enum connman_service_security security)
                return "wep";
        case CONNMAN_SERVICE_SECURITY_WPA:
                return "wpa";
-       case CONNMAN_SERVICE_SECURITY_WPA2:
-               return "wpa2";
+       case CONNMAN_SERVICE_SECURITY_RSN:
+               return "rsn";
        }
 
        return NULL;
@@ -173,6 +203,36 @@ static void state_changed(struct connman_service *service)
        g_dbus_send_message(connection, signal);
 }
 
+static void strength_changed(struct connman_service *service)
+{
+       DBusMessage *signal;
+       DBusMessageIter entry, value;
+       const char *key = "Strength";
+
+       if (service->path == NULL)
+               return;
+
+       if (service->strength == 0)
+               return;
+
+       signal = dbus_message_new_signal(service->path,
+                               CONNMAN_SERVICE_INTERFACE, "PropertyChanged");
+       if (signal == NULL)
+               return;
+
+       dbus_message_iter_init_append(signal, &entry);
+
+       dbus_message_iter_append_basic(&entry, DBUS_TYPE_STRING, &key);
+
+       dbus_message_iter_open_container(&entry, DBUS_TYPE_VARIANT,
+                                       DBUS_TYPE_STRING_AS_STRING, &value);
+       dbus_message_iter_append_basic(&value, DBUS_TYPE_BYTE,
+                                                       &service->strength);
+       dbus_message_iter_close_container(&entry, &value);
+
+       g_dbus_send_message(connection, signal);
+}
+
 static DBusMessage *get_properties(DBusConnection *conn,
                                        DBusMessage *msg, void *user_data)
 {
@@ -328,10 +388,13 @@ static DBusMessage *connect_service(DBusConnection *conn,
        if (service->network != NULL) {
                int err;
 
+               if (service->hidden == TRUE)
+                       return __connman_error_invalid_service(msg);
+
                connman_network_set_string(service->network,
                                "WiFi.Passphrase", service->passphrase);
 
-               err = connman_network_connect(service->network);
+               err = __connman_network_connect(service->network);
                if (err < 0 && err != -EINPROGRESS)
                        return __connman_error_failed(msg, -err);
 
@@ -379,13 +442,8 @@ static DBusMessage *disconnect_service(DBusConnection *conn,
        }
 
        if (service->network != NULL) {
-               struct connman_device *device;
                int err;
 
-               device = connman_network_get_device(service->network);
-               if (device != NULL)
-                       __connman_device_disconnect(device);
-
                err = __connman_network_disconnect(service->network);
                if (err < 0 && err != -EINPROGRESS)
                        return __connman_error_failed(msg, -err);
@@ -417,18 +475,11 @@ static DBusMessage *remove_service(DBusConnection *conn,
        if (service->type == CONNMAN_SERVICE_TYPE_ETHERNET)
                return __connman_error_not_supported(msg);
 
-       if (service->network != NULL) {
-               struct connman_device *device;
-               int err;
-
-               device = connman_network_get_device(service->network);
-               if (device != NULL)
-                       __connman_device_disconnect(device);
+       if (service->favorite == FALSE)
+               return __connman_error_not_supported(msg);
 
-               err = __connman_network_disconnect(service->network);
-               if (err < 0 && err != -EINPROGRESS)
-                       return __connman_error_failed(msg, -err);
-       }
+       if (service->network != NULL)
+               __connman_network_disconnect(service->network);
 
        connman_service_set_favorite(service, FALSE);
        __connman_storage_save_service(service);
@@ -440,12 +491,37 @@ static DBusMessage *move_before(DBusConnection *conn,
                                        DBusMessage *msg, void *user_data)
 {
        struct connman_service *service = user_data;
+       struct connman_service *target;
+       const char *path;
+       GSequenceIter *src, *dst;
 
        DBG("service %p", service);
 
+       dbus_message_get_args(msg, NULL, DBUS_TYPE_OBJECT_PATH, &path,
+                                                       DBUS_TYPE_INVALID);
+
        if (service->favorite == FALSE)
                return __connman_error_not_supported(msg);
 
+       target = find_service(path);
+       if (target == NULL || target->favorite == FALSE || target == service)
+               return __connman_error_invalid_service(msg);
+
+       DBG("target %s", target->identifier);
+
+       g_get_current_time(&service->modified);
+       __connman_storage_save_service(service);
+
+       src = g_hash_table_lookup(service_hash, service->identifier);
+       dst = g_hash_table_lookup(service_hash, target->identifier);
+
+#if 0
+       g_sequence_move(src, dst);
+
+       __connman_profile_changed();
+
+       return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
+#endif
        return __connman_error_not_implemented(msg);
 }
 
@@ -453,12 +529,26 @@ static DBusMessage *move_after(DBusConnection *conn,
                                        DBusMessage *msg, void *user_data)
 {
        struct connman_service *service = user_data;
+       struct connman_service *target;
+       const char *path;
 
        DBG("service %p", service);
 
+       dbus_message_get_args(msg, NULL, DBUS_TYPE_OBJECT_PATH, &path,
+                                                       DBUS_TYPE_INVALID);
+
        if (service->favorite == FALSE)
                return __connman_error_not_supported(msg);
 
+       target = find_service(path);
+       if (target == NULL || target->favorite == FALSE || target == service)
+               return __connman_error_invalid_service(msg);
+
+       DBG("target %s", target->identifier);
+
+       g_get_current_time(&service->modified);
+       __connman_storage_save_service(service);
+
        return __connman_error_not_implemented(msg);
 }
 
@@ -549,6 +639,7 @@ static void __connman_service_initialize(struct connman_service *service)
        service->state    = CONNMAN_SERVICE_STATE_UNKNOWN;
 
        service->favorite = FALSE;
+       service->hidden = FALSE;
 
        service->order = 0;
 }
@@ -729,6 +820,9 @@ int __connman_service_indicate_state(struct connman_service *service,
                        dbus_message_unref(service->pending);
                        service->pending = NULL;
                }
+
+               g_get_current_time(&service->modified);
+               __connman_storage_save_service(service);
        }
 
        if (state == CONNMAN_SERVICE_STATE_FAILURE) {
@@ -759,6 +853,13 @@ int __connman_service_indicate_state(struct connman_service *service,
        return 0;
 }
 
+int __connman_service_indicate_default(struct connman_service *service)
+{
+       DBG("service %p", service);
+
+       return 0;
+}
+
 /**
  * __connman_service_lookup:
  * @identifier: service identifier
@@ -1009,8 +1110,8 @@ static enum connman_service_mode convert_wifi_security(const char *security)
                return CONNMAN_SERVICE_SECURITY_WEP;
        else if (g_str_equal(security, "wpa") == TRUE)
                return CONNMAN_SERVICE_SECURITY_WPA;
-       else if (g_str_equal(security, "wpa2") == TRUE)
-               return CONNMAN_SERVICE_SECURITY_WPA2;
+       else if (g_str_equal(security, "rsn") == TRUE)
+               return CONNMAN_SERVICE_SECURITY_RSN;
        else
                return CONNMAN_SERVICE_SECURITY_UNKNOWN;
 }
@@ -1026,6 +1127,11 @@ static void update_from_network(struct connman_service *service,
        if (str != NULL) {
                g_free(service->name);
                service->name = g_strdup(str);
+               service->hidden = FALSE;
+       } else {
+               g_free(service->name);
+               service->name = NULL;
+               service->hidden = TRUE;
        }
 
        service->strength = connman_network_get_uint8(network, "Strength");
@@ -1039,6 +1145,8 @@ static void update_from_network(struct connman_service *service,
        if (service->strength > strength && service->network != NULL) {
                connman_network_unref(service->network);
                service->network = NULL;
+
+               strength_changed(service);
        }
 
        if (service->network == NULL) {
@@ -1112,7 +1220,7 @@ static int service_load(struct connman_service *service)
        GKeyFile *keyfile;
        gchar *pathname, *data = NULL;
        gsize length;
-       char *str;
+       gchar *str;
 
        DBG("service %p", service);
 
@@ -1152,6 +1260,13 @@ static int service_load(struct connman_service *service)
        }
 
        str = g_key_file_get_string(keyfile,
+                               service->identifier, "Modified", NULL);
+       if (str != NULL) {
+               g_time_val_from_iso8601(str, &service->modified);
+               g_free(str);
+       }
+
+       str = g_key_file_get_string(keyfile,
                                service->identifier, "Passphrase", NULL);
        if (str != NULL) {
                g_free(service->passphrase);
@@ -1168,6 +1283,7 @@ static int service_save(struct connman_service *service)
        GKeyFile *keyfile;
        gchar *pathname, *data = NULL;
        gsize length;
+       gchar *str;
 
        DBG("service %p", service);
 
@@ -1207,6 +1323,13 @@ update:
                break;
        }
 
+       str = g_time_val_to_iso8601(&service->modified);
+       if (str != NULL) {
+               g_key_file_set_string(keyfile, service->identifier,
+                                                       "Modified", str);
+               g_free(str);
+       }
+
        if (service->passphrase != NULL)
                g_key_file_set_string(keyfile, service->identifier,
                                        "Passphrase", service->passphrase);