Add frequency property to network objects
[connman] / src / network.c
index b3fdd45..861e815 100644 (file)
@@ -37,9 +37,8 @@ struct connman_network {
        connman_bool_t secondary;
        connman_bool_t available;
        connman_bool_t connected;
-       connman_bool_t remember;
-       connman_uint8_t priority;
        connman_uint8_t strength;
+       connman_uint16_t frequency;
        char *identifier;
        char *address;
        char *name;
@@ -124,14 +123,14 @@ static DBusMessage *get_properties(DBusConnection *conn,
        connman_dbus_dict_append_variant(&dict, "Connected",
                                DBUS_TYPE_BOOLEAN, &network->connected);
 
-       if (network->priority > 0)
-               connman_dbus_dict_append_variant(&dict, "Priority",
-                                       DBUS_TYPE_BYTE, &network->priority);
-
        if (network->strength > 0)
                connman_dbus_dict_append_variant(&dict, "Strength",
                                        DBUS_TYPE_BYTE, &network->strength);
 
+       if (network->frequency > 0)
+               connman_dbus_dict_append_variant(&dict, "Frequency",
+                                       DBUS_TYPE_UINT16, &network->frequency);
+
        if (network->wifi.ssid != NULL && network->wifi.ssid_len > 0)
                connman_dbus_dict_append_array(&dict, "WiFi.SSID",
                                DBUS_TYPE_BYTE, &network->wifi.ssid,
@@ -193,15 +192,6 @@ static DBusMessage *set_property(DBusConnection *conn,
 
                g_free(network->wifi.passphrase);
                network->wifi.passphrase = g_strdup(passphrase);
-       } else if (g_str_equal(name, "Priority") == TRUE) {
-               connman_uint8_t priority;
-
-               if (type != DBUS_TYPE_BYTE)
-                       return __connman_error_invalid_arguments(msg);
-
-               dbus_message_iter_get_basic(&value, &priority);
-
-               network->priority = priority;
        }
 
        __connman_storage_save_network(network);
@@ -586,8 +576,34 @@ void connman_network_set_protocol(struct connman_network *network,
 void connman_network_set_group(struct connman_network *network,
                                                        const char *group)
 {
-       g_free(network->group);
+       if (network->secondary == TRUE)
+               return;
+
+       if (g_strcmp0(network->group, group) == 0)
+               return;
+
+       switch (network->type) {
+       case CONNMAN_NETWORK_TYPE_UNKNOWN:
+       case CONNMAN_NETWORK_TYPE_VENDOR:
+       case CONNMAN_NETWORK_TYPE_BLUETOOTH_PAN:
+       case CONNMAN_NETWORK_TYPE_BLUETOOTH_DUN:
+       case CONNMAN_NETWORK_TYPE_HSO:
+               return;
+       case CONNMAN_NETWORK_TYPE_WIFI:
+       case CONNMAN_NETWORK_TYPE_WIMAX:
+               break;
+       }
+
+       if (network->group != NULL) {
+               __connman_profile_remove_network(network);
+
+               g_free(network->group);
+       }
+
        network->group = g_strdup(group);
+
+       if (network->group != NULL)
+               __connman_profile_add_network(network);
 }
 
 const char *__connman_network_get_group(struct connman_network *network)
@@ -778,37 +794,6 @@ connman_bool_t connman_network_get_connected(struct connman_network *network)
 }
 
 /**
- * connman_network_set_remember:
- * @network: network structure
- * @remember: remember state
- *
- * Change remember state of network (known networks)
- */
-int connman_network_set_remember(struct connman_network *network,
-                                               connman_bool_t remember)
-{
-       DBG("network %p remember %d", network, remember);
-
-       if (network->remember == remember)
-               return -EALREADY;
-
-       network->remember = remember;
-
-       return 0;
-}
-
-/**
- * connman_network_get_remember:
- * @network: network structure
- *
- * Get network remember setting
- */
-connman_bool_t connman_network_get_remember(struct connman_network *network)
-{
-       return network->remember;
-}
-
-/**
  * connman_network_connect:
  * @network: network structure
  *
@@ -832,6 +817,8 @@ int __connman_network_disconnect(struct connman_network *network)
        if (network->connected == FALSE)
                return -ENOTCONN;
 
+       __connman_device_set_network(network->device, NULL);
+
        connman_element_unregister_children(&network->element);
 
        if (network->driver && network->driver->disconnect)
@@ -919,9 +906,7 @@ int connman_network_set_uint8(struct connman_network *network,
 {
        DBG("network %p key %s value %d", network, key, value);
 
-       if (g_str_equal(key, "Priority") == TRUE)
-               network->priority = value;
-       else if (g_str_equal(key, "Strength") == TRUE)
+       if (g_str_equal(key, "Strength") == TRUE)
                network->strength = value;
 
        return connman_element_set_uint8(&network->element, key, value);
@@ -939,15 +924,50 @@ connman_uint8_t connman_network_get_uint8(struct connman_network *network,
 {
        DBG("network %p key %s", network, key);
 
-       if (g_str_equal(key, "Priority") == TRUE)
-               return network->priority;
-       else if (g_str_equal(key, "Strength") == TRUE)
+       if (g_str_equal(key, "Strength") == TRUE)
                return network->strength;
 
        return connman_element_get_uint8(&network->element, key);
 }
 
 /**
+ * connman_network_set_uint16:
+ * @network: network structure
+ * @key: unique identifier
+ * @value: integer value
+ *
+ * Set integer value for specific key
+ */
+int connman_network_set_uint16(struct connman_network *network,
+                               const char *key, connman_uint16_t value)
+{
+       DBG("network %p key %s value %d", network, key, value);
+
+       if (g_str_equal(key, "Frequency") == TRUE)
+               network->frequency = value;
+
+       return -EINVAL;
+}
+
+/**
+ * connman_network_get_uint16:
+ * @network: network structure
+ * @key: unique identifier
+ *
+ * Get integer value for specific key
+ */
+connman_uint16_t connman_network_get_uint16(struct connman_network *network,
+                                                       const char *key)
+{
+       DBG("network %p key %s", network, key);
+
+       if (g_str_equal(key, "Frequency") == TRUE)
+               return network->frequency;
+
+       return 0;
+}
+
+/**
  * connman_network_set_blob:
  * @network: network structure
  * @key: unique identifier
@@ -1092,7 +1112,7 @@ static int network_probe(struct connman_element *element)
                break;
        case CONNMAN_NETWORK_TYPE_WIFI:
        case CONNMAN_NETWORK_TYPE_WIMAX:
-               if (network->secondary == FALSE)
+               if (network->group != NULL && network->secondary == FALSE)
                        __connman_profile_add_network(network);
                break;
        }
@@ -1121,8 +1141,12 @@ static void network_remove(struct connman_element *element)
                break;
        case CONNMAN_NETWORK_TYPE_WIFI:
        case CONNMAN_NETWORK_TYPE_WIMAX:
-               if (network->secondary == FALSE)
+               if (network->group != NULL && network->secondary == FALSE) {
                        __connman_profile_remove_network(network);
+
+                       g_free(network->group);
+                       network->group = NULL;
+               }
                break;
        }
 
@@ -1168,150 +1192,12 @@ static struct connman_driver network_driver = {
        .change         = network_change,
 };
 
-static int network_init(struct connman_device *device)
-{
-       DBG("device %p", device);
-
-       return 0;
-}
-
-static int network_load(struct connman_network *network)
-{
-       GKeyFile *keyfile;
-       gchar *pathname, *data = NULL;
-       gsize length;
-       const char *name;
-       char *str;
-       int val;
-
-       DBG("network %p", network);
-
-       name = connman_device_get_name(network->device);
-       if (name == NULL)
-               return -EINVAL;
-
-       pathname = g_strdup_printf("%s/%s.conf", STORAGEDIR, name);
-       if (pathname == NULL)
-               return -ENOMEM;
-
-       keyfile = g_key_file_new();
-
-       if (g_file_get_contents(pathname, &data, &length, NULL) == FALSE) {
-               g_free(pathname);
-               return -ENOENT;
-       }
-
-       g_free(pathname);
-
-       if (g_key_file_load_from_data(keyfile, data, length,
-                                                       0, NULL) == FALSE) {
-               g_free(data);
-               return -EILSEQ;
-       }
-
-       g_free(data);
-
-       val = g_key_file_get_integer(keyfile, network->identifier,
-                                                       "Priority", NULL);
-       if (val > 0)
-               network->priority = val;
-
-       str = g_key_file_get_string(keyfile,
-                               network->identifier, "WiFi.Security", NULL);
-       if (str != NULL) {
-               g_free(network->wifi.security);
-               network->wifi.security = str;
-       }
-
-       str = g_key_file_get_string(keyfile,
-                               network->identifier, "WiFi.Passphrase", NULL);
-       if (str != NULL) {
-               g_free(network->wifi.passphrase);
-               network->wifi.passphrase = str;
-       }
-
-       g_key_file_free(keyfile);
-
-       return 0;
-}
-
-static int network_save(struct connman_network *network)
-{
-       GKeyFile *keyfile;
-       gchar *pathname, *data = NULL;
-       gsize length;
-       const char *name;
-
-       DBG("network %p", network);
-
-       name = connman_device_get_name(network->device);
-       if (name == NULL)
-               return -EINVAL;
-
-       pathname = g_strdup_printf("%s/%s.conf", STORAGEDIR, name);
-       if (pathname == NULL)
-               return -ENOMEM;
-
-       keyfile = g_key_file_new();
-
-       if (g_file_get_contents(pathname, &data, &length, NULL) == FALSE)
-               goto update;
-
-       if (length > 0) {
-               if (g_key_file_load_from_data(keyfile, data, length,
-                                                       0, NULL) == FALSE)
-                       goto done;
-       }
-
-       g_free(data);
-
-update:
-       if (network->priority > 0)
-               g_key_file_set_integer(keyfile, network->identifier,
-                                               "Priority", network->priority);
-
-       if (network->remember == TRUE || network->connected == TRUE) {
-               if (network->wifi.security != NULL)
-                       g_key_file_set_string(keyfile, network->identifier,
-                               "WiFi.Security", network->wifi.security);
-
-               if (network->wifi.passphrase != NULL)
-                       g_key_file_set_string(keyfile, network->identifier,
-                               "WiFi.Passphrase", network->wifi.passphrase);
-       }
-
-       data = g_key_file_to_data(keyfile, &length, NULL);
-
-       if (g_file_set_contents(pathname, data, length, NULL) == FALSE)
-               connman_error("Failed to store network information");
-
-done:
-       g_free(data);
-
-       g_key_file_free(keyfile);
-
-       g_free(pathname);
-
-       return 0;
-}
-
-static struct connman_storage network_storage = {
-       .name           = "network",
-       .priority       = CONNMAN_STORAGE_PRIORITY_LOW,
-       .network_init   = network_init,
-       .network_load   = network_load,
-       .network_save   = network_save,
-};
-
 int __connman_network_init(void)
 {
        DBG("");
 
        connection = connman_dbus_get_connection();
 
-       if (connman_storage_register(&network_storage) < 0)
-               connman_error("Failed to register network storage");
-
        return connman_driver_register(&network_driver);
 }
 
@@ -1321,7 +1207,5 @@ void __connman_network_cleanup(void)
 
        connman_driver_unregister(&network_driver);
 
-       connman_storage_unregister(&network_storage);
-
        dbus_connection_unref(connection);
 }