Fixed defects found in review

[situare] / src / map / friendgroupitem.cpp

diff --git a/src/map/friendgroupitem.cpp b/src/map/friendgroupitem.cpp
index 6bd1f5a..8ae761e 100644 (file)
--- a/src/map/friendgroupitem.cpp
+++ b/src/map/friendgroupitem.cpp
@@ -49,7 +49,6 @@ void FriendGroupItem::dropFriend(FriendLocationItem *item)
 
     m_friends.removeOne(item);
     item->setPartOfGroup(false);
-    item->show();
 }
 
 bool FriendGroupItem::dropFriends(int zoomLevel)
@@ -57,7 +56,8 @@ bool FriendGroupItem::dropFriends(int zoomLevel)
     qDebug() << __PRETTY_FUNCTION__;
 
     foreach (FriendLocationItem *friendItem, m_friends) {
-        if (!friendItem->sceneTransformedBoundingRect(zoomLevel).intersects(sceneTransformedBoundingRect(zoomLevel)))
+        if (!friendItem->sceneTransformedBoundingRect(zoomLevel)
+            .intersects(sceneTransformedBoundingRect(zoomLevel)))
             dropFriend(friendItem);
     }
 
@@ -78,7 +78,6 @@ void FriendGroupItem::joinFriend(FriendLocationItem *item)
 
     m_friends.append(item);
     item->setPartOfGroup(true);
-    item->hide();
 }
 
 void FriendGroupItem::mergeWithGroup(FriendGroupItem *group)
@@ -91,14 +90,15 @@ void FriendGroupItem::mergeWithGroup(FriendGroupItem *group)
     }
 }
 
-void FriendGroupItem::paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget)
+void FriendGroupItem::paint(QPainter *painter, const QStyleOptionGraphicsItem *option,
+                            QWidget *widget)
 {
     qDebug() << __PRETTY_FUNCTION__;
 
     BaseLocationItem::paint(painter, option, widget);
 
     QFont font = painter->font();
-    font.setPointSize(painter->font().pointSize() * 2);
+    font.setPointSize(painter->font().pointSize() * 2); // double default font size
     painter->setFont(font);
-    painter->drawText(QRect(-25, -25, 50, 50), Qt::AlignCenter, QString::number(m_friends.size()));
+    painter->drawText(boundingRect(), Qt::AlignCenter, QString::number(m_friends.count()));
 }