Add property for connection type
[connman] / src / element.c
index f088b59..d1e6de3 100644 (file)
@@ -112,8 +112,6 @@ static const char *type2string(enum connman_element_type type)
                return "bootp";
        case CONNMAN_ELEMENT_TYPE_ZEROCONF:
                return "zeroconf";
-       case CONNMAN_ELEMENT_TYPE_RESOLVER:
-               return "resolver";
        case CONNMAN_ELEMENT_TYPE_CONNECTION:
                return "connection";
        }
@@ -150,12 +148,10 @@ const char *__connman_element_policy2string(enum connman_element_policy policy)
        switch (policy) {
        case CONNMAN_ELEMENT_POLICY_UNKNOWN:
                return "unknown";
-       case CONNMAN_ELEMENT_POLICY_OFF:
-               return "off";
-       case CONNMAN_ELEMENT_POLICY_AUTO:
-               return "auto";
        case CONNMAN_ELEMENT_POLICY_IGNORE:
                return "ignore";
+       case CONNMAN_ELEMENT_POLICY_AUTO:
+               return "auto";
        case CONNMAN_ELEMENT_POLICY_ASK:
                return "ask";
        }
@@ -165,9 +161,7 @@ const char *__connman_element_policy2string(enum connman_element_policy policy)
 
 enum connman_element_policy __connman_element_string2policy(const char *policy)
 {
-       if (strcasecmp(policy, "off") == 0)
-               return CONNMAN_ELEMENT_POLICY_OFF;
-       else if (strcasecmp(policy, "ignore") == 0)
+       if (strcasecmp(policy, "ignore") == 0)
                return CONNMAN_ELEMENT_POLICY_IGNORE;
        else if (strcasecmp(policy, "auto") == 0)
                return CONNMAN_ELEMENT_POLICY_AUTO;
@@ -349,10 +343,8 @@ static void emit_enabled_signal(DBusConnection *conn,
 
        dbus_message_iter_open_container(&entry, DBUS_TYPE_VARIANT,
                                        DBUS_TYPE_BOOLEAN_AS_STRING, &value);
-
        dbus_message_iter_append_basic(&value, DBUS_TYPE_BOOLEAN,
                                                        &element->enabled);
-
        dbus_message_iter_close_container(&entry, &value);
 
        g_dbus_send_message(conn, signal);
@@ -398,13 +390,6 @@ static DBusMessage *do_enable(DBusConnection *conn,
 
        emit_enabled_signal(connection, element);
 
-#if 0
-       g_dbus_emit_signal(connection, CONNMAN_MANAGER_PATH,
-                               CONNMAN_MANAGER_INTERFACE, "ElementUpdated",
-                               DBUS_TYPE_OBJECT_PATH, &element->path,
-                                                       DBUS_TYPE_INVALID);
-#endif
-
        return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
 }
 
@@ -428,13 +413,6 @@ static DBusMessage *do_disable(DBusConnection *conn,
 
        emit_enabled_signal(connection, element);
 
-#if 0
-       g_dbus_emit_signal(connection, CONNMAN_MANAGER_PATH,
-                               CONNMAN_MANAGER_INTERFACE, "ElementUpdated",
-                               DBUS_TYPE_OBJECT_PATH, &element->path,
-                                                       DBUS_TYPE_INVALID);
-#endif
-
        return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
 }
 
@@ -444,10 +422,6 @@ static void append_networks(struct connman_element *element,
        DBusMessageIter value, iter;
        const char *key = "Networks";
 
-       if (element->subtype != CONNMAN_ELEMENT_SUBTYPE_WIFI &&
-                       element->subtype != CONNMAN_ELEMENT_SUBTYPE_WIMAX)
-               return;
-
        dbus_message_iter_append_basic(entry, DBUS_TYPE_STRING, &key);
 
        dbus_message_iter_open_container(entry, DBUS_TYPE_VARIANT,
@@ -498,12 +472,13 @@ static DBusMessage *device_get_properties(DBusConnection *conn,
        connman_dbus_dict_append_variant(&dict, "Powered",
                                        DBUS_TYPE_BOOLEAN, &element->enabled);
 
-       dbus_message_iter_open_container(&dict, DBUS_TYPE_DICT_ENTRY,
+       if (element->subtype == CONNMAN_ELEMENT_SUBTYPE_WIFI ||
+                       element->subtype == CONNMAN_ELEMENT_SUBTYPE_WIMAX) {
+               dbus_message_iter_open_container(&dict, DBUS_TYPE_DICT_ENTRY,
                                                                NULL, &entry);
-
-       append_networks(element, &dict);
-
-       dbus_message_iter_close_container(&dict, &entry);
+               append_networks(element, &entry);
+               dbus_message_iter_close_container(&dict, &entry);
+       }
 
        add_common_properties(element, &dict);
 
@@ -704,35 +679,7 @@ static DBusMessage *network_set_property(DBusConnection *conn,
        return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
 }
 
-static DBusMessage *get_connection_properties(DBusConnection *conn,
-                                       DBusMessage *msg, void *data)
-{
-       struct connman_element *element = data;
-       DBusMessage *reply;
-       DBusMessageIter array, dict;
-
-       DBG("conn %p", conn);
-
-       reply = dbus_message_new_method_return(msg);
-       if (reply == NULL)
-               return NULL;
-
-       dbus_message_iter_init_append(reply, &array);
-
-       dbus_message_iter_open_container(&array, DBUS_TYPE_ARRAY,
-                       DBUS_DICT_ENTRY_BEGIN_CHAR_AS_STRING
-                       DBUS_TYPE_STRING_AS_STRING DBUS_TYPE_VARIANT_AS_STRING
-                       DBUS_DICT_ENTRY_END_CHAR_AS_STRING, &dict);
-
-       add_common_properties(element, &dict);
-
-       dbus_message_iter_close_container(&array, &dict);
-
-       return reply;
-}
-
-#if 0
-static DBusMessage *get_properties(DBusConnection *conn,
+static DBusMessage *connection_get_properties(DBusConnection *conn,
                                        DBusMessage *msg, void *data)
 {
        struct connman_element *element = data;
@@ -753,24 +700,11 @@ static DBusMessage *get_properties(DBusConnection *conn,
                        DBUS_TYPE_STRING_AS_STRING DBUS_TYPE_VARIANT_AS_STRING
                        DBUS_DICT_ENTRY_END_CHAR_AS_STRING, &dict);
 
-       if (element->parent != NULL &&
-                       element->parent->type != CONNMAN_ELEMENT_TYPE_ROOT) {
-               connman_dbus_dict_append_variant(&dict, "Parent",
-                               DBUS_TYPE_OBJECT_PATH, &element->parent->path);
-       }
-
-       str = type2string(element->type);
-       if (str != NULL)
-               connman_dbus_dict_append_variant(&dict, "Type",
-                                               DBUS_TYPE_STRING, &str);
        str = subtype2string(element->subtype);
        if (str != NULL)
-               connman_dbus_dict_append_variant(&dict, "Subtype",
+               connman_dbus_dict_append_variant(&dict, "Type",
                                                DBUS_TYPE_STRING, &str);
 
-       connman_dbus_dict_append_variant(&dict, "Enabled",
-                                       DBUS_TYPE_BOOLEAN, &element->enabled);
-
        add_common_properties(element, &dict);
 
        dbus_message_iter_close_container(&array, &dict);
@@ -778,90 +712,6 @@ static DBusMessage *get_properties(DBusConnection *conn,
        return reply;
 }
 
-static DBusMessage *set_property(DBusConnection *conn,
-                                       DBusMessage *msg, void *data)
-{
-       struct connman_element *element = data;
-       DBusMessageIter iter;
-       DBusMessageIter value;
-       const char *name;
-
-       DBG("conn %p", conn);
-
-       if (dbus_message_iter_init(msg, &iter) == FALSE)
-               return __connman_error_invalid_arguments(msg);
-
-       dbus_message_iter_get_basic(&iter, &name);
-       dbus_message_iter_next(&iter);
-       dbus_message_iter_recurse(&iter, &value);
-
-       if (__connman_security_check_privileges(msg) < 0)
-               return __connman_error_permission_denied(msg);
-
-       set_common_property(element, name, &value);
-
-       return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
-}
-
-static DBusMessage *clear_property(DBusConnection *conn,
-                                       DBusMessage *msg, void *data)
-{
-       struct connman_element *element = data;
-       const char *name;
-       GSList *list;
-
-       DBG("conn %p", conn);
-
-       if (dbus_message_get_args(msg, NULL, DBUS_TYPE_STRING, &name,
-                                               DBUS_TYPE_INVALID) == FALSE)
-               return __connman_error_invalid_arguments(msg);
-
-       if (__connman_security_check_privileges(msg) < 0)
-               return __connman_error_permission_denied(msg);
-
-       __connman_element_lock(element);
-
-       for (list = element->properties; list; list = list->next) {
-               struct connman_property *property = list->data;
-
-               if (g_str_equal(property->name, name) == FALSE)
-                       continue;
-
-               if (property->flags & CONNMAN_PROPERTY_FLAG_STATIC)
-                       continue;
-
-               if (property->flags & CONNMAN_PROPERTY_FLAG_REFERENCE)
-                       continue;
-
-               property->flags |= CONNMAN_PROPERTY_FLAG_REFERENCE;
-
-               if (property->type == DBUS_TYPE_STRING)
-                       g_free(property->value);
-
-               property->value = NULL;
-       }
-
-       __connman_element_unlock(element);
-
-       return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
-}
-
-static GDBusMethodTable element_methods[] = {
-       { "GetProperties", "",   "a{sv}", get_properties },
-       { "SetProperty",   "sv", "",      set_property   },
-       { "ClearProperty", "s",  "",      clear_property },
-       { "Update",        "",   "",      do_update      },
-       { "Enable",        "",   "",      do_enable      },
-       { "Disable",       "",   "",      do_disable     },
-       { },
-};
-#endif
-
-static GDBusSignalTable element_signals[] = {
-       { "PropertyChanged", "sv" },
-       { },
-};
-
 static GDBusMethodTable device_methods[] = {
        { "GetProperties", "",      "a{sv}", device_get_properties },
        { "SetProperty",   "sv",    "",      device_set_property   },
@@ -880,7 +730,12 @@ static GDBusMethodTable network_methods[] = {
 };
 
 static GDBusMethodTable connection_methods[] = {
-       { "GetProperties", "",   "a{sv}", get_connection_properties },
+       { "GetProperties", "",   "a{sv}", connection_get_properties },
+       { },
+};
+
+static GDBusSignalTable element_signals[] = {
+       { "PropertyChanged", "sv" },
        { },
 };
 
@@ -1262,6 +1117,99 @@ int connman_element_add_static_property(struct connman_element *element,
        return 0;
 }
 
+static void emit_property_changed(DBusConnection *conn,
+                               struct connman_element *element,
+                               const char *name, int type, const void *data)
+{
+       DBusMessage *signal;
+       DBusMessageIter entry, value;
+       const char *iface, *sig;
+
+       DBG("conn %p", conn);
+
+       switch (element->type) {
+       case CONNMAN_ELEMENT_TYPE_DEVICE:
+               iface = CONNMAN_DEVICE_INTERFACE;
+               break;
+       case CONNMAN_ELEMENT_TYPE_NETWORK:
+               iface = CONNMAN_NETWORK_INTERFACE;
+               break;
+       default:
+               return;
+       }
+
+       signal = dbus_message_new_signal(element->path,
+                                               iface, "PropertyChanged");
+       if (signal == NULL)
+               return;
+
+       dbus_message_iter_init_append(signal, &entry);
+
+       dbus_message_iter_append_basic(&entry, DBUS_TYPE_STRING, &name);
+
+       switch (type) {
+       case DBUS_TYPE_STRING:
+               sig = DBUS_TYPE_STRING_AS_STRING;
+               break;
+       case DBUS_TYPE_BYTE:
+               sig = DBUS_TYPE_BYTE_AS_STRING;
+               break;
+       default:
+               sig = DBUS_TYPE_VARIANT_AS_STRING;
+               break;
+       }
+
+       dbus_message_iter_open_container(&entry, DBUS_TYPE_VARIANT,
+                                                       sig, &value);
+       dbus_message_iter_append_basic(&value, type, data);
+       dbus_message_iter_close_container(&entry, &value);
+
+       g_dbus_send_message(conn, signal);
+}
+
+int connman_element_set_static_property(struct connman_element *element,
+                               const char *name, int type, const void *value)
+{
+       GSList *list;
+
+       DBG("element %p name %s", element, element->name);
+
+       if (type != DBUS_TYPE_STRING && type != DBUS_TYPE_BYTE)
+               return -EINVAL;
+
+       __connman_element_lock(element);
+
+       for (list = element->properties; list; list = list->next) {
+               struct connman_property *property = list->data;
+
+               if (g_str_equal(property->name, name) == FALSE)
+                       continue;
+
+               if (!(property->flags & CONNMAN_PROPERTY_FLAG_STATIC))
+                       continue;
+
+               property->type = type;
+               g_free(property->value);
+
+               switch (type) {
+               case DBUS_TYPE_STRING:
+                       property->value = g_strdup(*((const char **) value));
+                       break;
+               case DBUS_TYPE_BYTE:
+                       property->value = g_try_malloc(1);
+                       if (property->value != NULL)
+                               memcpy(property->value, value, 1);
+                       break;
+               }
+       }
+
+       __connman_element_unlock(element);
+
+       emit_property_changed(connection, element, name, type, value);
+
+       return 0;
+}
+
 int connman_element_add_static_array_property(struct connman_element *element,
                        const char *name, int type, const void *value, int len)
 {
@@ -1502,13 +1450,6 @@ int connman_element_set_property(struct connman_element *element,
                return -EINVAL;
        }
 
-#if 0
-       g_dbus_emit_signal(connection, CONNMAN_MANAGER_PATH,
-                               CONNMAN_MANAGER_INTERFACE, "ElementUpdated",
-                               DBUS_TYPE_OBJECT_PATH, &element->path,
-                                                       DBUS_TYPE_INVALID);
-#endif
-
        return 0;
 }
 
@@ -1680,9 +1621,7 @@ static void append_devices(DBusMessageIter *entry)
 
        dbus_message_iter_open_container(&value, DBUS_TYPE_ARRAY,
                                DBUS_TYPE_OBJECT_PATH_AS_STRING, &iter);
-
        __connman_element_list(NULL, CONNMAN_ELEMENT_TYPE_DEVICE, &iter);
-
        dbus_message_iter_close_container(&value, &iter);
 
        dbus_message_iter_close_container(entry, &value);
@@ -1743,9 +1682,7 @@ static void append_connections(DBusMessageIter *entry)
 
        dbus_message_iter_open_container(&value, DBUS_TYPE_ARRAY,
                                DBUS_TYPE_OBJECT_PATH_AS_STRING, &iter);
-
        __connman_element_list(NULL, CONNMAN_ELEMENT_TYPE_CONNECTION, &iter);
-
        dbus_message_iter_close_container(&value, &iter);
 
        dbus_message_iter_close_container(entry, &value);
@@ -1779,9 +1716,7 @@ static void append_state(DBusMessageIter *entry, const char *state)
 
        dbus_message_iter_open_container(entry, DBUS_TYPE_VARIANT,
                                        DBUS_TYPE_STRING_AS_STRING, &value);
-
        dbus_message_iter_append_basic(&value, DBUS_TYPE_STRING, &state);
-
        dbus_message_iter_close_container(entry, &value);
 }
 
@@ -1839,14 +1774,6 @@ static void register_element(gpointer data, gpointer user_data)
 
        g_node_append_data(node, element);
 
-#if 0
-       if (g_dbus_register_interface(connection, element->path,
-                                       CONNMAN_ELEMENT_INTERFACE,
-                                       element_methods, element_signals,
-                                       NULL, element, NULL) == FALSE)
-               connman_error("Failed to register %s element", element->path);
-#endif
-
        if (element->type == CONNMAN_ELEMENT_TYPE_DEVICE &&
                        element->subtype != CONNMAN_ELEMENT_SUBTYPE_NETWORK) {
                if (g_dbus_register_interface(connection, element->path,
@@ -1883,13 +1810,6 @@ static void register_element(gpointer data, gpointer user_data)
                }
        }
 
-#if 0
-       g_dbus_emit_signal(connection, CONNMAN_MANAGER_PATH,
-                               CONNMAN_MANAGER_INTERFACE, "ElementAdded",
-                               DBUS_TYPE_OBJECT_PATH, &element->path,
-                                                       DBUS_TYPE_INVALID);
-#endif
-
        __connman_element_store(element);
 
        for (list = driver_list; list; list = list->next) {
@@ -1929,7 +1849,8 @@ int connman_element_register(struct connman_element *element,
        if (element->devname == NULL)
                element->devname = g_strdup(element->name);
 
-       if (device_filter && element->type == CONNMAN_ELEMENT_TYPE_DEVICE) {
+       if (device_filter && element->type == CONNMAN_ELEMENT_TYPE_DEVICE &&
+                       element->subtype != CONNMAN_ELEMENT_SUBTYPE_NETWORK) {
                if (g_pattern_match_simple(device_filter,
                                                element->devname) == FALSE) {
                        DBG("ignoring %s [%s] device", element->name,
@@ -1986,13 +1907,6 @@ static gboolean remove_element(GNode *node, gpointer user_data)
                g_node_destroy(node);
        }
 
-#if 0
-       g_dbus_emit_signal(connection, CONNMAN_MANAGER_PATH,
-                               CONNMAN_MANAGER_INTERFACE, "ElementRemoved",
-                               DBUS_TYPE_OBJECT_PATH, &element->path,
-                                                       DBUS_TYPE_INVALID);
-#endif
-
        if (element->type == CONNMAN_ELEMENT_TYPE_CONNECTION) {
                emit_state_change(connection, "offline");
                emit_connections_signal(connection);
@@ -2016,11 +1930,6 @@ static gboolean remove_element(GNode *node, gpointer user_data)
                                                CONNMAN_DEVICE_INTERFACE);
        }
 
-#if 0
-       g_dbus_unregister_interface(connection, element->path,
-                                               CONNMAN_ELEMENT_INTERFACE);
-#endif
-
        connman_element_unref(element);
 
        return FALSE;
@@ -2061,13 +1970,6 @@ static gboolean update_element(GNode *node, gpointer user_data)
        if (element->driver && element->driver->update)
                element->driver->update(element);
 
-#if 0
-       g_dbus_emit_signal(connection, CONNMAN_MANAGER_PATH,
-                               CONNMAN_MANAGER_INTERFACE, "ElementUpdated",
-                               DBUS_TYPE_OBJECT_PATH, &element->path,
-                                                       DBUS_TYPE_INVALID);
-#endif
-
        return FALSE;
 }
 
@@ -2092,7 +1994,7 @@ int connman_element_set_enabled(struct connman_element *element,
 
        element->enabled = enabled;
 
-       connman_element_update(element);
+       emit_enabled_signal(connection, element);
 
        return 0;
 }