Remove usage of reader/write lock
[connman] / src / element.c
index 00da43a..93c31df 100644 (file)
 
 static DBusConnection *connection;
 
-static GStaticRWLock element_lock = G_STATIC_RW_LOCK_INIT;
 static GNode *element_root = NULL;
-
 static GSList *driver_list = NULL;
-
 static gchar *device_filter = NULL;
 
 static struct {
@@ -180,18 +177,54 @@ enum connman_element_policy __connman_element_string2policy(const char *policy)
                return CONNMAN_ELEMENT_POLICY_UNKNOWN;
 }
 
+const char *__connman_ipv4_method2string(enum connman_ipv4_method method)
+{
+       switch (method) {
+       case CONNMAN_IPV4_METHOD_UNKNOWN:
+               return "unknown";
+       case CONNMAN_IPV4_METHOD_OFF:
+               return "off";
+       case CONNMAN_IPV4_METHOD_STATIC:
+               return "static";
+       case CONNMAN_IPV4_METHOD_DHCP:
+               return "dhcp";
+       }
+
+       return "unknown";
+}
+
+enum connman_ipv4_method __connman_ipv4_string2method(const char *method)
+{
+       if (strcasecmp(method, "off") == 0)
+               return CONNMAN_IPV4_METHOD_OFF;
+       else if (strcasecmp(method, "static") == 0)
+               return CONNMAN_IPV4_METHOD_STATIC;
+       else if (strcasecmp(method, "dhcp") == 0)
+               return CONNMAN_IPV4_METHOD_DHCP;
+       else
+               return CONNMAN_IPV4_METHOD_UNKNOWN;
+}
+
 static void append_property(DBusMessageIter *dict,
                                struct connman_property *property)
 {
        if (property->value == NULL)
                return;
 
-       if (property->type == DBUS_TYPE_ARRAY)
+       switch (property->type) {
+       case DBUS_TYPE_ARRAY:
                connman_dbus_dict_append_array(dict, property->name,
                        property->subtype, &property->value, property->size);
-       else
+               break;
+       case DBUS_TYPE_STRING:
                connman_dbus_dict_append_variant(dict, property->name,
                                        property->type, &property->value);
+               break;
+       default:
+               connman_dbus_dict_append_variant(dict, property->name,
+                                       property->type, property->value);
+               break;
+       }
 }
 
 static void add_common_properties(struct connman_element *element,
@@ -387,7 +420,7 @@ static void append_networks(struct connman_element *element,
        dbus_message_iter_close_container(dict, &entry);
 }
 
-static DBusMessage *get_device_properties(DBusConnection *conn,
+static DBusMessage *device_get_properties(DBusConnection *conn,
                                        DBusMessage *msg, void *data)
 {
        struct connman_element *element = data;
@@ -430,12 +463,11 @@ static DBusMessage *get_device_properties(DBusConnection *conn,
        return reply;
 }
 
-static DBusMessage *set_device_property(DBusConnection *conn,
+static DBusMessage *device_set_property(DBusConnection *conn,
                                        DBusMessage *msg, void *data)
 {
        struct connman_element *element = data;
-       DBusMessageIter iter;
-       DBusMessageIter value;
+       DBusMessageIter iter, value;
        const char *name;
 
        DBG("conn %p", conn);
@@ -467,7 +499,85 @@ static DBusMessage *set_device_property(DBusConnection *conn,
        return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
 }
 
-static DBusMessage *get_network_properties(DBusConnection *conn,
+static int parse_network_dict(DBusMessageIter *iter, const char **ssid,
+                               const char **security, const char **passphrase)
+{
+       while (dbus_message_iter_get_arg_type(iter) == DBUS_TYPE_DICT_ENTRY) {
+               DBusMessageIter entry, value;
+               const char *key;
+
+               dbus_message_iter_recurse(iter, &entry);
+               dbus_message_iter_get_basic(&entry, &key);
+
+               dbus_message_iter_next(&entry);
+               dbus_message_iter_recurse(&entry, &value);
+
+               switch (dbus_message_iter_get_arg_type(&value)) {
+               case DBUS_TYPE_STRING:
+                       if (g_str_equal(key, "WiFi.SSID") == TRUE)
+                               dbus_message_iter_get_basic(&value, ssid);
+                       else if (g_str_equal(key, "WiFi.Security") == TRUE)
+                               dbus_message_iter_get_basic(&value, security);
+                       else if (g_str_equal(key, "WiFi.Passphrase") == TRUE)
+                               dbus_message_iter_get_basic(&value, passphrase);
+                       break;
+               }
+
+               dbus_message_iter_next(iter);
+       }
+
+       return 0;
+}
+
+static DBusMessage *device_create_network(DBusConnection *conn,
+                                       DBusMessage *msg, void *data)
+{
+       struct connman_element *element = data;
+       struct connman_element *network;
+       DBusMessageIter iter, array;
+       const char *ssid = NULL, *security = NULL, *passphrase = NULL;
+
+       DBG("conn %p", conn);
+
+       if (dbus_message_iter_init(msg, &iter) == FALSE)
+               return __connman_error_invalid_arguments(msg);
+
+       dbus_message_iter_recurse(&iter, &array);
+       parse_network_dict(&array, &ssid, &security, &passphrase);
+       if (ssid == NULL)
+               return __connman_error_invalid_arguments(msg);
+
+       DBG("ssid %s security %s passphrase %s", ssid, security, passphrase);
+
+       network = connman_element_create(ssid);
+
+       network->type = CONNMAN_ELEMENT_TYPE_NETWORK;
+       network->index = element->index;
+
+       network->remember = TRUE;
+
+       connman_element_add_static_property(network, "Name",
+                                               DBUS_TYPE_STRING, &ssid);
+
+       connman_element_add_static_array_property(element, "WiFi.SSID",
+                                       DBUS_TYPE_BYTE, &ssid, strlen(ssid));
+
+       network->wifi.security = g_strdup(security);
+       network->wifi.passphrase = g_strdup(passphrase);
+
+       connman_element_register(network, element);
+
+       return g_dbus_create_reply(msg, DBUS_TYPE_OBJECT_PATH, &network->path,
+                                                       DBUS_TYPE_INVALID);
+}
+
+static DBusMessage *device_remove_network(DBusConnection *conn,
+                                       DBusMessage *msg, void *data)
+{
+       return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
+}
+
+static DBusMessage *network_get_properties(DBusConnection *conn,
                                        DBusMessage *msg, void *data)
 {
        struct connman_element *element = data;
@@ -493,9 +603,15 @@ static DBusMessage *get_network_properties(DBusConnection *conn,
                connman_dbus_dict_append_variant(&dict, "Policy",
                                                DBUS_TYPE_STRING, &str);
 
+       connman_dbus_dict_append_variant(&dict, "Available",
+                                       DBUS_TYPE_BOOLEAN, &element->available);
+
        connman_dbus_dict_append_variant(&dict, "Connected",
                                        DBUS_TYPE_BOOLEAN, &element->enabled);
 
+       connman_dbus_dict_append_variant(&dict, "Remember",
+                                       DBUS_TYPE_BOOLEAN, &element->remember);
+
        add_common_properties(element, &dict);
 
        dbus_message_iter_close_container(&array, &dict);
@@ -503,7 +619,7 @@ static DBusMessage *get_network_properties(DBusConnection *conn,
        return reply;
 }
 
-static DBusMessage *set_network_property(DBusConnection *conn,
+static DBusMessage *network_set_property(DBusConnection *conn,
                                        DBusMessage *msg, void *data)
 {
        struct connman_element *element = data;
@@ -523,7 +639,9 @@ static DBusMessage *set_network_property(DBusConnection *conn,
        if (__connman_security_check_privileges(msg) < 0)
                return __connman_error_permission_denied(msg);
 
-       if (g_str_equal(name, "WiFi.Passphrase") == TRUE) {
+       if (g_str_equal(name, "Remember") == TRUE) {
+               dbus_message_iter_get_basic(&value, &element->remember);
+       } else if (g_str_equal(name, "WiFi.Passphrase") == TRUE) {
                const char *str;
 
                dbus_message_iter_get_basic(&value, &str);
@@ -696,15 +814,17 @@ static GDBusSignalTable element_signals[] = {
 };
 
 static GDBusMethodTable device_methods[] = {
-       { "GetProperties", "",   "a{sv}", get_device_properties },
-       { "SetProperty",   "sv", "",      set_device_property   },
-       { "Scan",          "",   "",      do_update             },
+       { "GetProperties", "",      "a{sv}", device_get_properties },
+       { "SetProperty",   "sv",    "",      device_set_property   },
+       { "CreateNetwork", "a{sv}", "o",     device_create_network },
+       { "RemoveNetwork", "o",     "",      device_remove_network },
+       { "ProposeScan",   "",      "",      do_update             },
        { },
 };
 
 static GDBusMethodTable network_methods[] = {
-       { "GetProperties", "",   "a{sv}", get_network_properties },
-       { "SetProperty",   "sv", "",      set_network_property   },
+       { "GetProperties", "",   "a{sv}", network_get_properties },
+       { "SetProperty",   "sv", "",      network_set_property   },
        { "Connect",       "",   "",      do_enable              },
        { "Disconnect",    "",   "",      do_disable             },
        { },
@@ -734,6 +854,10 @@ static gboolean append_path(GNode *node, gpointer user_data)
                                        filter->type != element->type)
                return FALSE;
 
+       if (filter->type == CONNMAN_ELEMENT_TYPE_DEVICE &&
+                       element->subtype == CONNMAN_ELEMENT_SUBTYPE_NETWORK)
+               return FALSE;
+
        dbus_message_iter_append_basic(filter->iter,
                                DBUS_TYPE_OBJECT_PATH, &element->path);
 
@@ -757,10 +881,8 @@ void __connman_element_list(struct connman_element *element,
        } else
                node = element_root;
 
-       g_static_rw_lock_reader_lock(&element_lock);
        g_node_traverse(node, G_PRE_ORDER, G_TRAVERSE_ALL, -1,
                                                append_path, &filter);
-       g_static_rw_lock_reader_unlock(&element_lock);
 }
 
 struct count_data {
@@ -803,10 +925,8 @@ int __connman_element_count(struct connman_element *element,
        } else
                node = element_root;
 
-       g_static_rw_lock_reader_lock(&element_lock);
        g_node_traverse(node, G_PRE_ORDER, G_TRAVERSE_ALL, -1,
                                                count_element, &data);
-       g_static_rw_lock_reader_unlock(&element_lock);
 
        return data.count;
 }
@@ -878,13 +998,9 @@ void __connman_driver_rescan(struct connman_driver *driver)
        if (!driver->probe)
                return;
 
-       g_static_rw_lock_writer_lock(&element_lock);
-
        if (element_root != NULL)
                g_node_traverse(element_root, G_PRE_ORDER,
                                G_TRAVERSE_ALL, -1, probe_driver, driver);
-
-       g_static_rw_lock_writer_unlock(&element_lock);
 }
 
 /**
@@ -905,8 +1021,6 @@ int connman_driver_register(struct connman_driver *driver)
        if (!driver->probe)
                return -EINVAL;
 
-       g_static_rw_lock_writer_lock(&element_lock);
-
        driver_list = g_slist_insert_sorted(driver_list, driver,
                                                        compare_priority);
 
@@ -914,8 +1028,6 @@ int connman_driver_register(struct connman_driver *driver)
                g_node_traverse(element_root, G_PRE_ORDER,
                                G_TRAVERSE_ALL, -1, probe_driver, driver);
 
-       g_static_rw_lock_writer_unlock(&element_lock);
-
        return 0;
 }
 
@@ -964,15 +1076,11 @@ void connman_driver_unregister(struct connman_driver *driver)
 {
        DBG("driver %p name %s", driver, driver->name);
 
-       g_static_rw_lock_writer_lock(&element_lock);
-
        driver_list = g_slist_remove(driver_list, driver);
 
        if (element_root != NULL)
                g_node_traverse(element_root, G_POST_ORDER,
                                G_TRAVERSE_ALL, -1, remove_driver, driver);
-
-       g_static_rw_lock_writer_unlock(&element_lock);
 }
 
 /**
@@ -1055,6 +1163,7 @@ void connman_element_unref(struct connman_element *element)
                g_free(element->ipv4.network);
                g_free(element->ipv4.broadcast);
                g_free(element->ipv4.nameserver);
+               g_free(element->devname);
                g_free(element->path);
                g_free(element->name);
                g_free(element);
@@ -1068,8 +1177,7 @@ int connman_element_add_static_property(struct connman_element *element,
 
        DBG("element %p name %s", element, element->name);
 
-       if (type != DBUS_TYPE_STRING && type != DBUS_TYPE_BYTE &&
-                                               type != DBUS_TYPE_INT32)
+       if (type != DBUS_TYPE_STRING && type != DBUS_TYPE_BYTE)
                return -EINVAL;
 
        property = g_try_new0(struct connman_property, 1);
@@ -1092,11 +1200,6 @@ int connman_element_add_static_property(struct connman_element *element,
                if (property->value != NULL)
                        memcpy(property->value, value, 1);
                break;
-       case DBUS_TYPE_INT32:
-               property->value = g_try_malloc(sizeof(gint32));
-               if (property->value != NULL)
-                       memcpy(property->value, value, sizeof(gint32));
-               break;
        }
 
        __connman_element_lock(element);
@@ -1438,15 +1541,9 @@ gboolean connman_element_get_static_property(struct connman_element *element,
                        switch (property->type) {
                        case DBUS_TYPE_STRING:
                                *((char **) value) = property->value;
-                               break;
-                       case DBUS_TYPE_BYTE:
-                               *((guint8 *) value) = *((guint8 *) property->value);
-                               break;
-                       case DBUS_TYPE_INT32:
-                               *((gint32 *) value) = *((gint32 *) property->value);
+                               found = TRUE;
                                break;
                        }
-                       found = TRUE;
                        break;
                }
        }
@@ -1638,8 +1735,6 @@ static void register_element(gpointer data, gpointer user_data)
        GSList *list;
        GNode *node;
 
-       g_static_rw_lock_writer_lock(&element_lock);
-
        __connman_element_lock(element);
 
        if (element->parent) {
@@ -1717,12 +1812,8 @@ static void register_element(gpointer data, gpointer user_data)
                                                        DBUS_TYPE_INVALID);
 #endif
 
-       g_static_rw_lock_writer_unlock(&element_lock);
-
        __connman_element_store(element);
 
-       g_static_rw_lock_writer_lock(&element_lock);
-
        for (list = driver_list; list; list = list->next) {
                struct connman_driver *driver = list->data;
 
@@ -1740,8 +1831,6 @@ static void register_element(gpointer data, gpointer user_data)
                        break;
                }
        }
-
-       g_static_rw_lock_writer_unlock(&element_lock);
 }
 
 /**
@@ -1759,10 +1848,14 @@ int connman_element_register(struct connman_element *element,
 {
        DBG("element %p name %s parent %p", element, element->name, parent);
 
+       if (element->devname == NULL)
+               element->devname = g_strdup(element->name);
+
        if (device_filter && element->type == CONNMAN_ELEMENT_TYPE_DEVICE) {
                if (g_pattern_match_simple(device_filter,
-                                               element->name) == FALSE) {
-                       DBG("ignoring %s device", element->name);
+                                               element->devname) == FALSE) {
+                       DBG("ignoring %s [%s] device", element->name,
+                                                       element->devname);
                        return -EPERM;
                }
        }
@@ -1856,15 +1949,11 @@ void connman_element_unregister(struct connman_element *element)
 
        DBG("element %p name %s", element, element->name);
 
-       g_static_rw_lock_writer_lock(&element_lock);
-
        node = g_node_find(element_root, G_PRE_ORDER, G_TRAVERSE_ALL, element);
 
        if (node != NULL)
                g_node_traverse(node, G_POST_ORDER,
                                G_TRAVERSE_ALL, -1, remove_element, NULL);
-
-       g_static_rw_lock_writer_unlock(&element_lock);
 }
 
 void connman_element_unregister_children(struct connman_element *element)
@@ -1873,15 +1962,11 @@ void connman_element_unregister_children(struct connman_element *element)
 
        DBG("element %p name %s", element, element->name);
 
-       g_static_rw_lock_writer_lock(&element_lock);
-
        node = g_node_find(element_root, G_PRE_ORDER, G_TRAVERSE_ALL, element);
 
        if (node != NULL)
                g_node_traverse(node, G_POST_ORDER,
                                G_TRAVERSE_ALL, -1, remove_element, element);
-
-       g_static_rw_lock_writer_unlock(&element_lock);
 }
 
 static gboolean update_element(GNode *node, gpointer user_data)
@@ -1909,15 +1994,11 @@ void connman_element_update(struct connman_element *element)
 
        DBG("element %p name %s", element, element->name);
 
-       g_static_rw_lock_reader_lock(&element_lock);
-
        node = g_node_find(element_root, G_PRE_ORDER, G_TRAVERSE_ALL, element);
 
        if (node != NULL)
                g_node_traverse(node, G_PRE_ORDER,
                                G_TRAVERSE_ALL, -1, update_element, NULL);
-
-       g_static_rw_lock_reader_unlock(&element_lock);
 }
 
 int connman_element_set_enabled(struct connman_element *element,
@@ -1945,8 +2026,6 @@ int __connman_element_init(DBusConnection *conn, const char *device)
 
        device_filter = g_strdup(device);
 
-       g_static_rw_lock_writer_lock(&element_lock);
-
        element = connman_element_create("root");
 
        element->path = g_strdup("/");
@@ -1956,8 +2035,6 @@ int __connman_element_init(DBusConnection *conn, const char *device)
 
        element_root = g_node_new(element);
 
-       g_static_rw_lock_writer_unlock(&element_lock);
-
        __connman_device_init();
 
        return 0;
@@ -1999,20 +2076,14 @@ void __connman_element_cleanup(void)
 
        __connman_device_cleanup();
 
-       g_static_rw_lock_writer_lock(&element_lock);
        g_node_traverse(element_root, G_POST_ORDER, G_TRAVERSE_ALL, -1,
                                                        free_driver, NULL);
-       g_static_rw_lock_writer_unlock(&element_lock);
 
-       g_static_rw_lock_writer_lock(&element_lock);
        g_node_traverse(element_root, G_POST_ORDER, G_TRAVERSE_ALL, -1,
                                                        free_node, NULL);
-       g_static_rw_lock_writer_unlock(&element_lock);
 
-       g_static_rw_lock_writer_lock(&element_lock);
        g_node_destroy(element_root);
        element_root = NULL;
-       g_static_rw_lock_writer_unlock(&element_lock);
 
        g_free(device_filter);