Use async creation and removal for supplicant interfaces
[connman] / plugins / supplicant.c
index a51a517..88e8123 100644 (file)
 
 static GSList *driver_list = NULL;
 
+static void process_state_change(struct connman_device *device,
+                                               enum supplicant_state state)
+{
+       GSList *list;
+
+       for (list = driver_list; list; list = list->next) {
+               struct supplicant_driver *driver = list->data;
+
+               if (driver->state_change)
+                       driver->state_change(device, state);
+       }
+}
+
+static void process_clear_results(struct connman_device *device)
+{
+       GSList *list;
+
+       for (list = driver_list; list; list = list->next) {
+               struct supplicant_driver *driver = list->data;
+
+               if (driver->clear_results)
+                       driver->clear_results(device);
+       }
+}
+
+static void process_scan_result(struct connman_device *device,
+                                       struct supplicant_network *network)
+{
+       GSList *list;
+
+       for (list = driver_list; list; list = list->next) {
+               struct supplicant_driver *driver = list->data;
+
+               if (driver->scan_result)
+                       driver->scan_result(device, network);
+       }
+}
+
 struct supplicant_task {
        int ifindex;
        gchar *ifname;
        struct connman_device *device;
-       struct supplicant_callback *callback;
        gchar *path;
        gboolean created;
        gchar *network;
@@ -58,6 +95,15 @@ static GSList *task_list = NULL;
 
 static DBusConnection *connection;
 
+static void free_task(struct supplicant_task *task)
+{
+       DBG("task %p", task);
+
+       g_free(task->ifname);
+       g_free(task->path);
+       g_free(task);
+}
+
 static struct supplicant_task *find_task_by_index(int index)
 {
        GSList *list;
@@ -86,37 +132,21 @@ static struct supplicant_task *find_task_by_path(const char *path)
        return NULL;
 }
 
-static int get_interface(struct supplicant_task *task)
+static void add_interface_reply(DBusPendingCall *call, void *user_data)
 {
-       DBusMessage *message, *reply;
+       struct supplicant_task *task = user_data;
+       DBusMessage *reply;
        DBusError error;
        const char *path;
 
        DBG("task %p", task);
 
-       message = dbus_message_new_method_call(SUPPLICANT_NAME, SUPPLICANT_PATH,
-                                       SUPPLICANT_INTF, "getInterface");
-       if (message == NULL)
-               return -ENOMEM;
-
-       dbus_message_append_args(message, DBUS_TYPE_STRING, &task->ifname,
-                                                       DBUS_TYPE_INVALID);
-
-       dbus_error_init(&error);
-
-       reply = dbus_connection_send_with_reply_and_block(connection,
-                                                       message, -1, &error);
-       if (reply == NULL) {
-               if (dbus_error_is_set(&error) == TRUE) {
-                       connman_error("%s", error.message);
-                       dbus_error_free(&error);
-               } else
-                       connman_error("Failed to get interface");
-               dbus_message_unref(message);
-               return -EIO;
-       }
+       reply = dbus_pending_call_steal_reply(call);
+       if (reply == NULL)
+               return;
 
-       dbus_message_unref(message);
+       if (dbus_message_get_type(reply) == DBUS_MESSAGE_TYPE_ERROR)
+               goto done;
 
        dbus_error_init(&error);
 
@@ -127,25 +157,24 @@ static int get_interface(struct supplicant_task *task)
                        dbus_error_free(&error);
                } else
                        connman_error("Wrong arguments for interface");
-               dbus_message_unref(reply);
-               return -EIO;
+               goto done;
        }
 
        DBG("path %s", path);
 
        task->path = g_strdup(path);
-       task->created = FALSE;
+       task->created = TRUE;
 
-       dbus_message_unref(reply);
+       connman_device_set_powered(task->device, TRUE);
 
-       return 0;
+done:
+       dbus_message_unref(reply);
 }
 
 static int add_interface(struct supplicant_task *task)
 {
-       DBusMessage *message, *reply;
-       DBusError error;
-       const char *path;
+       DBusMessage *message;
+       DBusPendingCall *call;
 
        DBG("task %p", task);
 
@@ -154,25 +183,41 @@ static int add_interface(struct supplicant_task *task)
        if (message == NULL)
                return -ENOMEM;
 
-       dbus_error_init(&error);
-
        dbus_message_append_args(message, DBUS_TYPE_STRING, &task->ifname,
                                                        DBUS_TYPE_INVALID);
 
-       reply = dbus_connection_send_with_reply_and_block(connection,
-                                                       message, -1, &error);
-       if (reply == NULL) {
-               if (dbus_error_is_set(&error) == TRUE) {
-                       connman_error("%s", error.message);
-                       dbus_error_free(&error);
-               } else
-                       connman_error("Failed to add interface");
+       if (dbus_connection_send_with_reply(connection, message,
+                                               &call, TIMEOUT) == FALSE) {
+               connman_error("Failed to add interface");
                dbus_message_unref(message);
                return -EIO;
        }
 
+       dbus_pending_call_set_notify(call, add_interface_reply, task, NULL);
+
        dbus_message_unref(message);
 
+       return -EINPROGRESS;
+}
+
+static void get_interface_reply(DBusPendingCall *call, void *user_data)
+{
+       struct supplicant_task *task = user_data;
+       DBusMessage *reply;
+       DBusError error;
+       const char *path;
+
+       DBG("task %p", task);
+
+       reply = dbus_pending_call_steal_reply(call);
+       if (reply == NULL)
+               return;
+
+       if (dbus_message_get_type(reply) == DBUS_MESSAGE_TYPE_ERROR) {
+               add_interface(task);
+               goto done;
+       }
+
        dbus_error_init(&error);
 
        if (dbus_message_get_args(reply, &error, DBUS_TYPE_OBJECT_PATH, &path,
@@ -182,29 +227,76 @@ static int add_interface(struct supplicant_task *task)
                        dbus_error_free(&error);
                } else
                        connman_error("Wrong arguments for interface");
-               dbus_message_unref(reply);
-               return -EIO;
+               goto done;
        }
 
        DBG("path %s", path);
 
        task->path = g_strdup(path);
-       task->created = TRUE;
+       task->created = FALSE;
+
+       connman_device_set_powered(task->device, TRUE);
 
+done:
        dbus_message_unref(reply);
+}
 
-       return 0;
+static int create_interface(struct supplicant_task *task)
+{
+       DBusMessage *message;
+       DBusPendingCall *call;
+
+       DBG("task %p", task);
+
+       message = dbus_message_new_method_call(SUPPLICANT_NAME, SUPPLICANT_PATH,
+                                       SUPPLICANT_INTF, "getInterface");
+       if (message == NULL)
+               return -ENOMEM;
+
+       dbus_message_append_args(message, DBUS_TYPE_STRING, &task->ifname,
+                                                       DBUS_TYPE_INVALID);
+
+       if (dbus_connection_send_with_reply(connection, message,
+                                               &call, TIMEOUT) == FALSE) {
+               connman_error("Failed to get interface");
+               dbus_message_unref(message);
+               return -EIO;
+       }
+
+       dbus_pending_call_set_notify(call, get_interface_reply, task, NULL);
+
+       dbus_message_unref(message);
+
+       return -EINPROGRESS;
+}
+
+static void remove_interface_reply(DBusPendingCall *call, void *user_data)
+{
+       struct supplicant_task *task = user_data;
+       DBusMessage *reply;
+
+       DBG("task %p", task);
+
+       reply = dbus_pending_call_steal_reply(call);
+
+       connman_device_set_powered(task->device, FALSE);
+
+       free_task(task);
+
+       dbus_message_unref(reply);
 }
 
 static int remove_interface(struct supplicant_task *task)
 {
-       DBusMessage *message, *reply;
-       DBusError error;
+       DBusMessage *message;
+       DBusPendingCall *call;
 
        DBG("task %p", task);
 
-       if (task->created == FALSE)
-               return -EINVAL;
+       if (task->created == FALSE) {
+               connman_device_set_powered(task->device, FALSE);
+               return 0;
+       }
 
        message = dbus_message_new_method_call(SUPPLICANT_NAME, SUPPLICANT_PATH,
                                        SUPPLICANT_INTF, "removeInterface");
@@ -214,27 +306,21 @@ static int remove_interface(struct supplicant_task *task)
        dbus_message_append_args(message, DBUS_TYPE_OBJECT_PATH, &task->path,
                                                        DBUS_TYPE_INVALID);
 
-       dbus_error_init(&error);
-
-       reply = dbus_connection_send_with_reply_and_block(connection,
-                                                       message, -1, &error);
-       if (reply == NULL) {
-               if (dbus_error_is_set(&error) == TRUE) {
-                       connman_error("%s", error.message);
-                       dbus_error_free(&error);
-               } else
-                       connman_error("Failed to remove interface");
+       if (dbus_connection_send_with_reply(connection, message,
+                                               &call, TIMEOUT) == FALSE) {
+               connman_error("Failed to remove interface");
                dbus_message_unref(message);
                return -EIO;
        }
 
-       dbus_message_unref(message);
+       dbus_pending_call_set_notify(call, remove_interface_reply, task, NULL);
 
-       dbus_message_unref(reply);
+       dbus_message_unref(message);
 
-       return 0;
+       return -EINPROGRESS;
 }
 
+#if 0
 static int set_ap_scan(struct supplicant_task *task)
 {
        DBusMessage *message, *reply;
@@ -271,6 +357,7 @@ static int set_ap_scan(struct supplicant_task *task)
 
        return 0;
 }
+#endif
 
 static int add_network(struct supplicant_task *task)
 {
@@ -735,8 +822,7 @@ static void properties_reply(DBusPendingCall *call, void *user_data)
                dbus_message_iter_next(&dict);
        }
 
-       if (task->callback && task->callback->scan_result)
-               task->callback->scan_result(task->device, network);
+       process_scan_result(task->device, network);
 
        g_free(network->identifier);
        g_free(network->ssid);
@@ -798,8 +884,7 @@ static void scan_results_reply(DBusPendingCall *call, void *user_data)
                goto done;
        }
 
-       if (task->callback && task->callback->clear_results)
-                       task->callback->clear_results(task->device);
+       process_clear_results(task->device);
 
        for (i = 0; i < num_results; i++)
                get_network_properties(task, results[i]);
@@ -874,8 +959,7 @@ static void state_change(struct supplicant_task *task, DBusMessage *msg)
        else if (g_str_equal(state, "DISCONNECTED") == TRUE)
                task->state = STATE_DISCONNECTED;
 
-       if (task->callback && task->callback->state_change)
-               task->callback->state_change(task->device, task->state);
+       process_state_change(task->device, task->state);
 
        switch (task->state) {
        case STATE_COMPLETED:
@@ -921,11 +1005,9 @@ static DBusHandlerResult supplicant_filter(DBusConnection *conn,
        return DBUS_HANDLER_RESULT_NOT_YET_HANDLED;
 }
 
-int __supplicant_start(struct connman_device *device,
-                                       struct supplicant_callback *callback)
+int supplicant_start(struct connman_device *device)
 {
        struct supplicant_task *task;
-       int err;
 
        DBG("device %p", device);
 
@@ -936,7 +1018,6 @@ int __supplicant_start(struct connman_device *device,
        task->ifindex = connman_device_get_index(device);
        task->ifname = inet_index2name(task->ifindex);
        task->device = device;
-       task->callback = callback;
 
        if (task->ifname == NULL) {
                g_free(task);
@@ -948,21 +1029,10 @@ int __supplicant_start(struct connman_device *device,
 
        task_list = g_slist_append(task_list, task);
 
-       err = get_interface(task);
-       if (err < 0) {
-               err = add_interface(task);
-               if (err < 0) {
-                       g_free(task);
-                       return err;
-               }
-       }
-
-       set_ap_scan(task);
-
-       return 0;
+       return create_interface(task);
 }
 
-int __supplicant_stop(struct connman_device *device)
+int supplicant_stop(struct connman_device *device)
 {
        int index = connman_device_get_index(device);
        struct supplicant_task *task;
@@ -979,16 +1049,10 @@ int __supplicant_stop(struct connman_device *device)
 
        remove_network(task);
 
-       remove_interface(task);
-
-       g_free(task->ifname);
-       g_free(task->path);
-       g_free(task);
-
-       return 0;
+       return remove_interface(task);
 }
 
-int __supplicant_scan(struct connman_device *device)
+int supplicant_scan(struct connman_device *device)
 {
        int index = connman_device_get_index(device);
        struct supplicant_task *task;