1 2007-06-03 Christian Kellner <ckellner@openismus.com>
3 * libmodest-dbus-client/libmodest-dbus-client.h:
4 * libmodest-dbus-client/libmodest-dbus-client.c:
5 (libmodest_dbus_client_delete_message):
6 Implement deletion of messages (Client side).
8 (modest_search_hit_free),
9 (modest_search_hit_list_free):
10 Utility functions to free the result hits.
12 * src/dbus_api/modest-dbus-api.h:
13 * src/dbus_api/modest-dbus-callbacks.c:
15 (modest_dbus_req_handler):
16 Implement deletion of messages (Server side).
18 * tests/dbus_api/test_search.c: (main):
21 * tests/dbus_api/Makefile.am:
22 * tests/dbus_api/test_delete_message:
23 Add little test for the message deletion logic
25 2007-06-03 Armin Burgmeier <armin@openismus.com>
27 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
28 when the operation queue was not empty. projects.maemo.org bug
31 2007-06-03 Armin Burgmeier <armin@openismus.com>
33 * src/widgets/modest-account-view.c
34 (on_account_default_toggled): Toggle default account column
35 explicitely instead of waiting for gconf notification (which is
36 currently ignored). This should fix projects.maemo.org bug NB#56910
37 for now. It should probably be removed when gconf notifications are
40 2007-06-03 Christian Kellner <ckellner@openismus.com>
42 * libmodest-dbus-client/libmodest-dbus-client.c:
43 Removed debugging spew.
45 * src/dbus_api/modest-dbus-callbacks.c:
48 * src/modest-search.c:
49 (modest_search_all_accounts):
50 Use tny_account_store_get_accounts () on the account store
51 to get all accounts which is the way to get all accounts.
53 * tests/dbus_api/test_search.c: (main):
54 Make it possible to supply the search term on the command line.
56 2007-06-03 Christian Kellner <ckellner@openismus.com>
58 * libmodest-dbus-client/libmodest-dbus-client.c:
59 * libmodest-dbus-client/libmodest-dbus-client.h:
60 Implement searching for mesages over raw dbus. (Client side)
62 * src/dbus_api/Makefile.am:
63 * src/dbus_api/modest-dbus-api.h:
64 * src/dbus_api/modest-dbus-callbacks.c:
65 * src/dbus_api/modest-dbus-callbacks.h:
66 Search framework (Server side). Also implement on_idle_open_message().
68 * src/maemo/modest-platform.c: (modest_platform_init):
69 Prepare for raw dbus/osso rpc interaction.
71 * src/modest-search.h:
72 Changed minsize from unspecific guint to guint32.
74 * src/modest-search.c:
76 Added strange hack which magically made tnymail work.
78 (modest_search_folder),
79 (modest_search_account),
80 (modest_search_all_accounts):
81 Implement helper functions to search all accounts, specific account
84 * tests/dbus_api/Makefile.am:
85 * tests/dbus_api/test_open_message.c:
86 Read url to open from commandline.
88 * tests/dbus_api/test_search.c:
89 Implement small test for dbus search stuff
91 2007-06-02 Armin Burgmeier <armin@openismus.com>
93 * src/maemo/modest-account-settings-dialog.c: Changed window title to
94 include account type and account title. This fixes projects.maemo.org
97 * src/maemo/modest-account-view-window.c: Set a title for the window.
99 2007-06-02 Armin Burgmeier <armin@openismus.com>
101 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
102 incoming and outgoing server name based on email address and server
103 types as long as the names have not been edited manually. This fixes
104 projects.maemo.org bug NB#58671.
106 2007-06-02 Armin Burgmeier <armin@openismus.com>
108 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
109 server type cannot be changed in future to the incoming details page
110 when creating an account. This fixes projects.maemo.org bug NB#59029.
112 2007-06-02 Armin Burgmeier <armin@openismus.com>
114 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
115 and assigned max width chars so that they wrap instead of being
116 truncated. Fixes projects.maemo.org bug NB#56126.
118 2007-06-02 Armin Burgmeier <armin@openismus.com>
120 * src/maemo/modest-connection-specific-smtp-window.c: Add an
121 introductory note to the connection specific smtp servers dialog, as
122 section 8.12 of the email UI specification requires. This fixes
123 projects.maemo.org bug NB#59212.
125 2007-06-01 Murray Cumming <murrayc@murrayc.com>
127 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
128 Check for running mail operations, and offer to cancel them, as per the UI
129 spec. This fixes projects.maemo.org bug NB#59041 .
130 However, I suspect that tinymail may still use the network connection
131 in ways that we cannot detect or cancel. But it should at least adapt to
134 2007-06-01 Murray Cumming <murrayc@murrayc.com>
136 * src/modest-tny-account-store.c: (recreate_all_accounts),
137 (get_cached_accounts), (get_server_accounts): Do more sensible
138 ref-counting of the temporarily-cached outbox accounts list. This seems
139 to fix a crash when entering the password when the password was wrong.
141 2007-06-01 Murray Cumming <murrayc@murrayc.com>
143 * src/gnome/modest-main-window.c: (connect_signals):
144 * src/modest-tny-account-store.c: (get_password),
145 (modest_tny_account_store_alert): Added comments and clues and
146 commented-out code about how we currently fail to deal with connection
147 errors and wrong passwords, and how we should.
149 2007-06-01 Murray Cumming <murrayc@murrayc.com>
151 * src/widgets/modest-retrieve-combo-box.c:
152 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
153 This fixes projects.maemo.org bug NB#58472 .
155 2007-06-01 Murray Cumming <murrayc@murrayc.com>
157 * src/maemo/easysetup/modest-easysetup-wizard.c:
158 (create_page_complete_easysetup):
159 (create_page_complete_custom): Correct the last commit,
160 putting the correct sentences in the correct pages.
162 2007-06-01 Murray Cumming <murrayc@murrayc.com>
164 * src/maemo/easysetup/modest-easysetup-wizard.c:
165 (create_page_complete_custom): Show the second sentence of text
166 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
169 2007-06-01 Murray Cumming <murrayc@murrayc.com>
171 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
172 Set the leave-on-server conf key by default. This fixes
173 projects.maemo.org bug NB#59258 .
175 2007-06-01 Murray Cumming <murrayc@murrayc.com>
177 * src/maemo/modest-account-view-window.c:
178 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
179 logical ID for the confirmation messages. Fixed projects.maemo.org bug
182 2007-06-01 Murray Cumming <murrayc@murrayc.com>
184 * src/maemo/easysetup/modest-easysetup-wizard.c:
185 (create_caption_new_with_asterisk):
186 * src/maemo/modest-account-settings-dialog.c:
187 (create_caption_new_with_asterisk):
188 Uncomment the code to add the asterisk, because they are no longer in the
189 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
190 (update_incoming_server_title): Add an asterisk here too.
192 2007-06-01 Murray Cumming <murrayc@murrayc.com>
194 * src/maemo/modest-maemo-global-settings-dialog.c:
195 (current_connection): Check that we are even connected before trying to
196 get the current connection name, to prevent a warning.
198 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
199 Change the comments because tny_maemo_conic_device_connect() is now meant to
201 * src/modest-mail-operation.c:
202 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
203 make sure we have a connection and fail if we can't connect.
205 2007-05-31 Murray Cumming <murrayc@murrayc.com>
207 * src/maemo/modest-main-window.c:
208 (on_account_store_connecting_finished): Do not try to get the
209 connection ID if we are not really connected. I am surprised that
210 this signal handler is called when we are not connected.
212 2007-05-31 Murray Cumming <murrayc@murrayc.com>
214 * src/modest-error.h:
215 * src/modest-ui-actions.c:
216 (modest_ui_actions_get_msgs_full_error_handler):
217 Renamed an enum, added comments, added an enum
218 for retrieve-limit errors.
220 * src/modest-mail-operation.c: (foreach_add_item),
221 (internal_folder_observer_update), (update_account_thread),
222 (modest_mail_operation_get_msgs_full):
223 (modest_mail_operation_update_account),
224 Added comments about how this works, and some code that should
225 (but does not) check the retrieve-limit. See the TODO comment.
227 2007-05-31 Murray Cumming <murrayc@murrayc.com>
229 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
230 Initialize help_id to fix the build. Warnings are good.
232 2007-05-31 Murray Cumming <murrayc@murrayc.com>
234 * src/widgets/modest-hbox-cell-renderer.c:
235 (modest_hbox_cell_renderer_append):
236 * src/widgets/modest-vbox-cell-renderer.c:
237 (modest_vbox_cell_renderer_append):
238 Fix the last commit by doing an extra ref.
240 2007-05-31 Murray Cumming <murrayc@murrayc.com>
242 * src/widgets/modest-hbox-cell-renderer.c:
243 (modest_hbox_cell_renderer_append):
244 * src/widgets/modest-vbox-cell-renderer.c:
245 (modest_vbox_cell_renderer_append):
246 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
247 to fix the build with Maemo Bora.
248 However, there seems to be a remaining crash, probably due to reference
251 2007-05-30 Murray Cumming <murrayc@murrayc.com>
253 * src/modest-tny-account.c:
254 (modest_tny_account_new_for_local_folders):
255 Use hildon_file_system_info_async_new() to get a better name for
256 the memory card account, setting it as the account name.
257 The timing seems to work, but this is probably
258 not the best place to do this. See the TODO comment.
259 * src/maemo/modest-main-window.c: (create_details_widget):
260 * src/widgets/modest-folder-view.c: (text_cell_data):
261 Use the tny account name instead of hardcoding a name.
263 2007-05-30 Christian Kellner <ckellner@openismus.com>
265 * src/modest-search.c: (modest_search):
266 Correctly set part_search_func even if we have already parsed
267 the query and thus a valid OgsTextSearcher object.
269 2007-05-30 Christian Kellner <ckellner@openismus.com>
272 Search and check for libogs.
275 Incooparte the ogs build env.
277 * src/modest-mime-part-search-stream.c:
278 * src/modest-mime-part-search-stream.h:
279 Removed since we do the real searching now in modest-search.c.
281 * src/modest-search.c:
282 * src/modest-search.h:
283 Implement support for ogs. We use that if available and requested
284 and fall back to modest_text_utils_utf8_strcmp (). The search logic
285 should now handle the corner case when the search term is spread
286 across multiple reads.
287 Also the logic in modest_search () was corrected to search all
288 requested fields until one is found.
290 2007-05-30 Murray Cumming <murrayc@murrayc.com>
292 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
295 * src/modest-init.c: Made modest_init_local_folders() take a
296 path and be public so we can iniitialize maildir folders on
299 * src/modest-local-folder-info.h:
300 * src/modest-local-folder-info.c:
301 (modest_local_folder_info_get_maildir_path): Add a path parameter.
303 * src/modest-tny-account.c:
304 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
305 still means the standard local-folders path on the local volume.
307 * src/modest-tny-account-store.c:
308 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
309 signal so we can detect mount/unmount of the MMC1 card, and do an update of
310 all accounts when that happens.
311 (get_server_accounts): If the MMC1 card is mounted, create a store account for
312 this too, so it shows up in the treeview.
314 2007-05-28 Murray Cumming <murrayc@murrayc.com>
316 * src/maemo/modest-maemo-global-settings-dialog.c:
317 (current_connection):
318 * src/widgets/modest-global-settings-dialog.c:
319 (current_connection_default):
320 Use the enum values instead of 0, 1 and -1,
321 to make the code clearer.
323 * src/modest-account-mgr-helpers.c:
324 (modest_account_mgr_get_connection_specific_smtp): Make this code
327 * src/modest-runtime.h:
328 * src/modest-runtime.c:
329 Added modest_runtime_remove_all_send_queues().
330 * src/maemo/modest-main-window.c:
331 (on_account_store_connecting_finished): Recreate the send queues,
332 using the appropriate transport accounts for this new connection.
333 Some futher adapting might be needed if the old send queues are not
334 automatically stopped at this point.
336 * src/modest-tny-account-store.c: (get_server_accounts):
337 Create the connection-specific transport accounts, so that they can
338 be found later by their ID.
340 * src/modest-tny-account.h:
341 * src/modest-tny-account.c:
342 Added modest_tny_account_new_from_server_account_name().
343 modest_tny_account_new_from_server_account(): Do not create the
344 send queues here, because they will be
345 recreated anyway when the connection changes for the first time.
347 2007-05-28 Murray Cumming <murrayc@murrayc.com>
349 * src/modest-local-folder-info.h:
350 * src/modest-local-folder-info.c:
351 (modest_per_account_local_outbox_folder_info_get_maildir_path),
352 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
353 tbox_folder): Take a modest account name instead of a server TnyAccount,
354 so we can have per-modest-account rather than per-transport-account
356 We must make sure that we change or recreate the exisitng send queues
357 when the connection changes for connection-specific transport accounts.
359 * src/modest-tny-account-store.c:
360 (create_per_account_local_outbox_folders): Create outboxed per modest
361 account, not per transport account.
363 * src/modest-tny-account.h:
364 * src/modest-tny-account.c:
365 (modest_tny_account_get_special_folder): For outboxes, get the
366 parent modest account name. The account is ignored for other folders.
367 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
368 modest account name rather than a server TnyAccount.
370 2007-05-25 Murray Cumming <murrayc@murrayc.com>
372 * src/modest-tny-account.c:
373 (modest_tny_account_new_from_server_account):
374 Call modest_runtime_get_send_queue() immediately after creating transport
375 accounts, so that they start trying to send email from the outbox as soon
376 as possible at startup. This is probably what we want.
378 * src/modest-mail-operation.c: (update_account_thread):
379 * src/modest-runtime.c: (modest_runtime_get_send_queue):
380 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
381 * src/modest-tny-send-queue.h:
382 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
383 (modest_ui_actions_on_send):
384 Added comments about how sending works, though it needs some more work.
386 2007-05-25 Murray Cumming <murrayc@murrayc.com>
388 * src/modest-tny-account.c:
389 (modest_tny_account_get_special_folder): Add TODO because this fails when
391 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
392 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
393 Do not try to show this window when there is no active account. The UI
394 specs does not tell us what to do in this case.
396 2007-05-24 Murray Cumming <murrayc@murrayc.com>
400 * src/maemo/Makefile.am:
401 * src/widgets/Makefile.am: Some dist fixes.
403 2007-05-24 Murray Cumming <murrayc@murrayc.com>
405 * src/maemo/modest-connection-specific-smtp-window.c:
406 (on_button_edit): Make the code clearer, to prevent a double free.
408 2007-05-24 Murray Cumming <murrayc@murrayc.com>
410 * src/maemo/modest-account-settings-dialog.c:
411 (modest_account_settings_dialog_set_account_name),
412 Check the connection-specific smtp servers checkbox if there are any.
414 * src/maemo/modest-connection-specific-smtp-edit-window.c:
415 (modest_connection_specific_smtp_edit_window_init):
416 Start with a suitable port number.
418 * src/modest-account-mgr-helpers.h:
419 * src/modest-account-mgr-helpers.c: Added
420 modest_account_mgr_get_has_connection_specific_smtp().
422 (modest_account_mgr_set_connection_specific_smtp),
423 (modest_account_mgr_remove_connection_specific_smtp),
424 (modest_account_mgr_get_has_connection_specific_smtp),
425 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
426 connection-specific smtp server accounts in the account, rather than
427 the server account conf dir.
429 This fixes bug projects.maemo.org bug NB#58263 .
431 * src/modest-tny-account-store.c:
432 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
433 if there are no server accounts yet, to prevent an infinite loop when there
434 are no accounts. Document that one must be called before the other.
436 2007-05-24 Murray Cumming <murrayc@murrayc.com>
438 * src/modest-account-mgr-helpers.c:
439 (modest_account_mgr_get_default_account): Make sure that at least
440 one account is always the default, if there are any enabled accounts.
441 This is just a sanity check that shouldn't be necessary.
443 * src/modest-account-mgr-priv.c:
444 (_modest_account_mgr_account_from_key): Unescape the conf key to
445 get the real account name. For instance, this is an issue if a space
446 was in the account name, which can happen because the account name
447 is generated from the display name.
448 (_modest_account_mgr_get_account_keyname): Always escape the
450 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
451 Unescape the conf keys to get the real account names.
453 For instance, previously the is-default radio button in the accounts
454 list was not checked for any accounts at first. This fixes that,
455 and might fix several similar bugs.
457 2007-05-23 Murray Cumming <murrayc@murrayc.com>
459 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
460 Removed some debug printfs.
462 2007-05-23 Murray Cumming <murrayc@murrayc.com>
464 Modest on-disk outbox directories are now here, for instance:
465 $HOME/.modest/outboxes/<account-id-1>/outbox
466 $HOME/.modest/outboxes/<account-id-2>/outbox
468 $HOME/.modest/local-folders/outbox
469 so we can have a separate outbox for each account.
470 But they are shown as one outbox in the GtkTreeView, by using a
471 TnyMergeFolder in a ModestTnySimpleFolderStore.
474 * src/modest-tny-simple-folder-store.c:
475 * src/modest-tny-simple-folder-store.h:
476 Added ModestTnySimpleFolderStore, used to contain folders from
477 other folder stores, such as other accounts.
479 * src/modest-tny-outbox-account.h:
480 * src/modest-tny-outbox-account.c:
481 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
482 used for the per-account local outbox folders.
484 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
485 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
486 only use this (internally) now for the non-outbox local folders.
489 * src/modest-init.c: Added modest_init_one_local_folder(), for
490 setting up the directory structure for each local folder.
492 * src/modest-local-folder-info.c:
493 (modest_per_account_local_outbox_folder_info_get_maildir_path),
494 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
496 * src/modest-local-folder-info.h:
497 * src/modest-tny-account-store.c: (on_account_removed),
498 (on_account_changed), (create_per_account_local_outbox_folders),
499 (get_server_accounts), (modest_tny_account_store_get_accounts),
500 (modest_tny_account_store_get_tny_account_by_account),
501 (modest_tny_folder_store_is_virtual_local_folders):
503 * src/modest-tny-account.h:
504 * src/modest-tny-account.c:
505 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
506 to create an on-disk per-account local outbox folder for each
508 (create_per_account_local_outbox_folders): Create a local outbox folder
509 for each transport account.
510 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
511 for all local folders.
513 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
514 instead of using g_object_get/set() directly. It is clearer.
516 (modest_tny_folder_store_get_message_count),
517 (modest_tny_folder_store_get_local_size
518 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
519 because we now use these with non-acount folder stores.
521 (modest_tny_account_get_special_folder),
522 (modest_tny_account_new_from_server_account),
523 (modest_tny_account_new_from_account):
524 (recurse_folders): Adjust to the new outbox system.
526 * src/modest-tny-folder.h:
527 * src/modest-tny-folder.c:
528 (modest_tny_folder_is_local_folder),
529 (modest_tny_folder_get_local_folder_type),
530 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
532 * src/widgets/modest-main-window.h:
533 * src/maemo/modest-main-window.c: (create_details_widget),
534 (modest_main_window_set_contents_style): Show details for any folder store,
537 (modest_tny_folder_get_rules):
538 Remove the const. C does not support constness enough for this.
540 * src/modest-ui-actions.c:
541 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
542 make all outboxes appear as one, in the usual local-folders tree node.
544 (set_active_account_from_tny_account),
545 (modest_ui_actions_on_folder_selection_changed):
546 * src/widgets/modest-folder-view.c: (text_cell_data),
547 (icon_cell_data), (filter_row),
548 (add_account_folders_to_merged_folder),
549 (add_account_folders_to_simple_folder_store), (),
550 (get_cmp_rows_type_pos), (cmp_rows),
551 (modest_folder_view_set_account_id_of_visible_server_account):
552 Adjust to the new outbox system, using generic folder stores and folders
555 2007-05-23 Christian Kellner <ckellner@openismus.com>
557 * src/modest-mail-operation.c:
558 (modest_mail_operation_update_account):
559 Use info->max_size instead of unintialized local var [small
560 build fix]. (Added TODO to review that change since I don't
563 2007-05-23 Marcus Bauer <marcusb@openismus.com>
565 * libmodest-dbus-client/libmodest-dbus-client.c:
566 (libmodest_dbus_client_compose_mail): function added
567 * src/dbus_api/modest-dbus-api.h:
568 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
569 (on_compose_mail): Implementation of the SendAsMail functionality
571 2007-05-22 Murray Cumming <murrayc@murrayc.com>
573 * src/modest-account-mgr.c:
574 (modest_account_mgr_add_server_account): Set the secure-connection
575 conf key for transport accounts as well as store accounts. I don't know
576 why the if was there. For instance, this makes sure that we use SSL
577 for the gmail preset from the easysetup wizard.
579 2007-05-22 Murray Cumming <murrayc@murrayc.com>
581 * src/gnome/modest-main-window.c:
582 (on_account_store_connecting_finished), (connect_signals):
583 * src/maemo/modest-main-window.c:
584 (on_account_store_connecting_finished), (connect_signals),
585 (modest_main_window_new):
586 Handle TnyAccountStore::connecting-finished instead of
587 TnyDevice::connection-changed, because we cannot actually perform
588 operations on accounts until TnyAccountStore has itself responded to
589 the TnyDevice::connection-changed signal. This prevents a GError from
591 Do not try to update at startup, because we (at least on scratchbox)
592 already do an update at startup when the device goes online.
593 This prevents a GError from tinymail.
594 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
595 Added TODO about stopping simultaneous operations.
597 2007-05-21 Murray Cumming <murrayc@murrayc.com>
599 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
600 * src/modest-mail-operation-queue.c:
601 (modest_mail_operation_queue_remove):
602 * src/modest-tny-account-store.c: When GErrors happen, give more clues
603 about where they happened.
605 2007-05-21 Murray Cumming <murrayc@murrayc.com>
607 * src/modest-ui-actions.c:
608 (modest_ui_actions_on_password_requested): Make sure that the remember
609 output parameter is always TRUE.
611 2007-05-21 Murray Cumming <murrayc@murrayc.com>
613 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
614 Show a OK/Cancel dialog if the error is a question, though we still do not
615 know anything more about what we are asking the user.
616 * src/widgets/modest-folder-view.c: (on_drag_data_received):
617 Fix an uninitialized variable (helper). This is a logic error, however.
619 2007-05-21 Christian Kellner <ckellner@openismus.com>
621 * src/modest-search.h:
622 Correct bit shifting in the ModestSearchFlags enum.
624 2007-05-21 Murray Cumming <murrayc@murrayc.com>
626 * src/modest-tny-account.c:
627 (modest_tny_account_new_from_server_account): Do not use the lsub and
628 check-all hard-coded IMAP options when using POP.
630 2007-05-21 Murray Cumming <murrayc@murrayc.com>
632 * src/modest-tny-account.c:
633 (modest_tny_account_new_from_server_account):
634 Use NULL for the secure-auth method for POP when Password auth has been
635 specified by the user, as we already do for IMAP. "auth=Login" causes
636 an error from camel or the server.
638 2007-05-17 Murray Cumming <murrayc@murrayc.com>
640 * src/maemo/modest-account-settings-dialog.c:
641 (create_page_account_details),
642 (modest_account_settings_dialog_set_account_name):
643 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
644 for the leave-on-server checkbox, rathr than just the checkbox, when
645 the protocol is not POP.
647 2007-05-17 Murray Cumming <murrayc@murrayc.com>
649 * src/widgets/modest-account-view.c:
650 * src/widgets/modest-account-view.h:
651 Added modest_account_view_select_account() which will be useful later
652 to asynchronously re-select the edited account.
654 2007-05-17 Murray Cumming <murrayc@murrayc.com>
656 * src/maemo/modest-account-settings-dialog.c:
657 (modest_account_settings_dialog_set_account_name):
658 Automatically choose the port numbers based on the secure authentication
659 methods, if they have not been chosen before.
660 This fixes projects.maemo.org bug NB#56273 .
662 2007-05-17 Murray Cumming <murrayc@murrayc.com>
664 * src/maemo/modest-main-window-ui.h:
665 * src/modest-ui-actions.c:
666 * src/modest-ui-actions.h:
667 Connect the Tools/SMTP Servers menu item to
668 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
669 SMTP servers dialog, as in the UI specification and saves changes when it
670 is closed. This fixed projects.maemo.org bug NB#56305 .
672 2007-05-17 Murray Cumming <murrayc@murrayc.com>
674 * src/maemo/modest-connection-specific-smtp-window.c:
675 (modest_connection_specific_smtp_window_init):
676 Use gtk_window_set_default_size() to make this window big enough, so
677 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
679 2007-05-17 Murray Cumming <murrayc@murrayc.com>
681 * src/maemo/modest-connection-specific-smtp-edit-window.h:
682 * src/maemo/modest-connection-specific-smtp-edit-window.c:
683 (modest_connection_specific_smtp_edit_window_init),
684 Do not try to connect to a combobox signal before the combobox exists.
685 This fixes the cras in projects.maemo.org bug NB#56288 .
686 (modest_connection_specific_smtp_edit_window_get_settings):
687 Remove the server_account_name parameter which was being checked for NULL
688 though it was not used.
690 * src/maemo/modest-connection-specific-smtp-window.c:
691 (modest_connection_specific_smtp_window_fill_with_connections),
692 (on_button_edit), (modest_connection_specific_smtp_window_init):
693 Correct the number of treemodel columns to prevent a warning.
694 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
695 libconic does not work.
697 2007-05-16 Murray Cumming <murrayc@murrayc.com>
699 * src/modest-tny-account.c:
700 (modest_tny_account_new_from_server_account):
701 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
702 SMTP when "None" was chosen by the user. However, with my SMTP server that
703 does not support ANONYMOUS, the emails do not leave the Outbox and I see
706 2007-05-16 Murray Cumming <murrayc@murrayc.com>
708 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
709 to explain the memory management issue with the ID in the ModestPair.
711 * src/gnome/modest-account-assistant.c: (add_receiving_page),
712 (add_sending_page), (modest_account_assistant_finalize):
713 * src/gnome/modest-gnome-global-settings-dialog.c:
714 (create_updating_page), (create_composing_page):
715 * src/gnome/modest-msg-edit-window.c: (get_transports),
716 (init_window), (modest_msg_edit_window_finalize),
717 (modest_msg_edit_window_get_msg_data):
718 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
719 * src/gnome/modest-transport-widget.c:
720 (modest_transport_widget_finalize), (smtp_configuration):
721 * src/maemo/modest-maemo-global-settings-dialog.c:
722 (create_updating_page), (create_composing_page):
723 * src/maemo/modest-msg-edit-window.c: (get_transports),
724 (init_window), (modest_msg_edit_window_finalize),
725 (modest_msg_edit_window_get_msg_data),
726 (modest_msg_edit_window_free_msg_data):
727 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
728 (modest_store_widget_finalize):
729 * src/maemo/modest-transport-widget.c:
730 (modest_transport_widget_finalize), (smtp_configuration):
731 * src/modest-main.c: (send_mail):
732 * src/widgets/modest-combo-box.h:
733 * src/widgets/modest-global-settings-dialog-priv.h:
734 * src/widgets/modest-global-settings-dialog.c:
735 (modest_global_settings_dialog_finalize):
736 * src/widgets/modest-msg-edit-window.h:
737 Whenever using modest_combo_box_new(), keep the ModestPairList alive
738 as long as the combo box, to prevent use of freed memory for the ID.
740 2007-05-15 Murray Cumming <murrayc@murrayc.com>
742 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
743 get_accounts(), to make this clearer. Do not check for the enabled gconf
744 key, because we do not use this for server accounts (at least, not yet).
745 This allows us to send email again.
747 2007-05-15 Murray Cumming <murrayc@murrayc.com>
749 * src/maemo/modest-platform.c:
750 (on_modest_conf_update_interval_changed), (modest_platform_init):
751 Only respond to this particular key change. All these strcmp()s cannot be
754 2007-05-15 Murray Cumming <murrayc@murrayc.com>
756 * src/maemo/modest-maemo-global-settings-dialog.c:
757 (current_connection): Prevent a crash in scratchbox when
758 ny_maemo_conic_device_get_current_iap_id() returns NULL.
759 * src/maemo/modest-platform.c:
760 (on_modest_conf_update_interval_changed), (modest_platform_init):
761 Get the update interval from gconf and reset it when the gconf key changes.
763 2007-05-15 Murray Cumming <murrayc@murrayc.com>
765 * src/modest-protocol-info.c:
766 * src/modest-protocol-info.h: Adde enum-specific get functions,
767 instead of using a ModestProtocolType enum parameter.
769 * src/gnome/modest-account-assistant.c:
770 * src/gnome/modest-store-widget.c:
771 * src/gnome/modest-store-widget.h:
772 * src/gnome/modest-transport-widget.c:
773 * src/gnome/modest-transport-widget.h:
774 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
775 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
776 * src/maemo/easysetup/modest-easysetup-wizard.c:
777 * src/maemo/modest-account-settings-dialog.c:
778 * src/maemo/modest-account-settings-dialog.h:
779 * src/maemo/modest-store-widget.c:
780 * src/maemo/modest-store-widget.h:
781 * src/maemo/modest-transport-widget.c:
782 * src/maemo/modest-transport-widget.h:
783 * src/modest-account-mgr-helpers.c:
784 * src/modest-account-mgr-helpers.h:
785 * src/modest-account-mgr.c:
786 * src/modest-account-mgr.h:
787 * src/modest-tny-account.c:
788 * src/modest-tny-folder.c:
789 * src/widgets/modest-account-view.c:
790 * src/widgets/modest-retrieve-combo-box.c:
791 * src/widgets/modest-retrieve-combo-box.h:
792 * src/widgets/modest-secureauth-combo-box.c:
793 * src/widgets/modest-serversecurity-combo-box.c:
794 * src/widgets/modest-serversecurity-combo-box.h:
795 * tests/check_account-mgr.c:
796 Use the specific functions, and use the re-renamed enum values for GNOME too.
798 2007-05-15 Murray Cumming <murrayc@murrayc.com>
801 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
802 so we can get the second based on the first.
804 * src/maemo/modest-account-settings-dialog.h:
805 * src/maemo/modest-account-settings-dialog.c:
806 Added get_supported_secure_authentication_methods(), though it is mostly
807 commented-out for now until the necessary API is committed to tinymail.
808 (modest_account_settings_dialog_set_account_name),
809 (save_configuration): Request the supported authentication methods from the
810 server, so we can choose a working method.
812 * src/modest-tny-account-store.h:
813 * src/modest-tny-account-store.c:
814 (modest_tny_account_store_get_session): Rename from
815 tny_account_store_get_session().
817 2007-05-14 Murray Cumming <murrayc@murrayc.com>
819 * src/modest-protocol-info.h: Split the ModestProtocol enum
820 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
821 There was no need to have these unrelated values in one enum.
823 * src/: many files: Adapted to changed enum. This makes the code a bit
824 clearer, and the compiler could catch some errors.
826 2007-05-14 Murray Cumming <murrayc@murrayc.com>
828 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
829 Show the detailed internal camel error message when an error happens
830 during the configuration, so that our testers can give us more clues.
831 For instance, in projects.maemo.org bug NB#56910 .
833 2007-05-14 Murray Cumming <murrayc@murrayc.com>
835 * src/modest-tny-account.c:
836 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
837 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
839 2007-05-14 Murray Cumming <murrayc@murrayc.com>
841 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
842 * src/maemo/modest-account-settings-dialog.c:
843 (modest_account_settings_dialog_set_account_name),
844 (save_configuration): For the incoming secure authentication checkbox,
845 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
846 the UI specification. PLAIN does not seem to be supported for most IMAP
847 servers anyway, and I am not sure what it would mean.
848 However, we probably need to discover which of the secure-authentication
849 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
850 * src/modest-account-mgr-helpers.c:
851 (modest_account_mgr_get_server_account_data):
853 * src/modest-tny-account.c:
854 (modest_tny_account_new_from_server_account):
855 Use tny_account_set_mech() to set secure-authentication methods,
856 with some special-casing for IMAP, based on my observations of how
859 * src/modest-account-mgr-helpers.h:
860 * src/modest-account-mgr.c:
861 * src/modest-defs.h: Comment that the URI is only used for local folders.
863 2007-05-11 Murray Cumming <murrayc@murrayc.com>
865 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
866 parameter const, just to be neat.
867 * src/modest-text-utils.c: (modest_text_utils_inline):
868 End g_strconcat() with NULL, as its documentation says. This is almost
869 certainly the cause of my crash at startup on the device. Interestingly,
870 valgrind doesn't tell us about these errors.
872 2007-05-11 Murray Cumming <murrayc@murrayc.com>
874 * scripts/build-packages: Added more precise comments about how to use
875 this script, though I still get this error:
876 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
877 error building tinymail
879 2007-05-11 Murray Cumming <murrayc@murrayc.com>
881 * src/maemo/modest-main-window.c: (on_account_update):
882 Very slight cleanup, hoping to make it simpler to discover what causes
883 a crash here sometimes.
885 * src/modest-tny-account.c:
886 (modest_tny_account_new_from_server_account): Set the port. Added
887 comments about the options and a TODO comment because I need to find out
888 how to specify the secure authentication method.
890 2007-05-11 Marcus Bauer <marcusb@openismus.com>
892 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
893 changed CFlags paths form modest to libmodest
895 2007-05-10 Murray Cumming <murrayc@murrayc.com>
897 * src/modest-account-mgr-helpers.c:
898 (modest_account_mgr_get_server_account_data),
899 (modest_account_mgr_free_server_account_data):
900 * src/modest-account-mgr-helpers.h:
901 * src/modest-account-mgr.c:
902 (modest_account_mgr_add_server_account):
904 * src/modest-tny-account.c:
905 (modest_tny_account_new_from_server_account):
906 Determine the options for tny_camel_account_add_option() here,
907 based on the settings, rather than storing them directly in gconf.
909 2007-05-10 Murray Cumming <murrayc@murrayc.com>
911 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
912 Show a more friendly error dialog now that we expect (from the tinymail
913 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
915 2007-05-10 Murray Cumming <murrayc@murrayc.com>
917 * src/maemo/modest-main-window.c: (on_account_update): Check that
918 account_name is not NULL, to prevent a crash at startup that I am
919 seeing on the N800. I do wonder why it is NULL.
921 * src/maemo/easysetup/modest-easysetup-wizard.c:
922 (create_page_user_details):
923 * src/maemo/modest-account-settings-dialog.c:
924 (create_page_user_details), (create_page_outgoing):
925 * src/maemo/modest-connection-specific-smtp-edit-window.c:
926 (modest_connection_specific_smtp_edit_window_init):
927 * src/modest-ui-actions.c:
928 (modest_ui_actions_on_password_requested):
929 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
930 might do something useful with the on-screen keyboard.
932 2007-05-10 Murray Cumming <murrayc@murrayc.com>
934 * src/maemo/modest-main-window.c: (on_account_update):
935 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
936 NULL, to avoid lots of warnings. However, it probably should not be NULL.
938 2007-05-09 Murray Cumming <murrayc@murrayc.com>
940 * src/modest-tny-account-store.c: (on_account_changed):
941 Correct the signature of this signal handler.
943 2007-05-09 Murray Cumming <murrayc@murrayc.com>
945 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
946 Show a HildonNote instead of a GtkDialog for Maemo.
948 2007-05-09 Murray Cumming <murrayc@murrayc.com>
950 * src/widgets/modest-account-view.h:
951 * src/widgets/modest-account-view.c: (on_account_changed),
952 (on_account_removed). Added a boolean flag, set/unset by
953 modest_account_view_block_conf_updates(),
954 modest_account_view_unblock_conf_updates() to prevent unnecessary
955 updates, but this is not very useful because the gconf notifications are
956 so delays (maybe only on Maemo Bora).
957 So auto-updating is turned off, and these functions do an explicit
958 update when necessary.
959 However, something else is still doing too much work when adding/removing
960 accounts, probably in another part of the application.
962 * src/maemo/modest-account-view-window.c:
963 (on_delete_button_clicked), (on_edit_button_clicked),
964 (on_new_button_clicked): Use the new functions.
966 2007-05-09 Murray Cumming <murrayc@murrayc.com>
968 * src/modest-account-mgr-helpers.c:
969 (modest_account_mgr_set_first_account_as_default):
970 Sort the list of names alphabetically-by-title, so we choose the first one
972 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
973 alphabetically by the title.
975 This fixes projects.maemo.org bug NB#56418 .
977 * src/modest-account-mgr-priv.c:
978 (_modest_account_mgr_account_from_key):
979 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
980 avoid a valgrind error, and possible random behaviour.
982 2007-05-09 Murray Cumming <murrayc@murrayc.com>
984 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
985 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
986 tinymail documentation to say that this can be expected.
987 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
988 pretty, and should not happen, but I would prefer to know when it does.
990 2007-05-09 Murray Cumming <murrayc@murrayc.com>
992 * configure.ac: When using the older hildon version, probably on Bora,
993 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
995 * src/widgets/modest-attachment-view.c:
996 (modest_attachment_view_set_part_default): Initialize variables, to fix the
999 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1001 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1002 Implemented the prototype. Can be tested with
1003 tests/dbus_api/test_open_message:
1005 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1007 * src/modest-tny-account-store.c:
1008 (modest_tny_account_store_instance_init), (get_password):
1009 * src/modest-ui-actions.c:
1010 (modest_ui_actions_on_password_requested):
1011 Do not store the password in gconf, because this function is called
1012 for non-remembered passwords. Actually use the cached (in the hash map)
1013 password instead of releasing it.
1014 The password will now not be remembered if it is asked via the protected
1015 password dialog, as per the UI spec.
1017 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1019 * src/modest-defs.h:
1020 * src/modest-account-mgr-helpers.h:
1021 * src/modest-account-mgr-helpers.c:
1022 Added modest_server_account_get_username_has_succeeded(),
1023 modest_server_account_set_username_has_succeeded().
1024 (modest_server_account_set_username),
1025 Reset the has-succeeded flag if the username changes.
1027 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1028 * src/maemo/modest-connection-specific-smtp-window.c:
1029 (modest_connection_specific_smtp_window_save_server_accounts):
1030 Use modest_server_account_set_username() instead of using
1031 modest_conf_set_string() directly, so that the has-succeeded flag is always
1034 * src/modest-ui-actions.c:
1035 (modest_ui_actions_on_password_requested): Dim the username entry if
1036 the username has ever worked, as per the UI spec.
1038 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1040 * src/modest-tny-account-store.c: (get_password):
1041 * src/modest-ui-actions.c:
1042 (modest_ui_actions_on_password_requested):
1043 Allow the username to be changed too, though there is more work to
1044 be done on exactly how this behaves.
1046 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1048 * src/modest-account-mgr-helpers.h:
1049 * src/modest-account-mgr-helpers.c:
1050 Added modest_account_mgr_get_display_name(),
1051 modest_server_account_get_username(),
1052 modest_server_account_set_username(),
1053 modest_server_account_set_password(),
1054 modest_server_account_get_hostname() functions so we do not need to
1055 use the conf API directly.
1057 * src/maemo/modest-main-window.c: (connect_signals):
1058 Actually connect ot the ModestAccountStore::request-password signal,
1059 so that we show the dialog when the password is requested by Tinymail,
1060 for isntance if it is empty.
1062 * src/modest-marshal.list:
1063 * src/modest-tny-account-store.c:
1064 (modest_tny_account_store_class_init), (get_password),
1065 (modest_tny_account_store_alert):
1066 * src/modest-tny-account-store.h:
1067 * src/modest-ui-actions.h:
1068 * src/modest-ui-actions.c:
1069 (modest_ui_actions_on_password_requested):
1070 Change the signal parameters, so it is obvious that we are providing
1071 the non human-readable server name, and receiving both the username
1072 and password, though changing of the username is not yet implemented.
1073 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1074 for the GNOME version.
1076 This should fix the projects.maemo.org bug NB#56209, though it does not
1077 work on Bora, because the gconf_client_get() for the password fails
1078 immediately after we save it with gconf_client_set().
1080 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1083 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1084 caused an undefined symbol error:
1085 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1087 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1089 * src/modest-tny-account-store.c:
1090 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1091 using a GError instead of a string message, so we can translate it in
1094 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1096 * src/maemo/modest-address-book.c:
1097 (modest_address_book_check_names):
1098 * src/maemo/modest-msg-view-window.c:
1099 (modest_msg_view_window_clipboard_owner_change):
1100 * src/modest-init.c: (modest_init_init_ui):
1101 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1102 (update_folders_cb), (modest_mail_operation_update_account):
1103 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1104 (modest_ui_actions_on_msg_attachment_clicked),
1105 (modest_ui_actions_on_msg_recpt_activated):
1106 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1107 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1108 (modest_msg_view_search_next):
1109 * src/widgets/modest-recpt-editor.c:
1110 (modest_recpt_editor_on_button_release_event),
1111 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1112 g_message(). At this point we should only be seeing interesting errors on
1113 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1115 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1117 (modest_wizard_dialog_force_title_update):
1118 * src/maemo/easysetup/modest-wizard-dialog.h:
1119 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1120 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1121 can update the title when appropriate. Otherwise the title is wrong if the
1122 pages are added after adding the notebook to the dialog.
1123 This must be a problem in HildonWizardDialog too.
1124 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1126 * src/maemo/easysetup/modest-easysetup-wizard.c:
1127 (create_subsequent_customsetup_pages),
1128 (create_subsequent_easysetup_pages):
1129 Call modest_wizard_dialog_force_title_update() so that the title is
1130 correct even with GTK+ < 2.10.
1131 This fixes projects.maemo.org bug NB#56145 .
1133 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1135 * src/maemo/modest-platform.c:
1136 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1137 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1140 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1142 * src/widgets/modest-window.h:
1143 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1144 and modest_window_save_state(), which invokes it.
1146 * src/widgets/modest-window-mgr.h:
1147 * src/widgets/modest-window-mgr.c:
1148 Added modest_window_mgr_save_state_for_all_windows(), which calls
1149 the save_state vfunc on all registered windows, if implemented.
1151 * src/gnome/modest-msg-edit-window.c:
1152 * src/gnome/modest-msg-view-window.c:
1153 * src/maemo/modest-msg-edit-window.c:
1154 * src/maemo/modest-msg-view-window.c:
1155 * src/maemo/modest-main-window.c:
1156 Specify the existing save_settings functions as implementations of
1157 ModestWindow::save_state_func().
1159 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1160 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1161 enabling hibernation, for instance.
1163 We may need to do the same thing for restoring settings.
1166 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1168 * src/widgets/modest-window-mgr.c:
1169 * src/widgets/modest-window-mgr.h:
1170 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1171 modest_window_mgr_get_hibernation_is_prevented().
1173 * src/maemo/modest-main-window.c:
1174 (on_hildon_program_is_topmost_notify): Prevent hibernation
1175 (possible when the application goes to the background in the WM),
1176 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1178 * src/maemo/easysetup/modest-easysetup-wizard.c:
1179 (modest_easysetup_wizard_dialog_init):
1180 * src/maemo/modest-account-settings-dialog.c:
1181 (modest_account_settings_dialog_init):
1182 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1183 (modest_connection_specific_smtp_edit_window_init):
1184 * src/maemo/modest-connection-specific-smtp-window.c:
1185 (modest_connection_specific_smtp_window_init):
1186 * src/maemo/modest-signature-editor-dialog.c:
1187 (modest_signature_editor_dialog_init):
1188 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1189 prevent hibernation while any of these account settings dialogs are open.
1191 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1193 * src/maemo/Makefile.am:
1194 * src/maemo/modest-osso-state-saving.c:
1195 * src/maemo/modest-osso-state-saving.h: Added
1196 modest_osso_load_state() and modest_osso_save_state() though they do
1197 nothing now. They should iterate through all the open windows and load/save
1199 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1200 save state when closing.
1202 * src/maemo/modest-main-window.c:
1203 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1204 Add a notification handler for the HildonProgram::is-topmost property,
1205 so we can allow hibernation when the application goes into the background.
1206 But we still need to detect when the accounts setup windows are open so
1207 we can stop hibernation when they are open.
1208 To do this, I also added the main window the HildonProgram. This might have
1209 other side-effects/benefits, and should maybe be done for other windows.
1211 * src/maemo/modest-osso-autosave-callbacks.h:
1212 * src/maemo/modest-osso-autosave-callbacks.c:
1213 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1214 though it does not do anything yet, and we might never need this to do
1215 anything. For instance, we already save drafts.
1217 * src/maemo/modest-platform.c: (modest_platform_init):
1218 Specify the libosso auto-save callback.
1220 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1222 * src/maemo/modest-platform.c:
1223 (modest_platform_set_update_interval):
1224 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1225 aparently stays valid between application instances, so we can use this
1226 to remove and reset it later. According to a maemo-developers email from
1229 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1231 * configure.ac: Depend on libalarm for Maemo.
1233 * src/dbus_api/modest-dbus-api.h:
1234 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1235 (on_send_receive), (modest_dbus_req_handler):
1236 Handle a SEND_RECEIVE D-Bus method.
1238 * libmodest-dbus-client/libmodest-dbus-client.c:
1239 (libmodest_dbus_client_send_and_receive):
1240 * libmodest-dbus-client/libmodest-dbus-client.h:
1241 Add C convenience functions for calling the new D-Bus method.
1243 * src/modest-platform.h:
1244 * src/gnome/modest-platform.c:
1245 * src/maemo/modest-platform.c:
1246 Added modest_platform_set_update_interval(), which uses the
1247 alarmd API on Maemo.
1248 (modest_platform_init),
1249 Call modest_platform_set_update_interval(), using a hard-coded
1250 interval for now (until the global settings dialog is implemented),
1251 though I am not sure that this makes sense yet.
1253 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1255 * src/dbus_api/modest-dbus-callbacks.c:
1256 (modest_osso_cb_hw_state_handler):
1257 * src/dbus_api/modest-dbus-callbacks.h:
1258 * src/maemo/modest-platform.c: (modest_platform_init):
1259 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1260 in case this has some effect on the ability for Maemo to ping the
1263 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1265 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1266 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1267 warning. It is probably a logic error, but I need to fix the build.
1269 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1271 * src/modest-account-mgr.h:
1272 * src/modest-account-mgr.c:
1273 (modest_account_mgr_account_names): Add a gboolean enabled_only
1274 parameter, so we can get lists of onlt the enabled accounts.
1276 (modest_account_mgr_add_account),,
1277 (modest_account_mgr_account_with_display_name_exists):
1278 * src/maemo/modest-msg-edit-window.c: (get_transports):
1279 * src/modest-account-mgr-helpers.c:
1280 (modest_account_mgr_set_first_account_as_default):
1281 * src/modest-init.c: (init_default_account_maybe):
1282 * src/modest-tny-account-store.c: (get_accounts):
1283 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1284 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1285 * tests/check_account-mgr.c: (START_TEST):
1286 Provide the extra parameter, as appropriate.
1288 * src/widgets/modest-account-view.c: (update_account_view):
1289 Do not show disabled accounts (meaning that there is no way to
1290 enable/disable accounts in the UI (the feature is not in our UI
1291 specification), so we can use this internally only to mark unfinished
1292 or temporary account data.
1294 * src/maemo/easysetup/modest-easysetup-wizard.c:
1295 (create_account): Add boolean enable parameter, so we can specify FALSE
1296 to create the temporary account.
1297 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1298 (on_before_next): When finishing, when there is a temporary account, just
1300 Also, use a timeout to delay the showing of the dialog until gconf is likely
1301 to return correct information, due to a maemo gconf bug that is fixed in
1302 osso 1.1, but not yet in Bora.
1303 However, the dialog stays on screen after it is destroyed.
1305 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1306 for invalid data when cancelling. Use a hildon note instead of a dialog
1307 to complain about invalid data. Do not show the account-saved note if the
1308 account is disabled (a temporary account that will not really be saved for use
1311 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1313 * src/modest-account-mgr-helpers.h:
1314 * src/modest-account-mgr-helpers.c:
1315 Added modest_account_mgr_unset_default_account(),
1316 Added modest_account_mgr_set_first_account_as_default().
1318 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1319 If it was the default account, unset the default account name.
1321 * src/maemo/modest-account-view-window.c:
1322 (on_delete_button_clicked): If it was the default account,
1323 set the first remaining account as the default instead.
1325 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1326 a NULL account or a NULL default account, to prevent a crash. This should
1327 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1330 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1332 * src/widgets/modest-recpt-editor.c:
1333 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1334 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1335 TODO comment for this. This fixes the build.
1337 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1338 be the best place for it. This will in future update all auto-update accounts,
1339 rather than just the current/default account, when that gconf key exists.
1340 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1341 if there are no accounts, before calling do_send_receive().
1342 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1344 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1345 * src/maemo/modest-main-window-ui.h:
1346 * src/maemo/modest-main-window.c: (on_connection_changed),
1347 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1348 directly, becaue the signal handler does more.
1350 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1352 * src/modest-account-mgr-helpers.c:
1353 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1354 for the case that the account does not exist.
1356 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1357 (equivalent to the modest account name) rather than the tinymail account name
1358 (equivalent to the modest account title - human readable) to get the account data.
1359 Check for null account data to prevent the crash, and add a TODO comment saying that
1360 this needs fixing because it is using the server account name instead of the account name.
1362 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1364 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1365 * src/maemo/modest-account-settings-dialog.c: (show_error),
1367 Use hildon_note_new_information() for informative and error messages,
1368 which seems to be expected for Maemo applications (no documentation that I know of
1369 says this). I am surprised that there is no distinction between info and error
1372 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1374 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1375 it is easy to find where this is used.
1377 * src/maemo/easysetup/modest-easysetup-wizard.c:
1378 (create_page_welcome), (create_page_account_details),
1379 (create_page_user_details), (create_page_complete_easysetup),
1380 (create_page_custom_incoming), (create_page_custom_outgoing),
1381 (create_page_complete_custom):
1382 * src/maemo/modest-account-settings-dialog.c:
1383 (create_page_account_details), (create_page_user_details),
1384 (create_page_incoming), (create_page_outgoing):
1385 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1386 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1387 (modest_connection_specific_smtp_edit_window_init):
1388 * src/maemo/modest-connection-specific-smtp-window.c:
1389 (modest_connection_specific_smtp_window_init):
1390 * src/maemo/modest-signature-editor-dialog.c:
1391 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1392 and scrolling policy as per the Email Application Layout Guide, if I have
1395 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1397 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1398 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1399 which were empty, because these vfuncs have been removed from TnyAccountStore.
1400 This fixes the build.
1402 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1404 * src/maemo/modest-main-window.c:
1405 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1406 showing/hiding it. Added TODO because it probably should not be NULL.
1407 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1408 because unnecessary g_warnings() make degugging difficult.
1410 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1412 * src/maemo/modest-msg-edit-window.c:
1413 (modest_msg_edit_window_select_color),
1414 (modest_msg_edit_window_select_background_color): 2 const corrections and
1415 moving 2 #endifs before closing brackets, to fix the build.
1417 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1419 * src/maemo/easysetup/modest-easysetup-wizard.h:
1420 * src/maemo/easysetup/modest-easysetup-wizard.c:
1421 (modest_easysetup_wizard_dialog_finalize),
1422 (on_button_edit_advanced_settings), (create_page_complete_custom),
1423 (on_response), (create_account):
1424 Implement the Advanced Settings edit button, by saving the account information,
1425 for the Advanded Settings dialog to use directly from gconf, and removing it
1426 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1427 Bug #5533 in the projects.maemo.org bugzilla.
1429 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1431 * src/maemo/modest-msg-view-window.c:
1432 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1433 when opening a message window.
1435 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1437 * src/maemo/easysetup/modest-easysetup-wizard.c:
1438 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1441 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1442 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1443 gconf settings. I probably added more checks than necessary, but that is safer.
1445 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1446 variable to fix the build, but this seems to be used when it is still NULL.
1448 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1450 * src/modest-platform.h:
1451 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1452 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1453 * src/modest-main.c: Implement this function so we can avoid using
1454 maemo-specific API from cross-platform code.
1456 * src/modest-tny-account-store.c:
1457 (get_smtp_specific_transport_account_for_open_connection):
1458 * src/modest-ui-actions.c: (check_for_connection),
1459 (modest_ui_actions_on_item_not_found):
1460 Use modest_platform_connect_and_wait() and put #idefs around other
1461 maemo-specific code, because only maemo currently has a way to
1462 identify connection names.
1464 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1466 * src/modest-tny-account-store.h:
1467 * src/modest-tny-account-store.c:
1468 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1469 the connection-specific SMTP server settings in the configuration.
1471 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1473 * src/maemo/modest-main-window.c: (on_connection_changed),
1475 * src/modest-main.c: (main), (start_ui), (send_mail):
1476 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1477 that is what is intended.
1479 * src/modest-ui-actions.c: (action_send), (action_receive),
1480 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1481 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1482 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1483 SMTP server is used when it is specified.
1485 (modest_ui_actions_on_send_receive):
1486 Check that a connection is open before proceeding.
1487 Receive and then send, instead of vice-versa, as per the specification.
1489 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1491 * src/modest-mail-operation.c:
1492 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1493 though I guess it should be something other than NULL.
1495 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1497 * src/maemo/easysetup/modest-easysetup-wizard.c:
1498 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1499 combo twice, to avoid an g_warning and to make it visible again.
1500 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1501 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1502 (already intended) dereference when detaching, because we then recreate the menu.
1503 But I am not sure why the warning was happening, and it is possible that this is a memory
1506 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1508 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1509 and uri_parse_mailto() utility functions.
1510 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1512 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1514 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1516 * src/dbus_api/modest-dbus-api.h:
1517 * src/dbus_api/modest-dbus-callbacks.c:
1518 Use an idle callback to execute the modest code in the application's own thread.
1519 Remove the helloworld example method.
1520 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1521 parsed, and the open-message method is not implemented because this is not yet implemented in
1523 * libmodest-dbus-client/libmodest-dbus-client.c:
1524 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1525 (libmodest_dbus_client_open_message):
1526 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1528 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1529 body without crashing.
1531 * tests/dbus_api/Makefile.am:
1532 * tests/dbus_api/test_mail_to.c:
1533 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1535 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1537 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1538 Added file to fix the build. Sorry.
1540 * src/dbus_api/Makefile.am:
1541 * src/dbus_api/modest-dbus-api.h:
1542 * src/dbus_api/modest-dbus-callbacks.h:
1543 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1544 (modest_dbus_req_handler):
1545 Put constants in a separate header so it can be reused by the
1546 client library, without duplication
1548 * libmodest-dbus-client/Makefile.am:
1549 * libmodest-dbus-client/libmodest-dbus-client.c:
1550 (libmodest_dbus_client_call_helloworld),
1551 (libmodfest_dbus_client_send_mail),
1552 (libmodfest_dbus_client_mailto),
1553 (libmodfest_dbus_client_open_message):
1554 * libmodest-dbus-client/libmodest-dbus-client.h:
1555 (Partly) Implement a send_mail D-Bus method.
1557 * tests/dbus_api/Makefile.am:
1558 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1559 the send_email D-Bus method.
1561 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1565 * libmodest-dbus-client/Makefile.am:
1566 * libmodest-dbus-client/libmodest-dbus-client.c:
1567 * libmodest-dbus-client/libmodest-dbus-client.h:
1568 * tests/dbus_api/Makefile.am:
1569 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1570 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1572 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1574 * src/maemo/easysetup/modest-easysetup-wizard.c:
1575 (create_page_account_details):
1576 * src/maemo/modest-account-settings-dialog.c:
1577 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1578 widgets, because this might not be the default in future versions of the Maemo GTK+.
1579 However, I can not not get capitalization to work even in a simple test case.
1581 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1583 * src/maemo/easysetup/modest-easysetup-wizard.c:
1584 (create_page_custom_incoming), (create_page_custom_outgoing):
1585 * src/maemo/modest-account-settings-dialog.c:
1586 (create_page_account_details), (create_page_incoming),
1587 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1588 instead of using gtk_check_button_with_label(), so they are aligned like the other
1589 widgets, as per the UI spec.
1591 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1593 * src/maemo/easysetup/modest-easysetup-wizard.c:
1594 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1595 * src/widgets/modest-validating-entry.c:
1596 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1597 Modest prefix instead of an EasySetup prefix.
1599 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1601 * src/widgets/modest-validating-entry.h:
1602 * src/widgets/modest-validating-entry.c: (on_insert_text),
1603 Added easysetup_validating_entry_set_max_func(), used to set a callback
1604 to call when the max number of characters is reached. GtkEntry has a max-length
1605 already but is silent about it.
1607 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1608 (create_page_account_details), (create_page_user_details),
1610 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1611 (create_page_account_details), (create_page_user_details),
1612 (create_page_outgoing):
1613 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1614 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1615 the UI spec, when the user tries to enter more than the max number of characters.
1617 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1619 * src/maemo/easysetup/modest-easysetup-wizard.c:
1620 (create_page_user_details), (create_page_custom_incoming),
1621 (create_page_custom_outgoing):
1622 * src/maemo/modest-account-settings-dialog.c:
1623 (create_page_user_details), (create_page_incoming),
1624 (create_page_outgoing):
1625 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1626 (modest_connection_specific_smtp_edit_window_init):
1627 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1628 not appropriate. Bad Maemo-specific defaults!.
1630 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1632 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1633 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1634 (modest_signature_editor_dialog_set_settings):
1635 Disable the label and textview when the checkbox is disabled, and use the
1636 specified (UI spec) default signature text.
1638 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1640 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1641 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1643 * src/modest-defs.h:
1644 * src/modest-account-mgr-helpers.h:
1645 * src/modest-account-mgr-helpers.c:
1646 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1648 * src/maemo/Makefile.am:
1649 * src/maemo/modest-signature-editor-dialog.c:
1650 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1653 * src/maemo/modest-account-settings-dialog.h:
1654 * src/maemo/modest-account-settings-dialog.c:
1655 (modest_account_settings_dialog_finalize), (on_button_signature),
1656 (save_configuration): Use the new dialog when the Edit button is pressed, and
1657 save the changes if necessary, as per the UI spec.
1659 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1661 * src/maemo/Makefile.am:
1662 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1663 based on maemo-develoers email from Dirk.
1665 * src/maemo/easysetup/modest-easysetup-wizard.c:
1666 (create_page_welcome), (create_page_account_details),
1667 (create_page_user_details), (create_page_complete_easysetup),
1668 (create_page_custom_incoming), (create_page_custom_outgoing),
1669 (create_page_complete_custom),
1670 (modest_easysetup_wizard_dialog_init):
1671 * src/maemo/modest-account-settings-dialog.c:
1672 (create_page_account_details), (create_page_user_details),
1673 (create_page_incoming), (create_page_outgoing),
1674 (modest_account_settings_dialog_init):
1675 * src/maemo/modest-connection-specific-smtp-window.c:
1676 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1678 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1680 * src/maemo/easysetup/modest-easysetup-wizard.c:
1681 (create_page_account_details), (create_page_custom_outgoing),
1682 (create_page_complete_custom):
1683 * src/maemo/modest-account-settings-dialog.c:
1684 (create_page_user_details), (create_page_incoming),
1685 (create_page_outgoing):
1686 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1687 (modest_connection_specific_smtp_edit_window_init):
1688 Use the correct (UI spec) port min/max, and use horizontal separators,
1691 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1693 * src/maemo/easysetup/modest-easysetup-wizard.c:
1694 (set_default_custom_servernames):
1695 * src/maemo/modest-account-settings-dialog.c:
1696 (create_page_incoming), (on_combo_outgoing_security_changed),
1697 (on_combo_incoming_security_changed), (create_page_outgoing),
1698 (modest_account_settings_dialog_set_account_name),
1699 (save_configuration):
1700 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1701 (on_combo_security_changed),
1702 (modest_connection_specific_smtp_edit_window_init),
1703 (modest_connection_specific_smtp_edit_window_set_connection),
1704 (modest_connection_specific_smtp_edit_window_get_settings):
1705 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1708 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1711 * src/maemo/easysetup/modest-easysetup-wizard.c:
1712 (create_page_custom_outgoing), (create_page_complete_custom):
1713 * src/maemo/modest-account-settings-dialog.c:
1714 (create_page_user_details), (create_page_outgoing):
1715 * src/maemo/modest-account-view-window.c: (button_box_new):
1716 Use changed logical IDs as per the most recent UI spec:
1717 mcen_bd_emailsetup_edit -> mcen_bd_edit
1718 mcen_bd_emailsetup_delete -> mcen_bd_delete
1719 mcen_bd_emailsetup_close -> mcen_bd_close
1721 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1725 * src/dbus_api/Makefile.am:
1726 * src/dbus_api/modest-dbus-callbacks.c:
1727 * src/dbus_api/modest-dbus-callbacks.h:
1728 * src/maemo/modest-platform.c: (modest_platform_init):
1729 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1731 * tests/Makefile.am:
1732 * tests/dbus_api/Makefile.am:
1733 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1735 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1737 * src/maemo/modest-account-settings-dialog.c:
1738 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1739 Removed unnecessary includes.
1741 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1743 * src/maemo/easysetup/modest-easysetup-wizard.c:
1744 * src/maemo/modest-account-settings-dialog.c:
1745 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1746 * src/widgets/Makefile.am:
1747 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1748 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1749 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1750 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1751 * src/widgets/modest-secureauth-combo-box.c:
1752 * src/widgets/modest-secureauth-combo-box.h:
1753 * src/widgets/modest-serversecurity-combo-box.c:
1754 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1755 made the GObject names more consistent with the rest of the Modest code.
1757 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1759 * src/maemo/easysetup/Makefile.am:
1760 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1761 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1762 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1763 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1764 * src/maemo/easysetup/modest-easysetup-wizard.c:
1765 * src/maemo/easysetup/modest-validating-entry.c:
1766 * src/maemo/easysetup/modest-validating-entry.h:
1767 * src/maemo/modest-account-settings-dialog.c:
1768 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1769 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1770 widgets/ because they are used outside of easysetup too. After checking in,
1771 svn will allow me to rename them too.
1773 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1775 * src/gnome/modest-msg-edit-window.c:
1776 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1777 linker error, to fix the build on the GNOME platform.
1778 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1779 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1780 ifdefed out to avoid a warning.
1782 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1784 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1785 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1786 some alternative for GTK+ 2.6.
1788 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1790 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1792 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1793 specified for EmailAccountsDialog in UI spec.
1795 * src/maemo/easysetup/modest-easysetup-wizard.c:
1796 * src/maemo/easysetup/modest-easysetup-wizard.h:
1797 * src/maemo/modest-account-settings-dialog.c:
1798 * src/maemo/modest-account-settings-dialog.h:
1799 Reuse a member window widget for the connection-specific SMTP server accounts,
1800 so we can tell it to create/save the accounts only if we actually save changes.
1802 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1803 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1804 (modest_connection_specific_smtp_edit_window_get_settings):
1805 Return a struct instance for temporarily remembering the entered data.
1807 * src/maemo/modest-connection-specific-smtp-window.h:
1808 * src/maemo/modest-connection-specific-smtp-window.c:
1809 (modest_connection_specific_smtp_window_finalize),
1810 (modest_connection_specific_smtp_window_fill_with_connections),
1812 (modest_connection_specific_smtp_window_save_server_accounts),
1813 (update_model_server_names): Do not actually save data until asked,
1814 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1816 (on_selection_changed),
1817 (modest_connection_specific_smtp_window_init): Disable the edit
1818 button when nothing is selected.
1820 * src/modest-account-mgr-helpers.c:
1821 * src/modest-account-mgr-helpers.h:
1822 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1825 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1827 * src/modest-account-mgr-helpers.h:
1828 * src/modest-account-mgr-helpers.c:
1829 (modest_account_mgr_get_unused_account_name),
1830 (modest_account_mgr_get_unused_account_display_name): Added these
1831 utility functions, to avoid code duplication.
1833 * src/maemo/easysetup/modest-easysetup-wizard.c:
1834 (create_page_account_details), (create_account):
1835 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1836 (on_combo_security_changed),
1837 (modest_connection_specific_smtp_edit_window_init),
1838 (modest_connection_specific_smtp_edit_window_save_settings):
1839 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1840 * src/maemo/modest-connection-specific-smtp-window.c:
1841 (modest_connection_specific_smtp_window_finalize),
1842 (modest_connection_specific_smtp_window_fill_with_connections),
1843 (on_button_edit), (modest_connection_specific_smtp_window_init):
1844 * src/maemo/modest-connection-specific-smtp-window.h:
1845 Implementing saving of connection-specific server accounts.
1847 But I need to refactor this so we can save the data for each
1848 possible connection-specific account and only actually create the server accounts
1849 when the easysetup finished, or the OK button is pressed on the account settings
1852 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1854 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1855 (on_combo_security_changed):
1856 (modest_connection_specific_smtp_edit_window_init):
1857 Auto-fill the port number as in the account settings.
1859 (modest_connection_specific_smtp_edit_window_set_connection):
1860 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1861 * src/maemo/modest-connection-specific-smtp-window.c:
1862 (fill_with_connections), (on_button_edit),
1863 (modest_connection_specific_smtp_window_init):
1864 Turn the edit window into a dialog to simplify the code, and
1865 set a WM hint as in a GtkDialog, because only a popup can be on top of
1866 another window in Maemo, and popups usually have no WM decoration.
1868 * src/modest-defs.h:
1869 * src/modest-account-mgr-helpers.c:
1870 (modest_account_mgr_set_connection_specific_smtp),
1871 (modest_account_mgr_remove_connection_specific_smtp),
1872 (modest_account_mgr_get_connection_specific_smtp):
1873 * src/modest-account-mgr-helpers.h: Some functions to write the
1874 connection-specific SMTP server information. Not yet used.
1877 * src/widgets/modest-folder-view.c: (text_cell_data):
1878 Fix a warning about an uninitialized variable.
1879 (on_configuration_key_changed): Put an #ifdef around the use
1880 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1882 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1884 * src/maemo/modest-account-settings-dialog.h:
1885 * src/maemo/modest-account-settings-dialog.c:
1886 Added connect_for_modified() utility function to mark the new modified boolean.
1888 (create_page_account_details), (create_page_user_details),
1889 (create_page_incoming), (create_page_outgoing), (on_response),
1890 (modest_account_settings_dialog_init),
1891 (modest_account_settings_dialog_set_account_name):
1892 Only warn about unsaved changes when there are actually unsaved changes.
1894 * src/modest-account-mgr-helpers.c:
1895 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1896 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1897 to get the data from there in future.
1899 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1901 * src/modest-defs.h:
1903 * src/modest-account-mgr-helpers.h:
1904 * src/modest-account-mgr-helpers.c:
1905 Store the security account setting in a single conf key instead of using
1906 the options list, so that the list is left for just the to-be-removed camel hack,
1907 and because gconf_client_set_list() is failing for some reason.
1909 * src/modest-account-mgr.c:
1910 (modest_account_mgr_add_server_account):
1911 * src/maemo/modest-account-settings-dialog.c:
1912 (modest_account_settings_dialog_set_account_name),
1913 (save_configuration): Use the renamed functions.
1916 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1918 * src/widgets/Makefile.am:
1919 * src/widgets/modest-limit-retrieve-combo-box.c:
1920 * src/widgets/modest-limit-retrieve-combo-box.h:
1921 * src/widgets/modest-retrieve-combo-box.c:
1922 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1923 the account settings dialog.
1925 * src/modest-defs.h:
1926 * src/modest-account-mgr-helpers.h:
1927 * src/modest-account-mgr-helpers.c:
1928 (modest_server_account_get_option_secure_auth),
1929 (modest_server_account_set_option_secure_auth):
1930 * src/modest-account-mgr.c:
1931 (modest_account_mgr_add_server_account):
1932 Use the existing AUTH_MECH conf key for the secure-auth setting,
1933 instead of putting it in the list options, because this was actually used already.
1935 * src/maemo/modest-account-settings-dialog.c:
1936 (create_page_account_details),
1937 (modest_account_settings_dialog_set_account_name),
1938 (save_configuration):
1939 * src/maemo/modest-account-settings-dialog.h:
1940 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1941 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1943 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1945 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1946 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1947 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1949 * src/modest-defs.h:
1950 * src/maemo/modest-account-settings-dialog.c:
1951 (create_page_incoming), (on_combo_outgoing_security_changed),
1952 (on_combo_incoming_security_changed), (create_page_outgoing),
1953 (modest_account_settings_dialog_set_account_name),
1954 (save_configuration): Load/Save the port number, and change it when the
1955 security combo changes, to suitable defaults.
1957 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1959 * src/modest-account-mgr.c:
1960 (modest_account_mgr_add_server_account): Set the security and secure-auth
1961 options, and add a comment saying that the other camel-specific options should be
1964 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1966 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1968 * src/modest-tny-account-store.c: (account_list_free),
1969 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1970 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1973 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1975 * src/modest-protocol-info.c:
1976 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1977 is required by our UI spec. Maybe something in our implementation will use this eventually.
1978 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1979 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1980 instead of the previous 0 placeholder.
1982 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1983 secure-auth settings.
1984 * src/modest-account-mgr-helpers.h:
1985 * src/modest-account-mgr-helpers.c:
1986 (modest_server_account_data_get_option_secure_auth),
1987 (modest_server_account_set_option_secure_auth),
1988 (modest_server_account_data_get_option_security),
1989 (modest_server_account_set_option_security): Added this API for getting and setting the security
1990 and secure-auth settings.
1992 * src/maemo/modest-account-settings-dialog.h:
1993 * src/maemo/modest-account-settings-dialog.c:
1994 (modest_account_settings_dialog_finalize), (check_data),
1995 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1996 about changing titles.
1997 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1998 (save_configuration): Save the security and secure-auth settings.
2000 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2001 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2003 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2005 * src/modest-defs.h:
2006 * src/modest-account-mgr.c:
2007 (modest_account_mgr_add_server_account):
2008 Added and used defines for the options key and value pair strings,
2009 that are used so far, though they do not seem to correspond to anything in our
2010 UI specs or ModestProtocol enum.
2012 * src/modest-account-mgr-helpers.h:
2013 * src/modest-account-mgr-helpers.c:
2014 (compare_option_strings_for_name),
2015 (modest_server_account_data_get_option_value),
2016 (modest_server_account_data_get_option_bool),
2017 (modest_account_mgr_get_server_account_option):
2018 Added helper functions for parsing the options GSList.
2020 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2022 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2023 display name is based on the supplied account name.
2024 * src/modest-account-mgr.c:
2025 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2026 with an inefficient, but good-enough, implementation.
2028 * src/maemo/easysetup/modest-easysetup-wizard.c:
2029 (create_page_account_details), (on_before_next), (create_account):
2030 Check for existing display names rather than (non-user-visible) account names, and just
2031 create and set a unique account name at the end.
2033 * src/maemo/modest-account-settings-dialog.c:
2034 (modest_account_settings_dialog_init),
2035 (modest_account_settings_dialog_set_account_name),
2036 (create_page_incoming): Show the display name, instead of the account name.
2037 (on_response): Do some (not all) extra checks, as in the UI spec.
2038 (save_configuration): Save the display name if it was changed.
2040 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2042 * po/en_GB.po: Added needed logical ID and translation.
2043 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2044 (init_view): Made the is-default column clicking work.
2046 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2049 * src/maemo/easysetup/Makefile.am:
2050 * src/maemo/easysetup/modest-easysetup-wizard.c:
2051 (modest_easysetup_wizard_dialog_init):
2052 * src/maemo/easysetup/provider-data-test.keyfile:
2053 * src/maemo/easysetup/provider-data.keyfile:
2054 Moved the provider data file to the new modest-providers-data package and used it from there.
2056 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2058 * src/modest-local-folder-info.c:
2059 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2060 N_() was already used on the static strings, but this just marks it for translation without
2061 using the translation.
2063 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2065 * src/maemo/modest-account-settings-dialog.c:
2066 (create_page_incoming),
2067 (modest_account_settings_dialog_set_account_name):
2068 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2069 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2070 I will do this if nobody else gets there first.
2072 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2074 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2075 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2076 save the security stuff.
2078 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2080 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2081 Set the email address and user fullname, which I now see must be
2084 * src/maemo/modest-account-settings-dialog.h:
2085 * src/maemo/modest-account-settings-dialog.c:
2087 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2088 leave-on-server and authentication.
2089 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2092 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2095 * src/maemo/modest-account-settings-dialog.c:
2096 * src/maemo/modest-account-settings-dialog.h:
2097 Most (but not all) of the widgets are now present as specified by the UI spec.
2098 No changes are yet saved, and some details are not properly shown yet.
2100 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2102 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2104 * src/maemo/Makefile.am:
2105 * src/maemo/modest-account-settings-dialog.c:
2106 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2107 an existing account. Doesn't do much yet.
2109 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2110 Open the accounts settings dialog when Edit is clicked.
2112 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2114 * src/maemo/easysetup/Makefile.am:
2115 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2117 * src/maemo/easysetup/modest-easysetup-wizard.c:
2118 (modest_easysetup_wizard_dialog_init):
2119 Try to get the source directory from the build system,
2120 instead of hard-coding "./" into the source code, when opening our local
2121 copies of the configuration files.
2122 But this still fails when opening the wizard from the Accounts window,
2123 maybe because the working directory seems to change at runtime.
2124 So the wizard will fail the second time unless you copy the files into their
2125 proper locations - see the stdout warnings for the paths.
2127 (create_page_account_details),(on_before_next):
2128 Check for existing non-server accounts instead of server accounts,
2129 so the default account name is useful again, and to prevent trying to
2132 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2133 Show the wizard when New is clicked.
2135 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2136 (init_view): Show the column headers, and show the columns that are
2137 specified in the UI specs. However, something in Maemo's GTK+ prevents
2138 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2139 change the default account. This is despite unsetting the special properties.
2141 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2143 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2144 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2145 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2146 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2147 to make that clearer.
2148 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2150 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2152 * src/maemo/modest-account-view-window.c:
2153 (modest_account_view_window_init),
2154 (modest_account_view_window_new):
2155 Use the same buttons as specified in the
2156 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2157 the existing widgets, which never had a chance of working.
2158 Put the ModestAccountView treeview in a scrolled window.
2159 Do not repeat the initialization in both _init() and _new().
2161 * src/widgets/modest-account-view.c: (update_account_view):
2162 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2163 this widget and window shows no accounts.
2165 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2167 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2169 * src/maemo/easysetup/modest-easysetup-wizard.c:
2170 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2171 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2172 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2175 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2176 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2177 accounts exist yet, as in the UI spec.
2179 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2181 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2183 * src/maemo/Makefile.am:
2184 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2185 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2186 New window for editing connection-specific smtp details.
2187 Not fully implemented.
2189 * src/maemo/modest-connection-specific-smtp-window.c:
2190 (modest_connection_specific_smtp_window_finalize) :
2191 unref the tree model.
2192 (on_button_edit): Show the edit window.
2194 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2196 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2199 * src/maemo/Makefile.am:
2200 * src/maemo/modest-connection-specific-smtp-window.c:
2201 * src/maemo/modest-connection-specific-smtp-window.h:
2202 New window for showing the list of connections, for connection-specific
2203 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2204 * src/maemo/easysetup/modest-easysetup-wizard.c:
2205 (create_page_custom_outgoing): Show the new window when the button is clicked.
2207 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2209 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2210 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2211 * src/maemo/modest-msg-edit-window.c:
2212 (modest_msg_edit_window_insert_image):
2213 * src/modest-conf.c: (modest_conf_key_escape):
2214 * src/modest-mail-operation.c:
2215 (modest_mail_operation_send_new_mail):
2216 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2217 (modest_ui_actions_on_new_account):
2218 * src/widgets/modest-attachment-view.c: (update_filename_request):
2219 * src/widgets/modest-mail-header-view.c:
2220 Corrected warnings that were breaking the build, by commenting out unused variables,
2221 and a function, and by including a header.
2223 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2225 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2226 so we can #ifdef around platform-specific code when necessary.
2227 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2228 to allow this to build for the GNOME platform too.
2230 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2232 * src/maemo/easysetup/modest-easysetup-wizard.c:
2233 Added util_increment_name() and used it in create_page_account_details()
2234 to make sure that the default account name is always a new name.
2236 (modest_easysetup_wizard_dialog_init),
2237 (set_default_custom_servernames): Some minor memory management fixes.
2239 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2243 * src/modest-runtime.c: (init_i18n): Restored the translation
2244 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2245 are defined in config.h, and the translations are installed.
2247 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2248 is defined for translation.
2250 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2252 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2254 * src/maemo/easysetup/modest-easysetup-wizard.c:
2255 (modest_easysetup_wizard_dialog_init):
2256 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2257 Use realistic paths (though they should use $prefix generically) to the
2258 mcc_mapping and provider-data.keyfile files which might work when they
2259 are installed by the future version of the operator-wizard package,
2260 and then fallback to paths in our source code, with an explanatory
2263 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2267 * src/maemo/Makefile.am:
2268 * src/maemo/easysetup/: Added files from the previously-exernal
2269 osso-modest-easysetup.
2270 * src/maemo/modest-main-window-ui.h:
2271 * src/modest-ui-actions.c:
2272 * src/modest-ui-actions.h:
2273 Added modest_ui_actions_on_new_account() as a signal handler for the
2274 New Account menu item. It shows the easysetup wizard.
2275 * po/en_GB.po: Added additional needed logical IDs and translations.
2277 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2278 Apparently ChangeLog is not used for some vague Nokia legal reasons.