1 2007-06-22 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (get_password):
4 Restored the call to tny_account_set_user() because Philip seems to have
5 stopped this from crashing (by not using the freed string). It still does
6 not work, but now we can test it.
8 2007-06-22 Murray Cumming <murrayc@murrayc.com>
10 * src/maemo/modest-msg-edit-window.c: (init_window):
11 Comment out use of an uninitialzed GtkScrolledWindow variable,
12 to fix the build and stop a crash. Yet again.
14 2007-06-22 Murray Cumming <murrayc@murrayc.com>
16 * src/modest-tny-account-store.c: (get_password):
17 Remove the call to tny_account_set_user() because this actually crashes.
18 As mentioned in the last commit, it is known to not work anyway.
20 2007-06-22 Murray Cumming <murrayc@murrayc.com>
22 * src/modest-tny-account-store.c: (get_password):
23 Use tny_account_set_username() to tell tinymail that the username might
24 have changed too. But tinymail ignores this: see projects.maemo.org
26 * src/modest-ui-actions.c:
27 (modest_ui_actions_on_password_requested): Remove the useless attempt to
28 reset the connection when changing the username, and improve the comments.
29 Save the changed username to gconf at least, so it is used when Modest is
32 2007-06-21 Murray Cumming <murrayc@murrayc.com>
34 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
35 Do not use a query, so that we get all folders, including for POP and
36 local-folders. They work as search criteria too.
37 This fixes projects.maemo.org bug NB#57740.
39 2007-06-21 Murray Cumming <murrayc@murrayc.com>
41 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
42 Comment out the use of hildon_notification_set_sound() because it is
43 not declared, to fix the build. Warnings are serious, people.
45 2007-06-21 Armin Burgmeier <armin@openismus.com>
47 * src/maemo/modest-maemo-utils.h:
48 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
49 modest_maemo_utils_get_supported_secure_authentication_methods()
50 to query authentication methods for a specific user. This should fix
51 projects.maemo.org bug NB#61369.
53 * src/maemo/easysetup/modest-easysetup-wizard.c:
54 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
57 2007-06-21 Murray Cumming <murrayc@murrayc.com>
59 * libmodest-dbus-client/libmodest-dbus-client.h:
60 * libmodest-dbus-client/libmodest-dbus-client.c:
61 (modest_dbus_message_iter_get_search_hit),
62 (libmodest_dbus_client_search):
63 Reorganised and commented this.
64 Removed modest_search_hit_free() from the public API because it
67 Added libmodest_dbus_client_get_folders() and
68 modest_folder_result_list_free().
70 * src/dbus_api/modest-dbus-api.h:
71 * src/dbus_api/modest-dbus-callbacks.c:
72 (modest_dbus_req_filter): Commented. Moved most code to
73 on_dbus_method_search() and added on_dbus_method_get_folders().
75 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
76 of the extra D-Bus handler.
78 * tests/dbus_api/Makefile.am:
79 * tests/dbus_api/test_get_folders.c: New test for
80 libmodest_dbus_client_get_folders(). This seems to return an empty list
81 at the moment. That could be the same error that causes the message list
82 to be empty sometimes.
83 This should help with projects.maemo.org bug NB#57740.
85 2007-06-21 Armin Burgmeier <armin@openismus.com>
87 * src/modest-mail-operation.c: Do not call
88 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
89 notify the operation's end after having set the status to CANCELED for
90 the operation queue to listen on. This fixes a deadlock when there
91 were mail operations in the queue during its finalization.
93 * src/modest-singletons.c: Reordered uninitialization of the account
94 manager to happen after the mail operation queue was uninitialized
95 because the mail operation's in the queue might still try to access
96 the account manager (see modest_mail_operation_notify_end()). This
97 fixes a potential crash when terminating the application.
99 2007-06-21 Murray Cumming <murrayc@murrayc.com>
101 * src/modest-search.c:
102 (search_mime_part_and_child_parts): Moved some code here so we
103 can search recursively in child folders.
104 (modest_search_folder): Search in the message as a mime part, instead
105 of just its child mime parts.
106 (read_chunk), (search_mime_part_ogs):
107 Check how many bytes were read, to prevent an endless loop.
108 Searching in message bodies now works. This finishes the fix for
109 projects.maemo.org bug NB#61007.
111 2007-06-20 Murray Cumming <murrayc@murrayc.com>
113 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
114 Add a g_warning when the item is not a folder.
116 * src/modest-ui-dimming-rules.c:
117 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
118 when selected item is not a folder (for instance, an account), because
119 the UI spec only talks about folders.
120 I am not sure what the UI spec wants, so this might not totally fix
121 projects.maemo.org bug NB#60794.
123 2007-06-20 Murray Cumming <murrayc@murrayc.com>
125 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
126 (load_from_file): Sort the list. The unsorted list would be more noticeable
127 in non-English locales.
129 * src/maemo/modest-msg-edit-window.c:
130 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
131 warning and fix the build.
133 * src/maemo/modest-progress-bar-widget.c:
134 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
135 avoid a g_warning, and probably to avoid a crash.
137 2007-06-20 Murray Cumming <murrayc@murrayc.com>
139 * src/modest-search.c: (modest_search_folder): Check for a GError
140 when calling tny_folder_get_headers(), to show that this is not the cause
143 2007-06-20 Murray Cumming <murrayc@murrayc.com>
145 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
146 Actually set the body query instead of the subject query.
148 * src/modest-search.c: (search_mime_part_ogs),
149 (search_mime_part_strcmp): Remove extra space from the text/* regex,
150 which would probably cause it to fail if we got this far.
152 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
153 to simplify the code.
154 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
155 be causing search-in-body to fail.
157 2007-06-20 Murray Cumming <murrayc@murrayc.com>
159 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
161 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
162 Better debug message when the folder cannot be found.
163 This should help with fixing projects.maemo.org bug #61287.
164 * src/modest-search.c: (add_hit): Do not leak the furl string.
166 2007-06-20 Murray Cumming <murrayc@murrayc.com>
168 * src/modest-ui-actions.c:
169 (modest_ui_actions_on_folder_selection_changed):
170 Do not special-case TNY_MERGE_FOLDER here, because
171 modest_tny_folder_get_account() already does that. This fixes
172 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
173 shown when the Outbox was selected).
175 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
177 * libmodest-dbus-client/libmodest-dbus-client.c:
178 (_dbus_iter_get_string_or_null): Initialize the string variable in
179 case this helps with Dirk's crash.
181 2007-06-19 Murray Cumming <murrayc@murrayc.com>
183 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
184 though it is not implemented yet (this function is maybe not even used),
185 to avoid breaking ABI in future.
186 * libmodest-dbus-client/libmodest-dbus-client.c:
187 (get_attachments_string): Moved some code into this generic function.
188 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
189 sends email. It is maybe not used.
190 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
191 (on_send_mail): Use attachments.
193 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
194 * src/maemo/modest-msg-edit-window.c:
195 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
196 a filename before using it, to fix projects.maemo.org bug NB#58233.
198 2007-06-19 Murray Cumming <murrayc@murrayc.com>
200 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
201 Initialize the continue_download variable to fix the build, and probably
202 to fix randome behaviour.
204 2007-06-18 Armin Burgmeier <armin@openismus.com>
206 * src/modest-tny-send-queue.h:
207 * src/modest-tny-send-queue.c: Keep track of the status of messages in
208 the queue so we can later show it in the UI. Replaced
209 modest_tny_send_queue_msg_is_being_sent() by
210 modest_tny_send_queue_get_msg_status().
212 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
214 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
215 gpointer. This probably was not harmful, but just to be sure.
217 2007-06-18 Murray Cumming <murrayc@murrayc.com>
219 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
220 Fix the build, but leave the function broken on Bora, because
221 hildon_uri_action_get_service() does not exist.
222 osso_uri_action_get_service() does not exist either, it seems.
224 2007-06-18 Murray Cumming <murrayc@murrayc.com>
226 * src/modest-tny-account.c:
227 (modest_tny_account_new_from_server_account):
228 Uncommented the url debug output again, because it is useful for
229 debugging, as I said in the comment.
231 2007-06-18 Murray Cumming <murrayc@murrayc.com>
233 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
235 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
236 for Mameo Bora, to fix the build.
238 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
241 Fixed build with hildon < 0.99
243 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
244 Check if the selected account is busy instead of checking all accounts
246 * src/modest-account-mgr-priv.h:
247 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
248 (modest_account_mgr_init), (compare_account_name),
249 (modest_account_mgr_set_account_busy),
250 (modest_account_mgr_account_is_busy):
251 * src/modest-account-mgr.h:
252 Added busy information to the account manager. It possible to
253 set an account to busy or not busy now.
255 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
256 (modest_mail_operation_update_account),
257 (modest_mail_operation_notify_end):
258 Set the account to busy/not busy depending on the operation state.
260 * src/widgets/modest-account-view.c:
261 (modest_account_view_finalize), (get_last_updated_string),
262 (update_account_view), (on_account_busy_changed), (init_view):
263 Show string "Refreshing..." if the account is currently busy.
265 All this fixes projects.maemo.org bug NB#59711
267 2007-06-14 Armin Burgmeier <armin@openismus.com>
269 * src/widgets/modest-attachments-view.h:
270 * src/widgets/modest-attachments-view.c: Added
271 modest_attachments_view_has_attachments() and fixed coordinate
272 transformation in get_att_view_at_coords(). This fixes attachment
275 * src/widgets/modest-msg-view.c: Make use of
276 modest_attachments_view_has_attachments() to decide whether to show
277 attachments in the header.
279 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
281 * src/maemo/modest-connection-specific-smtp-edit-window.c:
282 (on_change), (on_combo_security_changed),
283 (modest_connection_specific_smtp_edit_window_init),
284 (modest_connection_specific_smtp_edit_window_set_connection),
285 (modest_connection_specific_smtp_edit_window_is_dirty):
286 * src/maemo/modest-connection-specific-smtp-edit-window.h:
287 * src/maemo/modest-connection-specific-smtp-window.c:
290 Show an comfirmation dialog for the smpt-edit-window if there are
291 unsaved changes and the user hits cancel.
292 (projects.maemo.org bug NB#60479)
294 2007-06-14 Armin Burgmeier <armin@openismus.com>
296 * src/maemo/easysetup/modest-easysetup-wizard.c:
297 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
298 address" info in banner instead of node, and select all the text as
299 per UI spec. This fixes projects.maemo.org bug NB#60550.
301 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
303 reviewed by: <delete if not using a buddy>
305 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
306 * src/modest-ui-actions.c: (folder_refreshed_cb):
308 2007-06-14 Murray Cumming <murrayc@murrayc.com>
310 * src/widgets/modest-folder-view.c: (filter_row):
311 Explictly filter out the per-account outbox accounts. I don't know why
312 these only sometimes show up, but now they should never show up in the UI.
313 This should fix projects.maemo.org bug NB#60160.
315 2007-06-14 Murray Cumming <murrayc@murrayc.com>
317 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
318 when the toolbar does not exist yet.
319 * src/modest-widget-memory.c: (save_settings_header_view):
320 Added g_warnings() to help us to discover when we are trying to set
321 an empty columns list in gconf.
323 2007-06-14 Murray Cumming <murrayc@murrayc.com>
327 Added modest_init_get_default_header_view_column_ids().
329 * src/modest-widget-memory.c: (restore_settings_header_view):
330 Use the new function to get defaults, if the gconf key is empty,
331 instead of not creating any columns. This seems to fix the
332 empty right-hand pane problems.
334 * src/widgets/modest-header-view.h: Improved documentation.
336 2007-06-13 Murray Cumming <murrayc@murrayc.com>
338 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
339 Revert the use of the display name as the account name, because this
340 is generally wrong and would break the code that follows.
342 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
344 * src/maemo/easysetup/modest-easysetup-wizard.c:
345 (check_for_supported_auth_methods), (on_before_next),
348 More correct fix for projects.maemo.org bug NB# 58991
349 Do not longer accept AUTH_PASSWORD as secure method and choose
350 correct method when creating the account.
352 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
354 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
355 Fixed projects.maemo.org bug NB# 58991
357 2007-06-13 Murray Cumming <murrayc@murrayc.com>
359 * src/modest-init.c: (modest_init_init_core),
360 (modest_init_local_folders): Fixed compilation errors.
362 2007-06-13 Murray Cumming <murrayc@murrayc.com>
364 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
365 Remove unnecessary lib/include, though it is good in principle when needed.
367 * src/modest-init.c: (modest_init_one_local_folder),
368 (modest_init_local_folders):
369 * src/modest-init.h: Initialize the .modest library for memory cards,
370 instead of just doing nothing for them. This should allow us to create
371 folders there, fixing projects.maemo.org bug NB#59297.
373 2007-06-13 Murray Cumming <murrayc@murrayc.com>
375 * libmodest-dbus-client/libmodest-dbus-client.c:
376 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
377 (libmodest_dbus_client_compose_mail),
378 (libmodest_dbus_client_open_message),
379 (libmodest_dbus_client_send_and_receive),
380 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
382 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
383 (on_idle_open_message), (modest_dbus_req_handler),
384 (search_result_to_message), (modest_dbus_req_filter):
385 * src/modest-search.c: (add_hit), (modest_search_folder),
386 (modest_search_all_accounts): Improved debug messages.
388 * tests/dbus_api/test_open_message.c: (main): Improved comments.
390 * src/modest-tny-account-store.c:
391 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
394 2007-06-13 Murray Cumming <murrayc@murrayc.com>
397 2007-06-12 Murray Cumming <murrayc@murrayc.com>
399 * src/modest-tny-account-store.c: (get_server_accounts):
400 Call modest_tny_local_folders_account_add_merged_outbox_folders()
401 even when there are no accounts, so that the Outbox folder is always
402 visible. This fixes projects.maemo.org bug NB#60158.
404 2007-06-12 Murray Cumming <murrayc@murrayc.com>
406 * src/maemo/modest-main-window.c: (create_details_widget):
407 Use the mcen_va_never logical ID.
409 2007-06-12 Murray Cumming <murrayc@murrayc.com>
411 * src/dbus_api/modest-dbus-api.h:
412 * src/dbus_api/modest-dbus-callbacks.c:
413 (on_idle_open_default_inbox), (on_open_default_inbox),
414 (modest_dbus_req_handler):
415 Added a new OpenDefaultInbox method.
417 * libmodest-dbus-client/libmodest-dbus-client.h:
418 * libmodest-dbus-client/libmodest-dbus-client.c:
419 Added libmodest_dbus_client_open_default_inbox() to call the new
420 dbus method. This should be useful to projects.maemo.org bug NB#57214,
421 though it should maybe be used by a new osso-email-interface function.
423 * tests/dbus_api/Makefile.am:
424 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
427 2007-06-12 Murray Cumming <murrayc@murrayc.com>
429 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
430 NULL, so that the signals get all the keys. This should not actually
431 change any behaviour because we currently update everything when anything
434 2007-06-12 Murray Cumming <murrayc@murrayc.com>
436 * src/widgets/modest-folder-view.c: (text_cell_data),
437 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
438 (find_inbox_iter): If tinymail tells us that the folder is
439 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
440 This causes the inbox to be selected at startup, fixing part of
441 projects.maemo.org bug NB#56305.
443 * src/modest-ui-dimming-rules.c:
444 (modest_ui_dimming_rules_on_tools_smtp_servers):
445 * src/modest-ui-dimming-rules.h: Added a callback function to dim
446 the SMTP servers menu item.
447 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
448 that the SMTP Servers menu item is dimmed when there are no accounts,
449 as a future version of the UI spec will require. This fixes
450 projects.maemo.org bug NB#56305.
452 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
454 * src/maemo/modest-maemo-utils.c:
455 (modest_maemo_utils_get_supported_secure_authentication_methods):
456 Added label to dialog instead of unreadable title
458 * src/maemo/modest-main-window.c: (sync_accounts_cb),
459 (modest_main_window_new):
460 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
463 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
464 * src/modest-account-mgr.h:
465 Added method to avoid code duplication
467 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
468 (modest_ui_actions_on_send_receive):
469 Use modest_account_mgr_has_accounts
471 2007-06-11 Murray Cumming <murrayc@murrayc.com>
473 * src/maemo/easysetup/modest-presets.c:
474 (modest_presets_get_info_server_security): Do not report secure auth
476 * src/modest-protocol-info.c: Use the defines for the gconf key names
477 for secure authentication. This was not working because we were writing
478 Password and reading password, and the check was case sensitive.
479 With this, gmail now works for receiving and sending when created via
482 2007-06-11 Murray Cumming <murrayc@murrayc.com>
484 * src/maemo/easysetup/modest-presets.c:
485 (modest_presets_get_info_server_security): Correct the key name for
486 SecureSmtp, because it seems to be case-sensitive.
487 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
488 Do not try to get the 0th notebook page if there are 0 pages, to
491 2007-06-11 Murray Cumming <murrayc@murrayc.com>
493 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
494 Prevent use of the new notification feature for now, because it currently
495 shows one dialog for each new email, which is annoying.
497 2007-06-11 Murray Cumming <murrayc@murrayc.com>
499 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
500 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
501 when no country was selected, so that we show the global ones.
502 * src/maemo/easysetup/modest-presets.c:
503 (modest_presets_get_providers): Return only the global providers, not
504 all providers when mmc=0 was requested.
506 2007-06-11 Murray Cumming <murrayc@murrayc.com>
508 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
509 (easysetup_provider_combo_box_fill): Remove debug code that showed the
510 provider ID in the combo.
512 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
513 Do not show the page numbers, because it would be confusing when we add
514 the 2 extra pages for the custom setup, when the user chooses the "Other"
515 provider. This fixes projects.maemo.org bug NB#59028
517 * src/modest-init.c: (modest_init_init_core),
518 (modest_init_local_folders):
520 * src/modest-tny-account.c:
521 (modest_tny_account_new_for_local_folders): Do not create default folders
522 for the memory card. This should fix projects.maemo.org bug NB#59328.
524 2007-06-11 Murray Cumming <murrayc@murrayc.com>
526 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
527 Free the changed_conf_keys string items. They are already freed in the
528 idle handler if that runs first.
530 2007-06-11 Murray Cumming <murrayc@murrayc.com>
532 * src/modest-ui-actions.c:
533 (modest_ui_actions_on_password_requested): Check that the server name
534 is not NULL, because I just saw a password dialog with (null) as the
537 * src/modest-tny-folder.[h|c]: Added
538 modest_tny_folder_is_memory_card_folder().
539 * src/modest-ui-dimming-rules.c:
540 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
541 menu item for memory cards, as per the UI spec (section 7.4). This should
542 fix projects.maemo.org bug NB#59297.
544 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
546 * src/maemo/modest-main-window.c: (sync_accounts_cb):
547 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
548 is another problem with the code, see Murray's comment at line 772)
550 2007-06-08 Murray Cumming <murrayc@murrayc.com>
552 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
553 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
554 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
555 (load_from_file), (easysetup_country_combo_box_init),
556 (easysetup_country_combo_box_get_active_country_ids),
557 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
558 instead of just one ID, to avoid duplicate country names in the UI.
560 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
561 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
562 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
563 a single ID, avoiding duplicate providers.
564 * src/maemo/easysetup/modest-easysetup-wizard.c:
565 (on_combo_account_country): Adapt to use a list.
567 2007-06-08 Murray Cumming <murrayc@murrayc.com>
569 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
570 keys changed in the last X seconds.
572 * src/modest-account-mgr.h:
573 * src/modest-account-mgr.c: (on_timeout_notify_changes),
574 (on_key_change), (modest_account_mgr_class_init),
575 (modest_account_mgr_init), (modest_account_mgr_finalize):
576 As the keys are changed, save them in a GSList* and signal that GSList*
577 further every X seconds, to batch changes, to allow us to do just one
578 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
579 bug NB#56941 and other (UI-blocking) delays when changing account settings.
581 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
582 changed signal signature.
584 * src/modest-conf.c: (modest_conf_set_list),
585 (modest_conf_on_change): Reenable notification.
587 (modest_conf_maemo_fake_on_change): Comment out the hack that
588 notified immediately instead of asynchronously.
590 * src/widgets/modest-account-view.h:
591 * src/widgets/modest-account-view.c:
592 (update_account_view): Select the previously-selected account ID,
593 if possible. This fixes projects.maemo.org bug NB#56933.
595 (on_account_changed), (on_account_removed),
596 (modest_account_view_select_account):
598 Remove the block/unblock functions
599 because they were not useful.
601 * src/maemo/modest-account-view-window.c:
602 (on_delete_button_clicked), (on_edit_button_clicked),
603 (on_new_button_clicked): Remove the use of the non-working block/unblock.
605 2007-06-08 Murray Cumming <murrayc@murrayc.com>
607 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
608 Improve the error dialog to show Incorrect Account Settings, which seems
609 clearer, and say that the internal error message (to be removed from the
610 dialog later) is often misleading.
611 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
613 * src/modest-tny-account.c:
614 (modest_tny_account_new_from_server_account): Uncomment the printf of the
615 URL because this is so useful for debugging on the device.
617 * src/widgets/modest-serversecurity-combo-box.c:
618 (modest_serversecurity_combo_box_fill): Correct a logical ID.
620 2007-06-08 Murray Cumming <murrayc@murrayc.com>
622 * src/modest-mail-operation.c:
623 (modest_mail_operation_send_new_mail):
624 Added a comment about a nasty but apparently harmless message. Details
625 added to the wiki g_warnings() page.
627 2007-06-08 Murray Cumming <murrayc@murrayc.com>
629 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
630 (modest_tny_send_queue_class_init):
631 Do not use the priv struct because it is empty, to avoid g_warnings
632 about a non-existant priv struct.
634 * src/modest-tny-account-store.c:
635 (modest_tny_account_store_get_server_account),
636 (modest_tny_account_store_get_transport_account_for_open_connection
637 ): Do not try to get transport server accounts for local folders,
638 because they don't have any. This avoids a g_warning().
640 * src/maemo/modest-main-window.c:
641 (modest_main_window_notify_send_receive_initied),
642 (on_configuration_key_changed):
643 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
645 * src/modest-mail-operation.c:
646 (modest_mail_operation_update_account):
647 * src/modest-tny-account-store.h:
648 * src/modest-tny-account.c:
649 (modest_tny_account_get_special_folder),
650 (modest_tny_account_new_for_local_folders),
651 (modest_tny_account_new_for_per_account_local_outbox_folder):
652 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
653 * src/modest-tny-local-folders-account.c:
654 (add_account_folders_to_merged_folder):
655 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
656 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
657 (modest_ui_actions_on_send):
658 * src/widgets/modest-folder-view.c: (update_model):
659 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
660 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
661 modest_tny_account_store_get_tny_account_by_account() to
662 modest_tny_account_store_get_server_account() to make the code clearer.
664 2007-06-07 Marcus Bauer <marcusb@openismus.com>
666 * src/dbus_api/modest-dbus-api.h:
667 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
668 * src/maemo/modest-msg-edit-window.c:
669 (modest_msg_edit_window_attach_file_noninteractive):
670 added g_warning in case the file to be attached does not exist
671 * tests/dbus_api/test_compose_mail.c: (main):
672 removed obsolete comment, added generic files as test case
674 2007-06-07 Murray Cumming <murrayc@murrayc.com>
676 * src/modest-tny-account-store.c: (get_server_accounts):
677 Create the local folders account only once, not once for each outbox, and
678 not only when there are some outboxes.
680 2007-06-07 Murray Cumming <murrayc@murrayc.com>
682 * src/widgets/modest-folder-view.c: (update_model): Comment out some
683 code that is causing a crash at startup. Sergio says that he is fixing this.
685 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
687 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
688 * src/maemo/modest-account-settings-dialog.c:
689 (create_page_outgoing),
690 (modest_account_settings_dialog_set_account_name),
691 (save_configuration):
692 - Fixed handling of the "Use secure authentication" toggle to comply with
693 the ui specification. See also projects.maemo.org bug NB#58400
695 - Restore the Secure connection setting combo correctly when loading
698 * src/maemo/modest-maemo-utils.c:
699 (on_camel_account_get_supported_secure_authentication),
700 (modest_maemo_utils_get_supported_secure_authentication_methods):
701 Fixed a crasher if operation is canceled
703 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
704 (modest_protocol_info_auth_is_secure):
705 * src/modest-protocol-info.h:
707 Added two new methods to determine if a protocol/auth method is secure/encrypted in
708 the sense of the "Use secure authentication" toggle.
710 2007-06-07 Murray Cumming <murrayc@murrayc.com>
712 * src/modest-tny-account-store.h:
713 * src/modest-tny-account-store.c:
714 Added modest_tny_account_store_get_local_folders_account().
716 * src/modest-tny-folder.h:
717 * src/modest-tny-folder.c:
718 (modest_tny_folder_get_account):
719 Added this replacement for tny_folder_get_account() which returns
720 the local-folders account for TnyMergeFolders, to avoid the
721 warning about the unimplemented get_account_func() vfunc().
723 (modest_tny_folder_get_rules),
724 * src/modest-ui-actions.c:
725 (modest_ui_actions_on_folder_selection_changed):
726 * src/modest-mail-operation.c:
727 (modest_mail_operation_remove_folder),
728 (modest_mail_operation_xfer_folder),
729 (modest_mail_operation_rename_folder),
730 (modest_mail_operation_get_msg),
731 (modest_mail_operation_get_msgs_full),
732 (modest_mail_operation_remove_msg),
733 (modest_mail_operation_xfer_msgs),
734 (modest_mail_operation_refresh_folder):
735 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
737 2007-06-07 Murray Cumming <murrayc@murrayc.com>
739 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
740 (modest_server_account_set_security):
741 * src/modest-defs.h: Add comments explaining that our
742 UI spec means TLS when it says Normal, so these do not look like errors.
744 * src/modest-tny-account.c:
745 (modest_tny_account_new_from_server_account): Use the new tinymail
746 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
747 for TLS. This should fix projects.maemo.org bug NB#58460.
749 2007-06-06 Murray Cumming <murrayc@murrayc.com>
751 * src/maemo/easysetup/modest-easysetup-wizard.c:
752 (create_account): Correct the position of the gconf sanity check warning.
753 (on_button_edit_advanced_settings): Show the dialog immediately, instead
754 of using the g_idle_add() hack, because this does not seem to be necessary
755 on osso 1.1. It might even work on Maemo Bora if the problems were actually
756 caused by something other than maemo's gconf.
757 This fixes projects.maemo.org bug #59022.
759 2007-06-06 Murray Cumming <murrayc@murrayc.com>
761 * src/modest-account-mgr-helpers.c:
762 (modest_account_mgr_get_default_account): Do not check that the account
763 exists if there is no default account (NULL), to fix a runtime warning.
765 2007-06-06 Murray Cumming <murrayc@murrayc.com>
767 * src/widgets/modest-folder-view.c: (update_model):
768 Do not unref the treemodel before we have finished with it.
769 This prevents a valgrind warning and an occasional crash at startup.
771 2007-06-06 Marcus Bauer <marcusb@openismus.com>
773 * libmodest-dbus-client/libmodest-dbus-client.h:
774 added libmodest_dbus_client_compose_mail()
775 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
777 added functions needed for SendAsMail() functionality
778 * src/maemo/modest-msg-edit-window.c:
779 (modest_msg_edit_window_attach_file_noninteractive):
780 non interactively attaching files to message edit window
781 * src/widgets/modest-msg-edit-window.h:
782 * tests/dbus_api/Makefile.am:
783 added test_compose_mail.c
784 * tests/dbus_api/test_compose_mail.c: (main):
786 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
788 * src/modest-account-view.c:
789 Fixed bug projects.maemo.org bug NB#59307
791 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
793 * src/maemo/easysetup/modest-easysetup-wizard.c:
794 (get_serverport_incoming), (on_before_next), (create_account):
795 * src/maemo/modest-account-settings-dialog.c:
796 (modest_account_settings_dialog_set_account_name):
797 * src/maemo/modest-maemo-utils.c:
798 (on_camel_account_get_supported_secure_authentication_status),
799 (on_camel_account_get_supported_secure_authentication),
800 (on_secure_auth_cancel),
801 (modest_maemo_utils_get_supported_secure_authentication_methods):
803 Implemented security authentication for settings and easysetup.
805 2007-06-05 Murray Cumming <murrayc@murrayc.com>
807 * src/maemo/modest-main-window.c: (create_details_widget):
808 Show the total size for memory card accounts too, instead of showing
809 the name again. Fixes bug projects.maemo.org bug NB#59307.
811 2007-06-05 Murray Cumming <murrayc@murrayc.com>
814 * src/modest-tny-simple-folder-store.c:
815 * src/modest-tny-simple-folder-store.h: Removed.
817 * src/modest-tny-local-folders-account.h
818 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
819 for the local-folders maildir, with an extra TnyMergedFolder containing
820 the folders of the per-account outbox store accounts.
821 * src/modest-tny-account-store.c: (get_server_accounts):
822 Add the outboxes to the special local folders account after creating it.
824 * src/modest-tny-account.c:
825 (modest_tny_account_new_for_local_folders): Create the derived
826 account when creating the main local-folders account.
828 * src/maemo/modest-main-window.c: (create_details_widget),
829 (modest_main_window_set_contents_style):
830 Adapted to the use of the derived account instead of the folder store.
832 * src/modest-ui-actions.c:
833 (modest_ui_actions_on_folder_selection_changed):
834 * src/modest-ui-dimming-rules.c:
835 (modest_ui_dimming_rules_on_new_folder):
836 * src/widgets/modest-folder-view.c: (text_cell_data),
837 (icon_cell_data), (filter_row), (update_model),
838 (get_cmp_rows_type_pos):
841 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
842 Do not get the priv struct, because no priv struct has been set,
843 to avoid a runtime warning.
845 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
846 #ifelse with #else, to fix a warning, to fix the build.
849 2007-06-05 Christian Kellner <ckellner@openismus.com>
851 * libmodest-dbus-client/libmodest-dbus-client.c:
852 Fix small typo in doc (why do you always see them
853 AFTER committing stuff?)
856 2007-06-05 Christian Kellner <ckellner@openismus.com>
858 * libmodest-dbus-client/libmodest-dbus-client.c:
859 (libmodest_dbus_client_search):
860 Initialize hit list with NULL. Also set folder list
861 to "" if NULL was supplied.
864 2007-06-03 Christian Kellner <ckellner@openismus.com>
866 * libmodest-dbus-client/libmodest-dbus-client.c:
867 (modest_search_hit_list_free):
868 Make it save to call it with NULL.
870 * src/dbus_api/modest-dbus-callbacks.c:
871 * src/modest-search.c:
872 Return full ModestSearchHits as the search result list not TnyHeader
873 since can't be around withouth the correspoding TnyFolder.
875 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
877 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
878 Added currently commented code to check for secure auth
880 * src/maemo/modest-account-settings-dialog.c: (on_response),
881 (save_configuration), (show_ok):
882 Fixed projects.maemo.org bugs NB #59248 and #59251
884 * src/maemo/modest-maemo-utils.c:
885 (on_camel_account_get_supported_secure_authentication_status),
886 (on_camel_account_get_supported_secure_authentication),
887 (modest_maemo_utils_get_supported_secure_authentication_methods):
888 * src/maemo/modest-maemo-utils.h:
889 Moved get_supported_secure_authentication() method here to be able
890 to use it from easysetup wizard.
892 * src/modest-pair.c: (on_pair_compare_as_string):
893 Should compare string with first part of pair and not
894 strcmp pairs which will crash.
896 * src/modest-protocol-info.c:
897 (modest_protocol_info_protocol_is_store):
898 * src/modest-protocol-info.h:
899 Added modest_protocol_info_get_auth_protocol_name()
901 2007-06-03 Armin Burgmeier <armin@openismus.com>
903 * src/modest-mail-operation.c:
904 (modest_mail_operation_get_msgs_full): Set priv->account also when
905 only retrieving a single message. This avoids a crash when canceling
908 (modest_mail_operation_notify_end): Do not explicitely remove the
909 operation from the queue but only emit the progress_changed signal.
910 The queue itself listens to that signal to remove the operation when
911 it is finished. This reduces coupling and removes a potential deadlock
912 when modest_mail_operation_notify_end() is called from the queue
913 itself. If that is a problem performance-wise, I would suggest to
914 implement a status-changed signal or something.
916 * src/modest-mail-operation-queue.c: Make sure to never call a
917 function from another file while the queue is locked. This (hopefully)
918 fixes another deadlock when exiting the application while retrieving
921 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
923 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
924 Fixed build if libogs is not available
926 2007-06-03 Christian Kellner <ckellner@openismus.com>
928 * libmodest-dbus-client/libmodest-dbus-client.h:
929 * libmodest-dbus-client/libmodest-dbus-client.c:
930 (libmodest_dbus_client_delete_message):
931 Implement deletion of messages (Client side).
933 (modest_search_hit_free),
934 (modest_search_hit_list_free):
935 Utility functions to free the result hits.
937 * src/dbus_api/modest-dbus-api.h:
938 * src/dbus_api/modest-dbus-callbacks.c:
940 (modest_dbus_req_handler):
941 Implement deletion of messages (Server side).
943 * tests/dbus_api/test_search.c: (main):
946 * tests/dbus_api/Makefile.am:
947 * tests/dbus_api/test_delete_message:
948 Add little test for the message deletion logic
950 2007-06-03 Armin Burgmeier <armin@openismus.com>
952 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
953 when the operation queue was not empty. projects.maemo.org bug
956 2007-06-03 Armin Burgmeier <armin@openismus.com>
958 * src/widgets/modest-account-view.c
959 (on_account_default_toggled): Toggle default account column
960 explicitely instead of waiting for gconf notification (which is
961 currently ignored). This should fix projects.maemo.org bug NB#56910
962 for now. It should probably be removed when gconf notifications are
965 2007-06-03 Christian Kellner <ckellner@openismus.com>
967 * libmodest-dbus-client/libmodest-dbus-client.c:
968 Removed debugging spew.
970 * src/dbus_api/modest-dbus-callbacks.c:
971 Added debugging info.
973 * src/modest-search.c:
974 (modest_search_all_accounts):
975 Use tny_account_store_get_accounts () on the account store
976 to get all accounts which is the way to get all accounts.
978 * tests/dbus_api/test_search.c: (main):
979 Make it possible to supply the search term on the command line.
981 2007-06-03 Christian Kellner <ckellner@openismus.com>
983 * libmodest-dbus-client/libmodest-dbus-client.c:
984 * libmodest-dbus-client/libmodest-dbus-client.h:
985 Implement searching for mesages over raw dbus. (Client side)
987 * src/dbus_api/Makefile.am:
988 * src/dbus_api/modest-dbus-api.h:
989 * src/dbus_api/modest-dbus-callbacks.c:
990 * src/dbus_api/modest-dbus-callbacks.h:
991 Search framework (Server side). Also implement on_idle_open_message().
993 * src/maemo/modest-platform.c: (modest_platform_init):
994 Prepare for raw dbus/osso rpc interaction.
996 * src/modest-search.h:
997 Changed minsize from unspecific guint to guint32.
999 * src/modest-search.c:
1001 Added strange hack which magically made tnymail work.
1003 (modest_search_folder),
1004 (modest_search_account),
1005 (modest_search_all_accounts):
1006 Implement helper functions to search all accounts, specific account
1009 * tests/dbus_api/Makefile.am:
1010 * tests/dbus_api/test_open_message.c:
1011 Read url to open from commandline.
1013 * tests/dbus_api/test_search.c:
1014 Implement small test for dbus search stuff
1016 2007-06-02 Armin Burgmeier <armin@openismus.com>
1018 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1019 include account type and account title. This fixes projects.maemo.org
1022 * src/maemo/modest-account-view-window.c: Set a title for the window.
1024 2007-06-02 Armin Burgmeier <armin@openismus.com>
1026 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1027 incoming and outgoing server name based on email address and server
1028 types as long as the names have not been edited manually. This fixes
1029 projects.maemo.org bug NB#58671.
1031 2007-06-02 Armin Burgmeier <armin@openismus.com>
1033 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1034 server type cannot be changed in future to the incoming details page
1035 when creating an account. This fixes projects.maemo.org bug NB#59029.
1037 2007-06-02 Armin Burgmeier <armin@openismus.com>
1039 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1040 and assigned max width chars so that they wrap instead of being
1041 truncated. Fixes projects.maemo.org bug NB#56126.
1043 2007-06-02 Armin Burgmeier <armin@openismus.com>
1045 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1046 introductory note to the connection specific smtp servers dialog, as
1047 section 8.12 of the email UI specification requires. This fixes
1048 projects.maemo.org bug NB#59212.
1050 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1052 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1053 Check for running mail operations, and offer to cancel them, as per the UI
1054 spec. This fixes projects.maemo.org bug NB#59041 .
1055 However, I suspect that tinymail may still use the network connection
1056 in ways that we cannot detect or cancel. But it should at least adapt to
1057 changes fairly well.
1059 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1061 * src/modest-tny-account-store.c: (recreate_all_accounts),
1062 (get_cached_accounts), (get_server_accounts): Do more sensible
1063 ref-counting of the temporarily-cached outbox accounts list. This seems
1064 to fix a crash when entering the password when the password was wrong.
1066 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1068 * src/gnome/modest-main-window.c: (connect_signals):
1069 * src/modest-tny-account-store.c: (get_password),
1070 (modest_tny_account_store_alert): Added comments and clues and
1071 commented-out code about how we currently fail to deal with connection
1072 errors and wrong passwords, and how we should.
1074 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1076 * src/widgets/modest-retrieve-combo-box.c:
1077 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1078 This fixes projects.maemo.org bug NB#58472 .
1080 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1082 * src/maemo/easysetup/modest-easysetup-wizard.c:
1083 (create_page_complete_easysetup):
1084 (create_page_complete_custom): Correct the last commit,
1085 putting the correct sentences in the correct pages.
1087 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1089 * src/maemo/easysetup/modest-easysetup-wizard.c:
1090 (create_page_complete_custom): Show the second sentence of text
1091 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1094 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1096 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1097 Set the leave-on-server conf key by default. This fixes
1098 projects.maemo.org bug NB#59258 .
1100 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1102 * src/maemo/modest-account-view-window.c:
1103 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1104 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1107 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1109 * src/maemo/easysetup/modest-easysetup-wizard.c:
1110 (create_caption_new_with_asterisk):
1111 * src/maemo/modest-account-settings-dialog.c:
1112 (create_caption_new_with_asterisk):
1113 Uncomment the code to add the asterisk, because they are no longer in the
1114 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1115 (update_incoming_server_title): Add an asterisk here too.
1117 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1119 * src/maemo/modest-maemo-global-settings-dialog.c:
1120 (current_connection): Check that we are even connected before trying to
1121 get the current connection name, to prevent a warning.
1123 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1124 Change the comments because tny_maemo_conic_device_connect() is now meant to
1126 * src/modest-mail-operation.c:
1127 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1128 make sure we have a connection and fail if we can't connect.
1130 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1132 * src/maemo/modest-main-window.c:
1133 (on_account_store_connecting_finished): Do not try to get the
1134 connection ID if we are not really connected. I am surprised that
1135 this signal handler is called when we are not connected.
1137 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1139 * src/modest-error.h:
1140 * src/modest-ui-actions.c:
1141 (modest_ui_actions_get_msgs_full_error_handler):
1142 Renamed an enum, added comments, added an enum
1143 for retrieve-limit errors.
1145 * src/modest-mail-operation.c: (foreach_add_item),
1146 (internal_folder_observer_update), (update_account_thread),
1147 (modest_mail_operation_get_msgs_full):
1148 (modest_mail_operation_update_account),
1149 Added comments about how this works, and some code that should
1150 (but does not) check the retrieve-limit. See the TODO comment.
1152 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1154 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1155 Initialize help_id to fix the build. Warnings are good.
1157 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1159 * src/widgets/modest-hbox-cell-renderer.c:
1160 (modest_hbox_cell_renderer_append):
1161 * src/widgets/modest-vbox-cell-renderer.c:
1162 (modest_vbox_cell_renderer_append):
1163 Fix the last commit by doing an extra ref.
1165 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1167 * src/widgets/modest-hbox-cell-renderer.c:
1168 (modest_hbox_cell_renderer_append):
1169 * src/widgets/modest-vbox-cell-renderer.c:
1170 (modest_vbox_cell_renderer_append):
1171 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1172 to fix the build with Maemo Bora.
1173 However, there seems to be a remaining crash, probably due to reference
1176 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1178 * src/modest-tny-account.c:
1179 (modest_tny_account_new_for_local_folders):
1180 Use hildon_file_system_info_async_new() to get a better name for
1181 the memory card account, setting it as the account name.
1182 The timing seems to work, but this is probably
1183 not the best place to do this. See the TODO comment.
1184 * src/maemo/modest-main-window.c: (create_details_widget):
1185 * src/widgets/modest-folder-view.c: (text_cell_data):
1186 Use the tny account name instead of hardcoding a name.
1188 2007-05-30 Christian Kellner <ckellner@openismus.com>
1190 * src/modest-search.c: (modest_search):
1191 Correctly set part_search_func even if we have already parsed
1192 the query and thus a valid OgsTextSearcher object.
1194 2007-05-30 Christian Kellner <ckellner@openismus.com>
1197 Search and check for libogs.
1200 Incooparte the ogs build env.
1202 * src/modest-mime-part-search-stream.c:
1203 * src/modest-mime-part-search-stream.h:
1204 Removed since we do the real searching now in modest-search.c.
1206 * src/modest-search.c:
1207 * src/modest-search.h:
1208 Implement support for ogs. We use that if available and requested
1209 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1210 should now handle the corner case when the search term is spread
1211 across multiple reads.
1212 Also the logic in modest_search () was corrected to search all
1213 requested fields until one is found.
1215 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1217 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1219 * src/modest-init.h:
1220 * src/modest-init.c: Made modest_init_local_folders() take a
1221 path and be public so we can iniitialize maildir folders on
1224 * src/modest-local-folder-info.h:
1225 * src/modest-local-folder-info.c:
1226 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1228 * src/modest-tny-account.c:
1229 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1230 still means the standard local-folders path on the local volume.
1232 * src/modest-tny-account-store.c:
1233 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1234 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1235 all accounts when that happens.
1236 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1237 this too, so it shows up in the treeview.
1239 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1241 * src/maemo/modest-maemo-global-settings-dialog.c:
1242 (current_connection):
1243 * src/widgets/modest-global-settings-dialog.c:
1244 (current_connection_default):
1245 Use the enum values instead of 0, 1 and -1,
1246 to make the code clearer.
1248 * src/modest-account-mgr-helpers.c:
1249 (modest_account_mgr_get_connection_specific_smtp): Make this code
1252 * src/modest-runtime.h:
1253 * src/modest-runtime.c:
1254 Added modest_runtime_remove_all_send_queues().
1255 * src/maemo/modest-main-window.c:
1256 (on_account_store_connecting_finished): Recreate the send queues,
1257 using the appropriate transport accounts for this new connection.
1258 Some futher adapting might be needed if the old send queues are not
1259 automatically stopped at this point.
1261 * src/modest-tny-account-store.c: (get_server_accounts):
1262 Create the connection-specific transport accounts, so that they can
1263 be found later by their ID.
1265 * src/modest-tny-account.h:
1266 * src/modest-tny-account.c:
1267 Added modest_tny_account_new_from_server_account_name().
1268 modest_tny_account_new_from_server_account(): Do not create the
1269 send queues here, because they will be
1270 recreated anyway when the connection changes for the first time.
1272 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1274 * src/modest-local-folder-info.h:
1275 * src/modest-local-folder-info.c:
1276 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1277 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1278 tbox_folder): Take a modest account name instead of a server TnyAccount,
1279 so we can have per-modest-account rather than per-transport-account
1281 We must make sure that we change or recreate the exisitng send queues
1282 when the connection changes for connection-specific transport accounts.
1284 * src/modest-tny-account-store.c:
1285 (create_per_account_local_outbox_folders): Create outboxed per modest
1286 account, not per transport account.
1288 * src/modest-tny-account.h:
1289 * src/modest-tny-account.c:
1290 (modest_tny_account_get_special_folder): For outboxes, get the
1291 parent modest account name. The account is ignored for other folders.
1292 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1293 modest account name rather than a server TnyAccount.
1295 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1297 * src/modest-tny-account.c:
1298 (modest_tny_account_new_from_server_account):
1299 Call modest_runtime_get_send_queue() immediately after creating transport
1300 accounts, so that they start trying to send email from the outbox as soon
1301 as possible at startup. This is probably what we want.
1303 * src/modest-mail-operation.c: (update_account_thread):
1304 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1305 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1306 * src/modest-tny-send-queue.h:
1307 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1308 (modest_ui_actions_on_send):
1309 Added comments about how sending works, though it needs some more work.
1311 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1313 * src/modest-tny-account.c:
1314 (modest_tny_account_get_special_folder): Add TODO because this fails when
1315 the network is busy.
1316 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1317 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1318 Do not try to show this window when there is no active account. The UI
1319 specs does not tell us what to do in this case.
1321 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1325 * src/maemo/Makefile.am:
1326 * src/widgets/Makefile.am: Some dist fixes.
1328 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1330 * src/maemo/modest-connection-specific-smtp-window.c:
1331 (on_button_edit): Make the code clearer, to prevent a double free.
1333 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1335 * src/maemo/modest-account-settings-dialog.c:
1336 (modest_account_settings_dialog_set_account_name),
1337 Check the connection-specific smtp servers checkbox if there are any.
1339 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1340 (modest_connection_specific_smtp_edit_window_init):
1341 Start with a suitable port number.
1343 * src/modest-account-mgr-helpers.h:
1344 * src/modest-account-mgr-helpers.c: Added
1345 modest_account_mgr_get_has_connection_specific_smtp().
1347 (modest_account_mgr_set_connection_specific_smtp),
1348 (modest_account_mgr_remove_connection_specific_smtp),
1349 (modest_account_mgr_get_has_connection_specific_smtp),
1350 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1351 connection-specific smtp server accounts in the account, rather than
1352 the server account conf dir.
1354 This fixes bug projects.maemo.org bug NB#58263 .
1356 * src/modest-tny-account-store.c:
1357 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1358 if there are no server accounts yet, to prevent an infinite loop when there
1359 are no accounts. Document that one must be called before the other.
1361 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1363 * src/modest-account-mgr-helpers.c:
1364 (modest_account_mgr_get_default_account): Make sure that at least
1365 one account is always the default, if there are any enabled accounts.
1366 This is just a sanity check that shouldn't be necessary.
1368 * src/modest-account-mgr-priv.c:
1369 (_modest_account_mgr_account_from_key): Unescape the conf key to
1370 get the real account name. For instance, this is an issue if a space
1371 was in the account name, which can happen because the account name
1372 is generated from the display name.
1373 (_modest_account_mgr_get_account_keyname): Always escape the
1375 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1376 Unescape the conf keys to get the real account names.
1378 For instance, previously the is-default radio button in the accounts
1379 list was not checked for any accounts at first. This fixes that,
1380 and might fix several similar bugs.
1382 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1384 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1385 Removed some debug printfs.
1387 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1389 Modest on-disk outbox directories are now here, for instance:
1390 $HOME/.modest/outboxes/<account-id-1>/outbox
1391 $HOME/.modest/outboxes/<account-id-2>/outbox
1393 $HOME/.modest/local-folders/outbox
1394 so we can have a separate outbox for each account.
1395 But they are shown as one outbox in the GtkTreeView, by using a
1396 TnyMergeFolder in a ModestTnySimpleFolderStore.
1399 * src/modest-tny-simple-folder-store.c:
1400 * src/modest-tny-simple-folder-store.h:
1401 Added ModestTnySimpleFolderStore, used to contain folders from
1402 other folder stores, such as other accounts.
1404 * src/modest-tny-outbox-account.h:
1405 * src/modest-tny-outbox-account.c:
1406 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1407 used for the per-account local outbox folders.
1409 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1410 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1411 only use this (internally) now for the non-outbox local folders.
1413 * src/modest-init.h:
1414 * src/modest-init.c: Added modest_init_one_local_folder(), for
1415 setting up the directory structure for each local folder.
1417 * src/modest-local-folder-info.c:
1418 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1419 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1421 * src/modest-local-folder-info.h:
1422 * src/modest-tny-account-store.c: (on_account_removed),
1423 (on_account_changed), (create_per_account_local_outbox_folders),
1424 (get_server_accounts), (modest_tny_account_store_get_accounts),
1425 (modest_tny_account_store_get_tny_account_by_account),
1426 (modest_tny_folder_store_is_virtual_local_folders):
1428 * src/modest-tny-account.h:
1429 * src/modest-tny-account.c:
1430 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1431 to create an on-disk per-account local outbox folder for each
1433 (create_per_account_local_outbox_folders): Create a local outbox folder
1434 for each transport account.
1435 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1436 for all local folders.
1438 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1439 instead of using g_object_get/set() directly. It is clearer.
1441 (modest_tny_folder_store_get_message_count),
1442 (modest_tny_folder_store_get_local_size
1443 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1444 because we now use these with non-acount folder stores.
1446 (modest_tny_account_get_special_folder),
1447 (modest_tny_account_new_from_server_account),
1448 (modest_tny_account_new_from_account):
1449 (recurse_folders): Adjust to the new outbox system.
1451 * src/modest-tny-folder.h:
1452 * src/modest-tny-folder.c:
1453 (modest_tny_folder_is_local_folder),
1454 (modest_tny_folder_get_local_folder_type),
1455 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1457 * src/widgets/modest-main-window.h:
1458 * src/maemo/modest-main-window.c: (create_details_widget),
1459 (modest_main_window_set_contents_style): Show details for any folder store,
1462 (modest_tny_folder_get_rules):
1463 Remove the const. C does not support constness enough for this.
1465 * src/modest-ui-actions.c:
1466 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1467 make all outboxes appear as one, in the usual local-folders tree node.
1469 (set_active_account_from_tny_account),
1470 (modest_ui_actions_on_folder_selection_changed):
1471 * src/widgets/modest-folder-view.c: (text_cell_data),
1472 (icon_cell_data), (filter_row),
1473 (add_account_folders_to_merged_folder),
1474 (add_account_folders_to_simple_folder_store), (),
1475 (get_cmp_rows_type_pos), (cmp_rows),
1476 (modest_folder_view_set_account_id_of_visible_server_account):
1477 Adjust to the new outbox system, using generic folder stores and folders
1478 in the GtkTreeModel.
1480 2007-05-23 Christian Kellner <ckellner@openismus.com>
1482 * src/modest-mail-operation.c:
1483 (modest_mail_operation_update_account):
1484 Use info->max_size instead of unintialized local var [small
1485 build fix]. (Added TODO to review that change since I don't
1488 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1490 * libmodest-dbus-client/libmodest-dbus-client.c:
1491 (libmodest_dbus_client_compose_mail): function added
1492 * src/dbus_api/modest-dbus-api.h:
1493 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1494 (on_compose_mail): Implementation of the SendAsMail functionality
1496 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1498 * src/modest-account-mgr.c:
1499 (modest_account_mgr_add_server_account): Set the secure-connection
1500 conf key for transport accounts as well as store accounts. I don't know
1501 why the if was there. For instance, this makes sure that we use SSL
1502 for the gmail preset from the easysetup wizard.
1504 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1506 * src/gnome/modest-main-window.c:
1507 (on_account_store_connecting_finished), (connect_signals):
1508 * src/maemo/modest-main-window.c:
1509 (on_account_store_connecting_finished), (connect_signals),
1510 (modest_main_window_new):
1511 Handle TnyAccountStore::connecting-finished instead of
1512 TnyDevice::connection-changed, because we cannot actually perform
1513 operations on accounts until TnyAccountStore has itself responded to
1514 the TnyDevice::connection-changed signal. This prevents a GError from
1516 Do not try to update at startup, because we (at least on scratchbox)
1517 already do an update at startup when the device goes online.
1518 This prevents a GError from tinymail.
1519 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1520 Added TODO about stopping simultaneous operations.
1522 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1524 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1525 * src/modest-mail-operation-queue.c:
1526 (modest_mail_operation_queue_remove):
1527 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1528 about where they happened.
1530 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1532 * src/modest-ui-actions.c:
1533 (modest_ui_actions_on_password_requested): Make sure that the remember
1534 output parameter is always TRUE.
1536 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1538 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1539 Show a OK/Cancel dialog if the error is a question, though we still do not
1540 know anything more about what we are asking the user.
1541 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1542 Fix an uninitialized variable (helper). This is a logic error, however.
1544 2007-05-21 Christian Kellner <ckellner@openismus.com>
1546 * src/modest-search.h:
1547 Correct bit shifting in the ModestSearchFlags enum.
1549 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1551 * src/modest-tny-account.c:
1552 (modest_tny_account_new_from_server_account): Do not use the lsub and
1553 check-all hard-coded IMAP options when using POP.
1555 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1557 * src/modest-tny-account.c:
1558 (modest_tny_account_new_from_server_account):
1559 Use NULL for the secure-auth method for POP when Password auth has been
1560 specified by the user, as we already do for IMAP. "auth=Login" causes
1561 an error from camel or the server.
1563 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1565 * src/maemo/modest-account-settings-dialog.c:
1566 (create_page_account_details),
1567 (modest_account_settings_dialog_set_account_name):
1568 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1569 for the leave-on-server checkbox, rathr than just the checkbox, when
1570 the protocol is not POP.
1572 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1574 * src/widgets/modest-account-view.c:
1575 * src/widgets/modest-account-view.h:
1576 Added modest_account_view_select_account() which will be useful later
1577 to asynchronously re-select the edited account.
1579 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1581 * src/maemo/modest-account-settings-dialog.c:
1582 (modest_account_settings_dialog_set_account_name):
1583 Automatically choose the port numbers based on the secure authentication
1584 methods, if they have not been chosen before.
1585 This fixes projects.maemo.org bug NB#56273 .
1587 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1589 * src/maemo/modest-main-window-ui.h:
1590 * src/modest-ui-actions.c:
1591 * src/modest-ui-actions.h:
1592 Connect the Tools/SMTP Servers menu item to
1593 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1594 SMTP servers dialog, as in the UI specification and saves changes when it
1595 is closed. This fixed projects.maemo.org bug NB#56305 .
1597 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1599 * src/maemo/modest-connection-specific-smtp-window.c:
1600 (modest_connection_specific_smtp_window_init):
1601 Use gtk_window_set_default_size() to make this window big enough, so
1602 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1604 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1606 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1607 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1608 (modest_connection_specific_smtp_edit_window_init),
1609 Do not try to connect to a combobox signal before the combobox exists.
1610 This fixes the cras in projects.maemo.org bug NB#56288 .
1611 (modest_connection_specific_smtp_edit_window_get_settings):
1612 Remove the server_account_name parameter which was being checked for NULL
1613 though it was not used.
1615 * src/maemo/modest-connection-specific-smtp-window.c:
1616 (modest_connection_specific_smtp_window_fill_with_connections),
1617 (on_button_edit), (modest_connection_specific_smtp_window_init):
1618 Correct the number of treemodel columns to prevent a warning.
1619 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1620 libconic does not work.
1622 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1624 * src/modest-tny-account.c:
1625 (modest_tny_account_new_from_server_account):
1626 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1627 SMTP when "None" was chosen by the user. However, with my SMTP server that
1628 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1631 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1633 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1634 to explain the memory management issue with the ID in the ModestPair.
1636 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1637 (add_sending_page), (modest_account_assistant_finalize):
1638 * src/gnome/modest-gnome-global-settings-dialog.c:
1639 (create_updating_page), (create_composing_page):
1640 * src/gnome/modest-msg-edit-window.c: (get_transports),
1641 (init_window), (modest_msg_edit_window_finalize),
1642 (modest_msg_edit_window_get_msg_data):
1643 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1644 * src/gnome/modest-transport-widget.c:
1645 (modest_transport_widget_finalize), (smtp_configuration):
1646 * src/maemo/modest-maemo-global-settings-dialog.c:
1647 (create_updating_page), (create_composing_page):
1648 * src/maemo/modest-msg-edit-window.c: (get_transports),
1649 (init_window), (modest_msg_edit_window_finalize),
1650 (modest_msg_edit_window_get_msg_data),
1651 (modest_msg_edit_window_free_msg_data):
1652 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1653 (modest_store_widget_finalize):
1654 * src/maemo/modest-transport-widget.c:
1655 (modest_transport_widget_finalize), (smtp_configuration):
1656 * src/modest-main.c: (send_mail):
1657 * src/widgets/modest-combo-box.h:
1658 * src/widgets/modest-global-settings-dialog-priv.h:
1659 * src/widgets/modest-global-settings-dialog.c:
1660 (modest_global_settings_dialog_finalize):
1661 * src/widgets/modest-msg-edit-window.h:
1662 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1663 as long as the combo box, to prevent use of freed memory for the ID.
1665 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1667 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1668 get_accounts(), to make this clearer. Do not check for the enabled gconf
1669 key, because we do not use this for server accounts (at least, not yet).
1670 This allows us to send email again.
1672 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1674 * src/maemo/modest-platform.c:
1675 (on_modest_conf_update_interval_changed), (modest_platform_init):
1676 Only respond to this particular key change. All these strcmp()s cannot be
1679 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1681 * src/maemo/modest-maemo-global-settings-dialog.c:
1682 (current_connection): Prevent a crash in scratchbox when
1683 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1684 * src/maemo/modest-platform.c:
1685 (on_modest_conf_update_interval_changed), (modest_platform_init):
1686 Get the update interval from gconf and reset it when the gconf key changes.
1688 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1690 * src/modest-protocol-info.c:
1691 * src/modest-protocol-info.h: Adde enum-specific get functions,
1692 instead of using a ModestProtocolType enum parameter.
1694 * src/gnome/modest-account-assistant.c:
1695 * src/gnome/modest-store-widget.c:
1696 * src/gnome/modest-store-widget.h:
1697 * src/gnome/modest-transport-widget.c:
1698 * src/gnome/modest-transport-widget.h:
1699 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1700 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1701 * src/maemo/easysetup/modest-easysetup-wizard.c:
1702 * src/maemo/modest-account-settings-dialog.c:
1703 * src/maemo/modest-account-settings-dialog.h:
1704 * src/maemo/modest-store-widget.c:
1705 * src/maemo/modest-store-widget.h:
1706 * src/maemo/modest-transport-widget.c:
1707 * src/maemo/modest-transport-widget.h:
1708 * src/modest-account-mgr-helpers.c:
1709 * src/modest-account-mgr-helpers.h:
1710 * src/modest-account-mgr.c:
1711 * src/modest-account-mgr.h:
1712 * src/modest-tny-account.c:
1713 * src/modest-tny-folder.c:
1714 * src/widgets/modest-account-view.c:
1715 * src/widgets/modest-retrieve-combo-box.c:
1716 * src/widgets/modest-retrieve-combo-box.h:
1717 * src/widgets/modest-secureauth-combo-box.c:
1718 * src/widgets/modest-serversecurity-combo-box.c:
1719 * src/widgets/modest-serversecurity-combo-box.h:
1720 * tests/check_account-mgr.c:
1721 Use the specific functions, and use the re-renamed enum values for GNOME too.
1723 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1725 * src/modest-pair.h:
1726 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1727 so we can get the second based on the first.
1729 * src/maemo/modest-account-settings-dialog.h:
1730 * src/maemo/modest-account-settings-dialog.c:
1731 Added get_supported_secure_authentication_methods(), though it is mostly
1732 commented-out for now until the necessary API is committed to tinymail.
1733 (modest_account_settings_dialog_set_account_name),
1734 (save_configuration): Request the supported authentication methods from the
1735 server, so we can choose a working method.
1737 * src/modest-tny-account-store.h:
1738 * src/modest-tny-account-store.c:
1739 (modest_tny_account_store_get_session): Rename from
1740 tny_account_store_get_session().
1742 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1744 * src/modest-protocol-info.h: Split the ModestProtocol enum
1745 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1746 There was no need to have these unrelated values in one enum.
1748 * src/: many files: Adapted to changed enum. This makes the code a bit
1749 clearer, and the compiler could catch some errors.
1751 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1753 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1754 Show the detailed internal camel error message when an error happens
1755 during the configuration, so that our testers can give us more clues.
1756 For instance, in projects.maemo.org bug NB#56910 .
1758 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1760 * src/modest-tny-account.c:
1761 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1762 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1764 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1766 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1767 * src/maemo/modest-account-settings-dialog.c:
1768 (modest_account_settings_dialog_set_account_name),
1769 (save_configuration): For the incoming secure authentication checkbox,
1770 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1771 the UI specification. PLAIN does not seem to be supported for most IMAP
1772 servers anyway, and I am not sure what it would mean.
1773 However, we probably need to discover which of the secure-authentication
1774 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1775 * src/modest-account-mgr-helpers.c:
1776 (modest_account_mgr_get_server_account_data):
1778 * src/modest-tny-account.c:
1779 (modest_tny_account_new_from_server_account):
1780 Use tny_account_set_mech() to set secure-authentication methods,
1781 with some special-casing for IMAP, based on my observations of how
1784 * src/modest-account-mgr-helpers.h:
1785 * src/modest-account-mgr.c:
1786 * src/modest-defs.h: Comment that the URI is only used for local folders.
1788 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1790 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1791 parameter const, just to be neat.
1792 * src/modest-text-utils.c: (modest_text_utils_inline):
1793 End g_strconcat() with NULL, as its documentation says. This is almost
1794 certainly the cause of my crash at startup on the device. Interestingly,
1795 valgrind doesn't tell us about these errors.
1797 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1799 * scripts/build-packages: Added more precise comments about how to use
1800 this script, though I still get this error:
1801 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1802 error building tinymail
1804 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1806 * src/maemo/modest-main-window.c: (on_account_update):
1807 Very slight cleanup, hoping to make it simpler to discover what causes
1808 a crash here sometimes.
1810 * src/modest-tny-account.c:
1811 (modest_tny_account_new_from_server_account): Set the port. Added
1812 comments about the options and a TODO comment because I need to find out
1813 how to specify the secure authentication method.
1815 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1817 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1818 changed CFlags paths form modest to libmodest
1820 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1822 * src/modest-account-mgr-helpers.c:
1823 (modest_account_mgr_get_server_account_data),
1824 (modest_account_mgr_free_server_account_data):
1825 * src/modest-account-mgr-helpers.h:
1826 * src/modest-account-mgr.c:
1827 (modest_account_mgr_add_server_account):
1828 * src/modest-defs.h:
1829 * src/modest-tny-account.c:
1830 (modest_tny_account_new_from_server_account):
1831 Determine the options for tny_camel_account_add_option() here,
1832 based on the settings, rather than storing them directly in gconf.
1834 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1836 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1837 Show a more friendly error dialog now that we expect (from the tinymail
1838 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1840 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1842 * src/maemo/modest-main-window.c: (on_account_update): Check that
1843 account_name is not NULL, to prevent a crash at startup that I am
1844 seeing on the N800. I do wonder why it is NULL.
1846 * src/maemo/easysetup/modest-easysetup-wizard.c:
1847 (create_page_user_details):
1848 * src/maemo/modest-account-settings-dialog.c:
1849 (create_page_user_details), (create_page_outgoing):
1850 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1851 (modest_connection_specific_smtp_edit_window_init):
1852 * src/modest-ui-actions.c:
1853 (modest_ui_actions_on_password_requested):
1854 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1855 might do something useful with the on-screen keyboard.
1857 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1859 * src/maemo/modest-main-window.c: (on_account_update):
1860 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1861 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1863 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1865 * src/modest-tny-account-store.c: (on_account_changed):
1866 Correct the signature of this signal handler.
1868 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1870 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1871 Show a HildonNote instead of a GtkDialog for Maemo.
1873 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1875 * src/widgets/modest-account-view.h:
1876 * src/widgets/modest-account-view.c: (on_account_changed),
1877 (on_account_removed). Added a boolean flag, set/unset by
1878 modest_account_view_block_conf_updates(),
1879 modest_account_view_unblock_conf_updates() to prevent unnecessary
1880 updates, but this is not very useful because the gconf notifications are
1881 so delays (maybe only on Maemo Bora).
1882 So auto-updating is turned off, and these functions do an explicit
1883 update when necessary.
1884 However, something else is still doing too much work when adding/removing
1885 accounts, probably in another part of the application.
1887 * src/maemo/modest-account-view-window.c:
1888 (on_delete_button_clicked), (on_edit_button_clicked),
1889 (on_new_button_clicked): Use the new functions.
1891 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1893 * src/modest-account-mgr-helpers.c:
1894 (modest_account_mgr_set_first_account_as_default):
1895 Sort the list of names alphabetically-by-title, so we choose the first one
1897 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1898 alphabetically by the title.
1900 This fixes projects.maemo.org bug NB#56418 .
1902 * src/modest-account-mgr-priv.c:
1903 (_modest_account_mgr_account_from_key):
1904 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1905 avoid a valgrind error, and possible random behaviour.
1907 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1909 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1910 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1911 tinymail documentation to say that this can be expected.
1912 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1913 pretty, and should not happen, but I would prefer to know when it does.
1915 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1917 * configure.ac: When using the older hildon version, probably on Bora,
1918 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1920 * src/widgets/modest-attachment-view.c:
1921 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1924 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1926 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1927 Implemented the prototype. Can be tested with
1928 tests/dbus_api/test_open_message:
1930 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1932 * src/modest-tny-account-store.c:
1933 (modest_tny_account_store_instance_init), (get_password):
1934 * src/modest-ui-actions.c:
1935 (modest_ui_actions_on_password_requested):
1936 Do not store the password in gconf, because this function is called
1937 for non-remembered passwords. Actually use the cached (in the hash map)
1938 password instead of releasing it.
1939 The password will now not be remembered if it is asked via the protected
1940 password dialog, as per the UI spec.
1942 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1944 * src/modest-defs.h:
1945 * src/modest-account-mgr-helpers.h:
1946 * src/modest-account-mgr-helpers.c:
1947 Added modest_server_account_get_username_has_succeeded(),
1948 modest_server_account_set_username_has_succeeded().
1949 (modest_server_account_set_username),
1950 Reset the has-succeeded flag if the username changes.
1952 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1953 * src/maemo/modest-connection-specific-smtp-window.c:
1954 (modest_connection_specific_smtp_window_save_server_accounts):
1955 Use modest_server_account_set_username() instead of using
1956 modest_conf_set_string() directly, so that the has-succeeded flag is always
1959 * src/modest-ui-actions.c:
1960 (modest_ui_actions_on_password_requested): Dim the username entry if
1961 the username has ever worked, as per the UI spec.
1963 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1965 * src/modest-tny-account-store.c: (get_password):
1966 * src/modest-ui-actions.c:
1967 (modest_ui_actions_on_password_requested):
1968 Allow the username to be changed too, though there is more work to
1969 be done on exactly how this behaves.
1971 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1973 * src/modest-account-mgr-helpers.h:
1974 * src/modest-account-mgr-helpers.c:
1975 Added modest_account_mgr_get_display_name(),
1976 modest_server_account_get_username(),
1977 modest_server_account_set_username(),
1978 modest_server_account_set_password(),
1979 modest_server_account_get_hostname() functions so we do not need to
1980 use the conf API directly.
1982 * src/maemo/modest-main-window.c: (connect_signals):
1983 Actually connect ot the ModestAccountStore::request-password signal,
1984 so that we show the dialog when the password is requested by Tinymail,
1985 for isntance if it is empty.
1987 * src/modest-marshal.list:
1988 * src/modest-tny-account-store.c:
1989 (modest_tny_account_store_class_init), (get_password),
1990 (modest_tny_account_store_alert):
1991 * src/modest-tny-account-store.h:
1992 * src/modest-ui-actions.h:
1993 * src/modest-ui-actions.c:
1994 (modest_ui_actions_on_password_requested):
1995 Change the signal parameters, so it is obvious that we are providing
1996 the non human-readable server name, and receiving both the username
1997 and password, though changing of the username is not yet implemented.
1998 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1999 for the GNOME version.
2001 This should fix the projects.maemo.org bug NB#56209, though it does not
2002 work on Bora, because the gconf_client_get() for the password fails
2003 immediately after we save it with gconf_client_set().
2005 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2008 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2009 caused an undefined symbol error:
2010 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2012 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2014 * src/modest-tny-account-store.c:
2015 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2016 using a GError instead of a string message, so we can translate it in
2019 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2021 * src/maemo/modest-address-book.c:
2022 (modest_address_book_check_names):
2023 * src/maemo/modest-msg-view-window.c:
2024 (modest_msg_view_window_clipboard_owner_change):
2025 * src/modest-init.c: (modest_init_init_ui):
2026 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2027 (update_folders_cb), (modest_mail_operation_update_account):
2028 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2029 (modest_ui_actions_on_msg_attachment_clicked),
2030 (modest_ui_actions_on_msg_recpt_activated):
2031 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2032 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2033 (modest_msg_view_search_next):
2034 * src/widgets/modest-recpt-editor.c:
2035 (modest_recpt_editor_on_button_release_event),
2036 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2037 g_message(). At this point we should only be seeing interesting errors on
2038 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2040 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2042 (modest_wizard_dialog_force_title_update):
2043 * src/maemo/easysetup/modest-wizard-dialog.h:
2044 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2045 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2046 can update the title when appropriate. Otherwise the title is wrong if the
2047 pages are added after adding the notebook to the dialog.
2048 This must be a problem in HildonWizardDialog too.
2049 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2051 * src/maemo/easysetup/modest-easysetup-wizard.c:
2052 (create_subsequent_customsetup_pages),
2053 (create_subsequent_easysetup_pages):
2054 Call modest_wizard_dialog_force_title_update() so that the title is
2055 correct even with GTK+ < 2.10.
2056 This fixes projects.maemo.org bug NB#56145 .
2058 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2060 * src/maemo/modest-platform.c:
2061 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2062 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2065 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2067 * src/widgets/modest-window.h:
2068 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2069 and modest_window_save_state(), which invokes it.
2071 * src/widgets/modest-window-mgr.h:
2072 * src/widgets/modest-window-mgr.c:
2073 Added modest_window_mgr_save_state_for_all_windows(), which calls
2074 the save_state vfunc on all registered windows, if implemented.
2076 * src/gnome/modest-msg-edit-window.c:
2077 * src/gnome/modest-msg-view-window.c:
2078 * src/maemo/modest-msg-edit-window.c:
2079 * src/maemo/modest-msg-view-window.c:
2080 * src/maemo/modest-main-window.c:
2081 Specify the existing save_settings functions as implementations of
2082 ModestWindow::save_state_func().
2084 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2085 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2086 enabling hibernation, for instance.
2088 We may need to do the same thing for restoring settings.
2091 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2093 * src/widgets/modest-window-mgr.c:
2094 * src/widgets/modest-window-mgr.h:
2095 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2096 modest_window_mgr_get_hibernation_is_prevented().
2098 * src/maemo/modest-main-window.c:
2099 (on_hildon_program_is_topmost_notify): Prevent hibernation
2100 (possible when the application goes to the background in the WM),
2101 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2103 * src/maemo/easysetup/modest-easysetup-wizard.c:
2104 (modest_easysetup_wizard_dialog_init):
2105 * src/maemo/modest-account-settings-dialog.c:
2106 (modest_account_settings_dialog_init):
2107 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2108 (modest_connection_specific_smtp_edit_window_init):
2109 * src/maemo/modest-connection-specific-smtp-window.c:
2110 (modest_connection_specific_smtp_window_init):
2111 * src/maemo/modest-signature-editor-dialog.c:
2112 (modest_signature_editor_dialog_init):
2113 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2114 prevent hibernation while any of these account settings dialogs are open.
2116 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2118 * src/maemo/Makefile.am:
2119 * src/maemo/modest-osso-state-saving.c:
2120 * src/maemo/modest-osso-state-saving.h: Added
2121 modest_osso_load_state() and modest_osso_save_state() though they do
2122 nothing now. They should iterate through all the open windows and load/save
2124 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2125 save state when closing.
2127 * src/maemo/modest-main-window.c:
2128 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2129 Add a notification handler for the HildonProgram::is-topmost property,
2130 so we can allow hibernation when the application goes into the background.
2131 But we still need to detect when the accounts setup windows are open so
2132 we can stop hibernation when they are open.
2133 To do this, I also added the main window the HildonProgram. This might have
2134 other side-effects/benefits, and should maybe be done for other windows.
2136 * src/maemo/modest-osso-autosave-callbacks.h:
2137 * src/maemo/modest-osso-autosave-callbacks.c:
2138 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2139 though it does not do anything yet, and we might never need this to do
2140 anything. For instance, we already save drafts.
2142 * src/maemo/modest-platform.c: (modest_platform_init):
2143 Specify the libosso auto-save callback.
2145 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2147 * src/maemo/modest-platform.c:
2148 (modest_platform_set_update_interval):
2149 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2150 aparently stays valid between application instances, so we can use this
2151 to remove and reset it later. According to a maemo-developers email from
2154 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2156 * configure.ac: Depend on libalarm for Maemo.
2158 * src/dbus_api/modest-dbus-api.h:
2159 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2160 (on_send_receive), (modest_dbus_req_handler):
2161 Handle a SEND_RECEIVE D-Bus method.
2163 * libmodest-dbus-client/libmodest-dbus-client.c:
2164 (libmodest_dbus_client_send_and_receive):
2165 * libmodest-dbus-client/libmodest-dbus-client.h:
2166 Add C convenience functions for calling the new D-Bus method.
2168 * src/modest-platform.h:
2169 * src/gnome/modest-platform.c:
2170 * src/maemo/modest-platform.c:
2171 Added modest_platform_set_update_interval(), which uses the
2172 alarmd API on Maemo.
2173 (modest_platform_init),
2174 Call modest_platform_set_update_interval(), using a hard-coded
2175 interval for now (until the global settings dialog is implemented),
2176 though I am not sure that this makes sense yet.
2178 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2180 * src/dbus_api/modest-dbus-callbacks.c:
2181 (modest_osso_cb_hw_state_handler):
2182 * src/dbus_api/modest-dbus-callbacks.h:
2183 * src/maemo/modest-platform.c: (modest_platform_init):
2184 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2185 in case this has some effect on the ability for Maemo to ping the
2188 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2190 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2191 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2192 warning. It is probably a logic error, but I need to fix the build.
2194 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2196 * src/modest-account-mgr.h:
2197 * src/modest-account-mgr.c:
2198 (modest_account_mgr_account_names): Add a gboolean enabled_only
2199 parameter, so we can get lists of onlt the enabled accounts.
2201 (modest_account_mgr_add_account),,
2202 (modest_account_mgr_account_with_display_name_exists):
2203 * src/maemo/modest-msg-edit-window.c: (get_transports):
2204 * src/modest-account-mgr-helpers.c:
2205 (modest_account_mgr_set_first_account_as_default):
2206 * src/modest-init.c: (init_default_account_maybe):
2207 * src/modest-tny-account-store.c: (get_accounts):
2208 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2209 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2210 * tests/check_account-mgr.c: (START_TEST):
2211 Provide the extra parameter, as appropriate.
2213 * src/widgets/modest-account-view.c: (update_account_view):
2214 Do not show disabled accounts (meaning that there is no way to
2215 enable/disable accounts in the UI (the feature is not in our UI
2216 specification), so we can use this internally only to mark unfinished
2217 or temporary account data.
2219 * src/maemo/easysetup/modest-easysetup-wizard.c:
2220 (create_account): Add boolean enable parameter, so we can specify FALSE
2221 to create the temporary account.
2222 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2223 (on_before_next): When finishing, when there is a temporary account, just
2225 Also, use a timeout to delay the showing of the dialog until gconf is likely
2226 to return correct information, due to a maemo gconf bug that is fixed in
2227 osso 1.1, but not yet in Bora.
2228 However, the dialog stays on screen after it is destroyed.
2230 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2231 for invalid data when cancelling. Use a hildon note instead of a dialog
2232 to complain about invalid data. Do not show the account-saved note if the
2233 account is disabled (a temporary account that will not really be saved for use
2236 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2238 * src/modest-account-mgr-helpers.h:
2239 * src/modest-account-mgr-helpers.c:
2240 Added modest_account_mgr_unset_default_account(),
2241 Added modest_account_mgr_set_first_account_as_default().
2243 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2244 If it was the default account, unset the default account name.
2246 * src/maemo/modest-account-view-window.c:
2247 (on_delete_button_clicked): If it was the default account,
2248 set the first remaining account as the default instead.
2250 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2251 a NULL account or a NULL default account, to prevent a crash. This should
2252 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2255 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2257 * src/widgets/modest-recpt-editor.c:
2258 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2259 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2260 TODO comment for this. This fixes the build.
2262 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2263 be the best place for it. This will in future update all auto-update accounts,
2264 rather than just the current/default account, when that gconf key exists.
2265 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2266 if there are no accounts, before calling do_send_receive().
2267 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2269 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2270 * src/maemo/modest-main-window-ui.h:
2271 * src/maemo/modest-main-window.c: (on_connection_changed),
2272 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2273 directly, becaue the signal handler does more.
2275 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2277 * src/modest-account-mgr-helpers.c:
2278 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2279 for the case that the account does not exist.
2281 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2282 (equivalent to the modest account name) rather than the tinymail account name
2283 (equivalent to the modest account title - human readable) to get the account data.
2284 Check for null account data to prevent the crash, and add a TODO comment saying that
2285 this needs fixing because it is using the server account name instead of the account name.
2287 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2289 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2290 * src/maemo/modest-account-settings-dialog.c: (show_error),
2292 Use hildon_note_new_information() for informative and error messages,
2293 which seems to be expected for Maemo applications (no documentation that I know of
2294 says this). I am surprised that there is no distinction between info and error
2297 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2299 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2300 it is easy to find where this is used.
2302 * src/maemo/easysetup/modest-easysetup-wizard.c:
2303 (create_page_welcome), (create_page_account_details),
2304 (create_page_user_details), (create_page_complete_easysetup),
2305 (create_page_custom_incoming), (create_page_custom_outgoing),
2306 (create_page_complete_custom):
2307 * src/maemo/modest-account-settings-dialog.c:
2308 (create_page_account_details), (create_page_user_details),
2309 (create_page_incoming), (create_page_outgoing):
2310 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2311 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2312 (modest_connection_specific_smtp_edit_window_init):
2313 * src/maemo/modest-connection-specific-smtp-window.c:
2314 (modest_connection_specific_smtp_window_init):
2315 * src/maemo/modest-signature-editor-dialog.c:
2316 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2317 and scrolling policy as per the Email Application Layout Guide, if I have
2320 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2322 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2323 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2324 which were empty, because these vfuncs have been removed from TnyAccountStore.
2325 This fixes the build.
2327 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2329 * src/maemo/modest-main-window.c:
2330 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2331 showing/hiding it. Added TODO because it probably should not be NULL.
2332 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2333 because unnecessary g_warnings() make degugging difficult.
2335 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2337 * src/maemo/modest-msg-edit-window.c:
2338 (modest_msg_edit_window_select_color),
2339 (modest_msg_edit_window_select_background_color): 2 const corrections and
2340 moving 2 #endifs before closing brackets, to fix the build.
2342 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2344 * src/maemo/easysetup/modest-easysetup-wizard.h:
2345 * src/maemo/easysetup/modest-easysetup-wizard.c:
2346 (modest_easysetup_wizard_dialog_finalize),
2347 (on_button_edit_advanced_settings), (create_page_complete_custom),
2348 (on_response), (create_account):
2349 Implement the Advanced Settings edit button, by saving the account information,
2350 for the Advanded Settings dialog to use directly from gconf, and removing it
2351 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2352 Bug #5533 in the projects.maemo.org bugzilla.
2354 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2356 * src/maemo/modest-msg-view-window.c:
2357 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2358 when opening a message window.
2360 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2362 * src/maemo/easysetup/modest-easysetup-wizard.c:
2363 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2366 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2367 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2368 gconf settings. I probably added more checks than necessary, but that is safer.
2370 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2371 variable to fix the build, but this seems to be used when it is still NULL.
2373 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2375 * src/modest-platform.h:
2376 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2377 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2378 * src/modest-main.c: Implement this function so we can avoid using
2379 maemo-specific API from cross-platform code.
2381 * src/modest-tny-account-store.c:
2382 (get_smtp_specific_transport_account_for_open_connection):
2383 * src/modest-ui-actions.c: (check_for_connection),
2384 (modest_ui_actions_on_item_not_found):
2385 Use modest_platform_connect_and_wait() and put #idefs around other
2386 maemo-specific code, because only maemo currently has a way to
2387 identify connection names.
2389 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2391 * src/modest-tny-account-store.h:
2392 * src/modest-tny-account-store.c:
2393 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2394 the connection-specific SMTP server settings in the configuration.
2396 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2398 * src/maemo/modest-main-window.c: (on_connection_changed),
2400 * src/modest-main.c: (main), (start_ui), (send_mail):
2401 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2402 that is what is intended.
2404 * src/modest-ui-actions.c: (action_send), (action_receive),
2405 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2406 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2407 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2408 SMTP server is used when it is specified.
2410 (modest_ui_actions_on_send_receive):
2411 Check that a connection is open before proceeding.
2412 Receive and then send, instead of vice-versa, as per the specification.
2414 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2416 * src/modest-mail-operation.c:
2417 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2418 though I guess it should be something other than NULL.
2420 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2422 * src/maemo/easysetup/modest-easysetup-wizard.c:
2423 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2424 combo twice, to avoid an g_warning and to make it visible again.
2425 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2426 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2427 (already intended) dereference when detaching, because we then recreate the menu.
2428 But I am not sure why the warning was happening, and it is possible that this is a memory
2431 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2433 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2434 and uri_parse_mailto() utility functions.
2435 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2437 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2439 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2441 * src/dbus_api/modest-dbus-api.h:
2442 * src/dbus_api/modest-dbus-callbacks.c:
2443 Use an idle callback to execute the modest code in the application's own thread.
2444 Remove the helloworld example method.
2445 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2446 parsed, and the open-message method is not implemented because this is not yet implemented in
2448 * libmodest-dbus-client/libmodest-dbus-client.c:
2449 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2450 (libmodest_dbus_client_open_message):
2451 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2453 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2454 body without crashing.
2456 * tests/dbus_api/Makefile.am:
2457 * tests/dbus_api/test_mail_to.c:
2458 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2460 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2462 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2463 Added file to fix the build. Sorry.
2465 * src/dbus_api/Makefile.am:
2466 * src/dbus_api/modest-dbus-api.h:
2467 * src/dbus_api/modest-dbus-callbacks.h:
2468 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2469 (modest_dbus_req_handler):
2470 Put constants in a separate header so it can be reused by the
2471 client library, without duplication
2473 * libmodest-dbus-client/Makefile.am:
2474 * libmodest-dbus-client/libmodest-dbus-client.c:
2475 (libmodest_dbus_client_call_helloworld),
2476 (libmodfest_dbus_client_send_mail),
2477 (libmodfest_dbus_client_mailto),
2478 (libmodfest_dbus_client_open_message):
2479 * libmodest-dbus-client/libmodest-dbus-client.h:
2480 (Partly) Implement a send_mail D-Bus method.
2482 * tests/dbus_api/Makefile.am:
2483 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2484 the send_email D-Bus method.
2486 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2490 * libmodest-dbus-client/Makefile.am:
2491 * libmodest-dbus-client/libmodest-dbus-client.c:
2492 * libmodest-dbus-client/libmodest-dbus-client.h:
2493 * tests/dbus_api/Makefile.am:
2494 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2495 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2497 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2499 * src/maemo/easysetup/modest-easysetup-wizard.c:
2500 (create_page_account_details):
2501 * src/maemo/modest-account-settings-dialog.c:
2502 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2503 widgets, because this might not be the default in future versions of the Maemo GTK+.
2504 However, I can not not get capitalization to work even in a simple test case.
2506 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2508 * src/maemo/easysetup/modest-easysetup-wizard.c:
2509 (create_page_custom_incoming), (create_page_custom_outgoing):
2510 * src/maemo/modest-account-settings-dialog.c:
2511 (create_page_account_details), (create_page_incoming),
2512 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2513 instead of using gtk_check_button_with_label(), so they are aligned like the other
2514 widgets, as per the UI spec.
2516 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2518 * src/maemo/easysetup/modest-easysetup-wizard.c:
2519 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2520 * src/widgets/modest-validating-entry.c:
2521 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2522 Modest prefix instead of an EasySetup prefix.
2524 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2526 * src/widgets/modest-validating-entry.h:
2527 * src/widgets/modest-validating-entry.c: (on_insert_text),
2528 Added easysetup_validating_entry_set_max_func(), used to set a callback
2529 to call when the max number of characters is reached. GtkEntry has a max-length
2530 already but is silent about it.
2532 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2533 (create_page_account_details), (create_page_user_details),
2535 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2536 (create_page_account_details), (create_page_user_details),
2537 (create_page_outgoing):
2538 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2539 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2540 the UI spec, when the user tries to enter more than the max number of characters.
2542 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2544 * src/maemo/easysetup/modest-easysetup-wizard.c:
2545 (create_page_user_details), (create_page_custom_incoming),
2546 (create_page_custom_outgoing):
2547 * src/maemo/modest-account-settings-dialog.c:
2548 (create_page_user_details), (create_page_incoming),
2549 (create_page_outgoing):
2550 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2551 (modest_connection_specific_smtp_edit_window_init):
2552 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2553 not appropriate. Bad Maemo-specific defaults!.
2555 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2557 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2558 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2559 (modest_signature_editor_dialog_set_settings):
2560 Disable the label and textview when the checkbox is disabled, and use the
2561 specified (UI spec) default signature text.
2563 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2565 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2566 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2568 * src/modest-defs.h:
2569 * src/modest-account-mgr-helpers.h:
2570 * src/modest-account-mgr-helpers.c:
2571 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2573 * src/maemo/Makefile.am:
2574 * src/maemo/modest-signature-editor-dialog.c:
2575 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2578 * src/maemo/modest-account-settings-dialog.h:
2579 * src/maemo/modest-account-settings-dialog.c:
2580 (modest_account_settings_dialog_finalize), (on_button_signature),
2581 (save_configuration): Use the new dialog when the Edit button is pressed, and
2582 save the changes if necessary, as per the UI spec.
2584 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2586 * src/maemo/Makefile.am:
2587 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2588 based on maemo-develoers email from Dirk.
2590 * src/maemo/easysetup/modest-easysetup-wizard.c:
2591 (create_page_welcome), (create_page_account_details),
2592 (create_page_user_details), (create_page_complete_easysetup),
2593 (create_page_custom_incoming), (create_page_custom_outgoing),
2594 (create_page_complete_custom),
2595 (modest_easysetup_wizard_dialog_init):
2596 * src/maemo/modest-account-settings-dialog.c:
2597 (create_page_account_details), (create_page_user_details),
2598 (create_page_incoming), (create_page_outgoing),
2599 (modest_account_settings_dialog_init):
2600 * src/maemo/modest-connection-specific-smtp-window.c:
2601 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2603 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2605 * src/maemo/easysetup/modest-easysetup-wizard.c:
2606 (create_page_account_details), (create_page_custom_outgoing),
2607 (create_page_complete_custom):
2608 * src/maemo/modest-account-settings-dialog.c:
2609 (create_page_user_details), (create_page_incoming),
2610 (create_page_outgoing):
2611 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2612 (modest_connection_specific_smtp_edit_window_init):
2613 Use the correct (UI spec) port min/max, and use horizontal separators,
2616 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2618 * src/maemo/easysetup/modest-easysetup-wizard.c:
2619 (set_default_custom_servernames):
2620 * src/maemo/modest-account-settings-dialog.c:
2621 (create_page_incoming), (on_combo_outgoing_security_changed),
2622 (on_combo_incoming_security_changed), (create_page_outgoing),
2623 (modest_account_settings_dialog_set_account_name),
2624 (save_configuration):
2625 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2626 (on_combo_security_changed),
2627 (modest_connection_specific_smtp_edit_window_init),
2628 (modest_connection_specific_smtp_edit_window_set_connection),
2629 (modest_connection_specific_smtp_edit_window_get_settings):
2630 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2633 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2636 * src/maemo/easysetup/modest-easysetup-wizard.c:
2637 (create_page_custom_outgoing), (create_page_complete_custom):
2638 * src/maemo/modest-account-settings-dialog.c:
2639 (create_page_user_details), (create_page_outgoing):
2640 * src/maemo/modest-account-view-window.c: (button_box_new):
2641 Use changed logical IDs as per the most recent UI spec:
2642 mcen_bd_emailsetup_edit -> mcen_bd_edit
2643 mcen_bd_emailsetup_delete -> mcen_bd_delete
2644 mcen_bd_emailsetup_close -> mcen_bd_close
2646 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2650 * src/dbus_api/Makefile.am:
2651 * src/dbus_api/modest-dbus-callbacks.c:
2652 * src/dbus_api/modest-dbus-callbacks.h:
2653 * src/maemo/modest-platform.c: (modest_platform_init):
2654 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2656 * tests/Makefile.am:
2657 * tests/dbus_api/Makefile.am:
2658 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2660 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2662 * src/maemo/modest-account-settings-dialog.c:
2663 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2664 Removed unnecessary includes.
2666 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2668 * src/maemo/easysetup/modest-easysetup-wizard.c:
2669 * src/maemo/modest-account-settings-dialog.c:
2670 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2671 * src/widgets/Makefile.am:
2672 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2673 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2674 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2675 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2676 * src/widgets/modest-secureauth-combo-box.c:
2677 * src/widgets/modest-secureauth-combo-box.h:
2678 * src/widgets/modest-serversecurity-combo-box.c:
2679 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2680 made the GObject names more consistent with the rest of the Modest code.
2682 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2684 * src/maemo/easysetup/Makefile.am:
2685 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2686 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2687 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2688 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2689 * src/maemo/easysetup/modest-easysetup-wizard.c:
2690 * src/maemo/easysetup/modest-validating-entry.c:
2691 * src/maemo/easysetup/modest-validating-entry.h:
2692 * src/maemo/modest-account-settings-dialog.c:
2693 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2694 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2695 widgets/ because they are used outside of easysetup too. After checking in,
2696 svn will allow me to rename them too.
2698 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2700 * src/gnome/modest-msg-edit-window.c:
2701 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2702 linker error, to fix the build on the GNOME platform.
2703 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2704 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2705 ifdefed out to avoid a warning.
2707 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2709 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2710 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2711 some alternative for GTK+ 2.6.
2713 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2715 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2717 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2718 specified for EmailAccountsDialog in UI spec.
2720 * src/maemo/easysetup/modest-easysetup-wizard.c:
2721 * src/maemo/easysetup/modest-easysetup-wizard.h:
2722 * src/maemo/modest-account-settings-dialog.c:
2723 * src/maemo/modest-account-settings-dialog.h:
2724 Reuse a member window widget for the connection-specific SMTP server accounts,
2725 so we can tell it to create/save the accounts only if we actually save changes.
2727 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2728 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2729 (modest_connection_specific_smtp_edit_window_get_settings):
2730 Return a struct instance for temporarily remembering the entered data.
2732 * src/maemo/modest-connection-specific-smtp-window.h:
2733 * src/maemo/modest-connection-specific-smtp-window.c:
2734 (modest_connection_specific_smtp_window_finalize),
2735 (modest_connection_specific_smtp_window_fill_with_connections),
2737 (modest_connection_specific_smtp_window_save_server_accounts),
2738 (update_model_server_names): Do not actually save data until asked,
2739 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2741 (on_selection_changed),
2742 (modest_connection_specific_smtp_window_init): Disable the edit
2743 button when nothing is selected.
2745 * src/modest-account-mgr-helpers.c:
2746 * src/modest-account-mgr-helpers.h:
2747 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2750 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2752 * src/modest-account-mgr-helpers.h:
2753 * src/modest-account-mgr-helpers.c:
2754 (modest_account_mgr_get_unused_account_name),
2755 (modest_account_mgr_get_unused_account_display_name): Added these
2756 utility functions, to avoid code duplication.
2758 * src/maemo/easysetup/modest-easysetup-wizard.c:
2759 (create_page_account_details), (create_account):
2760 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2761 (on_combo_security_changed),
2762 (modest_connection_specific_smtp_edit_window_init),
2763 (modest_connection_specific_smtp_edit_window_save_settings):
2764 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2765 * src/maemo/modest-connection-specific-smtp-window.c:
2766 (modest_connection_specific_smtp_window_finalize),
2767 (modest_connection_specific_smtp_window_fill_with_connections),
2768 (on_button_edit), (modest_connection_specific_smtp_window_init):
2769 * src/maemo/modest-connection-specific-smtp-window.h:
2770 Implementing saving of connection-specific server accounts.
2772 But I need to refactor this so we can save the data for each
2773 possible connection-specific account and only actually create the server accounts
2774 when the easysetup finished, or the OK button is pressed on the account settings
2777 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2779 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2780 (on_combo_security_changed):
2781 (modest_connection_specific_smtp_edit_window_init):
2782 Auto-fill the port number as in the account settings.
2784 (modest_connection_specific_smtp_edit_window_set_connection):
2785 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2786 * src/maemo/modest-connection-specific-smtp-window.c:
2787 (fill_with_connections), (on_button_edit),
2788 (modest_connection_specific_smtp_window_init):
2789 Turn the edit window into a dialog to simplify the code, and
2790 set a WM hint as in a GtkDialog, because only a popup can be on top of
2791 another window in Maemo, and popups usually have no WM decoration.
2793 * src/modest-defs.h:
2794 * src/modest-account-mgr-helpers.c:
2795 (modest_account_mgr_set_connection_specific_smtp),
2796 (modest_account_mgr_remove_connection_specific_smtp),
2797 (modest_account_mgr_get_connection_specific_smtp):
2798 * src/modest-account-mgr-helpers.h: Some functions to write the
2799 connection-specific SMTP server information. Not yet used.
2802 * src/widgets/modest-folder-view.c: (text_cell_data):
2803 Fix a warning about an uninitialized variable.
2804 (on_configuration_key_changed): Put an #ifdef around the use
2805 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2807 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2809 * src/maemo/modest-account-settings-dialog.h:
2810 * src/maemo/modest-account-settings-dialog.c:
2811 Added connect_for_modified() utility function to mark the new modified boolean.
2813 (create_page_account_details), (create_page_user_details),
2814 (create_page_incoming), (create_page_outgoing), (on_response),
2815 (modest_account_settings_dialog_init),
2816 (modest_account_settings_dialog_set_account_name):
2817 Only warn about unsaved changes when there are actually unsaved changes.
2819 * src/modest-account-mgr-helpers.c:
2820 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2821 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2822 to get the data from there in future.
2824 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2826 * src/modest-defs.h:
2828 * src/modest-account-mgr-helpers.h:
2829 * src/modest-account-mgr-helpers.c:
2830 Store the security account setting in a single conf key instead of using
2831 the options list, so that the list is left for just the to-be-removed camel hack,
2832 and because gconf_client_set_list() is failing for some reason.
2834 * src/modest-account-mgr.c:
2835 (modest_account_mgr_add_server_account):
2836 * src/maemo/modest-account-settings-dialog.c:
2837 (modest_account_settings_dialog_set_account_name),
2838 (save_configuration): Use the renamed functions.
2841 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2843 * src/widgets/Makefile.am:
2844 * src/widgets/modest-limit-retrieve-combo-box.c:
2845 * src/widgets/modest-limit-retrieve-combo-box.h:
2846 * src/widgets/modest-retrieve-combo-box.c:
2847 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2848 the account settings dialog.
2850 * src/modest-defs.h:
2851 * src/modest-account-mgr-helpers.h:
2852 * src/modest-account-mgr-helpers.c:
2853 (modest_server_account_get_option_secure_auth),
2854 (modest_server_account_set_option_secure_auth):
2855 * src/modest-account-mgr.c:
2856 (modest_account_mgr_add_server_account):
2857 Use the existing AUTH_MECH conf key for the secure-auth setting,
2858 instead of putting it in the list options, because this was actually used already.
2860 * src/maemo/modest-account-settings-dialog.c:
2861 (create_page_account_details),
2862 (modest_account_settings_dialog_set_account_name),
2863 (save_configuration):
2864 * src/maemo/modest-account-settings-dialog.h:
2865 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2866 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2868 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2870 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2871 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2872 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2874 * src/modest-defs.h:
2875 * src/maemo/modest-account-settings-dialog.c:
2876 (create_page_incoming), (on_combo_outgoing_security_changed),
2877 (on_combo_incoming_security_changed), (create_page_outgoing),
2878 (modest_account_settings_dialog_set_account_name),
2879 (save_configuration): Load/Save the port number, and change it when the
2880 security combo changes, to suitable defaults.
2882 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2884 * src/modest-account-mgr.c:
2885 (modest_account_mgr_add_server_account): Set the security and secure-auth
2886 options, and add a comment saying that the other camel-specific options should be
2889 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2891 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2893 * src/modest-tny-account-store.c: (account_list_free),
2894 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2895 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2898 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2900 * src/modest-protocol-info.c:
2901 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2902 is required by our UI spec. Maybe something in our implementation will use this eventually.
2903 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2904 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2905 instead of the previous 0 placeholder.
2907 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2908 secure-auth settings.
2909 * src/modest-account-mgr-helpers.h:
2910 * src/modest-account-mgr-helpers.c:
2911 (modest_server_account_data_get_option_secure_auth),
2912 (modest_server_account_set_option_secure_auth),
2913 (modest_server_account_data_get_option_security),
2914 (modest_server_account_set_option_security): Added this API for getting and setting the security
2915 and secure-auth settings.
2917 * src/maemo/modest-account-settings-dialog.h:
2918 * src/maemo/modest-account-settings-dialog.c:
2919 (modest_account_settings_dialog_finalize), (check_data),
2920 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2921 about changing titles.
2922 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2923 (save_configuration): Save the security and secure-auth settings.
2925 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2926 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2928 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2930 * src/modest-defs.h:
2931 * src/modest-account-mgr.c:
2932 (modest_account_mgr_add_server_account):
2933 Added and used defines for the options key and value pair strings,
2934 that are used so far, though they do not seem to correspond to anything in our
2935 UI specs or ModestProtocol enum.
2937 * src/modest-account-mgr-helpers.h:
2938 * src/modest-account-mgr-helpers.c:
2939 (compare_option_strings_for_name),
2940 (modest_server_account_data_get_option_value),
2941 (modest_server_account_data_get_option_bool),
2942 (modest_account_mgr_get_server_account_option):
2943 Added helper functions for parsing the options GSList.
2945 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2947 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2948 display name is based on the supplied account name.
2949 * src/modest-account-mgr.c:
2950 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2951 with an inefficient, but good-enough, implementation.
2953 * src/maemo/easysetup/modest-easysetup-wizard.c:
2954 (create_page_account_details), (on_before_next), (create_account):
2955 Check for existing display names rather than (non-user-visible) account names, and just
2956 create and set a unique account name at the end.
2958 * src/maemo/modest-account-settings-dialog.c:
2959 (modest_account_settings_dialog_init),
2960 (modest_account_settings_dialog_set_account_name),
2961 (create_page_incoming): Show the display name, instead of the account name.
2962 (on_response): Do some (not all) extra checks, as in the UI spec.
2963 (save_configuration): Save the display name if it was changed.
2965 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2967 * po/en_GB.po: Added needed logical ID and translation.
2968 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2969 (init_view): Made the is-default column clicking work.
2971 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2974 * src/maemo/easysetup/Makefile.am:
2975 * src/maemo/easysetup/modest-easysetup-wizard.c:
2976 (modest_easysetup_wizard_dialog_init):
2977 * src/maemo/easysetup/provider-data-test.keyfile:
2978 * src/maemo/easysetup/provider-data.keyfile:
2979 Moved the provider data file to the new modest-providers-data package and used it from there.
2981 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2983 * src/modest-local-folder-info.c:
2984 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2985 N_() was already used on the static strings, but this just marks it for translation without
2986 using the translation.
2988 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2990 * src/maemo/modest-account-settings-dialog.c:
2991 (create_page_incoming),
2992 (modest_account_settings_dialog_set_account_name):
2993 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2994 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2995 I will do this if nobody else gets there first.
2997 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2999 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3000 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3001 save the security stuff.
3003 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3005 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3006 Set the email address and user fullname, which I now see must be
3009 * src/maemo/modest-account-settings-dialog.h:
3010 * src/maemo/modest-account-settings-dialog.c:
3012 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3013 leave-on-server and authentication.
3014 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3017 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3020 * src/maemo/modest-account-settings-dialog.c:
3021 * src/maemo/modest-account-settings-dialog.h:
3022 Most (but not all) of the widgets are now present as specified by the UI spec.
3023 No changes are yet saved, and some details are not properly shown yet.
3025 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3027 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3029 * src/maemo/Makefile.am:
3030 * src/maemo/modest-account-settings-dialog.c:
3031 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3032 an existing account. Doesn't do much yet.
3034 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3035 Open the accounts settings dialog when Edit is clicked.
3037 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3039 * src/maemo/easysetup/Makefile.am:
3040 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3042 * src/maemo/easysetup/modest-easysetup-wizard.c:
3043 (modest_easysetup_wizard_dialog_init):
3044 Try to get the source directory from the build system,
3045 instead of hard-coding "./" into the source code, when opening our local
3046 copies of the configuration files.
3047 But this still fails when opening the wizard from the Accounts window,
3048 maybe because the working directory seems to change at runtime.
3049 So the wizard will fail the second time unless you copy the files into their
3050 proper locations - see the stdout warnings for the paths.
3052 (create_page_account_details),(on_before_next):
3053 Check for existing non-server accounts instead of server accounts,
3054 so the default account name is useful again, and to prevent trying to
3057 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3058 Show the wizard when New is clicked.
3060 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3061 (init_view): Show the column headers, and show the columns that are
3062 specified in the UI specs. However, something in Maemo's GTK+ prevents
3063 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3064 change the default account. This is despite unsetting the special properties.
3066 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3068 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3069 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3070 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3071 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3072 to make that clearer.
3073 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3075 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3077 * src/maemo/modest-account-view-window.c:
3078 (modest_account_view_window_init),
3079 (modest_account_view_window_new):
3080 Use the same buttons as specified in the
3081 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3082 the existing widgets, which never had a chance of working.
3083 Put the ModestAccountView treeview in a scrolled window.
3084 Do not repeat the initialization in both _init() and _new().
3086 * src/widgets/modest-account-view.c: (update_account_view):
3087 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3088 this widget and window shows no accounts.
3090 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3092 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3094 * src/maemo/easysetup/modest-easysetup-wizard.c:
3095 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3096 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3097 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3100 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3101 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3102 accounts exist yet, as in the UI spec.
3104 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3106 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3108 * src/maemo/Makefile.am:
3109 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3110 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3111 New window for editing connection-specific smtp details.
3112 Not fully implemented.
3114 * src/maemo/modest-connection-specific-smtp-window.c:
3115 (modest_connection_specific_smtp_window_finalize) :
3116 unref the tree model.
3117 (on_button_edit): Show the edit window.
3119 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3121 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3124 * src/maemo/Makefile.am:
3125 * src/maemo/modest-connection-specific-smtp-window.c:
3126 * src/maemo/modest-connection-specific-smtp-window.h:
3127 New window for showing the list of connections, for connection-specific
3128 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3129 * src/maemo/easysetup/modest-easysetup-wizard.c:
3130 (create_page_custom_outgoing): Show the new window when the button is clicked.
3132 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3134 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3135 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3136 * src/maemo/modest-msg-edit-window.c:
3137 (modest_msg_edit_window_insert_image):
3138 * src/modest-conf.c: (modest_conf_key_escape):
3139 * src/modest-mail-operation.c:
3140 (modest_mail_operation_send_new_mail):
3141 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3142 (modest_ui_actions_on_new_account):
3143 * src/widgets/modest-attachment-view.c: (update_filename_request):
3144 * src/widgets/modest-mail-header-view.c:
3145 Corrected warnings that were breaking the build, by commenting out unused variables,
3146 and a function, and by including a header.
3148 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3150 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3151 so we can #ifdef around platform-specific code when necessary.
3152 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3153 to allow this to build for the GNOME platform too.
3155 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3157 * src/maemo/easysetup/modest-easysetup-wizard.c:
3158 Added util_increment_name() and used it in create_page_account_details()
3159 to make sure that the default account name is always a new name.
3161 (modest_easysetup_wizard_dialog_init),
3162 (set_default_custom_servernames): Some minor memory management fixes.
3164 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3168 * src/modest-runtime.c: (init_i18n): Restored the translation
3169 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3170 are defined in config.h, and the translations are installed.
3172 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3173 is defined for translation.
3175 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3177 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3179 * src/maemo/easysetup/modest-easysetup-wizard.c:
3180 (modest_easysetup_wizard_dialog_init):
3181 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3182 Use realistic paths (though they should use $prefix generically) to the
3183 mcc_mapping and provider-data.keyfile files which might work when they
3184 are installed by the future version of the operator-wizard package,
3185 and then fallback to paths in our source code, with an explanatory
3188 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3192 * src/maemo/Makefile.am:
3193 * src/maemo/easysetup/: Added files from the previously-exernal
3194 osso-modest-easysetup.
3195 * src/maemo/modest-main-window-ui.h:
3196 * src/modest-ui-actions.c:
3197 * src/modest-ui-actions.h:
3198 Added modest_ui_actions_on_new_account() as a signal handler for the
3199 New Account menu item. It shows the easysetup wizard.
3200 * po/en_GB.po: Added additional needed logical IDs and translations.