1 2007-06-20 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4 Add a g_warning when the item is not a folder.
6 * src/modest-ui-dimming-rules.c:
7 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
8 when selected item is not a folder (for instance, an account), because
9 the UI spec only talks about folders.
10 I am not sure what the UI spec wants, so this might not totally fix
11 projects.maemo.org bug NB#60794.
13 2007-06-20 Murray Cumming <murrayc@murrayc.com>
15 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
16 (load_from_file): Sort the list. The unsorted list would be more noticeable
17 in non-English locales.
19 * src/maemo/modest-msg-edit-window.c:
20 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
21 warning and fix the build.
23 * src/maemo/modest-progress-bar-widget.c:
24 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
25 avoid a g_warning, and probably to avoid a crash.
27 2007-06-20 Murray Cumming <murrayc@murrayc.com>
29 * src/modest-search.c: (modest_search_folder): Check for a GError
30 when calling tny_folder_get_headers(), to show that this is not the cause
33 2007-06-20 Murray Cumming <murrayc@murrayc.com>
35 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
36 Actually set the body query instead of the subject query.
38 * src/modest-search.c: (search_mime_part_ogs),
39 (search_mime_part_strcmp): Remove extra space from the text/* regex,
40 which would probably cause it to fail if we got this far.
42 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
44 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
45 be causing search-in-body to fail.
47 2007-06-20 Murray Cumming <murrayc@murrayc.com>
49 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
51 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
52 Better debug message when the folder cannot be found.
53 This should help with fixing projects.maemo.org bug #61287.
54 * src/modest-search.c: (add_hit): Do not leak the furl string.
56 2007-06-20 Murray Cumming <murrayc@murrayc.com>
58 * src/modest-ui-actions.c:
59 (modest_ui_actions_on_folder_selection_changed):
60 Do not special-case TNY_MERGE_FOLDER here, because
61 modest_tny_folder_get_account() already does that. This fixes
62 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
63 shown when the Outbox was selected).
65 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
67 * libmodest-dbus-client/libmodest-dbus-client.c:
68 (_dbus_iter_get_string_or_null): Initialize the string variable in
69 case this helps with Dirk's crash.
71 2007-06-19 Murray Cumming <murrayc@murrayc.com>
73 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
74 though it is not implemented yet (this function is maybe not even used),
75 to avoid breaking ABI in future.
76 * libmodest-dbus-client/libmodest-dbus-client.c:
77 (get_attachments_string): Moved some code into this generic function.
78 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
79 sends email. It is maybe not used.
80 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
81 (on_send_mail): Use attachments.
83 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
84 * src/maemo/modest-msg-edit-window.c:
85 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
86 a filename before using it, to fix projects.maemo.org bug NB#58233.
88 2007-06-19 Murray Cumming <murrayc@murrayc.com>
90 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
91 Initialize the continue_download variable to fix the build, and probably
92 to fix randome behaviour.
94 2007-06-18 Armin Burgmeier <armin@openismus.com>
96 * src/modest-tny-send-queue.h:
97 * src/modest-tny-send-queue.c: Keep track of the status of messages in
98 the queue so we can later show it in the UI. Replaced
99 modest_tny_send_queue_msg_is_being_sent() by
100 modest_tny_send_queue_get_msg_status().
102 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
104 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
105 gpointer. This probably was not harmful, but just to be sure.
107 2007-06-18 Murray Cumming <murrayc@murrayc.com>
109 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
110 Fix the build, but leave the function broken on Bora, because
111 hildon_uri_action_get_service() does not exist.
112 osso_uri_action_get_service() does not exist either, it seems.
114 2007-06-18 Murray Cumming <murrayc@murrayc.com>
116 * src/modest-tny-account.c:
117 (modest_tny_account_new_from_server_account):
118 Uncommented the url debug output again, because it is useful for
119 debugging, as I said in the comment.
121 2007-06-18 Murray Cumming <murrayc@murrayc.com>
123 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
125 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
126 for Mameo Bora, to fix the build.
128 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
131 Fixed build with hildon < 0.99
133 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
134 Check if the selected account is busy instead of checking all accounts
136 * src/modest-account-mgr-priv.h:
137 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
138 (modest_account_mgr_init), (compare_account_name),
139 (modest_account_mgr_set_account_busy),
140 (modest_account_mgr_account_is_busy):
141 * src/modest-account-mgr.h:
142 Added busy information to the account manager. It possible to
143 set an account to busy or not busy now.
145 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
146 (modest_mail_operation_update_account),
147 (modest_mail_operation_notify_end):
148 Set the account to busy/not busy depending on the operation state.
150 * src/widgets/modest-account-view.c:
151 (modest_account_view_finalize), (get_last_updated_string),
152 (update_account_view), (on_account_busy_changed), (init_view):
153 Show string "Refreshing..." if the account is currently busy.
155 All this fixes projects.maemo.org bug NB#59711
157 2007-06-14 Armin Burgmeier <armin@openismus.com>
159 * src/widgets/modest-attachments-view.h:
160 * src/widgets/modest-attachments-view.c: Added
161 modest_attachments_view_has_attachments() and fixed coordinate
162 transformation in get_att_view_at_coords(). This fixes attachment
165 * src/widgets/modest-msg-view.c: Make use of
166 modest_attachments_view_has_attachments() to decide whether to show
167 attachments in the header.
169 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
171 * src/maemo/modest-connection-specific-smtp-edit-window.c:
172 (on_change), (on_combo_security_changed),
173 (modest_connection_specific_smtp_edit_window_init),
174 (modest_connection_specific_smtp_edit_window_set_connection),
175 (modest_connection_specific_smtp_edit_window_is_dirty):
176 * src/maemo/modest-connection-specific-smtp-edit-window.h:
177 * src/maemo/modest-connection-specific-smtp-window.c:
180 Show an comfirmation dialog for the smpt-edit-window if there are
181 unsaved changes and the user hits cancel.
182 (projects.maemo.org bug NB#60479)
184 2007-06-14 Armin Burgmeier <armin@openismus.com>
186 * src/maemo/easysetup/modest-easysetup-wizard.c:
187 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
188 address" info in banner instead of node, and select all the text as
189 per UI spec. This fixes projects.maemo.org bug NB#60550.
191 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
193 reviewed by: <delete if not using a buddy>
195 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
196 * src/modest-ui-actions.c: (folder_refreshed_cb):
198 2007-06-14 Murray Cumming <murrayc@murrayc.com>
200 * src/widgets/modest-folder-view.c: (filter_row):
201 Explictly filter out the per-account outbox accounts. I don't know why
202 these only sometimes show up, but now they should never show up in the UI.
203 This should fix projects.maemo.org bug NB#60160.
205 2007-06-14 Murray Cumming <murrayc@murrayc.com>
207 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
208 when the toolbar does not exist yet.
209 * src/modest-widget-memory.c: (save_settings_header_view):
210 Added g_warnings() to help us to discover when we are trying to set
211 an empty columns list in gconf.
213 2007-06-14 Murray Cumming <murrayc@murrayc.com>
217 Added modest_init_get_default_header_view_column_ids().
219 * src/modest-widget-memory.c: (restore_settings_header_view):
220 Use the new function to get defaults, if the gconf key is empty,
221 instead of not creating any columns. This seems to fix the
222 empty right-hand pane problems.
224 * src/widgets/modest-header-view.h: Improved documentation.
226 2007-06-13 Murray Cumming <murrayc@murrayc.com>
228 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
229 Revert the use of the display name as the account name, because this
230 is generally wrong and would break the code that follows.
232 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
234 * src/maemo/easysetup/modest-easysetup-wizard.c:
235 (check_for_supported_auth_methods), (on_before_next),
238 More correct fix for projects.maemo.org bug NB# 58991
239 Do not longer accept AUTH_PASSWORD as secure method and choose
240 correct method when creating the account.
242 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
244 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
245 Fixed projects.maemo.org bug NB# 58991
247 2007-06-13 Murray Cumming <murrayc@murrayc.com>
249 * src/modest-init.c: (modest_init_init_core),
250 (modest_init_local_folders): Fixed compilation errors.
252 2007-06-13 Murray Cumming <murrayc@murrayc.com>
254 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
255 Remove unnecessary lib/include, though it is good in principle when needed.
257 * src/modest-init.c: (modest_init_one_local_folder),
258 (modest_init_local_folders):
259 * src/modest-init.h: Initialize the .modest library for memory cards,
260 instead of just doing nothing for them. This should allow us to create
261 folders there, fixing projects.maemo.org bug NB#59297.
263 2007-06-13 Murray Cumming <murrayc@murrayc.com>
265 * libmodest-dbus-client/libmodest-dbus-client.c:
266 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
267 (libmodest_dbus_client_compose_mail),
268 (libmodest_dbus_client_open_message),
269 (libmodest_dbus_client_send_and_receive),
270 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
272 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
273 (on_idle_open_message), (modest_dbus_req_handler),
274 (search_result_to_message), (modest_dbus_req_filter):
275 * src/modest-search.c: (add_hit), (modest_search_folder),
276 (modest_search_all_accounts): Improved debug messages.
278 * tests/dbus_api/test_open_message.c: (main): Improved comments.
280 * src/modest-tny-account-store.c:
281 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
284 2007-06-13 Murray Cumming <murrayc@murrayc.com>
287 2007-06-12 Murray Cumming <murrayc@murrayc.com>
289 * src/modest-tny-account-store.c: (get_server_accounts):
290 Call modest_tny_local_folders_account_add_merged_outbox_folders()
291 even when there are no accounts, so that the Outbox folder is always
292 visible. This fixes projects.maemo.org bug NB#60158.
294 2007-06-12 Murray Cumming <murrayc@murrayc.com>
296 * src/maemo/modest-main-window.c: (create_details_widget):
297 Use the mcen_va_never logical ID.
299 2007-06-12 Murray Cumming <murrayc@murrayc.com>
301 * src/dbus_api/modest-dbus-api.h:
302 * src/dbus_api/modest-dbus-callbacks.c:
303 (on_idle_open_default_inbox), (on_open_default_inbox),
304 (modest_dbus_req_handler):
305 Added a new OpenDefaultInbox method.
307 * libmodest-dbus-client/libmodest-dbus-client.h:
308 * libmodest-dbus-client/libmodest-dbus-client.c:
309 Added libmodest_dbus_client_open_default_inbox() to call the new
310 dbus method. This should be useful to projects.maemo.org bug NB#57214,
311 though it should maybe be used by a new osso-email-interface function.
313 * tests/dbus_api/Makefile.am:
314 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
317 2007-06-12 Murray Cumming <murrayc@murrayc.com>
319 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
320 NULL, so that the signals get all the keys. This should not actually
321 change any behaviour because we currently update everything when anything
324 2007-06-12 Murray Cumming <murrayc@murrayc.com>
326 * src/widgets/modest-folder-view.c: (text_cell_data),
327 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
328 (find_inbox_iter): If tinymail tells us that the folder is
329 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
330 This causes the inbox to be selected at startup, fixing part of
331 projects.maemo.org bug NB#56305.
333 * src/modest-ui-dimming-rules.c:
334 (modest_ui_dimming_rules_on_tools_smtp_servers):
335 * src/modest-ui-dimming-rules.h: Added a callback function to dim
336 the SMTP servers menu item.
337 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
338 that the SMTP Servers menu item is dimmed when there are no accounts,
339 as a future version of the UI spec will require. This fixes
340 projects.maemo.org bug NB#56305.
342 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
344 * src/maemo/modest-maemo-utils.c:
345 (modest_maemo_utils_get_supported_secure_authentication_methods):
346 Added label to dialog instead of unreadable title
348 * src/maemo/modest-main-window.c: (sync_accounts_cb),
349 (modest_main_window_new):
350 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
353 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
354 * src/modest-account-mgr.h:
355 Added method to avoid code duplication
357 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
358 (modest_ui_actions_on_send_receive):
359 Use modest_account_mgr_has_accounts
361 2007-06-11 Murray Cumming <murrayc@murrayc.com>
363 * src/maemo/easysetup/modest-presets.c:
364 (modest_presets_get_info_server_security): Do not report secure auth
366 * src/modest-protocol-info.c: Use the defines for the gconf key names
367 for secure authentication. This was not working because we were writing
368 Password and reading password, and the check was case sensitive.
369 With this, gmail now works for receiving and sending when created via
372 2007-06-11 Murray Cumming <murrayc@murrayc.com>
374 * src/maemo/easysetup/modest-presets.c:
375 (modest_presets_get_info_server_security): Correct the key name for
376 SecureSmtp, because it seems to be case-sensitive.
377 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
378 Do not try to get the 0th notebook page if there are 0 pages, to
381 2007-06-11 Murray Cumming <murrayc@murrayc.com>
383 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
384 Prevent use of the new notification feature for now, because it currently
385 shows one dialog for each new email, which is annoying.
387 2007-06-11 Murray Cumming <murrayc@murrayc.com>
389 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
390 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
391 when no country was selected, so that we show the global ones.
392 * src/maemo/easysetup/modest-presets.c:
393 (modest_presets_get_providers): Return only the global providers, not
394 all providers when mmc=0 was requested.
396 2007-06-11 Murray Cumming <murrayc@murrayc.com>
398 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
399 (easysetup_provider_combo_box_fill): Remove debug code that showed the
400 provider ID in the combo.
402 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
403 Do not show the page numbers, because it would be confusing when we add
404 the 2 extra pages for the custom setup, when the user chooses the "Other"
405 provider. This fixes projects.maemo.org bug NB#59028
407 * src/modest-init.c: (modest_init_init_core),
408 (modest_init_local_folders):
410 * src/modest-tny-account.c:
411 (modest_tny_account_new_for_local_folders): Do not create default folders
412 for the memory card. This should fix projects.maemo.org bug NB#59328.
414 2007-06-11 Murray Cumming <murrayc@murrayc.com>
416 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
417 Free the changed_conf_keys string items. They are already freed in the
418 idle handler if that runs first.
420 2007-06-11 Murray Cumming <murrayc@murrayc.com>
422 * src/modest-ui-actions.c:
423 (modest_ui_actions_on_password_requested): Check that the server name
424 is not NULL, because I just saw a password dialog with (null) as the
427 * src/modest-tny-folder.[h|c]: Added
428 modest_tny_folder_is_memory_card_folder().
429 * src/modest-ui-dimming-rules.c:
430 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
431 menu item for memory cards, as per the UI spec (section 7.4). This should
432 fix projects.maemo.org bug NB#59297.
434 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
436 * src/maemo/modest-main-window.c: (sync_accounts_cb):
437 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
438 is another problem with the code, see Murray's comment at line 772)
440 2007-06-08 Murray Cumming <murrayc@murrayc.com>
442 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
443 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
444 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
445 (load_from_file), (easysetup_country_combo_box_init),
446 (easysetup_country_combo_box_get_active_country_ids),
447 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
448 instead of just one ID, to avoid duplicate country names in the UI.
450 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
451 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
452 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
453 a single ID, avoiding duplicate providers.
454 * src/maemo/easysetup/modest-easysetup-wizard.c:
455 (on_combo_account_country): Adapt to use a list.
457 2007-06-08 Murray Cumming <murrayc@murrayc.com>
459 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
460 keys changed in the last X seconds.
462 * src/modest-account-mgr.h:
463 * src/modest-account-mgr.c: (on_timeout_notify_changes),
464 (on_key_change), (modest_account_mgr_class_init),
465 (modest_account_mgr_init), (modest_account_mgr_finalize):
466 As the keys are changed, save them in a GSList* and signal that GSList*
467 further every X seconds, to batch changes, to allow us to do just one
468 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
469 bug NB#56941 and other (UI-blocking) delays when changing account settings.
471 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
472 changed signal signature.
474 * src/modest-conf.c: (modest_conf_set_list),
475 (modest_conf_on_change): Reenable notification.
477 (modest_conf_maemo_fake_on_change): Comment out the hack that
478 notified immediately instead of asynchronously.
480 * src/widgets/modest-account-view.h:
481 * src/widgets/modest-account-view.c:
482 (update_account_view): Select the previously-selected account ID,
483 if possible. This fixes projects.maemo.org bug NB#56933.
485 (on_account_changed), (on_account_removed),
486 (modest_account_view_select_account):
488 Remove the block/unblock functions
489 because they were not useful.
491 * src/maemo/modest-account-view-window.c:
492 (on_delete_button_clicked), (on_edit_button_clicked),
493 (on_new_button_clicked): Remove the use of the non-working block/unblock.
495 2007-06-08 Murray Cumming <murrayc@murrayc.com>
497 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
498 Improve the error dialog to show Incorrect Account Settings, which seems
499 clearer, and say that the internal error message (to be removed from the
500 dialog later) is often misleading.
501 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
503 * src/modest-tny-account.c:
504 (modest_tny_account_new_from_server_account): Uncomment the printf of the
505 URL because this is so useful for debugging on the device.
507 * src/widgets/modest-serversecurity-combo-box.c:
508 (modest_serversecurity_combo_box_fill): Correct a logical ID.
510 2007-06-08 Murray Cumming <murrayc@murrayc.com>
512 * src/modest-mail-operation.c:
513 (modest_mail_operation_send_new_mail):
514 Added a comment about a nasty but apparently harmless message. Details
515 added to the wiki g_warnings() page.
517 2007-06-08 Murray Cumming <murrayc@murrayc.com>
519 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
520 (modest_tny_send_queue_class_init):
521 Do not use the priv struct because it is empty, to avoid g_warnings
522 about a non-existant priv struct.
524 * src/modest-tny-account-store.c:
525 (modest_tny_account_store_get_server_account),
526 (modest_tny_account_store_get_transport_account_for_open_connection
527 ): Do not try to get transport server accounts for local folders,
528 because they don't have any. This avoids a g_warning().
530 * src/maemo/modest-main-window.c:
531 (modest_main_window_notify_send_receive_initied),
532 (on_configuration_key_changed):
533 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
535 * src/modest-mail-operation.c:
536 (modest_mail_operation_update_account):
537 * src/modest-tny-account-store.h:
538 * src/modest-tny-account.c:
539 (modest_tny_account_get_special_folder),
540 (modest_tny_account_new_for_local_folders),
541 (modest_tny_account_new_for_per_account_local_outbox_folder):
542 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
543 * src/modest-tny-local-folders-account.c:
544 (add_account_folders_to_merged_folder):
545 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
546 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
547 (modest_ui_actions_on_send):
548 * src/widgets/modest-folder-view.c: (update_model):
549 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
550 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
551 modest_tny_account_store_get_tny_account_by_account() to
552 modest_tny_account_store_get_server_account() to make the code clearer.
554 2007-06-07 Marcus Bauer <marcusb@openismus.com>
556 * src/dbus_api/modest-dbus-api.h:
557 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
558 * src/maemo/modest-msg-edit-window.c:
559 (modest_msg_edit_window_attach_file_noninteractive):
560 added g_warning in case the file to be attached does not exist
561 * tests/dbus_api/test_compose_mail.c: (main):
562 removed obsolete comment, added generic files as test case
564 2007-06-07 Murray Cumming <murrayc@murrayc.com>
566 * src/modest-tny-account-store.c: (get_server_accounts):
567 Create the local folders account only once, not once for each outbox, and
568 not only when there are some outboxes.
570 2007-06-07 Murray Cumming <murrayc@murrayc.com>
572 * src/widgets/modest-folder-view.c: (update_model): Comment out some
573 code that is causing a crash at startup. Sergio says that he is fixing this.
575 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
577 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
578 * src/maemo/modest-account-settings-dialog.c:
579 (create_page_outgoing),
580 (modest_account_settings_dialog_set_account_name),
581 (save_configuration):
582 - Fixed handling of the "Use secure authentication" toggle to comply with
583 the ui specification. See also projects.maemo.org bug NB#58400
585 - Restore the Secure connection setting combo correctly when loading
588 * src/maemo/modest-maemo-utils.c:
589 (on_camel_account_get_supported_secure_authentication),
590 (modest_maemo_utils_get_supported_secure_authentication_methods):
591 Fixed a crasher if operation is canceled
593 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
594 (modest_protocol_info_auth_is_secure):
595 * src/modest-protocol-info.h:
597 Added two new methods to determine if a protocol/auth method is secure/encrypted in
598 the sense of the "Use secure authentication" toggle.
600 2007-06-07 Murray Cumming <murrayc@murrayc.com>
602 * src/modest-tny-account-store.h:
603 * src/modest-tny-account-store.c:
604 Added modest_tny_account_store_get_local_folders_account().
606 * src/modest-tny-folder.h:
607 * src/modest-tny-folder.c:
608 (modest_tny_folder_get_account):
609 Added this replacement for tny_folder_get_account() which returns
610 the local-folders account for TnyMergeFolders, to avoid the
611 warning about the unimplemented get_account_func() vfunc().
613 (modest_tny_folder_get_rules),
614 * src/modest-ui-actions.c:
615 (modest_ui_actions_on_folder_selection_changed):
616 * src/modest-mail-operation.c:
617 (modest_mail_operation_remove_folder),
618 (modest_mail_operation_xfer_folder),
619 (modest_mail_operation_rename_folder),
620 (modest_mail_operation_get_msg),
621 (modest_mail_operation_get_msgs_full),
622 (modest_mail_operation_remove_msg),
623 (modest_mail_operation_xfer_msgs),
624 (modest_mail_operation_refresh_folder):
625 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
627 2007-06-07 Murray Cumming <murrayc@murrayc.com>
629 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
630 (modest_server_account_set_security):
631 * src/modest-defs.h: Add comments explaining that our
632 UI spec means TLS when it says Normal, so these do not look like errors.
634 * src/modest-tny-account.c:
635 (modest_tny_account_new_from_server_account): Use the new tinymail
636 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
637 for TLS. This should fix projects.maemo.org bug NB#58460.
639 2007-06-06 Murray Cumming <murrayc@murrayc.com>
641 * src/maemo/easysetup/modest-easysetup-wizard.c:
642 (create_account): Correct the position of the gconf sanity check warning.
643 (on_button_edit_advanced_settings): Show the dialog immediately, instead
644 of using the g_idle_add() hack, because this does not seem to be necessary
645 on osso 1.1. It might even work on Maemo Bora if the problems were actually
646 caused by something other than maemo's gconf.
647 This fixes projects.maemo.org bug #59022.
649 2007-06-06 Murray Cumming <murrayc@murrayc.com>
651 * src/modest-account-mgr-helpers.c:
652 (modest_account_mgr_get_default_account): Do not check that the account
653 exists if there is no default account (NULL), to fix a runtime warning.
655 2007-06-06 Murray Cumming <murrayc@murrayc.com>
657 * src/widgets/modest-folder-view.c: (update_model):
658 Do not unref the treemodel before we have finished with it.
659 This prevents a valgrind warning and an occasional crash at startup.
661 2007-06-06 Marcus Bauer <marcusb@openismus.com>
663 * libmodest-dbus-client/libmodest-dbus-client.h:
664 added libmodest_dbus_client_compose_mail()
665 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
667 added functions needed for SendAsMail() functionality
668 * src/maemo/modest-msg-edit-window.c:
669 (modest_msg_edit_window_attach_file_noninteractive):
670 non interactively attaching files to message edit window
671 * src/widgets/modest-msg-edit-window.h:
672 * tests/dbus_api/Makefile.am:
673 added test_compose_mail.c
674 * tests/dbus_api/test_compose_mail.c: (main):
676 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
678 * src/modest-account-view.c:
679 Fixed bug projects.maemo.org bug NB#59307
681 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
683 * src/maemo/easysetup/modest-easysetup-wizard.c:
684 (get_serverport_incoming), (on_before_next), (create_account):
685 * src/maemo/modest-account-settings-dialog.c:
686 (modest_account_settings_dialog_set_account_name):
687 * src/maemo/modest-maemo-utils.c:
688 (on_camel_account_get_supported_secure_authentication_status),
689 (on_camel_account_get_supported_secure_authentication),
690 (on_secure_auth_cancel),
691 (modest_maemo_utils_get_supported_secure_authentication_methods):
693 Implemented security authentication for settings and easysetup.
695 2007-06-05 Murray Cumming <murrayc@murrayc.com>
697 * src/maemo/modest-main-window.c: (create_details_widget):
698 Show the total size for memory card accounts too, instead of showing
699 the name again. Fixes bug projects.maemo.org bug NB#59307.
701 2007-06-05 Murray Cumming <murrayc@murrayc.com>
704 * src/modest-tny-simple-folder-store.c:
705 * src/modest-tny-simple-folder-store.h: Removed.
707 * src/modest-tny-local-folders-account.h
708 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
709 for the local-folders maildir, with an extra TnyMergedFolder containing
710 the folders of the per-account outbox store accounts.
711 * src/modest-tny-account-store.c: (get_server_accounts):
712 Add the outboxes to the special local folders account after creating it.
714 * src/modest-tny-account.c:
715 (modest_tny_account_new_for_local_folders): Create the derived
716 account when creating the main local-folders account.
718 * src/maemo/modest-main-window.c: (create_details_widget),
719 (modest_main_window_set_contents_style):
720 Adapted to the use of the derived account instead of the folder store.
722 * src/modest-ui-actions.c:
723 (modest_ui_actions_on_folder_selection_changed):
724 * src/modest-ui-dimming-rules.c:
725 (modest_ui_dimming_rules_on_new_folder):
726 * src/widgets/modest-folder-view.c: (text_cell_data),
727 (icon_cell_data), (filter_row), (update_model),
728 (get_cmp_rows_type_pos):
731 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
732 Do not get the priv struct, because no priv struct has been set,
733 to avoid a runtime warning.
735 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
736 #ifelse with #else, to fix a warning, to fix the build.
739 2007-06-05 Christian Kellner <ckellner@openismus.com>
741 * libmodest-dbus-client/libmodest-dbus-client.c:
742 Fix small typo in doc (why do you always see them
743 AFTER committing stuff?)
746 2007-06-05 Christian Kellner <ckellner@openismus.com>
748 * libmodest-dbus-client/libmodest-dbus-client.c:
749 (libmodest_dbus_client_search):
750 Initialize hit list with NULL. Also set folder list
751 to "" if NULL was supplied.
754 2007-06-03 Christian Kellner <ckellner@openismus.com>
756 * libmodest-dbus-client/libmodest-dbus-client.c:
757 (modest_search_hit_list_free):
758 Make it save to call it with NULL.
760 * src/dbus_api/modest-dbus-callbacks.c:
761 * src/modest-search.c:
762 Return full ModestSearchHits as the search result list not TnyHeader
763 since can't be around withouth the correspoding TnyFolder.
765 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
767 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
768 Added currently commented code to check for secure auth
770 * src/maemo/modest-account-settings-dialog.c: (on_response),
771 (save_configuration), (show_ok):
772 Fixed projects.maemo.org bugs NB #59248 and #59251
774 * src/maemo/modest-maemo-utils.c:
775 (on_camel_account_get_supported_secure_authentication_status),
776 (on_camel_account_get_supported_secure_authentication),
777 (modest_maemo_utils_get_supported_secure_authentication_methods):
778 * src/maemo/modest-maemo-utils.h:
779 Moved get_supported_secure_authentication() method here to be able
780 to use it from easysetup wizard.
782 * src/modest-pair.c: (on_pair_compare_as_string):
783 Should compare string with first part of pair and not
784 strcmp pairs which will crash.
786 * src/modest-protocol-info.c:
787 (modest_protocol_info_protocol_is_store):
788 * src/modest-protocol-info.h:
789 Added modest_protocol_info_get_auth_protocol_name()
791 2007-06-03 Armin Burgmeier <armin@openismus.com>
793 * src/modest-mail-operation.c:
794 (modest_mail_operation_get_msgs_full): Set priv->account also when
795 only retrieving a single message. This avoids a crash when canceling
798 (modest_mail_operation_notify_end): Do not explicitely remove the
799 operation from the queue but only emit the progress_changed signal.
800 The queue itself listens to that signal to remove the operation when
801 it is finished. This reduces coupling and removes a potential deadlock
802 when modest_mail_operation_notify_end() is called from the queue
803 itself. If that is a problem performance-wise, I would suggest to
804 implement a status-changed signal or something.
806 * src/modest-mail-operation-queue.c: Make sure to never call a
807 function from another file while the queue is locked. This (hopefully)
808 fixes another deadlock when exiting the application while retrieving
811 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
813 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
814 Fixed build if libogs is not available
816 2007-06-03 Christian Kellner <ckellner@openismus.com>
818 * libmodest-dbus-client/libmodest-dbus-client.h:
819 * libmodest-dbus-client/libmodest-dbus-client.c:
820 (libmodest_dbus_client_delete_message):
821 Implement deletion of messages (Client side).
823 (modest_search_hit_free),
824 (modest_search_hit_list_free):
825 Utility functions to free the result hits.
827 * src/dbus_api/modest-dbus-api.h:
828 * src/dbus_api/modest-dbus-callbacks.c:
830 (modest_dbus_req_handler):
831 Implement deletion of messages (Server side).
833 * tests/dbus_api/test_search.c: (main):
836 * tests/dbus_api/Makefile.am:
837 * tests/dbus_api/test_delete_message:
838 Add little test for the message deletion logic
840 2007-06-03 Armin Burgmeier <armin@openismus.com>
842 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
843 when the operation queue was not empty. projects.maemo.org bug
846 2007-06-03 Armin Burgmeier <armin@openismus.com>
848 * src/widgets/modest-account-view.c
849 (on_account_default_toggled): Toggle default account column
850 explicitely instead of waiting for gconf notification (which is
851 currently ignored). This should fix projects.maemo.org bug NB#56910
852 for now. It should probably be removed when gconf notifications are
855 2007-06-03 Christian Kellner <ckellner@openismus.com>
857 * libmodest-dbus-client/libmodest-dbus-client.c:
858 Removed debugging spew.
860 * src/dbus_api/modest-dbus-callbacks.c:
861 Added debugging info.
863 * src/modest-search.c:
864 (modest_search_all_accounts):
865 Use tny_account_store_get_accounts () on the account store
866 to get all accounts which is the way to get all accounts.
868 * tests/dbus_api/test_search.c: (main):
869 Make it possible to supply the search term on the command line.
871 2007-06-03 Christian Kellner <ckellner@openismus.com>
873 * libmodest-dbus-client/libmodest-dbus-client.c:
874 * libmodest-dbus-client/libmodest-dbus-client.h:
875 Implement searching for mesages over raw dbus. (Client side)
877 * src/dbus_api/Makefile.am:
878 * src/dbus_api/modest-dbus-api.h:
879 * src/dbus_api/modest-dbus-callbacks.c:
880 * src/dbus_api/modest-dbus-callbacks.h:
881 Search framework (Server side). Also implement on_idle_open_message().
883 * src/maemo/modest-platform.c: (modest_platform_init):
884 Prepare for raw dbus/osso rpc interaction.
886 * src/modest-search.h:
887 Changed minsize from unspecific guint to guint32.
889 * src/modest-search.c:
891 Added strange hack which magically made tnymail work.
893 (modest_search_folder),
894 (modest_search_account),
895 (modest_search_all_accounts):
896 Implement helper functions to search all accounts, specific account
899 * tests/dbus_api/Makefile.am:
900 * tests/dbus_api/test_open_message.c:
901 Read url to open from commandline.
903 * tests/dbus_api/test_search.c:
904 Implement small test for dbus search stuff
906 2007-06-02 Armin Burgmeier <armin@openismus.com>
908 * src/maemo/modest-account-settings-dialog.c: Changed window title to
909 include account type and account title. This fixes projects.maemo.org
912 * src/maemo/modest-account-view-window.c: Set a title for the window.
914 2007-06-02 Armin Burgmeier <armin@openismus.com>
916 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
917 incoming and outgoing server name based on email address and server
918 types as long as the names have not been edited manually. This fixes
919 projects.maemo.org bug NB#58671.
921 2007-06-02 Armin Burgmeier <armin@openismus.com>
923 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
924 server type cannot be changed in future to the incoming details page
925 when creating an account. This fixes projects.maemo.org bug NB#59029.
927 2007-06-02 Armin Burgmeier <armin@openismus.com>
929 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
930 and assigned max width chars so that they wrap instead of being
931 truncated. Fixes projects.maemo.org bug NB#56126.
933 2007-06-02 Armin Burgmeier <armin@openismus.com>
935 * src/maemo/modest-connection-specific-smtp-window.c: Add an
936 introductory note to the connection specific smtp servers dialog, as
937 section 8.12 of the email UI specification requires. This fixes
938 projects.maemo.org bug NB#59212.
940 2007-06-01 Murray Cumming <murrayc@murrayc.com>
942 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
943 Check for running mail operations, and offer to cancel them, as per the UI
944 spec. This fixes projects.maemo.org bug NB#59041 .
945 However, I suspect that tinymail may still use the network connection
946 in ways that we cannot detect or cancel. But it should at least adapt to
949 2007-06-01 Murray Cumming <murrayc@murrayc.com>
951 * src/modest-tny-account-store.c: (recreate_all_accounts),
952 (get_cached_accounts), (get_server_accounts): Do more sensible
953 ref-counting of the temporarily-cached outbox accounts list. This seems
954 to fix a crash when entering the password when the password was wrong.
956 2007-06-01 Murray Cumming <murrayc@murrayc.com>
958 * src/gnome/modest-main-window.c: (connect_signals):
959 * src/modest-tny-account-store.c: (get_password),
960 (modest_tny_account_store_alert): Added comments and clues and
961 commented-out code about how we currently fail to deal with connection
962 errors and wrong passwords, and how we should.
964 2007-06-01 Murray Cumming <murrayc@murrayc.com>
966 * src/widgets/modest-retrieve-combo-box.c:
967 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
968 This fixes projects.maemo.org bug NB#58472 .
970 2007-06-01 Murray Cumming <murrayc@murrayc.com>
972 * src/maemo/easysetup/modest-easysetup-wizard.c:
973 (create_page_complete_easysetup):
974 (create_page_complete_custom): Correct the last commit,
975 putting the correct sentences in the correct pages.
977 2007-06-01 Murray Cumming <murrayc@murrayc.com>
979 * src/maemo/easysetup/modest-easysetup-wizard.c:
980 (create_page_complete_custom): Show the second sentence of text
981 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
984 2007-06-01 Murray Cumming <murrayc@murrayc.com>
986 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
987 Set the leave-on-server conf key by default. This fixes
988 projects.maemo.org bug NB#59258 .
990 2007-06-01 Murray Cumming <murrayc@murrayc.com>
992 * src/maemo/modest-account-view-window.c:
993 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
994 logical ID for the confirmation messages. Fixed projects.maemo.org bug
997 2007-06-01 Murray Cumming <murrayc@murrayc.com>
999 * src/maemo/easysetup/modest-easysetup-wizard.c:
1000 (create_caption_new_with_asterisk):
1001 * src/maemo/modest-account-settings-dialog.c:
1002 (create_caption_new_with_asterisk):
1003 Uncomment the code to add the asterisk, because they are no longer in the
1004 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1005 (update_incoming_server_title): Add an asterisk here too.
1007 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1009 * src/maemo/modest-maemo-global-settings-dialog.c:
1010 (current_connection): Check that we are even connected before trying to
1011 get the current connection name, to prevent a warning.
1013 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1014 Change the comments because tny_maemo_conic_device_connect() is now meant to
1016 * src/modest-mail-operation.c:
1017 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1018 make sure we have a connection and fail if we can't connect.
1020 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1022 * src/maemo/modest-main-window.c:
1023 (on_account_store_connecting_finished): Do not try to get the
1024 connection ID if we are not really connected. I am surprised that
1025 this signal handler is called when we are not connected.
1027 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1029 * src/modest-error.h:
1030 * src/modest-ui-actions.c:
1031 (modest_ui_actions_get_msgs_full_error_handler):
1032 Renamed an enum, added comments, added an enum
1033 for retrieve-limit errors.
1035 * src/modest-mail-operation.c: (foreach_add_item),
1036 (internal_folder_observer_update), (update_account_thread),
1037 (modest_mail_operation_get_msgs_full):
1038 (modest_mail_operation_update_account),
1039 Added comments about how this works, and some code that should
1040 (but does not) check the retrieve-limit. See the TODO comment.
1042 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1044 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1045 Initialize help_id to fix the build. Warnings are good.
1047 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1049 * src/widgets/modest-hbox-cell-renderer.c:
1050 (modest_hbox_cell_renderer_append):
1051 * src/widgets/modest-vbox-cell-renderer.c:
1052 (modest_vbox_cell_renderer_append):
1053 Fix the last commit by doing an extra ref.
1055 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1057 * src/widgets/modest-hbox-cell-renderer.c:
1058 (modest_hbox_cell_renderer_append):
1059 * src/widgets/modest-vbox-cell-renderer.c:
1060 (modest_vbox_cell_renderer_append):
1061 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1062 to fix the build with Maemo Bora.
1063 However, there seems to be a remaining crash, probably due to reference
1066 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1068 * src/modest-tny-account.c:
1069 (modest_tny_account_new_for_local_folders):
1070 Use hildon_file_system_info_async_new() to get a better name for
1071 the memory card account, setting it as the account name.
1072 The timing seems to work, but this is probably
1073 not the best place to do this. See the TODO comment.
1074 * src/maemo/modest-main-window.c: (create_details_widget):
1075 * src/widgets/modest-folder-view.c: (text_cell_data):
1076 Use the tny account name instead of hardcoding a name.
1078 2007-05-30 Christian Kellner <ckellner@openismus.com>
1080 * src/modest-search.c: (modest_search):
1081 Correctly set part_search_func even if we have already parsed
1082 the query and thus a valid OgsTextSearcher object.
1084 2007-05-30 Christian Kellner <ckellner@openismus.com>
1087 Search and check for libogs.
1090 Incooparte the ogs build env.
1092 * src/modest-mime-part-search-stream.c:
1093 * src/modest-mime-part-search-stream.h:
1094 Removed since we do the real searching now in modest-search.c.
1096 * src/modest-search.c:
1097 * src/modest-search.h:
1098 Implement support for ogs. We use that if available and requested
1099 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1100 should now handle the corner case when the search term is spread
1101 across multiple reads.
1102 Also the logic in modest_search () was corrected to search all
1103 requested fields until one is found.
1105 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1107 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1109 * src/modest-init.h:
1110 * src/modest-init.c: Made modest_init_local_folders() take a
1111 path and be public so we can iniitialize maildir folders on
1114 * src/modest-local-folder-info.h:
1115 * src/modest-local-folder-info.c:
1116 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1118 * src/modest-tny-account.c:
1119 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1120 still means the standard local-folders path on the local volume.
1122 * src/modest-tny-account-store.c:
1123 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1124 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1125 all accounts when that happens.
1126 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1127 this too, so it shows up in the treeview.
1129 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1131 * src/maemo/modest-maemo-global-settings-dialog.c:
1132 (current_connection):
1133 * src/widgets/modest-global-settings-dialog.c:
1134 (current_connection_default):
1135 Use the enum values instead of 0, 1 and -1,
1136 to make the code clearer.
1138 * src/modest-account-mgr-helpers.c:
1139 (modest_account_mgr_get_connection_specific_smtp): Make this code
1142 * src/modest-runtime.h:
1143 * src/modest-runtime.c:
1144 Added modest_runtime_remove_all_send_queues().
1145 * src/maemo/modest-main-window.c:
1146 (on_account_store_connecting_finished): Recreate the send queues,
1147 using the appropriate transport accounts for this new connection.
1148 Some futher adapting might be needed if the old send queues are not
1149 automatically stopped at this point.
1151 * src/modest-tny-account-store.c: (get_server_accounts):
1152 Create the connection-specific transport accounts, so that they can
1153 be found later by their ID.
1155 * src/modest-tny-account.h:
1156 * src/modest-tny-account.c:
1157 Added modest_tny_account_new_from_server_account_name().
1158 modest_tny_account_new_from_server_account(): Do not create the
1159 send queues here, because they will be
1160 recreated anyway when the connection changes for the first time.
1162 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1164 * src/modest-local-folder-info.h:
1165 * src/modest-local-folder-info.c:
1166 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1167 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1168 tbox_folder): Take a modest account name instead of a server TnyAccount,
1169 so we can have per-modest-account rather than per-transport-account
1171 We must make sure that we change or recreate the exisitng send queues
1172 when the connection changes for connection-specific transport accounts.
1174 * src/modest-tny-account-store.c:
1175 (create_per_account_local_outbox_folders): Create outboxed per modest
1176 account, not per transport account.
1178 * src/modest-tny-account.h:
1179 * src/modest-tny-account.c:
1180 (modest_tny_account_get_special_folder): For outboxes, get the
1181 parent modest account name. The account is ignored for other folders.
1182 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1183 modest account name rather than a server TnyAccount.
1185 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1187 * src/modest-tny-account.c:
1188 (modest_tny_account_new_from_server_account):
1189 Call modest_runtime_get_send_queue() immediately after creating transport
1190 accounts, so that they start trying to send email from the outbox as soon
1191 as possible at startup. This is probably what we want.
1193 * src/modest-mail-operation.c: (update_account_thread):
1194 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1195 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1196 * src/modest-tny-send-queue.h:
1197 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1198 (modest_ui_actions_on_send):
1199 Added comments about how sending works, though it needs some more work.
1201 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1203 * src/modest-tny-account.c:
1204 (modest_tny_account_get_special_folder): Add TODO because this fails when
1205 the network is busy.
1206 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1207 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1208 Do not try to show this window when there is no active account. The UI
1209 specs does not tell us what to do in this case.
1211 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1215 * src/maemo/Makefile.am:
1216 * src/widgets/Makefile.am: Some dist fixes.
1218 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1220 * src/maemo/modest-connection-specific-smtp-window.c:
1221 (on_button_edit): Make the code clearer, to prevent a double free.
1223 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1225 * src/maemo/modest-account-settings-dialog.c:
1226 (modest_account_settings_dialog_set_account_name),
1227 Check the connection-specific smtp servers checkbox if there are any.
1229 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1230 (modest_connection_specific_smtp_edit_window_init):
1231 Start with a suitable port number.
1233 * src/modest-account-mgr-helpers.h:
1234 * src/modest-account-mgr-helpers.c: Added
1235 modest_account_mgr_get_has_connection_specific_smtp().
1237 (modest_account_mgr_set_connection_specific_smtp),
1238 (modest_account_mgr_remove_connection_specific_smtp),
1239 (modest_account_mgr_get_has_connection_specific_smtp),
1240 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1241 connection-specific smtp server accounts in the account, rather than
1242 the server account conf dir.
1244 This fixes bug projects.maemo.org bug NB#58263 .
1246 * src/modest-tny-account-store.c:
1247 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1248 if there are no server accounts yet, to prevent an infinite loop when there
1249 are no accounts. Document that one must be called before the other.
1251 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1253 * src/modest-account-mgr-helpers.c:
1254 (modest_account_mgr_get_default_account): Make sure that at least
1255 one account is always the default, if there are any enabled accounts.
1256 This is just a sanity check that shouldn't be necessary.
1258 * src/modest-account-mgr-priv.c:
1259 (_modest_account_mgr_account_from_key): Unescape the conf key to
1260 get the real account name. For instance, this is an issue if a space
1261 was in the account name, which can happen because the account name
1262 is generated from the display name.
1263 (_modest_account_mgr_get_account_keyname): Always escape the
1265 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1266 Unescape the conf keys to get the real account names.
1268 For instance, previously the is-default radio button in the accounts
1269 list was not checked for any accounts at first. This fixes that,
1270 and might fix several similar bugs.
1272 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1274 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1275 Removed some debug printfs.
1277 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1279 Modest on-disk outbox directories are now here, for instance:
1280 $HOME/.modest/outboxes/<account-id-1>/outbox
1281 $HOME/.modest/outboxes/<account-id-2>/outbox
1283 $HOME/.modest/local-folders/outbox
1284 so we can have a separate outbox for each account.
1285 But they are shown as one outbox in the GtkTreeView, by using a
1286 TnyMergeFolder in a ModestTnySimpleFolderStore.
1289 * src/modest-tny-simple-folder-store.c:
1290 * src/modest-tny-simple-folder-store.h:
1291 Added ModestTnySimpleFolderStore, used to contain folders from
1292 other folder stores, such as other accounts.
1294 * src/modest-tny-outbox-account.h:
1295 * src/modest-tny-outbox-account.c:
1296 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1297 used for the per-account local outbox folders.
1299 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1300 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1301 only use this (internally) now for the non-outbox local folders.
1303 * src/modest-init.h:
1304 * src/modest-init.c: Added modest_init_one_local_folder(), for
1305 setting up the directory structure for each local folder.
1307 * src/modest-local-folder-info.c:
1308 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1309 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1311 * src/modest-local-folder-info.h:
1312 * src/modest-tny-account-store.c: (on_account_removed),
1313 (on_account_changed), (create_per_account_local_outbox_folders),
1314 (get_server_accounts), (modest_tny_account_store_get_accounts),
1315 (modest_tny_account_store_get_tny_account_by_account),
1316 (modest_tny_folder_store_is_virtual_local_folders):
1318 * src/modest-tny-account.h:
1319 * src/modest-tny-account.c:
1320 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1321 to create an on-disk per-account local outbox folder for each
1323 (create_per_account_local_outbox_folders): Create a local outbox folder
1324 for each transport account.
1325 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1326 for all local folders.
1328 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1329 instead of using g_object_get/set() directly. It is clearer.
1331 (modest_tny_folder_store_get_message_count),
1332 (modest_tny_folder_store_get_local_size
1333 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1334 because we now use these with non-acount folder stores.
1336 (modest_tny_account_get_special_folder),
1337 (modest_tny_account_new_from_server_account),
1338 (modest_tny_account_new_from_account):
1339 (recurse_folders): Adjust to the new outbox system.
1341 * src/modest-tny-folder.h:
1342 * src/modest-tny-folder.c:
1343 (modest_tny_folder_is_local_folder),
1344 (modest_tny_folder_get_local_folder_type),
1345 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1347 * src/widgets/modest-main-window.h:
1348 * src/maemo/modest-main-window.c: (create_details_widget),
1349 (modest_main_window_set_contents_style): Show details for any folder store,
1352 (modest_tny_folder_get_rules):
1353 Remove the const. C does not support constness enough for this.
1355 * src/modest-ui-actions.c:
1356 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1357 make all outboxes appear as one, in the usual local-folders tree node.
1359 (set_active_account_from_tny_account),
1360 (modest_ui_actions_on_folder_selection_changed):
1361 * src/widgets/modest-folder-view.c: (text_cell_data),
1362 (icon_cell_data), (filter_row),
1363 (add_account_folders_to_merged_folder),
1364 (add_account_folders_to_simple_folder_store), (),
1365 (get_cmp_rows_type_pos), (cmp_rows),
1366 (modest_folder_view_set_account_id_of_visible_server_account):
1367 Adjust to the new outbox system, using generic folder stores and folders
1368 in the GtkTreeModel.
1370 2007-05-23 Christian Kellner <ckellner@openismus.com>
1372 * src/modest-mail-operation.c:
1373 (modest_mail_operation_update_account):
1374 Use info->max_size instead of unintialized local var [small
1375 build fix]. (Added TODO to review that change since I don't
1378 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1380 * libmodest-dbus-client/libmodest-dbus-client.c:
1381 (libmodest_dbus_client_compose_mail): function added
1382 * src/dbus_api/modest-dbus-api.h:
1383 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1384 (on_compose_mail): Implementation of the SendAsMail functionality
1386 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1388 * src/modest-account-mgr.c:
1389 (modest_account_mgr_add_server_account): Set the secure-connection
1390 conf key for transport accounts as well as store accounts. I don't know
1391 why the if was there. For instance, this makes sure that we use SSL
1392 for the gmail preset from the easysetup wizard.
1394 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1396 * src/gnome/modest-main-window.c:
1397 (on_account_store_connecting_finished), (connect_signals):
1398 * src/maemo/modest-main-window.c:
1399 (on_account_store_connecting_finished), (connect_signals),
1400 (modest_main_window_new):
1401 Handle TnyAccountStore::connecting-finished instead of
1402 TnyDevice::connection-changed, because we cannot actually perform
1403 operations on accounts until TnyAccountStore has itself responded to
1404 the TnyDevice::connection-changed signal. This prevents a GError from
1406 Do not try to update at startup, because we (at least on scratchbox)
1407 already do an update at startup when the device goes online.
1408 This prevents a GError from tinymail.
1409 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1410 Added TODO about stopping simultaneous operations.
1412 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1414 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1415 * src/modest-mail-operation-queue.c:
1416 (modest_mail_operation_queue_remove):
1417 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1418 about where they happened.
1420 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1422 * src/modest-ui-actions.c:
1423 (modest_ui_actions_on_password_requested): Make sure that the remember
1424 output parameter is always TRUE.
1426 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1428 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1429 Show a OK/Cancel dialog if the error is a question, though we still do not
1430 know anything more about what we are asking the user.
1431 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1432 Fix an uninitialized variable (helper). This is a logic error, however.
1434 2007-05-21 Christian Kellner <ckellner@openismus.com>
1436 * src/modest-search.h:
1437 Correct bit shifting in the ModestSearchFlags enum.
1439 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1441 * src/modest-tny-account.c:
1442 (modest_tny_account_new_from_server_account): Do not use the lsub and
1443 check-all hard-coded IMAP options when using POP.
1445 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1447 * src/modest-tny-account.c:
1448 (modest_tny_account_new_from_server_account):
1449 Use NULL for the secure-auth method for POP when Password auth has been
1450 specified by the user, as we already do for IMAP. "auth=Login" causes
1451 an error from camel or the server.
1453 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1455 * src/maemo/modest-account-settings-dialog.c:
1456 (create_page_account_details),
1457 (modest_account_settings_dialog_set_account_name):
1458 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1459 for the leave-on-server checkbox, rathr than just the checkbox, when
1460 the protocol is not POP.
1462 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1464 * src/widgets/modest-account-view.c:
1465 * src/widgets/modest-account-view.h:
1466 Added modest_account_view_select_account() which will be useful later
1467 to asynchronously re-select the edited account.
1469 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1471 * src/maemo/modest-account-settings-dialog.c:
1472 (modest_account_settings_dialog_set_account_name):
1473 Automatically choose the port numbers based on the secure authentication
1474 methods, if they have not been chosen before.
1475 This fixes projects.maemo.org bug NB#56273 .
1477 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1479 * src/maemo/modest-main-window-ui.h:
1480 * src/modest-ui-actions.c:
1481 * src/modest-ui-actions.h:
1482 Connect the Tools/SMTP Servers menu item to
1483 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1484 SMTP servers dialog, as in the UI specification and saves changes when it
1485 is closed. This fixed projects.maemo.org bug NB#56305 .
1487 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1489 * src/maemo/modest-connection-specific-smtp-window.c:
1490 (modest_connection_specific_smtp_window_init):
1491 Use gtk_window_set_default_size() to make this window big enough, so
1492 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1494 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1496 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1497 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1498 (modest_connection_specific_smtp_edit_window_init),
1499 Do not try to connect to a combobox signal before the combobox exists.
1500 This fixes the cras in projects.maemo.org bug NB#56288 .
1501 (modest_connection_specific_smtp_edit_window_get_settings):
1502 Remove the server_account_name parameter which was being checked for NULL
1503 though it was not used.
1505 * src/maemo/modest-connection-specific-smtp-window.c:
1506 (modest_connection_specific_smtp_window_fill_with_connections),
1507 (on_button_edit), (modest_connection_specific_smtp_window_init):
1508 Correct the number of treemodel columns to prevent a warning.
1509 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1510 libconic does not work.
1512 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1514 * src/modest-tny-account.c:
1515 (modest_tny_account_new_from_server_account):
1516 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1517 SMTP when "None" was chosen by the user. However, with my SMTP server that
1518 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1521 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1523 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1524 to explain the memory management issue with the ID in the ModestPair.
1526 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1527 (add_sending_page), (modest_account_assistant_finalize):
1528 * src/gnome/modest-gnome-global-settings-dialog.c:
1529 (create_updating_page), (create_composing_page):
1530 * src/gnome/modest-msg-edit-window.c: (get_transports),
1531 (init_window), (modest_msg_edit_window_finalize),
1532 (modest_msg_edit_window_get_msg_data):
1533 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1534 * src/gnome/modest-transport-widget.c:
1535 (modest_transport_widget_finalize), (smtp_configuration):
1536 * src/maemo/modest-maemo-global-settings-dialog.c:
1537 (create_updating_page), (create_composing_page):
1538 * src/maemo/modest-msg-edit-window.c: (get_transports),
1539 (init_window), (modest_msg_edit_window_finalize),
1540 (modest_msg_edit_window_get_msg_data),
1541 (modest_msg_edit_window_free_msg_data):
1542 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1543 (modest_store_widget_finalize):
1544 * src/maemo/modest-transport-widget.c:
1545 (modest_transport_widget_finalize), (smtp_configuration):
1546 * src/modest-main.c: (send_mail):
1547 * src/widgets/modest-combo-box.h:
1548 * src/widgets/modest-global-settings-dialog-priv.h:
1549 * src/widgets/modest-global-settings-dialog.c:
1550 (modest_global_settings_dialog_finalize):
1551 * src/widgets/modest-msg-edit-window.h:
1552 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1553 as long as the combo box, to prevent use of freed memory for the ID.
1555 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1557 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1558 get_accounts(), to make this clearer. Do not check for the enabled gconf
1559 key, because we do not use this for server accounts (at least, not yet).
1560 This allows us to send email again.
1562 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1564 * src/maemo/modest-platform.c:
1565 (on_modest_conf_update_interval_changed), (modest_platform_init):
1566 Only respond to this particular key change. All these strcmp()s cannot be
1569 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1571 * src/maemo/modest-maemo-global-settings-dialog.c:
1572 (current_connection): Prevent a crash in scratchbox when
1573 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1574 * src/maemo/modest-platform.c:
1575 (on_modest_conf_update_interval_changed), (modest_platform_init):
1576 Get the update interval from gconf and reset it when the gconf key changes.
1578 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1580 * src/modest-protocol-info.c:
1581 * src/modest-protocol-info.h: Adde enum-specific get functions,
1582 instead of using a ModestProtocolType enum parameter.
1584 * src/gnome/modest-account-assistant.c:
1585 * src/gnome/modest-store-widget.c:
1586 * src/gnome/modest-store-widget.h:
1587 * src/gnome/modest-transport-widget.c:
1588 * src/gnome/modest-transport-widget.h:
1589 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1590 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1591 * src/maemo/easysetup/modest-easysetup-wizard.c:
1592 * src/maemo/modest-account-settings-dialog.c:
1593 * src/maemo/modest-account-settings-dialog.h:
1594 * src/maemo/modest-store-widget.c:
1595 * src/maemo/modest-store-widget.h:
1596 * src/maemo/modest-transport-widget.c:
1597 * src/maemo/modest-transport-widget.h:
1598 * src/modest-account-mgr-helpers.c:
1599 * src/modest-account-mgr-helpers.h:
1600 * src/modest-account-mgr.c:
1601 * src/modest-account-mgr.h:
1602 * src/modest-tny-account.c:
1603 * src/modest-tny-folder.c:
1604 * src/widgets/modest-account-view.c:
1605 * src/widgets/modest-retrieve-combo-box.c:
1606 * src/widgets/modest-retrieve-combo-box.h:
1607 * src/widgets/modest-secureauth-combo-box.c:
1608 * src/widgets/modest-serversecurity-combo-box.c:
1609 * src/widgets/modest-serversecurity-combo-box.h:
1610 * tests/check_account-mgr.c:
1611 Use the specific functions, and use the re-renamed enum values for GNOME too.
1613 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1615 * src/modest-pair.h:
1616 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1617 so we can get the second based on the first.
1619 * src/maemo/modest-account-settings-dialog.h:
1620 * src/maemo/modest-account-settings-dialog.c:
1621 Added get_supported_secure_authentication_methods(), though it is mostly
1622 commented-out for now until the necessary API is committed to tinymail.
1623 (modest_account_settings_dialog_set_account_name),
1624 (save_configuration): Request the supported authentication methods from the
1625 server, so we can choose a working method.
1627 * src/modest-tny-account-store.h:
1628 * src/modest-tny-account-store.c:
1629 (modest_tny_account_store_get_session): Rename from
1630 tny_account_store_get_session().
1632 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1634 * src/modest-protocol-info.h: Split the ModestProtocol enum
1635 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1636 There was no need to have these unrelated values in one enum.
1638 * src/: many files: Adapted to changed enum. This makes the code a bit
1639 clearer, and the compiler could catch some errors.
1641 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1643 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1644 Show the detailed internal camel error message when an error happens
1645 during the configuration, so that our testers can give us more clues.
1646 For instance, in projects.maemo.org bug NB#56910 .
1648 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1650 * src/modest-tny-account.c:
1651 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1652 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1654 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1656 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1657 * src/maemo/modest-account-settings-dialog.c:
1658 (modest_account_settings_dialog_set_account_name),
1659 (save_configuration): For the incoming secure authentication checkbox,
1660 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1661 the UI specification. PLAIN does not seem to be supported for most IMAP
1662 servers anyway, and I am not sure what it would mean.
1663 However, we probably need to discover which of the secure-authentication
1664 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1665 * src/modest-account-mgr-helpers.c:
1666 (modest_account_mgr_get_server_account_data):
1668 * src/modest-tny-account.c:
1669 (modest_tny_account_new_from_server_account):
1670 Use tny_account_set_mech() to set secure-authentication methods,
1671 with some special-casing for IMAP, based on my observations of how
1674 * src/modest-account-mgr-helpers.h:
1675 * src/modest-account-mgr.c:
1676 * src/modest-defs.h: Comment that the URI is only used for local folders.
1678 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1680 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1681 parameter const, just to be neat.
1682 * src/modest-text-utils.c: (modest_text_utils_inline):
1683 End g_strconcat() with NULL, as its documentation says. This is almost
1684 certainly the cause of my crash at startup on the device. Interestingly,
1685 valgrind doesn't tell us about these errors.
1687 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1689 * scripts/build-packages: Added more precise comments about how to use
1690 this script, though I still get this error:
1691 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1692 error building tinymail
1694 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1696 * src/maemo/modest-main-window.c: (on_account_update):
1697 Very slight cleanup, hoping to make it simpler to discover what causes
1698 a crash here sometimes.
1700 * src/modest-tny-account.c:
1701 (modest_tny_account_new_from_server_account): Set the port. Added
1702 comments about the options and a TODO comment because I need to find out
1703 how to specify the secure authentication method.
1705 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1707 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1708 changed CFlags paths form modest to libmodest
1710 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1712 * src/modest-account-mgr-helpers.c:
1713 (modest_account_mgr_get_server_account_data),
1714 (modest_account_mgr_free_server_account_data):
1715 * src/modest-account-mgr-helpers.h:
1716 * src/modest-account-mgr.c:
1717 (modest_account_mgr_add_server_account):
1718 * src/modest-defs.h:
1719 * src/modest-tny-account.c:
1720 (modest_tny_account_new_from_server_account):
1721 Determine the options for tny_camel_account_add_option() here,
1722 based on the settings, rather than storing them directly in gconf.
1724 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1726 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1727 Show a more friendly error dialog now that we expect (from the tinymail
1728 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1730 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1732 * src/maemo/modest-main-window.c: (on_account_update): Check that
1733 account_name is not NULL, to prevent a crash at startup that I am
1734 seeing on the N800. I do wonder why it is NULL.
1736 * src/maemo/easysetup/modest-easysetup-wizard.c:
1737 (create_page_user_details):
1738 * src/maemo/modest-account-settings-dialog.c:
1739 (create_page_user_details), (create_page_outgoing):
1740 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1741 (modest_connection_specific_smtp_edit_window_init):
1742 * src/modest-ui-actions.c:
1743 (modest_ui_actions_on_password_requested):
1744 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1745 might do something useful with the on-screen keyboard.
1747 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1749 * src/maemo/modest-main-window.c: (on_account_update):
1750 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1751 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1753 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1755 * src/modest-tny-account-store.c: (on_account_changed):
1756 Correct the signature of this signal handler.
1758 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1760 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1761 Show a HildonNote instead of a GtkDialog for Maemo.
1763 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1765 * src/widgets/modest-account-view.h:
1766 * src/widgets/modest-account-view.c: (on_account_changed),
1767 (on_account_removed). Added a boolean flag, set/unset by
1768 modest_account_view_block_conf_updates(),
1769 modest_account_view_unblock_conf_updates() to prevent unnecessary
1770 updates, but this is not very useful because the gconf notifications are
1771 so delays (maybe only on Maemo Bora).
1772 So auto-updating is turned off, and these functions do an explicit
1773 update when necessary.
1774 However, something else is still doing too much work when adding/removing
1775 accounts, probably in another part of the application.
1777 * src/maemo/modest-account-view-window.c:
1778 (on_delete_button_clicked), (on_edit_button_clicked),
1779 (on_new_button_clicked): Use the new functions.
1781 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1783 * src/modest-account-mgr-helpers.c:
1784 (modest_account_mgr_set_first_account_as_default):
1785 Sort the list of names alphabetically-by-title, so we choose the first one
1787 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1788 alphabetically by the title.
1790 This fixes projects.maemo.org bug NB#56418 .
1792 * src/modest-account-mgr-priv.c:
1793 (_modest_account_mgr_account_from_key):
1794 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1795 avoid a valgrind error, and possible random behaviour.
1797 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1799 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1800 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1801 tinymail documentation to say that this can be expected.
1802 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1803 pretty, and should not happen, but I would prefer to know when it does.
1805 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1807 * configure.ac: When using the older hildon version, probably on Bora,
1808 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1810 * src/widgets/modest-attachment-view.c:
1811 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1814 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1816 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1817 Implemented the prototype. Can be tested with
1818 tests/dbus_api/test_open_message:
1820 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1822 * src/modest-tny-account-store.c:
1823 (modest_tny_account_store_instance_init), (get_password):
1824 * src/modest-ui-actions.c:
1825 (modest_ui_actions_on_password_requested):
1826 Do not store the password in gconf, because this function is called
1827 for non-remembered passwords. Actually use the cached (in the hash map)
1828 password instead of releasing it.
1829 The password will now not be remembered if it is asked via the protected
1830 password dialog, as per the UI spec.
1832 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1834 * src/modest-defs.h:
1835 * src/modest-account-mgr-helpers.h:
1836 * src/modest-account-mgr-helpers.c:
1837 Added modest_server_account_get_username_has_succeeded(),
1838 modest_server_account_set_username_has_succeeded().
1839 (modest_server_account_set_username),
1840 Reset the has-succeeded flag if the username changes.
1842 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1843 * src/maemo/modest-connection-specific-smtp-window.c:
1844 (modest_connection_specific_smtp_window_save_server_accounts):
1845 Use modest_server_account_set_username() instead of using
1846 modest_conf_set_string() directly, so that the has-succeeded flag is always
1849 * src/modest-ui-actions.c:
1850 (modest_ui_actions_on_password_requested): Dim the username entry if
1851 the username has ever worked, as per the UI spec.
1853 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1855 * src/modest-tny-account-store.c: (get_password):
1856 * src/modest-ui-actions.c:
1857 (modest_ui_actions_on_password_requested):
1858 Allow the username to be changed too, though there is more work to
1859 be done on exactly how this behaves.
1861 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1863 * src/modest-account-mgr-helpers.h:
1864 * src/modest-account-mgr-helpers.c:
1865 Added modest_account_mgr_get_display_name(),
1866 modest_server_account_get_username(),
1867 modest_server_account_set_username(),
1868 modest_server_account_set_password(),
1869 modest_server_account_get_hostname() functions so we do not need to
1870 use the conf API directly.
1872 * src/maemo/modest-main-window.c: (connect_signals):
1873 Actually connect ot the ModestAccountStore::request-password signal,
1874 so that we show the dialog when the password is requested by Tinymail,
1875 for isntance if it is empty.
1877 * src/modest-marshal.list:
1878 * src/modest-tny-account-store.c:
1879 (modest_tny_account_store_class_init), (get_password),
1880 (modest_tny_account_store_alert):
1881 * src/modest-tny-account-store.h:
1882 * src/modest-ui-actions.h:
1883 * src/modest-ui-actions.c:
1884 (modest_ui_actions_on_password_requested):
1885 Change the signal parameters, so it is obvious that we are providing
1886 the non human-readable server name, and receiving both the username
1887 and password, though changing of the username is not yet implemented.
1888 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1889 for the GNOME version.
1891 This should fix the projects.maemo.org bug NB#56209, though it does not
1892 work on Bora, because the gconf_client_get() for the password fails
1893 immediately after we save it with gconf_client_set().
1895 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1898 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1899 caused an undefined symbol error:
1900 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1902 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1904 * src/modest-tny-account-store.c:
1905 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1906 using a GError instead of a string message, so we can translate it in
1909 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1911 * src/maemo/modest-address-book.c:
1912 (modest_address_book_check_names):
1913 * src/maemo/modest-msg-view-window.c:
1914 (modest_msg_view_window_clipboard_owner_change):
1915 * src/modest-init.c: (modest_init_init_ui):
1916 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1917 (update_folders_cb), (modest_mail_operation_update_account):
1918 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1919 (modest_ui_actions_on_msg_attachment_clicked),
1920 (modest_ui_actions_on_msg_recpt_activated):
1921 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1922 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1923 (modest_msg_view_search_next):
1924 * src/widgets/modest-recpt-editor.c:
1925 (modest_recpt_editor_on_button_release_event),
1926 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1927 g_message(). At this point we should only be seeing interesting errors on
1928 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1930 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1932 (modest_wizard_dialog_force_title_update):
1933 * src/maemo/easysetup/modest-wizard-dialog.h:
1934 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1935 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1936 can update the title when appropriate. Otherwise the title is wrong if the
1937 pages are added after adding the notebook to the dialog.
1938 This must be a problem in HildonWizardDialog too.
1939 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1941 * src/maemo/easysetup/modest-easysetup-wizard.c:
1942 (create_subsequent_customsetup_pages),
1943 (create_subsequent_easysetup_pages):
1944 Call modest_wizard_dialog_force_title_update() so that the title is
1945 correct even with GTK+ < 2.10.
1946 This fixes projects.maemo.org bug NB#56145 .
1948 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1950 * src/maemo/modest-platform.c:
1951 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1952 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1955 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1957 * src/widgets/modest-window.h:
1958 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1959 and modest_window_save_state(), which invokes it.
1961 * src/widgets/modest-window-mgr.h:
1962 * src/widgets/modest-window-mgr.c:
1963 Added modest_window_mgr_save_state_for_all_windows(), which calls
1964 the save_state vfunc on all registered windows, if implemented.
1966 * src/gnome/modest-msg-edit-window.c:
1967 * src/gnome/modest-msg-view-window.c:
1968 * src/maemo/modest-msg-edit-window.c:
1969 * src/maemo/modest-msg-view-window.c:
1970 * src/maemo/modest-main-window.c:
1971 Specify the existing save_settings functions as implementations of
1972 ModestWindow::save_state_func().
1974 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1975 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1976 enabling hibernation, for instance.
1978 We may need to do the same thing for restoring settings.
1981 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1983 * src/widgets/modest-window-mgr.c:
1984 * src/widgets/modest-window-mgr.h:
1985 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1986 modest_window_mgr_get_hibernation_is_prevented().
1988 * src/maemo/modest-main-window.c:
1989 (on_hildon_program_is_topmost_notify): Prevent hibernation
1990 (possible when the application goes to the background in the WM),
1991 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1993 * src/maemo/easysetup/modest-easysetup-wizard.c:
1994 (modest_easysetup_wizard_dialog_init):
1995 * src/maemo/modest-account-settings-dialog.c:
1996 (modest_account_settings_dialog_init):
1997 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1998 (modest_connection_specific_smtp_edit_window_init):
1999 * src/maemo/modest-connection-specific-smtp-window.c:
2000 (modest_connection_specific_smtp_window_init):
2001 * src/maemo/modest-signature-editor-dialog.c:
2002 (modest_signature_editor_dialog_init):
2003 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2004 prevent hibernation while any of these account settings dialogs are open.
2006 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2008 * src/maemo/Makefile.am:
2009 * src/maemo/modest-osso-state-saving.c:
2010 * src/maemo/modest-osso-state-saving.h: Added
2011 modest_osso_load_state() and modest_osso_save_state() though they do
2012 nothing now. They should iterate through all the open windows and load/save
2014 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2015 save state when closing.
2017 * src/maemo/modest-main-window.c:
2018 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2019 Add a notification handler for the HildonProgram::is-topmost property,
2020 so we can allow hibernation when the application goes into the background.
2021 But we still need to detect when the accounts setup windows are open so
2022 we can stop hibernation when they are open.
2023 To do this, I also added the main window the HildonProgram. This might have
2024 other side-effects/benefits, and should maybe be done for other windows.
2026 * src/maemo/modest-osso-autosave-callbacks.h:
2027 * src/maemo/modest-osso-autosave-callbacks.c:
2028 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2029 though it does not do anything yet, and we might never need this to do
2030 anything. For instance, we already save drafts.
2032 * src/maemo/modest-platform.c: (modest_platform_init):
2033 Specify the libosso auto-save callback.
2035 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2037 * src/maemo/modest-platform.c:
2038 (modest_platform_set_update_interval):
2039 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2040 aparently stays valid between application instances, so we can use this
2041 to remove and reset it later. According to a maemo-developers email from
2044 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2046 * configure.ac: Depend on libalarm for Maemo.
2048 * src/dbus_api/modest-dbus-api.h:
2049 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2050 (on_send_receive), (modest_dbus_req_handler):
2051 Handle a SEND_RECEIVE D-Bus method.
2053 * libmodest-dbus-client/libmodest-dbus-client.c:
2054 (libmodest_dbus_client_send_and_receive):
2055 * libmodest-dbus-client/libmodest-dbus-client.h:
2056 Add C convenience functions for calling the new D-Bus method.
2058 * src/modest-platform.h:
2059 * src/gnome/modest-platform.c:
2060 * src/maemo/modest-platform.c:
2061 Added modest_platform_set_update_interval(), which uses the
2062 alarmd API on Maemo.
2063 (modest_platform_init),
2064 Call modest_platform_set_update_interval(), using a hard-coded
2065 interval for now (until the global settings dialog is implemented),
2066 though I am not sure that this makes sense yet.
2068 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2070 * src/dbus_api/modest-dbus-callbacks.c:
2071 (modest_osso_cb_hw_state_handler):
2072 * src/dbus_api/modest-dbus-callbacks.h:
2073 * src/maemo/modest-platform.c: (modest_platform_init):
2074 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2075 in case this has some effect on the ability for Maemo to ping the
2078 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2080 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2081 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2082 warning. It is probably a logic error, but I need to fix the build.
2084 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2086 * src/modest-account-mgr.h:
2087 * src/modest-account-mgr.c:
2088 (modest_account_mgr_account_names): Add a gboolean enabled_only
2089 parameter, so we can get lists of onlt the enabled accounts.
2091 (modest_account_mgr_add_account),,
2092 (modest_account_mgr_account_with_display_name_exists):
2093 * src/maemo/modest-msg-edit-window.c: (get_transports):
2094 * src/modest-account-mgr-helpers.c:
2095 (modest_account_mgr_set_first_account_as_default):
2096 * src/modest-init.c: (init_default_account_maybe):
2097 * src/modest-tny-account-store.c: (get_accounts):
2098 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2099 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2100 * tests/check_account-mgr.c: (START_TEST):
2101 Provide the extra parameter, as appropriate.
2103 * src/widgets/modest-account-view.c: (update_account_view):
2104 Do not show disabled accounts (meaning that there is no way to
2105 enable/disable accounts in the UI (the feature is not in our UI
2106 specification), so we can use this internally only to mark unfinished
2107 or temporary account data.
2109 * src/maemo/easysetup/modest-easysetup-wizard.c:
2110 (create_account): Add boolean enable parameter, so we can specify FALSE
2111 to create the temporary account.
2112 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2113 (on_before_next): When finishing, when there is a temporary account, just
2115 Also, use a timeout to delay the showing of the dialog until gconf is likely
2116 to return correct information, due to a maemo gconf bug that is fixed in
2117 osso 1.1, but not yet in Bora.
2118 However, the dialog stays on screen after it is destroyed.
2120 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2121 for invalid data when cancelling. Use a hildon note instead of a dialog
2122 to complain about invalid data. Do not show the account-saved note if the
2123 account is disabled (a temporary account that will not really be saved for use
2126 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2128 * src/modest-account-mgr-helpers.h:
2129 * src/modest-account-mgr-helpers.c:
2130 Added modest_account_mgr_unset_default_account(),
2131 Added modest_account_mgr_set_first_account_as_default().
2133 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2134 If it was the default account, unset the default account name.
2136 * src/maemo/modest-account-view-window.c:
2137 (on_delete_button_clicked): If it was the default account,
2138 set the first remaining account as the default instead.
2140 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2141 a NULL account or a NULL default account, to prevent a crash. This should
2142 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2145 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2147 * src/widgets/modest-recpt-editor.c:
2148 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2149 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2150 TODO comment for this. This fixes the build.
2152 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2153 be the best place for it. This will in future update all auto-update accounts,
2154 rather than just the current/default account, when that gconf key exists.
2155 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2156 if there are no accounts, before calling do_send_receive().
2157 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2159 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2160 * src/maemo/modest-main-window-ui.h:
2161 * src/maemo/modest-main-window.c: (on_connection_changed),
2162 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2163 directly, becaue the signal handler does more.
2165 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2167 * src/modest-account-mgr-helpers.c:
2168 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2169 for the case that the account does not exist.
2171 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2172 (equivalent to the modest account name) rather than the tinymail account name
2173 (equivalent to the modest account title - human readable) to get the account data.
2174 Check for null account data to prevent the crash, and add a TODO comment saying that
2175 this needs fixing because it is using the server account name instead of the account name.
2177 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2179 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2180 * src/maemo/modest-account-settings-dialog.c: (show_error),
2182 Use hildon_note_new_information() for informative and error messages,
2183 which seems to be expected for Maemo applications (no documentation that I know of
2184 says this). I am surprised that there is no distinction between info and error
2187 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2189 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2190 it is easy to find where this is used.
2192 * src/maemo/easysetup/modest-easysetup-wizard.c:
2193 (create_page_welcome), (create_page_account_details),
2194 (create_page_user_details), (create_page_complete_easysetup),
2195 (create_page_custom_incoming), (create_page_custom_outgoing),
2196 (create_page_complete_custom):
2197 * src/maemo/modest-account-settings-dialog.c:
2198 (create_page_account_details), (create_page_user_details),
2199 (create_page_incoming), (create_page_outgoing):
2200 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2201 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2202 (modest_connection_specific_smtp_edit_window_init):
2203 * src/maemo/modest-connection-specific-smtp-window.c:
2204 (modest_connection_specific_smtp_window_init):
2205 * src/maemo/modest-signature-editor-dialog.c:
2206 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2207 and scrolling policy as per the Email Application Layout Guide, if I have
2210 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2212 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2213 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2214 which were empty, because these vfuncs have been removed from TnyAccountStore.
2215 This fixes the build.
2217 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2219 * src/maemo/modest-main-window.c:
2220 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2221 showing/hiding it. Added TODO because it probably should not be NULL.
2222 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2223 because unnecessary g_warnings() make degugging difficult.
2225 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2227 * src/maemo/modest-msg-edit-window.c:
2228 (modest_msg_edit_window_select_color),
2229 (modest_msg_edit_window_select_background_color): 2 const corrections and
2230 moving 2 #endifs before closing brackets, to fix the build.
2232 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2234 * src/maemo/easysetup/modest-easysetup-wizard.h:
2235 * src/maemo/easysetup/modest-easysetup-wizard.c:
2236 (modest_easysetup_wizard_dialog_finalize),
2237 (on_button_edit_advanced_settings), (create_page_complete_custom),
2238 (on_response), (create_account):
2239 Implement the Advanced Settings edit button, by saving the account information,
2240 for the Advanded Settings dialog to use directly from gconf, and removing it
2241 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2242 Bug #5533 in the projects.maemo.org bugzilla.
2244 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2246 * src/maemo/modest-msg-view-window.c:
2247 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2248 when opening a message window.
2250 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2252 * src/maemo/easysetup/modest-easysetup-wizard.c:
2253 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2256 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2257 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2258 gconf settings. I probably added more checks than necessary, but that is safer.
2260 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2261 variable to fix the build, but this seems to be used when it is still NULL.
2263 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2265 * src/modest-platform.h:
2266 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2267 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2268 * src/modest-main.c: Implement this function so we can avoid using
2269 maemo-specific API from cross-platform code.
2271 * src/modest-tny-account-store.c:
2272 (get_smtp_specific_transport_account_for_open_connection):
2273 * src/modest-ui-actions.c: (check_for_connection),
2274 (modest_ui_actions_on_item_not_found):
2275 Use modest_platform_connect_and_wait() and put #idefs around other
2276 maemo-specific code, because only maemo currently has a way to
2277 identify connection names.
2279 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2281 * src/modest-tny-account-store.h:
2282 * src/modest-tny-account-store.c:
2283 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2284 the connection-specific SMTP server settings in the configuration.
2286 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2288 * src/maemo/modest-main-window.c: (on_connection_changed),
2290 * src/modest-main.c: (main), (start_ui), (send_mail):
2291 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2292 that is what is intended.
2294 * src/modest-ui-actions.c: (action_send), (action_receive),
2295 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2296 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2297 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2298 SMTP server is used when it is specified.
2300 (modest_ui_actions_on_send_receive):
2301 Check that a connection is open before proceeding.
2302 Receive and then send, instead of vice-versa, as per the specification.
2304 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2306 * src/modest-mail-operation.c:
2307 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2308 though I guess it should be something other than NULL.
2310 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2312 * src/maemo/easysetup/modest-easysetup-wizard.c:
2313 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2314 combo twice, to avoid an g_warning and to make it visible again.
2315 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2316 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2317 (already intended) dereference when detaching, because we then recreate the menu.
2318 But I am not sure why the warning was happening, and it is possible that this is a memory
2321 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2323 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2324 and uri_parse_mailto() utility functions.
2325 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2327 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2329 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2331 * src/dbus_api/modest-dbus-api.h:
2332 * src/dbus_api/modest-dbus-callbacks.c:
2333 Use an idle callback to execute the modest code in the application's own thread.
2334 Remove the helloworld example method.
2335 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2336 parsed, and the open-message method is not implemented because this is not yet implemented in
2338 * libmodest-dbus-client/libmodest-dbus-client.c:
2339 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2340 (libmodest_dbus_client_open_message):
2341 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2343 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2344 body without crashing.
2346 * tests/dbus_api/Makefile.am:
2347 * tests/dbus_api/test_mail_to.c:
2348 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2350 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2352 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2353 Added file to fix the build. Sorry.
2355 * src/dbus_api/Makefile.am:
2356 * src/dbus_api/modest-dbus-api.h:
2357 * src/dbus_api/modest-dbus-callbacks.h:
2358 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2359 (modest_dbus_req_handler):
2360 Put constants in a separate header so it can be reused by the
2361 client library, without duplication
2363 * libmodest-dbus-client/Makefile.am:
2364 * libmodest-dbus-client/libmodest-dbus-client.c:
2365 (libmodest_dbus_client_call_helloworld),
2366 (libmodfest_dbus_client_send_mail),
2367 (libmodfest_dbus_client_mailto),
2368 (libmodfest_dbus_client_open_message):
2369 * libmodest-dbus-client/libmodest-dbus-client.h:
2370 (Partly) Implement a send_mail D-Bus method.
2372 * tests/dbus_api/Makefile.am:
2373 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2374 the send_email D-Bus method.
2376 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2380 * libmodest-dbus-client/Makefile.am:
2381 * libmodest-dbus-client/libmodest-dbus-client.c:
2382 * libmodest-dbus-client/libmodest-dbus-client.h:
2383 * tests/dbus_api/Makefile.am:
2384 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2385 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2387 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2389 * src/maemo/easysetup/modest-easysetup-wizard.c:
2390 (create_page_account_details):
2391 * src/maemo/modest-account-settings-dialog.c:
2392 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2393 widgets, because this might not be the default in future versions of the Maemo GTK+.
2394 However, I can not not get capitalization to work even in a simple test case.
2396 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2398 * src/maemo/easysetup/modest-easysetup-wizard.c:
2399 (create_page_custom_incoming), (create_page_custom_outgoing):
2400 * src/maemo/modest-account-settings-dialog.c:
2401 (create_page_account_details), (create_page_incoming),
2402 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2403 instead of using gtk_check_button_with_label(), so they are aligned like the other
2404 widgets, as per the UI spec.
2406 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2408 * src/maemo/easysetup/modest-easysetup-wizard.c:
2409 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2410 * src/widgets/modest-validating-entry.c:
2411 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2412 Modest prefix instead of an EasySetup prefix.
2414 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2416 * src/widgets/modest-validating-entry.h:
2417 * src/widgets/modest-validating-entry.c: (on_insert_text),
2418 Added easysetup_validating_entry_set_max_func(), used to set a callback
2419 to call when the max number of characters is reached. GtkEntry has a max-length
2420 already but is silent about it.
2422 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2423 (create_page_account_details), (create_page_user_details),
2425 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2426 (create_page_account_details), (create_page_user_details),
2427 (create_page_outgoing):
2428 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2429 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2430 the UI spec, when the user tries to enter more than the max number of characters.
2432 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2434 * src/maemo/easysetup/modest-easysetup-wizard.c:
2435 (create_page_user_details), (create_page_custom_incoming),
2436 (create_page_custom_outgoing):
2437 * src/maemo/modest-account-settings-dialog.c:
2438 (create_page_user_details), (create_page_incoming),
2439 (create_page_outgoing):
2440 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2441 (modest_connection_specific_smtp_edit_window_init):
2442 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2443 not appropriate. Bad Maemo-specific defaults!.
2445 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2447 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2448 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2449 (modest_signature_editor_dialog_set_settings):
2450 Disable the label and textview when the checkbox is disabled, and use the
2451 specified (UI spec) default signature text.
2453 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2455 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2456 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2458 * src/modest-defs.h:
2459 * src/modest-account-mgr-helpers.h:
2460 * src/modest-account-mgr-helpers.c:
2461 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2463 * src/maemo/Makefile.am:
2464 * src/maemo/modest-signature-editor-dialog.c:
2465 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2468 * src/maemo/modest-account-settings-dialog.h:
2469 * src/maemo/modest-account-settings-dialog.c:
2470 (modest_account_settings_dialog_finalize), (on_button_signature),
2471 (save_configuration): Use the new dialog when the Edit button is pressed, and
2472 save the changes if necessary, as per the UI spec.
2474 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2476 * src/maemo/Makefile.am:
2477 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2478 based on maemo-develoers email from Dirk.
2480 * src/maemo/easysetup/modest-easysetup-wizard.c:
2481 (create_page_welcome), (create_page_account_details),
2482 (create_page_user_details), (create_page_complete_easysetup),
2483 (create_page_custom_incoming), (create_page_custom_outgoing),
2484 (create_page_complete_custom),
2485 (modest_easysetup_wizard_dialog_init):
2486 * src/maemo/modest-account-settings-dialog.c:
2487 (create_page_account_details), (create_page_user_details),
2488 (create_page_incoming), (create_page_outgoing),
2489 (modest_account_settings_dialog_init):
2490 * src/maemo/modest-connection-specific-smtp-window.c:
2491 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2493 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2495 * src/maemo/easysetup/modest-easysetup-wizard.c:
2496 (create_page_account_details), (create_page_custom_outgoing),
2497 (create_page_complete_custom):
2498 * src/maemo/modest-account-settings-dialog.c:
2499 (create_page_user_details), (create_page_incoming),
2500 (create_page_outgoing):
2501 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2502 (modest_connection_specific_smtp_edit_window_init):
2503 Use the correct (UI spec) port min/max, and use horizontal separators,
2506 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2508 * src/maemo/easysetup/modest-easysetup-wizard.c:
2509 (set_default_custom_servernames):
2510 * src/maemo/modest-account-settings-dialog.c:
2511 (create_page_incoming), (on_combo_outgoing_security_changed),
2512 (on_combo_incoming_security_changed), (create_page_outgoing),
2513 (modest_account_settings_dialog_set_account_name),
2514 (save_configuration):
2515 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2516 (on_combo_security_changed),
2517 (modest_connection_specific_smtp_edit_window_init),
2518 (modest_connection_specific_smtp_edit_window_set_connection),
2519 (modest_connection_specific_smtp_edit_window_get_settings):
2520 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2523 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2526 * src/maemo/easysetup/modest-easysetup-wizard.c:
2527 (create_page_custom_outgoing), (create_page_complete_custom):
2528 * src/maemo/modest-account-settings-dialog.c:
2529 (create_page_user_details), (create_page_outgoing):
2530 * src/maemo/modest-account-view-window.c: (button_box_new):
2531 Use changed logical IDs as per the most recent UI spec:
2532 mcen_bd_emailsetup_edit -> mcen_bd_edit
2533 mcen_bd_emailsetup_delete -> mcen_bd_delete
2534 mcen_bd_emailsetup_close -> mcen_bd_close
2536 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2540 * src/dbus_api/Makefile.am:
2541 * src/dbus_api/modest-dbus-callbacks.c:
2542 * src/dbus_api/modest-dbus-callbacks.h:
2543 * src/maemo/modest-platform.c: (modest_platform_init):
2544 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2546 * tests/Makefile.am:
2547 * tests/dbus_api/Makefile.am:
2548 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2550 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2552 * src/maemo/modest-account-settings-dialog.c:
2553 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2554 Removed unnecessary includes.
2556 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2558 * src/maemo/easysetup/modest-easysetup-wizard.c:
2559 * src/maemo/modest-account-settings-dialog.c:
2560 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2561 * src/widgets/Makefile.am:
2562 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2563 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2564 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2565 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2566 * src/widgets/modest-secureauth-combo-box.c:
2567 * src/widgets/modest-secureauth-combo-box.h:
2568 * src/widgets/modest-serversecurity-combo-box.c:
2569 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2570 made the GObject names more consistent with the rest of the Modest code.
2572 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2574 * src/maemo/easysetup/Makefile.am:
2575 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2576 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2577 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2578 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2579 * src/maemo/easysetup/modest-easysetup-wizard.c:
2580 * src/maemo/easysetup/modest-validating-entry.c:
2581 * src/maemo/easysetup/modest-validating-entry.h:
2582 * src/maemo/modest-account-settings-dialog.c:
2583 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2584 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2585 widgets/ because they are used outside of easysetup too. After checking in,
2586 svn will allow me to rename them too.
2588 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2590 * src/gnome/modest-msg-edit-window.c:
2591 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2592 linker error, to fix the build on the GNOME platform.
2593 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2594 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2595 ifdefed out to avoid a warning.
2597 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2599 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2600 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2601 some alternative for GTK+ 2.6.
2603 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2605 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2607 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2608 specified for EmailAccountsDialog in UI spec.
2610 * src/maemo/easysetup/modest-easysetup-wizard.c:
2611 * src/maemo/easysetup/modest-easysetup-wizard.h:
2612 * src/maemo/modest-account-settings-dialog.c:
2613 * src/maemo/modest-account-settings-dialog.h:
2614 Reuse a member window widget for the connection-specific SMTP server accounts,
2615 so we can tell it to create/save the accounts only if we actually save changes.
2617 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2618 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2619 (modest_connection_specific_smtp_edit_window_get_settings):
2620 Return a struct instance for temporarily remembering the entered data.
2622 * src/maemo/modest-connection-specific-smtp-window.h:
2623 * src/maemo/modest-connection-specific-smtp-window.c:
2624 (modest_connection_specific_smtp_window_finalize),
2625 (modest_connection_specific_smtp_window_fill_with_connections),
2627 (modest_connection_specific_smtp_window_save_server_accounts),
2628 (update_model_server_names): Do not actually save data until asked,
2629 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2631 (on_selection_changed),
2632 (modest_connection_specific_smtp_window_init): Disable the edit
2633 button when nothing is selected.
2635 * src/modest-account-mgr-helpers.c:
2636 * src/modest-account-mgr-helpers.h:
2637 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2640 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2642 * src/modest-account-mgr-helpers.h:
2643 * src/modest-account-mgr-helpers.c:
2644 (modest_account_mgr_get_unused_account_name),
2645 (modest_account_mgr_get_unused_account_display_name): Added these
2646 utility functions, to avoid code duplication.
2648 * src/maemo/easysetup/modest-easysetup-wizard.c:
2649 (create_page_account_details), (create_account):
2650 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2651 (on_combo_security_changed),
2652 (modest_connection_specific_smtp_edit_window_init),
2653 (modest_connection_specific_smtp_edit_window_save_settings):
2654 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2655 * src/maemo/modest-connection-specific-smtp-window.c:
2656 (modest_connection_specific_smtp_window_finalize),
2657 (modest_connection_specific_smtp_window_fill_with_connections),
2658 (on_button_edit), (modest_connection_specific_smtp_window_init):
2659 * src/maemo/modest-connection-specific-smtp-window.h:
2660 Implementing saving of connection-specific server accounts.
2662 But I need to refactor this so we can save the data for each
2663 possible connection-specific account and only actually create the server accounts
2664 when the easysetup finished, or the OK button is pressed on the account settings
2667 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2669 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2670 (on_combo_security_changed):
2671 (modest_connection_specific_smtp_edit_window_init):
2672 Auto-fill the port number as in the account settings.
2674 (modest_connection_specific_smtp_edit_window_set_connection):
2675 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2676 * src/maemo/modest-connection-specific-smtp-window.c:
2677 (fill_with_connections), (on_button_edit),
2678 (modest_connection_specific_smtp_window_init):
2679 Turn the edit window into a dialog to simplify the code, and
2680 set a WM hint as in a GtkDialog, because only a popup can be on top of
2681 another window in Maemo, and popups usually have no WM decoration.
2683 * src/modest-defs.h:
2684 * src/modest-account-mgr-helpers.c:
2685 (modest_account_mgr_set_connection_specific_smtp),
2686 (modest_account_mgr_remove_connection_specific_smtp),
2687 (modest_account_mgr_get_connection_specific_smtp):
2688 * src/modest-account-mgr-helpers.h: Some functions to write the
2689 connection-specific SMTP server information. Not yet used.
2692 * src/widgets/modest-folder-view.c: (text_cell_data):
2693 Fix a warning about an uninitialized variable.
2694 (on_configuration_key_changed): Put an #ifdef around the use
2695 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2697 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2699 * src/maemo/modest-account-settings-dialog.h:
2700 * src/maemo/modest-account-settings-dialog.c:
2701 Added connect_for_modified() utility function to mark the new modified boolean.
2703 (create_page_account_details), (create_page_user_details),
2704 (create_page_incoming), (create_page_outgoing), (on_response),
2705 (modest_account_settings_dialog_init),
2706 (modest_account_settings_dialog_set_account_name):
2707 Only warn about unsaved changes when there are actually unsaved changes.
2709 * src/modest-account-mgr-helpers.c:
2710 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2711 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2712 to get the data from there in future.
2714 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2716 * src/modest-defs.h:
2718 * src/modest-account-mgr-helpers.h:
2719 * src/modest-account-mgr-helpers.c:
2720 Store the security account setting in a single conf key instead of using
2721 the options list, so that the list is left for just the to-be-removed camel hack,
2722 and because gconf_client_set_list() is failing for some reason.
2724 * src/modest-account-mgr.c:
2725 (modest_account_mgr_add_server_account):
2726 * src/maemo/modest-account-settings-dialog.c:
2727 (modest_account_settings_dialog_set_account_name),
2728 (save_configuration): Use the renamed functions.
2731 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2733 * src/widgets/Makefile.am:
2734 * src/widgets/modest-limit-retrieve-combo-box.c:
2735 * src/widgets/modest-limit-retrieve-combo-box.h:
2736 * src/widgets/modest-retrieve-combo-box.c:
2737 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2738 the account settings dialog.
2740 * src/modest-defs.h:
2741 * src/modest-account-mgr-helpers.h:
2742 * src/modest-account-mgr-helpers.c:
2743 (modest_server_account_get_option_secure_auth),
2744 (modest_server_account_set_option_secure_auth):
2745 * src/modest-account-mgr.c:
2746 (modest_account_mgr_add_server_account):
2747 Use the existing AUTH_MECH conf key for the secure-auth setting,
2748 instead of putting it in the list options, because this was actually used already.
2750 * src/maemo/modest-account-settings-dialog.c:
2751 (create_page_account_details),
2752 (modest_account_settings_dialog_set_account_name),
2753 (save_configuration):
2754 * src/maemo/modest-account-settings-dialog.h:
2755 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2756 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2758 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2760 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2761 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2762 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2764 * src/modest-defs.h:
2765 * src/maemo/modest-account-settings-dialog.c:
2766 (create_page_incoming), (on_combo_outgoing_security_changed),
2767 (on_combo_incoming_security_changed), (create_page_outgoing),
2768 (modest_account_settings_dialog_set_account_name),
2769 (save_configuration): Load/Save the port number, and change it when the
2770 security combo changes, to suitable defaults.
2772 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2774 * src/modest-account-mgr.c:
2775 (modest_account_mgr_add_server_account): Set the security and secure-auth
2776 options, and add a comment saying that the other camel-specific options should be
2779 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2781 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2783 * src/modest-tny-account-store.c: (account_list_free),
2784 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2785 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2788 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2790 * src/modest-protocol-info.c:
2791 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2792 is required by our UI spec. Maybe something in our implementation will use this eventually.
2793 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2794 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2795 instead of the previous 0 placeholder.
2797 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2798 secure-auth settings.
2799 * src/modest-account-mgr-helpers.h:
2800 * src/modest-account-mgr-helpers.c:
2801 (modest_server_account_data_get_option_secure_auth),
2802 (modest_server_account_set_option_secure_auth),
2803 (modest_server_account_data_get_option_security),
2804 (modest_server_account_set_option_security): Added this API for getting and setting the security
2805 and secure-auth settings.
2807 * src/maemo/modest-account-settings-dialog.h:
2808 * src/maemo/modest-account-settings-dialog.c:
2809 (modest_account_settings_dialog_finalize), (check_data),
2810 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2811 about changing titles.
2812 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2813 (save_configuration): Save the security and secure-auth settings.
2815 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2816 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2818 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2820 * src/modest-defs.h:
2821 * src/modest-account-mgr.c:
2822 (modest_account_mgr_add_server_account):
2823 Added and used defines for the options key and value pair strings,
2824 that are used so far, though they do not seem to correspond to anything in our
2825 UI specs or ModestProtocol enum.
2827 * src/modest-account-mgr-helpers.h:
2828 * src/modest-account-mgr-helpers.c:
2829 (compare_option_strings_for_name),
2830 (modest_server_account_data_get_option_value),
2831 (modest_server_account_data_get_option_bool),
2832 (modest_account_mgr_get_server_account_option):
2833 Added helper functions for parsing the options GSList.
2835 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2837 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2838 display name is based on the supplied account name.
2839 * src/modest-account-mgr.c:
2840 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2841 with an inefficient, but good-enough, implementation.
2843 * src/maemo/easysetup/modest-easysetup-wizard.c:
2844 (create_page_account_details), (on_before_next), (create_account):
2845 Check for existing display names rather than (non-user-visible) account names, and just
2846 create and set a unique account name at the end.
2848 * src/maemo/modest-account-settings-dialog.c:
2849 (modest_account_settings_dialog_init),
2850 (modest_account_settings_dialog_set_account_name),
2851 (create_page_incoming): Show the display name, instead of the account name.
2852 (on_response): Do some (not all) extra checks, as in the UI spec.
2853 (save_configuration): Save the display name if it was changed.
2855 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2857 * po/en_GB.po: Added needed logical ID and translation.
2858 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2859 (init_view): Made the is-default column clicking work.
2861 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2864 * src/maemo/easysetup/Makefile.am:
2865 * src/maemo/easysetup/modest-easysetup-wizard.c:
2866 (modest_easysetup_wizard_dialog_init):
2867 * src/maemo/easysetup/provider-data-test.keyfile:
2868 * src/maemo/easysetup/provider-data.keyfile:
2869 Moved the provider data file to the new modest-providers-data package and used it from there.
2871 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2873 * src/modest-local-folder-info.c:
2874 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2875 N_() was already used on the static strings, but this just marks it for translation without
2876 using the translation.
2878 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2880 * src/maemo/modest-account-settings-dialog.c:
2881 (create_page_incoming),
2882 (modest_account_settings_dialog_set_account_name):
2883 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2884 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2885 I will do this if nobody else gets there first.
2887 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2889 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2890 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2891 save the security stuff.
2893 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2895 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2896 Set the email address and user fullname, which I now see must be
2899 * src/maemo/modest-account-settings-dialog.h:
2900 * src/maemo/modest-account-settings-dialog.c:
2902 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2903 leave-on-server and authentication.
2904 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2907 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2910 * src/maemo/modest-account-settings-dialog.c:
2911 * src/maemo/modest-account-settings-dialog.h:
2912 Most (but not all) of the widgets are now present as specified by the UI spec.
2913 No changes are yet saved, and some details are not properly shown yet.
2915 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2917 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2919 * src/maemo/Makefile.am:
2920 * src/maemo/modest-account-settings-dialog.c:
2921 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2922 an existing account. Doesn't do much yet.
2924 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2925 Open the accounts settings dialog when Edit is clicked.
2927 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2929 * src/maemo/easysetup/Makefile.am:
2930 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2932 * src/maemo/easysetup/modest-easysetup-wizard.c:
2933 (modest_easysetup_wizard_dialog_init):
2934 Try to get the source directory from the build system,
2935 instead of hard-coding "./" into the source code, when opening our local
2936 copies of the configuration files.
2937 But this still fails when opening the wizard from the Accounts window,
2938 maybe because the working directory seems to change at runtime.
2939 So the wizard will fail the second time unless you copy the files into their
2940 proper locations - see the stdout warnings for the paths.
2942 (create_page_account_details),(on_before_next):
2943 Check for existing non-server accounts instead of server accounts,
2944 so the default account name is useful again, and to prevent trying to
2947 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2948 Show the wizard when New is clicked.
2950 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2951 (init_view): Show the column headers, and show the columns that are
2952 specified in the UI specs. However, something in Maemo's GTK+ prevents
2953 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2954 change the default account. This is despite unsetting the special properties.
2956 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2958 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2959 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2960 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2961 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2962 to make that clearer.
2963 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2965 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2967 * src/maemo/modest-account-view-window.c:
2968 (modest_account_view_window_init),
2969 (modest_account_view_window_new):
2970 Use the same buttons as specified in the
2971 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2972 the existing widgets, which never had a chance of working.
2973 Put the ModestAccountView treeview in a scrolled window.
2974 Do not repeat the initialization in both _init() and _new().
2976 * src/widgets/modest-account-view.c: (update_account_view):
2977 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2978 this widget and window shows no accounts.
2980 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2982 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2984 * src/maemo/easysetup/modest-easysetup-wizard.c:
2985 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2986 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2987 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2990 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2991 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2992 accounts exist yet, as in the UI spec.
2994 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2996 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2998 * src/maemo/Makefile.am:
2999 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3000 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3001 New window for editing connection-specific smtp details.
3002 Not fully implemented.
3004 * src/maemo/modest-connection-specific-smtp-window.c:
3005 (modest_connection_specific_smtp_window_finalize) :
3006 unref the tree model.
3007 (on_button_edit): Show the edit window.
3009 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3011 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3014 * src/maemo/Makefile.am:
3015 * src/maemo/modest-connection-specific-smtp-window.c:
3016 * src/maemo/modest-connection-specific-smtp-window.h:
3017 New window for showing the list of connections, for connection-specific
3018 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3019 * src/maemo/easysetup/modest-easysetup-wizard.c:
3020 (create_page_custom_outgoing): Show the new window when the button is clicked.
3022 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3024 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3025 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3026 * src/maemo/modest-msg-edit-window.c:
3027 (modest_msg_edit_window_insert_image):
3028 * src/modest-conf.c: (modest_conf_key_escape):
3029 * src/modest-mail-operation.c:
3030 (modest_mail_operation_send_new_mail):
3031 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3032 (modest_ui_actions_on_new_account):
3033 * src/widgets/modest-attachment-view.c: (update_filename_request):
3034 * src/widgets/modest-mail-header-view.c:
3035 Corrected warnings that were breaking the build, by commenting out unused variables,
3036 and a function, and by including a header.
3038 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3040 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3041 so we can #ifdef around platform-specific code when necessary.
3042 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3043 to allow this to build for the GNOME platform too.
3045 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3047 * src/maemo/easysetup/modest-easysetup-wizard.c:
3048 Added util_increment_name() and used it in create_page_account_details()
3049 to make sure that the default account name is always a new name.
3051 (modest_easysetup_wizard_dialog_init),
3052 (set_default_custom_servernames): Some minor memory management fixes.
3054 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3058 * src/modest-runtime.c: (init_i18n): Restored the translation
3059 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3060 are defined in config.h, and the translations are installed.
3062 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3063 is defined for translation.
3065 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3067 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3069 * src/maemo/easysetup/modest-easysetup-wizard.c:
3070 (modest_easysetup_wizard_dialog_init):
3071 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3072 Use realistic paths (though they should use $prefix generically) to the
3073 mcc_mapping and provider-data.keyfile files which might work when they
3074 are installed by the future version of the operator-wizard package,
3075 and then fallback to paths in our source code, with an explanatory
3078 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3082 * src/maemo/Makefile.am:
3083 * src/maemo/easysetup/: Added files from the previously-exernal
3084 osso-modest-easysetup.
3085 * src/maemo/modest-main-window-ui.h:
3086 * src/modest-ui-actions.c:
3087 * src/modest-ui-actions.h:
3088 Added modest_ui_actions_on_new_account() as a signal handler for the
3089 New Account menu item. It shows the easysetup wizard.
3090 * po/en_GB.po: Added additional needed logical IDs and translations.
3092 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
3093 Apparently ChangeLog is not used for some vague Nokia legal reasons.