1 2007-06-29 Murray Cumming <murrayc@murrayc.com
3 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
4 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
5 Debug output to give some more clue when a folder move is not allowed.
7 2007-06-28 Murray Cumming <murrayc@murrayc.com
9 * src/modest-tny-account.c: (on_modest_file_system_info),
10 (modest_tny_account_get_mmc_account_name):
11 Always call the callback, without checking whether the name has changed.
12 * src/widgets/modest-folder-view.c: (strings_are_equal),
13 (on_model_foreach_set_name), (on_get_mmc_account_name),
14 (text_cell_data): Compare the name here, and use the name from
15 the account rather than from the
16 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
17 if the name was changed after the account was added to the model.
18 That's a tinymail bug but not one that I want to fix now.
20 This finally fixes projects.maemo.org bug NB#59301.
22 2007-06-27 Armin Burgmeier <armin@openismus.com>
24 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
27 2007-06-27 Murray Cumming <murrayc@murrayc.com
29 * src/modest-tny-account.h:
30 * src/modest-tny-account.c:
31 Added modest_tny_account_get_mmc_account_name(), to set the memory
32 card name asynchronously for the given account and then notify.
33 (modest_tny_account_new_for_local_folders): Use this new function instead
34 of using hildon_file_system_info_async_new() directly.
36 * src/widgets/modest-folder-view.c: (text_cell_data):
37 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
38 gtk_tree_model_row_changed() when it is available.
40 This should fix projects.maemo.org bug NB#59301.
42 2007-06-27 Murray Cumming <murrayc@murrayc.com
44 * src/modest-mail-operation.c: (update_account_thread),
45 (get_msgs_full_thread): Fix typo failures in the revert
48 2007-06-27 Murray Cumming <murrayc@murrayc.com
50 * src/maemo/modest-maemo-global-settings-dialog.c:
51 (idle_select_default_focus):
52 * src/modest-mail-operation.c: (idle_notify_progress),
53 (idle_notify_progress_once), (set_last_updated_idle),
54 (update_account_thread), (get_msgs_full_thread):
55 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
56 * src/widgets/modest-header-view.c:
57 (idle_notify_headers_count_changed_destroy),
58 (idle_notify_headers_count_changed):
59 Reverted the additions of gdk_threads_enter/leave(), in case this
60 helps with a startup hang on the device.
62 2007-06-26 Armin Burgmeier <armin@openismus.com>
64 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
65 for supported secure authentication methods from server by
66 gtk_dialog_run(), saving CPU time and a potential race condition.
68 2007-06-26 Armin Burgmeier <armin@openismus.com>
70 * src/maemo/modest-maemo-utils.h:
71 * src/maemo/modest-maemo-utils.c: Added a
72 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
73 only error code to tell the calling code when the user canceled the
76 * src/maemo/modest-account-settings-dialog.h:
77 * src/maemo/modest-account-settings-dialog.c:
78 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
79 message if the retrieval of secure authentication methods was canceled
80 by the user. Perform the check before saving anything to configuration
81 to not end up with half-committed configuration changes, do not show
82 a "Saving to configuration failed" note when authentication methods
83 could not be retrieved.
85 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
88 2007-06-26 Murray Cumming <murrayc@murrayc.com>
90 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
91 Only return the first level of folders under accounts, because the
92 osso-global-search UI spec doesn't want the rest.
93 This fixed projects.maemo.org bug NB#61811.
95 2007-06-26 Murray Cumming <murrayc@murrayc.com>
97 * src/modest-tny-account-store.c:
98 * src/modest-tny-account-store.h:
99 Added modest_tny_account_is_memory_card_account().
100 * src/maemo/modest-main-window.c: (create_details_widget):
101 Show the same information items for the memory card as we show for the
102 local-folders, to fix projects.maemo.org bug NB#59307.
104 2007-06-26 Murray Cumming <murrayc@murrayc.com>
106 * src/modest-tny-account-store.c: (get_password):
107 Added some checks for NULL to maybe prevent crashes, though I think
108 it was Philip's last commit that actually prevented the crash here
109 when creating a first new account.
110 But the new account is still not usable (no messages are shown)
111 until a restart of the application.
113 2007-06-26 Murray Cumming <murrayc@murrayc.com>
115 * src/maemo/modest-maemo-global-settings-dialog.c:
116 (idle_select_default_focus):
117 * src/modest-mail-operation.c: (idle_notify_progress),
118 (idle_notify_progress_once), (idle_notify_update_account_queue),
119 (set_last_updated_idle), (update_account_thread),
120 (notify_get_msgs_full), (get_msgs_full_destroyer),
121 (get_msgs_full_thread):
122 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
123 * src/widgets/modest-header-view.c:
124 (idle_notify_headers_count_changed_destroy),
125 (idle_notify_headers_count_changed):
126 Use gdk_threads_enter() and gdk_threads_enter_leave() in
127 all idle handlers, because some other thread could be blocking
128 the GDK lock, so that it can do GUI stuff.
130 2007-06-26 Murray Cumming <murrayc@murrayc.com>
132 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
133 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
134 (on_idle_send_receive), (on_idle_open_default_inbox):
135 * src/maemo/modest-msg-edit-window.c:
136 (modest_msg_edit_window_attach_file_noninteractive):
137 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
138 to prevent a hang. I don't quite understand why these are necessary,
139 beause we should already be in the main loop. I guess something outside
140 of the main loop is taking the lock.
142 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
143 we are really using URIs, and use files that are more likely to exist.
145 2007-06-26 Murray Cumming <murrayc@murrayc.com>
147 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
148 necessary because configure.ac now defines different variables.
150 2007-06-26 Murray Cumming <murrayc@murrayc.com>
152 * libmodest-dbus-client/libmodest-dbus-client.c:
153 * libmodest-dbus-client/libmodest-dbus-client.h:
154 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
155 libmodest_dbus_client_compose_mail() is what things actually use.
157 * src/dbus_api/modest-dbus-api.h:
158 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
159 * tests/dbus_api/Makefile.am:
160 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
163 2007-06-26 Murray Cumming <murrayc@murrayc.com>
165 * src/modest-init.c: (modest_init_local_folders):
166 For memory-card (or other non local-folders) maildir accounts,
167 always create an Archive folder, so that there is somewhere to put
168 messages. This should be less confusing, because the user does not need
169 to guess that the need to create a folder.
171 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
173 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
174 Fixed icon size by using (50, 50) which is the same as defined by
177 2007-06-25 Armin Burgmeier <armin@openismus.com>
179 * src/widgets/modest-window-mgr.c:
181 * configure.ac: Correctly recognize hildon-notify presence and fixed
182 the build without it being installed.
184 2007-06-25 Murray Cumming <murrayc@murrayc.com>
186 * libmodest-dbus-client/libmodest-dbus-client.c:
187 (libmodest_dbus_client_search): Fix the build. Sorry.
188 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
189 (reply_forward_cb): Initialize variables to fix the build.
191 * src/modest-tny-account-store.c:
192 (modest_tny_account_store_get_tny_account_by): Fix the account URI
193 comparison (a silly typo) so that email search results can be opened
194 when there are more than one account.
196 2007-06-25 Murray Cumming <murrayc@murrayc.com>
198 * libmodest-dbus-client/libmodest-dbus-client.c:
199 (libmodest_dbus_client_search),
200 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
201 instead of 1 second, because the search gets folders and messages from
202 the server, which can take a long time. When it times out,
203 osso-global-search will report no results.
205 We need to specify whether we should search only cached information
206 (maybe with a user preference), and the osso-email-search-plugin
207 API should really be improved to allow that option, and to allow results
208 to be delivered asynchronously in batches.
210 2007-06-25 Murray Cumming <murrayc@murrayc.com>
212 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
213 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
214 GTK_ICON_SIZE_DIALOG is probably the wrong size.
216 2007-06-25 Murray Cumming <murrayc@murrayc.com>
218 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
219 that is an empty string. D-Bus seems to give us these instead of NULL.
221 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
223 * src/dbus_api/modest-dbus-callbacks.c:
224 * src/maemo/easysetup/modest-easysetup-wizard.h:
225 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
226 * src/maemo/modest-connection-specific-smtp-edit-window.c:
227 (modest_connection_specific_smtp_edit_window_init):
228 * src/maemo/modest-maemo-global-settings-dialog.c:
230 * src/maemo/modest-maemo-utils.c:
231 (modest_maemo_utils_setup_images_filechooser):
232 * src/maemo/modest-main-window.c: (create_details_widget):
233 * src/maemo/modest-msg-edit-window.c:
234 (modest_msg_edit_window_attach_file_noninteractive),
235 (modest_msg_edit_window_color_button_change),
236 (modest_msg_edit_window_set_zoom):
237 * src/modest-mail-operation.c: (update_account_thread):
238 * src/modest-tny-account-store.c:
239 * src/modest-tny-account.c:
240 * src/widgets/modest-global-settings-dialog.c:
241 * src/widgets/modest-window.h:
245 2007-06-25 Murray Cumming <murrayc@murrayc.com>
247 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
248 * src/modest-search.c: (modest_search_folder),
249 (modest_search_all_accounts): Actually search only in the specified folder,
250 doing a simple match on the folder ID.
251 * src/modest-search.h: Added a folder field to the ModestSearch struct,
252 and added some documentation.
254 2007-06-22 Armin Burgmeier <armin@openismus.com>
256 * src/maemo/modest-maemo-utils.h:
257 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
258 modest_maemo_utils_get_supported_secure_authentication_methods.
260 * src/maemo/easysetup/modest-easysetup-wizard.c:
261 * src/maemo/modest-account-settings-dialog.c: Show correct error if
262 one occured, not just "Server does not support secure authentication".
264 2007-06-22 Murray Cumming <murrayc@murrayc.com>
266 * src/modest-tny-account-store.c: (get_password):
267 Restored the call to tny_account_set_user() because Philip seems to have
268 stopped this from crashing (by not using the freed string). It still does
269 not work, but now we can test it.
271 2007-06-22 Murray Cumming <murrayc@murrayc.com>
273 * src/maemo/modest-msg-edit-window.c: (init_window):
274 Comment out use of an uninitialzed GtkScrolledWindow variable,
275 to fix the build and stop a crash. Yet again.
277 2007-06-22 Murray Cumming <murrayc@murrayc.com>
279 * src/modest-tny-account-store.c: (get_password):
280 Remove the call to tny_account_set_user() because this actually crashes.
281 As mentioned in the last commit, it is known to not work anyway.
283 2007-06-22 Murray Cumming <murrayc@murrayc.com>
285 * src/modest-tny-account-store.c: (get_password):
286 Use tny_account_set_username() to tell tinymail that the username might
287 have changed too. But tinymail ignores this: see projects.maemo.org
289 * src/modest-ui-actions.c:
290 (modest_ui_actions_on_password_requested): Remove the useless attempt to
291 reset the connection when changing the username, and improve the comments.
292 Save the changed username to gconf at least, so it is used when Modest is
295 2007-06-21 Murray Cumming <murrayc@murrayc.com>
297 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
298 Do not use a query, so that we get all folders, including for POP and
299 local-folders. They work as search criteria too.
300 This fixes projects.maemo.org bug NB#57740.
302 2007-06-21 Murray Cumming <murrayc@murrayc.com>
304 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
305 Comment out the use of hildon_notification_set_sound() because it is
306 not declared, to fix the build. Warnings are serious, people.
308 2007-06-21 Armin Burgmeier <armin@openismus.com>
310 * src/maemo/modest-maemo-utils.h:
311 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
312 modest_maemo_utils_get_supported_secure_authentication_methods()
313 to query authentication methods for a specific user. This should fix
314 projects.maemo.org bug NB#61369.
316 * src/maemo/easysetup/modest-easysetup-wizard.c:
317 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
320 2007-06-21 Murray Cumming <murrayc@murrayc.com>
322 * libmodest-dbus-client/libmodest-dbus-client.h:
323 * libmodest-dbus-client/libmodest-dbus-client.c:
324 (modest_dbus_message_iter_get_search_hit),
325 (libmodest_dbus_client_search):
326 Reorganised and commented this.
327 Removed modest_search_hit_free() from the public API because it
330 Added libmodest_dbus_client_get_folders() and
331 modest_folder_result_list_free().
333 * src/dbus_api/modest-dbus-api.h:
334 * src/dbus_api/modest-dbus-callbacks.c:
335 (modest_dbus_req_filter): Commented. Moved most code to
336 on_dbus_method_search() and added on_dbus_method_get_folders().
338 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
339 of the extra D-Bus handler.
341 * tests/dbus_api/Makefile.am:
342 * tests/dbus_api/test_get_folders.c: New test for
343 libmodest_dbus_client_get_folders(). This seems to return an empty list
344 at the moment. That could be the same error that causes the message list
345 to be empty sometimes.
346 This should help with projects.maemo.org bug NB#57740.
348 2007-06-21 Armin Burgmeier <armin@openismus.com>
350 * src/modest-mail-operation.c: Do not call
351 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
352 notify the operation's end after having set the status to CANCELED for
353 the operation queue to listen on. This fixes a deadlock when there
354 were mail operations in the queue during its finalization.
356 * src/modest-singletons.c: Reordered uninitialization of the account
357 manager to happen after the mail operation queue was uninitialized
358 because the mail operation's in the queue might still try to access
359 the account manager (see modest_mail_operation_notify_end()). This
360 fixes a potential crash when terminating the application.
362 2007-06-21 Murray Cumming <murrayc@murrayc.com>
364 * src/modest-search.c:
365 (search_mime_part_and_child_parts): Moved some code here so we
366 can search recursively in child folders.
367 (modest_search_folder): Search in the message as a mime part, instead
368 of just its child mime parts.
369 (read_chunk), (search_mime_part_ogs):
370 Check how many bytes were read, to prevent an endless loop.
371 Searching in message bodies now works. This finishes the fix for
372 projects.maemo.org bug NB#61007.
374 2007-06-20 Murray Cumming <murrayc@murrayc.com>
376 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
377 Add a g_warning when the item is not a folder.
379 * src/modest-ui-dimming-rules.c:
380 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
381 when selected item is not a folder (for instance, an account), because
382 the UI spec only talks about folders.
383 I am not sure what the UI spec wants, so this might not totally fix
384 projects.maemo.org bug NB#60794.
386 2007-06-20 Murray Cumming <murrayc@murrayc.com>
388 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
389 (load_from_file): Sort the list. The unsorted list would be more noticeable
390 in non-English locales.
392 * src/maemo/modest-msg-edit-window.c:
393 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
394 warning and fix the build.
396 * src/maemo/modest-progress-bar-widget.c:
397 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
398 avoid a g_warning, and probably to avoid a crash.
400 2007-06-20 Murray Cumming <murrayc@murrayc.com>
402 * src/modest-search.c: (modest_search_folder): Check for a GError
403 when calling tny_folder_get_headers(), to show that this is not the cause
406 2007-06-20 Murray Cumming <murrayc@murrayc.com>
408 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
409 Actually set the body query instead of the subject query.
411 * src/modest-search.c: (search_mime_part_ogs),
412 (search_mime_part_strcmp): Remove extra space from the text/* regex,
413 which would probably cause it to fail if we got this far.
415 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
416 to simplify the code.
417 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
418 be causing search-in-body to fail.
420 2007-06-20 Murray Cumming <murrayc@murrayc.com>
422 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
424 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
425 Better debug message when the folder cannot be found.
426 This should help with fixing projects.maemo.org bug #61287.
427 * src/modest-search.c: (add_hit): Do not leak the furl string.
429 2007-06-20 Murray Cumming <murrayc@murrayc.com>
431 * src/modest-ui-actions.c:
432 (modest_ui_actions_on_folder_selection_changed):
433 Do not special-case TNY_MERGE_FOLDER here, because
434 modest_tny_folder_get_account() already does that. This fixes
435 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
436 shown when the Outbox was selected).
438 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
440 * libmodest-dbus-client/libmodest-dbus-client.c:
441 (_dbus_iter_get_string_or_null): Initialize the string variable in
442 case this helps with Dirk's crash.
444 2007-06-19 Murray Cumming <murrayc@murrayc.com>
446 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
447 though it is not implemented yet (this function is maybe not even used),
448 to avoid breaking ABI in future.
449 * libmodest-dbus-client/libmodest-dbus-client.c:
450 (get_attachments_string): Moved some code into this generic function.
451 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
452 sends email. It is maybe not used.
453 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
454 (on_send_mail): Use attachments.
456 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
457 * src/maemo/modest-msg-edit-window.c:
458 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
459 a filename before using it, to fix projects.maemo.org bug NB#58233.
461 2007-06-19 Murray Cumming <murrayc@murrayc.com>
463 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
464 Initialize the continue_download variable to fix the build, and probably
465 to fix randome behaviour.
467 2007-06-18 Armin Burgmeier <armin@openismus.com>
469 * src/modest-tny-send-queue.h:
470 * src/modest-tny-send-queue.c: Keep track of the status of messages in
471 the queue so we can later show it in the UI. Replaced
472 modest_tny_send_queue_msg_is_being_sent() by
473 modest_tny_send_queue_get_msg_status().
475 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
477 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
478 gpointer. This probably was not harmful, but just to be sure.
480 2007-06-18 Murray Cumming <murrayc@murrayc.com>
482 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
483 Fix the build, but leave the function broken on Bora, because
484 hildon_uri_action_get_service() does not exist.
485 osso_uri_action_get_service() does not exist either, it seems.
487 2007-06-18 Murray Cumming <murrayc@murrayc.com>
489 * src/modest-tny-account.c:
490 (modest_tny_account_new_from_server_account):
491 Uncommented the url debug output again, because it is useful for
492 debugging, as I said in the comment.
494 2007-06-18 Murray Cumming <murrayc@murrayc.com>
496 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
498 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
499 for Mameo Bora, to fix the build.
501 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
504 Fixed build with hildon < 0.99
506 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
507 Check if the selected account is busy instead of checking all accounts
509 * src/modest-account-mgr-priv.h:
510 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
511 (modest_account_mgr_init), (compare_account_name),
512 (modest_account_mgr_set_account_busy),
513 (modest_account_mgr_account_is_busy):
514 * src/modest-account-mgr.h:
515 Added busy information to the account manager. It possible to
516 set an account to busy or not busy now.
518 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
519 (modest_mail_operation_update_account),
520 (modest_mail_operation_notify_end):
521 Set the account to busy/not busy depending on the operation state.
523 * src/widgets/modest-account-view.c:
524 (modest_account_view_finalize), (get_last_updated_string),
525 (update_account_view), (on_account_busy_changed), (init_view):
526 Show string "Refreshing..." if the account is currently busy.
528 All this fixes projects.maemo.org bug NB#59711
530 2007-06-14 Armin Burgmeier <armin@openismus.com>
532 * src/widgets/modest-attachments-view.h:
533 * src/widgets/modest-attachments-view.c: Added
534 modest_attachments_view_has_attachments() and fixed coordinate
535 transformation in get_att_view_at_coords(). This fixes attachment
538 * src/widgets/modest-msg-view.c: Make use of
539 modest_attachments_view_has_attachments() to decide whether to show
540 attachments in the header.
542 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
544 * src/maemo/modest-connection-specific-smtp-edit-window.c:
545 (on_change), (on_combo_security_changed),
546 (modest_connection_specific_smtp_edit_window_init),
547 (modest_connection_specific_smtp_edit_window_set_connection),
548 (modest_connection_specific_smtp_edit_window_is_dirty):
549 * src/maemo/modest-connection-specific-smtp-edit-window.h:
550 * src/maemo/modest-connection-specific-smtp-window.c:
553 Show an comfirmation dialog for the smpt-edit-window if there are
554 unsaved changes and the user hits cancel.
555 (projects.maemo.org bug NB#60479)
557 2007-06-14 Armin Burgmeier <armin@openismus.com>
559 * src/maemo/easysetup/modest-easysetup-wizard.c:
560 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
561 address" info in banner instead of node, and select all the text as
562 per UI spec. This fixes projects.maemo.org bug NB#60550.
564 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
566 reviewed by: <delete if not using a buddy>
568 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
569 * src/modest-ui-actions.c: (folder_refreshed_cb):
571 2007-06-14 Murray Cumming <murrayc@murrayc.com>
573 * src/widgets/modest-folder-view.c: (filter_row):
574 Explictly filter out the per-account outbox accounts. I don't know why
575 these only sometimes show up, but now they should never show up in the UI.
576 This should fix projects.maemo.org bug NB#60160.
578 2007-06-14 Murray Cumming <murrayc@murrayc.com>
580 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
581 when the toolbar does not exist yet.
582 * src/modest-widget-memory.c: (save_settings_header_view):
583 Added g_warnings() to help us to discover when we are trying to set
584 an empty columns list in gconf.
586 2007-06-14 Murray Cumming <murrayc@murrayc.com>
590 Added modest_init_get_default_header_view_column_ids().
592 * src/modest-widget-memory.c: (restore_settings_header_view):
593 Use the new function to get defaults, if the gconf key is empty,
594 instead of not creating any columns. This seems to fix the
595 empty right-hand pane problems.
597 * src/widgets/modest-header-view.h: Improved documentation.
599 2007-06-13 Murray Cumming <murrayc@murrayc.com>
601 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
602 Revert the use of the display name as the account name, because this
603 is generally wrong and would break the code that follows.
605 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
607 * src/maemo/easysetup/modest-easysetup-wizard.c:
608 (check_for_supported_auth_methods), (on_before_next),
611 More correct fix for projects.maemo.org bug NB# 58991
612 Do not longer accept AUTH_PASSWORD as secure method and choose
613 correct method when creating the account.
615 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
617 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
618 Fixed projects.maemo.org bug NB# 58991
620 2007-06-13 Murray Cumming <murrayc@murrayc.com>
622 * src/modest-init.c: (modest_init_init_core),
623 (modest_init_local_folders): Fixed compilation errors.
625 2007-06-13 Murray Cumming <murrayc@murrayc.com>
627 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
628 Remove unnecessary lib/include, though it is good in principle when needed.
630 * src/modest-init.c: (modest_init_one_local_folder),
631 (modest_init_local_folders):
632 * src/modest-init.h: Initialize the .modest library for memory cards,
633 instead of just doing nothing for them. This should allow us to create
634 folders there, fixing projects.maemo.org bug NB#59297.
636 2007-06-13 Murray Cumming <murrayc@murrayc.com>
638 * libmodest-dbus-client/libmodest-dbus-client.c:
639 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
640 (libmodest_dbus_client_compose_mail),
641 (libmodest_dbus_client_open_message),
642 (libmodest_dbus_client_send_and_receive),
643 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
645 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
646 (on_idle_open_message), (modest_dbus_req_handler),
647 (search_result_to_message), (modest_dbus_req_filter):
648 * src/modest-search.c: (add_hit), (modest_search_folder),
649 (modest_search_all_accounts): Improved debug messages.
651 * tests/dbus_api/test_open_message.c: (main): Improved comments.
653 * src/modest-tny-account-store.c:
654 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
657 2007-06-13 Murray Cumming <murrayc@murrayc.com>
660 2007-06-12 Murray Cumming <murrayc@murrayc.com>
662 * src/modest-tny-account-store.c: (get_server_accounts):
663 Call modest_tny_local_folders_account_add_merged_outbox_folders()
664 even when there are no accounts, so that the Outbox folder is always
665 visible. This fixes projects.maemo.org bug NB#60158.
667 2007-06-12 Murray Cumming <murrayc@murrayc.com>
669 * src/maemo/modest-main-window.c: (create_details_widget):
670 Use the mcen_va_never logical ID.
672 2007-06-12 Murray Cumming <murrayc@murrayc.com>
674 * src/dbus_api/modest-dbus-api.h:
675 * src/dbus_api/modest-dbus-callbacks.c:
676 (on_idle_open_default_inbox), (on_open_default_inbox),
677 (modest_dbus_req_handler):
678 Added a new OpenDefaultInbox method.
680 * libmodest-dbus-client/libmodest-dbus-client.h:
681 * libmodest-dbus-client/libmodest-dbus-client.c:
682 Added libmodest_dbus_client_open_default_inbox() to call the new
683 dbus method. This should be useful to projects.maemo.org bug NB#57214,
684 though it should maybe be used by a new osso-email-interface function.
686 * tests/dbus_api/Makefile.am:
687 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
690 2007-06-12 Murray Cumming <murrayc@murrayc.com>
692 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
693 NULL, so that the signals get all the keys. This should not actually
694 change any behaviour because we currently update everything when anything
697 2007-06-12 Murray Cumming <murrayc@murrayc.com>
699 * src/widgets/modest-folder-view.c: (text_cell_data),
700 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
701 (find_inbox_iter): If tinymail tells us that the folder is
702 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
703 This causes the inbox to be selected at startup, fixing part of
704 projects.maemo.org bug NB#56305.
706 * src/modest-ui-dimming-rules.c:
707 (modest_ui_dimming_rules_on_tools_smtp_servers):
708 * src/modest-ui-dimming-rules.h: Added a callback function to dim
709 the SMTP servers menu item.
710 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
711 that the SMTP Servers menu item is dimmed when there are no accounts,
712 as a future version of the UI spec will require. This fixes
713 projects.maemo.org bug NB#56305.
715 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
717 * src/maemo/modest-maemo-utils.c:
718 (modest_maemo_utils_get_supported_secure_authentication_methods):
719 Added label to dialog instead of unreadable title
721 * src/maemo/modest-main-window.c: (sync_accounts_cb),
722 (modest_main_window_new):
723 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
726 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
727 * src/modest-account-mgr.h:
728 Added method to avoid code duplication
730 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
731 (modest_ui_actions_on_send_receive):
732 Use modest_account_mgr_has_accounts
734 2007-06-11 Murray Cumming <murrayc@murrayc.com>
736 * src/maemo/easysetup/modest-presets.c:
737 (modest_presets_get_info_server_security): Do not report secure auth
739 * src/modest-protocol-info.c: Use the defines for the gconf key names
740 for secure authentication. This was not working because we were writing
741 Password and reading password, and the check was case sensitive.
742 With this, gmail now works for receiving and sending when created via
745 2007-06-11 Murray Cumming <murrayc@murrayc.com>
747 * src/maemo/easysetup/modest-presets.c:
748 (modest_presets_get_info_server_security): Correct the key name for
749 SecureSmtp, because it seems to be case-sensitive.
750 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
751 Do not try to get the 0th notebook page if there are 0 pages, to
754 2007-06-11 Murray Cumming <murrayc@murrayc.com>
756 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
757 Prevent use of the new notification feature for now, because it currently
758 shows one dialog for each new email, which is annoying.
760 2007-06-11 Murray Cumming <murrayc@murrayc.com>
762 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
763 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
764 when no country was selected, so that we show the global ones.
765 * src/maemo/easysetup/modest-presets.c:
766 (modest_presets_get_providers): Return only the global providers, not
767 all providers when mmc=0 was requested.
769 2007-06-11 Murray Cumming <murrayc@murrayc.com>
771 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
772 (easysetup_provider_combo_box_fill): Remove debug code that showed the
773 provider ID in the combo.
775 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
776 Do not show the page numbers, because it would be confusing when we add
777 the 2 extra pages for the custom setup, when the user chooses the "Other"
778 provider. This fixes projects.maemo.org bug NB#59028
780 * src/modest-init.c: (modest_init_init_core),
781 (modest_init_local_folders):
783 * src/modest-tny-account.c:
784 (modest_tny_account_new_for_local_folders): Do not create default folders
785 for the memory card. This should fix projects.maemo.org bug NB#59328.
787 2007-06-11 Murray Cumming <murrayc@murrayc.com>
789 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
790 Free the changed_conf_keys string items. They are already freed in the
791 idle handler if that runs first.
793 2007-06-11 Murray Cumming <murrayc@murrayc.com>
795 * src/modest-ui-actions.c:
796 (modest_ui_actions_on_password_requested): Check that the server name
797 is not NULL, because I just saw a password dialog with (null) as the
800 * src/modest-tny-folder.[h|c]: Added
801 modest_tny_folder_is_memory_card_folder().
802 * src/modest-ui-dimming-rules.c:
803 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
804 menu item for memory cards, as per the UI spec (section 7.4). This should
805 fix projects.maemo.org bug NB#59297.
807 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
809 * src/maemo/modest-main-window.c: (sync_accounts_cb):
810 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
811 is another problem with the code, see Murray's comment at line 772)
813 2007-06-08 Murray Cumming <murrayc@murrayc.com>
815 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
816 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
817 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
818 (load_from_file), (easysetup_country_combo_box_init),
819 (easysetup_country_combo_box_get_active_country_ids),
820 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
821 instead of just one ID, to avoid duplicate country names in the UI.
823 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
824 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
825 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
826 a single ID, avoiding duplicate providers.
827 * src/maemo/easysetup/modest-easysetup-wizard.c:
828 (on_combo_account_country): Adapt to use a list.
830 2007-06-08 Murray Cumming <murrayc@murrayc.com>
832 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
833 keys changed in the last X seconds.
835 * src/modest-account-mgr.h:
836 * src/modest-account-mgr.c: (on_timeout_notify_changes),
837 (on_key_change), (modest_account_mgr_class_init),
838 (modest_account_mgr_init), (modest_account_mgr_finalize):
839 As the keys are changed, save them in a GSList* and signal that GSList*
840 further every X seconds, to batch changes, to allow us to do just one
841 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
842 bug NB#56941 and other (UI-blocking) delays when changing account settings.
844 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
845 changed signal signature.
847 * src/modest-conf.c: (modest_conf_set_list),
848 (modest_conf_on_change): Reenable notification.
850 (modest_conf_maemo_fake_on_change): Comment out the hack that
851 notified immediately instead of asynchronously.
853 * src/widgets/modest-account-view.h:
854 * src/widgets/modest-account-view.c:
855 (update_account_view): Select the previously-selected account ID,
856 if possible. This fixes projects.maemo.org bug NB#56933.
858 (on_account_changed), (on_account_removed),
859 (modest_account_view_select_account):
861 Remove the block/unblock functions
862 because they were not useful.
864 * src/maemo/modest-account-view-window.c:
865 (on_delete_button_clicked), (on_edit_button_clicked),
866 (on_new_button_clicked): Remove the use of the non-working block/unblock.
868 2007-06-08 Murray Cumming <murrayc@murrayc.com>
870 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
871 Improve the error dialog to show Incorrect Account Settings, which seems
872 clearer, and say that the internal error message (to be removed from the
873 dialog later) is often misleading.
874 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
876 * src/modest-tny-account.c:
877 (modest_tny_account_new_from_server_account): Uncomment the printf of the
878 URL because this is so useful for debugging on the device.
880 * src/widgets/modest-serversecurity-combo-box.c:
881 (modest_serversecurity_combo_box_fill): Correct a logical ID.
883 2007-06-08 Murray Cumming <murrayc@murrayc.com>
885 * src/modest-mail-operation.c:
886 (modest_mail_operation_send_new_mail):
887 Added a comment about a nasty but apparently harmless message. Details
888 added to the wiki g_warnings() page.
890 2007-06-08 Murray Cumming <murrayc@murrayc.com>
892 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
893 (modest_tny_send_queue_class_init):
894 Do not use the priv struct because it is empty, to avoid g_warnings
895 about a non-existant priv struct.
897 * src/modest-tny-account-store.c:
898 (modest_tny_account_store_get_server_account),
899 (modest_tny_account_store_get_transport_account_for_open_connection
900 ): Do not try to get transport server accounts for local folders,
901 because they don't have any. This avoids a g_warning().
903 * src/maemo/modest-main-window.c:
904 (modest_main_window_notify_send_receive_initied),
905 (on_configuration_key_changed):
906 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
908 * src/modest-mail-operation.c:
909 (modest_mail_operation_update_account):
910 * src/modest-tny-account-store.h:
911 * src/modest-tny-account.c:
912 (modest_tny_account_get_special_folder),
913 (modest_tny_account_new_for_local_folders),
914 (modest_tny_account_new_for_per_account_local_outbox_folder):
915 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
916 * src/modest-tny-local-folders-account.c:
917 (add_account_folders_to_merged_folder):
918 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
919 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
920 (modest_ui_actions_on_send):
921 * src/widgets/modest-folder-view.c: (update_model):
922 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
923 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
924 modest_tny_account_store_get_tny_account_by_account() to
925 modest_tny_account_store_get_server_account() to make the code clearer.
927 2007-06-07 Marcus Bauer <marcusb@openismus.com>
929 * src/dbus_api/modest-dbus-api.h:
930 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
931 * src/maemo/modest-msg-edit-window.c:
932 (modest_msg_edit_window_attach_file_noninteractive):
933 added g_warning in case the file to be attached does not exist
934 * tests/dbus_api/test_compose_mail.c: (main):
935 removed obsolete comment, added generic files as test case
937 2007-06-07 Murray Cumming <murrayc@murrayc.com>
939 * src/modest-tny-account-store.c: (get_server_accounts):
940 Create the local folders account only once, not once for each outbox, and
941 not only when there are some outboxes.
943 2007-06-07 Murray Cumming <murrayc@murrayc.com>
945 * src/widgets/modest-folder-view.c: (update_model): Comment out some
946 code that is causing a crash at startup. Sergio says that he is fixing this.
948 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
950 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
951 * src/maemo/modest-account-settings-dialog.c:
952 (create_page_outgoing),
953 (modest_account_settings_dialog_set_account_name),
954 (save_configuration):
955 - Fixed handling of the "Use secure authentication" toggle to comply with
956 the ui specification. See also projects.maemo.org bug NB#58400
958 - Restore the Secure connection setting combo correctly when loading
961 * src/maemo/modest-maemo-utils.c:
962 (on_camel_account_get_supported_secure_authentication),
963 (modest_maemo_utils_get_supported_secure_authentication_methods):
964 Fixed a crasher if operation is canceled
966 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
967 (modest_protocol_info_auth_is_secure):
968 * src/modest-protocol-info.h:
970 Added two new methods to determine if a protocol/auth method is secure/encrypted in
971 the sense of the "Use secure authentication" toggle.
973 2007-06-07 Murray Cumming <murrayc@murrayc.com>
975 * src/modest-tny-account-store.h:
976 * src/modest-tny-account-store.c:
977 Added modest_tny_account_store_get_local_folders_account().
979 * src/modest-tny-folder.h:
980 * src/modest-tny-folder.c:
981 (modest_tny_folder_get_account):
982 Added this replacement for tny_folder_get_account() which returns
983 the local-folders account for TnyMergeFolders, to avoid the
984 warning about the unimplemented get_account_func() vfunc().
986 (modest_tny_folder_get_rules),
987 * src/modest-ui-actions.c:
988 (modest_ui_actions_on_folder_selection_changed):
989 * src/modest-mail-operation.c:
990 (modest_mail_operation_remove_folder),
991 (modest_mail_operation_xfer_folder),
992 (modest_mail_operation_rename_folder),
993 (modest_mail_operation_get_msg),
994 (modest_mail_operation_get_msgs_full),
995 (modest_mail_operation_remove_msg),
996 (modest_mail_operation_xfer_msgs),
997 (modest_mail_operation_refresh_folder):
998 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1000 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1002 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1003 (modest_server_account_set_security):
1004 * src/modest-defs.h: Add comments explaining that our
1005 UI spec means TLS when it says Normal, so these do not look like errors.
1007 * src/modest-tny-account.c:
1008 (modest_tny_account_new_from_server_account): Use the new tinymail
1009 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1010 for TLS. This should fix projects.maemo.org bug NB#58460.
1012 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1014 * src/maemo/easysetup/modest-easysetup-wizard.c:
1015 (create_account): Correct the position of the gconf sanity check warning.
1016 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1017 of using the g_idle_add() hack, because this does not seem to be necessary
1018 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1019 caused by something other than maemo's gconf.
1020 This fixes projects.maemo.org bug #59022.
1022 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1024 * src/modest-account-mgr-helpers.c:
1025 (modest_account_mgr_get_default_account): Do not check that the account
1026 exists if there is no default account (NULL), to fix a runtime warning.
1028 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1030 * src/widgets/modest-folder-view.c: (update_model):
1031 Do not unref the treemodel before we have finished with it.
1032 This prevents a valgrind warning and an occasional crash at startup.
1034 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1036 * libmodest-dbus-client/libmodest-dbus-client.h:
1037 added libmodest_dbus_client_compose_mail()
1038 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1040 added functions needed for SendAsMail() functionality
1041 * src/maemo/modest-msg-edit-window.c:
1042 (modest_msg_edit_window_attach_file_noninteractive):
1043 non interactively attaching files to message edit window
1044 * src/widgets/modest-msg-edit-window.h:
1045 * tests/dbus_api/Makefile.am:
1046 added test_compose_mail.c
1047 * tests/dbus_api/test_compose_mail.c: (main):
1049 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1051 * src/modest-account-view.c:
1052 Fixed bug projects.maemo.org bug NB#59307
1054 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1056 * src/maemo/easysetup/modest-easysetup-wizard.c:
1057 (get_serverport_incoming), (on_before_next), (create_account):
1058 * src/maemo/modest-account-settings-dialog.c:
1059 (modest_account_settings_dialog_set_account_name):
1060 * src/maemo/modest-maemo-utils.c:
1061 (on_camel_account_get_supported_secure_authentication_status),
1062 (on_camel_account_get_supported_secure_authentication),
1063 (on_secure_auth_cancel),
1064 (modest_maemo_utils_get_supported_secure_authentication_methods):
1066 Implemented security authentication for settings and easysetup.
1068 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1070 * src/maemo/modest-main-window.c: (create_details_widget):
1071 Show the total size for memory card accounts too, instead of showing
1072 the name again. Fixes bug projects.maemo.org bug NB#59307.
1074 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1077 * src/modest-tny-simple-folder-store.c:
1078 * src/modest-tny-simple-folder-store.h: Removed.
1080 * src/modest-tny-local-folders-account.h
1081 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1082 for the local-folders maildir, with an extra TnyMergedFolder containing
1083 the folders of the per-account outbox store accounts.
1084 * src/modest-tny-account-store.c: (get_server_accounts):
1085 Add the outboxes to the special local folders account after creating it.
1087 * src/modest-tny-account.c:
1088 (modest_tny_account_new_for_local_folders): Create the derived
1089 account when creating the main local-folders account.
1091 * src/maemo/modest-main-window.c: (create_details_widget),
1092 (modest_main_window_set_contents_style):
1093 Adapted to the use of the derived account instead of the folder store.
1095 * src/modest-ui-actions.c:
1096 (modest_ui_actions_on_folder_selection_changed):
1097 * src/modest-ui-dimming-rules.c:
1098 (modest_ui_dimming_rules_on_new_folder):
1099 * src/widgets/modest-folder-view.c: (text_cell_data),
1100 (icon_cell_data), (filter_row), (update_model),
1101 (get_cmp_rows_type_pos):
1104 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1105 Do not get the priv struct, because no priv struct has been set,
1106 to avoid a runtime warning.
1108 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1109 #ifelse with #else, to fix a warning, to fix the build.
1112 2007-06-05 Christian Kellner <ckellner@openismus.com>
1114 * libmodest-dbus-client/libmodest-dbus-client.c:
1115 Fix small typo in doc (why do you always see them
1116 AFTER committing stuff?)
1119 2007-06-05 Christian Kellner <ckellner@openismus.com>
1121 * libmodest-dbus-client/libmodest-dbus-client.c:
1122 (libmodest_dbus_client_search):
1123 Initialize hit list with NULL. Also set folder list
1124 to "" if NULL was supplied.
1127 2007-06-03 Christian Kellner <ckellner@openismus.com>
1129 * libmodest-dbus-client/libmodest-dbus-client.c:
1130 (modest_search_hit_list_free):
1131 Make it save to call it with NULL.
1133 * src/dbus_api/modest-dbus-callbacks.c:
1134 * src/modest-search.c:
1135 Return full ModestSearchHits as the search result list not TnyHeader
1136 since can't be around withouth the correspoding TnyFolder.
1138 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1140 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1141 Added currently commented code to check for secure auth
1143 * src/maemo/modest-account-settings-dialog.c: (on_response),
1144 (save_configuration), (show_ok):
1145 Fixed projects.maemo.org bugs NB #59248 and #59251
1147 * src/maemo/modest-maemo-utils.c:
1148 (on_camel_account_get_supported_secure_authentication_status),
1149 (on_camel_account_get_supported_secure_authentication),
1150 (modest_maemo_utils_get_supported_secure_authentication_methods):
1151 * src/maemo/modest-maemo-utils.h:
1152 Moved get_supported_secure_authentication() method here to be able
1153 to use it from easysetup wizard.
1155 * src/modest-pair.c: (on_pair_compare_as_string):
1156 Should compare string with first part of pair and not
1157 strcmp pairs which will crash.
1159 * src/modest-protocol-info.c:
1160 (modest_protocol_info_protocol_is_store):
1161 * src/modest-protocol-info.h:
1162 Added modest_protocol_info_get_auth_protocol_name()
1164 2007-06-03 Armin Burgmeier <armin@openismus.com>
1166 * src/modest-mail-operation.c:
1167 (modest_mail_operation_get_msgs_full): Set priv->account also when
1168 only retrieving a single message. This avoids a crash when canceling
1171 (modest_mail_operation_notify_end): Do not explicitely remove the
1172 operation from the queue but only emit the progress_changed signal.
1173 The queue itself listens to that signal to remove the operation when
1174 it is finished. This reduces coupling and removes a potential deadlock
1175 when modest_mail_operation_notify_end() is called from the queue
1176 itself. If that is a problem performance-wise, I would suggest to
1177 implement a status-changed signal or something.
1179 * src/modest-mail-operation-queue.c: Make sure to never call a
1180 function from another file while the queue is locked. This (hopefully)
1181 fixes another deadlock when exiting the application while retrieving
1184 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1186 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1187 Fixed build if libogs is not available
1189 2007-06-03 Christian Kellner <ckellner@openismus.com>
1191 * libmodest-dbus-client/libmodest-dbus-client.h:
1192 * libmodest-dbus-client/libmodest-dbus-client.c:
1193 (libmodest_dbus_client_delete_message):
1194 Implement deletion of messages (Client side).
1196 (modest_search_hit_free),
1197 (modest_search_hit_list_free):
1198 Utility functions to free the result hits.
1200 * src/dbus_api/modest-dbus-api.h:
1201 * src/dbus_api/modest-dbus-callbacks.c:
1202 (on_delete_message),
1203 (modest_dbus_req_handler):
1204 Implement deletion of messages (Server side).
1206 * tests/dbus_api/test_search.c: (main):
1209 * tests/dbus_api/Makefile.am:
1210 * tests/dbus_api/test_delete_message:
1211 Add little test for the message deletion logic
1213 2007-06-03 Armin Burgmeier <armin@openismus.com>
1215 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1216 when the operation queue was not empty. projects.maemo.org bug
1219 2007-06-03 Armin Burgmeier <armin@openismus.com>
1221 * src/widgets/modest-account-view.c
1222 (on_account_default_toggled): Toggle default account column
1223 explicitely instead of waiting for gconf notification (which is
1224 currently ignored). This should fix projects.maemo.org bug NB#56910
1225 for now. It should probably be removed when gconf notifications are
1228 2007-06-03 Christian Kellner <ckellner@openismus.com>
1230 * libmodest-dbus-client/libmodest-dbus-client.c:
1231 Removed debugging spew.
1233 * src/dbus_api/modest-dbus-callbacks.c:
1234 Added debugging info.
1236 * src/modest-search.c:
1237 (modest_search_all_accounts):
1238 Use tny_account_store_get_accounts () on the account store
1239 to get all accounts which is the way to get all accounts.
1241 * tests/dbus_api/test_search.c: (main):
1242 Make it possible to supply the search term on the command line.
1244 2007-06-03 Christian Kellner <ckellner@openismus.com>
1246 * libmodest-dbus-client/libmodest-dbus-client.c:
1247 * libmodest-dbus-client/libmodest-dbus-client.h:
1248 Implement searching for mesages over raw dbus. (Client side)
1250 * src/dbus_api/Makefile.am:
1251 * src/dbus_api/modest-dbus-api.h:
1252 * src/dbus_api/modest-dbus-callbacks.c:
1253 * src/dbus_api/modest-dbus-callbacks.h:
1254 Search framework (Server side). Also implement on_idle_open_message().
1256 * src/maemo/modest-platform.c: (modest_platform_init):
1257 Prepare for raw dbus/osso rpc interaction.
1259 * src/modest-search.h:
1260 Changed minsize from unspecific guint to guint32.
1262 * src/modest-search.c:
1264 Added strange hack which magically made tnymail work.
1266 (modest_search_folder),
1267 (modest_search_account),
1268 (modest_search_all_accounts):
1269 Implement helper functions to search all accounts, specific account
1272 * tests/dbus_api/Makefile.am:
1273 * tests/dbus_api/test_open_message.c:
1274 Read url to open from commandline.
1276 * tests/dbus_api/test_search.c:
1277 Implement small test for dbus search stuff
1279 2007-06-02 Armin Burgmeier <armin@openismus.com>
1281 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1282 include account type and account title. This fixes projects.maemo.org
1285 * src/maemo/modest-account-view-window.c: Set a title for the window.
1287 2007-06-02 Armin Burgmeier <armin@openismus.com>
1289 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1290 incoming and outgoing server name based on email address and server
1291 types as long as the names have not been edited manually. This fixes
1292 projects.maemo.org bug NB#58671.
1294 2007-06-02 Armin Burgmeier <armin@openismus.com>
1296 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1297 server type cannot be changed in future to the incoming details page
1298 when creating an account. This fixes projects.maemo.org bug NB#59029.
1300 2007-06-02 Armin Burgmeier <armin@openismus.com>
1302 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1303 and assigned max width chars so that they wrap instead of being
1304 truncated. Fixes projects.maemo.org bug NB#56126.
1306 2007-06-02 Armin Burgmeier <armin@openismus.com>
1308 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1309 introductory note to the connection specific smtp servers dialog, as
1310 section 8.12 of the email UI specification requires. This fixes
1311 projects.maemo.org bug NB#59212.
1313 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1315 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1316 Check for running mail operations, and offer to cancel them, as per the UI
1317 spec. This fixes projects.maemo.org bug NB#59041 .
1318 However, I suspect that tinymail may still use the network connection
1319 in ways that we cannot detect or cancel. But it should at least adapt to
1320 changes fairly well.
1322 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1324 * src/modest-tny-account-store.c: (recreate_all_accounts),
1325 (get_cached_accounts), (get_server_accounts): Do more sensible
1326 ref-counting of the temporarily-cached outbox accounts list. This seems
1327 to fix a crash when entering the password when the password was wrong.
1329 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1331 * src/gnome/modest-main-window.c: (connect_signals):
1332 * src/modest-tny-account-store.c: (get_password),
1333 (modest_tny_account_store_alert): Added comments and clues and
1334 commented-out code about how we currently fail to deal with connection
1335 errors and wrong passwords, and how we should.
1337 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1339 * src/widgets/modest-retrieve-combo-box.c:
1340 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1341 This fixes projects.maemo.org bug NB#58472 .
1343 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1345 * src/maemo/easysetup/modest-easysetup-wizard.c:
1346 (create_page_complete_easysetup):
1347 (create_page_complete_custom): Correct the last commit,
1348 putting the correct sentences in the correct pages.
1350 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1352 * src/maemo/easysetup/modest-easysetup-wizard.c:
1353 (create_page_complete_custom): Show the second sentence of text
1354 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1357 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1359 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1360 Set the leave-on-server conf key by default. This fixes
1361 projects.maemo.org bug NB#59258 .
1363 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1365 * src/maemo/modest-account-view-window.c:
1366 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1367 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1370 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1372 * src/maemo/easysetup/modest-easysetup-wizard.c:
1373 (create_caption_new_with_asterisk):
1374 * src/maemo/modest-account-settings-dialog.c:
1375 (create_caption_new_with_asterisk):
1376 Uncomment the code to add the asterisk, because they are no longer in the
1377 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1378 (update_incoming_server_title): Add an asterisk here too.
1380 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1382 * src/maemo/modest-maemo-global-settings-dialog.c:
1383 (current_connection): Check that we are even connected before trying to
1384 get the current connection name, to prevent a warning.
1386 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1387 Change the comments because tny_maemo_conic_device_connect() is now meant to
1389 * src/modest-mail-operation.c:
1390 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1391 make sure we have a connection and fail if we can't connect.
1393 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1395 * src/maemo/modest-main-window.c:
1396 (on_account_store_connecting_finished): Do not try to get the
1397 connection ID if we are not really connected. I am surprised that
1398 this signal handler is called when we are not connected.
1400 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1402 * src/modest-error.h:
1403 * src/modest-ui-actions.c:
1404 (modest_ui_actions_get_msgs_full_error_handler):
1405 Renamed an enum, added comments, added an enum
1406 for retrieve-limit errors.
1408 * src/modest-mail-operation.c: (foreach_add_item),
1409 (internal_folder_observer_update), (update_account_thread),
1410 (modest_mail_operation_get_msgs_full):
1411 (modest_mail_operation_update_account),
1412 Added comments about how this works, and some code that should
1413 (but does not) check the retrieve-limit. See the TODO comment.
1415 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1417 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1418 Initialize help_id to fix the build. Warnings are good.
1420 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1422 * src/widgets/modest-hbox-cell-renderer.c:
1423 (modest_hbox_cell_renderer_append):
1424 * src/widgets/modest-vbox-cell-renderer.c:
1425 (modest_vbox_cell_renderer_append):
1426 Fix the last commit by doing an extra ref.
1428 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1430 * src/widgets/modest-hbox-cell-renderer.c:
1431 (modest_hbox_cell_renderer_append):
1432 * src/widgets/modest-vbox-cell-renderer.c:
1433 (modest_vbox_cell_renderer_append):
1434 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1435 to fix the build with Maemo Bora.
1436 However, there seems to be a remaining crash, probably due to reference
1439 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1441 * src/modest-tny-account.c:
1442 (modest_tny_account_new_for_local_folders):
1443 Use hildon_file_system_info_async_new() to get a better name for
1444 the memory card account, setting it as the account name.
1445 The timing seems to work, but this is probably
1446 not the best place to do this. See the TODO comment.
1447 * src/maemo/modest-main-window.c: (create_details_widget):
1448 * src/widgets/modest-folder-view.c: (text_cell_data):
1449 Use the tny account name instead of hardcoding a name.
1451 2007-05-30 Christian Kellner <ckellner@openismus.com>
1453 * src/modest-search.c: (modest_search):
1454 Correctly set part_search_func even if we have already parsed
1455 the query and thus a valid OgsTextSearcher object.
1457 2007-05-30 Christian Kellner <ckellner@openismus.com>
1460 Search and check for libogs.
1463 Incooparte the ogs build env.
1465 * src/modest-mime-part-search-stream.c:
1466 * src/modest-mime-part-search-stream.h:
1467 Removed since we do the real searching now in modest-search.c.
1469 * src/modest-search.c:
1470 * src/modest-search.h:
1471 Implement support for ogs. We use that if available and requested
1472 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1473 should now handle the corner case when the search term is spread
1474 across multiple reads.
1475 Also the logic in modest_search () was corrected to search all
1476 requested fields until one is found.
1478 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1480 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1482 * src/modest-init.h:
1483 * src/modest-init.c: Made modest_init_local_folders() take a
1484 path and be public so we can iniitialize maildir folders on
1487 * src/modest-local-folder-info.h:
1488 * src/modest-local-folder-info.c:
1489 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1491 * src/modest-tny-account.c:
1492 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1493 still means the standard local-folders path on the local volume.
1495 * src/modest-tny-account-store.c:
1496 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1497 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1498 all accounts when that happens.
1499 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1500 this too, so it shows up in the treeview.
1502 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1504 * src/maemo/modest-maemo-global-settings-dialog.c:
1505 (current_connection):
1506 * src/widgets/modest-global-settings-dialog.c:
1507 (current_connection_default):
1508 Use the enum values instead of 0, 1 and -1,
1509 to make the code clearer.
1511 * src/modest-account-mgr-helpers.c:
1512 (modest_account_mgr_get_connection_specific_smtp): Make this code
1515 * src/modest-runtime.h:
1516 * src/modest-runtime.c:
1517 Added modest_runtime_remove_all_send_queues().
1518 * src/maemo/modest-main-window.c:
1519 (on_account_store_connecting_finished): Recreate the send queues,
1520 using the appropriate transport accounts for this new connection.
1521 Some futher adapting might be needed if the old send queues are not
1522 automatically stopped at this point.
1524 * src/modest-tny-account-store.c: (get_server_accounts):
1525 Create the connection-specific transport accounts, so that they can
1526 be found later by their ID.
1528 * src/modest-tny-account.h:
1529 * src/modest-tny-account.c:
1530 Added modest_tny_account_new_from_server_account_name().
1531 modest_tny_account_new_from_server_account(): Do not create the
1532 send queues here, because they will be
1533 recreated anyway when the connection changes for the first time.
1535 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1537 * src/modest-local-folder-info.h:
1538 * src/modest-local-folder-info.c:
1539 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1540 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1541 tbox_folder): Take a modest account name instead of a server TnyAccount,
1542 so we can have per-modest-account rather than per-transport-account
1544 We must make sure that we change or recreate the exisitng send queues
1545 when the connection changes for connection-specific transport accounts.
1547 * src/modest-tny-account-store.c:
1548 (create_per_account_local_outbox_folders): Create outboxed per modest
1549 account, not per transport account.
1551 * src/modest-tny-account.h:
1552 * src/modest-tny-account.c:
1553 (modest_tny_account_get_special_folder): For outboxes, get the
1554 parent modest account name. The account is ignored for other folders.
1555 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1556 modest account name rather than a server TnyAccount.
1558 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1560 * src/modest-tny-account.c:
1561 (modest_tny_account_new_from_server_account):
1562 Call modest_runtime_get_send_queue() immediately after creating transport
1563 accounts, so that they start trying to send email from the outbox as soon
1564 as possible at startup. This is probably what we want.
1566 * src/modest-mail-operation.c: (update_account_thread):
1567 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1568 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1569 * src/modest-tny-send-queue.h:
1570 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1571 (modest_ui_actions_on_send):
1572 Added comments about how sending works, though it needs some more work.
1574 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1576 * src/modest-tny-account.c:
1577 (modest_tny_account_get_special_folder): Add TODO because this fails when
1578 the network is busy.
1579 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1580 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1581 Do not try to show this window when there is no active account. The UI
1582 specs does not tell us what to do in this case.
1584 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1588 * src/maemo/Makefile.am:
1589 * src/widgets/Makefile.am: Some dist fixes.
1591 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1593 * src/maemo/modest-connection-specific-smtp-window.c:
1594 (on_button_edit): Make the code clearer, to prevent a double free.
1596 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1598 * src/maemo/modest-account-settings-dialog.c:
1599 (modest_account_settings_dialog_set_account_name),
1600 Check the connection-specific smtp servers checkbox if there are any.
1602 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1603 (modest_connection_specific_smtp_edit_window_init):
1604 Start with a suitable port number.
1606 * src/modest-account-mgr-helpers.h:
1607 * src/modest-account-mgr-helpers.c: Added
1608 modest_account_mgr_get_has_connection_specific_smtp().
1610 (modest_account_mgr_set_connection_specific_smtp),
1611 (modest_account_mgr_remove_connection_specific_smtp),
1612 (modest_account_mgr_get_has_connection_specific_smtp),
1613 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1614 connection-specific smtp server accounts in the account, rather than
1615 the server account conf dir.
1617 This fixes bug projects.maemo.org bug NB#58263 .
1619 * src/modest-tny-account-store.c:
1620 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1621 if there are no server accounts yet, to prevent an infinite loop when there
1622 are no accounts. Document that one must be called before the other.
1624 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1626 * src/modest-account-mgr-helpers.c:
1627 (modest_account_mgr_get_default_account): Make sure that at least
1628 one account is always the default, if there are any enabled accounts.
1629 This is just a sanity check that shouldn't be necessary.
1631 * src/modest-account-mgr-priv.c:
1632 (_modest_account_mgr_account_from_key): Unescape the conf key to
1633 get the real account name. For instance, this is an issue if a space
1634 was in the account name, which can happen because the account name
1635 is generated from the display name.
1636 (_modest_account_mgr_get_account_keyname): Always escape the
1638 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1639 Unescape the conf keys to get the real account names.
1641 For instance, previously the is-default radio button in the accounts
1642 list was not checked for any accounts at first. This fixes that,
1643 and might fix several similar bugs.
1645 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1647 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1648 Removed some debug printfs.
1650 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1652 Modest on-disk outbox directories are now here, for instance:
1653 $HOME/.modest/outboxes/<account-id-1>/outbox
1654 $HOME/.modest/outboxes/<account-id-2>/outbox
1656 $HOME/.modest/local-folders/outbox
1657 so we can have a separate outbox for each account.
1658 But they are shown as one outbox in the GtkTreeView, by using a
1659 TnyMergeFolder in a ModestTnySimpleFolderStore.
1662 * src/modest-tny-simple-folder-store.c:
1663 * src/modest-tny-simple-folder-store.h:
1664 Added ModestTnySimpleFolderStore, used to contain folders from
1665 other folder stores, such as other accounts.
1667 * src/modest-tny-outbox-account.h:
1668 * src/modest-tny-outbox-account.c:
1669 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1670 used for the per-account local outbox folders.
1672 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1673 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1674 only use this (internally) now for the non-outbox local folders.
1676 * src/modest-init.h:
1677 * src/modest-init.c: Added modest_init_one_local_folder(), for
1678 setting up the directory structure for each local folder.
1680 * src/modest-local-folder-info.c:
1681 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1682 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1684 * src/modest-local-folder-info.h:
1685 * src/modest-tny-account-store.c: (on_account_removed),
1686 (on_account_changed), (create_per_account_local_outbox_folders),
1687 (get_server_accounts), (modest_tny_account_store_get_accounts),
1688 (modest_tny_account_store_get_tny_account_by_account),
1689 (modest_tny_folder_store_is_virtual_local_folders):
1691 * src/modest-tny-account.h:
1692 * src/modest-tny-account.c:
1693 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1694 to create an on-disk per-account local outbox folder for each
1696 (create_per_account_local_outbox_folders): Create a local outbox folder
1697 for each transport account.
1698 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1699 for all local folders.
1701 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1702 instead of using g_object_get/set() directly. It is clearer.
1704 (modest_tny_folder_store_get_message_count),
1705 (modest_tny_folder_store_get_local_size
1706 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1707 because we now use these with non-acount folder stores.
1709 (modest_tny_account_get_special_folder),
1710 (modest_tny_account_new_from_server_account),
1711 (modest_tny_account_new_from_account):
1712 (recurse_folders): Adjust to the new outbox system.
1714 * src/modest-tny-folder.h:
1715 * src/modest-tny-folder.c:
1716 (modest_tny_folder_is_local_folder),
1717 (modest_tny_folder_get_local_folder_type),
1718 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1720 * src/widgets/modest-main-window.h:
1721 * src/maemo/modest-main-window.c: (create_details_widget),
1722 (modest_main_window_set_contents_style): Show details for any folder store,
1725 (modest_tny_folder_get_rules):
1726 Remove the const. C does not support constness enough for this.
1728 * src/modest-ui-actions.c:
1729 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1730 make all outboxes appear as one, in the usual local-folders tree node.
1732 (set_active_account_from_tny_account),
1733 (modest_ui_actions_on_folder_selection_changed):
1734 * src/widgets/modest-folder-view.c: (text_cell_data),
1735 (icon_cell_data), (filter_row),
1736 (add_account_folders_to_merged_folder),
1737 (add_account_folders_to_simple_folder_store), (),
1738 (get_cmp_rows_type_pos), (cmp_rows),
1739 (modest_folder_view_set_account_id_of_visible_server_account):
1740 Adjust to the new outbox system, using generic folder stores and folders
1741 in the GtkTreeModel.
1743 2007-05-23 Christian Kellner <ckellner@openismus.com>
1745 * src/modest-mail-operation.c:
1746 (modest_mail_operation_update_account):
1747 Use info->max_size instead of unintialized local var [small
1748 build fix]. (Added TODO to review that change since I don't
1751 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1753 * libmodest-dbus-client/libmodest-dbus-client.c:
1754 (libmodest_dbus_client_compose_mail): function added
1755 * src/dbus_api/modest-dbus-api.h:
1756 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1757 (on_compose_mail): Implementation of the SendAsMail functionality
1759 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1761 * src/modest-account-mgr.c:
1762 (modest_account_mgr_add_server_account): Set the secure-connection
1763 conf key for transport accounts as well as store accounts. I don't know
1764 why the if was there. For instance, this makes sure that we use SSL
1765 for the gmail preset from the easysetup wizard.
1767 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1769 * src/gnome/modest-main-window.c:
1770 (on_account_store_connecting_finished), (connect_signals):
1771 * src/maemo/modest-main-window.c:
1772 (on_account_store_connecting_finished), (connect_signals),
1773 (modest_main_window_new):
1774 Handle TnyAccountStore::connecting-finished instead of
1775 TnyDevice::connection-changed, because we cannot actually perform
1776 operations on accounts until TnyAccountStore has itself responded to
1777 the TnyDevice::connection-changed signal. This prevents a GError from
1779 Do not try to update at startup, because we (at least on scratchbox)
1780 already do an update at startup when the device goes online.
1781 This prevents a GError from tinymail.
1782 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1783 Added TODO about stopping simultaneous operations.
1785 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1787 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1788 * src/modest-mail-operation-queue.c:
1789 (modest_mail_operation_queue_remove):
1790 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1791 about where they happened.
1793 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1795 * src/modest-ui-actions.c:
1796 (modest_ui_actions_on_password_requested): Make sure that the remember
1797 output parameter is always TRUE.
1799 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1801 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1802 Show a OK/Cancel dialog if the error is a question, though we still do not
1803 know anything more about what we are asking the user.
1804 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1805 Fix an uninitialized variable (helper). This is a logic error, however.
1807 2007-05-21 Christian Kellner <ckellner@openismus.com>
1809 * src/modest-search.h:
1810 Correct bit shifting in the ModestSearchFlags enum.
1812 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1814 * src/modest-tny-account.c:
1815 (modest_tny_account_new_from_server_account): Do not use the lsub and
1816 check-all hard-coded IMAP options when using POP.
1818 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1820 * src/modest-tny-account.c:
1821 (modest_tny_account_new_from_server_account):
1822 Use NULL for the secure-auth method for POP when Password auth has been
1823 specified by the user, as we already do for IMAP. "auth=Login" causes
1824 an error from camel or the server.
1826 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1828 * src/maemo/modest-account-settings-dialog.c:
1829 (create_page_account_details),
1830 (modest_account_settings_dialog_set_account_name):
1831 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1832 for the leave-on-server checkbox, rathr than just the checkbox, when
1833 the protocol is not POP.
1835 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1837 * src/widgets/modest-account-view.c:
1838 * src/widgets/modest-account-view.h:
1839 Added modest_account_view_select_account() which will be useful later
1840 to asynchronously re-select the edited account.
1842 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1844 * src/maemo/modest-account-settings-dialog.c:
1845 (modest_account_settings_dialog_set_account_name):
1846 Automatically choose the port numbers based on the secure authentication
1847 methods, if they have not been chosen before.
1848 This fixes projects.maemo.org bug NB#56273 .
1850 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1852 * src/maemo/modest-main-window-ui.h:
1853 * src/modest-ui-actions.c:
1854 * src/modest-ui-actions.h:
1855 Connect the Tools/SMTP Servers menu item to
1856 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1857 SMTP servers dialog, as in the UI specification and saves changes when it
1858 is closed. This fixed projects.maemo.org bug NB#56305 .
1860 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1862 * src/maemo/modest-connection-specific-smtp-window.c:
1863 (modest_connection_specific_smtp_window_init):
1864 Use gtk_window_set_default_size() to make this window big enough, so
1865 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1867 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1869 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1870 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1871 (modest_connection_specific_smtp_edit_window_init),
1872 Do not try to connect to a combobox signal before the combobox exists.
1873 This fixes the cras in projects.maemo.org bug NB#56288 .
1874 (modest_connection_specific_smtp_edit_window_get_settings):
1875 Remove the server_account_name parameter which was being checked for NULL
1876 though it was not used.
1878 * src/maemo/modest-connection-specific-smtp-window.c:
1879 (modest_connection_specific_smtp_window_fill_with_connections),
1880 (on_button_edit), (modest_connection_specific_smtp_window_init):
1881 Correct the number of treemodel columns to prevent a warning.
1882 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1883 libconic does not work.
1885 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1887 * src/modest-tny-account.c:
1888 (modest_tny_account_new_from_server_account):
1889 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1890 SMTP when "None" was chosen by the user. However, with my SMTP server that
1891 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1894 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1896 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1897 to explain the memory management issue with the ID in the ModestPair.
1899 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1900 (add_sending_page), (modest_account_assistant_finalize):
1901 * src/gnome/modest-gnome-global-settings-dialog.c:
1902 (create_updating_page), (create_composing_page):
1903 * src/gnome/modest-msg-edit-window.c: (get_transports),
1904 (init_window), (modest_msg_edit_window_finalize),
1905 (modest_msg_edit_window_get_msg_data):
1906 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1907 * src/gnome/modest-transport-widget.c:
1908 (modest_transport_widget_finalize), (smtp_configuration):
1909 * src/maemo/modest-maemo-global-settings-dialog.c:
1910 (create_updating_page), (create_composing_page):
1911 * src/maemo/modest-msg-edit-window.c: (get_transports),
1912 (init_window), (modest_msg_edit_window_finalize),
1913 (modest_msg_edit_window_get_msg_data),
1914 (modest_msg_edit_window_free_msg_data):
1915 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1916 (modest_store_widget_finalize):
1917 * src/maemo/modest-transport-widget.c:
1918 (modest_transport_widget_finalize), (smtp_configuration):
1919 * src/modest-main.c: (send_mail):
1920 * src/widgets/modest-combo-box.h:
1921 * src/widgets/modest-global-settings-dialog-priv.h:
1922 * src/widgets/modest-global-settings-dialog.c:
1923 (modest_global_settings_dialog_finalize):
1924 * src/widgets/modest-msg-edit-window.h:
1925 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1926 as long as the combo box, to prevent use of freed memory for the ID.
1928 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1930 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1931 get_accounts(), to make this clearer. Do not check for the enabled gconf
1932 key, because we do not use this for server accounts (at least, not yet).
1933 This allows us to send email again.
1935 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1937 * src/maemo/modest-platform.c:
1938 (on_modest_conf_update_interval_changed), (modest_platform_init):
1939 Only respond to this particular key change. All these strcmp()s cannot be
1942 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1944 * src/maemo/modest-maemo-global-settings-dialog.c:
1945 (current_connection): Prevent a crash in scratchbox when
1946 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1947 * src/maemo/modest-platform.c:
1948 (on_modest_conf_update_interval_changed), (modest_platform_init):
1949 Get the update interval from gconf and reset it when the gconf key changes.
1951 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1953 * src/modest-protocol-info.c:
1954 * src/modest-protocol-info.h: Adde enum-specific get functions,
1955 instead of using a ModestProtocolType enum parameter.
1957 * src/gnome/modest-account-assistant.c:
1958 * src/gnome/modest-store-widget.c:
1959 * src/gnome/modest-store-widget.h:
1960 * src/gnome/modest-transport-widget.c:
1961 * src/gnome/modest-transport-widget.h:
1962 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1963 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1964 * src/maemo/easysetup/modest-easysetup-wizard.c:
1965 * src/maemo/modest-account-settings-dialog.c:
1966 * src/maemo/modest-account-settings-dialog.h:
1967 * src/maemo/modest-store-widget.c:
1968 * src/maemo/modest-store-widget.h:
1969 * src/maemo/modest-transport-widget.c:
1970 * src/maemo/modest-transport-widget.h:
1971 * src/modest-account-mgr-helpers.c:
1972 * src/modest-account-mgr-helpers.h:
1973 * src/modest-account-mgr.c:
1974 * src/modest-account-mgr.h:
1975 * src/modest-tny-account.c:
1976 * src/modest-tny-folder.c:
1977 * src/widgets/modest-account-view.c:
1978 * src/widgets/modest-retrieve-combo-box.c:
1979 * src/widgets/modest-retrieve-combo-box.h:
1980 * src/widgets/modest-secureauth-combo-box.c:
1981 * src/widgets/modest-serversecurity-combo-box.c:
1982 * src/widgets/modest-serversecurity-combo-box.h:
1983 * tests/check_account-mgr.c:
1984 Use the specific functions, and use the re-renamed enum values for GNOME too.
1986 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1988 * src/modest-pair.h:
1989 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1990 so we can get the second based on the first.
1992 * src/maemo/modest-account-settings-dialog.h:
1993 * src/maemo/modest-account-settings-dialog.c:
1994 Added get_supported_secure_authentication_methods(), though it is mostly
1995 commented-out for now until the necessary API is committed to tinymail.
1996 (modest_account_settings_dialog_set_account_name),
1997 (save_configuration): Request the supported authentication methods from the
1998 server, so we can choose a working method.
2000 * src/modest-tny-account-store.h:
2001 * src/modest-tny-account-store.c:
2002 (modest_tny_account_store_get_session): Rename from
2003 tny_account_store_get_session().
2005 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2007 * src/modest-protocol-info.h: Split the ModestProtocol enum
2008 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2009 There was no need to have these unrelated values in one enum.
2011 * src/: many files: Adapted to changed enum. This makes the code a bit
2012 clearer, and the compiler could catch some errors.
2014 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2016 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2017 Show the detailed internal camel error message when an error happens
2018 during the configuration, so that our testers can give us more clues.
2019 For instance, in projects.maemo.org bug NB#56910 .
2021 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2023 * src/modest-tny-account.c:
2024 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2025 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2027 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2029 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2030 * src/maemo/modest-account-settings-dialog.c:
2031 (modest_account_settings_dialog_set_account_name),
2032 (save_configuration): For the incoming secure authentication checkbox,
2033 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2034 the UI specification. PLAIN does not seem to be supported for most IMAP
2035 servers anyway, and I am not sure what it would mean.
2036 However, we probably need to discover which of the secure-authentication
2037 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2038 * src/modest-account-mgr-helpers.c:
2039 (modest_account_mgr_get_server_account_data):
2041 * src/modest-tny-account.c:
2042 (modest_tny_account_new_from_server_account):
2043 Use tny_account_set_mech() to set secure-authentication methods,
2044 with some special-casing for IMAP, based on my observations of how
2047 * src/modest-account-mgr-helpers.h:
2048 * src/modest-account-mgr.c:
2049 * src/modest-defs.h: Comment that the URI is only used for local folders.
2051 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2053 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2054 parameter const, just to be neat.
2055 * src/modest-text-utils.c: (modest_text_utils_inline):
2056 End g_strconcat() with NULL, as its documentation says. This is almost
2057 certainly the cause of my crash at startup on the device. Interestingly,
2058 valgrind doesn't tell us about these errors.
2060 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2062 * scripts/build-packages: Added more precise comments about how to use
2063 this script, though I still get this error:
2064 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2065 error building tinymail
2067 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2069 * src/maemo/modest-main-window.c: (on_account_update):
2070 Very slight cleanup, hoping to make it simpler to discover what causes
2071 a crash here sometimes.
2073 * src/modest-tny-account.c:
2074 (modest_tny_account_new_from_server_account): Set the port. Added
2075 comments about the options and a TODO comment because I need to find out
2076 how to specify the secure authentication method.
2078 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2080 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2081 changed CFlags paths form modest to libmodest
2083 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2085 * src/modest-account-mgr-helpers.c:
2086 (modest_account_mgr_get_server_account_data),
2087 (modest_account_mgr_free_server_account_data):
2088 * src/modest-account-mgr-helpers.h:
2089 * src/modest-account-mgr.c:
2090 (modest_account_mgr_add_server_account):
2091 * src/modest-defs.h:
2092 * src/modest-tny-account.c:
2093 (modest_tny_account_new_from_server_account):
2094 Determine the options for tny_camel_account_add_option() here,
2095 based on the settings, rather than storing them directly in gconf.
2097 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2099 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2100 Show a more friendly error dialog now that we expect (from the tinymail
2101 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2103 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2105 * src/maemo/modest-main-window.c: (on_account_update): Check that
2106 account_name is not NULL, to prevent a crash at startup that I am
2107 seeing on the N800. I do wonder why it is NULL.
2109 * src/maemo/easysetup/modest-easysetup-wizard.c:
2110 (create_page_user_details):
2111 * src/maemo/modest-account-settings-dialog.c:
2112 (create_page_user_details), (create_page_outgoing):
2113 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2114 (modest_connection_specific_smtp_edit_window_init):
2115 * src/modest-ui-actions.c:
2116 (modest_ui_actions_on_password_requested):
2117 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2118 might do something useful with the on-screen keyboard.
2120 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2122 * src/maemo/modest-main-window.c: (on_account_update):
2123 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2124 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2126 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2128 * src/modest-tny-account-store.c: (on_account_changed):
2129 Correct the signature of this signal handler.
2131 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2133 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2134 Show a HildonNote instead of a GtkDialog for Maemo.
2136 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2138 * src/widgets/modest-account-view.h:
2139 * src/widgets/modest-account-view.c: (on_account_changed),
2140 (on_account_removed). Added a boolean flag, set/unset by
2141 modest_account_view_block_conf_updates(),
2142 modest_account_view_unblock_conf_updates() to prevent unnecessary
2143 updates, but this is not very useful because the gconf notifications are
2144 so delays (maybe only on Maemo Bora).
2145 So auto-updating is turned off, and these functions do an explicit
2146 update when necessary.
2147 However, something else is still doing too much work when adding/removing
2148 accounts, probably in another part of the application.
2150 * src/maemo/modest-account-view-window.c:
2151 (on_delete_button_clicked), (on_edit_button_clicked),
2152 (on_new_button_clicked): Use the new functions.
2154 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2156 * src/modest-account-mgr-helpers.c:
2157 (modest_account_mgr_set_first_account_as_default):
2158 Sort the list of names alphabetically-by-title, so we choose the first one
2160 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2161 alphabetically by the title.
2163 This fixes projects.maemo.org bug NB#56418 .
2165 * src/modest-account-mgr-priv.c:
2166 (_modest_account_mgr_account_from_key):
2167 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2168 avoid a valgrind error, and possible random behaviour.
2170 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2172 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2173 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2174 tinymail documentation to say that this can be expected.
2175 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2176 pretty, and should not happen, but I would prefer to know when it does.
2178 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2180 * configure.ac: When using the older hildon version, probably on Bora,
2181 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2183 * src/widgets/modest-attachment-view.c:
2184 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2187 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2189 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2190 Implemented the prototype. Can be tested with
2191 tests/dbus_api/test_open_message:
2193 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2195 * src/modest-tny-account-store.c:
2196 (modest_tny_account_store_instance_init), (get_password):
2197 * src/modest-ui-actions.c:
2198 (modest_ui_actions_on_password_requested):
2199 Do not store the password in gconf, because this function is called
2200 for non-remembered passwords. Actually use the cached (in the hash map)
2201 password instead of releasing it.
2202 The password will now not be remembered if it is asked via the protected
2203 password dialog, as per the UI spec.
2205 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2207 * src/modest-defs.h:
2208 * src/modest-account-mgr-helpers.h:
2209 * src/modest-account-mgr-helpers.c:
2210 Added modest_server_account_get_username_has_succeeded(),
2211 modest_server_account_set_username_has_succeeded().
2212 (modest_server_account_set_username),
2213 Reset the has-succeeded flag if the username changes.
2215 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2216 * src/maemo/modest-connection-specific-smtp-window.c:
2217 (modest_connection_specific_smtp_window_save_server_accounts):
2218 Use modest_server_account_set_username() instead of using
2219 modest_conf_set_string() directly, so that the has-succeeded flag is always
2222 * src/modest-ui-actions.c:
2223 (modest_ui_actions_on_password_requested): Dim the username entry if
2224 the username has ever worked, as per the UI spec.
2226 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2228 * src/modest-tny-account-store.c: (get_password):
2229 * src/modest-ui-actions.c:
2230 (modest_ui_actions_on_password_requested):
2231 Allow the username to be changed too, though there is more work to
2232 be done on exactly how this behaves.
2234 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2236 * src/modest-account-mgr-helpers.h:
2237 * src/modest-account-mgr-helpers.c:
2238 Added modest_account_mgr_get_display_name(),
2239 modest_server_account_get_username(),
2240 modest_server_account_set_username(),
2241 modest_server_account_set_password(),
2242 modest_server_account_get_hostname() functions so we do not need to
2243 use the conf API directly.
2245 * src/maemo/modest-main-window.c: (connect_signals):
2246 Actually connect ot the ModestAccountStore::request-password signal,
2247 so that we show the dialog when the password is requested by Tinymail,
2248 for isntance if it is empty.
2250 * src/modest-marshal.list:
2251 * src/modest-tny-account-store.c:
2252 (modest_tny_account_store_class_init), (get_password),
2253 (modest_tny_account_store_alert):
2254 * src/modest-tny-account-store.h:
2255 * src/modest-ui-actions.h:
2256 * src/modest-ui-actions.c:
2257 (modest_ui_actions_on_password_requested):
2258 Change the signal parameters, so it is obvious that we are providing
2259 the non human-readable server name, and receiving both the username
2260 and password, though changing of the username is not yet implemented.
2261 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2262 for the GNOME version.
2264 This should fix the projects.maemo.org bug NB#56209, though it does not
2265 work on Bora, because the gconf_client_get() for the password fails
2266 immediately after we save it with gconf_client_set().
2268 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2271 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2272 caused an undefined symbol error:
2273 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2275 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2277 * src/modest-tny-account-store.c:
2278 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2279 using a GError instead of a string message, so we can translate it in
2282 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2284 * src/maemo/modest-address-book.c:
2285 (modest_address_book_check_names):
2286 * src/maemo/modest-msg-view-window.c:
2287 (modest_msg_view_window_clipboard_owner_change):
2288 * src/modest-init.c: (modest_init_init_ui):
2289 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2290 (update_folders_cb), (modest_mail_operation_update_account):
2291 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2292 (modest_ui_actions_on_msg_attachment_clicked),
2293 (modest_ui_actions_on_msg_recpt_activated):
2294 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2295 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2296 (modest_msg_view_search_next):
2297 * src/widgets/modest-recpt-editor.c:
2298 (modest_recpt_editor_on_button_release_event),
2299 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2300 g_message(). At this point we should only be seeing interesting errors on
2301 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2303 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2305 (modest_wizard_dialog_force_title_update):
2306 * src/maemo/easysetup/modest-wizard-dialog.h:
2307 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2308 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2309 can update the title when appropriate. Otherwise the title is wrong if the
2310 pages are added after adding the notebook to the dialog.
2311 This must be a problem in HildonWizardDialog too.
2312 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2314 * src/maemo/easysetup/modest-easysetup-wizard.c:
2315 (create_subsequent_customsetup_pages),
2316 (create_subsequent_easysetup_pages):
2317 Call modest_wizard_dialog_force_title_update() so that the title is
2318 correct even with GTK+ < 2.10.
2319 This fixes projects.maemo.org bug NB#56145 .
2321 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2323 * src/maemo/modest-platform.c:
2324 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2325 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2328 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2330 * src/widgets/modest-window.h:
2331 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2332 and modest_window_save_state(), which invokes it.
2334 * src/widgets/modest-window-mgr.h:
2335 * src/widgets/modest-window-mgr.c:
2336 Added modest_window_mgr_save_state_for_all_windows(), which calls
2337 the save_state vfunc on all registered windows, if implemented.
2339 * src/gnome/modest-msg-edit-window.c:
2340 * src/gnome/modest-msg-view-window.c:
2341 * src/maemo/modest-msg-edit-window.c:
2342 * src/maemo/modest-msg-view-window.c:
2343 * src/maemo/modest-main-window.c:
2344 Specify the existing save_settings functions as implementations of
2345 ModestWindow::save_state_func().
2347 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2348 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2349 enabling hibernation, for instance.
2351 We may need to do the same thing for restoring settings.
2354 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2356 * src/widgets/modest-window-mgr.c:
2357 * src/widgets/modest-window-mgr.h:
2358 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2359 modest_window_mgr_get_hibernation_is_prevented().
2361 * src/maemo/modest-main-window.c:
2362 (on_hildon_program_is_topmost_notify): Prevent hibernation
2363 (possible when the application goes to the background in the WM),
2364 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2366 * src/maemo/easysetup/modest-easysetup-wizard.c:
2367 (modest_easysetup_wizard_dialog_init):
2368 * src/maemo/modest-account-settings-dialog.c:
2369 (modest_account_settings_dialog_init):
2370 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2371 (modest_connection_specific_smtp_edit_window_init):
2372 * src/maemo/modest-connection-specific-smtp-window.c:
2373 (modest_connection_specific_smtp_window_init):
2374 * src/maemo/modest-signature-editor-dialog.c:
2375 (modest_signature_editor_dialog_init):
2376 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2377 prevent hibernation while any of these account settings dialogs are open.
2379 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2381 * src/maemo/Makefile.am:
2382 * src/maemo/modest-osso-state-saving.c:
2383 * src/maemo/modest-osso-state-saving.h: Added
2384 modest_osso_load_state() and modest_osso_save_state() though they do
2385 nothing now. They should iterate through all the open windows and load/save
2387 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2388 save state when closing.
2390 * src/maemo/modest-main-window.c:
2391 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2392 Add a notification handler for the HildonProgram::is-topmost property,
2393 so we can allow hibernation when the application goes into the background.
2394 But we still need to detect when the accounts setup windows are open so
2395 we can stop hibernation when they are open.
2396 To do this, I also added the main window the HildonProgram. This might have
2397 other side-effects/benefits, and should maybe be done for other windows.
2399 * src/maemo/modest-osso-autosave-callbacks.h:
2400 * src/maemo/modest-osso-autosave-callbacks.c:
2401 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2402 though it does not do anything yet, and we might never need this to do
2403 anything. For instance, we already save drafts.
2405 * src/maemo/modest-platform.c: (modest_platform_init):
2406 Specify the libosso auto-save callback.
2408 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2410 * src/maemo/modest-platform.c:
2411 (modest_platform_set_update_interval):
2412 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2413 aparently stays valid between application instances, so we can use this
2414 to remove and reset it later. According to a maemo-developers email from
2417 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2419 * configure.ac: Depend on libalarm for Maemo.
2421 * src/dbus_api/modest-dbus-api.h:
2422 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2423 (on_send_receive), (modest_dbus_req_handler):
2424 Handle a SEND_RECEIVE D-Bus method.
2426 * libmodest-dbus-client/libmodest-dbus-client.c:
2427 (libmodest_dbus_client_send_and_receive):
2428 * libmodest-dbus-client/libmodest-dbus-client.h:
2429 Add C convenience functions for calling the new D-Bus method.
2431 * src/modest-platform.h:
2432 * src/gnome/modest-platform.c:
2433 * src/maemo/modest-platform.c:
2434 Added modest_platform_set_update_interval(), which uses the
2435 alarmd API on Maemo.
2436 (modest_platform_init),
2437 Call modest_platform_set_update_interval(), using a hard-coded
2438 interval for now (until the global settings dialog is implemented),
2439 though I am not sure that this makes sense yet.
2441 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2443 * src/dbus_api/modest-dbus-callbacks.c:
2444 (modest_osso_cb_hw_state_handler):
2445 * src/dbus_api/modest-dbus-callbacks.h:
2446 * src/maemo/modest-platform.c: (modest_platform_init):
2447 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2448 in case this has some effect on the ability for Maemo to ping the
2451 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2453 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2454 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2455 warning. It is probably a logic error, but I need to fix the build.
2457 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2459 * src/modest-account-mgr.h:
2460 * src/modest-account-mgr.c:
2461 (modest_account_mgr_account_names): Add a gboolean enabled_only
2462 parameter, so we can get lists of onlt the enabled accounts.
2464 (modest_account_mgr_add_account),,
2465 (modest_account_mgr_account_with_display_name_exists):
2466 * src/maemo/modest-msg-edit-window.c: (get_transports):
2467 * src/modest-account-mgr-helpers.c:
2468 (modest_account_mgr_set_first_account_as_default):
2469 * src/modest-init.c: (init_default_account_maybe):
2470 * src/modest-tny-account-store.c: (get_accounts):
2471 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2472 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2473 * tests/check_account-mgr.c: (START_TEST):
2474 Provide the extra parameter, as appropriate.
2476 * src/widgets/modest-account-view.c: (update_account_view):
2477 Do not show disabled accounts (meaning that there is no way to
2478 enable/disable accounts in the UI (the feature is not in our UI
2479 specification), so we can use this internally only to mark unfinished
2480 or temporary account data.
2482 * src/maemo/easysetup/modest-easysetup-wizard.c:
2483 (create_account): Add boolean enable parameter, so we can specify FALSE
2484 to create the temporary account.
2485 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2486 (on_before_next): When finishing, when there is a temporary account, just
2488 Also, use a timeout to delay the showing of the dialog until gconf is likely
2489 to return correct information, due to a maemo gconf bug that is fixed in
2490 osso 1.1, but not yet in Bora.
2491 However, the dialog stays on screen after it is destroyed.
2493 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2494 for invalid data when cancelling. Use a hildon note instead of a dialog
2495 to complain about invalid data. Do not show the account-saved note if the
2496 account is disabled (a temporary account that will not really be saved for use
2499 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2501 * src/modest-account-mgr-helpers.h:
2502 * src/modest-account-mgr-helpers.c:
2503 Added modest_account_mgr_unset_default_account(),
2504 Added modest_account_mgr_set_first_account_as_default().
2506 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2507 If it was the default account, unset the default account name.
2509 * src/maemo/modest-account-view-window.c:
2510 (on_delete_button_clicked): If it was the default account,
2511 set the first remaining account as the default instead.
2513 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2514 a NULL account or a NULL default account, to prevent a crash. This should
2515 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2518 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2520 * src/widgets/modest-recpt-editor.c:
2521 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2522 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2523 TODO comment for this. This fixes the build.
2525 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2526 be the best place for it. This will in future update all auto-update accounts,
2527 rather than just the current/default account, when that gconf key exists.
2528 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2529 if there are no accounts, before calling do_send_receive().
2530 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2532 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2533 * src/maemo/modest-main-window-ui.h:
2534 * src/maemo/modest-main-window.c: (on_connection_changed),
2535 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2536 directly, becaue the signal handler does more.
2538 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2540 * src/modest-account-mgr-helpers.c:
2541 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2542 for the case that the account does not exist.
2544 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2545 (equivalent to the modest account name) rather than the tinymail account name
2546 (equivalent to the modest account title - human readable) to get the account data.
2547 Check for null account data to prevent the crash, and add a TODO comment saying that
2548 this needs fixing because it is using the server account name instead of the account name.
2550 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2552 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2553 * src/maemo/modest-account-settings-dialog.c: (show_error),
2555 Use hildon_note_new_information() for informative and error messages,
2556 which seems to be expected for Maemo applications (no documentation that I know of
2557 says this). I am surprised that there is no distinction between info and error
2560 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2562 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2563 it is easy to find where this is used.
2565 * src/maemo/easysetup/modest-easysetup-wizard.c:
2566 (create_page_welcome), (create_page_account_details),
2567 (create_page_user_details), (create_page_complete_easysetup),
2568 (create_page_custom_incoming), (create_page_custom_outgoing),
2569 (create_page_complete_custom):
2570 * src/maemo/modest-account-settings-dialog.c:
2571 (create_page_account_details), (create_page_user_details),
2572 (create_page_incoming), (create_page_outgoing):
2573 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2574 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2575 (modest_connection_specific_smtp_edit_window_init):
2576 * src/maemo/modest-connection-specific-smtp-window.c:
2577 (modest_connection_specific_smtp_window_init):
2578 * src/maemo/modest-signature-editor-dialog.c:
2579 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2580 and scrolling policy as per the Email Application Layout Guide, if I have
2583 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2585 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2586 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2587 which were empty, because these vfuncs have been removed from TnyAccountStore.
2588 This fixes the build.
2590 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2592 * src/maemo/modest-main-window.c:
2593 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2594 showing/hiding it. Added TODO because it probably should not be NULL.
2595 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2596 because unnecessary g_warnings() make degugging difficult.
2598 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2600 * src/maemo/modest-msg-edit-window.c:
2601 (modest_msg_edit_window_select_color),
2602 (modest_msg_edit_window_select_background_color): 2 const corrections and
2603 moving 2 #endifs before closing brackets, to fix the build.
2605 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2607 * src/maemo/easysetup/modest-easysetup-wizard.h:
2608 * src/maemo/easysetup/modest-easysetup-wizard.c:
2609 (modest_easysetup_wizard_dialog_finalize),
2610 (on_button_edit_advanced_settings), (create_page_complete_custom),
2611 (on_response), (create_account):
2612 Implement the Advanced Settings edit button, by saving the account information,
2613 for the Advanded Settings dialog to use directly from gconf, and removing it
2614 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2615 Bug #5533 in the projects.maemo.org bugzilla.
2617 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2619 * src/maemo/modest-msg-view-window.c:
2620 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2621 when opening a message window.
2623 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2625 * src/maemo/easysetup/modest-easysetup-wizard.c:
2626 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2629 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2630 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2631 gconf settings. I probably added more checks than necessary, but that is safer.
2633 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2634 variable to fix the build, but this seems to be used when it is still NULL.
2636 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2638 * src/modest-platform.h:
2639 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2640 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2641 * src/modest-main.c: Implement this function so we can avoid using
2642 maemo-specific API from cross-platform code.
2644 * src/modest-tny-account-store.c:
2645 (get_smtp_specific_transport_account_for_open_connection):
2646 * src/modest-ui-actions.c: (check_for_connection),
2647 (modest_ui_actions_on_item_not_found):
2648 Use modest_platform_connect_and_wait() and put #idefs around other
2649 maemo-specific code, because only maemo currently has a way to
2650 identify connection names.
2652 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2654 * src/modest-tny-account-store.h:
2655 * src/modest-tny-account-store.c:
2656 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2657 the connection-specific SMTP server settings in the configuration.
2659 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2661 * src/maemo/modest-main-window.c: (on_connection_changed),
2663 * src/modest-main.c: (main), (start_ui), (send_mail):
2664 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2665 that is what is intended.
2667 * src/modest-ui-actions.c: (action_send), (action_receive),
2668 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2669 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2670 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2671 SMTP server is used when it is specified.
2673 (modest_ui_actions_on_send_receive):
2674 Check that a connection is open before proceeding.
2675 Receive and then send, instead of vice-versa, as per the specification.
2677 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2679 * src/modest-mail-operation.c:
2680 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2681 though I guess it should be something other than NULL.
2683 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2685 * src/maemo/easysetup/modest-easysetup-wizard.c:
2686 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2687 combo twice, to avoid an g_warning and to make it visible again.
2688 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2689 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2690 (already intended) dereference when detaching, because we then recreate the menu.
2691 But I am not sure why the warning was happening, and it is possible that this is a memory
2694 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2696 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2697 and uri_parse_mailto() utility functions.
2698 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2700 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2702 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2704 * src/dbus_api/modest-dbus-api.h:
2705 * src/dbus_api/modest-dbus-callbacks.c:
2706 Use an idle callback to execute the modest code in the application's own thread.
2707 Remove the helloworld example method.
2708 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2709 parsed, and the open-message method is not implemented because this is not yet implemented in
2711 * libmodest-dbus-client/libmodest-dbus-client.c:
2712 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2713 (libmodest_dbus_client_open_message):
2714 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2716 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2717 body without crashing.
2719 * tests/dbus_api/Makefile.am:
2720 * tests/dbus_api/test_mail_to.c:
2721 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2723 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2725 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2726 Added file to fix the build. Sorry.
2728 * src/dbus_api/Makefile.am:
2729 * src/dbus_api/modest-dbus-api.h:
2730 * src/dbus_api/modest-dbus-callbacks.h:
2731 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2732 (modest_dbus_req_handler):
2733 Put constants in a separate header so it can be reused by the
2734 client library, without duplication
2736 * libmodest-dbus-client/Makefile.am:
2737 * libmodest-dbus-client/libmodest-dbus-client.c:
2738 (libmodest_dbus_client_call_helloworld),
2739 (libmodfest_dbus_client_send_mail),
2740 (libmodfest_dbus_client_mailto),
2741 (libmodfest_dbus_client_open_message):
2742 * libmodest-dbus-client/libmodest-dbus-client.h:
2743 (Partly) Implement a send_mail D-Bus method.
2745 * tests/dbus_api/Makefile.am:
2746 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2747 the send_email D-Bus method.
2749 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2753 * libmodest-dbus-client/Makefile.am:
2754 * libmodest-dbus-client/libmodest-dbus-client.c:
2755 * libmodest-dbus-client/libmodest-dbus-client.h:
2756 * tests/dbus_api/Makefile.am:
2757 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2758 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2760 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2762 * src/maemo/easysetup/modest-easysetup-wizard.c:
2763 (create_page_account_details):
2764 * src/maemo/modest-account-settings-dialog.c:
2765 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2766 widgets, because this might not be the default in future versions of the Maemo GTK+.
2767 However, I can not not get capitalization to work even in a simple test case.
2769 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2771 * src/maemo/easysetup/modest-easysetup-wizard.c:
2772 (create_page_custom_incoming), (create_page_custom_outgoing):
2773 * src/maemo/modest-account-settings-dialog.c:
2774 (create_page_account_details), (create_page_incoming),
2775 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2776 instead of using gtk_check_button_with_label(), so they are aligned like the other
2777 widgets, as per the UI spec.
2779 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2781 * src/maemo/easysetup/modest-easysetup-wizard.c:
2782 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2783 * src/widgets/modest-validating-entry.c:
2784 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2785 Modest prefix instead of an EasySetup prefix.
2787 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2789 * src/widgets/modest-validating-entry.h:
2790 * src/widgets/modest-validating-entry.c: (on_insert_text),
2791 Added easysetup_validating_entry_set_max_func(), used to set a callback
2792 to call when the max number of characters is reached. GtkEntry has a max-length
2793 already but is silent about it.
2795 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2796 (create_page_account_details), (create_page_user_details),
2798 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2799 (create_page_account_details), (create_page_user_details),
2800 (create_page_outgoing):
2801 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2802 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2803 the UI spec, when the user tries to enter more than the max number of characters.
2805 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2807 * src/maemo/easysetup/modest-easysetup-wizard.c:
2808 (create_page_user_details), (create_page_custom_incoming),
2809 (create_page_custom_outgoing):
2810 * src/maemo/modest-account-settings-dialog.c:
2811 (create_page_user_details), (create_page_incoming),
2812 (create_page_outgoing):
2813 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2814 (modest_connection_specific_smtp_edit_window_init):
2815 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2816 not appropriate. Bad Maemo-specific defaults!.
2818 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2820 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2821 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2822 (modest_signature_editor_dialog_set_settings):
2823 Disable the label and textview when the checkbox is disabled, and use the
2824 specified (UI spec) default signature text.
2826 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2828 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2829 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2831 * src/modest-defs.h:
2832 * src/modest-account-mgr-helpers.h:
2833 * src/modest-account-mgr-helpers.c:
2834 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2836 * src/maemo/Makefile.am:
2837 * src/maemo/modest-signature-editor-dialog.c:
2838 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2841 * src/maemo/modest-account-settings-dialog.h:
2842 * src/maemo/modest-account-settings-dialog.c:
2843 (modest_account_settings_dialog_finalize), (on_button_signature),
2844 (save_configuration): Use the new dialog when the Edit button is pressed, and
2845 save the changes if necessary, as per the UI spec.
2847 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2849 * src/maemo/Makefile.am:
2850 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2851 based on maemo-develoers email from Dirk.
2853 * src/maemo/easysetup/modest-easysetup-wizard.c:
2854 (create_page_welcome), (create_page_account_details),
2855 (create_page_user_details), (create_page_complete_easysetup),
2856 (create_page_custom_incoming), (create_page_custom_outgoing),
2857 (create_page_complete_custom),
2858 (modest_easysetup_wizard_dialog_init):
2859 * src/maemo/modest-account-settings-dialog.c:
2860 (create_page_account_details), (create_page_user_details),
2861 (create_page_incoming), (create_page_outgoing),
2862 (modest_account_settings_dialog_init):
2863 * src/maemo/modest-connection-specific-smtp-window.c:
2864 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2866 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2868 * src/maemo/easysetup/modest-easysetup-wizard.c:
2869 (create_page_account_details), (create_page_custom_outgoing),
2870 (create_page_complete_custom):
2871 * src/maemo/modest-account-settings-dialog.c:
2872 (create_page_user_details), (create_page_incoming),
2873 (create_page_outgoing):
2874 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2875 (modest_connection_specific_smtp_edit_window_init):
2876 Use the correct (UI spec) port min/max, and use horizontal separators,
2879 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2881 * src/maemo/easysetup/modest-easysetup-wizard.c:
2882 (set_default_custom_servernames):
2883 * src/maemo/modest-account-settings-dialog.c:
2884 (create_page_incoming), (on_combo_outgoing_security_changed),
2885 (on_combo_incoming_security_changed), (create_page_outgoing),
2886 (modest_account_settings_dialog_set_account_name),
2887 (save_configuration):
2888 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2889 (on_combo_security_changed),
2890 (modest_connection_specific_smtp_edit_window_init),
2891 (modest_connection_specific_smtp_edit_window_set_connection),
2892 (modest_connection_specific_smtp_edit_window_get_settings):
2893 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2896 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2899 * src/maemo/easysetup/modest-easysetup-wizard.c:
2900 (create_page_custom_outgoing), (create_page_complete_custom):
2901 * src/maemo/modest-account-settings-dialog.c:
2902 (create_page_user_details), (create_page_outgoing):
2903 * src/maemo/modest-account-view-window.c: (button_box_new):
2904 Use changed logical IDs as per the most recent UI spec:
2905 mcen_bd_emailsetup_edit -> mcen_bd_edit
2906 mcen_bd_emailsetup_delete -> mcen_bd_delete
2907 mcen_bd_emailsetup_close -> mcen_bd_close
2909 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2913 * src/dbus_api/Makefile.am:
2914 * src/dbus_api/modest-dbus-callbacks.c:
2915 * src/dbus_api/modest-dbus-callbacks.h:
2916 * src/maemo/modest-platform.c: (modest_platform_init):
2917 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2919 * tests/Makefile.am:
2920 * tests/dbus_api/Makefile.am:
2921 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2923 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2925 * src/maemo/modest-account-settings-dialog.c:
2926 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2927 Removed unnecessary includes.
2929 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2931 * src/maemo/easysetup/modest-easysetup-wizard.c:
2932 * src/maemo/modest-account-settings-dialog.c:
2933 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2934 * src/widgets/Makefile.am:
2935 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2936 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2937 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2938 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2939 * src/widgets/modest-secureauth-combo-box.c:
2940 * src/widgets/modest-secureauth-combo-box.h:
2941 * src/widgets/modest-serversecurity-combo-box.c:
2942 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2943 made the GObject names more consistent with the rest of the Modest code.
2945 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2947 * src/maemo/easysetup/Makefile.am:
2948 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2949 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2950 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2951 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2952 * src/maemo/easysetup/modest-easysetup-wizard.c:
2953 * src/maemo/easysetup/modest-validating-entry.c:
2954 * src/maemo/easysetup/modest-validating-entry.h:
2955 * src/maemo/modest-account-settings-dialog.c:
2956 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2957 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2958 widgets/ because they are used outside of easysetup too. After checking in,
2959 svn will allow me to rename them too.
2961 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2963 * src/gnome/modest-msg-edit-window.c:
2964 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2965 linker error, to fix the build on the GNOME platform.
2966 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2967 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2968 ifdefed out to avoid a warning.
2970 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2972 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2973 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2974 some alternative for GTK+ 2.6.
2976 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2978 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2980 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2981 specified for EmailAccountsDialog in UI spec.
2983 * src/maemo/easysetup/modest-easysetup-wizard.c:
2984 * src/maemo/easysetup/modest-easysetup-wizard.h:
2985 * src/maemo/modest-account-settings-dialog.c:
2986 * src/maemo/modest-account-settings-dialog.h:
2987 Reuse a member window widget for the connection-specific SMTP server accounts,
2988 so we can tell it to create/save the accounts only if we actually save changes.
2990 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2991 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2992 (modest_connection_specific_smtp_edit_window_get_settings):
2993 Return a struct instance for temporarily remembering the entered data.
2995 * src/maemo/modest-connection-specific-smtp-window.h:
2996 * src/maemo/modest-connection-specific-smtp-window.c:
2997 (modest_connection_specific_smtp_window_finalize),
2998 (modest_connection_specific_smtp_window_fill_with_connections),
3000 (modest_connection_specific_smtp_window_save_server_accounts),
3001 (update_model_server_names): Do not actually save data until asked,
3002 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3004 (on_selection_changed),
3005 (modest_connection_specific_smtp_window_init): Disable the edit
3006 button when nothing is selected.
3008 * src/modest-account-mgr-helpers.c:
3009 * src/modest-account-mgr-helpers.h:
3010 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3013 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3015 * src/modest-account-mgr-helpers.h:
3016 * src/modest-account-mgr-helpers.c:
3017 (modest_account_mgr_get_unused_account_name),
3018 (modest_account_mgr_get_unused_account_display_name): Added these
3019 utility functions, to avoid code duplication.
3021 * src/maemo/easysetup/modest-easysetup-wizard.c:
3022 (create_page_account_details), (create_account):
3023 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3024 (on_combo_security_changed),
3025 (modest_connection_specific_smtp_edit_window_init),
3026 (modest_connection_specific_smtp_edit_window_save_settings):
3027 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3028 * src/maemo/modest-connection-specific-smtp-window.c:
3029 (modest_connection_specific_smtp_window_finalize),
3030 (modest_connection_specific_smtp_window_fill_with_connections),
3031 (on_button_edit), (modest_connection_specific_smtp_window_init):
3032 * src/maemo/modest-connection-specific-smtp-window.h:
3033 Implementing saving of connection-specific server accounts.
3035 But I need to refactor this so we can save the data for each
3036 possible connection-specific account and only actually create the server accounts
3037 when the easysetup finished, or the OK button is pressed on the account settings
3040 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3042 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3043 (on_combo_security_changed):
3044 (modest_connection_specific_smtp_edit_window_init):
3045 Auto-fill the port number as in the account settings.
3047 (modest_connection_specific_smtp_edit_window_set_connection):
3048 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3049 * src/maemo/modest-connection-specific-smtp-window.c:
3050 (fill_with_connections), (on_button_edit),
3051 (modest_connection_specific_smtp_window_init):
3052 Turn the edit window into a dialog to simplify the code, and
3053 set a WM hint as in a GtkDialog, because only a popup can be on top of
3054 another window in Maemo, and popups usually have no WM decoration.
3056 * src/modest-defs.h:
3057 * src/modest-account-mgr-helpers.c:
3058 (modest_account_mgr_set_connection_specific_smtp),
3059 (modest_account_mgr_remove_connection_specific_smtp),
3060 (modest_account_mgr_get_connection_specific_smtp):
3061 * src/modest-account-mgr-helpers.h: Some functions to write the
3062 connection-specific SMTP server information. Not yet used.
3065 * src/widgets/modest-folder-view.c: (text_cell_data):
3066 Fix a warning about an uninitialized variable.
3067 (on_configuration_key_changed): Put an #ifdef around the use
3068 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3070 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3072 * src/maemo/modest-account-settings-dialog.h:
3073 * src/maemo/modest-account-settings-dialog.c:
3074 Added connect_for_modified() utility function to mark the new modified boolean.
3076 (create_page_account_details), (create_page_user_details),
3077 (create_page_incoming), (create_page_outgoing), (on_response),
3078 (modest_account_settings_dialog_init),
3079 (modest_account_settings_dialog_set_account_name):
3080 Only warn about unsaved changes when there are actually unsaved changes.
3082 * src/modest-account-mgr-helpers.c:
3083 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3084 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3085 to get the data from there in future.
3087 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3089 * src/modest-defs.h:
3091 * src/modest-account-mgr-helpers.h:
3092 * src/modest-account-mgr-helpers.c:
3093 Store the security account setting in a single conf key instead of using
3094 the options list, so that the list is left for just the to-be-removed camel hack,
3095 and because gconf_client_set_list() is failing for some reason.
3097 * src/modest-account-mgr.c:
3098 (modest_account_mgr_add_server_account):
3099 * src/maemo/modest-account-settings-dialog.c:
3100 (modest_account_settings_dialog_set_account_name),
3101 (save_configuration): Use the renamed functions.
3104 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3106 * src/widgets/Makefile.am:
3107 * src/widgets/modest-limit-retrieve-combo-box.c:
3108 * src/widgets/modest-limit-retrieve-combo-box.h:
3109 * src/widgets/modest-retrieve-combo-box.c:
3110 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3111 the account settings dialog.
3113 * src/modest-defs.h:
3114 * src/modest-account-mgr-helpers.h:
3115 * src/modest-account-mgr-helpers.c:
3116 (modest_server_account_get_option_secure_auth),
3117 (modest_server_account_set_option_secure_auth):
3118 * src/modest-account-mgr.c:
3119 (modest_account_mgr_add_server_account):
3120 Use the existing AUTH_MECH conf key for the secure-auth setting,
3121 instead of putting it in the list options, because this was actually used already.
3123 * src/maemo/modest-account-settings-dialog.c:
3124 (create_page_account_details),
3125 (modest_account_settings_dialog_set_account_name),
3126 (save_configuration):
3127 * src/maemo/modest-account-settings-dialog.h:
3128 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3129 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3131 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3133 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3134 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3135 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3137 * src/modest-defs.h:
3138 * src/maemo/modest-account-settings-dialog.c:
3139 (create_page_incoming), (on_combo_outgoing_security_changed),
3140 (on_combo_incoming_security_changed), (create_page_outgoing),
3141 (modest_account_settings_dialog_set_account_name),
3142 (save_configuration): Load/Save the port number, and change it when the
3143 security combo changes, to suitable defaults.
3145 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3147 * src/modest-account-mgr.c:
3148 (modest_account_mgr_add_server_account): Set the security and secure-auth
3149 options, and add a comment saying that the other camel-specific options should be
3152 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3154 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3156 * src/modest-tny-account-store.c: (account_list_free),
3157 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3158 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3161 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3163 * src/modest-protocol-info.c:
3164 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3165 is required by our UI spec. Maybe something in our implementation will use this eventually.
3166 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3167 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3168 instead of the previous 0 placeholder.
3170 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3171 secure-auth settings.
3172 * src/modest-account-mgr-helpers.h:
3173 * src/modest-account-mgr-helpers.c:
3174 (modest_server_account_data_get_option_secure_auth),
3175 (modest_server_account_set_option_secure_auth),
3176 (modest_server_account_data_get_option_security),
3177 (modest_server_account_set_option_security): Added this API for getting and setting the security
3178 and secure-auth settings.
3180 * src/maemo/modest-account-settings-dialog.h:
3181 * src/maemo/modest-account-settings-dialog.c:
3182 (modest_account_settings_dialog_finalize), (check_data),
3183 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3184 about changing titles.
3185 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3186 (save_configuration): Save the security and secure-auth settings.
3188 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3189 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3191 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3193 * src/modest-defs.h:
3194 * src/modest-account-mgr.c:
3195 (modest_account_mgr_add_server_account):
3196 Added and used defines for the options key and value pair strings,
3197 that are used so far, though they do not seem to correspond to anything in our
3198 UI specs or ModestProtocol enum.
3200 * src/modest-account-mgr-helpers.h:
3201 * src/modest-account-mgr-helpers.c:
3202 (compare_option_strings_for_name),
3203 (modest_server_account_data_get_option_value),
3204 (modest_server_account_data_get_option_bool),
3205 (modest_account_mgr_get_server_account_option):
3206 Added helper functions for parsing the options GSList.
3208 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3210 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3211 display name is based on the supplied account name.
3212 * src/modest-account-mgr.c:
3213 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3214 with an inefficient, but good-enough, implementation.
3216 * src/maemo/easysetup/modest-easysetup-wizard.c:
3217 (create_page_account_details), (on_before_next), (create_account):
3218 Check for existing display names rather than (non-user-visible) account names, and just
3219 create and set a unique account name at the end.
3221 * src/maemo/modest-account-settings-dialog.c:
3222 (modest_account_settings_dialog_init),
3223 (modest_account_settings_dialog_set_account_name),
3224 (create_page_incoming): Show the display name, instead of the account name.
3225 (on_response): Do some (not all) extra checks, as in the UI spec.
3226 (save_configuration): Save the display name if it was changed.
3228 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3230 * po/en_GB.po: Added needed logical ID and translation.
3231 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3232 (init_view): Made the is-default column clicking work.
3234 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3237 * src/maemo/easysetup/Makefile.am:
3238 * src/maemo/easysetup/modest-easysetup-wizard.c:
3239 (modest_easysetup_wizard_dialog_init):
3240 * src/maemo/easysetup/provider-data-test.keyfile:
3241 * src/maemo/easysetup/provider-data.keyfile:
3242 Moved the provider data file to the new modest-providers-data package and used it from there.
3244 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3246 * src/modest-local-folder-info.c:
3247 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3248 N_() was already used on the static strings, but this just marks it for translation without
3249 using the translation.
3251 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3253 * src/maemo/modest-account-settings-dialog.c:
3254 (create_page_incoming),
3255 (modest_account_settings_dialog_set_account_name):
3256 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3257 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3258 I will do this if nobody else gets there first.
3260 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3262 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3263 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3264 save the security stuff.
3266 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3268 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3269 Set the email address and user fullname, which I now see must be
3272 * src/maemo/modest-account-settings-dialog.h:
3273 * src/maemo/modest-account-settings-dialog.c:
3275 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3276 leave-on-server and authentication.
3277 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3280 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3283 * src/maemo/modest-account-settings-dialog.c:
3284 * src/maemo/modest-account-settings-dialog.h:
3285 Most (but not all) of the widgets are now present as specified by the UI spec.
3286 No changes are yet saved, and some details are not properly shown yet.
3288 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3290 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3292 * src/maemo/Makefile.am:
3293 * src/maemo/modest-account-settings-dialog.c:
3294 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3295 an existing account. Doesn't do much yet.
3297 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3298 Open the accounts settings dialog when Edit is clicked.
3300 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3302 * src/maemo/easysetup/Makefile.am:
3303 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3305 * src/maemo/easysetup/modest-easysetup-wizard.c:
3306 (modest_easysetup_wizard_dialog_init):
3307 Try to get the source directory from the build system,
3308 instead of hard-coding "./" into the source code, when opening our local
3309 copies of the configuration files.
3310 But this still fails when opening the wizard from the Accounts window,
3311 maybe because the working directory seems to change at runtime.
3312 So the wizard will fail the second time unless you copy the files into their
3313 proper locations - see the stdout warnings for the paths.
3315 (create_page_account_details),(on_before_next):
3316 Check for existing non-server accounts instead of server accounts,
3317 so the default account name is useful again, and to prevent trying to
3320 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3321 Show the wizard when New is clicked.
3323 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3324 (init_view): Show the column headers, and show the columns that are
3325 specified in the UI specs. However, something in Maemo's GTK+ prevents
3326 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3327 change the default account. This is despite unsetting the special properties.
3329 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3331 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3332 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3333 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3334 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3335 to make that clearer.
3336 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3338 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3340 * src/maemo/modest-account-view-window.c:
3341 (modest_account_view_window_init),
3342 (modest_account_view_window_new):
3343 Use the same buttons as specified in the
3344 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3345 the existing widgets, which never had a chance of working.
3346 Put the ModestAccountView treeview in a scrolled window.
3347 Do not repeat the initialization in both _init() and _new().
3349 * src/widgets/modest-account-view.c: (update_account_view):
3350 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3351 this widget and window shows no accounts.
3353 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3355 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3357 * src/maemo/easysetup/modest-easysetup-wizard.c:
3358 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3359 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3360 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3363 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3364 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3365 accounts exist yet, as in the UI spec.
3367 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3369 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3371 * src/maemo/Makefile.am:
3372 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3373 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3374 New window for editing connection-specific smtp details.
3375 Not fully implemented.
3377 * src/maemo/modest-connection-specific-smtp-window.c:
3378 (modest_connection_specific_smtp_window_finalize) :
3379 unref the tree model.
3380 (on_button_edit): Show the edit window.
3382 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3384 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3387 * src/maemo/Makefile.am:
3388 * src/maemo/modest-connection-specific-smtp-window.c:
3389 * src/maemo/modest-connection-specific-smtp-window.h:
3390 New window for showing the list of connections, for connection-specific
3391 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3392 * src/maemo/easysetup/modest-easysetup-wizard.c:
3393 (create_page_custom_outgoing): Show the new window when the button is clicked.
3395 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3397 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3398 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3399 * src/maemo/modest-msg-edit-window.c:
3400 (modest_msg_edit_window_insert_image):
3401 * src/modest-conf.c: (modest_conf_key_escape):
3402 * src/modest-mail-operation.c:
3403 (modest_mail_operation_send_new_mail):
3404 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3405 (modest_ui_actions_on_new_account):
3406 * src/widgets/modest-attachment-view.c: (update_filename_request):
3407 * src/widgets/modest-mail-header-view.c:
3408 Corrected warnings that were breaking the build, by commenting out unused variables,
3409 and a function, and by including a header.
3411 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3413 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3414 so we can #ifdef around platform-specific code when necessary.
3415 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3416 to allow this to build for the GNOME platform too.
3418 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3420 * src/maemo/easysetup/modest-easysetup-wizard.c:
3421 Added util_increment_name() and used it in create_page_account_details()
3422 to make sure that the default account name is always a new name.
3424 (modest_easysetup_wizard_dialog_init),
3425 (set_default_custom_servernames): Some minor memory management fixes.
3427 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3431 * src/modest-runtime.c: (init_i18n): Restored the translation
3432 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3433 are defined in config.h, and the translations are installed.
3435 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3436 is defined for translation.
3438 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3440 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3442 * src/maemo/easysetup/modest-easysetup-wizard.c:
3443 (modest_easysetup_wizard_dialog_init):
3444 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3445 Use realistic paths (though they should use $prefix generically) to the
3446 mcc_mapping and provider-data.keyfile files which might work when they
3447 are installed by the future version of the operator-wizard package,
3448 and then fallback to paths in our source code, with an explanatory
3451 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3455 * src/maemo/Makefile.am:
3456 * src/maemo/easysetup/: Added files from the previously-exernal
3457 osso-modest-easysetup.
3458 * src/maemo/modest-main-window-ui.h:
3459 * src/modest-ui-actions.c:
3460 * src/modest-ui-actions.h:
3461 Added modest_ui_actions_on_new_account() as a signal handler for the
3462 New Account menu item. It shows the easysetup wizard.
3463 * po/en_GB.po: Added additional needed logical IDs and translations.