Fixes NB#153926, "insert image" button moved from app menu to toolbar
[modest] / src / widgets / modest-msg-edit-window.c
index 197ab17..e042b8d 100644 (file)
@@ -188,6 +188,8 @@ static void text_buffer_mark_set (GtkTextBuffer *buffer,
                                  GtkTextIter *iter,
                                  GtkTextMark *mark,
                                  ModestMsgEditWindow *userdata);
+static void on_show_toolbar_button_toggled (GtkWidget *button,
+                                           ModestMsgEditWindow *window);
 static void on_message_settings (GtkAction *action,
                                 ModestMsgEditWindow *window);
 static void setup_menu (ModestMsgEditWindow *self);
@@ -337,6 +339,7 @@ struct _ModestMsgEditWindowPrivate {
        GtkWidget   *app_menu;
        GtkWidget   *cc_button;
        GtkWidget   *bcc_button;
+       GtkWidget   *show_toolbar_button;
 
        GtkWidget   *max_chars_banner;
 
@@ -793,7 +796,9 @@ connect_signals (ModestMsgEditWindow *obj)
                          G_CALLBACK (msg_body_focus), obj);
        g_signal_connect (G_OBJECT (priv->msg_body), "size-request",
                          G_CALLBACK (body_size_request), obj);
-       g_signal_connect (G_OBJECT (obj), "set-focus", G_CALLBACK (window_focus), obj);
+       if (GTK_IS_WINDOW (obj)) {
+               g_signal_connect (G_OBJECT (obj), "set-focus", G_CALLBACK (window_focus), obj);
+       }
        g_signal_connect (G_OBJECT (modest_recpt_editor_get_buffer (MODEST_RECPT_EDITOR (priv->to_field))),
                          "changed", G_CALLBACK (recpt_field_changed), obj);
        g_signal_connect (G_OBJECT (modest_recpt_editor_get_buffer (MODEST_RECPT_EDITOR (priv->cc_field))),
@@ -1581,12 +1586,12 @@ modest_msg_edit_window_setup_toolbar (ModestMsgEditWindow *window)
        gint size_index;
        gint font_index;
        GtkWidget *sizes_menu;
-       GtkWidget *fonts_menu;
        gchar *markup;
        GtkWidget *arrow;
        GtkWidget *hbox;
 #ifndef MODEST_TOOLKIT_HILDON2
        GSList *radio_group, *node;
+       GtkWidget *fonts_menu;
 #endif
 
        /* Toolbar */
@@ -1760,6 +1765,9 @@ modest_msg_edit_window_setup_toolbar (ModestMsgEditWindow *window)
        tool_item = gtk_ui_manager_get_widget (parent_priv->ui_manager, "/ToolBar/ActionsItalics");
        gtk_tool_item_set_expand (GTK_TOOL_ITEM (tool_item), TRUE);
        gtk_tool_item_set_homogeneous (GTK_TOOL_ITEM (tool_item), TRUE);
+       tool_item = gtk_ui_manager_get_widget (parent_priv->ui_manager, "/ToolBar/ActionsInsertImage");
+       gtk_tool_item_set_expand (GTK_TOOL_ITEM (tool_item), TRUE);
+       gtk_tool_item_set_homogeneous (GTK_TOOL_ITEM (tool_item), TRUE);
 
        /* Explicitelly show all the toolbar (a normal gtk_widget_show
           will not show the tool items added to the placeholders) */
@@ -1767,7 +1775,7 @@ modest_msg_edit_window_setup_toolbar (ModestMsgEditWindow *window)
 
        /* Set the no show all *after* showing all items. We do not
           want the toolbar to be shown with a show all because it
-          could go agains the gconf setting regarding showing or not
+          could go against the gconf setting regarding showing or not
           the toolbar of the editor window */
        gtk_widget_set_no_show_all (parent_priv->toolbar, TRUE);
 }
@@ -2116,11 +2124,15 @@ modest_msg_edit_window_set_format (ModestMsgEditWindow *self,
        case MODEST_MSG_EDIT_FORMAT_HTML:
                wp_text_buffer_enable_rich_text (WP_TEXT_BUFFER (priv->text_buffer), TRUE);
                update_signature (self, priv->last_from_account, priv->last_from_account);
-               if (parent_priv->toolbar) gtk_widget_show (parent_priv->toolbar);
+               if (parent_priv->toolbar) 
+                       on_show_toolbar_button_toggled (priv->show_toolbar_button,
+                                                       MODEST_MSG_EDIT_WINDOW (self));
                break;
        case MODEST_MSG_EDIT_FORMAT_TEXT:
                wp_text_buffer_enable_rich_text (WP_TEXT_BUFFER (priv->text_buffer), FALSE);
-               if (parent_priv->toolbar) gtk_widget_hide (parent_priv->toolbar);
+               if (parent_priv->toolbar) 
+                       on_show_toolbar_button_toggled (priv->show_toolbar_button,
+                                                       MODEST_MSG_EDIT_WINDOW (self));
                break;
        default:
                g_return_if_reached ();
@@ -3164,6 +3176,10 @@ modest_msg_edit_window_show_toolbar (ModestWindow *self,
        } else {
                gtk_widget_hide (GTK_WIDGET (parent_priv->toolbar));
        }
+       modest_conf_set_bool(modest_runtime_get_conf(), MODEST_CONF_EDIT_WINDOW_SHOW_TOOLBAR, show_toolbar, NULL);
+       if (modest_togglable_get_active (priv->show_toolbar_button) != show_toolbar) {
+               modest_togglable_set_active (priv->show_toolbar_button, show_toolbar);
+       }
 }
 
 void
@@ -3247,7 +3263,8 @@ modest_msg_edit_window_set_file_format (ModestMsgEditWindow *window,
                        remove_tags (WP_TEXT_BUFFER (priv->text_buffer));
                        update_signature (window, priv->last_from_account, priv->last_from_account);
                        if (parent_priv->toolbar)
-                               gtk_widget_show (parent_priv->toolbar);
+                               on_show_toolbar_button_toggled (priv->show_toolbar_button,
+                                                               MODEST_MSG_EDIT_WINDOW (window));
                        break;
                case MODEST_FILE_FORMAT_PLAIN_TEXT:
                {
@@ -3256,7 +3273,8 @@ modest_msg_edit_window_set_file_format (ModestMsgEditWindow *window,
                        if (response == GTK_RESPONSE_OK) {
                                wp_text_buffer_enable_rich_text (WP_TEXT_BUFFER (priv->text_buffer), FALSE);
                                if (parent_priv->toolbar)
-                                       gtk_widget_hide (parent_priv->toolbar);
+                                       on_show_toolbar_button_toggled (priv->show_toolbar_button,
+                                                                       MODEST_MSG_EDIT_WINDOW (window));
                        } else {
                                GtkToggleAction *action = GTK_TOGGLE_ACTION (gtk_ui_manager_get_action (parent_priv->ui_manager, "/MenuBar/FormatMenu/FileFormatFormattedTextMenu"));
                                modest_utils_toggle_action_set_active_block_notify (action, TRUE);
@@ -3428,10 +3446,8 @@ modest_msg_edit_window_undo (ModestMsgEditWindow *window)
        is_rich_text = wp_text_buffer_is_rich_text (WP_TEXT_BUFFER (priv->text_buffer));
 
        if (parent_priv->toolbar && was_rich_text != is_rich_text) {
-               if (is_rich_text)
-                       gtk_widget_show (parent_priv->toolbar);
-               else
-                       gtk_widget_hide (parent_priv->toolbar);
+               on_show_toolbar_button_toggled (priv->show_toolbar_button,
+                                               MODEST_MSG_EDIT_WINDOW (window));
        }
 
        modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (window));
@@ -3620,14 +3636,18 @@ modest_msg_edit_window_check_names (ModestMsgEditWindow *window, gboolean add_to
 {
        ModestMsgEditWindowPrivate *priv = NULL;
        GSList *address_list = NULL;
+       gboolean no_to, no_cc, no_bcc;
 
        g_return_val_if_fail (MODEST_IS_MSG_EDIT_WINDOW (window), FALSE);
        priv = MODEST_MSG_EDIT_WINDOW_GET_PRIVATE (window);
 
        /* check if there's no recipient added */
-       if ((gtk_text_buffer_get_char_count (modest_recpt_editor_get_buffer (MODEST_RECPT_EDITOR (priv->to_field))) == 0) &&
-           (gtk_text_buffer_get_char_count (modest_recpt_editor_get_buffer (MODEST_RECPT_EDITOR (priv->cc_field))) == 0) &&
-           (gtk_text_buffer_get_char_count (modest_recpt_editor_get_buffer (MODEST_RECPT_EDITOR (priv->bcc_field))) == 0)) {
+       no_to = modest_text_utils_no_recipient (modest_recpt_editor_get_buffer (MODEST_RECPT_EDITOR (priv->to_field)));
+       no_cc = modest_text_utils_no_recipient (modest_recpt_editor_get_buffer (MODEST_RECPT_EDITOR (priv->cc_field)));
+       no_bcc = modest_text_utils_no_recipient (modest_recpt_editor_get_buffer (MODEST_RECPT_EDITOR (priv->bcc_field)));
+
+
+       if (no_to && no_cc && no_bcc) {
                /* no recipient contents, then select contacts */
                modest_msg_edit_window_open_addressbook (window, NULL);
                return FALSE;
@@ -3635,19 +3655,19 @@ modest_msg_edit_window_check_names (ModestMsgEditWindow *window, gboolean add_to
 
        /* Check names */
        g_object_ref (window);
-       if (!modest_address_book_check_names (MODEST_RECPT_EDITOR (priv->to_field),
+       if (!no_to && !modest_address_book_check_names (MODEST_RECPT_EDITOR (priv->to_field),
                                              (add_to_addressbook) ? &address_list : NULL)) {
                modest_recpt_editor_grab_focus (MODEST_RECPT_EDITOR (priv->to_field));
                g_object_unref (window);
                return FALSE;
        }
-       if (!modest_address_book_check_names (MODEST_RECPT_EDITOR (priv->cc_field),
+       if (!no_cc && !modest_address_book_check_names (MODEST_RECPT_EDITOR (priv->cc_field),
                                              (add_to_addressbook) ? &address_list : NULL)) {
                modest_recpt_editor_grab_focus (MODEST_RECPT_EDITOR (priv->cc_field));
                g_object_unref (window);
                return FALSE;
        }
-       if (!modest_address_book_check_names (MODEST_RECPT_EDITOR (priv->bcc_field),
+       if (!no_bcc && !modest_address_book_check_names (MODEST_RECPT_EDITOR (priv->bcc_field),
                                              (add_to_addressbook) ? &address_list : NULL)) {
                modest_recpt_editor_grab_focus (MODEST_RECPT_EDITOR (priv->bcc_field));
                g_object_unref (window);
@@ -4610,6 +4630,16 @@ on_message_settings (GtkAction *action,
 }
 
 static void
+on_show_toolbar_button_toggled (GtkWidget *button,
+                               ModestMsgEditWindow *window)
+{
+       g_return_if_fail (MODEST_MSG_EDIT_WINDOW (window));
+
+       modest_msg_edit_window_show_toolbar (MODEST_WINDOW (window),
+                                            modest_togglable_get_active (button));
+}
+
+static void
 on_cc_button_toggled (GtkWidget *button,
                      ModestMsgEditWindow *window)
 {
@@ -4683,6 +4713,17 @@ setup_menu (ModestMsgEditWindow *self)
        modest_window_add_to_menu (MODEST_WINDOW (self), _("mcen_me_viewer_find"), "<Ctrl>f",
                                   MODEST_WINDOW_MENU_CALLBACK (modest_ui_actions_on_toggle_find_in_page),
                                   NULL);
+
+       priv->show_toolbar_button = modest_toolkit_factory_create_check_menu (modest_runtime_get_toolkit_factory (),
+                                                                             _("mcen_bd_show_toolbar"));
+       modest_togglable_set_active (priv->show_toolbar_button,
+                                    FALSE);
+       modest_window_add_item_to_menu (MODEST_WINDOW (self), priv->show_toolbar_button, 
+                                       MODEST_DIMMING_CALLBACK (modest_ui_dimming_rules_on_editor_show_toolbar));
+       gtk_widget_show (priv->show_toolbar_button);
+       g_signal_connect (G_OBJECT (priv->show_toolbar_button), "toggled",
+                         G_CALLBACK (on_show_toolbar_button_toggled), (gpointer) self);
+
 }
 
 static void