Jose Dapena Paz [Thu, 26 Jul 2007 07:52:11 +0000 (07:52 +0000)]
* src/modest-mail-operation.c:
* (modest_mail_operation_cancel): a mail operation without an
account is a not expected status, so we show a warning for
this.
pmo-trunk-r2799
Murray Cumming [Thu, 26 Jul 2007 07:33:06 +0000 (07:33 +0000)]
2007-07-26 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.h:
* src/modest-ui-actions.c: Added
modest_do_refresh_current_folder() containing some code from
modest_ui_actions_on_send_receive().
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
Call modest_do_refresh_current_folder() before refreshing the
requested account, as in modest_ui_actions_on_send_receive().
This is strange, but seems to be necessary to show new mails.
Now new emails are finally visible in the UI when downloaded
via the automatic update interval, fixing bug NB#57458.
This also works because bug NB#57458 has been fixed somehow.
pmo-trunk-r2798
Murray Cumming [Thu, 26 Jul 2007 06:43:26 +0000 (06:43 +0000)]
Update the ChangeLog: This fixes projects.maemo.org bug
NB#64225.
pmo-trunk-r2797
Murray Cumming [Thu, 26 Jul 2007 06:42:47 +0000 (06:42 +0000)]
2007-07-26 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
printf more details when we get unhandled D-Bus methods, because
it is interesting.
* src/modest-mail-operation.c: (update_account_thread):
Comment out the tny_camel_pop_store_account_reconnect(), because this
is apparently no longer needed, and it did not work before anyway.
See the comment in the code.
* src/modest-search.c: (modest_search_folder): Ignore deleted emails,
by checking the header flags.
pmo-trunk-r2796
Dirk-Jan C. Binnema [Wed, 25 Jul 2007 16:03:50 +0000 (16:03 +0000)]
* make the memory card Archive folder a localized one,
make sure the folder rules understand it's a special folder
pmo-trunk-r2795
Dirk-Jan C. Binnema [Wed, 25 Jul 2007 15:15:30 +0000 (15:15 +0000)]
* add new addresses to the addressbook automatically when sending.
fixes major bug NB#63631
pmo-trunk-r2794
Dirk-Jan C. Binnema [Wed, 25 Jul 2007 12:44:59 +0000 (12:44 +0000)]
* inliner. save the bcc field as wel. Fixes major bug NB#64120
pmo-trunk-r2793
Murray Cumming [Wed, 25 Jul 2007 12:34:45 +0000 (12:34 +0000)]
2007-07-25 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-maemo-utils.h:
* src/maemo/modest-maemo-utils.c: Added
modest_maemo_show_information_note_in_main_context_and_forget().
* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Use the new function to show simple error dialogs in the main
context, though question dialogs are still in the current context,
which is unfortunately usually not the main context. This should
fix some hangs.
pmo-trunk-r2792
Dirk-Jan C. Binnema [Wed, 25 Jul 2007 12:20:42 +0000 (12:20 +0000)]
* don't do a regexp-search when doing search-in-page.
this actually fixes #64261 when searching for "\", and
the not-yet-discovered bug that we were doing regexp searches.
the crashing bug is actually in gtkhtml, will move the bug
there.
pmo-trunk-r2791
Murray Cumming [Wed, 25 Jul 2007 11:37:37 +0000 (11:37 +0000)]
2007-07-25 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (get_password):
Never save the entered username and password in gconf,
because the UI spec says we should not. This helps
slightly with projects.maemo.org bug NB#63671.
pmo-trunk-r2790
Murray Cumming [Wed, 25 Jul 2007 09:52:49 +0000 (09:52 +0000)]
2007-07-25 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-msg-edit-window.h:
* src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
Moved some code here to make it simpler.
(modest_msg_edit_window_attach_file_one): Renamed from
modest_msg_edit_window_attach_file_interactive().
(modest_msg_edit_window_offer_attach_file): Renamed from
modest_msg_edit_window_attach_file() and used
modest_msg_edit_window_attach_file_one() instead of
copy/pasting the code. The old code for one was not using
GnomeVFS. This allows use of smb:// URLs when using send-as
from external applications, fixing bug NB#63741.
(modest_msg_edit_window_insert_image),
(modest_msg_edit_window_add_attachment_clicked):
* src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
Adapted to the new function names.
pmo-trunk-r2789
Murray Cumming [Wed, 25 Jul 2007 08:58:32 +0000 (08:58 +0000)]
2007-07-25 Murray Cumming <murrayc@murrayc.com>
(modest_platform_set_update_interval): Set the alarm recurrence
fields so that auto-update does not just happen the first time.
This should have fixed projects.maemo.org bug NB#63938.
When this happens you can see a printf when the D-Bus method is
called:
GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
However, I do not actually seem to get new POP messages even when
clicking the refresh button manually. A restart gets them.
This might be a problem in today's tinymail only.
pmo-trunk-r2788
Murray Cumming [Tue, 24 Jul 2007 16:54:32 +0000 (16:54 +0000)]
2007-07-24 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-maemo-global-settings-dialog.c:
(current_connection):
Avoid a crash (probably only in scratchbox) when strcmp()ing a
NULL when closing the dialog.
pmo-trunk-r2787
Dirk-Jan C. Binnema [Tue, 24 Jul 2007 13:17:33 +0000 (13:17 +0000)]
Added fixes made on 24 july.
pmo-trunk-r2786
Dirk-Jan C. Binnema [Tue, 24 Jul 2007 10:06:10 +0000 (10:06 +0000)]
* let modest_platform_get_file_icon_name accept files with NULL
filenames as well. this should fix some icon / Criticals-issues.
pmo-trunk-r2784
Murray Cumming [Tue, 24 Jul 2007 09:49:17 +0000 (09:49 +0000)]
2007-07-24 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
Remove the hacky send/receive that didn't work, and instead
refilter the treemodel to make the deleted email really vanish from
the UI (though the delete-from-menu code does has commented out
the code that does that). This fixes projects.maemo.org bug
NB#62859.
pmo-trunk-r2783
Murray Cumming [Tue, 24 Jul 2007 09:07:54 +0000 (09:07 +0000)]
2007-07-24 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
Try a couple of tricks to force the treeview to update (
poke the folder, and do a send/receive refresh), but the deleted
email still appears with a strike-through instead of really being
removed.
pmo-trunk-r2782
Sergio Villar Senin [Tue, 24 Jul 2007 08:06:54 +0000 (08:06 +0000)]
* Fixes NB#58923, an information banner is shown when trying to create/rename a folder with an empty string
pmo-trunk-r2780
Sergio Villar Senin [Mon, 23 Jul 2007 19:45:40 +0000 (19:45 +0000)]
* Fixes NB#60774, the logical id was deleted in version 1.1 of the specs
pmo-trunk-r2779
Sergio Villar Senin [Mon, 23 Jul 2007 18:57:00 +0000 (18:57 +0000)]
* Reverting some of the changes of commit 2431 because they're no longer valid since 2521
pmo-trunk-r2778
Murray Cumming [Mon, 23 Jul 2007 18:18:25 +0000 (18:18 +0000)]
2007-07-23 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c:
(add_single_folder_to_list): Ignore TnyMergeFolder folders,
because their ID is not human-readable (see the comment about
improvements needed to the osso-email-interface API) and
TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
pmo-trunk-r2777
Murray Cumming [Mon, 23 Jul 2007 17:29:29 +0000 (17:29 +0000)]
2007-07-23 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
(add_folders_to_list), (on_dbus_method_get_folders),
(modest_dbus_req_filter):
* src/maemo/modest-maemo-utils.c:
(on_camel_account_get_supported_secure_authentication):
* src/maemo/modest-main-window.c: (modest_main_window_set_style),
(on_header_view_focus_in):
* src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
* src/modest-formatter.c: (modest_formatter_create_body_part):
* src/modest-mail-operation.c: (recurse_folders),
(update_account_thread), (get_msgs_full_thread),
(modest_mail_operation_get_msgs_full),
(modest_mail_operation_xfer_msgs):
* src/modest-search.c: (search_mime_part_and_child_parts),
(modest_search_account), (modest_search_all_accounts):
* src/modest-tny-account.c:
(modest_tny_account_get_special_folder), (recurse_folders):
* src/modest-tny-local-folders-account.c:
(modest_tny_local_folders_account_query_passes):
* src/modest-tny-msg.c: (copy_mime_part),
(modest_tny_msg_find_body_part_from_mime_part):
* src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
(modest_tny_send_queue_try_to_send):
* src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
(_modest_ui_actions_open), (download_uncached_messages),
(reply_forward), (modest_ui_actions_on_copy),
(modest_ui_actions_on_details), (has_retrieved_msgs),
(msgs_move_to_confirmation), (open_msg_for_purge_cb),
(do_headers_action):
* src/modest-ui-dimming-rules.c: (_already_opened_msg),
(_selected_msg_marked_as), (_msg_download_completed),
(_selected_msg_sent_in_progress):
* src/widgets/modest-attachments-view.c:
(modest_attachments_view_set_message):
* src/widgets/modest-msg-view.c: (find_cid_image):
* tests/check_folder-transfer.c: (find_folders):
* tests/check_update-account.c: (func):
* tests/dbus_api/test_get_folders.c: (main):
Checked all uses of tny_iterator_get_current(), making sure
that the object is unreferenced (3 or 4 places did not),
and adding checks for NULL.
pmo-trunk-r2776
Sergio Villar Senin [Mon, 23 Jul 2007 17:06:20 +0000 (17:06 +0000)]
* Update the next_row_reference if it was invalidated previously
* Fixes NB#63349, the viewer moves to the next message even if the old following one was deleted
pmo-trunk-r2775
Sergio Villar Senin [Mon, 23 Jul 2007 16:38:03 +0000 (16:38 +0000)]
* ModestAccountMgr: the account manager is just a facade to the configuration system, so it should
not know TnyAccounts only ModestAccounts. TnyAccounts are managed by the TnyAccountStore
- removed the server_account parametter from the account_removed signal
- removed the server_account parametter from the remove_account method
- Changed the signature of the methods that handled the signal
- completetly rewritten the account removal code
* ModestTnyAccountStore
- now it issues a account_removed for both the store and the transport account
- completety rewritten the get_server_account method, it makes no sense to use the account mgr, because we h
ave the accounts
* ModestFolderView
- added a missing check
- added a missing select inbox
- added a condition to the filter_row method, do not take into account the visible_account_id if we aren't in SHOW_ONE style
pmo-trunk-r2774
Murray Cumming [Mon, 23 Jul 2007 14:52:44 +0000 (14:52 +0000)]
2007-07-23 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c:
(on_idle_open_default_inbox): Make sure that the application UI is
visible.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(on_entry_invalid_character): Show the word whitespace instead
of (null) in the banner when whitespace was entered.
(show_error): Add a comment that this does not work in
Maemo Bora, though we do not know why.
pmo-trunk-r2773
Dirk-Jan C. Binnema [Mon, 23 Jul 2007 13:09:48 +0000 (13:09 +0000)]
s/__FUNCTION/__FUNCTION__/
pmo-trunk-r2772
Dirk-Jan C. Binnema [Mon, 23 Jul 2007 12:51:32 +0000 (12:51 +0000)]
Added new fixes to changelog - week 30.
pmo-trunk-r2771
Murray Cumming [Mon, 23 Jul 2007 12:07:22 +0000 (12:07 +0000)]
2007-07-23 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account.c:
(modest_tny_account_get_special_folder): Use an if instead of
an assert for when the parent account name is NULL, because this
might be causing a crash in projects.maemo.org bug 63192.
* src/modest-mail-operation.c:
(modest_mail_operation_send_new_mail_cb),
(modest_mail_operation_remove_folder): unref the folder that is
returned from modest_tny_account_get_special_folder().
pmo-trunk-r2770
Murray Cumming [Mon, 23 Jul 2007 11:43:49 +0000 (11:43 +0000)]
Added a comment.
pmo-trunk-r2769
Sergio Villar Senin [Mon, 23 Jul 2007 10:18:00 +0000 (10:18 +0000)]
* Reverted some changes from one of the latest armin's commits. We can never call gtk_widget_destroy over a window, we need to do all the window management always through the window manager
pmo-trunk-r2768
Murray Cumming [Mon, 23 Jul 2007 08:53:45 +0000 (08:53 +0000)]
2007-07-23 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c:
(modest_ui_actions_on_password_requested):
Show mail_ib_login_cancelled info banner when the user cancels
the protected password dialog, to fix projects.maemo.org
bug NB#63617.
pmo-trunk-r2767
Murray Cumming [Mon, 23 Jul 2007 08:18:21 +0000 (08:18 +0000)]
2007-07-23 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-settings-dialog.c:
(create_page_outgoing): Put this page in a GtkScrolledWindow,
matching the UI mock-up in the UI spec, and allowing access
to all widgets even when the on-screen keyboard is active.
pmo-trunk-r2766
Murray Cumming [Mon, 23 Jul 2007 08:04:12 +0000 (08:04 +0000)]
2007-07-16 Murray Cumming <murrayc@murrayc.com>
Reverted this previous commit from Johannes,
because the scrollbars are always visible and because
I think we only need it on onepage of the account
settings, not the account wizard.
(I wrote the wrong instructions in the bug.)
* src/maemo/easysetup/modest-easysetup-wizard.c:
Added scrollbars to account wizard dialog.
Fixed projects.maemo.org NB #62744
pmo-trunk-r2765
Johannes Schmid [Sun, 22 Jul 2007 14:48:44 +0000 (14:48 +0000)]
2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_user_details):
Use auto-cap for name (projects.maemo.org NB#63716)
* src/widgets/modest-account-view.c: (on_account_busy_changed):
pmo-trunk-r2764
Armin Burgmeier [Sun, 22 Jul 2007 13:17:17 +0000 (13:17 +0000)]
2007-07-22 Armin Burgmeier <armin@openismus.com>
* src/maemo/modest-ui-actions.c: Use current account instead of
default account for creating viewer windows, so that the viewer
window knows to which account the viewed message belongs.
* src/maemo/modest-msg-view-window.c: Destroy the window when the
corresponding account is deleted. This fixes projects.maemo.org bug
pmo-trunk-r2763
Jose Dapena Paz [Fri, 20 Jul 2007 16:52:01 +0000 (16:52 +0000)]
* src/modest-ui-actions.c:
* If there's no header view, then proper information banner
"nothing to sort" is shown.
* src/modest-ui-dimming-rules.c:
* Dim sort action if folder is empty. IN toolbar we show the
corresponding information banner (fixes NB#60446).
pmo-trunk-r2762
Jose Dapena Paz [Fri, 20 Jul 2007 09:48:31 +0000 (09:48 +0000)]
* src/maemo/modest-maemo-utils.[ch]:
* New method modest_maemo_gtk_toggle_action_set_active_block_notify
that disables handlers on changing the current status of a
toggle action. This was duplicated in msg view and editor, so
it's been refactored to make them share the implementation.
Using this in msg edit implementation change is pending on
other changes in wpeditor.
* src/maemo/modest-msg-view-window.c:
* Now we use the new modest-maemo-utils refactored toggle action
notify block method.
pmo-trunk-r2761
Jose Dapena Paz [Thu, 19 Jul 2007 21:44:28 +0000 (21:44 +0000)]
Some improvements on the header view layout. It puts finally the
priority icon in its place
* src/maemo/modest-icon-names.h:
* Added standard high and low priority icons, to be used
from the custom icon renderers in thumbable headers.
* src/widgets/modest-header-view-render.c:
* Use the proper icons for high and low priority, instead
of the old composed ones used for the shared priority and
attachments cell renderer (fixes NB#62262).
* src/widgets/modest-header-view.c:
* Some other layout fixes in compact header view.
pmo-trunk-r2760
Jose Dapena Paz [Thu, 19 Jul 2007 19:47:25 +0000 (19:47 +0000)]
* src/widgets/modest-recpt-view.c:
* Now we accept a small threshold (32 pixels) in press/release
cycles, to prevent when the click is done with a small
movement (as it can happen in maemo touchscreen)
(fixes NB#60728).
pmo-trunk-r2759
Jose Dapena Paz [Thu, 19 Jul 2007 17:36:12 +0000 (17:36 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now we show properly the find toolbar, as we attach it
using hildon_window_add_toolbar API. This partially fixes
(NB#63201) as this only fixes toolbar in view.
pmo-trunk-r2758
Jose Dapena Paz [Thu, 19 Jul 2007 17:20:10 +0000 (17:20 +0000)]
* src/widgets/modest-recpt-editor.c:
* Now we discard invalid chars (bullets and images) on pasting
in recipient editor. This way, if we paste from the editor
these symbols, they should be removed from text pasted in
the recipient editor (fixes NB#62575).
pmo-trunk-r2757
Jose Dapena Paz [Thu, 19 Jul 2007 16:39:42 +0000 (16:39 +0000)]
* src/widgets/modest-msg-view.c:
* Added implementation of get_message_is_empty method. It uses
gtk_html_export method to know if the buffer has any text
representation and this is empty or not.
* src/maemo/modest-msg-view-window.c:
* Removed check for empty buffer to show "nothing to find"
banner on toggling the toolbar. This should be shown on trying
to search in the toolbar, not on trying to show the toolbar.
* Added the nothing to find banner on searching empty buffers,
using the new implementation. This is a partial fix to
NB#62350.
pmo-trunk-r2756
Jose Dapena Paz [Thu, 19 Jul 2007 15:15:09 +0000 (15:15 +0000)]
* src/modest-formatter.c:
* Add an unref to avoid leaking a reference.
pmo-trunk-r2755
Jose Dapena Paz [Thu, 19 Jul 2007 15:13:51 +0000 (15:13 +0000)]
* src/modest-ui-actions.c:
* (folder_refreshed_cb): Now I check if the folder refreshed
message corresponds to the currently selected folder in
header view. This should prevent showing the empty folder
message for a populated folder when other folder request
finishes later.
pmo-trunk-r2754
Jose Dapena Paz [Thu, 19 Jul 2007 15:10:23 +0000 (15:10 +0000)]
* src/modest-tny-msg.c:
* Now we simplify the way we copy mime parts when the mime part
is an attachment. This, with a pending patch in tinymail,
should fix NB#61280.
pmo-trunk-r2753
Armin Burgmeier [Wed, 18 Jul 2007 15:52:17 +0000 (15:52 +0000)]
2007-07-18 Armin Burgmeier <armin@openismus.com>
* src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
the dialog close after entering an invalid port number and clicking
OK. This fixes projects.maemo.org bug NB#63602.
pmo-trunk-r2752
Armin Burgmeier [Wed, 18 Jul 2007 13:49:22 +0000 (13:49 +0000)]
2007-07-18 Armin Burgmeier <armin@openismus.com>
* src/modest-tny-account-store.c:
(get_server_accounts): Set parent modest account name for each
connection-specific transport account so that special folders of such
an account can be looked up. This fixes a crash when changing account
settings. This might also be related to projects.maemo.org bug
NB#63594.
pmo-trunk-r2751
Jose Dapena Paz [Tue, 17 Jul 2007 16:19:16 +0000 (16:19 +0000)]
* src/modest-ui-dimming-rules.c:
* Use the proper domain for "unable to delete" information
banner (fixes NB#63494).
pmo-trunk-r2750
Jose Dapena Paz [Tue, 17 Jul 2007 15:51:27 +0000 (15:51 +0000)]
* src/modest-mail-operation.c:
* Now it checks if there's no account already, and then cancel cannot
be run. Avoids a crash.
pmo-trunk-r2749
Dirk-Jan C. Binnema [Tue, 17 Jul 2007 14:07:44 +0000 (14:07 +0000)]
Changed the changelog to build for week 29.
pmo-trunk-r2748
Dirk-Jan C. Binnema [Tue, 17 Jul 2007 13:10:08 +0000 (13:10 +0000)]
Updated the resolved fixed bugs into changelog for week 29.
pmo-trunk-r2747
Armin Burgmeier [Mon, 16 Jul 2007 18:50:23 +0000 (18:50 +0000)]
2007-07-16 Armin Burgmeier <armin@openismus.com>
* src/modest-ui-actions.c: Added a button to create a folder to the
move-to dialog. This fixes projects.maemo.org bug NB#.
pmo-trunk-r2745
Johannes Schmid [Mon, 16 Jul 2007 17:18:44 +0000 (17:18 +0000)]
fixed Changelog...
pmo-trunk-r2744
Johannes Schmid [Mon, 16 Jul 2007 17:17:13 +0000 (17:17 +0000)]
2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
Added scrollbars to account wizard dialog.
Fixed projects.maemo.org NB #6274
pmo-trunk-r2743
Murray Cumming [Mon, 16 Jul 2007 12:15:00 +0000 (12:15 +0000)]
2007-07-16 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-msg-view.h:
* src/widgets/modest-msg-view.c:
Added modest_msg_view_get_message_is_empty() but this needs
to be implemented.
* src/maemo/modest-msg-edit-window.c: (message_is_empty):
Check if there is any text in the message yet.
But this needs to be implemented properly.
(modest_msg_edit_window_toggle_find_toolbar):
* src/maemo/modest-msg-view-window.c:
(modest_msg_view_window_toggle_find_toolbar):
Show a banner warning if there is no text to search, when
trying to start a search. This partially fixes
projects.maemo.org bug NB#62350.
pmo-trunk-r2742
Jose Dapena Paz [Mon, 16 Jul 2007 09:08:01 +0000 (09:08 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now we use GtkTreePath's instead of iterators
for message_reader function. This should be more
reliable against model changes that change the
stamp available for iterators, and avoid a crash
then (fixes NB#63270).
pmo-trunk-r2740
Sergio Villar Senin [Fri, 13 Jul 2007 19:23:42 +0000 (19:23 +0000)]
* Fixes NB#63080, size=0 is also translated by modest text utils
pmo-trunk-r2738
Murray Cumming [Fri, 13 Jul 2007 18:10:39 +0000 (18:10 +0000)]
2007-07-13 Murray Cumming <murrayc@murrayc.com>
* src/modest-mail-operation.c: (update_account_thread):
Initialized num_new_headers to fix the build.
pmo-trunk-r2737
Murray Cumming [Fri, 13 Jul 2007 17:31:13 +0000 (17:31 +0000)]
2007-07-13 MMurray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr.c: (modest_account_mgr_account_names):
Ignore modest accounts whose server accounts don't exist in gconf.
This prevents us trying to create TnyAccount instances for those
server accounts when the server account has been removed from gconf,
but the parent modest account has not yet been removed from modest.
I don't know why this is only noticeable now. It was probably just
a harmeless g_warning() anyway.
pmo-trunk-r2736
Sergio Villar Senin [Fri, 13 Jul 2007 17:05:36 +0000 (17:05 +0000)]
* Added the operation cancel_all_operations to the progress objects
* The cancel button now invokes the cancel_all operation
* Fixed modest_mail_operation cancel, now it really calls tny_account_cancel
* Removed the ugly did_a_cancel static boolean in the mail operations
* Fixed a leak with the new headers received when doing a send&receive
* Fixes NB#62946, several clicks on cancel do not make the application crash when S&R
* Fixed the new_headers count that was returned by the update_account_thread, it was wrong and was returning always 0 because the new_headers were freed before
pmo-trunk-r2735
Dirk-Jan C. Binnema [Fri, 13 Jul 2007 14:20:25 +0000 (14:20 +0000)]
Added all the bugs in resolved fixed status.
pmo-trunk-r2734
Murray Cumming [Fri, 13 Jul 2007 09:15:50 +0000 (09:15 +0000)]
2007-07-13 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
pmo-trunk-r2733
Sergio Villar Senin [Fri, 13 Jul 2007 07:39:54 +0000 (07:39 +0000)]
* Wrap all the signal emissions with gdk_threads_* stuff, we need to ensure that only one thread enter Gtk+ at the same time
pmo-trunk-r2732
Armin Burgmeier [Thu, 12 Jul 2007 17:03:45 +0000 (17:03 +0000)]
2007-07-12 Armin Burgmeier <armin@openismus.com>
* src/maemo/modest-main-window.c: Make default account appear bold
in view, tools/send & receive and toolbar/send & receive SCM menus.
This fixes projects.maemo.org bug NB#59010.
pmo-trunk-r2731
Murray Cumming [Thu, 12 Jul 2007 15:00:58 +0000 (15:00 +0000)]
2007-07-12 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
Add a short-cut, by checking if the folder store is an account.
This ensures that the Sort menu item and toolbar is dimmed for
the local-folders account root item, fixing
projects.maemo.org bug NB#62545.
pmo-trunk-r2730
Murray Cumming [Thu, 12 Jul 2007 14:25:33 +0000 (14:25 +0000)]
2007-07-12 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (get_password):
Show the password dialog (via the signal) only in the mainloop, via
an idle handler that we wait for. This could theoretically prevent
hangs, though I worry that it could introduce some too.
pmo-trunk-r2729
Sergio Villar Senin [Thu, 12 Jul 2007 14:22:11 +0000 (14:22 +0000)]
* Added support to get_folders call in the local folder account to filter by query
* Removed get_folders_async from the local folder account because it makes no sense to redefine it to just call the parent
* Redefined the create_folder method in the local folder account in order not to allow to create folders with the same name than the extra folders
* Removed some invalid string comparisons in the guess_folder_type_from_name
* Now Modest do not allow to create a folder called outbox, nor to move another one with that name to the local folders account
pmo-trunk-r2728
Murray Cumming [Thu, 12 Jul 2007 14:00:57 +0000 (14:00 +0000)]
2007-07-12 Murray Cumming <murrayc@murrayc.com>
* src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
* src/maemo/modest-platform.c:
(modest_platform_connect_and_wait):
Take a TnyAccount* parameter and try to set it to online
(a TnyCamel-only API), because tinymail sets accounts to offline
when the user cancels a password dialog, and doesn't ask again until
it has been set to online.
However, this is commented out because it causes a hang now.
(modest_platform_connect_and_wait_if_network_account):
* src/modest-mail-operation.c:
(modest_mail_operation_update_account):
* src/modest-platform.h:
* src/modest-ui-actions.c: (_modest_ui_actions_open),
(download_uncached_messages), (modest_ui_actions_on_send): Adapted.
pmo-trunk-r2727
Armin Burgmeier [Thu, 12 Jul 2007 13:20:03 +0000 (13:20 +0000)]
2007-07-12 Armin Burgmeier <armin@openismus.com>
* src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
* src/modest-mail-operation.c:
* src/modest-ui-actions.c: Check for already existing folder before
querying the server, show error message from camel if the request
still fails. This fixes projects.maemo.org bug NB#58701.
pmo-trunk-r2726
Murray Cumming [Thu, 12 Jul 2007 13:02:57 +0000 (13:02 +0000)]
2007-07-12 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.h:
* src/modest-tny-account-store.c:
Added modest_tny_account_store_forget_password_in_memory(),
(get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
when creating a new account, so that new passwords will be used, instead of
us thinking that it's a second request as a result of a failed password again.
pmo-trunk-r2725
Philip Van Hoof [Thu, 12 Jul 2007 12:15:10 +0000 (12:15 +0000)]
Unselecting when a rename or a delete should happen
pmo-trunk-r2724
Sergio Villar Senin [Thu, 12 Jul 2007 11:16:36 +0000 (11:16 +0000)]
* Removed some comments
* Fixes NB#63055
* Added query capabilities to the get_folders method of our local account store
* Added the name Outbox for the local merged folder with the same name
pmo-trunk-r2723
Murray Cumming [Thu, 12 Jul 2007 09:36:00 +0000 (09:36 +0000)]
2007-07-12 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c:
(on_idle_open_message): If the message is in drafts then open it
in an edit window instead of a view window. This fixes
projects.maemo.org bug NB#63005.
pmo-trunk-r2722
Murray Cumming [Thu, 12 Jul 2007 08:14:42 +0000 (08:14 +0000)]
2007-07-12 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
Avoided a harmless g_warning().
pmo-trunk-r2721
Murray Cumming [Thu, 12 Jul 2007 08:01:11 +0000 (08:01 +0000)]
Removed a debug printf.
pmo-trunk-r2720
Murray Cumming [Thu, 12 Jul 2007 07:59:04 +0000 (07:59 +0000)]
2007-07-12 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
Pass the modest account name, not the TnyAccount display name to
modest_msg_view_window_new() so that the reply feature works,
fixing projects.maemo.org bug NB#62892.
* src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
(modest_msg_view_window_new_with_header_model):
* src/maemo/modest-msg-view-window.c:
(modest_msg_view_window_new_with_header_model),
(modest_msg_view_window_new):
* src/modest-ui-actions.c: (reply_forward):
* src/widgets/modest-msg-view-window.h:
* src/widgets/modest-window.c: (modest_window_set_active_account):
Rename an account parameter to modest_account_name to make this clearer.
2007-07-11 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.h:
* src/modest-ui-actions.c: (headers_action_delete): Moved some code into
modest_do_message_delete().
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
Call modest_do_message_delete(), hoping that this would cause messages
to be really deleted from search instead of just marked with strike through.
Does not seem to help.
pmo-trunk-r2719
Dirk-Jan C. Binnema [Thu, 12 Jul 2007 07:58:58 +0000 (07:58 +0000)]
Added the fixes made till july 12th.
pmo-trunk-r2718
Armin Burgmeier [Wed, 11 Jul 2007 18:25:49 +0000 (18:25 +0000)]
2007-07-11 Armin Burgmeier <armin@openismus.com>
* src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
priv->reselect to FALSE prior to calling
modest_folder_view_select_first_inbox_or_local() to prevent endless
recursion and thus a crash on startup.
pmo-trunk-r2717
Armin Burgmeier [Wed, 11 Jul 2007 17:31:02 +0000 (17:31 +0000)]
2007-07-11 Armin Burgmeier <armin@openismus.com>
* src/maemo/modest-account-settings-dialog.h: Include
<gtk/gtknotebook.h> to fix the build (at least for me).
* src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
Use "New FolderN" as default suggested name if "New folder" already
exists, with N being the first free number, though never exceed "New
folder99" in which case we just fall back to "New Folder" even though
it already exists. This fixes projects.maemo.org bug NB#58663.
pmo-trunk-r2716
Jose Dapena Paz [Wed, 11 Jul 2007 16:52:45 +0000 (16:52 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Reactivate the focus vadjustment
* src/widgets/modest-window.c:
* Now escape sends a delete event to msg view and editor if
they're not fullscreen (fixes NB#58618).
pmo-trunk-r2715
Murray Cumming [Wed, 11 Jul 2007 16:43:54 +0000 (16:43 +0000)]
2007-07-11 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-view-window.c: (on_new_button_clicked):
Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
projects.maemo.org bug NB#62778.
pmo-trunk-r2714
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 16:15:05 +0000 (16:15 +0000)]
* auto expand the folder list again; we need to check if this works now.
Fixes: NB#62355
pmo-trunk-r2713
Murray Cumming [Wed, 11 Jul 2007 15:58:08 +0000 (15:58 +0000)]
2007-07-11 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
Ignore the wrong (for now) secure-smtp setting in the presets -
just default to requiring secure authentication for SMTP, because
that is most common.
pmo-trunk-r2712
Jose Dapena Paz [Wed, 11 Jul 2007 15:52:47 +0000 (15:52 +0000)]
* src/modest-init.c:
* Now we set properly the default settings of the columns
and we don't set random values due to random array values
(fixes NB#62593).
pmo-trunk-r2711
Murray Cumming [Wed, 11 Jul 2007 15:33:49 +0000 (15:33 +0000)]
Added a TODO.
pmo-trunk-r2710
Jose Dapena Paz [Wed, 11 Jul 2007 15:30:34 +0000 (15:30 +0000)]
* src/modest-ui-actions.c:
* Unregister header after finishing attachment purge
(fixes NB#63007).
pmo-trunk-r2709
Sergio Villar Senin [Wed, 11 Jul 2007 15:29:19 +0000 (15:29 +0000)]
* Fixed some reference leaks
* Removed an unneeded ref/unref pair
pmo-trunk-r2708
Murray Cumming [Wed, 11 Jul 2007 15:22:41 +0000 (15:22 +0000)]
2007-07-11 Murray Cumming <murrayc@murrayc-desktop>
* src/modest-ui-actions.h:
* src/modest-ui-actions.c:
(modest_ui_actions_on_delete_message):
Move some code into a new
modest_ui_actions_refresh_message_window_after_delete()
function so we can use it from elsewhere.
* src/dbus_api/modest-dbus-callbacks.c:
(on_idle_delete_message), (on_delete_message): Used an idle
handler, as we do for the other D-Bus method handlers.
Call modest_ui_actions_refresh_message_window_after_delete()
if the deleted message was open in a window. This fixed
projects.maemo.org bug NB#62862.
pmo-trunk-r2707
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 15:20:17 +0000 (15:20 +0000)]
* logical-id fix, fixes: NB #63117
pmo-trunk-r2706
Johannes Schmid [Wed, 11 Jul 2007 15:17:45 +0000 (15:17 +0000)]
2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
* src/widgets/modest-folder-view.c: (filter_row)
Do not show drafts folder (see UI specs)
pmo-trunk-r2705
Johannes Schmid [Wed, 11 Jul 2007 15:13:16 +0000 (15:13 +0000)]
2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
* src/modest-ui-actions.c:
Remove call to show_non_move_folders(TRUE) which was moved to a wrong
place and also not necessary.
* src/widgets/modest-folder-view.c: (filter_row)
Guess folder type and hide Sent & Outbox if necessary.
Fixed project.maemo.org NB#57328
pmo-trunk-r2704
Philip Van Hoof [Wed, 11 Jul 2007 14:53:03 +0000 (14:53 +0000)]
Moving some code
pmo-trunk-r2703
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 14:47:15 +0000 (14:47 +0000)]
Added all the bugs in resolved fixed status for w28.
pmo-trunk-r2702
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 14:44:02 +0000 (14:44 +0000)]
Added all the bugs in resolved fixed status for w28.
pmo-trunk-r2701
Jose Dapena Paz [Wed, 11 Jul 2007 14:23:05 +0000 (14:23 +0000)]
* src/widgets/modest-folder-view.c:
* Removed a posible leak of a reference to folders if
folders retrieval failed.
* src/widgets/modest-header-view.c:
* Put null to some headers initial values to prevent using it
without values.
* src/modest-tny-msg.c:
* Add a reference owned by the attachments list
* src/maemo/modest-msg-view-window.c:
* We don't run the clipboard owner change handler if the
window is not visible.
pmo-trunk-r2700
Philip Van Hoof [Wed, 11 Jul 2007 14:15:11 +0000 (14:15 +0000)]
Clearing the folder before rename
pmo-trunk-r2699
Jose Dapena Paz [Wed, 11 Jul 2007 14:04:08 +0000 (14:04 +0000)]
* src/widgets/modest-header-view-render.c:
* Now we unref the header instance for outgoing folders
after using it.
pmo-trunk-r2698
Murray Cumming [Wed, 11 Jul 2007 13:34:57 +0000 (13:34 +0000)]
2007-07-11 Murray Cumming <murrayc@murrayc-desktop>
* src/modest-main.c: (main): Only show the UI at the start if
the showui command line option was given. For instance,
run-standalone src/modest showui
Otherwise, we wait for the top_application D-Bus method to
be sent by hildon-desktop when the application is selected
from the menu.
This allows us to run without a UI when osso-global-search
uses our D-Bus methods.
pmo-trunk-r2697
Jose Dapena Paz [Wed, 11 Jul 2007 12:43:35 +0000 (12:43 +0000)]
* src/modest-ui-actions.c:
* Removed annoying warning for check retrieval in message open
handler. THis was appearing everytime we cancelled a
message retrieval.
* src/modest-mail-operation.c:
* Now we notify the end of the mail operation before
unreferencing. This prevents a crash.
* Now we do a tny_account_cancel in status handler when we
get a cancel status. This way we properly cancel the
message download (and then we can try again to open the
message as expected (fixes NB#62444).
pmo-trunk-r2696
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 12:08:59 +0000 (12:08 +0000)]
* improve modest_folder_view_select_folder:
- move the cursor as well (this fixes the seemingly double selection prob
- expand the the treeview if we created an invisible subfolder
pmo-trunk-r2695