Sergio Villar Senin [Thu, 10 Jan 2008 17:57:32 +0000 (17:57 +0000)]
* Fixes regarding the position of the paneds
pmo-trunk-r4014
Sergio Villar Senin [Thu, 10 Jan 2008 15:58:04 +0000 (15:58 +0000)]
* Fixed GNOME build
pmo-trunk-r4013
Jose Dapena Paz [Thu, 10 Jan 2008 14:54:42 +0000 (14:54 +0000)]
* src/widgets/modest-folder-view.c:
* Now we select the destination folder on finishing DnD of
folders (fixes NB#78939).
* src/modest-ui-actions.c:
* (..._on_folder_display_name_changed): improve the check
for the old folder name.
pmo-trunk-r4012
Jose Dapena Paz [Thu, 10 Jan 2008 14:43:51 +0000 (14:43 +0000)]
* src/maemo/modest-platform.c:
* Removed a warning message I forgot.
pmo-trunk-r4011
Dirk-Jan C. Binnema [Thu, 10 Jan 2008 12:55:06 +0000 (12:55 +0000)]
* added release notes for next public release
pmo-trunk-r4010
Jose Dapena Paz [Thu, 10 Jan 2008 10:31:26 +0000 (10:31 +0000)]
* src/widgets/modest-window-mgr.[ch]:
* Add methods _unregister_banner and _register_banner to count
the banners that we didn't close yet. We don't emit the
window list empty event until we don't have windows AND we
don't have pending banners.
* src/maemo/modest-platform.c:
* Use window manager banner count in method
modest_platform_show_information (fixes NB#79115).
pmo-trunk-r4009
Vivek Sekar [Thu, 10 Jan 2008 10:29:11 +0000 (10:29 +0000)]
postinst calls the NEWS file to display the latest info to the user using osso-1.1
pmo-trunk-r4008
Dirk-Jan C. Binnema [Thu, 10 Jan 2008 10:22:17 +0000 (10:22 +0000)]
* improve our debug-over-dbus a bit; added methods
DumpAccounts, DumpSendQueues and DumpOperationQueue
which will dump the given thing.
it can be used from the commandline as:
dbus-send --print-reply --dest='com.nokia.modest' /com/nokia/modest com.nokia.modest.DumpSendQueues
(in sbox you'll need run-standalone.sh)
pmo-trunk-r4007
Sergio Villar Senin [Wed, 9 Jan 2008 18:31:55 +0000 (18:31 +0000)]
* Performance optimization, do not update the menus if the account that have changed or been inserted/removed is a local account (MMC or local folders) or is a transport account (no effect for application menus)
pmo-trunk-r4006
Sergio Villar Senin [Wed, 9 Jan 2008 18:25:47 +0000 (18:25 +0000)]
* Fixes NB#79140, "Close all windows" now works as expected even if some other window was opened using the D-Bus interface
pmo-trunk-r4005
Dirk-Jan C. Binnema [Wed, 9 Jan 2008 16:38:04 +0000 (16:38 +0000)]
* install the NEWS file in $datadir/modest/data, so we
can use it for displaying release notes in the public modest
* add /usr/local/modest/data/* to the chinook install file
pmo-trunk-r4004
Alberto Garcia [Wed, 9 Jan 2008 16:37:47 +0000 (16:37 +0000)]
Simplified modest_msg_view_window_select_previous_message() to
make easier the removal of modest_platform_connect_and_wait()
pmo-trunk-r4003
Alberto Garcia [Wed, 9 Jan 2008 12:48:47 +0000 (12:48 +0000)]
Removed obsolete method modest_msg_view_window_select_first_message()
pmo-trunk-r4002
Jose Dapena Paz [Wed, 9 Jan 2008 12:27:42 +0000 (12:27 +0000)]
* src/maemo/modest-msg-view-window.c:
* Make backspace not delete the message but chars when focus is
on the toolbar. We also block the scroll shortcuts (fixes
NB#78989).
pmo-trunk-r4001
Sergio Villar Senin [Wed, 9 Jan 2008 12:15:50 +0000 (12:15 +0000)]
* Fixes NB#78850, "Checking names" information banner is now properly shown
pmo-trunk-r4000
Sergio Villar Senin [Wed, 9 Jan 2008 11:32:42 +0000 (11:32 +0000)]
* Fixes NB#79114, the OK is dimmed if the outgoing server field is left empty
pmo-trunk-r3999
Sergio Villar Senin [Wed, 9 Jan 2008 09:09:44 +0000 (09:09 +0000)]
* Don't set the device online if we're trying to remove a local folder while being offline
pmo-trunk-r3998
Dirk-Jan C. Binnema [Wed, 9 Jan 2008 09:06:31 +0000 (09:06 +0000)]
* add some parameter checks
pmo-trunk-r3997
Jose Dapena Paz [Tue, 8 Jan 2008 18:54:31 +0000 (18:54 +0000)]
Fixed some reference leaks of attachments. I also moved from using
GList* of TnyMimeParts to use TnyLists to maintain a more intuitive list
of references.
* src/widget/modest-gtkhtml-msg-view.[ch]:
* Use TnyList of attachments
* src/widgets/modest-msg-edit-window.h:
* Use TnyList instead of GList for attachments.
* src/widgets/modest-msg-view.[ch]:
* Use TnyList instead of GList for attachments.
* src/widgets/modest-attachment-view.c:
* Now the ModestAttachmentView always keep a reference
to the mime part with g_object_ref.
* src/widgets/modest-msg-view-window.h:
* Use TnyList instead of GList for attachments.
* src/widgets/modest-attachments-view.[ch]:
* Missing unreferencing on iteration.
* Use TnyList instead of GList for attachmetns.
* src/modest-tny-msg.c:
* Use TnyList and unrefernce an attachment list properly.
* src/modest-ui-actions.c:
* Mail operations for saving to drafts or sending mails from
edit window shouldn't keep a reference to the edit window.
* Fixed minor bug assigning a g_strdup.
* Some frees in error cases in modest_ui_actions_on_send.
* src/maemo/modest-msg-edit-window.c:
* Fixed some leaked references.
* Use TnyList instead of GList for lists of attachments.
* src/maemo/modest-msg-view-window.c:
* Use TnyList instead of GList for lists of attachments.
* Fixed some counting leaks.
* src/modest-utils.[ch]:
* New method modest_list_index (), that finds the ordinal index
of an item in a list.
* src/modest-ui-dimming-rules.c:
* Use TnyList instead of GList for lists of attachments.
pmo-trunk-r3996
Dirk-Jan C. Binnema [Tue, 8 Jan 2008 18:11:19 +0000 (18:11 +0000)]
* check if current_folder != NULL;
this caused a Glib-Critical when folder moving failed
pmo-trunk-r3995
Dirk-Jan C. Binnema [Tue, 8 Jan 2008 18:08:04 +0000 (18:08 +0000)]
* add online status to debug output
pmo-trunk-r3994
Dirk-Jan C. Binnema [Tue, 8 Jan 2008 15:10:53 +0000 (15:10 +0000)]
* after removing the last attachment, move focus to subject field
Fixes NB#79088
pmo-trunk-r3993
Alberto Garcia [Tue, 8 Jan 2008 14:47:57 +0000 (14:47 +0000)]
Rename ModestToolbarDimmingRules to ModestWindowDimmingRules and
include all the rules in ModestMenuDimmingRules. Remove this last
group and all of its references because it's no longer necessary.
Now menu entries are dimmed/undimmed at the same time as toolbar
buttons.
Fixes NB#78844
pmo-trunk-r3992
Dirk-Jan C. Binnema [Tue, 8 Jan 2008 14:46:53 +0000 (14:46 +0000)]
* enable getting debug information over dbus; for now
we can get the operation-queue contents; other things can be added later.
it can be retrieved (from cmdline):
run-standalone.sh dbus-send --print-reply --dest='com.nokia.modest' /com/nokia/modest com.nokia.modest.Dump
this will print it to stderr wherever that is for modest, and also return it as a string
over dbus. if you're lucky, you get something like:
modest debug dump
=================
mail operation queue (01)
-------------------------
0x82e7c00 "NokiaID_store" (RECEIVE) [IN-PROGRESS] {1/100} ''
pmo-trunk-r3991
Dirk-Jan C. Binnema [Tue, 8 Jan 2008 14:43:01 +0000 (14:43 +0000)]
* add some param checks
pmo-trunk-r3990
Sergio Villar Senin [Tue, 8 Jan 2008 10:55:57 +0000 (10:55 +0000)]
* Fixed NB#79057, delete confirmation note is now shown over the proper window
pmo-trunk-r3989
Dirk-Jan C. Binnema [Tue, 8 Jan 2008 09:17:25 +0000 (09:17 +0000)]
* improve the debug output a bit
pmo-trunk-r3988
Dirk-Jan C. Binnema [Tue, 8 Jan 2008 09:07:43 +0000 (09:07 +0000)]
* fix some runtime warning
pmo-trunk-r3987
Dirk-Jan C. Binnema [Tue, 8 Jan 2008 08:58:49 +0000 (08:58 +0000)]
* add debugging code to the send-queue and the operations-queue;
lots of interesting info when your run modest with
"MODEST_DEBUG="debug-code"
pmo-trunk-r3986
Sergio Villar Senin [Mon, 7 Jan 2008 11:16:32 +0000 (11:16 +0000)]
* Fixes NB#78732, messages now appear in the Outbox after the first sent message
pmo-trunk-r3985
Dirk-Jan C. Binnema [Sun, 6 Jan 2008 10:49:25 +0000 (10:49 +0000)]
* now fix NB#78955:
- choose the right MIME-part for the body, with breaking
messages which worked before
- display 'inline' mime parts as attachments, if we don't
display them otherwise
- create modest-tny-mime-part.[ch] as our TnyMimePart decorator
- do we need to use the new
modest_tny_mime_part_is_attachment_for_modest
in other places too?
pmo-trunk-r3984
Dirk-Jan C. Binnema [Fri, 4 Jan 2008 17:27:41 +0000 (17:27 +0000)]
* support all the URI-types in maemo (see /usr/share/applications/)
and vagalume
pmo-trunk-r3983
Dirk-Jan C. Binnema [Fri, 4 Jan 2008 16:14:09 +0000 (16:14 +0000)]
* fix precondition, which could cause a crash
pmo-trunk-r3982
Dirk-Jan C. Binnema [Fri, 4 Jan 2008 16:11:05 +0000 (16:11 +0000)]
* revert of patches r3978 and r3979
pmo-trunk-r3981
Dirk-Jan C. Binnema [Fri, 4 Jan 2008 15:01:18 +0000 (15:01 +0000)]
* correctly determine what are attachments from modest's perspective;
ie. non-image/ parts, even with "content-disposition: inline" are
considered attachments from modest's pov.
note; added modest_tny_mime_part_is_attachment_for_modest; it works
and improves upon the current situation; anyway, it's important to
keep an eye for any mails which fail our heuristics
pmo-trunk-r3980
Dirk-Jan C. Binnema [Fri, 4 Jan 2008 13:53:21 +0000 (13:53 +0000)]
* show the right body part for the message (this partly fixes NB#78955)
by excluding any parts with some Content-Disposition to be 'body-candidates'
* rename modest_tny_msg_get_header into the better modest_tny_mime_part_get_header_value
pmo-trunk-r3979
Vivek Sekar [Fri, 4 Jan 2008 13:20:10 +0000 (13:20 +0000)]
Added the week02 pre-release bug fixes.
pmo-trunk-r3977
Dirk-Jan C. Binnema [Fri, 4 Jan 2008 10:51:39 +0000 (10:51 +0000)]
* applied two syntax patches from steve.kowalik@canonical.com for Ubuntu Mobile
(apparently, -Wall/-Werror broke compilations with newer gcc's)
* remove the now unused curl echo from configure.ac
pmo-trunk-r3976
Vivek Sekar [Thu, 3 Jan 2008 16:00:09 +0000 (16:00 +0000)]
Added a small hack to make the modest packages depend on a particular version of tinymail against which modest is built.
pmo-trunk-r3975
Sergio Villar Senin [Thu, 3 Jan 2008 10:03:27 +0000 (10:03 +0000)]
* Fixes NB#78843, menus and CSM are working again after opening an editor window
pmo-trunk-r3974
Sergio Villar Senin [Wed, 2 Jan 2008 18:18:20 +0000 (18:18 +0000)]
* Partially fixes NB#78857, wait for the selected folder synchronization when closing modest
pmo-trunk-r3973
Sergio Villar Senin [Wed, 2 Jan 2008 18:17:13 +0000 (18:17 +0000)]
* Added some useful debug code
* Fixed a mistake in the refiltering code
pmo-trunk-r3972
Sergio Villar Senin [Wed, 2 Jan 2008 17:42:09 +0000 (17:42 +0000)]
* Fixes NB#78835, copy option is now properly dimmed
pmo-trunk-r3971
Dirk-Jan C. Binnema [Wed, 2 Jan 2008 10:53:34 +0000 (10:53 +0000)]
* handle 'other' TNY_TRANSPORT_ACCOUNT_ERRORs as well, instead
of asserting it cannot happen.
in:
...
pmo-trunk-r3970
Dirk-Jan C. Binnema [Mon, 31 Dec 2007 14:31:54 +0000 (14:31 +0000)]
* ok, fixed some more corner cases. it's getting rather hairy
pmo-trunk-r3969
Dirk-Jan C. Binnema [Mon, 31 Dec 2007 14:08:59 +0000 (14:08 +0000)]
* fix the url handling of '&'; it's a bit hairy because of the
text->html and then hyperlinkify after that. also, cleaned up
the regexps a bit.
Fixed: Maemo bug #2683
pmo-trunk-r3968
Dirk-Jan C. Binnema [Mon, 31 Dec 2007 10:03:32 +0000 (10:03 +0000)]
* we were assuming that the source of a 'new folder' thing always
was the main-window; however, it can also be the Move-To-Folder.
if that was the case, we were crashing (even in sbox).
fixed this by checking for the source of the new-folder thing,
and added a ptr to the internal ModestFolderView in the
Move-To-Dialog as a gobject parameter, so we can retrieve it
later and set the focus correctly.
One question remains: are there any other places where we show
ModestFolderViews?
Fixes: NB#78807
pmo-trunk-r3967
Jose Dapena Paz [Fri, 21 Dec 2007 19:29:19 +0000 (19:29 +0000)]
* src/widgets/modest-hbox-cell-renderer.c,
src/widgets/modest-vbox-cell-renderer.c:
* Only get the children full requested size if we have any
expanded item.
pmo-trunk-r3966
Alberto Garcia [Fri, 21 Dec 2007 17:12:50 +0000 (17:12 +0000)]
When changing account settings, get the transport account correctly
Fixes NB#78788
pmo-trunk-r3965
Dirk-Jan C. Binnema [Fri, 21 Dec 2007 15:01:20 +0000 (15:01 +0000)]
* update
pmo-trunk-r3964
Dirk-Jan C. Binnema [Fri, 21 Dec 2007 14:22:24 +0000 (14:22 +0000)]
* prepare public release
pmo-trunk-r3963
Felipe Erias Morandeira [Fri, 21 Dec 2007 13:49:32 +0000 (13:49 +0000)]
Partially fixes NB#77528
Notifies the user when "save to draft", "open attachment" or "send msg" operations fail
because the disk is full. It also improves general error notification in more general scenarios.
pmo-trunk-r3962
Alberto Garcia [Fri, 21 Dec 2007 12:33:27 +0000 (12:33 +0000)]
Removed GLIB CRITICAL
pmo-trunk-r3960
Vivek Sekar [Fri, 21 Dec 2007 08:58:15 +0000 (08:58 +0000)]
corrected a wrong formatting in debian/changelog
pmo-trunk-r3958
Vivek Sekar [Fri, 21 Dec 2007 08:45:15 +0000 (08:45 +0000)]
Added the week 52 bug fixes.
pmo-trunk-r3956
Dirk-Jan C. Binnema [Fri, 21 Dec 2007 08:40:44 +0000 (08:40 +0000)]
* don't need curl
pmo-trunk-r3955
Jose Dapena Paz [Thu, 20 Dec 2007 18:13:08 +0000 (18:13 +0000)]
* src/widgets/modest-gtkhtml-msg-view.c:
* Removed non required include
pmo-trunk-r3954
Jose Dapena Paz [Thu, 20 Dec 2007 17:32:25 +0000 (17:32 +0000)]
* src/modest-defs.h:
* Add (hidden) setting to enable fetching external images in
html messages.
* src/widgets/modest-gtkhtml-mime-part-view.c:
* Now it fetches external images from http servers, if allowed
in a hidden setting. It does the fetch asynchronously so that
it's retrieved after showing the message.
* src/modest-init.c:
* Default value of fetching external images is false.
pmo-trunk-r3953
Dirk-Jan C. Binnema [Thu, 20 Dec 2007 17:21:25 +0000 (17:21 +0000)]
* don't include Cc: with reply, only with replyall
pmo-trunk-r3952
Dirk-Jan C. Binnema [Thu, 20 Dec 2007 17:04:45 +0000 (17:04 +0000)]
* berto is smarter than i am
pmo-trunk-r3951
Dirk-Jan C. Binnema [Thu, 20 Dec 2007 16:54:06 +0000 (16:54 +0000)]
* only remove ourselves from the To: if we do ReplyAll;
and when even then, only if there are multiple recipients.
Fixes: NB#78773
pmo-trunk-r3950
Sergio Villar Senin [Thu, 20 Dec 2007 16:21:17 +0000 (16:21 +0000)]
* Fixes NB#63571, connection dialog is offered if we try to create a folder in offline mode
pmo-trunk-r3949
Sergio Villar Senin [Thu, 20 Dec 2007 13:10:32 +0000 (13:10 +0000)]
* Fixes NB#78699, there was a missing refilter before selecting the new folder
* Fixed a reference leak reported by pvanhoof
pmo-trunk-r3948
Jose Dapena Paz [Thu, 20 Dec 2007 11:33:12 +0000 (11:33 +0000)]
* src/modest-tny-msg.c:
* Preserve content id of mime parts in copy_mime_part and
add_attachments methods, if any available. This should make
mails with embedded images in modest be constructed properly
again (fixes NB#78698).
pmo-trunk-r3947
Dirk-Jan C. Binnema [Thu, 20 Dec 2007 06:50:44 +0000 (06:50 +0000)]
* add a libcurl-check (we'll need that when for downloading imgs)
pmo-trunk-r3946
Alberto Garcia [Wed, 19 Dec 2007 19:07:50 +0000 (19:07 +0000)]
Show "Copied" banner after copying a URL
Fixes NB#78751
pmo-trunk-r3945
Sergio Villar Senin [Wed, 19 Dec 2007 15:19:44 +0000 (15:19 +0000)]
* Use the async function instead of the sync call
pmo-trunk-r3944
Sergio Villar Senin [Wed, 19 Dec 2007 10:03:37 +0000 (10:03 +0000)]
* Added MCE ifdefs
pmo-trunk-r3943
Vivek Sekar [Wed, 19 Dec 2007 09:32:10 +0000 (09:32 +0000)]
Added the mce-dev dependency.
pmo-trunk-r3942
Alberto Garcia [Tue, 18 Dec 2007 19:06:07 +0000 (19:06 +0000)]
Don't fail if maemo-launcher-dev is not installed
pmo-trunk-r3941
Alberto Garcia [Tue, 18 Dec 2007 18:08:33 +0000 (18:08 +0000)]
Use dh_maemolauncher
pmo-trunk-r3940
Alberto Garcia [Tue, 18 Dec 2007 17:41:54 +0000 (17:41 +0000)]
Add LAUNCHER_DEPENDS to debian/rules
pmo-trunk-r3939
Alberto Garcia [Tue, 18 Dec 2007 17:29:10 +0000 (17:29 +0000)]
Get maemo-launcher flags using pkg-config from autoconf
pmo-trunk-r3938
Dirk-Jan C. Binnema [Tue, 18 Dec 2007 15:05:13 +0000 (15:05 +0000)]
* only change the window title if the new title is different from
the old one; updating is apparently an expensive op, and the
window mgr, gtk, etc. don't do this check themselves
pmo-trunk-r3937
Sergio Villar Senin [Tue, 18 Dec 2007 15:00:28 +0000 (15:00 +0000)]
* Fixes NB#78357, new mail sound is played now with IMAP IDLE events
pmo-trunk-r3936
Felipe Erias Morandeira [Tue, 18 Dec 2007 14:29:08 +0000 (14:29 +0000)]
Fixes NB#78683
* Adds checks for NULL values from modest_tny_send_queue_get_outbox() and modest_tny_account_get_special_folder()
* Also, removes three dummy g_warning() in modest-msg-edit-window.c
pmo-trunk-r3935
Alberto Garcia [Tue, 18 Dec 2007 12:14:07 +0000 (12:14 +0000)]
Use always the default account when creating a new message
Fixes NB#65189
pmo-trunk-r3934
Felipe Erias Morandeira [Tue, 18 Dec 2007 10:02:50 +0000 (10:02 +0000)]
* modest-msg-edit-window.c:
(modest_msg_edit_window_set_format_state) : the menus are updated after we change the state of the editor
(text_buffer_refresh_attributes) : the state of alignment menu items is updated when the cursor moves
pmo-trunk-r3933
Alberto Garcia [Mon, 17 Dec 2007 15:28:42 +0000 (15:28 +0000)]
Check for the existence of GErrors in modest_mail_operation_save_to_drafts_cb()
pmo-trunk-r3932
Jose Dapena Paz [Mon, 17 Dec 2007 12:38:22 +0000 (12:38 +0000)]
Changes to speed up opening messages in view and editor
* src/maemo/modest-msg-edit-window.c:
* Do the show all of edit window construction to make it
feel a bit faster.
* src/maemo/modest-msg-view-window.c:
* Show all early to feel faster.
* Dimming rules should be evaluated after being visible, not
before.
* src/modest-ui-dimming-rules.c:
* Make clipboard checks for GtkHtml be avoided when the
selection is empty.
pmo-trunk-r3931
Sergio Villar Senin [Mon, 17 Dec 2007 11:27:28 +0000 (11:27 +0000)]
* Fixes NB#78639, modest does not perform an update if the auto-update is disabled
pmo-trunk-r3930
Sergio Villar Senin [Mon, 17 Dec 2007 10:42:16 +0000 (10:42 +0000)]
* Reverted my previous commit, the problem was in tinymail camel
pmo-trunk-r3929
Sergio Villar Senin [Mon, 17 Dec 2007 10:39:06 +0000 (10:39 +0000)]
* Fixed the change to the new tinymail API
pmo-trunk-r3928
Dirk-Jan C. Binnema [Sun, 16 Dec 2007 12:48:55 +0000 (12:48 +0000)]
* make modest handle mailing lists somewhat correcter (RFC2369):
- with-reply all, reply to both the old From: and the Reply-To: address
(in non-mailinglist cases, we ignore From: if there's a Reply-To:)
- remove duplicate entries in the To: field
- added modest_text_utils_remove_duplicate_addresses (name says it all)
- rewrote modest_text_utils_split_addresses_list; the old version appended
the ","-seperator in some cases; the old impl is still there but #ifdef'd-out
jdapena: please check the new impl, I think you wrote the old one
- added modest_tny_msg_get_header to get some header; I think a version
of this function should go to Tinymail instead;
should fix NB #78638
Note: the real bug there seems to be that tny_header_get_reply_to always(?)
returns NULL; I worked around it by using the abovementioned,
modest_tny_msg_get_header (msg, "Reply-To")
now it works.
pmo-trunk-r3927
Dirk-Jan C. Binnema [Sun, 16 Dec 2007 10:08:45 +0000 (10:08 +0000)]
* compile for tinymail API change
pmo-trunk-r3926
Philip Van Hoof [Sat, 15 Dec 2007 19:24:30 +0000 (19:24 +0000)]
Update Modest to latest API change in Tinymail - rev. 3141
pmo-trunk-r3925
Dirk-Jan C. Binnema [Fri, 14 Dec 2007 20:52:50 +0000 (20:52 +0000)]
* no need for maemo-providers-data
pmo-trunk-r3924
Sergio Villar Senin [Fri, 14 Dec 2007 17:09:47 +0000 (17:09 +0000)]
* Fixed a memory leak
* Removed some notification stuff since it's no longer needed since Felipe's changes to progress bar
pmo-trunk-r3923
Felipe Erias Morandeira [Fri, 14 Dec 2007 15:53:38 +0000 (15:53 +0000)]
Fixes NB#78637
pmo-trunk-r3922
Vivek Sekar [Fri, 14 Dec 2007 14:04:06 +0000 (14:04 +0000)]
Week 51 bug fixes.
pmo-trunk-r3920
Felipe Erias Morandeira [Fri, 14 Dec 2007 12:43:48 +0000 (12:43 +0000)]
Corrected two g_object_unref
pmo-trunk-r3919
Felipe Erias Morandeira [Fri, 14 Dec 2007 12:30:42 +0000 (12:30 +0000)]
Corrected ref and unref of mail operations.
pmo-trunk-r3918
Felipe Erias Morandeira [Fri, 14 Dec 2007 12:05:20 +0000 (12:05 +0000)]
Fixes NB#78602
* modest-mail-operation-queue.[hc]:
(modest_mail_operation_queue_get_by_source): returns the mail operations
in the queue associated with a given source
* widgets/modest-window-mgr.c:
(modest_window_mgr_unregister_window): if the window that is being
closed is a ModestMsgViewWindow, it cancels "open" and "receive"
operations that have it as their source
* maemo/modest-main-window.c:
(on_mail_operation_started): only goes to transfer mode if it is the
source of the operation whose start has been notified
* maemo/modest-msg-view-window.c:
(on_mail_operation_started): only goes to transfer mode if it is the
source of the operation whose start has been notified
(view_msg_cb): added checks for cancelled operations and empty fields
pmo-trunk-r3917
Alberto Garcia [Fri, 14 Dec 2007 11:16:56 +0000 (11:16 +0000)]
modest-tny-msg: fixed leak in add_images()
pmo-trunk-r3916
Sergio Villar Senin [Thu, 13 Dec 2007 18:51:55 +0000 (18:51 +0000)]
* Speeds up the progress bar, makes things "feel" faster
pmo-trunk-r3915
Dirk-Jan C. Binnema [Thu, 13 Dec 2007 16:17:50 +0000 (16:17 +0000)]
* Use the old To: to determine the new To:
* Use the old Cc: to determine the new Cc:
* _don't_ add the Bcc:
* code-cleanup
* Together with Sergio's tny patch, fixes:
NB#78589
and
https://bugs.maemo.org/show_bug.cgi?id=2539
pmo-trunk-r3914
Dirk-Jan C. Binnema [Thu, 13 Dec 2007 16:01:18 +0000 (16:01 +0000)]
* sometimes, the text->html conversion screwed up, because
the hyperlinkify happens *after* text->html, and it would
mistakenly recognize some of the things as part of urls.
https://bugs.maemo.org/show_bug.cgi?id=2540
Now, we put \007 instead of & when doing the text->html,
then do the hyperlinkify, then replace \007 with &
pmo-trunk-r3913
Felipe Erias Morandeira [Thu, 13 Dec 2007 15:30:38 +0000 (15:30 +0000)]
Partially fixes NB#78521
* src/maemo/modest-progress-bar-widget.c:
When the progress bar receives a "progress-changed" signal from its mail operation
where state->done = 0 and state->total = 0, it begins to pulse periodically until
the mail operation finishes or it receives a "progress-changed" signal with
positive values.
* (modest_progress_bar_widget_is_pulsating) :
* (modest_progress_bar_widget_set_pulsating_mode) : manage this pulsating mode
* src/modest-mail-operation.c
* (modest_mail_operation_update_account) :
* (modest_mail_operation_get_msg) :
* (modest_mail_operation_get_msgs_full) :
* (modest_mail_operation_refresh_folder) : these functions send an initial "progress-changed"
signal because it could happen that the first signal with "real" data takes a long time
to happen, or in some cases doesn't happen at all, leaving the user with an empty
progress bar for a while.
pmo-trunk-r3912
Sergio Villar Senin [Thu, 13 Dec 2007 13:42:23 +0000 (13:42 +0000)]
* Expunge the messages of the local accounts when removing them to save disk space
pmo-trunk-r3911
Jose Dapena Paz [Thu, 13 Dec 2007 12:18:52 +0000 (12:18 +0000)]
Work to fix glitches with progress toolbar (fixes NB#78458).
* src/maemo/modest-progress-bar-widget.c:
* Now we make sure we never set a NULL string as label of the
progress bar, and we get an initial " " string. This is for
getting always the expected height. This should prevent some
toolbar resizements.
* src/maemo/modest-msg-view-window.c,
src/maemo/modest-main-window.c:
* Rework the toolbar buttons size management. This way the
progress toolbar does not cause a resize of the other buttons.
* src/maemo/ui/modest-msg-view-window-ui.xml,
src/maemo/ui/modest-main-window-ui.xml:
* Add position attributes to toolbar.
pmo-trunk-r3910