Javier Fernandez Garcia-Boente [Tue, 26 Jun 2007 18:17:25 +0000 (18:17 +0000)]
* Add new dimming rules for copy,cut and paste operations.
* Add dimming rules for undo operations.
* Implement undo operation for copy and cut operations.
* Fixes: NB#59325
pmo-trunk-r2442
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 18:06:07 +0000 (18:06 +0000)]
* some other apps (sketch) send attachment list that start with ','.
strip that one, to prevent a warnings later.
pmo-trunk-r2441
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 18:03:58 +0000 (18:03 +0000)]
* leak fix (modest-init)
* modest-main: sometimes, 'ui' was a not a valid gobject, which caused glib warnings
pmo-trunk-r2440
Philip Van Hoof [Tue, 26 Jun 2007 16:41:14 +0000 (16:41 +0000)]
Bugfix when creating an account
pmo-trunk-r2438
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 16:26:39 +0000 (16:26 +0000)]
* replace the unnecessary fill_server_account_cache_if_need with
direct calls to modest_tny_account_store_get_accounts. No need
to make modest-tny-account-store even uglier.
(as always, murray is right)
pmo-trunk-r2437
Javier Fernandez Garcia-Boente [Tue, 26 Jun 2007 16:25:38 +0000 (16:25 +0000)]
* Added a new reference to priv->draft_msg of edit window
to manages its own reference, becasue sometines, this object
was unreference and application crashed when get_msg method of
this window was called.
pmo-trunk-r2436
Murray Cumming [Tue, 26 Jun 2007 16:25:34 +0000 (16:25 +0000)]
2007-06-26 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c:
* src/modest-tny-account-store.h:
Added modest_tny_account_is_memory_card_account().
* src/maemo/modest-main-window.c: (create_details_widget):
Show the same information items for the memory card as we show for the
local-folders, to fix projects.maemo.org bug NB#59307.
pmo-trunk-r2435
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 16:06:35 +0000 (16:06 +0000)]
* do lazy initialization of the server accounts; this avoids
a chicken-egg problem at startup where modest_runtime_get_account_store would
be needed before initialized
pmo-trunk-r2434
Murray Cumming [Tue, 26 Jun 2007 15:57:57 +0000 (15:57 +0000)]
2007-06-26 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (get_password):
Added some checks for NULL to maybe prevent crashes, though I think
it was Philip's last commit that actually prevented the crash here
when creating a first new account.
But the new account is still not usable (no messages are shown)
until a restart of the application.
pmo-trunk-r2433
Philip Van Hoof [Tue, 26 Jun 2007 15:51:46 +0000 (15:51 +0000)]
Bugfix when setting the account to online
pmo-trunk-r2432
Javier Fernandez Garcia-Boente [Tue, 26 Jun 2007 14:27:50 +0000 (14:27 +0000)]
* Check headers flags (CACHED) to determine if some message
was already retreived, and sets a different id in get_message
mail operation (OPEN). This new id will be used by progress
bar widget to show a different message.
* Fixes: NB#56201
pmo-trunk-r2431
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 14:05:47 +0000 (14:05 +0000)]
* expunge deleted messages when switching folders or closing;
otherwise it's not possible to delete at all...
this should fix NB#61769, NB#61764
pmo-trunk-r2430
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 13:51:42 +0000 (13:51 +0000)]
Updated the changelog with the fixes, june, 26th, 16:50.
pmo-trunk-r2429
Murray Cumming [Tue, 26 Jun 2007 12:48:36 +0000 (12:48 +0000)]
2007-06-26 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-maemo-global-settings-dialog.c:
(idle_select_default_focus):
* src/modest-mail-operation.c: (idle_notify_progress),
(idle_notify_progress_once), (idle_notify_update_account_queue),
(set_last_updated_idle), (update_account_thread),
(notify_get_msgs_full), (get_msgs_full_destroyer),
(get_msgs_full_thread):
* src/widgets/modest-attachment-view.c: (get_size_idle_func):
* src/widgets/modest-header-view.c:
(idle_notify_headers_count_changed_destroy),
(idle_notify_headers_count_changed):
Use gdk_threads_enter() and gdk_threads_enter_leave() in
all idle handlers, because some other thread could be blocking
the GDK lock, so that it can do GUI stuff.
pmo-trunk-r2428
Murray Cumming [Tue, 26 Jun 2007 12:31:38 +0000 (12:31 +0000)]
2007-06-26 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
(on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
(on_idle_send_receive), (on_idle_open_default_inbox):
* src/maemo/modest-msg-edit-window.c:
(modest_msg_edit_window_attach_file_noninteractive):
Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
to prevent a hang. I don't quite understand why these are necessary,
beause we should already be in the main loop. I guess something outside
of the main loop is taking the lock.
* tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
we are really using URIs, and use files that are more likely to exist.
pmo-trunk-r2427
Murray Cumming [Tue, 26 Jun 2007 12:05:41 +0000 (12:05 +0000)]
2007-06-26 Murray Cumming <murrayc@murrayc.com>
* tests/dbus_api/Makefile.am: Fix the build of the tests. This was
necessary because configure.ac now defines different variables.
pmo-trunk-r2426
Murray Cumming [Tue, 26 Jun 2007 11:39:46 +0000 (11:39 +0000)]
2007-06-26 Murray Cumming <murrayc@murrayc.com>
* libmodest-dbus-client/libmodest-dbus-client.c:
* libmodest-dbus-client/libmodest-dbus-client.h:
Removed libmodest_dbus_client_send_mail() because it is not used by anything.
libmodest_dbus_client_compose_mail() is what things actually use.
* src/dbus_api/modest-dbus-api.h:
* src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
* tests/dbus_api/Makefile.am:
* tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
D-Bus method.
pmo-trunk-r2424
Sergio Villar Senin [Tue, 26 Jun 2007 11:00:32 +0000 (11:00 +0000)]
* Added an extra check that was causing a crash when the folder returns no stats
pmo-trunk-r2423
Jose Dapena Paz [Tue, 26 Jun 2007 10:33:24 +0000 (10:33 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Added gtk_text_iter_forward_search_insensitive to implement
case insensitive search of strings using the find toolbar.
* Added proper information banners for no matches, search
complete and empty find.
* Rework the find in page, to work similar to the upcoming
find in page new implementation of viewer.
pmo-trunk-r2422
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 09:39:29 +0000 (09:39 +0000)]
Changed the configure.ac file. corrected the helplib variable used instead of mimelib.
pmo-trunk-r2421
Murray Cumming [Tue, 26 Jun 2007 09:10:53 +0000 (09:10 +0000)]
2007-06-26 Murray Cumming <murrayc@murrayc.com>
* src/modest-init.c: (modest_init_local_folders):
For memory-card (or other non local-folders) maildir accounts,
always create an Archive folder, so that there is somewhere to put
messages. This should be less confusing, because the user does not need
to guess that the need to create a folder.
pmo-trunk-r2420
Javier Fernandez Garcia-Boente [Tue, 26 Jun 2007 09:05:20 +0000 (09:05 +0000)]
* Add a new check of new folder name string length in
'entry-changed' signal handler.
* Fixes: NB#61576
pmo-trunk-r2419
Philip Van Hoof [Tue, 26 Jun 2007 08:25:56 +0000 (08:25 +0000)]
Compilation error
pmo-trunk-r2418
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 08:03:16 +0000 (08:03 +0000)]
* call osso_abook_init before doing anything with the addressbook.
this fixes NB#57415
pmo-trunk-r2417
Philip Van Hoof [Mon, 25 Jun 2007 20:07:50 +0000 (20:07 +0000)]
Bugfix for 61408
pmo-trunk-r2416
Sergio Villar Senin [Mon, 25 Jun 2007 18:56:49 +0000 (18:56 +0000)]
* Added an attribute sent to the msg edit window that specifies that the mail has scheduled to be sent
* Modified the window destruction code in the window manager. Now checks that the message has not been sent before trying to save it to drafsts
* Some code reorganization in the window manager
pmo-trunk-r2415
Javier Fernandez Garcia-Boente [Mon, 25 Jun 2007 18:00:05 +0000 (18:00 +0000)]
* Added new dimming rules for Attachment menu option in
viewer window.
* Fixes: NB#61148
pmo-trunk-r2414
Johannes Schmid [Mon, 25 Jun 2007 17:46:07 +0000 (17:46 +0000)]
2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
* src/maemo/easysetup/modest-wizard-dialog.c: (init):
Fixed icon size by using (50, 50) which is the same as defined by
newer hildon-libs
pmo-trunk-r2413
Dirk-Jan C. Binnema [Mon, 25 Jun 2007 17:28:16 +0000 (17:28 +0000)]
* sync the folders when when we're moving to another one.
this fixes NB#57773
pmo-trunk-r2412
Sergio Villar Senin [Mon, 25 Jun 2007 16:37:02 +0000 (16:37 +0000)]
* Fixes NB#61266, now the user can navigate between the tabs of global settings dialog using the hardware keys
pmo-trunk-r2411
Sergio Villar Senin [Mon, 25 Jun 2007 16:00:42 +0000 (16:00 +0000)]
* Partially reverted last commit, sometimes the gdk_threads_enter blocks, still need to review it
pmo-trunk-r2410
Jose Dapena Paz [Mon, 25 Jun 2007 15:48:18 +0000 (15:48 +0000)]
* src/modest-ui-actions.c:
* Fixed translation of message retrieval information note
(fixes NB#61620).
pmo-trunk-r2409
Sergio Villar Senin [Mon, 25 Jun 2007 15:48:08 +0000 (15:48 +0000)]
* Added two missing gdk_threads_enter/leave statements
pmo-trunk-r2408
Sergio Villar Senin [Mon, 25 Jun 2007 15:44:03 +0000 (15:44 +0000)]
* Removed an invalid g_object_unref
* Added some gdk_threads_enter/leave in the mail operations
pmo-trunk-r2407
Dirk-Jan C. Binnema [Mon, 25 Jun 2007 15:36:12 +0000 (15:36 +0000)]
Updated yje
pmo-trunk-r2406
Jose Dapena Paz [Mon, 25 Jun 2007 14:47:55 +0000 (14:47 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now Paste is dimmed when focus is in attachments view
(fixes NB#60552).
* Added proper information banners for insensitive press
of Paste.
pmo-trunk-r2405
Jose Dapena Paz [Mon, 25 Jun 2007 14:26:47 +0000 (14:26 +0000)]
* src/maemo/modest-msg-view-window.c:
* Added information banner for search complete and no matches.
* Fixed translation of confirm overwrite dialog (fixes
NB#60401).
pmo-trunk-r2404
Jose Dapena Paz [Mon, 25 Jun 2007 14:11:52 +0000 (14:11 +0000)]
* src/maemo/modest-main-window.c:
* Now "No messages to show" message is aligned to top
instead of center (fixes NB#60298).
pmo-trunk-r2403
Jose Dapena Paz [Mon, 25 Jun 2007 14:02:59 +0000 (14:02 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now CC and BCC fields are shown even when show_cc and s
show_bcc are FALSE in settings, if these fields have any
values (for example replying to all in a message with Cc)
(fixes NB#60253).
pmo-trunk-r2402
Armin Burgmeier [Mon, 25 Jun 2007 13:18:44 +0000 (13:18 +0000)]
2007-06-25 Armin Burgmeier <armin@openismus.com>
* src/widgets/modest-window-mgr.c:
* src/modest-init.c:
* configure.ac: Correctly recognize hildon-notify presence and fixed
the build without it being installed.
pmo-trunk-r2401
Jose Dapena Paz [Mon, 25 Jun 2007 13:12:39 +0000 (13:12 +0000)]
* src/modest-ui-dimming-rules.c:
* Added dimming rule for trying to remove attachments from a
POP message (fixes NB#59869).
pmo-trunk-r2400
Murray Cumming [Mon, 25 Jun 2007 12:26:37 +0000 (12:26 +0000)]
2007-06-25 Murray Cumming <murrayc@murrayc.com>
* libmodest-dbus-client/libmodest-dbus-client.c:
(libmodest_dbus_client_search): Fix the build. Sorry.
* src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
(reply_forward_cb): Initialize variables to fix the build.
* src/modest-tny-account-store.c:
(modest_tny_account_store_get_tny_account_by): Fix the account URI
comparison (a silly typo) so that email search results can be opened
when there are more than one account.
pmo-trunk-r2398
Sergio Villar Senin [Mon, 25 Jun 2007 11:36:41 +0000 (11:36 +0000)]
* Fixes NB#59138, message is saved to drafts when main window is closed
* modest_msg_edit_window_is_modified is now public
* modest_window_mgr.c: added a hash table to store the "window-destroy" signal handlers
* modest_window_mgr.c: replaced a g_object_unref by gtk_widget_destroy
* moved the save_to_drafts call from the edit window to the window manager
* added some missing unrefs to the UI actions
* fixed save_to_drafts mail operation, it was not reporting the mail operation status
pmo-trunk-r2397
Murray Cumming [Mon, 25 Jun 2007 10:46:33 +0000 (10:46 +0000)]
2007-06-25 Murray Cumming <murrayc@murrayc.com>
* libmodest-dbus-client/libmodest-dbus-client.c:
(libmodest_dbus_client_search),
(libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
instead of 1 second, because the search gets folders and messages from
the server, which can take a long time. When it times out,
osso-global-search will report no results.
We need to specify whether we should search only cached information
(maybe with a user preference), and the osso-email-search-plugin
API should really be improved to allow that option, and to allow results
to be delivered asynchronously in batches.|
pmo-trunk-r2395
Javier Fernandez Garcia-Boente [Mon, 25 Jun 2007 10:45:12 +0000 (10:45 +0000)]
* Review dimming rules of attachment menu option.
* Fixes: NB#61295
pmo-trunk-r2394
Murray Cumming [Mon, 25 Jun 2007 09:06:51 +0000 (09:06 +0000)]
2007-06-25 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-wizard-dialog.c: (init):
Fix a typo to fix the osso 1.1. build. See the TODO comment though -
GTK_ICON_SIZE_DIALOG is probably the wrong size.
pmo-trunk-r2393
Murray Cumming [Mon, 25 Jun 2007 08:58:55 +0000 (08:58 +0000)]
2007-06-25 Murray Cumming <murrayc@murrayc.com>
* src/modest-search.c: (modest_search_folder): Ignore a seach folder
that is an empty string. D-Bus seems to give us these instead of NULL.
pmo-trunk-r2392
Johannes Schmid [Mon, 25 Jun 2007 08:50:55 +0000 (08:50 +0000)]
2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
* src/dbus_api/modest-dbus-callbacks.c:
* src/maemo/easysetup/modest-easysetup-wizard.h:
* src/maemo/easysetup/modest-wizard-dialog.c: (init):
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(modest_connection_specific_smtp_edit_window_init):
* src/maemo/modest-maemo-global-settings-dialog.c:
(on_range_error):
* src/maemo/modest-maemo-utils.c:
(modest_maemo_utils_setup_images_filechooser):
* src/maemo/modest-main-window.c: (create_details_widget):
* src/maemo/modest-msg-edit-window.c:
(modest_msg_edit_window_attach_file_noninteractive),
(modest_msg_edit_window_color_button_change),
(modest_msg_edit_window_set_zoom):
* src/modest-mail-operation.c: (update_account_thread):
* src/modest-tny-account-store.c:
* src/modest-tny-account.c:
* src/widgets/modest-global-settings-dialog.c:
* src/widgets/modest-window.h:
Fixed build on bora!
pmo-trunk-r2391
Jose Dapena Paz [Mon, 25 Jun 2007 08:38:45 +0000 (08:38 +0000)]
* src/widgets/modest-attachments-view.c:
* Now it updates properly the selected attachments list when
an attachment is removed. It also updates properly the
primary clipboard (fixes NB#61453).
pmo-trunk-r2390
Murray Cumming [Mon, 25 Jun 2007 08:37:19 +0000 (08:37 +0000)]
2007-06-25 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
* src/modest-search.c: (modest_search_folder),
(modest_search_all_accounts): Actually search only in the specified folder,
doing a simple match on the folder ID.
* src/modest-search.h: Added a folder field to the ModestSearch struct,
and added some documentation.
pmo-trunk-r2389
Javier Fernandez Garcia-Boente [Mon, 25 Jun 2007 07:42:57 +0000 (07:42 +0000)]
* Add a new gettext macro to use holdon-common-strings
translate domain.
* Add a new notification banner to edit/copy operation.
pmo-trunk-r2388
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 16:50:03 +0000 (16:50 +0000)]
- fix order of header fields in viewer; fixes NB#61497
pmo-trunk-r2387
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 11:02:40 +0000 (11:02 +0000)]
* gnome is currently broken; tell our users
pmo-trunk-r2386
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 10:48:17 +0000 (10:48 +0000)]
* fix the fallout of the configuration changes - builds again now
pmo-trunk-r2385
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 10:17:13 +0000 (10:17 +0000)]
* remove some unintended changes in the last checkin
pmo-trunk-r2384
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 10:09:45 +0000 (10:09 +0000)]
* cleanup the configuration system a bit:
- don't have an overall 'hildon0' or 'hildon1' check, because this causes problems with sardine
- check for ogs, hildon-help, hildon-notify etc. separately
- turn on -Werr for *all* maemo builds
pmo-trunk-r2383
Dirk-Jan C. Binnema [Sat, 23 Jun 2007 09:02:13 +0000 (09:02 +0000)]
* fix bora build (there's no hildonnotification there)
pmo-trunk-r2382
Armin Burgmeier [Fri, 22 Jun 2007 20:03:30 +0000 (20:03 +0000)]
2007-06-22 Armin Burgmeier <armin@openismus.com>
* src/maemo/modest-maemo-utils.h:
* src/maemo/modest-maemo-utils.c: Added a GError parameter to
modest_maemo_utils_get_supported_secure_authentication_methods.
* src/maemo/easysetup/modest-easysetup-wizard.c:
* src/maemo/modest-account-settings-dialog.c: Show correct error if
one occured, not just "Server does not support secure authentication".
pmo-trunk-r2381
Murray Cumming [Fri, 22 Jun 2007 16:13:17 +0000 (16:13 +0000)]
2007-06-22 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (get_password):
Restored the call to tny_account_set_user() because Philip seems to have
stopped this from crashing (by not using the freed string). It still does
not work, but now we can test it.
pmo-trunk-r2380
Jose Dapena Paz [Fri, 22 Jun 2007 15:11:11 +0000 (15:11 +0000)]
* src/widgets/modest-msg-view.[ch]:
* Remove an attachment mime part from view.
* src/widgets/modest-msg-view-window.[ch]:
* Implemented dialog for removing attachments, but dropped
any remove attachment implementation until we know how to
remove attachments only from cache.
pmo-trunk-r2379
Murray Cumming [Fri, 22 Jun 2007 14:09:23 +0000 (14:09 +0000)]
2007-06-22 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-msg-edit-window.c: (init_window):
Comment out use of an uninitialzed GtkScrolledWindow variable,
to fix the build and stop a crash. Yet again.
pmo-trunk-r2378
Jose Dapena Paz [Fri, 22 Jun 2007 12:15:57 +0000 (12:15 +0000)]
* src/modest-ui-actions.c:
* Now saving to drafts shows a proper information
banner (fixes NB#59333).
pmo-trunk-r2377
Jose Dapena Paz [Fri, 22 Jun 2007 12:07:28 +0000 (12:07 +0000)]
* src/widgets/modest-folder-view.c:
* Now local folder is bolded too (fixes NB#59314).
pmo-trunk-r2376
Jose Dapena Paz [Fri, 22 Jun 2007 11:53:46 +0000 (11:53 +0000)]
* src/modest-text-utils.[ch]:
* Added new method modest_text_utils_get_color_string, that
obtains a color string proper for inserting in pango markup
or html from a GdkColor.
* src/maemo/modest-main-window.c:
* Now the folder details view puts secondary text color on field
names (fixes NB#59310).
pmo-trunk-r2375
Murray Cumming [Fri, 22 Jun 2007 11:20:51 +0000 (11:20 +0000)]
2007-06-22 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (get_password):
Remove the call to tny_account_set_user() because this actually crashes.
As mentioned in the last commit, it is known to not work anyway.
pmo-trunk-r2374
Jose Dapena Paz [Fri, 22 Jun 2007 10:26:15 +0000 (10:26 +0000)]
* src/maemo/modest-address-book.c:
* Removed call to osso_abook_select_dialog_set_new_contact
as this has been removed from new osso abook API.
* src/maemo/modest-msg-edit-window.c:
* Now inserted images size are limited to a width of 640
on insertion to buffer, to avoid requiring horizontal
scroll.
* Now images are also obtained using Gnome VFS. This way we can
obtain remote images.
* Now we accept selecting multiple image files to insert
(fixes NB#59820).
* Now we open the insert image filechooser dialog in the
images special folder.
* src/maemo/modest-maemo-utils.[ch]:
* New modest_maemo_utils_setup_images_filechooser method,
that sets up a filechooser for saving or browsing images.
Sets the filter to images mimetype category, and the
default folder to the images one.
pmo-trunk-r2373
Murray Cumming [Fri, 22 Jun 2007 09:57:08 +0000 (09:57 +0000)]
2007-06-22 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (get_password):
Use tny_account_set_username() to tell tinymail that the username might
have changed too. But tinymail ignores this: see projects.maemo.org
bug #61463.
* src/modest-ui-actions.c:
(modest_ui_actions_on_password_requested): Remove the useless attempt to
reset the connection when changing the username, and improve the comments.
Save the changed username to gconf at least, so it is used when Modest is
restarted.
pmo-trunk-r2372
Murray Cumming [Thu, 21 Jun 2007 17:44:44 +0000 (17:44 +0000)]
2007-06-21 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
Do not use a query, so that we get all folders, including for POP and
local-folders. They work as search criteria too.
This fixes projects.maemo.org bug NB#57740.
pmo-trunk-r2371
Jose Dapena Paz [Thu, 21 Jun 2007 17:23:33 +0000 (17:23 +0000)]
* src/widgets/modest-msg-edit-window.h:
* Added zoom actions for 80% and 120%.
* src/maemo/modest-msg-edit-window.c:
* Now zoom menu is updated properly on inherited zooms
(fixes NB#61337).
* src/maemo/ui/modest-msg-edit-window-ui.xml:
* Added 80% and 120% menu levels actions.
pmo-trunk-r2370
Murray Cumming [Thu, 21 Jun 2007 17:20:51 +0000 (17:20 +0000)]
2007-06-21 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-platform.c: (modest_platform_on_new_msg):
Comment out the use of hildon_notification_set_sound() because it is
not declared, to fix the build. Warnings are serious, people.
pmo-trunk-r2368
Jose Dapena Paz [Thu, 21 Jun 2007 16:55:08 +0000 (16:55 +0000)]
Refactoring work to make new folder and rename folder share
the same implementation (fixes NB#58817).
* src/modest-platform.h:
* New rename_folder_dialog method.
* src/modest-ui-actions.c:
* Now rename uses a dialog in modest platform, sharing the
implementation with new folder dialog. Also removed old
dialog implementation.
* src/maemo/modest-platform.c:
* New method rename_folder_dialog, and refactored
new_folder_dialog, creating name_folder_dialog
that implements the same logic and controls for
both UI actions.
pmo-trunk-r2367
Jose Dapena Paz [Thu, 21 Jun 2007 16:11:41 +0000 (16:11 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now, if you're not focusing the body editor, zoom is not
allowed from menu nor hardware keys (fixes NB#58800).
* Fixed translation strings for zoom information banners.
Now they use the hildon-common-strings domain strings.
* src/maemo/modest-msg-view-window.c:
* Fix translation strings for zoom information banners.
* src/maemo/modest-main-window.c:
* Add unable to zoom information banner in main window.
* src/maemo/modest-main-window-ui.xml:
* Added zoom hardware key actions.
pmo-trunk-r2366
Armin Burgmeier [Thu, 21 Jun 2007 15:48:43 +0000 (15:48 +0000)]
2007-06-21 Armin Burgmeier <armin@openismus.com>
* src/maemo/modest-maemo-utils.h:
* src/maemo/modest-maemo-utils.c: Added a username parameter to the
modest_maemo_utils_get_supported_secure_authentication_methods()
to query authentication methods for a specific user. This should fix
projects.maemo.org bug NB#61369.
* src/maemo/easysetup/modest-easysetup-wizard.c:
* src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
function.
pmo-trunk-r2365
Sergio Villar Senin [Thu, 21 Jun 2007 15:09:15 +0000 (15:09 +0000)]
* Added a callback to the update_account operation that notifies about the new messages received
* Fixed the Empty view problem
* Removed the new message notification from the header view
pmo-trunk-r2364
Jose Dapena Paz [Thu, 21 Jun 2007 14:17:53 +0000 (14:17 +0000)]
* src/maemo/modest-folder-view.c:
* Now it sorts local folders in a different way. It puts
first the special folders outbox, drafts and sent, and then
all the user created folders (fixes NB#60361).
pmo-trunk-r2363
Javier Fernandez Garcia-Boente [Thu, 21 Jun 2007 13:46:27 +0000 (13:46 +0000)]
* Fix bug about how set_flags function was being used.
* Fixes: NB#59193
pmo-trunk-r2362
Murray Cumming [Thu, 21 Jun 2007 13:28:14 +0000 (13:28 +0000)]
2007-06-21 Murray Cumming <murrayc@murrayc.com>
* ossoemailinterface.c: (osso_email_get_folder_list):
Implement this with the new libmodest_dbus_client_get_folders()
function. This should help with projects.maemo.org bug NB#57740.
pmo-trunk-r2361
Murray Cumming [Thu, 21 Jun 2007 12:46:58 +0000 (12:46 +0000)]
Removed junk.
pmo-trunk-r2360
Murray Cumming [Thu, 21 Jun 2007 12:42:31 +0000 (12:42 +0000)]
2007-06-21 Murray Cumming <murrayc@murrayc.com>
* libmodest-dbus-client/libmodest-dbus-client.h:
* libmodest-dbus-client/libmodest-dbus-client.c:
(modest_dbus_message_iter_get_search_hit),
(libmodest_dbus_client_search):
Reorganised and commented this.
Removed modest_search_hit_free() from the public API because it
is not needed.
Added libmodest_dbus_client_get_folders() and
modest_folder_result_list_free().
* src/dbus_api/modest-dbus-api.h:
* src/dbus_api/modest-dbus-callbacks.c:
(modest_dbus_req_filter): Commented. Moved most code to
on_dbus_method_search() and added on_dbus_method_get_folders().
* src/maemo/modest-platform.c: (modest_platform_init): Commented the use
of the extra D-Bus handler.
* tests/dbus_api/Makefile.am:
* tests/dbus_api/test_get_folders.c: New test for
libmodest_dbus_client_get_folders(). This seems to return an empty list
at the moment. That could be the same error that causes the message list
to be empty sometimes.
This should help with projects.maemo.org bug NB#57740.
pmo-trunk-r2358
Dirk-Jan C. Binnema [Thu, 21 Jun 2007 12:17:17 +0000 (12:17 +0000)]
* update
pmo-trunk-r2357
Armin Burgmeier [Thu, 21 Jun 2007 11:47:07 +0000 (11:47 +0000)]
2007-06-21 Armin Burgmeier <armin@openismus.com>
* src/modest-mail-operation.c: Do not call
modest_mail_operation_queue_cancel_all() in _cancel() but do instead
notify the operation's end after having set the status to CANCELED for
the operation queue to listen on. This fixes a deadlock when there
were mail operations in the queue during its finalization.
* src/modest-singletons.c: Reordered uninitialization of the account
manager to happen after the mail operation queue was uninitialized
because the mail operation's in the queue might still try to access
the account manager (see modest_mail_operation_notify_end()). This
fixes a potential crash when terminating the application.
pmo-trunk-r2354
Jose Dapena Paz [Thu, 21 Jun 2007 10:53:43 +0000 (10:53 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now "Select all" is dimmed when focus is on an area without anything
to select (for example, an empty body) (fixes NB#59393).
* Minor API fix on usage of priority flags.
pmo-trunk-r2353
Murray Cumming [Thu, 21 Jun 2007 10:14:44 +0000 (10:14 +0000)]
removed junk
pmo-trunk-r2352
Murray Cumming [Thu, 21 Jun 2007 10:13:42 +0000 (10:13 +0000)]
2007-06-21 Murray Cumming <murrayc@murrayc.com>
* src/modest-search.c:
(search_mime_part_and_child_parts): Moved some code here so we
can search recursively in child folders.
(modest_search_folder): Search in the message as a mime part, instead
of just its child mime parts.
(read_chunk), (search_mime_part_ogs):
Check how many bytes were read, to prevent an endless loop.
Searching in message bodies now works. This finishes the fix for
projects.maemo.org bug NB#61007.
pmo-trunk-r2351
Jose Dapena Paz [Thu, 21 Jun 2007 09:35:23 +0000 (09:35 +0000)]
* src/modest-platform.h:
* Added a new platform function for showing information banner. Should
remove a new dependency in common non specific maemo code.
* src/modest-dimming-rules-group.c:
* Now it does not use hildon information banner, but the new platform
equivalent.
* src/modest-ui-actions.c:
* Now it shows an information banner on copying the messages to outbox
(fixes NB#59332).
* src/maemo/modest-platform.c:
* Added implementation of the new information banner platform function,
that uses the hildon information banner.
pmo-trunk-r2350
Javier Fernandez Garcia-Boente [Thu, 21 Jun 2007 08:45:19 +0000 (08:45 +0000)]
* Add some utility funcitons to email clipboard to check
if changes made on any folder must force to clear clipboard
data.
* Add new dimming rules for paste messages operation.
* Fixes: NB#59395
pmo-trunk-r2349
Jose Dapena Paz [Thu, 21 Jun 2007 08:37:11 +0000 (08:37 +0000)]
* src/modest-init.c:
* Now sort values are initialized to useful default values
(fixes NB#59321).
pmo-trunk-r2348
Jose Dapena Paz [Wed, 20 Jun 2007 17:39:01 +0000 (17:39 +0000)]
* src/maemo/modest-msg-edit-window-ui.xml:
* Removed delete message action, as it's not in new UI specs
(fixes NB#59245).
pmo-trunk-r2347
Jose Dapena Paz [Wed, 20 Jun 2007 17:34:00 +0000 (17:34 +0000)]
* src/maemo/modest-msg-edit-window-ui.xml:
* Removed delete message action, as it's not in new UI specs
(fixes NB#59245).
pmo-trunk-r2346
Jose Dapena Paz [Wed, 20 Jun 2007 17:26:29 +0000 (17:26 +0000)]
* src/maemo/modest-main-window.c:
* Now "send & receive/all" is hidden when there's only one
account available (fixes NB#59238).
pmo-trunk-r2345
Jose Dapena Paz [Wed, 20 Jun 2007 16:49:04 +0000 (16:49 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now it dims remove attachments action when there's no
attachment selected, and when there are more than one.
Also added insensitive press messages for both
(fixes NB#59176).
pmo-trunk-r2344
Jose Dapena Paz [Wed, 20 Jun 2007 16:25:05 +0000 (16:25 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now it dims properly the Paste menu option (fixes NB#58809).
pmo-trunk-r2343
Murray Cumming [Wed, 20 Jun 2007 15:47:22 +0000 (15:47 +0000)]
2007-06-20 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c: (modest_ui_actions_on_details):
Add a g_warning when the item is not a folder.
* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
when selected item is not a folder (for instance, an account), because
the UI spec only talks about folders.
I am not sure what the UI spec wants, so this might not totally fix
projects.maemo.org bug NB#60794.
pmo-trunk-r2342
Jose Dapena Paz [Wed, 20 Jun 2007 15:42:31 +0000 (15:42 +0000)]
* src/widgets/modest-header-view.c:
* Fix sort by priority, as it wasn't comparing the
fields values properly.
* src/maemo/modest-platform.c:
* Fix recovering the sort status from header view to
create the sort dialog.
* Save the new widget status on finishing the sort
(fixes NB#58628).
* src/modest-widget-memory.c:
* Fix the recovering of sort status from header view.
pmo-trunk-r2341
Murray Cumming [Wed, 20 Jun 2007 15:03:06 +0000 (15:03 +0000)]
2007-06-20 Murray Cumming <murrayc@murrayc-desktop>
* src/maemo/easysetup/modest-easysetup-country-combo-box.c:
(load_from_file): Sort the list. The unsorted list would be more noticeable
in non-English locales.
* src/maemo/modest-msg-edit-window.c:
(modest_msg_edit_window_attach_file): Initialize a variable to avoid a
warning and fix the build.
* src/maemo/modest-progress-bar-widget.c:
(modest_progress_bar_widget_set_progress): Avoid a division by zero, to
avoid a g_warning, and probably to avoid a crash.
pmo-trunk-r2340
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 14:40:02 +0000 (14:40 +0000)]
Add some notifications to dimmed rules.
pmo-trunk-r2339
Murray Cumming [Wed, 20 Jun 2007 14:25:17 +0000 (14:25 +0000)]
2007-06-20 Murray Cumming <murrayc@murrayc-desktop>
* src/modest-search.c: (modest_search_folder): Check for a GError
when calling tny_folder_get_headers(), to show that this is not the cause
of later failure.
pmo-trunk-r2338
Murray Cumming [Wed, 20 Jun 2007 14:11:31 +0000 (14:11 +0000)]
2007-06-20 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
Actually set the body query instead of the subject query.
* src/modest-search.c: (search_mime_part_ogs),
(search_mime_part_strcmp): Remove extra space from the text/* regex,
which would probably cause it to fail if we got this far.
(modest_search_folder): Use simple #ifdefs instead of the function pointer,
to simplify the code.
Warn when tny_mime_part_get_parts() returns an empty list, which seems to
be causing search-in-body to fail.
pmo-trunk-r2337
Jose Dapena Paz [Wed, 20 Jun 2007 14:02:17 +0000 (14:02 +0000)]
* src/maemo/modest-address-book.c:
* Minor change to avoid problems with addressbook init.
* src/maemo/modest-msg-edit-window.c:
* Support attaching more than one file at a time
(fixes NB#58614).
* src/maemo/modest-msg-view-window.c:
* Add an information banner for trying to search an empty
string.
pmo-trunk-r2336
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 13:51:37 +0000 (13:51 +0000)]
* Increase performance of dimming rules manager, avoiding call
get_selected_headers to check if no headers were selected to
perform operation.
pmo-trunk-r2335