* Fixes NB#88919, fixes crashes when sending emails in a standalone editor
authorSergio Villar Senin <svillar@igalia.com>
Wed, 19 Nov 2008 15:08:03 +0000 (15:08 +0000)
committerSergio Villar Senin <svillar@igalia.com>
Wed, 19 Nov 2008 15:08:03 +0000 (15:08 +0000)
pmo-diablo-r6338

src/maemo/modest-msg-view-window.c
src/modest-mail-operation.c
src/modest-tny-send-queue.c
src/modest-ui-actions.c
src/modest-utils.c

index 1b0bb69..a469ffe 100644 (file)
@@ -2543,7 +2543,7 @@ modest_msg_view_window_view_attachment (ModestMsgViewWindow *window, TnyMimePart
        attachments = modest_msg_view_get_attachments (MODEST_MSG_VIEW (priv->msg_view));
        attachment_index = modest_list_index (attachments, (GObject *) mime_part);
        g_object_unref (attachments);
-       
+
        if (msg_uid && attachment_index >= 0) {
                attachment_uid = g_strdup_printf ("%s/%d", msg_uid, attachment_index);
        }
@@ -2582,7 +2582,7 @@ modest_msg_view_window_view_attachment (ModestMsgViewWindow *window, TnyMimePart
                TnyFsStream *temp_stream = NULL;
                temp_stream = modest_utils_create_temp_stream (att_filename, attachment_uid,
                                                               &filepath);
-               
+
                if (temp_stream != NULL) {
                        DecodeAsyncHelper *helper = g_slice_new (DecodeAsyncHelper);
                        helper->filepath = g_strdup (filepath);
@@ -2616,9 +2616,9 @@ modest_msg_view_window_view_attachment (ModestMsgViewWindow *window, TnyMimePart
                ModestWindowMgr *mgr;
                ModestWindow *msg_win = NULL;
                gboolean found;
-               
+
                header = tny_msg_get_header (TNY_MSG (mime_part));
-               mgr = modest_runtime_get_window_mgr ();         
+               mgr = modest_runtime_get_window_mgr ();
                found = modest_window_mgr_find_registered_header (mgr, header, &msg_win);
 
                if (found) {
@@ -2924,7 +2924,7 @@ modest_msg_view_window_remove_attachments (ModestMsgViewWindow *window, gboolean
                mime_parts = modest_msg_view_get_attachments (MODEST_MSG_VIEW (priv->msg_view));
        else
                mime_parts = modest_msg_view_get_selected_attachments (MODEST_MSG_VIEW (priv->msg_view));
-               
+
        /* Remove already purged messages from mime parts list */
        iter = tny_list_create_iterator (mime_parts);
        while (!tny_iterator_is_done (iter)) {
@@ -2978,7 +2978,7 @@ modest_msg_view_window_remove_attachments (ModestMsgViewWindow *window, gboolean
        }
 
        priv->purge_timeout = g_timeout_add (2000, show_remove_attachment_information, window);
-       
+
        iter = tny_list_create_iterator (mime_parts);
        while (!tny_iterator_is_done (iter)) {
                TnyMimePart *part;
index ffafe90..40da2c9 100644 (file)
@@ -41,6 +41,7 @@
 #include <tny-simple-list.h>
 #include <tny-send-queue.h>
 #include <tny-status.h>
+#include <tny-error.h>
 #include <tny-folder-observer.h>
 #include <camel/camel-stream-mem.h>
 #include <glib/gi18n.h>
@@ -107,6 +108,18 @@ static void     sync_folder_finish_callback (TnyFolder *self,
 
 static gboolean _check_memory_low         (ModestMailOperation *mail_op);
 
+
+typedef struct {
+       ModestTnySendQueue *queue;
+       ModestMailOperation *self;
+       guint error_handler;
+       guint start_handler;
+       guint stop_handler;
+} RunQueueHelper;
+
+static void run_queue_notify_and_destroy (RunQueueHelper *helper,
+                                         ModestMailOperationStatus status);
+
 /* Helpers for the update account operation (send & receive)*/
 typedef struct 
 {
@@ -637,13 +650,16 @@ typedef struct
 } SendNewMailHelper;
 
 static void
-send_mail_common_cb (gboolean cancelled, 
-                    GError *err, 
-                    SendNewMailHelper *helper)
+send_mail_on_sync_async_cb (TnyFolder *folder, 
+                           gboolean cancelled, 
+                           GError *err, 
+                           gpointer user_data)
 {
        ModestMailOperationPrivate *priv;
        ModestMailOperation *self;
+       SendNewMailHelper *helper;
 
+       helper = (SendNewMailHelper *) user_data;
        self = helper->mail_op;
        priv = MODEST_MAIL_OPERATION_GET_PRIVATE (self);
 
@@ -668,12 +684,53 @@ send_mail_common_cb (gboolean cancelled,
 }
 
 static void
-send_mail_on_sync_async_cb (TnyFolder *self, 
-                           gboolean cancelled, 
-                           GError *err, 
-                           gpointer user_data)
+run_queue_start (TnySendQueue *self,
+                gpointer user_data)
+{
+       RunQueueHelper *helper = (RunQueueHelper *) user_data;
+       ModestMailOperation *mail_op;
+                       
+       g_debug ("%s sending queue successfully started", __FUNCTION__);
+
+       /* Wait for the message to be sent */
+       mail_op = modest_mail_operation_new (NULL);
+       modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (),
+                                        mail_op);
+       modest_mail_operation_run_queue (mail_op, helper->queue);
+       g_object_unref (mail_op);
+
+       /* Free the helper and end operation */
+       run_queue_notify_and_destroy (helper, MODEST_MAIL_OPERATION_STATUS_SUCCESS);
+}
+
+static void 
+run_queue_error_happened (TnySendQueue *queue, 
+                         TnyHeader *header, 
+                         TnyMsg *msg, 
+                         GError *error, 
+                         gpointer user_data)
 {
-       send_mail_common_cb (cancelled, err, (SendNewMailHelper *) user_data);
+       RunQueueHelper *helper = (RunQueueHelper *) user_data;
+       ModestMailOperationPrivate *priv;
+
+       /* If we are here this means that the send queue could not
+          start to send emails. Shouldn't happen as this means that
+          we could not create the thread */
+       g_debug ("%s sending queue failed to create the thread", __FUNCTION__);
+
+       priv = MODEST_MAIL_OPERATION_GET_PRIVATE (helper->self);
+       priv->error = g_error_copy ((const GError *) error);
+
+       if (error->code != TNY_SYSTEM_ERROR_UNKNOWN) {
+               /* This code is here for safety reasons. It should
+                  never be called, because that would mean that we
+                  are not controlling some error case */
+               g_warning ("%s Error %s should not happen", 
+                          __FUNCTION__, error->message);
+       }
+
+       /* Free helper and end operation */
+       run_queue_notify_and_destroy (helper, MODEST_MAIL_OPERATION_STATUS_FAILED);
 }
 
 static void
@@ -683,7 +740,65 @@ send_mail_on_added_to_outbox (TnySendQueue *send_queue,
                              GError *err,
                              gpointer user_data)
 {
-       send_mail_common_cb (cancelled, err, (SendNewMailHelper *) user_data);
+       ModestMailOperationPrivate *priv;
+       ModestMailOperation *self;
+       SendNewMailHelper *helper;
+
+       helper = (SendNewMailHelper *) user_data;
+       self = helper->mail_op;
+       priv = MODEST_MAIL_OPERATION_GET_PRIVATE (self);
+
+       if (cancelled || err)
+               goto end;
+
+       if (err) {
+               g_set_error (&(priv->error), MODEST_MAIL_OPERATION_ERROR,
+                            MODEST_MAIL_OPERATION_ERROR_SEND_QUEUE_ADD_ERROR,
+                            "Error adding a msg to the send queue\n");
+               priv->status = MODEST_MAIL_OPERATION_STATUS_FINISHED_WITH_ERRORS;
+       } else {
+               priv->status = MODEST_MAIL_OPERATION_STATUS_SUCCESS;
+       }
+
+ end:
+       if (helper->notify) {
+               TnyTransportAccount *trans_account;
+               ModestTnySendQueue *queue;
+
+               trans_account = (TnyTransportAccount *) modest_mail_operation_get_account (self);
+               queue = modest_runtime_get_send_queue (trans_account, TRUE);
+               if (queue) {
+                       RunQueueHelper *helper;
+
+                       /* Create the helper */
+                       helper = g_slice_new0 (RunQueueHelper);
+                       helper->queue = g_object_ref (queue);
+                       helper->self = g_object_ref (self);
+
+                       /* if sending is ongoing wait for the queue to
+                          stop. Otherwise wait for the queue-start
+                          signal. It could happen that the queue
+                          could not start, then check also the error
+                          happened signal */
+                       if (modest_tny_send_queue_sending_in_progress (queue)) {
+                               run_queue_start (TNY_SEND_QUEUE (queue), helper);
+                       } else {
+                               helper->start_handler = g_signal_connect (queue, "queue-start", 
+                                                                         G_CALLBACK (run_queue_start), 
+                                                                         helper);
+                               helper->error_handler = g_signal_connect (queue, "error-happened", 
+                                                                         G_CALLBACK (run_queue_error_happened), 
+                                                                         helper);
+                       }
+               } else {
+                       /* Finalize this mail operation */
+                       modest_mail_operation_notify_end (self);
+               }
+               g_object_unref (trans_account);
+       }
+
+       g_object_unref (helper->mail_op);
+       g_slice_free (SendNewMailHelper, helper);
 }
 
 static gboolean
@@ -1040,12 +1155,14 @@ modest_mail_operation_save_to_drafts_add_msg_cb(TnyFolder *self,
                TnyHeader *header = tny_msg_get_header (info->draft_msg);
                TnyFolder *src_folder = tny_header_get_folder (header);
 
+               g_debug ("--- REMOVE AND SYNC");
                /* Remove the old draft */
                tny_folder_remove_msg (src_folder, header, NULL);
 
                /* Synchronize to expunge and to update the msg counts */
                tny_folder_sync_async (info->drafts, TRUE, NULL, NULL, NULL);
                tny_folder_sync_async (src_folder, TRUE, NULL, NULL, NULL);
+               g_debug ("--- REMOVED - SYNCED");
 
                g_object_unref (G_OBJECT(header));
                g_object_unref (G_OBJECT(src_folder));
@@ -1177,6 +1294,7 @@ modest_mail_operation_save_to_drafts (ModestMailOperation *self,
        info->callback = callback;
        info->user_data = user_data;
 
+       g_debug ("--- CREATE MESSAGE");
        modest_mail_operation_notify_start (self);
        modest_mail_operation_create_msg (self, from, to, cc, bcc, subject, plain_body, html_body,
                                          attachments_list, images_list, priority_flags,
@@ -3235,26 +3353,53 @@ modest_mail_operation_refresh_folder  (ModestMailOperation *self,
 }
 
 static void
-run_queue_stop (ModestTnySendQueue *queue,
-               ModestMailOperation *self)
+run_queue_notify_and_destroy (RunQueueHelper *helper,
+                             ModestMailOperationStatus status)
 {
        ModestMailOperationPrivate *priv;
+       
+       /* Disconnect */
+       if (helper->error_handler && 
+           g_signal_handler_is_connected (helper->queue, helper->error_handler))
+               g_signal_handler_disconnect (helper->queue, helper->error_handler);
+       if (helper->start_handler && 
+           g_signal_handler_is_connected (helper->queue, helper->start_handler))
+               g_signal_handler_disconnect (helper->queue, helper->start_handler);
+       if (helper->stop_handler &&
+           g_signal_handler_is_connected (helper->queue, helper->stop_handler))
+               g_signal_handler_disconnect (helper->queue, helper->stop_handler);
+
+       /* Set status */
+       priv = MODEST_MAIL_OPERATION_GET_PRIVATE (helper->self);                
+       priv->status = status;
+
+       /* Notify end */
+       modest_mail_operation_notify_end (helper->self);
+
+       /* Free data */
+       g_object_unref (helper->queue);
+       g_object_unref (helper->self);
+       g_slice_free (RunQueueHelper, helper);
+}
 
-       g_return_if_fail (MODEST_IS_MAIL_OPERATION (self));
-       g_return_if_fail (MODEST_IS_TNY_SEND_QUEUE (queue));
-       priv = MODEST_MAIL_OPERATION_GET_PRIVATE (self);
-
-       priv->status = MODEST_MAIL_OPERATION_STATUS_SUCCESS;
+static void
+run_queue_stop (ModestTnySendQueue *queue,
+               gpointer user_data)
+{
+       RunQueueHelper *helper;
+       
+       g_debug ("%s sending queue stopped", __FUNCTION__);
 
-       modest_mail_operation_notify_end (self);
-       g_signal_handlers_disconnect_by_func (queue, run_queue_stop, self);
-       g_object_unref (self);
+       helper = (RunQueueHelper *) user_data;
+       run_queue_notify_and_destroy (helper, MODEST_MAIL_OPERATION_STATUS_SUCCESS);
 }
+
 void
 modest_mail_operation_run_queue (ModestMailOperation *self,
                                 ModestTnySendQueue *queue)
 {
        ModestMailOperationPrivate *priv;
+       RunQueueHelper *helper;
 
        g_return_if_fail (MODEST_IS_MAIL_OPERATION (self));
        g_return_if_fail (MODEST_IS_TNY_SEND_QUEUE (queue));
@@ -3264,9 +3409,17 @@ modest_mail_operation_run_queue (ModestMailOperation *self,
        priv->account = TNY_ACCOUNT (tny_camel_send_queue_get_transport_account (TNY_CAMEL_SEND_QUEUE (queue)));
        priv->op_type = MODEST_MAIL_OPERATION_TYPE_RUN_QUEUE;
 
+       /* Create the helper */
+       helper = g_slice_new0 (RunQueueHelper);
+       helper->queue = g_object_ref (queue);
+       helper->self = g_object_ref (self);
+       helper->stop_handler = g_signal_connect (queue, "queue-stop", 
+                                                G_CALLBACK (run_queue_stop), 
+                                                helper);
+
+       /* Notify operation has started */
        modest_mail_operation_notify_start (self);
-       g_object_ref (self);
-       g_signal_connect ((gpointer) queue, "queue-stop", G_CALLBACK (run_queue_stop), (gpointer) self);
+       g_debug ("%s, run queue started", __FUNCTION__);
 }
 
 static void
index cda9f35..46bc4c1 100644 (file)
@@ -73,6 +73,9 @@ static void _on_msg_error_happened (TnySendQueue *self,
 static void _on_queue_start        (TnySendQueue *self, 
                                    gpointer user_data);
 
+static void _on_queue_stop         (TnySendQueue *self,
+                                   gpointer data);
+
 static void modest_tny_send_queue_add_async (TnySendQueue *self, 
                                             TnyMsg *msg, 
                                             TnySendQueueAddCallback callback, 
@@ -108,6 +111,8 @@ struct _ModestTnySendQueuePrivate {
 
        /* last was send receive operation?*/
        gboolean requested_send_receive;
+
+       gboolean sending;
 };
 
 #define MODEST_TNY_SEND_QUEUE_GET_PRIVATE(o)      (G_TYPE_INSTANCE_GET_PRIVATE((o), \
@@ -399,6 +404,9 @@ modest_tny_send_queue_instance_init (GTypeInstance *instance, gpointer g_class)
        priv = MODEST_TNY_SEND_QUEUE_GET_PRIVATE (instance);
        priv->queue = g_queue_new();
        priv->current = NULL;
+       priv->outbox = NULL;
+       priv->sentbox = NULL;
+       priv->sending = FALSE;
 }
 
 static void
@@ -504,10 +512,14 @@ modest_tny_send_queue_new (TnyCamelTransportAccount *account)
        g_signal_connect (G_OBJECT(self), "error-happened",
                          G_CALLBACK(_on_msg_error_happened),
                          NULL);
+
        g_signal_connect (G_OBJECT (self), "queue-start",
                          G_CALLBACK (_on_queue_start),
                          NULL);
 
+       g_signal_connect (G_OBJECT (self), "queue-stop",
+                         G_CALLBACK (_on_queue_stop),
+                         NULL);
 
        priv->requested_send_receive = FALSE;
 
@@ -543,7 +555,7 @@ modest_tny_send_queue_sending_in_progress (ModestTnySendQueue* self)
        
        priv = MODEST_TNY_SEND_QUEUE_GET_PRIVATE (self);
        
-       return priv->current != NULL;
+       return priv->sending;
 }
 
 ModestTnySendQueueStatus
@@ -738,6 +750,7 @@ static void
 _on_queue_start (TnySendQueue *self,
                 gpointer data)
 {
+       ModestTnySendQueuePrivate *priv;
        ModestMailOperation *mail_op;
 
        mail_op = modest_mail_operation_new (NULL);
@@ -745,6 +758,19 @@ _on_queue_start (TnySendQueue *self,
                                         mail_op);
        modest_mail_operation_run_queue (mail_op, MODEST_TNY_SEND_QUEUE (self));
        g_object_unref (mail_op);
+
+       priv = MODEST_TNY_SEND_QUEUE_GET_PRIVATE (self);
+       priv->sending = TRUE;
+}
+
+static void 
+_on_queue_stop (TnySendQueue *self,
+               gpointer data)
+{
+       ModestTnySendQueuePrivate *priv;
+
+       priv = MODEST_TNY_SEND_QUEUE_GET_PRIVATE (self);
+       priv->sending = FALSE;
 }
 
 static void 
index 983fc14..b0a7961 100644 (file)
@@ -2515,7 +2515,7 @@ modest_ui_actions_on_msg_link_hover (ModestMsgView *msgview, const gchar* link,
                                     ModestWindow *win)
 {
        /* g_message ("%s %s", __FUNCTION__, link); */
-}      
+}
 
 
 void
@@ -2535,7 +2535,7 @@ modest_ui_actions_on_msg_link_contextual (ModestMsgView *msgview, const gchar* l
 void
 modest_ui_actions_on_msg_attachment_clicked (ModestMsgView *msgview, TnyMimePart *mime_part,
                                             ModestWindow *win)
-{              
+{
        /* we check for low-mem; in that case, show a warning, and don't allow
         * viewing attachments
         */
@@ -4989,7 +4989,7 @@ modest_ui_actions_on_main_window_remove_attachments (GtkAction *action,
                                                                         NULL, NULL);
                modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op);
                modest_mail_operation_get_msg (mail_op, header, FALSE, open_msg_for_purge_cb, win);
-               
+
                g_object_unref (mail_op);
        }
        if (header)
index 68833fa..1469803 100644 (file)
@@ -110,13 +110,13 @@ modest_utils_create_temp_stream (const gchar *orig_name, const gchar *hash_base,
                           __FUNCTION__, orig_name);
                return NULL;
        }
-       
+
        if (g_strstr_len (orig_name, strlen(orig_name), "/") != NULL) {
                g_warning ("%s: filename contains '/' character(s) (%s)",
                           __FUNCTION__, orig_name);
                return NULL;
        }
-               
+
        /* make a random subdir under /tmp or /var/tmp */
        if (hash_base != NULL) {
                hash_number = g_str_hash (hash_base);
@@ -146,7 +146,7 @@ modest_utils_create_temp_stream (const gchar *orig_name, const gchar *hash_base,
                fd = g_open (filepath, O_CREAT|O_WRONLY|O_TRUNC, 0644);
                if (fd == -1) {
                        g_warning ("%s: failed to create '%s': %s",
-                                       __FUNCTION__, filepath, g_strerror(errno));                     
+                                       __FUNCTION__, filepath, g_strerror(errno));
                        g_free (filepath);
                        g_free (tmpdir);
                        return NULL;