Some refactoring in SettingsDlg

[irwi] / src / settingsdlg.cpp

diff --git a/src/settingsdlg.cpp b/src/settingsdlg.cpp
index 4b7d5b3..e92586a 100644 (file)
--- a/src/settingsdlg.cpp
+++ b/src/settingsdlg.cpp
@@ -20,7 +20,7 @@ SettingsDlg::SettingsDlg(QWidget *parent)
     m_remoteNameLayout = new QHBoxLayout(this);
     
     m_advSettingsBtn = new QPushButton(tr("Advanced"), this);
-    m_selectRemoteBtn = new QPushButton(tr("Select m_remote"), this);
+    m_selectRemoteBtn = new QPushButton(tr("Select remote"), this);
     m_aboutBtn = new QPushButton(tr("About"), this);
     m_rateUpBtn = new QPushButton(
             QIcon(settings.value("rateUpIcon",
@@ -61,7 +61,14 @@ SettingsDlg::SettingsDlg(QWidget *parent)
     m_layout->addLayout(m_btnLayout);
     this->setLayout(m_layout);
 
-    initRemote();
+    QString selectedRemote = QSettings(this).value("remoteName", "").toString();
+    if (selectedRemote == "") {
+        m_remoteNameLabel->setText("No remote selected");
+        enableRateBtns(false);
+    } else {
+        setRemote(selectedRemote);
+        m_remote.updateInfo();
+    }
 }
 
 SettingsDlg::~SettingsDlg()
@@ -87,7 +94,7 @@ void SettingsDlg::showAdvSettingsDlg()
 void SettingsDlg::showSelectRemoteDlg()
 {
     SelectRemoteDlg dlg(this);
-    connect(&dlg, SIGNAL(m_remoteChanged(Remote)),
+    connect(&dlg, SIGNAL(remoteChanged(Remote)),
             this, SLOT(setRemote(Remote)));
     dlg.exec();
 }
@@ -98,25 +105,24 @@ void SettingsDlg::showAboutDlg()
     dlg.exec();
 }
 
-void SettingsDlg::initRemote()
-{
-    QString selectedRemote = QSettings(this).value("remoteName", "").toString();
-    if (selectedRemote == "") {
-        m_remoteNameLabel->setText("No remote selected");
-        enableRateBtns(false);
-    } else {
-        m_remote = Remote(selectedRemote);
-        connect(&m_remote, SIGNAL(infoUpdated()),
-                this, SLOT(updateRemoteInfo()));
-        m_remote.updateInfo();
-        enableRateBtns();
-    }
-}
-
 void SettingsDlg::setRemote(Remote r)
 {
     m_remote = r;
+    processRemoteChange();
     updateRemoteInfo();
+}
+
+void SettingsDlg::setRemote(const QString &name)
+{
+    m_remote = Remote(name);
+    processRemoteChange();
+    m_remote.updateInfo();  // request update from server
+}
+
+void SettingsDlg::processRemoteChange()
+{
+    connect(&m_remote, SIGNAL(infoUpdated()),
+            this, SLOT(updateRemoteInfo()));
     enableRateBtns();
 }
 
@@ -130,13 +136,19 @@ void SettingsDlg::updateRemoteInfo()
 void SettingsDlg::rateUpClicked()
 {
     m_remote.sendRating(Rating::Up);
-    enableRateBtns(false);
+    processRatingSent();
 }
 
 void SettingsDlg::rateDownClicked()
 {
     m_remote.sendRating(Rating::Down);
+    processRatingSent();
+}
+
+void SettingsDlg::processRatingSent()
+{
     enableRateBtns(false);
+    m_remote.updateInfo();
 }
 
 void SettingsDlg::enableRateBtns(bool enable)