Fix SHA-256-based KDF when using CCMP as the pairwise cipher
[wpasupplicant] / src / rsn_supp / wpa_ft.c
index c89b89a..9a39ed2 100644 (file)
 #include "wpa_ie.h"
 #include "aes_wrap.h"
 #include "ieee802_11_defs.h"
+#include "ieee802_11_common.h"
 
 #ifdef CONFIG_IEEE80211R
 
 int wpa_derive_ptk_ft(struct wpa_sm *sm, const unsigned char *src_addr,
                      const struct wpa_eapol_key *key,
-                     struct wpa_ptk *ptk)
+                     struct wpa_ptk *ptk, size_t ptk_len)
 {
        u8 pmk_r1_name[WPA_PMK_NAME_LEN];
        u8 ptk_name[WPA_PMK_NAME_LEN];
@@ -50,8 +51,8 @@ int wpa_derive_ptk_ft(struct wpa_sm *sm, const unsigned char *src_addr,
        wpa_hexdump(MSG_DEBUG, "FT: PMKR1Name", pmk_r1_name, WPA_PMK_NAME_LEN);
        wpa_pmk_r1_to_ptk(sm->pmk_r1, sm->snonce, anonce, sm->own_addr,
                          sm->bssid, pmk_r1_name,
-                         (u8 *) ptk, sizeof(*ptk), ptk_name);
-       wpa_hexdump_key(MSG_DEBUG, "FT: PTK", (u8 *) ptk, sizeof(*ptk));
+                         (u8 *) ptk, ptk_len, ptk_name);
+       wpa_hexdump_key(MSG_DEBUG, "FT: PTK", (u8 *) ptk, ptk_len);
        wpa_hexdump(MSG_DEBUG, "FT: PTKName", ptk_name, WPA_PMK_NAME_LEN);
 
        return 0;
@@ -105,20 +106,23 @@ int wpa_sm_set_ft_params(struct wpa_sm *sm, const u8 *mobility_domain,
 
 
 /**
- * wpa_ft_gen_req_ies - Generate FT (IEEE 802.11r) IEs for Auth Request
+ * wpa_ft_gen_req_ies - Generate FT (IEEE 802.11r) IEs for Auth/ReAssoc Request
  * @sm: Pointer to WPA state machine data from wpa_sm_init()
  * @len: Buffer for returning the length of the IEs
  * @anonce: ANonce or %NULL if not yet available
  * @pmk_name: PMKR0Name or PMKR1Name to be added into the RSN IE PMKID List
  * @kck: 128-bit KCK for MIC or %NULL if no MIC is used
  * @target_ap: Target AP address
+ * @ric_ies: Optional IE(s), e.g., WMM TSPEC(s), for RIC-Request or %NULL
+ * @ric_ies_len: Length of ric_ies buffer in octets
  * Returns: Pointer to buffer with IEs or %NULL on failure
  *
  * Caller is responsible for freeing the returned buffer with os_free();
  */
 static u8 * wpa_ft_gen_req_ies(struct wpa_sm *sm, size_t *len,
                               const u8 *anonce, const u8 *pmk_name,
-                              const u8 *kck, const u8 *target_ap)
+                              const u8 *kck, const u8 *target_ap,
+                              const u8 *ric_ies, size_t ric_ies_len)
 {
        size_t buf_len;
        u8 *buf, *pos, *ftie_len, *ftie_pos;
@@ -130,13 +134,13 @@ static u8 * wpa_ft_gen_req_ies(struct wpa_sm *sm, size_t *len,
        sm->ft_completed = 0;
 
        buf_len = 2 + sizeof(struct rsn_mdie) + 2 + sizeof(struct rsn_ftie) +
-               2 + sm->r0kh_id_len + 100;
+               2 + sm->r0kh_id_len + ric_ies_len + 100;
        buf = os_zalloc(buf_len);
        if (buf == NULL)
                return NULL;
        pos = buf;
 
-       /* RSNIE[PMKR0Name] */
+       /* RSNIE[PMKR0Name/PMKR1Name] */
        rsnie = (struct rsn_ie_hdr *) pos;
        rsnie->elem_id = WLAN_EID_RSN;
        WPA_PUT_LE16(rsnie->version, RSN_VERSION);
@@ -241,6 +245,12 @@ static u8 * wpa_ft_gen_req_ies(struct wpa_sm *sm, size_t *len,
        pos += sm->r0kh_id_len;
        *ftie_len = pos - ftie_len - 1;
 
+       if (ric_ies) {
+               /* RIC Request */
+               os_memcpy(pos, ric_ies, ric_ies_len);
+               pos += ric_ies_len;
+       }
+
        if (kck) {
                /*
                 * IEEE Std 802.11r-2008, 11A.8.4
@@ -253,12 +263,14 @@ static u8 * wpa_ft_gen_req_ies(struct wpa_sm *sm, size_t *len,
                 * FTIE (with MIC field set to 0)
                 * RIC-Request (if present)
                 */
-               ftie->mic_control[1] = 3; /* Information element count */
+               /* Information element count */
+               ftie->mic_control[1] = 3 + ieee802_11_ie_count(ric_ies,
+                                                              ric_ies_len);
                if (wpa_ft_mic(kck, sm->own_addr, target_ap, 5,
                               ((u8 *) mdie) - 2, 2 + sizeof(*mdie),
                               ftie_pos, 2 + *ftie_len,
-                              (u8 *) rsnie, 2 + rsnie->len, NULL, 0,
-                              ftie->mic) < 0) {
+                              (u8 *) rsnie, 2 + rsnie->len, ric_ies,
+                              ric_ies_len, ftie->mic) < 0) {
                        wpa_printf(MSG_INFO, "FT: Failed to calculate MIC");
                        os_free(buf);
                        return NULL;
@@ -288,6 +300,8 @@ struct wpa_ft_ies {
        size_t tie_len;
        const u8 *igtk;
        size_t igtk_len;
+       const u8 *ric;
+       size_t ric_len;
 };
 
 
@@ -346,6 +360,8 @@ static int wpa_ft_parse_ies(const u8 *ies, size_t ies_len,
        const u8 *end, *pos;
        struct wpa_ie_data data;
        int ret;
+       const struct rsn_ftie *ftie;
+       int prot_ie_count = 0;
 
        os_memset(parse, 0, sizeof(*parse));
        if (ies == NULL)
@@ -374,6 +390,10 @@ static int wpa_ft_parse_ies(const u8 *ies, size_t ies_len,
                        parse->mdie_len = pos[1];
                        break;
                case WLAN_EID_FAST_BSS_TRANSITION:
+                       if (pos[1] < sizeof(*ftie))
+                               return -1;
+                       ftie = (const struct rsn_ftie *) (pos + 2);
+                       prot_ie_count = ftie->mic_control[1];
                        if (wpa_ft_parse_ftie(pos + 2, pos[1], parse) < 0)
                                return -1;
                        break;
@@ -381,11 +401,55 @@ static int wpa_ft_parse_ies(const u8 *ies, size_t ies_len,
                        parse->tie = pos + 2;
                        parse->tie_len = pos[1];
                        break;
+               case WLAN_EID_RIC_DATA:
+                       if (parse->ric == NULL)
+                               parse->ric = pos;
                }
 
                pos += 2 + pos[1];
        }
 
+       if (prot_ie_count == 0)
+               return 0; /* no MIC */
+
+       /*
+        * Check that the protected IE count matches with IEs included in the
+        * frame.
+        */
+       if (parse->rsn)
+               prot_ie_count--;
+       if (parse->mdie)
+               prot_ie_count--;
+       if (parse->ftie)
+               prot_ie_count--;
+       if (parse->tie)
+               prot_ie_count--;
+       if (prot_ie_count < 0) {
+               wpa_printf(MSG_DEBUG, "FT: Some required IEs not included in "
+                          "the protected IE count");
+               return -1;
+       }
+
+       if (prot_ie_count == 0 && parse->ric) {
+               wpa_printf(MSG_DEBUG, "FT: RIC IE(s) in the frame, but not "
+                          "included in protected IE count");
+               return -1;
+       }
+
+       /* Determine the end of the RIC IE(s) */
+       pos = parse->ric;
+       while (pos && pos + 2 <= end && pos + 2 + pos[1] <= end &&
+              prot_ie_count) {
+               prot_ie_count--;
+               pos += 2 + pos[1];
+       }
+       parse->ric_len = pos - parse->ric;
+       if (prot_ie_count) {
+               wpa_printf(MSG_DEBUG, "FT: %d protected IEs missing from "
+                          "frame", (int) prot_ie_count);
+               return -1;
+       }
+
        return 0;
 }
 
@@ -440,7 +504,7 @@ int wpa_ft_prepare_auth_request(struct wpa_sm *sm)
        }
 
        ft_ies = wpa_ft_gen_req_ies(sm, &ft_ies_len, NULL, sm->pmk_r0_name,
-                                   NULL, sm->bssid);
+                                   NULL, sm->bssid, NULL, 0);
        if (ft_ies) {
                wpa_sm_update_ft_ies(sm, sm->mobility_domain,
                                     ft_ies, ft_ies_len);
@@ -452,10 +516,11 @@ int wpa_ft_prepare_auth_request(struct wpa_sm *sm)
 
 
 int wpa_ft_process_response(struct wpa_sm *sm, const u8 *ies, size_t ies_len,
-                           int ft_action, const u8 *target_ap)
+                           int ft_action, const u8 *target_ap,
+                           const u8 *ric_ies, size_t ric_ies_len)
 {
        u8 *ft_ies;
-       size_t ft_ies_len;
+       size_t ft_ies_len, ptk_len;
        struct wpa_ft_ies parse;
        struct rsn_mdie *mdie;
        struct rsn_ftie *ftie;
@@ -464,6 +529,7 @@ int wpa_ft_process_response(struct wpa_sm *sm, const u8 *ies, size_t ies_len,
        const u8 *bssid;
 
        wpa_hexdump(MSG_DEBUG, "FT: Response IEs", ies, ies_len);
+       wpa_hexdump(MSG_DEBUG, "FT: RIC IEs", ric_ies, ric_ies_len);
 
        if (ft_action) {
                if (!sm->over_the_ds_in_progress) {
@@ -545,15 +611,17 @@ int wpa_ft_process_response(struct wpa_sm *sm, const u8 *ies, size_t ies_len,
                    sm->pmk_r1_name, WPA_PMK_NAME_LEN);
 
        bssid = target_ap;
+       ptk_len = sm->pairwise_cipher == WPA_CIPHER_CCMP ? 48 : 64;
        wpa_pmk_r1_to_ptk(sm->pmk_r1, sm->snonce, ftie->anonce, sm->own_addr,
                          bssid, sm->pmk_r1_name,
-                         (u8 *) &sm->ptk, sizeof(sm->ptk), ptk_name);
+                         (u8 *) &sm->ptk, ptk_len, ptk_name);
        wpa_hexdump_key(MSG_DEBUG, "FT: PTK",
-                       (u8 *) &sm->ptk, sizeof(sm->ptk));
+                       (u8 *) &sm->ptk, ptk_len);
        wpa_hexdump(MSG_DEBUG, "FT: PTKName", ptk_name, WPA_PMK_NAME_LEN);
 
        ft_ies = wpa_ft_gen_req_ies(sm, &ft_ies_len, ftie->anonce,
-                                   sm->pmk_r1_name, sm->ptk.kck, bssid);
+                                   sm->pmk_r1_name, sm->ptk.kck, bssid,
+                                   ric_ies, ric_ies_len);
        if (ft_ies) {
                wpa_sm_update_ft_ies(sm, sm->mobility_domain,
                                     ft_ies, ft_ies_len);
@@ -803,16 +871,11 @@ int wpa_ft_validate_reassoc_resp(struct wpa_sm *sm, const u8 *ies,
        if (parse.tie)
                count++;
 
-       if (ftie->mic_control[1] != count) {
-               wpa_printf(MSG_DEBUG, "FT: Unexpected IE count in FTIE (%d)",
-                          ftie->mic_control[1]);
-               return -1;
-       }
-
        if (wpa_ft_mic(sm->ptk.kck, sm->own_addr, src_addr, 6,
                       parse.mdie - 2, parse.mdie_len + 2,
                       parse.ftie - 2, parse.ftie_len + 2,
-                      parse.rsn - 2, parse.rsn_len + 2, NULL, 0,
+                      parse.rsn - 2, parse.rsn_len + 2,
+                      parse.ric, parse.ric_len,
                       mic) < 0) {
                wpa_printf(MSG_DEBUG, "FT: Failed to calculate MIC");
                return -1;
@@ -833,6 +896,12 @@ int wpa_ft_validate_reassoc_resp(struct wpa_sm *sm, const u8 *ies,
                return -1;
 #endif /* CONFIG_IEEE80211W */
 
+       if (parse.ric) {
+               wpa_hexdump(MSG_MSGDUMP, "FT: RIC Response",
+                           parse.ric, parse.ric_len);
+               /* TODO: parse response and inform driver about results */
+       }
+
        return 0;
 }
 
@@ -857,7 +926,7 @@ int wpa_ft_start_over_ds(struct wpa_sm *sm, const u8 *target_ap)
        }
 
        ft_ies = wpa_ft_gen_req_ies(sm, &ft_ies_len, NULL, sm->pmk_r0_name,
-                                   NULL, target_ap);
+                                   NULL, target_ap, NULL, 0);
        if (ft_ies) {
                sm->over_the_ds_in_progress = 1;
                os_memcpy(sm->target_ap, target_ap, ETH_ALEN);