Very first changes to embrace the new tinymail session code
[modest] / src / modest-tny-account-store.c
index e4efc5f..6f35370 100644 (file)
 #include <libgnomevfs/gnome-vfs-volume-monitor.h>
 
 /* 'private'/'protected' functions */
-static void modest_tny_account_store_class_init   (ModestTnyAccountStoreClass *klass);
-//static void modest_tny_account_store_init         (ModestTnyAccountStore *obj);
-static void modest_tny_account_store_finalize     (GObject *obj);
+static void    modest_tny_account_store_class_init   (ModestTnyAccountStoreClass *klass);
+
+static void    modest_tny_account_store_finalize     (GObject *obj);
 
-/* implementations for tny-account-store-iface */
 static void    modest_tny_account_store_instance_init (ModestTnyAccountStore *obj);
+
 static void    modest_tny_account_store_init          (gpointer g, gpointer iface_data);
 
+static void    modest_tny_account_store_base_init     (gpointer g_class);
 
 static void    get_server_accounts                    (TnyAccountStore *self, 
                                                       TnyList *list, 
@@ -88,6 +89,9 @@ static void    get_server_accounts                    (TnyAccountStore *self,
 
 /* list my signals */
 enum {
+       ACCOUNT_CHANGED_SIGNAL,
+       ACCOUNT_INSERTED_SIGNAL,
+       ACCOUNT_REMOVED_SIGNAL,
        ACCOUNT_UPDATE_SIGNAL,
        PASSWORD_REQUESTED_SIGNAL,
        LAST_SIGNAL
@@ -132,7 +136,7 @@ modest_tny_account_store_get_type (void)
        if (!my_type) {
                static const GTypeInfo my_info = {
                        sizeof(ModestTnyAccountStoreClass),
-                       NULL,           /* base init */
+                       modest_tny_account_store_base_init,     /* base init */
                        NULL,           /* base finalize */
                        (GClassInitFunc) modest_tny_account_store_class_init,
                        NULL,           /* class finalize */
@@ -158,6 +162,74 @@ modest_tny_account_store_get_type (void)
        return my_type;
 }
 
+
+static void
+modest_tny_account_store_base_init (gpointer g_class)
+{
+       static gboolean tny_account_store_initialized = FALSE;
+
+       if (!tny_account_store_initialized) {
+
+               signals[ACCOUNT_CHANGED_SIGNAL] =
+                       g_signal_new ("account_changed",
+                                     MODEST_TYPE_TNY_ACCOUNT_STORE,
+                                     G_SIGNAL_RUN_FIRST,
+                                     G_STRUCT_OFFSET (ModestTnyAccountStoreClass, account_changed),
+                                     NULL, NULL,
+                                     g_cclosure_marshal_VOID__POINTER,
+                                     G_TYPE_NONE, 1, TNY_TYPE_ACCOUNT);
+
+               signals[ACCOUNT_INSERTED_SIGNAL] =
+                       g_signal_new ("account_inserted",
+                                     MODEST_TYPE_TNY_ACCOUNT_STORE,
+                                     G_SIGNAL_RUN_FIRST,
+                                     G_STRUCT_OFFSET (ModestTnyAccountStoreClass, account_inserted),
+                                     NULL, NULL,
+                                     g_cclosure_marshal_VOID__POINTER,
+                                     G_TYPE_NONE, 1, TNY_TYPE_ACCOUNT);
+               
+               signals[ACCOUNT_REMOVED_SIGNAL] =
+                       g_signal_new ("account_removed",
+                                     MODEST_TYPE_TNY_ACCOUNT_STORE,
+                                     G_SIGNAL_RUN_FIRST,
+                                     G_STRUCT_OFFSET (ModestTnyAccountStoreClass, account_removed),
+                                     NULL, NULL,
+                                     g_cclosure_marshal_VOID__POINTER,
+                                     G_TYPE_NONE, 1, TNY_TYPE_ACCOUNT);
+               
+/*             signals[TNY_ACCOUNT_STORE_CONNECTING_FINISHED] = */
+/*                     g_signal_new ("connecting_finished", */
+/*                                   TNY_TYPE_ACCOUNT_STORE, */
+/*                                   G_SIGNAL_RUN_FIRST, */
+/*                                   G_STRUCT_OFFSET (TnyAccountStoreIface, connecting_finished), */
+/*                                   NULL, NULL, */
+/*                                   g_cclosure_marshal_VOID__VOID,  */
+/*                                   G_TYPE_NONE, 0); */
+
+               signals[ACCOUNT_UPDATE_SIGNAL] =
+                       g_signal_new ("account_update",
+                                     MODEST_TYPE_TNY_ACCOUNT_STORE,
+                                     G_SIGNAL_RUN_FIRST,
+                                     G_STRUCT_OFFSET(ModestTnyAccountStoreClass, account_update),
+                                     NULL, NULL,
+                                     g_cclosure_marshal_VOID__STRING,
+                                     G_TYPE_NONE, 1, G_TYPE_STRING);
+               
+               signals[PASSWORD_REQUESTED_SIGNAL] =
+                       g_signal_new ("password_requested",
+                                     MODEST_TYPE_TNY_ACCOUNT_STORE,
+                                     G_SIGNAL_RUN_FIRST,
+                                     G_STRUCT_OFFSET(ModestTnyAccountStoreClass, password_requested),
+                                     NULL, NULL,
+                                     modest_marshal_VOID__STRING_POINTER_POINTER_POINTER_POINTER,
+                                     G_TYPE_NONE, 5, G_TYPE_STRING, G_TYPE_POINTER, G_TYPE_POINTER, G_TYPE_POINTER,
+                                     G_TYPE_POINTER);          
+
+               tny_account_store_initialized = TRUE;
+       }
+}
+
+
 static void
 modest_tny_account_store_class_init (ModestTnyAccountStoreClass *klass)
 {
@@ -169,25 +241,6 @@ modest_tny_account_store_class_init (ModestTnyAccountStoreClass *klass)
 
        g_type_class_add_private (gobject_class,
                                  sizeof(ModestTnyAccountStorePrivate));
-
-        signals[ACCOUNT_UPDATE_SIGNAL] =
-               g_signal_new ("account_update",
-                             G_TYPE_FROM_CLASS (gobject_class),
-                             G_SIGNAL_RUN_FIRST,
-                             G_STRUCT_OFFSET(ModestTnyAccountStoreClass, account_update),
-                             NULL, NULL,
-                             g_cclosure_marshal_VOID__STRING,
-                             G_TYPE_NONE, 1, G_TYPE_STRING);
-        
-        signals[PASSWORD_REQUESTED_SIGNAL] =
-                g_signal_new ("password_requested",
-                              G_TYPE_FROM_CLASS (gobject_class),
-                              G_SIGNAL_RUN_FIRST,
-                              G_STRUCT_OFFSET(ModestTnyAccountStoreClass, password_requested),
-                              NULL, NULL,
-                              modest_marshal_VOID__STRING_POINTER_POINTER_POINTER_POINTER,
-                              G_TYPE_NONE, 5, G_TYPE_STRING, G_TYPE_POINTER, G_TYPE_POINTER, G_TYPE_POINTER,
-                              G_TYPE_POINTER);
 }
 
 
@@ -271,6 +324,8 @@ account_list_disconnect (GSList *accounts)
 static void
 recreate_all_accounts (ModestTnyAccountStore *self)
 {
+       /* printf ("DEBUG: %s\n", __FUNCTION__); */
+       
        ModestTnyAccountStorePrivate *priv = 
                MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
        
@@ -279,19 +334,23 @@ recreate_all_accounts (ModestTnyAccountStore *self)
                priv->store_accounts_outboxes = NULL;
        }
                        
+                       
        if (priv->store_accounts) {
                account_list_free (priv->store_accounts);
                priv->store_accounts = NULL;
-               get_server_accounts (TNY_ACCOUNT_STORE(self),
-                                            NULL, TNY_ACCOUNT_TYPE_STORE);
        }
        
+       get_server_accounts (TNY_ACCOUNT_STORE(self),
+                                            NULL, TNY_ACCOUNT_TYPE_STORE);
+       
+       
        if (priv->transport_accounts) {
                account_list_free (priv->transport_accounts);
                priv->transport_accounts = NULL;
-               get_server_accounts (TNY_ACCOUNT_STORE(self), NULL,
-                                            TNY_ACCOUNT_TYPE_TRANSPORT);
        }
+       
+       get_server_accounts (TNY_ACCOUNT_STORE(self), NULL,
+                                            TNY_ACCOUNT_TYPE_TRANSPORT);
 }
 
 static void
@@ -343,37 +402,31 @@ on_vfs_volume_unmounted(GnomeVFSVolumeMonitor *volume_monitor,
 static void
 on_account_removed (ModestAccountMgr *acc_mgr, 
                    const gchar *account,
-                   gboolean is_server_account,
                    gpointer user_data)
 {
+       TnyAccount *store_account = NULL, *transport_account = NULL;
        ModestTnyAccountStore *self = MODEST_TNY_ACCOUNT_STORE(user_data);
-       TnyAccount *server_account;
        
-       /* Clear the account cache */
-       server_account = modest_tny_account_store_get_tny_account_by  (self, 
-                                                                     MODEST_TNY_ACCOUNT_STORE_QUERY_ID, 
-                                                                     account);
-       if (server_account) {
-               if (TNY_IS_STORE_ACCOUNT (server_account)) {
-
-                       tny_store_account_delete_cache (TNY_STORE_ACCOUNT (server_account));
-               
-                       g_signal_emit (G_OBJECT (self), 
-                                      tny_account_store_signals [TNY_ACCOUNT_STORE_ACCOUNT_REMOVED], 
-                                      0, server_account);
-
-/*                     /\* FIXME: make this more finegrained; changes do not */
-/*                      * really affect _all_ accounts, and some do not */
-/*                      * affect tny accounts at all (such as 'last_update') */
-/*                      *\/ */
-/*                     recreate_all_accounts (self); */
-                       
-/*                     g_signal_emit (G_OBJECT(self), signals[ACCOUNT_UPDATE_SIGNAL], 0, */
-/*                                    account); */
-               }
-               g_object_unref (server_account);
-       } else
-               g_printerr ("modest: cannot find server account for %s", account);
+       /* Get the server and the transport account */
+       store_account = 
+               modest_tny_account_store_get_server_account (self, account, TNY_ACCOUNT_TYPE_STORE);
+       transport_account = 
+               modest_tny_account_store_get_server_account (self, account, TNY_ACCOUNT_TYPE_TRANSPORT);
+
+       /* Clear the cache */
+       tny_store_account_delete_cache (TNY_STORE_ACCOUNT (store_account));
+
+       /* Notify the observers */
+       g_signal_emit (G_OBJECT (self),
+                      signals [ACCOUNT_REMOVED_SIGNAL],
+                      0, store_account);
+       g_signal_emit (G_OBJECT (self),
+                      signals [ACCOUNT_REMOVED_SIGNAL],
+                      0, transport_account);
+
+       /* Frees */
+       g_object_unref (store_account);
+       g_object_unref (transport_account);
 }
 
 /**
@@ -463,6 +516,23 @@ void on_account_settings_hide (GtkWidget *widget, gpointer user_data)
 }
 
 static 
+gboolean on_idle_wrong_password_warning_only (gpointer user_data)
+{
+       gdk_threads_enter();
+       
+       ModestWindow *main_window = 
+                               modest_window_mgr_get_main_window (modest_runtime_get_window_mgr ());
+                               
+       /* Show an explanatory temporary banner: */
+       hildon_banner_show_information ( 
+               GTK_WIDGET(main_window), NULL, _("mcen_ib_username_pw_incorrect"));
+               
+       gdk_threads_leave();
+       
+       return FALSE; /* Don't show again. */
+}
+               
+static 
 gboolean on_idle_wrong_password (gpointer user_data)
 { 
        TnyAccount *account = (TnyAccount*)user_data;
@@ -671,7 +741,7 @@ get_password (TnyAccount *account, const gchar * prompt_not_used, gboolean *canc
        
                        
                        /* The password must be wrong, so show the account settings dialog so it can be corrected: */
-                       /* We show it in the main loop, because this function might no tbe in the main loop. */
+                       /* We show it in the main loop, because this function might not be in the main loop. */
                        g_object_ref (account); /* unrefed in the idle handler. */
                        g_idle_add (on_idle_wrong_password, account);
                        
@@ -686,6 +756,11 @@ get_password (TnyAccount *account, const gchar * prompt_not_used, gboolean *canc
                gboolean remember = FALSE;
                pwd = NULL;
                
+               if (already_asked) {
+                       /* Show an info banner, before we show the protected password dialog: */
+                       g_idle_add (on_idle_wrong_password_warning_only, NULL);
+               }
+               
                request_password_in_main_loop_and_wait (self, account_id, 
                               &username, &pwd, cancel, &remember);
                
@@ -694,6 +769,9 @@ get_password (TnyAccount *account, const gchar * prompt_not_used, gboolean *canc
                         * but we need to tell tinymail about the username too: */
                        tny_account_set_user (account, username);
                        
+                       /* Do not save the password in gconf, 
+                        * because the UI spec says "The password will never be saved in the account": */
+                       /*
                        if (remember) {
                                printf ("%s: Storing username=%s, password=%s\n", 
                                        __FUNCTION__, username, pwd);
@@ -702,6 +780,8 @@ get_password (TnyAccount *account, const gchar * prompt_not_used, gboolean *canc
                                modest_server_account_set_password (priv->account_mgr, server_account_name,
                                                               pwd);
                        }
+                       */
+
                        /* We need to dup the string even knowing that
                           it's already a dup of the contents of an
                           entry, because it if it's wrong, then camel
@@ -843,7 +923,7 @@ modest_tny_account_store_new (ModestAccountMgr *account_mgr, TnyDevice *device)
        }
        
        tny_session_camel_set_ui_locker (priv->session,  tny_gtk_lockable_new ());
-       tny_session_camel_set_async_connecting (priv->session, TRUE);
+/*     tny_session_camel_set_async_connecting (priv->session, TRUE); */
                
        /* Connect signals */
        g_signal_connect (G_OBJECT(account_mgr), "account_changed",
@@ -1025,6 +1105,7 @@ get_server_accounts  (TnyAccountStore *self, TnyList *list, TnyAccountType type)
                         * modest account: */
                        GSList *iter = list_specifics;
                        while (iter) {
+                               /* The list alternates between the connection name and the transport name: */
                                /* const gchar* this_connection_name = (const gchar*)(iter->data); */
                                iter = g_slist_next (iter);
                                if (iter) {
@@ -1035,6 +1116,7 @@ get_server_accounts  (TnyAccountStore *self, TnyList *list, TnyAccountType type)
                                                tny_account = modest_tny_account_new_from_server_account_name (
                                                        priv->account_mgr, priv->session, transport_account_name);
                                                if (tny_account) {
+                                                       modest_tny_account_set_parent_modest_account_name_for_server_account (tny_account, account_name);
                                                        g_object_set_data (G_OBJECT(tny_account), "account_store",
                                                                           (gpointer)self);
                                                        if (list)
@@ -1335,48 +1417,31 @@ modest_tny_account_store_alert (TnyAccountStore *self, TnyAccount *account, TnyA
        if (!prompt)
                return FALSE;
 
-#ifdef MODEST_PLATFORM_MAEMO
-       /* The Tinymail documentation says that we should show Yes and No buttons, 
-        * when it is a question.
-        * Obviously, we need tinymail to use more specific error codes instead,
-        * so we know what buttons to show. */
-        GtkWidget *dialog = NULL;
-        if (question) {
-               dialog = GTK_WIDGET (hildon_note_new_confirmation (NULL, 
+       ModestWindow *main_window = 
+               modest_window_mgr_get_main_window (modest_runtime_get_window_mgr ());
+       gboolean retval = TRUE;
+       if (question) {
+               /* The Tinymail documentation says that we should show Yes and No buttons, 
+                * when it is a question.
+                * Obviously, we need tinymail to use more specific error codes instead,
+                * so we know what buttons to show. */
+        
+               /* TODO: Do this in the main context: */
+               GtkWidget *dialog = GTK_WIDGET (hildon_note_new_confirmation (GTK_WINDOW (main_window), 
                        prompt));
+               const int response = gtk_dialog_run (GTK_DIALOG (dialog));
+               if (question) {
+                       retval = (response == GTK_RESPONSE_YES) ||
+                                        (response == GTK_RESPONSE_OK);
+               }
+       
+               gtk_widget_destroy (dialog);
+       
         } else {
-               dialog = GTK_WIDGET (hildon_note_new_information (NULL, 
-                       prompt));
+               /* Just show the error text and use the default response: */
+               modest_maemo_show_information_note_in_main_context_and_forget (GTK_WINDOW (main_window), 
+                       prompt);
         }
-#else
-
-       GtkMessageType gtktype = GTK_MESSAGE_ERROR;
-       switch (type)
-       {
-               case TNY_ALERT_TYPE_INFO:
-               gtktype = GTK_MESSAGE_INFO;
-               break;
-               case TNY_ALERT_TYPE_WARNING:
-               gtktype = GTK_MESSAGE_WARNING;
-               break;
-               case TNY_ALERT_TYPE_ERROR:
-               default:
-               gtktype = GTK_MESSAGE_ERROR;
-               break;
-       }
-       
-       GtkWidget *dialog = gtk_message_dialog_new (NULL, 0,
-               gtktype, GTK_BUTTONS_YES_NO, prompt);
-#endif /* #ifdef MODEST_PLATFORM_MAEMO */
-
-       gboolean retval = TRUE;
-       const int response = gtk_dialog_run (GTK_DIALOG (dialog));
-       if (question) {
-               retval = (response == GTK_RESPONSE_YES) ||
-                                (response == GTK_RESPONSE_OK);
-       }
-
-       gtk_widget_destroy (dialog);
        
        /* TODO: Don't free this when we no longer strdup the message for testers. */
        g_free (prompt);
@@ -1515,59 +1580,62 @@ modest_tny_account_store_get_tny_account_by (ModestTnyAccountStore *self,
 
 TnyAccount*
 modest_tny_account_store_get_server_account (ModestTnyAccountStore *self,
-                                                    const gchar *account_name,
-                                                    TnyAccountType type)
+                                            const gchar *account_name,
+                                            TnyAccountType type)
 {
+       ModestTnyAccountStorePrivate *priv = NULL;
        TnyAccount *account = NULL;
-       gchar *id = NULL;
-       ModestTnyAccountStorePrivate *priv;     
+       GSList *account_list = NULL;
+       gboolean found = FALSE;
 
        g_return_val_if_fail (self, NULL);
        g_return_val_if_fail (account_name, NULL);
-       g_return_val_if_fail (type == TNY_ACCOUNT_TYPE_STORE || type == TNY_ACCOUNT_TYPE_TRANSPORT,
+       g_return_val_if_fail (type == TNY_ACCOUNT_TYPE_STORE || 
+                             type == TNY_ACCOUNT_TYPE_TRANSPORT,
                              NULL);
        
        priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
 
-       /* Special case for the local account */
-       if (!strcmp (account_name, MODEST_LOCAL_FOLDERS_ACCOUNT_ID)) {
-               if(type == TNY_ACCOUNT_TYPE_STORE)
-                       id = g_strdup (MODEST_LOCAL_FOLDERS_ACCOUNT_ID);
-               else {
-                       /* The local folders modest account has no transport server account. */
-                       return NULL;
-               }
-       } else {
-               ModestAccountData *account_data;
-               account_data = modest_account_mgr_get_account_data (priv->account_mgr, account_name);
-               if (!account_data) {
-                       g_printerr ("modest: %s: cannot get account data for account '%s'\n", __FUNCTION__,
-                                   account_name);
-                       return NULL;
-               }
+       /* Make sure that the tny accounts have been created:
+        * TODO: We might want to do this in several places.
+        */
+       if (!priv->store_accounts || !priv->transport_accounts)
+               recreate_all_accounts (self);
 
-               if (type == TNY_ACCOUNT_TYPE_STORE && account_data->store_account)
-                       id = g_strdup (account_data->store_account->account_name);
-               else if (type == TNY_ACCOUNT_TYPE_TRANSPORT && account_data->transport_account)
-                       id = g_strdup (account_data->transport_account->account_name);
+       account_list = (type == TNY_ACCOUNT_TYPE_STORE) ? 
+               priv->store_accounts : 
+               priv->transport_accounts;
 
-               modest_account_mgr_free_account_data (priv->account_mgr, account_data);
+       if (!account_list) {
+               g_printerr ("%s: No server accounts of type %s\n", __FUNCTION__, 
+                       (type == TNY_ACCOUNT_TYPE_STORE) ? "store" : "transport");
+               return NULL;
        }
+       
+       /* Look for the server account */
+       while (account_list && !found) {
+               const gchar *modest_acc_name;
 
-       if (!id)
-               g_printerr ("modest: could not get an id for account %s\n",
-                           account_name);
-       else    
-               account = modest_tny_account_store_get_tny_account_by (self, 
-                                                                      MODEST_TNY_ACCOUNT_STORE_QUERY_ID, id);
+               account = TNY_ACCOUNT (account_list->data);
+               modest_acc_name = 
+                       modest_tny_account_get_parent_modest_account_name_for_server_account (account);
+               
+               if (!strcmp (account_name, modest_acc_name))
+                       found = TRUE;
+               else
+                       account_list = g_slist_next (account_list);     
+       }
 
-       if (!account)
-               g_printerr ("modest: could not get tny %s account for %s (id=%s)\n",
-                           type == TNY_ACCOUNT_TYPE_STORE ? "store" : "transport",
-                           account_name, id ? id : "<none>");
-       g_free (id);
+       if (!found) {
+               g_printerr ("modest: %s: could not get tny %s account for %s\n.  Number of server accounts of this type=%d\n", __FUNCTION__, 
+                           (type == TNY_ACCOUNT_TYPE_STORE) ? "store" : "transport",
+                           account_name, g_slist_length (account_list));
+       } else {
+               /* Pick a reference */
+               g_object_ref (account);
+       }
 
-       return account; 
+       return account;
 }
 
 static TnyAccount*