do some sanity checking on url/quality from command line

[presencevnc] / src / main.cpp

diff --git a/src/main.cpp b/src/main.cpp
index ad5ea07..bb24fae 100644 (file)
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -1,54 +1,85 @@
-/****************************************************************************
-**
-** Copyright (C) 2008 Urs Wolfer <uwolfer @ kde.org>
-**
-** This file is part of KDE.
-**
-** This program is free software; you can redistribute it and/or modify
-** it under the terms of the GNU General Public License as published by
-** the Free Software Foundation; either version 2 of the License, or
-** (at your option) any later version.
-**
-** This program is distributed in the hope that it will be useful,
-** but WITHOUT ANY WARRANTY; without even the implied warranty of
-** MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-** GNU General Public License for more details.
-**
-** You should have received a copy of the GNU General Public License
-** along with this program; see the file COPYING. If not, write to
-** the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
-** Boston, MA 02110-1301, USA.
-**
-****************************************************************************/
+/*
+    Presence VNC
+    Copyright (C) 2010 Christian Pulvermacher
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License along
+    with this program; if not, write to the Free Software Foundation, Inc.,
+    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+*/
+#include "mainwindow.h"
 
 #include <QApplication>
-#include <QInputDialog>
 #include <QString>
 
-#include "mainwindow.h"
+#include <iostream>
+
+
+const QString APPNAME("Presence VNC");
+
+void printHelp() {
+       std::cout << "Usage: " << qPrintable(QCoreApplication::arguments().at(0)) << " [options] [URL [quality]]\n"
+
+               << "\nOptions:\n"
+               << " --help\t\t Print this text and exit.\n"
+               << " --viewonly\t Don't send mouse/keyboard input to remote desktop. This is only useful if you also supply a URL.\n"
+
+               << "\nURLs:\n"
+               << " vnc://:password@server:display\n\n"
+               << " Password and display can be omitted, e.g. vnc://server is a valid URL.\n"
+               << " Optionally, you can define the quality as a second argument (1-3, where 1 is the best). Default is 2.\n";
+}
 
 int main(int argc, char *argv[])
 {
+       QCoreApplication::setOrganizationName(APPNAME);
+       QCoreApplication::setApplicationName(APPNAME);
+
        QApplication app(argc, argv);
 
        QString url;
        int quality = 2;
+       bool view_only = false;
+
        QStringList arguments = QCoreApplication::arguments();
-       if (arguments.count() > 1) {
-               //Example: vnc://:password@server:1\n"
-               //"Optionally, you can define the quality as second argument (1-3, where 1 is the best). Default is 2.");
-
-               url = arguments.at(1);
-               if(arguments.count() > 2)
-                       quality = arguments.at(2).toInt();
-       } else {
-               url = QInputDialog::getText(0, "Connect to Host", "VNC Server:");
-               if(url.isEmpty()) { //dialog dismissed or nothing entered
-                       return 1;
+       for(int i = 1; i < arguments.count(); i++) {
+               if(arguments.at(i) == "--help") {
+                       printHelp();
+
+                       return 0;
+               } else if(arguments.at(i) == "--viewonly") {
+                       view_only = true;
+               } else { //not a valid command line option, should be the url
+                       url = arguments.at(i);
+
+                       //check url
+                       if(!url.startsWith("vnc://")) {
+                               std::cerr << "\"" << qPrintable(url) << "\" is not a valid command line option!\n\n";
+                               printHelp();
+
+                               return 1;
+                       }
+
+                       if(arguments.count() > i+1) { //having a --quality option would make more sense.
+                               int arg = arguments.at(i+1).toInt();
+                               if(1 <= arg and arg <= 3) { //check if arg is valid, might also be another option
+                                       quality = arg;
+                                       i++;
+                               }
+                       }
                }
-               url = "vnc://" + url;
        }
-       MainWindow main(url, quality);
+
+       MainWindow main(url, quality, view_only);
        main.show();
        return app.exec();
 }