---- /dev/null 2012-04-29 08:55:34.366920721 +0200
-+++ kernel-power/drivers/power/bq2415x_charger.c 2012-04-29 17:53:57.799826239 +0200
-@@ -0,0 +1,1564 @@
+--- /dev/null
++++ kernel-power/drivers/power/bq2415x_charger.c
+@@ -0,0 +1,1655 @@
+/*
+ bq2415x_charger.c - bq2415x charger driver
+ Copyright (C) 2011-2012 Pali Rohár <pali.rohar@gmail.com>
+*/
+
+#include <linux/version.h>
++#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/param.h>
+#include <linux/err.h>
+
+#include <linux/power/bq2415x_charger.h>
+
-+#define BQ2415X_TIMER_TIMEOUT 10
++/* timeout for resetting chip timer */
++#define BQ2415X_TIMER_TIMEOUT 10
+
+#define BQ2415X_REG_STATUS 0x00
+#define BQ2415X_REG_CONTROL 0x01
+#define BQ2415X_SHIFT_REVISION 0
+
+/* current register */
-+/* RESET BIT(7) */
-+#define BQ2415X_MASK_VI_CHRG (BIT(4)|BIT(5)|BIT(6)|BIT(7))
++#define BQ2415X_MASK_RESET BIT(7)
++#define BQ2415X_MASK_VI_CHRG (BIT(4)|BIT(5)|BIT(6))
+#define BQ2415X_SHIFT_VI_CHRG 4
+/* N/A BIT(3) */
-+#define BQ2415X_MASK_VI_TERM (BIT(0)|BIT(1)|BIT(2)|BIT(7))
++#define BQ2415X_MASK_VI_TERM (BIT(0)|BIT(1)|BIT(2))
+#define BQ2415X_SHIFT_VI_TERM 0
+
+
+ BQ24158,
+};
+
-+enum bq2415x_mode {
-+ BQ2415X_MODE_NONE,
-+ BQ2415X_MODE_HOST_CHARGER,
-+ BQ2415X_MODE_DEDICATED_CHARGER,
-+ BQ2415X_MODE_BOOST,
-+};
-+
+static char *bq2415x_chip_name[] = {
+ "unknown",
+ "bq24150",
+ struct bq2415x_platform_data init_data;
+ struct power_supply charger;
+ struct delayed_work work;
-+ enum bq2415x_mode charger_mode; /* mode reported by hook function */
-+ enum bq2415x_mode mode; /* actual setted mode */
++ enum bq2415x_mode reported_mode;/* mode reported by hook function */
++ enum bq2415x_mode mode; /* current configured mode */
+ enum bq2415x_chip chip;
++ const char *timer_error;
+ char *model;
+ char *name;
+ int autotimer; /* 1 - if driver automatically reset timer, 0 - not */
+ int id;
+};
+
++/* each registered chip must have unique id */
+static DEFINE_IDR(bq2415x_id);
+
+static DEFINE_MUTEX(bq2415x_id_mutex);
+static DEFINE_MUTEX(bq2415x_timer_mutex);
+static DEFINE_MUTEX(bq2415x_i2c_mutex);
+
-+/* i2c read functions */
++/**** i2c read functions ****/
+
++/* read value from register */
+static int bq2415x_i2c_read(struct bq2415x_device *bq, u8 reg)
+{
+ struct i2c_client *client = to_i2c_client(bq->dev);
+ return val;
+}
+
++/* read value from register, apply mask and right shift it */
+static int bq2415x_i2c_read_mask(struct bq2415x_device *bq, u8 reg,
+ u8 mask, u8 shift)
+{
+ return (ret & mask) >> shift;
+}
+
++/* read value from register and return one specified bit */
+static int bq2415x_i2c_read_bit(struct bq2415x_device *bq, u8 reg, u8 bit)
+{
+ if (bit > 8)
+ return bq2415x_i2c_read_mask(bq, reg, BIT(bit), bit);
+}
+
-+/* i2c write functions */
++/**** i2c write functions ****/
+
++/* write value to register */
+static int bq2415x_i2c_write(struct bq2415x_device *bq, u8 reg, u8 val)
+{
+ struct i2c_client *client = to_i2c_client(bq->dev);
+ return 0;
+}
+
++/* read value from register, change it with mask left shifted and write back */
+static int bq2415x_i2c_write_mask(struct bq2415x_device *bq, u8 reg, u8 val,
+ u8 mask, u8 shift)
+{
+ return bq2415x_i2c_write(bq, reg, ret);
+}
+
++/* change only one bit in register */
+static int bq2415x_i2c_write_bit(struct bq2415x_device *bq, u8 reg,
+ bool val, u8 bit)
+{
+ return bq2415x_i2c_write_mask(bq, reg, val, BIT(bit), bit);
+}
+
-+/* global exec command function */
++/**** global functions ****/
+
++/* exec command function */
+static int bq2415x_exec_command(struct bq2415x_device *bq,
+ enum bq2415x_command command)
+{
+ }
+}
+
-+/* global detect chip */
-+
++/* detect chip type */
+static enum bq2415x_chip bq2415x_detect_chip(struct bq2415x_device *bq)
+{
+ struct i2c_client *client = to_i2c_client(bq->dev);
+ return BQUNKNOWN;
+}
+
++/* detect chip revision */
+static int bq2415x_detect_revision(struct bq2415x_device *bq)
+{
+ int ret = bq2415x_exec_command(bq, BQ2415X_REVISION);
+ return -1;
+}
+
++/* return chip vender code */
+static int bq2415x_get_vender_code(struct bq2415x_device *bq)
+{
+ int ret = bq2415x_exec_command(bq, BQ2415X_VENDER_CODE);
+ ((ret >> 2) & 0x1) * 100;
+}
+
-+/* global other functions */
-+
++/* reset all chip registers to default state */
+static void bq2415x_reset_chip(struct bq2415x_device *bq)
+{
+ bq2415x_i2c_write(bq, BQ2415X_REG_CURRENT, BQ2415X_RESET_CURRENT);
+ bq2415x_i2c_write(bq, BQ2415X_REG_VOLTAGE, BQ2415X_RESET_VOLTAGE);
+ bq2415x_i2c_write(bq, BQ2415X_REG_CONTROL, BQ2415X_RESET_CONTROL);
+ bq2415x_i2c_write(bq, BQ2415X_REG_STATUS, BQ2415X_RESET_STATUS);
++ bq->timer_error = NULL;
+}
+
++/**** properties functions ****/
++
++/* set current limit in mA */
+static int bq2415x_set_current_limit(struct bq2415x_device *bq, int mA)
+{
+ int val;
+ BQ2415X_MASK_LIMIT, BQ2415X_SHIFT_LIMIT);
+}
+
++/* get current limit in mA */
+static int bq2415x_get_current_limit(struct bq2415x_device *bq)
+{
+ int ret = bq2415x_i2c_read_mask(bq, BQ2415X_REG_CONTROL,
+ return -EINVAL;
+}
+
++/* set weak battery voltage in mV */
+static int bq2415x_set_weak_battery_voltage(struct bq2415x_device *bq, int mV)
+{
-+ int val = mV/100 + (mV%100 > 0 ? 1 : 0) - 34;
-+
-+ if (val < 0)
++ /* round to 100mV */
++ int val;
++ if (mV <= 3400 + 50)
+ val = 0;
-+ else if (val > 3)
++ else if (mV <= 3500 + 50)
++ val = 1;
++ else if (mV <= 3600 + 50)
++ val = 2;
++ else
+ val = 3;
-+
+ return bq2415x_i2c_write_mask(bq, BQ2415X_REG_CONTROL, val,
+ BQ2415X_MASK_VLOWV, BQ2415X_SHIFT_VLOWV);
+}
+
++/* get weak battery voltage in mV */
+static int bq2415x_get_weak_battery_voltage(struct bq2415x_device *bq)
+{
+ int ret = bq2415x_i2c_read_mask(bq, BQ2415X_REG_CONTROL,
+ return 100 * (34 + ret);
+}
+
++/* set battery regulation voltage in mV */
+static int bq2415x_set_battery_regulation_voltage(struct bq2415x_device *bq,
+ int mV)
+{
-+ int val = (mV/10 + (mV%10 > 0 ? 1 : 0) - 350) / 2;
++ int val = (mV/10 - 350) / 2;
+
+ if (val < 0)
+ val = 0;
-+ else if (val > 94) /* FIXME: Max is 94 or 122 ? */
++ else if (val > 94) /* FIXME: Max is 94 or 122 ? Set max value ? */
+ return -EINVAL;
+
+ return bq2415x_i2c_write_mask(bq, BQ2415X_REG_VOLTAGE, val,
+ BQ2415X_MASK_VO, BQ2415X_SHIFT_VO);
+}
+
++/* get battery regulation voltage in mV */
+static int bq2415x_get_battery_regulation_voltage(struct bq2415x_device *bq)
+{
+ int ret = bq2415x_i2c_read_mask(bq, BQ2415X_REG_VOLTAGE,
+ return 10 * (350 + 2*ret);
+}
+
++/* set charge current in mA (platform data must provide resistor sense) */
+static int bq2415x_set_charge_current(struct bq2415x_device *bq, int mA)
+{
+ int val;
+ if (bq->init_data.resistor_sense <= 0)
+ return -ENOSYS;
+
-+ val = (mA * bq->init_data.resistor_sense - 37400);
-+ val = val/6800 + (val%6800 > 0 ? 1 : 0);
++ val = (mA * bq->init_data.resistor_sense - 37400) / 6800;
+
+ if (val < 0)
+ val = 0;
+ val = 7;
+
+ return bq2415x_i2c_write_mask(bq, BQ2415X_REG_CURRENT, val,
-+ BQ2415X_MASK_VI_CHRG, BQ2415X_SHIFT_VI_CHRG);
++ BQ2415X_MASK_VI_CHRG | BQ2415X_MASK_RESET,
++ BQ2415X_SHIFT_VI_CHRG);
+}
+
++/* get charge current in mA (platform data must provide resistor sense) */
+static int bq2415x_get_charge_current(struct bq2415x_device *bq)
+{
+ int ret;
+ return (37400 + 6800*ret) / bq->init_data.resistor_sense;
+}
+
++/* set termination current in mA (platform data must provide resistor sense) */
+static int bq2415x_set_termination_current(struct bq2415x_device *bq, int mA)
+{
+ int val;
+ if (bq->init_data.resistor_sense <= 0)
+ return -ENOSYS;
+
-+ val = (mA * bq->init_data.resistor_sense - 3400);
-+ val = val/3400 + (val%3400 > 0 ? 1 : 0);
++ val = (mA * bq->init_data.resistor_sense - 3400) / 3400;
+
+ if (val < 0)
+ val = 0;
+ val = 7;
+
+ return bq2415x_i2c_write_mask(bq, BQ2415X_REG_CURRENT, val,
-+ BQ2415X_MASK_VI_TERM, BQ2415X_SHIFT_VI_TERM);
++ BQ2415X_MASK_VI_TERM | BQ2415X_MASK_RESET,
++ BQ2415X_SHIFT_VI_TERM);
+}
+
++/* get termination current in mA (platform data must provide resistor sense) */
+static int bq2415x_get_termination_current(struct bq2415x_device *bq)
+{
+ int ret;
+ return (3400 + 3400*ret) / bq->init_data.resistor_sense;
+}
+
-+#define bq2415x_set_default_value(bq, value) \
++/* set default value of property */
++#define bq2415x_set_default_value(bq, prop) \
+ do { \
+ int ret = 0; \
-+ if (bq->init_data.value != -1) \
-+ ret = bq2415x_set_##value(bq, bq->init_data.value); \
++ if (bq->init_data.prop != -1) \
++ ret = bq2415x_set_##prop(bq, bq->init_data.prop); \
+ if (ret < 0) \
+ return ret; \
+ } while (0)
+
++/* set default values of all properties */
+static int bq2415x_set_defaults(struct bq2415x_device *bq)
+{
+ bq2415x_exec_command(bq, BQ2415X_BOOST_MODE_DISABLE);
+ bq2415x_exec_command(bq, BQ2415X_CHARGER_DISABLE);
++ bq2415x_exec_command(bq, BQ2415X_CHARGE_TERMINATION_DISABLE);
+ bq2415x_set_default_value(bq, current_limit);
+ bq2415x_set_default_value(bq, weak_battery_voltage);
+ bq2415x_set_default_value(bq, battery_regulation_voltage);
+ return 0;
+}
+
-+#undef bq2415x_set_default_value
-+
-+/* charger mode functions */
++/**** charger mode functions ****/
+
++/* set charger mode */
+static int bq2415x_set_mode(struct bq2415x_device *bq, enum bq2415x_mode mode)
+{
+ int ret = 0;
+ int charger = 0;
++ int boost = 0;
+
-+ if (mode == BQ2415X_MODE_NONE ||
-+ mode == BQ2415X_MODE_HOST_CHARGER ||
-+ mode == BQ2415X_MODE_DEDICATED_CHARGER)
-+ charger = 1;
++ if (mode == BQ2415X_MODE_BOOST)
++ boost = 1;
++ else if (mode != BQ2415X_MODE_OFF)
++ charger = 1;
+
-+ if (charger)
-+ ret = bq2415x_exec_command(bq, BQ2415X_BOOST_MODE_DISABLE);
-+ else
++ if (!charger)
+ ret = bq2415x_exec_command(bq, BQ2415X_CHARGER_DISABLE);
+
++ if (!boost)
++ ret = bq2415x_exec_command(bq, BQ2415X_BOOST_MODE_DISABLE);
++
+ if (ret < 0)
+ return ret;
+
+ switch (mode) {
++ case BQ2415X_MODE_OFF:
++ dev_dbg(bq->dev, "changing mode to: Offline\n");
++ ret = bq2415x_set_current_limit(bq, 100);
++ break;
+ case BQ2415X_MODE_NONE:
-+ dev_info(bq->dev, "mode: N/A\n");
++ dev_dbg(bq->dev, "changing mode to: N/A\n");
+ ret = bq2415x_set_current_limit(bq, 100);
+ break;
+ case BQ2415X_MODE_HOST_CHARGER:
-+ dev_info(bq->dev, "mode: Host/HUB charger\n");
++ dev_dbg(bq->dev, "changing mode to: Host/HUB charger\n");
+ ret = bq2415x_set_current_limit(bq, 500);
+ break;
+ case BQ2415X_MODE_DEDICATED_CHARGER:
-+ dev_info(bq->dev, "mode: Dedicated charger\n");
++ dev_dbg(bq->dev, "changing mode to: Dedicated charger\n");
+ ret = bq2415x_set_current_limit(bq, 1800);
+ break;
+ case BQ2415X_MODE_BOOST: /* Boost mode */
-+ dev_info(bq->dev, "mode: Boost\n");
++ dev_dbg(bq->dev, "changing mode to: Boost\n");
+ ret = bq2415x_set_current_limit(bq, 100);
+ break;
+ }
+
+ if (charger)
+ ret = bq2415x_exec_command(bq, BQ2415X_CHARGER_ENABLE);
-+ else
++ else if (boost)
+ ret = bq2415x_exec_command(bq, BQ2415X_BOOST_MODE_ENABLE);
+
+ if (ret < 0)
+ return ret;
+
++ bq2415x_set_default_value(bq, weak_battery_voltage);
++ bq2415x_set_default_value(bq, battery_regulation_voltage);
++
+ bq->mode = mode;
++ sysfs_notify(&bq->charger.dev->kobj, NULL, "mode");
++
+ return 0;
+
+}
+
-+static void bq2415x_set_charger_type(int type, void *data)
++/* hook function called by other driver which set reported mode */
++static void bq2415x_hook_function(enum bq2415x_mode mode, void *data)
+{
+ struct bq2415x_device *bq = data;
+
+ if (!bq)
+ return;
+
-+ switch (type) {
-+ case 0:
-+ bq->charger_mode = BQ2415X_MODE_NONE;
-+ break;
-+ case 1:
-+ bq->charger_mode = BQ2415X_MODE_HOST_CHARGER;
-+ break;
-+ case 2:
-+ bq->charger_mode = BQ2415X_MODE_DEDICATED_CHARGER;
-+ break;
-+ default:
-+ return;
-+ }
++ dev_dbg(bq->dev, "hook function was called\n");
++ bq->reported_mode = mode;
+
++ /* if automode is not enabled do not tell about reported_mode */
+ if (bq->automode < 1)
+ return;
+
-+ /* TODO: Detect USB Host mode */
-+
-+ bq2415x_set_mode(bq, bq->charger_mode);
++ sysfs_notify(&bq->charger.dev->kobj, NULL, "reported_mode");
++ bq2415x_set_mode(bq, bq->reported_mode);
+
+}
+
-+/* timer functions */
++/**** timer functions ****/
+
++/* enable/disable auto resetting chip timer */
+static void bq2415x_set_autotimer(struct bq2415x_device *bq, int state)
+{
+ mutex_lock(&bq2415x_timer_mutex);
+ if (state) {
+ schedule_delayed_work(&bq->work, BQ2415X_TIMER_TIMEOUT * HZ);
+ bq2415x_exec_command(bq, BQ2415X_TIMER_RESET);
++ bq->timer_error = NULL;
+ } else {
+ cancel_delayed_work_sync(&bq->work);
+ }
+ mutex_unlock(&bq2415x_timer_mutex);
+}
+
++/* called by bq2415x_timer_work on timer error */
+static void bq2415x_timer_error(struct bq2415x_device *bq, const char *msg)
+{
++ bq->timer_error = msg;
++ sysfs_notify(&bq->charger.dev->kobj, NULL, "timer");
+ dev_err(bq->dev, "%s\n", msg);
+ if (bq->automode > 0)
+ bq->automode = 0;
-+ bq2415x_set_mode(bq, BQ2415X_MODE_NONE);
++ bq2415x_set_mode(bq, BQ2415X_MODE_OFF);
+ bq2415x_set_autotimer(bq, 0);
+}
+
++/* delayed work function for auto resetting chip timer */
+static void bq2415x_timer_work(struct work_struct *work)
+{
+ struct bq2415x_device *bq = container_of(work, struct bq2415x_device,
+
+ ret = bq2415x_exec_command(bq, BQ2415X_TIMER_RESET);
+ if (ret < 0) {
-+ bq2415x_timer_error(bq, "Reseting timer failed");
++ bq2415x_timer_error(bq, "Resetting timer failed");
+ return;
+ }
+
+ boost = bq2415x_exec_command(bq, BQ2415X_BOOST_MODE_STATUS);
+ if (boost < 0) {
-+ bq2415x_timer_error(bq, "Unknow error");
++ bq2415x_timer_error(bq, "Unknown error");
+ return;
+ }
+
+ error = bq2415x_exec_command(bq, BQ2415X_FAULT_STATUS);
+ if (error < 0) {
-+ bq2415x_timer_error(bq, "Unknow error");
++ bq2415x_timer_error(bq, "Unknown error");
+ return;
+ }
+
+ if (boost) {
+ switch (error) {
++ /* Non fatal errors, chip is OK */
+ case 0: /* No error */
+ break;
+ case 6: /* Timer expired */
+ dev_err(bq->dev, "Battery voltage to low\n");
+ break;
+
++ /* Fatal errors, disable and reset chip */
+ case 1: /* Overvoltage protection (chip fried) */
+ bq2415x_timer_error(bq,
-+ "Overvolatge protection (chip fried)");
++ "Overvoltage protection (chip fried)");
+ return;
+ case 2: /* Overload */
+ bq2415x_timer_error(bq, "Overload");
+ }
+ } else {
+ switch (error) {
++ /* Non fatal errors, chip is OK */
+ case 0: /* No error */
+ break;
+ case 2: /* Sleep mode */
+ dev_err(bq->dev, "No battery\n");
+ break;
+
++ /* Fatal errors, disable and reset chip */
+ case 1: /* Overvoltage protection (chip fried) */
+ bq2415x_timer_error(bq,
-+ "Overvolatge protection (chip fried)");
++ "Overvoltage protection (chip fried)");
+ return;
+ case 4: /* Battery overvoltage protection */
+ bq2415x_timer_error(bq,
+ schedule_delayed_work(&bq->work, BQ2415X_TIMER_TIMEOUT * HZ);
+}
+
-+/* power supply */
++/**** power supply interface code ****/
+
+static enum power_supply_property bq2415x_power_supply_props[] = {
-+ /* TODO: more power supply properties */
++ /* TODO: maybe add more power supply properties */
+ POWER_SUPPLY_PROP_STATUS,
+ POWER_SUPPLY_PROP_MODEL_NAME,
+};
+ kfree(bq->model);
+}
+
-+/* sysfs files */
++/**** additional sysfs entries for power supply interface ****/
+
++/* show *_status entries */
+static ssize_t bq2415x_sysfs_show_status(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ return sprintf(buf, "%d\n", ret);
+}
+
++/* set timer entry:
++ auto - enable auto mode
++ off - disable auto mode
++ (other values) - reset chip timer
++*/
+static ssize_t bq2415x_sysfs_set_timer(struct device *dev,
+ struct device_attribute *attr, const char *buf, size_t count)
+{
+ return count;
+}
+
++/* show timer entry (auto or off) */
+static ssize_t bq2415x_sysfs_show_timer(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct bq2415x_device *bq = container_of(psy, struct bq2415x_device,
+ charger);
+
++ if (bq->timer_error)
++ return sprintf(buf, "%s\n", bq->timer_error);
++
+ if (bq->autotimer)
+ return sprintf(buf, "auto\n");
+ else
+ return sprintf(buf, "off\n");
+}
+
++/* set mode entry:
++ auto - if automode is supported, enable it and set mode to reported
++ none - disable charger and boost mode
++ host - charging mode for host/hub chargers (current limit 500mA)
++ dedicated - charging mode for dedicated chargers (unlimited current limit)
++ boost - disable charger and enable boost mode
++*/
+static ssize_t bq2415x_sysfs_set_mode(struct device *dev,
+ struct device_attribute *attr, const char *buf, size_t count)
+{
+ if (bq->automode < 0)
+ return -ENOSYS;
+ bq->automode = 1;
-+ mode = bq->charger_mode;
++ mode = bq->reported_mode;
++ } else if (strncmp(buf, "off", 3) == 0) {
++ if (bq->automode > 0)
++ bq->automode = 0;
++ mode = BQ2415X_MODE_OFF;
+ } else if (strncmp(buf, "none", 4) == 0) {
+ if (bq->automode > 0)
+ bq->automode = 0;
+ } else if (strncmp(buf, "reset", 5) == 0) {
+ bq2415x_reset_chip(bq);
+ bq2415x_set_defaults(bq);
-+ if (bq->automode > 0)
-+ bq->automode = 1;
-+ return count;
++ if (bq->automode <= 0)
++ return count;
++ bq->automode = 1;
++ mode = bq->reported_mode;
+ } else
+ return -EINVAL;
+
+ return count;
+}
+
++/* show mode entry (auto, none, host, dedicated or boost) */
+static ssize_t bq2415x_sysfs_show_mode(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ ret += sprintf(buf+ret, "auto (");
+
+ switch (bq->mode) {
++ case BQ2415X_MODE_OFF:
++ ret += sprintf(buf+ret, "off");
++ break;
+ case BQ2415X_MODE_NONE:
+ ret += sprintf(buf+ret, "none");
+ break;
+ return ret;
+}
+
++/* show reported_mode entry (none, host, dedicated or boost) */
++static ssize_t bq2415x_sysfs_show_reported_mode(struct device *dev,
++ struct device_attribute *attr, char *buf)
++{
++ struct power_supply *psy = dev_get_drvdata(dev);
++ struct bq2415x_device *bq = container_of(psy, struct bq2415x_device,
++ charger);
++
++ if (bq->automode < 0)
++ return -EINVAL;
++
++ switch (bq->reported_mode) {
++ case BQ2415X_MODE_OFF:
++ return sprintf(buf, "off\n");
++ case BQ2415X_MODE_NONE:
++ return sprintf(buf, "none\n");
++ case BQ2415X_MODE_HOST_CHARGER:
++ return sprintf(buf, "host\n");
++ case BQ2415X_MODE_DEDICATED_CHARGER:
++ return sprintf(buf, "dedicated\n");
++ case BQ2415X_MODE_BOOST:
++ return sprintf(buf, "boost\n");
++ }
++
++ return -EINVAL;
++}
++
++/* directly set raw value to chip register, format: 'register value' */
+static ssize_t bq2415x_sysfs_set_registers(struct device *dev,
+ struct device_attribute *attr, const char *buf, size_t count)
+{
+ struct bq2415x_device *bq = container_of(psy, struct bq2415x_device,
+ charger);
+ ssize_t ret = 0;
-+ char *end;
-+ int reg;
-+ int val;
++ unsigned int reg;
++ unsigned int val;
+
-+ reg = simple_strtol(buf, &end, 16);
-+ if (reg < 0 || reg > 4)
++ if (sscanf(buf, "%x %x", ®, &val) != 2)
+ return -EINVAL;
+
-+ val = simple_strtol(end+1, NULL, 16);
-+ if (val < 0 || val > 255)
++ if (reg > 4 || val > 255)
+ return -EINVAL;
+
+ ret = bq2415x_i2c_write(bq, reg, val);
+ return count;
+}
+
++/* print value of chip register, format: 'register=value' */
+static ssize_t bq2415x_sysfs_print_reg(struct bq2415x_device *bq,
+ u8 reg, char *buf)
+{
+ return sprintf(buf, "%#.2x=%#.2x\n", reg, ret);
+}
+
++/* show all raw values of chip register, format per line: 'register=value' */
+static ssize_t bq2415x_sysfs_show_registers(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ return ret;
+}
+
-+/* Current & Volatage settings */
-+
++/* set current and voltage limit entries (in mA or mV) */
+static ssize_t bq2415x_sysfs_set_limit(struct device *dev,
+ struct device_attribute *attr, const char *buf, size_t count)
+{
+ long val;
+ int ret;
+
-+ if (strict_strtol(buf, 10, &val) < 0)
++ if (kstrtol(buf, 10, &val) < 0)
+ return -EINVAL;
+
+ if (strcmp(attr->attr.name, "current_limit") == 0)
+ return count;
+}
+
++/* show current and voltage limit entries (in mA or mV) */
+static ssize_t bq2415x_sysfs_show_limit(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ return sprintf(buf, "%d\n", ret);
+}
+
++/* set *_enable entries */
+static ssize_t bq2415x_sysfs_set_enable(struct device *dev,
+ struct device_attribute *attr, const char *buf, size_t count)
+{
+ long val;
+ int ret;
+
-+ if (strict_strtol(buf, 10, &val) < 0)
++ if (kstrtol(buf, 10, &val) < 0)
+ return -EINVAL;
+
+ if (strcmp(attr->attr.name, "charge_termination_enable") == 0)
+ return count;
+}
+
++/* show *_enable entries */
+static ssize_t bq2415x_sysfs_show_enable(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+static DEVICE_ATTR(stat_pin_enable, S_IWUSR | S_IRUGO,
+ bq2415x_sysfs_show_enable, bq2415x_sysfs_set_enable);
+
++static DEVICE_ATTR(reported_mode, S_IRUGO,
++ bq2415x_sysfs_show_reported_mode, NULL);
+static DEVICE_ATTR(mode, S_IWUSR | S_IRUGO,
+ bq2415x_sysfs_show_mode, bq2415x_sysfs_set_mode);
+static DEVICE_ATTR(timer, S_IWUSR | S_IRUGO,
+ &dev_attr_otg_pin_enable.attr,
+ &dev_attr_stat_pin_enable.attr,
+
++ &dev_attr_reported_mode.attr,
+ &dev_attr_mode.attr,
+ &dev_attr_timer.attr,
+
+ sysfs_remove_group(&bq->charger.dev->kobj, &bq2415x_sysfs_attr_group);
+}
+
-+/* bq2415x register */
-+
++/* main bq2415x probe function */
+static int bq2415x_probe(struct i2c_client *client,
+ const struct i2c_device_id *id)
+{
+ bq->dev = &client->dev;
+ bq->chip = id->driver_data;
+ bq->name = name;
-+ bq->mode = BQ2415X_MODE_NONE;
-+ bq->charger_mode = BQ2415X_MODE_NONE;
++ bq->mode = BQ2415X_MODE_OFF;
++ bq->reported_mode = BQ2415X_MODE_OFF;
+ bq->autotimer = 0;
+ bq->automode = 0;
+
+ goto error_5;
+ }
+
-+ if (bq->init_data.set_charger_type_hook) {
-+ if (bq->init_data.set_charger_type_hook(
-+ bq2415x_set_charger_type, bq)) {
++ if (bq->init_data.set_mode_hook) {
++ if (bq->init_data.set_mode_hook(
++ bq2415x_hook_function, bq)) {
+ bq->automode = 1;
++ bq2415x_set_mode(bq, bq->reported_mode);
+ dev_info(bq->dev, "automode enabled\n");
+ } else {
+ bq->automode = -1;
-+ dev_info(bq->dev, "automode not supported\n");
++ dev_info(bq->dev, "automode failed\n");
+ }
+ } else {
+ bq->automode = -1;
+ INIT_DELAYED_WORK(&bq->work, bq2415x_timer_work);
+ bq2415x_set_autotimer(bq, 1);
+
-+ dev_info(bq->dev, "driver registred\n");
++ dev_info(bq->dev, "driver registered\n");
+ return 0;
+
+error_5:
+ return ret;
+}
+
-+/* bq2415x unregister */
++/* main bq2415x remove function */
+
+static int bq2415x_remove(struct i2c_client *client)
+{
+ struct bq2415x_device *bq = i2c_get_clientdata(client);
+
-+ if (bq->init_data.set_charger_type_hook)
-+ bq->init_data.set_charger_type_hook(NULL, NULL);
++ if (bq->init_data.set_mode_hook)
++ bq->init_data.set_mode_hook(NULL, NULL);
+
+ bq2415x_sysfs_exit(bq);
+ bq2415x_power_supply_exit(bq);
+ idr_remove(&bq2415x_id, bq->id);
+ mutex_unlock(&bq2415x_id_mutex);
+
-+ dev_info(bq->dev, "driver unregistred\n");
++ dev_info(bq->dev, "driver unregistered\n");
+
+ kfree(bq->name);
+ kfree(bq);
+MODULE_AUTHOR("Pali Rohár <pali.rohar@gmail.com>");
+MODULE_DESCRIPTION("bq2415x charger driver");
+MODULE_LICENSE("GPL");
---- /dev/null 2012-04-29 08:55:34.366920721 +0200
-+++ kernel-power/include/linux/power/bq2415x_charger.h 2012-01-27 15:47:45.689585447 +0100
-@@ -0,0 +1,78 @@
+--- /dev/null
++++ kernel-power/include/linux/power/bq2415x_charger.h
+@@ -0,0 +1,91 @@
+/*
+ bq2415x_charger.h - bq2415x charger driver
+ Copyright (C) 2011-2012 Pali Rohár <pali.rohar@gmail.com>
+#define BQ2415X_CHARGER_H
+
+/*
-+ This is platform data for bq2415x chip. It contains default board volatages
++ This is platform data for bq2415x chip. It contains default board voltages
+ and currents which can be also later configured via sysfs. If value is -1
+ then default chip value (specified in datasheet) will be used.
+
+ current. It it is less or equal to zero, configuring charge and termination
+ current will not be possible.
+
-+ Function set_charger_type_hook is needed for automode (setting correct
-+ current limit when charger is connected/disconnected). When is NULL,
++ Function set_mode_hook is needed for automode (setting correct current limit
++ when charger is connected/disconnected or setting boost mode). When is NULL,
+ automode function is disabled. When is not NULL, it must have this prototype:
+
-+ int (*set_charger_type_hook)(void (*hook)(int type, void *data), void *data)
++ int (*set_mode_hook)(
++ void (*hook)(enum bq2415x_mode mode, void *data),
++ void *data)
+
-+ and bq2415x driver will call it as:
++ hook is hook function (see below) and data is pointer to driver private data
+
-+ platform_data->set_charger_type_hook(bq_hook_function, bq_private_data);
++ bq2415x driver will call it as:
+
-+ Board/platform function set_charger_type_hook return non zero when hook
-+ function was successfull registred. Platform code should call that hook
++ platform_data->set_mode_hook(bq2415x_hook_function, bq2415x_device);
++
++ Board/platform function set_mode_hook return non zero value when hook
++ function was successful registered. Platform code should call that hook
+ function (which get from pointer, with data) every time when charger was
-+ connected/disconnected. bq driver then set correct current limit.
++ connected/disconnected or require to enable boost mode. bq2415x driver then
++ will set correct current limit, enable/disable charger or boost mode.
+
+ Hook function has this prototype:
+
-+ void hook(int type, void *data);
-+
-+ type is:
-+ 0 - for unknown or none charger (max current limit is 100mA)
-+ 1 - for usb host/hub charger (max current limit is 500mA)
-+ 2 - for dedicated charger (unlimited)
++ void hook(enum bq2415x_mode mode, void *data);
+
-+ data is pointer to bq_private_data (which get from set_charger_type_hook)
++ mode is bq2415x mode (charger or boost)
++ data is pointer to driver private data (which get from set_charger_type_hook)
+
+ When bq driver is being unloaded, it call function:
+
-+ platform_data->set_charger_type_hook(NULL, NULL);
++ platform_data->set_mode_hook(NULL, NULL);
+
-+ After thet board/platform code must not call bq hook function! It is
-+ possible that pointer to hook function will not be valid.
++ (hook function and driver private data are NULL)
++
++ After that board/platform code must not call driver hook function! It is
++ possible that pointer to hook function will not be valid and calling will
++ cause undefined result.
+
+*/
+
++/* Supported modes with maximal current limit */
++enum bq2415x_mode {
++ BQ2415X_MODE_OFF, /* offline mode (charger disabled) */
++ BQ2415X_MODE_NONE, /* unknown charger (100mA) */
++ BQ2415X_MODE_HOST_CHARGER, /* usb host/hub charger (500mA) */
++ BQ2415X_MODE_DEDICATED_CHARGER, /* dedicated charger (unlimited) */
++ BQ2415X_MODE_BOOST, /* boost mode (charging disabled) */
++};
++
+struct bq2415x_platform_data {
+ int current_limit; /* mA */
+ int weak_battery_voltage; /* mV */
+ int charge_current; /* mA */
+ int termination_current; /* mA */
+ int resistor_sense; /* m ohm */
-+ int (*set_charger_type_hook)(void (*hook)(int type, void *data),
-+ void *data);
++ int (*set_mode_hook)(void (*hook)(enum bq2415x_mode mode, void *data),
++ void *data);
+};
+
+#endif