## name passes by assigning error variable ## failures 0 ## cut my $error = close( $filehandle ); my $error = close $filehandle; my $error = close CLOSE; my $error = close OR; #----------------------------------------------------------------------------- ## name passes by "or die" ## failures 0 ## cut close $filehandle or die 'could not close'; close ($filehandle) or die 'could not close'; close ($filehandle) or croak 'could not close'; #----------------------------------------------------------------------------- ## name passes by "|| die" ## failures 0 ## cut close $filehandle || die 'could not close'; close ($filehandle) || die 'could not close'; close ($filehandle) || croak 'could not close'; #----------------------------------------------------------------------------- ## name passes by "unless" ## failures 0 ## cut die unless close ( $filehandle ); die unless close $filehandle; croak unless close ( $filehandle ); croak unless close $filehandle; #----------------------------------------------------------------------------- ## name passes by "if not" ## failures 0 ## cut die if not close ( $filehandle ); die if not close $filehandle; croak if not close ( $filehandle ); croak if not close $filehandle; die if !close ( $filehandle ); die if !close $filehandle; croak if !close ( $filehandle ); croak if !close $filehandle; #----------------------------------------------------------------------------- ## name passes with "if" statement ## failures 0 ## cut if ( close $filehandle ) { dosomething(); }; #----------------------------------------------------------------------------- ## name Basic failure with parens ## failures 1 ## cut close( $filehandle ); #----------------------------------------------------------------------------- ## name Basic failure no parens ## failures 1 ## cut close $filehandle; #----------------------------------------------------------------------------- ## name Fatal.pm on ## failures 0 ## cut use Fatal qw(close); close $filehandle; #----------------------------------------------------------------------------- ## name Fatal.pm on ## failures 0 ## cut use Fatal 'close'; close $filehandle; #----------------------------------------------------------------------------- ## name Fatal.pm on ## failures 0 ## cut use Fatal ('close'); close $filehandle; #----------------------------------------------------------------------------- ## name Fatal::Exception on ## failures 0 ## cut use Fatal::Exception 'Exception' => qw(close); close $filehandle; #----------------------------------------------------------------------------- ## name Fatal.pm off ## failures 1 ## cut use Fatal qw(open); close $filehandle; #----------------------------------------------------------------------------- ############################################################################## # $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic/t/InputOutput/RequireCheckedClose.run $ # $Date: 2008-03-16 17:40:45 -0500 (Sun, 16 Mar 2008) $ # $Author: clonezone $ # $Revision: 2187 $ ############################################################################## # Local Variables: # mode: cperl # cperl-indent-level: 4 # fill-column: 78 # indent-tabs-mode: nil # c-indentation-style: bsd # End: # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :