1 ##############################################################################
2 # $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic/lib/Perl/Critic/Policy/References/ProhibitDoubleSigils.pm $
3 # $Date: 2008-07-03 10:19:10 -0500 (Thu, 03 Jul 2008) $
6 ##############################################################################
8 package Perl::Critic::Policy::References::ProhibitDoubleSigils;
15 use Perl::Critic::Utils qw{ :severities };
16 use base 'Perl::Critic::Policy';
18 our $VERSION = '1.088';
20 #-----------------------------------------------------------------------------
22 Readonly::Scalar my $DESC => q{Double-sigil dereference};
23 Readonly::Scalar my $EXPL => [ 228 ];
25 #-----------------------------------------------------------------------------
27 sub supported_parameters { return () }
28 sub default_severity { return $SEVERITY_LOW }
29 sub default_themes { return qw(core pbp cosmetic) }
30 sub applies_to { return 'PPI::Token::Cast' }
32 #-----------------------------------------------------------------------------
35 my ( $self, $elem, undef ) = @_;
36 return if $elem eq q{\\};
38 my $sib = $elem->snext_sibling;
40 if ( ! $sib->isa('PPI::Structure::Block') ) {
41 return $self->violation( $DESC, $EXPL, $elem );
50 #-----------------------------------------------------------------------------
56 Perl::Critic::Policy::References::ProhibitDoubleSigils - Write C<@{ $array_ref }> instead of C<@$array_ref>.
60 This Policy is part of the core L<Perl::Critic> distribution.
65 When dereferencing a reference, put braces around the reference to
66 separate the sigils. Especially for newbies, the braces eliminate any
67 potential confusion about the relative precedence of the sigils.
69 push @$array_ref, 'foo', 'bar', 'baz'; #not ok
70 push @{ $array_ref }, 'foo', 'bar', 'baz'; #ok
72 foreach ( keys %$hash_ref ){} #not ok
73 foreach ( keys %{ $hash_ref } ){} #ok
78 This Policy is not configurable except for the standard options.
83 Jeffrey Ryan Thalhammer <thaljef@cpan.org>
87 Copyright (c) 2005-2008 Jeffrey Ryan Thalhammer. All rights reserved.
89 This program is free software; you can redistribute it and/or modify
90 it under the same terms as Perl itself. The full text of this license
91 can be found in the LICENSE file included with this module.
97 # cperl-indent-level: 4
99 # indent-tabs-mode: nil
100 # c-indentation-style: bsd
102 # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :