vcs.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/modest-account-mgr-helpers.h:
   4         * src/modest-account-mgr-helpers.c:
   5         (modest_account_mgr_get_unused_account_name),
   6         (modest_account_mgr_get_unused_account_display_name): Added these
   7         utility functions, to avoid code duplication.
   8
   9         * src/maemo/easysetup/modest-easysetup-wizard.c:
  10         (create_page_account_details), (create_account):
  11         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  12         (on_combo_security_changed),
  13         (modest_connection_specific_smtp_edit_window_init),
  14         (modest_connection_specific_smtp_edit_window_save_settings):
  15         * src/maemo/modest-connection-specific-smtp-edit-window.h:
  16         * src/maemo/modest-connection-specific-smtp-window.c:
  17         (modest_connection_specific_smtp_window_finalize),
  18         (modest_connection_specific_smtp_window_fill_with_connections),
  19         (on_button_edit), (modest_connection_specific_smtp_window_init):
  20         * src/maemo/modest-connection-specific-smtp-window.h:
  21         Implementing saving of connection-specific server accounts.
  22
  23         But I need to refactor this so we can save the data for each
  24         possible connection-specific account and only actually create the server accounts
  25         when the easysetup finished, or the OK button is pressed on the account settings
  26         dialog.
  27
  28 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
  29
  30         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  31         (on_combo_security_changed):
  32         (modest_connection_specific_smtp_edit_window_init):
  33         Auto-fill the port number as in the account settings.
  34
  35         (modest_connection_specific_smtp_edit_window_set_connection):
  36         * src/maemo/modest-connection-specific-smtp-edit-window.h:
  37         * src/maemo/modest-connection-specific-smtp-window.c:
  38         (fill_with_connections), (on_button_edit),
  39         (modest_connection_specific_smtp_window_init):
  40         Turn the edit window into a dialog to simplify the code, and
  41         set a WM hint as in a GtkDialog, because only a popup can be on top of
  42         another window in Maemo, and popups usually have no WM decoration.
  43
  44         * src/modest-defs.h:
  45         * src/modest-account-mgr-helpers.c:
  46         (modest_account_mgr_set_connection_specific_smtp),
  47         (modest_account_mgr_remove_connection_specific_smtp),
  48         (modest_account_mgr_get_connection_specific_smtp):
  49         * src/modest-account-mgr-helpers.h: Some functions to write the
  50         connection-specific SMTP server information. Not yet used.
  51
  52
  53         * src/widgets/modest-folder-view.c: (text_cell_data):
  54         Fix a warning about an uninitialized variable.
  55         (on_configuration_key_changed): Put an #ifdef around the use
  56         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
  57
  58 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
  59
  60         * src/maemo/modest-account-settings-dialog.h:
  61         * src/maemo/modest-account-settings-dialog.c:
  62         Added connect_for_modified() utility function to mark the new modified boolean.
  63
  64         (create_page_account_details), (create_page_user_details),
  65         (create_page_incoming), (create_page_outgoing), (on_response),
  66         (modest_account_settings_dialog_init),
  67         (modest_account_settings_dialog_set_account_name):
  68         Only warn about unsaved changes when there are actually unsaved changes.
  69
  70         * src/modest-account-mgr-helpers.c:
  71         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
  72         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
  73         to get the data from there in future.
  74
  75 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
  76
  77         * src/modest-defs.h:
  78
  79         * src/modest-account-mgr-helpers.h:
  80         * src/modest-account-mgr-helpers.c:
  81         Store the security account setting in a single conf key instead of using
  82         the options list, so that the list is left for just the to-be-removed camel hack,
  83         and because gconf_client_set_list() is failing for some reason.
  84
  85         * src/modest-account-mgr.c:
  86         (modest_account_mgr_add_server_account):
  87         * src/maemo/modest-account-settings-dialog.c:
  88         (modest_account_settings_dialog_set_account_name),
  89         (save_configuration): Use the renamed functions.
  90
  91
  92 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
  93
  94         * src/widgets/Makefile.am:
  95         * src/widgets/modest-limit-retrieve-combo-box.c:
  96         * src/widgets/modest-limit-retrieve-combo-box.h:
  97         * src/widgets/modest-retrieve-combo-box.c:
  98         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
  99         the account settings dialog.
 100
 101         * src/modest-defs.h:
 102         * src/modest-account-mgr-helpers.h:
 103         * src/modest-account-mgr-helpers.c:
 104         (modest_server_account_get_option_secure_auth),
 105         (modest_server_account_set_option_secure_auth):
 106         * src/modest-account-mgr.c:
 107         (modest_account_mgr_add_server_account):
 108         Use the existing AUTH_MECH conf key for the secure-auth setting,
 109         instead of putting it in the list options, because this was actually used already.
 110
 111         * src/maemo/modest-account-settings-dialog.c:
 112         (create_page_account_details),
 113         (modest_account_settings_dialog_set_account_name),
 114         (save_configuration):
 115         * src/maemo/modest-account-settings-dialog.h:
 116         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 117         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 118
 119 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 120
 121         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 122         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 123         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 124
 125         * src/modest-defs.h:
 126         * src/maemo/modest-account-settings-dialog.c:
 127         (create_page_incoming), (on_combo_outgoing_security_changed),
 128         (on_combo_incoming_security_changed), (create_page_outgoing),
 129         (modest_account_settings_dialog_set_account_name),
 130         (save_configuration): Load/Save the port number, and change it when the
 131         security combo changes, to suitable defaults.
 132
 133 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 134
 135         * src/modest-account-mgr.c:
 136         (modest_account_mgr_add_server_account): Set the security and secure-auth
 137         options, and add a comment saying that the other camel-specific options should be
 138         removed in future.
 139
 140 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 141
 142         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 143         found by valgrind.
 144         * src/modest-tny-account-store.c: (account_list_free),
 145         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 146         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 147         easy to fix.
 148
 149 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 150
 151         * src/modest-protocol-info.c:
 152         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 153         is required by our UI spec. Maybe something in our implementation will use this eventually.
 154         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 155         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 156         instead of the previous 0 placeholder.
 157
 158         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 159         secure-auth settings.
 160         * src/modest-account-mgr-helpers.h:
 161         * src/modest-account-mgr-helpers.c:
 162         (modest_server_account_data_get_option_secure_auth),
 163         (modest_server_account_set_option_secure_auth),
 164         (modest_server_account_data_get_option_security),
 165         (modest_server_account_set_option_security): Added this API for getting and setting the security
 166         and secure-auth settings.
 167
 168         * src/maemo/modest-account-settings-dialog.h:
 169         * src/maemo/modest-account-settings-dialog.c:
 170         (modest_account_settings_dialog_finalize), (check_data),
 171         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 172         about changing titles.
 173         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 174         (save_configuration): Save the security and secure-auth settings.
 175
 176         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 177         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 178
 179 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 180
 181         * src/modest-defs.h:
 182         * src/modest-account-mgr.c:
 183         (modest_account_mgr_add_server_account):
 184         Added and used defines for the options key and value pair strings,
 185         that are used so far, though they do not seem to correspond to anything in our
 186         UI specs or ModestProtocol enum.
 187
 188         * src/modest-account-mgr-helpers.h:
 189         * src/modest-account-mgr-helpers.c:
 190         (compare_option_strings_for_name),
 191         (modest_server_account_data_get_option_value),
 192         (modest_server_account_data_get_option_bool),
 193         (modest_account_mgr_get_server_account_option):
 194         Added helper functions for parsing the options GSList.
 195
 196 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 197
 198         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 199         display name is based on the supplied account name.
 200         * src/modest-account-mgr.c:
 201         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 202         with an inefficient, but good-enough, implementation.
 203
 204         * src/maemo/easysetup/modest-easysetup-wizard.c:
 205         (create_page_account_details), (on_before_next), (create_account):
 206         Check for existing display names rather than (non-user-visible) account names, and just
 207         create and set a unique account name at the end.
 208
 209         * src/maemo/modest-account-settings-dialog.c:
 210         (modest_account_settings_dialog_init),
 211         (modest_account_settings_dialog_set_account_name),
 212         (create_page_incoming): Show the display name, instead of the account name.
 213         (on_response): Do some (not all) extra checks, as in the UI spec.
 214         (save_configuration): Save the display name if it was changed.
 215
 216 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 217
 218         * po/en_GB.po: Added needed logical ID and translation.
 219         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 220         (init_view): Made the is-default column clicking work.
 221
 222 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 223
 224         * configure.ac:
 225         * src/maemo/easysetup/Makefile.am:
 226         * src/maemo/easysetup/modest-easysetup-wizard.c:
 227         (modest_easysetup_wizard_dialog_init):
 228         * src/maemo/easysetup/provider-data-test.keyfile:
 229         * src/maemo/easysetup/provider-data.keyfile:
 230         Moved the provider data file to the new modest-providers-data package and used it from there.
 231
 232 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 233
 234         * src/modest-local-folder-info.c:
 235         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 236         N_() was already used on the static strings, but this just marks it for translation without
 237         using the translation.
 238
 239 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 240
 241         * src/maemo/modest-account-settings-dialog.c:
 242         (create_page_incoming),
 243         (modest_account_settings_dialog_set_account_name):
 244         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 245         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 246         I will do this if nobody else gets there first.
 247
 248 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 249
 250         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 251         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 252         save the security stuff.
 253
 254 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 255
 256         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 257         Set the email address and user fullname, which I now see must be
 258         done separately.
 259
 260         * src/maemo/modest-account-settings-dialog.h:
 261         * src/maemo/modest-account-settings-dialog.c:
 262          (on_response),
 263         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 264         leave-on-server and authentication.
 265         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 266         how to do the rest.
 267
 268 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 269
 270
 271         * src/maemo/modest-account-settings-dialog.c:
 272         * src/maemo/modest-account-settings-dialog.h:
 273         Most (but not all) of the widgets are now present as specified by the UI spec.
 274         No changes are yet saved, and some details are not properly shown yet.
 275
 276         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 277
 278 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 279
 280         * src/maemo/Makefile.am:
 281         * src/maemo/modest-account-settings-dialog.c:
 282         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 283         an existing account. Doesn't do much yet.
 284
 285         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 286         Open the accounts settings dialog when Edit is clicked.
 287
 288 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 289
 290         * src/maemo/easysetup/Makefile.am:
 291         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 292         (load_from_file):
 293         * src/maemo/easysetup/modest-easysetup-wizard.c:
 294         (modest_easysetup_wizard_dialog_init):
 295         Try to get the source directory from the build system,
 296         instead of hard-coding "./" into the source code, when opening our local
 297         copies of the configuration files.
 298         But this still fails when opening the wizard from the Accounts window,
 299         maybe because the working directory seems to change at runtime.
 300         So the wizard will fail the second time unless you copy the files into their
 301         proper locations - see the stdout warnings for the paths.
 302
 303         (create_page_account_details),(on_before_next):
 304         Check for existing non-server accounts instead of server accounts,
 305         so the default account name is useful again, and to prevent trying to
 306         recreate accounts.
 307
 308         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 309         Show the wizard when New is clicked.
 310
 311         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 312         (init_view): Show the column headers, and show the columns that are
 313         specified in the UI specs. However, something in Maemo's GTK+ prevents
 314         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 315         change the default account. This is despite unsetting the special properties.
 316
 317 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 318
 319         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 320         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 321         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 322         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 323         to make that clearer.
 324         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 325
 326 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 327
 328         * src/maemo/modest-account-view-window.c:
 329         (modest_account_view_window_init),
 330         (modest_account_view_window_new):
 331         Use the same buttons as specified in the
 332         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 333         the existing widgets, which never had a chance of working.
 334         Put the ModestAccountView treeview in a scrolled window.
 335         Do not repeat the initialization in both _init() and _new().
 336
 337         * src/widgets/modest-account-view.c: (update_account_view):
 338         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 339         this widget and window shows no accounts.
 340
 341         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 342
 343 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 344
 345         * src/maemo/easysetup/modest-easysetup-wizard.c:
 346         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 347         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 348         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 349         which seems wrong.
 350
 351         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 352         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 353         accounts exist yet, as in the UI spec.
 354
 355         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 356
 357 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 358
 359         * src/maemo/Makefile.am:
 360         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 361         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 362         New window for editing connection-specific smtp details.
 363         Not fully implemented.
 364
 365         * src/maemo/modest-connection-specific-smtp-window.c:
 366         (modest_connection_specific_smtp_window_finalize) :
 367         unref the tree model.
 368         (on_button_edit): Show the edit window.
 369
 370 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 371
 372         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 373         error for me.
 374
 375         * src/maemo/Makefile.am:
 376         * src/maemo/modest-connection-specific-smtp-window.c:
 377         * src/maemo/modest-connection-specific-smtp-window.h:
 378         New window for showing the list of connections, for connection-specific
 379         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 380         * src/maemo/easysetup/modest-easysetup-wizard.c:
 381         (create_page_custom_outgoing): Show the new window when the button is clicked.
 382
 383 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 384
 385         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 386         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 387         * src/maemo/modest-msg-edit-window.c:
 388         (modest_msg_edit_window_insert_image):
 389         * src/modest-conf.c: (modest_conf_key_escape):
 390         * src/modest-mail-operation.c:
 391         (modest_mail_operation_send_new_mail):
 392         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 393         (modest_ui_actions_on_new_account):
 394         * src/widgets/modest-attachment-view.c: (update_filename_request):
 395         * src/widgets/modest-mail-header-view.c:
 396         Corrected warnings that were breaking the build, by commenting out unused variables,
 397         and a function, and by including a header.
 398
 399 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 400
 401         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 402         so we can #ifdef around platform-specific code when necessary.
 403         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 404         to allow this to build for the GNOME platform too.
 405
 406 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 407
 408         * src/maemo/easysetup/modest-easysetup-wizard.c:
 409         Added util_increment_name() and used it in create_page_account_details()
 410         to make sure that the default account name is always a new name.
 411
 412         (modest_easysetup_wizard_dialog_init),
 413         (set_default_custom_servernames): Some minor memory management fixes.
 414
 415 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 416
 417         * Makefile.am:
 418         * configure.ac:
 419         * src/modest-runtime.c: (init_i18n): Restored the translation
 420         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 421         are defined in config.h, and the translations are installed.
 422
 423         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 424         is defined for translation.
 425
 426 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 427
 428         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 429         (load_from_file):
 430         * src/maemo/easysetup/modest-easysetup-wizard.c:
 431         (modest_easysetup_wizard_dialog_init):
 432         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 433         Use realistic paths (though they should use $prefix generically) to the
 434         mcc_mapping and provider-data.keyfile files which might work when they
 435         are installed by the future version of the operator-wizard package,
 436         and then fallback to paths in our source code, with an explanatory
 437         warning.
 438
 439 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 440
 441         * configure.ac:
 442         * src/Makefile.am:
 443         * src/maemo/Makefile.am:
 444         * src/maemo/easysetup/: Added files from the previously-exernal
 445         osso-modest-easysetup.
 446         * src/maemo/modest-main-window-ui.h:
 447         * src/modest-ui-actions.c:
 448         * src/modest-ui-actions.h:
 449         Added modest_ui_actions_on_new_account() as a signal handler for the
 450         New Account menu item. It shows the easysetup wizard.
 451         * po/en_GB.po: Added additional needed logical IDs and translations.
 452
 453 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 454 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 455