1 2007-07-18 Armin Burgmeier <armin@openismus.com>
3 * src/modest-tny-account-store.c:
4 (get_server_accounts): Set parent modest account name for each
5 connection-specific transport account so that special folders of such
6 an account can be looked up. This fixes a crash when changing account
7 settings. This might also be related to projects.maemo.org bug
10 2007-07-16 Armin Burgmeier <armin@openismus.com>
12 * src/modest-ui-actions.c: Added a button to create a folder to the
13 move-to dialog. This fixes projects.maemo.org bug NB#.
15 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
17 * src/maemo/easysetup/modest-easysetup-wizard.c:
18 Added scrollbars to account wizard dialog.
19 Fixed projects.maemo.org NB #62744
21 2007-07-16 Murray Cumming <murrayc@murrayc.com>
23 * src/widgets/modest-msg-view.h:
24 * src/widgets/modest-msg-view.c:
25 Added modest_msg_view_get_message_is_empty() but this needs
27 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
28 Check if there is any text in the message yet.
29 But this needs to be implemented properly.
30 (modest_msg_edit_window_toggle_find_toolbar):
31 * src/maemo/modest-msg-view-window.c:
32 (modest_msg_view_window_toggle_find_toolbar):
33 Show a banner warning if there is no text to search, when
34 trying to start a search. This partially fixes
35 projects.maemo.org bug NB#62350.
37 2007-07-13 Murray Cumming <murrayc@murrayc.com>
39 * src/modest-mail-operation.c: (update_account_thread):
40 Initialized num_new_headers to fix the build.
42 2007-07-13 Murray Cumming <murrayc@murrayc.com>
44 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
45 Ignore modest accounts whose server accounts don't exist in gconf.
46 This prevents us trying to create TnyAccount instances for those
47 server accounts when the server account has been removed from gconf,
48 but the parent modest account has not yet been removed from modest.
49 I don't know why this is only noticeable now. It was probably just
50 a harmeless g_warning() anyway.
52 2007-07-13 Murray Cumming <murrayc@murrayc.com>
54 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
55 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
57 2007-07-12 Armin Burgmeier <armin@openismus.com>
59 * src/maemo/modest-main-window.c: Make default account appear bold
60 in view, tools/send & receive and toolbar/send & receive SCM menus.
61 This fixes projects.maemo.org bug NB#59010.
63 2007-07-12 Murray Cumming <murrayc@murrayc.com>
65 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
66 Add a short-cut, by checking if the folder store is an account.
67 This ensures that the Sort menu item and toolbar is dimmed for
68 the local-folders account root item, fixing
69 projects.maemo.org bug NB#62545.
71 2007-07-12 Murray Cumming <murrayc@murrayc.com>
73 * src/modest-tny-account-store.c: (get_password):
74 Show the password dialog (via the signal) only in the mainloop, via
75 an idle handler that we wait for. This could theoretically prevent
76 hangs, though I worry that it could introduce some too.
78 2007-07-12 Murray Cumming <murrayc@murrayc.com>
80 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
81 * src/maemo/modest-platform.c:
82 (modest_platform_connect_and_wait):
83 Take a TnyAccount* parameter and try to set it to online
84 (a TnyCamel-only API), because tinymail sets accounts to offline
85 when the user cancels a password dialog, and doesn't ask again until
86 it has been set to online.
87 However, this is commented out because it causes a hang now.
89 (modest_platform_connect_and_wait_if_network_account):
90 * src/modest-mail-operation.c:
91 (modest_mail_operation_update_account):
92 * src/modest-platform.h:
93 * src/modest-ui-actions.c: (_modest_ui_actions_open),
94 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
96 2007-07-12 Armin Burgmeier <armin@openismus.com>
98 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
100 * src/modest-mail-operation.c:
101 * src/modest-ui-actions.c: Check for already existing folder before
102 querying the server, show error message from camel if the request
103 still fails. This fixes projects.maemo.org bug NB#58701.
105 2007-07-12 Murray Cumming <murrayc@murrayc.com>
107 * src/modest-tny-account-store.h:
108 * src/modest-tny-account-store.c:
109 Added modest_tny_account_store_forget_password_in_memory(),
110 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
111 when creating a new account, so that new passwords will be used, instead of
112 us thinking that it's a second request as a result of a failed password again.
114 2007-07-12 Murray Cumming <murrayc@murrayc.com>
116 * src/dbus_api/modest-dbus-callbacks.c:
117 (on_idle_open_message): If the message is in drafts then open it
118 in an edit window instead of a view window. This fixes
119 projects.maemo.org bug NB#63005.
121 2007-07-12 Murray Cumming <murrayc@murrayc.com>
123 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
124 Avoided a harmless g_warning().
126 2007-07-12 Murray Cumming <murrayc@murrayc.com>
128 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
129 Pass the modest account name, not the TnyAccount display name to
130 modest_msg_view_window_new() so that the reply feature works,
131 fixing projects.maemo.org bug NB#62892.
133 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
134 (modest_msg_view_window_new_with_header_model):
135 * src/maemo/modest-msg-view-window.c:
136 (modest_msg_view_window_new_with_header_model),
137 (modest_msg_view_window_new):
138 * src/modest-ui-actions.c: (reply_forward):
139 * src/widgets/modest-msg-view-window.h:
140 * src/widgets/modest-window.c: (modest_window_set_active_account):
141 Rename an account parameter to modest_account_name to make this clearer.
143 2007-07-11 Murray Cumming <murrayc@murrayc.com>
145 * src/modest-ui-actions.h:
146 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
147 modest_do_message_delete().
148 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
149 Call modest_do_message_delete(), hoping that this would cause messages
150 to be really deleted from search instead of just marked with strike through.
151 Does not seem to help.
153 2007-07-11 Armin Burgmeier <armin@openismus.com>
155 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
156 priv->reselect to FALSE prior to calling
157 modest_folder_view_select_first_inbox_or_local() to prevent endless
158 recursion and thus a crash on startup.
160 2007-07-11 Armin Burgmeier <armin@openismus.com>
162 * src/maemo/modest-account-settings-dialog.h: Include
163 <gtk/gtknotebook.h> to fix the build (at least for me).
165 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
166 Use "New FolderN" as default suggested name if "New folder" already
167 exists, with N being the first free number, though never exceed "New
168 folder99" in which case we just fall back to "New Folder" even though
169 it already exists. This fixes projects.maemo.org bug NB#58663.
171 2007-07-11 Murray Cumming <murrayc@murrayc.com>
173 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
174 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
175 projects.maemo.org bug NB#62778.
177 2007-07-11 Murray Cumming <murrayc@murrayc.com>
179 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
180 Ignore the wrong (for now) secure-smtp setting in the presets -
181 just default to requiring secure authentication for SMTP, because
184 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
186 * src/widgets/modest-folder-view.c: (filter_row)
187 Do not show drafts folder (see UI specs)
189 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
191 * src/modest-ui-actions.c:
192 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
193 place and also not necessary.
195 * src/widgets/modest-folder-view.c: (filter_row)
196 Guess folder type and hide Sent & Outbox if necessary.
197 Fixed project.maemo.org NB#57328
199 2007-07-11 Murray Cumming <murrayc@murrayc.com>
201 * src/modest-ui-actions.h:
202 * src/modest-ui-actions.c:
203 (modest_ui_actions_on_delete_message):
204 Move some code into a new
205 modest_ui_actions_refresh_message_window_after_delete()
206 function so we can use it from elsewhere.
208 * src/dbus_api/modest-dbus-callbacks.c:
209 (on_idle_delete_message), (on_delete_message): Used an idle
210 handler, as we do for the other D-Bus method handlers.
211 Call modest_ui_actions_refresh_message_window_after_delete()
212 if the deleted message was open in a window. This fixed
213 projects.maemo.org bug NB#62862.
215 2007-07-11 Murray Cumming <murrayc@murrayc.com>
217 * src/modest-main.c: (main): Only show the UI at the start if
218 the showui command line option was given. For instance,
219 run-standalone src/modest showui
220 Otherwise, we wait for the top_application D-Bus method to
221 be sent by hildon-desktop when the application is selected
223 This allows us to run without a UI when osso-global-search
224 uses our D-Bus methods.
226 2007-07-11 Murray Cumming <murrayc@murrayc.com>
228 * src/dbus_api/modest-dbus-api.h: Added a define for a
229 top-application D-Bus method.
230 * src/dbus_api/modest-dbus-callbacks.c:
231 (on_top_application),
232 (modest_dbus_req_handler): Handle the top-application D-Bus
233 method, which might be an undocumented D-Bus signal sent by
234 hildon-desktop when it starts the application from the menu.
235 But I am not sure and I need to test it on the device, because
236 my scratchbox does not have the application in the menu now.
237 This method shows the main window, so that it can be invisible
238 when started, for instance, just for email searching from
241 * src/maemo/modest-main-window.c: (restore_settings),
242 (modest_main_window_new): Do not show the window immediately
243 upon creation. We show it later.
244 * src/modest-widget-memory.c: (save_settings_paned):
245 Try (unsuccessfully) to avoid saving the paned position when
246 it is not even visible.
247 (restore_settings_paned): Do not allow a silly paned position.
248 This seems necessary when not showing the window at first.
250 * tests/dbus_api/Makefile.am:
251 * tests/dbus_api/test_top_application.c: (main): Test for the
254 2007-07-10 Murray Cumming <murrayc@murrayc.com>
256 * src/modest-ui-dimming-rules.c:
257 (modest_ui_dimming_rules_on_new_msg),
258 (modest_ui_dimming_rules_on_reply_msg),
259 (modest_ui_dimming_rules_on_delete_msg),
260 (modest_ui_dimming_rules_on_details),
261 (modest_ui_dimming_rules_on_view_window_move_to),
262 (modest_ui_dimming_rules_on_view_previous),
263 (modest_ui_dimming_rules_on_view_next),
264 (_invalid_folder_for_purge): Added checks before
265 casting the window. This looks like an actual
266 logic error in _invalid_folder_for_purge(), because it
267 tries to use a ModestMainWindow as a message window.
269 2007-07-10 Murray Cumming <murrayc@murrayc.com>
271 * src/maemo/modest-account-settings-dialog.c:
272 (show_error): Use the same implementation as in
273 modest-easysetup-wizard.c:
274 (on_entry_invalid_character): The logical ID contains a %s.
275 Guessed what it should be.
276 (on_entry_max), (check_data), (on_response): Adapt to
277 changed show_error().
278 (create_page_account_details): Really call
279 modest_validating_entry_set_func() on the correct widgets.
280 * src/maemo/easysetup/modest-easysetup-wizard.c:
281 (on_entry_invalid_character): Fix the logical ID here too.
282 (create_page_account_details),
283 (create_page_user_details):
285 modest_validating_entry_set_func() on the correct widgets.
287 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
288 Do not try to use the account if it is NULL.
290 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
292 * src/modest-ui-actions.c: (create_move_to_dialog),
293 (modest_ui_actions_on_main_window_move_to),
294 (modest_ui_actions_on_msg_view_window_move_to):
295 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
296 (filter_row), (modest_folder_view_show_non_move_folders):
297 * src/widgets/modest-folder-view.h:
299 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
300 the Sent folder yet as it does not report the correct folder type.
302 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
304 * src/maemo/modest-msg-edit-window.c: (init_window):
307 2007-07-10 Murray Cumming <murrayc@murrayc.com>
309 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
310 Take a parent widget instead of a parent window, and
311 implement this with hildon_banner_show_information() instead.
312 Non-Maemo builds can just ifdef that there.
313 This fixed projects.maemo.org bug NB#62766.
315 (on_entry_invalid_character): Use show_error() again instead
316 of using hildon directly, and use the _CS() macro to use the correct
318 (create_account), (check_for_supported_auth_methods), (on_entry_max):
319 Pass a widget instead od a window to show_error().
321 2007-07-10 Murray Cumming <murrayc@murrayc.com>
323 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
324 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
325 This allows us to show the server name in the error message, fixing
326 projects.maemo.org bug NB#62904.
327 Also, use the appropriate logical ID message for the account protocol.
329 2007-07-10 Murray Cumming <murrayc@murrayc.com>
331 * src/modest-tny-account-store.c: (on_idle_wrong_password):
332 A compilation fix, though the build wasn't broken for me.
334 2007-07-09 Murray Cumming <murrayc@murrayc.com>
336 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
337 Do not try to unref a NULL folder store, to avoid a runtime warning.
338 This seems to happen sometimes when changing accounts settings.
340 2007-07-09 Murray Cumming <murrayc@murrayc.com>
342 * src/modest-tny-account-store.c:
343 (modest_tny_account_store_instance_init),
344 (modest_tny_account_store_finalize),
345 (on_account_settings_hide), (on_idle_wrong_password):
346 Use a GHashTable to ensure that we only show one account settings
347 dialog per modest account. This avoids us having a dialog open for
348 both the store and transport accounts, or due to repeated get_password()
349 calls that shouldn't happen anyway.
351 2007-07-09 Murray Cumming <murrayc@murrayc.com>
353 * src/maemo/modest-maemo-utils.c: (on_hide),
354 (modest_maemo_show_dialog_and_forget): Handle the response, because
355 the window is not even hidden by default.
357 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
358 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
359 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
360 which seems to prevent some modality problems.
362 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
363 Ignore user cancellation errors.
365 * src/modest-account-mgr-helpers.h:
366 * src/modest-account-mgr-helpers.c:
367 Added modest_server_account_get_password() and
368 modest_server_account_get_has_password() to avoid direct use of
371 * src/maemo/modest-account-settings-dialog.h:
372 * src/maemo/modest-account-settings-dialog.c:
373 (modest_account_settings_dialog_init): Store the notebook so we can
375 Added modest_account_settings_dialog_switch_to_user_info().
377 * src/modest-tny-account-store.c:
378 (get_password): When the password in the account settings is wrong (we think),
379 show the relevant page of the account settings dialog, in the mainloop.
380 However, we currently get many of these at once because cancel does not
382 (forget_password): Do not forget the password
383 from the account settings, because this causes side-effects when
384 tinymail seems to call it at strange time, maybe because of how we
385 are cancelling get_password().
386 (modest_tny_account_store_alert): Ignore user cancellations.
388 2007-07-09 Murray Cumming <murrayc@murrayc.com>
390 * src/maemo/modest-maemo-utils.h:
391 * src/maemo/modest-maemo-utils.c:
392 Added modest_maemo_show_information_note_and_forget() for use instead of
393 gtk_dialog_run() when the response is not needed, to avoid an extra
394 mainloop which could cause a hang.
396 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
397 Use the logical IDs for the error message, though they are not
398 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
399 because gtk_dialog_run() caused a hang here (the window did not close).
400 This fixes projects.maemo.org bug NB#62646.
402 2007-07-09 Murray Cumming <murrayc@murrayc.com>
404 * src/modest-account-mgr-helpers.h:
405 * src/modest-account-mgr-helpers.c:
406 Added modest_account_mgr_get_store_protocol().
408 * src/maemo/modest-account-view-window.c:
409 (on_delete_button_clicked): Show different warning text depending on
410 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
411 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
414 2007-07-09 Murray Cumming <murrayc@murrayc.com>
416 * src/maemo/modest-msg-edit-window.c:
417 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
418 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
420 2007-07-07 Armin Burgmeier <armin@openismus.com>
422 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
423 ckdg_ib_maximum_characters_reached from correct package.
425 * src/modest-ui-actions.c: Show an error message when a folder could
426 not be created. Tinymail does not give us specific error codes about
427 what has gone wrong, so we assume that a folder with that name
428 already exists, though there might be other reasons.
430 2007-07-06 Murray Cumming <murrayc@murrayc.com>
432 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
433 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
434 give a more exact error message that can be partly translated.
436 2007-07-05 Murray Cumming <murrayc@murrayc.com>
438 * src/maemo/modest-address-book.c:
439 (select_email_addrs_for_contact): Specify a default window size for the
440 select-email-address dialog, so that it is probably big enough for the
441 title. This should fix projects.maemo.org bug NB#62277.
443 2007-07-05 Murray Cumming <murrayc@murrayc.com>
445 * src/maemo/easysetup/modest-easysetup-wizard.c:
446 (create_page_complete_easysetup): Use
447 gtk_widget_set_size() request to ensure that the text wraps
450 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
452 * src/maemo/easysetup/modest-easysetup-wizard.c:
453 (on_entry_invalid_character), (create_page_account_details),
454 (create_page_user_details):
455 Use new API of ModestValidatingEntry. But for some reason the banner is
456 not shown. I will have to investigate that further.
458 * src/widgets/modest-validating-entry.c: (on_insert_text),
459 (modest_validating_entry_set_func):
460 * src/widgets/modest-validating-entry.h:
461 Added a new callback function to be able to react to prevented
462 characters whitespaces to e.g show a banner.
464 2007-07-05 Armin Burgmeier <armin@openismus.com>
466 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
467 notification of HildonNumberEditor instead of remembering the port
468 number. Thanks to Johannes for pointing this out.
470 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
472 * src/maemo/easysetup/modest-easysetup-wizard.c:
473 Check if there are any user changes before showing a confirmation
474 dialog (projects.maemo.org NB#60946)
476 2007-07-05 Armin Burgmeier <armin@openismus.com>
478 * src/maemo/modest-account-settings-dialog.c: Remember custom port
479 number at the beginning of the dialog and set the modified flag at the
480 end if the port number has changed. This is necessary because
481 HildonNumberEditor does not support notification when the value has
484 2007-07-05 Murray Cumming <murrayc@murrayc.com>
486 * src/modest-ui-actions.c:
487 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
488 a connection before asking anything else. Correct the check for the destination
489 folder so that it succeeds when online.
490 This fixed projects.maemo.org bug NB#61645.
492 2007-07-05 Murray Cumming <murrayc@murrayc.com>
494 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
495 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
496 to fix projects.maemo.org bug NB#62439.
498 2007-07-05 Murray Cumming <murrayc@murrayc.com>
500 * src/modest-tny-account.c: (on_connection_status_changed):
501 Really do not use tny_device_force_offline() here. See the previous comment.
503 2007-07-04 Murray Cumming <murrayc@murrayc.com>
505 * src/modest-tny-account.c: (on_connection_status_changed):
506 Do not use tny_device_force_offline() when tinymail says that something
507 went wrong with the connection. It seems to report this unnecessarily.
509 2007-07-04 Murray Cumming <murrayc@murrayc.com>
511 * src/maemo/modest-connection-specific-smtp-window.c:
512 (modest_connection_specific_smtp_window_init):
513 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
514 does not seem to have any effect in osso 1.1 (though it works in
515 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
517 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
519 * src/maemo/modest-connection-specific-smtp-window.c:
520 Fix UI specification problems with projects.meamo.org NB#60479
522 2007-07-04 Murray Cumming <murrayc@murrayc.com>
524 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
525 clue when this has failed, because the error dialog is not always shown
526 (at least in earlier version).
528 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
529 GError message, because the generic error dialog is not helpful.
531 'This message is not currently available (can't let a new connection go online)'
532 when trying to open an IMAP message.
534 (_modest_ui_actions_open): Offer a connection when some messages would
535 have to be downloaded and we are offline.
537 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
539 * src/widgets/modest-folder-view.c:
540 Don't check for MERGE type anymore as we use the correct type
542 NOTE: For the last two changes you need to update your tinymail copy
543 because of API changes!
545 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
547 * src/modest-tny-local-folders-account.c:
548 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
549 (see projects.maemo.org NB#61580)
551 2007-07-04 Murray Cumming <murrayc@murrayc.com>
553 * src/modest-tny-account.c: (on_connection_status_changed):
554 Commented out the call to modest_platform_connect_and_wait() because this
555 seems to always hang, and I would like to know if this is the only thing
556 that causes a hang when showing the connection dialog.
557 It is not very useful anyway.
559 2007-07-04 Murray Cumming <murrayc@murrayc.com>
561 * src/maemo/modest-msg-view-window.c:
562 (modest_msg_view_window_select_next_message):
564 * src/modest-platform.h:
565 * src/maemo/modest-platform.c:
566 Added modest_platform_connect_and_wait(), which calls
567 tny_maemo_conic_device_connect() always in the main thread, by calling it
568 in an idle handler and waiting for the idle handler to run. It should be
569 in the main thread because it uses GTK+ UI code. It just returns TRUE
570 if the device is already online.
572 There is some nasty code to ensure that subsequent calls to
573 modest_platform_connect_and_wait() just wait for the first one to finish,
574 by checking repeatedly in another idle handler. This is necessary,
575 because other threads (or even the main thread, via another idle handler)
576 can call modest_platform_connect_and_wait() while
577 modest_platform_connect_and_wait() is running.
579 (modest_platform_connect_and_wait_if_network_account),
580 (modest_platform_connect_and_wait_if_network_folderstore):
581 Convenience functions that calls modest_platform_connect_and_wait() if
582 the account or folder might want network access.
584 * src/modest-mail-operation.c:
585 (modest_mail_operation_update_account):
586 * src/modest-ui-actions.c: (download_uncached_messages),
587 (modest_ui_actions_on_rename_folder), (delete_folder),
588 (modest_ui_actions_on_main_window_move_to),
589 (modest_ui_actions_on_msg_view_window_move_to):
590 * src/widgets/modest-folder-view.c:
591 (drag_and_drop_from_folder_view):
592 Offer a connection if we are offline.
594 * src/modest-tny-account.c: (on_connection_status_changed):
595 Document this as only handling errors during network operations in progress,
596 and replace the idle code with a simple call to
597 modest_platform_connect_and_wait(), which does this instead.
599 2007-07-03 Murray Cumming <murrayc@murrayc.com>
601 * src/modest-tny-account.c:
602 (modest_tny_account_get_special_folder): (util_on_idle),
603 Handle the GError so we can see when tny_folder_store_get_folders()
604 fails, as it currently does while something else is connecting.
606 Added util_run_in_main_thread_and_wait()
607 which uses an idlen handler and mainloop to ensure that the function
608 is called in the main thread.
609 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
610 to make sure that we call attempt the connection in the mainloop only,
611 which might solve some hangs.
613 2007-07-03 Murray Cumming <murrayc@murrayc.com>
615 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
616 be found by their display name. This is never useful.
617 * src/modest-tny-account-store.c: (on_account_removed): Find the account
618 by its ID, instead of trying to use its ID as its display name.
620 * src/modest-tny-account-store.h:
621 * src/modest-tny-account.c:
622 (modest_tny_account_get_special_folder): Add a g_warning() when
623 tny_folder_store_get_folders() returns an empty list for the maildir.
625 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
626 Add a g_warning() when this returns NULL, because that it not allowed
629 2007-07-02 Armin Burgmeier <armin@openismus.com>
631 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
632 note when trying to cancel the wizard. This fixes projects.maemo.org
635 2007-07-02 Murray Cumming <murrayc@murrayc.com>
637 * src/modest-tny-account.h:
638 * src/modest-tny-account.c:
639 (modest_tny_account_new_from_server_account),
640 (modest_tny_account_new_from_server_account_name),
641 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
642 because this must now be set before setting the proto. This is usd in
643 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
644 warning in camel_session_get_service() caused by
645 tny_camel_transport_account_prepare().
647 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
650 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
652 * src/maemo/modest-connection-specific-smtp-edit-window.c:
654 (modest_connection_specific_smtp_edit_window_init):
656 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
659 2007-06-29 Murray Cumming <murrayc@murrayc.com>
661 * src/modest-tny-account.c:
662 (modest_tny_account_new_from_server_account):
663 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
664 now uses to request a connection when it needs one, and which it uses
665 to tell us that something is wrong with the connection, so we can force
666 the accounts offline to prevent further problems.
669 * src/modest-init.c: (init_default_settings):
670 * src/modest-mail-operation.c:
671 (modest_mail_operation_update_account):
672 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
673 This should not be necessary anymore. Do not set the conf key that
674 determined this (it was always TRUE and not set anywhere else).
676 * src/modest-ui-actions.h: Remove unused and unimplemented
677 modest_ui_actions_on_online_toggle_toggled().
679 2007-06-29 Murray Cumming <murrayc@murrayc.com
681 * src/maemo/modest-main-window.c: (connect_signals):
682 Don't connect to delete_event twice. Maybe this was harmless.
684 2007-06-29 Murray Cumming <murrayc@murrayc.com
686 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
687 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
688 Debug output to give some more clue when a folder move is not allowed.
690 2007-06-28 Murray Cumming <murrayc@murrayc.com
692 * src/modest-tny-account.c: (on_modest_file_system_info),
693 (modest_tny_account_get_mmc_account_name):
694 Always call the callback, without checking whether the name has changed.
695 * src/widgets/modest-folder-view.c: (strings_are_equal),
696 (on_model_foreach_set_name), (on_get_mmc_account_name),
697 (text_cell_data): Compare the name here, and use the name from
698 the account rather than from the
699 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
700 if the name was changed after the account was added to the model.
701 That's a tinymail bug but not one that I want to fix now.
703 This finally fixes projects.maemo.org bug NB#59301.
705 2007-06-27 Armin Burgmeier <armin@openismus.com>
707 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
710 2007-06-27 Murray Cumming <murrayc@murrayc.com
712 * src/modest-tny-account.h:
713 * src/modest-tny-account.c:
714 Added modest_tny_account_get_mmc_account_name(), to set the memory
715 card name asynchronously for the given account and then notify.
716 (modest_tny_account_new_for_local_folders): Use this new function instead
717 of using hildon_file_system_info_async_new() directly.
719 * src/widgets/modest-folder-view.c: (text_cell_data):
720 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
721 gtk_tree_model_row_changed() when it is available.
723 This should fix projects.maemo.org bug NB#59301.
725 2007-06-27 Murray Cumming <murrayc@murrayc.com
727 * src/modest-mail-operation.c: (update_account_thread),
728 (get_msgs_full_thread): Fix typo failures in the revert
731 2007-06-27 Murray Cumming <murrayc@murrayc.com
733 * src/maemo/modest-maemo-global-settings-dialog.c:
734 (idle_select_default_focus):
735 * src/modest-mail-operation.c: (idle_notify_progress),
736 (idle_notify_progress_once), (set_last_updated_idle),
737 (update_account_thread), (get_msgs_full_thread):
738 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
739 * src/widgets/modest-header-view.c:
740 (idle_notify_headers_count_changed_destroy),
741 (idle_notify_headers_count_changed):
742 Reverted the additions of gdk_threads_enter/leave(), in case this
743 helps with a startup hang on the device.
745 2007-06-26 Armin Burgmeier <armin@openismus.com>
747 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
748 for supported secure authentication methods from server by
749 gtk_dialog_run(), saving CPU time and a potential race condition.
751 2007-06-26 Armin Burgmeier <armin@openismus.com>
753 * src/maemo/modest-maemo-utils.h:
754 * src/maemo/modest-maemo-utils.c: Added a
755 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
756 only error code to tell the calling code when the user canceled the
759 * src/maemo/modest-account-settings-dialog.h:
760 * src/maemo/modest-account-settings-dialog.c:
761 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
762 message if the retrieval of secure authentication methods was canceled
763 by the user. Perform the check before saving anything to configuration
764 to not end up with half-committed configuration changes, do not show
765 a "Saving to configuration failed" note when authentication methods
766 could not be retrieved.
768 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
771 2007-06-26 Murray Cumming <murrayc@murrayc.com>
773 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
774 Only return the first level of folders under accounts, because the
775 osso-global-search UI spec doesn't want the rest.
776 This fixed projects.maemo.org bug NB#61811.
778 2007-06-26 Murray Cumming <murrayc@murrayc.com>
780 * src/modest-tny-account-store.c:
781 * src/modest-tny-account-store.h:
782 Added modest_tny_account_is_memory_card_account().
783 * src/maemo/modest-main-window.c: (create_details_widget):
784 Show the same information items for the memory card as we show for the
785 local-folders, to fix projects.maemo.org bug NB#59307.
787 2007-06-26 Murray Cumming <murrayc@murrayc.com>
789 * src/modest-tny-account-store.c: (get_password):
790 Added some checks for NULL to maybe prevent crashes, though I think
791 it was Philip's last commit that actually prevented the crash here
792 when creating a first new account.
793 But the new account is still not usable (no messages are shown)
794 until a restart of the application.
796 2007-06-26 Murray Cumming <murrayc@murrayc.com>
798 * src/maemo/modest-maemo-global-settings-dialog.c:
799 (idle_select_default_focus):
800 * src/modest-mail-operation.c: (idle_notify_progress),
801 (idle_notify_progress_once), (idle_notify_update_account_queue),
802 (set_last_updated_idle), (update_account_thread),
803 (notify_get_msgs_full), (get_msgs_full_destroyer),
804 (get_msgs_full_thread):
805 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
806 * src/widgets/modest-header-view.c:
807 (idle_notify_headers_count_changed_destroy),
808 (idle_notify_headers_count_changed):
809 Use gdk_threads_enter() and gdk_threads_enter_leave() in
810 all idle handlers, because some other thread could be blocking
811 the GDK lock, so that it can do GUI stuff.
813 2007-06-26 Murray Cumming <murrayc@murrayc.com>
815 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
816 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
817 (on_idle_send_receive), (on_idle_open_default_inbox):
818 * src/maemo/modest-msg-edit-window.c:
819 (modest_msg_edit_window_attach_file_noninteractive):
820 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
821 to prevent a hang. I don't quite understand why these are necessary,
822 beause we should already be in the main loop. I guess something outside
823 of the main loop is taking the lock.
825 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
826 we are really using URIs, and use files that are more likely to exist.
828 2007-06-26 Murray Cumming <murrayc@murrayc.com>
830 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
831 necessary because configure.ac now defines different variables.
833 2007-06-26 Murray Cumming <murrayc@murrayc.com>
835 * libmodest-dbus-client/libmodest-dbus-client.c:
836 * libmodest-dbus-client/libmodest-dbus-client.h:
837 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
838 libmodest_dbus_client_compose_mail() is what things actually use.
840 * src/dbus_api/modest-dbus-api.h:
841 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
842 * tests/dbus_api/Makefile.am:
843 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
846 2007-06-26 Murray Cumming <murrayc@murrayc.com>
848 * src/modest-init.c: (modest_init_local_folders):
849 For memory-card (or other non local-folders) maildir accounts,
850 always create an Archive folder, so that there is somewhere to put
851 messages. This should be less confusing, because the user does not need
852 to guess that the need to create a folder.
854 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
856 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
857 Fixed icon size by using (50, 50) which is the same as defined by
860 2007-06-25 Armin Burgmeier <armin@openismus.com>
862 * src/widgets/modest-window-mgr.c:
864 * configure.ac: Correctly recognize hildon-notify presence and fixed
865 the build without it being installed.
867 2007-06-25 Murray Cumming <murrayc@murrayc.com>
869 * libmodest-dbus-client/libmodest-dbus-client.c:
870 (libmodest_dbus_client_search): Fix the build. Sorry.
871 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
872 (reply_forward_cb): Initialize variables to fix the build.
874 * src/modest-tny-account-store.c:
875 (modest_tny_account_store_get_tny_account_by): Fix the account URI
876 comparison (a silly typo) so that email search results can be opened
877 when there are more than one account.
879 2007-06-25 Murray Cumming <murrayc@murrayc.com>
881 * libmodest-dbus-client/libmodest-dbus-client.c:
882 (libmodest_dbus_client_search),
883 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
884 instead of 1 second, because the search gets folders and messages from
885 the server, which can take a long time. When it times out,
886 osso-global-search will report no results.
888 We need to specify whether we should search only cached information
889 (maybe with a user preference), and the osso-email-search-plugin
890 API should really be improved to allow that option, and to allow results
891 to be delivered asynchronously in batches.
893 2007-06-25 Murray Cumming <murrayc@murrayc.com>
895 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
896 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
897 GTK_ICON_SIZE_DIALOG is probably the wrong size.
899 2007-06-25 Murray Cumming <murrayc@murrayc.com>
901 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
902 that is an empty string. D-Bus seems to give us these instead of NULL.
904 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
906 * src/dbus_api/modest-dbus-callbacks.c:
907 * src/maemo/easysetup/modest-easysetup-wizard.h:
908 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
909 * src/maemo/modest-connection-specific-smtp-edit-window.c:
910 (modest_connection_specific_smtp_edit_window_init):
911 * src/maemo/modest-maemo-global-settings-dialog.c:
913 * src/maemo/modest-maemo-utils.c:
914 (modest_maemo_utils_setup_images_filechooser):
915 * src/maemo/modest-main-window.c: (create_details_widget):
916 * src/maemo/modest-msg-edit-window.c:
917 (modest_msg_edit_window_attach_file_noninteractive),
918 (modest_msg_edit_window_color_button_change),
919 (modest_msg_edit_window_set_zoom):
920 * src/modest-mail-operation.c: (update_account_thread):
921 * src/modest-tny-account-store.c:
922 * src/modest-tny-account.c:
923 * src/widgets/modest-global-settings-dialog.c:
924 * src/widgets/modest-window.h:
928 2007-06-25 Murray Cumming <murrayc@murrayc.com>
930 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
931 * src/modest-search.c: (modest_search_folder),
932 (modest_search_all_accounts): Actually search only in the specified folder,
933 doing a simple match on the folder ID.
934 * src/modest-search.h: Added a folder field to the ModestSearch struct,
935 and added some documentation.
937 2007-06-22 Armin Burgmeier <armin@openismus.com>
939 * src/maemo/modest-maemo-utils.h:
940 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
941 modest_maemo_utils_get_supported_secure_authentication_methods.
943 * src/maemo/easysetup/modest-easysetup-wizard.c:
944 * src/maemo/modest-account-settings-dialog.c: Show correct error if
945 one occured, not just "Server does not support secure authentication".
947 2007-06-22 Murray Cumming <murrayc@murrayc.com>
949 * src/modest-tny-account-store.c: (get_password):
950 Restored the call to tny_account_set_user() because Philip seems to have
951 stopped this from crashing (by not using the freed string). It still does
952 not work, but now we can test it.
954 2007-06-22 Murray Cumming <murrayc@murrayc.com>
956 * src/maemo/modest-msg-edit-window.c: (init_window):
957 Comment out use of an uninitialzed GtkScrolledWindow variable,
958 to fix the build and stop a crash. Yet again.
960 2007-06-22 Murray Cumming <murrayc@murrayc.com>
962 * src/modest-tny-account-store.c: (get_password):
963 Remove the call to tny_account_set_user() because this actually crashes.
964 As mentioned in the last commit, it is known to not work anyway.
966 2007-06-22 Murray Cumming <murrayc@murrayc.com>
968 * src/modest-tny-account-store.c: (get_password):
969 Use tny_account_set_username() to tell tinymail that the username might
970 have changed too. But tinymail ignores this: see projects.maemo.org
972 * src/modest-ui-actions.c:
973 (modest_ui_actions_on_password_requested): Remove the useless attempt to
974 reset the connection when changing the username, and improve the comments.
975 Save the changed username to gconf at least, so it is used when Modest is
978 2007-06-21 Murray Cumming <murrayc@murrayc.com>
980 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
981 Do not use a query, so that we get all folders, including for POP and
982 local-folders. They work as search criteria too.
983 This fixes projects.maemo.org bug NB#57740.
985 2007-06-21 Murray Cumming <murrayc@murrayc.com>
987 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
988 Comment out the use of hildon_notification_set_sound() because it is
989 not declared, to fix the build. Warnings are serious, people.
991 2007-06-21 Armin Burgmeier <armin@openismus.com>
993 * src/maemo/modest-maemo-utils.h:
994 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
995 modest_maemo_utils_get_supported_secure_authentication_methods()
996 to query authentication methods for a specific user. This should fix
997 projects.maemo.org bug NB#61369.
999 * src/maemo/easysetup/modest-easysetup-wizard.c:
1000 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1003 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1005 * libmodest-dbus-client/libmodest-dbus-client.h:
1006 * libmodest-dbus-client/libmodest-dbus-client.c:
1007 (modest_dbus_message_iter_get_search_hit),
1008 (libmodest_dbus_client_search):
1009 Reorganised and commented this.
1010 Removed modest_search_hit_free() from the public API because it
1013 Added libmodest_dbus_client_get_folders() and
1014 modest_folder_result_list_free().
1016 * src/dbus_api/modest-dbus-api.h:
1017 * src/dbus_api/modest-dbus-callbacks.c:
1018 (modest_dbus_req_filter): Commented. Moved most code to
1019 on_dbus_method_search() and added on_dbus_method_get_folders().
1021 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1022 of the extra D-Bus handler.
1024 * tests/dbus_api/Makefile.am:
1025 * tests/dbus_api/test_get_folders.c: New test for
1026 libmodest_dbus_client_get_folders(). This seems to return an empty list
1027 at the moment. That could be the same error that causes the message list
1028 to be empty sometimes.
1029 This should help with projects.maemo.org bug NB#57740.
1031 2007-06-21 Armin Burgmeier <armin@openismus.com>
1033 * src/modest-mail-operation.c: Do not call
1034 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1035 notify the operation's end after having set the status to CANCELED for
1036 the operation queue to listen on. This fixes a deadlock when there
1037 were mail operations in the queue during its finalization.
1039 * src/modest-singletons.c: Reordered uninitialization of the account
1040 manager to happen after the mail operation queue was uninitialized
1041 because the mail operation's in the queue might still try to access
1042 the account manager (see modest_mail_operation_notify_end()). This
1043 fixes a potential crash when terminating the application.
1045 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1047 * src/modest-search.c:
1048 (search_mime_part_and_child_parts): Moved some code here so we
1049 can search recursively in child folders.
1050 (modest_search_folder): Search in the message as a mime part, instead
1051 of just its child mime parts.
1052 (read_chunk), (search_mime_part_ogs):
1053 Check how many bytes were read, to prevent an endless loop.
1054 Searching in message bodies now works. This finishes the fix for
1055 projects.maemo.org bug NB#61007.
1057 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1059 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1060 Add a g_warning when the item is not a folder.
1062 * src/modest-ui-dimming-rules.c:
1063 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1064 when selected item is not a folder (for instance, an account), because
1065 the UI spec only talks about folders.
1066 I am not sure what the UI spec wants, so this might not totally fix
1067 projects.maemo.org bug NB#60794.
1069 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1071 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1072 (load_from_file): Sort the list. The unsorted list would be more noticeable
1073 in non-English locales.
1075 * src/maemo/modest-msg-edit-window.c:
1076 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1077 warning and fix the build.
1079 * src/maemo/modest-progress-bar-widget.c:
1080 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1081 avoid a g_warning, and probably to avoid a crash.
1083 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1085 * src/modest-search.c: (modest_search_folder): Check for a GError
1086 when calling tny_folder_get_headers(), to show that this is not the cause
1089 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1091 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1092 Actually set the body query instead of the subject query.
1094 * src/modest-search.c: (search_mime_part_ogs),
1095 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1096 which would probably cause it to fail if we got this far.
1098 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1099 to simplify the code.
1100 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1101 be causing search-in-body to fail.
1103 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1105 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1107 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1108 Better debug message when the folder cannot be found.
1109 This should help with fixing projects.maemo.org bug #61287.
1110 * src/modest-search.c: (add_hit): Do not leak the furl string.
1112 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1114 * src/modest-ui-actions.c:
1115 (modest_ui_actions_on_folder_selection_changed):
1116 Do not special-case TNY_MERGE_FOLDER here, because
1117 modest_tny_folder_get_account() already does that. This fixes
1118 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1119 shown when the Outbox was selected).
1121 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1123 * libmodest-dbus-client/libmodest-dbus-client.c:
1124 (_dbus_iter_get_string_or_null): Initialize the string variable in
1125 case this helps with Dirk's crash.
1127 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1129 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1130 though it is not implemented yet (this function is maybe not even used),
1131 to avoid breaking ABI in future.
1132 * libmodest-dbus-client/libmodest-dbus-client.c:
1133 (get_attachments_string): Moved some code into this generic function.
1134 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1135 sends email. It is maybe not used.
1136 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1137 (on_send_mail): Use attachments.
1139 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1140 * src/maemo/modest-msg-edit-window.c:
1141 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1142 a filename before using it, to fix projects.maemo.org bug NB#58233.
1144 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1146 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1147 Initialize the continue_download variable to fix the build, and probably
1148 to fix randome behaviour.
1150 2007-06-18 Armin Burgmeier <armin@openismus.com>
1152 * src/modest-tny-send-queue.h:
1153 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1154 the queue so we can later show it in the UI. Replaced
1155 modest_tny_send_queue_msg_is_being_sent() by
1156 modest_tny_send_queue_get_msg_status().
1158 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1160 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1161 gpointer. This probably was not harmful, but just to be sure.
1163 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1165 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1166 Fix the build, but leave the function broken on Bora, because
1167 hildon_uri_action_get_service() does not exist.
1168 osso_uri_action_get_service() does not exist either, it seems.
1170 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1172 * src/modest-tny-account.c:
1173 (modest_tny_account_new_from_server_account):
1174 Uncommented the url debug output again, because it is useful for
1175 debugging, as I said in the comment.
1177 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1179 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1181 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1182 for Mameo Bora, to fix the build.
1184 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1187 Fixed build with hildon < 0.99
1189 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1190 Check if the selected account is busy instead of checking all accounts
1192 * src/modest-account-mgr-priv.h:
1193 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1194 (modest_account_mgr_init), (compare_account_name),
1195 (modest_account_mgr_set_account_busy),
1196 (modest_account_mgr_account_is_busy):
1197 * src/modest-account-mgr.h:
1198 Added busy information to the account manager. It possible to
1199 set an account to busy or not busy now.
1201 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1202 (modest_mail_operation_update_account),
1203 (modest_mail_operation_notify_end):
1204 Set the account to busy/not busy depending on the operation state.
1206 * src/widgets/modest-account-view.c:
1207 (modest_account_view_finalize), (get_last_updated_string),
1208 (update_account_view), (on_account_busy_changed), (init_view):
1209 Show string "Refreshing..." if the account is currently busy.
1211 All this fixes projects.maemo.org bug NB#59711
1213 2007-06-14 Armin Burgmeier <armin@openismus.com>
1215 * src/widgets/modest-attachments-view.h:
1216 * src/widgets/modest-attachments-view.c: Added
1217 modest_attachments_view_has_attachments() and fixed coordinate
1218 transformation in get_att_view_at_coords(). This fixes attachment
1221 * src/widgets/modest-msg-view.c: Make use of
1222 modest_attachments_view_has_attachments() to decide whether to show
1223 attachments in the header.
1225 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1227 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1228 (on_change), (on_combo_security_changed),
1229 (modest_connection_specific_smtp_edit_window_init),
1230 (modest_connection_specific_smtp_edit_window_set_connection),
1231 (modest_connection_specific_smtp_edit_window_is_dirty):
1232 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1233 * src/maemo/modest-connection-specific-smtp-window.c:
1236 Show an comfirmation dialog for the smpt-edit-window if there are
1237 unsaved changes and the user hits cancel.
1238 (projects.maemo.org bug NB#60479)
1240 2007-06-14 Armin Burgmeier <armin@openismus.com>
1242 * src/maemo/easysetup/modest-easysetup-wizard.c:
1243 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1244 address" info in banner instead of node, and select all the text as
1245 per UI spec. This fixes projects.maemo.org bug NB#60550.
1247 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1249 reviewed by: <delete if not using a buddy>
1251 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1252 * src/modest-ui-actions.c: (folder_refreshed_cb):
1254 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1256 * src/widgets/modest-folder-view.c: (filter_row):
1257 Explictly filter out the per-account outbox accounts. I don't know why
1258 these only sometimes show up, but now they should never show up in the UI.
1259 This should fix projects.maemo.org bug NB#60160.
1261 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1263 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1264 when the toolbar does not exist yet.
1265 * src/modest-widget-memory.c: (save_settings_header_view):
1266 Added g_warnings() to help us to discover when we are trying to set
1267 an empty columns list in gconf.
1269 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1271 * src/modest-init.h:
1272 * src/modest-init.c:
1273 Added modest_init_get_default_header_view_column_ids().
1275 * src/modest-widget-memory.c: (restore_settings_header_view):
1276 Use the new function to get defaults, if the gconf key is empty,
1277 instead of not creating any columns. This seems to fix the
1278 empty right-hand pane problems.
1280 * src/widgets/modest-header-view.h: Improved documentation.
1282 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1284 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1285 Revert the use of the display name as the account name, because this
1286 is generally wrong and would break the code that follows.
1288 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1290 * src/maemo/easysetup/modest-easysetup-wizard.c:
1291 (check_for_supported_auth_methods), (on_before_next),
1294 More correct fix for projects.maemo.org bug NB# 58991
1295 Do not longer accept AUTH_PASSWORD as secure method and choose
1296 correct method when creating the account.
1298 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1300 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1301 Fixed projects.maemo.org bug NB# 58991
1303 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1305 * src/modest-init.c: (modest_init_init_core),
1306 (modest_init_local_folders): Fixed compilation errors.
1308 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1310 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1311 Remove unnecessary lib/include, though it is good in principle when needed.
1313 * src/modest-init.c: (modest_init_one_local_folder),
1314 (modest_init_local_folders):
1315 * src/modest-init.h: Initialize the .modest library for memory cards,
1316 instead of just doing nothing for them. This should allow us to create
1317 folders there, fixing projects.maemo.org bug NB#59297.
1319 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1321 * libmodest-dbus-client/libmodest-dbus-client.c:
1322 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1323 (libmodest_dbus_client_compose_mail),
1324 (libmodest_dbus_client_open_message),
1325 (libmodest_dbus_client_send_and_receive),
1326 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1328 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1329 (on_idle_open_message), (modest_dbus_req_handler),
1330 (search_result_to_message), (modest_dbus_req_filter):
1331 * src/modest-search.c: (add_hit), (modest_search_folder),
1332 (modest_search_all_accounts): Improved debug messages.
1334 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1336 * src/modest-tny-account-store.c:
1337 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1340 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1343 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1345 * src/modest-tny-account-store.c: (get_server_accounts):
1346 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1347 even when there are no accounts, so that the Outbox folder is always
1348 visible. This fixes projects.maemo.org bug NB#60158.
1350 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1352 * src/maemo/modest-main-window.c: (create_details_widget):
1353 Use the mcen_va_never logical ID.
1355 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1357 * src/dbus_api/modest-dbus-api.h:
1358 * src/dbus_api/modest-dbus-callbacks.c:
1359 (on_idle_open_default_inbox), (on_open_default_inbox),
1360 (modest_dbus_req_handler):
1361 Added a new OpenDefaultInbox method.
1363 * libmodest-dbus-client/libmodest-dbus-client.h:
1364 * libmodest-dbus-client/libmodest-dbus-client.c:
1365 Added libmodest_dbus_client_open_default_inbox() to call the new
1366 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1367 though it should maybe be used by a new osso-email-interface function.
1369 * tests/dbus_api/Makefile.am:
1370 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1373 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1375 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1376 NULL, so that the signals get all the keys. This should not actually
1377 change any behaviour because we currently update everything when anything
1380 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1382 * src/widgets/modest-folder-view.c: (text_cell_data),
1383 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1384 (find_inbox_iter): If tinymail tells us that the folder is
1385 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1386 This causes the inbox to be selected at startup, fixing part of
1387 projects.maemo.org bug NB#56305.
1389 * src/modest-ui-dimming-rules.c:
1390 (modest_ui_dimming_rules_on_tools_smtp_servers):
1391 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1392 the SMTP servers menu item.
1393 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1394 that the SMTP Servers menu item is dimmed when there are no accounts,
1395 as a future version of the UI spec will require. This fixes
1396 projects.maemo.org bug NB#56305.
1398 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1400 * src/maemo/modest-maemo-utils.c:
1401 (modest_maemo_utils_get_supported_secure_authentication_methods):
1402 Added label to dialog instead of unreadable title
1404 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1405 (modest_main_window_new):
1406 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1409 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1410 * src/modest-account-mgr.h:
1411 Added method to avoid code duplication
1413 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1414 (modest_ui_actions_on_send_receive):
1415 Use modest_account_mgr_has_accounts
1417 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1419 * src/maemo/easysetup/modest-presets.c:
1420 (modest_presets_get_info_server_security): Do not report secure auth
1422 * src/modest-protocol-info.c: Use the defines for the gconf key names
1423 for secure authentication. This was not working because we were writing
1424 Password and reading password, and the check was case sensitive.
1425 With this, gmail now works for receiving and sending when created via
1428 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1430 * src/maemo/easysetup/modest-presets.c:
1431 (modest_presets_get_info_server_security): Correct the key name for
1432 SecureSmtp, because it seems to be case-sensitive.
1433 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1434 Do not try to get the 0th notebook page if there are 0 pages, to
1435 avoid a g_warning().
1437 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1439 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1440 Prevent use of the new notification feature for now, because it currently
1441 shows one dialog for each new email, which is annoying.
1443 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1445 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1446 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1447 when no country was selected, so that we show the global ones.
1448 * src/maemo/easysetup/modest-presets.c:
1449 (modest_presets_get_providers): Return only the global providers, not
1450 all providers when mmc=0 was requested.
1452 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1454 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1455 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1456 provider ID in the combo.
1458 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1459 Do not show the page numbers, because it would be confusing when we add
1460 the 2 extra pages for the custom setup, when the user chooses the "Other"
1461 provider. This fixes projects.maemo.org bug NB#59028
1463 * src/modest-init.c: (modest_init_init_core),
1464 (modest_init_local_folders):
1465 * src/modest-init.h:
1466 * src/modest-tny-account.c:
1467 (modest_tny_account_new_for_local_folders): Do not create default folders
1468 for the memory card. This should fix projects.maemo.org bug NB#59328.
1470 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1472 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1473 Free the changed_conf_keys string items. They are already freed in the
1474 idle handler if that runs first.
1476 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1478 * src/modest-ui-actions.c:
1479 (modest_ui_actions_on_password_requested): Check that the server name
1480 is not NULL, because I just saw a password dialog with (null) as the
1483 * src/modest-tny-folder.[h|c]: Added
1484 modest_tny_folder_is_memory_card_folder().
1485 * src/modest-ui-dimming-rules.c:
1486 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1487 menu item for memory cards, as per the UI spec (section 7.4). This should
1488 fix projects.maemo.org bug NB#59297.
1490 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1492 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1493 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1494 is another problem with the code, see Murray's comment at line 772)
1496 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1498 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1499 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1500 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1501 (load_from_file), (easysetup_country_combo_box_init),
1502 (easysetup_country_combo_box_get_active_country_ids),
1503 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1504 instead of just one ID, to avoid duplicate country names in the UI.
1506 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1507 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1508 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1509 a single ID, avoiding duplicate providers.
1510 * src/maemo/easysetup/modest-easysetup-wizard.c:
1511 (on_combo_account_country): Adapt to use a list.
1513 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1515 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1516 keys changed in the last X seconds.
1518 * src/modest-account-mgr.h:
1519 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1520 (on_key_change), (modest_account_mgr_class_init),
1521 (modest_account_mgr_init), (modest_account_mgr_finalize):
1522 As the keys are changed, save them in a GSList* and signal that GSList*
1523 further every X seconds, to batch changes, to allow us to do just one
1524 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1525 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1527 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1528 changed signal signature.
1530 * src/modest-conf.c: (modest_conf_set_list),
1531 (modest_conf_on_change): Reenable notification.
1533 (modest_conf_maemo_fake_on_change): Comment out the hack that
1534 notified immediately instead of asynchronously.
1536 * src/widgets/modest-account-view.h:
1537 * src/widgets/modest-account-view.c:
1538 (update_account_view): Select the previously-selected account ID,
1539 if possible. This fixes projects.maemo.org bug NB#56933.
1541 (on_account_changed), (on_account_removed),
1542 (modest_account_view_select_account):
1544 Remove the block/unblock functions
1545 because they were not useful.
1547 * src/maemo/modest-account-view-window.c:
1548 (on_delete_button_clicked), (on_edit_button_clicked),
1549 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1551 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1553 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1554 Improve the error dialog to show Incorrect Account Settings, which seems
1555 clearer, and say that the internal error message (to be removed from the
1556 dialog later) is often misleading.
1557 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1559 * src/modest-tny-account.c:
1560 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1561 URL because this is so useful for debugging on the device.
1563 * src/widgets/modest-serversecurity-combo-box.c:
1564 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1566 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1568 * src/modest-mail-operation.c:
1569 (modest_mail_operation_send_new_mail):
1570 Added a comment about a nasty but apparently harmless message. Details
1571 added to the wiki g_warnings() page.
1573 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1575 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1576 (modest_tny_send_queue_class_init):
1577 Do not use the priv struct because it is empty, to avoid g_warnings
1578 about a non-existant priv struct.
1580 * src/modest-tny-account-store.c:
1581 (modest_tny_account_store_get_server_account),
1582 (modest_tny_account_store_get_transport_account_for_open_connection
1583 ): Do not try to get transport server accounts for local folders,
1584 because they don't have any. This avoids a g_warning().
1586 * src/maemo/modest-main-window.c:
1587 (modest_main_window_notify_send_receive_initied),
1588 (on_configuration_key_changed):
1589 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1590 * src/modest-defs.h:
1591 * src/modest-mail-operation.c:
1592 (modest_mail_operation_update_account):
1593 * src/modest-tny-account-store.h:
1594 * src/modest-tny-account.c:
1595 (modest_tny_account_get_special_folder),
1596 (modest_tny_account_new_for_local_folders),
1597 (modest_tny_account_new_for_per_account_local_outbox_folder):
1598 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1599 * src/modest-tny-local-folders-account.c:
1600 (add_account_folders_to_merged_folder):
1601 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1602 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1603 (modest_ui_actions_on_send):
1604 * src/widgets/modest-folder-view.c: (update_model):
1605 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1606 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1607 modest_tny_account_store_get_tny_account_by_account() to
1608 modest_tny_account_store_get_server_account() to make the code clearer.
1610 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1612 * src/dbus_api/modest-dbus-api.h:
1613 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1614 * src/maemo/modest-msg-edit-window.c:
1615 (modest_msg_edit_window_attach_file_noninteractive):
1616 added g_warning in case the file to be attached does not exist
1617 * tests/dbus_api/test_compose_mail.c: (main):
1618 removed obsolete comment, added generic files as test case
1620 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1622 * src/modest-tny-account-store.c: (get_server_accounts):
1623 Create the local folders account only once, not once for each outbox, and
1624 not only when there are some outboxes.
1626 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1628 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1629 code that is causing a crash at startup. Sergio says that he is fixing this.
1631 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1633 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1634 * src/maemo/modest-account-settings-dialog.c:
1635 (create_page_outgoing),
1636 (modest_account_settings_dialog_set_account_name),
1637 (save_configuration):
1638 - Fixed handling of the "Use secure authentication" toggle to comply with
1639 the ui specification. See also projects.maemo.org bug NB#58400
1641 - Restore the Secure connection setting combo correctly when loading
1644 * src/maemo/modest-maemo-utils.c:
1645 (on_camel_account_get_supported_secure_authentication),
1646 (modest_maemo_utils_get_supported_secure_authentication_methods):
1647 Fixed a crasher if operation is canceled
1649 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1650 (modest_protocol_info_auth_is_secure):
1651 * src/modest-protocol-info.h:
1653 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1654 the sense of the "Use secure authentication" toggle.
1656 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1658 * src/modest-tny-account-store.h:
1659 * src/modest-tny-account-store.c:
1660 Added modest_tny_account_store_get_local_folders_account().
1662 * src/modest-tny-folder.h:
1663 * src/modest-tny-folder.c:
1664 (modest_tny_folder_get_account):
1665 Added this replacement for tny_folder_get_account() which returns
1666 the local-folders account for TnyMergeFolders, to avoid the
1667 warning about the unimplemented get_account_func() vfunc().
1669 (modest_tny_folder_get_rules),
1670 * src/modest-ui-actions.c:
1671 (modest_ui_actions_on_folder_selection_changed):
1672 * src/modest-mail-operation.c:
1673 (modest_mail_operation_remove_folder),
1674 (modest_mail_operation_xfer_folder),
1675 (modest_mail_operation_rename_folder),
1676 (modest_mail_operation_get_msg),
1677 (modest_mail_operation_get_msgs_full),
1678 (modest_mail_operation_remove_msg),
1679 (modest_mail_operation_xfer_msgs),
1680 (modest_mail_operation_refresh_folder):
1681 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1683 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1685 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1686 (modest_server_account_set_security):
1687 * src/modest-defs.h: Add comments explaining that our
1688 UI spec means TLS when it says Normal, so these do not look like errors.
1690 * src/modest-tny-account.c:
1691 (modest_tny_account_new_from_server_account): Use the new tinymail
1692 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1693 for TLS. This should fix projects.maemo.org bug NB#58460.
1695 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1697 * src/maemo/easysetup/modest-easysetup-wizard.c:
1698 (create_account): Correct the position of the gconf sanity check warning.
1699 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1700 of using the g_idle_add() hack, because this does not seem to be necessary
1701 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1702 caused by something other than maemo's gconf.
1703 This fixes projects.maemo.org bug #59022.
1705 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1707 * src/modest-account-mgr-helpers.c:
1708 (modest_account_mgr_get_default_account): Do not check that the account
1709 exists if there is no default account (NULL), to fix a runtime warning.
1711 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1713 * src/widgets/modest-folder-view.c: (update_model):
1714 Do not unref the treemodel before we have finished with it.
1715 This prevents a valgrind warning and an occasional crash at startup.
1717 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1719 * libmodest-dbus-client/libmodest-dbus-client.h:
1720 added libmodest_dbus_client_compose_mail()
1721 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1723 added functions needed for SendAsMail() functionality
1724 * src/maemo/modest-msg-edit-window.c:
1725 (modest_msg_edit_window_attach_file_noninteractive):
1726 non interactively attaching files to message edit window
1727 * src/widgets/modest-msg-edit-window.h:
1728 * tests/dbus_api/Makefile.am:
1729 added test_compose_mail.c
1730 * tests/dbus_api/test_compose_mail.c: (main):
1732 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1734 * src/modest-account-view.c:
1735 Fixed bug projects.maemo.org bug NB#59307
1737 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1739 * src/maemo/easysetup/modest-easysetup-wizard.c:
1740 (get_serverport_incoming), (on_before_next), (create_account):
1741 * src/maemo/modest-account-settings-dialog.c:
1742 (modest_account_settings_dialog_set_account_name):
1743 * src/maemo/modest-maemo-utils.c:
1744 (on_camel_account_get_supported_secure_authentication_status),
1745 (on_camel_account_get_supported_secure_authentication),
1746 (on_secure_auth_cancel),
1747 (modest_maemo_utils_get_supported_secure_authentication_methods):
1749 Implemented security authentication for settings and easysetup.
1751 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1753 * src/maemo/modest-main-window.c: (create_details_widget):
1754 Show the total size for memory card accounts too, instead of showing
1755 the name again. Fixes bug projects.maemo.org bug NB#59307.
1757 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1760 * src/modest-tny-simple-folder-store.c:
1761 * src/modest-tny-simple-folder-store.h: Removed.
1763 * src/modest-tny-local-folders-account.h
1764 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1765 for the local-folders maildir, with an extra TnyMergedFolder containing
1766 the folders of the per-account outbox store accounts.
1767 * src/modest-tny-account-store.c: (get_server_accounts):
1768 Add the outboxes to the special local folders account after creating it.
1770 * src/modest-tny-account.c:
1771 (modest_tny_account_new_for_local_folders): Create the derived
1772 account when creating the main local-folders account.
1774 * src/maemo/modest-main-window.c: (create_details_widget),
1775 (modest_main_window_set_contents_style):
1776 Adapted to the use of the derived account instead of the folder store.
1778 * src/modest-ui-actions.c:
1779 (modest_ui_actions_on_folder_selection_changed):
1780 * src/modest-ui-dimming-rules.c:
1781 (modest_ui_dimming_rules_on_new_folder):
1782 * src/widgets/modest-folder-view.c: (text_cell_data),
1783 (icon_cell_data), (filter_row), (update_model),
1784 (get_cmp_rows_type_pos):
1787 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1788 Do not get the priv struct, because no priv struct has been set,
1789 to avoid a runtime warning.
1791 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1792 #ifelse with #else, to fix a warning, to fix the build.
1795 2007-06-05 Christian Kellner <ckellner@openismus.com>
1797 * libmodest-dbus-client/libmodest-dbus-client.c:
1798 Fix small typo in doc (why do you always see them
1799 AFTER committing stuff?)
1802 2007-06-05 Christian Kellner <ckellner@openismus.com>
1804 * libmodest-dbus-client/libmodest-dbus-client.c:
1805 (libmodest_dbus_client_search):
1806 Initialize hit list with NULL. Also set folder list
1807 to "" if NULL was supplied.
1810 2007-06-03 Christian Kellner <ckellner@openismus.com>
1812 * libmodest-dbus-client/libmodest-dbus-client.c:
1813 (modest_search_hit_list_free):
1814 Make it save to call it with NULL.
1816 * src/dbus_api/modest-dbus-callbacks.c:
1817 * src/modest-search.c:
1818 Return full ModestSearchHits as the search result list not TnyHeader
1819 since can't be around withouth the correspoding TnyFolder.
1821 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1823 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1824 Added currently commented code to check for secure auth
1826 * src/maemo/modest-account-settings-dialog.c: (on_response),
1827 (save_configuration), (show_ok):
1828 Fixed projects.maemo.org bugs NB #59248 and #59251
1830 * src/maemo/modest-maemo-utils.c:
1831 (on_camel_account_get_supported_secure_authentication_status),
1832 (on_camel_account_get_supported_secure_authentication),
1833 (modest_maemo_utils_get_supported_secure_authentication_methods):
1834 * src/maemo/modest-maemo-utils.h:
1835 Moved get_supported_secure_authentication() method here to be able
1836 to use it from easysetup wizard.
1838 * src/modest-pair.c: (on_pair_compare_as_string):
1839 Should compare string with first part of pair and not
1840 strcmp pairs which will crash.
1842 * src/modest-protocol-info.c:
1843 (modest_protocol_info_protocol_is_store):
1844 * src/modest-protocol-info.h:
1845 Added modest_protocol_info_get_auth_protocol_name()
1847 2007-06-03 Armin Burgmeier <armin@openismus.com>
1849 * src/modest-mail-operation.c:
1850 (modest_mail_operation_get_msgs_full): Set priv->account also when
1851 only retrieving a single message. This avoids a crash when canceling
1854 (modest_mail_operation_notify_end): Do not explicitely remove the
1855 operation from the queue but only emit the progress_changed signal.
1856 The queue itself listens to that signal to remove the operation when
1857 it is finished. This reduces coupling and removes a potential deadlock
1858 when modest_mail_operation_notify_end() is called from the queue
1859 itself. If that is a problem performance-wise, I would suggest to
1860 implement a status-changed signal or something.
1862 * src/modest-mail-operation-queue.c: Make sure to never call a
1863 function from another file while the queue is locked. This (hopefully)
1864 fixes another deadlock when exiting the application while retrieving
1867 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1869 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1870 Fixed build if libogs is not available
1872 2007-06-03 Christian Kellner <ckellner@openismus.com>
1874 * libmodest-dbus-client/libmodest-dbus-client.h:
1875 * libmodest-dbus-client/libmodest-dbus-client.c:
1876 (libmodest_dbus_client_delete_message):
1877 Implement deletion of messages (Client side).
1879 (modest_search_hit_free),
1880 (modest_search_hit_list_free):
1881 Utility functions to free the result hits.
1883 * src/dbus_api/modest-dbus-api.h:
1884 * src/dbus_api/modest-dbus-callbacks.c:
1885 (on_delete_message),
1886 (modest_dbus_req_handler):
1887 Implement deletion of messages (Server side).
1889 * tests/dbus_api/test_search.c: (main):
1892 * tests/dbus_api/Makefile.am:
1893 * tests/dbus_api/test_delete_message:
1894 Add little test for the message deletion logic
1896 2007-06-03 Armin Burgmeier <armin@openismus.com>
1898 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1899 when the operation queue was not empty. projects.maemo.org bug
1902 2007-06-03 Armin Burgmeier <armin@openismus.com>
1904 * src/widgets/modest-account-view.c
1905 (on_account_default_toggled): Toggle default account column
1906 explicitely instead of waiting for gconf notification (which is
1907 currently ignored). This should fix projects.maemo.org bug NB#56910
1908 for now. It should probably be removed when gconf notifications are
1911 2007-06-03 Christian Kellner <ckellner@openismus.com>
1913 * libmodest-dbus-client/libmodest-dbus-client.c:
1914 Removed debugging spew.
1916 * src/dbus_api/modest-dbus-callbacks.c:
1917 Added debugging info.
1919 * src/modest-search.c:
1920 (modest_search_all_accounts):
1921 Use tny_account_store_get_accounts () on the account store
1922 to get all accounts which is the way to get all accounts.
1924 * tests/dbus_api/test_search.c: (main):
1925 Make it possible to supply the search term on the command line.
1927 2007-06-03 Christian Kellner <ckellner@openismus.com>
1929 * libmodest-dbus-client/libmodest-dbus-client.c:
1930 * libmodest-dbus-client/libmodest-dbus-client.h:
1931 Implement searching for mesages over raw dbus. (Client side)
1933 * src/dbus_api/Makefile.am:
1934 * src/dbus_api/modest-dbus-api.h:
1935 * src/dbus_api/modest-dbus-callbacks.c:
1936 * src/dbus_api/modest-dbus-callbacks.h:
1937 Search framework (Server side). Also implement on_idle_open_message().
1939 * src/maemo/modest-platform.c: (modest_platform_init):
1940 Prepare for raw dbus/osso rpc interaction.
1942 * src/modest-search.h:
1943 Changed minsize from unspecific guint to guint32.
1945 * src/modest-search.c:
1947 Added strange hack which magically made tnymail work.
1949 (modest_search_folder),
1950 (modest_search_account),
1951 (modest_search_all_accounts):
1952 Implement helper functions to search all accounts, specific account
1955 * tests/dbus_api/Makefile.am:
1956 * tests/dbus_api/test_open_message.c:
1957 Read url to open from commandline.
1959 * tests/dbus_api/test_search.c:
1960 Implement small test for dbus search stuff
1962 2007-06-02 Armin Burgmeier <armin@openismus.com>
1964 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1965 include account type and account title. This fixes projects.maemo.org
1968 * src/maemo/modest-account-view-window.c: Set a title for the window.
1970 2007-06-02 Armin Burgmeier <armin@openismus.com>
1972 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1973 incoming and outgoing server name based on email address and server
1974 types as long as the names have not been edited manually. This fixes
1975 projects.maemo.org bug NB#58671.
1977 2007-06-02 Armin Burgmeier <armin@openismus.com>
1979 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1980 server type cannot be changed in future to the incoming details page
1981 when creating an account. This fixes projects.maemo.org bug NB#59029.
1983 2007-06-02 Armin Burgmeier <armin@openismus.com>
1985 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1986 and assigned max width chars so that they wrap instead of being
1987 truncated. Fixes projects.maemo.org bug NB#56126.
1989 2007-06-02 Armin Burgmeier <armin@openismus.com>
1991 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1992 introductory note to the connection specific smtp servers dialog, as
1993 section 8.12 of the email UI specification requires. This fixes
1994 projects.maemo.org bug NB#59212.
1996 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1998 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1999 Check for running mail operations, and offer to cancel them, as per the UI
2000 spec. This fixes projects.maemo.org bug NB#59041 .
2001 However, I suspect that tinymail may still use the network connection
2002 in ways that we cannot detect or cancel. But it should at least adapt to
2003 changes fairly well.
2005 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2007 * src/modest-tny-account-store.c: (recreate_all_accounts),
2008 (get_cached_accounts), (get_server_accounts): Do more sensible
2009 ref-counting of the temporarily-cached outbox accounts list. This seems
2010 to fix a crash when entering the password when the password was wrong.
2012 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2014 * src/gnome/modest-main-window.c: (connect_signals):
2015 * src/modest-tny-account-store.c: (get_password),
2016 (modest_tny_account_store_alert): Added comments and clues and
2017 commented-out code about how we currently fail to deal with connection
2018 errors and wrong passwords, and how we should.
2020 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2022 * src/widgets/modest-retrieve-combo-box.c:
2023 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2024 This fixes projects.maemo.org bug NB#58472 .
2026 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2028 * src/maemo/easysetup/modest-easysetup-wizard.c:
2029 (create_page_complete_easysetup):
2030 (create_page_complete_custom): Correct the last commit,
2031 putting the correct sentences in the correct pages.
2033 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2035 * src/maemo/easysetup/modest-easysetup-wizard.c:
2036 (create_page_complete_custom): Show the second sentence of text
2037 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2040 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2042 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2043 Set the leave-on-server conf key by default. This fixes
2044 projects.maemo.org bug NB#59258 .
2046 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2048 * src/maemo/modest-account-view-window.c:
2049 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2050 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2053 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2055 * src/maemo/easysetup/modest-easysetup-wizard.c:
2056 (create_caption_new_with_asterisk):
2057 * src/maemo/modest-account-settings-dialog.c:
2058 (create_caption_new_with_asterisk):
2059 Uncomment the code to add the asterisk, because they are no longer in the
2060 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2061 (update_incoming_server_title): Add an asterisk here too.
2063 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2065 * src/maemo/modest-maemo-global-settings-dialog.c:
2066 (current_connection): Check that we are even connected before trying to
2067 get the current connection name, to prevent a warning.
2069 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2070 Change the comments because tny_maemo_conic_device_connect() is now meant to
2072 * src/modest-mail-operation.c:
2073 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2074 make sure we have a connection and fail if we can't connect.
2076 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2078 * src/maemo/modest-main-window.c:
2079 (on_account_store_connecting_finished): Do not try to get the
2080 connection ID if we are not really connected. I am surprised that
2081 this signal handler is called when we are not connected.
2083 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2085 * src/modest-error.h:
2086 * src/modest-ui-actions.c:
2087 (modest_ui_actions_get_msgs_full_error_handler):
2088 Renamed an enum, added comments, added an enum
2089 for retrieve-limit errors.
2091 * src/modest-mail-operation.c: (foreach_add_item),
2092 (internal_folder_observer_update), (update_account_thread),
2093 (modest_mail_operation_get_msgs_full):
2094 (modest_mail_operation_update_account),
2095 Added comments about how this works, and some code that should
2096 (but does not) check the retrieve-limit. See the TODO comment.
2098 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2100 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2101 Initialize help_id to fix the build. Warnings are good.
2103 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2105 * src/widgets/modest-hbox-cell-renderer.c:
2106 (modest_hbox_cell_renderer_append):
2107 * src/widgets/modest-vbox-cell-renderer.c:
2108 (modest_vbox_cell_renderer_append):
2109 Fix the last commit by doing an extra ref.
2111 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2113 * src/widgets/modest-hbox-cell-renderer.c:
2114 (modest_hbox_cell_renderer_append):
2115 * src/widgets/modest-vbox-cell-renderer.c:
2116 (modest_vbox_cell_renderer_append):
2117 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2118 to fix the build with Maemo Bora.
2119 However, there seems to be a remaining crash, probably due to reference
2122 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2124 * src/modest-tny-account.c:
2125 (modest_tny_account_new_for_local_folders):
2126 Use hildon_file_system_info_async_new() to get a better name for
2127 the memory card account, setting it as the account name.
2128 The timing seems to work, but this is probably
2129 not the best place to do this. See the TODO comment.
2130 * src/maemo/modest-main-window.c: (create_details_widget):
2131 * src/widgets/modest-folder-view.c: (text_cell_data):
2132 Use the tny account name instead of hardcoding a name.
2134 2007-05-30 Christian Kellner <ckellner@openismus.com>
2136 * src/modest-search.c: (modest_search):
2137 Correctly set part_search_func even if we have already parsed
2138 the query and thus a valid OgsTextSearcher object.
2140 2007-05-30 Christian Kellner <ckellner@openismus.com>
2143 Search and check for libogs.
2146 Incooparte the ogs build env.
2148 * src/modest-mime-part-search-stream.c:
2149 * src/modest-mime-part-search-stream.h:
2150 Removed since we do the real searching now in modest-search.c.
2152 * src/modest-search.c:
2153 * src/modest-search.h:
2154 Implement support for ogs. We use that if available and requested
2155 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2156 should now handle the corner case when the search term is spread
2157 across multiple reads.
2158 Also the logic in modest_search () was corrected to search all
2159 requested fields until one is found.
2161 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2163 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2165 * src/modest-init.h:
2166 * src/modest-init.c: Made modest_init_local_folders() take a
2167 path and be public so we can iniitialize maildir folders on
2170 * src/modest-local-folder-info.h:
2171 * src/modest-local-folder-info.c:
2172 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2174 * src/modest-tny-account.c:
2175 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2176 still means the standard local-folders path on the local volume.
2178 * src/modest-tny-account-store.c:
2179 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2180 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2181 all accounts when that happens.
2182 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2183 this too, so it shows up in the treeview.
2185 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2187 * src/maemo/modest-maemo-global-settings-dialog.c:
2188 (current_connection):
2189 * src/widgets/modest-global-settings-dialog.c:
2190 (current_connection_default):
2191 Use the enum values instead of 0, 1 and -1,
2192 to make the code clearer.
2194 * src/modest-account-mgr-helpers.c:
2195 (modest_account_mgr_get_connection_specific_smtp): Make this code
2198 * src/modest-runtime.h:
2199 * src/modest-runtime.c:
2200 Added modest_runtime_remove_all_send_queues().
2201 * src/maemo/modest-main-window.c:
2202 (on_account_store_connecting_finished): Recreate the send queues,
2203 using the appropriate transport accounts for this new connection.
2204 Some futher adapting might be needed if the old send queues are not
2205 automatically stopped at this point.
2207 * src/modest-tny-account-store.c: (get_server_accounts):
2208 Create the connection-specific transport accounts, so that they can
2209 be found later by their ID.
2211 * src/modest-tny-account.h:
2212 * src/modest-tny-account.c:
2213 Added modest_tny_account_new_from_server_account_name().
2214 modest_tny_account_new_from_server_account(): Do not create the
2215 send queues here, because they will be
2216 recreated anyway when the connection changes for the first time.
2218 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2220 * src/modest-local-folder-info.h:
2221 * src/modest-local-folder-info.c:
2222 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2223 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2224 tbox_folder): Take a modest account name instead of a server TnyAccount,
2225 so we can have per-modest-account rather than per-transport-account
2227 We must make sure that we change or recreate the exisitng send queues
2228 when the connection changes for connection-specific transport accounts.
2230 * src/modest-tny-account-store.c:
2231 (create_per_account_local_outbox_folders): Create outboxed per modest
2232 account, not per transport account.
2234 * src/modest-tny-account.h:
2235 * src/modest-tny-account.c:
2236 (modest_tny_account_get_special_folder): For outboxes, get the
2237 parent modest account name. The account is ignored for other folders.
2238 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2239 modest account name rather than a server TnyAccount.
2241 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2243 * src/modest-tny-account.c:
2244 (modest_tny_account_new_from_server_account):
2245 Call modest_runtime_get_send_queue() immediately after creating transport
2246 accounts, so that they start trying to send email from the outbox as soon
2247 as possible at startup. This is probably what we want.
2249 * src/modest-mail-operation.c: (update_account_thread):
2250 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2251 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2252 * src/modest-tny-send-queue.h:
2253 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2254 (modest_ui_actions_on_send):
2255 Added comments about how sending works, though it needs some more work.
2257 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2259 * src/modest-tny-account.c:
2260 (modest_tny_account_get_special_folder): Add TODO because this fails when
2261 the network is busy.
2262 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2263 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2264 Do not try to show this window when there is no active account. The UI
2265 specs does not tell us what to do in this case.
2267 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2271 * src/maemo/Makefile.am:
2272 * src/widgets/Makefile.am: Some dist fixes.
2274 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2276 * src/maemo/modest-connection-specific-smtp-window.c:
2277 (on_button_edit): Make the code clearer, to prevent a double free.
2279 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2281 * src/maemo/modest-account-settings-dialog.c:
2282 (modest_account_settings_dialog_set_account_name),
2283 Check the connection-specific smtp servers checkbox if there are any.
2285 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2286 (modest_connection_specific_smtp_edit_window_init):
2287 Start with a suitable port number.
2289 * src/modest-account-mgr-helpers.h:
2290 * src/modest-account-mgr-helpers.c: Added
2291 modest_account_mgr_get_has_connection_specific_smtp().
2293 (modest_account_mgr_set_connection_specific_smtp),
2294 (modest_account_mgr_remove_connection_specific_smtp),
2295 (modest_account_mgr_get_has_connection_specific_smtp),
2296 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2297 connection-specific smtp server accounts in the account, rather than
2298 the server account conf dir.
2300 This fixes bug projects.maemo.org bug NB#58263 .
2302 * src/modest-tny-account-store.c:
2303 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2304 if there are no server accounts yet, to prevent an infinite loop when there
2305 are no accounts. Document that one must be called before the other.
2307 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2309 * src/modest-account-mgr-helpers.c:
2310 (modest_account_mgr_get_default_account): Make sure that at least
2311 one account is always the default, if there are any enabled accounts.
2312 This is just a sanity check that shouldn't be necessary.
2314 * src/modest-account-mgr-priv.c:
2315 (_modest_account_mgr_account_from_key): Unescape the conf key to
2316 get the real account name. For instance, this is an issue if a space
2317 was in the account name, which can happen because the account name
2318 is generated from the display name.
2319 (_modest_account_mgr_get_account_keyname): Always escape the
2321 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2322 Unescape the conf keys to get the real account names.
2324 For instance, previously the is-default radio button in the accounts
2325 list was not checked for any accounts at first. This fixes that,
2326 and might fix several similar bugs.
2328 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2330 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2331 Removed some debug printfs.
2333 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2335 Modest on-disk outbox directories are now here, for instance:
2336 $HOME/.modest/outboxes/<account-id-1>/outbox
2337 $HOME/.modest/outboxes/<account-id-2>/outbox
2339 $HOME/.modest/local-folders/outbox
2340 so we can have a separate outbox for each account.
2341 But they are shown as one outbox in the GtkTreeView, by using a
2342 TnyMergeFolder in a ModestTnySimpleFolderStore.
2345 * src/modest-tny-simple-folder-store.c:
2346 * src/modest-tny-simple-folder-store.h:
2347 Added ModestTnySimpleFolderStore, used to contain folders from
2348 other folder stores, such as other accounts.
2350 * src/modest-tny-outbox-account.h:
2351 * src/modest-tny-outbox-account.c:
2352 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2353 used for the per-account local outbox folders.
2355 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2356 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2357 only use this (internally) now for the non-outbox local folders.
2359 * src/modest-init.h:
2360 * src/modest-init.c: Added modest_init_one_local_folder(), for
2361 setting up the directory structure for each local folder.
2363 * src/modest-local-folder-info.c:
2364 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2365 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2367 * src/modest-local-folder-info.h:
2368 * src/modest-tny-account-store.c: (on_account_removed),
2369 (on_account_changed), (create_per_account_local_outbox_folders),
2370 (get_server_accounts), (modest_tny_account_store_get_accounts),
2371 (modest_tny_account_store_get_tny_account_by_account),
2372 (modest_tny_folder_store_is_virtual_local_folders):
2374 * src/modest-tny-account.h:
2375 * src/modest-tny-account.c:
2376 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2377 to create an on-disk per-account local outbox folder for each
2379 (create_per_account_local_outbox_folders): Create a local outbox folder
2380 for each transport account.
2381 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2382 for all local folders.
2384 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2385 instead of using g_object_get/set() directly. It is clearer.
2387 (modest_tny_folder_store_get_message_count),
2388 (modest_tny_folder_store_get_local_size
2389 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2390 because we now use these with non-acount folder stores.
2392 (modest_tny_account_get_special_folder),
2393 (modest_tny_account_new_from_server_account),
2394 (modest_tny_account_new_from_account):
2395 (recurse_folders): Adjust to the new outbox system.
2397 * src/modest-tny-folder.h:
2398 * src/modest-tny-folder.c:
2399 (modest_tny_folder_is_local_folder),
2400 (modest_tny_folder_get_local_folder_type),
2401 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2403 * src/widgets/modest-main-window.h:
2404 * src/maemo/modest-main-window.c: (create_details_widget),
2405 (modest_main_window_set_contents_style): Show details for any folder store,
2408 (modest_tny_folder_get_rules):
2409 Remove the const. C does not support constness enough for this.
2411 * src/modest-ui-actions.c:
2412 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2413 make all outboxes appear as one, in the usual local-folders tree node.
2415 (set_active_account_from_tny_account),
2416 (modest_ui_actions_on_folder_selection_changed):
2417 * src/widgets/modest-folder-view.c: (text_cell_data),
2418 (icon_cell_data), (filter_row),
2419 (add_account_folders_to_merged_folder),
2420 (add_account_folders_to_simple_folder_store), (),
2421 (get_cmp_rows_type_pos), (cmp_rows),
2422 (modest_folder_view_set_account_id_of_visible_server_account):
2423 Adjust to the new outbox system, using generic folder stores and folders
2424 in the GtkTreeModel.
2426 2007-05-23 Christian Kellner <ckellner@openismus.com>
2428 * src/modest-mail-operation.c:
2429 (modest_mail_operation_update_account):
2430 Use info->max_size instead of unintialized local var [small
2431 build fix]. (Added TODO to review that change since I don't
2434 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2436 * libmodest-dbus-client/libmodest-dbus-client.c:
2437 (libmodest_dbus_client_compose_mail): function added
2438 * src/dbus_api/modest-dbus-api.h:
2439 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2440 (on_compose_mail): Implementation of the SendAsMail functionality
2442 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2444 * src/modest-account-mgr.c:
2445 (modest_account_mgr_add_server_account): Set the secure-connection
2446 conf key for transport accounts as well as store accounts. I don't know
2447 why the if was there. For instance, this makes sure that we use SSL
2448 for the gmail preset from the easysetup wizard.
2450 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2452 * src/gnome/modest-main-window.c:
2453 (on_account_store_connecting_finished), (connect_signals):
2454 * src/maemo/modest-main-window.c:
2455 (on_account_store_connecting_finished), (connect_signals),
2456 (modest_main_window_new):
2457 Handle TnyAccountStore::connecting-finished instead of
2458 TnyDevice::connection-changed, because we cannot actually perform
2459 operations on accounts until TnyAccountStore has itself responded to
2460 the TnyDevice::connection-changed signal. This prevents a GError from
2462 Do not try to update at startup, because we (at least on scratchbox)
2463 already do an update at startup when the device goes online.
2464 This prevents a GError from tinymail.
2465 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2466 Added TODO about stopping simultaneous operations.
2468 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2470 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2471 * src/modest-mail-operation-queue.c:
2472 (modest_mail_operation_queue_remove):
2473 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2474 about where they happened.
2476 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2478 * src/modest-ui-actions.c:
2479 (modest_ui_actions_on_password_requested): Make sure that the remember
2480 output parameter is always TRUE.
2482 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2484 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2485 Show a OK/Cancel dialog if the error is a question, though we still do not
2486 know anything more about what we are asking the user.
2487 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2488 Fix an uninitialized variable (helper). This is a logic error, however.
2490 2007-05-21 Christian Kellner <ckellner@openismus.com>
2492 * src/modest-search.h:
2493 Correct bit shifting in the ModestSearchFlags enum.
2495 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2497 * src/modest-tny-account.c:
2498 (modest_tny_account_new_from_server_account): Do not use the lsub and
2499 check-all hard-coded IMAP options when using POP.
2501 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2503 * src/modest-tny-account.c:
2504 (modest_tny_account_new_from_server_account):
2505 Use NULL for the secure-auth method for POP when Password auth has been
2506 specified by the user, as we already do for IMAP. "auth=Login" causes
2507 an error from camel or the server.
2509 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2511 * src/maemo/modest-account-settings-dialog.c:
2512 (create_page_account_details),
2513 (modest_account_settings_dialog_set_account_name):
2514 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2515 for the leave-on-server checkbox, rathr than just the checkbox, when
2516 the protocol is not POP.
2518 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2520 * src/widgets/modest-account-view.c:
2521 * src/widgets/modest-account-view.h:
2522 Added modest_account_view_select_account() which will be useful later
2523 to asynchronously re-select the edited account.
2525 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2527 * src/maemo/modest-account-settings-dialog.c:
2528 (modest_account_settings_dialog_set_account_name):
2529 Automatically choose the port numbers based on the secure authentication
2530 methods, if they have not been chosen before.
2531 This fixes projects.maemo.org bug NB#56273 .
2533 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2535 * src/maemo/modest-main-window-ui.h:
2536 * src/modest-ui-actions.c:
2537 * src/modest-ui-actions.h:
2538 Connect the Tools/SMTP Servers menu item to
2539 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2540 SMTP servers dialog, as in the UI specification and saves changes when it
2541 is closed. This fixed projects.maemo.org bug NB#56305 .
2543 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2545 * src/maemo/modest-connection-specific-smtp-window.c:
2546 (modest_connection_specific_smtp_window_init):
2547 Use gtk_window_set_default_size() to make this window big enough, so
2548 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2550 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2552 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2553 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2554 (modest_connection_specific_smtp_edit_window_init),
2555 Do not try to connect to a combobox signal before the combobox exists.
2556 This fixes the cras in projects.maemo.org bug NB#56288 .
2557 (modest_connection_specific_smtp_edit_window_get_settings):
2558 Remove the server_account_name parameter which was being checked for NULL
2559 though it was not used.
2561 * src/maemo/modest-connection-specific-smtp-window.c:
2562 (modest_connection_specific_smtp_window_fill_with_connections),
2563 (on_button_edit), (modest_connection_specific_smtp_window_init):
2564 Correct the number of treemodel columns to prevent a warning.
2565 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2566 libconic does not work.
2568 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2570 * src/modest-tny-account.c:
2571 (modest_tny_account_new_from_server_account):
2572 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2573 SMTP when "None" was chosen by the user. However, with my SMTP server that
2574 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2577 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2579 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2580 to explain the memory management issue with the ID in the ModestPair.
2582 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2583 (add_sending_page), (modest_account_assistant_finalize):
2584 * src/gnome/modest-gnome-global-settings-dialog.c:
2585 (create_updating_page), (create_composing_page):
2586 * src/gnome/modest-msg-edit-window.c: (get_transports),
2587 (init_window), (modest_msg_edit_window_finalize),
2588 (modest_msg_edit_window_get_msg_data):
2589 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2590 * src/gnome/modest-transport-widget.c:
2591 (modest_transport_widget_finalize), (smtp_configuration):
2592 * src/maemo/modest-maemo-global-settings-dialog.c:
2593 (create_updating_page), (create_composing_page):
2594 * src/maemo/modest-msg-edit-window.c: (get_transports),
2595 (init_window), (modest_msg_edit_window_finalize),
2596 (modest_msg_edit_window_get_msg_data),
2597 (modest_msg_edit_window_free_msg_data):
2598 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2599 (modest_store_widget_finalize):
2600 * src/maemo/modest-transport-widget.c:
2601 (modest_transport_widget_finalize), (smtp_configuration):
2602 * src/modest-main.c: (send_mail):
2603 * src/widgets/modest-combo-box.h:
2604 * src/widgets/modest-global-settings-dialog-priv.h:
2605 * src/widgets/modest-global-settings-dialog.c:
2606 (modest_global_settings_dialog_finalize):
2607 * src/widgets/modest-msg-edit-window.h:
2608 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2609 as long as the combo box, to prevent use of freed memory for the ID.
2611 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2613 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2614 get_accounts(), to make this clearer. Do not check for the enabled gconf
2615 key, because we do not use this for server accounts (at least, not yet).
2616 This allows us to send email again.
2618 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2620 * src/maemo/modest-platform.c:
2621 (on_modest_conf_update_interval_changed), (modest_platform_init):
2622 Only respond to this particular key change. All these strcmp()s cannot be
2625 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2627 * src/maemo/modest-maemo-global-settings-dialog.c:
2628 (current_connection): Prevent a crash in scratchbox when
2629 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2630 * src/maemo/modest-platform.c:
2631 (on_modest_conf_update_interval_changed), (modest_platform_init):
2632 Get the update interval from gconf and reset it when the gconf key changes.
2634 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2636 * src/modest-protocol-info.c:
2637 * src/modest-protocol-info.h: Adde enum-specific get functions,
2638 instead of using a ModestProtocolType enum parameter.
2640 * src/gnome/modest-account-assistant.c:
2641 * src/gnome/modest-store-widget.c:
2642 * src/gnome/modest-store-widget.h:
2643 * src/gnome/modest-transport-widget.c:
2644 * src/gnome/modest-transport-widget.h:
2645 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2646 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2647 * src/maemo/easysetup/modest-easysetup-wizard.c:
2648 * src/maemo/modest-account-settings-dialog.c:
2649 * src/maemo/modest-account-settings-dialog.h:
2650 * src/maemo/modest-store-widget.c:
2651 * src/maemo/modest-store-widget.h:
2652 * src/maemo/modest-transport-widget.c:
2653 * src/maemo/modest-transport-widget.h:
2654 * src/modest-account-mgr-helpers.c:
2655 * src/modest-account-mgr-helpers.h:
2656 * src/modest-account-mgr.c:
2657 * src/modest-account-mgr.h:
2658 * src/modest-tny-account.c:
2659 * src/modest-tny-folder.c:
2660 * src/widgets/modest-account-view.c:
2661 * src/widgets/modest-retrieve-combo-box.c:
2662 * src/widgets/modest-retrieve-combo-box.h:
2663 * src/widgets/modest-secureauth-combo-box.c:
2664 * src/widgets/modest-serversecurity-combo-box.c:
2665 * src/widgets/modest-serversecurity-combo-box.h:
2666 * tests/check_account-mgr.c:
2667 Use the specific functions, and use the re-renamed enum values for GNOME too.
2669 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2671 * src/modest-pair.h:
2672 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2673 so we can get the second based on the first.
2675 * src/maemo/modest-account-settings-dialog.h:
2676 * src/maemo/modest-account-settings-dialog.c:
2677 Added get_supported_secure_authentication_methods(), though it is mostly
2678 commented-out for now until the necessary API is committed to tinymail.
2679 (modest_account_settings_dialog_set_account_name),
2680 (save_configuration): Request the supported authentication methods from the
2681 server, so we can choose a working method.
2683 * src/modest-tny-account-store.h:
2684 * src/modest-tny-account-store.c:
2685 (modest_tny_account_store_get_session): Rename from
2686 tny_account_store_get_session().
2688 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2690 * src/modest-protocol-info.h: Split the ModestProtocol enum
2691 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2692 There was no need to have these unrelated values in one enum.
2694 * src/: many files: Adapted to changed enum. This makes the code a bit
2695 clearer, and the compiler could catch some errors.
2697 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2699 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2700 Show the detailed internal camel error message when an error happens
2701 during the configuration, so that our testers can give us more clues.
2702 For instance, in projects.maemo.org bug NB#56910 .
2704 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2706 * src/modest-tny-account.c:
2707 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2708 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2710 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2712 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2713 * src/maemo/modest-account-settings-dialog.c:
2714 (modest_account_settings_dialog_set_account_name),
2715 (save_configuration): For the incoming secure authentication checkbox,
2716 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2717 the UI specification. PLAIN does not seem to be supported for most IMAP
2718 servers anyway, and I am not sure what it would mean.
2719 However, we probably need to discover which of the secure-authentication
2720 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2721 * src/modest-account-mgr-helpers.c:
2722 (modest_account_mgr_get_server_account_data):
2724 * src/modest-tny-account.c:
2725 (modest_tny_account_new_from_server_account):
2726 Use tny_account_set_mech() to set secure-authentication methods,
2727 with some special-casing for IMAP, based on my observations of how
2730 * src/modest-account-mgr-helpers.h:
2731 * src/modest-account-mgr.c:
2732 * src/modest-defs.h: Comment that the URI is only used for local folders.
2734 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2736 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2737 parameter const, just to be neat.
2738 * src/modest-text-utils.c: (modest_text_utils_inline):
2739 End g_strconcat() with NULL, as its documentation says. This is almost
2740 certainly the cause of my crash at startup on the device. Interestingly,
2741 valgrind doesn't tell us about these errors.
2743 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2745 * scripts/build-packages: Added more precise comments about how to use
2746 this script, though I still get this error:
2747 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2748 error building tinymail
2750 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2752 * src/maemo/modest-main-window.c: (on_account_update):
2753 Very slight cleanup, hoping to make it simpler to discover what causes
2754 a crash here sometimes.
2756 * src/modest-tny-account.c:
2757 (modest_tny_account_new_from_server_account): Set the port. Added
2758 comments about the options and a TODO comment because I need to find out
2759 how to specify the secure authentication method.
2761 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2763 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2764 changed CFlags paths form modest to libmodest
2766 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2768 * src/modest-account-mgr-helpers.c:
2769 (modest_account_mgr_get_server_account_data),
2770 (modest_account_mgr_free_server_account_data):
2771 * src/modest-account-mgr-helpers.h:
2772 * src/modest-account-mgr.c:
2773 (modest_account_mgr_add_server_account):
2774 * src/modest-defs.h:
2775 * src/modest-tny-account.c:
2776 (modest_tny_account_new_from_server_account):
2777 Determine the options for tny_camel_account_add_option() here,
2778 based on the settings, rather than storing them directly in gconf.
2780 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2782 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2783 Show a more friendly error dialog now that we expect (from the tinymail
2784 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2786 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2788 * src/maemo/modest-main-window.c: (on_account_update): Check that
2789 account_name is not NULL, to prevent a crash at startup that I am
2790 seeing on the N800. I do wonder why it is NULL.
2792 * src/maemo/easysetup/modest-easysetup-wizard.c:
2793 (create_page_user_details):
2794 * src/maemo/modest-account-settings-dialog.c:
2795 (create_page_user_details), (create_page_outgoing):
2796 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2797 (modest_connection_specific_smtp_edit_window_init):
2798 * src/modest-ui-actions.c:
2799 (modest_ui_actions_on_password_requested):
2800 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2801 might do something useful with the on-screen keyboard.
2803 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2805 * src/maemo/modest-main-window.c: (on_account_update):
2806 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2807 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2809 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2811 * src/modest-tny-account-store.c: (on_account_changed):
2812 Correct the signature of this signal handler.
2814 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2816 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2817 Show a HildonNote instead of a GtkDialog for Maemo.
2819 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2821 * src/widgets/modest-account-view.h:
2822 * src/widgets/modest-account-view.c: (on_account_changed),
2823 (on_account_removed). Added a boolean flag, set/unset by
2824 modest_account_view_block_conf_updates(),
2825 modest_account_view_unblock_conf_updates() to prevent unnecessary
2826 updates, but this is not very useful because the gconf notifications are
2827 so delays (maybe only on Maemo Bora).
2828 So auto-updating is turned off, and these functions do an explicit
2829 update when necessary.
2830 However, something else is still doing too much work when adding/removing
2831 accounts, probably in another part of the application.
2833 * src/maemo/modest-account-view-window.c:
2834 (on_delete_button_clicked), (on_edit_button_clicked),
2835 (on_new_button_clicked): Use the new functions.
2837 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2839 * src/modest-account-mgr-helpers.c:
2840 (modest_account_mgr_set_first_account_as_default):
2841 Sort the list of names alphabetically-by-title, so we choose the first one
2843 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2844 alphabetically by the title.
2846 This fixes projects.maemo.org bug NB#56418 .
2848 * src/modest-account-mgr-priv.c:
2849 (_modest_account_mgr_account_from_key):
2850 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2851 avoid a valgrind error, and possible random behaviour.
2853 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2855 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2856 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2857 tinymail documentation to say that this can be expected.
2858 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2859 pretty, and should not happen, but I would prefer to know when it does.
2861 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2863 * configure.ac: When using the older hildon version, probably on Bora,
2864 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2866 * src/widgets/modest-attachment-view.c:
2867 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2870 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2872 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2873 Implemented the prototype. Can be tested with
2874 tests/dbus_api/test_open_message:
2876 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2878 * src/modest-tny-account-store.c:
2879 (modest_tny_account_store_instance_init), (get_password):
2880 * src/modest-ui-actions.c:
2881 (modest_ui_actions_on_password_requested):
2882 Do not store the password in gconf, because this function is called
2883 for non-remembered passwords. Actually use the cached (in the hash map)
2884 password instead of releasing it.
2885 The password will now not be remembered if it is asked via the protected
2886 password dialog, as per the UI spec.
2888 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2890 * src/modest-defs.h:
2891 * src/modest-account-mgr-helpers.h:
2892 * src/modest-account-mgr-helpers.c:
2893 Added modest_server_account_get_username_has_succeeded(),
2894 modest_server_account_set_username_has_succeeded().
2895 (modest_server_account_set_username),
2896 Reset the has-succeeded flag if the username changes.
2898 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2899 * src/maemo/modest-connection-specific-smtp-window.c:
2900 (modest_connection_specific_smtp_window_save_server_accounts):
2901 Use modest_server_account_set_username() instead of using
2902 modest_conf_set_string() directly, so that the has-succeeded flag is always
2905 * src/modest-ui-actions.c:
2906 (modest_ui_actions_on_password_requested): Dim the username entry if
2907 the username has ever worked, as per the UI spec.
2909 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2911 * src/modest-tny-account-store.c: (get_password):
2912 * src/modest-ui-actions.c:
2913 (modest_ui_actions_on_password_requested):
2914 Allow the username to be changed too, though there is more work to
2915 be done on exactly how this behaves.
2917 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2919 * src/modest-account-mgr-helpers.h:
2920 * src/modest-account-mgr-helpers.c:
2921 Added modest_account_mgr_get_display_name(),
2922 modest_server_account_get_username(),
2923 modest_server_account_set_username(),
2924 modest_server_account_set_password(),
2925 modest_server_account_get_hostname() functions so we do not need to
2926 use the conf API directly.
2928 * src/maemo/modest-main-window.c: (connect_signals):
2929 Actually connect ot the ModestAccountStore::request-password signal,
2930 so that we show the dialog when the password is requested by Tinymail,
2931 for isntance if it is empty.
2933 * src/modest-marshal.list:
2934 * src/modest-tny-account-store.c:
2935 (modest_tny_account_store_class_init), (get_password),
2936 (modest_tny_account_store_alert):
2937 * src/modest-tny-account-store.h:
2938 * src/modest-ui-actions.h:
2939 * src/modest-ui-actions.c:
2940 (modest_ui_actions_on_password_requested):
2941 Change the signal parameters, so it is obvious that we are providing
2942 the non human-readable server name, and receiving both the username
2943 and password, though changing of the username is not yet implemented.
2944 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2945 for the GNOME version.
2947 This should fix the projects.maemo.org bug NB#56209, though it does not
2948 work on Bora, because the gconf_client_get() for the password fails
2949 immediately after we save it with gconf_client_set().
2951 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2954 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2955 caused an undefined symbol error:
2956 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2958 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2960 * src/modest-tny-account-store.c:
2961 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2962 using a GError instead of a string message, so we can translate it in
2965 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2967 * src/maemo/modest-address-book.c:
2968 (modest_address_book_check_names):
2969 * src/maemo/modest-msg-view-window.c:
2970 (modest_msg_view_window_clipboard_owner_change):
2971 * src/modest-init.c: (modest_init_init_ui):
2972 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2973 (update_folders_cb), (modest_mail_operation_update_account):
2974 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2975 (modest_ui_actions_on_msg_attachment_clicked),
2976 (modest_ui_actions_on_msg_recpt_activated):
2977 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2978 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2979 (modest_msg_view_search_next):
2980 * src/widgets/modest-recpt-editor.c:
2981 (modest_recpt_editor_on_button_release_event),
2982 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2983 g_message(). At this point we should only be seeing interesting errors on
2984 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2986 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2988 (modest_wizard_dialog_force_title_update):
2989 * src/maemo/easysetup/modest-wizard-dialog.h:
2990 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2991 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2992 can update the title when appropriate. Otherwise the title is wrong if the
2993 pages are added after adding the notebook to the dialog.
2994 This must be a problem in HildonWizardDialog too.
2995 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2997 * src/maemo/easysetup/modest-easysetup-wizard.c:
2998 (create_subsequent_customsetup_pages),
2999 (create_subsequent_easysetup_pages):
3000 Call modest_wizard_dialog_force_title_update() so that the title is
3001 correct even with GTK+ < 2.10.
3002 This fixes projects.maemo.org bug NB#56145 .
3004 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3006 * src/maemo/modest-platform.c:
3007 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3008 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3011 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3013 * src/widgets/modest-window.h:
3014 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3015 and modest_window_save_state(), which invokes it.
3017 * src/widgets/modest-window-mgr.h:
3018 * src/widgets/modest-window-mgr.c:
3019 Added modest_window_mgr_save_state_for_all_windows(), which calls
3020 the save_state vfunc on all registered windows, if implemented.
3022 * src/gnome/modest-msg-edit-window.c:
3023 * src/gnome/modest-msg-view-window.c:
3024 * src/maemo/modest-msg-edit-window.c:
3025 * src/maemo/modest-msg-view-window.c:
3026 * src/maemo/modest-main-window.c:
3027 Specify the existing save_settings functions as implementations of
3028 ModestWindow::save_state_func().
3030 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3031 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3032 enabling hibernation, for instance.
3034 We may need to do the same thing for restoring settings.
3037 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3039 * src/widgets/modest-window-mgr.c:
3040 * src/widgets/modest-window-mgr.h:
3041 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3042 modest_window_mgr_get_hibernation_is_prevented().
3044 * src/maemo/modest-main-window.c:
3045 (on_hildon_program_is_topmost_notify): Prevent hibernation
3046 (possible when the application goes to the background in the WM),
3047 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3049 * src/maemo/easysetup/modest-easysetup-wizard.c:
3050 (modest_easysetup_wizard_dialog_init):
3051 * src/maemo/modest-account-settings-dialog.c:
3052 (modest_account_settings_dialog_init):
3053 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3054 (modest_connection_specific_smtp_edit_window_init):
3055 * src/maemo/modest-connection-specific-smtp-window.c:
3056 (modest_connection_specific_smtp_window_init):
3057 * src/maemo/modest-signature-editor-dialog.c:
3058 (modest_signature_editor_dialog_init):
3059 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3060 prevent hibernation while any of these account settings dialogs are open.
3062 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3064 * src/maemo/Makefile.am:
3065 * src/maemo/modest-osso-state-saving.c:
3066 * src/maemo/modest-osso-state-saving.h: Added
3067 modest_osso_load_state() and modest_osso_save_state() though they do
3068 nothing now. They should iterate through all the open windows and load/save
3070 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3071 save state when closing.
3073 * src/maemo/modest-main-window.c:
3074 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3075 Add a notification handler for the HildonProgram::is-topmost property,
3076 so we can allow hibernation when the application goes into the background.
3077 But we still need to detect when the accounts setup windows are open so
3078 we can stop hibernation when they are open.
3079 To do this, I also added the main window the HildonProgram. This might have
3080 other side-effects/benefits, and should maybe be done for other windows.
3082 * src/maemo/modest-osso-autosave-callbacks.h:
3083 * src/maemo/modest-osso-autosave-callbacks.c:
3084 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3085 though it does not do anything yet, and we might never need this to do
3086 anything. For instance, we already save drafts.
3088 * src/maemo/modest-platform.c: (modest_platform_init):
3089 Specify the libosso auto-save callback.
3091 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3093 * src/maemo/modest-platform.c:
3094 (modest_platform_set_update_interval):
3095 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3096 aparently stays valid between application instances, so we can use this
3097 to remove and reset it later. According to a maemo-developers email from
3100 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3102 * configure.ac: Depend on libalarm for Maemo.
3104 * src/dbus_api/modest-dbus-api.h:
3105 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3106 (on_send_receive), (modest_dbus_req_handler):
3107 Handle a SEND_RECEIVE D-Bus method.
3109 * libmodest-dbus-client/libmodest-dbus-client.c:
3110 (libmodest_dbus_client_send_and_receive):
3111 * libmodest-dbus-client/libmodest-dbus-client.h:
3112 Add C convenience functions for calling the new D-Bus method.
3114 * src/modest-platform.h:
3115 * src/gnome/modest-platform.c:
3116 * src/maemo/modest-platform.c:
3117 Added modest_platform_set_update_interval(), which uses the
3118 alarmd API on Maemo.
3119 (modest_platform_init),
3120 Call modest_platform_set_update_interval(), using a hard-coded
3121 interval for now (until the global settings dialog is implemented),
3122 though I am not sure that this makes sense yet.
3124 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3126 * src/dbus_api/modest-dbus-callbacks.c:
3127 (modest_osso_cb_hw_state_handler):
3128 * src/dbus_api/modest-dbus-callbacks.h:
3129 * src/maemo/modest-platform.c: (modest_platform_init):
3130 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3131 in case this has some effect on the ability for Maemo to ping the
3134 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3136 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3137 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3138 warning. It is probably a logic error, but I need to fix the build.
3140 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3142 * src/modest-account-mgr.h:
3143 * src/modest-account-mgr.c:
3144 (modest_account_mgr_account_names): Add a gboolean enabled_only
3145 parameter, so we can get lists of onlt the enabled accounts.
3147 (modest_account_mgr_add_account),,
3148 (modest_account_mgr_account_with_display_name_exists):
3149 * src/maemo/modest-msg-edit-window.c: (get_transports):
3150 * src/modest-account-mgr-helpers.c:
3151 (modest_account_mgr_set_first_account_as_default):
3152 * src/modest-init.c: (init_default_account_maybe):
3153 * src/modest-tny-account-store.c: (get_accounts):
3154 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3155 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3156 * tests/check_account-mgr.c: (START_TEST):
3157 Provide the extra parameter, as appropriate.
3159 * src/widgets/modest-account-view.c: (update_account_view):
3160 Do not show disabled accounts (meaning that there is no way to
3161 enable/disable accounts in the UI (the feature is not in our UI
3162 specification), so we can use this internally only to mark unfinished
3163 or temporary account data.
3165 * src/maemo/easysetup/modest-easysetup-wizard.c:
3166 (create_account): Add boolean enable parameter, so we can specify FALSE
3167 to create the temporary account.
3168 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3169 (on_before_next): When finishing, when there is a temporary account, just
3171 Also, use a timeout to delay the showing of the dialog until gconf is likely
3172 to return correct information, due to a maemo gconf bug that is fixed in
3173 osso 1.1, but not yet in Bora.
3174 However, the dialog stays on screen after it is destroyed.
3176 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3177 for invalid data when cancelling. Use a hildon note instead of a dialog
3178 to complain about invalid data. Do not show the account-saved note if the
3179 account is disabled (a temporary account that will not really be saved for use
3182 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3184 * src/modest-account-mgr-helpers.h:
3185 * src/modest-account-mgr-helpers.c:
3186 Added modest_account_mgr_unset_default_account(),
3187 Added modest_account_mgr_set_first_account_as_default().
3189 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3190 If it was the default account, unset the default account name.
3192 * src/maemo/modest-account-view-window.c:
3193 (on_delete_button_clicked): If it was the default account,
3194 set the first remaining account as the default instead.
3196 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3197 a NULL account or a NULL default account, to prevent a crash. This should
3198 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3201 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3203 * src/widgets/modest-recpt-editor.c:
3204 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3205 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3206 TODO comment for this. This fixes the build.
3208 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3209 be the best place for it. This will in future update all auto-update accounts,
3210 rather than just the current/default account, when that gconf key exists.
3211 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3212 if there are no accounts, before calling do_send_receive().
3213 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3215 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3216 * src/maemo/modest-main-window-ui.h:
3217 * src/maemo/modest-main-window.c: (on_connection_changed),
3218 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3219 directly, becaue the signal handler does more.
3221 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3223 * src/modest-account-mgr-helpers.c:
3224 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3225 for the case that the account does not exist.
3227 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3228 (equivalent to the modest account name) rather than the tinymail account name
3229 (equivalent to the modest account title - human readable) to get the account data.
3230 Check for null account data to prevent the crash, and add a TODO comment saying that
3231 this needs fixing because it is using the server account name instead of the account name.
3233 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3235 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3236 * src/maemo/modest-account-settings-dialog.c: (show_error),
3238 Use hildon_note_new_information() for informative and error messages,
3239 which seems to be expected for Maemo applications (no documentation that I know of
3240 says this). I am surprised that there is no distinction between info and error
3243 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3245 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3246 it is easy to find where this is used.
3248 * src/maemo/easysetup/modest-easysetup-wizard.c:
3249 (create_page_welcome), (create_page_account_details),
3250 (create_page_user_details), (create_page_complete_easysetup),
3251 (create_page_custom_incoming), (create_page_custom_outgoing),
3252 (create_page_complete_custom):
3253 * src/maemo/modest-account-settings-dialog.c:
3254 (create_page_account_details), (create_page_user_details),
3255 (create_page_incoming), (create_page_outgoing):
3256 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3257 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3258 (modest_connection_specific_smtp_edit_window_init):
3259 * src/maemo/modest-connection-specific-smtp-window.c:
3260 (modest_connection_specific_smtp_window_init):
3261 * src/maemo/modest-signature-editor-dialog.c:
3262 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3263 and scrolling policy as per the Email Application Layout Guide, if I have
3266 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3268 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3269 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3270 which were empty, because these vfuncs have been removed from TnyAccountStore.
3271 This fixes the build.
3273 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3275 * src/maemo/modest-main-window.c:
3276 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3277 showing/hiding it. Added TODO because it probably should not be NULL.
3278 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3279 because unnecessary g_warnings() make degugging difficult.
3281 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3283 * src/maemo/modest-msg-edit-window.c:
3284 (modest_msg_edit_window_select_color),
3285 (modest_msg_edit_window_select_background_color): 2 const corrections and
3286 moving 2 #endifs before closing brackets, to fix the build.
3288 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3290 * src/maemo/easysetup/modest-easysetup-wizard.h:
3291 * src/maemo/easysetup/modest-easysetup-wizard.c:
3292 (modest_easysetup_wizard_dialog_finalize),
3293 (on_button_edit_advanced_settings), (create_page_complete_custom),
3294 (on_response), (create_account):
3295 Implement the Advanced Settings edit button, by saving the account information,
3296 for the Advanded Settings dialog to use directly from gconf, and removing it
3297 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3298 Bug #5533 in the projects.maemo.org bugzilla.
3300 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3302 * src/maemo/modest-msg-view-window.c:
3303 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3304 when opening a message window.
3306 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3308 * src/maemo/easysetup/modest-easysetup-wizard.c:
3309 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3312 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3313 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3314 gconf settings. I probably added more checks than necessary, but that is safer.
3316 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3317 variable to fix the build, but this seems to be used when it is still NULL.
3319 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3321 * src/modest-platform.h:
3322 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3323 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3324 * src/modest-main.c: Implement this function so we can avoid using
3325 maemo-specific API from cross-platform code.
3327 * src/modest-tny-account-store.c:
3328 (get_smtp_specific_transport_account_for_open_connection):
3329 * src/modest-ui-actions.c: (check_for_connection),
3330 (modest_ui_actions_on_item_not_found):
3331 Use modest_platform_connect_and_wait() and put #idefs around other
3332 maemo-specific code, because only maemo currently has a way to
3333 identify connection names.
3335 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3337 * src/modest-tny-account-store.h:
3338 * src/modest-tny-account-store.c:
3339 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3340 the connection-specific SMTP server settings in the configuration.
3342 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3344 * src/maemo/modest-main-window.c: (on_connection_changed),
3346 * src/modest-main.c: (main), (start_ui), (send_mail):
3347 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3348 that is what is intended.
3350 * src/modest-ui-actions.c: (action_send), (action_receive),
3351 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3352 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3353 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3354 SMTP server is used when it is specified.
3356 (modest_ui_actions_on_send_receive):
3357 Check that a connection is open before proceeding.
3358 Receive and then send, instead of vice-versa, as per the specification.
3360 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3362 * src/modest-mail-operation.c:
3363 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3364 though I guess it should be something other than NULL.
3366 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3368 * src/maemo/easysetup/modest-easysetup-wizard.c:
3369 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3370 combo twice, to avoid an g_warning and to make it visible again.
3371 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3372 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3373 (already intended) dereference when detaching, because we then recreate the menu.
3374 But I am not sure why the warning was happening, and it is possible that this is a memory
3377 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3379 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3380 and uri_parse_mailto() utility functions.
3381 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3383 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3385 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3387 * src/dbus_api/modest-dbus-api.h:
3388 * src/dbus_api/modest-dbus-callbacks.c:
3389 Use an idle callback to execute the modest code in the application's own thread.
3390 Remove the helloworld example method.
3391 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3392 parsed, and the open-message method is not implemented because this is not yet implemented in
3394 * libmodest-dbus-client/libmodest-dbus-client.c:
3395 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3396 (libmodest_dbus_client_open_message):
3397 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3399 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3400 body without crashing.
3402 * tests/dbus_api/Makefile.am:
3403 * tests/dbus_api/test_mail_to.c:
3404 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3406 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3408 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3409 Added file to fix the build. Sorry.
3411 * src/dbus_api/Makefile.am:
3412 * src/dbus_api/modest-dbus-api.h:
3413 * src/dbus_api/modest-dbus-callbacks.h:
3414 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3415 (modest_dbus_req_handler):
3416 Put constants in a separate header so it can be reused by the
3417 client library, without duplication
3419 * libmodest-dbus-client/Makefile.am:
3420 * libmodest-dbus-client/libmodest-dbus-client.c:
3421 (libmodest_dbus_client_call_helloworld),
3422 (libmodfest_dbus_client_send_mail),
3423 (libmodfest_dbus_client_mailto),
3424 (libmodfest_dbus_client_open_message):
3425 * libmodest-dbus-client/libmodest-dbus-client.h:
3426 (Partly) Implement a send_mail D-Bus method.
3428 * tests/dbus_api/Makefile.am:
3429 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3430 the send_email D-Bus method.
3432 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3436 * libmodest-dbus-client/Makefile.am:
3437 * libmodest-dbus-client/libmodest-dbus-client.c:
3438 * libmodest-dbus-client/libmodest-dbus-client.h:
3439 * tests/dbus_api/Makefile.am:
3440 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3441 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3443 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3445 * src/maemo/easysetup/modest-easysetup-wizard.c:
3446 (create_page_account_details):
3447 * src/maemo/modest-account-settings-dialog.c:
3448 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3449 widgets, because this might not be the default in future versions of the Maemo GTK+.
3450 However, I can not not get capitalization to work even in a simple test case.
3452 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3454 * src/maemo/easysetup/modest-easysetup-wizard.c:
3455 (create_page_custom_incoming), (create_page_custom_outgoing):
3456 * src/maemo/modest-account-settings-dialog.c:
3457 (create_page_account_details), (create_page_incoming),
3458 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3459 instead of using gtk_check_button_with_label(), so they are aligned like the other
3460 widgets, as per the UI spec.
3462 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3464 * src/maemo/easysetup/modest-easysetup-wizard.c:
3465 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3466 * src/widgets/modest-validating-entry.c:
3467 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3468 Modest prefix instead of an EasySetup prefix.
3470 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3472 * src/widgets/modest-validating-entry.h:
3473 * src/widgets/modest-validating-entry.c: (on_insert_text),
3474 Added easysetup_validating_entry_set_max_func(), used to set a callback
3475 to call when the max number of characters is reached. GtkEntry has a max-length
3476 already but is silent about it.
3478 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3479 (create_page_account_details), (create_page_user_details),
3481 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3482 (create_page_account_details), (create_page_user_details),
3483 (create_page_outgoing):
3484 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3485 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3486 the UI spec, when the user tries to enter more than the max number of characters.
3488 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3490 * src/maemo/easysetup/modest-easysetup-wizard.c:
3491 (create_page_user_details), (create_page_custom_incoming),
3492 (create_page_custom_outgoing):
3493 * src/maemo/modest-account-settings-dialog.c:
3494 (create_page_user_details), (create_page_incoming),
3495 (create_page_outgoing):
3496 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3497 (modest_connection_specific_smtp_edit_window_init):
3498 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3499 not appropriate. Bad Maemo-specific defaults!.
3501 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3503 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3504 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3505 (modest_signature_editor_dialog_set_settings):
3506 Disable the label and textview when the checkbox is disabled, and use the
3507 specified (UI spec) default signature text.
3509 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3511 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3512 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3514 * src/modest-defs.h:
3515 * src/modest-account-mgr-helpers.h:
3516 * src/modest-account-mgr-helpers.c:
3517 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3519 * src/maemo/Makefile.am:
3520 * src/maemo/modest-signature-editor-dialog.c:
3521 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3524 * src/maemo/modest-account-settings-dialog.h:
3525 * src/maemo/modest-account-settings-dialog.c:
3526 (modest_account_settings_dialog_finalize), (on_button_signature),
3527 (save_configuration): Use the new dialog when the Edit button is pressed, and
3528 save the changes if necessary, as per the UI spec.
3530 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3532 * src/maemo/Makefile.am:
3533 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3534 based on maemo-develoers email from Dirk.
3536 * src/maemo/easysetup/modest-easysetup-wizard.c:
3537 (create_page_welcome), (create_page_account_details),
3538 (create_page_user_details), (create_page_complete_easysetup),
3539 (create_page_custom_incoming), (create_page_custom_outgoing),
3540 (create_page_complete_custom),
3541 (modest_easysetup_wizard_dialog_init):
3542 * src/maemo/modest-account-settings-dialog.c:
3543 (create_page_account_details), (create_page_user_details),
3544 (create_page_incoming), (create_page_outgoing),
3545 (modest_account_settings_dialog_init):
3546 * src/maemo/modest-connection-specific-smtp-window.c:
3547 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3549 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3551 * src/maemo/easysetup/modest-easysetup-wizard.c:
3552 (create_page_account_details), (create_page_custom_outgoing),
3553 (create_page_complete_custom):
3554 * src/maemo/modest-account-settings-dialog.c:
3555 (create_page_user_details), (create_page_incoming),
3556 (create_page_outgoing):
3557 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3558 (modest_connection_specific_smtp_edit_window_init):
3559 Use the correct (UI spec) port min/max, and use horizontal separators,
3562 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3564 * src/maemo/easysetup/modest-easysetup-wizard.c:
3565 (set_default_custom_servernames):
3566 * src/maemo/modest-account-settings-dialog.c:
3567 (create_page_incoming), (on_combo_outgoing_security_changed),
3568 (on_combo_incoming_security_changed), (create_page_outgoing),
3569 (modest_account_settings_dialog_set_account_name),
3570 (save_configuration):
3571 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3572 (on_combo_security_changed),
3573 (modest_connection_specific_smtp_edit_window_init),
3574 (modest_connection_specific_smtp_edit_window_set_connection),
3575 (modest_connection_specific_smtp_edit_window_get_settings):
3576 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3579 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3582 * src/maemo/easysetup/modest-easysetup-wizard.c:
3583 (create_page_custom_outgoing), (create_page_complete_custom):
3584 * src/maemo/modest-account-settings-dialog.c:
3585 (create_page_user_details), (create_page_outgoing):
3586 * src/maemo/modest-account-view-window.c: (button_box_new):
3587 Use changed logical IDs as per the most recent UI spec:
3588 mcen_bd_emailsetup_edit -> mcen_bd_edit
3589 mcen_bd_emailsetup_delete -> mcen_bd_delete
3590 mcen_bd_emailsetup_close -> mcen_bd_close
3592 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3596 * src/dbus_api/Makefile.am:
3597 * src/dbus_api/modest-dbus-callbacks.c:
3598 * src/dbus_api/modest-dbus-callbacks.h:
3599 * src/maemo/modest-platform.c: (modest_platform_init):
3600 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3602 * tests/Makefile.am:
3603 * tests/dbus_api/Makefile.am:
3604 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3606 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3608 * src/maemo/modest-account-settings-dialog.c:
3609 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3610 Removed unnecessary includes.
3612 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3614 * src/maemo/easysetup/modest-easysetup-wizard.c:
3615 * src/maemo/modest-account-settings-dialog.c:
3616 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3617 * src/widgets/Makefile.am:
3618 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3619 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3620 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3621 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3622 * src/widgets/modest-secureauth-combo-box.c:
3623 * src/widgets/modest-secureauth-combo-box.h:
3624 * src/widgets/modest-serversecurity-combo-box.c:
3625 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3626 made the GObject names more consistent with the rest of the Modest code.
3628 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3630 * src/maemo/easysetup/Makefile.am:
3631 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3632 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3633 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3634 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3635 * src/maemo/easysetup/modest-easysetup-wizard.c:
3636 * src/maemo/easysetup/modest-validating-entry.c:
3637 * src/maemo/easysetup/modest-validating-entry.h:
3638 * src/maemo/modest-account-settings-dialog.c:
3639 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3640 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3641 widgets/ because they are used outside of easysetup too. After checking in,
3642 svn will allow me to rename them too.
3644 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3646 * src/gnome/modest-msg-edit-window.c:
3647 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3648 linker error, to fix the build on the GNOME platform.
3649 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3650 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3651 ifdefed out to avoid a warning.
3653 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3655 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3656 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3657 some alternative for GTK+ 2.6.
3659 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3661 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3663 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3664 specified for EmailAccountsDialog in UI spec.
3666 * src/maemo/easysetup/modest-easysetup-wizard.c:
3667 * src/maemo/easysetup/modest-easysetup-wizard.h:
3668 * src/maemo/modest-account-settings-dialog.c:
3669 * src/maemo/modest-account-settings-dialog.h:
3670 Reuse a member window widget for the connection-specific SMTP server accounts,
3671 so we can tell it to create/save the accounts only if we actually save changes.
3673 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3674 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3675 (modest_connection_specific_smtp_edit_window_get_settings):
3676 Return a struct instance for temporarily remembering the entered data.
3678 * src/maemo/modest-connection-specific-smtp-window.h:
3679 * src/maemo/modest-connection-specific-smtp-window.c:
3680 (modest_connection_specific_smtp_window_finalize),
3681 (modest_connection_specific_smtp_window_fill_with_connections),
3683 (modest_connection_specific_smtp_window_save_server_accounts),
3684 (update_model_server_names): Do not actually save data until asked,
3685 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3687 (on_selection_changed),
3688 (modest_connection_specific_smtp_window_init): Disable the edit
3689 button when nothing is selected.
3691 * src/modest-account-mgr-helpers.c:
3692 * src/modest-account-mgr-helpers.h:
3693 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3696 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3698 * src/modest-account-mgr-helpers.h:
3699 * src/modest-account-mgr-helpers.c:
3700 (modest_account_mgr_get_unused_account_name),
3701 (modest_account_mgr_get_unused_account_display_name): Added these
3702 utility functions, to avoid code duplication.
3704 * src/maemo/easysetup/modest-easysetup-wizard.c:
3705 (create_page_account_details), (create_account):
3706 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3707 (on_combo_security_changed),
3708 (modest_connection_specific_smtp_edit_window_init),
3709 (modest_connection_specific_smtp_edit_window_save_settings):
3710 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3711 * src/maemo/modest-connection-specific-smtp-window.c:
3712 (modest_connection_specific_smtp_window_finalize),
3713 (modest_connection_specific_smtp_window_fill_with_connections),
3714 (on_button_edit), (modest_connection_specific_smtp_window_init):
3715 * src/maemo/modest-connection-specific-smtp-window.h:
3716 Implementing saving of connection-specific server accounts.
3718 But I need to refactor this so we can save the data for each
3719 possible connection-specific account and only actually create the server accounts
3720 when the easysetup finished, or the OK button is pressed on the account settings
3723 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3725 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3726 (on_combo_security_changed):
3727 (modest_connection_specific_smtp_edit_window_init):
3728 Auto-fill the port number as in the account settings.
3730 (modest_connection_specific_smtp_edit_window_set_connection):
3731 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3732 * src/maemo/modest-connection-specific-smtp-window.c:
3733 (fill_with_connections), (on_button_edit),
3734 (modest_connection_specific_smtp_window_init):
3735 Turn the edit window into a dialog to simplify the code, and
3736 set a WM hint as in a GtkDialog, because only a popup can be on top of
3737 another window in Maemo, and popups usually have no WM decoration.
3739 * src/modest-defs.h:
3740 * src/modest-account-mgr-helpers.c:
3741 (modest_account_mgr_set_connection_specific_smtp),
3742 (modest_account_mgr_remove_connection_specific_smtp),
3743 (modest_account_mgr_get_connection_specific_smtp):
3744 * src/modest-account-mgr-helpers.h: Some functions to write the
3745 connection-specific SMTP server information. Not yet used.
3748 * src/widgets/modest-folder-view.c: (text_cell_data):
3749 Fix a warning about an uninitialized variable.
3750 (on_configuration_key_changed): Put an #ifdef around the use
3751 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3753 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3755 * src/maemo/modest-account-settings-dialog.h:
3756 * src/maemo/modest-account-settings-dialog.c:
3757 Added connect_for_modified() utility function to mark the new modified boolean.
3759 (create_page_account_details), (create_page_user_details),
3760 (create_page_incoming), (create_page_outgoing), (on_response),
3761 (modest_account_settings_dialog_init),
3762 (modest_account_settings_dialog_set_account_name):
3763 Only warn about unsaved changes when there are actually unsaved changes.
3765 * src/modest-account-mgr-helpers.c:
3766 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3767 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3768 to get the data from there in future.
3770 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3772 * src/modest-defs.h:
3774 * src/modest-account-mgr-helpers.h:
3775 * src/modest-account-mgr-helpers.c:
3776 Store the security account setting in a single conf key instead of using
3777 the options list, so that the list is left for just the to-be-removed camel hack,
3778 and because gconf_client_set_list() is failing for some reason.
3780 * src/modest-account-mgr.c:
3781 (modest_account_mgr_add_server_account):
3782 * src/maemo/modest-account-settings-dialog.c:
3783 (modest_account_settings_dialog_set_account_name),
3784 (save_configuration): Use the renamed functions.
3787 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3789 * src/widgets/Makefile.am:
3790 * src/widgets/modest-limit-retrieve-combo-box.c:
3791 * src/widgets/modest-limit-retrieve-combo-box.h:
3792 * src/widgets/modest-retrieve-combo-box.c:
3793 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3794 the account settings dialog.
3796 * src/modest-defs.h:
3797 * src/modest-account-mgr-helpers.h:
3798 * src/modest-account-mgr-helpers.c:
3799 (modest_server_account_get_option_secure_auth),
3800 (modest_server_account_set_option_secure_auth):
3801 * src/modest-account-mgr.c:
3802 (modest_account_mgr_add_server_account):
3803 Use the existing AUTH_MECH conf key for the secure-auth setting,
3804 instead of putting it in the list options, because this was actually used already.
3806 * src/maemo/modest-account-settings-dialog.c:
3807 (create_page_account_details),
3808 (modest_account_settings_dialog_set_account_name),
3809 (save_configuration):
3810 * src/maemo/modest-account-settings-dialog.h:
3811 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3812 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3814 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3816 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3817 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3818 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3820 * src/modest-defs.h:
3821 * src/maemo/modest-account-settings-dialog.c:
3822 (create_page_incoming), (on_combo_outgoing_security_changed),
3823 (on_combo_incoming_security_changed), (create_page_outgoing),
3824 (modest_account_settings_dialog_set_account_name),
3825 (save_configuration): Load/Save the port number, and change it when the
3826 security combo changes, to suitable defaults.
3828 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3830 * src/modest-account-mgr.c:
3831 (modest_account_mgr_add_server_account): Set the security and secure-auth
3832 options, and add a comment saying that the other camel-specific options should be
3835 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3837 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3839 * src/modest-tny-account-store.c: (account_list_free),
3840 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3841 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3844 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3846 * src/modest-protocol-info.c:
3847 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3848 is required by our UI spec. Maybe something in our implementation will use this eventually.
3849 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3850 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3851 instead of the previous 0 placeholder.
3853 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3854 secure-auth settings.
3855 * src/modest-account-mgr-helpers.h:
3856 * src/modest-account-mgr-helpers.c:
3857 (modest_server_account_data_get_option_secure_auth),
3858 (modest_server_account_set_option_secure_auth),
3859 (modest_server_account_data_get_option_security),
3860 (modest_server_account_set_option_security): Added this API for getting and setting the security
3861 and secure-auth settings.
3863 * src/maemo/modest-account-settings-dialog.h:
3864 * src/maemo/modest-account-settings-dialog.c:
3865 (modest_account_settings_dialog_finalize), (check_data),
3866 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3867 about changing titles.
3868 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3869 (save_configuration): Save the security and secure-auth settings.
3871 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3872 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3874 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3876 * src/modest-defs.h:
3877 * src/modest-account-mgr.c:
3878 (modest_account_mgr_add_server_account):
3879 Added and used defines for the options key and value pair strings,
3880 that are used so far, though they do not seem to correspond to anything in our
3881 UI specs or ModestProtocol enum.
3883 * src/modest-account-mgr-helpers.h:
3884 * src/modest-account-mgr-helpers.c:
3885 (compare_option_strings_for_name),
3886 (modest_server_account_data_get_option_value),
3887 (modest_server_account_data_get_option_bool),
3888 (modest_account_mgr_get_server_account_option):
3889 Added helper functions for parsing the options GSList.
3891 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3893 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3894 display name is based on the supplied account name.
3895 * src/modest-account-mgr.c:
3896 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3897 with an inefficient, but good-enough, implementation.
3899 * src/maemo/easysetup/modest-easysetup-wizard.c:
3900 (create_page_account_details), (on_before_next), (create_account):
3901 Check for existing display names rather than (non-user-visible) account names, and just
3902 create and set a unique account name at the end.
3904 * src/maemo/modest-account-settings-dialog.c:
3905 (modest_account_settings_dialog_init),
3906 (modest_account_settings_dialog_set_account_name),
3907 (create_page_incoming): Show the display name, instead of the account name.
3908 (on_response): Do some (not all) extra checks, as in the UI spec.
3909 (save_configuration): Save the display name if it was changed.
3911 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3913 * po/en_GB.po: Added needed logical ID and translation.
3914 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3915 (init_view): Made the is-default column clicking work.
3917 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3920 * src/maemo/easysetup/Makefile.am:
3921 * src/maemo/easysetup/modest-easysetup-wizard.c:
3922 (modest_easysetup_wizard_dialog_init):
3923 * src/maemo/easysetup/provider-data-test.keyfile:
3924 * src/maemo/easysetup/provider-data.keyfile:
3925 Moved the provider data file to the new modest-providers-data package and used it from there.
3927 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3929 * src/modest-local-folder-info.c:
3930 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3931 N_() was already used on the static strings, but this just marks it for translation without
3932 using the translation.
3934 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3936 * src/maemo/modest-account-settings-dialog.c:
3937 (create_page_incoming),
3938 (modest_account_settings_dialog_set_account_name):
3939 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3940 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3941 I will do this if nobody else gets there first.
3943 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3945 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3946 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3947 save the security stuff.
3949 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3951 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3952 Set the email address and user fullname, which I now see must be
3955 * src/maemo/modest-account-settings-dialog.h:
3956 * src/maemo/modest-account-settings-dialog.c:
3958 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3959 leave-on-server and authentication.
3960 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3963 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3966 * src/maemo/modest-account-settings-dialog.c:
3967 * src/maemo/modest-account-settings-dialog.h:
3968 Most (but not all) of the widgets are now present as specified by the UI spec.
3969 No changes are yet saved, and some details are not properly shown yet.
3971 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3973 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3975 * src/maemo/Makefile.am:
3976 * src/maemo/modest-account-settings-dialog.c:
3977 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3978 an existing account. Doesn't do much yet.
3980 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3981 Open the accounts settings dialog when Edit is clicked.
3983 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3985 * src/maemo/easysetup/Makefile.am:
3986 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3988 * src/maemo/easysetup/modest-easysetup-wizard.c:
3989 (modest_easysetup_wizard_dialog_init):
3990 Try to get the source directory from the build system,
3991 instead of hard-coding "./" into the source code, when opening our local
3992 copies of the configuration files.
3993 But this still fails when opening the wizard from the Accounts window,
3994 maybe because the working directory seems to change at runtime.
3995 So the wizard will fail the second time unless you copy the files into their
3996 proper locations - see the stdout warnings for the paths.
3998 (create_page_account_details),(on_before_next):
3999 Check for existing non-server accounts instead of server accounts,
4000 so the default account name is useful again, and to prevent trying to
4003 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4004 Show the wizard when New is clicked.
4006 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4007 (init_view): Show the column headers, and show the columns that are
4008 specified in the UI specs. However, something in Maemo's GTK+ prevents
4009 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4010 change the default account. This is despite unsetting the special properties.
4012 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4014 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4015 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4016 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4017 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4018 to make that clearer.
4019 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4021 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4023 * src/maemo/modest-account-view-window.c:
4024 (modest_account_view_window_init),
4025 (modest_account_view_window_new):
4026 Use the same buttons as specified in the
4027 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4028 the existing widgets, which never had a chance of working.
4029 Put the ModestAccountView treeview in a scrolled window.
4030 Do not repeat the initialization in both _init() and _new().
4032 * src/widgets/modest-account-view.c: (update_account_view):
4033 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4034 this widget and window shows no accounts.
4036 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4038 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4040 * src/maemo/easysetup/modest-easysetup-wizard.c:
4041 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4042 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4043 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4046 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4047 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4048 accounts exist yet, as in the UI spec.
4050 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4052 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4054 * src/maemo/Makefile.am:
4055 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4056 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4057 New window for editing connection-specific smtp details.
4058 Not fully implemented.
4060 * src/maemo/modest-connection-specific-smtp-window.c:
4061 (modest_connection_specific_smtp_window_finalize) :
4062 unref the tree model.
4063 (on_button_edit): Show the edit window.
4065 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4067 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4070 * src/maemo/Makefile.am:
4071 * src/maemo/modest-connection-specific-smtp-window.c:
4072 * src/maemo/modest-connection-specific-smtp-window.h:
4073 New window for showing the list of connections, for connection-specific
4074 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4075 * src/maemo/easysetup/modest-easysetup-wizard.c:
4076 (create_page_custom_outgoing): Show the new window when the button is clicked.
4078 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4080 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4081 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4082 * src/maemo/modest-msg-edit-window.c:
4083 (modest_msg_edit_window_insert_image):
4084 * src/modest-conf.c: (modest_conf_key_escape):
4085 * src/modest-mail-operation.c:
4086 (modest_mail_operation_send_new_mail):
4087 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4088 (modest_ui_actions_on_new_account):
4089 * src/widgets/modest-attachment-view.c: (update_filename_request):
4090 * src/widgets/modest-mail-header-view.c:
4091 Corrected warnings that were breaking the build, by commenting out unused variables,
4092 and a function, and by including a header.
4094 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4096 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4097 so we can #ifdef around platform-specific code when necessary.
4098 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4099 to allow this to build for the GNOME platform too.
4101 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4103 * src/maemo/easysetup/modest-easysetup-wizard.c:
4104 Added util_increment_name() and used it in create_page_account_details()
4105 to make sure that the default account name is always a new name.
4107 (modest_easysetup_wizard_dialog_init),
4108 (set_default_custom_servernames): Some minor memory management fixes.
4110 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4114 * src/modest-runtime.c: (init_i18n): Restored the translation
4115 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4116 are defined in config.h, and the translations are installed.
4118 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4119 is defined for translation.
4121 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4123 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4125 * src/maemo/easysetup/modest-easysetup-wizard.c:
4126 (modest_easysetup_wizard_dialog_init):
4127 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4128 Use realistic paths (though they should use $prefix generically) to the
4129 mcc_mapping and provider-data.keyfile files which might work when they
4130 are installed by the future version of the operator-wizard package,
4131 and then fallback to paths in our source code, with an explanatory
4134 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4138 * src/maemo/Makefile.am:
4139 * src/maemo/easysetup/: Added files from the previously-exernal
4140 osso-modest-easysetup.
4141 * src/maemo/modest-main-window-ui.h:
4142 * src/modest-ui-actions.c:
4143 * src/modest-ui-actions.h:
4144 Added modest_ui_actions_on_new_account() as a signal handler for the
4145 New Account menu item. It shows the easysetup wizard.
4146 * po/en_GB.po: Added additional needed logical IDs and translations.