1 2007-07-23 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c:
4 (on_idle_open_default_inbox): Make sure that the application UI is
6 * src/maemo/easysetup/modest-easysetup-wizard.c:
7 (on_entry_invalid_character): Show the word whitespace instead
8 of (null) in the banner when whitespace was entered.
9 (show_error): Add a comment that this does not work in
10 Maemo Bora, though we do not know why.
12 2007-07-23 Murray Cumming <murrayc@murrayc.com>
14 * src/modest-tny-account.c:
15 (modest_tny_account_get_special_folder): Use an if instead of
16 an assert for when the parent account name is NULL, because this
17 might be causing a crash in projects.maemo.org bug 63192.
18 * src/modest-mail-operation.c:
19 (modest_mail_operation_send_new_mail_cb),
20 (modest_mail_operation_remove_folder): unref the folder that is
21 returned from modest_tny_account_get_special_folder().
23 2007-07-23 Murray Cumming <murrayc@murrayc.com>
25 * src/modest-ui-actions.c:
26 (modest_ui_actions_on_password_requested):
27 Show mail_ib_login_cancelled info banner when the user cancels
28 the protected password dialog, to fix projects.maemo.org
31 2007-07-23 Murray Cumming <murrayc@murrayc.com>
33 * src/maemo/modest-account-settings-dialog.c:
34 (create_page_outgoing): Put this page in a GtkScrolledWindow,
35 matching the UI mock-up in the UI spec, and allowing access
36 to all widgets even when the on-screen keyboard is active.
38 2007-07-23 Murray Cumming <murrayc@murrayc.com>
40 Reverted this previous commit from Johannes,
41 because the scrollbars are always visible and because
42 I think we only need it on onepage of the account
43 settings, not the account wizard.
44 (I wrote the wrong instructions in the bug.)
46 * src/maemo/easysetup/modest-easysetup-wizard.c:
47 Added scrollbars to account wizard dialog.
48 Fixed projects.maemo.org NB #62744
50 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
52 * src/maemo/easysetup/modest-easysetup-wizard.c:
53 (create_page_user_details):
54 Use auto-cap for name (projects.maemo.org NB#63716)
55 * src/widgets/modest-account-view.c: (on_account_busy_changed):
57 2007-07-22 Armin Burgmeier <armin@openismus.com>
59 * src/maemo/modest-ui-actions.c: Use current account instead of
60 default account for creating viewer windows, so that the viewer
61 window knows to which account the viewed message belongs.
63 * src/maemo/modest-msg-view-window.c: Destroy the window when the
64 corresponding account is deleted. This fixes projects.maemo.org bug
67 2007-07-18 Armin Burgmeier <armin@openismus.com>
69 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
70 the dialog close after entering an invalid port number and clicking
71 OK. This fixes projects.maemo.org bug NB#63602.
73 2007-07-18 Armin Burgmeier <armin@openismus.com>
75 * src/modest-tny-account-store.c:
76 (get_server_accounts): Set parent modest account name for each
77 connection-specific transport account so that special folders of such
78 an account can be looked up. This fixes a crash when changing account
79 settings. This might also be related to projects.maemo.org bug
82 2007-07-16 Armin Burgmeier <armin@openismus.com>
84 * src/modest-ui-actions.c: Added a button to create a folder to the
85 move-to dialog. This fixes projects.maemo.org bug NB#.
87 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
89 * src/maemo/easysetup/modest-easysetup-wizard.c:
90 Added scrollbars to account wizard dialog.
91 Fixed projects.maemo.org NB #62744
93 2007-07-16 Murray Cumming <murrayc@murrayc.com>
95 * src/widgets/modest-msg-view.h:
96 * src/widgets/modest-msg-view.c:
97 Added modest_msg_view_get_message_is_empty() but this needs
99 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
100 Check if there is any text in the message yet.
101 But this needs to be implemented properly.
102 (modest_msg_edit_window_toggle_find_toolbar):
103 * src/maemo/modest-msg-view-window.c:
104 (modest_msg_view_window_toggle_find_toolbar):
105 Show a banner warning if there is no text to search, when
106 trying to start a search. This partially fixes
107 projects.maemo.org bug NB#62350.
109 2007-07-13 Murray Cumming <murrayc@murrayc.com>
111 * src/modest-mail-operation.c: (update_account_thread):
112 Initialized num_new_headers to fix the build.
114 2007-07-13 Murray Cumming <murrayc@murrayc.com>
116 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
117 Ignore modest accounts whose server accounts don't exist in gconf.
118 This prevents us trying to create TnyAccount instances for those
119 server accounts when the server account has been removed from gconf,
120 but the parent modest account has not yet been removed from modest.
121 I don't know why this is only noticeable now. It was probably just
122 a harmeless g_warning() anyway.
124 2007-07-13 Murray Cumming <murrayc@murrayc.com>
126 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
127 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
129 2007-07-12 Armin Burgmeier <armin@openismus.com>
131 * src/maemo/modest-main-window.c: Make default account appear bold
132 in view, tools/send & receive and toolbar/send & receive SCM menus.
133 This fixes projects.maemo.org bug NB#59010.
135 2007-07-12 Murray Cumming <murrayc@murrayc.com>
137 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
138 Add a short-cut, by checking if the folder store is an account.
139 This ensures that the Sort menu item and toolbar is dimmed for
140 the local-folders account root item, fixing
141 projects.maemo.org bug NB#62545.
143 2007-07-12 Murray Cumming <murrayc@murrayc.com>
145 * src/modest-tny-account-store.c: (get_password):
146 Show the password dialog (via the signal) only in the mainloop, via
147 an idle handler that we wait for. This could theoretically prevent
148 hangs, though I worry that it could introduce some too.
150 2007-07-12 Murray Cumming <murrayc@murrayc.com>
152 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
153 * src/maemo/modest-platform.c:
154 (modest_platform_connect_and_wait):
155 Take a TnyAccount* parameter and try to set it to online
156 (a TnyCamel-only API), because tinymail sets accounts to offline
157 when the user cancels a password dialog, and doesn't ask again until
158 it has been set to online.
159 However, this is commented out because it causes a hang now.
161 (modest_platform_connect_and_wait_if_network_account):
162 * src/modest-mail-operation.c:
163 (modest_mail_operation_update_account):
164 * src/modest-platform.h:
165 * src/modest-ui-actions.c: (_modest_ui_actions_open),
166 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
168 2007-07-12 Armin Burgmeier <armin@openismus.com>
170 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
172 * src/modest-mail-operation.c:
173 * src/modest-ui-actions.c: Check for already existing folder before
174 querying the server, show error message from camel if the request
175 still fails. This fixes projects.maemo.org bug NB#58701.
177 2007-07-12 Murray Cumming <murrayc@murrayc.com>
179 * src/modest-tny-account-store.h:
180 * src/modest-tny-account-store.c:
181 Added modest_tny_account_store_forget_password_in_memory(),
182 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
183 when creating a new account, so that new passwords will be used, instead of
184 us thinking that it's a second request as a result of a failed password again.
186 2007-07-12 Murray Cumming <murrayc@murrayc.com>
188 * src/dbus_api/modest-dbus-callbacks.c:
189 (on_idle_open_message): If the message is in drafts then open it
190 in an edit window instead of a view window. This fixes
191 projects.maemo.org bug NB#63005.
193 2007-07-12 Murray Cumming <murrayc@murrayc.com>
195 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
196 Avoided a harmless g_warning().
198 2007-07-12 Murray Cumming <murrayc@murrayc.com>
200 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
201 Pass the modest account name, not the TnyAccount display name to
202 modest_msg_view_window_new() so that the reply feature works,
203 fixing projects.maemo.org bug NB#62892.
205 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
206 (modest_msg_view_window_new_with_header_model):
207 * src/maemo/modest-msg-view-window.c:
208 (modest_msg_view_window_new_with_header_model),
209 (modest_msg_view_window_new):
210 * src/modest-ui-actions.c: (reply_forward):
211 * src/widgets/modest-msg-view-window.h:
212 * src/widgets/modest-window.c: (modest_window_set_active_account):
213 Rename an account parameter to modest_account_name to make this clearer.
215 2007-07-11 Murray Cumming <murrayc@murrayc.com>
217 * src/modest-ui-actions.h:
218 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
219 modest_do_message_delete().
220 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
221 Call modest_do_message_delete(), hoping that this would cause messages
222 to be really deleted from search instead of just marked with strike through.
223 Does not seem to help.
225 2007-07-11 Armin Burgmeier <armin@openismus.com>
227 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
228 priv->reselect to FALSE prior to calling
229 modest_folder_view_select_first_inbox_or_local() to prevent endless
230 recursion and thus a crash on startup.
232 2007-07-11 Armin Burgmeier <armin@openismus.com>
234 * src/maemo/modest-account-settings-dialog.h: Include
235 <gtk/gtknotebook.h> to fix the build (at least for me).
237 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
238 Use "New FolderN" as default suggested name if "New folder" already
239 exists, with N being the first free number, though never exceed "New
240 folder99" in which case we just fall back to "New Folder" even though
241 it already exists. This fixes projects.maemo.org bug NB#58663.
243 2007-07-11 Murray Cumming <murrayc@murrayc.com>
245 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
246 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
247 projects.maemo.org bug NB#62778.
249 2007-07-11 Murray Cumming <murrayc@murrayc.com>
251 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
252 Ignore the wrong (for now) secure-smtp setting in the presets -
253 just default to requiring secure authentication for SMTP, because
256 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
258 * src/widgets/modest-folder-view.c: (filter_row)
259 Do not show drafts folder (see UI specs)
261 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
263 * src/modest-ui-actions.c:
264 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
265 place and also not necessary.
267 * src/widgets/modest-folder-view.c: (filter_row)
268 Guess folder type and hide Sent & Outbox if necessary.
269 Fixed project.maemo.org NB#57328
271 2007-07-11 Murray Cumming <murrayc@murrayc.com>
273 * src/modest-ui-actions.h:
274 * src/modest-ui-actions.c:
275 (modest_ui_actions_on_delete_message):
276 Move some code into a new
277 modest_ui_actions_refresh_message_window_after_delete()
278 function so we can use it from elsewhere.
280 * src/dbus_api/modest-dbus-callbacks.c:
281 (on_idle_delete_message), (on_delete_message): Used an idle
282 handler, as we do for the other D-Bus method handlers.
283 Call modest_ui_actions_refresh_message_window_after_delete()
284 if the deleted message was open in a window. This fixed
285 projects.maemo.org bug NB#62862.
287 2007-07-11 Murray Cumming <murrayc@murrayc.com>
289 * src/modest-main.c: (main): Only show the UI at the start if
290 the showui command line option was given. For instance,
291 run-standalone src/modest showui
292 Otherwise, we wait for the top_application D-Bus method to
293 be sent by hildon-desktop when the application is selected
295 This allows us to run without a UI when osso-global-search
296 uses our D-Bus methods.
298 2007-07-11 Murray Cumming <murrayc@murrayc.com>
300 * src/dbus_api/modest-dbus-api.h: Added a define for a
301 top-application D-Bus method.
302 * src/dbus_api/modest-dbus-callbacks.c:
303 (on_top_application),
304 (modest_dbus_req_handler): Handle the top-application D-Bus
305 method, which might be an undocumented D-Bus signal sent by
306 hildon-desktop when it starts the application from the menu.
307 But I am not sure and I need to test it on the device, because
308 my scratchbox does not have the application in the menu now.
309 This method shows the main window, so that it can be invisible
310 when started, for instance, just for email searching from
313 * src/maemo/modest-main-window.c: (restore_settings),
314 (modest_main_window_new): Do not show the window immediately
315 upon creation. We show it later.
316 * src/modest-widget-memory.c: (save_settings_paned):
317 Try (unsuccessfully) to avoid saving the paned position when
318 it is not even visible.
319 (restore_settings_paned): Do not allow a silly paned position.
320 This seems necessary when not showing the window at first.
322 * tests/dbus_api/Makefile.am:
323 * tests/dbus_api/test_top_application.c: (main): Test for the
326 2007-07-10 Murray Cumming <murrayc@murrayc.com>
328 * src/modest-ui-dimming-rules.c:
329 (modest_ui_dimming_rules_on_new_msg),
330 (modest_ui_dimming_rules_on_reply_msg),
331 (modest_ui_dimming_rules_on_delete_msg),
332 (modest_ui_dimming_rules_on_details),
333 (modest_ui_dimming_rules_on_view_window_move_to),
334 (modest_ui_dimming_rules_on_view_previous),
335 (modest_ui_dimming_rules_on_view_next),
336 (_invalid_folder_for_purge): Added checks before
337 casting the window. This looks like an actual
338 logic error in _invalid_folder_for_purge(), because it
339 tries to use a ModestMainWindow as a message window.
341 2007-07-10 Murray Cumming <murrayc@murrayc.com>
343 * src/maemo/modest-account-settings-dialog.c:
344 (show_error): Use the same implementation as in
345 modest-easysetup-wizard.c:
346 (on_entry_invalid_character): The logical ID contains a %s.
347 Guessed what it should be.
348 (on_entry_max), (check_data), (on_response): Adapt to
349 changed show_error().
350 (create_page_account_details): Really call
351 modest_validating_entry_set_func() on the correct widgets.
352 * src/maemo/easysetup/modest-easysetup-wizard.c:
353 (on_entry_invalid_character): Fix the logical ID here too.
354 (create_page_account_details),
355 (create_page_user_details):
357 modest_validating_entry_set_func() on the correct widgets.
359 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
360 Do not try to use the account if it is NULL.
362 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
364 * src/modest-ui-actions.c: (create_move_to_dialog),
365 (modest_ui_actions_on_main_window_move_to),
366 (modest_ui_actions_on_msg_view_window_move_to):
367 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
368 (filter_row), (modest_folder_view_show_non_move_folders):
369 * src/widgets/modest-folder-view.h:
371 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
372 the Sent folder yet as it does not report the correct folder type.
374 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
376 * src/maemo/modest-msg-edit-window.c: (init_window):
379 2007-07-10 Murray Cumming <murrayc@murrayc.com>
381 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
382 Take a parent widget instead of a parent window, and
383 implement this with hildon_banner_show_information() instead.
384 Non-Maemo builds can just ifdef that there.
385 This fixed projects.maemo.org bug NB#62766.
387 (on_entry_invalid_character): Use show_error() again instead
388 of using hildon directly, and use the _CS() macro to use the correct
390 (create_account), (check_for_supported_auth_methods), (on_entry_max):
391 Pass a widget instead od a window to show_error().
393 2007-07-10 Murray Cumming <murrayc@murrayc.com>
395 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
396 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
397 This allows us to show the server name in the error message, fixing
398 projects.maemo.org bug NB#62904.
399 Also, use the appropriate logical ID message for the account protocol.
401 2007-07-10 Murray Cumming <murrayc@murrayc.com>
403 * src/modest-tny-account-store.c: (on_idle_wrong_password):
404 A compilation fix, though the build wasn't broken for me.
406 2007-07-09 Murray Cumming <murrayc@murrayc.com>
408 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
409 Do not try to unref a NULL folder store, to avoid a runtime warning.
410 This seems to happen sometimes when changing accounts settings.
412 2007-07-09 Murray Cumming <murrayc@murrayc.com>
414 * src/modest-tny-account-store.c:
415 (modest_tny_account_store_instance_init),
416 (modest_tny_account_store_finalize),
417 (on_account_settings_hide), (on_idle_wrong_password):
418 Use a GHashTable to ensure that we only show one account settings
419 dialog per modest account. This avoids us having a dialog open for
420 both the store and transport accounts, or due to repeated get_password()
421 calls that shouldn't happen anyway.
423 2007-07-09 Murray Cumming <murrayc@murrayc.com>
425 * src/maemo/modest-maemo-utils.c: (on_hide),
426 (modest_maemo_show_dialog_and_forget): Handle the response, because
427 the window is not even hidden by default.
429 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
430 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
431 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
432 which seems to prevent some modality problems.
434 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
435 Ignore user cancellation errors.
437 * src/modest-account-mgr-helpers.h:
438 * src/modest-account-mgr-helpers.c:
439 Added modest_server_account_get_password() and
440 modest_server_account_get_has_password() to avoid direct use of
443 * src/maemo/modest-account-settings-dialog.h:
444 * src/maemo/modest-account-settings-dialog.c:
445 (modest_account_settings_dialog_init): Store the notebook so we can
447 Added modest_account_settings_dialog_switch_to_user_info().
449 * src/modest-tny-account-store.c:
450 (get_password): When the password in the account settings is wrong (we think),
451 show the relevant page of the account settings dialog, in the mainloop.
452 However, we currently get many of these at once because cancel does not
454 (forget_password): Do not forget the password
455 from the account settings, because this causes side-effects when
456 tinymail seems to call it at strange time, maybe because of how we
457 are cancelling get_password().
458 (modest_tny_account_store_alert): Ignore user cancellations.
460 2007-07-09 Murray Cumming <murrayc@murrayc.com>
462 * src/maemo/modest-maemo-utils.h:
463 * src/maemo/modest-maemo-utils.c:
464 Added modest_maemo_show_information_note_and_forget() for use instead of
465 gtk_dialog_run() when the response is not needed, to avoid an extra
466 mainloop which could cause a hang.
468 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
469 Use the logical IDs for the error message, though they are not
470 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
471 because gtk_dialog_run() caused a hang here (the window did not close).
472 This fixes projects.maemo.org bug NB#62646.
474 2007-07-09 Murray Cumming <murrayc@murrayc.com>
476 * src/modest-account-mgr-helpers.h:
477 * src/modest-account-mgr-helpers.c:
478 Added modest_account_mgr_get_store_protocol().
480 * src/maemo/modest-account-view-window.c:
481 (on_delete_button_clicked): Show different warning text depending on
482 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
483 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
486 2007-07-09 Murray Cumming <murrayc@murrayc.com>
488 * src/maemo/modest-msg-edit-window.c:
489 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
490 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
492 2007-07-07 Armin Burgmeier <armin@openismus.com>
494 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
495 ckdg_ib_maximum_characters_reached from correct package.
497 * src/modest-ui-actions.c: Show an error message when a folder could
498 not be created. Tinymail does not give us specific error codes about
499 what has gone wrong, so we assume that a folder with that name
500 already exists, though there might be other reasons.
502 2007-07-06 Murray Cumming <murrayc@murrayc.com>
504 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
505 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
506 give a more exact error message that can be partly translated.
508 2007-07-05 Murray Cumming <murrayc@murrayc.com>
510 * src/maemo/modest-address-book.c:
511 (select_email_addrs_for_contact): Specify a default window size for the
512 select-email-address dialog, so that it is probably big enough for the
513 title. This should fix projects.maemo.org bug NB#62277.
515 2007-07-05 Murray Cumming <murrayc@murrayc.com>
517 * src/maemo/easysetup/modest-easysetup-wizard.c:
518 (create_page_complete_easysetup): Use
519 gtk_widget_set_size() request to ensure that the text wraps
522 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
524 * src/maemo/easysetup/modest-easysetup-wizard.c:
525 (on_entry_invalid_character), (create_page_account_details),
526 (create_page_user_details):
527 Use new API of ModestValidatingEntry. But for some reason the banner is
528 not shown. I will have to investigate that further.
530 * src/widgets/modest-validating-entry.c: (on_insert_text),
531 (modest_validating_entry_set_func):
532 * src/widgets/modest-validating-entry.h:
533 Added a new callback function to be able to react to prevented
534 characters whitespaces to e.g show a banner.
536 2007-07-05 Armin Burgmeier <armin@openismus.com>
538 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
539 notification of HildonNumberEditor instead of remembering the port
540 number. Thanks to Johannes for pointing this out.
542 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
544 * src/maemo/easysetup/modest-easysetup-wizard.c:
545 Check if there are any user changes before showing a confirmation
546 dialog (projects.maemo.org NB#60946)
548 2007-07-05 Armin Burgmeier <armin@openismus.com>
550 * src/maemo/modest-account-settings-dialog.c: Remember custom port
551 number at the beginning of the dialog and set the modified flag at the
552 end if the port number has changed. This is necessary because
553 HildonNumberEditor does not support notification when the value has
556 2007-07-05 Murray Cumming <murrayc@murrayc.com>
558 * src/modest-ui-actions.c:
559 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
560 a connection before asking anything else. Correct the check for the destination
561 folder so that it succeeds when online.
562 This fixed projects.maemo.org bug NB#61645.
564 2007-07-05 Murray Cumming <murrayc@murrayc.com>
566 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
567 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
568 to fix projects.maemo.org bug NB#62439.
570 2007-07-05 Murray Cumming <murrayc@murrayc.com>
572 * src/modest-tny-account.c: (on_connection_status_changed):
573 Really do not use tny_device_force_offline() here. See the previous comment.
575 2007-07-04 Murray Cumming <murrayc@murrayc.com>
577 * src/modest-tny-account.c: (on_connection_status_changed):
578 Do not use tny_device_force_offline() when tinymail says that something
579 went wrong with the connection. It seems to report this unnecessarily.
581 2007-07-04 Murray Cumming <murrayc@murrayc.com>
583 * src/maemo/modest-connection-specific-smtp-window.c:
584 (modest_connection_specific_smtp_window_init):
585 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
586 does not seem to have any effect in osso 1.1 (though it works in
587 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
589 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
591 * src/maemo/modest-connection-specific-smtp-window.c:
592 Fix UI specification problems with projects.meamo.org NB#60479
594 2007-07-04 Murray Cumming <murrayc@murrayc.com>
596 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
597 clue when this has failed, because the error dialog is not always shown
598 (at least in earlier version).
600 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
601 GError message, because the generic error dialog is not helpful.
603 'This message is not currently available (can't let a new connection go online)'
604 when trying to open an IMAP message.
606 (_modest_ui_actions_open): Offer a connection when some messages would
607 have to be downloaded and we are offline.
609 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
611 * src/widgets/modest-folder-view.c:
612 Don't check for MERGE type anymore as we use the correct type
614 NOTE: For the last two changes you need to update your tinymail copy
615 because of API changes!
617 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
619 * src/modest-tny-local-folders-account.c:
620 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
621 (see projects.maemo.org NB#61580)
623 2007-07-04 Murray Cumming <murrayc@murrayc.com>
625 * src/modest-tny-account.c: (on_connection_status_changed):
626 Commented out the call to modest_platform_connect_and_wait() because this
627 seems to always hang, and I would like to know if this is the only thing
628 that causes a hang when showing the connection dialog.
629 It is not very useful anyway.
631 2007-07-04 Murray Cumming <murrayc@murrayc.com>
633 * src/maemo/modest-msg-view-window.c:
634 (modest_msg_view_window_select_next_message):
636 * src/modest-platform.h:
637 * src/maemo/modest-platform.c:
638 Added modest_platform_connect_and_wait(), which calls
639 tny_maemo_conic_device_connect() always in the main thread, by calling it
640 in an idle handler and waiting for the idle handler to run. It should be
641 in the main thread because it uses GTK+ UI code. It just returns TRUE
642 if the device is already online.
644 There is some nasty code to ensure that subsequent calls to
645 modest_platform_connect_and_wait() just wait for the first one to finish,
646 by checking repeatedly in another idle handler. This is necessary,
647 because other threads (or even the main thread, via another idle handler)
648 can call modest_platform_connect_and_wait() while
649 modest_platform_connect_and_wait() is running.
651 (modest_platform_connect_and_wait_if_network_account),
652 (modest_platform_connect_and_wait_if_network_folderstore):
653 Convenience functions that calls modest_platform_connect_and_wait() if
654 the account or folder might want network access.
656 * src/modest-mail-operation.c:
657 (modest_mail_operation_update_account):
658 * src/modest-ui-actions.c: (download_uncached_messages),
659 (modest_ui_actions_on_rename_folder), (delete_folder),
660 (modest_ui_actions_on_main_window_move_to),
661 (modest_ui_actions_on_msg_view_window_move_to):
662 * src/widgets/modest-folder-view.c:
663 (drag_and_drop_from_folder_view):
664 Offer a connection if we are offline.
666 * src/modest-tny-account.c: (on_connection_status_changed):
667 Document this as only handling errors during network operations in progress,
668 and replace the idle code with a simple call to
669 modest_platform_connect_and_wait(), which does this instead.
671 2007-07-03 Murray Cumming <murrayc@murrayc.com>
673 * src/modest-tny-account.c:
674 (modest_tny_account_get_special_folder): (util_on_idle),
675 Handle the GError so we can see when tny_folder_store_get_folders()
676 fails, as it currently does while something else is connecting.
678 Added util_run_in_main_thread_and_wait()
679 which uses an idlen handler and mainloop to ensure that the function
680 is called in the main thread.
681 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
682 to make sure that we call attempt the connection in the mainloop only,
683 which might solve some hangs.
685 2007-07-03 Murray Cumming <murrayc@murrayc.com>
687 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
688 be found by their display name. This is never useful.
689 * src/modest-tny-account-store.c: (on_account_removed): Find the account
690 by its ID, instead of trying to use its ID as its display name.
692 * src/modest-tny-account-store.h:
693 * src/modest-tny-account.c:
694 (modest_tny_account_get_special_folder): Add a g_warning() when
695 tny_folder_store_get_folders() returns an empty list for the maildir.
697 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
698 Add a g_warning() when this returns NULL, because that it not allowed
701 2007-07-02 Armin Burgmeier <armin@openismus.com>
703 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
704 note when trying to cancel the wizard. This fixes projects.maemo.org
707 2007-07-02 Murray Cumming <murrayc@murrayc.com>
709 * src/modest-tny-account.h:
710 * src/modest-tny-account.c:
711 (modest_tny_account_new_from_server_account),
712 (modest_tny_account_new_from_server_account_name),
713 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
714 because this must now be set before setting the proto. This is usd in
715 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
716 warning in camel_session_get_service() caused by
717 tny_camel_transport_account_prepare().
719 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
722 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
724 * src/maemo/modest-connection-specific-smtp-edit-window.c:
726 (modest_connection_specific_smtp_edit_window_init):
728 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
731 2007-06-29 Murray Cumming <murrayc@murrayc.com>
733 * src/modest-tny-account.c:
734 (modest_tny_account_new_from_server_account):
735 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
736 now uses to request a connection when it needs one, and which it uses
737 to tell us that something is wrong with the connection, so we can force
738 the accounts offline to prevent further problems.
741 * src/modest-init.c: (init_default_settings):
742 * src/modest-mail-operation.c:
743 (modest_mail_operation_update_account):
744 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
745 This should not be necessary anymore. Do not set the conf key that
746 determined this (it was always TRUE and not set anywhere else).
748 * src/modest-ui-actions.h: Remove unused and unimplemented
749 modest_ui_actions_on_online_toggle_toggled().
751 2007-06-29 Murray Cumming <murrayc@murrayc.com
753 * src/maemo/modest-main-window.c: (connect_signals):
754 Don't connect to delete_event twice. Maybe this was harmless.
756 2007-06-29 Murray Cumming <murrayc@murrayc.com
758 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
759 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
760 Debug output to give some more clue when a folder move is not allowed.
762 2007-06-28 Murray Cumming <murrayc@murrayc.com
764 * src/modest-tny-account.c: (on_modest_file_system_info),
765 (modest_tny_account_get_mmc_account_name):
766 Always call the callback, without checking whether the name has changed.
767 * src/widgets/modest-folder-view.c: (strings_are_equal),
768 (on_model_foreach_set_name), (on_get_mmc_account_name),
769 (text_cell_data): Compare the name here, and use the name from
770 the account rather than from the
771 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
772 if the name was changed after the account was added to the model.
773 That's a tinymail bug but not one that I want to fix now.
775 This finally fixes projects.maemo.org bug NB#59301.
777 2007-06-27 Armin Burgmeier <armin@openismus.com>
779 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
782 2007-06-27 Murray Cumming <murrayc@murrayc.com
784 * src/modest-tny-account.h:
785 * src/modest-tny-account.c:
786 Added modest_tny_account_get_mmc_account_name(), to set the memory
787 card name asynchronously for the given account and then notify.
788 (modest_tny_account_new_for_local_folders): Use this new function instead
789 of using hildon_file_system_info_async_new() directly.
791 * src/widgets/modest-folder-view.c: (text_cell_data):
792 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
793 gtk_tree_model_row_changed() when it is available.
795 This should fix projects.maemo.org bug NB#59301.
797 2007-06-27 Murray Cumming <murrayc@murrayc.com
799 * src/modest-mail-operation.c: (update_account_thread),
800 (get_msgs_full_thread): Fix typo failures in the revert
803 2007-06-27 Murray Cumming <murrayc@murrayc.com
805 * src/maemo/modest-maemo-global-settings-dialog.c:
806 (idle_select_default_focus):
807 * src/modest-mail-operation.c: (idle_notify_progress),
808 (idle_notify_progress_once), (set_last_updated_idle),
809 (update_account_thread), (get_msgs_full_thread):
810 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
811 * src/widgets/modest-header-view.c:
812 (idle_notify_headers_count_changed_destroy),
813 (idle_notify_headers_count_changed):
814 Reverted the additions of gdk_threads_enter/leave(), in case this
815 helps with a startup hang on the device.
817 2007-06-26 Armin Burgmeier <armin@openismus.com>
819 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
820 for supported secure authentication methods from server by
821 gtk_dialog_run(), saving CPU time and a potential race condition.
823 2007-06-26 Armin Burgmeier <armin@openismus.com>
825 * src/maemo/modest-maemo-utils.h:
826 * src/maemo/modest-maemo-utils.c: Added a
827 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
828 only error code to tell the calling code when the user canceled the
831 * src/maemo/modest-account-settings-dialog.h:
832 * src/maemo/modest-account-settings-dialog.c:
833 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
834 message if the retrieval of secure authentication methods was canceled
835 by the user. Perform the check before saving anything to configuration
836 to not end up with half-committed configuration changes, do not show
837 a "Saving to configuration failed" note when authentication methods
838 could not be retrieved.
840 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
843 2007-06-26 Murray Cumming <murrayc@murrayc.com>
845 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
846 Only return the first level of folders under accounts, because the
847 osso-global-search UI spec doesn't want the rest.
848 This fixed projects.maemo.org bug NB#61811.
850 2007-06-26 Murray Cumming <murrayc@murrayc.com>
852 * src/modest-tny-account-store.c:
853 * src/modest-tny-account-store.h:
854 Added modest_tny_account_is_memory_card_account().
855 * src/maemo/modest-main-window.c: (create_details_widget):
856 Show the same information items for the memory card as we show for the
857 local-folders, to fix projects.maemo.org bug NB#59307.
859 2007-06-26 Murray Cumming <murrayc@murrayc.com>
861 * src/modest-tny-account-store.c: (get_password):
862 Added some checks for NULL to maybe prevent crashes, though I think
863 it was Philip's last commit that actually prevented the crash here
864 when creating a first new account.
865 But the new account is still not usable (no messages are shown)
866 until a restart of the application.
868 2007-06-26 Murray Cumming <murrayc@murrayc.com>
870 * src/maemo/modest-maemo-global-settings-dialog.c:
871 (idle_select_default_focus):
872 * src/modest-mail-operation.c: (idle_notify_progress),
873 (idle_notify_progress_once), (idle_notify_update_account_queue),
874 (set_last_updated_idle), (update_account_thread),
875 (notify_get_msgs_full), (get_msgs_full_destroyer),
876 (get_msgs_full_thread):
877 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
878 * src/widgets/modest-header-view.c:
879 (idle_notify_headers_count_changed_destroy),
880 (idle_notify_headers_count_changed):
881 Use gdk_threads_enter() and gdk_threads_enter_leave() in
882 all idle handlers, because some other thread could be blocking
883 the GDK lock, so that it can do GUI stuff.
885 2007-06-26 Murray Cumming <murrayc@murrayc.com>
887 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
888 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
889 (on_idle_send_receive), (on_idle_open_default_inbox):
890 * src/maemo/modest-msg-edit-window.c:
891 (modest_msg_edit_window_attach_file_noninteractive):
892 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
893 to prevent a hang. I don't quite understand why these are necessary,
894 beause we should already be in the main loop. I guess something outside
895 of the main loop is taking the lock.
897 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
898 we are really using URIs, and use files that are more likely to exist.
900 2007-06-26 Murray Cumming <murrayc@murrayc.com>
902 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
903 necessary because configure.ac now defines different variables.
905 2007-06-26 Murray Cumming <murrayc@murrayc.com>
907 * libmodest-dbus-client/libmodest-dbus-client.c:
908 * libmodest-dbus-client/libmodest-dbus-client.h:
909 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
910 libmodest_dbus_client_compose_mail() is what things actually use.
912 * src/dbus_api/modest-dbus-api.h:
913 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
914 * tests/dbus_api/Makefile.am:
915 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
918 2007-06-26 Murray Cumming <murrayc@murrayc.com>
920 * src/modest-init.c: (modest_init_local_folders):
921 For memory-card (or other non local-folders) maildir accounts,
922 always create an Archive folder, so that there is somewhere to put
923 messages. This should be less confusing, because the user does not need
924 to guess that the need to create a folder.
926 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
928 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
929 Fixed icon size by using (50, 50) which is the same as defined by
932 2007-06-25 Armin Burgmeier <armin@openismus.com>
934 * src/widgets/modest-window-mgr.c:
936 * configure.ac: Correctly recognize hildon-notify presence and fixed
937 the build without it being installed.
939 2007-06-25 Murray Cumming <murrayc@murrayc.com>
941 * libmodest-dbus-client/libmodest-dbus-client.c:
942 (libmodest_dbus_client_search): Fix the build. Sorry.
943 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
944 (reply_forward_cb): Initialize variables to fix the build.
946 * src/modest-tny-account-store.c:
947 (modest_tny_account_store_get_tny_account_by): Fix the account URI
948 comparison (a silly typo) so that email search results can be opened
949 when there are more than one account.
951 2007-06-25 Murray Cumming <murrayc@murrayc.com>
953 * libmodest-dbus-client/libmodest-dbus-client.c:
954 (libmodest_dbus_client_search),
955 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
956 instead of 1 second, because the search gets folders and messages from
957 the server, which can take a long time. When it times out,
958 osso-global-search will report no results.
960 We need to specify whether we should search only cached information
961 (maybe with a user preference), and the osso-email-search-plugin
962 API should really be improved to allow that option, and to allow results
963 to be delivered asynchronously in batches.
965 2007-06-25 Murray Cumming <murrayc@murrayc.com>
967 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
968 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
969 GTK_ICON_SIZE_DIALOG is probably the wrong size.
971 2007-06-25 Murray Cumming <murrayc@murrayc.com>
973 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
974 that is an empty string. D-Bus seems to give us these instead of NULL.
976 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
978 * src/dbus_api/modest-dbus-callbacks.c:
979 * src/maemo/easysetup/modest-easysetup-wizard.h:
980 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
981 * src/maemo/modest-connection-specific-smtp-edit-window.c:
982 (modest_connection_specific_smtp_edit_window_init):
983 * src/maemo/modest-maemo-global-settings-dialog.c:
985 * src/maemo/modest-maemo-utils.c:
986 (modest_maemo_utils_setup_images_filechooser):
987 * src/maemo/modest-main-window.c: (create_details_widget):
988 * src/maemo/modest-msg-edit-window.c:
989 (modest_msg_edit_window_attach_file_noninteractive),
990 (modest_msg_edit_window_color_button_change),
991 (modest_msg_edit_window_set_zoom):
992 * src/modest-mail-operation.c: (update_account_thread):
993 * src/modest-tny-account-store.c:
994 * src/modest-tny-account.c:
995 * src/widgets/modest-global-settings-dialog.c:
996 * src/widgets/modest-window.h:
1000 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1002 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1003 * src/modest-search.c: (modest_search_folder),
1004 (modest_search_all_accounts): Actually search only in the specified folder,
1005 doing a simple match on the folder ID.
1006 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1007 and added some documentation.
1009 2007-06-22 Armin Burgmeier <armin@openismus.com>
1011 * src/maemo/modest-maemo-utils.h:
1012 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1013 modest_maemo_utils_get_supported_secure_authentication_methods.
1015 * src/maemo/easysetup/modest-easysetup-wizard.c:
1016 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1017 one occured, not just "Server does not support secure authentication".
1019 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1021 * src/modest-tny-account-store.c: (get_password):
1022 Restored the call to tny_account_set_user() because Philip seems to have
1023 stopped this from crashing (by not using the freed string). It still does
1024 not work, but now we can test it.
1026 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1028 * src/maemo/modest-msg-edit-window.c: (init_window):
1029 Comment out use of an uninitialzed GtkScrolledWindow variable,
1030 to fix the build and stop a crash. Yet again.
1032 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1034 * src/modest-tny-account-store.c: (get_password):
1035 Remove the call to tny_account_set_user() because this actually crashes.
1036 As mentioned in the last commit, it is known to not work anyway.
1038 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1040 * src/modest-tny-account-store.c: (get_password):
1041 Use tny_account_set_username() to tell tinymail that the username might
1042 have changed too. But tinymail ignores this: see projects.maemo.org
1044 * src/modest-ui-actions.c:
1045 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1046 reset the connection when changing the username, and improve the comments.
1047 Save the changed username to gconf at least, so it is used when Modest is
1050 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1052 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1053 Do not use a query, so that we get all folders, including for POP and
1054 local-folders. They work as search criteria too.
1055 This fixes projects.maemo.org bug NB#57740.
1057 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1059 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1060 Comment out the use of hildon_notification_set_sound() because it is
1061 not declared, to fix the build. Warnings are serious, people.
1063 2007-06-21 Armin Burgmeier <armin@openismus.com>
1065 * src/maemo/modest-maemo-utils.h:
1066 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1067 modest_maemo_utils_get_supported_secure_authentication_methods()
1068 to query authentication methods for a specific user. This should fix
1069 projects.maemo.org bug NB#61369.
1071 * src/maemo/easysetup/modest-easysetup-wizard.c:
1072 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1075 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1077 * libmodest-dbus-client/libmodest-dbus-client.h:
1078 * libmodest-dbus-client/libmodest-dbus-client.c:
1079 (modest_dbus_message_iter_get_search_hit),
1080 (libmodest_dbus_client_search):
1081 Reorganised and commented this.
1082 Removed modest_search_hit_free() from the public API because it
1085 Added libmodest_dbus_client_get_folders() and
1086 modest_folder_result_list_free().
1088 * src/dbus_api/modest-dbus-api.h:
1089 * src/dbus_api/modest-dbus-callbacks.c:
1090 (modest_dbus_req_filter): Commented. Moved most code to
1091 on_dbus_method_search() and added on_dbus_method_get_folders().
1093 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1094 of the extra D-Bus handler.
1096 * tests/dbus_api/Makefile.am:
1097 * tests/dbus_api/test_get_folders.c: New test for
1098 libmodest_dbus_client_get_folders(). This seems to return an empty list
1099 at the moment. That could be the same error that causes the message list
1100 to be empty sometimes.
1101 This should help with projects.maemo.org bug NB#57740.
1103 2007-06-21 Armin Burgmeier <armin@openismus.com>
1105 * src/modest-mail-operation.c: Do not call
1106 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1107 notify the operation's end after having set the status to CANCELED for
1108 the operation queue to listen on. This fixes a deadlock when there
1109 were mail operations in the queue during its finalization.
1111 * src/modest-singletons.c: Reordered uninitialization of the account
1112 manager to happen after the mail operation queue was uninitialized
1113 because the mail operation's in the queue might still try to access
1114 the account manager (see modest_mail_operation_notify_end()). This
1115 fixes a potential crash when terminating the application.
1117 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1119 * src/modest-search.c:
1120 (search_mime_part_and_child_parts): Moved some code here so we
1121 can search recursively in child folders.
1122 (modest_search_folder): Search in the message as a mime part, instead
1123 of just its child mime parts.
1124 (read_chunk), (search_mime_part_ogs):
1125 Check how many bytes were read, to prevent an endless loop.
1126 Searching in message bodies now works. This finishes the fix for
1127 projects.maemo.org bug NB#61007.
1129 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1131 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1132 Add a g_warning when the item is not a folder.
1134 * src/modest-ui-dimming-rules.c:
1135 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1136 when selected item is not a folder (for instance, an account), because
1137 the UI spec only talks about folders.
1138 I am not sure what the UI spec wants, so this might not totally fix
1139 projects.maemo.org bug NB#60794.
1141 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1143 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1144 (load_from_file): Sort the list. The unsorted list would be more noticeable
1145 in non-English locales.
1147 * src/maemo/modest-msg-edit-window.c:
1148 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1149 warning and fix the build.
1151 * src/maemo/modest-progress-bar-widget.c:
1152 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1153 avoid a g_warning, and probably to avoid a crash.
1155 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1157 * src/modest-search.c: (modest_search_folder): Check for a GError
1158 when calling tny_folder_get_headers(), to show that this is not the cause
1161 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1163 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1164 Actually set the body query instead of the subject query.
1166 * src/modest-search.c: (search_mime_part_ogs),
1167 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1168 which would probably cause it to fail if we got this far.
1170 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1171 to simplify the code.
1172 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1173 be causing search-in-body to fail.
1175 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1177 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1179 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1180 Better debug message when the folder cannot be found.
1181 This should help with fixing projects.maemo.org bug #61287.
1182 * src/modest-search.c: (add_hit): Do not leak the furl string.
1184 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1186 * src/modest-ui-actions.c:
1187 (modest_ui_actions_on_folder_selection_changed):
1188 Do not special-case TNY_MERGE_FOLDER here, because
1189 modest_tny_folder_get_account() already does that. This fixes
1190 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1191 shown when the Outbox was selected).
1193 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1195 * libmodest-dbus-client/libmodest-dbus-client.c:
1196 (_dbus_iter_get_string_or_null): Initialize the string variable in
1197 case this helps with Dirk's crash.
1199 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1201 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1202 though it is not implemented yet (this function is maybe not even used),
1203 to avoid breaking ABI in future.
1204 * libmodest-dbus-client/libmodest-dbus-client.c:
1205 (get_attachments_string): Moved some code into this generic function.
1206 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1207 sends email. It is maybe not used.
1208 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1209 (on_send_mail): Use attachments.
1211 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1212 * src/maemo/modest-msg-edit-window.c:
1213 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1214 a filename before using it, to fix projects.maemo.org bug NB#58233.
1216 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1218 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1219 Initialize the continue_download variable to fix the build, and probably
1220 to fix randome behaviour.
1222 2007-06-18 Armin Burgmeier <armin@openismus.com>
1224 * src/modest-tny-send-queue.h:
1225 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1226 the queue so we can later show it in the UI. Replaced
1227 modest_tny_send_queue_msg_is_being_sent() by
1228 modest_tny_send_queue_get_msg_status().
1230 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1232 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1233 gpointer. This probably was not harmful, but just to be sure.
1235 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1237 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1238 Fix the build, but leave the function broken on Bora, because
1239 hildon_uri_action_get_service() does not exist.
1240 osso_uri_action_get_service() does not exist either, it seems.
1242 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1244 * src/modest-tny-account.c:
1245 (modest_tny_account_new_from_server_account):
1246 Uncommented the url debug output again, because it is useful for
1247 debugging, as I said in the comment.
1249 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1251 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1253 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1254 for Mameo Bora, to fix the build.
1256 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1259 Fixed build with hildon < 0.99
1261 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1262 Check if the selected account is busy instead of checking all accounts
1264 * src/modest-account-mgr-priv.h:
1265 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1266 (modest_account_mgr_init), (compare_account_name),
1267 (modest_account_mgr_set_account_busy),
1268 (modest_account_mgr_account_is_busy):
1269 * src/modest-account-mgr.h:
1270 Added busy information to the account manager. It possible to
1271 set an account to busy or not busy now.
1273 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1274 (modest_mail_operation_update_account),
1275 (modest_mail_operation_notify_end):
1276 Set the account to busy/not busy depending on the operation state.
1278 * src/widgets/modest-account-view.c:
1279 (modest_account_view_finalize), (get_last_updated_string),
1280 (update_account_view), (on_account_busy_changed), (init_view):
1281 Show string "Refreshing..." if the account is currently busy.
1283 All this fixes projects.maemo.org bug NB#59711
1285 2007-06-14 Armin Burgmeier <armin@openismus.com>
1287 * src/widgets/modest-attachments-view.h:
1288 * src/widgets/modest-attachments-view.c: Added
1289 modest_attachments_view_has_attachments() and fixed coordinate
1290 transformation in get_att_view_at_coords(). This fixes attachment
1293 * src/widgets/modest-msg-view.c: Make use of
1294 modest_attachments_view_has_attachments() to decide whether to show
1295 attachments in the header.
1297 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1299 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1300 (on_change), (on_combo_security_changed),
1301 (modest_connection_specific_smtp_edit_window_init),
1302 (modest_connection_specific_smtp_edit_window_set_connection),
1303 (modest_connection_specific_smtp_edit_window_is_dirty):
1304 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1305 * src/maemo/modest-connection-specific-smtp-window.c:
1308 Show an comfirmation dialog for the smpt-edit-window if there are
1309 unsaved changes and the user hits cancel.
1310 (projects.maemo.org bug NB#60479)
1312 2007-06-14 Armin Burgmeier <armin@openismus.com>
1314 * src/maemo/easysetup/modest-easysetup-wizard.c:
1315 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1316 address" info in banner instead of node, and select all the text as
1317 per UI spec. This fixes projects.maemo.org bug NB#60550.
1319 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1321 reviewed by: <delete if not using a buddy>
1323 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1324 * src/modest-ui-actions.c: (folder_refreshed_cb):
1326 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1328 * src/widgets/modest-folder-view.c: (filter_row):
1329 Explictly filter out the per-account outbox accounts. I don't know why
1330 these only sometimes show up, but now they should never show up in the UI.
1331 This should fix projects.maemo.org bug NB#60160.
1333 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1335 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1336 when the toolbar does not exist yet.
1337 * src/modest-widget-memory.c: (save_settings_header_view):
1338 Added g_warnings() to help us to discover when we are trying to set
1339 an empty columns list in gconf.
1341 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1343 * src/modest-init.h:
1344 * src/modest-init.c:
1345 Added modest_init_get_default_header_view_column_ids().
1347 * src/modest-widget-memory.c: (restore_settings_header_view):
1348 Use the new function to get defaults, if the gconf key is empty,
1349 instead of not creating any columns. This seems to fix the
1350 empty right-hand pane problems.
1352 * src/widgets/modest-header-view.h: Improved documentation.
1354 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1356 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1357 Revert the use of the display name as the account name, because this
1358 is generally wrong and would break the code that follows.
1360 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1362 * src/maemo/easysetup/modest-easysetup-wizard.c:
1363 (check_for_supported_auth_methods), (on_before_next),
1366 More correct fix for projects.maemo.org bug NB# 58991
1367 Do not longer accept AUTH_PASSWORD as secure method and choose
1368 correct method when creating the account.
1370 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1372 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1373 Fixed projects.maemo.org bug NB# 58991
1375 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1377 * src/modest-init.c: (modest_init_init_core),
1378 (modest_init_local_folders): Fixed compilation errors.
1380 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1382 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1383 Remove unnecessary lib/include, though it is good in principle when needed.
1385 * src/modest-init.c: (modest_init_one_local_folder),
1386 (modest_init_local_folders):
1387 * src/modest-init.h: Initialize the .modest library for memory cards,
1388 instead of just doing nothing for them. This should allow us to create
1389 folders there, fixing projects.maemo.org bug NB#59297.
1391 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1393 * libmodest-dbus-client/libmodest-dbus-client.c:
1394 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1395 (libmodest_dbus_client_compose_mail),
1396 (libmodest_dbus_client_open_message),
1397 (libmodest_dbus_client_send_and_receive),
1398 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1400 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1401 (on_idle_open_message), (modest_dbus_req_handler),
1402 (search_result_to_message), (modest_dbus_req_filter):
1403 * src/modest-search.c: (add_hit), (modest_search_folder),
1404 (modest_search_all_accounts): Improved debug messages.
1406 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1408 * src/modest-tny-account-store.c:
1409 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1412 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1415 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1417 * src/modest-tny-account-store.c: (get_server_accounts):
1418 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1419 even when there are no accounts, so that the Outbox folder is always
1420 visible. This fixes projects.maemo.org bug NB#60158.
1422 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1424 * src/maemo/modest-main-window.c: (create_details_widget):
1425 Use the mcen_va_never logical ID.
1427 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1429 * src/dbus_api/modest-dbus-api.h:
1430 * src/dbus_api/modest-dbus-callbacks.c:
1431 (on_idle_open_default_inbox), (on_open_default_inbox),
1432 (modest_dbus_req_handler):
1433 Added a new OpenDefaultInbox method.
1435 * libmodest-dbus-client/libmodest-dbus-client.h:
1436 * libmodest-dbus-client/libmodest-dbus-client.c:
1437 Added libmodest_dbus_client_open_default_inbox() to call the new
1438 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1439 though it should maybe be used by a new osso-email-interface function.
1441 * tests/dbus_api/Makefile.am:
1442 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1445 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1447 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1448 NULL, so that the signals get all the keys. This should not actually
1449 change any behaviour because we currently update everything when anything
1452 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1454 * src/widgets/modest-folder-view.c: (text_cell_data),
1455 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1456 (find_inbox_iter): If tinymail tells us that the folder is
1457 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1458 This causes the inbox to be selected at startup, fixing part of
1459 projects.maemo.org bug NB#56305.
1461 * src/modest-ui-dimming-rules.c:
1462 (modest_ui_dimming_rules_on_tools_smtp_servers):
1463 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1464 the SMTP servers menu item.
1465 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1466 that the SMTP Servers menu item is dimmed when there are no accounts,
1467 as a future version of the UI spec will require. This fixes
1468 projects.maemo.org bug NB#56305.
1470 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1472 * src/maemo/modest-maemo-utils.c:
1473 (modest_maemo_utils_get_supported_secure_authentication_methods):
1474 Added label to dialog instead of unreadable title
1476 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1477 (modest_main_window_new):
1478 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1481 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1482 * src/modest-account-mgr.h:
1483 Added method to avoid code duplication
1485 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1486 (modest_ui_actions_on_send_receive):
1487 Use modest_account_mgr_has_accounts
1489 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1491 * src/maemo/easysetup/modest-presets.c:
1492 (modest_presets_get_info_server_security): Do not report secure auth
1494 * src/modest-protocol-info.c: Use the defines for the gconf key names
1495 for secure authentication. This was not working because we were writing
1496 Password and reading password, and the check was case sensitive.
1497 With this, gmail now works for receiving and sending when created via
1500 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1502 * src/maemo/easysetup/modest-presets.c:
1503 (modest_presets_get_info_server_security): Correct the key name for
1504 SecureSmtp, because it seems to be case-sensitive.
1505 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1506 Do not try to get the 0th notebook page if there are 0 pages, to
1507 avoid a g_warning().
1509 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1511 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1512 Prevent use of the new notification feature for now, because it currently
1513 shows one dialog for each new email, which is annoying.
1515 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1517 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1518 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1519 when no country was selected, so that we show the global ones.
1520 * src/maemo/easysetup/modest-presets.c:
1521 (modest_presets_get_providers): Return only the global providers, not
1522 all providers when mmc=0 was requested.
1524 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1526 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1527 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1528 provider ID in the combo.
1530 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1531 Do not show the page numbers, because it would be confusing when we add
1532 the 2 extra pages for the custom setup, when the user chooses the "Other"
1533 provider. This fixes projects.maemo.org bug NB#59028
1535 * src/modest-init.c: (modest_init_init_core),
1536 (modest_init_local_folders):
1537 * src/modest-init.h:
1538 * src/modest-tny-account.c:
1539 (modest_tny_account_new_for_local_folders): Do not create default folders
1540 for the memory card. This should fix projects.maemo.org bug NB#59328.
1542 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1544 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1545 Free the changed_conf_keys string items. They are already freed in the
1546 idle handler if that runs first.
1548 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1550 * src/modest-ui-actions.c:
1551 (modest_ui_actions_on_password_requested): Check that the server name
1552 is not NULL, because I just saw a password dialog with (null) as the
1555 * src/modest-tny-folder.[h|c]: Added
1556 modest_tny_folder_is_memory_card_folder().
1557 * src/modest-ui-dimming-rules.c:
1558 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1559 menu item for memory cards, as per the UI spec (section 7.4). This should
1560 fix projects.maemo.org bug NB#59297.
1562 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1564 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1565 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1566 is another problem with the code, see Murray's comment at line 772)
1568 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1570 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1571 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1572 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1573 (load_from_file), (easysetup_country_combo_box_init),
1574 (easysetup_country_combo_box_get_active_country_ids),
1575 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1576 instead of just one ID, to avoid duplicate country names in the UI.
1578 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1579 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1580 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1581 a single ID, avoiding duplicate providers.
1582 * src/maemo/easysetup/modest-easysetup-wizard.c:
1583 (on_combo_account_country): Adapt to use a list.
1585 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1587 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1588 keys changed in the last X seconds.
1590 * src/modest-account-mgr.h:
1591 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1592 (on_key_change), (modest_account_mgr_class_init),
1593 (modest_account_mgr_init), (modest_account_mgr_finalize):
1594 As the keys are changed, save them in a GSList* and signal that GSList*
1595 further every X seconds, to batch changes, to allow us to do just one
1596 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1597 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1599 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1600 changed signal signature.
1602 * src/modest-conf.c: (modest_conf_set_list),
1603 (modest_conf_on_change): Reenable notification.
1605 (modest_conf_maemo_fake_on_change): Comment out the hack that
1606 notified immediately instead of asynchronously.
1608 * src/widgets/modest-account-view.h:
1609 * src/widgets/modest-account-view.c:
1610 (update_account_view): Select the previously-selected account ID,
1611 if possible. This fixes projects.maemo.org bug NB#56933.
1613 (on_account_changed), (on_account_removed),
1614 (modest_account_view_select_account):
1616 Remove the block/unblock functions
1617 because they were not useful.
1619 * src/maemo/modest-account-view-window.c:
1620 (on_delete_button_clicked), (on_edit_button_clicked),
1621 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1623 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1625 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1626 Improve the error dialog to show Incorrect Account Settings, which seems
1627 clearer, and say that the internal error message (to be removed from the
1628 dialog later) is often misleading.
1629 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1631 * src/modest-tny-account.c:
1632 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1633 URL because this is so useful for debugging on the device.
1635 * src/widgets/modest-serversecurity-combo-box.c:
1636 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1638 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1640 * src/modest-mail-operation.c:
1641 (modest_mail_operation_send_new_mail):
1642 Added a comment about a nasty but apparently harmless message. Details
1643 added to the wiki g_warnings() page.
1645 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1647 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1648 (modest_tny_send_queue_class_init):
1649 Do not use the priv struct because it is empty, to avoid g_warnings
1650 about a non-existant priv struct.
1652 * src/modest-tny-account-store.c:
1653 (modest_tny_account_store_get_server_account),
1654 (modest_tny_account_store_get_transport_account_for_open_connection
1655 ): Do not try to get transport server accounts for local folders,
1656 because they don't have any. This avoids a g_warning().
1658 * src/maemo/modest-main-window.c:
1659 (modest_main_window_notify_send_receive_initied),
1660 (on_configuration_key_changed):
1661 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1662 * src/modest-defs.h:
1663 * src/modest-mail-operation.c:
1664 (modest_mail_operation_update_account):
1665 * src/modest-tny-account-store.h:
1666 * src/modest-tny-account.c:
1667 (modest_tny_account_get_special_folder),
1668 (modest_tny_account_new_for_local_folders),
1669 (modest_tny_account_new_for_per_account_local_outbox_folder):
1670 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1671 * src/modest-tny-local-folders-account.c:
1672 (add_account_folders_to_merged_folder):
1673 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1674 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1675 (modest_ui_actions_on_send):
1676 * src/widgets/modest-folder-view.c: (update_model):
1677 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1678 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1679 modest_tny_account_store_get_tny_account_by_account() to
1680 modest_tny_account_store_get_server_account() to make the code clearer.
1682 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1684 * src/dbus_api/modest-dbus-api.h:
1685 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1686 * src/maemo/modest-msg-edit-window.c:
1687 (modest_msg_edit_window_attach_file_noninteractive):
1688 added g_warning in case the file to be attached does not exist
1689 * tests/dbus_api/test_compose_mail.c: (main):
1690 removed obsolete comment, added generic files as test case
1692 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1694 * src/modest-tny-account-store.c: (get_server_accounts):
1695 Create the local folders account only once, not once for each outbox, and
1696 not only when there are some outboxes.
1698 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1700 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1701 code that is causing a crash at startup. Sergio says that he is fixing this.
1703 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1705 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1706 * src/maemo/modest-account-settings-dialog.c:
1707 (create_page_outgoing),
1708 (modest_account_settings_dialog_set_account_name),
1709 (save_configuration):
1710 - Fixed handling of the "Use secure authentication" toggle to comply with
1711 the ui specification. See also projects.maemo.org bug NB#58400
1713 - Restore the Secure connection setting combo correctly when loading
1716 * src/maemo/modest-maemo-utils.c:
1717 (on_camel_account_get_supported_secure_authentication),
1718 (modest_maemo_utils_get_supported_secure_authentication_methods):
1719 Fixed a crasher if operation is canceled
1721 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1722 (modest_protocol_info_auth_is_secure):
1723 * src/modest-protocol-info.h:
1725 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1726 the sense of the "Use secure authentication" toggle.
1728 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1730 * src/modest-tny-account-store.h:
1731 * src/modest-tny-account-store.c:
1732 Added modest_tny_account_store_get_local_folders_account().
1734 * src/modest-tny-folder.h:
1735 * src/modest-tny-folder.c:
1736 (modest_tny_folder_get_account):
1737 Added this replacement for tny_folder_get_account() which returns
1738 the local-folders account for TnyMergeFolders, to avoid the
1739 warning about the unimplemented get_account_func() vfunc().
1741 (modest_tny_folder_get_rules),
1742 * src/modest-ui-actions.c:
1743 (modest_ui_actions_on_folder_selection_changed):
1744 * src/modest-mail-operation.c:
1745 (modest_mail_operation_remove_folder),
1746 (modest_mail_operation_xfer_folder),
1747 (modest_mail_operation_rename_folder),
1748 (modest_mail_operation_get_msg),
1749 (modest_mail_operation_get_msgs_full),
1750 (modest_mail_operation_remove_msg),
1751 (modest_mail_operation_xfer_msgs),
1752 (modest_mail_operation_refresh_folder):
1753 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1755 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1757 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1758 (modest_server_account_set_security):
1759 * src/modest-defs.h: Add comments explaining that our
1760 UI spec means TLS when it says Normal, so these do not look like errors.
1762 * src/modest-tny-account.c:
1763 (modest_tny_account_new_from_server_account): Use the new tinymail
1764 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1765 for TLS. This should fix projects.maemo.org bug NB#58460.
1767 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1769 * src/maemo/easysetup/modest-easysetup-wizard.c:
1770 (create_account): Correct the position of the gconf sanity check warning.
1771 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1772 of using the g_idle_add() hack, because this does not seem to be necessary
1773 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1774 caused by something other than maemo's gconf.
1775 This fixes projects.maemo.org bug #59022.
1777 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1779 * src/modest-account-mgr-helpers.c:
1780 (modest_account_mgr_get_default_account): Do not check that the account
1781 exists if there is no default account (NULL), to fix a runtime warning.
1783 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1785 * src/widgets/modest-folder-view.c: (update_model):
1786 Do not unref the treemodel before we have finished with it.
1787 This prevents a valgrind warning and an occasional crash at startup.
1789 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1791 * libmodest-dbus-client/libmodest-dbus-client.h:
1792 added libmodest_dbus_client_compose_mail()
1793 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1795 added functions needed for SendAsMail() functionality
1796 * src/maemo/modest-msg-edit-window.c:
1797 (modest_msg_edit_window_attach_file_noninteractive):
1798 non interactively attaching files to message edit window
1799 * src/widgets/modest-msg-edit-window.h:
1800 * tests/dbus_api/Makefile.am:
1801 added test_compose_mail.c
1802 * tests/dbus_api/test_compose_mail.c: (main):
1804 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1806 * src/modest-account-view.c:
1807 Fixed bug projects.maemo.org bug NB#59307
1809 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1811 * src/maemo/easysetup/modest-easysetup-wizard.c:
1812 (get_serverport_incoming), (on_before_next), (create_account):
1813 * src/maemo/modest-account-settings-dialog.c:
1814 (modest_account_settings_dialog_set_account_name):
1815 * src/maemo/modest-maemo-utils.c:
1816 (on_camel_account_get_supported_secure_authentication_status),
1817 (on_camel_account_get_supported_secure_authentication),
1818 (on_secure_auth_cancel),
1819 (modest_maemo_utils_get_supported_secure_authentication_methods):
1821 Implemented security authentication for settings and easysetup.
1823 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1825 * src/maemo/modest-main-window.c: (create_details_widget):
1826 Show the total size for memory card accounts too, instead of showing
1827 the name again. Fixes bug projects.maemo.org bug NB#59307.
1829 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1832 * src/modest-tny-simple-folder-store.c:
1833 * src/modest-tny-simple-folder-store.h: Removed.
1835 * src/modest-tny-local-folders-account.h
1836 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1837 for the local-folders maildir, with an extra TnyMergedFolder containing
1838 the folders of the per-account outbox store accounts.
1839 * src/modest-tny-account-store.c: (get_server_accounts):
1840 Add the outboxes to the special local folders account after creating it.
1842 * src/modest-tny-account.c:
1843 (modest_tny_account_new_for_local_folders): Create the derived
1844 account when creating the main local-folders account.
1846 * src/maemo/modest-main-window.c: (create_details_widget),
1847 (modest_main_window_set_contents_style):
1848 Adapted to the use of the derived account instead of the folder store.
1850 * src/modest-ui-actions.c:
1851 (modest_ui_actions_on_folder_selection_changed):
1852 * src/modest-ui-dimming-rules.c:
1853 (modest_ui_dimming_rules_on_new_folder):
1854 * src/widgets/modest-folder-view.c: (text_cell_data),
1855 (icon_cell_data), (filter_row), (update_model),
1856 (get_cmp_rows_type_pos):
1859 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1860 Do not get the priv struct, because no priv struct has been set,
1861 to avoid a runtime warning.
1863 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1864 #ifelse with #else, to fix a warning, to fix the build.
1867 2007-06-05 Christian Kellner <ckellner@openismus.com>
1869 * libmodest-dbus-client/libmodest-dbus-client.c:
1870 Fix small typo in doc (why do you always see them
1871 AFTER committing stuff?)
1874 2007-06-05 Christian Kellner <ckellner@openismus.com>
1876 * libmodest-dbus-client/libmodest-dbus-client.c:
1877 (libmodest_dbus_client_search):
1878 Initialize hit list with NULL. Also set folder list
1879 to "" if NULL was supplied.
1882 2007-06-03 Christian Kellner <ckellner@openismus.com>
1884 * libmodest-dbus-client/libmodest-dbus-client.c:
1885 (modest_search_hit_list_free):
1886 Make it save to call it with NULL.
1888 * src/dbus_api/modest-dbus-callbacks.c:
1889 * src/modest-search.c:
1890 Return full ModestSearchHits as the search result list not TnyHeader
1891 since can't be around withouth the correspoding TnyFolder.
1893 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1895 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1896 Added currently commented code to check for secure auth
1898 * src/maemo/modest-account-settings-dialog.c: (on_response),
1899 (save_configuration), (show_ok):
1900 Fixed projects.maemo.org bugs NB #59248 and #59251
1902 * src/maemo/modest-maemo-utils.c:
1903 (on_camel_account_get_supported_secure_authentication_status),
1904 (on_camel_account_get_supported_secure_authentication),
1905 (modest_maemo_utils_get_supported_secure_authentication_methods):
1906 * src/maemo/modest-maemo-utils.h:
1907 Moved get_supported_secure_authentication() method here to be able
1908 to use it from easysetup wizard.
1910 * src/modest-pair.c: (on_pair_compare_as_string):
1911 Should compare string with first part of pair and not
1912 strcmp pairs which will crash.
1914 * src/modest-protocol-info.c:
1915 (modest_protocol_info_protocol_is_store):
1916 * src/modest-protocol-info.h:
1917 Added modest_protocol_info_get_auth_protocol_name()
1919 2007-06-03 Armin Burgmeier <armin@openismus.com>
1921 * src/modest-mail-operation.c:
1922 (modest_mail_operation_get_msgs_full): Set priv->account also when
1923 only retrieving a single message. This avoids a crash when canceling
1926 (modest_mail_operation_notify_end): Do not explicitely remove the
1927 operation from the queue but only emit the progress_changed signal.
1928 The queue itself listens to that signal to remove the operation when
1929 it is finished. This reduces coupling and removes a potential deadlock
1930 when modest_mail_operation_notify_end() is called from the queue
1931 itself. If that is a problem performance-wise, I would suggest to
1932 implement a status-changed signal or something.
1934 * src/modest-mail-operation-queue.c: Make sure to never call a
1935 function from another file while the queue is locked. This (hopefully)
1936 fixes another deadlock when exiting the application while retrieving
1939 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1941 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1942 Fixed build if libogs is not available
1944 2007-06-03 Christian Kellner <ckellner@openismus.com>
1946 * libmodest-dbus-client/libmodest-dbus-client.h:
1947 * libmodest-dbus-client/libmodest-dbus-client.c:
1948 (libmodest_dbus_client_delete_message):
1949 Implement deletion of messages (Client side).
1951 (modest_search_hit_free),
1952 (modest_search_hit_list_free):
1953 Utility functions to free the result hits.
1955 * src/dbus_api/modest-dbus-api.h:
1956 * src/dbus_api/modest-dbus-callbacks.c:
1957 (on_delete_message),
1958 (modest_dbus_req_handler):
1959 Implement deletion of messages (Server side).
1961 * tests/dbus_api/test_search.c: (main):
1964 * tests/dbus_api/Makefile.am:
1965 * tests/dbus_api/test_delete_message:
1966 Add little test for the message deletion logic
1968 2007-06-03 Armin Burgmeier <armin@openismus.com>
1970 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1971 when the operation queue was not empty. projects.maemo.org bug
1974 2007-06-03 Armin Burgmeier <armin@openismus.com>
1976 * src/widgets/modest-account-view.c
1977 (on_account_default_toggled): Toggle default account column
1978 explicitely instead of waiting for gconf notification (which is
1979 currently ignored). This should fix projects.maemo.org bug NB#56910
1980 for now. It should probably be removed when gconf notifications are
1983 2007-06-03 Christian Kellner <ckellner@openismus.com>
1985 * libmodest-dbus-client/libmodest-dbus-client.c:
1986 Removed debugging spew.
1988 * src/dbus_api/modest-dbus-callbacks.c:
1989 Added debugging info.
1991 * src/modest-search.c:
1992 (modest_search_all_accounts):
1993 Use tny_account_store_get_accounts () on the account store
1994 to get all accounts which is the way to get all accounts.
1996 * tests/dbus_api/test_search.c: (main):
1997 Make it possible to supply the search term on the command line.
1999 2007-06-03 Christian Kellner <ckellner@openismus.com>
2001 * libmodest-dbus-client/libmodest-dbus-client.c:
2002 * libmodest-dbus-client/libmodest-dbus-client.h:
2003 Implement searching for mesages over raw dbus. (Client side)
2005 * src/dbus_api/Makefile.am:
2006 * src/dbus_api/modest-dbus-api.h:
2007 * src/dbus_api/modest-dbus-callbacks.c:
2008 * src/dbus_api/modest-dbus-callbacks.h:
2009 Search framework (Server side). Also implement on_idle_open_message().
2011 * src/maemo/modest-platform.c: (modest_platform_init):
2012 Prepare for raw dbus/osso rpc interaction.
2014 * src/modest-search.h:
2015 Changed minsize from unspecific guint to guint32.
2017 * src/modest-search.c:
2019 Added strange hack which magically made tnymail work.
2021 (modest_search_folder),
2022 (modest_search_account),
2023 (modest_search_all_accounts):
2024 Implement helper functions to search all accounts, specific account
2027 * tests/dbus_api/Makefile.am:
2028 * tests/dbus_api/test_open_message.c:
2029 Read url to open from commandline.
2031 * tests/dbus_api/test_search.c:
2032 Implement small test for dbus search stuff
2034 2007-06-02 Armin Burgmeier <armin@openismus.com>
2036 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2037 include account type and account title. This fixes projects.maemo.org
2040 * src/maemo/modest-account-view-window.c: Set a title for the window.
2042 2007-06-02 Armin Burgmeier <armin@openismus.com>
2044 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2045 incoming and outgoing server name based on email address and server
2046 types as long as the names have not been edited manually. This fixes
2047 projects.maemo.org bug NB#58671.
2049 2007-06-02 Armin Burgmeier <armin@openismus.com>
2051 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2052 server type cannot be changed in future to the incoming details page
2053 when creating an account. This fixes projects.maemo.org bug NB#59029.
2055 2007-06-02 Armin Burgmeier <armin@openismus.com>
2057 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2058 and assigned max width chars so that they wrap instead of being
2059 truncated. Fixes projects.maemo.org bug NB#56126.
2061 2007-06-02 Armin Burgmeier <armin@openismus.com>
2063 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2064 introductory note to the connection specific smtp servers dialog, as
2065 section 8.12 of the email UI specification requires. This fixes
2066 projects.maemo.org bug NB#59212.
2068 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2070 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2071 Check for running mail operations, and offer to cancel them, as per the UI
2072 spec. This fixes projects.maemo.org bug NB#59041 .
2073 However, I suspect that tinymail may still use the network connection
2074 in ways that we cannot detect or cancel. But it should at least adapt to
2075 changes fairly well.
2077 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2079 * src/modest-tny-account-store.c: (recreate_all_accounts),
2080 (get_cached_accounts), (get_server_accounts): Do more sensible
2081 ref-counting of the temporarily-cached outbox accounts list. This seems
2082 to fix a crash when entering the password when the password was wrong.
2084 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2086 * src/gnome/modest-main-window.c: (connect_signals):
2087 * src/modest-tny-account-store.c: (get_password),
2088 (modest_tny_account_store_alert): Added comments and clues and
2089 commented-out code about how we currently fail to deal with connection
2090 errors and wrong passwords, and how we should.
2092 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2094 * src/widgets/modest-retrieve-combo-box.c:
2095 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2096 This fixes projects.maemo.org bug NB#58472 .
2098 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2100 * src/maemo/easysetup/modest-easysetup-wizard.c:
2101 (create_page_complete_easysetup):
2102 (create_page_complete_custom): Correct the last commit,
2103 putting the correct sentences in the correct pages.
2105 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2107 * src/maemo/easysetup/modest-easysetup-wizard.c:
2108 (create_page_complete_custom): Show the second sentence of text
2109 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2112 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2114 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2115 Set the leave-on-server conf key by default. This fixes
2116 projects.maemo.org bug NB#59258 .
2118 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2120 * src/maemo/modest-account-view-window.c:
2121 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2122 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2125 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2127 * src/maemo/easysetup/modest-easysetup-wizard.c:
2128 (create_caption_new_with_asterisk):
2129 * src/maemo/modest-account-settings-dialog.c:
2130 (create_caption_new_with_asterisk):
2131 Uncomment the code to add the asterisk, because they are no longer in the
2132 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2133 (update_incoming_server_title): Add an asterisk here too.
2135 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2137 * src/maemo/modest-maemo-global-settings-dialog.c:
2138 (current_connection): Check that we are even connected before trying to
2139 get the current connection name, to prevent a warning.
2141 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2142 Change the comments because tny_maemo_conic_device_connect() is now meant to
2144 * src/modest-mail-operation.c:
2145 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2146 make sure we have a connection and fail if we can't connect.
2148 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2150 * src/maemo/modest-main-window.c:
2151 (on_account_store_connecting_finished): Do not try to get the
2152 connection ID if we are not really connected. I am surprised that
2153 this signal handler is called when we are not connected.
2155 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2157 * src/modest-error.h:
2158 * src/modest-ui-actions.c:
2159 (modest_ui_actions_get_msgs_full_error_handler):
2160 Renamed an enum, added comments, added an enum
2161 for retrieve-limit errors.
2163 * src/modest-mail-operation.c: (foreach_add_item),
2164 (internal_folder_observer_update), (update_account_thread),
2165 (modest_mail_operation_get_msgs_full):
2166 (modest_mail_operation_update_account),
2167 Added comments about how this works, and some code that should
2168 (but does not) check the retrieve-limit. See the TODO comment.
2170 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2172 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2173 Initialize help_id to fix the build. Warnings are good.
2175 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2177 * src/widgets/modest-hbox-cell-renderer.c:
2178 (modest_hbox_cell_renderer_append):
2179 * src/widgets/modest-vbox-cell-renderer.c:
2180 (modest_vbox_cell_renderer_append):
2181 Fix the last commit by doing an extra ref.
2183 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2185 * src/widgets/modest-hbox-cell-renderer.c:
2186 (modest_hbox_cell_renderer_append):
2187 * src/widgets/modest-vbox-cell-renderer.c:
2188 (modest_vbox_cell_renderer_append):
2189 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2190 to fix the build with Maemo Bora.
2191 However, there seems to be a remaining crash, probably due to reference
2194 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2196 * src/modest-tny-account.c:
2197 (modest_tny_account_new_for_local_folders):
2198 Use hildon_file_system_info_async_new() to get a better name for
2199 the memory card account, setting it as the account name.
2200 The timing seems to work, but this is probably
2201 not the best place to do this. See the TODO comment.
2202 * src/maemo/modest-main-window.c: (create_details_widget):
2203 * src/widgets/modest-folder-view.c: (text_cell_data):
2204 Use the tny account name instead of hardcoding a name.
2206 2007-05-30 Christian Kellner <ckellner@openismus.com>
2208 * src/modest-search.c: (modest_search):
2209 Correctly set part_search_func even if we have already parsed
2210 the query and thus a valid OgsTextSearcher object.
2212 2007-05-30 Christian Kellner <ckellner@openismus.com>
2215 Search and check for libogs.
2218 Incooparte the ogs build env.
2220 * src/modest-mime-part-search-stream.c:
2221 * src/modest-mime-part-search-stream.h:
2222 Removed since we do the real searching now in modest-search.c.
2224 * src/modest-search.c:
2225 * src/modest-search.h:
2226 Implement support for ogs. We use that if available and requested
2227 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2228 should now handle the corner case when the search term is spread
2229 across multiple reads.
2230 Also the logic in modest_search () was corrected to search all
2231 requested fields until one is found.
2233 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2235 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2237 * src/modest-init.h:
2238 * src/modest-init.c: Made modest_init_local_folders() take a
2239 path and be public so we can iniitialize maildir folders on
2242 * src/modest-local-folder-info.h:
2243 * src/modest-local-folder-info.c:
2244 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2246 * src/modest-tny-account.c:
2247 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2248 still means the standard local-folders path on the local volume.
2250 * src/modest-tny-account-store.c:
2251 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2252 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2253 all accounts when that happens.
2254 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2255 this too, so it shows up in the treeview.
2257 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2259 * src/maemo/modest-maemo-global-settings-dialog.c:
2260 (current_connection):
2261 * src/widgets/modest-global-settings-dialog.c:
2262 (current_connection_default):
2263 Use the enum values instead of 0, 1 and -1,
2264 to make the code clearer.
2266 * src/modest-account-mgr-helpers.c:
2267 (modest_account_mgr_get_connection_specific_smtp): Make this code
2270 * src/modest-runtime.h:
2271 * src/modest-runtime.c:
2272 Added modest_runtime_remove_all_send_queues().
2273 * src/maemo/modest-main-window.c:
2274 (on_account_store_connecting_finished): Recreate the send queues,
2275 using the appropriate transport accounts for this new connection.
2276 Some futher adapting might be needed if the old send queues are not
2277 automatically stopped at this point.
2279 * src/modest-tny-account-store.c: (get_server_accounts):
2280 Create the connection-specific transport accounts, so that they can
2281 be found later by their ID.
2283 * src/modest-tny-account.h:
2284 * src/modest-tny-account.c:
2285 Added modest_tny_account_new_from_server_account_name().
2286 modest_tny_account_new_from_server_account(): Do not create the
2287 send queues here, because they will be
2288 recreated anyway when the connection changes for the first time.
2290 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2292 * src/modest-local-folder-info.h:
2293 * src/modest-local-folder-info.c:
2294 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2295 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2296 tbox_folder): Take a modest account name instead of a server TnyAccount,
2297 so we can have per-modest-account rather than per-transport-account
2299 We must make sure that we change or recreate the exisitng send queues
2300 when the connection changes for connection-specific transport accounts.
2302 * src/modest-tny-account-store.c:
2303 (create_per_account_local_outbox_folders): Create outboxed per modest
2304 account, not per transport account.
2306 * src/modest-tny-account.h:
2307 * src/modest-tny-account.c:
2308 (modest_tny_account_get_special_folder): For outboxes, get the
2309 parent modest account name. The account is ignored for other folders.
2310 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2311 modest account name rather than a server TnyAccount.
2313 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2315 * src/modest-tny-account.c:
2316 (modest_tny_account_new_from_server_account):
2317 Call modest_runtime_get_send_queue() immediately after creating transport
2318 accounts, so that they start trying to send email from the outbox as soon
2319 as possible at startup. This is probably what we want.
2321 * src/modest-mail-operation.c: (update_account_thread):
2322 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2323 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2324 * src/modest-tny-send-queue.h:
2325 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2326 (modest_ui_actions_on_send):
2327 Added comments about how sending works, though it needs some more work.
2329 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2331 * src/modest-tny-account.c:
2332 (modest_tny_account_get_special_folder): Add TODO because this fails when
2333 the network is busy.
2334 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2335 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2336 Do not try to show this window when there is no active account. The UI
2337 specs does not tell us what to do in this case.
2339 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2343 * src/maemo/Makefile.am:
2344 * src/widgets/Makefile.am: Some dist fixes.
2346 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2348 * src/maemo/modest-connection-specific-smtp-window.c:
2349 (on_button_edit): Make the code clearer, to prevent a double free.
2351 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2353 * src/maemo/modest-account-settings-dialog.c:
2354 (modest_account_settings_dialog_set_account_name),
2355 Check the connection-specific smtp servers checkbox if there are any.
2357 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2358 (modest_connection_specific_smtp_edit_window_init):
2359 Start with a suitable port number.
2361 * src/modest-account-mgr-helpers.h:
2362 * src/modest-account-mgr-helpers.c: Added
2363 modest_account_mgr_get_has_connection_specific_smtp().
2365 (modest_account_mgr_set_connection_specific_smtp),
2366 (modest_account_mgr_remove_connection_specific_smtp),
2367 (modest_account_mgr_get_has_connection_specific_smtp),
2368 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2369 connection-specific smtp server accounts in the account, rather than
2370 the server account conf dir.
2372 This fixes bug projects.maemo.org bug NB#58263 .
2374 * src/modest-tny-account-store.c:
2375 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2376 if there are no server accounts yet, to prevent an infinite loop when there
2377 are no accounts. Document that one must be called before the other.
2379 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2381 * src/modest-account-mgr-helpers.c:
2382 (modest_account_mgr_get_default_account): Make sure that at least
2383 one account is always the default, if there are any enabled accounts.
2384 This is just a sanity check that shouldn't be necessary.
2386 * src/modest-account-mgr-priv.c:
2387 (_modest_account_mgr_account_from_key): Unescape the conf key to
2388 get the real account name. For instance, this is an issue if a space
2389 was in the account name, which can happen because the account name
2390 is generated from the display name.
2391 (_modest_account_mgr_get_account_keyname): Always escape the
2393 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2394 Unescape the conf keys to get the real account names.
2396 For instance, previously the is-default radio button in the accounts
2397 list was not checked for any accounts at first. This fixes that,
2398 and might fix several similar bugs.
2400 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2402 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2403 Removed some debug printfs.
2405 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2407 Modest on-disk outbox directories are now here, for instance:
2408 $HOME/.modest/outboxes/<account-id-1>/outbox
2409 $HOME/.modest/outboxes/<account-id-2>/outbox
2411 $HOME/.modest/local-folders/outbox
2412 so we can have a separate outbox for each account.
2413 But they are shown as one outbox in the GtkTreeView, by using a
2414 TnyMergeFolder in a ModestTnySimpleFolderStore.
2417 * src/modest-tny-simple-folder-store.c:
2418 * src/modest-tny-simple-folder-store.h:
2419 Added ModestTnySimpleFolderStore, used to contain folders from
2420 other folder stores, such as other accounts.
2422 * src/modest-tny-outbox-account.h:
2423 * src/modest-tny-outbox-account.c:
2424 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2425 used for the per-account local outbox folders.
2427 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2428 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2429 only use this (internally) now for the non-outbox local folders.
2431 * src/modest-init.h:
2432 * src/modest-init.c: Added modest_init_one_local_folder(), for
2433 setting up the directory structure for each local folder.
2435 * src/modest-local-folder-info.c:
2436 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2437 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2439 * src/modest-local-folder-info.h:
2440 * src/modest-tny-account-store.c: (on_account_removed),
2441 (on_account_changed), (create_per_account_local_outbox_folders),
2442 (get_server_accounts), (modest_tny_account_store_get_accounts),
2443 (modest_tny_account_store_get_tny_account_by_account),
2444 (modest_tny_folder_store_is_virtual_local_folders):
2446 * src/modest-tny-account.h:
2447 * src/modest-tny-account.c:
2448 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2449 to create an on-disk per-account local outbox folder for each
2451 (create_per_account_local_outbox_folders): Create a local outbox folder
2452 for each transport account.
2453 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2454 for all local folders.
2456 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2457 instead of using g_object_get/set() directly. It is clearer.
2459 (modest_tny_folder_store_get_message_count),
2460 (modest_tny_folder_store_get_local_size
2461 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2462 because we now use these with non-acount folder stores.
2464 (modest_tny_account_get_special_folder),
2465 (modest_tny_account_new_from_server_account),
2466 (modest_tny_account_new_from_account):
2467 (recurse_folders): Adjust to the new outbox system.
2469 * src/modest-tny-folder.h:
2470 * src/modest-tny-folder.c:
2471 (modest_tny_folder_is_local_folder),
2472 (modest_tny_folder_get_local_folder_type),
2473 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2475 * src/widgets/modest-main-window.h:
2476 * src/maemo/modest-main-window.c: (create_details_widget),
2477 (modest_main_window_set_contents_style): Show details for any folder store,
2480 (modest_tny_folder_get_rules):
2481 Remove the const. C does not support constness enough for this.
2483 * src/modest-ui-actions.c:
2484 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2485 make all outboxes appear as one, in the usual local-folders tree node.
2487 (set_active_account_from_tny_account),
2488 (modest_ui_actions_on_folder_selection_changed):
2489 * src/widgets/modest-folder-view.c: (text_cell_data),
2490 (icon_cell_data), (filter_row),
2491 (add_account_folders_to_merged_folder),
2492 (add_account_folders_to_simple_folder_store), (),
2493 (get_cmp_rows_type_pos), (cmp_rows),
2494 (modest_folder_view_set_account_id_of_visible_server_account):
2495 Adjust to the new outbox system, using generic folder stores and folders
2496 in the GtkTreeModel.
2498 2007-05-23 Christian Kellner <ckellner@openismus.com>
2500 * src/modest-mail-operation.c:
2501 (modest_mail_operation_update_account):
2502 Use info->max_size instead of unintialized local var [small
2503 build fix]. (Added TODO to review that change since I don't
2506 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2508 * libmodest-dbus-client/libmodest-dbus-client.c:
2509 (libmodest_dbus_client_compose_mail): function added
2510 * src/dbus_api/modest-dbus-api.h:
2511 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2512 (on_compose_mail): Implementation of the SendAsMail functionality
2514 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2516 * src/modest-account-mgr.c:
2517 (modest_account_mgr_add_server_account): Set the secure-connection
2518 conf key for transport accounts as well as store accounts. I don't know
2519 why the if was there. For instance, this makes sure that we use SSL
2520 for the gmail preset from the easysetup wizard.
2522 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2524 * src/gnome/modest-main-window.c:
2525 (on_account_store_connecting_finished), (connect_signals):
2526 * src/maemo/modest-main-window.c:
2527 (on_account_store_connecting_finished), (connect_signals),
2528 (modest_main_window_new):
2529 Handle TnyAccountStore::connecting-finished instead of
2530 TnyDevice::connection-changed, because we cannot actually perform
2531 operations on accounts until TnyAccountStore has itself responded to
2532 the TnyDevice::connection-changed signal. This prevents a GError from
2534 Do not try to update at startup, because we (at least on scratchbox)
2535 already do an update at startup when the device goes online.
2536 This prevents a GError from tinymail.
2537 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2538 Added TODO about stopping simultaneous operations.
2540 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2542 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2543 * src/modest-mail-operation-queue.c:
2544 (modest_mail_operation_queue_remove):
2545 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2546 about where they happened.
2548 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2550 * src/modest-ui-actions.c:
2551 (modest_ui_actions_on_password_requested): Make sure that the remember
2552 output parameter is always TRUE.
2554 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2556 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2557 Show a OK/Cancel dialog if the error is a question, though we still do not
2558 know anything more about what we are asking the user.
2559 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2560 Fix an uninitialized variable (helper). This is a logic error, however.
2562 2007-05-21 Christian Kellner <ckellner@openismus.com>
2564 * src/modest-search.h:
2565 Correct bit shifting in the ModestSearchFlags enum.
2567 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2569 * src/modest-tny-account.c:
2570 (modest_tny_account_new_from_server_account): Do not use the lsub and
2571 check-all hard-coded IMAP options when using POP.
2573 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2575 * src/modest-tny-account.c:
2576 (modest_tny_account_new_from_server_account):
2577 Use NULL for the secure-auth method for POP when Password auth has been
2578 specified by the user, as we already do for IMAP. "auth=Login" causes
2579 an error from camel or the server.
2581 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2583 * src/maemo/modest-account-settings-dialog.c:
2584 (create_page_account_details),
2585 (modest_account_settings_dialog_set_account_name):
2586 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2587 for the leave-on-server checkbox, rathr than just the checkbox, when
2588 the protocol is not POP.
2590 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2592 * src/widgets/modest-account-view.c:
2593 * src/widgets/modest-account-view.h:
2594 Added modest_account_view_select_account() which will be useful later
2595 to asynchronously re-select the edited account.
2597 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2599 * src/maemo/modest-account-settings-dialog.c:
2600 (modest_account_settings_dialog_set_account_name):
2601 Automatically choose the port numbers based on the secure authentication
2602 methods, if they have not been chosen before.
2603 This fixes projects.maemo.org bug NB#56273 .
2605 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2607 * src/maemo/modest-main-window-ui.h:
2608 * src/modest-ui-actions.c:
2609 * src/modest-ui-actions.h:
2610 Connect the Tools/SMTP Servers menu item to
2611 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2612 SMTP servers dialog, as in the UI specification and saves changes when it
2613 is closed. This fixed projects.maemo.org bug NB#56305 .
2615 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2617 * src/maemo/modest-connection-specific-smtp-window.c:
2618 (modest_connection_specific_smtp_window_init):
2619 Use gtk_window_set_default_size() to make this window big enough, so
2620 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2622 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2624 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2625 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2626 (modest_connection_specific_smtp_edit_window_init),
2627 Do not try to connect to a combobox signal before the combobox exists.
2628 This fixes the cras in projects.maemo.org bug NB#56288 .
2629 (modest_connection_specific_smtp_edit_window_get_settings):
2630 Remove the server_account_name parameter which was being checked for NULL
2631 though it was not used.
2633 * src/maemo/modest-connection-specific-smtp-window.c:
2634 (modest_connection_specific_smtp_window_fill_with_connections),
2635 (on_button_edit), (modest_connection_specific_smtp_window_init):
2636 Correct the number of treemodel columns to prevent a warning.
2637 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2638 libconic does not work.
2640 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2642 * src/modest-tny-account.c:
2643 (modest_tny_account_new_from_server_account):
2644 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2645 SMTP when "None" was chosen by the user. However, with my SMTP server that
2646 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2649 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2651 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2652 to explain the memory management issue with the ID in the ModestPair.
2654 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2655 (add_sending_page), (modest_account_assistant_finalize):
2656 * src/gnome/modest-gnome-global-settings-dialog.c:
2657 (create_updating_page), (create_composing_page):
2658 * src/gnome/modest-msg-edit-window.c: (get_transports),
2659 (init_window), (modest_msg_edit_window_finalize),
2660 (modest_msg_edit_window_get_msg_data):
2661 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2662 * src/gnome/modest-transport-widget.c:
2663 (modest_transport_widget_finalize), (smtp_configuration):
2664 * src/maemo/modest-maemo-global-settings-dialog.c:
2665 (create_updating_page), (create_composing_page):
2666 * src/maemo/modest-msg-edit-window.c: (get_transports),
2667 (init_window), (modest_msg_edit_window_finalize),
2668 (modest_msg_edit_window_get_msg_data),
2669 (modest_msg_edit_window_free_msg_data):
2670 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2671 (modest_store_widget_finalize):
2672 * src/maemo/modest-transport-widget.c:
2673 (modest_transport_widget_finalize), (smtp_configuration):
2674 * src/modest-main.c: (send_mail):
2675 * src/widgets/modest-combo-box.h:
2676 * src/widgets/modest-global-settings-dialog-priv.h:
2677 * src/widgets/modest-global-settings-dialog.c:
2678 (modest_global_settings_dialog_finalize):
2679 * src/widgets/modest-msg-edit-window.h:
2680 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2681 as long as the combo box, to prevent use of freed memory for the ID.
2683 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2685 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2686 get_accounts(), to make this clearer. Do not check for the enabled gconf
2687 key, because we do not use this for server accounts (at least, not yet).
2688 This allows us to send email again.
2690 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2692 * src/maemo/modest-platform.c:
2693 (on_modest_conf_update_interval_changed), (modest_platform_init):
2694 Only respond to this particular key change. All these strcmp()s cannot be
2697 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2699 * src/maemo/modest-maemo-global-settings-dialog.c:
2700 (current_connection): Prevent a crash in scratchbox when
2701 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2702 * src/maemo/modest-platform.c:
2703 (on_modest_conf_update_interval_changed), (modest_platform_init):
2704 Get the update interval from gconf and reset it when the gconf key changes.
2706 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2708 * src/modest-protocol-info.c:
2709 * src/modest-protocol-info.h: Adde enum-specific get functions,
2710 instead of using a ModestProtocolType enum parameter.
2712 * src/gnome/modest-account-assistant.c:
2713 * src/gnome/modest-store-widget.c:
2714 * src/gnome/modest-store-widget.h:
2715 * src/gnome/modest-transport-widget.c:
2716 * src/gnome/modest-transport-widget.h:
2717 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2718 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2719 * src/maemo/easysetup/modest-easysetup-wizard.c:
2720 * src/maemo/modest-account-settings-dialog.c:
2721 * src/maemo/modest-account-settings-dialog.h:
2722 * src/maemo/modest-store-widget.c:
2723 * src/maemo/modest-store-widget.h:
2724 * src/maemo/modest-transport-widget.c:
2725 * src/maemo/modest-transport-widget.h:
2726 * src/modest-account-mgr-helpers.c:
2727 * src/modest-account-mgr-helpers.h:
2728 * src/modest-account-mgr.c:
2729 * src/modest-account-mgr.h:
2730 * src/modest-tny-account.c:
2731 * src/modest-tny-folder.c:
2732 * src/widgets/modest-account-view.c:
2733 * src/widgets/modest-retrieve-combo-box.c:
2734 * src/widgets/modest-retrieve-combo-box.h:
2735 * src/widgets/modest-secureauth-combo-box.c:
2736 * src/widgets/modest-serversecurity-combo-box.c:
2737 * src/widgets/modest-serversecurity-combo-box.h:
2738 * tests/check_account-mgr.c:
2739 Use the specific functions, and use the re-renamed enum values for GNOME too.
2741 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2743 * src/modest-pair.h:
2744 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2745 so we can get the second based on the first.
2747 * src/maemo/modest-account-settings-dialog.h:
2748 * src/maemo/modest-account-settings-dialog.c:
2749 Added get_supported_secure_authentication_methods(), though it is mostly
2750 commented-out for now until the necessary API is committed to tinymail.
2751 (modest_account_settings_dialog_set_account_name),
2752 (save_configuration): Request the supported authentication methods from the
2753 server, so we can choose a working method.
2755 * src/modest-tny-account-store.h:
2756 * src/modest-tny-account-store.c:
2757 (modest_tny_account_store_get_session): Rename from
2758 tny_account_store_get_session().
2760 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2762 * src/modest-protocol-info.h: Split the ModestProtocol enum
2763 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2764 There was no need to have these unrelated values in one enum.
2766 * src/: many files: Adapted to changed enum. This makes the code a bit
2767 clearer, and the compiler could catch some errors.
2769 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2771 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2772 Show the detailed internal camel error message when an error happens
2773 during the configuration, so that our testers can give us more clues.
2774 For instance, in projects.maemo.org bug NB#56910 .
2776 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2778 * src/modest-tny-account.c:
2779 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2780 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2782 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2784 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2785 * src/maemo/modest-account-settings-dialog.c:
2786 (modest_account_settings_dialog_set_account_name),
2787 (save_configuration): For the incoming secure authentication checkbox,
2788 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2789 the UI specification. PLAIN does not seem to be supported for most IMAP
2790 servers anyway, and I am not sure what it would mean.
2791 However, we probably need to discover which of the secure-authentication
2792 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2793 * src/modest-account-mgr-helpers.c:
2794 (modest_account_mgr_get_server_account_data):
2796 * src/modest-tny-account.c:
2797 (modest_tny_account_new_from_server_account):
2798 Use tny_account_set_mech() to set secure-authentication methods,
2799 with some special-casing for IMAP, based on my observations of how
2802 * src/modest-account-mgr-helpers.h:
2803 * src/modest-account-mgr.c:
2804 * src/modest-defs.h: Comment that the URI is only used for local folders.
2806 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2808 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2809 parameter const, just to be neat.
2810 * src/modest-text-utils.c: (modest_text_utils_inline):
2811 End g_strconcat() with NULL, as its documentation says. This is almost
2812 certainly the cause of my crash at startup on the device. Interestingly,
2813 valgrind doesn't tell us about these errors.
2815 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2817 * scripts/build-packages: Added more precise comments about how to use
2818 this script, though I still get this error:
2819 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2820 error building tinymail
2822 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2824 * src/maemo/modest-main-window.c: (on_account_update):
2825 Very slight cleanup, hoping to make it simpler to discover what causes
2826 a crash here sometimes.
2828 * src/modest-tny-account.c:
2829 (modest_tny_account_new_from_server_account): Set the port. Added
2830 comments about the options and a TODO comment because I need to find out
2831 how to specify the secure authentication method.
2833 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2835 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2836 changed CFlags paths form modest to libmodest
2838 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2840 * src/modest-account-mgr-helpers.c:
2841 (modest_account_mgr_get_server_account_data),
2842 (modest_account_mgr_free_server_account_data):
2843 * src/modest-account-mgr-helpers.h:
2844 * src/modest-account-mgr.c:
2845 (modest_account_mgr_add_server_account):
2846 * src/modest-defs.h:
2847 * src/modest-tny-account.c:
2848 (modest_tny_account_new_from_server_account):
2849 Determine the options for tny_camel_account_add_option() here,
2850 based on the settings, rather than storing them directly in gconf.
2852 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2854 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2855 Show a more friendly error dialog now that we expect (from the tinymail
2856 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2858 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2860 * src/maemo/modest-main-window.c: (on_account_update): Check that
2861 account_name is not NULL, to prevent a crash at startup that I am
2862 seeing on the N800. I do wonder why it is NULL.
2864 * src/maemo/easysetup/modest-easysetup-wizard.c:
2865 (create_page_user_details):
2866 * src/maemo/modest-account-settings-dialog.c:
2867 (create_page_user_details), (create_page_outgoing):
2868 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2869 (modest_connection_specific_smtp_edit_window_init):
2870 * src/modest-ui-actions.c:
2871 (modest_ui_actions_on_password_requested):
2872 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2873 might do something useful with the on-screen keyboard.
2875 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2877 * src/maemo/modest-main-window.c: (on_account_update):
2878 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2879 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2881 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2883 * src/modest-tny-account-store.c: (on_account_changed):
2884 Correct the signature of this signal handler.
2886 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2888 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2889 Show a HildonNote instead of a GtkDialog for Maemo.
2891 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2893 * src/widgets/modest-account-view.h:
2894 * src/widgets/modest-account-view.c: (on_account_changed),
2895 (on_account_removed). Added a boolean flag, set/unset by
2896 modest_account_view_block_conf_updates(),
2897 modest_account_view_unblock_conf_updates() to prevent unnecessary
2898 updates, but this is not very useful because the gconf notifications are
2899 so delays (maybe only on Maemo Bora).
2900 So auto-updating is turned off, and these functions do an explicit
2901 update when necessary.
2902 However, something else is still doing too much work when adding/removing
2903 accounts, probably in another part of the application.
2905 * src/maemo/modest-account-view-window.c:
2906 (on_delete_button_clicked), (on_edit_button_clicked),
2907 (on_new_button_clicked): Use the new functions.
2909 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2911 * src/modest-account-mgr-helpers.c:
2912 (modest_account_mgr_set_first_account_as_default):
2913 Sort the list of names alphabetically-by-title, so we choose the first one
2915 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2916 alphabetically by the title.
2918 This fixes projects.maemo.org bug NB#56418 .
2920 * src/modest-account-mgr-priv.c:
2921 (_modest_account_mgr_account_from_key):
2922 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2923 avoid a valgrind error, and possible random behaviour.
2925 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2927 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2928 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2929 tinymail documentation to say that this can be expected.
2930 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2931 pretty, and should not happen, but I would prefer to know when it does.
2933 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2935 * configure.ac: When using the older hildon version, probably on Bora,
2936 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2938 * src/widgets/modest-attachment-view.c:
2939 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2942 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2944 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2945 Implemented the prototype. Can be tested with
2946 tests/dbus_api/test_open_message:
2948 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2950 * src/modest-tny-account-store.c:
2951 (modest_tny_account_store_instance_init), (get_password):
2952 * src/modest-ui-actions.c:
2953 (modest_ui_actions_on_password_requested):
2954 Do not store the password in gconf, because this function is called
2955 for non-remembered passwords. Actually use the cached (in the hash map)
2956 password instead of releasing it.
2957 The password will now not be remembered if it is asked via the protected
2958 password dialog, as per the UI spec.
2960 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2962 * src/modest-defs.h:
2963 * src/modest-account-mgr-helpers.h:
2964 * src/modest-account-mgr-helpers.c:
2965 Added modest_server_account_get_username_has_succeeded(),
2966 modest_server_account_set_username_has_succeeded().
2967 (modest_server_account_set_username),
2968 Reset the has-succeeded flag if the username changes.
2970 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2971 * src/maemo/modest-connection-specific-smtp-window.c:
2972 (modest_connection_specific_smtp_window_save_server_accounts):
2973 Use modest_server_account_set_username() instead of using
2974 modest_conf_set_string() directly, so that the has-succeeded flag is always
2977 * src/modest-ui-actions.c:
2978 (modest_ui_actions_on_password_requested): Dim the username entry if
2979 the username has ever worked, as per the UI spec.
2981 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2983 * src/modest-tny-account-store.c: (get_password):
2984 * src/modest-ui-actions.c:
2985 (modest_ui_actions_on_password_requested):
2986 Allow the username to be changed too, though there is more work to
2987 be done on exactly how this behaves.
2989 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2991 * src/modest-account-mgr-helpers.h:
2992 * src/modest-account-mgr-helpers.c:
2993 Added modest_account_mgr_get_display_name(),
2994 modest_server_account_get_username(),
2995 modest_server_account_set_username(),
2996 modest_server_account_set_password(),
2997 modest_server_account_get_hostname() functions so we do not need to
2998 use the conf API directly.
3000 * src/maemo/modest-main-window.c: (connect_signals):
3001 Actually connect ot the ModestAccountStore::request-password signal,
3002 so that we show the dialog when the password is requested by Tinymail,
3003 for isntance if it is empty.
3005 * src/modest-marshal.list:
3006 * src/modest-tny-account-store.c:
3007 (modest_tny_account_store_class_init), (get_password),
3008 (modest_tny_account_store_alert):
3009 * src/modest-tny-account-store.h:
3010 * src/modest-ui-actions.h:
3011 * src/modest-ui-actions.c:
3012 (modest_ui_actions_on_password_requested):
3013 Change the signal parameters, so it is obvious that we are providing
3014 the non human-readable server name, and receiving both the username
3015 and password, though changing of the username is not yet implemented.
3016 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3017 for the GNOME version.
3019 This should fix the projects.maemo.org bug NB#56209, though it does not
3020 work on Bora, because the gconf_client_get() for the password fails
3021 immediately after we save it with gconf_client_set().
3023 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3026 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3027 caused an undefined symbol error:
3028 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3030 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3032 * src/modest-tny-account-store.c:
3033 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3034 using a GError instead of a string message, so we can translate it in
3037 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3039 * src/maemo/modest-address-book.c:
3040 (modest_address_book_check_names):
3041 * src/maemo/modest-msg-view-window.c:
3042 (modest_msg_view_window_clipboard_owner_change):
3043 * src/modest-init.c: (modest_init_init_ui):
3044 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3045 (update_folders_cb), (modest_mail_operation_update_account):
3046 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3047 (modest_ui_actions_on_msg_attachment_clicked),
3048 (modest_ui_actions_on_msg_recpt_activated):
3049 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3050 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3051 (modest_msg_view_search_next):
3052 * src/widgets/modest-recpt-editor.c:
3053 (modest_recpt_editor_on_button_release_event),
3054 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3055 g_message(). At this point we should only be seeing interesting errors on
3056 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3058 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3060 (modest_wizard_dialog_force_title_update):
3061 * src/maemo/easysetup/modest-wizard-dialog.h:
3062 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3063 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3064 can update the title when appropriate. Otherwise the title is wrong if the
3065 pages are added after adding the notebook to the dialog.
3066 This must be a problem in HildonWizardDialog too.
3067 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3069 * src/maemo/easysetup/modest-easysetup-wizard.c:
3070 (create_subsequent_customsetup_pages),
3071 (create_subsequent_easysetup_pages):
3072 Call modest_wizard_dialog_force_title_update() so that the title is
3073 correct even with GTK+ < 2.10.
3074 This fixes projects.maemo.org bug NB#56145 .
3076 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3078 * src/maemo/modest-platform.c:
3079 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3080 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3083 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3085 * src/widgets/modest-window.h:
3086 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3087 and modest_window_save_state(), which invokes it.
3089 * src/widgets/modest-window-mgr.h:
3090 * src/widgets/modest-window-mgr.c:
3091 Added modest_window_mgr_save_state_for_all_windows(), which calls
3092 the save_state vfunc on all registered windows, if implemented.
3094 * src/gnome/modest-msg-edit-window.c:
3095 * src/gnome/modest-msg-view-window.c:
3096 * src/maemo/modest-msg-edit-window.c:
3097 * src/maemo/modest-msg-view-window.c:
3098 * src/maemo/modest-main-window.c:
3099 Specify the existing save_settings functions as implementations of
3100 ModestWindow::save_state_func().
3102 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3103 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3104 enabling hibernation, for instance.
3106 We may need to do the same thing for restoring settings.
3109 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3111 * src/widgets/modest-window-mgr.c:
3112 * src/widgets/modest-window-mgr.h:
3113 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3114 modest_window_mgr_get_hibernation_is_prevented().
3116 * src/maemo/modest-main-window.c:
3117 (on_hildon_program_is_topmost_notify): Prevent hibernation
3118 (possible when the application goes to the background in the WM),
3119 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3121 * src/maemo/easysetup/modest-easysetup-wizard.c:
3122 (modest_easysetup_wizard_dialog_init):
3123 * src/maemo/modest-account-settings-dialog.c:
3124 (modest_account_settings_dialog_init):
3125 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3126 (modest_connection_specific_smtp_edit_window_init):
3127 * src/maemo/modest-connection-specific-smtp-window.c:
3128 (modest_connection_specific_smtp_window_init):
3129 * src/maemo/modest-signature-editor-dialog.c:
3130 (modest_signature_editor_dialog_init):
3131 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3132 prevent hibernation while any of these account settings dialogs are open.
3134 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3136 * src/maemo/Makefile.am:
3137 * src/maemo/modest-osso-state-saving.c:
3138 * src/maemo/modest-osso-state-saving.h: Added
3139 modest_osso_load_state() and modest_osso_save_state() though they do
3140 nothing now. They should iterate through all the open windows and load/save
3142 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3143 save state when closing.
3145 * src/maemo/modest-main-window.c:
3146 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3147 Add a notification handler for the HildonProgram::is-topmost property,
3148 so we can allow hibernation when the application goes into the background.
3149 But we still need to detect when the accounts setup windows are open so
3150 we can stop hibernation when they are open.
3151 To do this, I also added the main window the HildonProgram. This might have
3152 other side-effects/benefits, and should maybe be done for other windows.
3154 * src/maemo/modest-osso-autosave-callbacks.h:
3155 * src/maemo/modest-osso-autosave-callbacks.c:
3156 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3157 though it does not do anything yet, and we might never need this to do
3158 anything. For instance, we already save drafts.
3160 * src/maemo/modest-platform.c: (modest_platform_init):
3161 Specify the libosso auto-save callback.
3163 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3165 * src/maemo/modest-platform.c:
3166 (modest_platform_set_update_interval):
3167 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3168 aparently stays valid between application instances, so we can use this
3169 to remove and reset it later. According to a maemo-developers email from
3172 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3174 * configure.ac: Depend on libalarm for Maemo.
3176 * src/dbus_api/modest-dbus-api.h:
3177 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3178 (on_send_receive), (modest_dbus_req_handler):
3179 Handle a SEND_RECEIVE D-Bus method.
3181 * libmodest-dbus-client/libmodest-dbus-client.c:
3182 (libmodest_dbus_client_send_and_receive):
3183 * libmodest-dbus-client/libmodest-dbus-client.h:
3184 Add C convenience functions for calling the new D-Bus method.
3186 * src/modest-platform.h:
3187 * src/gnome/modest-platform.c:
3188 * src/maemo/modest-platform.c:
3189 Added modest_platform_set_update_interval(), which uses the
3190 alarmd API on Maemo.
3191 (modest_platform_init),
3192 Call modest_platform_set_update_interval(), using a hard-coded
3193 interval for now (until the global settings dialog is implemented),
3194 though I am not sure that this makes sense yet.
3196 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3198 * src/dbus_api/modest-dbus-callbacks.c:
3199 (modest_osso_cb_hw_state_handler):
3200 * src/dbus_api/modest-dbus-callbacks.h:
3201 * src/maemo/modest-platform.c: (modest_platform_init):
3202 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3203 in case this has some effect on the ability for Maemo to ping the
3206 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3208 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3209 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3210 warning. It is probably a logic error, but I need to fix the build.
3212 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3214 * src/modest-account-mgr.h:
3215 * src/modest-account-mgr.c:
3216 (modest_account_mgr_account_names): Add a gboolean enabled_only
3217 parameter, so we can get lists of onlt the enabled accounts.
3219 (modest_account_mgr_add_account),,
3220 (modest_account_mgr_account_with_display_name_exists):
3221 * src/maemo/modest-msg-edit-window.c: (get_transports):
3222 * src/modest-account-mgr-helpers.c:
3223 (modest_account_mgr_set_first_account_as_default):
3224 * src/modest-init.c: (init_default_account_maybe):
3225 * src/modest-tny-account-store.c: (get_accounts):
3226 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3227 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3228 * tests/check_account-mgr.c: (START_TEST):
3229 Provide the extra parameter, as appropriate.
3231 * src/widgets/modest-account-view.c: (update_account_view):
3232 Do not show disabled accounts (meaning that there is no way to
3233 enable/disable accounts in the UI (the feature is not in our UI
3234 specification), so we can use this internally only to mark unfinished
3235 or temporary account data.
3237 * src/maemo/easysetup/modest-easysetup-wizard.c:
3238 (create_account): Add boolean enable parameter, so we can specify FALSE
3239 to create the temporary account.
3240 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3241 (on_before_next): When finishing, when there is a temporary account, just
3243 Also, use a timeout to delay the showing of the dialog until gconf is likely
3244 to return correct information, due to a maemo gconf bug that is fixed in
3245 osso 1.1, but not yet in Bora.
3246 However, the dialog stays on screen after it is destroyed.
3248 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3249 for invalid data when cancelling. Use a hildon note instead of a dialog
3250 to complain about invalid data. Do not show the account-saved note if the
3251 account is disabled (a temporary account that will not really be saved for use
3254 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3256 * src/modest-account-mgr-helpers.h:
3257 * src/modest-account-mgr-helpers.c:
3258 Added modest_account_mgr_unset_default_account(),
3259 Added modest_account_mgr_set_first_account_as_default().
3261 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3262 If it was the default account, unset the default account name.
3264 * src/maemo/modest-account-view-window.c:
3265 (on_delete_button_clicked): If it was the default account,
3266 set the first remaining account as the default instead.
3268 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3269 a NULL account or a NULL default account, to prevent a crash. This should
3270 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3273 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3275 * src/widgets/modest-recpt-editor.c:
3276 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3277 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3278 TODO comment for this. This fixes the build.
3280 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3281 be the best place for it. This will in future update all auto-update accounts,
3282 rather than just the current/default account, when that gconf key exists.
3283 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3284 if there are no accounts, before calling do_send_receive().
3285 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3287 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3288 * src/maemo/modest-main-window-ui.h:
3289 * src/maemo/modest-main-window.c: (on_connection_changed),
3290 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3291 directly, becaue the signal handler does more.
3293 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3295 * src/modest-account-mgr-helpers.c:
3296 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3297 for the case that the account does not exist.
3299 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3300 (equivalent to the modest account name) rather than the tinymail account name
3301 (equivalent to the modest account title - human readable) to get the account data.
3302 Check for null account data to prevent the crash, and add a TODO comment saying that
3303 this needs fixing because it is using the server account name instead of the account name.
3305 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3307 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3308 * src/maemo/modest-account-settings-dialog.c: (show_error),
3310 Use hildon_note_new_information() for informative and error messages,
3311 which seems to be expected for Maemo applications (no documentation that I know of
3312 says this). I am surprised that there is no distinction between info and error
3315 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3317 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3318 it is easy to find where this is used.
3320 * src/maemo/easysetup/modest-easysetup-wizard.c:
3321 (create_page_welcome), (create_page_account_details),
3322 (create_page_user_details), (create_page_complete_easysetup),
3323 (create_page_custom_incoming), (create_page_custom_outgoing),
3324 (create_page_complete_custom):
3325 * src/maemo/modest-account-settings-dialog.c:
3326 (create_page_account_details), (create_page_user_details),
3327 (create_page_incoming), (create_page_outgoing):
3328 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3329 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3330 (modest_connection_specific_smtp_edit_window_init):
3331 * src/maemo/modest-connection-specific-smtp-window.c:
3332 (modest_connection_specific_smtp_window_init):
3333 * src/maemo/modest-signature-editor-dialog.c:
3334 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3335 and scrolling policy as per the Email Application Layout Guide, if I have
3338 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3340 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3341 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3342 which were empty, because these vfuncs have been removed from TnyAccountStore.
3343 This fixes the build.
3345 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3347 * src/maemo/modest-main-window.c:
3348 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3349 showing/hiding it. Added TODO because it probably should not be NULL.
3350 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3351 because unnecessary g_warnings() make degugging difficult.
3353 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3355 * src/maemo/modest-msg-edit-window.c:
3356 (modest_msg_edit_window_select_color),
3357 (modest_msg_edit_window_select_background_color): 2 const corrections and
3358 moving 2 #endifs before closing brackets, to fix the build.
3360 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3362 * src/maemo/easysetup/modest-easysetup-wizard.h:
3363 * src/maemo/easysetup/modest-easysetup-wizard.c:
3364 (modest_easysetup_wizard_dialog_finalize),
3365 (on_button_edit_advanced_settings), (create_page_complete_custom),
3366 (on_response), (create_account):
3367 Implement the Advanced Settings edit button, by saving the account information,
3368 for the Advanded Settings dialog to use directly from gconf, and removing it
3369 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3370 Bug #5533 in the projects.maemo.org bugzilla.
3372 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3374 * src/maemo/modest-msg-view-window.c:
3375 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3376 when opening a message window.
3378 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3380 * src/maemo/easysetup/modest-easysetup-wizard.c:
3381 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3384 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3385 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3386 gconf settings. I probably added more checks than necessary, but that is safer.
3388 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3389 variable to fix the build, but this seems to be used when it is still NULL.
3391 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3393 * src/modest-platform.h:
3394 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3395 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3396 * src/modest-main.c: Implement this function so we can avoid using
3397 maemo-specific API from cross-platform code.
3399 * src/modest-tny-account-store.c:
3400 (get_smtp_specific_transport_account_for_open_connection):
3401 * src/modest-ui-actions.c: (check_for_connection),
3402 (modest_ui_actions_on_item_not_found):
3403 Use modest_platform_connect_and_wait() and put #idefs around other
3404 maemo-specific code, because only maemo currently has a way to
3405 identify connection names.
3407 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3409 * src/modest-tny-account-store.h:
3410 * src/modest-tny-account-store.c:
3411 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3412 the connection-specific SMTP server settings in the configuration.
3414 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3416 * src/maemo/modest-main-window.c: (on_connection_changed),
3418 * src/modest-main.c: (main), (start_ui), (send_mail):
3419 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3420 that is what is intended.
3422 * src/modest-ui-actions.c: (action_send), (action_receive),
3423 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3424 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3425 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3426 SMTP server is used when it is specified.
3428 (modest_ui_actions_on_send_receive):
3429 Check that a connection is open before proceeding.
3430 Receive and then send, instead of vice-versa, as per the specification.
3432 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3434 * src/modest-mail-operation.c:
3435 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3436 though I guess it should be something other than NULL.
3438 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3440 * src/maemo/easysetup/modest-easysetup-wizard.c:
3441 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3442 combo twice, to avoid an g_warning and to make it visible again.
3443 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3444 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3445 (already intended) dereference when detaching, because we then recreate the menu.
3446 But I am not sure why the warning was happening, and it is possible that this is a memory
3449 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3451 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3452 and uri_parse_mailto() utility functions.
3453 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3455 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3457 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3459 * src/dbus_api/modest-dbus-api.h:
3460 * src/dbus_api/modest-dbus-callbacks.c:
3461 Use an idle callback to execute the modest code in the application's own thread.
3462 Remove the helloworld example method.
3463 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3464 parsed, and the open-message method is not implemented because this is not yet implemented in
3466 * libmodest-dbus-client/libmodest-dbus-client.c:
3467 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3468 (libmodest_dbus_client_open_message):
3469 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3471 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3472 body without crashing.
3474 * tests/dbus_api/Makefile.am:
3475 * tests/dbus_api/test_mail_to.c:
3476 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3478 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3480 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3481 Added file to fix the build. Sorry.
3483 * src/dbus_api/Makefile.am:
3484 * src/dbus_api/modest-dbus-api.h:
3485 * src/dbus_api/modest-dbus-callbacks.h:
3486 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3487 (modest_dbus_req_handler):
3488 Put constants in a separate header so it can be reused by the
3489 client library, without duplication
3491 * libmodest-dbus-client/Makefile.am:
3492 * libmodest-dbus-client/libmodest-dbus-client.c:
3493 (libmodest_dbus_client_call_helloworld),
3494 (libmodfest_dbus_client_send_mail),
3495 (libmodfest_dbus_client_mailto),
3496 (libmodfest_dbus_client_open_message):
3497 * libmodest-dbus-client/libmodest-dbus-client.h:
3498 (Partly) Implement a send_mail D-Bus method.
3500 * tests/dbus_api/Makefile.am:
3501 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3502 the send_email D-Bus method.
3504 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3508 * libmodest-dbus-client/Makefile.am:
3509 * libmodest-dbus-client/libmodest-dbus-client.c:
3510 * libmodest-dbus-client/libmodest-dbus-client.h:
3511 * tests/dbus_api/Makefile.am:
3512 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3513 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3515 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3517 * src/maemo/easysetup/modest-easysetup-wizard.c:
3518 (create_page_account_details):
3519 * src/maemo/modest-account-settings-dialog.c:
3520 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3521 widgets, because this might not be the default in future versions of the Maemo GTK+.
3522 However, I can not not get capitalization to work even in a simple test case.
3524 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3526 * src/maemo/easysetup/modest-easysetup-wizard.c:
3527 (create_page_custom_incoming), (create_page_custom_outgoing):
3528 * src/maemo/modest-account-settings-dialog.c:
3529 (create_page_account_details), (create_page_incoming),
3530 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3531 instead of using gtk_check_button_with_label(), so they are aligned like the other
3532 widgets, as per the UI spec.
3534 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3536 * src/maemo/easysetup/modest-easysetup-wizard.c:
3537 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3538 * src/widgets/modest-validating-entry.c:
3539 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3540 Modest prefix instead of an EasySetup prefix.
3542 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3544 * src/widgets/modest-validating-entry.h:
3545 * src/widgets/modest-validating-entry.c: (on_insert_text),
3546 Added easysetup_validating_entry_set_max_func(), used to set a callback
3547 to call when the max number of characters is reached. GtkEntry has a max-length
3548 already but is silent about it.
3550 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3551 (create_page_account_details), (create_page_user_details),
3553 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3554 (create_page_account_details), (create_page_user_details),
3555 (create_page_outgoing):
3556 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3557 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3558 the UI spec, when the user tries to enter more than the max number of characters.
3560 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3562 * src/maemo/easysetup/modest-easysetup-wizard.c:
3563 (create_page_user_details), (create_page_custom_incoming),
3564 (create_page_custom_outgoing):
3565 * src/maemo/modest-account-settings-dialog.c:
3566 (create_page_user_details), (create_page_incoming),
3567 (create_page_outgoing):
3568 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3569 (modest_connection_specific_smtp_edit_window_init):
3570 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3571 not appropriate. Bad Maemo-specific defaults!.
3573 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3575 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3576 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3577 (modest_signature_editor_dialog_set_settings):
3578 Disable the label and textview when the checkbox is disabled, and use the
3579 specified (UI spec) default signature text.
3581 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3583 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3584 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3586 * src/modest-defs.h:
3587 * src/modest-account-mgr-helpers.h:
3588 * src/modest-account-mgr-helpers.c:
3589 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3591 * src/maemo/Makefile.am:
3592 * src/maemo/modest-signature-editor-dialog.c:
3593 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3596 * src/maemo/modest-account-settings-dialog.h:
3597 * src/maemo/modest-account-settings-dialog.c:
3598 (modest_account_settings_dialog_finalize), (on_button_signature),
3599 (save_configuration): Use the new dialog when the Edit button is pressed, and
3600 save the changes if necessary, as per the UI spec.
3602 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3604 * src/maemo/Makefile.am:
3605 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3606 based on maemo-develoers email from Dirk.
3608 * src/maemo/easysetup/modest-easysetup-wizard.c:
3609 (create_page_welcome), (create_page_account_details),
3610 (create_page_user_details), (create_page_complete_easysetup),
3611 (create_page_custom_incoming), (create_page_custom_outgoing),
3612 (create_page_complete_custom),
3613 (modest_easysetup_wizard_dialog_init):
3614 * src/maemo/modest-account-settings-dialog.c:
3615 (create_page_account_details), (create_page_user_details),
3616 (create_page_incoming), (create_page_outgoing),
3617 (modest_account_settings_dialog_init):
3618 * src/maemo/modest-connection-specific-smtp-window.c:
3619 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3621 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3623 * src/maemo/easysetup/modest-easysetup-wizard.c:
3624 (create_page_account_details), (create_page_custom_outgoing),
3625 (create_page_complete_custom):
3626 * src/maemo/modest-account-settings-dialog.c:
3627 (create_page_user_details), (create_page_incoming),
3628 (create_page_outgoing):
3629 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3630 (modest_connection_specific_smtp_edit_window_init):
3631 Use the correct (UI spec) port min/max, and use horizontal separators,
3634 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3636 * src/maemo/easysetup/modest-easysetup-wizard.c:
3637 (set_default_custom_servernames):
3638 * src/maemo/modest-account-settings-dialog.c:
3639 (create_page_incoming), (on_combo_outgoing_security_changed),
3640 (on_combo_incoming_security_changed), (create_page_outgoing),
3641 (modest_account_settings_dialog_set_account_name),
3642 (save_configuration):
3643 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3644 (on_combo_security_changed),
3645 (modest_connection_specific_smtp_edit_window_init),
3646 (modest_connection_specific_smtp_edit_window_set_connection),
3647 (modest_connection_specific_smtp_edit_window_get_settings):
3648 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3651 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3654 * src/maemo/easysetup/modest-easysetup-wizard.c:
3655 (create_page_custom_outgoing), (create_page_complete_custom):
3656 * src/maemo/modest-account-settings-dialog.c:
3657 (create_page_user_details), (create_page_outgoing):
3658 * src/maemo/modest-account-view-window.c: (button_box_new):
3659 Use changed logical IDs as per the most recent UI spec:
3660 mcen_bd_emailsetup_edit -> mcen_bd_edit
3661 mcen_bd_emailsetup_delete -> mcen_bd_delete
3662 mcen_bd_emailsetup_close -> mcen_bd_close
3664 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3668 * src/dbus_api/Makefile.am:
3669 * src/dbus_api/modest-dbus-callbacks.c:
3670 * src/dbus_api/modest-dbus-callbacks.h:
3671 * src/maemo/modest-platform.c: (modest_platform_init):
3672 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3674 * tests/Makefile.am:
3675 * tests/dbus_api/Makefile.am:
3676 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3678 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3680 * src/maemo/modest-account-settings-dialog.c:
3681 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3682 Removed unnecessary includes.
3684 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3686 * src/maemo/easysetup/modest-easysetup-wizard.c:
3687 * src/maemo/modest-account-settings-dialog.c:
3688 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3689 * src/widgets/Makefile.am:
3690 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3691 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3692 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3693 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3694 * src/widgets/modest-secureauth-combo-box.c:
3695 * src/widgets/modest-secureauth-combo-box.h:
3696 * src/widgets/modest-serversecurity-combo-box.c:
3697 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3698 made the GObject names more consistent with the rest of the Modest code.
3700 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3702 * src/maemo/easysetup/Makefile.am:
3703 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3704 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3705 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3706 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3707 * src/maemo/easysetup/modest-easysetup-wizard.c:
3708 * src/maemo/easysetup/modest-validating-entry.c:
3709 * src/maemo/easysetup/modest-validating-entry.h:
3710 * src/maemo/modest-account-settings-dialog.c:
3711 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3712 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3713 widgets/ because they are used outside of easysetup too. After checking in,
3714 svn will allow me to rename them too.
3716 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3718 * src/gnome/modest-msg-edit-window.c:
3719 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3720 linker error, to fix the build on the GNOME platform.
3721 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3722 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3723 ifdefed out to avoid a warning.
3725 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3727 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3728 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3729 some alternative for GTK+ 2.6.
3731 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3733 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3735 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3736 specified for EmailAccountsDialog in UI spec.
3738 * src/maemo/easysetup/modest-easysetup-wizard.c:
3739 * src/maemo/easysetup/modest-easysetup-wizard.h:
3740 * src/maemo/modest-account-settings-dialog.c:
3741 * src/maemo/modest-account-settings-dialog.h:
3742 Reuse a member window widget for the connection-specific SMTP server accounts,
3743 so we can tell it to create/save the accounts only if we actually save changes.
3745 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3746 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3747 (modest_connection_specific_smtp_edit_window_get_settings):
3748 Return a struct instance for temporarily remembering the entered data.
3750 * src/maemo/modest-connection-specific-smtp-window.h:
3751 * src/maemo/modest-connection-specific-smtp-window.c:
3752 (modest_connection_specific_smtp_window_finalize),
3753 (modest_connection_specific_smtp_window_fill_with_connections),
3755 (modest_connection_specific_smtp_window_save_server_accounts),
3756 (update_model_server_names): Do not actually save data until asked,
3757 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3759 (on_selection_changed),
3760 (modest_connection_specific_smtp_window_init): Disable the edit
3761 button when nothing is selected.
3763 * src/modest-account-mgr-helpers.c:
3764 * src/modest-account-mgr-helpers.h:
3765 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3768 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3770 * src/modest-account-mgr-helpers.h:
3771 * src/modest-account-mgr-helpers.c:
3772 (modest_account_mgr_get_unused_account_name),
3773 (modest_account_mgr_get_unused_account_display_name): Added these
3774 utility functions, to avoid code duplication.
3776 * src/maemo/easysetup/modest-easysetup-wizard.c:
3777 (create_page_account_details), (create_account):
3778 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3779 (on_combo_security_changed),
3780 (modest_connection_specific_smtp_edit_window_init),
3781 (modest_connection_specific_smtp_edit_window_save_settings):
3782 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3783 * src/maemo/modest-connection-specific-smtp-window.c:
3784 (modest_connection_specific_smtp_window_finalize),
3785 (modest_connection_specific_smtp_window_fill_with_connections),
3786 (on_button_edit), (modest_connection_specific_smtp_window_init):
3787 * src/maemo/modest-connection-specific-smtp-window.h:
3788 Implementing saving of connection-specific server accounts.
3790 But I need to refactor this so we can save the data for each
3791 possible connection-specific account and only actually create the server accounts
3792 when the easysetup finished, or the OK button is pressed on the account settings
3795 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3797 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3798 (on_combo_security_changed):
3799 (modest_connection_specific_smtp_edit_window_init):
3800 Auto-fill the port number as in the account settings.
3802 (modest_connection_specific_smtp_edit_window_set_connection):
3803 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3804 * src/maemo/modest-connection-specific-smtp-window.c:
3805 (fill_with_connections), (on_button_edit),
3806 (modest_connection_specific_smtp_window_init):
3807 Turn the edit window into a dialog to simplify the code, and
3808 set a WM hint as in a GtkDialog, because only a popup can be on top of
3809 another window in Maemo, and popups usually have no WM decoration.
3811 * src/modest-defs.h:
3812 * src/modest-account-mgr-helpers.c:
3813 (modest_account_mgr_set_connection_specific_smtp),
3814 (modest_account_mgr_remove_connection_specific_smtp),
3815 (modest_account_mgr_get_connection_specific_smtp):
3816 * src/modest-account-mgr-helpers.h: Some functions to write the
3817 connection-specific SMTP server information. Not yet used.
3820 * src/widgets/modest-folder-view.c: (text_cell_data):
3821 Fix a warning about an uninitialized variable.
3822 (on_configuration_key_changed): Put an #ifdef around the use
3823 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3825 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3827 * src/maemo/modest-account-settings-dialog.h:
3828 * src/maemo/modest-account-settings-dialog.c:
3829 Added connect_for_modified() utility function to mark the new modified boolean.
3831 (create_page_account_details), (create_page_user_details),
3832 (create_page_incoming), (create_page_outgoing), (on_response),
3833 (modest_account_settings_dialog_init),
3834 (modest_account_settings_dialog_set_account_name):
3835 Only warn about unsaved changes when there are actually unsaved changes.
3837 * src/modest-account-mgr-helpers.c:
3838 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3839 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3840 to get the data from there in future.
3842 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3844 * src/modest-defs.h:
3846 * src/modest-account-mgr-helpers.h:
3847 * src/modest-account-mgr-helpers.c:
3848 Store the security account setting in a single conf key instead of using
3849 the options list, so that the list is left for just the to-be-removed camel hack,
3850 and because gconf_client_set_list() is failing for some reason.
3852 * src/modest-account-mgr.c:
3853 (modest_account_mgr_add_server_account):
3854 * src/maemo/modest-account-settings-dialog.c:
3855 (modest_account_settings_dialog_set_account_name),
3856 (save_configuration): Use the renamed functions.
3859 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3861 * src/widgets/Makefile.am:
3862 * src/widgets/modest-limit-retrieve-combo-box.c:
3863 * src/widgets/modest-limit-retrieve-combo-box.h:
3864 * src/widgets/modest-retrieve-combo-box.c:
3865 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3866 the account settings dialog.
3868 * src/modest-defs.h:
3869 * src/modest-account-mgr-helpers.h:
3870 * src/modest-account-mgr-helpers.c:
3871 (modest_server_account_get_option_secure_auth),
3872 (modest_server_account_set_option_secure_auth):
3873 * src/modest-account-mgr.c:
3874 (modest_account_mgr_add_server_account):
3875 Use the existing AUTH_MECH conf key for the secure-auth setting,
3876 instead of putting it in the list options, because this was actually used already.
3878 * src/maemo/modest-account-settings-dialog.c:
3879 (create_page_account_details),
3880 (modest_account_settings_dialog_set_account_name),
3881 (save_configuration):
3882 * src/maemo/modest-account-settings-dialog.h:
3883 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3884 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3886 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3888 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3889 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3890 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3892 * src/modest-defs.h:
3893 * src/maemo/modest-account-settings-dialog.c:
3894 (create_page_incoming), (on_combo_outgoing_security_changed),
3895 (on_combo_incoming_security_changed), (create_page_outgoing),
3896 (modest_account_settings_dialog_set_account_name),
3897 (save_configuration): Load/Save the port number, and change it when the
3898 security combo changes, to suitable defaults.
3900 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3902 * src/modest-account-mgr.c:
3903 (modest_account_mgr_add_server_account): Set the security and secure-auth
3904 options, and add a comment saying that the other camel-specific options should be
3907 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3909 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3911 * src/modest-tny-account-store.c: (account_list_free),
3912 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3913 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3916 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3918 * src/modest-protocol-info.c:
3919 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3920 is required by our UI spec. Maybe something in our implementation will use this eventually.
3921 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3922 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3923 instead of the previous 0 placeholder.
3925 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3926 secure-auth settings.
3927 * src/modest-account-mgr-helpers.h:
3928 * src/modest-account-mgr-helpers.c:
3929 (modest_server_account_data_get_option_secure_auth),
3930 (modest_server_account_set_option_secure_auth),
3931 (modest_server_account_data_get_option_security),
3932 (modest_server_account_set_option_security): Added this API for getting and setting the security
3933 and secure-auth settings.
3935 * src/maemo/modest-account-settings-dialog.h:
3936 * src/maemo/modest-account-settings-dialog.c:
3937 (modest_account_settings_dialog_finalize), (check_data),
3938 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3939 about changing titles.
3940 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3941 (save_configuration): Save the security and secure-auth settings.
3943 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3944 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3946 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3948 * src/modest-defs.h:
3949 * src/modest-account-mgr.c:
3950 (modest_account_mgr_add_server_account):
3951 Added and used defines for the options key and value pair strings,
3952 that are used so far, though they do not seem to correspond to anything in our
3953 UI specs or ModestProtocol enum.
3955 * src/modest-account-mgr-helpers.h:
3956 * src/modest-account-mgr-helpers.c:
3957 (compare_option_strings_for_name),
3958 (modest_server_account_data_get_option_value),
3959 (modest_server_account_data_get_option_bool),
3960 (modest_account_mgr_get_server_account_option):
3961 Added helper functions for parsing the options GSList.
3963 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3965 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3966 display name is based on the supplied account name.
3967 * src/modest-account-mgr.c:
3968 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3969 with an inefficient, but good-enough, implementation.
3971 * src/maemo/easysetup/modest-easysetup-wizard.c:
3972 (create_page_account_details), (on_before_next), (create_account):
3973 Check for existing display names rather than (non-user-visible) account names, and just
3974 create and set a unique account name at the end.
3976 * src/maemo/modest-account-settings-dialog.c:
3977 (modest_account_settings_dialog_init),
3978 (modest_account_settings_dialog_set_account_name),
3979 (create_page_incoming): Show the display name, instead of the account name.
3980 (on_response): Do some (not all) extra checks, as in the UI spec.
3981 (save_configuration): Save the display name if it was changed.
3983 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3985 * po/en_GB.po: Added needed logical ID and translation.
3986 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3987 (init_view): Made the is-default column clicking work.
3989 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3992 * src/maemo/easysetup/Makefile.am:
3993 * src/maemo/easysetup/modest-easysetup-wizard.c:
3994 (modest_easysetup_wizard_dialog_init):
3995 * src/maemo/easysetup/provider-data-test.keyfile:
3996 * src/maemo/easysetup/provider-data.keyfile:
3997 Moved the provider data file to the new modest-providers-data package and used it from there.
3999 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4001 * src/modest-local-folder-info.c:
4002 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4003 N_() was already used on the static strings, but this just marks it for translation without
4004 using the translation.
4006 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4008 * src/maemo/modest-account-settings-dialog.c:
4009 (create_page_incoming),
4010 (modest_account_settings_dialog_set_account_name):
4011 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4012 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4013 I will do this if nobody else gets there first.
4015 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4017 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4018 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4019 save the security stuff.
4021 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4023 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4024 Set the email address and user fullname, which I now see must be
4027 * src/maemo/modest-account-settings-dialog.h:
4028 * src/maemo/modest-account-settings-dialog.c:
4030 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4031 leave-on-server and authentication.
4032 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4035 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4038 * src/maemo/modest-account-settings-dialog.c:
4039 * src/maemo/modest-account-settings-dialog.h:
4040 Most (but not all) of the widgets are now present as specified by the UI spec.
4041 No changes are yet saved, and some details are not properly shown yet.
4043 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4045 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4047 * src/maemo/Makefile.am:
4048 * src/maemo/modest-account-settings-dialog.c:
4049 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4050 an existing account. Doesn't do much yet.
4052 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4053 Open the accounts settings dialog when Edit is clicked.
4055 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4057 * src/maemo/easysetup/Makefile.am:
4058 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4060 * src/maemo/easysetup/modest-easysetup-wizard.c:
4061 (modest_easysetup_wizard_dialog_init):
4062 Try to get the source directory from the build system,
4063 instead of hard-coding "./" into the source code, when opening our local
4064 copies of the configuration files.
4065 But this still fails when opening the wizard from the Accounts window,
4066 maybe because the working directory seems to change at runtime.
4067 So the wizard will fail the second time unless you copy the files into their
4068 proper locations - see the stdout warnings for the paths.
4070 (create_page_account_details),(on_before_next):
4071 Check for existing non-server accounts instead of server accounts,
4072 so the default account name is useful again, and to prevent trying to
4075 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4076 Show the wizard when New is clicked.
4078 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4079 (init_view): Show the column headers, and show the columns that are
4080 specified in the UI specs. However, something in Maemo's GTK+ prevents
4081 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4082 change the default account. This is despite unsetting the special properties.
4084 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4086 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4087 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4088 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4089 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4090 to make that clearer.
4091 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4093 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4095 * src/maemo/modest-account-view-window.c:
4096 (modest_account_view_window_init),
4097 (modest_account_view_window_new):
4098 Use the same buttons as specified in the
4099 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4100 the existing widgets, which never had a chance of working.
4101 Put the ModestAccountView treeview in a scrolled window.
4102 Do not repeat the initialization in both _init() and _new().
4104 * src/widgets/modest-account-view.c: (update_account_view):
4105 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4106 this widget and window shows no accounts.
4108 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4110 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4112 * src/maemo/easysetup/modest-easysetup-wizard.c:
4113 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4114 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4115 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4118 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4119 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4120 accounts exist yet, as in the UI spec.
4122 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4124 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4126 * src/maemo/Makefile.am:
4127 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4128 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4129 New window for editing connection-specific smtp details.
4130 Not fully implemented.
4132 * src/maemo/modest-connection-specific-smtp-window.c:
4133 (modest_connection_specific_smtp_window_finalize) :
4134 unref the tree model.
4135 (on_button_edit): Show the edit window.
4137 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4139 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4142 * src/maemo/Makefile.am:
4143 * src/maemo/modest-connection-specific-smtp-window.c:
4144 * src/maemo/modest-connection-specific-smtp-window.h:
4145 New window for showing the list of connections, for connection-specific
4146 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4147 * src/maemo/easysetup/modest-easysetup-wizard.c:
4148 (create_page_custom_outgoing): Show the new window when the button is clicked.
4150 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4152 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4153 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4154 * src/maemo/modest-msg-edit-window.c:
4155 (modest_msg_edit_window_insert_image):
4156 * src/modest-conf.c: (modest_conf_key_escape):
4157 * src/modest-mail-operation.c:
4158 (modest_mail_operation_send_new_mail):
4159 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4160 (modest_ui_actions_on_new_account):
4161 * src/widgets/modest-attachment-view.c: (update_filename_request):
4162 * src/widgets/modest-mail-header-view.c:
4163 Corrected warnings that were breaking the build, by commenting out unused variables,
4164 and a function, and by including a header.
4166 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4168 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4169 so we can #ifdef around platform-specific code when necessary.
4170 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4171 to allow this to build for the GNOME platform too.
4173 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4175 * src/maemo/easysetup/modest-easysetup-wizard.c:
4176 Added util_increment_name() and used it in create_page_account_details()
4177 to make sure that the default account name is always a new name.
4179 (modest_easysetup_wizard_dialog_init),
4180 (set_default_custom_servernames): Some minor memory management fixes.
4182 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4186 * src/modest-runtime.c: (init_i18n): Restored the translation
4187 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4188 are defined in config.h, and the translations are installed.
4190 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4191 is defined for translation.
4193 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4195 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4197 * src/maemo/easysetup/modest-easysetup-wizard.c:
4198 (modest_easysetup_wizard_dialog_init):
4199 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4200 Use realistic paths (though they should use $prefix generically) to the
4201 mcc_mapping and provider-data.keyfile files which might work when they
4202 are installed by the future version of the operator-wizard package,
4203 and then fallback to paths in our source code, with an explanatory
4206 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4210 * src/maemo/Makefile.am:
4211 * src/maemo/easysetup/: Added files from the previously-exernal
4212 osso-modest-easysetup.
4213 * src/maemo/modest-main-window-ui.h:
4214 * src/modest-ui-actions.c:
4215 * src/modest-ui-actions.h:
4216 Added modest_ui_actions_on_new_account() as a signal handler for the
4217 New Account menu item. It shows the easysetup wizard.
4218 * po/en_GB.po: Added additional needed logical IDs and translations.