1 2007-06-27 Murray Cumming <murrayc@murrayc.com
3 * src/modest-tny-account.h:
4 * src/modest-tny-account.c:
5 Added modest_tny_account_get_mmc_account_name(), to set the memory
6 card name asynchronously for the given account and then notify.
7 (modest_tny_account_new_for_local_folders): Use this new function instead
8 of using hildon_file_system_info_async_new() directly.
10 * src/widgets/modest-folder-view.c: (text_cell_data):
11 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
12 gtk_tree_model_row_changed() when it is available.
14 This should fix projects.maemo.org bug NB#59301.
16 2007-06-27 Murray Cumming <murrayc@murrayc.com
18 * src/modest-mail-operation.c: (update_account_thread),
19 (get_msgs_full_thread): Fix typo failures in the revert
22 2007-06-27 Murray Cumming <murrayc@murrayc.com
24 * src/maemo/modest-maemo-global-settings-dialog.c:
25 (idle_select_default_focus):
26 * src/modest-mail-operation.c: (idle_notify_progress),
27 (idle_notify_progress_once), (set_last_updated_idle),
28 (update_account_thread), (get_msgs_full_thread):
29 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
30 * src/widgets/modest-header-view.c:
31 (idle_notify_headers_count_changed_destroy),
32 (idle_notify_headers_count_changed):
33 Reverted the additions of gdk_threads_enter/leave(), in case this
34 helps with a startup hang on the device.
36 2007-06-26 Armin Burgmeier <armin@openismus.com>
38 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
39 for supported secure authentication methods from server by
40 gtk_dialog_run(), saving CPU time and a potential race condition.
42 2007-06-26 Armin Burgmeier <armin@openismus.com>
44 * src/maemo/modest-maemo-utils.h:
45 * src/maemo/modest-maemo-utils.c: Added a
46 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
47 only error code to tell the calling code when the user canceled the
50 * src/maemo/modest-account-settings-dialog.h:
51 * src/maemo/modest-account-settings-dialog.c:
52 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
53 message if the retrieval of secure authentication methods was canceled
54 by the user. Perform the check before saving anything to configuration
55 to not end up with half-committed configuration changes, do not show
56 a "Saving to configuration failed" note when authentication methods
57 could not be retrieved.
59 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
62 2007-06-26 Murray Cumming <murrayc@murrayc.com>
64 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
65 Only return the first level of folders under accounts, because the
66 osso-global-search UI spec doesn't want the rest.
67 This fixed projects.maemo.org bug NB#61811.
69 2007-06-26 Murray Cumming <murrayc@murrayc.com>
71 * src/modest-tny-account-store.c:
72 * src/modest-tny-account-store.h:
73 Added modest_tny_account_is_memory_card_account().
74 * src/maemo/modest-main-window.c: (create_details_widget):
75 Show the same information items for the memory card as we show for the
76 local-folders, to fix projects.maemo.org bug NB#59307.
78 2007-06-26 Murray Cumming <murrayc@murrayc.com>
80 * src/modest-tny-account-store.c: (get_password):
81 Added some checks for NULL to maybe prevent crashes, though I think
82 it was Philip's last commit that actually prevented the crash here
83 when creating a first new account.
84 But the new account is still not usable (no messages are shown)
85 until a restart of the application.
87 2007-06-26 Murray Cumming <murrayc@murrayc.com>
89 * src/maemo/modest-maemo-global-settings-dialog.c:
90 (idle_select_default_focus):
91 * src/modest-mail-operation.c: (idle_notify_progress),
92 (idle_notify_progress_once), (idle_notify_update_account_queue),
93 (set_last_updated_idle), (update_account_thread),
94 (notify_get_msgs_full), (get_msgs_full_destroyer),
95 (get_msgs_full_thread):
96 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
97 * src/widgets/modest-header-view.c:
98 (idle_notify_headers_count_changed_destroy),
99 (idle_notify_headers_count_changed):
100 Use gdk_threads_enter() and gdk_threads_enter_leave() in
101 all idle handlers, because some other thread could be blocking
102 the GDK lock, so that it can do GUI stuff.
104 2007-06-26 Murray Cumming <murrayc@murrayc.com>
106 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
107 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
108 (on_idle_send_receive), (on_idle_open_default_inbox):
109 * src/maemo/modest-msg-edit-window.c:
110 (modest_msg_edit_window_attach_file_noninteractive):
111 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
112 to prevent a hang. I don't quite understand why these are necessary,
113 beause we should already be in the main loop. I guess something outside
114 of the main loop is taking the lock.
116 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
117 we are really using URIs, and use files that are more likely to exist.
119 2007-06-26 Murray Cumming <murrayc@murrayc.com>
121 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
122 necessary because configure.ac now defines different variables.
124 2007-06-26 Murray Cumming <murrayc@murrayc.com>
126 * libmodest-dbus-client/libmodest-dbus-client.c:
127 * libmodest-dbus-client/libmodest-dbus-client.h:
128 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
129 libmodest_dbus_client_compose_mail() is what things actually use.
131 * src/dbus_api/modest-dbus-api.h:
132 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
133 * tests/dbus_api/Makefile.am:
134 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
137 2007-06-26 Murray Cumming <murrayc@murrayc.com>
139 * src/modest-init.c: (modest_init_local_folders):
140 For memory-card (or other non local-folders) maildir accounts,
141 always create an Archive folder, so that there is somewhere to put
142 messages. This should be less confusing, because the user does not need
143 to guess that the need to create a folder.
145 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
147 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
148 Fixed icon size by using (50, 50) which is the same as defined by
151 2007-06-25 Armin Burgmeier <armin@openismus.com>
153 * src/widgets/modest-window-mgr.c:
155 * configure.ac: Correctly recognize hildon-notify presence and fixed
156 the build without it being installed.
158 2007-06-25 Murray Cumming <murrayc@murrayc.com>
160 * libmodest-dbus-client/libmodest-dbus-client.c:
161 (libmodest_dbus_client_search): Fix the build. Sorry.
162 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
163 (reply_forward_cb): Initialize variables to fix the build.
165 * src/modest-tny-account-store.c:
166 (modest_tny_account_store_get_tny_account_by): Fix the account URI
167 comparison (a silly typo) so that email search results can be opened
168 when there are more than one account.
170 2007-06-25 Murray Cumming <murrayc@murrayc.com>
172 * libmodest-dbus-client/libmodest-dbus-client.c:
173 (libmodest_dbus_client_search),
174 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
175 instead of 1 second, because the search gets folders and messages from
176 the server, which can take a long time. When it times out,
177 osso-global-search will report no results.
179 We need to specify whether we should search only cached information
180 (maybe with a user preference), and the osso-email-search-plugin
181 API should really be improved to allow that option, and to allow results
182 to be delivered asynchronously in batches.
184 2007-06-25 Murray Cumming <murrayc@murrayc.com>
186 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
187 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
188 GTK_ICON_SIZE_DIALOG is probably the wrong size.
190 2007-06-25 Murray Cumming <murrayc@murrayc.com>
192 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
193 that is an empty string. D-Bus seems to give us these instead of NULL.
195 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
197 * src/dbus_api/modest-dbus-callbacks.c:
198 * src/maemo/easysetup/modest-easysetup-wizard.h:
199 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
200 * src/maemo/modest-connection-specific-smtp-edit-window.c:
201 (modest_connection_specific_smtp_edit_window_init):
202 * src/maemo/modest-maemo-global-settings-dialog.c:
204 * src/maemo/modest-maemo-utils.c:
205 (modest_maemo_utils_setup_images_filechooser):
206 * src/maemo/modest-main-window.c: (create_details_widget):
207 * src/maemo/modest-msg-edit-window.c:
208 (modest_msg_edit_window_attach_file_noninteractive),
209 (modest_msg_edit_window_color_button_change),
210 (modest_msg_edit_window_set_zoom):
211 * src/modest-mail-operation.c: (update_account_thread):
212 * src/modest-tny-account-store.c:
213 * src/modest-tny-account.c:
214 * src/widgets/modest-global-settings-dialog.c:
215 * src/widgets/modest-window.h:
219 2007-06-25 Murray Cumming <murrayc@murrayc.com>
221 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
222 * src/modest-search.c: (modest_search_folder),
223 (modest_search_all_accounts): Actually search only in the specified folder,
224 doing a simple match on the folder ID.
225 * src/modest-search.h: Added a folder field to the ModestSearch struct,
226 and added some documentation.
228 2007-06-22 Armin Burgmeier <armin@openismus.com>
230 * src/maemo/modest-maemo-utils.h:
231 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
232 modest_maemo_utils_get_supported_secure_authentication_methods.
234 * src/maemo/easysetup/modest-easysetup-wizard.c:
235 * src/maemo/modest-account-settings-dialog.c: Show correct error if
236 one occured, not just "Server does not support secure authentication".
238 2007-06-22 Murray Cumming <murrayc@murrayc.com>
240 * src/modest-tny-account-store.c: (get_password):
241 Restored the call to tny_account_set_user() because Philip seems to have
242 stopped this from crashing (by not using the freed string). It still does
243 not work, but now we can test it.
245 2007-06-22 Murray Cumming <murrayc@murrayc.com>
247 * src/maemo/modest-msg-edit-window.c: (init_window):
248 Comment out use of an uninitialzed GtkScrolledWindow variable,
249 to fix the build and stop a crash. Yet again.
251 2007-06-22 Murray Cumming <murrayc@murrayc.com>
253 * src/modest-tny-account-store.c: (get_password):
254 Remove the call to tny_account_set_user() because this actually crashes.
255 As mentioned in the last commit, it is known to not work anyway.
257 2007-06-22 Murray Cumming <murrayc@murrayc.com>
259 * src/modest-tny-account-store.c: (get_password):
260 Use tny_account_set_username() to tell tinymail that the username might
261 have changed too. But tinymail ignores this: see projects.maemo.org
263 * src/modest-ui-actions.c:
264 (modest_ui_actions_on_password_requested): Remove the useless attempt to
265 reset the connection when changing the username, and improve the comments.
266 Save the changed username to gconf at least, so it is used when Modest is
269 2007-06-21 Murray Cumming <murrayc@murrayc.com>
271 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
272 Do not use a query, so that we get all folders, including for POP and
273 local-folders. They work as search criteria too.
274 This fixes projects.maemo.org bug NB#57740.
276 2007-06-21 Murray Cumming <murrayc@murrayc.com>
278 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
279 Comment out the use of hildon_notification_set_sound() because it is
280 not declared, to fix the build. Warnings are serious, people.
282 2007-06-21 Armin Burgmeier <armin@openismus.com>
284 * src/maemo/modest-maemo-utils.h:
285 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
286 modest_maemo_utils_get_supported_secure_authentication_methods()
287 to query authentication methods for a specific user. This should fix
288 projects.maemo.org bug NB#61369.
290 * src/maemo/easysetup/modest-easysetup-wizard.c:
291 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
294 2007-06-21 Murray Cumming <murrayc@murrayc.com>
296 * libmodest-dbus-client/libmodest-dbus-client.h:
297 * libmodest-dbus-client/libmodest-dbus-client.c:
298 (modest_dbus_message_iter_get_search_hit),
299 (libmodest_dbus_client_search):
300 Reorganised and commented this.
301 Removed modest_search_hit_free() from the public API because it
304 Added libmodest_dbus_client_get_folders() and
305 modest_folder_result_list_free().
307 * src/dbus_api/modest-dbus-api.h:
308 * src/dbus_api/modest-dbus-callbacks.c:
309 (modest_dbus_req_filter): Commented. Moved most code to
310 on_dbus_method_search() and added on_dbus_method_get_folders().
312 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
313 of the extra D-Bus handler.
315 * tests/dbus_api/Makefile.am:
316 * tests/dbus_api/test_get_folders.c: New test for
317 libmodest_dbus_client_get_folders(). This seems to return an empty list
318 at the moment. That could be the same error that causes the message list
319 to be empty sometimes.
320 This should help with projects.maemo.org bug NB#57740.
322 2007-06-21 Armin Burgmeier <armin@openismus.com>
324 * src/modest-mail-operation.c: Do not call
325 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
326 notify the operation's end after having set the status to CANCELED for
327 the operation queue to listen on. This fixes a deadlock when there
328 were mail operations in the queue during its finalization.
330 * src/modest-singletons.c: Reordered uninitialization of the account
331 manager to happen after the mail operation queue was uninitialized
332 because the mail operation's in the queue might still try to access
333 the account manager (see modest_mail_operation_notify_end()). This
334 fixes a potential crash when terminating the application.
336 2007-06-21 Murray Cumming <murrayc@murrayc.com>
338 * src/modest-search.c:
339 (search_mime_part_and_child_parts): Moved some code here so we
340 can search recursively in child folders.
341 (modest_search_folder): Search in the message as a mime part, instead
342 of just its child mime parts.
343 (read_chunk), (search_mime_part_ogs):
344 Check how many bytes were read, to prevent an endless loop.
345 Searching in message bodies now works. This finishes the fix for
346 projects.maemo.org bug NB#61007.
348 2007-06-20 Murray Cumming <murrayc@murrayc.com>
350 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
351 Add a g_warning when the item is not a folder.
353 * src/modest-ui-dimming-rules.c:
354 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
355 when selected item is not a folder (for instance, an account), because
356 the UI spec only talks about folders.
357 I am not sure what the UI spec wants, so this might not totally fix
358 projects.maemo.org bug NB#60794.
360 2007-06-20 Murray Cumming <murrayc@murrayc.com>
362 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
363 (load_from_file): Sort the list. The unsorted list would be more noticeable
364 in non-English locales.
366 * src/maemo/modest-msg-edit-window.c:
367 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
368 warning and fix the build.
370 * src/maemo/modest-progress-bar-widget.c:
371 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
372 avoid a g_warning, and probably to avoid a crash.
374 2007-06-20 Murray Cumming <murrayc@murrayc.com>
376 * src/modest-search.c: (modest_search_folder): Check for a GError
377 when calling tny_folder_get_headers(), to show that this is not the cause
380 2007-06-20 Murray Cumming <murrayc@murrayc.com>
382 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
383 Actually set the body query instead of the subject query.
385 * src/modest-search.c: (search_mime_part_ogs),
386 (search_mime_part_strcmp): Remove extra space from the text/* regex,
387 which would probably cause it to fail if we got this far.
389 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
390 to simplify the code.
391 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
392 be causing search-in-body to fail.
394 2007-06-20 Murray Cumming <murrayc@murrayc.com>
396 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
398 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
399 Better debug message when the folder cannot be found.
400 This should help with fixing projects.maemo.org bug #61287.
401 * src/modest-search.c: (add_hit): Do not leak the furl string.
403 2007-06-20 Murray Cumming <murrayc@murrayc.com>
405 * src/modest-ui-actions.c:
406 (modest_ui_actions_on_folder_selection_changed):
407 Do not special-case TNY_MERGE_FOLDER here, because
408 modest_tny_folder_get_account() already does that. This fixes
409 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
410 shown when the Outbox was selected).
412 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
414 * libmodest-dbus-client/libmodest-dbus-client.c:
415 (_dbus_iter_get_string_or_null): Initialize the string variable in
416 case this helps with Dirk's crash.
418 2007-06-19 Murray Cumming <murrayc@murrayc.com>
420 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
421 though it is not implemented yet (this function is maybe not even used),
422 to avoid breaking ABI in future.
423 * libmodest-dbus-client/libmodest-dbus-client.c:
424 (get_attachments_string): Moved some code into this generic function.
425 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
426 sends email. It is maybe not used.
427 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
428 (on_send_mail): Use attachments.
430 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
431 * src/maemo/modest-msg-edit-window.c:
432 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
433 a filename before using it, to fix projects.maemo.org bug NB#58233.
435 2007-06-19 Murray Cumming <murrayc@murrayc.com>
437 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
438 Initialize the continue_download variable to fix the build, and probably
439 to fix randome behaviour.
441 2007-06-18 Armin Burgmeier <armin@openismus.com>
443 * src/modest-tny-send-queue.h:
444 * src/modest-tny-send-queue.c: Keep track of the status of messages in
445 the queue so we can later show it in the UI. Replaced
446 modest_tny_send_queue_msg_is_being_sent() by
447 modest_tny_send_queue_get_msg_status().
449 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
451 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
452 gpointer. This probably was not harmful, but just to be sure.
454 2007-06-18 Murray Cumming <murrayc@murrayc.com>
456 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
457 Fix the build, but leave the function broken on Bora, because
458 hildon_uri_action_get_service() does not exist.
459 osso_uri_action_get_service() does not exist either, it seems.
461 2007-06-18 Murray Cumming <murrayc@murrayc.com>
463 * src/modest-tny-account.c:
464 (modest_tny_account_new_from_server_account):
465 Uncommented the url debug output again, because it is useful for
466 debugging, as I said in the comment.
468 2007-06-18 Murray Cumming <murrayc@murrayc.com>
470 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
472 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
473 for Mameo Bora, to fix the build.
475 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
478 Fixed build with hildon < 0.99
480 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
481 Check if the selected account is busy instead of checking all accounts
483 * src/modest-account-mgr-priv.h:
484 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
485 (modest_account_mgr_init), (compare_account_name),
486 (modest_account_mgr_set_account_busy),
487 (modest_account_mgr_account_is_busy):
488 * src/modest-account-mgr.h:
489 Added busy information to the account manager. It possible to
490 set an account to busy or not busy now.
492 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
493 (modest_mail_operation_update_account),
494 (modest_mail_operation_notify_end):
495 Set the account to busy/not busy depending on the operation state.
497 * src/widgets/modest-account-view.c:
498 (modest_account_view_finalize), (get_last_updated_string),
499 (update_account_view), (on_account_busy_changed), (init_view):
500 Show string "Refreshing..." if the account is currently busy.
502 All this fixes projects.maemo.org bug NB#59711
504 2007-06-14 Armin Burgmeier <armin@openismus.com>
506 * src/widgets/modest-attachments-view.h:
507 * src/widgets/modest-attachments-view.c: Added
508 modest_attachments_view_has_attachments() and fixed coordinate
509 transformation in get_att_view_at_coords(). This fixes attachment
512 * src/widgets/modest-msg-view.c: Make use of
513 modest_attachments_view_has_attachments() to decide whether to show
514 attachments in the header.
516 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
518 * src/maemo/modest-connection-specific-smtp-edit-window.c:
519 (on_change), (on_combo_security_changed),
520 (modest_connection_specific_smtp_edit_window_init),
521 (modest_connection_specific_smtp_edit_window_set_connection),
522 (modest_connection_specific_smtp_edit_window_is_dirty):
523 * src/maemo/modest-connection-specific-smtp-edit-window.h:
524 * src/maemo/modest-connection-specific-smtp-window.c:
527 Show an comfirmation dialog for the smpt-edit-window if there are
528 unsaved changes and the user hits cancel.
529 (projects.maemo.org bug NB#60479)
531 2007-06-14 Armin Burgmeier <armin@openismus.com>
533 * src/maemo/easysetup/modest-easysetup-wizard.c:
534 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
535 address" info in banner instead of node, and select all the text as
536 per UI spec. This fixes projects.maemo.org bug NB#60550.
538 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
540 reviewed by: <delete if not using a buddy>
542 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
543 * src/modest-ui-actions.c: (folder_refreshed_cb):
545 2007-06-14 Murray Cumming <murrayc@murrayc.com>
547 * src/widgets/modest-folder-view.c: (filter_row):
548 Explictly filter out the per-account outbox accounts. I don't know why
549 these only sometimes show up, but now they should never show up in the UI.
550 This should fix projects.maemo.org bug NB#60160.
552 2007-06-14 Murray Cumming <murrayc@murrayc.com>
554 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
555 when the toolbar does not exist yet.
556 * src/modest-widget-memory.c: (save_settings_header_view):
557 Added g_warnings() to help us to discover when we are trying to set
558 an empty columns list in gconf.
560 2007-06-14 Murray Cumming <murrayc@murrayc.com>
564 Added modest_init_get_default_header_view_column_ids().
566 * src/modest-widget-memory.c: (restore_settings_header_view):
567 Use the new function to get defaults, if the gconf key is empty,
568 instead of not creating any columns. This seems to fix the
569 empty right-hand pane problems.
571 * src/widgets/modest-header-view.h: Improved documentation.
573 2007-06-13 Murray Cumming <murrayc@murrayc.com>
575 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
576 Revert the use of the display name as the account name, because this
577 is generally wrong and would break the code that follows.
579 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
581 * src/maemo/easysetup/modest-easysetup-wizard.c:
582 (check_for_supported_auth_methods), (on_before_next),
585 More correct fix for projects.maemo.org bug NB# 58991
586 Do not longer accept AUTH_PASSWORD as secure method and choose
587 correct method when creating the account.
589 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
591 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
592 Fixed projects.maemo.org bug NB# 58991
594 2007-06-13 Murray Cumming <murrayc@murrayc.com>
596 * src/modest-init.c: (modest_init_init_core),
597 (modest_init_local_folders): Fixed compilation errors.
599 2007-06-13 Murray Cumming <murrayc@murrayc.com>
601 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
602 Remove unnecessary lib/include, though it is good in principle when needed.
604 * src/modest-init.c: (modest_init_one_local_folder),
605 (modest_init_local_folders):
606 * src/modest-init.h: Initialize the .modest library for memory cards,
607 instead of just doing nothing for them. This should allow us to create
608 folders there, fixing projects.maemo.org bug NB#59297.
610 2007-06-13 Murray Cumming <murrayc@murrayc.com>
612 * libmodest-dbus-client/libmodest-dbus-client.c:
613 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
614 (libmodest_dbus_client_compose_mail),
615 (libmodest_dbus_client_open_message),
616 (libmodest_dbus_client_send_and_receive),
617 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
619 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
620 (on_idle_open_message), (modest_dbus_req_handler),
621 (search_result_to_message), (modest_dbus_req_filter):
622 * src/modest-search.c: (add_hit), (modest_search_folder),
623 (modest_search_all_accounts): Improved debug messages.
625 * tests/dbus_api/test_open_message.c: (main): Improved comments.
627 * src/modest-tny-account-store.c:
628 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
631 2007-06-13 Murray Cumming <murrayc@murrayc.com>
634 2007-06-12 Murray Cumming <murrayc@murrayc.com>
636 * src/modest-tny-account-store.c: (get_server_accounts):
637 Call modest_tny_local_folders_account_add_merged_outbox_folders()
638 even when there are no accounts, so that the Outbox folder is always
639 visible. This fixes projects.maemo.org bug NB#60158.
641 2007-06-12 Murray Cumming <murrayc@murrayc.com>
643 * src/maemo/modest-main-window.c: (create_details_widget):
644 Use the mcen_va_never logical ID.
646 2007-06-12 Murray Cumming <murrayc@murrayc.com>
648 * src/dbus_api/modest-dbus-api.h:
649 * src/dbus_api/modest-dbus-callbacks.c:
650 (on_idle_open_default_inbox), (on_open_default_inbox),
651 (modest_dbus_req_handler):
652 Added a new OpenDefaultInbox method.
654 * libmodest-dbus-client/libmodest-dbus-client.h:
655 * libmodest-dbus-client/libmodest-dbus-client.c:
656 Added libmodest_dbus_client_open_default_inbox() to call the new
657 dbus method. This should be useful to projects.maemo.org bug NB#57214,
658 though it should maybe be used by a new osso-email-interface function.
660 * tests/dbus_api/Makefile.am:
661 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
664 2007-06-12 Murray Cumming <murrayc@murrayc.com>
666 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
667 NULL, so that the signals get all the keys. This should not actually
668 change any behaviour because we currently update everything when anything
671 2007-06-12 Murray Cumming <murrayc@murrayc.com>
673 * src/widgets/modest-folder-view.c: (text_cell_data),
674 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
675 (find_inbox_iter): If tinymail tells us that the folder is
676 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
677 This causes the inbox to be selected at startup, fixing part of
678 projects.maemo.org bug NB#56305.
680 * src/modest-ui-dimming-rules.c:
681 (modest_ui_dimming_rules_on_tools_smtp_servers):
682 * src/modest-ui-dimming-rules.h: Added a callback function to dim
683 the SMTP servers menu item.
684 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
685 that the SMTP Servers menu item is dimmed when there are no accounts,
686 as a future version of the UI spec will require. This fixes
687 projects.maemo.org bug NB#56305.
689 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
691 * src/maemo/modest-maemo-utils.c:
692 (modest_maemo_utils_get_supported_secure_authentication_methods):
693 Added label to dialog instead of unreadable title
695 * src/maemo/modest-main-window.c: (sync_accounts_cb),
696 (modest_main_window_new):
697 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
700 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
701 * src/modest-account-mgr.h:
702 Added method to avoid code duplication
704 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
705 (modest_ui_actions_on_send_receive):
706 Use modest_account_mgr_has_accounts
708 2007-06-11 Murray Cumming <murrayc@murrayc.com>
710 * src/maemo/easysetup/modest-presets.c:
711 (modest_presets_get_info_server_security): Do not report secure auth
713 * src/modest-protocol-info.c: Use the defines for the gconf key names
714 for secure authentication. This was not working because we were writing
715 Password and reading password, and the check was case sensitive.
716 With this, gmail now works for receiving and sending when created via
719 2007-06-11 Murray Cumming <murrayc@murrayc.com>
721 * src/maemo/easysetup/modest-presets.c:
722 (modest_presets_get_info_server_security): Correct the key name for
723 SecureSmtp, because it seems to be case-sensitive.
724 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
725 Do not try to get the 0th notebook page if there are 0 pages, to
728 2007-06-11 Murray Cumming <murrayc@murrayc.com>
730 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
731 Prevent use of the new notification feature for now, because it currently
732 shows one dialog for each new email, which is annoying.
734 2007-06-11 Murray Cumming <murrayc@murrayc.com>
736 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
737 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
738 when no country was selected, so that we show the global ones.
739 * src/maemo/easysetup/modest-presets.c:
740 (modest_presets_get_providers): Return only the global providers, not
741 all providers when mmc=0 was requested.
743 2007-06-11 Murray Cumming <murrayc@murrayc.com>
745 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
746 (easysetup_provider_combo_box_fill): Remove debug code that showed the
747 provider ID in the combo.
749 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
750 Do not show the page numbers, because it would be confusing when we add
751 the 2 extra pages for the custom setup, when the user chooses the "Other"
752 provider. This fixes projects.maemo.org bug NB#59028
754 * src/modest-init.c: (modest_init_init_core),
755 (modest_init_local_folders):
757 * src/modest-tny-account.c:
758 (modest_tny_account_new_for_local_folders): Do not create default folders
759 for the memory card. This should fix projects.maemo.org bug NB#59328.
761 2007-06-11 Murray Cumming <murrayc@murrayc.com>
763 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
764 Free the changed_conf_keys string items. They are already freed in the
765 idle handler if that runs first.
767 2007-06-11 Murray Cumming <murrayc@murrayc.com>
769 * src/modest-ui-actions.c:
770 (modest_ui_actions_on_password_requested): Check that the server name
771 is not NULL, because I just saw a password dialog with (null) as the
774 * src/modest-tny-folder.[h|c]: Added
775 modest_tny_folder_is_memory_card_folder().
776 * src/modest-ui-dimming-rules.c:
777 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
778 menu item for memory cards, as per the UI spec (section 7.4). This should
779 fix projects.maemo.org bug NB#59297.
781 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
783 * src/maemo/modest-main-window.c: (sync_accounts_cb):
784 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
785 is another problem with the code, see Murray's comment at line 772)
787 2007-06-08 Murray Cumming <murrayc@murrayc.com>
789 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
790 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
791 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
792 (load_from_file), (easysetup_country_combo_box_init),
793 (easysetup_country_combo_box_get_active_country_ids),
794 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
795 instead of just one ID, to avoid duplicate country names in the UI.
797 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
798 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
799 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
800 a single ID, avoiding duplicate providers.
801 * src/maemo/easysetup/modest-easysetup-wizard.c:
802 (on_combo_account_country): Adapt to use a list.
804 2007-06-08 Murray Cumming <murrayc@murrayc.com>
806 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
807 keys changed in the last X seconds.
809 * src/modest-account-mgr.h:
810 * src/modest-account-mgr.c: (on_timeout_notify_changes),
811 (on_key_change), (modest_account_mgr_class_init),
812 (modest_account_mgr_init), (modest_account_mgr_finalize):
813 As the keys are changed, save them in a GSList* and signal that GSList*
814 further every X seconds, to batch changes, to allow us to do just one
815 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
816 bug NB#56941 and other (UI-blocking) delays when changing account settings.
818 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
819 changed signal signature.
821 * src/modest-conf.c: (modest_conf_set_list),
822 (modest_conf_on_change): Reenable notification.
824 (modest_conf_maemo_fake_on_change): Comment out the hack that
825 notified immediately instead of asynchronously.
827 * src/widgets/modest-account-view.h:
828 * src/widgets/modest-account-view.c:
829 (update_account_view): Select the previously-selected account ID,
830 if possible. This fixes projects.maemo.org bug NB#56933.
832 (on_account_changed), (on_account_removed),
833 (modest_account_view_select_account):
835 Remove the block/unblock functions
836 because they were not useful.
838 * src/maemo/modest-account-view-window.c:
839 (on_delete_button_clicked), (on_edit_button_clicked),
840 (on_new_button_clicked): Remove the use of the non-working block/unblock.
842 2007-06-08 Murray Cumming <murrayc@murrayc.com>
844 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
845 Improve the error dialog to show Incorrect Account Settings, which seems
846 clearer, and say that the internal error message (to be removed from the
847 dialog later) is often misleading.
848 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
850 * src/modest-tny-account.c:
851 (modest_tny_account_new_from_server_account): Uncomment the printf of the
852 URL because this is so useful for debugging on the device.
854 * src/widgets/modest-serversecurity-combo-box.c:
855 (modest_serversecurity_combo_box_fill): Correct a logical ID.
857 2007-06-08 Murray Cumming <murrayc@murrayc.com>
859 * src/modest-mail-operation.c:
860 (modest_mail_operation_send_new_mail):
861 Added a comment about a nasty but apparently harmless message. Details
862 added to the wiki g_warnings() page.
864 2007-06-08 Murray Cumming <murrayc@murrayc.com>
866 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
867 (modest_tny_send_queue_class_init):
868 Do not use the priv struct because it is empty, to avoid g_warnings
869 about a non-existant priv struct.
871 * src/modest-tny-account-store.c:
872 (modest_tny_account_store_get_server_account),
873 (modest_tny_account_store_get_transport_account_for_open_connection
874 ): Do not try to get transport server accounts for local folders,
875 because they don't have any. This avoids a g_warning().
877 * src/maemo/modest-main-window.c:
878 (modest_main_window_notify_send_receive_initied),
879 (on_configuration_key_changed):
880 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
882 * src/modest-mail-operation.c:
883 (modest_mail_operation_update_account):
884 * src/modest-tny-account-store.h:
885 * src/modest-tny-account.c:
886 (modest_tny_account_get_special_folder),
887 (modest_tny_account_new_for_local_folders),
888 (modest_tny_account_new_for_per_account_local_outbox_folder):
889 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
890 * src/modest-tny-local-folders-account.c:
891 (add_account_folders_to_merged_folder):
892 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
893 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
894 (modest_ui_actions_on_send):
895 * src/widgets/modest-folder-view.c: (update_model):
896 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
897 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
898 modest_tny_account_store_get_tny_account_by_account() to
899 modest_tny_account_store_get_server_account() to make the code clearer.
901 2007-06-07 Marcus Bauer <marcusb@openismus.com>
903 * src/dbus_api/modest-dbus-api.h:
904 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
905 * src/maemo/modest-msg-edit-window.c:
906 (modest_msg_edit_window_attach_file_noninteractive):
907 added g_warning in case the file to be attached does not exist
908 * tests/dbus_api/test_compose_mail.c: (main):
909 removed obsolete comment, added generic files as test case
911 2007-06-07 Murray Cumming <murrayc@murrayc.com>
913 * src/modest-tny-account-store.c: (get_server_accounts):
914 Create the local folders account only once, not once for each outbox, and
915 not only when there are some outboxes.
917 2007-06-07 Murray Cumming <murrayc@murrayc.com>
919 * src/widgets/modest-folder-view.c: (update_model): Comment out some
920 code that is causing a crash at startup. Sergio says that he is fixing this.
922 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
924 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
925 * src/maemo/modest-account-settings-dialog.c:
926 (create_page_outgoing),
927 (modest_account_settings_dialog_set_account_name),
928 (save_configuration):
929 - Fixed handling of the "Use secure authentication" toggle to comply with
930 the ui specification. See also projects.maemo.org bug NB#58400
932 - Restore the Secure connection setting combo correctly when loading
935 * src/maemo/modest-maemo-utils.c:
936 (on_camel_account_get_supported_secure_authentication),
937 (modest_maemo_utils_get_supported_secure_authentication_methods):
938 Fixed a crasher if operation is canceled
940 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
941 (modest_protocol_info_auth_is_secure):
942 * src/modest-protocol-info.h:
944 Added two new methods to determine if a protocol/auth method is secure/encrypted in
945 the sense of the "Use secure authentication" toggle.
947 2007-06-07 Murray Cumming <murrayc@murrayc.com>
949 * src/modest-tny-account-store.h:
950 * src/modest-tny-account-store.c:
951 Added modest_tny_account_store_get_local_folders_account().
953 * src/modest-tny-folder.h:
954 * src/modest-tny-folder.c:
955 (modest_tny_folder_get_account):
956 Added this replacement for tny_folder_get_account() which returns
957 the local-folders account for TnyMergeFolders, to avoid the
958 warning about the unimplemented get_account_func() vfunc().
960 (modest_tny_folder_get_rules),
961 * src/modest-ui-actions.c:
962 (modest_ui_actions_on_folder_selection_changed):
963 * src/modest-mail-operation.c:
964 (modest_mail_operation_remove_folder),
965 (modest_mail_operation_xfer_folder),
966 (modest_mail_operation_rename_folder),
967 (modest_mail_operation_get_msg),
968 (modest_mail_operation_get_msgs_full),
969 (modest_mail_operation_remove_msg),
970 (modest_mail_operation_xfer_msgs),
971 (modest_mail_operation_refresh_folder):
972 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
974 2007-06-07 Murray Cumming <murrayc@murrayc.com>
976 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
977 (modest_server_account_set_security):
978 * src/modest-defs.h: Add comments explaining that our
979 UI spec means TLS when it says Normal, so these do not look like errors.
981 * src/modest-tny-account.c:
982 (modest_tny_account_new_from_server_account): Use the new tinymail
983 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
984 for TLS. This should fix projects.maemo.org bug NB#58460.
986 2007-06-06 Murray Cumming <murrayc@murrayc.com>
988 * src/maemo/easysetup/modest-easysetup-wizard.c:
989 (create_account): Correct the position of the gconf sanity check warning.
990 (on_button_edit_advanced_settings): Show the dialog immediately, instead
991 of using the g_idle_add() hack, because this does not seem to be necessary
992 on osso 1.1. It might even work on Maemo Bora if the problems were actually
993 caused by something other than maemo's gconf.
994 This fixes projects.maemo.org bug #59022.
996 2007-06-06 Murray Cumming <murrayc@murrayc.com>
998 * src/modest-account-mgr-helpers.c:
999 (modest_account_mgr_get_default_account): Do not check that the account
1000 exists if there is no default account (NULL), to fix a runtime warning.
1002 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1004 * src/widgets/modest-folder-view.c: (update_model):
1005 Do not unref the treemodel before we have finished with it.
1006 This prevents a valgrind warning and an occasional crash at startup.
1008 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1010 * libmodest-dbus-client/libmodest-dbus-client.h:
1011 added libmodest_dbus_client_compose_mail()
1012 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1014 added functions needed for SendAsMail() functionality
1015 * src/maemo/modest-msg-edit-window.c:
1016 (modest_msg_edit_window_attach_file_noninteractive):
1017 non interactively attaching files to message edit window
1018 * src/widgets/modest-msg-edit-window.h:
1019 * tests/dbus_api/Makefile.am:
1020 added test_compose_mail.c
1021 * tests/dbus_api/test_compose_mail.c: (main):
1023 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1025 * src/modest-account-view.c:
1026 Fixed bug projects.maemo.org bug NB#59307
1028 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1030 * src/maemo/easysetup/modest-easysetup-wizard.c:
1031 (get_serverport_incoming), (on_before_next), (create_account):
1032 * src/maemo/modest-account-settings-dialog.c:
1033 (modest_account_settings_dialog_set_account_name):
1034 * src/maemo/modest-maemo-utils.c:
1035 (on_camel_account_get_supported_secure_authentication_status),
1036 (on_camel_account_get_supported_secure_authentication),
1037 (on_secure_auth_cancel),
1038 (modest_maemo_utils_get_supported_secure_authentication_methods):
1040 Implemented security authentication for settings and easysetup.
1042 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1044 * src/maemo/modest-main-window.c: (create_details_widget):
1045 Show the total size for memory card accounts too, instead of showing
1046 the name again. Fixes bug projects.maemo.org bug NB#59307.
1048 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1051 * src/modest-tny-simple-folder-store.c:
1052 * src/modest-tny-simple-folder-store.h: Removed.
1054 * src/modest-tny-local-folders-account.h
1055 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1056 for the local-folders maildir, with an extra TnyMergedFolder containing
1057 the folders of the per-account outbox store accounts.
1058 * src/modest-tny-account-store.c: (get_server_accounts):
1059 Add the outboxes to the special local folders account after creating it.
1061 * src/modest-tny-account.c:
1062 (modest_tny_account_new_for_local_folders): Create the derived
1063 account when creating the main local-folders account.
1065 * src/maemo/modest-main-window.c: (create_details_widget),
1066 (modest_main_window_set_contents_style):
1067 Adapted to the use of the derived account instead of the folder store.
1069 * src/modest-ui-actions.c:
1070 (modest_ui_actions_on_folder_selection_changed):
1071 * src/modest-ui-dimming-rules.c:
1072 (modest_ui_dimming_rules_on_new_folder):
1073 * src/widgets/modest-folder-view.c: (text_cell_data),
1074 (icon_cell_data), (filter_row), (update_model),
1075 (get_cmp_rows_type_pos):
1078 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1079 Do not get the priv struct, because no priv struct has been set,
1080 to avoid a runtime warning.
1082 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1083 #ifelse with #else, to fix a warning, to fix the build.
1086 2007-06-05 Christian Kellner <ckellner@openismus.com>
1088 * libmodest-dbus-client/libmodest-dbus-client.c:
1089 Fix small typo in doc (why do you always see them
1090 AFTER committing stuff?)
1093 2007-06-05 Christian Kellner <ckellner@openismus.com>
1095 * libmodest-dbus-client/libmodest-dbus-client.c:
1096 (libmodest_dbus_client_search):
1097 Initialize hit list with NULL. Also set folder list
1098 to "" if NULL was supplied.
1101 2007-06-03 Christian Kellner <ckellner@openismus.com>
1103 * libmodest-dbus-client/libmodest-dbus-client.c:
1104 (modest_search_hit_list_free):
1105 Make it save to call it with NULL.
1107 * src/dbus_api/modest-dbus-callbacks.c:
1108 * src/modest-search.c:
1109 Return full ModestSearchHits as the search result list not TnyHeader
1110 since can't be around withouth the correspoding TnyFolder.
1112 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1114 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1115 Added currently commented code to check for secure auth
1117 * src/maemo/modest-account-settings-dialog.c: (on_response),
1118 (save_configuration), (show_ok):
1119 Fixed projects.maemo.org bugs NB #59248 and #59251
1121 * src/maemo/modest-maemo-utils.c:
1122 (on_camel_account_get_supported_secure_authentication_status),
1123 (on_camel_account_get_supported_secure_authentication),
1124 (modest_maemo_utils_get_supported_secure_authentication_methods):
1125 * src/maemo/modest-maemo-utils.h:
1126 Moved get_supported_secure_authentication() method here to be able
1127 to use it from easysetup wizard.
1129 * src/modest-pair.c: (on_pair_compare_as_string):
1130 Should compare string with first part of pair and not
1131 strcmp pairs which will crash.
1133 * src/modest-protocol-info.c:
1134 (modest_protocol_info_protocol_is_store):
1135 * src/modest-protocol-info.h:
1136 Added modest_protocol_info_get_auth_protocol_name()
1138 2007-06-03 Armin Burgmeier <armin@openismus.com>
1140 * src/modest-mail-operation.c:
1141 (modest_mail_operation_get_msgs_full): Set priv->account also when
1142 only retrieving a single message. This avoids a crash when canceling
1145 (modest_mail_operation_notify_end): Do not explicitely remove the
1146 operation from the queue but only emit the progress_changed signal.
1147 The queue itself listens to that signal to remove the operation when
1148 it is finished. This reduces coupling and removes a potential deadlock
1149 when modest_mail_operation_notify_end() is called from the queue
1150 itself. If that is a problem performance-wise, I would suggest to
1151 implement a status-changed signal or something.
1153 * src/modest-mail-operation-queue.c: Make sure to never call a
1154 function from another file while the queue is locked. This (hopefully)
1155 fixes another deadlock when exiting the application while retrieving
1158 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1160 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1161 Fixed build if libogs is not available
1163 2007-06-03 Christian Kellner <ckellner@openismus.com>
1165 * libmodest-dbus-client/libmodest-dbus-client.h:
1166 * libmodest-dbus-client/libmodest-dbus-client.c:
1167 (libmodest_dbus_client_delete_message):
1168 Implement deletion of messages (Client side).
1170 (modest_search_hit_free),
1171 (modest_search_hit_list_free):
1172 Utility functions to free the result hits.
1174 * src/dbus_api/modest-dbus-api.h:
1175 * src/dbus_api/modest-dbus-callbacks.c:
1176 (on_delete_message),
1177 (modest_dbus_req_handler):
1178 Implement deletion of messages (Server side).
1180 * tests/dbus_api/test_search.c: (main):
1183 * tests/dbus_api/Makefile.am:
1184 * tests/dbus_api/test_delete_message:
1185 Add little test for the message deletion logic
1187 2007-06-03 Armin Burgmeier <armin@openismus.com>
1189 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1190 when the operation queue was not empty. projects.maemo.org bug
1193 2007-06-03 Armin Burgmeier <armin@openismus.com>
1195 * src/widgets/modest-account-view.c
1196 (on_account_default_toggled): Toggle default account column
1197 explicitely instead of waiting for gconf notification (which is
1198 currently ignored). This should fix projects.maemo.org bug NB#56910
1199 for now. It should probably be removed when gconf notifications are
1202 2007-06-03 Christian Kellner <ckellner@openismus.com>
1204 * libmodest-dbus-client/libmodest-dbus-client.c:
1205 Removed debugging spew.
1207 * src/dbus_api/modest-dbus-callbacks.c:
1208 Added debugging info.
1210 * src/modest-search.c:
1211 (modest_search_all_accounts):
1212 Use tny_account_store_get_accounts () on the account store
1213 to get all accounts which is the way to get all accounts.
1215 * tests/dbus_api/test_search.c: (main):
1216 Make it possible to supply the search term on the command line.
1218 2007-06-03 Christian Kellner <ckellner@openismus.com>
1220 * libmodest-dbus-client/libmodest-dbus-client.c:
1221 * libmodest-dbus-client/libmodest-dbus-client.h:
1222 Implement searching for mesages over raw dbus. (Client side)
1224 * src/dbus_api/Makefile.am:
1225 * src/dbus_api/modest-dbus-api.h:
1226 * src/dbus_api/modest-dbus-callbacks.c:
1227 * src/dbus_api/modest-dbus-callbacks.h:
1228 Search framework (Server side). Also implement on_idle_open_message().
1230 * src/maemo/modest-platform.c: (modest_platform_init):
1231 Prepare for raw dbus/osso rpc interaction.
1233 * src/modest-search.h:
1234 Changed minsize from unspecific guint to guint32.
1236 * src/modest-search.c:
1238 Added strange hack which magically made tnymail work.
1240 (modest_search_folder),
1241 (modest_search_account),
1242 (modest_search_all_accounts):
1243 Implement helper functions to search all accounts, specific account
1246 * tests/dbus_api/Makefile.am:
1247 * tests/dbus_api/test_open_message.c:
1248 Read url to open from commandline.
1250 * tests/dbus_api/test_search.c:
1251 Implement small test for dbus search stuff
1253 2007-06-02 Armin Burgmeier <armin@openismus.com>
1255 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1256 include account type and account title. This fixes projects.maemo.org
1259 * src/maemo/modest-account-view-window.c: Set a title for the window.
1261 2007-06-02 Armin Burgmeier <armin@openismus.com>
1263 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1264 incoming and outgoing server name based on email address and server
1265 types as long as the names have not been edited manually. This fixes
1266 projects.maemo.org bug NB#58671.
1268 2007-06-02 Armin Burgmeier <armin@openismus.com>
1270 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1271 server type cannot be changed in future to the incoming details page
1272 when creating an account. This fixes projects.maemo.org bug NB#59029.
1274 2007-06-02 Armin Burgmeier <armin@openismus.com>
1276 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1277 and assigned max width chars so that they wrap instead of being
1278 truncated. Fixes projects.maemo.org bug NB#56126.
1280 2007-06-02 Armin Burgmeier <armin@openismus.com>
1282 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1283 introductory note to the connection specific smtp servers dialog, as
1284 section 8.12 of the email UI specification requires. This fixes
1285 projects.maemo.org bug NB#59212.
1287 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1289 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1290 Check for running mail operations, and offer to cancel them, as per the UI
1291 spec. This fixes projects.maemo.org bug NB#59041 .
1292 However, I suspect that tinymail may still use the network connection
1293 in ways that we cannot detect or cancel. But it should at least adapt to
1294 changes fairly well.
1296 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1298 * src/modest-tny-account-store.c: (recreate_all_accounts),
1299 (get_cached_accounts), (get_server_accounts): Do more sensible
1300 ref-counting of the temporarily-cached outbox accounts list. This seems
1301 to fix a crash when entering the password when the password was wrong.
1303 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1305 * src/gnome/modest-main-window.c: (connect_signals):
1306 * src/modest-tny-account-store.c: (get_password),
1307 (modest_tny_account_store_alert): Added comments and clues and
1308 commented-out code about how we currently fail to deal with connection
1309 errors and wrong passwords, and how we should.
1311 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1313 * src/widgets/modest-retrieve-combo-box.c:
1314 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1315 This fixes projects.maemo.org bug NB#58472 .
1317 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1319 * src/maemo/easysetup/modest-easysetup-wizard.c:
1320 (create_page_complete_easysetup):
1321 (create_page_complete_custom): Correct the last commit,
1322 putting the correct sentences in the correct pages.
1324 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1326 * src/maemo/easysetup/modest-easysetup-wizard.c:
1327 (create_page_complete_custom): Show the second sentence of text
1328 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1331 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1333 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1334 Set the leave-on-server conf key by default. This fixes
1335 projects.maemo.org bug NB#59258 .
1337 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1339 * src/maemo/modest-account-view-window.c:
1340 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1341 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1344 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1346 * src/maemo/easysetup/modest-easysetup-wizard.c:
1347 (create_caption_new_with_asterisk):
1348 * src/maemo/modest-account-settings-dialog.c:
1349 (create_caption_new_with_asterisk):
1350 Uncomment the code to add the asterisk, because they are no longer in the
1351 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1352 (update_incoming_server_title): Add an asterisk here too.
1354 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1356 * src/maemo/modest-maemo-global-settings-dialog.c:
1357 (current_connection): Check that we are even connected before trying to
1358 get the current connection name, to prevent a warning.
1360 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1361 Change the comments because tny_maemo_conic_device_connect() is now meant to
1363 * src/modest-mail-operation.c:
1364 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1365 make sure we have a connection and fail if we can't connect.
1367 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1369 * src/maemo/modest-main-window.c:
1370 (on_account_store_connecting_finished): Do not try to get the
1371 connection ID if we are not really connected. I am surprised that
1372 this signal handler is called when we are not connected.
1374 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1376 * src/modest-error.h:
1377 * src/modest-ui-actions.c:
1378 (modest_ui_actions_get_msgs_full_error_handler):
1379 Renamed an enum, added comments, added an enum
1380 for retrieve-limit errors.
1382 * src/modest-mail-operation.c: (foreach_add_item),
1383 (internal_folder_observer_update), (update_account_thread),
1384 (modest_mail_operation_get_msgs_full):
1385 (modest_mail_operation_update_account),
1386 Added comments about how this works, and some code that should
1387 (but does not) check the retrieve-limit. See the TODO comment.
1389 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1391 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1392 Initialize help_id to fix the build. Warnings are good.
1394 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1396 * src/widgets/modest-hbox-cell-renderer.c:
1397 (modest_hbox_cell_renderer_append):
1398 * src/widgets/modest-vbox-cell-renderer.c:
1399 (modest_vbox_cell_renderer_append):
1400 Fix the last commit by doing an extra ref.
1402 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1404 * src/widgets/modest-hbox-cell-renderer.c:
1405 (modest_hbox_cell_renderer_append):
1406 * src/widgets/modest-vbox-cell-renderer.c:
1407 (modest_vbox_cell_renderer_append):
1408 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1409 to fix the build with Maemo Bora.
1410 However, there seems to be a remaining crash, probably due to reference
1413 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1415 * src/modest-tny-account.c:
1416 (modest_tny_account_new_for_local_folders):
1417 Use hildon_file_system_info_async_new() to get a better name for
1418 the memory card account, setting it as the account name.
1419 The timing seems to work, but this is probably
1420 not the best place to do this. See the TODO comment.
1421 * src/maemo/modest-main-window.c: (create_details_widget):
1422 * src/widgets/modest-folder-view.c: (text_cell_data):
1423 Use the tny account name instead of hardcoding a name.
1425 2007-05-30 Christian Kellner <ckellner@openismus.com>
1427 * src/modest-search.c: (modest_search):
1428 Correctly set part_search_func even if we have already parsed
1429 the query and thus a valid OgsTextSearcher object.
1431 2007-05-30 Christian Kellner <ckellner@openismus.com>
1434 Search and check for libogs.
1437 Incooparte the ogs build env.
1439 * src/modest-mime-part-search-stream.c:
1440 * src/modest-mime-part-search-stream.h:
1441 Removed since we do the real searching now in modest-search.c.
1443 * src/modest-search.c:
1444 * src/modest-search.h:
1445 Implement support for ogs. We use that if available and requested
1446 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1447 should now handle the corner case when the search term is spread
1448 across multiple reads.
1449 Also the logic in modest_search () was corrected to search all
1450 requested fields until one is found.
1452 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1454 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1456 * src/modest-init.h:
1457 * src/modest-init.c: Made modest_init_local_folders() take a
1458 path and be public so we can iniitialize maildir folders on
1461 * src/modest-local-folder-info.h:
1462 * src/modest-local-folder-info.c:
1463 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1465 * src/modest-tny-account.c:
1466 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1467 still means the standard local-folders path on the local volume.
1469 * src/modest-tny-account-store.c:
1470 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1471 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1472 all accounts when that happens.
1473 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1474 this too, so it shows up in the treeview.
1476 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1478 * src/maemo/modest-maemo-global-settings-dialog.c:
1479 (current_connection):
1480 * src/widgets/modest-global-settings-dialog.c:
1481 (current_connection_default):
1482 Use the enum values instead of 0, 1 and -1,
1483 to make the code clearer.
1485 * src/modest-account-mgr-helpers.c:
1486 (modest_account_mgr_get_connection_specific_smtp): Make this code
1489 * src/modest-runtime.h:
1490 * src/modest-runtime.c:
1491 Added modest_runtime_remove_all_send_queues().
1492 * src/maemo/modest-main-window.c:
1493 (on_account_store_connecting_finished): Recreate the send queues,
1494 using the appropriate transport accounts for this new connection.
1495 Some futher adapting might be needed if the old send queues are not
1496 automatically stopped at this point.
1498 * src/modest-tny-account-store.c: (get_server_accounts):
1499 Create the connection-specific transport accounts, so that they can
1500 be found later by their ID.
1502 * src/modest-tny-account.h:
1503 * src/modest-tny-account.c:
1504 Added modest_tny_account_new_from_server_account_name().
1505 modest_tny_account_new_from_server_account(): Do not create the
1506 send queues here, because they will be
1507 recreated anyway when the connection changes for the first time.
1509 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1511 * src/modest-local-folder-info.h:
1512 * src/modest-local-folder-info.c:
1513 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1514 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1515 tbox_folder): Take a modest account name instead of a server TnyAccount,
1516 so we can have per-modest-account rather than per-transport-account
1518 We must make sure that we change or recreate the exisitng send queues
1519 when the connection changes for connection-specific transport accounts.
1521 * src/modest-tny-account-store.c:
1522 (create_per_account_local_outbox_folders): Create outboxed per modest
1523 account, not per transport account.
1525 * src/modest-tny-account.h:
1526 * src/modest-tny-account.c:
1527 (modest_tny_account_get_special_folder): For outboxes, get the
1528 parent modest account name. The account is ignored for other folders.
1529 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1530 modest account name rather than a server TnyAccount.
1532 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1534 * src/modest-tny-account.c:
1535 (modest_tny_account_new_from_server_account):
1536 Call modest_runtime_get_send_queue() immediately after creating transport
1537 accounts, so that they start trying to send email from the outbox as soon
1538 as possible at startup. This is probably what we want.
1540 * src/modest-mail-operation.c: (update_account_thread):
1541 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1542 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1543 * src/modest-tny-send-queue.h:
1544 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1545 (modest_ui_actions_on_send):
1546 Added comments about how sending works, though it needs some more work.
1548 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1550 * src/modest-tny-account.c:
1551 (modest_tny_account_get_special_folder): Add TODO because this fails when
1552 the network is busy.
1553 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1554 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1555 Do not try to show this window when there is no active account. The UI
1556 specs does not tell us what to do in this case.
1558 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1562 * src/maemo/Makefile.am:
1563 * src/widgets/Makefile.am: Some dist fixes.
1565 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1567 * src/maemo/modest-connection-specific-smtp-window.c:
1568 (on_button_edit): Make the code clearer, to prevent a double free.
1570 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1572 * src/maemo/modest-account-settings-dialog.c:
1573 (modest_account_settings_dialog_set_account_name),
1574 Check the connection-specific smtp servers checkbox if there are any.
1576 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1577 (modest_connection_specific_smtp_edit_window_init):
1578 Start with a suitable port number.
1580 * src/modest-account-mgr-helpers.h:
1581 * src/modest-account-mgr-helpers.c: Added
1582 modest_account_mgr_get_has_connection_specific_smtp().
1584 (modest_account_mgr_set_connection_specific_smtp),
1585 (modest_account_mgr_remove_connection_specific_smtp),
1586 (modest_account_mgr_get_has_connection_specific_smtp),
1587 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1588 connection-specific smtp server accounts in the account, rather than
1589 the server account conf dir.
1591 This fixes bug projects.maemo.org bug NB#58263 .
1593 * src/modest-tny-account-store.c:
1594 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1595 if there are no server accounts yet, to prevent an infinite loop when there
1596 are no accounts. Document that one must be called before the other.
1598 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1600 * src/modest-account-mgr-helpers.c:
1601 (modest_account_mgr_get_default_account): Make sure that at least
1602 one account is always the default, if there are any enabled accounts.
1603 This is just a sanity check that shouldn't be necessary.
1605 * src/modest-account-mgr-priv.c:
1606 (_modest_account_mgr_account_from_key): Unescape the conf key to
1607 get the real account name. For instance, this is an issue if a space
1608 was in the account name, which can happen because the account name
1609 is generated from the display name.
1610 (_modest_account_mgr_get_account_keyname): Always escape the
1612 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1613 Unescape the conf keys to get the real account names.
1615 For instance, previously the is-default radio button in the accounts
1616 list was not checked for any accounts at first. This fixes that,
1617 and might fix several similar bugs.
1619 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1621 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1622 Removed some debug printfs.
1624 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1626 Modest on-disk outbox directories are now here, for instance:
1627 $HOME/.modest/outboxes/<account-id-1>/outbox
1628 $HOME/.modest/outboxes/<account-id-2>/outbox
1630 $HOME/.modest/local-folders/outbox
1631 so we can have a separate outbox for each account.
1632 But they are shown as one outbox in the GtkTreeView, by using a
1633 TnyMergeFolder in a ModestTnySimpleFolderStore.
1636 * src/modest-tny-simple-folder-store.c:
1637 * src/modest-tny-simple-folder-store.h:
1638 Added ModestTnySimpleFolderStore, used to contain folders from
1639 other folder stores, such as other accounts.
1641 * src/modest-tny-outbox-account.h:
1642 * src/modest-tny-outbox-account.c:
1643 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1644 used for the per-account local outbox folders.
1646 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1647 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1648 only use this (internally) now for the non-outbox local folders.
1650 * src/modest-init.h:
1651 * src/modest-init.c: Added modest_init_one_local_folder(), for
1652 setting up the directory structure for each local folder.
1654 * src/modest-local-folder-info.c:
1655 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1656 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1658 * src/modest-local-folder-info.h:
1659 * src/modest-tny-account-store.c: (on_account_removed),
1660 (on_account_changed), (create_per_account_local_outbox_folders),
1661 (get_server_accounts), (modest_tny_account_store_get_accounts),
1662 (modest_tny_account_store_get_tny_account_by_account),
1663 (modest_tny_folder_store_is_virtual_local_folders):
1665 * src/modest-tny-account.h:
1666 * src/modest-tny-account.c:
1667 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1668 to create an on-disk per-account local outbox folder for each
1670 (create_per_account_local_outbox_folders): Create a local outbox folder
1671 for each transport account.
1672 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1673 for all local folders.
1675 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1676 instead of using g_object_get/set() directly. It is clearer.
1678 (modest_tny_folder_store_get_message_count),
1679 (modest_tny_folder_store_get_local_size
1680 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1681 because we now use these with non-acount folder stores.
1683 (modest_tny_account_get_special_folder),
1684 (modest_tny_account_new_from_server_account),
1685 (modest_tny_account_new_from_account):
1686 (recurse_folders): Adjust to the new outbox system.
1688 * src/modest-tny-folder.h:
1689 * src/modest-tny-folder.c:
1690 (modest_tny_folder_is_local_folder),
1691 (modest_tny_folder_get_local_folder_type),
1692 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1694 * src/widgets/modest-main-window.h:
1695 * src/maemo/modest-main-window.c: (create_details_widget),
1696 (modest_main_window_set_contents_style): Show details for any folder store,
1699 (modest_tny_folder_get_rules):
1700 Remove the const. C does not support constness enough for this.
1702 * src/modest-ui-actions.c:
1703 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1704 make all outboxes appear as one, in the usual local-folders tree node.
1706 (set_active_account_from_tny_account),
1707 (modest_ui_actions_on_folder_selection_changed):
1708 * src/widgets/modest-folder-view.c: (text_cell_data),
1709 (icon_cell_data), (filter_row),
1710 (add_account_folders_to_merged_folder),
1711 (add_account_folders_to_simple_folder_store), (),
1712 (get_cmp_rows_type_pos), (cmp_rows),
1713 (modest_folder_view_set_account_id_of_visible_server_account):
1714 Adjust to the new outbox system, using generic folder stores and folders
1715 in the GtkTreeModel.
1717 2007-05-23 Christian Kellner <ckellner@openismus.com>
1719 * src/modest-mail-operation.c:
1720 (modest_mail_operation_update_account):
1721 Use info->max_size instead of unintialized local var [small
1722 build fix]. (Added TODO to review that change since I don't
1725 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1727 * libmodest-dbus-client/libmodest-dbus-client.c:
1728 (libmodest_dbus_client_compose_mail): function added
1729 * src/dbus_api/modest-dbus-api.h:
1730 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1731 (on_compose_mail): Implementation of the SendAsMail functionality
1733 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1735 * src/modest-account-mgr.c:
1736 (modest_account_mgr_add_server_account): Set the secure-connection
1737 conf key for transport accounts as well as store accounts. I don't know
1738 why the if was there. For instance, this makes sure that we use SSL
1739 for the gmail preset from the easysetup wizard.
1741 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1743 * src/gnome/modest-main-window.c:
1744 (on_account_store_connecting_finished), (connect_signals):
1745 * src/maemo/modest-main-window.c:
1746 (on_account_store_connecting_finished), (connect_signals),
1747 (modest_main_window_new):
1748 Handle TnyAccountStore::connecting-finished instead of
1749 TnyDevice::connection-changed, because we cannot actually perform
1750 operations on accounts until TnyAccountStore has itself responded to
1751 the TnyDevice::connection-changed signal. This prevents a GError from
1753 Do not try to update at startup, because we (at least on scratchbox)
1754 already do an update at startup when the device goes online.
1755 This prevents a GError from tinymail.
1756 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1757 Added TODO about stopping simultaneous operations.
1759 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1761 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1762 * src/modest-mail-operation-queue.c:
1763 (modest_mail_operation_queue_remove):
1764 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1765 about where they happened.
1767 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1769 * src/modest-ui-actions.c:
1770 (modest_ui_actions_on_password_requested): Make sure that the remember
1771 output parameter is always TRUE.
1773 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1775 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1776 Show a OK/Cancel dialog if the error is a question, though we still do not
1777 know anything more about what we are asking the user.
1778 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1779 Fix an uninitialized variable (helper). This is a logic error, however.
1781 2007-05-21 Christian Kellner <ckellner@openismus.com>
1783 * src/modest-search.h:
1784 Correct bit shifting in the ModestSearchFlags enum.
1786 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1788 * src/modest-tny-account.c:
1789 (modest_tny_account_new_from_server_account): Do not use the lsub and
1790 check-all hard-coded IMAP options when using POP.
1792 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1794 * src/modest-tny-account.c:
1795 (modest_tny_account_new_from_server_account):
1796 Use NULL for the secure-auth method for POP when Password auth has been
1797 specified by the user, as we already do for IMAP. "auth=Login" causes
1798 an error from camel or the server.
1800 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1802 * src/maemo/modest-account-settings-dialog.c:
1803 (create_page_account_details),
1804 (modest_account_settings_dialog_set_account_name):
1805 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1806 for the leave-on-server checkbox, rathr than just the checkbox, when
1807 the protocol is not POP.
1809 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1811 * src/widgets/modest-account-view.c:
1812 * src/widgets/modest-account-view.h:
1813 Added modest_account_view_select_account() which will be useful later
1814 to asynchronously re-select the edited account.
1816 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1818 * src/maemo/modest-account-settings-dialog.c:
1819 (modest_account_settings_dialog_set_account_name):
1820 Automatically choose the port numbers based on the secure authentication
1821 methods, if they have not been chosen before.
1822 This fixes projects.maemo.org bug NB#56273 .
1824 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1826 * src/maemo/modest-main-window-ui.h:
1827 * src/modest-ui-actions.c:
1828 * src/modest-ui-actions.h:
1829 Connect the Tools/SMTP Servers menu item to
1830 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1831 SMTP servers dialog, as in the UI specification and saves changes when it
1832 is closed. This fixed projects.maemo.org bug NB#56305 .
1834 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1836 * src/maemo/modest-connection-specific-smtp-window.c:
1837 (modest_connection_specific_smtp_window_init):
1838 Use gtk_window_set_default_size() to make this window big enough, so
1839 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1841 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1843 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1844 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1845 (modest_connection_specific_smtp_edit_window_init),
1846 Do not try to connect to a combobox signal before the combobox exists.
1847 This fixes the cras in projects.maemo.org bug NB#56288 .
1848 (modest_connection_specific_smtp_edit_window_get_settings):
1849 Remove the server_account_name parameter which was being checked for NULL
1850 though it was not used.
1852 * src/maemo/modest-connection-specific-smtp-window.c:
1853 (modest_connection_specific_smtp_window_fill_with_connections),
1854 (on_button_edit), (modest_connection_specific_smtp_window_init):
1855 Correct the number of treemodel columns to prevent a warning.
1856 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1857 libconic does not work.
1859 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1861 * src/modest-tny-account.c:
1862 (modest_tny_account_new_from_server_account):
1863 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1864 SMTP when "None" was chosen by the user. However, with my SMTP server that
1865 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1868 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1870 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1871 to explain the memory management issue with the ID in the ModestPair.
1873 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1874 (add_sending_page), (modest_account_assistant_finalize):
1875 * src/gnome/modest-gnome-global-settings-dialog.c:
1876 (create_updating_page), (create_composing_page):
1877 * src/gnome/modest-msg-edit-window.c: (get_transports),
1878 (init_window), (modest_msg_edit_window_finalize),
1879 (modest_msg_edit_window_get_msg_data):
1880 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1881 * src/gnome/modest-transport-widget.c:
1882 (modest_transport_widget_finalize), (smtp_configuration):
1883 * src/maemo/modest-maemo-global-settings-dialog.c:
1884 (create_updating_page), (create_composing_page):
1885 * src/maemo/modest-msg-edit-window.c: (get_transports),
1886 (init_window), (modest_msg_edit_window_finalize),
1887 (modest_msg_edit_window_get_msg_data),
1888 (modest_msg_edit_window_free_msg_data):
1889 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1890 (modest_store_widget_finalize):
1891 * src/maemo/modest-transport-widget.c:
1892 (modest_transport_widget_finalize), (smtp_configuration):
1893 * src/modest-main.c: (send_mail):
1894 * src/widgets/modest-combo-box.h:
1895 * src/widgets/modest-global-settings-dialog-priv.h:
1896 * src/widgets/modest-global-settings-dialog.c:
1897 (modest_global_settings_dialog_finalize):
1898 * src/widgets/modest-msg-edit-window.h:
1899 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1900 as long as the combo box, to prevent use of freed memory for the ID.
1902 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1904 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1905 get_accounts(), to make this clearer. Do not check for the enabled gconf
1906 key, because we do not use this for server accounts (at least, not yet).
1907 This allows us to send email again.
1909 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1911 * src/maemo/modest-platform.c:
1912 (on_modest_conf_update_interval_changed), (modest_platform_init):
1913 Only respond to this particular key change. All these strcmp()s cannot be
1916 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1918 * src/maemo/modest-maemo-global-settings-dialog.c:
1919 (current_connection): Prevent a crash in scratchbox when
1920 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1921 * src/maemo/modest-platform.c:
1922 (on_modest_conf_update_interval_changed), (modest_platform_init):
1923 Get the update interval from gconf and reset it when the gconf key changes.
1925 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1927 * src/modest-protocol-info.c:
1928 * src/modest-protocol-info.h: Adde enum-specific get functions,
1929 instead of using a ModestProtocolType enum parameter.
1931 * src/gnome/modest-account-assistant.c:
1932 * src/gnome/modest-store-widget.c:
1933 * src/gnome/modest-store-widget.h:
1934 * src/gnome/modest-transport-widget.c:
1935 * src/gnome/modest-transport-widget.h:
1936 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1937 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1938 * src/maemo/easysetup/modest-easysetup-wizard.c:
1939 * src/maemo/modest-account-settings-dialog.c:
1940 * src/maemo/modest-account-settings-dialog.h:
1941 * src/maemo/modest-store-widget.c:
1942 * src/maemo/modest-store-widget.h:
1943 * src/maemo/modest-transport-widget.c:
1944 * src/maemo/modest-transport-widget.h:
1945 * src/modest-account-mgr-helpers.c:
1946 * src/modest-account-mgr-helpers.h:
1947 * src/modest-account-mgr.c:
1948 * src/modest-account-mgr.h:
1949 * src/modest-tny-account.c:
1950 * src/modest-tny-folder.c:
1951 * src/widgets/modest-account-view.c:
1952 * src/widgets/modest-retrieve-combo-box.c:
1953 * src/widgets/modest-retrieve-combo-box.h:
1954 * src/widgets/modest-secureauth-combo-box.c:
1955 * src/widgets/modest-serversecurity-combo-box.c:
1956 * src/widgets/modest-serversecurity-combo-box.h:
1957 * tests/check_account-mgr.c:
1958 Use the specific functions, and use the re-renamed enum values for GNOME too.
1960 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1962 * src/modest-pair.h:
1963 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1964 so we can get the second based on the first.
1966 * src/maemo/modest-account-settings-dialog.h:
1967 * src/maemo/modest-account-settings-dialog.c:
1968 Added get_supported_secure_authentication_methods(), though it is mostly
1969 commented-out for now until the necessary API is committed to tinymail.
1970 (modest_account_settings_dialog_set_account_name),
1971 (save_configuration): Request the supported authentication methods from the
1972 server, so we can choose a working method.
1974 * src/modest-tny-account-store.h:
1975 * src/modest-tny-account-store.c:
1976 (modest_tny_account_store_get_session): Rename from
1977 tny_account_store_get_session().
1979 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1981 * src/modest-protocol-info.h: Split the ModestProtocol enum
1982 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1983 There was no need to have these unrelated values in one enum.
1985 * src/: many files: Adapted to changed enum. This makes the code a bit
1986 clearer, and the compiler could catch some errors.
1988 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1990 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1991 Show the detailed internal camel error message when an error happens
1992 during the configuration, so that our testers can give us more clues.
1993 For instance, in projects.maemo.org bug NB#56910 .
1995 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1997 * src/modest-tny-account.c:
1998 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1999 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2001 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2003 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2004 * src/maemo/modest-account-settings-dialog.c:
2005 (modest_account_settings_dialog_set_account_name),
2006 (save_configuration): For the incoming secure authentication checkbox,
2007 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2008 the UI specification. PLAIN does not seem to be supported for most IMAP
2009 servers anyway, and I am not sure what it would mean.
2010 However, we probably need to discover which of the secure-authentication
2011 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2012 * src/modest-account-mgr-helpers.c:
2013 (modest_account_mgr_get_server_account_data):
2015 * src/modest-tny-account.c:
2016 (modest_tny_account_new_from_server_account):
2017 Use tny_account_set_mech() to set secure-authentication methods,
2018 with some special-casing for IMAP, based on my observations of how
2021 * src/modest-account-mgr-helpers.h:
2022 * src/modest-account-mgr.c:
2023 * src/modest-defs.h: Comment that the URI is only used for local folders.
2025 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2027 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2028 parameter const, just to be neat.
2029 * src/modest-text-utils.c: (modest_text_utils_inline):
2030 End g_strconcat() with NULL, as its documentation says. This is almost
2031 certainly the cause of my crash at startup on the device. Interestingly,
2032 valgrind doesn't tell us about these errors.
2034 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2036 * scripts/build-packages: Added more precise comments about how to use
2037 this script, though I still get this error:
2038 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2039 error building tinymail
2041 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2043 * src/maemo/modest-main-window.c: (on_account_update):
2044 Very slight cleanup, hoping to make it simpler to discover what causes
2045 a crash here sometimes.
2047 * src/modest-tny-account.c:
2048 (modest_tny_account_new_from_server_account): Set the port. Added
2049 comments about the options and a TODO comment because I need to find out
2050 how to specify the secure authentication method.
2052 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2054 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2055 changed CFlags paths form modest to libmodest
2057 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2059 * src/modest-account-mgr-helpers.c:
2060 (modest_account_mgr_get_server_account_data),
2061 (modest_account_mgr_free_server_account_data):
2062 * src/modest-account-mgr-helpers.h:
2063 * src/modest-account-mgr.c:
2064 (modest_account_mgr_add_server_account):
2065 * src/modest-defs.h:
2066 * src/modest-tny-account.c:
2067 (modest_tny_account_new_from_server_account):
2068 Determine the options for tny_camel_account_add_option() here,
2069 based on the settings, rather than storing them directly in gconf.
2071 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2073 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2074 Show a more friendly error dialog now that we expect (from the tinymail
2075 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2077 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2079 * src/maemo/modest-main-window.c: (on_account_update): Check that
2080 account_name is not NULL, to prevent a crash at startup that I am
2081 seeing on the N800. I do wonder why it is NULL.
2083 * src/maemo/easysetup/modest-easysetup-wizard.c:
2084 (create_page_user_details):
2085 * src/maemo/modest-account-settings-dialog.c:
2086 (create_page_user_details), (create_page_outgoing):
2087 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2088 (modest_connection_specific_smtp_edit_window_init):
2089 * src/modest-ui-actions.c:
2090 (modest_ui_actions_on_password_requested):
2091 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2092 might do something useful with the on-screen keyboard.
2094 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2096 * src/maemo/modest-main-window.c: (on_account_update):
2097 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2098 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2100 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2102 * src/modest-tny-account-store.c: (on_account_changed):
2103 Correct the signature of this signal handler.
2105 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2107 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2108 Show a HildonNote instead of a GtkDialog for Maemo.
2110 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2112 * src/widgets/modest-account-view.h:
2113 * src/widgets/modest-account-view.c: (on_account_changed),
2114 (on_account_removed). Added a boolean flag, set/unset by
2115 modest_account_view_block_conf_updates(),
2116 modest_account_view_unblock_conf_updates() to prevent unnecessary
2117 updates, but this is not very useful because the gconf notifications are
2118 so delays (maybe only on Maemo Bora).
2119 So auto-updating is turned off, and these functions do an explicit
2120 update when necessary.
2121 However, something else is still doing too much work when adding/removing
2122 accounts, probably in another part of the application.
2124 * src/maemo/modest-account-view-window.c:
2125 (on_delete_button_clicked), (on_edit_button_clicked),
2126 (on_new_button_clicked): Use the new functions.
2128 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2130 * src/modest-account-mgr-helpers.c:
2131 (modest_account_mgr_set_first_account_as_default):
2132 Sort the list of names alphabetically-by-title, so we choose the first one
2134 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2135 alphabetically by the title.
2137 This fixes projects.maemo.org bug NB#56418 .
2139 * src/modest-account-mgr-priv.c:
2140 (_modest_account_mgr_account_from_key):
2141 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2142 avoid a valgrind error, and possible random behaviour.
2144 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2146 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2147 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2148 tinymail documentation to say that this can be expected.
2149 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2150 pretty, and should not happen, but I would prefer to know when it does.
2152 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2154 * configure.ac: When using the older hildon version, probably on Bora,
2155 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2157 * src/widgets/modest-attachment-view.c:
2158 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2161 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2163 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2164 Implemented the prototype. Can be tested with
2165 tests/dbus_api/test_open_message:
2167 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2169 * src/modest-tny-account-store.c:
2170 (modest_tny_account_store_instance_init), (get_password):
2171 * src/modest-ui-actions.c:
2172 (modest_ui_actions_on_password_requested):
2173 Do not store the password in gconf, because this function is called
2174 for non-remembered passwords. Actually use the cached (in the hash map)
2175 password instead of releasing it.
2176 The password will now not be remembered if it is asked via the protected
2177 password dialog, as per the UI spec.
2179 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2181 * src/modest-defs.h:
2182 * src/modest-account-mgr-helpers.h:
2183 * src/modest-account-mgr-helpers.c:
2184 Added modest_server_account_get_username_has_succeeded(),
2185 modest_server_account_set_username_has_succeeded().
2186 (modest_server_account_set_username),
2187 Reset the has-succeeded flag if the username changes.
2189 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2190 * src/maemo/modest-connection-specific-smtp-window.c:
2191 (modest_connection_specific_smtp_window_save_server_accounts):
2192 Use modest_server_account_set_username() instead of using
2193 modest_conf_set_string() directly, so that the has-succeeded flag is always
2196 * src/modest-ui-actions.c:
2197 (modest_ui_actions_on_password_requested): Dim the username entry if
2198 the username has ever worked, as per the UI spec.
2200 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2202 * src/modest-tny-account-store.c: (get_password):
2203 * src/modest-ui-actions.c:
2204 (modest_ui_actions_on_password_requested):
2205 Allow the username to be changed too, though there is more work to
2206 be done on exactly how this behaves.
2208 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2210 * src/modest-account-mgr-helpers.h:
2211 * src/modest-account-mgr-helpers.c:
2212 Added modest_account_mgr_get_display_name(),
2213 modest_server_account_get_username(),
2214 modest_server_account_set_username(),
2215 modest_server_account_set_password(),
2216 modest_server_account_get_hostname() functions so we do not need to
2217 use the conf API directly.
2219 * src/maemo/modest-main-window.c: (connect_signals):
2220 Actually connect ot the ModestAccountStore::request-password signal,
2221 so that we show the dialog when the password is requested by Tinymail,
2222 for isntance if it is empty.
2224 * src/modest-marshal.list:
2225 * src/modest-tny-account-store.c:
2226 (modest_tny_account_store_class_init), (get_password),
2227 (modest_tny_account_store_alert):
2228 * src/modest-tny-account-store.h:
2229 * src/modest-ui-actions.h:
2230 * src/modest-ui-actions.c:
2231 (modest_ui_actions_on_password_requested):
2232 Change the signal parameters, so it is obvious that we are providing
2233 the non human-readable server name, and receiving both the username
2234 and password, though changing of the username is not yet implemented.
2235 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2236 for the GNOME version.
2238 This should fix the projects.maemo.org bug NB#56209, though it does not
2239 work on Bora, because the gconf_client_get() for the password fails
2240 immediately after we save it with gconf_client_set().
2242 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2245 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2246 caused an undefined symbol error:
2247 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2249 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2251 * src/modest-tny-account-store.c:
2252 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2253 using a GError instead of a string message, so we can translate it in
2256 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2258 * src/maemo/modest-address-book.c:
2259 (modest_address_book_check_names):
2260 * src/maemo/modest-msg-view-window.c:
2261 (modest_msg_view_window_clipboard_owner_change):
2262 * src/modest-init.c: (modest_init_init_ui):
2263 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2264 (update_folders_cb), (modest_mail_operation_update_account):
2265 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2266 (modest_ui_actions_on_msg_attachment_clicked),
2267 (modest_ui_actions_on_msg_recpt_activated):
2268 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2269 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2270 (modest_msg_view_search_next):
2271 * src/widgets/modest-recpt-editor.c:
2272 (modest_recpt_editor_on_button_release_event),
2273 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2274 g_message(). At this point we should only be seeing interesting errors on
2275 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2277 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2279 (modest_wizard_dialog_force_title_update):
2280 * src/maemo/easysetup/modest-wizard-dialog.h:
2281 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2282 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2283 can update the title when appropriate. Otherwise the title is wrong if the
2284 pages are added after adding the notebook to the dialog.
2285 This must be a problem in HildonWizardDialog too.
2286 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2288 * src/maemo/easysetup/modest-easysetup-wizard.c:
2289 (create_subsequent_customsetup_pages),
2290 (create_subsequent_easysetup_pages):
2291 Call modest_wizard_dialog_force_title_update() so that the title is
2292 correct even with GTK+ < 2.10.
2293 This fixes projects.maemo.org bug NB#56145 .
2295 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2297 * src/maemo/modest-platform.c:
2298 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2299 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2302 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2304 * src/widgets/modest-window.h:
2305 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2306 and modest_window_save_state(), which invokes it.
2308 * src/widgets/modest-window-mgr.h:
2309 * src/widgets/modest-window-mgr.c:
2310 Added modest_window_mgr_save_state_for_all_windows(), which calls
2311 the save_state vfunc on all registered windows, if implemented.
2313 * src/gnome/modest-msg-edit-window.c:
2314 * src/gnome/modest-msg-view-window.c:
2315 * src/maemo/modest-msg-edit-window.c:
2316 * src/maemo/modest-msg-view-window.c:
2317 * src/maemo/modest-main-window.c:
2318 Specify the existing save_settings functions as implementations of
2319 ModestWindow::save_state_func().
2321 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2322 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2323 enabling hibernation, for instance.
2325 We may need to do the same thing for restoring settings.
2328 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2330 * src/widgets/modest-window-mgr.c:
2331 * src/widgets/modest-window-mgr.h:
2332 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2333 modest_window_mgr_get_hibernation_is_prevented().
2335 * src/maemo/modest-main-window.c:
2336 (on_hildon_program_is_topmost_notify): Prevent hibernation
2337 (possible when the application goes to the background in the WM),
2338 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2340 * src/maemo/easysetup/modest-easysetup-wizard.c:
2341 (modest_easysetup_wizard_dialog_init):
2342 * src/maemo/modest-account-settings-dialog.c:
2343 (modest_account_settings_dialog_init):
2344 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2345 (modest_connection_specific_smtp_edit_window_init):
2346 * src/maemo/modest-connection-specific-smtp-window.c:
2347 (modest_connection_specific_smtp_window_init):
2348 * src/maemo/modest-signature-editor-dialog.c:
2349 (modest_signature_editor_dialog_init):
2350 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2351 prevent hibernation while any of these account settings dialogs are open.
2353 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2355 * src/maemo/Makefile.am:
2356 * src/maemo/modest-osso-state-saving.c:
2357 * src/maemo/modest-osso-state-saving.h: Added
2358 modest_osso_load_state() and modest_osso_save_state() though they do
2359 nothing now. They should iterate through all the open windows and load/save
2361 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2362 save state when closing.
2364 * src/maemo/modest-main-window.c:
2365 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2366 Add a notification handler for the HildonProgram::is-topmost property,
2367 so we can allow hibernation when the application goes into the background.
2368 But we still need to detect when the accounts setup windows are open so
2369 we can stop hibernation when they are open.
2370 To do this, I also added the main window the HildonProgram. This might have
2371 other side-effects/benefits, and should maybe be done for other windows.
2373 * src/maemo/modest-osso-autosave-callbacks.h:
2374 * src/maemo/modest-osso-autosave-callbacks.c:
2375 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2376 though it does not do anything yet, and we might never need this to do
2377 anything. For instance, we already save drafts.
2379 * src/maemo/modest-platform.c: (modest_platform_init):
2380 Specify the libosso auto-save callback.
2382 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2384 * src/maemo/modest-platform.c:
2385 (modest_platform_set_update_interval):
2386 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2387 aparently stays valid between application instances, so we can use this
2388 to remove and reset it later. According to a maemo-developers email from
2391 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2393 * configure.ac: Depend on libalarm for Maemo.
2395 * src/dbus_api/modest-dbus-api.h:
2396 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2397 (on_send_receive), (modest_dbus_req_handler):
2398 Handle a SEND_RECEIVE D-Bus method.
2400 * libmodest-dbus-client/libmodest-dbus-client.c:
2401 (libmodest_dbus_client_send_and_receive):
2402 * libmodest-dbus-client/libmodest-dbus-client.h:
2403 Add C convenience functions for calling the new D-Bus method.
2405 * src/modest-platform.h:
2406 * src/gnome/modest-platform.c:
2407 * src/maemo/modest-platform.c:
2408 Added modest_platform_set_update_interval(), which uses the
2409 alarmd API on Maemo.
2410 (modest_platform_init),
2411 Call modest_platform_set_update_interval(), using a hard-coded
2412 interval for now (until the global settings dialog is implemented),
2413 though I am not sure that this makes sense yet.
2415 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2417 * src/dbus_api/modest-dbus-callbacks.c:
2418 (modest_osso_cb_hw_state_handler):
2419 * src/dbus_api/modest-dbus-callbacks.h:
2420 * src/maemo/modest-platform.c: (modest_platform_init):
2421 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2422 in case this has some effect on the ability for Maemo to ping the
2425 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2427 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2428 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2429 warning. It is probably a logic error, but I need to fix the build.
2431 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2433 * src/modest-account-mgr.h:
2434 * src/modest-account-mgr.c:
2435 (modest_account_mgr_account_names): Add a gboolean enabled_only
2436 parameter, so we can get lists of onlt the enabled accounts.
2438 (modest_account_mgr_add_account),,
2439 (modest_account_mgr_account_with_display_name_exists):
2440 * src/maemo/modest-msg-edit-window.c: (get_transports):
2441 * src/modest-account-mgr-helpers.c:
2442 (modest_account_mgr_set_first_account_as_default):
2443 * src/modest-init.c: (init_default_account_maybe):
2444 * src/modest-tny-account-store.c: (get_accounts):
2445 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2446 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2447 * tests/check_account-mgr.c: (START_TEST):
2448 Provide the extra parameter, as appropriate.
2450 * src/widgets/modest-account-view.c: (update_account_view):
2451 Do not show disabled accounts (meaning that there is no way to
2452 enable/disable accounts in the UI (the feature is not in our UI
2453 specification), so we can use this internally only to mark unfinished
2454 or temporary account data.
2456 * src/maemo/easysetup/modest-easysetup-wizard.c:
2457 (create_account): Add boolean enable parameter, so we can specify FALSE
2458 to create the temporary account.
2459 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2460 (on_before_next): When finishing, when there is a temporary account, just
2462 Also, use a timeout to delay the showing of the dialog until gconf is likely
2463 to return correct information, due to a maemo gconf bug that is fixed in
2464 osso 1.1, but not yet in Bora.
2465 However, the dialog stays on screen after it is destroyed.
2467 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2468 for invalid data when cancelling. Use a hildon note instead of a dialog
2469 to complain about invalid data. Do not show the account-saved note if the
2470 account is disabled (a temporary account that will not really be saved for use
2473 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2475 * src/modest-account-mgr-helpers.h:
2476 * src/modest-account-mgr-helpers.c:
2477 Added modest_account_mgr_unset_default_account(),
2478 Added modest_account_mgr_set_first_account_as_default().
2480 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2481 If it was the default account, unset the default account name.
2483 * src/maemo/modest-account-view-window.c:
2484 (on_delete_button_clicked): If it was the default account,
2485 set the first remaining account as the default instead.
2487 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2488 a NULL account or a NULL default account, to prevent a crash. This should
2489 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2492 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2494 * src/widgets/modest-recpt-editor.c:
2495 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2496 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2497 TODO comment for this. This fixes the build.
2499 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2500 be the best place for it. This will in future update all auto-update accounts,
2501 rather than just the current/default account, when that gconf key exists.
2502 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2503 if there are no accounts, before calling do_send_receive().
2504 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2506 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2507 * src/maemo/modest-main-window-ui.h:
2508 * src/maemo/modest-main-window.c: (on_connection_changed),
2509 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2510 directly, becaue the signal handler does more.
2512 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2514 * src/modest-account-mgr-helpers.c:
2515 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2516 for the case that the account does not exist.
2518 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2519 (equivalent to the modest account name) rather than the tinymail account name
2520 (equivalent to the modest account title - human readable) to get the account data.
2521 Check for null account data to prevent the crash, and add a TODO comment saying that
2522 this needs fixing because it is using the server account name instead of the account name.
2524 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2526 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2527 * src/maemo/modest-account-settings-dialog.c: (show_error),
2529 Use hildon_note_new_information() for informative and error messages,
2530 which seems to be expected for Maemo applications (no documentation that I know of
2531 says this). I am surprised that there is no distinction between info and error
2534 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2536 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2537 it is easy to find where this is used.
2539 * src/maemo/easysetup/modest-easysetup-wizard.c:
2540 (create_page_welcome), (create_page_account_details),
2541 (create_page_user_details), (create_page_complete_easysetup),
2542 (create_page_custom_incoming), (create_page_custom_outgoing),
2543 (create_page_complete_custom):
2544 * src/maemo/modest-account-settings-dialog.c:
2545 (create_page_account_details), (create_page_user_details),
2546 (create_page_incoming), (create_page_outgoing):
2547 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2548 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2549 (modest_connection_specific_smtp_edit_window_init):
2550 * src/maemo/modest-connection-specific-smtp-window.c:
2551 (modest_connection_specific_smtp_window_init):
2552 * src/maemo/modest-signature-editor-dialog.c:
2553 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2554 and scrolling policy as per the Email Application Layout Guide, if I have
2557 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2559 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2560 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2561 which were empty, because these vfuncs have been removed from TnyAccountStore.
2562 This fixes the build.
2564 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2566 * src/maemo/modest-main-window.c:
2567 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2568 showing/hiding it. Added TODO because it probably should not be NULL.
2569 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2570 because unnecessary g_warnings() make degugging difficult.
2572 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2574 * src/maemo/modest-msg-edit-window.c:
2575 (modest_msg_edit_window_select_color),
2576 (modest_msg_edit_window_select_background_color): 2 const corrections and
2577 moving 2 #endifs before closing brackets, to fix the build.
2579 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2581 * src/maemo/easysetup/modest-easysetup-wizard.h:
2582 * src/maemo/easysetup/modest-easysetup-wizard.c:
2583 (modest_easysetup_wizard_dialog_finalize),
2584 (on_button_edit_advanced_settings), (create_page_complete_custom),
2585 (on_response), (create_account):
2586 Implement the Advanced Settings edit button, by saving the account information,
2587 for the Advanded Settings dialog to use directly from gconf, and removing it
2588 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2589 Bug #5533 in the projects.maemo.org bugzilla.
2591 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2593 * src/maemo/modest-msg-view-window.c:
2594 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2595 when opening a message window.
2597 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2599 * src/maemo/easysetup/modest-easysetup-wizard.c:
2600 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2603 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2604 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2605 gconf settings. I probably added more checks than necessary, but that is safer.
2607 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2608 variable to fix the build, but this seems to be used when it is still NULL.
2610 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2612 * src/modest-platform.h:
2613 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2614 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2615 * src/modest-main.c: Implement this function so we can avoid using
2616 maemo-specific API from cross-platform code.
2618 * src/modest-tny-account-store.c:
2619 (get_smtp_specific_transport_account_for_open_connection):
2620 * src/modest-ui-actions.c: (check_for_connection),
2621 (modest_ui_actions_on_item_not_found):
2622 Use modest_platform_connect_and_wait() and put #idefs around other
2623 maemo-specific code, because only maemo currently has a way to
2624 identify connection names.
2626 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2628 * src/modest-tny-account-store.h:
2629 * src/modest-tny-account-store.c:
2630 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2631 the connection-specific SMTP server settings in the configuration.
2633 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2635 * src/maemo/modest-main-window.c: (on_connection_changed),
2637 * src/modest-main.c: (main), (start_ui), (send_mail):
2638 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2639 that is what is intended.
2641 * src/modest-ui-actions.c: (action_send), (action_receive),
2642 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2643 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2644 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2645 SMTP server is used when it is specified.
2647 (modest_ui_actions_on_send_receive):
2648 Check that a connection is open before proceeding.
2649 Receive and then send, instead of vice-versa, as per the specification.
2651 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2653 * src/modest-mail-operation.c:
2654 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2655 though I guess it should be something other than NULL.
2657 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2659 * src/maemo/easysetup/modest-easysetup-wizard.c:
2660 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2661 combo twice, to avoid an g_warning and to make it visible again.
2662 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2663 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2664 (already intended) dereference when detaching, because we then recreate the menu.
2665 But I am not sure why the warning was happening, and it is possible that this is a memory
2668 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2670 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2671 and uri_parse_mailto() utility functions.
2672 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2674 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2676 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2678 * src/dbus_api/modest-dbus-api.h:
2679 * src/dbus_api/modest-dbus-callbacks.c:
2680 Use an idle callback to execute the modest code in the application's own thread.
2681 Remove the helloworld example method.
2682 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2683 parsed, and the open-message method is not implemented because this is not yet implemented in
2685 * libmodest-dbus-client/libmodest-dbus-client.c:
2686 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2687 (libmodest_dbus_client_open_message):
2688 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2690 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2691 body without crashing.
2693 * tests/dbus_api/Makefile.am:
2694 * tests/dbus_api/test_mail_to.c:
2695 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2697 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2699 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2700 Added file to fix the build. Sorry.
2702 * src/dbus_api/Makefile.am:
2703 * src/dbus_api/modest-dbus-api.h:
2704 * src/dbus_api/modest-dbus-callbacks.h:
2705 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2706 (modest_dbus_req_handler):
2707 Put constants in a separate header so it can be reused by the
2708 client library, without duplication
2710 * libmodest-dbus-client/Makefile.am:
2711 * libmodest-dbus-client/libmodest-dbus-client.c:
2712 (libmodest_dbus_client_call_helloworld),
2713 (libmodfest_dbus_client_send_mail),
2714 (libmodfest_dbus_client_mailto),
2715 (libmodfest_dbus_client_open_message):
2716 * libmodest-dbus-client/libmodest-dbus-client.h:
2717 (Partly) Implement a send_mail D-Bus method.
2719 * tests/dbus_api/Makefile.am:
2720 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2721 the send_email D-Bus method.
2723 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2727 * libmodest-dbus-client/Makefile.am:
2728 * libmodest-dbus-client/libmodest-dbus-client.c:
2729 * libmodest-dbus-client/libmodest-dbus-client.h:
2730 * tests/dbus_api/Makefile.am:
2731 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2732 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2734 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2736 * src/maemo/easysetup/modest-easysetup-wizard.c:
2737 (create_page_account_details):
2738 * src/maemo/modest-account-settings-dialog.c:
2739 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2740 widgets, because this might not be the default in future versions of the Maemo GTK+.
2741 However, I can not not get capitalization to work even in a simple test case.
2743 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2745 * src/maemo/easysetup/modest-easysetup-wizard.c:
2746 (create_page_custom_incoming), (create_page_custom_outgoing):
2747 * src/maemo/modest-account-settings-dialog.c:
2748 (create_page_account_details), (create_page_incoming),
2749 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2750 instead of using gtk_check_button_with_label(), so they are aligned like the other
2751 widgets, as per the UI spec.
2753 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2755 * src/maemo/easysetup/modest-easysetup-wizard.c:
2756 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2757 * src/widgets/modest-validating-entry.c:
2758 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2759 Modest prefix instead of an EasySetup prefix.
2761 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2763 * src/widgets/modest-validating-entry.h:
2764 * src/widgets/modest-validating-entry.c: (on_insert_text),
2765 Added easysetup_validating_entry_set_max_func(), used to set a callback
2766 to call when the max number of characters is reached. GtkEntry has a max-length
2767 already but is silent about it.
2769 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2770 (create_page_account_details), (create_page_user_details),
2772 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2773 (create_page_account_details), (create_page_user_details),
2774 (create_page_outgoing):
2775 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2776 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2777 the UI spec, when the user tries to enter more than the max number of characters.
2779 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2781 * src/maemo/easysetup/modest-easysetup-wizard.c:
2782 (create_page_user_details), (create_page_custom_incoming),
2783 (create_page_custom_outgoing):
2784 * src/maemo/modest-account-settings-dialog.c:
2785 (create_page_user_details), (create_page_incoming),
2786 (create_page_outgoing):
2787 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2788 (modest_connection_specific_smtp_edit_window_init):
2789 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2790 not appropriate. Bad Maemo-specific defaults!.
2792 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2794 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2795 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2796 (modest_signature_editor_dialog_set_settings):
2797 Disable the label and textview when the checkbox is disabled, and use the
2798 specified (UI spec) default signature text.
2800 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2802 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2803 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2805 * src/modest-defs.h:
2806 * src/modest-account-mgr-helpers.h:
2807 * src/modest-account-mgr-helpers.c:
2808 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2810 * src/maemo/Makefile.am:
2811 * src/maemo/modest-signature-editor-dialog.c:
2812 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2815 * src/maemo/modest-account-settings-dialog.h:
2816 * src/maemo/modest-account-settings-dialog.c:
2817 (modest_account_settings_dialog_finalize), (on_button_signature),
2818 (save_configuration): Use the new dialog when the Edit button is pressed, and
2819 save the changes if necessary, as per the UI spec.
2821 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2823 * src/maemo/Makefile.am:
2824 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2825 based on maemo-develoers email from Dirk.
2827 * src/maemo/easysetup/modest-easysetup-wizard.c:
2828 (create_page_welcome), (create_page_account_details),
2829 (create_page_user_details), (create_page_complete_easysetup),
2830 (create_page_custom_incoming), (create_page_custom_outgoing),
2831 (create_page_complete_custom),
2832 (modest_easysetup_wizard_dialog_init):
2833 * src/maemo/modest-account-settings-dialog.c:
2834 (create_page_account_details), (create_page_user_details),
2835 (create_page_incoming), (create_page_outgoing),
2836 (modest_account_settings_dialog_init):
2837 * src/maemo/modest-connection-specific-smtp-window.c:
2838 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2840 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2842 * src/maemo/easysetup/modest-easysetup-wizard.c:
2843 (create_page_account_details), (create_page_custom_outgoing),
2844 (create_page_complete_custom):
2845 * src/maemo/modest-account-settings-dialog.c:
2846 (create_page_user_details), (create_page_incoming),
2847 (create_page_outgoing):
2848 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2849 (modest_connection_specific_smtp_edit_window_init):
2850 Use the correct (UI spec) port min/max, and use horizontal separators,
2853 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2855 * src/maemo/easysetup/modest-easysetup-wizard.c:
2856 (set_default_custom_servernames):
2857 * src/maemo/modest-account-settings-dialog.c:
2858 (create_page_incoming), (on_combo_outgoing_security_changed),
2859 (on_combo_incoming_security_changed), (create_page_outgoing),
2860 (modest_account_settings_dialog_set_account_name),
2861 (save_configuration):
2862 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2863 (on_combo_security_changed),
2864 (modest_connection_specific_smtp_edit_window_init),
2865 (modest_connection_specific_smtp_edit_window_set_connection),
2866 (modest_connection_specific_smtp_edit_window_get_settings):
2867 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2870 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2873 * src/maemo/easysetup/modest-easysetup-wizard.c:
2874 (create_page_custom_outgoing), (create_page_complete_custom):
2875 * src/maemo/modest-account-settings-dialog.c:
2876 (create_page_user_details), (create_page_outgoing):
2877 * src/maemo/modest-account-view-window.c: (button_box_new):
2878 Use changed logical IDs as per the most recent UI spec:
2879 mcen_bd_emailsetup_edit -> mcen_bd_edit
2880 mcen_bd_emailsetup_delete -> mcen_bd_delete
2881 mcen_bd_emailsetup_close -> mcen_bd_close
2883 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2887 * src/dbus_api/Makefile.am:
2888 * src/dbus_api/modest-dbus-callbacks.c:
2889 * src/dbus_api/modest-dbus-callbacks.h:
2890 * src/maemo/modest-platform.c: (modest_platform_init):
2891 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2893 * tests/Makefile.am:
2894 * tests/dbus_api/Makefile.am:
2895 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2897 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2899 * src/maemo/modest-account-settings-dialog.c:
2900 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2901 Removed unnecessary includes.
2903 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2905 * src/maemo/easysetup/modest-easysetup-wizard.c:
2906 * src/maemo/modest-account-settings-dialog.c:
2907 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2908 * src/widgets/Makefile.am:
2909 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2910 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2911 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2912 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2913 * src/widgets/modest-secureauth-combo-box.c:
2914 * src/widgets/modest-secureauth-combo-box.h:
2915 * src/widgets/modest-serversecurity-combo-box.c:
2916 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2917 made the GObject names more consistent with the rest of the Modest code.
2919 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2921 * src/maemo/easysetup/Makefile.am:
2922 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2923 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2924 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2925 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2926 * src/maemo/easysetup/modest-easysetup-wizard.c:
2927 * src/maemo/easysetup/modest-validating-entry.c:
2928 * src/maemo/easysetup/modest-validating-entry.h:
2929 * src/maemo/modest-account-settings-dialog.c:
2930 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2931 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2932 widgets/ because they are used outside of easysetup too. After checking in,
2933 svn will allow me to rename them too.
2935 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2937 * src/gnome/modest-msg-edit-window.c:
2938 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2939 linker error, to fix the build on the GNOME platform.
2940 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2941 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2942 ifdefed out to avoid a warning.
2944 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2946 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2947 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2948 some alternative for GTK+ 2.6.
2950 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2952 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2954 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2955 specified for EmailAccountsDialog in UI spec.
2957 * src/maemo/easysetup/modest-easysetup-wizard.c:
2958 * src/maemo/easysetup/modest-easysetup-wizard.h:
2959 * src/maemo/modest-account-settings-dialog.c:
2960 * src/maemo/modest-account-settings-dialog.h:
2961 Reuse a member window widget for the connection-specific SMTP server accounts,
2962 so we can tell it to create/save the accounts only if we actually save changes.
2964 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2965 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2966 (modest_connection_specific_smtp_edit_window_get_settings):
2967 Return a struct instance for temporarily remembering the entered data.
2969 * src/maemo/modest-connection-specific-smtp-window.h:
2970 * src/maemo/modest-connection-specific-smtp-window.c:
2971 (modest_connection_specific_smtp_window_finalize),
2972 (modest_connection_specific_smtp_window_fill_with_connections),
2974 (modest_connection_specific_smtp_window_save_server_accounts),
2975 (update_model_server_names): Do not actually save data until asked,
2976 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2978 (on_selection_changed),
2979 (modest_connection_specific_smtp_window_init): Disable the edit
2980 button when nothing is selected.
2982 * src/modest-account-mgr-helpers.c:
2983 * src/modest-account-mgr-helpers.h:
2984 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2987 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2989 * src/modest-account-mgr-helpers.h:
2990 * src/modest-account-mgr-helpers.c:
2991 (modest_account_mgr_get_unused_account_name),
2992 (modest_account_mgr_get_unused_account_display_name): Added these
2993 utility functions, to avoid code duplication.
2995 * src/maemo/easysetup/modest-easysetup-wizard.c:
2996 (create_page_account_details), (create_account):
2997 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2998 (on_combo_security_changed),
2999 (modest_connection_specific_smtp_edit_window_init),
3000 (modest_connection_specific_smtp_edit_window_save_settings):
3001 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3002 * src/maemo/modest-connection-specific-smtp-window.c:
3003 (modest_connection_specific_smtp_window_finalize),
3004 (modest_connection_specific_smtp_window_fill_with_connections),
3005 (on_button_edit), (modest_connection_specific_smtp_window_init):
3006 * src/maemo/modest-connection-specific-smtp-window.h:
3007 Implementing saving of connection-specific server accounts.
3009 But I need to refactor this so we can save the data for each
3010 possible connection-specific account and only actually create the server accounts
3011 when the easysetup finished, or the OK button is pressed on the account settings
3014 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3016 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3017 (on_combo_security_changed):
3018 (modest_connection_specific_smtp_edit_window_init):
3019 Auto-fill the port number as in the account settings.
3021 (modest_connection_specific_smtp_edit_window_set_connection):
3022 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3023 * src/maemo/modest-connection-specific-smtp-window.c:
3024 (fill_with_connections), (on_button_edit),
3025 (modest_connection_specific_smtp_window_init):
3026 Turn the edit window into a dialog to simplify the code, and
3027 set a WM hint as in a GtkDialog, because only a popup can be on top of
3028 another window in Maemo, and popups usually have no WM decoration.
3030 * src/modest-defs.h:
3031 * src/modest-account-mgr-helpers.c:
3032 (modest_account_mgr_set_connection_specific_smtp),
3033 (modest_account_mgr_remove_connection_specific_smtp),
3034 (modest_account_mgr_get_connection_specific_smtp):
3035 * src/modest-account-mgr-helpers.h: Some functions to write the
3036 connection-specific SMTP server information. Not yet used.
3039 * src/widgets/modest-folder-view.c: (text_cell_data):
3040 Fix a warning about an uninitialized variable.
3041 (on_configuration_key_changed): Put an #ifdef around the use
3042 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3044 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3046 * src/maemo/modest-account-settings-dialog.h:
3047 * src/maemo/modest-account-settings-dialog.c:
3048 Added connect_for_modified() utility function to mark the new modified boolean.
3050 (create_page_account_details), (create_page_user_details),
3051 (create_page_incoming), (create_page_outgoing), (on_response),
3052 (modest_account_settings_dialog_init),
3053 (modest_account_settings_dialog_set_account_name):
3054 Only warn about unsaved changes when there are actually unsaved changes.
3056 * src/modest-account-mgr-helpers.c:
3057 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3058 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3059 to get the data from there in future.
3061 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3063 * src/modest-defs.h:
3065 * src/modest-account-mgr-helpers.h:
3066 * src/modest-account-mgr-helpers.c:
3067 Store the security account setting in a single conf key instead of using
3068 the options list, so that the list is left for just the to-be-removed camel hack,
3069 and because gconf_client_set_list() is failing for some reason.
3071 * src/modest-account-mgr.c:
3072 (modest_account_mgr_add_server_account):
3073 * src/maemo/modest-account-settings-dialog.c:
3074 (modest_account_settings_dialog_set_account_name),
3075 (save_configuration): Use the renamed functions.
3078 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3080 * src/widgets/Makefile.am:
3081 * src/widgets/modest-limit-retrieve-combo-box.c:
3082 * src/widgets/modest-limit-retrieve-combo-box.h:
3083 * src/widgets/modest-retrieve-combo-box.c:
3084 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3085 the account settings dialog.
3087 * src/modest-defs.h:
3088 * src/modest-account-mgr-helpers.h:
3089 * src/modest-account-mgr-helpers.c:
3090 (modest_server_account_get_option_secure_auth),
3091 (modest_server_account_set_option_secure_auth):
3092 * src/modest-account-mgr.c:
3093 (modest_account_mgr_add_server_account):
3094 Use the existing AUTH_MECH conf key for the secure-auth setting,
3095 instead of putting it in the list options, because this was actually used already.
3097 * src/maemo/modest-account-settings-dialog.c:
3098 (create_page_account_details),
3099 (modest_account_settings_dialog_set_account_name),
3100 (save_configuration):
3101 * src/maemo/modest-account-settings-dialog.h:
3102 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3103 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3105 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3107 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3108 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3109 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3111 * src/modest-defs.h:
3112 * src/maemo/modest-account-settings-dialog.c:
3113 (create_page_incoming), (on_combo_outgoing_security_changed),
3114 (on_combo_incoming_security_changed), (create_page_outgoing),
3115 (modest_account_settings_dialog_set_account_name),
3116 (save_configuration): Load/Save the port number, and change it when the
3117 security combo changes, to suitable defaults.
3119 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3121 * src/modest-account-mgr.c:
3122 (modest_account_mgr_add_server_account): Set the security and secure-auth
3123 options, and add a comment saying that the other camel-specific options should be
3126 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3128 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3130 * src/modest-tny-account-store.c: (account_list_free),
3131 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3132 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3135 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3137 * src/modest-protocol-info.c:
3138 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3139 is required by our UI spec. Maybe something in our implementation will use this eventually.
3140 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3141 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3142 instead of the previous 0 placeholder.
3144 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3145 secure-auth settings.
3146 * src/modest-account-mgr-helpers.h:
3147 * src/modest-account-mgr-helpers.c:
3148 (modest_server_account_data_get_option_secure_auth),
3149 (modest_server_account_set_option_secure_auth),
3150 (modest_server_account_data_get_option_security),
3151 (modest_server_account_set_option_security): Added this API for getting and setting the security
3152 and secure-auth settings.
3154 * src/maemo/modest-account-settings-dialog.h:
3155 * src/maemo/modest-account-settings-dialog.c:
3156 (modest_account_settings_dialog_finalize), (check_data),
3157 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3158 about changing titles.
3159 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3160 (save_configuration): Save the security and secure-auth settings.
3162 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3163 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3165 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3167 * src/modest-defs.h:
3168 * src/modest-account-mgr.c:
3169 (modest_account_mgr_add_server_account):
3170 Added and used defines for the options key and value pair strings,
3171 that are used so far, though they do not seem to correspond to anything in our
3172 UI specs or ModestProtocol enum.
3174 * src/modest-account-mgr-helpers.h:
3175 * src/modest-account-mgr-helpers.c:
3176 (compare_option_strings_for_name),
3177 (modest_server_account_data_get_option_value),
3178 (modest_server_account_data_get_option_bool),
3179 (modest_account_mgr_get_server_account_option):
3180 Added helper functions for parsing the options GSList.
3182 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3184 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3185 display name is based on the supplied account name.
3186 * src/modest-account-mgr.c:
3187 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3188 with an inefficient, but good-enough, implementation.
3190 * src/maemo/easysetup/modest-easysetup-wizard.c:
3191 (create_page_account_details), (on_before_next), (create_account):
3192 Check for existing display names rather than (non-user-visible) account names, and just
3193 create and set a unique account name at the end.
3195 * src/maemo/modest-account-settings-dialog.c:
3196 (modest_account_settings_dialog_init),
3197 (modest_account_settings_dialog_set_account_name),
3198 (create_page_incoming): Show the display name, instead of the account name.
3199 (on_response): Do some (not all) extra checks, as in the UI spec.
3200 (save_configuration): Save the display name if it was changed.
3202 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3204 * po/en_GB.po: Added needed logical ID and translation.
3205 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3206 (init_view): Made the is-default column clicking work.
3208 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3211 * src/maemo/easysetup/Makefile.am:
3212 * src/maemo/easysetup/modest-easysetup-wizard.c:
3213 (modest_easysetup_wizard_dialog_init):
3214 * src/maemo/easysetup/provider-data-test.keyfile:
3215 * src/maemo/easysetup/provider-data.keyfile:
3216 Moved the provider data file to the new modest-providers-data package and used it from there.
3218 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3220 * src/modest-local-folder-info.c:
3221 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3222 N_() was already used on the static strings, but this just marks it for translation without
3223 using the translation.
3225 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3227 * src/maemo/modest-account-settings-dialog.c:
3228 (create_page_incoming),
3229 (modest_account_settings_dialog_set_account_name):
3230 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3231 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3232 I will do this if nobody else gets there first.
3234 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3236 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3237 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3238 save the security stuff.
3240 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3242 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3243 Set the email address and user fullname, which I now see must be
3246 * src/maemo/modest-account-settings-dialog.h:
3247 * src/maemo/modest-account-settings-dialog.c:
3249 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3250 leave-on-server and authentication.
3251 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3254 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3257 * src/maemo/modest-account-settings-dialog.c:
3258 * src/maemo/modest-account-settings-dialog.h:
3259 Most (but not all) of the widgets are now present as specified by the UI spec.
3260 No changes are yet saved, and some details are not properly shown yet.
3262 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3264 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3266 * src/maemo/Makefile.am:
3267 * src/maemo/modest-account-settings-dialog.c:
3268 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3269 an existing account. Doesn't do much yet.
3271 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3272 Open the accounts settings dialog when Edit is clicked.
3274 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3276 * src/maemo/easysetup/Makefile.am:
3277 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3279 * src/maemo/easysetup/modest-easysetup-wizard.c:
3280 (modest_easysetup_wizard_dialog_init):
3281 Try to get the source directory from the build system,
3282 instead of hard-coding "./" into the source code, when opening our local
3283 copies of the configuration files.
3284 But this still fails when opening the wizard from the Accounts window,
3285 maybe because the working directory seems to change at runtime.
3286 So the wizard will fail the second time unless you copy the files into their
3287 proper locations - see the stdout warnings for the paths.
3289 (create_page_account_details),(on_before_next):
3290 Check for existing non-server accounts instead of server accounts,
3291 so the default account name is useful again, and to prevent trying to
3294 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3295 Show the wizard when New is clicked.
3297 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3298 (init_view): Show the column headers, and show the columns that are
3299 specified in the UI specs. However, something in Maemo's GTK+ prevents
3300 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3301 change the default account. This is despite unsetting the special properties.
3303 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3305 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3306 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3307 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3308 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3309 to make that clearer.
3310 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3312 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3314 * src/maemo/modest-account-view-window.c:
3315 (modest_account_view_window_init),
3316 (modest_account_view_window_new):
3317 Use the same buttons as specified in the
3318 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3319 the existing widgets, which never had a chance of working.
3320 Put the ModestAccountView treeview in a scrolled window.
3321 Do not repeat the initialization in both _init() and _new().
3323 * src/widgets/modest-account-view.c: (update_account_view):
3324 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3325 this widget and window shows no accounts.
3327 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3329 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3331 * src/maemo/easysetup/modest-easysetup-wizard.c:
3332 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3333 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3334 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3337 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3338 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3339 accounts exist yet, as in the UI spec.
3341 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3343 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3345 * src/maemo/Makefile.am:
3346 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3347 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3348 New window for editing connection-specific smtp details.
3349 Not fully implemented.
3351 * src/maemo/modest-connection-specific-smtp-window.c:
3352 (modest_connection_specific_smtp_window_finalize) :
3353 unref the tree model.
3354 (on_button_edit): Show the edit window.
3356 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3358 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3361 * src/maemo/Makefile.am:
3362 * src/maemo/modest-connection-specific-smtp-window.c:
3363 * src/maemo/modest-connection-specific-smtp-window.h:
3364 New window for showing the list of connections, for connection-specific
3365 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3366 * src/maemo/easysetup/modest-easysetup-wizard.c:
3367 (create_page_custom_outgoing): Show the new window when the button is clicked.
3369 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3371 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3372 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3373 * src/maemo/modest-msg-edit-window.c:
3374 (modest_msg_edit_window_insert_image):
3375 * src/modest-conf.c: (modest_conf_key_escape):
3376 * src/modest-mail-operation.c:
3377 (modest_mail_operation_send_new_mail):
3378 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3379 (modest_ui_actions_on_new_account):
3380 * src/widgets/modest-attachment-view.c: (update_filename_request):
3381 * src/widgets/modest-mail-header-view.c:
3382 Corrected warnings that were breaking the build, by commenting out unused variables,
3383 and a function, and by including a header.
3385 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3387 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3388 so we can #ifdef around platform-specific code when necessary.
3389 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3390 to allow this to build for the GNOME platform too.
3392 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3394 * src/maemo/easysetup/modest-easysetup-wizard.c:
3395 Added util_increment_name() and used it in create_page_account_details()
3396 to make sure that the default account name is always a new name.
3398 (modest_easysetup_wizard_dialog_init),
3399 (set_default_custom_servernames): Some minor memory management fixes.
3401 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3405 * src/modest-runtime.c: (init_i18n): Restored the translation
3406 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3407 are defined in config.h, and the translations are installed.
3409 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3410 is defined for translation.
3412 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3414 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3416 * src/maemo/easysetup/modest-easysetup-wizard.c:
3417 (modest_easysetup_wizard_dialog_init):
3418 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3419 Use realistic paths (though they should use $prefix generically) to the
3420 mcc_mapping and provider-data.keyfile files which might work when they
3421 are installed by the future version of the operator-wizard package,
3422 and then fallback to paths in our source code, with an explanatory
3425 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3429 * src/maemo/Makefile.am:
3430 * src/maemo/easysetup/: Added files from the previously-exernal
3431 osso-modest-easysetup.
3432 * src/maemo/modest-main-window-ui.h:
3433 * src/modest-ui-actions.c:
3434 * src/modest-ui-actions.h:
3435 Added modest_ui_actions_on_new_account() as a signal handler for the
3436 New Account menu item. It shows the easysetup wizard.
3437 * po/en_GB.po: Added additional needed logical IDs and translations.