1 2007-07-25 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (get_password):
4 Never save the entered username and password in gconf,
5 because the UI spec says we should not. This helps
6 slightly with projects.maemo.org bug NB#63671.
8 2007-07-25 Murray Cumming <murrayc@murrayc.com>
10 * src/widgets/modest-msg-edit-window.h:
11 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
12 Moved some code here to make it simpler.
13 (modest_msg_edit_window_attach_file_one): Renamed from
14 modest_msg_edit_window_attach_file_interactive().
15 (modest_msg_edit_window_offer_attach_file): Renamed from
16 modest_msg_edit_window_attach_file() and used
17 modest_msg_edit_window_attach_file_one() instead of
18 copy/pasting the code. The old code for one was not using
19 GnomeVFS. This allows use of smb:// URLs when using send-as
20 from external applications, fixing bug NB#63741.
22 (modest_msg_edit_window_insert_image),
23 (modest_msg_edit_window_add_attachment_clicked):
24 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
25 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
26 Adapted to the new function names.
28 2007-07-25 Murray Cumming <murrayc@murrayc.com>
30 (modest_platform_set_update_interval): Set the alarm recurrence
31 fields so that auto-update does not just happen the first time.
32 This should have fixed projects.maemo.org bug NB#63938.
34 When this happens you can see a printf when the D-Bus method is
36 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
38 However, I do not actually seem to get new POP messages even when
39 clicking the refresh button manually. A restart gets them.
40 This might be a problem in today's tinymail only.
42 2007-07-24 Murray Cumming <murrayc@murrayc.com>
44 * src/maemo/modest-maemo-global-settings-dialog.c:
46 Avoid a crash (probably only in scratchbox) when strcmp()ing a
47 NULL when closing the dialog.
49 2007-07-24 Murray Cumming <murrayc@murrayc.com>
51 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
52 Remove the hacky send/receive that didn't work, and instead
53 refilter the treemodel to make the deleted email really vanish from
54 the UI (though the delete-from-menu code does has commented out
55 the code that does that). This fixes projects.maemo.org bug
58 2007-07-24 Murray Cumming <murrayc@murrayc.com>
60 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
61 Try a couple of tricks to force the treeview to update (
62 poke the folder, and do a send/receive refresh), but the deleted
63 email still appears with a strike-through instead of really being
66 2007-07-23 Murray Cumming <murrayc@murrayc.com>
68 * src/dbus_api/modest-dbus-callbacks.c:
69 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
70 because their ID is not human-readable (see the comment about
71 improvements needed to the osso-email-interface API) and
72 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
74 2007-07-23 Murray Cumming <murrayc@murrayc.com>
76 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
77 (add_folders_to_list), (on_dbus_method_get_folders),
78 (modest_dbus_req_filter):
79 * src/maemo/modest-maemo-utils.c:
80 (on_camel_account_get_supported_secure_authentication):
81 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
82 (on_header_view_focus_in):
83 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
84 * src/modest-formatter.c: (modest_formatter_create_body_part):
85 * src/modest-mail-operation.c: (recurse_folders),
86 (update_account_thread), (get_msgs_full_thread),
87 (modest_mail_operation_get_msgs_full),
88 (modest_mail_operation_xfer_msgs):
89 * src/modest-search.c: (search_mime_part_and_child_parts),
90 (modest_search_account), (modest_search_all_accounts):
91 * src/modest-tny-account.c:
92 (modest_tny_account_get_special_folder), (recurse_folders):
93 * src/modest-tny-local-folders-account.c:
94 (modest_tny_local_folders_account_query_passes):
95 * src/modest-tny-msg.c: (copy_mime_part),
96 (modest_tny_msg_find_body_part_from_mime_part):
97 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
98 (modest_tny_send_queue_try_to_send):
99 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
100 (_modest_ui_actions_open), (download_uncached_messages),
101 (reply_forward), (modest_ui_actions_on_copy),
102 (modest_ui_actions_on_details), (has_retrieved_msgs),
103 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
105 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
106 (_selected_msg_marked_as), (_msg_download_completed),
107 (_selected_msg_sent_in_progress):
108 * src/widgets/modest-attachments-view.c:
109 (modest_attachments_view_set_message):
110 * src/widgets/modest-msg-view.c: (find_cid_image):
111 * tests/check_folder-transfer.c: (find_folders):
112 * tests/check_update-account.c: (func):
113 * tests/dbus_api/test_get_folders.c: (main):
114 Checked all uses of tny_iterator_get_current(), making sure
115 that the object is unreferenced (3 or 4 places did not),
116 and adding checks for NULL.
118 2007-07-23 Murray Cumming <murrayc@murrayc.com>
120 * src/dbus_api/modest-dbus-callbacks.c:
121 (on_idle_open_default_inbox): Make sure that the application UI is
123 * src/maemo/easysetup/modest-easysetup-wizard.c:
124 (on_entry_invalid_character): Show the word whitespace instead
125 of (null) in the banner when whitespace was entered.
126 (show_error): Add a comment that this does not work in
127 Maemo Bora, though we do not know why.
129 2007-07-23 Murray Cumming <murrayc@murrayc.com>
131 * src/modest-tny-account.c:
132 (modest_tny_account_get_special_folder): Use an if instead of
133 an assert for when the parent account name is NULL, because this
134 might be causing a crash in projects.maemo.org bug 63192.
135 * src/modest-mail-operation.c:
136 (modest_mail_operation_send_new_mail_cb),
137 (modest_mail_operation_remove_folder): unref the folder that is
138 returned from modest_tny_account_get_special_folder().
140 2007-07-23 Murray Cumming <murrayc@murrayc.com>
142 * src/modest-ui-actions.c:
143 (modest_ui_actions_on_password_requested):
144 Show mail_ib_login_cancelled info banner when the user cancels
145 the protected password dialog, to fix projects.maemo.org
148 2007-07-23 Murray Cumming <murrayc@murrayc.com>
150 * src/maemo/modest-account-settings-dialog.c:
151 (create_page_outgoing): Put this page in a GtkScrolledWindow,
152 matching the UI mock-up in the UI spec, and allowing access
153 to all widgets even when the on-screen keyboard is active.
155 2007-07-23 Murray Cumming <murrayc@murrayc.com>
157 Reverted this previous commit from Johannes,
158 because the scrollbars are always visible and because
159 I think we only need it on onepage of the account
160 settings, not the account wizard.
161 (I wrote the wrong instructions in the bug.)
163 * src/maemo/easysetup/modest-easysetup-wizard.c:
164 Added scrollbars to account wizard dialog.
165 Fixed projects.maemo.org NB #62744
167 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
169 * src/maemo/easysetup/modest-easysetup-wizard.c:
170 (create_page_user_details):
171 Use auto-cap for name (projects.maemo.org NB#63716)
172 * src/widgets/modest-account-view.c: (on_account_busy_changed):
174 2007-07-22 Armin Burgmeier <armin@openismus.com>
176 * src/maemo/modest-ui-actions.c: Use current account instead of
177 default account for creating viewer windows, so that the viewer
178 window knows to which account the viewed message belongs.
180 * src/maemo/modest-msg-view-window.c: Destroy the window when the
181 corresponding account is deleted. This fixes projects.maemo.org bug
184 2007-07-18 Armin Burgmeier <armin@openismus.com>
186 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
187 the dialog close after entering an invalid port number and clicking
188 OK. This fixes projects.maemo.org bug NB#63602.
190 2007-07-18 Armin Burgmeier <armin@openismus.com>
192 * src/modest-tny-account-store.c:
193 (get_server_accounts): Set parent modest account name for each
194 connection-specific transport account so that special folders of such
195 an account can be looked up. This fixes a crash when changing account
196 settings. This might also be related to projects.maemo.org bug
199 2007-07-16 Armin Burgmeier <armin@openismus.com>
201 * src/modest-ui-actions.c: Added a button to create a folder to the
202 move-to dialog. This fixes projects.maemo.org bug NB#.
204 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
206 * src/maemo/easysetup/modest-easysetup-wizard.c:
207 Added scrollbars to account wizard dialog.
208 Fixed projects.maemo.org NB #62744
210 2007-07-16 Murray Cumming <murrayc@murrayc.com>
212 * src/widgets/modest-msg-view.h:
213 * src/widgets/modest-msg-view.c:
214 Added modest_msg_view_get_message_is_empty() but this needs
216 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
217 Check if there is any text in the message yet.
218 But this needs to be implemented properly.
219 (modest_msg_edit_window_toggle_find_toolbar):
220 * src/maemo/modest-msg-view-window.c:
221 (modest_msg_view_window_toggle_find_toolbar):
222 Show a banner warning if there is no text to search, when
223 trying to start a search. This partially fixes
224 projects.maemo.org bug NB#62350.
226 2007-07-13 Murray Cumming <murrayc@murrayc.com>
228 * src/modest-mail-operation.c: (update_account_thread):
229 Initialized num_new_headers to fix the build.
231 2007-07-13 Murray Cumming <murrayc@murrayc.com>
233 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
234 Ignore modest accounts whose server accounts don't exist in gconf.
235 This prevents us trying to create TnyAccount instances for those
236 server accounts when the server account has been removed from gconf,
237 but the parent modest account has not yet been removed from modest.
238 I don't know why this is only noticeable now. It was probably just
239 a harmeless g_warning() anyway.
241 2007-07-13 Murray Cumming <murrayc@murrayc.com>
243 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
244 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
246 2007-07-12 Armin Burgmeier <armin@openismus.com>
248 * src/maemo/modest-main-window.c: Make default account appear bold
249 in view, tools/send & receive and toolbar/send & receive SCM menus.
250 This fixes projects.maemo.org bug NB#59010.
252 2007-07-12 Murray Cumming <murrayc@murrayc.com>
254 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
255 Add a short-cut, by checking if the folder store is an account.
256 This ensures that the Sort menu item and toolbar is dimmed for
257 the local-folders account root item, fixing
258 projects.maemo.org bug NB#62545.
260 2007-07-12 Murray Cumming <murrayc@murrayc.com>
262 * src/modest-tny-account-store.c: (get_password):
263 Show the password dialog (via the signal) only in the mainloop, via
264 an idle handler that we wait for. This could theoretically prevent
265 hangs, though I worry that it could introduce some too.
267 2007-07-12 Murray Cumming <murrayc@murrayc.com>
269 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
270 * src/maemo/modest-platform.c:
271 (modest_platform_connect_and_wait):
272 Take a TnyAccount* parameter and try to set it to online
273 (a TnyCamel-only API), because tinymail sets accounts to offline
274 when the user cancels a password dialog, and doesn't ask again until
275 it has been set to online.
276 However, this is commented out because it causes a hang now.
278 (modest_platform_connect_and_wait_if_network_account):
279 * src/modest-mail-operation.c:
280 (modest_mail_operation_update_account):
281 * src/modest-platform.h:
282 * src/modest-ui-actions.c: (_modest_ui_actions_open),
283 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
285 2007-07-12 Armin Burgmeier <armin@openismus.com>
287 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
289 * src/modest-mail-operation.c:
290 * src/modest-ui-actions.c: Check for already existing folder before
291 querying the server, show error message from camel if the request
292 still fails. This fixes projects.maemo.org bug NB#58701.
294 2007-07-12 Murray Cumming <murrayc@murrayc.com>
296 * src/modest-tny-account-store.h:
297 * src/modest-tny-account-store.c:
298 Added modest_tny_account_store_forget_password_in_memory(),
299 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
300 when creating a new account, so that new passwords will be used, instead of
301 us thinking that it's a second request as a result of a failed password again.
303 2007-07-12 Murray Cumming <murrayc@murrayc.com>
305 * src/dbus_api/modest-dbus-callbacks.c:
306 (on_idle_open_message): If the message is in drafts then open it
307 in an edit window instead of a view window. This fixes
308 projects.maemo.org bug NB#63005.
310 2007-07-12 Murray Cumming <murrayc@murrayc.com>
312 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
313 Avoided a harmless g_warning().
315 2007-07-12 Murray Cumming <murrayc@murrayc.com>
317 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
318 Pass the modest account name, not the TnyAccount display name to
319 modest_msg_view_window_new() so that the reply feature works,
320 fixing projects.maemo.org bug NB#62892.
322 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
323 (modest_msg_view_window_new_with_header_model):
324 * src/maemo/modest-msg-view-window.c:
325 (modest_msg_view_window_new_with_header_model),
326 (modest_msg_view_window_new):
327 * src/modest-ui-actions.c: (reply_forward):
328 * src/widgets/modest-msg-view-window.h:
329 * src/widgets/modest-window.c: (modest_window_set_active_account):
330 Rename an account parameter to modest_account_name to make this clearer.
332 2007-07-11 Murray Cumming <murrayc@murrayc.com>
334 * src/modest-ui-actions.h:
335 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
336 modest_do_message_delete().
337 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
338 Call modest_do_message_delete(), hoping that this would cause messages
339 to be really deleted from search instead of just marked with strike through.
340 Does not seem to help.
342 2007-07-11 Armin Burgmeier <armin@openismus.com>
344 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
345 priv->reselect to FALSE prior to calling
346 modest_folder_view_select_first_inbox_or_local() to prevent endless
347 recursion and thus a crash on startup.
349 2007-07-11 Armin Burgmeier <armin@openismus.com>
351 * src/maemo/modest-account-settings-dialog.h: Include
352 <gtk/gtknotebook.h> to fix the build (at least for me).
354 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
355 Use "New FolderN" as default suggested name if "New folder" already
356 exists, with N being the first free number, though never exceed "New
357 folder99" in which case we just fall back to "New Folder" even though
358 it already exists. This fixes projects.maemo.org bug NB#58663.
360 2007-07-11 Murray Cumming <murrayc@murrayc.com>
362 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
363 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
364 projects.maemo.org bug NB#62778.
366 2007-07-11 Murray Cumming <murrayc@murrayc.com>
368 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
369 Ignore the wrong (for now) secure-smtp setting in the presets -
370 just default to requiring secure authentication for SMTP, because
373 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
375 * src/widgets/modest-folder-view.c: (filter_row)
376 Do not show drafts folder (see UI specs)
378 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
380 * src/modest-ui-actions.c:
381 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
382 place and also not necessary.
384 * src/widgets/modest-folder-view.c: (filter_row)
385 Guess folder type and hide Sent & Outbox if necessary.
386 Fixed project.maemo.org NB#57328
388 2007-07-11 Murray Cumming <murrayc@murrayc.com>
390 * src/modest-ui-actions.h:
391 * src/modest-ui-actions.c:
392 (modest_ui_actions_on_delete_message):
393 Move some code into a new
394 modest_ui_actions_refresh_message_window_after_delete()
395 function so we can use it from elsewhere.
397 * src/dbus_api/modest-dbus-callbacks.c:
398 (on_idle_delete_message), (on_delete_message): Used an idle
399 handler, as we do for the other D-Bus method handlers.
400 Call modest_ui_actions_refresh_message_window_after_delete()
401 if the deleted message was open in a window. This fixed
402 projects.maemo.org bug NB#62862.
404 2007-07-11 Murray Cumming <murrayc@murrayc.com>
406 * src/modest-main.c: (main): Only show the UI at the start if
407 the showui command line option was given. For instance,
408 run-standalone src/modest showui
409 Otherwise, we wait for the top_application D-Bus method to
410 be sent by hildon-desktop when the application is selected
412 This allows us to run without a UI when osso-global-search
413 uses our D-Bus methods.
415 2007-07-11 Murray Cumming <murrayc@murrayc.com>
417 * src/dbus_api/modest-dbus-api.h: Added a define for a
418 top-application D-Bus method.
419 * src/dbus_api/modest-dbus-callbacks.c:
420 (on_top_application),
421 (modest_dbus_req_handler): Handle the top-application D-Bus
422 method, which might be an undocumented D-Bus signal sent by
423 hildon-desktop when it starts the application from the menu.
424 But I am not sure and I need to test it on the device, because
425 my scratchbox does not have the application in the menu now.
426 This method shows the main window, so that it can be invisible
427 when started, for instance, just for email searching from
430 * src/maemo/modest-main-window.c: (restore_settings),
431 (modest_main_window_new): Do not show the window immediately
432 upon creation. We show it later.
433 * src/modest-widget-memory.c: (save_settings_paned):
434 Try (unsuccessfully) to avoid saving the paned position when
435 it is not even visible.
436 (restore_settings_paned): Do not allow a silly paned position.
437 This seems necessary when not showing the window at first.
439 * tests/dbus_api/Makefile.am:
440 * tests/dbus_api/test_top_application.c: (main): Test for the
443 2007-07-10 Murray Cumming <murrayc@murrayc.com>
445 * src/modest-ui-dimming-rules.c:
446 (modest_ui_dimming_rules_on_new_msg),
447 (modest_ui_dimming_rules_on_reply_msg),
448 (modest_ui_dimming_rules_on_delete_msg),
449 (modest_ui_dimming_rules_on_details),
450 (modest_ui_dimming_rules_on_view_window_move_to),
451 (modest_ui_dimming_rules_on_view_previous),
452 (modest_ui_dimming_rules_on_view_next),
453 (_invalid_folder_for_purge): Added checks before
454 casting the window. This looks like an actual
455 logic error in _invalid_folder_for_purge(), because it
456 tries to use a ModestMainWindow as a message window.
458 2007-07-10 Murray Cumming <murrayc@murrayc.com>
460 * src/maemo/modest-account-settings-dialog.c:
461 (show_error): Use the same implementation as in
462 modest-easysetup-wizard.c:
463 (on_entry_invalid_character): The logical ID contains a %s.
464 Guessed what it should be.
465 (on_entry_max), (check_data), (on_response): Adapt to
466 changed show_error().
467 (create_page_account_details): Really call
468 modest_validating_entry_set_func() on the correct widgets.
469 * src/maemo/easysetup/modest-easysetup-wizard.c:
470 (on_entry_invalid_character): Fix the logical ID here too.
471 (create_page_account_details),
472 (create_page_user_details):
474 modest_validating_entry_set_func() on the correct widgets.
476 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
477 Do not try to use the account if it is NULL.
479 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
481 * src/modest-ui-actions.c: (create_move_to_dialog),
482 (modest_ui_actions_on_main_window_move_to),
483 (modest_ui_actions_on_msg_view_window_move_to):
484 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
485 (filter_row), (modest_folder_view_show_non_move_folders):
486 * src/widgets/modest-folder-view.h:
488 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
489 the Sent folder yet as it does not report the correct folder type.
491 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
493 * src/maemo/modest-msg-edit-window.c: (init_window):
496 2007-07-10 Murray Cumming <murrayc@murrayc.com>
498 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
499 Take a parent widget instead of a parent window, and
500 implement this with hildon_banner_show_information() instead.
501 Non-Maemo builds can just ifdef that there.
502 This fixed projects.maemo.org bug NB#62766.
504 (on_entry_invalid_character): Use show_error() again instead
505 of using hildon directly, and use the _CS() macro to use the correct
507 (create_account), (check_for_supported_auth_methods), (on_entry_max):
508 Pass a widget instead od a window to show_error().
510 2007-07-10 Murray Cumming <murrayc@murrayc.com>
512 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
513 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
514 This allows us to show the server name in the error message, fixing
515 projects.maemo.org bug NB#62904.
516 Also, use the appropriate logical ID message for the account protocol.
518 2007-07-10 Murray Cumming <murrayc@murrayc.com>
520 * src/modest-tny-account-store.c: (on_idle_wrong_password):
521 A compilation fix, though the build wasn't broken for me.
523 2007-07-09 Murray Cumming <murrayc@murrayc.com>
525 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
526 Do not try to unref a NULL folder store, to avoid a runtime warning.
527 This seems to happen sometimes when changing accounts settings.
529 2007-07-09 Murray Cumming <murrayc@murrayc.com>
531 * src/modest-tny-account-store.c:
532 (modest_tny_account_store_instance_init),
533 (modest_tny_account_store_finalize),
534 (on_account_settings_hide), (on_idle_wrong_password):
535 Use a GHashTable to ensure that we only show one account settings
536 dialog per modest account. This avoids us having a dialog open for
537 both the store and transport accounts, or due to repeated get_password()
538 calls that shouldn't happen anyway.
540 2007-07-09 Murray Cumming <murrayc@murrayc.com>
542 * src/maemo/modest-maemo-utils.c: (on_hide),
543 (modest_maemo_show_dialog_and_forget): Handle the response, because
544 the window is not even hidden by default.
546 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
547 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
548 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
549 which seems to prevent some modality problems.
551 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
552 Ignore user cancellation errors.
554 * src/modest-account-mgr-helpers.h:
555 * src/modest-account-mgr-helpers.c:
556 Added modest_server_account_get_password() and
557 modest_server_account_get_has_password() to avoid direct use of
560 * src/maemo/modest-account-settings-dialog.h:
561 * src/maemo/modest-account-settings-dialog.c:
562 (modest_account_settings_dialog_init): Store the notebook so we can
564 Added modest_account_settings_dialog_switch_to_user_info().
566 * src/modest-tny-account-store.c:
567 (get_password): When the password in the account settings is wrong (we think),
568 show the relevant page of the account settings dialog, in the mainloop.
569 However, we currently get many of these at once because cancel does not
571 (forget_password): Do not forget the password
572 from the account settings, because this causes side-effects when
573 tinymail seems to call it at strange time, maybe because of how we
574 are cancelling get_password().
575 (modest_tny_account_store_alert): Ignore user cancellations.
577 2007-07-09 Murray Cumming <murrayc@murrayc.com>
579 * src/maemo/modest-maemo-utils.h:
580 * src/maemo/modest-maemo-utils.c:
581 Added modest_maemo_show_information_note_and_forget() for use instead of
582 gtk_dialog_run() when the response is not needed, to avoid an extra
583 mainloop which could cause a hang.
585 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
586 Use the logical IDs for the error message, though they are not
587 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
588 because gtk_dialog_run() caused a hang here (the window did not close).
589 This fixes projects.maemo.org bug NB#62646.
591 2007-07-09 Murray Cumming <murrayc@murrayc.com>
593 * src/modest-account-mgr-helpers.h:
594 * src/modest-account-mgr-helpers.c:
595 Added modest_account_mgr_get_store_protocol().
597 * src/maemo/modest-account-view-window.c:
598 (on_delete_button_clicked): Show different warning text depending on
599 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
600 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
603 2007-07-09 Murray Cumming <murrayc@murrayc.com>
605 * src/maemo/modest-msg-edit-window.c:
606 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
607 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
609 2007-07-07 Armin Burgmeier <armin@openismus.com>
611 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
612 ckdg_ib_maximum_characters_reached from correct package.
614 * src/modest-ui-actions.c: Show an error message when a folder could
615 not be created. Tinymail does not give us specific error codes about
616 what has gone wrong, so we assume that a folder with that name
617 already exists, though there might be other reasons.
619 2007-07-06 Murray Cumming <murrayc@murrayc.com>
621 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
622 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
623 give a more exact error message that can be partly translated.
625 2007-07-05 Murray Cumming <murrayc@murrayc.com>
627 * src/maemo/modest-address-book.c:
628 (select_email_addrs_for_contact): Specify a default window size for the
629 select-email-address dialog, so that it is probably big enough for the
630 title. This should fix projects.maemo.org bug NB#62277.
632 2007-07-05 Murray Cumming <murrayc@murrayc.com>
634 * src/maemo/easysetup/modest-easysetup-wizard.c:
635 (create_page_complete_easysetup): Use
636 gtk_widget_set_size() request to ensure that the text wraps
639 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
641 * src/maemo/easysetup/modest-easysetup-wizard.c:
642 (on_entry_invalid_character), (create_page_account_details),
643 (create_page_user_details):
644 Use new API of ModestValidatingEntry. But for some reason the banner is
645 not shown. I will have to investigate that further.
647 * src/widgets/modest-validating-entry.c: (on_insert_text),
648 (modest_validating_entry_set_func):
649 * src/widgets/modest-validating-entry.h:
650 Added a new callback function to be able to react to prevented
651 characters whitespaces to e.g show a banner.
653 2007-07-05 Armin Burgmeier <armin@openismus.com>
655 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
656 notification of HildonNumberEditor instead of remembering the port
657 number. Thanks to Johannes for pointing this out.
659 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
661 * src/maemo/easysetup/modest-easysetup-wizard.c:
662 Check if there are any user changes before showing a confirmation
663 dialog (projects.maemo.org NB#60946)
665 2007-07-05 Armin Burgmeier <armin@openismus.com>
667 * src/maemo/modest-account-settings-dialog.c: Remember custom port
668 number at the beginning of the dialog and set the modified flag at the
669 end if the port number has changed. This is necessary because
670 HildonNumberEditor does not support notification when the value has
673 2007-07-05 Murray Cumming <murrayc@murrayc.com>
675 * src/modest-ui-actions.c:
676 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
677 a connection before asking anything else. Correct the check for the destination
678 folder so that it succeeds when online.
679 This fixed projects.maemo.org bug NB#61645.
681 2007-07-05 Murray Cumming <murrayc@murrayc.com>
683 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
684 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
685 to fix projects.maemo.org bug NB#62439.
687 2007-07-05 Murray Cumming <murrayc@murrayc.com>
689 * src/modest-tny-account.c: (on_connection_status_changed):
690 Really do not use tny_device_force_offline() here. See the previous comment.
692 2007-07-04 Murray Cumming <murrayc@murrayc.com>
694 * src/modest-tny-account.c: (on_connection_status_changed):
695 Do not use tny_device_force_offline() when tinymail says that something
696 went wrong with the connection. It seems to report this unnecessarily.
698 2007-07-04 Murray Cumming <murrayc@murrayc.com>
700 * src/maemo/modest-connection-specific-smtp-window.c:
701 (modest_connection_specific_smtp_window_init):
702 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
703 does not seem to have any effect in osso 1.1 (though it works in
704 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
706 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
708 * src/maemo/modest-connection-specific-smtp-window.c:
709 Fix UI specification problems with projects.meamo.org NB#60479
711 2007-07-04 Murray Cumming <murrayc@murrayc.com>
713 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
714 clue when this has failed, because the error dialog is not always shown
715 (at least in earlier version).
717 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
718 GError message, because the generic error dialog is not helpful.
720 'This message is not currently available (can't let a new connection go online)'
721 when trying to open an IMAP message.
723 (_modest_ui_actions_open): Offer a connection when some messages would
724 have to be downloaded and we are offline.
726 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
728 * src/widgets/modest-folder-view.c:
729 Don't check for MERGE type anymore as we use the correct type
731 NOTE: For the last two changes you need to update your tinymail copy
732 because of API changes!
734 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
736 * src/modest-tny-local-folders-account.c:
737 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
738 (see projects.maemo.org NB#61580)
740 2007-07-04 Murray Cumming <murrayc@murrayc.com>
742 * src/modest-tny-account.c: (on_connection_status_changed):
743 Commented out the call to modest_platform_connect_and_wait() because this
744 seems to always hang, and I would like to know if this is the only thing
745 that causes a hang when showing the connection dialog.
746 It is not very useful anyway.
748 2007-07-04 Murray Cumming <murrayc@murrayc.com>
750 * src/maemo/modest-msg-view-window.c:
751 (modest_msg_view_window_select_next_message):
753 * src/modest-platform.h:
754 * src/maemo/modest-platform.c:
755 Added modest_platform_connect_and_wait(), which calls
756 tny_maemo_conic_device_connect() always in the main thread, by calling it
757 in an idle handler and waiting for the idle handler to run. It should be
758 in the main thread because it uses GTK+ UI code. It just returns TRUE
759 if the device is already online.
761 There is some nasty code to ensure that subsequent calls to
762 modest_platform_connect_and_wait() just wait for the first one to finish,
763 by checking repeatedly in another idle handler. This is necessary,
764 because other threads (or even the main thread, via another idle handler)
765 can call modest_platform_connect_and_wait() while
766 modest_platform_connect_and_wait() is running.
768 (modest_platform_connect_and_wait_if_network_account),
769 (modest_platform_connect_and_wait_if_network_folderstore):
770 Convenience functions that calls modest_platform_connect_and_wait() if
771 the account or folder might want network access.
773 * src/modest-mail-operation.c:
774 (modest_mail_operation_update_account):
775 * src/modest-ui-actions.c: (download_uncached_messages),
776 (modest_ui_actions_on_rename_folder), (delete_folder),
777 (modest_ui_actions_on_main_window_move_to),
778 (modest_ui_actions_on_msg_view_window_move_to):
779 * src/widgets/modest-folder-view.c:
780 (drag_and_drop_from_folder_view):
781 Offer a connection if we are offline.
783 * src/modest-tny-account.c: (on_connection_status_changed):
784 Document this as only handling errors during network operations in progress,
785 and replace the idle code with a simple call to
786 modest_platform_connect_and_wait(), which does this instead.
788 2007-07-03 Murray Cumming <murrayc@murrayc.com>
790 * src/modest-tny-account.c:
791 (modest_tny_account_get_special_folder): (util_on_idle),
792 Handle the GError so we can see when tny_folder_store_get_folders()
793 fails, as it currently does while something else is connecting.
795 Added util_run_in_main_thread_and_wait()
796 which uses an idlen handler and mainloop to ensure that the function
797 is called in the main thread.
798 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
799 to make sure that we call attempt the connection in the mainloop only,
800 which might solve some hangs.
802 2007-07-03 Murray Cumming <murrayc@murrayc.com>
804 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
805 be found by their display name. This is never useful.
806 * src/modest-tny-account-store.c: (on_account_removed): Find the account
807 by its ID, instead of trying to use its ID as its display name.
809 * src/modest-tny-account-store.h:
810 * src/modest-tny-account.c:
811 (modest_tny_account_get_special_folder): Add a g_warning() when
812 tny_folder_store_get_folders() returns an empty list for the maildir.
814 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
815 Add a g_warning() when this returns NULL, because that it not allowed
818 2007-07-02 Armin Burgmeier <armin@openismus.com>
820 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
821 note when trying to cancel the wizard. This fixes projects.maemo.org
824 2007-07-02 Murray Cumming <murrayc@murrayc.com>
826 * src/modest-tny-account.h:
827 * src/modest-tny-account.c:
828 (modest_tny_account_new_from_server_account),
829 (modest_tny_account_new_from_server_account_name),
830 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
831 because this must now be set before setting the proto. This is usd in
832 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
833 warning in camel_session_get_service() caused by
834 tny_camel_transport_account_prepare().
836 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
839 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
841 * src/maemo/modest-connection-specific-smtp-edit-window.c:
843 (modest_connection_specific_smtp_edit_window_init):
845 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
848 2007-06-29 Murray Cumming <murrayc@murrayc.com>
850 * src/modest-tny-account.c:
851 (modest_tny_account_new_from_server_account):
852 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
853 now uses to request a connection when it needs one, and which it uses
854 to tell us that something is wrong with the connection, so we can force
855 the accounts offline to prevent further problems.
858 * src/modest-init.c: (init_default_settings):
859 * src/modest-mail-operation.c:
860 (modest_mail_operation_update_account):
861 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
862 This should not be necessary anymore. Do not set the conf key that
863 determined this (it was always TRUE and not set anywhere else).
865 * src/modest-ui-actions.h: Remove unused and unimplemented
866 modest_ui_actions_on_online_toggle_toggled().
868 2007-06-29 Murray Cumming <murrayc@murrayc.com
870 * src/maemo/modest-main-window.c: (connect_signals):
871 Don't connect to delete_event twice. Maybe this was harmless.
873 2007-06-29 Murray Cumming <murrayc@murrayc.com
875 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
876 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
877 Debug output to give some more clue when a folder move is not allowed.
879 2007-06-28 Murray Cumming <murrayc@murrayc.com
881 * src/modest-tny-account.c: (on_modest_file_system_info),
882 (modest_tny_account_get_mmc_account_name):
883 Always call the callback, without checking whether the name has changed.
884 * src/widgets/modest-folder-view.c: (strings_are_equal),
885 (on_model_foreach_set_name), (on_get_mmc_account_name),
886 (text_cell_data): Compare the name here, and use the name from
887 the account rather than from the
888 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
889 if the name was changed after the account was added to the model.
890 That's a tinymail bug but not one that I want to fix now.
892 This finally fixes projects.maemo.org bug NB#59301.
894 2007-06-27 Armin Burgmeier <armin@openismus.com>
896 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
899 2007-06-27 Murray Cumming <murrayc@murrayc.com
901 * src/modest-tny-account.h:
902 * src/modest-tny-account.c:
903 Added modest_tny_account_get_mmc_account_name(), to set the memory
904 card name asynchronously for the given account and then notify.
905 (modest_tny_account_new_for_local_folders): Use this new function instead
906 of using hildon_file_system_info_async_new() directly.
908 * src/widgets/modest-folder-view.c: (text_cell_data):
909 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
910 gtk_tree_model_row_changed() when it is available.
912 This should fix projects.maemo.org bug NB#59301.
914 2007-06-27 Murray Cumming <murrayc@murrayc.com
916 * src/modest-mail-operation.c: (update_account_thread),
917 (get_msgs_full_thread): Fix typo failures in the revert
920 2007-06-27 Murray Cumming <murrayc@murrayc.com
922 * src/maemo/modest-maemo-global-settings-dialog.c:
923 (idle_select_default_focus):
924 * src/modest-mail-operation.c: (idle_notify_progress),
925 (idle_notify_progress_once), (set_last_updated_idle),
926 (update_account_thread), (get_msgs_full_thread):
927 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
928 * src/widgets/modest-header-view.c:
929 (idle_notify_headers_count_changed_destroy),
930 (idle_notify_headers_count_changed):
931 Reverted the additions of gdk_threads_enter/leave(), in case this
932 helps with a startup hang on the device.
934 2007-06-26 Armin Burgmeier <armin@openismus.com>
936 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
937 for supported secure authentication methods from server by
938 gtk_dialog_run(), saving CPU time and a potential race condition.
940 2007-06-26 Armin Burgmeier <armin@openismus.com>
942 * src/maemo/modest-maemo-utils.h:
943 * src/maemo/modest-maemo-utils.c: Added a
944 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
945 only error code to tell the calling code when the user canceled the
948 * src/maemo/modest-account-settings-dialog.h:
949 * src/maemo/modest-account-settings-dialog.c:
950 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
951 message if the retrieval of secure authentication methods was canceled
952 by the user. Perform the check before saving anything to configuration
953 to not end up with half-committed configuration changes, do not show
954 a "Saving to configuration failed" note when authentication methods
955 could not be retrieved.
957 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
960 2007-06-26 Murray Cumming <murrayc@murrayc.com>
962 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
963 Only return the first level of folders under accounts, because the
964 osso-global-search UI spec doesn't want the rest.
965 This fixed projects.maemo.org bug NB#61811.
967 2007-06-26 Murray Cumming <murrayc@murrayc.com>
969 * src/modest-tny-account-store.c:
970 * src/modest-tny-account-store.h:
971 Added modest_tny_account_is_memory_card_account().
972 * src/maemo/modest-main-window.c: (create_details_widget):
973 Show the same information items for the memory card as we show for the
974 local-folders, to fix projects.maemo.org bug NB#59307.
976 2007-06-26 Murray Cumming <murrayc@murrayc.com>
978 * src/modest-tny-account-store.c: (get_password):
979 Added some checks for NULL to maybe prevent crashes, though I think
980 it was Philip's last commit that actually prevented the crash here
981 when creating a first new account.
982 But the new account is still not usable (no messages are shown)
983 until a restart of the application.
985 2007-06-26 Murray Cumming <murrayc@murrayc.com>
987 * src/maemo/modest-maemo-global-settings-dialog.c:
988 (idle_select_default_focus):
989 * src/modest-mail-operation.c: (idle_notify_progress),
990 (idle_notify_progress_once), (idle_notify_update_account_queue),
991 (set_last_updated_idle), (update_account_thread),
992 (notify_get_msgs_full), (get_msgs_full_destroyer),
993 (get_msgs_full_thread):
994 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
995 * src/widgets/modest-header-view.c:
996 (idle_notify_headers_count_changed_destroy),
997 (idle_notify_headers_count_changed):
998 Use gdk_threads_enter() and gdk_threads_enter_leave() in
999 all idle handlers, because some other thread could be blocking
1000 the GDK lock, so that it can do GUI stuff.
1002 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1004 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1005 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1006 (on_idle_send_receive), (on_idle_open_default_inbox):
1007 * src/maemo/modest-msg-edit-window.c:
1008 (modest_msg_edit_window_attach_file_noninteractive):
1009 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1010 to prevent a hang. I don't quite understand why these are necessary,
1011 beause we should already be in the main loop. I guess something outside
1012 of the main loop is taking the lock.
1014 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1015 we are really using URIs, and use files that are more likely to exist.
1017 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1019 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1020 necessary because configure.ac now defines different variables.
1022 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1024 * libmodest-dbus-client/libmodest-dbus-client.c:
1025 * libmodest-dbus-client/libmodest-dbus-client.h:
1026 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1027 libmodest_dbus_client_compose_mail() is what things actually use.
1029 * src/dbus_api/modest-dbus-api.h:
1030 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1031 * tests/dbus_api/Makefile.am:
1032 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1035 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1037 * src/modest-init.c: (modest_init_local_folders):
1038 For memory-card (or other non local-folders) maildir accounts,
1039 always create an Archive folder, so that there is somewhere to put
1040 messages. This should be less confusing, because the user does not need
1041 to guess that the need to create a folder.
1043 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1045 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1046 Fixed icon size by using (50, 50) which is the same as defined by
1049 2007-06-25 Armin Burgmeier <armin@openismus.com>
1051 * src/widgets/modest-window-mgr.c:
1052 * src/modest-init.c:
1053 * configure.ac: Correctly recognize hildon-notify presence and fixed
1054 the build without it being installed.
1056 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1058 * libmodest-dbus-client/libmodest-dbus-client.c:
1059 (libmodest_dbus_client_search): Fix the build. Sorry.
1060 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1061 (reply_forward_cb): Initialize variables to fix the build.
1063 * src/modest-tny-account-store.c:
1064 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1065 comparison (a silly typo) so that email search results can be opened
1066 when there are more than one account.
1068 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1070 * libmodest-dbus-client/libmodest-dbus-client.c:
1071 (libmodest_dbus_client_search),
1072 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1073 instead of 1 second, because the search gets folders and messages from
1074 the server, which can take a long time. When it times out,
1075 osso-global-search will report no results.
1077 We need to specify whether we should search only cached information
1078 (maybe with a user preference), and the osso-email-search-plugin
1079 API should really be improved to allow that option, and to allow results
1080 to be delivered asynchronously in batches.
1082 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1084 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1085 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1086 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1088 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1090 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1091 that is an empty string. D-Bus seems to give us these instead of NULL.
1093 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1095 * src/dbus_api/modest-dbus-callbacks.c:
1096 * src/maemo/easysetup/modest-easysetup-wizard.h:
1097 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1098 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1099 (modest_connection_specific_smtp_edit_window_init):
1100 * src/maemo/modest-maemo-global-settings-dialog.c:
1102 * src/maemo/modest-maemo-utils.c:
1103 (modest_maemo_utils_setup_images_filechooser):
1104 * src/maemo/modest-main-window.c: (create_details_widget):
1105 * src/maemo/modest-msg-edit-window.c:
1106 (modest_msg_edit_window_attach_file_noninteractive),
1107 (modest_msg_edit_window_color_button_change),
1108 (modest_msg_edit_window_set_zoom):
1109 * src/modest-mail-operation.c: (update_account_thread):
1110 * src/modest-tny-account-store.c:
1111 * src/modest-tny-account.c:
1112 * src/widgets/modest-global-settings-dialog.c:
1113 * src/widgets/modest-window.h:
1115 Fixed build on bora!
1117 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1119 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1120 * src/modest-search.c: (modest_search_folder),
1121 (modest_search_all_accounts): Actually search only in the specified folder,
1122 doing a simple match on the folder ID.
1123 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1124 and added some documentation.
1126 2007-06-22 Armin Burgmeier <armin@openismus.com>
1128 * src/maemo/modest-maemo-utils.h:
1129 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1130 modest_maemo_utils_get_supported_secure_authentication_methods.
1132 * src/maemo/easysetup/modest-easysetup-wizard.c:
1133 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1134 one occured, not just "Server does not support secure authentication".
1136 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1138 * src/modest-tny-account-store.c: (get_password):
1139 Restored the call to tny_account_set_user() because Philip seems to have
1140 stopped this from crashing (by not using the freed string). It still does
1141 not work, but now we can test it.
1143 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1145 * src/maemo/modest-msg-edit-window.c: (init_window):
1146 Comment out use of an uninitialzed GtkScrolledWindow variable,
1147 to fix the build and stop a crash. Yet again.
1149 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1151 * src/modest-tny-account-store.c: (get_password):
1152 Remove the call to tny_account_set_user() because this actually crashes.
1153 As mentioned in the last commit, it is known to not work anyway.
1155 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1157 * src/modest-tny-account-store.c: (get_password):
1158 Use tny_account_set_username() to tell tinymail that the username might
1159 have changed too. But tinymail ignores this: see projects.maemo.org
1161 * src/modest-ui-actions.c:
1162 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1163 reset the connection when changing the username, and improve the comments.
1164 Save the changed username to gconf at least, so it is used when Modest is
1167 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1169 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1170 Do not use a query, so that we get all folders, including for POP and
1171 local-folders. They work as search criteria too.
1172 This fixes projects.maemo.org bug NB#57740.
1174 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1176 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1177 Comment out the use of hildon_notification_set_sound() because it is
1178 not declared, to fix the build. Warnings are serious, people.
1180 2007-06-21 Armin Burgmeier <armin@openismus.com>
1182 * src/maemo/modest-maemo-utils.h:
1183 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1184 modest_maemo_utils_get_supported_secure_authentication_methods()
1185 to query authentication methods for a specific user. This should fix
1186 projects.maemo.org bug NB#61369.
1188 * src/maemo/easysetup/modest-easysetup-wizard.c:
1189 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1192 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1194 * libmodest-dbus-client/libmodest-dbus-client.h:
1195 * libmodest-dbus-client/libmodest-dbus-client.c:
1196 (modest_dbus_message_iter_get_search_hit),
1197 (libmodest_dbus_client_search):
1198 Reorganised and commented this.
1199 Removed modest_search_hit_free() from the public API because it
1202 Added libmodest_dbus_client_get_folders() and
1203 modest_folder_result_list_free().
1205 * src/dbus_api/modest-dbus-api.h:
1206 * src/dbus_api/modest-dbus-callbacks.c:
1207 (modest_dbus_req_filter): Commented. Moved most code to
1208 on_dbus_method_search() and added on_dbus_method_get_folders().
1210 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1211 of the extra D-Bus handler.
1213 * tests/dbus_api/Makefile.am:
1214 * tests/dbus_api/test_get_folders.c: New test for
1215 libmodest_dbus_client_get_folders(). This seems to return an empty list
1216 at the moment. That could be the same error that causes the message list
1217 to be empty sometimes.
1218 This should help with projects.maemo.org bug NB#57740.
1220 2007-06-21 Armin Burgmeier <armin@openismus.com>
1222 * src/modest-mail-operation.c: Do not call
1223 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1224 notify the operation's end after having set the status to CANCELED for
1225 the operation queue to listen on. This fixes a deadlock when there
1226 were mail operations in the queue during its finalization.
1228 * src/modest-singletons.c: Reordered uninitialization of the account
1229 manager to happen after the mail operation queue was uninitialized
1230 because the mail operation's in the queue might still try to access
1231 the account manager (see modest_mail_operation_notify_end()). This
1232 fixes a potential crash when terminating the application.
1234 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1236 * src/modest-search.c:
1237 (search_mime_part_and_child_parts): Moved some code here so we
1238 can search recursively in child folders.
1239 (modest_search_folder): Search in the message as a mime part, instead
1240 of just its child mime parts.
1241 (read_chunk), (search_mime_part_ogs):
1242 Check how many bytes were read, to prevent an endless loop.
1243 Searching in message bodies now works. This finishes the fix for
1244 projects.maemo.org bug NB#61007.
1246 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1248 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1249 Add a g_warning when the item is not a folder.
1251 * src/modest-ui-dimming-rules.c:
1252 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1253 when selected item is not a folder (for instance, an account), because
1254 the UI spec only talks about folders.
1255 I am not sure what the UI spec wants, so this might not totally fix
1256 projects.maemo.org bug NB#60794.
1258 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1260 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1261 (load_from_file): Sort the list. The unsorted list would be more noticeable
1262 in non-English locales.
1264 * src/maemo/modest-msg-edit-window.c:
1265 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1266 warning and fix the build.
1268 * src/maemo/modest-progress-bar-widget.c:
1269 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1270 avoid a g_warning, and probably to avoid a crash.
1272 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1274 * src/modest-search.c: (modest_search_folder): Check for a GError
1275 when calling tny_folder_get_headers(), to show that this is not the cause
1278 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1280 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1281 Actually set the body query instead of the subject query.
1283 * src/modest-search.c: (search_mime_part_ogs),
1284 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1285 which would probably cause it to fail if we got this far.
1287 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1288 to simplify the code.
1289 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1290 be causing search-in-body to fail.
1292 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1294 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1296 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1297 Better debug message when the folder cannot be found.
1298 This should help with fixing projects.maemo.org bug #61287.
1299 * src/modest-search.c: (add_hit): Do not leak the furl string.
1301 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1303 * src/modest-ui-actions.c:
1304 (modest_ui_actions_on_folder_selection_changed):
1305 Do not special-case TNY_MERGE_FOLDER here, because
1306 modest_tny_folder_get_account() already does that. This fixes
1307 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1308 shown when the Outbox was selected).
1310 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1312 * libmodest-dbus-client/libmodest-dbus-client.c:
1313 (_dbus_iter_get_string_or_null): Initialize the string variable in
1314 case this helps with Dirk's crash.
1316 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1318 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1319 though it is not implemented yet (this function is maybe not even used),
1320 to avoid breaking ABI in future.
1321 * libmodest-dbus-client/libmodest-dbus-client.c:
1322 (get_attachments_string): Moved some code into this generic function.
1323 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1324 sends email. It is maybe not used.
1325 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1326 (on_send_mail): Use attachments.
1328 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1329 * src/maemo/modest-msg-edit-window.c:
1330 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1331 a filename before using it, to fix projects.maemo.org bug NB#58233.
1333 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1335 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1336 Initialize the continue_download variable to fix the build, and probably
1337 to fix randome behaviour.
1339 2007-06-18 Armin Burgmeier <armin@openismus.com>
1341 * src/modest-tny-send-queue.h:
1342 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1343 the queue so we can later show it in the UI. Replaced
1344 modest_tny_send_queue_msg_is_being_sent() by
1345 modest_tny_send_queue_get_msg_status().
1347 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1349 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1350 gpointer. This probably was not harmful, but just to be sure.
1352 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1354 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1355 Fix the build, but leave the function broken on Bora, because
1356 hildon_uri_action_get_service() does not exist.
1357 osso_uri_action_get_service() does not exist either, it seems.
1359 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1361 * src/modest-tny-account.c:
1362 (modest_tny_account_new_from_server_account):
1363 Uncommented the url debug output again, because it is useful for
1364 debugging, as I said in the comment.
1366 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1368 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1370 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1371 for Mameo Bora, to fix the build.
1373 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1376 Fixed build with hildon < 0.99
1378 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1379 Check if the selected account is busy instead of checking all accounts
1381 * src/modest-account-mgr-priv.h:
1382 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1383 (modest_account_mgr_init), (compare_account_name),
1384 (modest_account_mgr_set_account_busy),
1385 (modest_account_mgr_account_is_busy):
1386 * src/modest-account-mgr.h:
1387 Added busy information to the account manager. It possible to
1388 set an account to busy or not busy now.
1390 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1391 (modest_mail_operation_update_account),
1392 (modest_mail_operation_notify_end):
1393 Set the account to busy/not busy depending on the operation state.
1395 * src/widgets/modest-account-view.c:
1396 (modest_account_view_finalize), (get_last_updated_string),
1397 (update_account_view), (on_account_busy_changed), (init_view):
1398 Show string "Refreshing..." if the account is currently busy.
1400 All this fixes projects.maemo.org bug NB#59711
1402 2007-06-14 Armin Burgmeier <armin@openismus.com>
1404 * src/widgets/modest-attachments-view.h:
1405 * src/widgets/modest-attachments-view.c: Added
1406 modest_attachments_view_has_attachments() and fixed coordinate
1407 transformation in get_att_view_at_coords(). This fixes attachment
1410 * src/widgets/modest-msg-view.c: Make use of
1411 modest_attachments_view_has_attachments() to decide whether to show
1412 attachments in the header.
1414 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1416 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1417 (on_change), (on_combo_security_changed),
1418 (modest_connection_specific_smtp_edit_window_init),
1419 (modest_connection_specific_smtp_edit_window_set_connection),
1420 (modest_connection_specific_smtp_edit_window_is_dirty):
1421 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1422 * src/maemo/modest-connection-specific-smtp-window.c:
1425 Show an comfirmation dialog for the smpt-edit-window if there are
1426 unsaved changes and the user hits cancel.
1427 (projects.maemo.org bug NB#60479)
1429 2007-06-14 Armin Burgmeier <armin@openismus.com>
1431 * src/maemo/easysetup/modest-easysetup-wizard.c:
1432 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1433 address" info in banner instead of node, and select all the text as
1434 per UI spec. This fixes projects.maemo.org bug NB#60550.
1436 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1438 reviewed by: <delete if not using a buddy>
1440 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1441 * src/modest-ui-actions.c: (folder_refreshed_cb):
1443 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1445 * src/widgets/modest-folder-view.c: (filter_row):
1446 Explictly filter out the per-account outbox accounts. I don't know why
1447 these only sometimes show up, but now they should never show up in the UI.
1448 This should fix projects.maemo.org bug NB#60160.
1450 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1452 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1453 when the toolbar does not exist yet.
1454 * src/modest-widget-memory.c: (save_settings_header_view):
1455 Added g_warnings() to help us to discover when we are trying to set
1456 an empty columns list in gconf.
1458 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1460 * src/modest-init.h:
1461 * src/modest-init.c:
1462 Added modest_init_get_default_header_view_column_ids().
1464 * src/modest-widget-memory.c: (restore_settings_header_view):
1465 Use the new function to get defaults, if the gconf key is empty,
1466 instead of not creating any columns. This seems to fix the
1467 empty right-hand pane problems.
1469 * src/widgets/modest-header-view.h: Improved documentation.
1471 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1473 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1474 Revert the use of the display name as the account name, because this
1475 is generally wrong and would break the code that follows.
1477 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1479 * src/maemo/easysetup/modest-easysetup-wizard.c:
1480 (check_for_supported_auth_methods), (on_before_next),
1483 More correct fix for projects.maemo.org bug NB# 58991
1484 Do not longer accept AUTH_PASSWORD as secure method and choose
1485 correct method when creating the account.
1487 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1489 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1490 Fixed projects.maemo.org bug NB# 58991
1492 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1494 * src/modest-init.c: (modest_init_init_core),
1495 (modest_init_local_folders): Fixed compilation errors.
1497 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1499 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1500 Remove unnecessary lib/include, though it is good in principle when needed.
1502 * src/modest-init.c: (modest_init_one_local_folder),
1503 (modest_init_local_folders):
1504 * src/modest-init.h: Initialize the .modest library for memory cards,
1505 instead of just doing nothing for them. This should allow us to create
1506 folders there, fixing projects.maemo.org bug NB#59297.
1508 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1510 * libmodest-dbus-client/libmodest-dbus-client.c:
1511 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1512 (libmodest_dbus_client_compose_mail),
1513 (libmodest_dbus_client_open_message),
1514 (libmodest_dbus_client_send_and_receive),
1515 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1517 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1518 (on_idle_open_message), (modest_dbus_req_handler),
1519 (search_result_to_message), (modest_dbus_req_filter):
1520 * src/modest-search.c: (add_hit), (modest_search_folder),
1521 (modest_search_all_accounts): Improved debug messages.
1523 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1525 * src/modest-tny-account-store.c:
1526 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1529 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1532 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1534 * src/modest-tny-account-store.c: (get_server_accounts):
1535 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1536 even when there are no accounts, so that the Outbox folder is always
1537 visible. This fixes projects.maemo.org bug NB#60158.
1539 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1541 * src/maemo/modest-main-window.c: (create_details_widget):
1542 Use the mcen_va_never logical ID.
1544 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1546 * src/dbus_api/modest-dbus-api.h:
1547 * src/dbus_api/modest-dbus-callbacks.c:
1548 (on_idle_open_default_inbox), (on_open_default_inbox),
1549 (modest_dbus_req_handler):
1550 Added a new OpenDefaultInbox method.
1552 * libmodest-dbus-client/libmodest-dbus-client.h:
1553 * libmodest-dbus-client/libmodest-dbus-client.c:
1554 Added libmodest_dbus_client_open_default_inbox() to call the new
1555 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1556 though it should maybe be used by a new osso-email-interface function.
1558 * tests/dbus_api/Makefile.am:
1559 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1562 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1564 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1565 NULL, so that the signals get all the keys. This should not actually
1566 change any behaviour because we currently update everything when anything
1569 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1571 * src/widgets/modest-folder-view.c: (text_cell_data),
1572 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1573 (find_inbox_iter): If tinymail tells us that the folder is
1574 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1575 This causes the inbox to be selected at startup, fixing part of
1576 projects.maemo.org bug NB#56305.
1578 * src/modest-ui-dimming-rules.c:
1579 (modest_ui_dimming_rules_on_tools_smtp_servers):
1580 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1581 the SMTP servers menu item.
1582 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1583 that the SMTP Servers menu item is dimmed when there are no accounts,
1584 as a future version of the UI spec will require. This fixes
1585 projects.maemo.org bug NB#56305.
1587 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1589 * src/maemo/modest-maemo-utils.c:
1590 (modest_maemo_utils_get_supported_secure_authentication_methods):
1591 Added label to dialog instead of unreadable title
1593 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1594 (modest_main_window_new):
1595 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1598 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1599 * src/modest-account-mgr.h:
1600 Added method to avoid code duplication
1602 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1603 (modest_ui_actions_on_send_receive):
1604 Use modest_account_mgr_has_accounts
1606 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1608 * src/maemo/easysetup/modest-presets.c:
1609 (modest_presets_get_info_server_security): Do not report secure auth
1611 * src/modest-protocol-info.c: Use the defines for the gconf key names
1612 for secure authentication. This was not working because we were writing
1613 Password and reading password, and the check was case sensitive.
1614 With this, gmail now works for receiving and sending when created via
1617 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1619 * src/maemo/easysetup/modest-presets.c:
1620 (modest_presets_get_info_server_security): Correct the key name for
1621 SecureSmtp, because it seems to be case-sensitive.
1622 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1623 Do not try to get the 0th notebook page if there are 0 pages, to
1624 avoid a g_warning().
1626 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1628 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1629 Prevent use of the new notification feature for now, because it currently
1630 shows one dialog for each new email, which is annoying.
1632 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1634 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1635 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1636 when no country was selected, so that we show the global ones.
1637 * src/maemo/easysetup/modest-presets.c:
1638 (modest_presets_get_providers): Return only the global providers, not
1639 all providers when mmc=0 was requested.
1641 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1643 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1644 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1645 provider ID in the combo.
1647 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1648 Do not show the page numbers, because it would be confusing when we add
1649 the 2 extra pages for the custom setup, when the user chooses the "Other"
1650 provider. This fixes projects.maemo.org bug NB#59028
1652 * src/modest-init.c: (modest_init_init_core),
1653 (modest_init_local_folders):
1654 * src/modest-init.h:
1655 * src/modest-tny-account.c:
1656 (modest_tny_account_new_for_local_folders): Do not create default folders
1657 for the memory card. This should fix projects.maemo.org bug NB#59328.
1659 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1661 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1662 Free the changed_conf_keys string items. They are already freed in the
1663 idle handler if that runs first.
1665 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1667 * src/modest-ui-actions.c:
1668 (modest_ui_actions_on_password_requested): Check that the server name
1669 is not NULL, because I just saw a password dialog with (null) as the
1672 * src/modest-tny-folder.[h|c]: Added
1673 modest_tny_folder_is_memory_card_folder().
1674 * src/modest-ui-dimming-rules.c:
1675 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1676 menu item for memory cards, as per the UI spec (section 7.4). This should
1677 fix projects.maemo.org bug NB#59297.
1679 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1681 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1682 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1683 is another problem with the code, see Murray's comment at line 772)
1685 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1687 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1688 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1689 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1690 (load_from_file), (easysetup_country_combo_box_init),
1691 (easysetup_country_combo_box_get_active_country_ids),
1692 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1693 instead of just one ID, to avoid duplicate country names in the UI.
1695 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1696 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1697 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1698 a single ID, avoiding duplicate providers.
1699 * src/maemo/easysetup/modest-easysetup-wizard.c:
1700 (on_combo_account_country): Adapt to use a list.
1702 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1704 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1705 keys changed in the last X seconds.
1707 * src/modest-account-mgr.h:
1708 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1709 (on_key_change), (modest_account_mgr_class_init),
1710 (modest_account_mgr_init), (modest_account_mgr_finalize):
1711 As the keys are changed, save them in a GSList* and signal that GSList*
1712 further every X seconds, to batch changes, to allow us to do just one
1713 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1714 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1716 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1717 changed signal signature.
1719 * src/modest-conf.c: (modest_conf_set_list),
1720 (modest_conf_on_change): Reenable notification.
1722 (modest_conf_maemo_fake_on_change): Comment out the hack that
1723 notified immediately instead of asynchronously.
1725 * src/widgets/modest-account-view.h:
1726 * src/widgets/modest-account-view.c:
1727 (update_account_view): Select the previously-selected account ID,
1728 if possible. This fixes projects.maemo.org bug NB#56933.
1730 (on_account_changed), (on_account_removed),
1731 (modest_account_view_select_account):
1733 Remove the block/unblock functions
1734 because they were not useful.
1736 * src/maemo/modest-account-view-window.c:
1737 (on_delete_button_clicked), (on_edit_button_clicked),
1738 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1740 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1742 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1743 Improve the error dialog to show Incorrect Account Settings, which seems
1744 clearer, and say that the internal error message (to be removed from the
1745 dialog later) is often misleading.
1746 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1748 * src/modest-tny-account.c:
1749 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1750 URL because this is so useful for debugging on the device.
1752 * src/widgets/modest-serversecurity-combo-box.c:
1753 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1755 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1757 * src/modest-mail-operation.c:
1758 (modest_mail_operation_send_new_mail):
1759 Added a comment about a nasty but apparently harmless message. Details
1760 added to the wiki g_warnings() page.
1762 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1764 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1765 (modest_tny_send_queue_class_init):
1766 Do not use the priv struct because it is empty, to avoid g_warnings
1767 about a non-existant priv struct.
1769 * src/modest-tny-account-store.c:
1770 (modest_tny_account_store_get_server_account),
1771 (modest_tny_account_store_get_transport_account_for_open_connection
1772 ): Do not try to get transport server accounts for local folders,
1773 because they don't have any. This avoids a g_warning().
1775 * src/maemo/modest-main-window.c:
1776 (modest_main_window_notify_send_receive_initied),
1777 (on_configuration_key_changed):
1778 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1779 * src/modest-defs.h:
1780 * src/modest-mail-operation.c:
1781 (modest_mail_operation_update_account):
1782 * src/modest-tny-account-store.h:
1783 * src/modest-tny-account.c:
1784 (modest_tny_account_get_special_folder),
1785 (modest_tny_account_new_for_local_folders),
1786 (modest_tny_account_new_for_per_account_local_outbox_folder):
1787 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1788 * src/modest-tny-local-folders-account.c:
1789 (add_account_folders_to_merged_folder):
1790 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1791 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1792 (modest_ui_actions_on_send):
1793 * src/widgets/modest-folder-view.c: (update_model):
1794 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1795 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1796 modest_tny_account_store_get_tny_account_by_account() to
1797 modest_tny_account_store_get_server_account() to make the code clearer.
1799 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1801 * src/dbus_api/modest-dbus-api.h:
1802 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1803 * src/maemo/modest-msg-edit-window.c:
1804 (modest_msg_edit_window_attach_file_noninteractive):
1805 added g_warning in case the file to be attached does not exist
1806 * tests/dbus_api/test_compose_mail.c: (main):
1807 removed obsolete comment, added generic files as test case
1809 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1811 * src/modest-tny-account-store.c: (get_server_accounts):
1812 Create the local folders account only once, not once for each outbox, and
1813 not only when there are some outboxes.
1815 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1817 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1818 code that is causing a crash at startup. Sergio says that he is fixing this.
1820 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1822 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1823 * src/maemo/modest-account-settings-dialog.c:
1824 (create_page_outgoing),
1825 (modest_account_settings_dialog_set_account_name),
1826 (save_configuration):
1827 - Fixed handling of the "Use secure authentication" toggle to comply with
1828 the ui specification. See also projects.maemo.org bug NB#58400
1830 - Restore the Secure connection setting combo correctly when loading
1833 * src/maemo/modest-maemo-utils.c:
1834 (on_camel_account_get_supported_secure_authentication),
1835 (modest_maemo_utils_get_supported_secure_authentication_methods):
1836 Fixed a crasher if operation is canceled
1838 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1839 (modest_protocol_info_auth_is_secure):
1840 * src/modest-protocol-info.h:
1842 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1843 the sense of the "Use secure authentication" toggle.
1845 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1847 * src/modest-tny-account-store.h:
1848 * src/modest-tny-account-store.c:
1849 Added modest_tny_account_store_get_local_folders_account().
1851 * src/modest-tny-folder.h:
1852 * src/modest-tny-folder.c:
1853 (modest_tny_folder_get_account):
1854 Added this replacement for tny_folder_get_account() which returns
1855 the local-folders account for TnyMergeFolders, to avoid the
1856 warning about the unimplemented get_account_func() vfunc().
1858 (modest_tny_folder_get_rules),
1859 * src/modest-ui-actions.c:
1860 (modest_ui_actions_on_folder_selection_changed):
1861 * src/modest-mail-operation.c:
1862 (modest_mail_operation_remove_folder),
1863 (modest_mail_operation_xfer_folder),
1864 (modest_mail_operation_rename_folder),
1865 (modest_mail_operation_get_msg),
1866 (modest_mail_operation_get_msgs_full),
1867 (modest_mail_operation_remove_msg),
1868 (modest_mail_operation_xfer_msgs),
1869 (modest_mail_operation_refresh_folder):
1870 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1872 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1874 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1875 (modest_server_account_set_security):
1876 * src/modest-defs.h: Add comments explaining that our
1877 UI spec means TLS when it says Normal, so these do not look like errors.
1879 * src/modest-tny-account.c:
1880 (modest_tny_account_new_from_server_account): Use the new tinymail
1881 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1882 for TLS. This should fix projects.maemo.org bug NB#58460.
1884 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1886 * src/maemo/easysetup/modest-easysetup-wizard.c:
1887 (create_account): Correct the position of the gconf sanity check warning.
1888 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1889 of using the g_idle_add() hack, because this does not seem to be necessary
1890 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1891 caused by something other than maemo's gconf.
1892 This fixes projects.maemo.org bug #59022.
1894 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1896 * src/modest-account-mgr-helpers.c:
1897 (modest_account_mgr_get_default_account): Do not check that the account
1898 exists if there is no default account (NULL), to fix a runtime warning.
1900 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1902 * src/widgets/modest-folder-view.c: (update_model):
1903 Do not unref the treemodel before we have finished with it.
1904 This prevents a valgrind warning and an occasional crash at startup.
1906 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1908 * libmodest-dbus-client/libmodest-dbus-client.h:
1909 added libmodest_dbus_client_compose_mail()
1910 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1912 added functions needed for SendAsMail() functionality
1913 * src/maemo/modest-msg-edit-window.c:
1914 (modest_msg_edit_window_attach_file_noninteractive):
1915 non interactively attaching files to message edit window
1916 * src/widgets/modest-msg-edit-window.h:
1917 * tests/dbus_api/Makefile.am:
1918 added test_compose_mail.c
1919 * tests/dbus_api/test_compose_mail.c: (main):
1921 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1923 * src/modest-account-view.c:
1924 Fixed bug projects.maemo.org bug NB#59307
1926 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1928 * src/maemo/easysetup/modest-easysetup-wizard.c:
1929 (get_serverport_incoming), (on_before_next), (create_account):
1930 * src/maemo/modest-account-settings-dialog.c:
1931 (modest_account_settings_dialog_set_account_name):
1932 * src/maemo/modest-maemo-utils.c:
1933 (on_camel_account_get_supported_secure_authentication_status),
1934 (on_camel_account_get_supported_secure_authentication),
1935 (on_secure_auth_cancel),
1936 (modest_maemo_utils_get_supported_secure_authentication_methods):
1938 Implemented security authentication for settings and easysetup.
1940 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1942 * src/maemo/modest-main-window.c: (create_details_widget):
1943 Show the total size for memory card accounts too, instead of showing
1944 the name again. Fixes bug projects.maemo.org bug NB#59307.
1946 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1949 * src/modest-tny-simple-folder-store.c:
1950 * src/modest-tny-simple-folder-store.h: Removed.
1952 * src/modest-tny-local-folders-account.h
1953 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1954 for the local-folders maildir, with an extra TnyMergedFolder containing
1955 the folders of the per-account outbox store accounts.
1956 * src/modest-tny-account-store.c: (get_server_accounts):
1957 Add the outboxes to the special local folders account after creating it.
1959 * src/modest-tny-account.c:
1960 (modest_tny_account_new_for_local_folders): Create the derived
1961 account when creating the main local-folders account.
1963 * src/maemo/modest-main-window.c: (create_details_widget),
1964 (modest_main_window_set_contents_style):
1965 Adapted to the use of the derived account instead of the folder store.
1967 * src/modest-ui-actions.c:
1968 (modest_ui_actions_on_folder_selection_changed):
1969 * src/modest-ui-dimming-rules.c:
1970 (modest_ui_dimming_rules_on_new_folder):
1971 * src/widgets/modest-folder-view.c: (text_cell_data),
1972 (icon_cell_data), (filter_row), (update_model),
1973 (get_cmp_rows_type_pos):
1976 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1977 Do not get the priv struct, because no priv struct has been set,
1978 to avoid a runtime warning.
1980 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1981 #ifelse with #else, to fix a warning, to fix the build.
1984 2007-06-05 Christian Kellner <ckellner@openismus.com>
1986 * libmodest-dbus-client/libmodest-dbus-client.c:
1987 Fix small typo in doc (why do you always see them
1988 AFTER committing stuff?)
1991 2007-06-05 Christian Kellner <ckellner@openismus.com>
1993 * libmodest-dbus-client/libmodest-dbus-client.c:
1994 (libmodest_dbus_client_search):
1995 Initialize hit list with NULL. Also set folder list
1996 to "" if NULL was supplied.
1999 2007-06-03 Christian Kellner <ckellner@openismus.com>
2001 * libmodest-dbus-client/libmodest-dbus-client.c:
2002 (modest_search_hit_list_free):
2003 Make it save to call it with NULL.
2005 * src/dbus_api/modest-dbus-callbacks.c:
2006 * src/modest-search.c:
2007 Return full ModestSearchHits as the search result list not TnyHeader
2008 since can't be around withouth the correspoding TnyFolder.
2010 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2012 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2013 Added currently commented code to check for secure auth
2015 * src/maemo/modest-account-settings-dialog.c: (on_response),
2016 (save_configuration), (show_ok):
2017 Fixed projects.maemo.org bugs NB #59248 and #59251
2019 * src/maemo/modest-maemo-utils.c:
2020 (on_camel_account_get_supported_secure_authentication_status),
2021 (on_camel_account_get_supported_secure_authentication),
2022 (modest_maemo_utils_get_supported_secure_authentication_methods):
2023 * src/maemo/modest-maemo-utils.h:
2024 Moved get_supported_secure_authentication() method here to be able
2025 to use it from easysetup wizard.
2027 * src/modest-pair.c: (on_pair_compare_as_string):
2028 Should compare string with first part of pair and not
2029 strcmp pairs which will crash.
2031 * src/modest-protocol-info.c:
2032 (modest_protocol_info_protocol_is_store):
2033 * src/modest-protocol-info.h:
2034 Added modest_protocol_info_get_auth_protocol_name()
2036 2007-06-03 Armin Burgmeier <armin@openismus.com>
2038 * src/modest-mail-operation.c:
2039 (modest_mail_operation_get_msgs_full): Set priv->account also when
2040 only retrieving a single message. This avoids a crash when canceling
2043 (modest_mail_operation_notify_end): Do not explicitely remove the
2044 operation from the queue but only emit the progress_changed signal.
2045 The queue itself listens to that signal to remove the operation when
2046 it is finished. This reduces coupling and removes a potential deadlock
2047 when modest_mail_operation_notify_end() is called from the queue
2048 itself. If that is a problem performance-wise, I would suggest to
2049 implement a status-changed signal or something.
2051 * src/modest-mail-operation-queue.c: Make sure to never call a
2052 function from another file while the queue is locked. This (hopefully)
2053 fixes another deadlock when exiting the application while retrieving
2056 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2058 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2059 Fixed build if libogs is not available
2061 2007-06-03 Christian Kellner <ckellner@openismus.com>
2063 * libmodest-dbus-client/libmodest-dbus-client.h:
2064 * libmodest-dbus-client/libmodest-dbus-client.c:
2065 (libmodest_dbus_client_delete_message):
2066 Implement deletion of messages (Client side).
2068 (modest_search_hit_free),
2069 (modest_search_hit_list_free):
2070 Utility functions to free the result hits.
2072 * src/dbus_api/modest-dbus-api.h:
2073 * src/dbus_api/modest-dbus-callbacks.c:
2074 (on_delete_message),
2075 (modest_dbus_req_handler):
2076 Implement deletion of messages (Server side).
2078 * tests/dbus_api/test_search.c: (main):
2081 * tests/dbus_api/Makefile.am:
2082 * tests/dbus_api/test_delete_message:
2083 Add little test for the message deletion logic
2085 2007-06-03 Armin Burgmeier <armin@openismus.com>
2087 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2088 when the operation queue was not empty. projects.maemo.org bug
2091 2007-06-03 Armin Burgmeier <armin@openismus.com>
2093 * src/widgets/modest-account-view.c
2094 (on_account_default_toggled): Toggle default account column
2095 explicitely instead of waiting for gconf notification (which is
2096 currently ignored). This should fix projects.maemo.org bug NB#56910
2097 for now. It should probably be removed when gconf notifications are
2100 2007-06-03 Christian Kellner <ckellner@openismus.com>
2102 * libmodest-dbus-client/libmodest-dbus-client.c:
2103 Removed debugging spew.
2105 * src/dbus_api/modest-dbus-callbacks.c:
2106 Added debugging info.
2108 * src/modest-search.c:
2109 (modest_search_all_accounts):
2110 Use tny_account_store_get_accounts () on the account store
2111 to get all accounts which is the way to get all accounts.
2113 * tests/dbus_api/test_search.c: (main):
2114 Make it possible to supply the search term on the command line.
2116 2007-06-03 Christian Kellner <ckellner@openismus.com>
2118 * libmodest-dbus-client/libmodest-dbus-client.c:
2119 * libmodest-dbus-client/libmodest-dbus-client.h:
2120 Implement searching for mesages over raw dbus. (Client side)
2122 * src/dbus_api/Makefile.am:
2123 * src/dbus_api/modest-dbus-api.h:
2124 * src/dbus_api/modest-dbus-callbacks.c:
2125 * src/dbus_api/modest-dbus-callbacks.h:
2126 Search framework (Server side). Also implement on_idle_open_message().
2128 * src/maemo/modest-platform.c: (modest_platform_init):
2129 Prepare for raw dbus/osso rpc interaction.
2131 * src/modest-search.h:
2132 Changed minsize from unspecific guint to guint32.
2134 * src/modest-search.c:
2136 Added strange hack which magically made tnymail work.
2138 (modest_search_folder),
2139 (modest_search_account),
2140 (modest_search_all_accounts):
2141 Implement helper functions to search all accounts, specific account
2144 * tests/dbus_api/Makefile.am:
2145 * tests/dbus_api/test_open_message.c:
2146 Read url to open from commandline.
2148 * tests/dbus_api/test_search.c:
2149 Implement small test for dbus search stuff
2151 2007-06-02 Armin Burgmeier <armin@openismus.com>
2153 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2154 include account type and account title. This fixes projects.maemo.org
2157 * src/maemo/modest-account-view-window.c: Set a title for the window.
2159 2007-06-02 Armin Burgmeier <armin@openismus.com>
2161 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2162 incoming and outgoing server name based on email address and server
2163 types as long as the names have not been edited manually. This fixes
2164 projects.maemo.org bug NB#58671.
2166 2007-06-02 Armin Burgmeier <armin@openismus.com>
2168 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2169 server type cannot be changed in future to the incoming details page
2170 when creating an account. This fixes projects.maemo.org bug NB#59029.
2172 2007-06-02 Armin Burgmeier <armin@openismus.com>
2174 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2175 and assigned max width chars so that they wrap instead of being
2176 truncated. Fixes projects.maemo.org bug NB#56126.
2178 2007-06-02 Armin Burgmeier <armin@openismus.com>
2180 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2181 introductory note to the connection specific smtp servers dialog, as
2182 section 8.12 of the email UI specification requires. This fixes
2183 projects.maemo.org bug NB#59212.
2185 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2187 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2188 Check for running mail operations, and offer to cancel them, as per the UI
2189 spec. This fixes projects.maemo.org bug NB#59041 .
2190 However, I suspect that tinymail may still use the network connection
2191 in ways that we cannot detect or cancel. But it should at least adapt to
2192 changes fairly well.
2194 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2196 * src/modest-tny-account-store.c: (recreate_all_accounts),
2197 (get_cached_accounts), (get_server_accounts): Do more sensible
2198 ref-counting of the temporarily-cached outbox accounts list. This seems
2199 to fix a crash when entering the password when the password was wrong.
2201 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2203 * src/gnome/modest-main-window.c: (connect_signals):
2204 * src/modest-tny-account-store.c: (get_password),
2205 (modest_tny_account_store_alert): Added comments and clues and
2206 commented-out code about how we currently fail to deal with connection
2207 errors and wrong passwords, and how we should.
2209 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2211 * src/widgets/modest-retrieve-combo-box.c:
2212 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2213 This fixes projects.maemo.org bug NB#58472 .
2215 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2217 * src/maemo/easysetup/modest-easysetup-wizard.c:
2218 (create_page_complete_easysetup):
2219 (create_page_complete_custom): Correct the last commit,
2220 putting the correct sentences in the correct pages.
2222 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2224 * src/maemo/easysetup/modest-easysetup-wizard.c:
2225 (create_page_complete_custom): Show the second sentence of text
2226 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2229 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2231 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2232 Set the leave-on-server conf key by default. This fixes
2233 projects.maemo.org bug NB#59258 .
2235 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2237 * src/maemo/modest-account-view-window.c:
2238 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2239 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2242 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2244 * src/maemo/easysetup/modest-easysetup-wizard.c:
2245 (create_caption_new_with_asterisk):
2246 * src/maemo/modest-account-settings-dialog.c:
2247 (create_caption_new_with_asterisk):
2248 Uncomment the code to add the asterisk, because they are no longer in the
2249 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2250 (update_incoming_server_title): Add an asterisk here too.
2252 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2254 * src/maemo/modest-maemo-global-settings-dialog.c:
2255 (current_connection): Check that we are even connected before trying to
2256 get the current connection name, to prevent a warning.
2258 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2259 Change the comments because tny_maemo_conic_device_connect() is now meant to
2261 * src/modest-mail-operation.c:
2262 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2263 make sure we have a connection and fail if we can't connect.
2265 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2267 * src/maemo/modest-main-window.c:
2268 (on_account_store_connecting_finished): Do not try to get the
2269 connection ID if we are not really connected. I am surprised that
2270 this signal handler is called when we are not connected.
2272 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2274 * src/modest-error.h:
2275 * src/modest-ui-actions.c:
2276 (modest_ui_actions_get_msgs_full_error_handler):
2277 Renamed an enum, added comments, added an enum
2278 for retrieve-limit errors.
2280 * src/modest-mail-operation.c: (foreach_add_item),
2281 (internal_folder_observer_update), (update_account_thread),
2282 (modest_mail_operation_get_msgs_full):
2283 (modest_mail_operation_update_account),
2284 Added comments about how this works, and some code that should
2285 (but does not) check the retrieve-limit. See the TODO comment.
2287 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2289 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2290 Initialize help_id to fix the build. Warnings are good.
2292 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2294 * src/widgets/modest-hbox-cell-renderer.c:
2295 (modest_hbox_cell_renderer_append):
2296 * src/widgets/modest-vbox-cell-renderer.c:
2297 (modest_vbox_cell_renderer_append):
2298 Fix the last commit by doing an extra ref.
2300 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2302 * src/widgets/modest-hbox-cell-renderer.c:
2303 (modest_hbox_cell_renderer_append):
2304 * src/widgets/modest-vbox-cell-renderer.c:
2305 (modest_vbox_cell_renderer_append):
2306 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2307 to fix the build with Maemo Bora.
2308 However, there seems to be a remaining crash, probably due to reference
2311 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2313 * src/modest-tny-account.c:
2314 (modest_tny_account_new_for_local_folders):
2315 Use hildon_file_system_info_async_new() to get a better name for
2316 the memory card account, setting it as the account name.
2317 The timing seems to work, but this is probably
2318 not the best place to do this. See the TODO comment.
2319 * src/maemo/modest-main-window.c: (create_details_widget):
2320 * src/widgets/modest-folder-view.c: (text_cell_data):
2321 Use the tny account name instead of hardcoding a name.
2323 2007-05-30 Christian Kellner <ckellner@openismus.com>
2325 * src/modest-search.c: (modest_search):
2326 Correctly set part_search_func even if we have already parsed
2327 the query and thus a valid OgsTextSearcher object.
2329 2007-05-30 Christian Kellner <ckellner@openismus.com>
2332 Search and check for libogs.
2335 Incooparte the ogs build env.
2337 * src/modest-mime-part-search-stream.c:
2338 * src/modest-mime-part-search-stream.h:
2339 Removed since we do the real searching now in modest-search.c.
2341 * src/modest-search.c:
2342 * src/modest-search.h:
2343 Implement support for ogs. We use that if available and requested
2344 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2345 should now handle the corner case when the search term is spread
2346 across multiple reads.
2347 Also the logic in modest_search () was corrected to search all
2348 requested fields until one is found.
2350 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2352 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2354 * src/modest-init.h:
2355 * src/modest-init.c: Made modest_init_local_folders() take a
2356 path and be public so we can iniitialize maildir folders on
2359 * src/modest-local-folder-info.h:
2360 * src/modest-local-folder-info.c:
2361 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2363 * src/modest-tny-account.c:
2364 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2365 still means the standard local-folders path on the local volume.
2367 * src/modest-tny-account-store.c:
2368 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2369 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2370 all accounts when that happens.
2371 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2372 this too, so it shows up in the treeview.
2374 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2376 * src/maemo/modest-maemo-global-settings-dialog.c:
2377 (current_connection):
2378 * src/widgets/modest-global-settings-dialog.c:
2379 (current_connection_default):
2380 Use the enum values instead of 0, 1 and -1,
2381 to make the code clearer.
2383 * src/modest-account-mgr-helpers.c:
2384 (modest_account_mgr_get_connection_specific_smtp): Make this code
2387 * src/modest-runtime.h:
2388 * src/modest-runtime.c:
2389 Added modest_runtime_remove_all_send_queues().
2390 * src/maemo/modest-main-window.c:
2391 (on_account_store_connecting_finished): Recreate the send queues,
2392 using the appropriate transport accounts for this new connection.
2393 Some futher adapting might be needed if the old send queues are not
2394 automatically stopped at this point.
2396 * src/modest-tny-account-store.c: (get_server_accounts):
2397 Create the connection-specific transport accounts, so that they can
2398 be found later by their ID.
2400 * src/modest-tny-account.h:
2401 * src/modest-tny-account.c:
2402 Added modest_tny_account_new_from_server_account_name().
2403 modest_tny_account_new_from_server_account(): Do not create the
2404 send queues here, because they will be
2405 recreated anyway when the connection changes for the first time.
2407 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2409 * src/modest-local-folder-info.h:
2410 * src/modest-local-folder-info.c:
2411 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2412 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2413 tbox_folder): Take a modest account name instead of a server TnyAccount,
2414 so we can have per-modest-account rather than per-transport-account
2416 We must make sure that we change or recreate the exisitng send queues
2417 when the connection changes for connection-specific transport accounts.
2419 * src/modest-tny-account-store.c:
2420 (create_per_account_local_outbox_folders): Create outboxed per modest
2421 account, not per transport account.
2423 * src/modest-tny-account.h:
2424 * src/modest-tny-account.c:
2425 (modest_tny_account_get_special_folder): For outboxes, get the
2426 parent modest account name. The account is ignored for other folders.
2427 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2428 modest account name rather than a server TnyAccount.
2430 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2432 * src/modest-tny-account.c:
2433 (modest_tny_account_new_from_server_account):
2434 Call modest_runtime_get_send_queue() immediately after creating transport
2435 accounts, so that they start trying to send email from the outbox as soon
2436 as possible at startup. This is probably what we want.
2438 * src/modest-mail-operation.c: (update_account_thread):
2439 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2440 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2441 * src/modest-tny-send-queue.h:
2442 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2443 (modest_ui_actions_on_send):
2444 Added comments about how sending works, though it needs some more work.
2446 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2448 * src/modest-tny-account.c:
2449 (modest_tny_account_get_special_folder): Add TODO because this fails when
2450 the network is busy.
2451 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2452 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2453 Do not try to show this window when there is no active account. The UI
2454 specs does not tell us what to do in this case.
2456 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2460 * src/maemo/Makefile.am:
2461 * src/widgets/Makefile.am: Some dist fixes.
2463 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2465 * src/maemo/modest-connection-specific-smtp-window.c:
2466 (on_button_edit): Make the code clearer, to prevent a double free.
2468 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2470 * src/maemo/modest-account-settings-dialog.c:
2471 (modest_account_settings_dialog_set_account_name),
2472 Check the connection-specific smtp servers checkbox if there are any.
2474 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2475 (modest_connection_specific_smtp_edit_window_init):
2476 Start with a suitable port number.
2478 * src/modest-account-mgr-helpers.h:
2479 * src/modest-account-mgr-helpers.c: Added
2480 modest_account_mgr_get_has_connection_specific_smtp().
2482 (modest_account_mgr_set_connection_specific_smtp),
2483 (modest_account_mgr_remove_connection_specific_smtp),
2484 (modest_account_mgr_get_has_connection_specific_smtp),
2485 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2486 connection-specific smtp server accounts in the account, rather than
2487 the server account conf dir.
2489 This fixes bug projects.maemo.org bug NB#58263 .
2491 * src/modest-tny-account-store.c:
2492 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2493 if there are no server accounts yet, to prevent an infinite loop when there
2494 are no accounts. Document that one must be called before the other.
2496 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2498 * src/modest-account-mgr-helpers.c:
2499 (modest_account_mgr_get_default_account): Make sure that at least
2500 one account is always the default, if there are any enabled accounts.
2501 This is just a sanity check that shouldn't be necessary.
2503 * src/modest-account-mgr-priv.c:
2504 (_modest_account_mgr_account_from_key): Unescape the conf key to
2505 get the real account name. For instance, this is an issue if a space
2506 was in the account name, which can happen because the account name
2507 is generated from the display name.
2508 (_modest_account_mgr_get_account_keyname): Always escape the
2510 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2511 Unescape the conf keys to get the real account names.
2513 For instance, previously the is-default radio button in the accounts
2514 list was not checked for any accounts at first. This fixes that,
2515 and might fix several similar bugs.
2517 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2519 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2520 Removed some debug printfs.
2522 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2524 Modest on-disk outbox directories are now here, for instance:
2525 $HOME/.modest/outboxes/<account-id-1>/outbox
2526 $HOME/.modest/outboxes/<account-id-2>/outbox
2528 $HOME/.modest/local-folders/outbox
2529 so we can have a separate outbox for each account.
2530 But they are shown as one outbox in the GtkTreeView, by using a
2531 TnyMergeFolder in a ModestTnySimpleFolderStore.
2534 * src/modest-tny-simple-folder-store.c:
2535 * src/modest-tny-simple-folder-store.h:
2536 Added ModestTnySimpleFolderStore, used to contain folders from
2537 other folder stores, such as other accounts.
2539 * src/modest-tny-outbox-account.h:
2540 * src/modest-tny-outbox-account.c:
2541 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2542 used for the per-account local outbox folders.
2544 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2545 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2546 only use this (internally) now for the non-outbox local folders.
2548 * src/modest-init.h:
2549 * src/modest-init.c: Added modest_init_one_local_folder(), for
2550 setting up the directory structure for each local folder.
2552 * src/modest-local-folder-info.c:
2553 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2554 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2556 * src/modest-local-folder-info.h:
2557 * src/modest-tny-account-store.c: (on_account_removed),
2558 (on_account_changed), (create_per_account_local_outbox_folders),
2559 (get_server_accounts), (modest_tny_account_store_get_accounts),
2560 (modest_tny_account_store_get_tny_account_by_account),
2561 (modest_tny_folder_store_is_virtual_local_folders):
2563 * src/modest-tny-account.h:
2564 * src/modest-tny-account.c:
2565 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2566 to create an on-disk per-account local outbox folder for each
2568 (create_per_account_local_outbox_folders): Create a local outbox folder
2569 for each transport account.
2570 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2571 for all local folders.
2573 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2574 instead of using g_object_get/set() directly. It is clearer.
2576 (modest_tny_folder_store_get_message_count),
2577 (modest_tny_folder_store_get_local_size
2578 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2579 because we now use these with non-acount folder stores.
2581 (modest_tny_account_get_special_folder),
2582 (modest_tny_account_new_from_server_account),
2583 (modest_tny_account_new_from_account):
2584 (recurse_folders): Adjust to the new outbox system.
2586 * src/modest-tny-folder.h:
2587 * src/modest-tny-folder.c:
2588 (modest_tny_folder_is_local_folder),
2589 (modest_tny_folder_get_local_folder_type),
2590 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2592 * src/widgets/modest-main-window.h:
2593 * src/maemo/modest-main-window.c: (create_details_widget),
2594 (modest_main_window_set_contents_style): Show details for any folder store,
2597 (modest_tny_folder_get_rules):
2598 Remove the const. C does not support constness enough for this.
2600 * src/modest-ui-actions.c:
2601 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2602 make all outboxes appear as one, in the usual local-folders tree node.
2604 (set_active_account_from_tny_account),
2605 (modest_ui_actions_on_folder_selection_changed):
2606 * src/widgets/modest-folder-view.c: (text_cell_data),
2607 (icon_cell_data), (filter_row),
2608 (add_account_folders_to_merged_folder),
2609 (add_account_folders_to_simple_folder_store), (),
2610 (get_cmp_rows_type_pos), (cmp_rows),
2611 (modest_folder_view_set_account_id_of_visible_server_account):
2612 Adjust to the new outbox system, using generic folder stores and folders
2613 in the GtkTreeModel.
2615 2007-05-23 Christian Kellner <ckellner@openismus.com>
2617 * src/modest-mail-operation.c:
2618 (modest_mail_operation_update_account):
2619 Use info->max_size instead of unintialized local var [small
2620 build fix]. (Added TODO to review that change since I don't
2623 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2625 * libmodest-dbus-client/libmodest-dbus-client.c:
2626 (libmodest_dbus_client_compose_mail): function added
2627 * src/dbus_api/modest-dbus-api.h:
2628 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2629 (on_compose_mail): Implementation of the SendAsMail functionality
2631 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2633 * src/modest-account-mgr.c:
2634 (modest_account_mgr_add_server_account): Set the secure-connection
2635 conf key for transport accounts as well as store accounts. I don't know
2636 why the if was there. For instance, this makes sure that we use SSL
2637 for the gmail preset from the easysetup wizard.
2639 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2641 * src/gnome/modest-main-window.c:
2642 (on_account_store_connecting_finished), (connect_signals):
2643 * src/maemo/modest-main-window.c:
2644 (on_account_store_connecting_finished), (connect_signals),
2645 (modest_main_window_new):
2646 Handle TnyAccountStore::connecting-finished instead of
2647 TnyDevice::connection-changed, because we cannot actually perform
2648 operations on accounts until TnyAccountStore has itself responded to
2649 the TnyDevice::connection-changed signal. This prevents a GError from
2651 Do not try to update at startup, because we (at least on scratchbox)
2652 already do an update at startup when the device goes online.
2653 This prevents a GError from tinymail.
2654 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2655 Added TODO about stopping simultaneous operations.
2657 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2659 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2660 * src/modest-mail-operation-queue.c:
2661 (modest_mail_operation_queue_remove):
2662 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2663 about where they happened.
2665 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2667 * src/modest-ui-actions.c:
2668 (modest_ui_actions_on_password_requested): Make sure that the remember
2669 output parameter is always TRUE.
2671 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2673 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2674 Show a OK/Cancel dialog if the error is a question, though we still do not
2675 know anything more about what we are asking the user.
2676 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2677 Fix an uninitialized variable (helper). This is a logic error, however.
2679 2007-05-21 Christian Kellner <ckellner@openismus.com>
2681 * src/modest-search.h:
2682 Correct bit shifting in the ModestSearchFlags enum.
2684 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2686 * src/modest-tny-account.c:
2687 (modest_tny_account_new_from_server_account): Do not use the lsub and
2688 check-all hard-coded IMAP options when using POP.
2690 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2692 * src/modest-tny-account.c:
2693 (modest_tny_account_new_from_server_account):
2694 Use NULL for the secure-auth method for POP when Password auth has been
2695 specified by the user, as we already do for IMAP. "auth=Login" causes
2696 an error from camel or the server.
2698 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2700 * src/maemo/modest-account-settings-dialog.c:
2701 (create_page_account_details),
2702 (modest_account_settings_dialog_set_account_name):
2703 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2704 for the leave-on-server checkbox, rathr than just the checkbox, when
2705 the protocol is not POP.
2707 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2709 * src/widgets/modest-account-view.c:
2710 * src/widgets/modest-account-view.h:
2711 Added modest_account_view_select_account() which will be useful later
2712 to asynchronously re-select the edited account.
2714 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2716 * src/maemo/modest-account-settings-dialog.c:
2717 (modest_account_settings_dialog_set_account_name):
2718 Automatically choose the port numbers based on the secure authentication
2719 methods, if they have not been chosen before.
2720 This fixes projects.maemo.org bug NB#56273 .
2722 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2724 * src/maemo/modest-main-window-ui.h:
2725 * src/modest-ui-actions.c:
2726 * src/modest-ui-actions.h:
2727 Connect the Tools/SMTP Servers menu item to
2728 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2729 SMTP servers dialog, as in the UI specification and saves changes when it
2730 is closed. This fixed projects.maemo.org bug NB#56305 .
2732 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2734 * src/maemo/modest-connection-specific-smtp-window.c:
2735 (modest_connection_specific_smtp_window_init):
2736 Use gtk_window_set_default_size() to make this window big enough, so
2737 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2739 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2741 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2742 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2743 (modest_connection_specific_smtp_edit_window_init),
2744 Do not try to connect to a combobox signal before the combobox exists.
2745 This fixes the cras in projects.maemo.org bug NB#56288 .
2746 (modest_connection_specific_smtp_edit_window_get_settings):
2747 Remove the server_account_name parameter which was being checked for NULL
2748 though it was not used.
2750 * src/maemo/modest-connection-specific-smtp-window.c:
2751 (modest_connection_specific_smtp_window_fill_with_connections),
2752 (on_button_edit), (modest_connection_specific_smtp_window_init):
2753 Correct the number of treemodel columns to prevent a warning.
2754 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2755 libconic does not work.
2757 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2759 * src/modest-tny-account.c:
2760 (modest_tny_account_new_from_server_account):
2761 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2762 SMTP when "None" was chosen by the user. However, with my SMTP server that
2763 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2766 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2768 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2769 to explain the memory management issue with the ID in the ModestPair.
2771 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2772 (add_sending_page), (modest_account_assistant_finalize):
2773 * src/gnome/modest-gnome-global-settings-dialog.c:
2774 (create_updating_page), (create_composing_page):
2775 * src/gnome/modest-msg-edit-window.c: (get_transports),
2776 (init_window), (modest_msg_edit_window_finalize),
2777 (modest_msg_edit_window_get_msg_data):
2778 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2779 * src/gnome/modest-transport-widget.c:
2780 (modest_transport_widget_finalize), (smtp_configuration):
2781 * src/maemo/modest-maemo-global-settings-dialog.c:
2782 (create_updating_page), (create_composing_page):
2783 * src/maemo/modest-msg-edit-window.c: (get_transports),
2784 (init_window), (modest_msg_edit_window_finalize),
2785 (modest_msg_edit_window_get_msg_data),
2786 (modest_msg_edit_window_free_msg_data):
2787 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2788 (modest_store_widget_finalize):
2789 * src/maemo/modest-transport-widget.c:
2790 (modest_transport_widget_finalize), (smtp_configuration):
2791 * src/modest-main.c: (send_mail):
2792 * src/widgets/modest-combo-box.h:
2793 * src/widgets/modest-global-settings-dialog-priv.h:
2794 * src/widgets/modest-global-settings-dialog.c:
2795 (modest_global_settings_dialog_finalize):
2796 * src/widgets/modest-msg-edit-window.h:
2797 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2798 as long as the combo box, to prevent use of freed memory for the ID.
2800 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2802 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2803 get_accounts(), to make this clearer. Do not check for the enabled gconf
2804 key, because we do not use this for server accounts (at least, not yet).
2805 This allows us to send email again.
2807 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2809 * src/maemo/modest-platform.c:
2810 (on_modest_conf_update_interval_changed), (modest_platform_init):
2811 Only respond to this particular key change. All these strcmp()s cannot be
2814 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2816 * src/maemo/modest-maemo-global-settings-dialog.c:
2817 (current_connection): Prevent a crash in scratchbox when
2818 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2819 * src/maemo/modest-platform.c:
2820 (on_modest_conf_update_interval_changed), (modest_platform_init):
2821 Get the update interval from gconf and reset it when the gconf key changes.
2823 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2825 * src/modest-protocol-info.c:
2826 * src/modest-protocol-info.h: Adde enum-specific get functions,
2827 instead of using a ModestProtocolType enum parameter.
2829 * src/gnome/modest-account-assistant.c:
2830 * src/gnome/modest-store-widget.c:
2831 * src/gnome/modest-store-widget.h:
2832 * src/gnome/modest-transport-widget.c:
2833 * src/gnome/modest-transport-widget.h:
2834 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2835 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2836 * src/maemo/easysetup/modest-easysetup-wizard.c:
2837 * src/maemo/modest-account-settings-dialog.c:
2838 * src/maemo/modest-account-settings-dialog.h:
2839 * src/maemo/modest-store-widget.c:
2840 * src/maemo/modest-store-widget.h:
2841 * src/maemo/modest-transport-widget.c:
2842 * src/maemo/modest-transport-widget.h:
2843 * src/modest-account-mgr-helpers.c:
2844 * src/modest-account-mgr-helpers.h:
2845 * src/modest-account-mgr.c:
2846 * src/modest-account-mgr.h:
2847 * src/modest-tny-account.c:
2848 * src/modest-tny-folder.c:
2849 * src/widgets/modest-account-view.c:
2850 * src/widgets/modest-retrieve-combo-box.c:
2851 * src/widgets/modest-retrieve-combo-box.h:
2852 * src/widgets/modest-secureauth-combo-box.c:
2853 * src/widgets/modest-serversecurity-combo-box.c:
2854 * src/widgets/modest-serversecurity-combo-box.h:
2855 * tests/check_account-mgr.c:
2856 Use the specific functions, and use the re-renamed enum values for GNOME too.
2858 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2860 * src/modest-pair.h:
2861 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2862 so we can get the second based on the first.
2864 * src/maemo/modest-account-settings-dialog.h:
2865 * src/maemo/modest-account-settings-dialog.c:
2866 Added get_supported_secure_authentication_methods(), though it is mostly
2867 commented-out for now until the necessary API is committed to tinymail.
2868 (modest_account_settings_dialog_set_account_name),
2869 (save_configuration): Request the supported authentication methods from the
2870 server, so we can choose a working method.
2872 * src/modest-tny-account-store.h:
2873 * src/modest-tny-account-store.c:
2874 (modest_tny_account_store_get_session): Rename from
2875 tny_account_store_get_session().
2877 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2879 * src/modest-protocol-info.h: Split the ModestProtocol enum
2880 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2881 There was no need to have these unrelated values in one enum.
2883 * src/: many files: Adapted to changed enum. This makes the code a bit
2884 clearer, and the compiler could catch some errors.
2886 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2888 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2889 Show the detailed internal camel error message when an error happens
2890 during the configuration, so that our testers can give us more clues.
2891 For instance, in projects.maemo.org bug NB#56910 .
2893 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2895 * src/modest-tny-account.c:
2896 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2897 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2899 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2901 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2902 * src/maemo/modest-account-settings-dialog.c:
2903 (modest_account_settings_dialog_set_account_name),
2904 (save_configuration): For the incoming secure authentication checkbox,
2905 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2906 the UI specification. PLAIN does not seem to be supported for most IMAP
2907 servers anyway, and I am not sure what it would mean.
2908 However, we probably need to discover which of the secure-authentication
2909 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2910 * src/modest-account-mgr-helpers.c:
2911 (modest_account_mgr_get_server_account_data):
2913 * src/modest-tny-account.c:
2914 (modest_tny_account_new_from_server_account):
2915 Use tny_account_set_mech() to set secure-authentication methods,
2916 with some special-casing for IMAP, based on my observations of how
2919 * src/modest-account-mgr-helpers.h:
2920 * src/modest-account-mgr.c:
2921 * src/modest-defs.h: Comment that the URI is only used for local folders.
2923 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2925 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2926 parameter const, just to be neat.
2927 * src/modest-text-utils.c: (modest_text_utils_inline):
2928 End g_strconcat() with NULL, as its documentation says. This is almost
2929 certainly the cause of my crash at startup on the device. Interestingly,
2930 valgrind doesn't tell us about these errors.
2932 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2934 * scripts/build-packages: Added more precise comments about how to use
2935 this script, though I still get this error:
2936 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2937 error building tinymail
2939 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2941 * src/maemo/modest-main-window.c: (on_account_update):
2942 Very slight cleanup, hoping to make it simpler to discover what causes
2943 a crash here sometimes.
2945 * src/modest-tny-account.c:
2946 (modest_tny_account_new_from_server_account): Set the port. Added
2947 comments about the options and a TODO comment because I need to find out
2948 how to specify the secure authentication method.
2950 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2952 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2953 changed CFlags paths form modest to libmodest
2955 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2957 * src/modest-account-mgr-helpers.c:
2958 (modest_account_mgr_get_server_account_data),
2959 (modest_account_mgr_free_server_account_data):
2960 * src/modest-account-mgr-helpers.h:
2961 * src/modest-account-mgr.c:
2962 (modest_account_mgr_add_server_account):
2963 * src/modest-defs.h:
2964 * src/modest-tny-account.c:
2965 (modest_tny_account_new_from_server_account):
2966 Determine the options for tny_camel_account_add_option() here,
2967 based on the settings, rather than storing them directly in gconf.
2969 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2971 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2972 Show a more friendly error dialog now that we expect (from the tinymail
2973 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2975 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2977 * src/maemo/modest-main-window.c: (on_account_update): Check that
2978 account_name is not NULL, to prevent a crash at startup that I am
2979 seeing on the N800. I do wonder why it is NULL.
2981 * src/maemo/easysetup/modest-easysetup-wizard.c:
2982 (create_page_user_details):
2983 * src/maemo/modest-account-settings-dialog.c:
2984 (create_page_user_details), (create_page_outgoing):
2985 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2986 (modest_connection_specific_smtp_edit_window_init):
2987 * src/modest-ui-actions.c:
2988 (modest_ui_actions_on_password_requested):
2989 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2990 might do something useful with the on-screen keyboard.
2992 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2994 * src/maemo/modest-main-window.c: (on_account_update):
2995 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2996 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2998 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3000 * src/modest-tny-account-store.c: (on_account_changed):
3001 Correct the signature of this signal handler.
3003 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3005 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3006 Show a HildonNote instead of a GtkDialog for Maemo.
3008 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3010 * src/widgets/modest-account-view.h:
3011 * src/widgets/modest-account-view.c: (on_account_changed),
3012 (on_account_removed). Added a boolean flag, set/unset by
3013 modest_account_view_block_conf_updates(),
3014 modest_account_view_unblock_conf_updates() to prevent unnecessary
3015 updates, but this is not very useful because the gconf notifications are
3016 so delays (maybe only on Maemo Bora).
3017 So auto-updating is turned off, and these functions do an explicit
3018 update when necessary.
3019 However, something else is still doing too much work when adding/removing
3020 accounts, probably in another part of the application.
3022 * src/maemo/modest-account-view-window.c:
3023 (on_delete_button_clicked), (on_edit_button_clicked),
3024 (on_new_button_clicked): Use the new functions.
3026 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3028 * src/modest-account-mgr-helpers.c:
3029 (modest_account_mgr_set_first_account_as_default):
3030 Sort the list of names alphabetically-by-title, so we choose the first one
3032 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3033 alphabetically by the title.
3035 This fixes projects.maemo.org bug NB#56418 .
3037 * src/modest-account-mgr-priv.c:
3038 (_modest_account_mgr_account_from_key):
3039 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3040 avoid a valgrind error, and possible random behaviour.
3042 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3044 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3045 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3046 tinymail documentation to say that this can be expected.
3047 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3048 pretty, and should not happen, but I would prefer to know when it does.
3050 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3052 * configure.ac: When using the older hildon version, probably on Bora,
3053 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3055 * src/widgets/modest-attachment-view.c:
3056 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3059 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3061 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3062 Implemented the prototype. Can be tested with
3063 tests/dbus_api/test_open_message:
3065 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3067 * src/modest-tny-account-store.c:
3068 (modest_tny_account_store_instance_init), (get_password):
3069 * src/modest-ui-actions.c:
3070 (modest_ui_actions_on_password_requested):
3071 Do not store the password in gconf, because this function is called
3072 for non-remembered passwords. Actually use the cached (in the hash map)
3073 password instead of releasing it.
3074 The password will now not be remembered if it is asked via the protected
3075 password dialog, as per the UI spec.
3077 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3079 * src/modest-defs.h:
3080 * src/modest-account-mgr-helpers.h:
3081 * src/modest-account-mgr-helpers.c:
3082 Added modest_server_account_get_username_has_succeeded(),
3083 modest_server_account_set_username_has_succeeded().
3084 (modest_server_account_set_username),
3085 Reset the has-succeeded flag if the username changes.
3087 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3088 * src/maemo/modest-connection-specific-smtp-window.c:
3089 (modest_connection_specific_smtp_window_save_server_accounts):
3090 Use modest_server_account_set_username() instead of using
3091 modest_conf_set_string() directly, so that the has-succeeded flag is always
3094 * src/modest-ui-actions.c:
3095 (modest_ui_actions_on_password_requested): Dim the username entry if
3096 the username has ever worked, as per the UI spec.
3098 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3100 * src/modest-tny-account-store.c: (get_password):
3101 * src/modest-ui-actions.c:
3102 (modest_ui_actions_on_password_requested):
3103 Allow the username to be changed too, though there is more work to
3104 be done on exactly how this behaves.
3106 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3108 * src/modest-account-mgr-helpers.h:
3109 * src/modest-account-mgr-helpers.c:
3110 Added modest_account_mgr_get_display_name(),
3111 modest_server_account_get_username(),
3112 modest_server_account_set_username(),
3113 modest_server_account_set_password(),
3114 modest_server_account_get_hostname() functions so we do not need to
3115 use the conf API directly.
3117 * src/maemo/modest-main-window.c: (connect_signals):
3118 Actually connect ot the ModestAccountStore::request-password signal,
3119 so that we show the dialog when the password is requested by Tinymail,
3120 for isntance if it is empty.
3122 * src/modest-marshal.list:
3123 * src/modest-tny-account-store.c:
3124 (modest_tny_account_store_class_init), (get_password),
3125 (modest_tny_account_store_alert):
3126 * src/modest-tny-account-store.h:
3127 * src/modest-ui-actions.h:
3128 * src/modest-ui-actions.c:
3129 (modest_ui_actions_on_password_requested):
3130 Change the signal parameters, so it is obvious that we are providing
3131 the non human-readable server name, and receiving both the username
3132 and password, though changing of the username is not yet implemented.
3133 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3134 for the GNOME version.
3136 This should fix the projects.maemo.org bug NB#56209, though it does not
3137 work on Bora, because the gconf_client_get() for the password fails
3138 immediately after we save it with gconf_client_set().
3140 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3143 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3144 caused an undefined symbol error:
3145 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3147 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3149 * src/modest-tny-account-store.c:
3150 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3151 using a GError instead of a string message, so we can translate it in
3154 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3156 * src/maemo/modest-address-book.c:
3157 (modest_address_book_check_names):
3158 * src/maemo/modest-msg-view-window.c:
3159 (modest_msg_view_window_clipboard_owner_change):
3160 * src/modest-init.c: (modest_init_init_ui):
3161 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3162 (update_folders_cb), (modest_mail_operation_update_account):
3163 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3164 (modest_ui_actions_on_msg_attachment_clicked),
3165 (modest_ui_actions_on_msg_recpt_activated):
3166 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3167 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3168 (modest_msg_view_search_next):
3169 * src/widgets/modest-recpt-editor.c:
3170 (modest_recpt_editor_on_button_release_event),
3171 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3172 g_message(). At this point we should only be seeing interesting errors on
3173 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3175 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3177 (modest_wizard_dialog_force_title_update):
3178 * src/maemo/easysetup/modest-wizard-dialog.h:
3179 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3180 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3181 can update the title when appropriate. Otherwise the title is wrong if the
3182 pages are added after adding the notebook to the dialog.
3183 This must be a problem in HildonWizardDialog too.
3184 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3186 * src/maemo/easysetup/modest-easysetup-wizard.c:
3187 (create_subsequent_customsetup_pages),
3188 (create_subsequent_easysetup_pages):
3189 Call modest_wizard_dialog_force_title_update() so that the title is
3190 correct even with GTK+ < 2.10.
3191 This fixes projects.maemo.org bug NB#56145 .
3193 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3195 * src/maemo/modest-platform.c:
3196 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3197 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3200 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3202 * src/widgets/modest-window.h:
3203 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3204 and modest_window_save_state(), which invokes it.
3206 * src/widgets/modest-window-mgr.h:
3207 * src/widgets/modest-window-mgr.c:
3208 Added modest_window_mgr_save_state_for_all_windows(), which calls
3209 the save_state vfunc on all registered windows, if implemented.
3211 * src/gnome/modest-msg-edit-window.c:
3212 * src/gnome/modest-msg-view-window.c:
3213 * src/maemo/modest-msg-edit-window.c:
3214 * src/maemo/modest-msg-view-window.c:
3215 * src/maemo/modest-main-window.c:
3216 Specify the existing save_settings functions as implementations of
3217 ModestWindow::save_state_func().
3219 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3220 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3221 enabling hibernation, for instance.
3223 We may need to do the same thing for restoring settings.
3226 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3228 * src/widgets/modest-window-mgr.c:
3229 * src/widgets/modest-window-mgr.h:
3230 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3231 modest_window_mgr_get_hibernation_is_prevented().
3233 * src/maemo/modest-main-window.c:
3234 (on_hildon_program_is_topmost_notify): Prevent hibernation
3235 (possible when the application goes to the background in the WM),
3236 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3238 * src/maemo/easysetup/modest-easysetup-wizard.c:
3239 (modest_easysetup_wizard_dialog_init):
3240 * src/maemo/modest-account-settings-dialog.c:
3241 (modest_account_settings_dialog_init):
3242 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3243 (modest_connection_specific_smtp_edit_window_init):
3244 * src/maemo/modest-connection-specific-smtp-window.c:
3245 (modest_connection_specific_smtp_window_init):
3246 * src/maemo/modest-signature-editor-dialog.c:
3247 (modest_signature_editor_dialog_init):
3248 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3249 prevent hibernation while any of these account settings dialogs are open.
3251 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3253 * src/maemo/Makefile.am:
3254 * src/maemo/modest-osso-state-saving.c:
3255 * src/maemo/modest-osso-state-saving.h: Added
3256 modest_osso_load_state() and modest_osso_save_state() though they do
3257 nothing now. They should iterate through all the open windows and load/save
3259 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3260 save state when closing.
3262 * src/maemo/modest-main-window.c:
3263 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3264 Add a notification handler for the HildonProgram::is-topmost property,
3265 so we can allow hibernation when the application goes into the background.
3266 But we still need to detect when the accounts setup windows are open so
3267 we can stop hibernation when they are open.
3268 To do this, I also added the main window the HildonProgram. This might have
3269 other side-effects/benefits, and should maybe be done for other windows.
3271 * src/maemo/modest-osso-autosave-callbacks.h:
3272 * src/maemo/modest-osso-autosave-callbacks.c:
3273 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3274 though it does not do anything yet, and we might never need this to do
3275 anything. For instance, we already save drafts.
3277 * src/maemo/modest-platform.c: (modest_platform_init):
3278 Specify the libosso auto-save callback.
3280 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3282 * src/maemo/modest-platform.c:
3283 (modest_platform_set_update_interval):
3284 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3285 aparently stays valid between application instances, so we can use this
3286 to remove and reset it later. According to a maemo-developers email from
3289 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3291 * configure.ac: Depend on libalarm for Maemo.
3293 * src/dbus_api/modest-dbus-api.h:
3294 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3295 (on_send_receive), (modest_dbus_req_handler):
3296 Handle a SEND_RECEIVE D-Bus method.
3298 * libmodest-dbus-client/libmodest-dbus-client.c:
3299 (libmodest_dbus_client_send_and_receive):
3300 * libmodest-dbus-client/libmodest-dbus-client.h:
3301 Add C convenience functions for calling the new D-Bus method.
3303 * src/modest-platform.h:
3304 * src/gnome/modest-platform.c:
3305 * src/maemo/modest-platform.c:
3306 Added modest_platform_set_update_interval(), which uses the
3307 alarmd API on Maemo.
3308 (modest_platform_init),
3309 Call modest_platform_set_update_interval(), using a hard-coded
3310 interval for now (until the global settings dialog is implemented),
3311 though I am not sure that this makes sense yet.
3313 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3315 * src/dbus_api/modest-dbus-callbacks.c:
3316 (modest_osso_cb_hw_state_handler):
3317 * src/dbus_api/modest-dbus-callbacks.h:
3318 * src/maemo/modest-platform.c: (modest_platform_init):
3319 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3320 in case this has some effect on the ability for Maemo to ping the
3323 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3325 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3326 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3327 warning. It is probably a logic error, but I need to fix the build.
3329 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3331 * src/modest-account-mgr.h:
3332 * src/modest-account-mgr.c:
3333 (modest_account_mgr_account_names): Add a gboolean enabled_only
3334 parameter, so we can get lists of onlt the enabled accounts.
3336 (modest_account_mgr_add_account),,
3337 (modest_account_mgr_account_with_display_name_exists):
3338 * src/maemo/modest-msg-edit-window.c: (get_transports):
3339 * src/modest-account-mgr-helpers.c:
3340 (modest_account_mgr_set_first_account_as_default):
3341 * src/modest-init.c: (init_default_account_maybe):
3342 * src/modest-tny-account-store.c: (get_accounts):
3343 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3344 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3345 * tests/check_account-mgr.c: (START_TEST):
3346 Provide the extra parameter, as appropriate.
3348 * src/widgets/modest-account-view.c: (update_account_view):
3349 Do not show disabled accounts (meaning that there is no way to
3350 enable/disable accounts in the UI (the feature is not in our UI
3351 specification), so we can use this internally only to mark unfinished
3352 or temporary account data.
3354 * src/maemo/easysetup/modest-easysetup-wizard.c:
3355 (create_account): Add boolean enable parameter, so we can specify FALSE
3356 to create the temporary account.
3357 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3358 (on_before_next): When finishing, when there is a temporary account, just
3360 Also, use a timeout to delay the showing of the dialog until gconf is likely
3361 to return correct information, due to a maemo gconf bug that is fixed in
3362 osso 1.1, but not yet in Bora.
3363 However, the dialog stays on screen after it is destroyed.
3365 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3366 for invalid data when cancelling. Use a hildon note instead of a dialog
3367 to complain about invalid data. Do not show the account-saved note if the
3368 account is disabled (a temporary account that will not really be saved for use
3371 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3373 * src/modest-account-mgr-helpers.h:
3374 * src/modest-account-mgr-helpers.c:
3375 Added modest_account_mgr_unset_default_account(),
3376 Added modest_account_mgr_set_first_account_as_default().
3378 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3379 If it was the default account, unset the default account name.
3381 * src/maemo/modest-account-view-window.c:
3382 (on_delete_button_clicked): If it was the default account,
3383 set the first remaining account as the default instead.
3385 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3386 a NULL account or a NULL default account, to prevent a crash. This should
3387 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3390 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3392 * src/widgets/modest-recpt-editor.c:
3393 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3394 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3395 TODO comment for this. This fixes the build.
3397 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3398 be the best place for it. This will in future update all auto-update accounts,
3399 rather than just the current/default account, when that gconf key exists.
3400 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3401 if there are no accounts, before calling do_send_receive().
3402 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3404 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3405 * src/maemo/modest-main-window-ui.h:
3406 * src/maemo/modest-main-window.c: (on_connection_changed),
3407 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3408 directly, becaue the signal handler does more.
3410 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3412 * src/modest-account-mgr-helpers.c:
3413 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3414 for the case that the account does not exist.
3416 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3417 (equivalent to the modest account name) rather than the tinymail account name
3418 (equivalent to the modest account title - human readable) to get the account data.
3419 Check for null account data to prevent the crash, and add a TODO comment saying that
3420 this needs fixing because it is using the server account name instead of the account name.
3422 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3424 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3425 * src/maemo/modest-account-settings-dialog.c: (show_error),
3427 Use hildon_note_new_information() for informative and error messages,
3428 which seems to be expected for Maemo applications (no documentation that I know of
3429 says this). I am surprised that there is no distinction between info and error
3432 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3434 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3435 it is easy to find where this is used.
3437 * src/maemo/easysetup/modest-easysetup-wizard.c:
3438 (create_page_welcome), (create_page_account_details),
3439 (create_page_user_details), (create_page_complete_easysetup),
3440 (create_page_custom_incoming), (create_page_custom_outgoing),
3441 (create_page_complete_custom):
3442 * src/maemo/modest-account-settings-dialog.c:
3443 (create_page_account_details), (create_page_user_details),
3444 (create_page_incoming), (create_page_outgoing):
3445 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3446 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3447 (modest_connection_specific_smtp_edit_window_init):
3448 * src/maemo/modest-connection-specific-smtp-window.c:
3449 (modest_connection_specific_smtp_window_init):
3450 * src/maemo/modest-signature-editor-dialog.c:
3451 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3452 and scrolling policy as per the Email Application Layout Guide, if I have
3455 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3457 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3458 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3459 which were empty, because these vfuncs have been removed from TnyAccountStore.
3460 This fixes the build.
3462 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3464 * src/maemo/modest-main-window.c:
3465 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3466 showing/hiding it. Added TODO because it probably should not be NULL.
3467 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3468 because unnecessary g_warnings() make degugging difficult.
3470 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3472 * src/maemo/modest-msg-edit-window.c:
3473 (modest_msg_edit_window_select_color),
3474 (modest_msg_edit_window_select_background_color): 2 const corrections and
3475 moving 2 #endifs before closing brackets, to fix the build.
3477 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3479 * src/maemo/easysetup/modest-easysetup-wizard.h:
3480 * src/maemo/easysetup/modest-easysetup-wizard.c:
3481 (modest_easysetup_wizard_dialog_finalize),
3482 (on_button_edit_advanced_settings), (create_page_complete_custom),
3483 (on_response), (create_account):
3484 Implement the Advanced Settings edit button, by saving the account information,
3485 for the Advanded Settings dialog to use directly from gconf, and removing it
3486 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3487 Bug #5533 in the projects.maemo.org bugzilla.
3489 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3491 * src/maemo/modest-msg-view-window.c:
3492 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3493 when opening a message window.
3495 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3497 * src/maemo/easysetup/modest-easysetup-wizard.c:
3498 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3501 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3502 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3503 gconf settings. I probably added more checks than necessary, but that is safer.
3505 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3506 variable to fix the build, but this seems to be used when it is still NULL.
3508 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3510 * src/modest-platform.h:
3511 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3512 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3513 * src/modest-main.c: Implement this function so we can avoid using
3514 maemo-specific API from cross-platform code.
3516 * src/modest-tny-account-store.c:
3517 (get_smtp_specific_transport_account_for_open_connection):
3518 * src/modest-ui-actions.c: (check_for_connection),
3519 (modest_ui_actions_on_item_not_found):
3520 Use modest_platform_connect_and_wait() and put #idefs around other
3521 maemo-specific code, because only maemo currently has a way to
3522 identify connection names.
3524 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3526 * src/modest-tny-account-store.h:
3527 * src/modest-tny-account-store.c:
3528 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3529 the connection-specific SMTP server settings in the configuration.
3531 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3533 * src/maemo/modest-main-window.c: (on_connection_changed),
3535 * src/modest-main.c: (main), (start_ui), (send_mail):
3536 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3537 that is what is intended.
3539 * src/modest-ui-actions.c: (action_send), (action_receive),
3540 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3541 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3542 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3543 SMTP server is used when it is specified.
3545 (modest_ui_actions_on_send_receive):
3546 Check that a connection is open before proceeding.
3547 Receive and then send, instead of vice-versa, as per the specification.
3549 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3551 * src/modest-mail-operation.c:
3552 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3553 though I guess it should be something other than NULL.
3555 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3557 * src/maemo/easysetup/modest-easysetup-wizard.c:
3558 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3559 combo twice, to avoid an g_warning and to make it visible again.
3560 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3561 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3562 (already intended) dereference when detaching, because we then recreate the menu.
3563 But I am not sure why the warning was happening, and it is possible that this is a memory
3566 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3568 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3569 and uri_parse_mailto() utility functions.
3570 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3572 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3574 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3576 * src/dbus_api/modest-dbus-api.h:
3577 * src/dbus_api/modest-dbus-callbacks.c:
3578 Use an idle callback to execute the modest code in the application's own thread.
3579 Remove the helloworld example method.
3580 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3581 parsed, and the open-message method is not implemented because this is not yet implemented in
3583 * libmodest-dbus-client/libmodest-dbus-client.c:
3584 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3585 (libmodest_dbus_client_open_message):
3586 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3588 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3589 body without crashing.
3591 * tests/dbus_api/Makefile.am:
3592 * tests/dbus_api/test_mail_to.c:
3593 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3595 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3597 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3598 Added file to fix the build. Sorry.
3600 * src/dbus_api/Makefile.am:
3601 * src/dbus_api/modest-dbus-api.h:
3602 * src/dbus_api/modest-dbus-callbacks.h:
3603 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3604 (modest_dbus_req_handler):
3605 Put constants in a separate header so it can be reused by the
3606 client library, without duplication
3608 * libmodest-dbus-client/Makefile.am:
3609 * libmodest-dbus-client/libmodest-dbus-client.c:
3610 (libmodest_dbus_client_call_helloworld),
3611 (libmodfest_dbus_client_send_mail),
3612 (libmodfest_dbus_client_mailto),
3613 (libmodfest_dbus_client_open_message):
3614 * libmodest-dbus-client/libmodest-dbus-client.h:
3615 (Partly) Implement a send_mail D-Bus method.
3617 * tests/dbus_api/Makefile.am:
3618 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3619 the send_email D-Bus method.
3621 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3625 * libmodest-dbus-client/Makefile.am:
3626 * libmodest-dbus-client/libmodest-dbus-client.c:
3627 * libmodest-dbus-client/libmodest-dbus-client.h:
3628 * tests/dbus_api/Makefile.am:
3629 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3630 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3632 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3634 * src/maemo/easysetup/modest-easysetup-wizard.c:
3635 (create_page_account_details):
3636 * src/maemo/modest-account-settings-dialog.c:
3637 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3638 widgets, because this might not be the default in future versions of the Maemo GTK+.
3639 However, I can not not get capitalization to work even in a simple test case.
3641 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3643 * src/maemo/easysetup/modest-easysetup-wizard.c:
3644 (create_page_custom_incoming), (create_page_custom_outgoing):
3645 * src/maemo/modest-account-settings-dialog.c:
3646 (create_page_account_details), (create_page_incoming),
3647 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3648 instead of using gtk_check_button_with_label(), so they are aligned like the other
3649 widgets, as per the UI spec.
3651 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3653 * src/maemo/easysetup/modest-easysetup-wizard.c:
3654 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3655 * src/widgets/modest-validating-entry.c:
3656 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3657 Modest prefix instead of an EasySetup prefix.
3659 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3661 * src/widgets/modest-validating-entry.h:
3662 * src/widgets/modest-validating-entry.c: (on_insert_text),
3663 Added easysetup_validating_entry_set_max_func(), used to set a callback
3664 to call when the max number of characters is reached. GtkEntry has a max-length
3665 already but is silent about it.
3667 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3668 (create_page_account_details), (create_page_user_details),
3670 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3671 (create_page_account_details), (create_page_user_details),
3672 (create_page_outgoing):
3673 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3674 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3675 the UI spec, when the user tries to enter more than the max number of characters.
3677 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3679 * src/maemo/easysetup/modest-easysetup-wizard.c:
3680 (create_page_user_details), (create_page_custom_incoming),
3681 (create_page_custom_outgoing):
3682 * src/maemo/modest-account-settings-dialog.c:
3683 (create_page_user_details), (create_page_incoming),
3684 (create_page_outgoing):
3685 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3686 (modest_connection_specific_smtp_edit_window_init):
3687 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3688 not appropriate. Bad Maemo-specific defaults!.
3690 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3692 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3693 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3694 (modest_signature_editor_dialog_set_settings):
3695 Disable the label and textview when the checkbox is disabled, and use the
3696 specified (UI spec) default signature text.
3698 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3700 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3701 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3703 * src/modest-defs.h:
3704 * src/modest-account-mgr-helpers.h:
3705 * src/modest-account-mgr-helpers.c:
3706 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3708 * src/maemo/Makefile.am:
3709 * src/maemo/modest-signature-editor-dialog.c:
3710 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3713 * src/maemo/modest-account-settings-dialog.h:
3714 * src/maemo/modest-account-settings-dialog.c:
3715 (modest_account_settings_dialog_finalize), (on_button_signature),
3716 (save_configuration): Use the new dialog when the Edit button is pressed, and
3717 save the changes if necessary, as per the UI spec.
3719 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3721 * src/maemo/Makefile.am:
3722 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3723 based on maemo-develoers email from Dirk.
3725 * src/maemo/easysetup/modest-easysetup-wizard.c:
3726 (create_page_welcome), (create_page_account_details),
3727 (create_page_user_details), (create_page_complete_easysetup),
3728 (create_page_custom_incoming), (create_page_custom_outgoing),
3729 (create_page_complete_custom),
3730 (modest_easysetup_wizard_dialog_init):
3731 * src/maemo/modest-account-settings-dialog.c:
3732 (create_page_account_details), (create_page_user_details),
3733 (create_page_incoming), (create_page_outgoing),
3734 (modest_account_settings_dialog_init):
3735 * src/maemo/modest-connection-specific-smtp-window.c:
3736 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3738 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3740 * src/maemo/easysetup/modest-easysetup-wizard.c:
3741 (create_page_account_details), (create_page_custom_outgoing),
3742 (create_page_complete_custom):
3743 * src/maemo/modest-account-settings-dialog.c:
3744 (create_page_user_details), (create_page_incoming),
3745 (create_page_outgoing):
3746 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3747 (modest_connection_specific_smtp_edit_window_init):
3748 Use the correct (UI spec) port min/max, and use horizontal separators,
3751 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3753 * src/maemo/easysetup/modest-easysetup-wizard.c:
3754 (set_default_custom_servernames):
3755 * src/maemo/modest-account-settings-dialog.c:
3756 (create_page_incoming), (on_combo_outgoing_security_changed),
3757 (on_combo_incoming_security_changed), (create_page_outgoing),
3758 (modest_account_settings_dialog_set_account_name),
3759 (save_configuration):
3760 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3761 (on_combo_security_changed),
3762 (modest_connection_specific_smtp_edit_window_init),
3763 (modest_connection_specific_smtp_edit_window_set_connection),
3764 (modest_connection_specific_smtp_edit_window_get_settings):
3765 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3768 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3771 * src/maemo/easysetup/modest-easysetup-wizard.c:
3772 (create_page_custom_outgoing), (create_page_complete_custom):
3773 * src/maemo/modest-account-settings-dialog.c:
3774 (create_page_user_details), (create_page_outgoing):
3775 * src/maemo/modest-account-view-window.c: (button_box_new):
3776 Use changed logical IDs as per the most recent UI spec:
3777 mcen_bd_emailsetup_edit -> mcen_bd_edit
3778 mcen_bd_emailsetup_delete -> mcen_bd_delete
3779 mcen_bd_emailsetup_close -> mcen_bd_close
3781 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3785 * src/dbus_api/Makefile.am:
3786 * src/dbus_api/modest-dbus-callbacks.c:
3787 * src/dbus_api/modest-dbus-callbacks.h:
3788 * src/maemo/modest-platform.c: (modest_platform_init):
3789 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3791 * tests/Makefile.am:
3792 * tests/dbus_api/Makefile.am:
3793 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3795 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3797 * src/maemo/modest-account-settings-dialog.c:
3798 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3799 Removed unnecessary includes.
3801 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3803 * src/maemo/easysetup/modest-easysetup-wizard.c:
3804 * src/maemo/modest-account-settings-dialog.c:
3805 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3806 * src/widgets/Makefile.am:
3807 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3808 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3809 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3810 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3811 * src/widgets/modest-secureauth-combo-box.c:
3812 * src/widgets/modest-secureauth-combo-box.h:
3813 * src/widgets/modest-serversecurity-combo-box.c:
3814 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3815 made the GObject names more consistent with the rest of the Modest code.
3817 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3819 * src/maemo/easysetup/Makefile.am:
3820 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3821 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3822 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3823 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3824 * src/maemo/easysetup/modest-easysetup-wizard.c:
3825 * src/maemo/easysetup/modest-validating-entry.c:
3826 * src/maemo/easysetup/modest-validating-entry.h:
3827 * src/maemo/modest-account-settings-dialog.c:
3828 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3829 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3830 widgets/ because they are used outside of easysetup too. After checking in,
3831 svn will allow me to rename them too.
3833 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3835 * src/gnome/modest-msg-edit-window.c:
3836 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3837 linker error, to fix the build on the GNOME platform.
3838 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3839 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3840 ifdefed out to avoid a warning.
3842 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3844 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3845 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3846 some alternative for GTK+ 2.6.
3848 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3850 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3852 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3853 specified for EmailAccountsDialog in UI spec.
3855 * src/maemo/easysetup/modest-easysetup-wizard.c:
3856 * src/maemo/easysetup/modest-easysetup-wizard.h:
3857 * src/maemo/modest-account-settings-dialog.c:
3858 * src/maemo/modest-account-settings-dialog.h:
3859 Reuse a member window widget for the connection-specific SMTP server accounts,
3860 so we can tell it to create/save the accounts only if we actually save changes.
3862 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3863 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3864 (modest_connection_specific_smtp_edit_window_get_settings):
3865 Return a struct instance for temporarily remembering the entered data.
3867 * src/maemo/modest-connection-specific-smtp-window.h:
3868 * src/maemo/modest-connection-specific-smtp-window.c:
3869 (modest_connection_specific_smtp_window_finalize),
3870 (modest_connection_specific_smtp_window_fill_with_connections),
3872 (modest_connection_specific_smtp_window_save_server_accounts),
3873 (update_model_server_names): Do not actually save data until asked,
3874 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3876 (on_selection_changed),
3877 (modest_connection_specific_smtp_window_init): Disable the edit
3878 button when nothing is selected.
3880 * src/modest-account-mgr-helpers.c:
3881 * src/modest-account-mgr-helpers.h:
3882 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3885 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3887 * src/modest-account-mgr-helpers.h:
3888 * src/modest-account-mgr-helpers.c:
3889 (modest_account_mgr_get_unused_account_name),
3890 (modest_account_mgr_get_unused_account_display_name): Added these
3891 utility functions, to avoid code duplication.
3893 * src/maemo/easysetup/modest-easysetup-wizard.c:
3894 (create_page_account_details), (create_account):
3895 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3896 (on_combo_security_changed),
3897 (modest_connection_specific_smtp_edit_window_init),
3898 (modest_connection_specific_smtp_edit_window_save_settings):
3899 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3900 * src/maemo/modest-connection-specific-smtp-window.c:
3901 (modest_connection_specific_smtp_window_finalize),
3902 (modest_connection_specific_smtp_window_fill_with_connections),
3903 (on_button_edit), (modest_connection_specific_smtp_window_init):
3904 * src/maemo/modest-connection-specific-smtp-window.h:
3905 Implementing saving of connection-specific server accounts.
3907 But I need to refactor this so we can save the data for each
3908 possible connection-specific account and only actually create the server accounts
3909 when the easysetup finished, or the OK button is pressed on the account settings
3912 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3914 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3915 (on_combo_security_changed):
3916 (modest_connection_specific_smtp_edit_window_init):
3917 Auto-fill the port number as in the account settings.
3919 (modest_connection_specific_smtp_edit_window_set_connection):
3920 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3921 * src/maemo/modest-connection-specific-smtp-window.c:
3922 (fill_with_connections), (on_button_edit),
3923 (modest_connection_specific_smtp_window_init):
3924 Turn the edit window into a dialog to simplify the code, and
3925 set a WM hint as in a GtkDialog, because only a popup can be on top of
3926 another window in Maemo, and popups usually have no WM decoration.
3928 * src/modest-defs.h:
3929 * src/modest-account-mgr-helpers.c:
3930 (modest_account_mgr_set_connection_specific_smtp),
3931 (modest_account_mgr_remove_connection_specific_smtp),
3932 (modest_account_mgr_get_connection_specific_smtp):
3933 * src/modest-account-mgr-helpers.h: Some functions to write the
3934 connection-specific SMTP server information. Not yet used.
3937 * src/widgets/modest-folder-view.c: (text_cell_data):
3938 Fix a warning about an uninitialized variable.
3939 (on_configuration_key_changed): Put an #ifdef around the use
3940 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3942 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3944 * src/maemo/modest-account-settings-dialog.h:
3945 * src/maemo/modest-account-settings-dialog.c:
3946 Added connect_for_modified() utility function to mark the new modified boolean.
3948 (create_page_account_details), (create_page_user_details),
3949 (create_page_incoming), (create_page_outgoing), (on_response),
3950 (modest_account_settings_dialog_init),
3951 (modest_account_settings_dialog_set_account_name):
3952 Only warn about unsaved changes when there are actually unsaved changes.
3954 * src/modest-account-mgr-helpers.c:
3955 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3956 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3957 to get the data from there in future.
3959 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3961 * src/modest-defs.h:
3963 * src/modest-account-mgr-helpers.h:
3964 * src/modest-account-mgr-helpers.c:
3965 Store the security account setting in a single conf key instead of using
3966 the options list, so that the list is left for just the to-be-removed camel hack,
3967 and because gconf_client_set_list() is failing for some reason.
3969 * src/modest-account-mgr.c:
3970 (modest_account_mgr_add_server_account):
3971 * src/maemo/modest-account-settings-dialog.c:
3972 (modest_account_settings_dialog_set_account_name),
3973 (save_configuration): Use the renamed functions.
3976 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3978 * src/widgets/Makefile.am:
3979 * src/widgets/modest-limit-retrieve-combo-box.c:
3980 * src/widgets/modest-limit-retrieve-combo-box.h:
3981 * src/widgets/modest-retrieve-combo-box.c:
3982 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3983 the account settings dialog.
3985 * src/modest-defs.h:
3986 * src/modest-account-mgr-helpers.h:
3987 * src/modest-account-mgr-helpers.c:
3988 (modest_server_account_get_option_secure_auth),
3989 (modest_server_account_set_option_secure_auth):
3990 * src/modest-account-mgr.c:
3991 (modest_account_mgr_add_server_account):
3992 Use the existing AUTH_MECH conf key for the secure-auth setting,
3993 instead of putting it in the list options, because this was actually used already.
3995 * src/maemo/modest-account-settings-dialog.c:
3996 (create_page_account_details),
3997 (modest_account_settings_dialog_set_account_name),
3998 (save_configuration):
3999 * src/maemo/modest-account-settings-dialog.h:
4000 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4001 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4003 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4005 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4006 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4007 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4009 * src/modest-defs.h:
4010 * src/maemo/modest-account-settings-dialog.c:
4011 (create_page_incoming), (on_combo_outgoing_security_changed),
4012 (on_combo_incoming_security_changed), (create_page_outgoing),
4013 (modest_account_settings_dialog_set_account_name),
4014 (save_configuration): Load/Save the port number, and change it when the
4015 security combo changes, to suitable defaults.
4017 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4019 * src/modest-account-mgr.c:
4020 (modest_account_mgr_add_server_account): Set the security and secure-auth
4021 options, and add a comment saying that the other camel-specific options should be
4024 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4026 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4028 * src/modest-tny-account-store.c: (account_list_free),
4029 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4030 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4033 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4035 * src/modest-protocol-info.c:
4036 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4037 is required by our UI spec. Maybe something in our implementation will use this eventually.
4038 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4039 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4040 instead of the previous 0 placeholder.
4042 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4043 secure-auth settings.
4044 * src/modest-account-mgr-helpers.h:
4045 * src/modest-account-mgr-helpers.c:
4046 (modest_server_account_data_get_option_secure_auth),
4047 (modest_server_account_set_option_secure_auth),
4048 (modest_server_account_data_get_option_security),
4049 (modest_server_account_set_option_security): Added this API for getting and setting the security
4050 and secure-auth settings.
4052 * src/maemo/modest-account-settings-dialog.h:
4053 * src/maemo/modest-account-settings-dialog.c:
4054 (modest_account_settings_dialog_finalize), (check_data),
4055 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4056 about changing titles.
4057 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4058 (save_configuration): Save the security and secure-auth settings.
4060 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4061 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4063 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4065 * src/modest-defs.h:
4066 * src/modest-account-mgr.c:
4067 (modest_account_mgr_add_server_account):
4068 Added and used defines for the options key and value pair strings,
4069 that are used so far, though they do not seem to correspond to anything in our
4070 UI specs or ModestProtocol enum.
4072 * src/modest-account-mgr-helpers.h:
4073 * src/modest-account-mgr-helpers.c:
4074 (compare_option_strings_for_name),
4075 (modest_server_account_data_get_option_value),
4076 (modest_server_account_data_get_option_bool),
4077 (modest_account_mgr_get_server_account_option):
4078 Added helper functions for parsing the options GSList.
4080 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4082 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4083 display name is based on the supplied account name.
4084 * src/modest-account-mgr.c:
4085 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4086 with an inefficient, but good-enough, implementation.
4088 * src/maemo/easysetup/modest-easysetup-wizard.c:
4089 (create_page_account_details), (on_before_next), (create_account):
4090 Check for existing display names rather than (non-user-visible) account names, and just
4091 create and set a unique account name at the end.
4093 * src/maemo/modest-account-settings-dialog.c:
4094 (modest_account_settings_dialog_init),
4095 (modest_account_settings_dialog_set_account_name),
4096 (create_page_incoming): Show the display name, instead of the account name.
4097 (on_response): Do some (not all) extra checks, as in the UI spec.
4098 (save_configuration): Save the display name if it was changed.
4100 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4102 * po/en_GB.po: Added needed logical ID and translation.
4103 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4104 (init_view): Made the is-default column clicking work.
4106 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4109 * src/maemo/easysetup/Makefile.am:
4110 * src/maemo/easysetup/modest-easysetup-wizard.c:
4111 (modest_easysetup_wizard_dialog_init):
4112 * src/maemo/easysetup/provider-data-test.keyfile:
4113 * src/maemo/easysetup/provider-data.keyfile:
4114 Moved the provider data file to the new modest-providers-data package and used it from there.
4116 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4118 * src/modest-local-folder-info.c:
4119 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4120 N_() was already used on the static strings, but this just marks it for translation without
4121 using the translation.
4123 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4125 * src/maemo/modest-account-settings-dialog.c:
4126 (create_page_incoming),
4127 (modest_account_settings_dialog_set_account_name):
4128 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4129 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4130 I will do this if nobody else gets there first.
4132 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4134 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4135 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4136 save the security stuff.
4138 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4140 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4141 Set the email address and user fullname, which I now see must be
4144 * src/maemo/modest-account-settings-dialog.h:
4145 * src/maemo/modest-account-settings-dialog.c:
4147 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4148 leave-on-server and authentication.
4149 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4152 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4155 * src/maemo/modest-account-settings-dialog.c:
4156 * src/maemo/modest-account-settings-dialog.h:
4157 Most (but not all) of the widgets are now present as specified by the UI spec.
4158 No changes are yet saved, and some details are not properly shown yet.
4160 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4162 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4164 * src/maemo/Makefile.am:
4165 * src/maemo/modest-account-settings-dialog.c:
4166 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4167 an existing account. Doesn't do much yet.
4169 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4170 Open the accounts settings dialog when Edit is clicked.
4172 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4174 * src/maemo/easysetup/Makefile.am:
4175 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4177 * src/maemo/easysetup/modest-easysetup-wizard.c:
4178 (modest_easysetup_wizard_dialog_init):
4179 Try to get the source directory from the build system,
4180 instead of hard-coding "./" into the source code, when opening our local
4181 copies of the configuration files.
4182 But this still fails when opening the wizard from the Accounts window,
4183 maybe because the working directory seems to change at runtime.
4184 So the wizard will fail the second time unless you copy the files into their
4185 proper locations - see the stdout warnings for the paths.
4187 (create_page_account_details),(on_before_next):
4188 Check for existing non-server accounts instead of server accounts,
4189 so the default account name is useful again, and to prevent trying to
4192 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4193 Show the wizard when New is clicked.
4195 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4196 (init_view): Show the column headers, and show the columns that are
4197 specified in the UI specs. However, something in Maemo's GTK+ prevents
4198 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4199 change the default account. This is despite unsetting the special properties.
4201 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4203 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4204 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4205 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4206 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4207 to make that clearer.
4208 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4210 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4212 * src/maemo/modest-account-view-window.c:
4213 (modest_account_view_window_init),
4214 (modest_account_view_window_new):
4215 Use the same buttons as specified in the
4216 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4217 the existing widgets, which never had a chance of working.
4218 Put the ModestAccountView treeview in a scrolled window.
4219 Do not repeat the initialization in both _init() and _new().
4221 * src/widgets/modest-account-view.c: (update_account_view):
4222 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4223 this widget and window shows no accounts.
4225 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4227 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4229 * src/maemo/easysetup/modest-easysetup-wizard.c:
4230 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4231 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4232 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4235 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4236 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4237 accounts exist yet, as in the UI spec.
4239 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4241 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4243 * src/maemo/Makefile.am:
4244 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4245 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4246 New window for editing connection-specific smtp details.
4247 Not fully implemented.
4249 * src/maemo/modest-connection-specific-smtp-window.c:
4250 (modest_connection_specific_smtp_window_finalize) :
4251 unref the tree model.
4252 (on_button_edit): Show the edit window.
4254 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4256 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4259 * src/maemo/Makefile.am:
4260 * src/maemo/modest-connection-specific-smtp-window.c:
4261 * src/maemo/modest-connection-specific-smtp-window.h:
4262 New window for showing the list of connections, for connection-specific
4263 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4264 * src/maemo/easysetup/modest-easysetup-wizard.c:
4265 (create_page_custom_outgoing): Show the new window when the button is clicked.
4267 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4269 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4270 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4271 * src/maemo/modest-msg-edit-window.c:
4272 (modest_msg_edit_window_insert_image):
4273 * src/modest-conf.c: (modest_conf_key_escape):
4274 * src/modest-mail-operation.c:
4275 (modest_mail_operation_send_new_mail):
4276 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4277 (modest_ui_actions_on_new_account):
4278 * src/widgets/modest-attachment-view.c: (update_filename_request):
4279 * src/widgets/modest-mail-header-view.c:
4280 Corrected warnings that were breaking the build, by commenting out unused variables,
4281 and a function, and by including a header.
4283 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4285 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4286 so we can #ifdef around platform-specific code when necessary.
4287 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4288 to allow this to build for the GNOME platform too.
4290 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4292 * src/maemo/easysetup/modest-easysetup-wizard.c:
4293 Added util_increment_name() and used it in create_page_account_details()
4294 to make sure that the default account name is always a new name.
4296 (modest_easysetup_wizard_dialog_init),
4297 (set_default_custom_servernames): Some minor memory management fixes.
4299 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4303 * src/modest-runtime.c: (init_i18n): Restored the translation
4304 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4305 are defined in config.h, and the translations are installed.
4307 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4308 is defined for translation.
4310 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4312 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4314 * src/maemo/easysetup/modest-easysetup-wizard.c:
4315 (modest_easysetup_wizard_dialog_init):
4316 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4317 Use realistic paths (though they should use $prefix generically) to the
4318 mcc_mapping and provider-data.keyfile files which might work when they
4319 are installed by the future version of the operator-wizard package,
4320 and then fallback to paths in our source code, with an explanatory
4323 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4327 * src/maemo/Makefile.am:
4328 * src/maemo/easysetup/: Added files from the previously-exernal
4329 osso-modest-easysetup.
4330 * src/maemo/modest-main-window-ui.h:
4331 * src/modest-ui-actions.c:
4332 * src/modest-ui-actions.h:
4333 Added modest_ui_actions_on_new_account() as a signal handler for the
4334 New Account menu item. It shows the easysetup wizard.
4335 * po/en_GB.po: Added additional needed logical IDs and translations.