1 2007-07-03 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account.c:
4 (modest_tny_account_get_special_folder): (util_on_idle),
5 Handle the GError so we can see when tny_folder_store_get_folders()
6 fails, as it currently does while something else is connecting.
8 Added util_run_in_main_thread_and_wait()
9 which uses an idlen handler and mainloop to ensure that the function
10 is called in the main thread.
11 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
12 to make sure that we call attempt the connection in the mainloop only,
13 which might solve some hangs.
15 2007-07-03 Murray Cumming <murrayc@murrayc.com>
17 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
18 be found by their display name. This is never useful.
19 * src/modest-tny-account-store.c: (on_account_removed): Find the account
20 by its ID, instead of trying to use its ID as its display name.
22 * src/modest-tny-account-store.h:
23 * src/modest-tny-account.c:
24 (modest_tny_account_get_special_folder): Add a g_warning() when
25 tny_folder_store_get_folders() returns an empty list for the maildir.
27 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
28 Add a g_warning() when this returns NULL, because that it not allowed
31 2007-07-02 Armin Burgmeier <armin@openismus.com>
33 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
34 note when trying to cancel the wizard. This fixes projects.maemo.org
37 2007-07-02 Murray Cumming <murrayc@murrayc.com>
39 * src/modest-tny-account.h:
40 * src/modest-tny-account.c:
41 (modest_tny_account_new_from_server_account),
42 (modest_tny_account_new_from_server_account_name),
43 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
44 because this must now be set before setting the proto. This is usd in
45 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
46 warning in camel_session_get_service() caused by
47 tny_camel_transport_account_prepare().
49 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
52 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
54 * src/maemo/modest-connection-specific-smtp-edit-window.c:
56 (modest_connection_specific_smtp_edit_window_init):
58 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
61 2007-06-29 Murray Cumming <murrayc@murrayc.com>
63 * src/modest-tny-account.c:
64 (modest_tny_account_new_from_server_account):
65 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
66 now uses to request a connection when it needs one, and which it uses
67 to tell us that something is wrong with the connection, so we can force
68 the accounts offline to prevent further problems.
71 * src/modest-init.c: (init_default_settings):
72 * src/modest-mail-operation.c:
73 (modest_mail_operation_update_account):
74 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
75 This should not be necessary anymore. Do not set the conf key that
76 determined this (it was always TRUE and not set anywhere else).
78 * src/modest-ui-actions.h: Remove unused and unimplemented
79 modest_ui_actions_on_online_toggle_toggled().
81 2007-06-29 Murray Cumming <murrayc@murrayc.com
83 * src/maemo/modest-main-window.c: (connect_signals):
84 Don't connect to delete_event twice. Maybe this was harmless.
86 2007-06-29 Murray Cumming <murrayc@murrayc.com
88 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
89 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
90 Debug output to give some more clue when a folder move is not allowed.
92 2007-06-28 Murray Cumming <murrayc@murrayc.com
94 * src/modest-tny-account.c: (on_modest_file_system_info),
95 (modest_tny_account_get_mmc_account_name):
96 Always call the callback, without checking whether the name has changed.
97 * src/widgets/modest-folder-view.c: (strings_are_equal),
98 (on_model_foreach_set_name), (on_get_mmc_account_name),
99 (text_cell_data): Compare the name here, and use the name from
100 the account rather than from the
101 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
102 if the name was changed after the account was added to the model.
103 That's a tinymail bug but not one that I want to fix now.
105 This finally fixes projects.maemo.org bug NB#59301.
107 2007-06-27 Armin Burgmeier <armin@openismus.com>
109 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
112 2007-06-27 Murray Cumming <murrayc@murrayc.com
114 * src/modest-tny-account.h:
115 * src/modest-tny-account.c:
116 Added modest_tny_account_get_mmc_account_name(), to set the memory
117 card name asynchronously for the given account and then notify.
118 (modest_tny_account_new_for_local_folders): Use this new function instead
119 of using hildon_file_system_info_async_new() directly.
121 * src/widgets/modest-folder-view.c: (text_cell_data):
122 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
123 gtk_tree_model_row_changed() when it is available.
125 This should fix projects.maemo.org bug NB#59301.
127 2007-06-27 Murray Cumming <murrayc@murrayc.com
129 * src/modest-mail-operation.c: (update_account_thread),
130 (get_msgs_full_thread): Fix typo failures in the revert
133 2007-06-27 Murray Cumming <murrayc@murrayc.com
135 * src/maemo/modest-maemo-global-settings-dialog.c:
136 (idle_select_default_focus):
137 * src/modest-mail-operation.c: (idle_notify_progress),
138 (idle_notify_progress_once), (set_last_updated_idle),
139 (update_account_thread), (get_msgs_full_thread):
140 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
141 * src/widgets/modest-header-view.c:
142 (idle_notify_headers_count_changed_destroy),
143 (idle_notify_headers_count_changed):
144 Reverted the additions of gdk_threads_enter/leave(), in case this
145 helps with a startup hang on the device.
147 2007-06-26 Armin Burgmeier <armin@openismus.com>
149 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
150 for supported secure authentication methods from server by
151 gtk_dialog_run(), saving CPU time and a potential race condition.
153 2007-06-26 Armin Burgmeier <armin@openismus.com>
155 * src/maemo/modest-maemo-utils.h:
156 * src/maemo/modest-maemo-utils.c: Added a
157 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
158 only error code to tell the calling code when the user canceled the
161 * src/maemo/modest-account-settings-dialog.h:
162 * src/maemo/modest-account-settings-dialog.c:
163 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
164 message if the retrieval of secure authentication methods was canceled
165 by the user. Perform the check before saving anything to configuration
166 to not end up with half-committed configuration changes, do not show
167 a "Saving to configuration failed" note when authentication methods
168 could not be retrieved.
170 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
173 2007-06-26 Murray Cumming <murrayc@murrayc.com>
175 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
176 Only return the first level of folders under accounts, because the
177 osso-global-search UI spec doesn't want the rest.
178 This fixed projects.maemo.org bug NB#61811.
180 2007-06-26 Murray Cumming <murrayc@murrayc.com>
182 * src/modest-tny-account-store.c:
183 * src/modest-tny-account-store.h:
184 Added modest_tny_account_is_memory_card_account().
185 * src/maemo/modest-main-window.c: (create_details_widget):
186 Show the same information items for the memory card as we show for the
187 local-folders, to fix projects.maemo.org bug NB#59307.
189 2007-06-26 Murray Cumming <murrayc@murrayc.com>
191 * src/modest-tny-account-store.c: (get_password):
192 Added some checks for NULL to maybe prevent crashes, though I think
193 it was Philip's last commit that actually prevented the crash here
194 when creating a first new account.
195 But the new account is still not usable (no messages are shown)
196 until a restart of the application.
198 2007-06-26 Murray Cumming <murrayc@murrayc.com>
200 * src/maemo/modest-maemo-global-settings-dialog.c:
201 (idle_select_default_focus):
202 * src/modest-mail-operation.c: (idle_notify_progress),
203 (idle_notify_progress_once), (idle_notify_update_account_queue),
204 (set_last_updated_idle), (update_account_thread),
205 (notify_get_msgs_full), (get_msgs_full_destroyer),
206 (get_msgs_full_thread):
207 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
208 * src/widgets/modest-header-view.c:
209 (idle_notify_headers_count_changed_destroy),
210 (idle_notify_headers_count_changed):
211 Use gdk_threads_enter() and gdk_threads_enter_leave() in
212 all idle handlers, because some other thread could be blocking
213 the GDK lock, so that it can do GUI stuff.
215 2007-06-26 Murray Cumming <murrayc@murrayc.com>
217 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
218 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
219 (on_idle_send_receive), (on_idle_open_default_inbox):
220 * src/maemo/modest-msg-edit-window.c:
221 (modest_msg_edit_window_attach_file_noninteractive):
222 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
223 to prevent a hang. I don't quite understand why these are necessary,
224 beause we should already be in the main loop. I guess something outside
225 of the main loop is taking the lock.
227 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
228 we are really using URIs, and use files that are more likely to exist.
230 2007-06-26 Murray Cumming <murrayc@murrayc.com>
232 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
233 necessary because configure.ac now defines different variables.
235 2007-06-26 Murray Cumming <murrayc@murrayc.com>
237 * libmodest-dbus-client/libmodest-dbus-client.c:
238 * libmodest-dbus-client/libmodest-dbus-client.h:
239 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
240 libmodest_dbus_client_compose_mail() is what things actually use.
242 * src/dbus_api/modest-dbus-api.h:
243 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
244 * tests/dbus_api/Makefile.am:
245 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
248 2007-06-26 Murray Cumming <murrayc@murrayc.com>
250 * src/modest-init.c: (modest_init_local_folders):
251 For memory-card (or other non local-folders) maildir accounts,
252 always create an Archive folder, so that there is somewhere to put
253 messages. This should be less confusing, because the user does not need
254 to guess that the need to create a folder.
256 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
258 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
259 Fixed icon size by using (50, 50) which is the same as defined by
262 2007-06-25 Armin Burgmeier <armin@openismus.com>
264 * src/widgets/modest-window-mgr.c:
266 * configure.ac: Correctly recognize hildon-notify presence and fixed
267 the build without it being installed.
269 2007-06-25 Murray Cumming <murrayc@murrayc.com>
271 * libmodest-dbus-client/libmodest-dbus-client.c:
272 (libmodest_dbus_client_search): Fix the build. Sorry.
273 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
274 (reply_forward_cb): Initialize variables to fix the build.
276 * src/modest-tny-account-store.c:
277 (modest_tny_account_store_get_tny_account_by): Fix the account URI
278 comparison (a silly typo) so that email search results can be opened
279 when there are more than one account.
281 2007-06-25 Murray Cumming <murrayc@murrayc.com>
283 * libmodest-dbus-client/libmodest-dbus-client.c:
284 (libmodest_dbus_client_search),
285 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
286 instead of 1 second, because the search gets folders and messages from
287 the server, which can take a long time. When it times out,
288 osso-global-search will report no results.
290 We need to specify whether we should search only cached information
291 (maybe with a user preference), and the osso-email-search-plugin
292 API should really be improved to allow that option, and to allow results
293 to be delivered asynchronously in batches.
295 2007-06-25 Murray Cumming <murrayc@murrayc.com>
297 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
298 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
299 GTK_ICON_SIZE_DIALOG is probably the wrong size.
301 2007-06-25 Murray Cumming <murrayc@murrayc.com>
303 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
304 that is an empty string. D-Bus seems to give us these instead of NULL.
306 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
308 * src/dbus_api/modest-dbus-callbacks.c:
309 * src/maemo/easysetup/modest-easysetup-wizard.h:
310 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
311 * src/maemo/modest-connection-specific-smtp-edit-window.c:
312 (modest_connection_specific_smtp_edit_window_init):
313 * src/maemo/modest-maemo-global-settings-dialog.c:
315 * src/maemo/modest-maemo-utils.c:
316 (modest_maemo_utils_setup_images_filechooser):
317 * src/maemo/modest-main-window.c: (create_details_widget):
318 * src/maemo/modest-msg-edit-window.c:
319 (modest_msg_edit_window_attach_file_noninteractive),
320 (modest_msg_edit_window_color_button_change),
321 (modest_msg_edit_window_set_zoom):
322 * src/modest-mail-operation.c: (update_account_thread):
323 * src/modest-tny-account-store.c:
324 * src/modest-tny-account.c:
325 * src/widgets/modest-global-settings-dialog.c:
326 * src/widgets/modest-window.h:
330 2007-06-25 Murray Cumming <murrayc@murrayc.com>
332 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
333 * src/modest-search.c: (modest_search_folder),
334 (modest_search_all_accounts): Actually search only in the specified folder,
335 doing a simple match on the folder ID.
336 * src/modest-search.h: Added a folder field to the ModestSearch struct,
337 and added some documentation.
339 2007-06-22 Armin Burgmeier <armin@openismus.com>
341 * src/maemo/modest-maemo-utils.h:
342 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
343 modest_maemo_utils_get_supported_secure_authentication_methods.
345 * src/maemo/easysetup/modest-easysetup-wizard.c:
346 * src/maemo/modest-account-settings-dialog.c: Show correct error if
347 one occured, not just "Server does not support secure authentication".
349 2007-06-22 Murray Cumming <murrayc@murrayc.com>
351 * src/modest-tny-account-store.c: (get_password):
352 Restored the call to tny_account_set_user() because Philip seems to have
353 stopped this from crashing (by not using the freed string). It still does
354 not work, but now we can test it.
356 2007-06-22 Murray Cumming <murrayc@murrayc.com>
358 * src/maemo/modest-msg-edit-window.c: (init_window):
359 Comment out use of an uninitialzed GtkScrolledWindow variable,
360 to fix the build and stop a crash. Yet again.
362 2007-06-22 Murray Cumming <murrayc@murrayc.com>
364 * src/modest-tny-account-store.c: (get_password):
365 Remove the call to tny_account_set_user() because this actually crashes.
366 As mentioned in the last commit, it is known to not work anyway.
368 2007-06-22 Murray Cumming <murrayc@murrayc.com>
370 * src/modest-tny-account-store.c: (get_password):
371 Use tny_account_set_username() to tell tinymail that the username might
372 have changed too. But tinymail ignores this: see projects.maemo.org
374 * src/modest-ui-actions.c:
375 (modest_ui_actions_on_password_requested): Remove the useless attempt to
376 reset the connection when changing the username, and improve the comments.
377 Save the changed username to gconf at least, so it is used when Modest is
380 2007-06-21 Murray Cumming <murrayc@murrayc.com>
382 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
383 Do not use a query, so that we get all folders, including for POP and
384 local-folders. They work as search criteria too.
385 This fixes projects.maemo.org bug NB#57740.
387 2007-06-21 Murray Cumming <murrayc@murrayc.com>
389 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
390 Comment out the use of hildon_notification_set_sound() because it is
391 not declared, to fix the build. Warnings are serious, people.
393 2007-06-21 Armin Burgmeier <armin@openismus.com>
395 * src/maemo/modest-maemo-utils.h:
396 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
397 modest_maemo_utils_get_supported_secure_authentication_methods()
398 to query authentication methods for a specific user. This should fix
399 projects.maemo.org bug NB#61369.
401 * src/maemo/easysetup/modest-easysetup-wizard.c:
402 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
405 2007-06-21 Murray Cumming <murrayc@murrayc.com>
407 * libmodest-dbus-client/libmodest-dbus-client.h:
408 * libmodest-dbus-client/libmodest-dbus-client.c:
409 (modest_dbus_message_iter_get_search_hit),
410 (libmodest_dbus_client_search):
411 Reorganised and commented this.
412 Removed modest_search_hit_free() from the public API because it
415 Added libmodest_dbus_client_get_folders() and
416 modest_folder_result_list_free().
418 * src/dbus_api/modest-dbus-api.h:
419 * src/dbus_api/modest-dbus-callbacks.c:
420 (modest_dbus_req_filter): Commented. Moved most code to
421 on_dbus_method_search() and added on_dbus_method_get_folders().
423 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
424 of the extra D-Bus handler.
426 * tests/dbus_api/Makefile.am:
427 * tests/dbus_api/test_get_folders.c: New test for
428 libmodest_dbus_client_get_folders(). This seems to return an empty list
429 at the moment. That could be the same error that causes the message list
430 to be empty sometimes.
431 This should help with projects.maemo.org bug NB#57740.
433 2007-06-21 Armin Burgmeier <armin@openismus.com>
435 * src/modest-mail-operation.c: Do not call
436 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
437 notify the operation's end after having set the status to CANCELED for
438 the operation queue to listen on. This fixes a deadlock when there
439 were mail operations in the queue during its finalization.
441 * src/modest-singletons.c: Reordered uninitialization of the account
442 manager to happen after the mail operation queue was uninitialized
443 because the mail operation's in the queue might still try to access
444 the account manager (see modest_mail_operation_notify_end()). This
445 fixes a potential crash when terminating the application.
447 2007-06-21 Murray Cumming <murrayc@murrayc.com>
449 * src/modest-search.c:
450 (search_mime_part_and_child_parts): Moved some code here so we
451 can search recursively in child folders.
452 (modest_search_folder): Search in the message as a mime part, instead
453 of just its child mime parts.
454 (read_chunk), (search_mime_part_ogs):
455 Check how many bytes were read, to prevent an endless loop.
456 Searching in message bodies now works. This finishes the fix for
457 projects.maemo.org bug NB#61007.
459 2007-06-20 Murray Cumming <murrayc@murrayc.com>
461 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
462 Add a g_warning when the item is not a folder.
464 * src/modest-ui-dimming-rules.c:
465 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
466 when selected item is not a folder (for instance, an account), because
467 the UI spec only talks about folders.
468 I am not sure what the UI spec wants, so this might not totally fix
469 projects.maemo.org bug NB#60794.
471 2007-06-20 Murray Cumming <murrayc@murrayc.com>
473 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
474 (load_from_file): Sort the list. The unsorted list would be more noticeable
475 in non-English locales.
477 * src/maemo/modest-msg-edit-window.c:
478 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
479 warning and fix the build.
481 * src/maemo/modest-progress-bar-widget.c:
482 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
483 avoid a g_warning, and probably to avoid a crash.
485 2007-06-20 Murray Cumming <murrayc@murrayc.com>
487 * src/modest-search.c: (modest_search_folder): Check for a GError
488 when calling tny_folder_get_headers(), to show that this is not the cause
491 2007-06-20 Murray Cumming <murrayc@murrayc.com>
493 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
494 Actually set the body query instead of the subject query.
496 * src/modest-search.c: (search_mime_part_ogs),
497 (search_mime_part_strcmp): Remove extra space from the text/* regex,
498 which would probably cause it to fail if we got this far.
500 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
501 to simplify the code.
502 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
503 be causing search-in-body to fail.
505 2007-06-20 Murray Cumming <murrayc@murrayc.com>
507 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
509 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
510 Better debug message when the folder cannot be found.
511 This should help with fixing projects.maemo.org bug #61287.
512 * src/modest-search.c: (add_hit): Do not leak the furl string.
514 2007-06-20 Murray Cumming <murrayc@murrayc.com>
516 * src/modest-ui-actions.c:
517 (modest_ui_actions_on_folder_selection_changed):
518 Do not special-case TNY_MERGE_FOLDER here, because
519 modest_tny_folder_get_account() already does that. This fixes
520 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
521 shown when the Outbox was selected).
523 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
525 * libmodest-dbus-client/libmodest-dbus-client.c:
526 (_dbus_iter_get_string_or_null): Initialize the string variable in
527 case this helps with Dirk's crash.
529 2007-06-19 Murray Cumming <murrayc@murrayc.com>
531 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
532 though it is not implemented yet (this function is maybe not even used),
533 to avoid breaking ABI in future.
534 * libmodest-dbus-client/libmodest-dbus-client.c:
535 (get_attachments_string): Moved some code into this generic function.
536 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
537 sends email. It is maybe not used.
538 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
539 (on_send_mail): Use attachments.
541 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
542 * src/maemo/modest-msg-edit-window.c:
543 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
544 a filename before using it, to fix projects.maemo.org bug NB#58233.
546 2007-06-19 Murray Cumming <murrayc@murrayc.com>
548 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
549 Initialize the continue_download variable to fix the build, and probably
550 to fix randome behaviour.
552 2007-06-18 Armin Burgmeier <armin@openismus.com>
554 * src/modest-tny-send-queue.h:
555 * src/modest-tny-send-queue.c: Keep track of the status of messages in
556 the queue so we can later show it in the UI. Replaced
557 modest_tny_send_queue_msg_is_being_sent() by
558 modest_tny_send_queue_get_msg_status().
560 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
562 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
563 gpointer. This probably was not harmful, but just to be sure.
565 2007-06-18 Murray Cumming <murrayc@murrayc.com>
567 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
568 Fix the build, but leave the function broken on Bora, because
569 hildon_uri_action_get_service() does not exist.
570 osso_uri_action_get_service() does not exist either, it seems.
572 2007-06-18 Murray Cumming <murrayc@murrayc.com>
574 * src/modest-tny-account.c:
575 (modest_tny_account_new_from_server_account):
576 Uncommented the url debug output again, because it is useful for
577 debugging, as I said in the comment.
579 2007-06-18 Murray Cumming <murrayc@murrayc.com>
581 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
583 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
584 for Mameo Bora, to fix the build.
586 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
589 Fixed build with hildon < 0.99
591 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
592 Check if the selected account is busy instead of checking all accounts
594 * src/modest-account-mgr-priv.h:
595 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
596 (modest_account_mgr_init), (compare_account_name),
597 (modest_account_mgr_set_account_busy),
598 (modest_account_mgr_account_is_busy):
599 * src/modest-account-mgr.h:
600 Added busy information to the account manager. It possible to
601 set an account to busy or not busy now.
603 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
604 (modest_mail_operation_update_account),
605 (modest_mail_operation_notify_end):
606 Set the account to busy/not busy depending on the operation state.
608 * src/widgets/modest-account-view.c:
609 (modest_account_view_finalize), (get_last_updated_string),
610 (update_account_view), (on_account_busy_changed), (init_view):
611 Show string "Refreshing..." if the account is currently busy.
613 All this fixes projects.maemo.org bug NB#59711
615 2007-06-14 Armin Burgmeier <armin@openismus.com>
617 * src/widgets/modest-attachments-view.h:
618 * src/widgets/modest-attachments-view.c: Added
619 modest_attachments_view_has_attachments() and fixed coordinate
620 transformation in get_att_view_at_coords(). This fixes attachment
623 * src/widgets/modest-msg-view.c: Make use of
624 modest_attachments_view_has_attachments() to decide whether to show
625 attachments in the header.
627 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
629 * src/maemo/modest-connection-specific-smtp-edit-window.c:
630 (on_change), (on_combo_security_changed),
631 (modest_connection_specific_smtp_edit_window_init),
632 (modest_connection_specific_smtp_edit_window_set_connection),
633 (modest_connection_specific_smtp_edit_window_is_dirty):
634 * src/maemo/modest-connection-specific-smtp-edit-window.h:
635 * src/maemo/modest-connection-specific-smtp-window.c:
638 Show an comfirmation dialog for the smpt-edit-window if there are
639 unsaved changes and the user hits cancel.
640 (projects.maemo.org bug NB#60479)
642 2007-06-14 Armin Burgmeier <armin@openismus.com>
644 * src/maemo/easysetup/modest-easysetup-wizard.c:
645 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
646 address" info in banner instead of node, and select all the text as
647 per UI spec. This fixes projects.maemo.org bug NB#60550.
649 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
651 reviewed by: <delete if not using a buddy>
653 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
654 * src/modest-ui-actions.c: (folder_refreshed_cb):
656 2007-06-14 Murray Cumming <murrayc@murrayc.com>
658 * src/widgets/modest-folder-view.c: (filter_row):
659 Explictly filter out the per-account outbox accounts. I don't know why
660 these only sometimes show up, but now they should never show up in the UI.
661 This should fix projects.maemo.org bug NB#60160.
663 2007-06-14 Murray Cumming <murrayc@murrayc.com>
665 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
666 when the toolbar does not exist yet.
667 * src/modest-widget-memory.c: (save_settings_header_view):
668 Added g_warnings() to help us to discover when we are trying to set
669 an empty columns list in gconf.
671 2007-06-14 Murray Cumming <murrayc@murrayc.com>
675 Added modest_init_get_default_header_view_column_ids().
677 * src/modest-widget-memory.c: (restore_settings_header_view):
678 Use the new function to get defaults, if the gconf key is empty,
679 instead of not creating any columns. This seems to fix the
680 empty right-hand pane problems.
682 * src/widgets/modest-header-view.h: Improved documentation.
684 2007-06-13 Murray Cumming <murrayc@murrayc.com>
686 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
687 Revert the use of the display name as the account name, because this
688 is generally wrong and would break the code that follows.
690 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
692 * src/maemo/easysetup/modest-easysetup-wizard.c:
693 (check_for_supported_auth_methods), (on_before_next),
696 More correct fix for projects.maemo.org bug NB# 58991
697 Do not longer accept AUTH_PASSWORD as secure method and choose
698 correct method when creating the account.
700 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
702 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
703 Fixed projects.maemo.org bug NB# 58991
705 2007-06-13 Murray Cumming <murrayc@murrayc.com>
707 * src/modest-init.c: (modest_init_init_core),
708 (modest_init_local_folders): Fixed compilation errors.
710 2007-06-13 Murray Cumming <murrayc@murrayc.com>
712 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
713 Remove unnecessary lib/include, though it is good in principle when needed.
715 * src/modest-init.c: (modest_init_one_local_folder),
716 (modest_init_local_folders):
717 * src/modest-init.h: Initialize the .modest library for memory cards,
718 instead of just doing nothing for them. This should allow us to create
719 folders there, fixing projects.maemo.org bug NB#59297.
721 2007-06-13 Murray Cumming <murrayc@murrayc.com>
723 * libmodest-dbus-client/libmodest-dbus-client.c:
724 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
725 (libmodest_dbus_client_compose_mail),
726 (libmodest_dbus_client_open_message),
727 (libmodest_dbus_client_send_and_receive),
728 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
730 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
731 (on_idle_open_message), (modest_dbus_req_handler),
732 (search_result_to_message), (modest_dbus_req_filter):
733 * src/modest-search.c: (add_hit), (modest_search_folder),
734 (modest_search_all_accounts): Improved debug messages.
736 * tests/dbus_api/test_open_message.c: (main): Improved comments.
738 * src/modest-tny-account-store.c:
739 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
742 2007-06-13 Murray Cumming <murrayc@murrayc.com>
745 2007-06-12 Murray Cumming <murrayc@murrayc.com>
747 * src/modest-tny-account-store.c: (get_server_accounts):
748 Call modest_tny_local_folders_account_add_merged_outbox_folders()
749 even when there are no accounts, so that the Outbox folder is always
750 visible. This fixes projects.maemo.org bug NB#60158.
752 2007-06-12 Murray Cumming <murrayc@murrayc.com>
754 * src/maemo/modest-main-window.c: (create_details_widget):
755 Use the mcen_va_never logical ID.
757 2007-06-12 Murray Cumming <murrayc@murrayc.com>
759 * src/dbus_api/modest-dbus-api.h:
760 * src/dbus_api/modest-dbus-callbacks.c:
761 (on_idle_open_default_inbox), (on_open_default_inbox),
762 (modest_dbus_req_handler):
763 Added a new OpenDefaultInbox method.
765 * libmodest-dbus-client/libmodest-dbus-client.h:
766 * libmodest-dbus-client/libmodest-dbus-client.c:
767 Added libmodest_dbus_client_open_default_inbox() to call the new
768 dbus method. This should be useful to projects.maemo.org bug NB#57214,
769 though it should maybe be used by a new osso-email-interface function.
771 * tests/dbus_api/Makefile.am:
772 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
775 2007-06-12 Murray Cumming <murrayc@murrayc.com>
777 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
778 NULL, so that the signals get all the keys. This should not actually
779 change any behaviour because we currently update everything when anything
782 2007-06-12 Murray Cumming <murrayc@murrayc.com>
784 * src/widgets/modest-folder-view.c: (text_cell_data),
785 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
786 (find_inbox_iter): If tinymail tells us that the folder is
787 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
788 This causes the inbox to be selected at startup, fixing part of
789 projects.maemo.org bug NB#56305.
791 * src/modest-ui-dimming-rules.c:
792 (modest_ui_dimming_rules_on_tools_smtp_servers):
793 * src/modest-ui-dimming-rules.h: Added a callback function to dim
794 the SMTP servers menu item.
795 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
796 that the SMTP Servers menu item is dimmed when there are no accounts,
797 as a future version of the UI spec will require. This fixes
798 projects.maemo.org bug NB#56305.
800 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
802 * src/maemo/modest-maemo-utils.c:
803 (modest_maemo_utils_get_supported_secure_authentication_methods):
804 Added label to dialog instead of unreadable title
806 * src/maemo/modest-main-window.c: (sync_accounts_cb),
807 (modest_main_window_new):
808 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
811 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
812 * src/modest-account-mgr.h:
813 Added method to avoid code duplication
815 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
816 (modest_ui_actions_on_send_receive):
817 Use modest_account_mgr_has_accounts
819 2007-06-11 Murray Cumming <murrayc@murrayc.com>
821 * src/maemo/easysetup/modest-presets.c:
822 (modest_presets_get_info_server_security): Do not report secure auth
824 * src/modest-protocol-info.c: Use the defines for the gconf key names
825 for secure authentication. This was not working because we were writing
826 Password and reading password, and the check was case sensitive.
827 With this, gmail now works for receiving and sending when created via
830 2007-06-11 Murray Cumming <murrayc@murrayc.com>
832 * src/maemo/easysetup/modest-presets.c:
833 (modest_presets_get_info_server_security): Correct the key name for
834 SecureSmtp, because it seems to be case-sensitive.
835 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
836 Do not try to get the 0th notebook page if there are 0 pages, to
839 2007-06-11 Murray Cumming <murrayc@murrayc.com>
841 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
842 Prevent use of the new notification feature for now, because it currently
843 shows one dialog for each new email, which is annoying.
845 2007-06-11 Murray Cumming <murrayc@murrayc.com>
847 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
848 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
849 when no country was selected, so that we show the global ones.
850 * src/maemo/easysetup/modest-presets.c:
851 (modest_presets_get_providers): Return only the global providers, not
852 all providers when mmc=0 was requested.
854 2007-06-11 Murray Cumming <murrayc@murrayc.com>
856 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
857 (easysetup_provider_combo_box_fill): Remove debug code that showed the
858 provider ID in the combo.
860 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
861 Do not show the page numbers, because it would be confusing when we add
862 the 2 extra pages for the custom setup, when the user chooses the "Other"
863 provider. This fixes projects.maemo.org bug NB#59028
865 * src/modest-init.c: (modest_init_init_core),
866 (modest_init_local_folders):
868 * src/modest-tny-account.c:
869 (modest_tny_account_new_for_local_folders): Do not create default folders
870 for the memory card. This should fix projects.maemo.org bug NB#59328.
872 2007-06-11 Murray Cumming <murrayc@murrayc.com>
874 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
875 Free the changed_conf_keys string items. They are already freed in the
876 idle handler if that runs first.
878 2007-06-11 Murray Cumming <murrayc@murrayc.com>
880 * src/modest-ui-actions.c:
881 (modest_ui_actions_on_password_requested): Check that the server name
882 is not NULL, because I just saw a password dialog with (null) as the
885 * src/modest-tny-folder.[h|c]: Added
886 modest_tny_folder_is_memory_card_folder().
887 * src/modest-ui-dimming-rules.c:
888 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
889 menu item for memory cards, as per the UI spec (section 7.4). This should
890 fix projects.maemo.org bug NB#59297.
892 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
894 * src/maemo/modest-main-window.c: (sync_accounts_cb):
895 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
896 is another problem with the code, see Murray's comment at line 772)
898 2007-06-08 Murray Cumming <murrayc@murrayc.com>
900 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
901 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
902 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
903 (load_from_file), (easysetup_country_combo_box_init),
904 (easysetup_country_combo_box_get_active_country_ids),
905 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
906 instead of just one ID, to avoid duplicate country names in the UI.
908 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
909 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
910 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
911 a single ID, avoiding duplicate providers.
912 * src/maemo/easysetup/modest-easysetup-wizard.c:
913 (on_combo_account_country): Adapt to use a list.
915 2007-06-08 Murray Cumming <murrayc@murrayc.com>
917 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
918 keys changed in the last X seconds.
920 * src/modest-account-mgr.h:
921 * src/modest-account-mgr.c: (on_timeout_notify_changes),
922 (on_key_change), (modest_account_mgr_class_init),
923 (modest_account_mgr_init), (modest_account_mgr_finalize):
924 As the keys are changed, save them in a GSList* and signal that GSList*
925 further every X seconds, to batch changes, to allow us to do just one
926 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
927 bug NB#56941 and other (UI-blocking) delays when changing account settings.
929 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
930 changed signal signature.
932 * src/modest-conf.c: (modest_conf_set_list),
933 (modest_conf_on_change): Reenable notification.
935 (modest_conf_maemo_fake_on_change): Comment out the hack that
936 notified immediately instead of asynchronously.
938 * src/widgets/modest-account-view.h:
939 * src/widgets/modest-account-view.c:
940 (update_account_view): Select the previously-selected account ID,
941 if possible. This fixes projects.maemo.org bug NB#56933.
943 (on_account_changed), (on_account_removed),
944 (modest_account_view_select_account):
946 Remove the block/unblock functions
947 because they were not useful.
949 * src/maemo/modest-account-view-window.c:
950 (on_delete_button_clicked), (on_edit_button_clicked),
951 (on_new_button_clicked): Remove the use of the non-working block/unblock.
953 2007-06-08 Murray Cumming <murrayc@murrayc.com>
955 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
956 Improve the error dialog to show Incorrect Account Settings, which seems
957 clearer, and say that the internal error message (to be removed from the
958 dialog later) is often misleading.
959 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
961 * src/modest-tny-account.c:
962 (modest_tny_account_new_from_server_account): Uncomment the printf of the
963 URL because this is so useful for debugging on the device.
965 * src/widgets/modest-serversecurity-combo-box.c:
966 (modest_serversecurity_combo_box_fill): Correct a logical ID.
968 2007-06-08 Murray Cumming <murrayc@murrayc.com>
970 * src/modest-mail-operation.c:
971 (modest_mail_operation_send_new_mail):
972 Added a comment about a nasty but apparently harmless message. Details
973 added to the wiki g_warnings() page.
975 2007-06-08 Murray Cumming <murrayc@murrayc.com>
977 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
978 (modest_tny_send_queue_class_init):
979 Do not use the priv struct because it is empty, to avoid g_warnings
980 about a non-existant priv struct.
982 * src/modest-tny-account-store.c:
983 (modest_tny_account_store_get_server_account),
984 (modest_tny_account_store_get_transport_account_for_open_connection
985 ): Do not try to get transport server accounts for local folders,
986 because they don't have any. This avoids a g_warning().
988 * src/maemo/modest-main-window.c:
989 (modest_main_window_notify_send_receive_initied),
990 (on_configuration_key_changed):
991 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
993 * src/modest-mail-operation.c:
994 (modest_mail_operation_update_account):
995 * src/modest-tny-account-store.h:
996 * src/modest-tny-account.c:
997 (modest_tny_account_get_special_folder),
998 (modest_tny_account_new_for_local_folders),
999 (modest_tny_account_new_for_per_account_local_outbox_folder):
1000 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1001 * src/modest-tny-local-folders-account.c:
1002 (add_account_folders_to_merged_folder):
1003 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1004 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1005 (modest_ui_actions_on_send):
1006 * src/widgets/modest-folder-view.c: (update_model):
1007 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1008 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1009 modest_tny_account_store_get_tny_account_by_account() to
1010 modest_tny_account_store_get_server_account() to make the code clearer.
1012 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1014 * src/dbus_api/modest-dbus-api.h:
1015 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1016 * src/maemo/modest-msg-edit-window.c:
1017 (modest_msg_edit_window_attach_file_noninteractive):
1018 added g_warning in case the file to be attached does not exist
1019 * tests/dbus_api/test_compose_mail.c: (main):
1020 removed obsolete comment, added generic files as test case
1022 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1024 * src/modest-tny-account-store.c: (get_server_accounts):
1025 Create the local folders account only once, not once for each outbox, and
1026 not only when there are some outboxes.
1028 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1030 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1031 code that is causing a crash at startup. Sergio says that he is fixing this.
1033 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1035 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1036 * src/maemo/modest-account-settings-dialog.c:
1037 (create_page_outgoing),
1038 (modest_account_settings_dialog_set_account_name),
1039 (save_configuration):
1040 - Fixed handling of the "Use secure authentication" toggle to comply with
1041 the ui specification. See also projects.maemo.org bug NB#58400
1043 - Restore the Secure connection setting combo correctly when loading
1046 * src/maemo/modest-maemo-utils.c:
1047 (on_camel_account_get_supported_secure_authentication),
1048 (modest_maemo_utils_get_supported_secure_authentication_methods):
1049 Fixed a crasher if operation is canceled
1051 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1052 (modest_protocol_info_auth_is_secure):
1053 * src/modest-protocol-info.h:
1055 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1056 the sense of the "Use secure authentication" toggle.
1058 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1060 * src/modest-tny-account-store.h:
1061 * src/modest-tny-account-store.c:
1062 Added modest_tny_account_store_get_local_folders_account().
1064 * src/modest-tny-folder.h:
1065 * src/modest-tny-folder.c:
1066 (modest_tny_folder_get_account):
1067 Added this replacement for tny_folder_get_account() which returns
1068 the local-folders account for TnyMergeFolders, to avoid the
1069 warning about the unimplemented get_account_func() vfunc().
1071 (modest_tny_folder_get_rules),
1072 * src/modest-ui-actions.c:
1073 (modest_ui_actions_on_folder_selection_changed):
1074 * src/modest-mail-operation.c:
1075 (modest_mail_operation_remove_folder),
1076 (modest_mail_operation_xfer_folder),
1077 (modest_mail_operation_rename_folder),
1078 (modest_mail_operation_get_msg),
1079 (modest_mail_operation_get_msgs_full),
1080 (modest_mail_operation_remove_msg),
1081 (modest_mail_operation_xfer_msgs),
1082 (modest_mail_operation_refresh_folder):
1083 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1085 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1087 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1088 (modest_server_account_set_security):
1089 * src/modest-defs.h: Add comments explaining that our
1090 UI spec means TLS when it says Normal, so these do not look like errors.
1092 * src/modest-tny-account.c:
1093 (modest_tny_account_new_from_server_account): Use the new tinymail
1094 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1095 for TLS. This should fix projects.maemo.org bug NB#58460.
1097 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1099 * src/maemo/easysetup/modest-easysetup-wizard.c:
1100 (create_account): Correct the position of the gconf sanity check warning.
1101 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1102 of using the g_idle_add() hack, because this does not seem to be necessary
1103 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1104 caused by something other than maemo's gconf.
1105 This fixes projects.maemo.org bug #59022.
1107 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1109 * src/modest-account-mgr-helpers.c:
1110 (modest_account_mgr_get_default_account): Do not check that the account
1111 exists if there is no default account (NULL), to fix a runtime warning.
1113 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1115 * src/widgets/modest-folder-view.c: (update_model):
1116 Do not unref the treemodel before we have finished with it.
1117 This prevents a valgrind warning and an occasional crash at startup.
1119 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1121 * libmodest-dbus-client/libmodest-dbus-client.h:
1122 added libmodest_dbus_client_compose_mail()
1123 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1125 added functions needed for SendAsMail() functionality
1126 * src/maemo/modest-msg-edit-window.c:
1127 (modest_msg_edit_window_attach_file_noninteractive):
1128 non interactively attaching files to message edit window
1129 * src/widgets/modest-msg-edit-window.h:
1130 * tests/dbus_api/Makefile.am:
1131 added test_compose_mail.c
1132 * tests/dbus_api/test_compose_mail.c: (main):
1134 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1136 * src/modest-account-view.c:
1137 Fixed bug projects.maemo.org bug NB#59307
1139 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1141 * src/maemo/easysetup/modest-easysetup-wizard.c:
1142 (get_serverport_incoming), (on_before_next), (create_account):
1143 * src/maemo/modest-account-settings-dialog.c:
1144 (modest_account_settings_dialog_set_account_name):
1145 * src/maemo/modest-maemo-utils.c:
1146 (on_camel_account_get_supported_secure_authentication_status),
1147 (on_camel_account_get_supported_secure_authentication),
1148 (on_secure_auth_cancel),
1149 (modest_maemo_utils_get_supported_secure_authentication_methods):
1151 Implemented security authentication for settings and easysetup.
1153 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1155 * src/maemo/modest-main-window.c: (create_details_widget):
1156 Show the total size for memory card accounts too, instead of showing
1157 the name again. Fixes bug projects.maemo.org bug NB#59307.
1159 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1162 * src/modest-tny-simple-folder-store.c:
1163 * src/modest-tny-simple-folder-store.h: Removed.
1165 * src/modest-tny-local-folders-account.h
1166 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1167 for the local-folders maildir, with an extra TnyMergedFolder containing
1168 the folders of the per-account outbox store accounts.
1169 * src/modest-tny-account-store.c: (get_server_accounts):
1170 Add the outboxes to the special local folders account after creating it.
1172 * src/modest-tny-account.c:
1173 (modest_tny_account_new_for_local_folders): Create the derived
1174 account when creating the main local-folders account.
1176 * src/maemo/modest-main-window.c: (create_details_widget),
1177 (modest_main_window_set_contents_style):
1178 Adapted to the use of the derived account instead of the folder store.
1180 * src/modest-ui-actions.c:
1181 (modest_ui_actions_on_folder_selection_changed):
1182 * src/modest-ui-dimming-rules.c:
1183 (modest_ui_dimming_rules_on_new_folder):
1184 * src/widgets/modest-folder-view.c: (text_cell_data),
1185 (icon_cell_data), (filter_row), (update_model),
1186 (get_cmp_rows_type_pos):
1189 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1190 Do not get the priv struct, because no priv struct has been set,
1191 to avoid a runtime warning.
1193 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1194 #ifelse with #else, to fix a warning, to fix the build.
1197 2007-06-05 Christian Kellner <ckellner@openismus.com>
1199 * libmodest-dbus-client/libmodest-dbus-client.c:
1200 Fix small typo in doc (why do you always see them
1201 AFTER committing stuff?)
1204 2007-06-05 Christian Kellner <ckellner@openismus.com>
1206 * libmodest-dbus-client/libmodest-dbus-client.c:
1207 (libmodest_dbus_client_search):
1208 Initialize hit list with NULL. Also set folder list
1209 to "" if NULL was supplied.
1212 2007-06-03 Christian Kellner <ckellner@openismus.com>
1214 * libmodest-dbus-client/libmodest-dbus-client.c:
1215 (modest_search_hit_list_free):
1216 Make it save to call it with NULL.
1218 * src/dbus_api/modest-dbus-callbacks.c:
1219 * src/modest-search.c:
1220 Return full ModestSearchHits as the search result list not TnyHeader
1221 since can't be around withouth the correspoding TnyFolder.
1223 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1225 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1226 Added currently commented code to check for secure auth
1228 * src/maemo/modest-account-settings-dialog.c: (on_response),
1229 (save_configuration), (show_ok):
1230 Fixed projects.maemo.org bugs NB #59248 and #59251
1232 * src/maemo/modest-maemo-utils.c:
1233 (on_camel_account_get_supported_secure_authentication_status),
1234 (on_camel_account_get_supported_secure_authentication),
1235 (modest_maemo_utils_get_supported_secure_authentication_methods):
1236 * src/maemo/modest-maemo-utils.h:
1237 Moved get_supported_secure_authentication() method here to be able
1238 to use it from easysetup wizard.
1240 * src/modest-pair.c: (on_pair_compare_as_string):
1241 Should compare string with first part of pair and not
1242 strcmp pairs which will crash.
1244 * src/modest-protocol-info.c:
1245 (modest_protocol_info_protocol_is_store):
1246 * src/modest-protocol-info.h:
1247 Added modest_protocol_info_get_auth_protocol_name()
1249 2007-06-03 Armin Burgmeier <armin@openismus.com>
1251 * src/modest-mail-operation.c:
1252 (modest_mail_operation_get_msgs_full): Set priv->account also when
1253 only retrieving a single message. This avoids a crash when canceling
1256 (modest_mail_operation_notify_end): Do not explicitely remove the
1257 operation from the queue but only emit the progress_changed signal.
1258 The queue itself listens to that signal to remove the operation when
1259 it is finished. This reduces coupling and removes a potential deadlock
1260 when modest_mail_operation_notify_end() is called from the queue
1261 itself. If that is a problem performance-wise, I would suggest to
1262 implement a status-changed signal or something.
1264 * src/modest-mail-operation-queue.c: Make sure to never call a
1265 function from another file while the queue is locked. This (hopefully)
1266 fixes another deadlock when exiting the application while retrieving
1269 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1271 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1272 Fixed build if libogs is not available
1274 2007-06-03 Christian Kellner <ckellner@openismus.com>
1276 * libmodest-dbus-client/libmodest-dbus-client.h:
1277 * libmodest-dbus-client/libmodest-dbus-client.c:
1278 (libmodest_dbus_client_delete_message):
1279 Implement deletion of messages (Client side).
1281 (modest_search_hit_free),
1282 (modest_search_hit_list_free):
1283 Utility functions to free the result hits.
1285 * src/dbus_api/modest-dbus-api.h:
1286 * src/dbus_api/modest-dbus-callbacks.c:
1287 (on_delete_message),
1288 (modest_dbus_req_handler):
1289 Implement deletion of messages (Server side).
1291 * tests/dbus_api/test_search.c: (main):
1294 * tests/dbus_api/Makefile.am:
1295 * tests/dbus_api/test_delete_message:
1296 Add little test for the message deletion logic
1298 2007-06-03 Armin Burgmeier <armin@openismus.com>
1300 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1301 when the operation queue was not empty. projects.maemo.org bug
1304 2007-06-03 Armin Burgmeier <armin@openismus.com>
1306 * src/widgets/modest-account-view.c
1307 (on_account_default_toggled): Toggle default account column
1308 explicitely instead of waiting for gconf notification (which is
1309 currently ignored). This should fix projects.maemo.org bug NB#56910
1310 for now. It should probably be removed when gconf notifications are
1313 2007-06-03 Christian Kellner <ckellner@openismus.com>
1315 * libmodest-dbus-client/libmodest-dbus-client.c:
1316 Removed debugging spew.
1318 * src/dbus_api/modest-dbus-callbacks.c:
1319 Added debugging info.
1321 * src/modest-search.c:
1322 (modest_search_all_accounts):
1323 Use tny_account_store_get_accounts () on the account store
1324 to get all accounts which is the way to get all accounts.
1326 * tests/dbus_api/test_search.c: (main):
1327 Make it possible to supply the search term on the command line.
1329 2007-06-03 Christian Kellner <ckellner@openismus.com>
1331 * libmodest-dbus-client/libmodest-dbus-client.c:
1332 * libmodest-dbus-client/libmodest-dbus-client.h:
1333 Implement searching for mesages over raw dbus. (Client side)
1335 * src/dbus_api/Makefile.am:
1336 * src/dbus_api/modest-dbus-api.h:
1337 * src/dbus_api/modest-dbus-callbacks.c:
1338 * src/dbus_api/modest-dbus-callbacks.h:
1339 Search framework (Server side). Also implement on_idle_open_message().
1341 * src/maemo/modest-platform.c: (modest_platform_init):
1342 Prepare for raw dbus/osso rpc interaction.
1344 * src/modest-search.h:
1345 Changed minsize from unspecific guint to guint32.
1347 * src/modest-search.c:
1349 Added strange hack which magically made tnymail work.
1351 (modest_search_folder),
1352 (modest_search_account),
1353 (modest_search_all_accounts):
1354 Implement helper functions to search all accounts, specific account
1357 * tests/dbus_api/Makefile.am:
1358 * tests/dbus_api/test_open_message.c:
1359 Read url to open from commandline.
1361 * tests/dbus_api/test_search.c:
1362 Implement small test for dbus search stuff
1364 2007-06-02 Armin Burgmeier <armin@openismus.com>
1366 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1367 include account type and account title. This fixes projects.maemo.org
1370 * src/maemo/modest-account-view-window.c: Set a title for the window.
1372 2007-06-02 Armin Burgmeier <armin@openismus.com>
1374 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1375 incoming and outgoing server name based on email address and server
1376 types as long as the names have not been edited manually. This fixes
1377 projects.maemo.org bug NB#58671.
1379 2007-06-02 Armin Burgmeier <armin@openismus.com>
1381 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1382 server type cannot be changed in future to the incoming details page
1383 when creating an account. This fixes projects.maemo.org bug NB#59029.
1385 2007-06-02 Armin Burgmeier <armin@openismus.com>
1387 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1388 and assigned max width chars so that they wrap instead of being
1389 truncated. Fixes projects.maemo.org bug NB#56126.
1391 2007-06-02 Armin Burgmeier <armin@openismus.com>
1393 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1394 introductory note to the connection specific smtp servers dialog, as
1395 section 8.12 of the email UI specification requires. This fixes
1396 projects.maemo.org bug NB#59212.
1398 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1400 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1401 Check for running mail operations, and offer to cancel them, as per the UI
1402 spec. This fixes projects.maemo.org bug NB#59041 .
1403 However, I suspect that tinymail may still use the network connection
1404 in ways that we cannot detect or cancel. But it should at least adapt to
1405 changes fairly well.
1407 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1409 * src/modest-tny-account-store.c: (recreate_all_accounts),
1410 (get_cached_accounts), (get_server_accounts): Do more sensible
1411 ref-counting of the temporarily-cached outbox accounts list. This seems
1412 to fix a crash when entering the password when the password was wrong.
1414 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1416 * src/gnome/modest-main-window.c: (connect_signals):
1417 * src/modest-tny-account-store.c: (get_password),
1418 (modest_tny_account_store_alert): Added comments and clues and
1419 commented-out code about how we currently fail to deal with connection
1420 errors and wrong passwords, and how we should.
1422 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1424 * src/widgets/modest-retrieve-combo-box.c:
1425 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1426 This fixes projects.maemo.org bug NB#58472 .
1428 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1430 * src/maemo/easysetup/modest-easysetup-wizard.c:
1431 (create_page_complete_easysetup):
1432 (create_page_complete_custom): Correct the last commit,
1433 putting the correct sentences in the correct pages.
1435 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1437 * src/maemo/easysetup/modest-easysetup-wizard.c:
1438 (create_page_complete_custom): Show the second sentence of text
1439 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1442 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1444 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1445 Set the leave-on-server conf key by default. This fixes
1446 projects.maemo.org bug NB#59258 .
1448 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1450 * src/maemo/modest-account-view-window.c:
1451 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1452 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1455 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1457 * src/maemo/easysetup/modest-easysetup-wizard.c:
1458 (create_caption_new_with_asterisk):
1459 * src/maemo/modest-account-settings-dialog.c:
1460 (create_caption_new_with_asterisk):
1461 Uncomment the code to add the asterisk, because they are no longer in the
1462 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1463 (update_incoming_server_title): Add an asterisk here too.
1465 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1467 * src/maemo/modest-maemo-global-settings-dialog.c:
1468 (current_connection): Check that we are even connected before trying to
1469 get the current connection name, to prevent a warning.
1471 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1472 Change the comments because tny_maemo_conic_device_connect() is now meant to
1474 * src/modest-mail-operation.c:
1475 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1476 make sure we have a connection and fail if we can't connect.
1478 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1480 * src/maemo/modest-main-window.c:
1481 (on_account_store_connecting_finished): Do not try to get the
1482 connection ID if we are not really connected. I am surprised that
1483 this signal handler is called when we are not connected.
1485 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1487 * src/modest-error.h:
1488 * src/modest-ui-actions.c:
1489 (modest_ui_actions_get_msgs_full_error_handler):
1490 Renamed an enum, added comments, added an enum
1491 for retrieve-limit errors.
1493 * src/modest-mail-operation.c: (foreach_add_item),
1494 (internal_folder_observer_update), (update_account_thread),
1495 (modest_mail_operation_get_msgs_full):
1496 (modest_mail_operation_update_account),
1497 Added comments about how this works, and some code that should
1498 (but does not) check the retrieve-limit. See the TODO comment.
1500 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1502 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1503 Initialize help_id to fix the build. Warnings are good.
1505 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1507 * src/widgets/modest-hbox-cell-renderer.c:
1508 (modest_hbox_cell_renderer_append):
1509 * src/widgets/modest-vbox-cell-renderer.c:
1510 (modest_vbox_cell_renderer_append):
1511 Fix the last commit by doing an extra ref.
1513 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1515 * src/widgets/modest-hbox-cell-renderer.c:
1516 (modest_hbox_cell_renderer_append):
1517 * src/widgets/modest-vbox-cell-renderer.c:
1518 (modest_vbox_cell_renderer_append):
1519 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1520 to fix the build with Maemo Bora.
1521 However, there seems to be a remaining crash, probably due to reference
1524 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1526 * src/modest-tny-account.c:
1527 (modest_tny_account_new_for_local_folders):
1528 Use hildon_file_system_info_async_new() to get a better name for
1529 the memory card account, setting it as the account name.
1530 The timing seems to work, but this is probably
1531 not the best place to do this. See the TODO comment.
1532 * src/maemo/modest-main-window.c: (create_details_widget):
1533 * src/widgets/modest-folder-view.c: (text_cell_data):
1534 Use the tny account name instead of hardcoding a name.
1536 2007-05-30 Christian Kellner <ckellner@openismus.com>
1538 * src/modest-search.c: (modest_search):
1539 Correctly set part_search_func even if we have already parsed
1540 the query and thus a valid OgsTextSearcher object.
1542 2007-05-30 Christian Kellner <ckellner@openismus.com>
1545 Search and check for libogs.
1548 Incooparte the ogs build env.
1550 * src/modest-mime-part-search-stream.c:
1551 * src/modest-mime-part-search-stream.h:
1552 Removed since we do the real searching now in modest-search.c.
1554 * src/modest-search.c:
1555 * src/modest-search.h:
1556 Implement support for ogs. We use that if available and requested
1557 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1558 should now handle the corner case when the search term is spread
1559 across multiple reads.
1560 Also the logic in modest_search () was corrected to search all
1561 requested fields until one is found.
1563 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1565 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1567 * src/modest-init.h:
1568 * src/modest-init.c: Made modest_init_local_folders() take a
1569 path and be public so we can iniitialize maildir folders on
1572 * src/modest-local-folder-info.h:
1573 * src/modest-local-folder-info.c:
1574 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1576 * src/modest-tny-account.c:
1577 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1578 still means the standard local-folders path on the local volume.
1580 * src/modest-tny-account-store.c:
1581 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1582 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1583 all accounts when that happens.
1584 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1585 this too, so it shows up in the treeview.
1587 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1589 * src/maemo/modest-maemo-global-settings-dialog.c:
1590 (current_connection):
1591 * src/widgets/modest-global-settings-dialog.c:
1592 (current_connection_default):
1593 Use the enum values instead of 0, 1 and -1,
1594 to make the code clearer.
1596 * src/modest-account-mgr-helpers.c:
1597 (modest_account_mgr_get_connection_specific_smtp): Make this code
1600 * src/modest-runtime.h:
1601 * src/modest-runtime.c:
1602 Added modest_runtime_remove_all_send_queues().
1603 * src/maemo/modest-main-window.c:
1604 (on_account_store_connecting_finished): Recreate the send queues,
1605 using the appropriate transport accounts for this new connection.
1606 Some futher adapting might be needed if the old send queues are not
1607 automatically stopped at this point.
1609 * src/modest-tny-account-store.c: (get_server_accounts):
1610 Create the connection-specific transport accounts, so that they can
1611 be found later by their ID.
1613 * src/modest-tny-account.h:
1614 * src/modest-tny-account.c:
1615 Added modest_tny_account_new_from_server_account_name().
1616 modest_tny_account_new_from_server_account(): Do not create the
1617 send queues here, because they will be
1618 recreated anyway when the connection changes for the first time.
1620 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1622 * src/modest-local-folder-info.h:
1623 * src/modest-local-folder-info.c:
1624 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1625 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1626 tbox_folder): Take a modest account name instead of a server TnyAccount,
1627 so we can have per-modest-account rather than per-transport-account
1629 We must make sure that we change or recreate the exisitng send queues
1630 when the connection changes for connection-specific transport accounts.
1632 * src/modest-tny-account-store.c:
1633 (create_per_account_local_outbox_folders): Create outboxed per modest
1634 account, not per transport account.
1636 * src/modest-tny-account.h:
1637 * src/modest-tny-account.c:
1638 (modest_tny_account_get_special_folder): For outboxes, get the
1639 parent modest account name. The account is ignored for other folders.
1640 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1641 modest account name rather than a server TnyAccount.
1643 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1645 * src/modest-tny-account.c:
1646 (modest_tny_account_new_from_server_account):
1647 Call modest_runtime_get_send_queue() immediately after creating transport
1648 accounts, so that they start trying to send email from the outbox as soon
1649 as possible at startup. This is probably what we want.
1651 * src/modest-mail-operation.c: (update_account_thread):
1652 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1653 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1654 * src/modest-tny-send-queue.h:
1655 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1656 (modest_ui_actions_on_send):
1657 Added comments about how sending works, though it needs some more work.
1659 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1661 * src/modest-tny-account.c:
1662 (modest_tny_account_get_special_folder): Add TODO because this fails when
1663 the network is busy.
1664 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1665 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1666 Do not try to show this window when there is no active account. The UI
1667 specs does not tell us what to do in this case.
1669 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1673 * src/maemo/Makefile.am:
1674 * src/widgets/Makefile.am: Some dist fixes.
1676 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1678 * src/maemo/modest-connection-specific-smtp-window.c:
1679 (on_button_edit): Make the code clearer, to prevent a double free.
1681 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1683 * src/maemo/modest-account-settings-dialog.c:
1684 (modest_account_settings_dialog_set_account_name),
1685 Check the connection-specific smtp servers checkbox if there are any.
1687 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1688 (modest_connection_specific_smtp_edit_window_init):
1689 Start with a suitable port number.
1691 * src/modest-account-mgr-helpers.h:
1692 * src/modest-account-mgr-helpers.c: Added
1693 modest_account_mgr_get_has_connection_specific_smtp().
1695 (modest_account_mgr_set_connection_specific_smtp),
1696 (modest_account_mgr_remove_connection_specific_smtp),
1697 (modest_account_mgr_get_has_connection_specific_smtp),
1698 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1699 connection-specific smtp server accounts in the account, rather than
1700 the server account conf dir.
1702 This fixes bug projects.maemo.org bug NB#58263 .
1704 * src/modest-tny-account-store.c:
1705 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1706 if there are no server accounts yet, to prevent an infinite loop when there
1707 are no accounts. Document that one must be called before the other.
1709 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1711 * src/modest-account-mgr-helpers.c:
1712 (modest_account_mgr_get_default_account): Make sure that at least
1713 one account is always the default, if there are any enabled accounts.
1714 This is just a sanity check that shouldn't be necessary.
1716 * src/modest-account-mgr-priv.c:
1717 (_modest_account_mgr_account_from_key): Unescape the conf key to
1718 get the real account name. For instance, this is an issue if a space
1719 was in the account name, which can happen because the account name
1720 is generated from the display name.
1721 (_modest_account_mgr_get_account_keyname): Always escape the
1723 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1724 Unescape the conf keys to get the real account names.
1726 For instance, previously the is-default radio button in the accounts
1727 list was not checked for any accounts at first. This fixes that,
1728 and might fix several similar bugs.
1730 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1732 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1733 Removed some debug printfs.
1735 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1737 Modest on-disk outbox directories are now here, for instance:
1738 $HOME/.modest/outboxes/<account-id-1>/outbox
1739 $HOME/.modest/outboxes/<account-id-2>/outbox
1741 $HOME/.modest/local-folders/outbox
1742 so we can have a separate outbox for each account.
1743 But they are shown as one outbox in the GtkTreeView, by using a
1744 TnyMergeFolder in a ModestTnySimpleFolderStore.
1747 * src/modest-tny-simple-folder-store.c:
1748 * src/modest-tny-simple-folder-store.h:
1749 Added ModestTnySimpleFolderStore, used to contain folders from
1750 other folder stores, such as other accounts.
1752 * src/modest-tny-outbox-account.h:
1753 * src/modest-tny-outbox-account.c:
1754 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1755 used for the per-account local outbox folders.
1757 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1758 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1759 only use this (internally) now for the non-outbox local folders.
1761 * src/modest-init.h:
1762 * src/modest-init.c: Added modest_init_one_local_folder(), for
1763 setting up the directory structure for each local folder.
1765 * src/modest-local-folder-info.c:
1766 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1767 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1769 * src/modest-local-folder-info.h:
1770 * src/modest-tny-account-store.c: (on_account_removed),
1771 (on_account_changed), (create_per_account_local_outbox_folders),
1772 (get_server_accounts), (modest_tny_account_store_get_accounts),
1773 (modest_tny_account_store_get_tny_account_by_account),
1774 (modest_tny_folder_store_is_virtual_local_folders):
1776 * src/modest-tny-account.h:
1777 * src/modest-tny-account.c:
1778 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1779 to create an on-disk per-account local outbox folder for each
1781 (create_per_account_local_outbox_folders): Create a local outbox folder
1782 for each transport account.
1783 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1784 for all local folders.
1786 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1787 instead of using g_object_get/set() directly. It is clearer.
1789 (modest_tny_folder_store_get_message_count),
1790 (modest_tny_folder_store_get_local_size
1791 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1792 because we now use these with non-acount folder stores.
1794 (modest_tny_account_get_special_folder),
1795 (modest_tny_account_new_from_server_account),
1796 (modest_tny_account_new_from_account):
1797 (recurse_folders): Adjust to the new outbox system.
1799 * src/modest-tny-folder.h:
1800 * src/modest-tny-folder.c:
1801 (modest_tny_folder_is_local_folder),
1802 (modest_tny_folder_get_local_folder_type),
1803 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1805 * src/widgets/modest-main-window.h:
1806 * src/maemo/modest-main-window.c: (create_details_widget),
1807 (modest_main_window_set_contents_style): Show details for any folder store,
1810 (modest_tny_folder_get_rules):
1811 Remove the const. C does not support constness enough for this.
1813 * src/modest-ui-actions.c:
1814 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1815 make all outboxes appear as one, in the usual local-folders tree node.
1817 (set_active_account_from_tny_account),
1818 (modest_ui_actions_on_folder_selection_changed):
1819 * src/widgets/modest-folder-view.c: (text_cell_data),
1820 (icon_cell_data), (filter_row),
1821 (add_account_folders_to_merged_folder),
1822 (add_account_folders_to_simple_folder_store), (),
1823 (get_cmp_rows_type_pos), (cmp_rows),
1824 (modest_folder_view_set_account_id_of_visible_server_account):
1825 Adjust to the new outbox system, using generic folder stores and folders
1826 in the GtkTreeModel.
1828 2007-05-23 Christian Kellner <ckellner@openismus.com>
1830 * src/modest-mail-operation.c:
1831 (modest_mail_operation_update_account):
1832 Use info->max_size instead of unintialized local var [small
1833 build fix]. (Added TODO to review that change since I don't
1836 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1838 * libmodest-dbus-client/libmodest-dbus-client.c:
1839 (libmodest_dbus_client_compose_mail): function added
1840 * src/dbus_api/modest-dbus-api.h:
1841 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1842 (on_compose_mail): Implementation of the SendAsMail functionality
1844 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1846 * src/modest-account-mgr.c:
1847 (modest_account_mgr_add_server_account): Set the secure-connection
1848 conf key for transport accounts as well as store accounts. I don't know
1849 why the if was there. For instance, this makes sure that we use SSL
1850 for the gmail preset from the easysetup wizard.
1852 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1854 * src/gnome/modest-main-window.c:
1855 (on_account_store_connecting_finished), (connect_signals):
1856 * src/maemo/modest-main-window.c:
1857 (on_account_store_connecting_finished), (connect_signals),
1858 (modest_main_window_new):
1859 Handle TnyAccountStore::connecting-finished instead of
1860 TnyDevice::connection-changed, because we cannot actually perform
1861 operations on accounts until TnyAccountStore has itself responded to
1862 the TnyDevice::connection-changed signal. This prevents a GError from
1864 Do not try to update at startup, because we (at least on scratchbox)
1865 already do an update at startup when the device goes online.
1866 This prevents a GError from tinymail.
1867 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1868 Added TODO about stopping simultaneous operations.
1870 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1872 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1873 * src/modest-mail-operation-queue.c:
1874 (modest_mail_operation_queue_remove):
1875 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1876 about where they happened.
1878 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1880 * src/modest-ui-actions.c:
1881 (modest_ui_actions_on_password_requested): Make sure that the remember
1882 output parameter is always TRUE.
1884 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1886 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1887 Show a OK/Cancel dialog if the error is a question, though we still do not
1888 know anything more about what we are asking the user.
1889 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1890 Fix an uninitialized variable (helper). This is a logic error, however.
1892 2007-05-21 Christian Kellner <ckellner@openismus.com>
1894 * src/modest-search.h:
1895 Correct bit shifting in the ModestSearchFlags enum.
1897 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1899 * src/modest-tny-account.c:
1900 (modest_tny_account_new_from_server_account): Do not use the lsub and
1901 check-all hard-coded IMAP options when using POP.
1903 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1905 * src/modest-tny-account.c:
1906 (modest_tny_account_new_from_server_account):
1907 Use NULL for the secure-auth method for POP when Password auth has been
1908 specified by the user, as we already do for IMAP. "auth=Login" causes
1909 an error from camel or the server.
1911 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1913 * src/maemo/modest-account-settings-dialog.c:
1914 (create_page_account_details),
1915 (modest_account_settings_dialog_set_account_name):
1916 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1917 for the leave-on-server checkbox, rathr than just the checkbox, when
1918 the protocol is not POP.
1920 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1922 * src/widgets/modest-account-view.c:
1923 * src/widgets/modest-account-view.h:
1924 Added modest_account_view_select_account() which will be useful later
1925 to asynchronously re-select the edited account.
1927 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1929 * src/maemo/modest-account-settings-dialog.c:
1930 (modest_account_settings_dialog_set_account_name):
1931 Automatically choose the port numbers based on the secure authentication
1932 methods, if they have not been chosen before.
1933 This fixes projects.maemo.org bug NB#56273 .
1935 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1937 * src/maemo/modest-main-window-ui.h:
1938 * src/modest-ui-actions.c:
1939 * src/modest-ui-actions.h:
1940 Connect the Tools/SMTP Servers menu item to
1941 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1942 SMTP servers dialog, as in the UI specification and saves changes when it
1943 is closed. This fixed projects.maemo.org bug NB#56305 .
1945 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1947 * src/maemo/modest-connection-specific-smtp-window.c:
1948 (modest_connection_specific_smtp_window_init):
1949 Use gtk_window_set_default_size() to make this window big enough, so
1950 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1952 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1954 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1955 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1956 (modest_connection_specific_smtp_edit_window_init),
1957 Do not try to connect to a combobox signal before the combobox exists.
1958 This fixes the cras in projects.maemo.org bug NB#56288 .
1959 (modest_connection_specific_smtp_edit_window_get_settings):
1960 Remove the server_account_name parameter which was being checked for NULL
1961 though it was not used.
1963 * src/maemo/modest-connection-specific-smtp-window.c:
1964 (modest_connection_specific_smtp_window_fill_with_connections),
1965 (on_button_edit), (modest_connection_specific_smtp_window_init):
1966 Correct the number of treemodel columns to prevent a warning.
1967 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1968 libconic does not work.
1970 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1972 * src/modest-tny-account.c:
1973 (modest_tny_account_new_from_server_account):
1974 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1975 SMTP when "None" was chosen by the user. However, with my SMTP server that
1976 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1979 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1981 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1982 to explain the memory management issue with the ID in the ModestPair.
1984 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1985 (add_sending_page), (modest_account_assistant_finalize):
1986 * src/gnome/modest-gnome-global-settings-dialog.c:
1987 (create_updating_page), (create_composing_page):
1988 * src/gnome/modest-msg-edit-window.c: (get_transports),
1989 (init_window), (modest_msg_edit_window_finalize),
1990 (modest_msg_edit_window_get_msg_data):
1991 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1992 * src/gnome/modest-transport-widget.c:
1993 (modest_transport_widget_finalize), (smtp_configuration):
1994 * src/maemo/modest-maemo-global-settings-dialog.c:
1995 (create_updating_page), (create_composing_page):
1996 * src/maemo/modest-msg-edit-window.c: (get_transports),
1997 (init_window), (modest_msg_edit_window_finalize),
1998 (modest_msg_edit_window_get_msg_data),
1999 (modest_msg_edit_window_free_msg_data):
2000 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2001 (modest_store_widget_finalize):
2002 * src/maemo/modest-transport-widget.c:
2003 (modest_transport_widget_finalize), (smtp_configuration):
2004 * src/modest-main.c: (send_mail):
2005 * src/widgets/modest-combo-box.h:
2006 * src/widgets/modest-global-settings-dialog-priv.h:
2007 * src/widgets/modest-global-settings-dialog.c:
2008 (modest_global_settings_dialog_finalize):
2009 * src/widgets/modest-msg-edit-window.h:
2010 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2011 as long as the combo box, to prevent use of freed memory for the ID.
2013 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2015 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2016 get_accounts(), to make this clearer. Do not check for the enabled gconf
2017 key, because we do not use this for server accounts (at least, not yet).
2018 This allows us to send email again.
2020 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2022 * src/maemo/modest-platform.c:
2023 (on_modest_conf_update_interval_changed), (modest_platform_init):
2024 Only respond to this particular key change. All these strcmp()s cannot be
2027 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2029 * src/maemo/modest-maemo-global-settings-dialog.c:
2030 (current_connection): Prevent a crash in scratchbox when
2031 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2032 * src/maemo/modest-platform.c:
2033 (on_modest_conf_update_interval_changed), (modest_platform_init):
2034 Get the update interval from gconf and reset it when the gconf key changes.
2036 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2038 * src/modest-protocol-info.c:
2039 * src/modest-protocol-info.h: Adde enum-specific get functions,
2040 instead of using a ModestProtocolType enum parameter.
2042 * src/gnome/modest-account-assistant.c:
2043 * src/gnome/modest-store-widget.c:
2044 * src/gnome/modest-store-widget.h:
2045 * src/gnome/modest-transport-widget.c:
2046 * src/gnome/modest-transport-widget.h:
2047 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2048 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2049 * src/maemo/easysetup/modest-easysetup-wizard.c:
2050 * src/maemo/modest-account-settings-dialog.c:
2051 * src/maemo/modest-account-settings-dialog.h:
2052 * src/maemo/modest-store-widget.c:
2053 * src/maemo/modest-store-widget.h:
2054 * src/maemo/modest-transport-widget.c:
2055 * src/maemo/modest-transport-widget.h:
2056 * src/modest-account-mgr-helpers.c:
2057 * src/modest-account-mgr-helpers.h:
2058 * src/modest-account-mgr.c:
2059 * src/modest-account-mgr.h:
2060 * src/modest-tny-account.c:
2061 * src/modest-tny-folder.c:
2062 * src/widgets/modest-account-view.c:
2063 * src/widgets/modest-retrieve-combo-box.c:
2064 * src/widgets/modest-retrieve-combo-box.h:
2065 * src/widgets/modest-secureauth-combo-box.c:
2066 * src/widgets/modest-serversecurity-combo-box.c:
2067 * src/widgets/modest-serversecurity-combo-box.h:
2068 * tests/check_account-mgr.c:
2069 Use the specific functions, and use the re-renamed enum values for GNOME too.
2071 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2073 * src/modest-pair.h:
2074 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2075 so we can get the second based on the first.
2077 * src/maemo/modest-account-settings-dialog.h:
2078 * src/maemo/modest-account-settings-dialog.c:
2079 Added get_supported_secure_authentication_methods(), though it is mostly
2080 commented-out for now until the necessary API is committed to tinymail.
2081 (modest_account_settings_dialog_set_account_name),
2082 (save_configuration): Request the supported authentication methods from the
2083 server, so we can choose a working method.
2085 * src/modest-tny-account-store.h:
2086 * src/modest-tny-account-store.c:
2087 (modest_tny_account_store_get_session): Rename from
2088 tny_account_store_get_session().
2090 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2092 * src/modest-protocol-info.h: Split the ModestProtocol enum
2093 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2094 There was no need to have these unrelated values in one enum.
2096 * src/: many files: Adapted to changed enum. This makes the code a bit
2097 clearer, and the compiler could catch some errors.
2099 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2101 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2102 Show the detailed internal camel error message when an error happens
2103 during the configuration, so that our testers can give us more clues.
2104 For instance, in projects.maemo.org bug NB#56910 .
2106 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2108 * src/modest-tny-account.c:
2109 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2110 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2112 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2114 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2115 * src/maemo/modest-account-settings-dialog.c:
2116 (modest_account_settings_dialog_set_account_name),
2117 (save_configuration): For the incoming secure authentication checkbox,
2118 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2119 the UI specification. PLAIN does not seem to be supported for most IMAP
2120 servers anyway, and I am not sure what it would mean.
2121 However, we probably need to discover which of the secure-authentication
2122 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2123 * src/modest-account-mgr-helpers.c:
2124 (modest_account_mgr_get_server_account_data):
2126 * src/modest-tny-account.c:
2127 (modest_tny_account_new_from_server_account):
2128 Use tny_account_set_mech() to set secure-authentication methods,
2129 with some special-casing for IMAP, based on my observations of how
2132 * src/modest-account-mgr-helpers.h:
2133 * src/modest-account-mgr.c:
2134 * src/modest-defs.h: Comment that the URI is only used for local folders.
2136 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2138 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2139 parameter const, just to be neat.
2140 * src/modest-text-utils.c: (modest_text_utils_inline):
2141 End g_strconcat() with NULL, as its documentation says. This is almost
2142 certainly the cause of my crash at startup on the device. Interestingly,
2143 valgrind doesn't tell us about these errors.
2145 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2147 * scripts/build-packages: Added more precise comments about how to use
2148 this script, though I still get this error:
2149 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2150 error building tinymail
2152 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2154 * src/maemo/modest-main-window.c: (on_account_update):
2155 Very slight cleanup, hoping to make it simpler to discover what causes
2156 a crash here sometimes.
2158 * src/modest-tny-account.c:
2159 (modest_tny_account_new_from_server_account): Set the port. Added
2160 comments about the options and a TODO comment because I need to find out
2161 how to specify the secure authentication method.
2163 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2165 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2166 changed CFlags paths form modest to libmodest
2168 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2170 * src/modest-account-mgr-helpers.c:
2171 (modest_account_mgr_get_server_account_data),
2172 (modest_account_mgr_free_server_account_data):
2173 * src/modest-account-mgr-helpers.h:
2174 * src/modest-account-mgr.c:
2175 (modest_account_mgr_add_server_account):
2176 * src/modest-defs.h:
2177 * src/modest-tny-account.c:
2178 (modest_tny_account_new_from_server_account):
2179 Determine the options for tny_camel_account_add_option() here,
2180 based on the settings, rather than storing them directly in gconf.
2182 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2184 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2185 Show a more friendly error dialog now that we expect (from the tinymail
2186 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2188 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2190 * src/maemo/modest-main-window.c: (on_account_update): Check that
2191 account_name is not NULL, to prevent a crash at startup that I am
2192 seeing on the N800. I do wonder why it is NULL.
2194 * src/maemo/easysetup/modest-easysetup-wizard.c:
2195 (create_page_user_details):
2196 * src/maemo/modest-account-settings-dialog.c:
2197 (create_page_user_details), (create_page_outgoing):
2198 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2199 (modest_connection_specific_smtp_edit_window_init):
2200 * src/modest-ui-actions.c:
2201 (modest_ui_actions_on_password_requested):
2202 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2203 might do something useful with the on-screen keyboard.
2205 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2207 * src/maemo/modest-main-window.c: (on_account_update):
2208 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2209 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2211 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2213 * src/modest-tny-account-store.c: (on_account_changed):
2214 Correct the signature of this signal handler.
2216 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2218 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2219 Show a HildonNote instead of a GtkDialog for Maemo.
2221 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2223 * src/widgets/modest-account-view.h:
2224 * src/widgets/modest-account-view.c: (on_account_changed),
2225 (on_account_removed). Added a boolean flag, set/unset by
2226 modest_account_view_block_conf_updates(),
2227 modest_account_view_unblock_conf_updates() to prevent unnecessary
2228 updates, but this is not very useful because the gconf notifications are
2229 so delays (maybe only on Maemo Bora).
2230 So auto-updating is turned off, and these functions do an explicit
2231 update when necessary.
2232 However, something else is still doing too much work when adding/removing
2233 accounts, probably in another part of the application.
2235 * src/maemo/modest-account-view-window.c:
2236 (on_delete_button_clicked), (on_edit_button_clicked),
2237 (on_new_button_clicked): Use the new functions.
2239 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2241 * src/modest-account-mgr-helpers.c:
2242 (modest_account_mgr_set_first_account_as_default):
2243 Sort the list of names alphabetically-by-title, so we choose the first one
2245 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2246 alphabetically by the title.
2248 This fixes projects.maemo.org bug NB#56418 .
2250 * src/modest-account-mgr-priv.c:
2251 (_modest_account_mgr_account_from_key):
2252 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2253 avoid a valgrind error, and possible random behaviour.
2255 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2257 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2258 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2259 tinymail documentation to say that this can be expected.
2260 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2261 pretty, and should not happen, but I would prefer to know when it does.
2263 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2265 * configure.ac: When using the older hildon version, probably on Bora,
2266 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2268 * src/widgets/modest-attachment-view.c:
2269 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2272 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2274 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2275 Implemented the prototype. Can be tested with
2276 tests/dbus_api/test_open_message:
2278 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2280 * src/modest-tny-account-store.c:
2281 (modest_tny_account_store_instance_init), (get_password):
2282 * src/modest-ui-actions.c:
2283 (modest_ui_actions_on_password_requested):
2284 Do not store the password in gconf, because this function is called
2285 for non-remembered passwords. Actually use the cached (in the hash map)
2286 password instead of releasing it.
2287 The password will now not be remembered if it is asked via the protected
2288 password dialog, as per the UI spec.
2290 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2292 * src/modest-defs.h:
2293 * src/modest-account-mgr-helpers.h:
2294 * src/modest-account-mgr-helpers.c:
2295 Added modest_server_account_get_username_has_succeeded(),
2296 modest_server_account_set_username_has_succeeded().
2297 (modest_server_account_set_username),
2298 Reset the has-succeeded flag if the username changes.
2300 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2301 * src/maemo/modest-connection-specific-smtp-window.c:
2302 (modest_connection_specific_smtp_window_save_server_accounts):
2303 Use modest_server_account_set_username() instead of using
2304 modest_conf_set_string() directly, so that the has-succeeded flag is always
2307 * src/modest-ui-actions.c:
2308 (modest_ui_actions_on_password_requested): Dim the username entry if
2309 the username has ever worked, as per the UI spec.
2311 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2313 * src/modest-tny-account-store.c: (get_password):
2314 * src/modest-ui-actions.c:
2315 (modest_ui_actions_on_password_requested):
2316 Allow the username to be changed too, though there is more work to
2317 be done on exactly how this behaves.
2319 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2321 * src/modest-account-mgr-helpers.h:
2322 * src/modest-account-mgr-helpers.c:
2323 Added modest_account_mgr_get_display_name(),
2324 modest_server_account_get_username(),
2325 modest_server_account_set_username(),
2326 modest_server_account_set_password(),
2327 modest_server_account_get_hostname() functions so we do not need to
2328 use the conf API directly.
2330 * src/maemo/modest-main-window.c: (connect_signals):
2331 Actually connect ot the ModestAccountStore::request-password signal,
2332 so that we show the dialog when the password is requested by Tinymail,
2333 for isntance if it is empty.
2335 * src/modest-marshal.list:
2336 * src/modest-tny-account-store.c:
2337 (modest_tny_account_store_class_init), (get_password),
2338 (modest_tny_account_store_alert):
2339 * src/modest-tny-account-store.h:
2340 * src/modest-ui-actions.h:
2341 * src/modest-ui-actions.c:
2342 (modest_ui_actions_on_password_requested):
2343 Change the signal parameters, so it is obvious that we are providing
2344 the non human-readable server name, and receiving both the username
2345 and password, though changing of the username is not yet implemented.
2346 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2347 for the GNOME version.
2349 This should fix the projects.maemo.org bug NB#56209, though it does not
2350 work on Bora, because the gconf_client_get() for the password fails
2351 immediately after we save it with gconf_client_set().
2353 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2356 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2357 caused an undefined symbol error:
2358 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2360 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2362 * src/modest-tny-account-store.c:
2363 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2364 using a GError instead of a string message, so we can translate it in
2367 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2369 * src/maemo/modest-address-book.c:
2370 (modest_address_book_check_names):
2371 * src/maemo/modest-msg-view-window.c:
2372 (modest_msg_view_window_clipboard_owner_change):
2373 * src/modest-init.c: (modest_init_init_ui):
2374 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2375 (update_folders_cb), (modest_mail_operation_update_account):
2376 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2377 (modest_ui_actions_on_msg_attachment_clicked),
2378 (modest_ui_actions_on_msg_recpt_activated):
2379 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2380 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2381 (modest_msg_view_search_next):
2382 * src/widgets/modest-recpt-editor.c:
2383 (modest_recpt_editor_on_button_release_event),
2384 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2385 g_message(). At this point we should only be seeing interesting errors on
2386 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2388 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2390 (modest_wizard_dialog_force_title_update):
2391 * src/maemo/easysetup/modest-wizard-dialog.h:
2392 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2393 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2394 can update the title when appropriate. Otherwise the title is wrong if the
2395 pages are added after adding the notebook to the dialog.
2396 This must be a problem in HildonWizardDialog too.
2397 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2399 * src/maemo/easysetup/modest-easysetup-wizard.c:
2400 (create_subsequent_customsetup_pages),
2401 (create_subsequent_easysetup_pages):
2402 Call modest_wizard_dialog_force_title_update() so that the title is
2403 correct even with GTK+ < 2.10.
2404 This fixes projects.maemo.org bug NB#56145 .
2406 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2408 * src/maemo/modest-platform.c:
2409 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2410 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2413 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2415 * src/widgets/modest-window.h:
2416 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2417 and modest_window_save_state(), which invokes it.
2419 * src/widgets/modest-window-mgr.h:
2420 * src/widgets/modest-window-mgr.c:
2421 Added modest_window_mgr_save_state_for_all_windows(), which calls
2422 the save_state vfunc on all registered windows, if implemented.
2424 * src/gnome/modest-msg-edit-window.c:
2425 * src/gnome/modest-msg-view-window.c:
2426 * src/maemo/modest-msg-edit-window.c:
2427 * src/maemo/modest-msg-view-window.c:
2428 * src/maemo/modest-main-window.c:
2429 Specify the existing save_settings functions as implementations of
2430 ModestWindow::save_state_func().
2432 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2433 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2434 enabling hibernation, for instance.
2436 We may need to do the same thing for restoring settings.
2439 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2441 * src/widgets/modest-window-mgr.c:
2442 * src/widgets/modest-window-mgr.h:
2443 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2444 modest_window_mgr_get_hibernation_is_prevented().
2446 * src/maemo/modest-main-window.c:
2447 (on_hildon_program_is_topmost_notify): Prevent hibernation
2448 (possible when the application goes to the background in the WM),
2449 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2451 * src/maemo/easysetup/modest-easysetup-wizard.c:
2452 (modest_easysetup_wizard_dialog_init):
2453 * src/maemo/modest-account-settings-dialog.c:
2454 (modest_account_settings_dialog_init):
2455 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2456 (modest_connection_specific_smtp_edit_window_init):
2457 * src/maemo/modest-connection-specific-smtp-window.c:
2458 (modest_connection_specific_smtp_window_init):
2459 * src/maemo/modest-signature-editor-dialog.c:
2460 (modest_signature_editor_dialog_init):
2461 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2462 prevent hibernation while any of these account settings dialogs are open.
2464 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2466 * src/maemo/Makefile.am:
2467 * src/maemo/modest-osso-state-saving.c:
2468 * src/maemo/modest-osso-state-saving.h: Added
2469 modest_osso_load_state() and modest_osso_save_state() though they do
2470 nothing now. They should iterate through all the open windows and load/save
2472 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2473 save state when closing.
2475 * src/maemo/modest-main-window.c:
2476 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2477 Add a notification handler for the HildonProgram::is-topmost property,
2478 so we can allow hibernation when the application goes into the background.
2479 But we still need to detect when the accounts setup windows are open so
2480 we can stop hibernation when they are open.
2481 To do this, I also added the main window the HildonProgram. This might have
2482 other side-effects/benefits, and should maybe be done for other windows.
2484 * src/maemo/modest-osso-autosave-callbacks.h:
2485 * src/maemo/modest-osso-autosave-callbacks.c:
2486 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2487 though it does not do anything yet, and we might never need this to do
2488 anything. For instance, we already save drafts.
2490 * src/maemo/modest-platform.c: (modest_platform_init):
2491 Specify the libosso auto-save callback.
2493 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2495 * src/maemo/modest-platform.c:
2496 (modest_platform_set_update_interval):
2497 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2498 aparently stays valid between application instances, so we can use this
2499 to remove and reset it later. According to a maemo-developers email from
2502 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2504 * configure.ac: Depend on libalarm for Maemo.
2506 * src/dbus_api/modest-dbus-api.h:
2507 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2508 (on_send_receive), (modest_dbus_req_handler):
2509 Handle a SEND_RECEIVE D-Bus method.
2511 * libmodest-dbus-client/libmodest-dbus-client.c:
2512 (libmodest_dbus_client_send_and_receive):
2513 * libmodest-dbus-client/libmodest-dbus-client.h:
2514 Add C convenience functions for calling the new D-Bus method.
2516 * src/modest-platform.h:
2517 * src/gnome/modest-platform.c:
2518 * src/maemo/modest-platform.c:
2519 Added modest_platform_set_update_interval(), which uses the
2520 alarmd API on Maemo.
2521 (modest_platform_init),
2522 Call modest_platform_set_update_interval(), using a hard-coded
2523 interval for now (until the global settings dialog is implemented),
2524 though I am not sure that this makes sense yet.
2526 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2528 * src/dbus_api/modest-dbus-callbacks.c:
2529 (modest_osso_cb_hw_state_handler):
2530 * src/dbus_api/modest-dbus-callbacks.h:
2531 * src/maemo/modest-platform.c: (modest_platform_init):
2532 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2533 in case this has some effect on the ability for Maemo to ping the
2536 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2538 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2539 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2540 warning. It is probably a logic error, but I need to fix the build.
2542 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2544 * src/modest-account-mgr.h:
2545 * src/modest-account-mgr.c:
2546 (modest_account_mgr_account_names): Add a gboolean enabled_only
2547 parameter, so we can get lists of onlt the enabled accounts.
2549 (modest_account_mgr_add_account),,
2550 (modest_account_mgr_account_with_display_name_exists):
2551 * src/maemo/modest-msg-edit-window.c: (get_transports):
2552 * src/modest-account-mgr-helpers.c:
2553 (modest_account_mgr_set_first_account_as_default):
2554 * src/modest-init.c: (init_default_account_maybe):
2555 * src/modest-tny-account-store.c: (get_accounts):
2556 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2557 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2558 * tests/check_account-mgr.c: (START_TEST):
2559 Provide the extra parameter, as appropriate.
2561 * src/widgets/modest-account-view.c: (update_account_view):
2562 Do not show disabled accounts (meaning that there is no way to
2563 enable/disable accounts in the UI (the feature is not in our UI
2564 specification), so we can use this internally only to mark unfinished
2565 or temporary account data.
2567 * src/maemo/easysetup/modest-easysetup-wizard.c:
2568 (create_account): Add boolean enable parameter, so we can specify FALSE
2569 to create the temporary account.
2570 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2571 (on_before_next): When finishing, when there is a temporary account, just
2573 Also, use a timeout to delay the showing of the dialog until gconf is likely
2574 to return correct information, due to a maemo gconf bug that is fixed in
2575 osso 1.1, but not yet in Bora.
2576 However, the dialog stays on screen after it is destroyed.
2578 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2579 for invalid data when cancelling. Use a hildon note instead of a dialog
2580 to complain about invalid data. Do not show the account-saved note if the
2581 account is disabled (a temporary account that will not really be saved for use
2584 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2586 * src/modest-account-mgr-helpers.h:
2587 * src/modest-account-mgr-helpers.c:
2588 Added modest_account_mgr_unset_default_account(),
2589 Added modest_account_mgr_set_first_account_as_default().
2591 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2592 If it was the default account, unset the default account name.
2594 * src/maemo/modest-account-view-window.c:
2595 (on_delete_button_clicked): If it was the default account,
2596 set the first remaining account as the default instead.
2598 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2599 a NULL account or a NULL default account, to prevent a crash. This should
2600 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2603 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2605 * src/widgets/modest-recpt-editor.c:
2606 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2607 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2608 TODO comment for this. This fixes the build.
2610 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2611 be the best place for it. This will in future update all auto-update accounts,
2612 rather than just the current/default account, when that gconf key exists.
2613 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2614 if there are no accounts, before calling do_send_receive().
2615 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2617 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2618 * src/maemo/modest-main-window-ui.h:
2619 * src/maemo/modest-main-window.c: (on_connection_changed),
2620 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2621 directly, becaue the signal handler does more.
2623 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2625 * src/modest-account-mgr-helpers.c:
2626 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2627 for the case that the account does not exist.
2629 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2630 (equivalent to the modest account name) rather than the tinymail account name
2631 (equivalent to the modest account title - human readable) to get the account data.
2632 Check for null account data to prevent the crash, and add a TODO comment saying that
2633 this needs fixing because it is using the server account name instead of the account name.
2635 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2637 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2638 * src/maemo/modest-account-settings-dialog.c: (show_error),
2640 Use hildon_note_new_information() for informative and error messages,
2641 which seems to be expected for Maemo applications (no documentation that I know of
2642 says this). I am surprised that there is no distinction between info and error
2645 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2647 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2648 it is easy to find where this is used.
2650 * src/maemo/easysetup/modest-easysetup-wizard.c:
2651 (create_page_welcome), (create_page_account_details),
2652 (create_page_user_details), (create_page_complete_easysetup),
2653 (create_page_custom_incoming), (create_page_custom_outgoing),
2654 (create_page_complete_custom):
2655 * src/maemo/modest-account-settings-dialog.c:
2656 (create_page_account_details), (create_page_user_details),
2657 (create_page_incoming), (create_page_outgoing):
2658 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2659 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2660 (modest_connection_specific_smtp_edit_window_init):
2661 * src/maemo/modest-connection-specific-smtp-window.c:
2662 (modest_connection_specific_smtp_window_init):
2663 * src/maemo/modest-signature-editor-dialog.c:
2664 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2665 and scrolling policy as per the Email Application Layout Guide, if I have
2668 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2670 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2671 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2672 which were empty, because these vfuncs have been removed from TnyAccountStore.
2673 This fixes the build.
2675 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2677 * src/maemo/modest-main-window.c:
2678 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2679 showing/hiding it. Added TODO because it probably should not be NULL.
2680 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2681 because unnecessary g_warnings() make degugging difficult.
2683 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2685 * src/maemo/modest-msg-edit-window.c:
2686 (modest_msg_edit_window_select_color),
2687 (modest_msg_edit_window_select_background_color): 2 const corrections and
2688 moving 2 #endifs before closing brackets, to fix the build.
2690 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2692 * src/maemo/easysetup/modest-easysetup-wizard.h:
2693 * src/maemo/easysetup/modest-easysetup-wizard.c:
2694 (modest_easysetup_wizard_dialog_finalize),
2695 (on_button_edit_advanced_settings), (create_page_complete_custom),
2696 (on_response), (create_account):
2697 Implement the Advanced Settings edit button, by saving the account information,
2698 for the Advanded Settings dialog to use directly from gconf, and removing it
2699 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2700 Bug #5533 in the projects.maemo.org bugzilla.
2702 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2704 * src/maemo/modest-msg-view-window.c:
2705 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2706 when opening a message window.
2708 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2710 * src/maemo/easysetup/modest-easysetup-wizard.c:
2711 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2714 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2715 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2716 gconf settings. I probably added more checks than necessary, but that is safer.
2718 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2719 variable to fix the build, but this seems to be used when it is still NULL.
2721 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2723 * src/modest-platform.h:
2724 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2725 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2726 * src/modest-main.c: Implement this function so we can avoid using
2727 maemo-specific API from cross-platform code.
2729 * src/modest-tny-account-store.c:
2730 (get_smtp_specific_transport_account_for_open_connection):
2731 * src/modest-ui-actions.c: (check_for_connection),
2732 (modest_ui_actions_on_item_not_found):
2733 Use modest_platform_connect_and_wait() and put #idefs around other
2734 maemo-specific code, because only maemo currently has a way to
2735 identify connection names.
2737 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2739 * src/modest-tny-account-store.h:
2740 * src/modest-tny-account-store.c:
2741 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2742 the connection-specific SMTP server settings in the configuration.
2744 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2746 * src/maemo/modest-main-window.c: (on_connection_changed),
2748 * src/modest-main.c: (main), (start_ui), (send_mail):
2749 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2750 that is what is intended.
2752 * src/modest-ui-actions.c: (action_send), (action_receive),
2753 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2754 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2755 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2756 SMTP server is used when it is specified.
2758 (modest_ui_actions_on_send_receive):
2759 Check that a connection is open before proceeding.
2760 Receive and then send, instead of vice-versa, as per the specification.
2762 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2764 * src/modest-mail-operation.c:
2765 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2766 though I guess it should be something other than NULL.
2768 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2770 * src/maemo/easysetup/modest-easysetup-wizard.c:
2771 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2772 combo twice, to avoid an g_warning and to make it visible again.
2773 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2774 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2775 (already intended) dereference when detaching, because we then recreate the menu.
2776 But I am not sure why the warning was happening, and it is possible that this is a memory
2779 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2781 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2782 and uri_parse_mailto() utility functions.
2783 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2785 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2787 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2789 * src/dbus_api/modest-dbus-api.h:
2790 * src/dbus_api/modest-dbus-callbacks.c:
2791 Use an idle callback to execute the modest code in the application's own thread.
2792 Remove the helloworld example method.
2793 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2794 parsed, and the open-message method is not implemented because this is not yet implemented in
2796 * libmodest-dbus-client/libmodest-dbus-client.c:
2797 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2798 (libmodest_dbus_client_open_message):
2799 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2801 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2802 body without crashing.
2804 * tests/dbus_api/Makefile.am:
2805 * tests/dbus_api/test_mail_to.c:
2806 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2808 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2810 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2811 Added file to fix the build. Sorry.
2813 * src/dbus_api/Makefile.am:
2814 * src/dbus_api/modest-dbus-api.h:
2815 * src/dbus_api/modest-dbus-callbacks.h:
2816 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2817 (modest_dbus_req_handler):
2818 Put constants in a separate header so it can be reused by the
2819 client library, without duplication
2821 * libmodest-dbus-client/Makefile.am:
2822 * libmodest-dbus-client/libmodest-dbus-client.c:
2823 (libmodest_dbus_client_call_helloworld),
2824 (libmodfest_dbus_client_send_mail),
2825 (libmodfest_dbus_client_mailto),
2826 (libmodfest_dbus_client_open_message):
2827 * libmodest-dbus-client/libmodest-dbus-client.h:
2828 (Partly) Implement a send_mail D-Bus method.
2830 * tests/dbus_api/Makefile.am:
2831 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2832 the send_email D-Bus method.
2834 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2838 * libmodest-dbus-client/Makefile.am:
2839 * libmodest-dbus-client/libmodest-dbus-client.c:
2840 * libmodest-dbus-client/libmodest-dbus-client.h:
2841 * tests/dbus_api/Makefile.am:
2842 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2843 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2845 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2847 * src/maemo/easysetup/modest-easysetup-wizard.c:
2848 (create_page_account_details):
2849 * src/maemo/modest-account-settings-dialog.c:
2850 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2851 widgets, because this might not be the default in future versions of the Maemo GTK+.
2852 However, I can not not get capitalization to work even in a simple test case.
2854 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2856 * src/maemo/easysetup/modest-easysetup-wizard.c:
2857 (create_page_custom_incoming), (create_page_custom_outgoing):
2858 * src/maemo/modest-account-settings-dialog.c:
2859 (create_page_account_details), (create_page_incoming),
2860 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2861 instead of using gtk_check_button_with_label(), so they are aligned like the other
2862 widgets, as per the UI spec.
2864 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2866 * src/maemo/easysetup/modest-easysetup-wizard.c:
2867 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2868 * src/widgets/modest-validating-entry.c:
2869 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2870 Modest prefix instead of an EasySetup prefix.
2872 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2874 * src/widgets/modest-validating-entry.h:
2875 * src/widgets/modest-validating-entry.c: (on_insert_text),
2876 Added easysetup_validating_entry_set_max_func(), used to set a callback
2877 to call when the max number of characters is reached. GtkEntry has a max-length
2878 already but is silent about it.
2880 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2881 (create_page_account_details), (create_page_user_details),
2883 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2884 (create_page_account_details), (create_page_user_details),
2885 (create_page_outgoing):
2886 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2887 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2888 the UI spec, when the user tries to enter more than the max number of characters.
2890 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2892 * src/maemo/easysetup/modest-easysetup-wizard.c:
2893 (create_page_user_details), (create_page_custom_incoming),
2894 (create_page_custom_outgoing):
2895 * src/maemo/modest-account-settings-dialog.c:
2896 (create_page_user_details), (create_page_incoming),
2897 (create_page_outgoing):
2898 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2899 (modest_connection_specific_smtp_edit_window_init):
2900 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2901 not appropriate. Bad Maemo-specific defaults!.
2903 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2905 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2906 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2907 (modest_signature_editor_dialog_set_settings):
2908 Disable the label and textview when the checkbox is disabled, and use the
2909 specified (UI spec) default signature text.
2911 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2913 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2914 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2916 * src/modest-defs.h:
2917 * src/modest-account-mgr-helpers.h:
2918 * src/modest-account-mgr-helpers.c:
2919 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2921 * src/maemo/Makefile.am:
2922 * src/maemo/modest-signature-editor-dialog.c:
2923 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2926 * src/maemo/modest-account-settings-dialog.h:
2927 * src/maemo/modest-account-settings-dialog.c:
2928 (modest_account_settings_dialog_finalize), (on_button_signature),
2929 (save_configuration): Use the new dialog when the Edit button is pressed, and
2930 save the changes if necessary, as per the UI spec.
2932 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2934 * src/maemo/Makefile.am:
2935 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2936 based on maemo-develoers email from Dirk.
2938 * src/maemo/easysetup/modest-easysetup-wizard.c:
2939 (create_page_welcome), (create_page_account_details),
2940 (create_page_user_details), (create_page_complete_easysetup),
2941 (create_page_custom_incoming), (create_page_custom_outgoing),
2942 (create_page_complete_custom),
2943 (modest_easysetup_wizard_dialog_init):
2944 * src/maemo/modest-account-settings-dialog.c:
2945 (create_page_account_details), (create_page_user_details),
2946 (create_page_incoming), (create_page_outgoing),
2947 (modest_account_settings_dialog_init):
2948 * src/maemo/modest-connection-specific-smtp-window.c:
2949 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2951 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2953 * src/maemo/easysetup/modest-easysetup-wizard.c:
2954 (create_page_account_details), (create_page_custom_outgoing),
2955 (create_page_complete_custom):
2956 * src/maemo/modest-account-settings-dialog.c:
2957 (create_page_user_details), (create_page_incoming),
2958 (create_page_outgoing):
2959 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2960 (modest_connection_specific_smtp_edit_window_init):
2961 Use the correct (UI spec) port min/max, and use horizontal separators,
2964 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2966 * src/maemo/easysetup/modest-easysetup-wizard.c:
2967 (set_default_custom_servernames):
2968 * src/maemo/modest-account-settings-dialog.c:
2969 (create_page_incoming), (on_combo_outgoing_security_changed),
2970 (on_combo_incoming_security_changed), (create_page_outgoing),
2971 (modest_account_settings_dialog_set_account_name),
2972 (save_configuration):
2973 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2974 (on_combo_security_changed),
2975 (modest_connection_specific_smtp_edit_window_init),
2976 (modest_connection_specific_smtp_edit_window_set_connection),
2977 (modest_connection_specific_smtp_edit_window_get_settings):
2978 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2981 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2984 * src/maemo/easysetup/modest-easysetup-wizard.c:
2985 (create_page_custom_outgoing), (create_page_complete_custom):
2986 * src/maemo/modest-account-settings-dialog.c:
2987 (create_page_user_details), (create_page_outgoing):
2988 * src/maemo/modest-account-view-window.c: (button_box_new):
2989 Use changed logical IDs as per the most recent UI spec:
2990 mcen_bd_emailsetup_edit -> mcen_bd_edit
2991 mcen_bd_emailsetup_delete -> mcen_bd_delete
2992 mcen_bd_emailsetup_close -> mcen_bd_close
2994 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2998 * src/dbus_api/Makefile.am:
2999 * src/dbus_api/modest-dbus-callbacks.c:
3000 * src/dbus_api/modest-dbus-callbacks.h:
3001 * src/maemo/modest-platform.c: (modest_platform_init):
3002 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3004 * tests/Makefile.am:
3005 * tests/dbus_api/Makefile.am:
3006 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3008 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3010 * src/maemo/modest-account-settings-dialog.c:
3011 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3012 Removed unnecessary includes.
3014 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3016 * src/maemo/easysetup/modest-easysetup-wizard.c:
3017 * src/maemo/modest-account-settings-dialog.c:
3018 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3019 * src/widgets/Makefile.am:
3020 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3021 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3022 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3023 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3024 * src/widgets/modest-secureauth-combo-box.c:
3025 * src/widgets/modest-secureauth-combo-box.h:
3026 * src/widgets/modest-serversecurity-combo-box.c:
3027 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3028 made the GObject names more consistent with the rest of the Modest code.
3030 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3032 * src/maemo/easysetup/Makefile.am:
3033 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3034 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3035 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3036 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3037 * src/maemo/easysetup/modest-easysetup-wizard.c:
3038 * src/maemo/easysetup/modest-validating-entry.c:
3039 * src/maemo/easysetup/modest-validating-entry.h:
3040 * src/maemo/modest-account-settings-dialog.c:
3041 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3042 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3043 widgets/ because they are used outside of easysetup too. After checking in,
3044 svn will allow me to rename them too.
3046 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3048 * src/gnome/modest-msg-edit-window.c:
3049 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3050 linker error, to fix the build on the GNOME platform.
3051 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3052 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3053 ifdefed out to avoid a warning.
3055 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3057 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3058 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3059 some alternative for GTK+ 2.6.
3061 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3063 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3065 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3066 specified for EmailAccountsDialog in UI spec.
3068 * src/maemo/easysetup/modest-easysetup-wizard.c:
3069 * src/maemo/easysetup/modest-easysetup-wizard.h:
3070 * src/maemo/modest-account-settings-dialog.c:
3071 * src/maemo/modest-account-settings-dialog.h:
3072 Reuse a member window widget for the connection-specific SMTP server accounts,
3073 so we can tell it to create/save the accounts only if we actually save changes.
3075 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3076 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3077 (modest_connection_specific_smtp_edit_window_get_settings):
3078 Return a struct instance for temporarily remembering the entered data.
3080 * src/maemo/modest-connection-specific-smtp-window.h:
3081 * src/maemo/modest-connection-specific-smtp-window.c:
3082 (modest_connection_specific_smtp_window_finalize),
3083 (modest_connection_specific_smtp_window_fill_with_connections),
3085 (modest_connection_specific_smtp_window_save_server_accounts),
3086 (update_model_server_names): Do not actually save data until asked,
3087 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3089 (on_selection_changed),
3090 (modest_connection_specific_smtp_window_init): Disable the edit
3091 button when nothing is selected.
3093 * src/modest-account-mgr-helpers.c:
3094 * src/modest-account-mgr-helpers.h:
3095 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3098 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3100 * src/modest-account-mgr-helpers.h:
3101 * src/modest-account-mgr-helpers.c:
3102 (modest_account_mgr_get_unused_account_name),
3103 (modest_account_mgr_get_unused_account_display_name): Added these
3104 utility functions, to avoid code duplication.
3106 * src/maemo/easysetup/modest-easysetup-wizard.c:
3107 (create_page_account_details), (create_account):
3108 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3109 (on_combo_security_changed),
3110 (modest_connection_specific_smtp_edit_window_init),
3111 (modest_connection_specific_smtp_edit_window_save_settings):
3112 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3113 * src/maemo/modest-connection-specific-smtp-window.c:
3114 (modest_connection_specific_smtp_window_finalize),
3115 (modest_connection_specific_smtp_window_fill_with_connections),
3116 (on_button_edit), (modest_connection_specific_smtp_window_init):
3117 * src/maemo/modest-connection-specific-smtp-window.h:
3118 Implementing saving of connection-specific server accounts.
3120 But I need to refactor this so we can save the data for each
3121 possible connection-specific account and only actually create the server accounts
3122 when the easysetup finished, or the OK button is pressed on the account settings
3125 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3127 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3128 (on_combo_security_changed):
3129 (modest_connection_specific_smtp_edit_window_init):
3130 Auto-fill the port number as in the account settings.
3132 (modest_connection_specific_smtp_edit_window_set_connection):
3133 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3134 * src/maemo/modest-connection-specific-smtp-window.c:
3135 (fill_with_connections), (on_button_edit),
3136 (modest_connection_specific_smtp_window_init):
3137 Turn the edit window into a dialog to simplify the code, and
3138 set a WM hint as in a GtkDialog, because only a popup can be on top of
3139 another window in Maemo, and popups usually have no WM decoration.
3141 * src/modest-defs.h:
3142 * src/modest-account-mgr-helpers.c:
3143 (modest_account_mgr_set_connection_specific_smtp),
3144 (modest_account_mgr_remove_connection_specific_smtp),
3145 (modest_account_mgr_get_connection_specific_smtp):
3146 * src/modest-account-mgr-helpers.h: Some functions to write the
3147 connection-specific SMTP server information. Not yet used.
3150 * src/widgets/modest-folder-view.c: (text_cell_data):
3151 Fix a warning about an uninitialized variable.
3152 (on_configuration_key_changed): Put an #ifdef around the use
3153 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3155 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3157 * src/maemo/modest-account-settings-dialog.h:
3158 * src/maemo/modest-account-settings-dialog.c:
3159 Added connect_for_modified() utility function to mark the new modified boolean.
3161 (create_page_account_details), (create_page_user_details),
3162 (create_page_incoming), (create_page_outgoing), (on_response),
3163 (modest_account_settings_dialog_init),
3164 (modest_account_settings_dialog_set_account_name):
3165 Only warn about unsaved changes when there are actually unsaved changes.
3167 * src/modest-account-mgr-helpers.c:
3168 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3169 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3170 to get the data from there in future.
3172 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3174 * src/modest-defs.h:
3176 * src/modest-account-mgr-helpers.h:
3177 * src/modest-account-mgr-helpers.c:
3178 Store the security account setting in a single conf key instead of using
3179 the options list, so that the list is left for just the to-be-removed camel hack,
3180 and because gconf_client_set_list() is failing for some reason.
3182 * src/modest-account-mgr.c:
3183 (modest_account_mgr_add_server_account):
3184 * src/maemo/modest-account-settings-dialog.c:
3185 (modest_account_settings_dialog_set_account_name),
3186 (save_configuration): Use the renamed functions.
3189 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3191 * src/widgets/Makefile.am:
3192 * src/widgets/modest-limit-retrieve-combo-box.c:
3193 * src/widgets/modest-limit-retrieve-combo-box.h:
3194 * src/widgets/modest-retrieve-combo-box.c:
3195 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3196 the account settings dialog.
3198 * src/modest-defs.h:
3199 * src/modest-account-mgr-helpers.h:
3200 * src/modest-account-mgr-helpers.c:
3201 (modest_server_account_get_option_secure_auth),
3202 (modest_server_account_set_option_secure_auth):
3203 * src/modest-account-mgr.c:
3204 (modest_account_mgr_add_server_account):
3205 Use the existing AUTH_MECH conf key for the secure-auth setting,
3206 instead of putting it in the list options, because this was actually used already.
3208 * src/maemo/modest-account-settings-dialog.c:
3209 (create_page_account_details),
3210 (modest_account_settings_dialog_set_account_name),
3211 (save_configuration):
3212 * src/maemo/modest-account-settings-dialog.h:
3213 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3214 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3216 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3218 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3219 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3220 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3222 * src/modest-defs.h:
3223 * src/maemo/modest-account-settings-dialog.c:
3224 (create_page_incoming), (on_combo_outgoing_security_changed),
3225 (on_combo_incoming_security_changed), (create_page_outgoing),
3226 (modest_account_settings_dialog_set_account_name),
3227 (save_configuration): Load/Save the port number, and change it when the
3228 security combo changes, to suitable defaults.
3230 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3232 * src/modest-account-mgr.c:
3233 (modest_account_mgr_add_server_account): Set the security and secure-auth
3234 options, and add a comment saying that the other camel-specific options should be
3237 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3239 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3241 * src/modest-tny-account-store.c: (account_list_free),
3242 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3243 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3246 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3248 * src/modest-protocol-info.c:
3249 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3250 is required by our UI spec. Maybe something in our implementation will use this eventually.
3251 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3252 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3253 instead of the previous 0 placeholder.
3255 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3256 secure-auth settings.
3257 * src/modest-account-mgr-helpers.h:
3258 * src/modest-account-mgr-helpers.c:
3259 (modest_server_account_data_get_option_secure_auth),
3260 (modest_server_account_set_option_secure_auth),
3261 (modest_server_account_data_get_option_security),
3262 (modest_server_account_set_option_security): Added this API for getting and setting the security
3263 and secure-auth settings.
3265 * src/maemo/modest-account-settings-dialog.h:
3266 * src/maemo/modest-account-settings-dialog.c:
3267 (modest_account_settings_dialog_finalize), (check_data),
3268 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3269 about changing titles.
3270 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3271 (save_configuration): Save the security and secure-auth settings.
3273 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3274 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3276 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3278 * src/modest-defs.h:
3279 * src/modest-account-mgr.c:
3280 (modest_account_mgr_add_server_account):
3281 Added and used defines for the options key and value pair strings,
3282 that are used so far, though they do not seem to correspond to anything in our
3283 UI specs or ModestProtocol enum.
3285 * src/modest-account-mgr-helpers.h:
3286 * src/modest-account-mgr-helpers.c:
3287 (compare_option_strings_for_name),
3288 (modest_server_account_data_get_option_value),
3289 (modest_server_account_data_get_option_bool),
3290 (modest_account_mgr_get_server_account_option):
3291 Added helper functions for parsing the options GSList.
3293 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3295 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3296 display name is based on the supplied account name.
3297 * src/modest-account-mgr.c:
3298 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3299 with an inefficient, but good-enough, implementation.
3301 * src/maemo/easysetup/modest-easysetup-wizard.c:
3302 (create_page_account_details), (on_before_next), (create_account):
3303 Check for existing display names rather than (non-user-visible) account names, and just
3304 create and set a unique account name at the end.
3306 * src/maemo/modest-account-settings-dialog.c:
3307 (modest_account_settings_dialog_init),
3308 (modest_account_settings_dialog_set_account_name),
3309 (create_page_incoming): Show the display name, instead of the account name.
3310 (on_response): Do some (not all) extra checks, as in the UI spec.
3311 (save_configuration): Save the display name if it was changed.
3313 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3315 * po/en_GB.po: Added needed logical ID and translation.
3316 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3317 (init_view): Made the is-default column clicking work.
3319 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3322 * src/maemo/easysetup/Makefile.am:
3323 * src/maemo/easysetup/modest-easysetup-wizard.c:
3324 (modest_easysetup_wizard_dialog_init):
3325 * src/maemo/easysetup/provider-data-test.keyfile:
3326 * src/maemo/easysetup/provider-data.keyfile:
3327 Moved the provider data file to the new modest-providers-data package and used it from there.
3329 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3331 * src/modest-local-folder-info.c:
3332 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3333 N_() was already used on the static strings, but this just marks it for translation without
3334 using the translation.
3336 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3338 * src/maemo/modest-account-settings-dialog.c:
3339 (create_page_incoming),
3340 (modest_account_settings_dialog_set_account_name):
3341 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3342 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3343 I will do this if nobody else gets there first.
3345 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3347 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3348 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3349 save the security stuff.
3351 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3353 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3354 Set the email address and user fullname, which I now see must be
3357 * src/maemo/modest-account-settings-dialog.h:
3358 * src/maemo/modest-account-settings-dialog.c:
3360 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3361 leave-on-server and authentication.
3362 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3365 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3368 * src/maemo/modest-account-settings-dialog.c:
3369 * src/maemo/modest-account-settings-dialog.h:
3370 Most (but not all) of the widgets are now present as specified by the UI spec.
3371 No changes are yet saved, and some details are not properly shown yet.
3373 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3375 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3377 * src/maemo/Makefile.am:
3378 * src/maemo/modest-account-settings-dialog.c:
3379 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3380 an existing account. Doesn't do much yet.
3382 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3383 Open the accounts settings dialog when Edit is clicked.
3385 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3387 * src/maemo/easysetup/Makefile.am:
3388 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3390 * src/maemo/easysetup/modest-easysetup-wizard.c:
3391 (modest_easysetup_wizard_dialog_init):
3392 Try to get the source directory from the build system,
3393 instead of hard-coding "./" into the source code, when opening our local
3394 copies of the configuration files.
3395 But this still fails when opening the wizard from the Accounts window,
3396 maybe because the working directory seems to change at runtime.
3397 So the wizard will fail the second time unless you copy the files into their
3398 proper locations - see the stdout warnings for the paths.
3400 (create_page_account_details),(on_before_next):
3401 Check for existing non-server accounts instead of server accounts,
3402 so the default account name is useful again, and to prevent trying to
3405 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3406 Show the wizard when New is clicked.
3408 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3409 (init_view): Show the column headers, and show the columns that are
3410 specified in the UI specs. However, something in Maemo's GTK+ prevents
3411 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3412 change the default account. This is despite unsetting the special properties.
3414 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3416 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3417 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3418 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3419 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3420 to make that clearer.
3421 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3423 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3425 * src/maemo/modest-account-view-window.c:
3426 (modest_account_view_window_init),
3427 (modest_account_view_window_new):
3428 Use the same buttons as specified in the
3429 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3430 the existing widgets, which never had a chance of working.
3431 Put the ModestAccountView treeview in a scrolled window.
3432 Do not repeat the initialization in both _init() and _new().
3434 * src/widgets/modest-account-view.c: (update_account_view):
3435 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3436 this widget and window shows no accounts.
3438 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3440 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3442 * src/maemo/easysetup/modest-easysetup-wizard.c:
3443 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3444 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3445 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3448 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3449 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3450 accounts exist yet, as in the UI spec.
3452 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3454 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3456 * src/maemo/Makefile.am:
3457 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3458 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3459 New window for editing connection-specific smtp details.
3460 Not fully implemented.
3462 * src/maemo/modest-connection-specific-smtp-window.c:
3463 (modest_connection_specific_smtp_window_finalize) :
3464 unref the tree model.
3465 (on_button_edit): Show the edit window.
3467 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3469 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3472 * src/maemo/Makefile.am:
3473 * src/maemo/modest-connection-specific-smtp-window.c:
3474 * src/maemo/modest-connection-specific-smtp-window.h:
3475 New window for showing the list of connections, for connection-specific
3476 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3477 * src/maemo/easysetup/modest-easysetup-wizard.c:
3478 (create_page_custom_outgoing): Show the new window when the button is clicked.
3480 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3482 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3483 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3484 * src/maemo/modest-msg-edit-window.c:
3485 (modest_msg_edit_window_insert_image):
3486 * src/modest-conf.c: (modest_conf_key_escape):
3487 * src/modest-mail-operation.c:
3488 (modest_mail_operation_send_new_mail):
3489 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3490 (modest_ui_actions_on_new_account):
3491 * src/widgets/modest-attachment-view.c: (update_filename_request):
3492 * src/widgets/modest-mail-header-view.c:
3493 Corrected warnings that were breaking the build, by commenting out unused variables,
3494 and a function, and by including a header.
3496 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3498 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3499 so we can #ifdef around platform-specific code when necessary.
3500 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3501 to allow this to build for the GNOME platform too.
3503 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3505 * src/maemo/easysetup/modest-easysetup-wizard.c:
3506 Added util_increment_name() and used it in create_page_account_details()
3507 to make sure that the default account name is always a new name.
3509 (modest_easysetup_wizard_dialog_init),
3510 (set_default_custom_servernames): Some minor memory management fixes.
3512 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3516 * src/modest-runtime.c: (init_i18n): Restored the translation
3517 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3518 are defined in config.h, and the translations are installed.
3520 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3521 is defined for translation.
3523 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3525 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3527 * src/maemo/easysetup/modest-easysetup-wizard.c:
3528 (modest_easysetup_wizard_dialog_init):
3529 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3530 Use realistic paths (though they should use $prefix generically) to the
3531 mcc_mapping and provider-data.keyfile files which might work when they
3532 are installed by the future version of the operator-wizard package,
3533 and then fallback to paths in our source code, with an explanatory
3536 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3540 * src/maemo/Makefile.am:
3541 * src/maemo/easysetup/: Added files from the previously-exernal
3542 osso-modest-easysetup.
3543 * src/maemo/modest-main-window-ui.h:
3544 * src/modest-ui-actions.c:
3545 * src/modest-ui-actions.h:
3546 Added modest_ui_actions_on_new_account() as a signal handler for the
3547 New Account menu item. It shows the easysetup wizard.
3548 * po/en_GB.po: Added additional needed logical IDs and translations.