1 2007-07-16 Murray Cumming <murrayc@murrayc.com>
3 Reverted this previous commit from Johannes,
4 because the scrollbars are always visible and because
5 I think we only need it on onepage of the account
6 settings, not the account wizard.
7 (I wrote the wrong instructions in the bug.)
9 * src/maemo/easysetup/modest-easysetup-wizard.c:
10 Added scrollbars to account wizard dialog.
11 Fixed projects.maemo.org NB #62744
13 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
15 * src/maemo/easysetup/modest-easysetup-wizard.c:
16 (create_page_user_details):
17 Use auto-cap for name (projects.maemo.org NB#63716)
18 * src/widgets/modest-account-view.c: (on_account_busy_changed):
20 2007-07-22 Armin Burgmeier <armin@openismus.com>
22 * src/maemo/modest-ui-actions.c: Use current account instead of
23 default account for creating viewer windows, so that the viewer
24 window knows to which account the viewed message belongs.
26 * src/maemo/modest-msg-view-window.c: Destroy the window when the
27 corresponding account is deleted. This fixes projects.maemo.org bug
30 2007-07-18 Armin Burgmeier <armin@openismus.com>
32 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
33 the dialog close after entering an invalid port number and clicking
34 OK. This fixes projects.maemo.org bug NB#63602.
36 2007-07-18 Armin Burgmeier <armin@openismus.com>
38 * src/modest-tny-account-store.c:
39 (get_server_accounts): Set parent modest account name for each
40 connection-specific transport account so that special folders of such
41 an account can be looked up. This fixes a crash when changing account
42 settings. This might also be related to projects.maemo.org bug
45 2007-07-16 Armin Burgmeier <armin@openismus.com>
47 * src/modest-ui-actions.c: Added a button to create a folder to the
48 move-to dialog. This fixes projects.maemo.org bug NB#.
50 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
52 * src/maemo/easysetup/modest-easysetup-wizard.c:
53 Added scrollbars to account wizard dialog.
54 Fixed projects.maemo.org NB #62744
56 2007-07-16 Murray Cumming <murrayc@murrayc.com>
58 * src/widgets/modest-msg-view.h:
59 * src/widgets/modest-msg-view.c:
60 Added modest_msg_view_get_message_is_empty() but this needs
62 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
63 Check if there is any text in the message yet.
64 But this needs to be implemented properly.
65 (modest_msg_edit_window_toggle_find_toolbar):
66 * src/maemo/modest-msg-view-window.c:
67 (modest_msg_view_window_toggle_find_toolbar):
68 Show a banner warning if there is no text to search, when
69 trying to start a search. This partially fixes
70 projects.maemo.org bug NB#62350.
72 2007-07-13 Murray Cumming <murrayc@murrayc.com>
74 * src/modest-mail-operation.c: (update_account_thread):
75 Initialized num_new_headers to fix the build.
77 2007-07-13 Murray Cumming <murrayc@murrayc.com>
79 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
80 Ignore modest accounts whose server accounts don't exist in gconf.
81 This prevents us trying to create TnyAccount instances for those
82 server accounts when the server account has been removed from gconf,
83 but the parent modest account has not yet been removed from modest.
84 I don't know why this is only noticeable now. It was probably just
85 a harmeless g_warning() anyway.
87 2007-07-13 Murray Cumming <murrayc@murrayc.com>
89 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
90 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
92 2007-07-12 Armin Burgmeier <armin@openismus.com>
94 * src/maemo/modest-main-window.c: Make default account appear bold
95 in view, tools/send & receive and toolbar/send & receive SCM menus.
96 This fixes projects.maemo.org bug NB#59010.
98 2007-07-12 Murray Cumming <murrayc@murrayc.com>
100 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
101 Add a short-cut, by checking if the folder store is an account.
102 This ensures that the Sort menu item and toolbar is dimmed for
103 the local-folders account root item, fixing
104 projects.maemo.org bug NB#62545.
106 2007-07-12 Murray Cumming <murrayc@murrayc.com>
108 * src/modest-tny-account-store.c: (get_password):
109 Show the password dialog (via the signal) only in the mainloop, via
110 an idle handler that we wait for. This could theoretically prevent
111 hangs, though I worry that it could introduce some too.
113 2007-07-12 Murray Cumming <murrayc@murrayc.com>
115 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
116 * src/maemo/modest-platform.c:
117 (modest_platform_connect_and_wait):
118 Take a TnyAccount* parameter and try to set it to online
119 (a TnyCamel-only API), because tinymail sets accounts to offline
120 when the user cancels a password dialog, and doesn't ask again until
121 it has been set to online.
122 However, this is commented out because it causes a hang now.
124 (modest_platform_connect_and_wait_if_network_account):
125 * src/modest-mail-operation.c:
126 (modest_mail_operation_update_account):
127 * src/modest-platform.h:
128 * src/modest-ui-actions.c: (_modest_ui_actions_open),
129 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
131 2007-07-12 Armin Burgmeier <armin@openismus.com>
133 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
135 * src/modest-mail-operation.c:
136 * src/modest-ui-actions.c: Check for already existing folder before
137 querying the server, show error message from camel if the request
138 still fails. This fixes projects.maemo.org bug NB#58701.
140 2007-07-12 Murray Cumming <murrayc@murrayc.com>
142 * src/modest-tny-account-store.h:
143 * src/modest-tny-account-store.c:
144 Added modest_tny_account_store_forget_password_in_memory(),
145 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
146 when creating a new account, so that new passwords will be used, instead of
147 us thinking that it's a second request as a result of a failed password again.
149 2007-07-12 Murray Cumming <murrayc@murrayc.com>
151 * src/dbus_api/modest-dbus-callbacks.c:
152 (on_idle_open_message): If the message is in drafts then open it
153 in an edit window instead of a view window. This fixes
154 projects.maemo.org bug NB#63005.
156 2007-07-12 Murray Cumming <murrayc@murrayc.com>
158 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
159 Avoided a harmless g_warning().
161 2007-07-12 Murray Cumming <murrayc@murrayc.com>
163 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
164 Pass the modest account name, not the TnyAccount display name to
165 modest_msg_view_window_new() so that the reply feature works,
166 fixing projects.maemo.org bug NB#62892.
168 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
169 (modest_msg_view_window_new_with_header_model):
170 * src/maemo/modest-msg-view-window.c:
171 (modest_msg_view_window_new_with_header_model),
172 (modest_msg_view_window_new):
173 * src/modest-ui-actions.c: (reply_forward):
174 * src/widgets/modest-msg-view-window.h:
175 * src/widgets/modest-window.c: (modest_window_set_active_account):
176 Rename an account parameter to modest_account_name to make this clearer.
178 2007-07-11 Murray Cumming <murrayc@murrayc.com>
180 * src/modest-ui-actions.h:
181 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
182 modest_do_message_delete().
183 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
184 Call modest_do_message_delete(), hoping that this would cause messages
185 to be really deleted from search instead of just marked with strike through.
186 Does not seem to help.
188 2007-07-11 Armin Burgmeier <armin@openismus.com>
190 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
191 priv->reselect to FALSE prior to calling
192 modest_folder_view_select_first_inbox_or_local() to prevent endless
193 recursion and thus a crash on startup.
195 2007-07-11 Armin Burgmeier <armin@openismus.com>
197 * src/maemo/modest-account-settings-dialog.h: Include
198 <gtk/gtknotebook.h> to fix the build (at least for me).
200 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
201 Use "New FolderN" as default suggested name if "New folder" already
202 exists, with N being the first free number, though never exceed "New
203 folder99" in which case we just fall back to "New Folder" even though
204 it already exists. This fixes projects.maemo.org bug NB#58663.
206 2007-07-11 Murray Cumming <murrayc@murrayc.com>
208 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
209 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
210 projects.maemo.org bug NB#62778.
212 2007-07-11 Murray Cumming <murrayc@murrayc.com>
214 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
215 Ignore the wrong (for now) secure-smtp setting in the presets -
216 just default to requiring secure authentication for SMTP, because
219 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
221 * src/widgets/modest-folder-view.c: (filter_row)
222 Do not show drafts folder (see UI specs)
224 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
226 * src/modest-ui-actions.c:
227 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
228 place and also not necessary.
230 * src/widgets/modest-folder-view.c: (filter_row)
231 Guess folder type and hide Sent & Outbox if necessary.
232 Fixed project.maemo.org NB#57328
234 2007-07-11 Murray Cumming <murrayc@murrayc.com>
236 * src/modest-ui-actions.h:
237 * src/modest-ui-actions.c:
238 (modest_ui_actions_on_delete_message):
239 Move some code into a new
240 modest_ui_actions_refresh_message_window_after_delete()
241 function so we can use it from elsewhere.
243 * src/dbus_api/modest-dbus-callbacks.c:
244 (on_idle_delete_message), (on_delete_message): Used an idle
245 handler, as we do for the other D-Bus method handlers.
246 Call modest_ui_actions_refresh_message_window_after_delete()
247 if the deleted message was open in a window. This fixed
248 projects.maemo.org bug NB#62862.
250 2007-07-11 Murray Cumming <murrayc@murrayc.com>
252 * src/modest-main.c: (main): Only show the UI at the start if
253 the showui command line option was given. For instance,
254 run-standalone src/modest showui
255 Otherwise, we wait for the top_application D-Bus method to
256 be sent by hildon-desktop when the application is selected
258 This allows us to run without a UI when osso-global-search
259 uses our D-Bus methods.
261 2007-07-11 Murray Cumming <murrayc@murrayc.com>
263 * src/dbus_api/modest-dbus-api.h: Added a define for a
264 top-application D-Bus method.
265 * src/dbus_api/modest-dbus-callbacks.c:
266 (on_top_application),
267 (modest_dbus_req_handler): Handle the top-application D-Bus
268 method, which might be an undocumented D-Bus signal sent by
269 hildon-desktop when it starts the application from the menu.
270 But I am not sure and I need to test it on the device, because
271 my scratchbox does not have the application in the menu now.
272 This method shows the main window, so that it can be invisible
273 when started, for instance, just for email searching from
276 * src/maemo/modest-main-window.c: (restore_settings),
277 (modest_main_window_new): Do not show the window immediately
278 upon creation. We show it later.
279 * src/modest-widget-memory.c: (save_settings_paned):
280 Try (unsuccessfully) to avoid saving the paned position when
281 it is not even visible.
282 (restore_settings_paned): Do not allow a silly paned position.
283 This seems necessary when not showing the window at first.
285 * tests/dbus_api/Makefile.am:
286 * tests/dbus_api/test_top_application.c: (main): Test for the
289 2007-07-10 Murray Cumming <murrayc@murrayc.com>
291 * src/modest-ui-dimming-rules.c:
292 (modest_ui_dimming_rules_on_new_msg),
293 (modest_ui_dimming_rules_on_reply_msg),
294 (modest_ui_dimming_rules_on_delete_msg),
295 (modest_ui_dimming_rules_on_details),
296 (modest_ui_dimming_rules_on_view_window_move_to),
297 (modest_ui_dimming_rules_on_view_previous),
298 (modest_ui_dimming_rules_on_view_next),
299 (_invalid_folder_for_purge): Added checks before
300 casting the window. This looks like an actual
301 logic error in _invalid_folder_for_purge(), because it
302 tries to use a ModestMainWindow as a message window.
304 2007-07-10 Murray Cumming <murrayc@murrayc.com>
306 * src/maemo/modest-account-settings-dialog.c:
307 (show_error): Use the same implementation as in
308 modest-easysetup-wizard.c:
309 (on_entry_invalid_character): The logical ID contains a %s.
310 Guessed what it should be.
311 (on_entry_max), (check_data), (on_response): Adapt to
312 changed show_error().
313 (create_page_account_details): Really call
314 modest_validating_entry_set_func() on the correct widgets.
315 * src/maemo/easysetup/modest-easysetup-wizard.c:
316 (on_entry_invalid_character): Fix the logical ID here too.
317 (create_page_account_details),
318 (create_page_user_details):
320 modest_validating_entry_set_func() on the correct widgets.
322 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
323 Do not try to use the account if it is NULL.
325 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
327 * src/modest-ui-actions.c: (create_move_to_dialog),
328 (modest_ui_actions_on_main_window_move_to),
329 (modest_ui_actions_on_msg_view_window_move_to):
330 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
331 (filter_row), (modest_folder_view_show_non_move_folders):
332 * src/widgets/modest-folder-view.h:
334 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
335 the Sent folder yet as it does not report the correct folder type.
337 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
339 * src/maemo/modest-msg-edit-window.c: (init_window):
342 2007-07-10 Murray Cumming <murrayc@murrayc.com>
344 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
345 Take a parent widget instead of a parent window, and
346 implement this with hildon_banner_show_information() instead.
347 Non-Maemo builds can just ifdef that there.
348 This fixed projects.maemo.org bug NB#62766.
350 (on_entry_invalid_character): Use show_error() again instead
351 of using hildon directly, and use the _CS() macro to use the correct
353 (create_account), (check_for_supported_auth_methods), (on_entry_max):
354 Pass a widget instead od a window to show_error().
356 2007-07-10 Murray Cumming <murrayc@murrayc.com>
358 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
359 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
360 This allows us to show the server name in the error message, fixing
361 projects.maemo.org bug NB#62904.
362 Also, use the appropriate logical ID message for the account protocol.
364 2007-07-10 Murray Cumming <murrayc@murrayc.com>
366 * src/modest-tny-account-store.c: (on_idle_wrong_password):
367 A compilation fix, though the build wasn't broken for me.
369 2007-07-09 Murray Cumming <murrayc@murrayc.com>
371 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
372 Do not try to unref a NULL folder store, to avoid a runtime warning.
373 This seems to happen sometimes when changing accounts settings.
375 2007-07-09 Murray Cumming <murrayc@murrayc.com>
377 * src/modest-tny-account-store.c:
378 (modest_tny_account_store_instance_init),
379 (modest_tny_account_store_finalize),
380 (on_account_settings_hide), (on_idle_wrong_password):
381 Use a GHashTable to ensure that we only show one account settings
382 dialog per modest account. This avoids us having a dialog open for
383 both the store and transport accounts, or due to repeated get_password()
384 calls that shouldn't happen anyway.
386 2007-07-09 Murray Cumming <murrayc@murrayc.com>
388 * src/maemo/modest-maemo-utils.c: (on_hide),
389 (modest_maemo_show_dialog_and_forget): Handle the response, because
390 the window is not even hidden by default.
392 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
393 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
394 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
395 which seems to prevent some modality problems.
397 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
398 Ignore user cancellation errors.
400 * src/modest-account-mgr-helpers.h:
401 * src/modest-account-mgr-helpers.c:
402 Added modest_server_account_get_password() and
403 modest_server_account_get_has_password() to avoid direct use of
406 * src/maemo/modest-account-settings-dialog.h:
407 * src/maemo/modest-account-settings-dialog.c:
408 (modest_account_settings_dialog_init): Store the notebook so we can
410 Added modest_account_settings_dialog_switch_to_user_info().
412 * src/modest-tny-account-store.c:
413 (get_password): When the password in the account settings is wrong (we think),
414 show the relevant page of the account settings dialog, in the mainloop.
415 However, we currently get many of these at once because cancel does not
417 (forget_password): Do not forget the password
418 from the account settings, because this causes side-effects when
419 tinymail seems to call it at strange time, maybe because of how we
420 are cancelling get_password().
421 (modest_tny_account_store_alert): Ignore user cancellations.
423 2007-07-09 Murray Cumming <murrayc@murrayc.com>
425 * src/maemo/modest-maemo-utils.h:
426 * src/maemo/modest-maemo-utils.c:
427 Added modest_maemo_show_information_note_and_forget() for use instead of
428 gtk_dialog_run() when the response is not needed, to avoid an extra
429 mainloop which could cause a hang.
431 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
432 Use the logical IDs for the error message, though they are not
433 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
434 because gtk_dialog_run() caused a hang here (the window did not close).
435 This fixes projects.maemo.org bug NB#62646.
437 2007-07-09 Murray Cumming <murrayc@murrayc.com>
439 * src/modest-account-mgr-helpers.h:
440 * src/modest-account-mgr-helpers.c:
441 Added modest_account_mgr_get_store_protocol().
443 * src/maemo/modest-account-view-window.c:
444 (on_delete_button_clicked): Show different warning text depending on
445 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
446 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
449 2007-07-09 Murray Cumming <murrayc@murrayc.com>
451 * src/maemo/modest-msg-edit-window.c:
452 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
453 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
455 2007-07-07 Armin Burgmeier <armin@openismus.com>
457 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
458 ckdg_ib_maximum_characters_reached from correct package.
460 * src/modest-ui-actions.c: Show an error message when a folder could
461 not be created. Tinymail does not give us specific error codes about
462 what has gone wrong, so we assume that a folder with that name
463 already exists, though there might be other reasons.
465 2007-07-06 Murray Cumming <murrayc@murrayc.com>
467 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
468 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
469 give a more exact error message that can be partly translated.
471 2007-07-05 Murray Cumming <murrayc@murrayc.com>
473 * src/maemo/modest-address-book.c:
474 (select_email_addrs_for_contact): Specify a default window size for the
475 select-email-address dialog, so that it is probably big enough for the
476 title. This should fix projects.maemo.org bug NB#62277.
478 2007-07-05 Murray Cumming <murrayc@murrayc.com>
480 * src/maemo/easysetup/modest-easysetup-wizard.c:
481 (create_page_complete_easysetup): Use
482 gtk_widget_set_size() request to ensure that the text wraps
485 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
487 * src/maemo/easysetup/modest-easysetup-wizard.c:
488 (on_entry_invalid_character), (create_page_account_details),
489 (create_page_user_details):
490 Use new API of ModestValidatingEntry. But for some reason the banner is
491 not shown. I will have to investigate that further.
493 * src/widgets/modest-validating-entry.c: (on_insert_text),
494 (modest_validating_entry_set_func):
495 * src/widgets/modest-validating-entry.h:
496 Added a new callback function to be able to react to prevented
497 characters whitespaces to e.g show a banner.
499 2007-07-05 Armin Burgmeier <armin@openismus.com>
501 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
502 notification of HildonNumberEditor instead of remembering the port
503 number. Thanks to Johannes for pointing this out.
505 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
507 * src/maemo/easysetup/modest-easysetup-wizard.c:
508 Check if there are any user changes before showing a confirmation
509 dialog (projects.maemo.org NB#60946)
511 2007-07-05 Armin Burgmeier <armin@openismus.com>
513 * src/maemo/modest-account-settings-dialog.c: Remember custom port
514 number at the beginning of the dialog and set the modified flag at the
515 end if the port number has changed. This is necessary because
516 HildonNumberEditor does not support notification when the value has
519 2007-07-05 Murray Cumming <murrayc@murrayc.com>
521 * src/modest-ui-actions.c:
522 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
523 a connection before asking anything else. Correct the check for the destination
524 folder so that it succeeds when online.
525 This fixed projects.maemo.org bug NB#61645.
527 2007-07-05 Murray Cumming <murrayc@murrayc.com>
529 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
530 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
531 to fix projects.maemo.org bug NB#62439.
533 2007-07-05 Murray Cumming <murrayc@murrayc.com>
535 * src/modest-tny-account.c: (on_connection_status_changed):
536 Really do not use tny_device_force_offline() here. See the previous comment.
538 2007-07-04 Murray Cumming <murrayc@murrayc.com>
540 * src/modest-tny-account.c: (on_connection_status_changed):
541 Do not use tny_device_force_offline() when tinymail says that something
542 went wrong with the connection. It seems to report this unnecessarily.
544 2007-07-04 Murray Cumming <murrayc@murrayc.com>
546 * src/maemo/modest-connection-specific-smtp-window.c:
547 (modest_connection_specific_smtp_window_init):
548 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
549 does not seem to have any effect in osso 1.1 (though it works in
550 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
552 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
554 * src/maemo/modest-connection-specific-smtp-window.c:
555 Fix UI specification problems with projects.meamo.org NB#60479
557 2007-07-04 Murray Cumming <murrayc@murrayc.com>
559 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
560 clue when this has failed, because the error dialog is not always shown
561 (at least in earlier version).
563 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
564 GError message, because the generic error dialog is not helpful.
566 'This message is not currently available (can't let a new connection go online)'
567 when trying to open an IMAP message.
569 (_modest_ui_actions_open): Offer a connection when some messages would
570 have to be downloaded and we are offline.
572 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
574 * src/widgets/modest-folder-view.c:
575 Don't check for MERGE type anymore as we use the correct type
577 NOTE: For the last two changes you need to update your tinymail copy
578 because of API changes!
580 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
582 * src/modest-tny-local-folders-account.c:
583 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
584 (see projects.maemo.org NB#61580)
586 2007-07-04 Murray Cumming <murrayc@murrayc.com>
588 * src/modest-tny-account.c: (on_connection_status_changed):
589 Commented out the call to modest_platform_connect_and_wait() because this
590 seems to always hang, and I would like to know if this is the only thing
591 that causes a hang when showing the connection dialog.
592 It is not very useful anyway.
594 2007-07-04 Murray Cumming <murrayc@murrayc.com>
596 * src/maemo/modest-msg-view-window.c:
597 (modest_msg_view_window_select_next_message):
599 * src/modest-platform.h:
600 * src/maemo/modest-platform.c:
601 Added modest_platform_connect_and_wait(), which calls
602 tny_maemo_conic_device_connect() always in the main thread, by calling it
603 in an idle handler and waiting for the idle handler to run. It should be
604 in the main thread because it uses GTK+ UI code. It just returns TRUE
605 if the device is already online.
607 There is some nasty code to ensure that subsequent calls to
608 modest_platform_connect_and_wait() just wait for the first one to finish,
609 by checking repeatedly in another idle handler. This is necessary,
610 because other threads (or even the main thread, via another idle handler)
611 can call modest_platform_connect_and_wait() while
612 modest_platform_connect_and_wait() is running.
614 (modest_platform_connect_and_wait_if_network_account),
615 (modest_platform_connect_and_wait_if_network_folderstore):
616 Convenience functions that calls modest_platform_connect_and_wait() if
617 the account or folder might want network access.
619 * src/modest-mail-operation.c:
620 (modest_mail_operation_update_account):
621 * src/modest-ui-actions.c: (download_uncached_messages),
622 (modest_ui_actions_on_rename_folder), (delete_folder),
623 (modest_ui_actions_on_main_window_move_to),
624 (modest_ui_actions_on_msg_view_window_move_to):
625 * src/widgets/modest-folder-view.c:
626 (drag_and_drop_from_folder_view):
627 Offer a connection if we are offline.
629 * src/modest-tny-account.c: (on_connection_status_changed):
630 Document this as only handling errors during network operations in progress,
631 and replace the idle code with a simple call to
632 modest_platform_connect_and_wait(), which does this instead.
634 2007-07-03 Murray Cumming <murrayc@murrayc.com>
636 * src/modest-tny-account.c:
637 (modest_tny_account_get_special_folder): (util_on_idle),
638 Handle the GError so we can see when tny_folder_store_get_folders()
639 fails, as it currently does while something else is connecting.
641 Added util_run_in_main_thread_and_wait()
642 which uses an idlen handler and mainloop to ensure that the function
643 is called in the main thread.
644 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
645 to make sure that we call attempt the connection in the mainloop only,
646 which might solve some hangs.
648 2007-07-03 Murray Cumming <murrayc@murrayc.com>
650 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
651 be found by their display name. This is never useful.
652 * src/modest-tny-account-store.c: (on_account_removed): Find the account
653 by its ID, instead of trying to use its ID as its display name.
655 * src/modest-tny-account-store.h:
656 * src/modest-tny-account.c:
657 (modest_tny_account_get_special_folder): Add a g_warning() when
658 tny_folder_store_get_folders() returns an empty list for the maildir.
660 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
661 Add a g_warning() when this returns NULL, because that it not allowed
664 2007-07-02 Armin Burgmeier <armin@openismus.com>
666 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
667 note when trying to cancel the wizard. This fixes projects.maemo.org
670 2007-07-02 Murray Cumming <murrayc@murrayc.com>
672 * src/modest-tny-account.h:
673 * src/modest-tny-account.c:
674 (modest_tny_account_new_from_server_account),
675 (modest_tny_account_new_from_server_account_name),
676 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
677 because this must now be set before setting the proto. This is usd in
678 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
679 warning in camel_session_get_service() caused by
680 tny_camel_transport_account_prepare().
682 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
685 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
687 * src/maemo/modest-connection-specific-smtp-edit-window.c:
689 (modest_connection_specific_smtp_edit_window_init):
691 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
694 2007-06-29 Murray Cumming <murrayc@murrayc.com>
696 * src/modest-tny-account.c:
697 (modest_tny_account_new_from_server_account):
698 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
699 now uses to request a connection when it needs one, and which it uses
700 to tell us that something is wrong with the connection, so we can force
701 the accounts offline to prevent further problems.
704 * src/modest-init.c: (init_default_settings):
705 * src/modest-mail-operation.c:
706 (modest_mail_operation_update_account):
707 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
708 This should not be necessary anymore. Do not set the conf key that
709 determined this (it was always TRUE and not set anywhere else).
711 * src/modest-ui-actions.h: Remove unused and unimplemented
712 modest_ui_actions_on_online_toggle_toggled().
714 2007-06-29 Murray Cumming <murrayc@murrayc.com
716 * src/maemo/modest-main-window.c: (connect_signals):
717 Don't connect to delete_event twice. Maybe this was harmless.
719 2007-06-29 Murray Cumming <murrayc@murrayc.com
721 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
722 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
723 Debug output to give some more clue when a folder move is not allowed.
725 2007-06-28 Murray Cumming <murrayc@murrayc.com
727 * src/modest-tny-account.c: (on_modest_file_system_info),
728 (modest_tny_account_get_mmc_account_name):
729 Always call the callback, without checking whether the name has changed.
730 * src/widgets/modest-folder-view.c: (strings_are_equal),
731 (on_model_foreach_set_name), (on_get_mmc_account_name),
732 (text_cell_data): Compare the name here, and use the name from
733 the account rather than from the
734 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
735 if the name was changed after the account was added to the model.
736 That's a tinymail bug but not one that I want to fix now.
738 This finally fixes projects.maemo.org bug NB#59301.
740 2007-06-27 Armin Burgmeier <armin@openismus.com>
742 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
745 2007-06-27 Murray Cumming <murrayc@murrayc.com
747 * src/modest-tny-account.h:
748 * src/modest-tny-account.c:
749 Added modest_tny_account_get_mmc_account_name(), to set the memory
750 card name asynchronously for the given account and then notify.
751 (modest_tny_account_new_for_local_folders): Use this new function instead
752 of using hildon_file_system_info_async_new() directly.
754 * src/widgets/modest-folder-view.c: (text_cell_data):
755 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
756 gtk_tree_model_row_changed() when it is available.
758 This should fix projects.maemo.org bug NB#59301.
760 2007-06-27 Murray Cumming <murrayc@murrayc.com
762 * src/modest-mail-operation.c: (update_account_thread),
763 (get_msgs_full_thread): Fix typo failures in the revert
766 2007-06-27 Murray Cumming <murrayc@murrayc.com
768 * src/maemo/modest-maemo-global-settings-dialog.c:
769 (idle_select_default_focus):
770 * src/modest-mail-operation.c: (idle_notify_progress),
771 (idle_notify_progress_once), (set_last_updated_idle),
772 (update_account_thread), (get_msgs_full_thread):
773 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
774 * src/widgets/modest-header-view.c:
775 (idle_notify_headers_count_changed_destroy),
776 (idle_notify_headers_count_changed):
777 Reverted the additions of gdk_threads_enter/leave(), in case this
778 helps with a startup hang on the device.
780 2007-06-26 Armin Burgmeier <armin@openismus.com>
782 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
783 for supported secure authentication methods from server by
784 gtk_dialog_run(), saving CPU time and a potential race condition.
786 2007-06-26 Armin Burgmeier <armin@openismus.com>
788 * src/maemo/modest-maemo-utils.h:
789 * src/maemo/modest-maemo-utils.c: Added a
790 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
791 only error code to tell the calling code when the user canceled the
794 * src/maemo/modest-account-settings-dialog.h:
795 * src/maemo/modest-account-settings-dialog.c:
796 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
797 message if the retrieval of secure authentication methods was canceled
798 by the user. Perform the check before saving anything to configuration
799 to not end up with half-committed configuration changes, do not show
800 a "Saving to configuration failed" note when authentication methods
801 could not be retrieved.
803 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
806 2007-06-26 Murray Cumming <murrayc@murrayc.com>
808 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
809 Only return the first level of folders under accounts, because the
810 osso-global-search UI spec doesn't want the rest.
811 This fixed projects.maemo.org bug NB#61811.
813 2007-06-26 Murray Cumming <murrayc@murrayc.com>
815 * src/modest-tny-account-store.c:
816 * src/modest-tny-account-store.h:
817 Added modest_tny_account_is_memory_card_account().
818 * src/maemo/modest-main-window.c: (create_details_widget):
819 Show the same information items for the memory card as we show for the
820 local-folders, to fix projects.maemo.org bug NB#59307.
822 2007-06-26 Murray Cumming <murrayc@murrayc.com>
824 * src/modest-tny-account-store.c: (get_password):
825 Added some checks for NULL to maybe prevent crashes, though I think
826 it was Philip's last commit that actually prevented the crash here
827 when creating a first new account.
828 But the new account is still not usable (no messages are shown)
829 until a restart of the application.
831 2007-06-26 Murray Cumming <murrayc@murrayc.com>
833 * src/maemo/modest-maemo-global-settings-dialog.c:
834 (idle_select_default_focus):
835 * src/modest-mail-operation.c: (idle_notify_progress),
836 (idle_notify_progress_once), (idle_notify_update_account_queue),
837 (set_last_updated_idle), (update_account_thread),
838 (notify_get_msgs_full), (get_msgs_full_destroyer),
839 (get_msgs_full_thread):
840 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
841 * src/widgets/modest-header-view.c:
842 (idle_notify_headers_count_changed_destroy),
843 (idle_notify_headers_count_changed):
844 Use gdk_threads_enter() and gdk_threads_enter_leave() in
845 all idle handlers, because some other thread could be blocking
846 the GDK lock, so that it can do GUI stuff.
848 2007-06-26 Murray Cumming <murrayc@murrayc.com>
850 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
851 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
852 (on_idle_send_receive), (on_idle_open_default_inbox):
853 * src/maemo/modest-msg-edit-window.c:
854 (modest_msg_edit_window_attach_file_noninteractive):
855 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
856 to prevent a hang. I don't quite understand why these are necessary,
857 beause we should already be in the main loop. I guess something outside
858 of the main loop is taking the lock.
860 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
861 we are really using URIs, and use files that are more likely to exist.
863 2007-06-26 Murray Cumming <murrayc@murrayc.com>
865 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
866 necessary because configure.ac now defines different variables.
868 2007-06-26 Murray Cumming <murrayc@murrayc.com>
870 * libmodest-dbus-client/libmodest-dbus-client.c:
871 * libmodest-dbus-client/libmodest-dbus-client.h:
872 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
873 libmodest_dbus_client_compose_mail() is what things actually use.
875 * src/dbus_api/modest-dbus-api.h:
876 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
877 * tests/dbus_api/Makefile.am:
878 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
881 2007-06-26 Murray Cumming <murrayc@murrayc.com>
883 * src/modest-init.c: (modest_init_local_folders):
884 For memory-card (or other non local-folders) maildir accounts,
885 always create an Archive folder, so that there is somewhere to put
886 messages. This should be less confusing, because the user does not need
887 to guess that the need to create a folder.
889 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
891 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
892 Fixed icon size by using (50, 50) which is the same as defined by
895 2007-06-25 Armin Burgmeier <armin@openismus.com>
897 * src/widgets/modest-window-mgr.c:
899 * configure.ac: Correctly recognize hildon-notify presence and fixed
900 the build without it being installed.
902 2007-06-25 Murray Cumming <murrayc@murrayc.com>
904 * libmodest-dbus-client/libmodest-dbus-client.c:
905 (libmodest_dbus_client_search): Fix the build. Sorry.
906 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
907 (reply_forward_cb): Initialize variables to fix the build.
909 * src/modest-tny-account-store.c:
910 (modest_tny_account_store_get_tny_account_by): Fix the account URI
911 comparison (a silly typo) so that email search results can be opened
912 when there are more than one account.
914 2007-06-25 Murray Cumming <murrayc@murrayc.com>
916 * libmodest-dbus-client/libmodest-dbus-client.c:
917 (libmodest_dbus_client_search),
918 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
919 instead of 1 second, because the search gets folders and messages from
920 the server, which can take a long time. When it times out,
921 osso-global-search will report no results.
923 We need to specify whether we should search only cached information
924 (maybe with a user preference), and the osso-email-search-plugin
925 API should really be improved to allow that option, and to allow results
926 to be delivered asynchronously in batches.
928 2007-06-25 Murray Cumming <murrayc@murrayc.com>
930 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
931 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
932 GTK_ICON_SIZE_DIALOG is probably the wrong size.
934 2007-06-25 Murray Cumming <murrayc@murrayc.com>
936 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
937 that is an empty string. D-Bus seems to give us these instead of NULL.
939 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
941 * src/dbus_api/modest-dbus-callbacks.c:
942 * src/maemo/easysetup/modest-easysetup-wizard.h:
943 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
944 * src/maemo/modest-connection-specific-smtp-edit-window.c:
945 (modest_connection_specific_smtp_edit_window_init):
946 * src/maemo/modest-maemo-global-settings-dialog.c:
948 * src/maemo/modest-maemo-utils.c:
949 (modest_maemo_utils_setup_images_filechooser):
950 * src/maemo/modest-main-window.c: (create_details_widget):
951 * src/maemo/modest-msg-edit-window.c:
952 (modest_msg_edit_window_attach_file_noninteractive),
953 (modest_msg_edit_window_color_button_change),
954 (modest_msg_edit_window_set_zoom):
955 * src/modest-mail-operation.c: (update_account_thread):
956 * src/modest-tny-account-store.c:
957 * src/modest-tny-account.c:
958 * src/widgets/modest-global-settings-dialog.c:
959 * src/widgets/modest-window.h:
963 2007-06-25 Murray Cumming <murrayc@murrayc.com>
965 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
966 * src/modest-search.c: (modest_search_folder),
967 (modest_search_all_accounts): Actually search only in the specified folder,
968 doing a simple match on the folder ID.
969 * src/modest-search.h: Added a folder field to the ModestSearch struct,
970 and added some documentation.
972 2007-06-22 Armin Burgmeier <armin@openismus.com>
974 * src/maemo/modest-maemo-utils.h:
975 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
976 modest_maemo_utils_get_supported_secure_authentication_methods.
978 * src/maemo/easysetup/modest-easysetup-wizard.c:
979 * src/maemo/modest-account-settings-dialog.c: Show correct error if
980 one occured, not just "Server does not support secure authentication".
982 2007-06-22 Murray Cumming <murrayc@murrayc.com>
984 * src/modest-tny-account-store.c: (get_password):
985 Restored the call to tny_account_set_user() because Philip seems to have
986 stopped this from crashing (by not using the freed string). It still does
987 not work, but now we can test it.
989 2007-06-22 Murray Cumming <murrayc@murrayc.com>
991 * src/maemo/modest-msg-edit-window.c: (init_window):
992 Comment out use of an uninitialzed GtkScrolledWindow variable,
993 to fix the build and stop a crash. Yet again.
995 2007-06-22 Murray Cumming <murrayc@murrayc.com>
997 * src/modest-tny-account-store.c: (get_password):
998 Remove the call to tny_account_set_user() because this actually crashes.
999 As mentioned in the last commit, it is known to not work anyway.
1001 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1003 * src/modest-tny-account-store.c: (get_password):
1004 Use tny_account_set_username() to tell tinymail that the username might
1005 have changed too. But tinymail ignores this: see projects.maemo.org
1007 * src/modest-ui-actions.c:
1008 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1009 reset the connection when changing the username, and improve the comments.
1010 Save the changed username to gconf at least, so it is used when Modest is
1013 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1015 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1016 Do not use a query, so that we get all folders, including for POP and
1017 local-folders. They work as search criteria too.
1018 This fixes projects.maemo.org bug NB#57740.
1020 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1022 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1023 Comment out the use of hildon_notification_set_sound() because it is
1024 not declared, to fix the build. Warnings are serious, people.
1026 2007-06-21 Armin Burgmeier <armin@openismus.com>
1028 * src/maemo/modest-maemo-utils.h:
1029 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1030 modest_maemo_utils_get_supported_secure_authentication_methods()
1031 to query authentication methods for a specific user. This should fix
1032 projects.maemo.org bug NB#61369.
1034 * src/maemo/easysetup/modest-easysetup-wizard.c:
1035 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1038 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1040 * libmodest-dbus-client/libmodest-dbus-client.h:
1041 * libmodest-dbus-client/libmodest-dbus-client.c:
1042 (modest_dbus_message_iter_get_search_hit),
1043 (libmodest_dbus_client_search):
1044 Reorganised and commented this.
1045 Removed modest_search_hit_free() from the public API because it
1048 Added libmodest_dbus_client_get_folders() and
1049 modest_folder_result_list_free().
1051 * src/dbus_api/modest-dbus-api.h:
1052 * src/dbus_api/modest-dbus-callbacks.c:
1053 (modest_dbus_req_filter): Commented. Moved most code to
1054 on_dbus_method_search() and added on_dbus_method_get_folders().
1056 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1057 of the extra D-Bus handler.
1059 * tests/dbus_api/Makefile.am:
1060 * tests/dbus_api/test_get_folders.c: New test for
1061 libmodest_dbus_client_get_folders(). This seems to return an empty list
1062 at the moment. That could be the same error that causes the message list
1063 to be empty sometimes.
1064 This should help with projects.maemo.org bug NB#57740.
1066 2007-06-21 Armin Burgmeier <armin@openismus.com>
1068 * src/modest-mail-operation.c: Do not call
1069 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1070 notify the operation's end after having set the status to CANCELED for
1071 the operation queue to listen on. This fixes a deadlock when there
1072 were mail operations in the queue during its finalization.
1074 * src/modest-singletons.c: Reordered uninitialization of the account
1075 manager to happen after the mail operation queue was uninitialized
1076 because the mail operation's in the queue might still try to access
1077 the account manager (see modest_mail_operation_notify_end()). This
1078 fixes a potential crash when terminating the application.
1080 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1082 * src/modest-search.c:
1083 (search_mime_part_and_child_parts): Moved some code here so we
1084 can search recursively in child folders.
1085 (modest_search_folder): Search in the message as a mime part, instead
1086 of just its child mime parts.
1087 (read_chunk), (search_mime_part_ogs):
1088 Check how many bytes were read, to prevent an endless loop.
1089 Searching in message bodies now works. This finishes the fix for
1090 projects.maemo.org bug NB#61007.
1092 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1094 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1095 Add a g_warning when the item is not a folder.
1097 * src/modest-ui-dimming-rules.c:
1098 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1099 when selected item is not a folder (for instance, an account), because
1100 the UI spec only talks about folders.
1101 I am not sure what the UI spec wants, so this might not totally fix
1102 projects.maemo.org bug NB#60794.
1104 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1106 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1107 (load_from_file): Sort the list. The unsorted list would be more noticeable
1108 in non-English locales.
1110 * src/maemo/modest-msg-edit-window.c:
1111 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1112 warning and fix the build.
1114 * src/maemo/modest-progress-bar-widget.c:
1115 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1116 avoid a g_warning, and probably to avoid a crash.
1118 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1120 * src/modest-search.c: (modest_search_folder): Check for a GError
1121 when calling tny_folder_get_headers(), to show that this is not the cause
1124 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1126 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1127 Actually set the body query instead of the subject query.
1129 * src/modest-search.c: (search_mime_part_ogs),
1130 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1131 which would probably cause it to fail if we got this far.
1133 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1134 to simplify the code.
1135 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1136 be causing search-in-body to fail.
1138 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1140 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1142 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1143 Better debug message when the folder cannot be found.
1144 This should help with fixing projects.maemo.org bug #61287.
1145 * src/modest-search.c: (add_hit): Do not leak the furl string.
1147 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1149 * src/modest-ui-actions.c:
1150 (modest_ui_actions_on_folder_selection_changed):
1151 Do not special-case TNY_MERGE_FOLDER here, because
1152 modest_tny_folder_get_account() already does that. This fixes
1153 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1154 shown when the Outbox was selected).
1156 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1158 * libmodest-dbus-client/libmodest-dbus-client.c:
1159 (_dbus_iter_get_string_or_null): Initialize the string variable in
1160 case this helps with Dirk's crash.
1162 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1164 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1165 though it is not implemented yet (this function is maybe not even used),
1166 to avoid breaking ABI in future.
1167 * libmodest-dbus-client/libmodest-dbus-client.c:
1168 (get_attachments_string): Moved some code into this generic function.
1169 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1170 sends email. It is maybe not used.
1171 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1172 (on_send_mail): Use attachments.
1174 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1175 * src/maemo/modest-msg-edit-window.c:
1176 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1177 a filename before using it, to fix projects.maemo.org bug NB#58233.
1179 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1181 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1182 Initialize the continue_download variable to fix the build, and probably
1183 to fix randome behaviour.
1185 2007-06-18 Armin Burgmeier <armin@openismus.com>
1187 * src/modest-tny-send-queue.h:
1188 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1189 the queue so we can later show it in the UI. Replaced
1190 modest_tny_send_queue_msg_is_being_sent() by
1191 modest_tny_send_queue_get_msg_status().
1193 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1195 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1196 gpointer. This probably was not harmful, but just to be sure.
1198 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1200 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1201 Fix the build, but leave the function broken on Bora, because
1202 hildon_uri_action_get_service() does not exist.
1203 osso_uri_action_get_service() does not exist either, it seems.
1205 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1207 * src/modest-tny-account.c:
1208 (modest_tny_account_new_from_server_account):
1209 Uncommented the url debug output again, because it is useful for
1210 debugging, as I said in the comment.
1212 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1214 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1216 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1217 for Mameo Bora, to fix the build.
1219 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1222 Fixed build with hildon < 0.99
1224 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1225 Check if the selected account is busy instead of checking all accounts
1227 * src/modest-account-mgr-priv.h:
1228 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1229 (modest_account_mgr_init), (compare_account_name),
1230 (modest_account_mgr_set_account_busy),
1231 (modest_account_mgr_account_is_busy):
1232 * src/modest-account-mgr.h:
1233 Added busy information to the account manager. It possible to
1234 set an account to busy or not busy now.
1236 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1237 (modest_mail_operation_update_account),
1238 (modest_mail_operation_notify_end):
1239 Set the account to busy/not busy depending on the operation state.
1241 * src/widgets/modest-account-view.c:
1242 (modest_account_view_finalize), (get_last_updated_string),
1243 (update_account_view), (on_account_busy_changed), (init_view):
1244 Show string "Refreshing..." if the account is currently busy.
1246 All this fixes projects.maemo.org bug NB#59711
1248 2007-06-14 Armin Burgmeier <armin@openismus.com>
1250 * src/widgets/modest-attachments-view.h:
1251 * src/widgets/modest-attachments-view.c: Added
1252 modest_attachments_view_has_attachments() and fixed coordinate
1253 transformation in get_att_view_at_coords(). This fixes attachment
1256 * src/widgets/modest-msg-view.c: Make use of
1257 modest_attachments_view_has_attachments() to decide whether to show
1258 attachments in the header.
1260 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1262 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1263 (on_change), (on_combo_security_changed),
1264 (modest_connection_specific_smtp_edit_window_init),
1265 (modest_connection_specific_smtp_edit_window_set_connection),
1266 (modest_connection_specific_smtp_edit_window_is_dirty):
1267 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1268 * src/maemo/modest-connection-specific-smtp-window.c:
1271 Show an comfirmation dialog for the smpt-edit-window if there are
1272 unsaved changes and the user hits cancel.
1273 (projects.maemo.org bug NB#60479)
1275 2007-06-14 Armin Burgmeier <armin@openismus.com>
1277 * src/maemo/easysetup/modest-easysetup-wizard.c:
1278 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1279 address" info in banner instead of node, and select all the text as
1280 per UI spec. This fixes projects.maemo.org bug NB#60550.
1282 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1284 reviewed by: <delete if not using a buddy>
1286 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1287 * src/modest-ui-actions.c: (folder_refreshed_cb):
1289 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1291 * src/widgets/modest-folder-view.c: (filter_row):
1292 Explictly filter out the per-account outbox accounts. I don't know why
1293 these only sometimes show up, but now they should never show up in the UI.
1294 This should fix projects.maemo.org bug NB#60160.
1296 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1298 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1299 when the toolbar does not exist yet.
1300 * src/modest-widget-memory.c: (save_settings_header_view):
1301 Added g_warnings() to help us to discover when we are trying to set
1302 an empty columns list in gconf.
1304 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1306 * src/modest-init.h:
1307 * src/modest-init.c:
1308 Added modest_init_get_default_header_view_column_ids().
1310 * src/modest-widget-memory.c: (restore_settings_header_view):
1311 Use the new function to get defaults, if the gconf key is empty,
1312 instead of not creating any columns. This seems to fix the
1313 empty right-hand pane problems.
1315 * src/widgets/modest-header-view.h: Improved documentation.
1317 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1319 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1320 Revert the use of the display name as the account name, because this
1321 is generally wrong and would break the code that follows.
1323 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1325 * src/maemo/easysetup/modest-easysetup-wizard.c:
1326 (check_for_supported_auth_methods), (on_before_next),
1329 More correct fix for projects.maemo.org bug NB# 58991
1330 Do not longer accept AUTH_PASSWORD as secure method and choose
1331 correct method when creating the account.
1333 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1335 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1336 Fixed projects.maemo.org bug NB# 58991
1338 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1340 * src/modest-init.c: (modest_init_init_core),
1341 (modest_init_local_folders): Fixed compilation errors.
1343 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1345 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1346 Remove unnecessary lib/include, though it is good in principle when needed.
1348 * src/modest-init.c: (modest_init_one_local_folder),
1349 (modest_init_local_folders):
1350 * src/modest-init.h: Initialize the .modest library for memory cards,
1351 instead of just doing nothing for them. This should allow us to create
1352 folders there, fixing projects.maemo.org bug NB#59297.
1354 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1356 * libmodest-dbus-client/libmodest-dbus-client.c:
1357 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1358 (libmodest_dbus_client_compose_mail),
1359 (libmodest_dbus_client_open_message),
1360 (libmodest_dbus_client_send_and_receive),
1361 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1363 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1364 (on_idle_open_message), (modest_dbus_req_handler),
1365 (search_result_to_message), (modest_dbus_req_filter):
1366 * src/modest-search.c: (add_hit), (modest_search_folder),
1367 (modest_search_all_accounts): Improved debug messages.
1369 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1371 * src/modest-tny-account-store.c:
1372 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1375 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1378 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1380 * src/modest-tny-account-store.c: (get_server_accounts):
1381 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1382 even when there are no accounts, so that the Outbox folder is always
1383 visible. This fixes projects.maemo.org bug NB#60158.
1385 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1387 * src/maemo/modest-main-window.c: (create_details_widget):
1388 Use the mcen_va_never logical ID.
1390 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1392 * src/dbus_api/modest-dbus-api.h:
1393 * src/dbus_api/modest-dbus-callbacks.c:
1394 (on_idle_open_default_inbox), (on_open_default_inbox),
1395 (modest_dbus_req_handler):
1396 Added a new OpenDefaultInbox method.
1398 * libmodest-dbus-client/libmodest-dbus-client.h:
1399 * libmodest-dbus-client/libmodest-dbus-client.c:
1400 Added libmodest_dbus_client_open_default_inbox() to call the new
1401 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1402 though it should maybe be used by a new osso-email-interface function.
1404 * tests/dbus_api/Makefile.am:
1405 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1408 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1410 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1411 NULL, so that the signals get all the keys. This should not actually
1412 change any behaviour because we currently update everything when anything
1415 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1417 * src/widgets/modest-folder-view.c: (text_cell_data),
1418 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1419 (find_inbox_iter): If tinymail tells us that the folder is
1420 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1421 This causes the inbox to be selected at startup, fixing part of
1422 projects.maemo.org bug NB#56305.
1424 * src/modest-ui-dimming-rules.c:
1425 (modest_ui_dimming_rules_on_tools_smtp_servers):
1426 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1427 the SMTP servers menu item.
1428 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1429 that the SMTP Servers menu item is dimmed when there are no accounts,
1430 as a future version of the UI spec will require. This fixes
1431 projects.maemo.org bug NB#56305.
1433 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1435 * src/maemo/modest-maemo-utils.c:
1436 (modest_maemo_utils_get_supported_secure_authentication_methods):
1437 Added label to dialog instead of unreadable title
1439 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1440 (modest_main_window_new):
1441 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1444 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1445 * src/modest-account-mgr.h:
1446 Added method to avoid code duplication
1448 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1449 (modest_ui_actions_on_send_receive):
1450 Use modest_account_mgr_has_accounts
1452 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1454 * src/maemo/easysetup/modest-presets.c:
1455 (modest_presets_get_info_server_security): Do not report secure auth
1457 * src/modest-protocol-info.c: Use the defines for the gconf key names
1458 for secure authentication. This was not working because we were writing
1459 Password and reading password, and the check was case sensitive.
1460 With this, gmail now works for receiving and sending when created via
1463 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1465 * src/maemo/easysetup/modest-presets.c:
1466 (modest_presets_get_info_server_security): Correct the key name for
1467 SecureSmtp, because it seems to be case-sensitive.
1468 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1469 Do not try to get the 0th notebook page if there are 0 pages, to
1470 avoid a g_warning().
1472 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1474 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1475 Prevent use of the new notification feature for now, because it currently
1476 shows one dialog for each new email, which is annoying.
1478 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1480 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1481 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1482 when no country was selected, so that we show the global ones.
1483 * src/maemo/easysetup/modest-presets.c:
1484 (modest_presets_get_providers): Return only the global providers, not
1485 all providers when mmc=0 was requested.
1487 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1489 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1490 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1491 provider ID in the combo.
1493 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1494 Do not show the page numbers, because it would be confusing when we add
1495 the 2 extra pages for the custom setup, when the user chooses the "Other"
1496 provider. This fixes projects.maemo.org bug NB#59028
1498 * src/modest-init.c: (modest_init_init_core),
1499 (modest_init_local_folders):
1500 * src/modest-init.h:
1501 * src/modest-tny-account.c:
1502 (modest_tny_account_new_for_local_folders): Do not create default folders
1503 for the memory card. This should fix projects.maemo.org bug NB#59328.
1505 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1507 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1508 Free the changed_conf_keys string items. They are already freed in the
1509 idle handler if that runs first.
1511 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1513 * src/modest-ui-actions.c:
1514 (modest_ui_actions_on_password_requested): Check that the server name
1515 is not NULL, because I just saw a password dialog with (null) as the
1518 * src/modest-tny-folder.[h|c]: Added
1519 modest_tny_folder_is_memory_card_folder().
1520 * src/modest-ui-dimming-rules.c:
1521 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1522 menu item for memory cards, as per the UI spec (section 7.4). This should
1523 fix projects.maemo.org bug NB#59297.
1525 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1527 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1528 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1529 is another problem with the code, see Murray's comment at line 772)
1531 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1533 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1534 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1535 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1536 (load_from_file), (easysetup_country_combo_box_init),
1537 (easysetup_country_combo_box_get_active_country_ids),
1538 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1539 instead of just one ID, to avoid duplicate country names in the UI.
1541 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1542 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1543 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1544 a single ID, avoiding duplicate providers.
1545 * src/maemo/easysetup/modest-easysetup-wizard.c:
1546 (on_combo_account_country): Adapt to use a list.
1548 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1550 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1551 keys changed in the last X seconds.
1553 * src/modest-account-mgr.h:
1554 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1555 (on_key_change), (modest_account_mgr_class_init),
1556 (modest_account_mgr_init), (modest_account_mgr_finalize):
1557 As the keys are changed, save them in a GSList* and signal that GSList*
1558 further every X seconds, to batch changes, to allow us to do just one
1559 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1560 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1562 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1563 changed signal signature.
1565 * src/modest-conf.c: (modest_conf_set_list),
1566 (modest_conf_on_change): Reenable notification.
1568 (modest_conf_maemo_fake_on_change): Comment out the hack that
1569 notified immediately instead of asynchronously.
1571 * src/widgets/modest-account-view.h:
1572 * src/widgets/modest-account-view.c:
1573 (update_account_view): Select the previously-selected account ID,
1574 if possible. This fixes projects.maemo.org bug NB#56933.
1576 (on_account_changed), (on_account_removed),
1577 (modest_account_view_select_account):
1579 Remove the block/unblock functions
1580 because they were not useful.
1582 * src/maemo/modest-account-view-window.c:
1583 (on_delete_button_clicked), (on_edit_button_clicked),
1584 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1586 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1588 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1589 Improve the error dialog to show Incorrect Account Settings, which seems
1590 clearer, and say that the internal error message (to be removed from the
1591 dialog later) is often misleading.
1592 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1594 * src/modest-tny-account.c:
1595 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1596 URL because this is so useful for debugging on the device.
1598 * src/widgets/modest-serversecurity-combo-box.c:
1599 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1601 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1603 * src/modest-mail-operation.c:
1604 (modest_mail_operation_send_new_mail):
1605 Added a comment about a nasty but apparently harmless message. Details
1606 added to the wiki g_warnings() page.
1608 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1610 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1611 (modest_tny_send_queue_class_init):
1612 Do not use the priv struct because it is empty, to avoid g_warnings
1613 about a non-existant priv struct.
1615 * src/modest-tny-account-store.c:
1616 (modest_tny_account_store_get_server_account),
1617 (modest_tny_account_store_get_transport_account_for_open_connection
1618 ): Do not try to get transport server accounts for local folders,
1619 because they don't have any. This avoids a g_warning().
1621 * src/maemo/modest-main-window.c:
1622 (modest_main_window_notify_send_receive_initied),
1623 (on_configuration_key_changed):
1624 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1625 * src/modest-defs.h:
1626 * src/modest-mail-operation.c:
1627 (modest_mail_operation_update_account):
1628 * src/modest-tny-account-store.h:
1629 * src/modest-tny-account.c:
1630 (modest_tny_account_get_special_folder),
1631 (modest_tny_account_new_for_local_folders),
1632 (modest_tny_account_new_for_per_account_local_outbox_folder):
1633 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1634 * src/modest-tny-local-folders-account.c:
1635 (add_account_folders_to_merged_folder):
1636 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1637 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1638 (modest_ui_actions_on_send):
1639 * src/widgets/modest-folder-view.c: (update_model):
1640 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1641 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1642 modest_tny_account_store_get_tny_account_by_account() to
1643 modest_tny_account_store_get_server_account() to make the code clearer.
1645 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1647 * src/dbus_api/modest-dbus-api.h:
1648 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1649 * src/maemo/modest-msg-edit-window.c:
1650 (modest_msg_edit_window_attach_file_noninteractive):
1651 added g_warning in case the file to be attached does not exist
1652 * tests/dbus_api/test_compose_mail.c: (main):
1653 removed obsolete comment, added generic files as test case
1655 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1657 * src/modest-tny-account-store.c: (get_server_accounts):
1658 Create the local folders account only once, not once for each outbox, and
1659 not only when there are some outboxes.
1661 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1663 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1664 code that is causing a crash at startup. Sergio says that he is fixing this.
1666 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1668 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1669 * src/maemo/modest-account-settings-dialog.c:
1670 (create_page_outgoing),
1671 (modest_account_settings_dialog_set_account_name),
1672 (save_configuration):
1673 - Fixed handling of the "Use secure authentication" toggle to comply with
1674 the ui specification. See also projects.maemo.org bug NB#58400
1676 - Restore the Secure connection setting combo correctly when loading
1679 * src/maemo/modest-maemo-utils.c:
1680 (on_camel_account_get_supported_secure_authentication),
1681 (modest_maemo_utils_get_supported_secure_authentication_methods):
1682 Fixed a crasher if operation is canceled
1684 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1685 (modest_protocol_info_auth_is_secure):
1686 * src/modest-protocol-info.h:
1688 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1689 the sense of the "Use secure authentication" toggle.
1691 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1693 * src/modest-tny-account-store.h:
1694 * src/modest-tny-account-store.c:
1695 Added modest_tny_account_store_get_local_folders_account().
1697 * src/modest-tny-folder.h:
1698 * src/modest-tny-folder.c:
1699 (modest_tny_folder_get_account):
1700 Added this replacement for tny_folder_get_account() which returns
1701 the local-folders account for TnyMergeFolders, to avoid the
1702 warning about the unimplemented get_account_func() vfunc().
1704 (modest_tny_folder_get_rules),
1705 * src/modest-ui-actions.c:
1706 (modest_ui_actions_on_folder_selection_changed):
1707 * src/modest-mail-operation.c:
1708 (modest_mail_operation_remove_folder),
1709 (modest_mail_operation_xfer_folder),
1710 (modest_mail_operation_rename_folder),
1711 (modest_mail_operation_get_msg),
1712 (modest_mail_operation_get_msgs_full),
1713 (modest_mail_operation_remove_msg),
1714 (modest_mail_operation_xfer_msgs),
1715 (modest_mail_operation_refresh_folder):
1716 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1718 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1720 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1721 (modest_server_account_set_security):
1722 * src/modest-defs.h: Add comments explaining that our
1723 UI spec means TLS when it says Normal, so these do not look like errors.
1725 * src/modest-tny-account.c:
1726 (modest_tny_account_new_from_server_account): Use the new tinymail
1727 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1728 for TLS. This should fix projects.maemo.org bug NB#58460.
1730 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1732 * src/maemo/easysetup/modest-easysetup-wizard.c:
1733 (create_account): Correct the position of the gconf sanity check warning.
1734 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1735 of using the g_idle_add() hack, because this does not seem to be necessary
1736 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1737 caused by something other than maemo's gconf.
1738 This fixes projects.maemo.org bug #59022.
1740 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1742 * src/modest-account-mgr-helpers.c:
1743 (modest_account_mgr_get_default_account): Do not check that the account
1744 exists if there is no default account (NULL), to fix a runtime warning.
1746 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1748 * src/widgets/modest-folder-view.c: (update_model):
1749 Do not unref the treemodel before we have finished with it.
1750 This prevents a valgrind warning and an occasional crash at startup.
1752 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1754 * libmodest-dbus-client/libmodest-dbus-client.h:
1755 added libmodest_dbus_client_compose_mail()
1756 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1758 added functions needed for SendAsMail() functionality
1759 * src/maemo/modest-msg-edit-window.c:
1760 (modest_msg_edit_window_attach_file_noninteractive):
1761 non interactively attaching files to message edit window
1762 * src/widgets/modest-msg-edit-window.h:
1763 * tests/dbus_api/Makefile.am:
1764 added test_compose_mail.c
1765 * tests/dbus_api/test_compose_mail.c: (main):
1767 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1769 * src/modest-account-view.c:
1770 Fixed bug projects.maemo.org bug NB#59307
1772 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1774 * src/maemo/easysetup/modest-easysetup-wizard.c:
1775 (get_serverport_incoming), (on_before_next), (create_account):
1776 * src/maemo/modest-account-settings-dialog.c:
1777 (modest_account_settings_dialog_set_account_name):
1778 * src/maemo/modest-maemo-utils.c:
1779 (on_camel_account_get_supported_secure_authentication_status),
1780 (on_camel_account_get_supported_secure_authentication),
1781 (on_secure_auth_cancel),
1782 (modest_maemo_utils_get_supported_secure_authentication_methods):
1784 Implemented security authentication for settings and easysetup.
1786 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1788 * src/maemo/modest-main-window.c: (create_details_widget):
1789 Show the total size for memory card accounts too, instead of showing
1790 the name again. Fixes bug projects.maemo.org bug NB#59307.
1792 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1795 * src/modest-tny-simple-folder-store.c:
1796 * src/modest-tny-simple-folder-store.h: Removed.
1798 * src/modest-tny-local-folders-account.h
1799 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1800 for the local-folders maildir, with an extra TnyMergedFolder containing
1801 the folders of the per-account outbox store accounts.
1802 * src/modest-tny-account-store.c: (get_server_accounts):
1803 Add the outboxes to the special local folders account after creating it.
1805 * src/modest-tny-account.c:
1806 (modest_tny_account_new_for_local_folders): Create the derived
1807 account when creating the main local-folders account.
1809 * src/maemo/modest-main-window.c: (create_details_widget),
1810 (modest_main_window_set_contents_style):
1811 Adapted to the use of the derived account instead of the folder store.
1813 * src/modest-ui-actions.c:
1814 (modest_ui_actions_on_folder_selection_changed):
1815 * src/modest-ui-dimming-rules.c:
1816 (modest_ui_dimming_rules_on_new_folder):
1817 * src/widgets/modest-folder-view.c: (text_cell_data),
1818 (icon_cell_data), (filter_row), (update_model),
1819 (get_cmp_rows_type_pos):
1822 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1823 Do not get the priv struct, because no priv struct has been set,
1824 to avoid a runtime warning.
1826 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1827 #ifelse with #else, to fix a warning, to fix the build.
1830 2007-06-05 Christian Kellner <ckellner@openismus.com>
1832 * libmodest-dbus-client/libmodest-dbus-client.c:
1833 Fix small typo in doc (why do you always see them
1834 AFTER committing stuff?)
1837 2007-06-05 Christian Kellner <ckellner@openismus.com>
1839 * libmodest-dbus-client/libmodest-dbus-client.c:
1840 (libmodest_dbus_client_search):
1841 Initialize hit list with NULL. Also set folder list
1842 to "" if NULL was supplied.
1845 2007-06-03 Christian Kellner <ckellner@openismus.com>
1847 * libmodest-dbus-client/libmodest-dbus-client.c:
1848 (modest_search_hit_list_free):
1849 Make it save to call it with NULL.
1851 * src/dbus_api/modest-dbus-callbacks.c:
1852 * src/modest-search.c:
1853 Return full ModestSearchHits as the search result list not TnyHeader
1854 since can't be around withouth the correspoding TnyFolder.
1856 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1858 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1859 Added currently commented code to check for secure auth
1861 * src/maemo/modest-account-settings-dialog.c: (on_response),
1862 (save_configuration), (show_ok):
1863 Fixed projects.maemo.org bugs NB #59248 and #59251
1865 * src/maemo/modest-maemo-utils.c:
1866 (on_camel_account_get_supported_secure_authentication_status),
1867 (on_camel_account_get_supported_secure_authentication),
1868 (modest_maemo_utils_get_supported_secure_authentication_methods):
1869 * src/maemo/modest-maemo-utils.h:
1870 Moved get_supported_secure_authentication() method here to be able
1871 to use it from easysetup wizard.
1873 * src/modest-pair.c: (on_pair_compare_as_string):
1874 Should compare string with first part of pair and not
1875 strcmp pairs which will crash.
1877 * src/modest-protocol-info.c:
1878 (modest_protocol_info_protocol_is_store):
1879 * src/modest-protocol-info.h:
1880 Added modest_protocol_info_get_auth_protocol_name()
1882 2007-06-03 Armin Burgmeier <armin@openismus.com>
1884 * src/modest-mail-operation.c:
1885 (modest_mail_operation_get_msgs_full): Set priv->account also when
1886 only retrieving a single message. This avoids a crash when canceling
1889 (modest_mail_operation_notify_end): Do not explicitely remove the
1890 operation from the queue but only emit the progress_changed signal.
1891 The queue itself listens to that signal to remove the operation when
1892 it is finished. This reduces coupling and removes a potential deadlock
1893 when modest_mail_operation_notify_end() is called from the queue
1894 itself. If that is a problem performance-wise, I would suggest to
1895 implement a status-changed signal or something.
1897 * src/modest-mail-operation-queue.c: Make sure to never call a
1898 function from another file while the queue is locked. This (hopefully)
1899 fixes another deadlock when exiting the application while retrieving
1902 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1904 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1905 Fixed build if libogs is not available
1907 2007-06-03 Christian Kellner <ckellner@openismus.com>
1909 * libmodest-dbus-client/libmodest-dbus-client.h:
1910 * libmodest-dbus-client/libmodest-dbus-client.c:
1911 (libmodest_dbus_client_delete_message):
1912 Implement deletion of messages (Client side).
1914 (modest_search_hit_free),
1915 (modest_search_hit_list_free):
1916 Utility functions to free the result hits.
1918 * src/dbus_api/modest-dbus-api.h:
1919 * src/dbus_api/modest-dbus-callbacks.c:
1920 (on_delete_message),
1921 (modest_dbus_req_handler):
1922 Implement deletion of messages (Server side).
1924 * tests/dbus_api/test_search.c: (main):
1927 * tests/dbus_api/Makefile.am:
1928 * tests/dbus_api/test_delete_message:
1929 Add little test for the message deletion logic
1931 2007-06-03 Armin Burgmeier <armin@openismus.com>
1933 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1934 when the operation queue was not empty. projects.maemo.org bug
1937 2007-06-03 Armin Burgmeier <armin@openismus.com>
1939 * src/widgets/modest-account-view.c
1940 (on_account_default_toggled): Toggle default account column
1941 explicitely instead of waiting for gconf notification (which is
1942 currently ignored). This should fix projects.maemo.org bug NB#56910
1943 for now. It should probably be removed when gconf notifications are
1946 2007-06-03 Christian Kellner <ckellner@openismus.com>
1948 * libmodest-dbus-client/libmodest-dbus-client.c:
1949 Removed debugging spew.
1951 * src/dbus_api/modest-dbus-callbacks.c:
1952 Added debugging info.
1954 * src/modest-search.c:
1955 (modest_search_all_accounts):
1956 Use tny_account_store_get_accounts () on the account store
1957 to get all accounts which is the way to get all accounts.
1959 * tests/dbus_api/test_search.c: (main):
1960 Make it possible to supply the search term on the command line.
1962 2007-06-03 Christian Kellner <ckellner@openismus.com>
1964 * libmodest-dbus-client/libmodest-dbus-client.c:
1965 * libmodest-dbus-client/libmodest-dbus-client.h:
1966 Implement searching for mesages over raw dbus. (Client side)
1968 * src/dbus_api/Makefile.am:
1969 * src/dbus_api/modest-dbus-api.h:
1970 * src/dbus_api/modest-dbus-callbacks.c:
1971 * src/dbus_api/modest-dbus-callbacks.h:
1972 Search framework (Server side). Also implement on_idle_open_message().
1974 * src/maemo/modest-platform.c: (modest_platform_init):
1975 Prepare for raw dbus/osso rpc interaction.
1977 * src/modest-search.h:
1978 Changed minsize from unspecific guint to guint32.
1980 * src/modest-search.c:
1982 Added strange hack which magically made tnymail work.
1984 (modest_search_folder),
1985 (modest_search_account),
1986 (modest_search_all_accounts):
1987 Implement helper functions to search all accounts, specific account
1990 * tests/dbus_api/Makefile.am:
1991 * tests/dbus_api/test_open_message.c:
1992 Read url to open from commandline.
1994 * tests/dbus_api/test_search.c:
1995 Implement small test for dbus search stuff
1997 2007-06-02 Armin Burgmeier <armin@openismus.com>
1999 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2000 include account type and account title. This fixes projects.maemo.org
2003 * src/maemo/modest-account-view-window.c: Set a title for the window.
2005 2007-06-02 Armin Burgmeier <armin@openismus.com>
2007 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2008 incoming and outgoing server name based on email address and server
2009 types as long as the names have not been edited manually. This fixes
2010 projects.maemo.org bug NB#58671.
2012 2007-06-02 Armin Burgmeier <armin@openismus.com>
2014 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2015 server type cannot be changed in future to the incoming details page
2016 when creating an account. This fixes projects.maemo.org bug NB#59029.
2018 2007-06-02 Armin Burgmeier <armin@openismus.com>
2020 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2021 and assigned max width chars so that they wrap instead of being
2022 truncated. Fixes projects.maemo.org bug NB#56126.
2024 2007-06-02 Armin Burgmeier <armin@openismus.com>
2026 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2027 introductory note to the connection specific smtp servers dialog, as
2028 section 8.12 of the email UI specification requires. This fixes
2029 projects.maemo.org bug NB#59212.
2031 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2033 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2034 Check for running mail operations, and offer to cancel them, as per the UI
2035 spec. This fixes projects.maemo.org bug NB#59041 .
2036 However, I suspect that tinymail may still use the network connection
2037 in ways that we cannot detect or cancel. But it should at least adapt to
2038 changes fairly well.
2040 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2042 * src/modest-tny-account-store.c: (recreate_all_accounts),
2043 (get_cached_accounts), (get_server_accounts): Do more sensible
2044 ref-counting of the temporarily-cached outbox accounts list. This seems
2045 to fix a crash when entering the password when the password was wrong.
2047 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2049 * src/gnome/modest-main-window.c: (connect_signals):
2050 * src/modest-tny-account-store.c: (get_password),
2051 (modest_tny_account_store_alert): Added comments and clues and
2052 commented-out code about how we currently fail to deal with connection
2053 errors and wrong passwords, and how we should.
2055 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2057 * src/widgets/modest-retrieve-combo-box.c:
2058 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2059 This fixes projects.maemo.org bug NB#58472 .
2061 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2063 * src/maemo/easysetup/modest-easysetup-wizard.c:
2064 (create_page_complete_easysetup):
2065 (create_page_complete_custom): Correct the last commit,
2066 putting the correct sentences in the correct pages.
2068 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2070 * src/maemo/easysetup/modest-easysetup-wizard.c:
2071 (create_page_complete_custom): Show the second sentence of text
2072 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2075 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2077 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2078 Set the leave-on-server conf key by default. This fixes
2079 projects.maemo.org bug NB#59258 .
2081 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2083 * src/maemo/modest-account-view-window.c:
2084 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2085 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2088 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2090 * src/maemo/easysetup/modest-easysetup-wizard.c:
2091 (create_caption_new_with_asterisk):
2092 * src/maemo/modest-account-settings-dialog.c:
2093 (create_caption_new_with_asterisk):
2094 Uncomment the code to add the asterisk, because they are no longer in the
2095 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2096 (update_incoming_server_title): Add an asterisk here too.
2098 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2100 * src/maemo/modest-maemo-global-settings-dialog.c:
2101 (current_connection): Check that we are even connected before trying to
2102 get the current connection name, to prevent a warning.
2104 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2105 Change the comments because tny_maemo_conic_device_connect() is now meant to
2107 * src/modest-mail-operation.c:
2108 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2109 make sure we have a connection and fail if we can't connect.
2111 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2113 * src/maemo/modest-main-window.c:
2114 (on_account_store_connecting_finished): Do not try to get the
2115 connection ID if we are not really connected. I am surprised that
2116 this signal handler is called when we are not connected.
2118 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2120 * src/modest-error.h:
2121 * src/modest-ui-actions.c:
2122 (modest_ui_actions_get_msgs_full_error_handler):
2123 Renamed an enum, added comments, added an enum
2124 for retrieve-limit errors.
2126 * src/modest-mail-operation.c: (foreach_add_item),
2127 (internal_folder_observer_update), (update_account_thread),
2128 (modest_mail_operation_get_msgs_full):
2129 (modest_mail_operation_update_account),
2130 Added comments about how this works, and some code that should
2131 (but does not) check the retrieve-limit. See the TODO comment.
2133 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2135 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2136 Initialize help_id to fix the build. Warnings are good.
2138 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2140 * src/widgets/modest-hbox-cell-renderer.c:
2141 (modest_hbox_cell_renderer_append):
2142 * src/widgets/modest-vbox-cell-renderer.c:
2143 (modest_vbox_cell_renderer_append):
2144 Fix the last commit by doing an extra ref.
2146 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2148 * src/widgets/modest-hbox-cell-renderer.c:
2149 (modest_hbox_cell_renderer_append):
2150 * src/widgets/modest-vbox-cell-renderer.c:
2151 (modest_vbox_cell_renderer_append):
2152 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2153 to fix the build with Maemo Bora.
2154 However, there seems to be a remaining crash, probably due to reference
2157 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2159 * src/modest-tny-account.c:
2160 (modest_tny_account_new_for_local_folders):
2161 Use hildon_file_system_info_async_new() to get a better name for
2162 the memory card account, setting it as the account name.
2163 The timing seems to work, but this is probably
2164 not the best place to do this. See the TODO comment.
2165 * src/maemo/modest-main-window.c: (create_details_widget):
2166 * src/widgets/modest-folder-view.c: (text_cell_data):
2167 Use the tny account name instead of hardcoding a name.
2169 2007-05-30 Christian Kellner <ckellner@openismus.com>
2171 * src/modest-search.c: (modest_search):
2172 Correctly set part_search_func even if we have already parsed
2173 the query and thus a valid OgsTextSearcher object.
2175 2007-05-30 Christian Kellner <ckellner@openismus.com>
2178 Search and check for libogs.
2181 Incooparte the ogs build env.
2183 * src/modest-mime-part-search-stream.c:
2184 * src/modest-mime-part-search-stream.h:
2185 Removed since we do the real searching now in modest-search.c.
2187 * src/modest-search.c:
2188 * src/modest-search.h:
2189 Implement support for ogs. We use that if available and requested
2190 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2191 should now handle the corner case when the search term is spread
2192 across multiple reads.
2193 Also the logic in modest_search () was corrected to search all
2194 requested fields until one is found.
2196 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2198 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2200 * src/modest-init.h:
2201 * src/modest-init.c: Made modest_init_local_folders() take a
2202 path and be public so we can iniitialize maildir folders on
2205 * src/modest-local-folder-info.h:
2206 * src/modest-local-folder-info.c:
2207 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2209 * src/modest-tny-account.c:
2210 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2211 still means the standard local-folders path on the local volume.
2213 * src/modest-tny-account-store.c:
2214 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2215 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2216 all accounts when that happens.
2217 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2218 this too, so it shows up in the treeview.
2220 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2222 * src/maemo/modest-maemo-global-settings-dialog.c:
2223 (current_connection):
2224 * src/widgets/modest-global-settings-dialog.c:
2225 (current_connection_default):
2226 Use the enum values instead of 0, 1 and -1,
2227 to make the code clearer.
2229 * src/modest-account-mgr-helpers.c:
2230 (modest_account_mgr_get_connection_specific_smtp): Make this code
2233 * src/modest-runtime.h:
2234 * src/modest-runtime.c:
2235 Added modest_runtime_remove_all_send_queues().
2236 * src/maemo/modest-main-window.c:
2237 (on_account_store_connecting_finished): Recreate the send queues,
2238 using the appropriate transport accounts for this new connection.
2239 Some futher adapting might be needed if the old send queues are not
2240 automatically stopped at this point.
2242 * src/modest-tny-account-store.c: (get_server_accounts):
2243 Create the connection-specific transport accounts, so that they can
2244 be found later by their ID.
2246 * src/modest-tny-account.h:
2247 * src/modest-tny-account.c:
2248 Added modest_tny_account_new_from_server_account_name().
2249 modest_tny_account_new_from_server_account(): Do not create the
2250 send queues here, because they will be
2251 recreated anyway when the connection changes for the first time.
2253 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2255 * src/modest-local-folder-info.h:
2256 * src/modest-local-folder-info.c:
2257 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2258 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2259 tbox_folder): Take a modest account name instead of a server TnyAccount,
2260 so we can have per-modest-account rather than per-transport-account
2262 We must make sure that we change or recreate the exisitng send queues
2263 when the connection changes for connection-specific transport accounts.
2265 * src/modest-tny-account-store.c:
2266 (create_per_account_local_outbox_folders): Create outboxed per modest
2267 account, not per transport account.
2269 * src/modest-tny-account.h:
2270 * src/modest-tny-account.c:
2271 (modest_tny_account_get_special_folder): For outboxes, get the
2272 parent modest account name. The account is ignored for other folders.
2273 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2274 modest account name rather than a server TnyAccount.
2276 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2278 * src/modest-tny-account.c:
2279 (modest_tny_account_new_from_server_account):
2280 Call modest_runtime_get_send_queue() immediately after creating transport
2281 accounts, so that they start trying to send email from the outbox as soon
2282 as possible at startup. This is probably what we want.
2284 * src/modest-mail-operation.c: (update_account_thread):
2285 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2286 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2287 * src/modest-tny-send-queue.h:
2288 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2289 (modest_ui_actions_on_send):
2290 Added comments about how sending works, though it needs some more work.
2292 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2294 * src/modest-tny-account.c:
2295 (modest_tny_account_get_special_folder): Add TODO because this fails when
2296 the network is busy.
2297 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2298 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2299 Do not try to show this window when there is no active account. The UI
2300 specs does not tell us what to do in this case.
2302 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2306 * src/maemo/Makefile.am:
2307 * src/widgets/Makefile.am: Some dist fixes.
2309 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2311 * src/maemo/modest-connection-specific-smtp-window.c:
2312 (on_button_edit): Make the code clearer, to prevent a double free.
2314 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2316 * src/maemo/modest-account-settings-dialog.c:
2317 (modest_account_settings_dialog_set_account_name),
2318 Check the connection-specific smtp servers checkbox if there are any.
2320 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2321 (modest_connection_specific_smtp_edit_window_init):
2322 Start with a suitable port number.
2324 * src/modest-account-mgr-helpers.h:
2325 * src/modest-account-mgr-helpers.c: Added
2326 modest_account_mgr_get_has_connection_specific_smtp().
2328 (modest_account_mgr_set_connection_specific_smtp),
2329 (modest_account_mgr_remove_connection_specific_smtp),
2330 (modest_account_mgr_get_has_connection_specific_smtp),
2331 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2332 connection-specific smtp server accounts in the account, rather than
2333 the server account conf dir.
2335 This fixes bug projects.maemo.org bug NB#58263 .
2337 * src/modest-tny-account-store.c:
2338 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2339 if there are no server accounts yet, to prevent an infinite loop when there
2340 are no accounts. Document that one must be called before the other.
2342 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2344 * src/modest-account-mgr-helpers.c:
2345 (modest_account_mgr_get_default_account): Make sure that at least
2346 one account is always the default, if there are any enabled accounts.
2347 This is just a sanity check that shouldn't be necessary.
2349 * src/modest-account-mgr-priv.c:
2350 (_modest_account_mgr_account_from_key): Unescape the conf key to
2351 get the real account name. For instance, this is an issue if a space
2352 was in the account name, which can happen because the account name
2353 is generated from the display name.
2354 (_modest_account_mgr_get_account_keyname): Always escape the
2356 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2357 Unescape the conf keys to get the real account names.
2359 For instance, previously the is-default radio button in the accounts
2360 list was not checked for any accounts at first. This fixes that,
2361 and might fix several similar bugs.
2363 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2365 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2366 Removed some debug printfs.
2368 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2370 Modest on-disk outbox directories are now here, for instance:
2371 $HOME/.modest/outboxes/<account-id-1>/outbox
2372 $HOME/.modest/outboxes/<account-id-2>/outbox
2374 $HOME/.modest/local-folders/outbox
2375 so we can have a separate outbox for each account.
2376 But they are shown as one outbox in the GtkTreeView, by using a
2377 TnyMergeFolder in a ModestTnySimpleFolderStore.
2380 * src/modest-tny-simple-folder-store.c:
2381 * src/modest-tny-simple-folder-store.h:
2382 Added ModestTnySimpleFolderStore, used to contain folders from
2383 other folder stores, such as other accounts.
2385 * src/modest-tny-outbox-account.h:
2386 * src/modest-tny-outbox-account.c:
2387 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2388 used for the per-account local outbox folders.
2390 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2391 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2392 only use this (internally) now for the non-outbox local folders.
2394 * src/modest-init.h:
2395 * src/modest-init.c: Added modest_init_one_local_folder(), for
2396 setting up the directory structure for each local folder.
2398 * src/modest-local-folder-info.c:
2399 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2400 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2402 * src/modest-local-folder-info.h:
2403 * src/modest-tny-account-store.c: (on_account_removed),
2404 (on_account_changed), (create_per_account_local_outbox_folders),
2405 (get_server_accounts), (modest_tny_account_store_get_accounts),
2406 (modest_tny_account_store_get_tny_account_by_account),
2407 (modest_tny_folder_store_is_virtual_local_folders):
2409 * src/modest-tny-account.h:
2410 * src/modest-tny-account.c:
2411 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2412 to create an on-disk per-account local outbox folder for each
2414 (create_per_account_local_outbox_folders): Create a local outbox folder
2415 for each transport account.
2416 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2417 for all local folders.
2419 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2420 instead of using g_object_get/set() directly. It is clearer.
2422 (modest_tny_folder_store_get_message_count),
2423 (modest_tny_folder_store_get_local_size
2424 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2425 because we now use these with non-acount folder stores.
2427 (modest_tny_account_get_special_folder),
2428 (modest_tny_account_new_from_server_account),
2429 (modest_tny_account_new_from_account):
2430 (recurse_folders): Adjust to the new outbox system.
2432 * src/modest-tny-folder.h:
2433 * src/modest-tny-folder.c:
2434 (modest_tny_folder_is_local_folder),
2435 (modest_tny_folder_get_local_folder_type),
2436 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2438 * src/widgets/modest-main-window.h:
2439 * src/maemo/modest-main-window.c: (create_details_widget),
2440 (modest_main_window_set_contents_style): Show details for any folder store,
2443 (modest_tny_folder_get_rules):
2444 Remove the const. C does not support constness enough for this.
2446 * src/modest-ui-actions.c:
2447 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2448 make all outboxes appear as one, in the usual local-folders tree node.
2450 (set_active_account_from_tny_account),
2451 (modest_ui_actions_on_folder_selection_changed):
2452 * src/widgets/modest-folder-view.c: (text_cell_data),
2453 (icon_cell_data), (filter_row),
2454 (add_account_folders_to_merged_folder),
2455 (add_account_folders_to_simple_folder_store), (),
2456 (get_cmp_rows_type_pos), (cmp_rows),
2457 (modest_folder_view_set_account_id_of_visible_server_account):
2458 Adjust to the new outbox system, using generic folder stores and folders
2459 in the GtkTreeModel.
2461 2007-05-23 Christian Kellner <ckellner@openismus.com>
2463 * src/modest-mail-operation.c:
2464 (modest_mail_operation_update_account):
2465 Use info->max_size instead of unintialized local var [small
2466 build fix]. (Added TODO to review that change since I don't
2469 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2471 * libmodest-dbus-client/libmodest-dbus-client.c:
2472 (libmodest_dbus_client_compose_mail): function added
2473 * src/dbus_api/modest-dbus-api.h:
2474 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2475 (on_compose_mail): Implementation of the SendAsMail functionality
2477 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2479 * src/modest-account-mgr.c:
2480 (modest_account_mgr_add_server_account): Set the secure-connection
2481 conf key for transport accounts as well as store accounts. I don't know
2482 why the if was there. For instance, this makes sure that we use SSL
2483 for the gmail preset from the easysetup wizard.
2485 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2487 * src/gnome/modest-main-window.c:
2488 (on_account_store_connecting_finished), (connect_signals):
2489 * src/maemo/modest-main-window.c:
2490 (on_account_store_connecting_finished), (connect_signals),
2491 (modest_main_window_new):
2492 Handle TnyAccountStore::connecting-finished instead of
2493 TnyDevice::connection-changed, because we cannot actually perform
2494 operations on accounts until TnyAccountStore has itself responded to
2495 the TnyDevice::connection-changed signal. This prevents a GError from
2497 Do not try to update at startup, because we (at least on scratchbox)
2498 already do an update at startup when the device goes online.
2499 This prevents a GError from tinymail.
2500 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2501 Added TODO about stopping simultaneous operations.
2503 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2505 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2506 * src/modest-mail-operation-queue.c:
2507 (modest_mail_operation_queue_remove):
2508 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2509 about where they happened.
2511 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2513 * src/modest-ui-actions.c:
2514 (modest_ui_actions_on_password_requested): Make sure that the remember
2515 output parameter is always TRUE.
2517 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2519 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2520 Show a OK/Cancel dialog if the error is a question, though we still do not
2521 know anything more about what we are asking the user.
2522 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2523 Fix an uninitialized variable (helper). This is a logic error, however.
2525 2007-05-21 Christian Kellner <ckellner@openismus.com>
2527 * src/modest-search.h:
2528 Correct bit shifting in the ModestSearchFlags enum.
2530 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2532 * src/modest-tny-account.c:
2533 (modest_tny_account_new_from_server_account): Do not use the lsub and
2534 check-all hard-coded IMAP options when using POP.
2536 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2538 * src/modest-tny-account.c:
2539 (modest_tny_account_new_from_server_account):
2540 Use NULL for the secure-auth method for POP when Password auth has been
2541 specified by the user, as we already do for IMAP. "auth=Login" causes
2542 an error from camel or the server.
2544 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2546 * src/maemo/modest-account-settings-dialog.c:
2547 (create_page_account_details),
2548 (modest_account_settings_dialog_set_account_name):
2549 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2550 for the leave-on-server checkbox, rathr than just the checkbox, when
2551 the protocol is not POP.
2553 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2555 * src/widgets/modest-account-view.c:
2556 * src/widgets/modest-account-view.h:
2557 Added modest_account_view_select_account() which will be useful later
2558 to asynchronously re-select the edited account.
2560 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2562 * src/maemo/modest-account-settings-dialog.c:
2563 (modest_account_settings_dialog_set_account_name):
2564 Automatically choose the port numbers based on the secure authentication
2565 methods, if they have not been chosen before.
2566 This fixes projects.maemo.org bug NB#56273 .
2568 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2570 * src/maemo/modest-main-window-ui.h:
2571 * src/modest-ui-actions.c:
2572 * src/modest-ui-actions.h:
2573 Connect the Tools/SMTP Servers menu item to
2574 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2575 SMTP servers dialog, as in the UI specification and saves changes when it
2576 is closed. This fixed projects.maemo.org bug NB#56305 .
2578 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2580 * src/maemo/modest-connection-specific-smtp-window.c:
2581 (modest_connection_specific_smtp_window_init):
2582 Use gtk_window_set_default_size() to make this window big enough, so
2583 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2585 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2587 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2588 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2589 (modest_connection_specific_smtp_edit_window_init),
2590 Do not try to connect to a combobox signal before the combobox exists.
2591 This fixes the cras in projects.maemo.org bug NB#56288 .
2592 (modest_connection_specific_smtp_edit_window_get_settings):
2593 Remove the server_account_name parameter which was being checked for NULL
2594 though it was not used.
2596 * src/maemo/modest-connection-specific-smtp-window.c:
2597 (modest_connection_specific_smtp_window_fill_with_connections),
2598 (on_button_edit), (modest_connection_specific_smtp_window_init):
2599 Correct the number of treemodel columns to prevent a warning.
2600 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2601 libconic does not work.
2603 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2605 * src/modest-tny-account.c:
2606 (modest_tny_account_new_from_server_account):
2607 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2608 SMTP when "None" was chosen by the user. However, with my SMTP server that
2609 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2612 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2614 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2615 to explain the memory management issue with the ID in the ModestPair.
2617 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2618 (add_sending_page), (modest_account_assistant_finalize):
2619 * src/gnome/modest-gnome-global-settings-dialog.c:
2620 (create_updating_page), (create_composing_page):
2621 * src/gnome/modest-msg-edit-window.c: (get_transports),
2622 (init_window), (modest_msg_edit_window_finalize),
2623 (modest_msg_edit_window_get_msg_data):
2624 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2625 * src/gnome/modest-transport-widget.c:
2626 (modest_transport_widget_finalize), (smtp_configuration):
2627 * src/maemo/modest-maemo-global-settings-dialog.c:
2628 (create_updating_page), (create_composing_page):
2629 * src/maemo/modest-msg-edit-window.c: (get_transports),
2630 (init_window), (modest_msg_edit_window_finalize),
2631 (modest_msg_edit_window_get_msg_data),
2632 (modest_msg_edit_window_free_msg_data):
2633 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2634 (modest_store_widget_finalize):
2635 * src/maemo/modest-transport-widget.c:
2636 (modest_transport_widget_finalize), (smtp_configuration):
2637 * src/modest-main.c: (send_mail):
2638 * src/widgets/modest-combo-box.h:
2639 * src/widgets/modest-global-settings-dialog-priv.h:
2640 * src/widgets/modest-global-settings-dialog.c:
2641 (modest_global_settings_dialog_finalize):
2642 * src/widgets/modest-msg-edit-window.h:
2643 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2644 as long as the combo box, to prevent use of freed memory for the ID.
2646 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2648 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2649 get_accounts(), to make this clearer. Do not check for the enabled gconf
2650 key, because we do not use this for server accounts (at least, not yet).
2651 This allows us to send email again.
2653 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2655 * src/maemo/modest-platform.c:
2656 (on_modest_conf_update_interval_changed), (modest_platform_init):
2657 Only respond to this particular key change. All these strcmp()s cannot be
2660 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2662 * src/maemo/modest-maemo-global-settings-dialog.c:
2663 (current_connection): Prevent a crash in scratchbox when
2664 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2665 * src/maemo/modest-platform.c:
2666 (on_modest_conf_update_interval_changed), (modest_platform_init):
2667 Get the update interval from gconf and reset it when the gconf key changes.
2669 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2671 * src/modest-protocol-info.c:
2672 * src/modest-protocol-info.h: Adde enum-specific get functions,
2673 instead of using a ModestProtocolType enum parameter.
2675 * src/gnome/modest-account-assistant.c:
2676 * src/gnome/modest-store-widget.c:
2677 * src/gnome/modest-store-widget.h:
2678 * src/gnome/modest-transport-widget.c:
2679 * src/gnome/modest-transport-widget.h:
2680 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2681 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2682 * src/maemo/easysetup/modest-easysetup-wizard.c:
2683 * src/maemo/modest-account-settings-dialog.c:
2684 * src/maemo/modest-account-settings-dialog.h:
2685 * src/maemo/modest-store-widget.c:
2686 * src/maemo/modest-store-widget.h:
2687 * src/maemo/modest-transport-widget.c:
2688 * src/maemo/modest-transport-widget.h:
2689 * src/modest-account-mgr-helpers.c:
2690 * src/modest-account-mgr-helpers.h:
2691 * src/modest-account-mgr.c:
2692 * src/modest-account-mgr.h:
2693 * src/modest-tny-account.c:
2694 * src/modest-tny-folder.c:
2695 * src/widgets/modest-account-view.c:
2696 * src/widgets/modest-retrieve-combo-box.c:
2697 * src/widgets/modest-retrieve-combo-box.h:
2698 * src/widgets/modest-secureauth-combo-box.c:
2699 * src/widgets/modest-serversecurity-combo-box.c:
2700 * src/widgets/modest-serversecurity-combo-box.h:
2701 * tests/check_account-mgr.c:
2702 Use the specific functions, and use the re-renamed enum values for GNOME too.
2704 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2706 * src/modest-pair.h:
2707 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2708 so we can get the second based on the first.
2710 * src/maemo/modest-account-settings-dialog.h:
2711 * src/maemo/modest-account-settings-dialog.c:
2712 Added get_supported_secure_authentication_methods(), though it is mostly
2713 commented-out for now until the necessary API is committed to tinymail.
2714 (modest_account_settings_dialog_set_account_name),
2715 (save_configuration): Request the supported authentication methods from the
2716 server, so we can choose a working method.
2718 * src/modest-tny-account-store.h:
2719 * src/modest-tny-account-store.c:
2720 (modest_tny_account_store_get_session): Rename from
2721 tny_account_store_get_session().
2723 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2725 * src/modest-protocol-info.h: Split the ModestProtocol enum
2726 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2727 There was no need to have these unrelated values in one enum.
2729 * src/: many files: Adapted to changed enum. This makes the code a bit
2730 clearer, and the compiler could catch some errors.
2732 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2734 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2735 Show the detailed internal camel error message when an error happens
2736 during the configuration, so that our testers can give us more clues.
2737 For instance, in projects.maemo.org bug NB#56910 .
2739 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2741 * src/modest-tny-account.c:
2742 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2743 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2745 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2747 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2748 * src/maemo/modest-account-settings-dialog.c:
2749 (modest_account_settings_dialog_set_account_name),
2750 (save_configuration): For the incoming secure authentication checkbox,
2751 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2752 the UI specification. PLAIN does not seem to be supported for most IMAP
2753 servers anyway, and I am not sure what it would mean.
2754 However, we probably need to discover which of the secure-authentication
2755 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2756 * src/modest-account-mgr-helpers.c:
2757 (modest_account_mgr_get_server_account_data):
2759 * src/modest-tny-account.c:
2760 (modest_tny_account_new_from_server_account):
2761 Use tny_account_set_mech() to set secure-authentication methods,
2762 with some special-casing for IMAP, based on my observations of how
2765 * src/modest-account-mgr-helpers.h:
2766 * src/modest-account-mgr.c:
2767 * src/modest-defs.h: Comment that the URI is only used for local folders.
2769 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2771 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2772 parameter const, just to be neat.
2773 * src/modest-text-utils.c: (modest_text_utils_inline):
2774 End g_strconcat() with NULL, as its documentation says. This is almost
2775 certainly the cause of my crash at startup on the device. Interestingly,
2776 valgrind doesn't tell us about these errors.
2778 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2780 * scripts/build-packages: Added more precise comments about how to use
2781 this script, though I still get this error:
2782 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2783 error building tinymail
2785 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2787 * src/maemo/modest-main-window.c: (on_account_update):
2788 Very slight cleanup, hoping to make it simpler to discover what causes
2789 a crash here sometimes.
2791 * src/modest-tny-account.c:
2792 (modest_tny_account_new_from_server_account): Set the port. Added
2793 comments about the options and a TODO comment because I need to find out
2794 how to specify the secure authentication method.
2796 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2798 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2799 changed CFlags paths form modest to libmodest
2801 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2803 * src/modest-account-mgr-helpers.c:
2804 (modest_account_mgr_get_server_account_data),
2805 (modest_account_mgr_free_server_account_data):
2806 * src/modest-account-mgr-helpers.h:
2807 * src/modest-account-mgr.c:
2808 (modest_account_mgr_add_server_account):
2809 * src/modest-defs.h:
2810 * src/modest-tny-account.c:
2811 (modest_tny_account_new_from_server_account):
2812 Determine the options for tny_camel_account_add_option() here,
2813 based on the settings, rather than storing them directly in gconf.
2815 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2817 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2818 Show a more friendly error dialog now that we expect (from the tinymail
2819 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2821 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2823 * src/maemo/modest-main-window.c: (on_account_update): Check that
2824 account_name is not NULL, to prevent a crash at startup that I am
2825 seeing on the N800. I do wonder why it is NULL.
2827 * src/maemo/easysetup/modest-easysetup-wizard.c:
2828 (create_page_user_details):
2829 * src/maemo/modest-account-settings-dialog.c:
2830 (create_page_user_details), (create_page_outgoing):
2831 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2832 (modest_connection_specific_smtp_edit_window_init):
2833 * src/modest-ui-actions.c:
2834 (modest_ui_actions_on_password_requested):
2835 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2836 might do something useful with the on-screen keyboard.
2838 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2840 * src/maemo/modest-main-window.c: (on_account_update):
2841 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2842 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2844 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2846 * src/modest-tny-account-store.c: (on_account_changed):
2847 Correct the signature of this signal handler.
2849 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2851 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2852 Show a HildonNote instead of a GtkDialog for Maemo.
2854 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2856 * src/widgets/modest-account-view.h:
2857 * src/widgets/modest-account-view.c: (on_account_changed),
2858 (on_account_removed). Added a boolean flag, set/unset by
2859 modest_account_view_block_conf_updates(),
2860 modest_account_view_unblock_conf_updates() to prevent unnecessary
2861 updates, but this is not very useful because the gconf notifications are
2862 so delays (maybe only on Maemo Bora).
2863 So auto-updating is turned off, and these functions do an explicit
2864 update when necessary.
2865 However, something else is still doing too much work when adding/removing
2866 accounts, probably in another part of the application.
2868 * src/maemo/modest-account-view-window.c:
2869 (on_delete_button_clicked), (on_edit_button_clicked),
2870 (on_new_button_clicked): Use the new functions.
2872 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2874 * src/modest-account-mgr-helpers.c:
2875 (modest_account_mgr_set_first_account_as_default):
2876 Sort the list of names alphabetically-by-title, so we choose the first one
2878 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2879 alphabetically by the title.
2881 This fixes projects.maemo.org bug NB#56418 .
2883 * src/modest-account-mgr-priv.c:
2884 (_modest_account_mgr_account_from_key):
2885 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2886 avoid a valgrind error, and possible random behaviour.
2888 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2890 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2891 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2892 tinymail documentation to say that this can be expected.
2893 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2894 pretty, and should not happen, but I would prefer to know when it does.
2896 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2898 * configure.ac: When using the older hildon version, probably on Bora,
2899 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2901 * src/widgets/modest-attachment-view.c:
2902 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2905 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2907 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2908 Implemented the prototype. Can be tested with
2909 tests/dbus_api/test_open_message:
2911 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2913 * src/modest-tny-account-store.c:
2914 (modest_tny_account_store_instance_init), (get_password):
2915 * src/modest-ui-actions.c:
2916 (modest_ui_actions_on_password_requested):
2917 Do not store the password in gconf, because this function is called
2918 for non-remembered passwords. Actually use the cached (in the hash map)
2919 password instead of releasing it.
2920 The password will now not be remembered if it is asked via the protected
2921 password dialog, as per the UI spec.
2923 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2925 * src/modest-defs.h:
2926 * src/modest-account-mgr-helpers.h:
2927 * src/modest-account-mgr-helpers.c:
2928 Added modest_server_account_get_username_has_succeeded(),
2929 modest_server_account_set_username_has_succeeded().
2930 (modest_server_account_set_username),
2931 Reset the has-succeeded flag if the username changes.
2933 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2934 * src/maemo/modest-connection-specific-smtp-window.c:
2935 (modest_connection_specific_smtp_window_save_server_accounts):
2936 Use modest_server_account_set_username() instead of using
2937 modest_conf_set_string() directly, so that the has-succeeded flag is always
2940 * src/modest-ui-actions.c:
2941 (modest_ui_actions_on_password_requested): Dim the username entry if
2942 the username has ever worked, as per the UI spec.
2944 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2946 * src/modest-tny-account-store.c: (get_password):
2947 * src/modest-ui-actions.c:
2948 (modest_ui_actions_on_password_requested):
2949 Allow the username to be changed too, though there is more work to
2950 be done on exactly how this behaves.
2952 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2954 * src/modest-account-mgr-helpers.h:
2955 * src/modest-account-mgr-helpers.c:
2956 Added modest_account_mgr_get_display_name(),
2957 modest_server_account_get_username(),
2958 modest_server_account_set_username(),
2959 modest_server_account_set_password(),
2960 modest_server_account_get_hostname() functions so we do not need to
2961 use the conf API directly.
2963 * src/maemo/modest-main-window.c: (connect_signals):
2964 Actually connect ot the ModestAccountStore::request-password signal,
2965 so that we show the dialog when the password is requested by Tinymail,
2966 for isntance if it is empty.
2968 * src/modest-marshal.list:
2969 * src/modest-tny-account-store.c:
2970 (modest_tny_account_store_class_init), (get_password),
2971 (modest_tny_account_store_alert):
2972 * src/modest-tny-account-store.h:
2973 * src/modest-ui-actions.h:
2974 * src/modest-ui-actions.c:
2975 (modest_ui_actions_on_password_requested):
2976 Change the signal parameters, so it is obvious that we are providing
2977 the non human-readable server name, and receiving both the username
2978 and password, though changing of the username is not yet implemented.
2979 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2980 for the GNOME version.
2982 This should fix the projects.maemo.org bug NB#56209, though it does not
2983 work on Bora, because the gconf_client_get() for the password fails
2984 immediately after we save it with gconf_client_set().
2986 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2989 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2990 caused an undefined symbol error:
2991 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2993 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2995 * src/modest-tny-account-store.c:
2996 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2997 using a GError instead of a string message, so we can translate it in
3000 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3002 * src/maemo/modest-address-book.c:
3003 (modest_address_book_check_names):
3004 * src/maemo/modest-msg-view-window.c:
3005 (modest_msg_view_window_clipboard_owner_change):
3006 * src/modest-init.c: (modest_init_init_ui):
3007 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3008 (update_folders_cb), (modest_mail_operation_update_account):
3009 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3010 (modest_ui_actions_on_msg_attachment_clicked),
3011 (modest_ui_actions_on_msg_recpt_activated):
3012 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3013 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3014 (modest_msg_view_search_next):
3015 * src/widgets/modest-recpt-editor.c:
3016 (modest_recpt_editor_on_button_release_event),
3017 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3018 g_message(). At this point we should only be seeing interesting errors on
3019 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3021 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3023 (modest_wizard_dialog_force_title_update):
3024 * src/maemo/easysetup/modest-wizard-dialog.h:
3025 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3026 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3027 can update the title when appropriate. Otherwise the title is wrong if the
3028 pages are added after adding the notebook to the dialog.
3029 This must be a problem in HildonWizardDialog too.
3030 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3032 * src/maemo/easysetup/modest-easysetup-wizard.c:
3033 (create_subsequent_customsetup_pages),
3034 (create_subsequent_easysetup_pages):
3035 Call modest_wizard_dialog_force_title_update() so that the title is
3036 correct even with GTK+ < 2.10.
3037 This fixes projects.maemo.org bug NB#56145 .
3039 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3041 * src/maemo/modest-platform.c:
3042 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3043 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3046 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3048 * src/widgets/modest-window.h:
3049 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3050 and modest_window_save_state(), which invokes it.
3052 * src/widgets/modest-window-mgr.h:
3053 * src/widgets/modest-window-mgr.c:
3054 Added modest_window_mgr_save_state_for_all_windows(), which calls
3055 the save_state vfunc on all registered windows, if implemented.
3057 * src/gnome/modest-msg-edit-window.c:
3058 * src/gnome/modest-msg-view-window.c:
3059 * src/maemo/modest-msg-edit-window.c:
3060 * src/maemo/modest-msg-view-window.c:
3061 * src/maemo/modest-main-window.c:
3062 Specify the existing save_settings functions as implementations of
3063 ModestWindow::save_state_func().
3065 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3066 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3067 enabling hibernation, for instance.
3069 We may need to do the same thing for restoring settings.
3072 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3074 * src/widgets/modest-window-mgr.c:
3075 * src/widgets/modest-window-mgr.h:
3076 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3077 modest_window_mgr_get_hibernation_is_prevented().
3079 * src/maemo/modest-main-window.c:
3080 (on_hildon_program_is_topmost_notify): Prevent hibernation
3081 (possible when the application goes to the background in the WM),
3082 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3084 * src/maemo/easysetup/modest-easysetup-wizard.c:
3085 (modest_easysetup_wizard_dialog_init):
3086 * src/maemo/modest-account-settings-dialog.c:
3087 (modest_account_settings_dialog_init):
3088 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3089 (modest_connection_specific_smtp_edit_window_init):
3090 * src/maemo/modest-connection-specific-smtp-window.c:
3091 (modest_connection_specific_smtp_window_init):
3092 * src/maemo/modest-signature-editor-dialog.c:
3093 (modest_signature_editor_dialog_init):
3094 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3095 prevent hibernation while any of these account settings dialogs are open.
3097 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3099 * src/maemo/Makefile.am:
3100 * src/maemo/modest-osso-state-saving.c:
3101 * src/maemo/modest-osso-state-saving.h: Added
3102 modest_osso_load_state() and modest_osso_save_state() though they do
3103 nothing now. They should iterate through all the open windows and load/save
3105 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3106 save state when closing.
3108 * src/maemo/modest-main-window.c:
3109 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3110 Add a notification handler for the HildonProgram::is-topmost property,
3111 so we can allow hibernation when the application goes into the background.
3112 But we still need to detect when the accounts setup windows are open so
3113 we can stop hibernation when they are open.
3114 To do this, I also added the main window the HildonProgram. This might have
3115 other side-effects/benefits, and should maybe be done for other windows.
3117 * src/maemo/modest-osso-autosave-callbacks.h:
3118 * src/maemo/modest-osso-autosave-callbacks.c:
3119 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3120 though it does not do anything yet, and we might never need this to do
3121 anything. For instance, we already save drafts.
3123 * src/maemo/modest-platform.c: (modest_platform_init):
3124 Specify the libosso auto-save callback.
3126 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3128 * src/maemo/modest-platform.c:
3129 (modest_platform_set_update_interval):
3130 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3131 aparently stays valid between application instances, so we can use this
3132 to remove and reset it later. According to a maemo-developers email from
3135 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3137 * configure.ac: Depend on libalarm for Maemo.
3139 * src/dbus_api/modest-dbus-api.h:
3140 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3141 (on_send_receive), (modest_dbus_req_handler):
3142 Handle a SEND_RECEIVE D-Bus method.
3144 * libmodest-dbus-client/libmodest-dbus-client.c:
3145 (libmodest_dbus_client_send_and_receive):
3146 * libmodest-dbus-client/libmodest-dbus-client.h:
3147 Add C convenience functions for calling the new D-Bus method.
3149 * src/modest-platform.h:
3150 * src/gnome/modest-platform.c:
3151 * src/maemo/modest-platform.c:
3152 Added modest_platform_set_update_interval(), which uses the
3153 alarmd API on Maemo.
3154 (modest_platform_init),
3155 Call modest_platform_set_update_interval(), using a hard-coded
3156 interval for now (until the global settings dialog is implemented),
3157 though I am not sure that this makes sense yet.
3159 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3161 * src/dbus_api/modest-dbus-callbacks.c:
3162 (modest_osso_cb_hw_state_handler):
3163 * src/dbus_api/modest-dbus-callbacks.h:
3164 * src/maemo/modest-platform.c: (modest_platform_init):
3165 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3166 in case this has some effect on the ability for Maemo to ping the
3169 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3171 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3172 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3173 warning. It is probably a logic error, but I need to fix the build.
3175 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3177 * src/modest-account-mgr.h:
3178 * src/modest-account-mgr.c:
3179 (modest_account_mgr_account_names): Add a gboolean enabled_only
3180 parameter, so we can get lists of onlt the enabled accounts.
3182 (modest_account_mgr_add_account),,
3183 (modest_account_mgr_account_with_display_name_exists):
3184 * src/maemo/modest-msg-edit-window.c: (get_transports):
3185 * src/modest-account-mgr-helpers.c:
3186 (modest_account_mgr_set_first_account_as_default):
3187 * src/modest-init.c: (init_default_account_maybe):
3188 * src/modest-tny-account-store.c: (get_accounts):
3189 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3190 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3191 * tests/check_account-mgr.c: (START_TEST):
3192 Provide the extra parameter, as appropriate.
3194 * src/widgets/modest-account-view.c: (update_account_view):
3195 Do not show disabled accounts (meaning that there is no way to
3196 enable/disable accounts in the UI (the feature is not in our UI
3197 specification), so we can use this internally only to mark unfinished
3198 or temporary account data.
3200 * src/maemo/easysetup/modest-easysetup-wizard.c:
3201 (create_account): Add boolean enable parameter, so we can specify FALSE
3202 to create the temporary account.
3203 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3204 (on_before_next): When finishing, when there is a temporary account, just
3206 Also, use a timeout to delay the showing of the dialog until gconf is likely
3207 to return correct information, due to a maemo gconf bug that is fixed in
3208 osso 1.1, but not yet in Bora.
3209 However, the dialog stays on screen after it is destroyed.
3211 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3212 for invalid data when cancelling. Use a hildon note instead of a dialog
3213 to complain about invalid data. Do not show the account-saved note if the
3214 account is disabled (a temporary account that will not really be saved for use
3217 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3219 * src/modest-account-mgr-helpers.h:
3220 * src/modest-account-mgr-helpers.c:
3221 Added modest_account_mgr_unset_default_account(),
3222 Added modest_account_mgr_set_first_account_as_default().
3224 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3225 If it was the default account, unset the default account name.
3227 * src/maemo/modest-account-view-window.c:
3228 (on_delete_button_clicked): If it was the default account,
3229 set the first remaining account as the default instead.
3231 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3232 a NULL account or a NULL default account, to prevent a crash. This should
3233 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3236 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3238 * src/widgets/modest-recpt-editor.c:
3239 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3240 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3241 TODO comment for this. This fixes the build.
3243 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3244 be the best place for it. This will in future update all auto-update accounts,
3245 rather than just the current/default account, when that gconf key exists.
3246 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3247 if there are no accounts, before calling do_send_receive().
3248 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3250 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3251 * src/maemo/modest-main-window-ui.h:
3252 * src/maemo/modest-main-window.c: (on_connection_changed),
3253 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3254 directly, becaue the signal handler does more.
3256 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3258 * src/modest-account-mgr-helpers.c:
3259 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3260 for the case that the account does not exist.
3262 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3263 (equivalent to the modest account name) rather than the tinymail account name
3264 (equivalent to the modest account title - human readable) to get the account data.
3265 Check for null account data to prevent the crash, and add a TODO comment saying that
3266 this needs fixing because it is using the server account name instead of the account name.
3268 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3270 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3271 * src/maemo/modest-account-settings-dialog.c: (show_error),
3273 Use hildon_note_new_information() for informative and error messages,
3274 which seems to be expected for Maemo applications (no documentation that I know of
3275 says this). I am surprised that there is no distinction between info and error
3278 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3280 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3281 it is easy to find where this is used.
3283 * src/maemo/easysetup/modest-easysetup-wizard.c:
3284 (create_page_welcome), (create_page_account_details),
3285 (create_page_user_details), (create_page_complete_easysetup),
3286 (create_page_custom_incoming), (create_page_custom_outgoing),
3287 (create_page_complete_custom):
3288 * src/maemo/modest-account-settings-dialog.c:
3289 (create_page_account_details), (create_page_user_details),
3290 (create_page_incoming), (create_page_outgoing):
3291 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3292 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3293 (modest_connection_specific_smtp_edit_window_init):
3294 * src/maemo/modest-connection-specific-smtp-window.c:
3295 (modest_connection_specific_smtp_window_init):
3296 * src/maemo/modest-signature-editor-dialog.c:
3297 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3298 and scrolling policy as per the Email Application Layout Guide, if I have
3301 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3303 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3304 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3305 which were empty, because these vfuncs have been removed from TnyAccountStore.
3306 This fixes the build.
3308 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3310 * src/maemo/modest-main-window.c:
3311 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3312 showing/hiding it. Added TODO because it probably should not be NULL.
3313 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3314 because unnecessary g_warnings() make degugging difficult.
3316 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3318 * src/maemo/modest-msg-edit-window.c:
3319 (modest_msg_edit_window_select_color),
3320 (modest_msg_edit_window_select_background_color): 2 const corrections and
3321 moving 2 #endifs before closing brackets, to fix the build.
3323 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3325 * src/maemo/easysetup/modest-easysetup-wizard.h:
3326 * src/maemo/easysetup/modest-easysetup-wizard.c:
3327 (modest_easysetup_wizard_dialog_finalize),
3328 (on_button_edit_advanced_settings), (create_page_complete_custom),
3329 (on_response), (create_account):
3330 Implement the Advanced Settings edit button, by saving the account information,
3331 for the Advanded Settings dialog to use directly from gconf, and removing it
3332 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3333 Bug #5533 in the projects.maemo.org bugzilla.
3335 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3337 * src/maemo/modest-msg-view-window.c:
3338 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3339 when opening a message window.
3341 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3343 * src/maemo/easysetup/modest-easysetup-wizard.c:
3344 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3347 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3348 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3349 gconf settings. I probably added more checks than necessary, but that is safer.
3351 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3352 variable to fix the build, but this seems to be used when it is still NULL.
3354 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3356 * src/modest-platform.h:
3357 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3358 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3359 * src/modest-main.c: Implement this function so we can avoid using
3360 maemo-specific API from cross-platform code.
3362 * src/modest-tny-account-store.c:
3363 (get_smtp_specific_transport_account_for_open_connection):
3364 * src/modest-ui-actions.c: (check_for_connection),
3365 (modest_ui_actions_on_item_not_found):
3366 Use modest_platform_connect_and_wait() and put #idefs around other
3367 maemo-specific code, because only maemo currently has a way to
3368 identify connection names.
3370 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3372 * src/modest-tny-account-store.h:
3373 * src/modest-tny-account-store.c:
3374 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3375 the connection-specific SMTP server settings in the configuration.
3377 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3379 * src/maemo/modest-main-window.c: (on_connection_changed),
3381 * src/modest-main.c: (main), (start_ui), (send_mail):
3382 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3383 that is what is intended.
3385 * src/modest-ui-actions.c: (action_send), (action_receive),
3386 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3387 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3388 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3389 SMTP server is used when it is specified.
3391 (modest_ui_actions_on_send_receive):
3392 Check that a connection is open before proceeding.
3393 Receive and then send, instead of vice-versa, as per the specification.
3395 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3397 * src/modest-mail-operation.c:
3398 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3399 though I guess it should be something other than NULL.
3401 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3403 * src/maemo/easysetup/modest-easysetup-wizard.c:
3404 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3405 combo twice, to avoid an g_warning and to make it visible again.
3406 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3407 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3408 (already intended) dereference when detaching, because we then recreate the menu.
3409 But I am not sure why the warning was happening, and it is possible that this is a memory
3412 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3414 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3415 and uri_parse_mailto() utility functions.
3416 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3418 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3420 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3422 * src/dbus_api/modest-dbus-api.h:
3423 * src/dbus_api/modest-dbus-callbacks.c:
3424 Use an idle callback to execute the modest code in the application's own thread.
3425 Remove the helloworld example method.
3426 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3427 parsed, and the open-message method is not implemented because this is not yet implemented in
3429 * libmodest-dbus-client/libmodest-dbus-client.c:
3430 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3431 (libmodest_dbus_client_open_message):
3432 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3434 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3435 body without crashing.
3437 * tests/dbus_api/Makefile.am:
3438 * tests/dbus_api/test_mail_to.c:
3439 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3441 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3443 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3444 Added file to fix the build. Sorry.
3446 * src/dbus_api/Makefile.am:
3447 * src/dbus_api/modest-dbus-api.h:
3448 * src/dbus_api/modest-dbus-callbacks.h:
3449 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3450 (modest_dbus_req_handler):
3451 Put constants in a separate header so it can be reused by the
3452 client library, without duplication
3454 * libmodest-dbus-client/Makefile.am:
3455 * libmodest-dbus-client/libmodest-dbus-client.c:
3456 (libmodest_dbus_client_call_helloworld),
3457 (libmodfest_dbus_client_send_mail),
3458 (libmodfest_dbus_client_mailto),
3459 (libmodfest_dbus_client_open_message):
3460 * libmodest-dbus-client/libmodest-dbus-client.h:
3461 (Partly) Implement a send_mail D-Bus method.
3463 * tests/dbus_api/Makefile.am:
3464 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3465 the send_email D-Bus method.
3467 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3471 * libmodest-dbus-client/Makefile.am:
3472 * libmodest-dbus-client/libmodest-dbus-client.c:
3473 * libmodest-dbus-client/libmodest-dbus-client.h:
3474 * tests/dbus_api/Makefile.am:
3475 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3476 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3478 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3480 * src/maemo/easysetup/modest-easysetup-wizard.c:
3481 (create_page_account_details):
3482 * src/maemo/modest-account-settings-dialog.c:
3483 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3484 widgets, because this might not be the default in future versions of the Maemo GTK+.
3485 However, I can not not get capitalization to work even in a simple test case.
3487 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3489 * src/maemo/easysetup/modest-easysetup-wizard.c:
3490 (create_page_custom_incoming), (create_page_custom_outgoing):
3491 * src/maemo/modest-account-settings-dialog.c:
3492 (create_page_account_details), (create_page_incoming),
3493 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3494 instead of using gtk_check_button_with_label(), so they are aligned like the other
3495 widgets, as per the UI spec.
3497 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3499 * src/maemo/easysetup/modest-easysetup-wizard.c:
3500 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3501 * src/widgets/modest-validating-entry.c:
3502 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3503 Modest prefix instead of an EasySetup prefix.
3505 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3507 * src/widgets/modest-validating-entry.h:
3508 * src/widgets/modest-validating-entry.c: (on_insert_text),
3509 Added easysetup_validating_entry_set_max_func(), used to set a callback
3510 to call when the max number of characters is reached. GtkEntry has a max-length
3511 already but is silent about it.
3513 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3514 (create_page_account_details), (create_page_user_details),
3516 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3517 (create_page_account_details), (create_page_user_details),
3518 (create_page_outgoing):
3519 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3520 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3521 the UI spec, when the user tries to enter more than the max number of characters.
3523 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3525 * src/maemo/easysetup/modest-easysetup-wizard.c:
3526 (create_page_user_details), (create_page_custom_incoming),
3527 (create_page_custom_outgoing):
3528 * src/maemo/modest-account-settings-dialog.c:
3529 (create_page_user_details), (create_page_incoming),
3530 (create_page_outgoing):
3531 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3532 (modest_connection_specific_smtp_edit_window_init):
3533 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3534 not appropriate. Bad Maemo-specific defaults!.
3536 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3538 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3539 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3540 (modest_signature_editor_dialog_set_settings):
3541 Disable the label and textview when the checkbox is disabled, and use the
3542 specified (UI spec) default signature text.
3544 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3546 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3547 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3549 * src/modest-defs.h:
3550 * src/modest-account-mgr-helpers.h:
3551 * src/modest-account-mgr-helpers.c:
3552 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3554 * src/maemo/Makefile.am:
3555 * src/maemo/modest-signature-editor-dialog.c:
3556 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3559 * src/maemo/modest-account-settings-dialog.h:
3560 * src/maemo/modest-account-settings-dialog.c:
3561 (modest_account_settings_dialog_finalize), (on_button_signature),
3562 (save_configuration): Use the new dialog when the Edit button is pressed, and
3563 save the changes if necessary, as per the UI spec.
3565 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3567 * src/maemo/Makefile.am:
3568 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3569 based on maemo-develoers email from Dirk.
3571 * src/maemo/easysetup/modest-easysetup-wizard.c:
3572 (create_page_welcome), (create_page_account_details),
3573 (create_page_user_details), (create_page_complete_easysetup),
3574 (create_page_custom_incoming), (create_page_custom_outgoing),
3575 (create_page_complete_custom),
3576 (modest_easysetup_wizard_dialog_init):
3577 * src/maemo/modest-account-settings-dialog.c:
3578 (create_page_account_details), (create_page_user_details),
3579 (create_page_incoming), (create_page_outgoing),
3580 (modest_account_settings_dialog_init):
3581 * src/maemo/modest-connection-specific-smtp-window.c:
3582 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3584 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3586 * src/maemo/easysetup/modest-easysetup-wizard.c:
3587 (create_page_account_details), (create_page_custom_outgoing),
3588 (create_page_complete_custom):
3589 * src/maemo/modest-account-settings-dialog.c:
3590 (create_page_user_details), (create_page_incoming),
3591 (create_page_outgoing):
3592 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3593 (modest_connection_specific_smtp_edit_window_init):
3594 Use the correct (UI spec) port min/max, and use horizontal separators,
3597 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3599 * src/maemo/easysetup/modest-easysetup-wizard.c:
3600 (set_default_custom_servernames):
3601 * src/maemo/modest-account-settings-dialog.c:
3602 (create_page_incoming), (on_combo_outgoing_security_changed),
3603 (on_combo_incoming_security_changed), (create_page_outgoing),
3604 (modest_account_settings_dialog_set_account_name),
3605 (save_configuration):
3606 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3607 (on_combo_security_changed),
3608 (modest_connection_specific_smtp_edit_window_init),
3609 (modest_connection_specific_smtp_edit_window_set_connection),
3610 (modest_connection_specific_smtp_edit_window_get_settings):
3611 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3614 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3617 * src/maemo/easysetup/modest-easysetup-wizard.c:
3618 (create_page_custom_outgoing), (create_page_complete_custom):
3619 * src/maemo/modest-account-settings-dialog.c:
3620 (create_page_user_details), (create_page_outgoing):
3621 * src/maemo/modest-account-view-window.c: (button_box_new):
3622 Use changed logical IDs as per the most recent UI spec:
3623 mcen_bd_emailsetup_edit -> mcen_bd_edit
3624 mcen_bd_emailsetup_delete -> mcen_bd_delete
3625 mcen_bd_emailsetup_close -> mcen_bd_close
3627 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3631 * src/dbus_api/Makefile.am:
3632 * src/dbus_api/modest-dbus-callbacks.c:
3633 * src/dbus_api/modest-dbus-callbacks.h:
3634 * src/maemo/modest-platform.c: (modest_platform_init):
3635 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3637 * tests/Makefile.am:
3638 * tests/dbus_api/Makefile.am:
3639 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3641 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3643 * src/maemo/modest-account-settings-dialog.c:
3644 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3645 Removed unnecessary includes.
3647 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3649 * src/maemo/easysetup/modest-easysetup-wizard.c:
3650 * src/maemo/modest-account-settings-dialog.c:
3651 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3652 * src/widgets/Makefile.am:
3653 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3654 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3655 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3656 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3657 * src/widgets/modest-secureauth-combo-box.c:
3658 * src/widgets/modest-secureauth-combo-box.h:
3659 * src/widgets/modest-serversecurity-combo-box.c:
3660 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3661 made the GObject names more consistent with the rest of the Modest code.
3663 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3665 * src/maemo/easysetup/Makefile.am:
3666 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3667 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3668 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3669 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3670 * src/maemo/easysetup/modest-easysetup-wizard.c:
3671 * src/maemo/easysetup/modest-validating-entry.c:
3672 * src/maemo/easysetup/modest-validating-entry.h:
3673 * src/maemo/modest-account-settings-dialog.c:
3674 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3675 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3676 widgets/ because they are used outside of easysetup too. After checking in,
3677 svn will allow me to rename them too.
3679 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3681 * src/gnome/modest-msg-edit-window.c:
3682 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3683 linker error, to fix the build on the GNOME platform.
3684 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3685 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3686 ifdefed out to avoid a warning.
3688 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3690 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3691 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3692 some alternative for GTK+ 2.6.
3694 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3696 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3698 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3699 specified for EmailAccountsDialog in UI spec.
3701 * src/maemo/easysetup/modest-easysetup-wizard.c:
3702 * src/maemo/easysetup/modest-easysetup-wizard.h:
3703 * src/maemo/modest-account-settings-dialog.c:
3704 * src/maemo/modest-account-settings-dialog.h:
3705 Reuse a member window widget for the connection-specific SMTP server accounts,
3706 so we can tell it to create/save the accounts only if we actually save changes.
3708 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3709 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3710 (modest_connection_specific_smtp_edit_window_get_settings):
3711 Return a struct instance for temporarily remembering the entered data.
3713 * src/maemo/modest-connection-specific-smtp-window.h:
3714 * src/maemo/modest-connection-specific-smtp-window.c:
3715 (modest_connection_specific_smtp_window_finalize),
3716 (modest_connection_specific_smtp_window_fill_with_connections),
3718 (modest_connection_specific_smtp_window_save_server_accounts),
3719 (update_model_server_names): Do not actually save data until asked,
3720 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3722 (on_selection_changed),
3723 (modest_connection_specific_smtp_window_init): Disable the edit
3724 button when nothing is selected.
3726 * src/modest-account-mgr-helpers.c:
3727 * src/modest-account-mgr-helpers.h:
3728 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3731 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3733 * src/modest-account-mgr-helpers.h:
3734 * src/modest-account-mgr-helpers.c:
3735 (modest_account_mgr_get_unused_account_name),
3736 (modest_account_mgr_get_unused_account_display_name): Added these
3737 utility functions, to avoid code duplication.
3739 * src/maemo/easysetup/modest-easysetup-wizard.c:
3740 (create_page_account_details), (create_account):
3741 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3742 (on_combo_security_changed),
3743 (modest_connection_specific_smtp_edit_window_init),
3744 (modest_connection_specific_smtp_edit_window_save_settings):
3745 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3746 * src/maemo/modest-connection-specific-smtp-window.c:
3747 (modest_connection_specific_smtp_window_finalize),
3748 (modest_connection_specific_smtp_window_fill_with_connections),
3749 (on_button_edit), (modest_connection_specific_smtp_window_init):
3750 * src/maemo/modest-connection-specific-smtp-window.h:
3751 Implementing saving of connection-specific server accounts.
3753 But I need to refactor this so we can save the data for each
3754 possible connection-specific account and only actually create the server accounts
3755 when the easysetup finished, or the OK button is pressed on the account settings
3758 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3760 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3761 (on_combo_security_changed):
3762 (modest_connection_specific_smtp_edit_window_init):
3763 Auto-fill the port number as in the account settings.
3765 (modest_connection_specific_smtp_edit_window_set_connection):
3766 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3767 * src/maemo/modest-connection-specific-smtp-window.c:
3768 (fill_with_connections), (on_button_edit),
3769 (modest_connection_specific_smtp_window_init):
3770 Turn the edit window into a dialog to simplify the code, and
3771 set a WM hint as in a GtkDialog, because only a popup can be on top of
3772 another window in Maemo, and popups usually have no WM decoration.
3774 * src/modest-defs.h:
3775 * src/modest-account-mgr-helpers.c:
3776 (modest_account_mgr_set_connection_specific_smtp),
3777 (modest_account_mgr_remove_connection_specific_smtp),
3778 (modest_account_mgr_get_connection_specific_smtp):
3779 * src/modest-account-mgr-helpers.h: Some functions to write the
3780 connection-specific SMTP server information. Not yet used.
3783 * src/widgets/modest-folder-view.c: (text_cell_data):
3784 Fix a warning about an uninitialized variable.
3785 (on_configuration_key_changed): Put an #ifdef around the use
3786 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3788 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3790 * src/maemo/modest-account-settings-dialog.h:
3791 * src/maemo/modest-account-settings-dialog.c:
3792 Added connect_for_modified() utility function to mark the new modified boolean.
3794 (create_page_account_details), (create_page_user_details),
3795 (create_page_incoming), (create_page_outgoing), (on_response),
3796 (modest_account_settings_dialog_init),
3797 (modest_account_settings_dialog_set_account_name):
3798 Only warn about unsaved changes when there are actually unsaved changes.
3800 * src/modest-account-mgr-helpers.c:
3801 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3802 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3803 to get the data from there in future.
3805 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3807 * src/modest-defs.h:
3809 * src/modest-account-mgr-helpers.h:
3810 * src/modest-account-mgr-helpers.c:
3811 Store the security account setting in a single conf key instead of using
3812 the options list, so that the list is left for just the to-be-removed camel hack,
3813 and because gconf_client_set_list() is failing for some reason.
3815 * src/modest-account-mgr.c:
3816 (modest_account_mgr_add_server_account):
3817 * src/maemo/modest-account-settings-dialog.c:
3818 (modest_account_settings_dialog_set_account_name),
3819 (save_configuration): Use the renamed functions.
3822 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3824 * src/widgets/Makefile.am:
3825 * src/widgets/modest-limit-retrieve-combo-box.c:
3826 * src/widgets/modest-limit-retrieve-combo-box.h:
3827 * src/widgets/modest-retrieve-combo-box.c:
3828 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3829 the account settings dialog.
3831 * src/modest-defs.h:
3832 * src/modest-account-mgr-helpers.h:
3833 * src/modest-account-mgr-helpers.c:
3834 (modest_server_account_get_option_secure_auth),
3835 (modest_server_account_set_option_secure_auth):
3836 * src/modest-account-mgr.c:
3837 (modest_account_mgr_add_server_account):
3838 Use the existing AUTH_MECH conf key for the secure-auth setting,
3839 instead of putting it in the list options, because this was actually used already.
3841 * src/maemo/modest-account-settings-dialog.c:
3842 (create_page_account_details),
3843 (modest_account_settings_dialog_set_account_name),
3844 (save_configuration):
3845 * src/maemo/modest-account-settings-dialog.h:
3846 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3847 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3849 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3851 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3852 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3853 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3855 * src/modest-defs.h:
3856 * src/maemo/modest-account-settings-dialog.c:
3857 (create_page_incoming), (on_combo_outgoing_security_changed),
3858 (on_combo_incoming_security_changed), (create_page_outgoing),
3859 (modest_account_settings_dialog_set_account_name),
3860 (save_configuration): Load/Save the port number, and change it when the
3861 security combo changes, to suitable defaults.
3863 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3865 * src/modest-account-mgr.c:
3866 (modest_account_mgr_add_server_account): Set the security and secure-auth
3867 options, and add a comment saying that the other camel-specific options should be
3870 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3872 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3874 * src/modest-tny-account-store.c: (account_list_free),
3875 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3876 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3879 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3881 * src/modest-protocol-info.c:
3882 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3883 is required by our UI spec. Maybe something in our implementation will use this eventually.
3884 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3885 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3886 instead of the previous 0 placeholder.
3888 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3889 secure-auth settings.
3890 * src/modest-account-mgr-helpers.h:
3891 * src/modest-account-mgr-helpers.c:
3892 (modest_server_account_data_get_option_secure_auth),
3893 (modest_server_account_set_option_secure_auth),
3894 (modest_server_account_data_get_option_security),
3895 (modest_server_account_set_option_security): Added this API for getting and setting the security
3896 and secure-auth settings.
3898 * src/maemo/modest-account-settings-dialog.h:
3899 * src/maemo/modest-account-settings-dialog.c:
3900 (modest_account_settings_dialog_finalize), (check_data),
3901 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3902 about changing titles.
3903 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3904 (save_configuration): Save the security and secure-auth settings.
3906 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3907 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3909 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3911 * src/modest-defs.h:
3912 * src/modest-account-mgr.c:
3913 (modest_account_mgr_add_server_account):
3914 Added and used defines for the options key and value pair strings,
3915 that are used so far, though they do not seem to correspond to anything in our
3916 UI specs or ModestProtocol enum.
3918 * src/modest-account-mgr-helpers.h:
3919 * src/modest-account-mgr-helpers.c:
3920 (compare_option_strings_for_name),
3921 (modest_server_account_data_get_option_value),
3922 (modest_server_account_data_get_option_bool),
3923 (modest_account_mgr_get_server_account_option):
3924 Added helper functions for parsing the options GSList.
3926 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3928 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3929 display name is based on the supplied account name.
3930 * src/modest-account-mgr.c:
3931 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3932 with an inefficient, but good-enough, implementation.
3934 * src/maemo/easysetup/modest-easysetup-wizard.c:
3935 (create_page_account_details), (on_before_next), (create_account):
3936 Check for existing display names rather than (non-user-visible) account names, and just
3937 create and set a unique account name at the end.
3939 * src/maemo/modest-account-settings-dialog.c:
3940 (modest_account_settings_dialog_init),
3941 (modest_account_settings_dialog_set_account_name),
3942 (create_page_incoming): Show the display name, instead of the account name.
3943 (on_response): Do some (not all) extra checks, as in the UI spec.
3944 (save_configuration): Save the display name if it was changed.
3946 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3948 * po/en_GB.po: Added needed logical ID and translation.
3949 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3950 (init_view): Made the is-default column clicking work.
3952 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3955 * src/maemo/easysetup/Makefile.am:
3956 * src/maemo/easysetup/modest-easysetup-wizard.c:
3957 (modest_easysetup_wizard_dialog_init):
3958 * src/maemo/easysetup/provider-data-test.keyfile:
3959 * src/maemo/easysetup/provider-data.keyfile:
3960 Moved the provider data file to the new modest-providers-data package and used it from there.
3962 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3964 * src/modest-local-folder-info.c:
3965 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3966 N_() was already used on the static strings, but this just marks it for translation without
3967 using the translation.
3969 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3971 * src/maemo/modest-account-settings-dialog.c:
3972 (create_page_incoming),
3973 (modest_account_settings_dialog_set_account_name):
3974 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3975 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3976 I will do this if nobody else gets there first.
3978 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3980 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3981 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3982 save the security stuff.
3984 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3986 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3987 Set the email address and user fullname, which I now see must be
3990 * src/maemo/modest-account-settings-dialog.h:
3991 * src/maemo/modest-account-settings-dialog.c:
3993 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3994 leave-on-server and authentication.
3995 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3998 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4001 * src/maemo/modest-account-settings-dialog.c:
4002 * src/maemo/modest-account-settings-dialog.h:
4003 Most (but not all) of the widgets are now present as specified by the UI spec.
4004 No changes are yet saved, and some details are not properly shown yet.
4006 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4008 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4010 * src/maemo/Makefile.am:
4011 * src/maemo/modest-account-settings-dialog.c:
4012 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4013 an existing account. Doesn't do much yet.
4015 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4016 Open the accounts settings dialog when Edit is clicked.
4018 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4020 * src/maemo/easysetup/Makefile.am:
4021 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4023 * src/maemo/easysetup/modest-easysetup-wizard.c:
4024 (modest_easysetup_wizard_dialog_init):
4025 Try to get the source directory from the build system,
4026 instead of hard-coding "./" into the source code, when opening our local
4027 copies of the configuration files.
4028 But this still fails when opening the wizard from the Accounts window,
4029 maybe because the working directory seems to change at runtime.
4030 So the wizard will fail the second time unless you copy the files into their
4031 proper locations - see the stdout warnings for the paths.
4033 (create_page_account_details),(on_before_next):
4034 Check for existing non-server accounts instead of server accounts,
4035 so the default account name is useful again, and to prevent trying to
4038 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4039 Show the wizard when New is clicked.
4041 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4042 (init_view): Show the column headers, and show the columns that are
4043 specified in the UI specs. However, something in Maemo's GTK+ prevents
4044 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4045 change the default account. This is despite unsetting the special properties.
4047 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4049 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4050 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4051 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4052 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4053 to make that clearer.
4054 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4056 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4058 * src/maemo/modest-account-view-window.c:
4059 (modest_account_view_window_init),
4060 (modest_account_view_window_new):
4061 Use the same buttons as specified in the
4062 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4063 the existing widgets, which never had a chance of working.
4064 Put the ModestAccountView treeview in a scrolled window.
4065 Do not repeat the initialization in both _init() and _new().
4067 * src/widgets/modest-account-view.c: (update_account_view):
4068 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4069 this widget and window shows no accounts.
4071 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4073 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4075 * src/maemo/easysetup/modest-easysetup-wizard.c:
4076 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4077 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4078 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4081 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4082 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4083 accounts exist yet, as in the UI spec.
4085 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4087 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4089 * src/maemo/Makefile.am:
4090 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4091 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4092 New window for editing connection-specific smtp details.
4093 Not fully implemented.
4095 * src/maemo/modest-connection-specific-smtp-window.c:
4096 (modest_connection_specific_smtp_window_finalize) :
4097 unref the tree model.
4098 (on_button_edit): Show the edit window.
4100 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4102 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4105 * src/maemo/Makefile.am:
4106 * src/maemo/modest-connection-specific-smtp-window.c:
4107 * src/maemo/modest-connection-specific-smtp-window.h:
4108 New window for showing the list of connections, for connection-specific
4109 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4110 * src/maemo/easysetup/modest-easysetup-wizard.c:
4111 (create_page_custom_outgoing): Show the new window when the button is clicked.
4113 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4115 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4116 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4117 * src/maemo/modest-msg-edit-window.c:
4118 (modest_msg_edit_window_insert_image):
4119 * src/modest-conf.c: (modest_conf_key_escape):
4120 * src/modest-mail-operation.c:
4121 (modest_mail_operation_send_new_mail):
4122 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4123 (modest_ui_actions_on_new_account):
4124 * src/widgets/modest-attachment-view.c: (update_filename_request):
4125 * src/widgets/modest-mail-header-view.c:
4126 Corrected warnings that were breaking the build, by commenting out unused variables,
4127 and a function, and by including a header.
4129 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4131 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4132 so we can #ifdef around platform-specific code when necessary.
4133 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4134 to allow this to build for the GNOME platform too.
4136 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4138 * src/maemo/easysetup/modest-easysetup-wizard.c:
4139 Added util_increment_name() and used it in create_page_account_details()
4140 to make sure that the default account name is always a new name.
4142 (modest_easysetup_wizard_dialog_init),
4143 (set_default_custom_servernames): Some minor memory management fixes.
4145 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4149 * src/modest-runtime.c: (init_i18n): Restored the translation
4150 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4151 are defined in config.h, and the translations are installed.
4153 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4154 is defined for translation.
4156 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4158 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4160 * src/maemo/easysetup/modest-easysetup-wizard.c:
4161 (modest_easysetup_wizard_dialog_init):
4162 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4163 Use realistic paths (though they should use $prefix generically) to the
4164 mcc_mapping and provider-data.keyfile files which might work when they
4165 are installed by the future version of the operator-wizard package,
4166 and then fallback to paths in our source code, with an explanatory
4169 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4173 * src/maemo/Makefile.am:
4174 * src/maemo/easysetup/: Added files from the previously-exernal
4175 osso-modest-easysetup.
4176 * src/maemo/modest-main-window-ui.h:
4177 * src/modest-ui-actions.c:
4178 * src/modest-ui-actions.h:
4179 Added modest_ui_actions_on_new_account() as a signal handler for the
4180 New Account menu item. It shows the easysetup wizard.
4181 * po/en_GB.po: Added additional needed logical IDs and translations.