1 2007-06-21 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
4 Do not use a query, so that we get all folders, including for POP and
5 local-folders. They work as search criteria too.
6 This fixes projects.maemo.org bug NB#57740.
8 2007-06-21 Murray Cumming <murrayc@murrayc.com>
10 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
11 Comment out the use of hildon_notification_set_sound() because it is
12 not declared, to fix the build. Warnings are serious, people.
14 2007-06-21 Armin Burgmeier <armin@openismus.com>
16 * src/maemo/modest-maemo-utils.h:
17 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
18 modest_maemo_utils_get_supported_secure_authentication_methods()
19 to query authentication methods for a specific user. This should fix
20 projects.maemo.org bug NB#61369.
22 * src/maemo/easysetup/modest-easysetup-wizard.c:
23 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
26 2007-06-21 Murray Cumming <murrayc@murrayc.com>
28 * libmodest-dbus-client/libmodest-dbus-client.h:
29 * libmodest-dbus-client/libmodest-dbus-client.c:
30 (modest_dbus_message_iter_get_search_hit),
31 (libmodest_dbus_client_search):
32 Reorganised and commented this.
33 Removed modest_search_hit_free() from the public API because it
36 Added libmodest_dbus_client_get_folders() and
37 modest_folder_result_list_free().
39 * src/dbus_api/modest-dbus-api.h:
40 * src/dbus_api/modest-dbus-callbacks.c:
41 (modest_dbus_req_filter): Commented. Moved most code to
42 on_dbus_method_search() and added on_dbus_method_get_folders().
44 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
45 of the extra D-Bus handler.
47 * tests/dbus_api/Makefile.am:
48 * tests/dbus_api/test_get_folders.c: New test for
49 libmodest_dbus_client_get_folders(). This seems to return an empty list
50 at the moment. That could be the same error that causes the message list
51 to be empty sometimes.
52 This should help with projects.maemo.org bug NB#57740.
54 2007-06-21 Armin Burgmeier <armin@openismus.com>
56 * src/modest-mail-operation.c: Do not call
57 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
58 notify the operation's end after having set the status to CANCELED for
59 the operation queue to listen on. This fixes a deadlock when there
60 were mail operations in the queue during its finalization.
62 * src/modest-singletons.c: Reordered uninitialization of the account
63 manager to happen after the mail operation queue was uninitialized
64 because the mail operation's in the queue might still try to access
65 the account manager (see modest_mail_operation_notify_end()). This
66 fixes a potential crash when terminating the application.
68 2007-06-21 Murray Cumming <murrayc@murrayc.com>
70 * src/modest-search.c:
71 (search_mime_part_and_child_parts): Moved some code here so we
72 can search recursively in child folders.
73 (modest_search_folder): Search in the message as a mime part, instead
74 of just its child mime parts.
75 (read_chunk), (search_mime_part_ogs):
76 Check how many bytes were read, to prevent an endless loop.
77 Searching in message bodies now works. This finishes the fix for
78 projects.maemo.org bug NB#61007.
80 2007-06-20 Murray Cumming <murrayc@murrayc.com>
82 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
83 Add a g_warning when the item is not a folder.
85 * src/modest-ui-dimming-rules.c:
86 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
87 when selected item is not a folder (for instance, an account), because
88 the UI spec only talks about folders.
89 I am not sure what the UI spec wants, so this might not totally fix
90 projects.maemo.org bug NB#60794.
92 2007-06-20 Murray Cumming <murrayc@murrayc.com>
94 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
95 (load_from_file): Sort the list. The unsorted list would be more noticeable
96 in non-English locales.
98 * src/maemo/modest-msg-edit-window.c:
99 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
100 warning and fix the build.
102 * src/maemo/modest-progress-bar-widget.c:
103 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
104 avoid a g_warning, and probably to avoid a crash.
106 2007-06-20 Murray Cumming <murrayc@murrayc.com>
108 * src/modest-search.c: (modest_search_folder): Check for a GError
109 when calling tny_folder_get_headers(), to show that this is not the cause
112 2007-06-20 Murray Cumming <murrayc@murrayc.com>
114 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
115 Actually set the body query instead of the subject query.
117 * src/modest-search.c: (search_mime_part_ogs),
118 (search_mime_part_strcmp): Remove extra space from the text/* regex,
119 which would probably cause it to fail if we got this far.
121 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
122 to simplify the code.
123 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
124 be causing search-in-body to fail.
126 2007-06-20 Murray Cumming <murrayc@murrayc.com>
128 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
130 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
131 Better debug message when the folder cannot be found.
132 This should help with fixing projects.maemo.org bug #61287.
133 * src/modest-search.c: (add_hit): Do not leak the furl string.
135 2007-06-20 Murray Cumming <murrayc@murrayc.com>
137 * src/modest-ui-actions.c:
138 (modest_ui_actions_on_folder_selection_changed):
139 Do not special-case TNY_MERGE_FOLDER here, because
140 modest_tny_folder_get_account() already does that. This fixes
141 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
142 shown when the Outbox was selected).
144 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
146 * libmodest-dbus-client/libmodest-dbus-client.c:
147 (_dbus_iter_get_string_or_null): Initialize the string variable in
148 case this helps with Dirk's crash.
150 2007-06-19 Murray Cumming <murrayc@murrayc.com>
152 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
153 though it is not implemented yet (this function is maybe not even used),
154 to avoid breaking ABI in future.
155 * libmodest-dbus-client/libmodest-dbus-client.c:
156 (get_attachments_string): Moved some code into this generic function.
157 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
158 sends email. It is maybe not used.
159 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
160 (on_send_mail): Use attachments.
162 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
163 * src/maemo/modest-msg-edit-window.c:
164 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
165 a filename before using it, to fix projects.maemo.org bug NB#58233.
167 2007-06-19 Murray Cumming <murrayc@murrayc.com>
169 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
170 Initialize the continue_download variable to fix the build, and probably
171 to fix randome behaviour.
173 2007-06-18 Armin Burgmeier <armin@openismus.com>
175 * src/modest-tny-send-queue.h:
176 * src/modest-tny-send-queue.c: Keep track of the status of messages in
177 the queue so we can later show it in the UI. Replaced
178 modest_tny_send_queue_msg_is_being_sent() by
179 modest_tny_send_queue_get_msg_status().
181 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
183 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
184 gpointer. This probably was not harmful, but just to be sure.
186 2007-06-18 Murray Cumming <murrayc@murrayc.com>
188 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
189 Fix the build, but leave the function broken on Bora, because
190 hildon_uri_action_get_service() does not exist.
191 osso_uri_action_get_service() does not exist either, it seems.
193 2007-06-18 Murray Cumming <murrayc@murrayc.com>
195 * src/modest-tny-account.c:
196 (modest_tny_account_new_from_server_account):
197 Uncommented the url debug output again, because it is useful for
198 debugging, as I said in the comment.
200 2007-06-18 Murray Cumming <murrayc@murrayc.com>
202 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
204 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
205 for Mameo Bora, to fix the build.
207 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
210 Fixed build with hildon < 0.99
212 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
213 Check if the selected account is busy instead of checking all accounts
215 * src/modest-account-mgr-priv.h:
216 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
217 (modest_account_mgr_init), (compare_account_name),
218 (modest_account_mgr_set_account_busy),
219 (modest_account_mgr_account_is_busy):
220 * src/modest-account-mgr.h:
221 Added busy information to the account manager. It possible to
222 set an account to busy or not busy now.
224 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
225 (modest_mail_operation_update_account),
226 (modest_mail_operation_notify_end):
227 Set the account to busy/not busy depending on the operation state.
229 * src/widgets/modest-account-view.c:
230 (modest_account_view_finalize), (get_last_updated_string),
231 (update_account_view), (on_account_busy_changed), (init_view):
232 Show string "Refreshing..." if the account is currently busy.
234 All this fixes projects.maemo.org bug NB#59711
236 2007-06-14 Armin Burgmeier <armin@openismus.com>
238 * src/widgets/modest-attachments-view.h:
239 * src/widgets/modest-attachments-view.c: Added
240 modest_attachments_view_has_attachments() and fixed coordinate
241 transformation in get_att_view_at_coords(). This fixes attachment
244 * src/widgets/modest-msg-view.c: Make use of
245 modest_attachments_view_has_attachments() to decide whether to show
246 attachments in the header.
248 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
250 * src/maemo/modest-connection-specific-smtp-edit-window.c:
251 (on_change), (on_combo_security_changed),
252 (modest_connection_specific_smtp_edit_window_init),
253 (modest_connection_specific_smtp_edit_window_set_connection),
254 (modest_connection_specific_smtp_edit_window_is_dirty):
255 * src/maemo/modest-connection-specific-smtp-edit-window.h:
256 * src/maemo/modest-connection-specific-smtp-window.c:
259 Show an comfirmation dialog for the smpt-edit-window if there are
260 unsaved changes and the user hits cancel.
261 (projects.maemo.org bug NB#60479)
263 2007-06-14 Armin Burgmeier <armin@openismus.com>
265 * src/maemo/easysetup/modest-easysetup-wizard.c:
266 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
267 address" info in banner instead of node, and select all the text as
268 per UI spec. This fixes projects.maemo.org bug NB#60550.
270 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
272 reviewed by: <delete if not using a buddy>
274 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
275 * src/modest-ui-actions.c: (folder_refreshed_cb):
277 2007-06-14 Murray Cumming <murrayc@murrayc.com>
279 * src/widgets/modest-folder-view.c: (filter_row):
280 Explictly filter out the per-account outbox accounts. I don't know why
281 these only sometimes show up, but now they should never show up in the UI.
282 This should fix projects.maemo.org bug NB#60160.
284 2007-06-14 Murray Cumming <murrayc@murrayc.com>
286 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
287 when the toolbar does not exist yet.
288 * src/modest-widget-memory.c: (save_settings_header_view):
289 Added g_warnings() to help us to discover when we are trying to set
290 an empty columns list in gconf.
292 2007-06-14 Murray Cumming <murrayc@murrayc.com>
296 Added modest_init_get_default_header_view_column_ids().
298 * src/modest-widget-memory.c: (restore_settings_header_view):
299 Use the new function to get defaults, if the gconf key is empty,
300 instead of not creating any columns. This seems to fix the
301 empty right-hand pane problems.
303 * src/widgets/modest-header-view.h: Improved documentation.
305 2007-06-13 Murray Cumming <murrayc@murrayc.com>
307 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
308 Revert the use of the display name as the account name, because this
309 is generally wrong and would break the code that follows.
311 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
313 * src/maemo/easysetup/modest-easysetup-wizard.c:
314 (check_for_supported_auth_methods), (on_before_next),
317 More correct fix for projects.maemo.org bug NB# 58991
318 Do not longer accept AUTH_PASSWORD as secure method and choose
319 correct method when creating the account.
321 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
323 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
324 Fixed projects.maemo.org bug NB# 58991
326 2007-06-13 Murray Cumming <murrayc@murrayc.com>
328 * src/modest-init.c: (modest_init_init_core),
329 (modest_init_local_folders): Fixed compilation errors.
331 2007-06-13 Murray Cumming <murrayc@murrayc.com>
333 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
334 Remove unnecessary lib/include, though it is good in principle when needed.
336 * src/modest-init.c: (modest_init_one_local_folder),
337 (modest_init_local_folders):
338 * src/modest-init.h: Initialize the .modest library for memory cards,
339 instead of just doing nothing for them. This should allow us to create
340 folders there, fixing projects.maemo.org bug NB#59297.
342 2007-06-13 Murray Cumming <murrayc@murrayc.com>
344 * libmodest-dbus-client/libmodest-dbus-client.c:
345 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
346 (libmodest_dbus_client_compose_mail),
347 (libmodest_dbus_client_open_message),
348 (libmodest_dbus_client_send_and_receive),
349 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
351 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
352 (on_idle_open_message), (modest_dbus_req_handler),
353 (search_result_to_message), (modest_dbus_req_filter):
354 * src/modest-search.c: (add_hit), (modest_search_folder),
355 (modest_search_all_accounts): Improved debug messages.
357 * tests/dbus_api/test_open_message.c: (main): Improved comments.
359 * src/modest-tny-account-store.c:
360 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
363 2007-06-13 Murray Cumming <murrayc@murrayc.com>
366 2007-06-12 Murray Cumming <murrayc@murrayc.com>
368 * src/modest-tny-account-store.c: (get_server_accounts):
369 Call modest_tny_local_folders_account_add_merged_outbox_folders()
370 even when there are no accounts, so that the Outbox folder is always
371 visible. This fixes projects.maemo.org bug NB#60158.
373 2007-06-12 Murray Cumming <murrayc@murrayc.com>
375 * src/maemo/modest-main-window.c: (create_details_widget):
376 Use the mcen_va_never logical ID.
378 2007-06-12 Murray Cumming <murrayc@murrayc.com>
380 * src/dbus_api/modest-dbus-api.h:
381 * src/dbus_api/modest-dbus-callbacks.c:
382 (on_idle_open_default_inbox), (on_open_default_inbox),
383 (modest_dbus_req_handler):
384 Added a new OpenDefaultInbox method.
386 * libmodest-dbus-client/libmodest-dbus-client.h:
387 * libmodest-dbus-client/libmodest-dbus-client.c:
388 Added libmodest_dbus_client_open_default_inbox() to call the new
389 dbus method. This should be useful to projects.maemo.org bug NB#57214,
390 though it should maybe be used by a new osso-email-interface function.
392 * tests/dbus_api/Makefile.am:
393 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
396 2007-06-12 Murray Cumming <murrayc@murrayc.com>
398 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
399 NULL, so that the signals get all the keys. This should not actually
400 change any behaviour because we currently update everything when anything
403 2007-06-12 Murray Cumming <murrayc@murrayc.com>
405 * src/widgets/modest-folder-view.c: (text_cell_data),
406 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
407 (find_inbox_iter): If tinymail tells us that the folder is
408 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
409 This causes the inbox to be selected at startup, fixing part of
410 projects.maemo.org bug NB#56305.
412 * src/modest-ui-dimming-rules.c:
413 (modest_ui_dimming_rules_on_tools_smtp_servers):
414 * src/modest-ui-dimming-rules.h: Added a callback function to dim
415 the SMTP servers menu item.
416 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
417 that the SMTP Servers menu item is dimmed when there are no accounts,
418 as a future version of the UI spec will require. This fixes
419 projects.maemo.org bug NB#56305.
421 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
423 * src/maemo/modest-maemo-utils.c:
424 (modest_maemo_utils_get_supported_secure_authentication_methods):
425 Added label to dialog instead of unreadable title
427 * src/maemo/modest-main-window.c: (sync_accounts_cb),
428 (modest_main_window_new):
429 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
432 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
433 * src/modest-account-mgr.h:
434 Added method to avoid code duplication
436 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
437 (modest_ui_actions_on_send_receive):
438 Use modest_account_mgr_has_accounts
440 2007-06-11 Murray Cumming <murrayc@murrayc.com>
442 * src/maemo/easysetup/modest-presets.c:
443 (modest_presets_get_info_server_security): Do not report secure auth
445 * src/modest-protocol-info.c: Use the defines for the gconf key names
446 for secure authentication. This was not working because we were writing
447 Password and reading password, and the check was case sensitive.
448 With this, gmail now works for receiving and sending when created via
451 2007-06-11 Murray Cumming <murrayc@murrayc.com>
453 * src/maemo/easysetup/modest-presets.c:
454 (modest_presets_get_info_server_security): Correct the key name for
455 SecureSmtp, because it seems to be case-sensitive.
456 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
457 Do not try to get the 0th notebook page if there are 0 pages, to
460 2007-06-11 Murray Cumming <murrayc@murrayc.com>
462 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
463 Prevent use of the new notification feature for now, because it currently
464 shows one dialog for each new email, which is annoying.
466 2007-06-11 Murray Cumming <murrayc@murrayc.com>
468 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
469 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
470 when no country was selected, so that we show the global ones.
471 * src/maemo/easysetup/modest-presets.c:
472 (modest_presets_get_providers): Return only the global providers, not
473 all providers when mmc=0 was requested.
475 2007-06-11 Murray Cumming <murrayc@murrayc.com>
477 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
478 (easysetup_provider_combo_box_fill): Remove debug code that showed the
479 provider ID in the combo.
481 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
482 Do not show the page numbers, because it would be confusing when we add
483 the 2 extra pages for the custom setup, when the user chooses the "Other"
484 provider. This fixes projects.maemo.org bug NB#59028
486 * src/modest-init.c: (modest_init_init_core),
487 (modest_init_local_folders):
489 * src/modest-tny-account.c:
490 (modest_tny_account_new_for_local_folders): Do not create default folders
491 for the memory card. This should fix projects.maemo.org bug NB#59328.
493 2007-06-11 Murray Cumming <murrayc@murrayc.com>
495 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
496 Free the changed_conf_keys string items. They are already freed in the
497 idle handler if that runs first.
499 2007-06-11 Murray Cumming <murrayc@murrayc.com>
501 * src/modest-ui-actions.c:
502 (modest_ui_actions_on_password_requested): Check that the server name
503 is not NULL, because I just saw a password dialog with (null) as the
506 * src/modest-tny-folder.[h|c]: Added
507 modest_tny_folder_is_memory_card_folder().
508 * src/modest-ui-dimming-rules.c:
509 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
510 menu item for memory cards, as per the UI spec (section 7.4). This should
511 fix projects.maemo.org bug NB#59297.
513 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
515 * src/maemo/modest-main-window.c: (sync_accounts_cb):
516 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
517 is another problem with the code, see Murray's comment at line 772)
519 2007-06-08 Murray Cumming <murrayc@murrayc.com>
521 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
522 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
523 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
524 (load_from_file), (easysetup_country_combo_box_init),
525 (easysetup_country_combo_box_get_active_country_ids),
526 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
527 instead of just one ID, to avoid duplicate country names in the UI.
529 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
530 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
531 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
532 a single ID, avoiding duplicate providers.
533 * src/maemo/easysetup/modest-easysetup-wizard.c:
534 (on_combo_account_country): Adapt to use a list.
536 2007-06-08 Murray Cumming <murrayc@murrayc.com>
538 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
539 keys changed in the last X seconds.
541 * src/modest-account-mgr.h:
542 * src/modest-account-mgr.c: (on_timeout_notify_changes),
543 (on_key_change), (modest_account_mgr_class_init),
544 (modest_account_mgr_init), (modest_account_mgr_finalize):
545 As the keys are changed, save them in a GSList* and signal that GSList*
546 further every X seconds, to batch changes, to allow us to do just one
547 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
548 bug NB#56941 and other (UI-blocking) delays when changing account settings.
550 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
551 changed signal signature.
553 * src/modest-conf.c: (modest_conf_set_list),
554 (modest_conf_on_change): Reenable notification.
556 (modest_conf_maemo_fake_on_change): Comment out the hack that
557 notified immediately instead of asynchronously.
559 * src/widgets/modest-account-view.h:
560 * src/widgets/modest-account-view.c:
561 (update_account_view): Select the previously-selected account ID,
562 if possible. This fixes projects.maemo.org bug NB#56933.
564 (on_account_changed), (on_account_removed),
565 (modest_account_view_select_account):
567 Remove the block/unblock functions
568 because they were not useful.
570 * src/maemo/modest-account-view-window.c:
571 (on_delete_button_clicked), (on_edit_button_clicked),
572 (on_new_button_clicked): Remove the use of the non-working block/unblock.
574 2007-06-08 Murray Cumming <murrayc@murrayc.com>
576 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
577 Improve the error dialog to show Incorrect Account Settings, which seems
578 clearer, and say that the internal error message (to be removed from the
579 dialog later) is often misleading.
580 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
582 * src/modest-tny-account.c:
583 (modest_tny_account_new_from_server_account): Uncomment the printf of the
584 URL because this is so useful for debugging on the device.
586 * src/widgets/modest-serversecurity-combo-box.c:
587 (modest_serversecurity_combo_box_fill): Correct a logical ID.
589 2007-06-08 Murray Cumming <murrayc@murrayc.com>
591 * src/modest-mail-operation.c:
592 (modest_mail_operation_send_new_mail):
593 Added a comment about a nasty but apparently harmless message. Details
594 added to the wiki g_warnings() page.
596 2007-06-08 Murray Cumming <murrayc@murrayc.com>
598 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
599 (modest_tny_send_queue_class_init):
600 Do not use the priv struct because it is empty, to avoid g_warnings
601 about a non-existant priv struct.
603 * src/modest-tny-account-store.c:
604 (modest_tny_account_store_get_server_account),
605 (modest_tny_account_store_get_transport_account_for_open_connection
606 ): Do not try to get transport server accounts for local folders,
607 because they don't have any. This avoids a g_warning().
609 * src/maemo/modest-main-window.c:
610 (modest_main_window_notify_send_receive_initied),
611 (on_configuration_key_changed):
612 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
614 * src/modest-mail-operation.c:
615 (modest_mail_operation_update_account):
616 * src/modest-tny-account-store.h:
617 * src/modest-tny-account.c:
618 (modest_tny_account_get_special_folder),
619 (modest_tny_account_new_for_local_folders),
620 (modest_tny_account_new_for_per_account_local_outbox_folder):
621 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
622 * src/modest-tny-local-folders-account.c:
623 (add_account_folders_to_merged_folder):
624 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
625 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
626 (modest_ui_actions_on_send):
627 * src/widgets/modest-folder-view.c: (update_model):
628 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
629 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
630 modest_tny_account_store_get_tny_account_by_account() to
631 modest_tny_account_store_get_server_account() to make the code clearer.
633 2007-06-07 Marcus Bauer <marcusb@openismus.com>
635 * src/dbus_api/modest-dbus-api.h:
636 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
637 * src/maemo/modest-msg-edit-window.c:
638 (modest_msg_edit_window_attach_file_noninteractive):
639 added g_warning in case the file to be attached does not exist
640 * tests/dbus_api/test_compose_mail.c: (main):
641 removed obsolete comment, added generic files as test case
643 2007-06-07 Murray Cumming <murrayc@murrayc.com>
645 * src/modest-tny-account-store.c: (get_server_accounts):
646 Create the local folders account only once, not once for each outbox, and
647 not only when there are some outboxes.
649 2007-06-07 Murray Cumming <murrayc@murrayc.com>
651 * src/widgets/modest-folder-view.c: (update_model): Comment out some
652 code that is causing a crash at startup. Sergio says that he is fixing this.
654 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
656 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
657 * src/maemo/modest-account-settings-dialog.c:
658 (create_page_outgoing),
659 (modest_account_settings_dialog_set_account_name),
660 (save_configuration):
661 - Fixed handling of the "Use secure authentication" toggle to comply with
662 the ui specification. See also projects.maemo.org bug NB#58400
664 - Restore the Secure connection setting combo correctly when loading
667 * src/maemo/modest-maemo-utils.c:
668 (on_camel_account_get_supported_secure_authentication),
669 (modest_maemo_utils_get_supported_secure_authentication_methods):
670 Fixed a crasher if operation is canceled
672 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
673 (modest_protocol_info_auth_is_secure):
674 * src/modest-protocol-info.h:
676 Added two new methods to determine if a protocol/auth method is secure/encrypted in
677 the sense of the "Use secure authentication" toggle.
679 2007-06-07 Murray Cumming <murrayc@murrayc.com>
681 * src/modest-tny-account-store.h:
682 * src/modest-tny-account-store.c:
683 Added modest_tny_account_store_get_local_folders_account().
685 * src/modest-tny-folder.h:
686 * src/modest-tny-folder.c:
687 (modest_tny_folder_get_account):
688 Added this replacement for tny_folder_get_account() which returns
689 the local-folders account for TnyMergeFolders, to avoid the
690 warning about the unimplemented get_account_func() vfunc().
692 (modest_tny_folder_get_rules),
693 * src/modest-ui-actions.c:
694 (modest_ui_actions_on_folder_selection_changed):
695 * src/modest-mail-operation.c:
696 (modest_mail_operation_remove_folder),
697 (modest_mail_operation_xfer_folder),
698 (modest_mail_operation_rename_folder),
699 (modest_mail_operation_get_msg),
700 (modest_mail_operation_get_msgs_full),
701 (modest_mail_operation_remove_msg),
702 (modest_mail_operation_xfer_msgs),
703 (modest_mail_operation_refresh_folder):
704 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
706 2007-06-07 Murray Cumming <murrayc@murrayc.com>
708 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
709 (modest_server_account_set_security):
710 * src/modest-defs.h: Add comments explaining that our
711 UI spec means TLS when it says Normal, so these do not look like errors.
713 * src/modest-tny-account.c:
714 (modest_tny_account_new_from_server_account): Use the new tinymail
715 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
716 for TLS. This should fix projects.maemo.org bug NB#58460.
718 2007-06-06 Murray Cumming <murrayc@murrayc.com>
720 * src/maemo/easysetup/modest-easysetup-wizard.c:
721 (create_account): Correct the position of the gconf sanity check warning.
722 (on_button_edit_advanced_settings): Show the dialog immediately, instead
723 of using the g_idle_add() hack, because this does not seem to be necessary
724 on osso 1.1. It might even work on Maemo Bora if the problems were actually
725 caused by something other than maemo's gconf.
726 This fixes projects.maemo.org bug #59022.
728 2007-06-06 Murray Cumming <murrayc@murrayc.com>
730 * src/modest-account-mgr-helpers.c:
731 (modest_account_mgr_get_default_account): Do not check that the account
732 exists if there is no default account (NULL), to fix a runtime warning.
734 2007-06-06 Murray Cumming <murrayc@murrayc.com>
736 * src/widgets/modest-folder-view.c: (update_model):
737 Do not unref the treemodel before we have finished with it.
738 This prevents a valgrind warning and an occasional crash at startup.
740 2007-06-06 Marcus Bauer <marcusb@openismus.com>
742 * libmodest-dbus-client/libmodest-dbus-client.h:
743 added libmodest_dbus_client_compose_mail()
744 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
746 added functions needed for SendAsMail() functionality
747 * src/maemo/modest-msg-edit-window.c:
748 (modest_msg_edit_window_attach_file_noninteractive):
749 non interactively attaching files to message edit window
750 * src/widgets/modest-msg-edit-window.h:
751 * tests/dbus_api/Makefile.am:
752 added test_compose_mail.c
753 * tests/dbus_api/test_compose_mail.c: (main):
755 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
757 * src/modest-account-view.c:
758 Fixed bug projects.maemo.org bug NB#59307
760 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
762 * src/maemo/easysetup/modest-easysetup-wizard.c:
763 (get_serverport_incoming), (on_before_next), (create_account):
764 * src/maemo/modest-account-settings-dialog.c:
765 (modest_account_settings_dialog_set_account_name):
766 * src/maemo/modest-maemo-utils.c:
767 (on_camel_account_get_supported_secure_authentication_status),
768 (on_camel_account_get_supported_secure_authentication),
769 (on_secure_auth_cancel),
770 (modest_maemo_utils_get_supported_secure_authentication_methods):
772 Implemented security authentication for settings and easysetup.
774 2007-06-05 Murray Cumming <murrayc@murrayc.com>
776 * src/maemo/modest-main-window.c: (create_details_widget):
777 Show the total size for memory card accounts too, instead of showing
778 the name again. Fixes bug projects.maemo.org bug NB#59307.
780 2007-06-05 Murray Cumming <murrayc@murrayc.com>
783 * src/modest-tny-simple-folder-store.c:
784 * src/modest-tny-simple-folder-store.h: Removed.
786 * src/modest-tny-local-folders-account.h
787 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
788 for the local-folders maildir, with an extra TnyMergedFolder containing
789 the folders of the per-account outbox store accounts.
790 * src/modest-tny-account-store.c: (get_server_accounts):
791 Add the outboxes to the special local folders account after creating it.
793 * src/modest-tny-account.c:
794 (modest_tny_account_new_for_local_folders): Create the derived
795 account when creating the main local-folders account.
797 * src/maemo/modest-main-window.c: (create_details_widget),
798 (modest_main_window_set_contents_style):
799 Adapted to the use of the derived account instead of the folder store.
801 * src/modest-ui-actions.c:
802 (modest_ui_actions_on_folder_selection_changed):
803 * src/modest-ui-dimming-rules.c:
804 (modest_ui_dimming_rules_on_new_folder):
805 * src/widgets/modest-folder-view.c: (text_cell_data),
806 (icon_cell_data), (filter_row), (update_model),
807 (get_cmp_rows_type_pos):
810 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
811 Do not get the priv struct, because no priv struct has been set,
812 to avoid a runtime warning.
814 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
815 #ifelse with #else, to fix a warning, to fix the build.
818 2007-06-05 Christian Kellner <ckellner@openismus.com>
820 * libmodest-dbus-client/libmodest-dbus-client.c:
821 Fix small typo in doc (why do you always see them
822 AFTER committing stuff?)
825 2007-06-05 Christian Kellner <ckellner@openismus.com>
827 * libmodest-dbus-client/libmodest-dbus-client.c:
828 (libmodest_dbus_client_search):
829 Initialize hit list with NULL. Also set folder list
830 to "" if NULL was supplied.
833 2007-06-03 Christian Kellner <ckellner@openismus.com>
835 * libmodest-dbus-client/libmodest-dbus-client.c:
836 (modest_search_hit_list_free):
837 Make it save to call it with NULL.
839 * src/dbus_api/modest-dbus-callbacks.c:
840 * src/modest-search.c:
841 Return full ModestSearchHits as the search result list not TnyHeader
842 since can't be around withouth the correspoding TnyFolder.
844 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
846 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
847 Added currently commented code to check for secure auth
849 * src/maemo/modest-account-settings-dialog.c: (on_response),
850 (save_configuration), (show_ok):
851 Fixed projects.maemo.org bugs NB #59248 and #59251
853 * src/maemo/modest-maemo-utils.c:
854 (on_camel_account_get_supported_secure_authentication_status),
855 (on_camel_account_get_supported_secure_authentication),
856 (modest_maemo_utils_get_supported_secure_authentication_methods):
857 * src/maemo/modest-maemo-utils.h:
858 Moved get_supported_secure_authentication() method here to be able
859 to use it from easysetup wizard.
861 * src/modest-pair.c: (on_pair_compare_as_string):
862 Should compare string with first part of pair and not
863 strcmp pairs which will crash.
865 * src/modest-protocol-info.c:
866 (modest_protocol_info_protocol_is_store):
867 * src/modest-protocol-info.h:
868 Added modest_protocol_info_get_auth_protocol_name()
870 2007-06-03 Armin Burgmeier <armin@openismus.com>
872 * src/modest-mail-operation.c:
873 (modest_mail_operation_get_msgs_full): Set priv->account also when
874 only retrieving a single message. This avoids a crash when canceling
877 (modest_mail_operation_notify_end): Do not explicitely remove the
878 operation from the queue but only emit the progress_changed signal.
879 The queue itself listens to that signal to remove the operation when
880 it is finished. This reduces coupling and removes a potential deadlock
881 when modest_mail_operation_notify_end() is called from the queue
882 itself. If that is a problem performance-wise, I would suggest to
883 implement a status-changed signal or something.
885 * src/modest-mail-operation-queue.c: Make sure to never call a
886 function from another file while the queue is locked. This (hopefully)
887 fixes another deadlock when exiting the application while retrieving
890 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
892 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
893 Fixed build if libogs is not available
895 2007-06-03 Christian Kellner <ckellner@openismus.com>
897 * libmodest-dbus-client/libmodest-dbus-client.h:
898 * libmodest-dbus-client/libmodest-dbus-client.c:
899 (libmodest_dbus_client_delete_message):
900 Implement deletion of messages (Client side).
902 (modest_search_hit_free),
903 (modest_search_hit_list_free):
904 Utility functions to free the result hits.
906 * src/dbus_api/modest-dbus-api.h:
907 * src/dbus_api/modest-dbus-callbacks.c:
909 (modest_dbus_req_handler):
910 Implement deletion of messages (Server side).
912 * tests/dbus_api/test_search.c: (main):
915 * tests/dbus_api/Makefile.am:
916 * tests/dbus_api/test_delete_message:
917 Add little test for the message deletion logic
919 2007-06-03 Armin Burgmeier <armin@openismus.com>
921 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
922 when the operation queue was not empty. projects.maemo.org bug
925 2007-06-03 Armin Burgmeier <armin@openismus.com>
927 * src/widgets/modest-account-view.c
928 (on_account_default_toggled): Toggle default account column
929 explicitely instead of waiting for gconf notification (which is
930 currently ignored). This should fix projects.maemo.org bug NB#56910
931 for now. It should probably be removed when gconf notifications are
934 2007-06-03 Christian Kellner <ckellner@openismus.com>
936 * libmodest-dbus-client/libmodest-dbus-client.c:
937 Removed debugging spew.
939 * src/dbus_api/modest-dbus-callbacks.c:
940 Added debugging info.
942 * src/modest-search.c:
943 (modest_search_all_accounts):
944 Use tny_account_store_get_accounts () on the account store
945 to get all accounts which is the way to get all accounts.
947 * tests/dbus_api/test_search.c: (main):
948 Make it possible to supply the search term on the command line.
950 2007-06-03 Christian Kellner <ckellner@openismus.com>
952 * libmodest-dbus-client/libmodest-dbus-client.c:
953 * libmodest-dbus-client/libmodest-dbus-client.h:
954 Implement searching for mesages over raw dbus. (Client side)
956 * src/dbus_api/Makefile.am:
957 * src/dbus_api/modest-dbus-api.h:
958 * src/dbus_api/modest-dbus-callbacks.c:
959 * src/dbus_api/modest-dbus-callbacks.h:
960 Search framework (Server side). Also implement on_idle_open_message().
962 * src/maemo/modest-platform.c: (modest_platform_init):
963 Prepare for raw dbus/osso rpc interaction.
965 * src/modest-search.h:
966 Changed minsize from unspecific guint to guint32.
968 * src/modest-search.c:
970 Added strange hack which magically made tnymail work.
972 (modest_search_folder),
973 (modest_search_account),
974 (modest_search_all_accounts):
975 Implement helper functions to search all accounts, specific account
978 * tests/dbus_api/Makefile.am:
979 * tests/dbus_api/test_open_message.c:
980 Read url to open from commandline.
982 * tests/dbus_api/test_search.c:
983 Implement small test for dbus search stuff
985 2007-06-02 Armin Burgmeier <armin@openismus.com>
987 * src/maemo/modest-account-settings-dialog.c: Changed window title to
988 include account type and account title. This fixes projects.maemo.org
991 * src/maemo/modest-account-view-window.c: Set a title for the window.
993 2007-06-02 Armin Burgmeier <armin@openismus.com>
995 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
996 incoming and outgoing server name based on email address and server
997 types as long as the names have not been edited manually. This fixes
998 projects.maemo.org bug NB#58671.
1000 2007-06-02 Armin Burgmeier <armin@openismus.com>
1002 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1003 server type cannot be changed in future to the incoming details page
1004 when creating an account. This fixes projects.maemo.org bug NB#59029.
1006 2007-06-02 Armin Burgmeier <armin@openismus.com>
1008 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1009 and assigned max width chars so that they wrap instead of being
1010 truncated. Fixes projects.maemo.org bug NB#56126.
1012 2007-06-02 Armin Burgmeier <armin@openismus.com>
1014 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1015 introductory note to the connection specific smtp servers dialog, as
1016 section 8.12 of the email UI specification requires. This fixes
1017 projects.maemo.org bug NB#59212.
1019 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1021 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1022 Check for running mail operations, and offer to cancel them, as per the UI
1023 spec. This fixes projects.maemo.org bug NB#59041 .
1024 However, I suspect that tinymail may still use the network connection
1025 in ways that we cannot detect or cancel. But it should at least adapt to
1026 changes fairly well.
1028 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1030 * src/modest-tny-account-store.c: (recreate_all_accounts),
1031 (get_cached_accounts), (get_server_accounts): Do more sensible
1032 ref-counting of the temporarily-cached outbox accounts list. This seems
1033 to fix a crash when entering the password when the password was wrong.
1035 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1037 * src/gnome/modest-main-window.c: (connect_signals):
1038 * src/modest-tny-account-store.c: (get_password),
1039 (modest_tny_account_store_alert): Added comments and clues and
1040 commented-out code about how we currently fail to deal with connection
1041 errors and wrong passwords, and how we should.
1043 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1045 * src/widgets/modest-retrieve-combo-box.c:
1046 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1047 This fixes projects.maemo.org bug NB#58472 .
1049 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1051 * src/maemo/easysetup/modest-easysetup-wizard.c:
1052 (create_page_complete_easysetup):
1053 (create_page_complete_custom): Correct the last commit,
1054 putting the correct sentences in the correct pages.
1056 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1058 * src/maemo/easysetup/modest-easysetup-wizard.c:
1059 (create_page_complete_custom): Show the second sentence of text
1060 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1063 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1065 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1066 Set the leave-on-server conf key by default. This fixes
1067 projects.maemo.org bug NB#59258 .
1069 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1071 * src/maemo/modest-account-view-window.c:
1072 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1073 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1076 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1078 * src/maemo/easysetup/modest-easysetup-wizard.c:
1079 (create_caption_new_with_asterisk):
1080 * src/maemo/modest-account-settings-dialog.c:
1081 (create_caption_new_with_asterisk):
1082 Uncomment the code to add the asterisk, because they are no longer in the
1083 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1084 (update_incoming_server_title): Add an asterisk here too.
1086 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1088 * src/maemo/modest-maemo-global-settings-dialog.c:
1089 (current_connection): Check that we are even connected before trying to
1090 get the current connection name, to prevent a warning.
1092 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1093 Change the comments because tny_maemo_conic_device_connect() is now meant to
1095 * src/modest-mail-operation.c:
1096 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1097 make sure we have a connection and fail if we can't connect.
1099 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1101 * src/maemo/modest-main-window.c:
1102 (on_account_store_connecting_finished): Do not try to get the
1103 connection ID if we are not really connected. I am surprised that
1104 this signal handler is called when we are not connected.
1106 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1108 * src/modest-error.h:
1109 * src/modest-ui-actions.c:
1110 (modest_ui_actions_get_msgs_full_error_handler):
1111 Renamed an enum, added comments, added an enum
1112 for retrieve-limit errors.
1114 * src/modest-mail-operation.c: (foreach_add_item),
1115 (internal_folder_observer_update), (update_account_thread),
1116 (modest_mail_operation_get_msgs_full):
1117 (modest_mail_operation_update_account),
1118 Added comments about how this works, and some code that should
1119 (but does not) check the retrieve-limit. See the TODO comment.
1121 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1123 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1124 Initialize help_id to fix the build. Warnings are good.
1126 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1128 * src/widgets/modest-hbox-cell-renderer.c:
1129 (modest_hbox_cell_renderer_append):
1130 * src/widgets/modest-vbox-cell-renderer.c:
1131 (modest_vbox_cell_renderer_append):
1132 Fix the last commit by doing an extra ref.
1134 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1136 * src/widgets/modest-hbox-cell-renderer.c:
1137 (modest_hbox_cell_renderer_append):
1138 * src/widgets/modest-vbox-cell-renderer.c:
1139 (modest_vbox_cell_renderer_append):
1140 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1141 to fix the build with Maemo Bora.
1142 However, there seems to be a remaining crash, probably due to reference
1145 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1147 * src/modest-tny-account.c:
1148 (modest_tny_account_new_for_local_folders):
1149 Use hildon_file_system_info_async_new() to get a better name for
1150 the memory card account, setting it as the account name.
1151 The timing seems to work, but this is probably
1152 not the best place to do this. See the TODO comment.
1153 * src/maemo/modest-main-window.c: (create_details_widget):
1154 * src/widgets/modest-folder-view.c: (text_cell_data):
1155 Use the tny account name instead of hardcoding a name.
1157 2007-05-30 Christian Kellner <ckellner@openismus.com>
1159 * src/modest-search.c: (modest_search):
1160 Correctly set part_search_func even if we have already parsed
1161 the query and thus a valid OgsTextSearcher object.
1163 2007-05-30 Christian Kellner <ckellner@openismus.com>
1166 Search and check for libogs.
1169 Incooparte the ogs build env.
1171 * src/modest-mime-part-search-stream.c:
1172 * src/modest-mime-part-search-stream.h:
1173 Removed since we do the real searching now in modest-search.c.
1175 * src/modest-search.c:
1176 * src/modest-search.h:
1177 Implement support for ogs. We use that if available and requested
1178 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1179 should now handle the corner case when the search term is spread
1180 across multiple reads.
1181 Also the logic in modest_search () was corrected to search all
1182 requested fields until one is found.
1184 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1186 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1188 * src/modest-init.h:
1189 * src/modest-init.c: Made modest_init_local_folders() take a
1190 path and be public so we can iniitialize maildir folders on
1193 * src/modest-local-folder-info.h:
1194 * src/modest-local-folder-info.c:
1195 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1197 * src/modest-tny-account.c:
1198 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1199 still means the standard local-folders path on the local volume.
1201 * src/modest-tny-account-store.c:
1202 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1203 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1204 all accounts when that happens.
1205 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1206 this too, so it shows up in the treeview.
1208 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1210 * src/maemo/modest-maemo-global-settings-dialog.c:
1211 (current_connection):
1212 * src/widgets/modest-global-settings-dialog.c:
1213 (current_connection_default):
1214 Use the enum values instead of 0, 1 and -1,
1215 to make the code clearer.
1217 * src/modest-account-mgr-helpers.c:
1218 (modest_account_mgr_get_connection_specific_smtp): Make this code
1221 * src/modest-runtime.h:
1222 * src/modest-runtime.c:
1223 Added modest_runtime_remove_all_send_queues().
1224 * src/maemo/modest-main-window.c:
1225 (on_account_store_connecting_finished): Recreate the send queues,
1226 using the appropriate transport accounts for this new connection.
1227 Some futher adapting might be needed if the old send queues are not
1228 automatically stopped at this point.
1230 * src/modest-tny-account-store.c: (get_server_accounts):
1231 Create the connection-specific transport accounts, so that they can
1232 be found later by their ID.
1234 * src/modest-tny-account.h:
1235 * src/modest-tny-account.c:
1236 Added modest_tny_account_new_from_server_account_name().
1237 modest_tny_account_new_from_server_account(): Do not create the
1238 send queues here, because they will be
1239 recreated anyway when the connection changes for the first time.
1241 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1243 * src/modest-local-folder-info.h:
1244 * src/modest-local-folder-info.c:
1245 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1246 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1247 tbox_folder): Take a modest account name instead of a server TnyAccount,
1248 so we can have per-modest-account rather than per-transport-account
1250 We must make sure that we change or recreate the exisitng send queues
1251 when the connection changes for connection-specific transport accounts.
1253 * src/modest-tny-account-store.c:
1254 (create_per_account_local_outbox_folders): Create outboxed per modest
1255 account, not per transport account.
1257 * src/modest-tny-account.h:
1258 * src/modest-tny-account.c:
1259 (modest_tny_account_get_special_folder): For outboxes, get the
1260 parent modest account name. The account is ignored for other folders.
1261 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1262 modest account name rather than a server TnyAccount.
1264 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1266 * src/modest-tny-account.c:
1267 (modest_tny_account_new_from_server_account):
1268 Call modest_runtime_get_send_queue() immediately after creating transport
1269 accounts, so that they start trying to send email from the outbox as soon
1270 as possible at startup. This is probably what we want.
1272 * src/modest-mail-operation.c: (update_account_thread):
1273 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1274 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1275 * src/modest-tny-send-queue.h:
1276 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1277 (modest_ui_actions_on_send):
1278 Added comments about how sending works, though it needs some more work.
1280 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1282 * src/modest-tny-account.c:
1283 (modest_tny_account_get_special_folder): Add TODO because this fails when
1284 the network is busy.
1285 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1286 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1287 Do not try to show this window when there is no active account. The UI
1288 specs does not tell us what to do in this case.
1290 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1294 * src/maemo/Makefile.am:
1295 * src/widgets/Makefile.am: Some dist fixes.
1297 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1299 * src/maemo/modest-connection-specific-smtp-window.c:
1300 (on_button_edit): Make the code clearer, to prevent a double free.
1302 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1304 * src/maemo/modest-account-settings-dialog.c:
1305 (modest_account_settings_dialog_set_account_name),
1306 Check the connection-specific smtp servers checkbox if there are any.
1308 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1309 (modest_connection_specific_smtp_edit_window_init):
1310 Start with a suitable port number.
1312 * src/modest-account-mgr-helpers.h:
1313 * src/modest-account-mgr-helpers.c: Added
1314 modest_account_mgr_get_has_connection_specific_smtp().
1316 (modest_account_mgr_set_connection_specific_smtp),
1317 (modest_account_mgr_remove_connection_specific_smtp),
1318 (modest_account_mgr_get_has_connection_specific_smtp),
1319 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1320 connection-specific smtp server accounts in the account, rather than
1321 the server account conf dir.
1323 This fixes bug projects.maemo.org bug NB#58263 .
1325 * src/modest-tny-account-store.c:
1326 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1327 if there are no server accounts yet, to prevent an infinite loop when there
1328 are no accounts. Document that one must be called before the other.
1330 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1332 * src/modest-account-mgr-helpers.c:
1333 (modest_account_mgr_get_default_account): Make sure that at least
1334 one account is always the default, if there are any enabled accounts.
1335 This is just a sanity check that shouldn't be necessary.
1337 * src/modest-account-mgr-priv.c:
1338 (_modest_account_mgr_account_from_key): Unescape the conf key to
1339 get the real account name. For instance, this is an issue if a space
1340 was in the account name, which can happen because the account name
1341 is generated from the display name.
1342 (_modest_account_mgr_get_account_keyname): Always escape the
1344 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1345 Unescape the conf keys to get the real account names.
1347 For instance, previously the is-default radio button in the accounts
1348 list was not checked for any accounts at first. This fixes that,
1349 and might fix several similar bugs.
1351 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1353 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1354 Removed some debug printfs.
1356 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1358 Modest on-disk outbox directories are now here, for instance:
1359 $HOME/.modest/outboxes/<account-id-1>/outbox
1360 $HOME/.modest/outboxes/<account-id-2>/outbox
1362 $HOME/.modest/local-folders/outbox
1363 so we can have a separate outbox for each account.
1364 But they are shown as one outbox in the GtkTreeView, by using a
1365 TnyMergeFolder in a ModestTnySimpleFolderStore.
1368 * src/modest-tny-simple-folder-store.c:
1369 * src/modest-tny-simple-folder-store.h:
1370 Added ModestTnySimpleFolderStore, used to contain folders from
1371 other folder stores, such as other accounts.
1373 * src/modest-tny-outbox-account.h:
1374 * src/modest-tny-outbox-account.c:
1375 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1376 used for the per-account local outbox folders.
1378 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1379 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1380 only use this (internally) now for the non-outbox local folders.
1382 * src/modest-init.h:
1383 * src/modest-init.c: Added modest_init_one_local_folder(), for
1384 setting up the directory structure for each local folder.
1386 * src/modest-local-folder-info.c:
1387 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1388 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1390 * src/modest-local-folder-info.h:
1391 * src/modest-tny-account-store.c: (on_account_removed),
1392 (on_account_changed), (create_per_account_local_outbox_folders),
1393 (get_server_accounts), (modest_tny_account_store_get_accounts),
1394 (modest_tny_account_store_get_tny_account_by_account),
1395 (modest_tny_folder_store_is_virtual_local_folders):
1397 * src/modest-tny-account.h:
1398 * src/modest-tny-account.c:
1399 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1400 to create an on-disk per-account local outbox folder for each
1402 (create_per_account_local_outbox_folders): Create a local outbox folder
1403 for each transport account.
1404 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1405 for all local folders.
1407 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1408 instead of using g_object_get/set() directly. It is clearer.
1410 (modest_tny_folder_store_get_message_count),
1411 (modest_tny_folder_store_get_local_size
1412 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1413 because we now use these with non-acount folder stores.
1415 (modest_tny_account_get_special_folder),
1416 (modest_tny_account_new_from_server_account),
1417 (modest_tny_account_new_from_account):
1418 (recurse_folders): Adjust to the new outbox system.
1420 * src/modest-tny-folder.h:
1421 * src/modest-tny-folder.c:
1422 (modest_tny_folder_is_local_folder),
1423 (modest_tny_folder_get_local_folder_type),
1424 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1426 * src/widgets/modest-main-window.h:
1427 * src/maemo/modest-main-window.c: (create_details_widget),
1428 (modest_main_window_set_contents_style): Show details for any folder store,
1431 (modest_tny_folder_get_rules):
1432 Remove the const. C does not support constness enough for this.
1434 * src/modest-ui-actions.c:
1435 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1436 make all outboxes appear as one, in the usual local-folders tree node.
1438 (set_active_account_from_tny_account),
1439 (modest_ui_actions_on_folder_selection_changed):
1440 * src/widgets/modest-folder-view.c: (text_cell_data),
1441 (icon_cell_data), (filter_row),
1442 (add_account_folders_to_merged_folder),
1443 (add_account_folders_to_simple_folder_store), (),
1444 (get_cmp_rows_type_pos), (cmp_rows),
1445 (modest_folder_view_set_account_id_of_visible_server_account):
1446 Adjust to the new outbox system, using generic folder stores and folders
1447 in the GtkTreeModel.
1449 2007-05-23 Christian Kellner <ckellner@openismus.com>
1451 * src/modest-mail-operation.c:
1452 (modest_mail_operation_update_account):
1453 Use info->max_size instead of unintialized local var [small
1454 build fix]. (Added TODO to review that change since I don't
1457 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1459 * libmodest-dbus-client/libmodest-dbus-client.c:
1460 (libmodest_dbus_client_compose_mail): function added
1461 * src/dbus_api/modest-dbus-api.h:
1462 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1463 (on_compose_mail): Implementation of the SendAsMail functionality
1465 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1467 * src/modest-account-mgr.c:
1468 (modest_account_mgr_add_server_account): Set the secure-connection
1469 conf key for transport accounts as well as store accounts. I don't know
1470 why the if was there. For instance, this makes sure that we use SSL
1471 for the gmail preset from the easysetup wizard.
1473 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1475 * src/gnome/modest-main-window.c:
1476 (on_account_store_connecting_finished), (connect_signals):
1477 * src/maemo/modest-main-window.c:
1478 (on_account_store_connecting_finished), (connect_signals),
1479 (modest_main_window_new):
1480 Handle TnyAccountStore::connecting-finished instead of
1481 TnyDevice::connection-changed, because we cannot actually perform
1482 operations on accounts until TnyAccountStore has itself responded to
1483 the TnyDevice::connection-changed signal. This prevents a GError from
1485 Do not try to update at startup, because we (at least on scratchbox)
1486 already do an update at startup when the device goes online.
1487 This prevents a GError from tinymail.
1488 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1489 Added TODO about stopping simultaneous operations.
1491 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1493 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1494 * src/modest-mail-operation-queue.c:
1495 (modest_mail_operation_queue_remove):
1496 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1497 about where they happened.
1499 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1501 * src/modest-ui-actions.c:
1502 (modest_ui_actions_on_password_requested): Make sure that the remember
1503 output parameter is always TRUE.
1505 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1507 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1508 Show a OK/Cancel dialog if the error is a question, though we still do not
1509 know anything more about what we are asking the user.
1510 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1511 Fix an uninitialized variable (helper). This is a logic error, however.
1513 2007-05-21 Christian Kellner <ckellner@openismus.com>
1515 * src/modest-search.h:
1516 Correct bit shifting in the ModestSearchFlags enum.
1518 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1520 * src/modest-tny-account.c:
1521 (modest_tny_account_new_from_server_account): Do not use the lsub and
1522 check-all hard-coded IMAP options when using POP.
1524 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1526 * src/modest-tny-account.c:
1527 (modest_tny_account_new_from_server_account):
1528 Use NULL for the secure-auth method for POP when Password auth has been
1529 specified by the user, as we already do for IMAP. "auth=Login" causes
1530 an error from camel or the server.
1532 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1534 * src/maemo/modest-account-settings-dialog.c:
1535 (create_page_account_details),
1536 (modest_account_settings_dialog_set_account_name):
1537 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1538 for the leave-on-server checkbox, rathr than just the checkbox, when
1539 the protocol is not POP.
1541 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1543 * src/widgets/modest-account-view.c:
1544 * src/widgets/modest-account-view.h:
1545 Added modest_account_view_select_account() which will be useful later
1546 to asynchronously re-select the edited account.
1548 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1550 * src/maemo/modest-account-settings-dialog.c:
1551 (modest_account_settings_dialog_set_account_name):
1552 Automatically choose the port numbers based on the secure authentication
1553 methods, if they have not been chosen before.
1554 This fixes projects.maemo.org bug NB#56273 .
1556 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1558 * src/maemo/modest-main-window-ui.h:
1559 * src/modest-ui-actions.c:
1560 * src/modest-ui-actions.h:
1561 Connect the Tools/SMTP Servers menu item to
1562 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1563 SMTP servers dialog, as in the UI specification and saves changes when it
1564 is closed. This fixed projects.maemo.org bug NB#56305 .
1566 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1568 * src/maemo/modest-connection-specific-smtp-window.c:
1569 (modest_connection_specific_smtp_window_init):
1570 Use gtk_window_set_default_size() to make this window big enough, so
1571 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1573 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1575 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1576 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1577 (modest_connection_specific_smtp_edit_window_init),
1578 Do not try to connect to a combobox signal before the combobox exists.
1579 This fixes the cras in projects.maemo.org bug NB#56288 .
1580 (modest_connection_specific_smtp_edit_window_get_settings):
1581 Remove the server_account_name parameter which was being checked for NULL
1582 though it was not used.
1584 * src/maemo/modest-connection-specific-smtp-window.c:
1585 (modest_connection_specific_smtp_window_fill_with_connections),
1586 (on_button_edit), (modest_connection_specific_smtp_window_init):
1587 Correct the number of treemodel columns to prevent a warning.
1588 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1589 libconic does not work.
1591 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1593 * src/modest-tny-account.c:
1594 (modest_tny_account_new_from_server_account):
1595 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1596 SMTP when "None" was chosen by the user. However, with my SMTP server that
1597 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1600 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1602 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1603 to explain the memory management issue with the ID in the ModestPair.
1605 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1606 (add_sending_page), (modest_account_assistant_finalize):
1607 * src/gnome/modest-gnome-global-settings-dialog.c:
1608 (create_updating_page), (create_composing_page):
1609 * src/gnome/modest-msg-edit-window.c: (get_transports),
1610 (init_window), (modest_msg_edit_window_finalize),
1611 (modest_msg_edit_window_get_msg_data):
1612 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1613 * src/gnome/modest-transport-widget.c:
1614 (modest_transport_widget_finalize), (smtp_configuration):
1615 * src/maemo/modest-maemo-global-settings-dialog.c:
1616 (create_updating_page), (create_composing_page):
1617 * src/maemo/modest-msg-edit-window.c: (get_transports),
1618 (init_window), (modest_msg_edit_window_finalize),
1619 (modest_msg_edit_window_get_msg_data),
1620 (modest_msg_edit_window_free_msg_data):
1621 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1622 (modest_store_widget_finalize):
1623 * src/maemo/modest-transport-widget.c:
1624 (modest_transport_widget_finalize), (smtp_configuration):
1625 * src/modest-main.c: (send_mail):
1626 * src/widgets/modest-combo-box.h:
1627 * src/widgets/modest-global-settings-dialog-priv.h:
1628 * src/widgets/modest-global-settings-dialog.c:
1629 (modest_global_settings_dialog_finalize):
1630 * src/widgets/modest-msg-edit-window.h:
1631 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1632 as long as the combo box, to prevent use of freed memory for the ID.
1634 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1636 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1637 get_accounts(), to make this clearer. Do not check for the enabled gconf
1638 key, because we do not use this for server accounts (at least, not yet).
1639 This allows us to send email again.
1641 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1643 * src/maemo/modest-platform.c:
1644 (on_modest_conf_update_interval_changed), (modest_platform_init):
1645 Only respond to this particular key change. All these strcmp()s cannot be
1648 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1650 * src/maemo/modest-maemo-global-settings-dialog.c:
1651 (current_connection): Prevent a crash in scratchbox when
1652 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1653 * src/maemo/modest-platform.c:
1654 (on_modest_conf_update_interval_changed), (modest_platform_init):
1655 Get the update interval from gconf and reset it when the gconf key changes.
1657 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1659 * src/modest-protocol-info.c:
1660 * src/modest-protocol-info.h: Adde enum-specific get functions,
1661 instead of using a ModestProtocolType enum parameter.
1663 * src/gnome/modest-account-assistant.c:
1664 * src/gnome/modest-store-widget.c:
1665 * src/gnome/modest-store-widget.h:
1666 * src/gnome/modest-transport-widget.c:
1667 * src/gnome/modest-transport-widget.h:
1668 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1669 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1670 * src/maemo/easysetup/modest-easysetup-wizard.c:
1671 * src/maemo/modest-account-settings-dialog.c:
1672 * src/maemo/modest-account-settings-dialog.h:
1673 * src/maemo/modest-store-widget.c:
1674 * src/maemo/modest-store-widget.h:
1675 * src/maemo/modest-transport-widget.c:
1676 * src/maemo/modest-transport-widget.h:
1677 * src/modest-account-mgr-helpers.c:
1678 * src/modest-account-mgr-helpers.h:
1679 * src/modest-account-mgr.c:
1680 * src/modest-account-mgr.h:
1681 * src/modest-tny-account.c:
1682 * src/modest-tny-folder.c:
1683 * src/widgets/modest-account-view.c:
1684 * src/widgets/modest-retrieve-combo-box.c:
1685 * src/widgets/modest-retrieve-combo-box.h:
1686 * src/widgets/modest-secureauth-combo-box.c:
1687 * src/widgets/modest-serversecurity-combo-box.c:
1688 * src/widgets/modest-serversecurity-combo-box.h:
1689 * tests/check_account-mgr.c:
1690 Use the specific functions, and use the re-renamed enum values for GNOME too.
1692 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1694 * src/modest-pair.h:
1695 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1696 so we can get the second based on the first.
1698 * src/maemo/modest-account-settings-dialog.h:
1699 * src/maemo/modest-account-settings-dialog.c:
1700 Added get_supported_secure_authentication_methods(), though it is mostly
1701 commented-out for now until the necessary API is committed to tinymail.
1702 (modest_account_settings_dialog_set_account_name),
1703 (save_configuration): Request the supported authentication methods from the
1704 server, so we can choose a working method.
1706 * src/modest-tny-account-store.h:
1707 * src/modest-tny-account-store.c:
1708 (modest_tny_account_store_get_session): Rename from
1709 tny_account_store_get_session().
1711 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1713 * src/modest-protocol-info.h: Split the ModestProtocol enum
1714 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1715 There was no need to have these unrelated values in one enum.
1717 * src/: many files: Adapted to changed enum. This makes the code a bit
1718 clearer, and the compiler could catch some errors.
1720 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1722 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1723 Show the detailed internal camel error message when an error happens
1724 during the configuration, so that our testers can give us more clues.
1725 For instance, in projects.maemo.org bug NB#56910 .
1727 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1729 * src/modest-tny-account.c:
1730 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1731 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1733 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1735 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1736 * src/maemo/modest-account-settings-dialog.c:
1737 (modest_account_settings_dialog_set_account_name),
1738 (save_configuration): For the incoming secure authentication checkbox,
1739 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1740 the UI specification. PLAIN does not seem to be supported for most IMAP
1741 servers anyway, and I am not sure what it would mean.
1742 However, we probably need to discover which of the secure-authentication
1743 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1744 * src/modest-account-mgr-helpers.c:
1745 (modest_account_mgr_get_server_account_data):
1747 * src/modest-tny-account.c:
1748 (modest_tny_account_new_from_server_account):
1749 Use tny_account_set_mech() to set secure-authentication methods,
1750 with some special-casing for IMAP, based on my observations of how
1753 * src/modest-account-mgr-helpers.h:
1754 * src/modest-account-mgr.c:
1755 * src/modest-defs.h: Comment that the URI is only used for local folders.
1757 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1759 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1760 parameter const, just to be neat.
1761 * src/modest-text-utils.c: (modest_text_utils_inline):
1762 End g_strconcat() with NULL, as its documentation says. This is almost
1763 certainly the cause of my crash at startup on the device. Interestingly,
1764 valgrind doesn't tell us about these errors.
1766 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1768 * scripts/build-packages: Added more precise comments about how to use
1769 this script, though I still get this error:
1770 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1771 error building tinymail
1773 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1775 * src/maemo/modest-main-window.c: (on_account_update):
1776 Very slight cleanup, hoping to make it simpler to discover what causes
1777 a crash here sometimes.
1779 * src/modest-tny-account.c:
1780 (modest_tny_account_new_from_server_account): Set the port. Added
1781 comments about the options and a TODO comment because I need to find out
1782 how to specify the secure authentication method.
1784 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1786 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1787 changed CFlags paths form modest to libmodest
1789 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1791 * src/modest-account-mgr-helpers.c:
1792 (modest_account_mgr_get_server_account_data),
1793 (modest_account_mgr_free_server_account_data):
1794 * src/modest-account-mgr-helpers.h:
1795 * src/modest-account-mgr.c:
1796 (modest_account_mgr_add_server_account):
1797 * src/modest-defs.h:
1798 * src/modest-tny-account.c:
1799 (modest_tny_account_new_from_server_account):
1800 Determine the options for tny_camel_account_add_option() here,
1801 based on the settings, rather than storing them directly in gconf.
1803 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1805 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1806 Show a more friendly error dialog now that we expect (from the tinymail
1807 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1809 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1811 * src/maemo/modest-main-window.c: (on_account_update): Check that
1812 account_name is not NULL, to prevent a crash at startup that I am
1813 seeing on the N800. I do wonder why it is NULL.
1815 * src/maemo/easysetup/modest-easysetup-wizard.c:
1816 (create_page_user_details):
1817 * src/maemo/modest-account-settings-dialog.c:
1818 (create_page_user_details), (create_page_outgoing):
1819 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1820 (modest_connection_specific_smtp_edit_window_init):
1821 * src/modest-ui-actions.c:
1822 (modest_ui_actions_on_password_requested):
1823 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1824 might do something useful with the on-screen keyboard.
1826 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1828 * src/maemo/modest-main-window.c: (on_account_update):
1829 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1830 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1832 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1834 * src/modest-tny-account-store.c: (on_account_changed):
1835 Correct the signature of this signal handler.
1837 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1839 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1840 Show a HildonNote instead of a GtkDialog for Maemo.
1842 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1844 * src/widgets/modest-account-view.h:
1845 * src/widgets/modest-account-view.c: (on_account_changed),
1846 (on_account_removed). Added a boolean flag, set/unset by
1847 modest_account_view_block_conf_updates(),
1848 modest_account_view_unblock_conf_updates() to prevent unnecessary
1849 updates, but this is not very useful because the gconf notifications are
1850 so delays (maybe only on Maemo Bora).
1851 So auto-updating is turned off, and these functions do an explicit
1852 update when necessary.
1853 However, something else is still doing too much work when adding/removing
1854 accounts, probably in another part of the application.
1856 * src/maemo/modest-account-view-window.c:
1857 (on_delete_button_clicked), (on_edit_button_clicked),
1858 (on_new_button_clicked): Use the new functions.
1860 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1862 * src/modest-account-mgr-helpers.c:
1863 (modest_account_mgr_set_first_account_as_default):
1864 Sort the list of names alphabetically-by-title, so we choose the first one
1866 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1867 alphabetically by the title.
1869 This fixes projects.maemo.org bug NB#56418 .
1871 * src/modest-account-mgr-priv.c:
1872 (_modest_account_mgr_account_from_key):
1873 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1874 avoid a valgrind error, and possible random behaviour.
1876 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1878 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1879 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1880 tinymail documentation to say that this can be expected.
1881 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1882 pretty, and should not happen, but I would prefer to know when it does.
1884 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1886 * configure.ac: When using the older hildon version, probably on Bora,
1887 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1889 * src/widgets/modest-attachment-view.c:
1890 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1893 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1895 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1896 Implemented the prototype. Can be tested with
1897 tests/dbus_api/test_open_message:
1899 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1901 * src/modest-tny-account-store.c:
1902 (modest_tny_account_store_instance_init), (get_password):
1903 * src/modest-ui-actions.c:
1904 (modest_ui_actions_on_password_requested):
1905 Do not store the password in gconf, because this function is called
1906 for non-remembered passwords. Actually use the cached (in the hash map)
1907 password instead of releasing it.
1908 The password will now not be remembered if it is asked via the protected
1909 password dialog, as per the UI spec.
1911 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1913 * src/modest-defs.h:
1914 * src/modest-account-mgr-helpers.h:
1915 * src/modest-account-mgr-helpers.c:
1916 Added modest_server_account_get_username_has_succeeded(),
1917 modest_server_account_set_username_has_succeeded().
1918 (modest_server_account_set_username),
1919 Reset the has-succeeded flag if the username changes.
1921 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1922 * src/maemo/modest-connection-specific-smtp-window.c:
1923 (modest_connection_specific_smtp_window_save_server_accounts):
1924 Use modest_server_account_set_username() instead of using
1925 modest_conf_set_string() directly, so that the has-succeeded flag is always
1928 * src/modest-ui-actions.c:
1929 (modest_ui_actions_on_password_requested): Dim the username entry if
1930 the username has ever worked, as per the UI spec.
1932 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1934 * src/modest-tny-account-store.c: (get_password):
1935 * src/modest-ui-actions.c:
1936 (modest_ui_actions_on_password_requested):
1937 Allow the username to be changed too, though there is more work to
1938 be done on exactly how this behaves.
1940 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1942 * src/modest-account-mgr-helpers.h:
1943 * src/modest-account-mgr-helpers.c:
1944 Added modest_account_mgr_get_display_name(),
1945 modest_server_account_get_username(),
1946 modest_server_account_set_username(),
1947 modest_server_account_set_password(),
1948 modest_server_account_get_hostname() functions so we do not need to
1949 use the conf API directly.
1951 * src/maemo/modest-main-window.c: (connect_signals):
1952 Actually connect ot the ModestAccountStore::request-password signal,
1953 so that we show the dialog when the password is requested by Tinymail,
1954 for isntance if it is empty.
1956 * src/modest-marshal.list:
1957 * src/modest-tny-account-store.c:
1958 (modest_tny_account_store_class_init), (get_password),
1959 (modest_tny_account_store_alert):
1960 * src/modest-tny-account-store.h:
1961 * src/modest-ui-actions.h:
1962 * src/modest-ui-actions.c:
1963 (modest_ui_actions_on_password_requested):
1964 Change the signal parameters, so it is obvious that we are providing
1965 the non human-readable server name, and receiving both the username
1966 and password, though changing of the username is not yet implemented.
1967 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1968 for the GNOME version.
1970 This should fix the projects.maemo.org bug NB#56209, though it does not
1971 work on Bora, because the gconf_client_get() for the password fails
1972 immediately after we save it with gconf_client_set().
1974 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1977 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1978 caused an undefined symbol error:
1979 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1981 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1983 * src/modest-tny-account-store.c:
1984 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1985 using a GError instead of a string message, so we can translate it in
1988 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1990 * src/maemo/modest-address-book.c:
1991 (modest_address_book_check_names):
1992 * src/maemo/modest-msg-view-window.c:
1993 (modest_msg_view_window_clipboard_owner_change):
1994 * src/modest-init.c: (modest_init_init_ui):
1995 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1996 (update_folders_cb), (modest_mail_operation_update_account):
1997 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1998 (modest_ui_actions_on_msg_attachment_clicked),
1999 (modest_ui_actions_on_msg_recpt_activated):
2000 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2001 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2002 (modest_msg_view_search_next):
2003 * src/widgets/modest-recpt-editor.c:
2004 (modest_recpt_editor_on_button_release_event),
2005 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2006 g_message(). At this point we should only be seeing interesting errors on
2007 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2009 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2011 (modest_wizard_dialog_force_title_update):
2012 * src/maemo/easysetup/modest-wizard-dialog.h:
2013 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2014 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2015 can update the title when appropriate. Otherwise the title is wrong if the
2016 pages are added after adding the notebook to the dialog.
2017 This must be a problem in HildonWizardDialog too.
2018 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2020 * src/maemo/easysetup/modest-easysetup-wizard.c:
2021 (create_subsequent_customsetup_pages),
2022 (create_subsequent_easysetup_pages):
2023 Call modest_wizard_dialog_force_title_update() so that the title is
2024 correct even with GTK+ < 2.10.
2025 This fixes projects.maemo.org bug NB#56145 .
2027 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2029 * src/maemo/modest-platform.c:
2030 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2031 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2034 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2036 * src/widgets/modest-window.h:
2037 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2038 and modest_window_save_state(), which invokes it.
2040 * src/widgets/modest-window-mgr.h:
2041 * src/widgets/modest-window-mgr.c:
2042 Added modest_window_mgr_save_state_for_all_windows(), which calls
2043 the save_state vfunc on all registered windows, if implemented.
2045 * src/gnome/modest-msg-edit-window.c:
2046 * src/gnome/modest-msg-view-window.c:
2047 * src/maemo/modest-msg-edit-window.c:
2048 * src/maemo/modest-msg-view-window.c:
2049 * src/maemo/modest-main-window.c:
2050 Specify the existing save_settings functions as implementations of
2051 ModestWindow::save_state_func().
2053 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2054 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2055 enabling hibernation, for instance.
2057 We may need to do the same thing for restoring settings.
2060 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2062 * src/widgets/modest-window-mgr.c:
2063 * src/widgets/modest-window-mgr.h:
2064 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2065 modest_window_mgr_get_hibernation_is_prevented().
2067 * src/maemo/modest-main-window.c:
2068 (on_hildon_program_is_topmost_notify): Prevent hibernation
2069 (possible when the application goes to the background in the WM),
2070 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2072 * src/maemo/easysetup/modest-easysetup-wizard.c:
2073 (modest_easysetup_wizard_dialog_init):
2074 * src/maemo/modest-account-settings-dialog.c:
2075 (modest_account_settings_dialog_init):
2076 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2077 (modest_connection_specific_smtp_edit_window_init):
2078 * src/maemo/modest-connection-specific-smtp-window.c:
2079 (modest_connection_specific_smtp_window_init):
2080 * src/maemo/modest-signature-editor-dialog.c:
2081 (modest_signature_editor_dialog_init):
2082 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2083 prevent hibernation while any of these account settings dialogs are open.
2085 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2087 * src/maemo/Makefile.am:
2088 * src/maemo/modest-osso-state-saving.c:
2089 * src/maemo/modest-osso-state-saving.h: Added
2090 modest_osso_load_state() and modest_osso_save_state() though they do
2091 nothing now. They should iterate through all the open windows and load/save
2093 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2094 save state when closing.
2096 * src/maemo/modest-main-window.c:
2097 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2098 Add a notification handler for the HildonProgram::is-topmost property,
2099 so we can allow hibernation when the application goes into the background.
2100 But we still need to detect when the accounts setup windows are open so
2101 we can stop hibernation when they are open.
2102 To do this, I also added the main window the HildonProgram. This might have
2103 other side-effects/benefits, and should maybe be done for other windows.
2105 * src/maemo/modest-osso-autosave-callbacks.h:
2106 * src/maemo/modest-osso-autosave-callbacks.c:
2107 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2108 though it does not do anything yet, and we might never need this to do
2109 anything. For instance, we already save drafts.
2111 * src/maemo/modest-platform.c: (modest_platform_init):
2112 Specify the libosso auto-save callback.
2114 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2116 * src/maemo/modest-platform.c:
2117 (modest_platform_set_update_interval):
2118 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2119 aparently stays valid between application instances, so we can use this
2120 to remove and reset it later. According to a maemo-developers email from
2123 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2125 * configure.ac: Depend on libalarm for Maemo.
2127 * src/dbus_api/modest-dbus-api.h:
2128 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2129 (on_send_receive), (modest_dbus_req_handler):
2130 Handle a SEND_RECEIVE D-Bus method.
2132 * libmodest-dbus-client/libmodest-dbus-client.c:
2133 (libmodest_dbus_client_send_and_receive):
2134 * libmodest-dbus-client/libmodest-dbus-client.h:
2135 Add C convenience functions for calling the new D-Bus method.
2137 * src/modest-platform.h:
2138 * src/gnome/modest-platform.c:
2139 * src/maemo/modest-platform.c:
2140 Added modest_platform_set_update_interval(), which uses the
2141 alarmd API on Maemo.
2142 (modest_platform_init),
2143 Call modest_platform_set_update_interval(), using a hard-coded
2144 interval for now (until the global settings dialog is implemented),
2145 though I am not sure that this makes sense yet.
2147 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2149 * src/dbus_api/modest-dbus-callbacks.c:
2150 (modest_osso_cb_hw_state_handler):
2151 * src/dbus_api/modest-dbus-callbacks.h:
2152 * src/maemo/modest-platform.c: (modest_platform_init):
2153 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2154 in case this has some effect on the ability for Maemo to ping the
2157 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2159 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2160 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2161 warning. It is probably a logic error, but I need to fix the build.
2163 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2165 * src/modest-account-mgr.h:
2166 * src/modest-account-mgr.c:
2167 (modest_account_mgr_account_names): Add a gboolean enabled_only
2168 parameter, so we can get lists of onlt the enabled accounts.
2170 (modest_account_mgr_add_account),,
2171 (modest_account_mgr_account_with_display_name_exists):
2172 * src/maemo/modest-msg-edit-window.c: (get_transports):
2173 * src/modest-account-mgr-helpers.c:
2174 (modest_account_mgr_set_first_account_as_default):
2175 * src/modest-init.c: (init_default_account_maybe):
2176 * src/modest-tny-account-store.c: (get_accounts):
2177 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2178 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2179 * tests/check_account-mgr.c: (START_TEST):
2180 Provide the extra parameter, as appropriate.
2182 * src/widgets/modest-account-view.c: (update_account_view):
2183 Do not show disabled accounts (meaning that there is no way to
2184 enable/disable accounts in the UI (the feature is not in our UI
2185 specification), so we can use this internally only to mark unfinished
2186 or temporary account data.
2188 * src/maemo/easysetup/modest-easysetup-wizard.c:
2189 (create_account): Add boolean enable parameter, so we can specify FALSE
2190 to create the temporary account.
2191 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2192 (on_before_next): When finishing, when there is a temporary account, just
2194 Also, use a timeout to delay the showing of the dialog until gconf is likely
2195 to return correct information, due to a maemo gconf bug that is fixed in
2196 osso 1.1, but not yet in Bora.
2197 However, the dialog stays on screen after it is destroyed.
2199 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2200 for invalid data when cancelling. Use a hildon note instead of a dialog
2201 to complain about invalid data. Do not show the account-saved note if the
2202 account is disabled (a temporary account that will not really be saved for use
2205 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2207 * src/modest-account-mgr-helpers.h:
2208 * src/modest-account-mgr-helpers.c:
2209 Added modest_account_mgr_unset_default_account(),
2210 Added modest_account_mgr_set_first_account_as_default().
2212 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2213 If it was the default account, unset the default account name.
2215 * src/maemo/modest-account-view-window.c:
2216 (on_delete_button_clicked): If it was the default account,
2217 set the first remaining account as the default instead.
2219 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2220 a NULL account or a NULL default account, to prevent a crash. This should
2221 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2224 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2226 * src/widgets/modest-recpt-editor.c:
2227 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2228 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2229 TODO comment for this. This fixes the build.
2231 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2232 be the best place for it. This will in future update all auto-update accounts,
2233 rather than just the current/default account, when that gconf key exists.
2234 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2235 if there are no accounts, before calling do_send_receive().
2236 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2238 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2239 * src/maemo/modest-main-window-ui.h:
2240 * src/maemo/modest-main-window.c: (on_connection_changed),
2241 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2242 directly, becaue the signal handler does more.
2244 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2246 * src/modest-account-mgr-helpers.c:
2247 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2248 for the case that the account does not exist.
2250 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2251 (equivalent to the modest account name) rather than the tinymail account name
2252 (equivalent to the modest account title - human readable) to get the account data.
2253 Check for null account data to prevent the crash, and add a TODO comment saying that
2254 this needs fixing because it is using the server account name instead of the account name.
2256 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2258 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2259 * src/maemo/modest-account-settings-dialog.c: (show_error),
2261 Use hildon_note_new_information() for informative and error messages,
2262 which seems to be expected for Maemo applications (no documentation that I know of
2263 says this). I am surprised that there is no distinction between info and error
2266 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2268 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2269 it is easy to find where this is used.
2271 * src/maemo/easysetup/modest-easysetup-wizard.c:
2272 (create_page_welcome), (create_page_account_details),
2273 (create_page_user_details), (create_page_complete_easysetup),
2274 (create_page_custom_incoming), (create_page_custom_outgoing),
2275 (create_page_complete_custom):
2276 * src/maemo/modest-account-settings-dialog.c:
2277 (create_page_account_details), (create_page_user_details),
2278 (create_page_incoming), (create_page_outgoing):
2279 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2280 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2281 (modest_connection_specific_smtp_edit_window_init):
2282 * src/maemo/modest-connection-specific-smtp-window.c:
2283 (modest_connection_specific_smtp_window_init):
2284 * src/maemo/modest-signature-editor-dialog.c:
2285 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2286 and scrolling policy as per the Email Application Layout Guide, if I have
2289 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2291 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2292 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2293 which were empty, because these vfuncs have been removed from TnyAccountStore.
2294 This fixes the build.
2296 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2298 * src/maemo/modest-main-window.c:
2299 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2300 showing/hiding it. Added TODO because it probably should not be NULL.
2301 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2302 because unnecessary g_warnings() make degugging difficult.
2304 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2306 * src/maemo/modest-msg-edit-window.c:
2307 (modest_msg_edit_window_select_color),
2308 (modest_msg_edit_window_select_background_color): 2 const corrections and
2309 moving 2 #endifs before closing brackets, to fix the build.
2311 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2313 * src/maemo/easysetup/modest-easysetup-wizard.h:
2314 * src/maemo/easysetup/modest-easysetup-wizard.c:
2315 (modest_easysetup_wizard_dialog_finalize),
2316 (on_button_edit_advanced_settings), (create_page_complete_custom),
2317 (on_response), (create_account):
2318 Implement the Advanced Settings edit button, by saving the account information,
2319 for the Advanded Settings dialog to use directly from gconf, and removing it
2320 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2321 Bug #5533 in the projects.maemo.org bugzilla.
2323 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2325 * src/maemo/modest-msg-view-window.c:
2326 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2327 when opening a message window.
2329 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2331 * src/maemo/easysetup/modest-easysetup-wizard.c:
2332 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2335 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2336 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2337 gconf settings. I probably added more checks than necessary, but that is safer.
2339 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2340 variable to fix the build, but this seems to be used when it is still NULL.
2342 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2344 * src/modest-platform.h:
2345 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2346 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2347 * src/modest-main.c: Implement this function so we can avoid using
2348 maemo-specific API from cross-platform code.
2350 * src/modest-tny-account-store.c:
2351 (get_smtp_specific_transport_account_for_open_connection):
2352 * src/modest-ui-actions.c: (check_for_connection),
2353 (modest_ui_actions_on_item_not_found):
2354 Use modest_platform_connect_and_wait() and put #idefs around other
2355 maemo-specific code, because only maemo currently has a way to
2356 identify connection names.
2358 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2360 * src/modest-tny-account-store.h:
2361 * src/modest-tny-account-store.c:
2362 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2363 the connection-specific SMTP server settings in the configuration.
2365 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2367 * src/maemo/modest-main-window.c: (on_connection_changed),
2369 * src/modest-main.c: (main), (start_ui), (send_mail):
2370 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2371 that is what is intended.
2373 * src/modest-ui-actions.c: (action_send), (action_receive),
2374 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2375 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2376 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2377 SMTP server is used when it is specified.
2379 (modest_ui_actions_on_send_receive):
2380 Check that a connection is open before proceeding.
2381 Receive and then send, instead of vice-versa, as per the specification.
2383 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2385 * src/modest-mail-operation.c:
2386 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2387 though I guess it should be something other than NULL.
2389 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2391 * src/maemo/easysetup/modest-easysetup-wizard.c:
2392 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2393 combo twice, to avoid an g_warning and to make it visible again.
2394 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2395 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2396 (already intended) dereference when detaching, because we then recreate the menu.
2397 But I am not sure why the warning was happening, and it is possible that this is a memory
2400 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2402 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2403 and uri_parse_mailto() utility functions.
2404 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2406 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2408 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2410 * src/dbus_api/modest-dbus-api.h:
2411 * src/dbus_api/modest-dbus-callbacks.c:
2412 Use an idle callback to execute the modest code in the application's own thread.
2413 Remove the helloworld example method.
2414 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2415 parsed, and the open-message method is not implemented because this is not yet implemented in
2417 * libmodest-dbus-client/libmodest-dbus-client.c:
2418 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2419 (libmodest_dbus_client_open_message):
2420 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2422 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2423 body without crashing.
2425 * tests/dbus_api/Makefile.am:
2426 * tests/dbus_api/test_mail_to.c:
2427 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2429 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2431 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2432 Added file to fix the build. Sorry.
2434 * src/dbus_api/Makefile.am:
2435 * src/dbus_api/modest-dbus-api.h:
2436 * src/dbus_api/modest-dbus-callbacks.h:
2437 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2438 (modest_dbus_req_handler):
2439 Put constants in a separate header so it can be reused by the
2440 client library, without duplication
2442 * libmodest-dbus-client/Makefile.am:
2443 * libmodest-dbus-client/libmodest-dbus-client.c:
2444 (libmodest_dbus_client_call_helloworld),
2445 (libmodfest_dbus_client_send_mail),
2446 (libmodfest_dbus_client_mailto),
2447 (libmodfest_dbus_client_open_message):
2448 * libmodest-dbus-client/libmodest-dbus-client.h:
2449 (Partly) Implement a send_mail D-Bus method.
2451 * tests/dbus_api/Makefile.am:
2452 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2453 the send_email D-Bus method.
2455 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2459 * libmodest-dbus-client/Makefile.am:
2460 * libmodest-dbus-client/libmodest-dbus-client.c:
2461 * libmodest-dbus-client/libmodest-dbus-client.h:
2462 * tests/dbus_api/Makefile.am:
2463 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2464 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2466 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2468 * src/maemo/easysetup/modest-easysetup-wizard.c:
2469 (create_page_account_details):
2470 * src/maemo/modest-account-settings-dialog.c:
2471 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2472 widgets, because this might not be the default in future versions of the Maemo GTK+.
2473 However, I can not not get capitalization to work even in a simple test case.
2475 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2477 * src/maemo/easysetup/modest-easysetup-wizard.c:
2478 (create_page_custom_incoming), (create_page_custom_outgoing):
2479 * src/maemo/modest-account-settings-dialog.c:
2480 (create_page_account_details), (create_page_incoming),
2481 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2482 instead of using gtk_check_button_with_label(), so they are aligned like the other
2483 widgets, as per the UI spec.
2485 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2487 * src/maemo/easysetup/modest-easysetup-wizard.c:
2488 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2489 * src/widgets/modest-validating-entry.c:
2490 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2491 Modest prefix instead of an EasySetup prefix.
2493 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2495 * src/widgets/modest-validating-entry.h:
2496 * src/widgets/modest-validating-entry.c: (on_insert_text),
2497 Added easysetup_validating_entry_set_max_func(), used to set a callback
2498 to call when the max number of characters is reached. GtkEntry has a max-length
2499 already but is silent about it.
2501 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2502 (create_page_account_details), (create_page_user_details),
2504 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2505 (create_page_account_details), (create_page_user_details),
2506 (create_page_outgoing):
2507 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2508 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2509 the UI spec, when the user tries to enter more than the max number of characters.
2511 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2513 * src/maemo/easysetup/modest-easysetup-wizard.c:
2514 (create_page_user_details), (create_page_custom_incoming),
2515 (create_page_custom_outgoing):
2516 * src/maemo/modest-account-settings-dialog.c:
2517 (create_page_user_details), (create_page_incoming),
2518 (create_page_outgoing):
2519 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2520 (modest_connection_specific_smtp_edit_window_init):
2521 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2522 not appropriate. Bad Maemo-specific defaults!.
2524 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2526 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2527 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2528 (modest_signature_editor_dialog_set_settings):
2529 Disable the label and textview when the checkbox is disabled, and use the
2530 specified (UI spec) default signature text.
2532 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2534 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2535 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2537 * src/modest-defs.h:
2538 * src/modest-account-mgr-helpers.h:
2539 * src/modest-account-mgr-helpers.c:
2540 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2542 * src/maemo/Makefile.am:
2543 * src/maemo/modest-signature-editor-dialog.c:
2544 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2547 * src/maemo/modest-account-settings-dialog.h:
2548 * src/maemo/modest-account-settings-dialog.c:
2549 (modest_account_settings_dialog_finalize), (on_button_signature),
2550 (save_configuration): Use the new dialog when the Edit button is pressed, and
2551 save the changes if necessary, as per the UI spec.
2553 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2555 * src/maemo/Makefile.am:
2556 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2557 based on maemo-develoers email from Dirk.
2559 * src/maemo/easysetup/modest-easysetup-wizard.c:
2560 (create_page_welcome), (create_page_account_details),
2561 (create_page_user_details), (create_page_complete_easysetup),
2562 (create_page_custom_incoming), (create_page_custom_outgoing),
2563 (create_page_complete_custom),
2564 (modest_easysetup_wizard_dialog_init):
2565 * src/maemo/modest-account-settings-dialog.c:
2566 (create_page_account_details), (create_page_user_details),
2567 (create_page_incoming), (create_page_outgoing),
2568 (modest_account_settings_dialog_init):
2569 * src/maemo/modest-connection-specific-smtp-window.c:
2570 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2572 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2574 * src/maemo/easysetup/modest-easysetup-wizard.c:
2575 (create_page_account_details), (create_page_custom_outgoing),
2576 (create_page_complete_custom):
2577 * src/maemo/modest-account-settings-dialog.c:
2578 (create_page_user_details), (create_page_incoming),
2579 (create_page_outgoing):
2580 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2581 (modest_connection_specific_smtp_edit_window_init):
2582 Use the correct (UI spec) port min/max, and use horizontal separators,
2585 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2587 * src/maemo/easysetup/modest-easysetup-wizard.c:
2588 (set_default_custom_servernames):
2589 * src/maemo/modest-account-settings-dialog.c:
2590 (create_page_incoming), (on_combo_outgoing_security_changed),
2591 (on_combo_incoming_security_changed), (create_page_outgoing),
2592 (modest_account_settings_dialog_set_account_name),
2593 (save_configuration):
2594 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2595 (on_combo_security_changed),
2596 (modest_connection_specific_smtp_edit_window_init),
2597 (modest_connection_specific_smtp_edit_window_set_connection),
2598 (modest_connection_specific_smtp_edit_window_get_settings):
2599 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2602 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2605 * src/maemo/easysetup/modest-easysetup-wizard.c:
2606 (create_page_custom_outgoing), (create_page_complete_custom):
2607 * src/maemo/modest-account-settings-dialog.c:
2608 (create_page_user_details), (create_page_outgoing):
2609 * src/maemo/modest-account-view-window.c: (button_box_new):
2610 Use changed logical IDs as per the most recent UI spec:
2611 mcen_bd_emailsetup_edit -> mcen_bd_edit
2612 mcen_bd_emailsetup_delete -> mcen_bd_delete
2613 mcen_bd_emailsetup_close -> mcen_bd_close
2615 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2619 * src/dbus_api/Makefile.am:
2620 * src/dbus_api/modest-dbus-callbacks.c:
2621 * src/dbus_api/modest-dbus-callbacks.h:
2622 * src/maemo/modest-platform.c: (modest_platform_init):
2623 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2625 * tests/Makefile.am:
2626 * tests/dbus_api/Makefile.am:
2627 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2629 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2631 * src/maemo/modest-account-settings-dialog.c:
2632 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2633 Removed unnecessary includes.
2635 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2637 * src/maemo/easysetup/modest-easysetup-wizard.c:
2638 * src/maemo/modest-account-settings-dialog.c:
2639 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2640 * src/widgets/Makefile.am:
2641 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2642 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2643 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2644 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2645 * src/widgets/modest-secureauth-combo-box.c:
2646 * src/widgets/modest-secureauth-combo-box.h:
2647 * src/widgets/modest-serversecurity-combo-box.c:
2648 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2649 made the GObject names more consistent with the rest of the Modest code.
2651 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2653 * src/maemo/easysetup/Makefile.am:
2654 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2655 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2656 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2657 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2658 * src/maemo/easysetup/modest-easysetup-wizard.c:
2659 * src/maemo/easysetup/modest-validating-entry.c:
2660 * src/maemo/easysetup/modest-validating-entry.h:
2661 * src/maemo/modest-account-settings-dialog.c:
2662 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2663 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2664 widgets/ because they are used outside of easysetup too. After checking in,
2665 svn will allow me to rename them too.
2667 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2669 * src/gnome/modest-msg-edit-window.c:
2670 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2671 linker error, to fix the build on the GNOME platform.
2672 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2673 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2674 ifdefed out to avoid a warning.
2676 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2678 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2679 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2680 some alternative for GTK+ 2.6.
2682 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2684 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2686 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2687 specified for EmailAccountsDialog in UI spec.
2689 * src/maemo/easysetup/modest-easysetup-wizard.c:
2690 * src/maemo/easysetup/modest-easysetup-wizard.h:
2691 * src/maemo/modest-account-settings-dialog.c:
2692 * src/maemo/modest-account-settings-dialog.h:
2693 Reuse a member window widget for the connection-specific SMTP server accounts,
2694 so we can tell it to create/save the accounts only if we actually save changes.
2696 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2697 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2698 (modest_connection_specific_smtp_edit_window_get_settings):
2699 Return a struct instance for temporarily remembering the entered data.
2701 * src/maemo/modest-connection-specific-smtp-window.h:
2702 * src/maemo/modest-connection-specific-smtp-window.c:
2703 (modest_connection_specific_smtp_window_finalize),
2704 (modest_connection_specific_smtp_window_fill_with_connections),
2706 (modest_connection_specific_smtp_window_save_server_accounts),
2707 (update_model_server_names): Do not actually save data until asked,
2708 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2710 (on_selection_changed),
2711 (modest_connection_specific_smtp_window_init): Disable the edit
2712 button when nothing is selected.
2714 * src/modest-account-mgr-helpers.c:
2715 * src/modest-account-mgr-helpers.h:
2716 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2719 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2721 * src/modest-account-mgr-helpers.h:
2722 * src/modest-account-mgr-helpers.c:
2723 (modest_account_mgr_get_unused_account_name),
2724 (modest_account_mgr_get_unused_account_display_name): Added these
2725 utility functions, to avoid code duplication.
2727 * src/maemo/easysetup/modest-easysetup-wizard.c:
2728 (create_page_account_details), (create_account):
2729 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2730 (on_combo_security_changed),
2731 (modest_connection_specific_smtp_edit_window_init),
2732 (modest_connection_specific_smtp_edit_window_save_settings):
2733 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2734 * src/maemo/modest-connection-specific-smtp-window.c:
2735 (modest_connection_specific_smtp_window_finalize),
2736 (modest_connection_specific_smtp_window_fill_with_connections),
2737 (on_button_edit), (modest_connection_specific_smtp_window_init):
2738 * src/maemo/modest-connection-specific-smtp-window.h:
2739 Implementing saving of connection-specific server accounts.
2741 But I need to refactor this so we can save the data for each
2742 possible connection-specific account and only actually create the server accounts
2743 when the easysetup finished, or the OK button is pressed on the account settings
2746 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2748 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2749 (on_combo_security_changed):
2750 (modest_connection_specific_smtp_edit_window_init):
2751 Auto-fill the port number as in the account settings.
2753 (modest_connection_specific_smtp_edit_window_set_connection):
2754 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2755 * src/maemo/modest-connection-specific-smtp-window.c:
2756 (fill_with_connections), (on_button_edit),
2757 (modest_connection_specific_smtp_window_init):
2758 Turn the edit window into a dialog to simplify the code, and
2759 set a WM hint as in a GtkDialog, because only a popup can be on top of
2760 another window in Maemo, and popups usually have no WM decoration.
2762 * src/modest-defs.h:
2763 * src/modest-account-mgr-helpers.c:
2764 (modest_account_mgr_set_connection_specific_smtp),
2765 (modest_account_mgr_remove_connection_specific_smtp),
2766 (modest_account_mgr_get_connection_specific_smtp):
2767 * src/modest-account-mgr-helpers.h: Some functions to write the
2768 connection-specific SMTP server information. Not yet used.
2771 * src/widgets/modest-folder-view.c: (text_cell_data):
2772 Fix a warning about an uninitialized variable.
2773 (on_configuration_key_changed): Put an #ifdef around the use
2774 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2776 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2778 * src/maemo/modest-account-settings-dialog.h:
2779 * src/maemo/modest-account-settings-dialog.c:
2780 Added connect_for_modified() utility function to mark the new modified boolean.
2782 (create_page_account_details), (create_page_user_details),
2783 (create_page_incoming), (create_page_outgoing), (on_response),
2784 (modest_account_settings_dialog_init),
2785 (modest_account_settings_dialog_set_account_name):
2786 Only warn about unsaved changes when there are actually unsaved changes.
2788 * src/modest-account-mgr-helpers.c:
2789 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2790 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2791 to get the data from there in future.
2793 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2795 * src/modest-defs.h:
2797 * src/modest-account-mgr-helpers.h:
2798 * src/modest-account-mgr-helpers.c:
2799 Store the security account setting in a single conf key instead of using
2800 the options list, so that the list is left for just the to-be-removed camel hack,
2801 and because gconf_client_set_list() is failing for some reason.
2803 * src/modest-account-mgr.c:
2804 (modest_account_mgr_add_server_account):
2805 * src/maemo/modest-account-settings-dialog.c:
2806 (modest_account_settings_dialog_set_account_name),
2807 (save_configuration): Use the renamed functions.
2810 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2812 * src/widgets/Makefile.am:
2813 * src/widgets/modest-limit-retrieve-combo-box.c:
2814 * src/widgets/modest-limit-retrieve-combo-box.h:
2815 * src/widgets/modest-retrieve-combo-box.c:
2816 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2817 the account settings dialog.
2819 * src/modest-defs.h:
2820 * src/modest-account-mgr-helpers.h:
2821 * src/modest-account-mgr-helpers.c:
2822 (modest_server_account_get_option_secure_auth),
2823 (modest_server_account_set_option_secure_auth):
2824 * src/modest-account-mgr.c:
2825 (modest_account_mgr_add_server_account):
2826 Use the existing AUTH_MECH conf key for the secure-auth setting,
2827 instead of putting it in the list options, because this was actually used already.
2829 * src/maemo/modest-account-settings-dialog.c:
2830 (create_page_account_details),
2831 (modest_account_settings_dialog_set_account_name),
2832 (save_configuration):
2833 * src/maemo/modest-account-settings-dialog.h:
2834 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2835 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2837 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2839 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2840 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2841 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2843 * src/modest-defs.h:
2844 * src/maemo/modest-account-settings-dialog.c:
2845 (create_page_incoming), (on_combo_outgoing_security_changed),
2846 (on_combo_incoming_security_changed), (create_page_outgoing),
2847 (modest_account_settings_dialog_set_account_name),
2848 (save_configuration): Load/Save the port number, and change it when the
2849 security combo changes, to suitable defaults.
2851 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2853 * src/modest-account-mgr.c:
2854 (modest_account_mgr_add_server_account): Set the security and secure-auth
2855 options, and add a comment saying that the other camel-specific options should be
2858 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2860 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2862 * src/modest-tny-account-store.c: (account_list_free),
2863 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2864 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2867 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2869 * src/modest-protocol-info.c:
2870 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2871 is required by our UI spec. Maybe something in our implementation will use this eventually.
2872 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2873 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2874 instead of the previous 0 placeholder.
2876 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2877 secure-auth settings.
2878 * src/modest-account-mgr-helpers.h:
2879 * src/modest-account-mgr-helpers.c:
2880 (modest_server_account_data_get_option_secure_auth),
2881 (modest_server_account_set_option_secure_auth),
2882 (modest_server_account_data_get_option_security),
2883 (modest_server_account_set_option_security): Added this API for getting and setting the security
2884 and secure-auth settings.
2886 * src/maemo/modest-account-settings-dialog.h:
2887 * src/maemo/modest-account-settings-dialog.c:
2888 (modest_account_settings_dialog_finalize), (check_data),
2889 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2890 about changing titles.
2891 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2892 (save_configuration): Save the security and secure-auth settings.
2894 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2895 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2897 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2899 * src/modest-defs.h:
2900 * src/modest-account-mgr.c:
2901 (modest_account_mgr_add_server_account):
2902 Added and used defines for the options key and value pair strings,
2903 that are used so far, though they do not seem to correspond to anything in our
2904 UI specs or ModestProtocol enum.
2906 * src/modest-account-mgr-helpers.h:
2907 * src/modest-account-mgr-helpers.c:
2908 (compare_option_strings_for_name),
2909 (modest_server_account_data_get_option_value),
2910 (modest_server_account_data_get_option_bool),
2911 (modest_account_mgr_get_server_account_option):
2912 Added helper functions for parsing the options GSList.
2914 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2916 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2917 display name is based on the supplied account name.
2918 * src/modest-account-mgr.c:
2919 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2920 with an inefficient, but good-enough, implementation.
2922 * src/maemo/easysetup/modest-easysetup-wizard.c:
2923 (create_page_account_details), (on_before_next), (create_account):
2924 Check for existing display names rather than (non-user-visible) account names, and just
2925 create and set a unique account name at the end.
2927 * src/maemo/modest-account-settings-dialog.c:
2928 (modest_account_settings_dialog_init),
2929 (modest_account_settings_dialog_set_account_name),
2930 (create_page_incoming): Show the display name, instead of the account name.
2931 (on_response): Do some (not all) extra checks, as in the UI spec.
2932 (save_configuration): Save the display name if it was changed.
2934 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2936 * po/en_GB.po: Added needed logical ID and translation.
2937 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2938 (init_view): Made the is-default column clicking work.
2940 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2943 * src/maemo/easysetup/Makefile.am:
2944 * src/maemo/easysetup/modest-easysetup-wizard.c:
2945 (modest_easysetup_wizard_dialog_init):
2946 * src/maemo/easysetup/provider-data-test.keyfile:
2947 * src/maemo/easysetup/provider-data.keyfile:
2948 Moved the provider data file to the new modest-providers-data package and used it from there.
2950 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2952 * src/modest-local-folder-info.c:
2953 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2954 N_() was already used on the static strings, but this just marks it for translation without
2955 using the translation.
2957 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2959 * src/maemo/modest-account-settings-dialog.c:
2960 (create_page_incoming),
2961 (modest_account_settings_dialog_set_account_name):
2962 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2963 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2964 I will do this if nobody else gets there first.
2966 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2968 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2969 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2970 save the security stuff.
2972 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2974 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2975 Set the email address and user fullname, which I now see must be
2978 * src/maemo/modest-account-settings-dialog.h:
2979 * src/maemo/modest-account-settings-dialog.c:
2981 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2982 leave-on-server and authentication.
2983 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2986 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2989 * src/maemo/modest-account-settings-dialog.c:
2990 * src/maemo/modest-account-settings-dialog.h:
2991 Most (but not all) of the widgets are now present as specified by the UI spec.
2992 No changes are yet saved, and some details are not properly shown yet.
2994 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2996 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2998 * src/maemo/Makefile.am:
2999 * src/maemo/modest-account-settings-dialog.c:
3000 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3001 an existing account. Doesn't do much yet.
3003 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3004 Open the accounts settings dialog when Edit is clicked.
3006 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3008 * src/maemo/easysetup/Makefile.am:
3009 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3011 * src/maemo/easysetup/modest-easysetup-wizard.c:
3012 (modest_easysetup_wizard_dialog_init):
3013 Try to get the source directory from the build system,
3014 instead of hard-coding "./" into the source code, when opening our local
3015 copies of the configuration files.
3016 But this still fails when opening the wizard from the Accounts window,
3017 maybe because the working directory seems to change at runtime.
3018 So the wizard will fail the second time unless you copy the files into their
3019 proper locations - see the stdout warnings for the paths.
3021 (create_page_account_details),(on_before_next):
3022 Check for existing non-server accounts instead of server accounts,
3023 so the default account name is useful again, and to prevent trying to
3026 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3027 Show the wizard when New is clicked.
3029 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3030 (init_view): Show the column headers, and show the columns that are
3031 specified in the UI specs. However, something in Maemo's GTK+ prevents
3032 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3033 change the default account. This is despite unsetting the special properties.
3035 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3037 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3038 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3039 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3040 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3041 to make that clearer.
3042 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3044 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3046 * src/maemo/modest-account-view-window.c:
3047 (modest_account_view_window_init),
3048 (modest_account_view_window_new):
3049 Use the same buttons as specified in the
3050 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3051 the existing widgets, which never had a chance of working.
3052 Put the ModestAccountView treeview in a scrolled window.
3053 Do not repeat the initialization in both _init() and _new().
3055 * src/widgets/modest-account-view.c: (update_account_view):
3056 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3057 this widget and window shows no accounts.
3059 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3061 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3063 * src/maemo/easysetup/modest-easysetup-wizard.c:
3064 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3065 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3066 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3069 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3070 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3071 accounts exist yet, as in the UI spec.
3073 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3075 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3077 * src/maemo/Makefile.am:
3078 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3079 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3080 New window for editing connection-specific smtp details.
3081 Not fully implemented.
3083 * src/maemo/modest-connection-specific-smtp-window.c:
3084 (modest_connection_specific_smtp_window_finalize) :
3085 unref the tree model.
3086 (on_button_edit): Show the edit window.
3088 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3090 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3093 * src/maemo/Makefile.am:
3094 * src/maemo/modest-connection-specific-smtp-window.c:
3095 * src/maemo/modest-connection-specific-smtp-window.h:
3096 New window for showing the list of connections, for connection-specific
3097 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3098 * src/maemo/easysetup/modest-easysetup-wizard.c:
3099 (create_page_custom_outgoing): Show the new window when the button is clicked.
3101 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3103 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3104 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3105 * src/maemo/modest-msg-edit-window.c:
3106 (modest_msg_edit_window_insert_image):
3107 * src/modest-conf.c: (modest_conf_key_escape):
3108 * src/modest-mail-operation.c:
3109 (modest_mail_operation_send_new_mail):
3110 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3111 (modest_ui_actions_on_new_account):
3112 * src/widgets/modest-attachment-view.c: (update_filename_request):
3113 * src/widgets/modest-mail-header-view.c:
3114 Corrected warnings that were breaking the build, by commenting out unused variables,
3115 and a function, and by including a header.
3117 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3119 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3120 so we can #ifdef around platform-specific code when necessary.
3121 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3122 to allow this to build for the GNOME platform too.
3124 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3126 * src/maemo/easysetup/modest-easysetup-wizard.c:
3127 Added util_increment_name() and used it in create_page_account_details()
3128 to make sure that the default account name is always a new name.
3130 (modest_easysetup_wizard_dialog_init),
3131 (set_default_custom_servernames): Some minor memory management fixes.
3133 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3137 * src/modest-runtime.c: (init_i18n): Restored the translation
3138 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3139 are defined in config.h, and the translations are installed.
3141 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3142 is defined for translation.
3144 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3146 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3148 * src/maemo/easysetup/modest-easysetup-wizard.c:
3149 (modest_easysetup_wizard_dialog_init):
3150 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3151 Use realistic paths (though they should use $prefix generically) to the
3152 mcc_mapping and provider-data.keyfile files which might work when they
3153 are installed by the future version of the operator-wizard package,
3154 and then fallback to paths in our source code, with an explanatory
3157 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3161 * src/maemo/Makefile.am:
3162 * src/maemo/easysetup/: Added files from the previously-exernal
3163 osso-modest-easysetup.
3164 * src/maemo/modest-main-window-ui.h:
3165 * src/modest-ui-actions.c:
3166 * src/modest-ui-actions.h:
3167 Added modest_ui_actions_on_new_account() as a signal handler for the
3168 New Account menu item. It shows the easysetup wizard.
3169 * po/en_GB.po: Added additional needed logical IDs and translations.