1 2007-07-27 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
4 Offer a connection dialog if there is no connection when
5 starting modest. This should fix projects.maemo.org bug NB#61134.
7 2007-07-27 Murray Cumming <murrayc@murrayc.com>
9 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
10 Reverted my last commit. I was able to fix the build by doing
11 apt-get install wpeditor0 (replacing other wpeditor packages) and
12 an explicit apt-get install wpeditor-dev to upgrade the -dev
15 2007-07-27 Murray Cumming <murrayc@murrayc.com>
17 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
18 Commented out the use of wp_text_buffer_replace_image()
19 because it does not exist, to break the build. Added a TODO for it.
21 2007-07-26 Murray Cumming <murrayc@murrayc.com>
23 * src/modest-tny-account-store.c: (recreate_all_accounts):
24 Recreate them even if they were NULL before. I guess something
25 else was already creating them before, or this would never
27 (modest_tny_account_store_get_server_account): Make sure that
28 the tny accounts have been created before trying to find one.
29 This allows libmodest_dbus_client_compose_mail() to work
30 when the UI is not yet visible.
31 This is probably useful in other cases too.
33 (get_password): When the password is wrong after it is entered
34 in the protected password dialog, show an info banner (in an
35 idle handler) before showing the protected password dialog
38 2007-07-26 Murray Cumming <murrayc@murrayc.com>
40 * src/modest-ui-actions.h:
41 * src/modest-ui-actions.c: Added
42 modest_do_refresh_current_folder() containing some code from
43 modest_ui_actions_on_send_receive().
44 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
45 Call modest_do_refresh_current_folder() before refreshing the
46 requested account, as in modest_ui_actions_on_send_receive().
47 This is strange, but seems to be necessary to show new mails.
48 Now new emails are finally visible in the UI when downloaded
49 via the automatic update interval, fixing bug NB#57458.
50 This also works because bug NB#57458 has been fixed somehow.
52 2007-07-26 Murray Cumming <murrayc@murrayc.com>
54 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
55 printf more details when we get unhandled D-Bus methods, because
58 * src/modest-mail-operation.c: (update_account_thread):
59 Comment out the tny_camel_pop_store_account_reconnect(), because this
60 is apparently no longer needed, and it did not work before anyway.
61 See the comment in the code.
63 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
64 by checking the header flags. This fixes projects.maemo.org bug
67 2007-07-25 Murray Cumming <murrayc@murrayc.com>
69 * src/maemo/modest-maemo-utils.h:
70 * src/maemo/modest-maemo-utils.c: Added
71 modest_maemo_show_information_note_in_main_context_and_forget().
72 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
73 Use the new function to show simple error dialogs in the main
74 context, though question dialogs are still in the current context,
75 which is unfortunately usually not the main context. This should
78 2007-07-25 Murray Cumming <murrayc@murrayc.com>
80 * src/modest-tny-account-store.c: (get_password):
81 Never save the entered username and password in gconf,
82 because the UI spec says we should not. This helps
83 slightly with projects.maemo.org bug NB#63671.
85 2007-07-25 Murray Cumming <murrayc@murrayc.com>
87 * src/widgets/modest-msg-edit-window.h:
88 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
89 Moved some code here to make it simpler.
90 (modest_msg_edit_window_attach_file_one): Renamed from
91 modest_msg_edit_window_attach_file_interactive().
92 (modest_msg_edit_window_offer_attach_file): Renamed from
93 modest_msg_edit_window_attach_file() and used
94 modest_msg_edit_window_attach_file_one() instead of
95 copy/pasting the code. The old code for one was not using
96 GnomeVFS. This allows use of smb:// URLs when using send-as
97 from external applications, fixing bug NB#63741.
99 (modest_msg_edit_window_insert_image),
100 (modest_msg_edit_window_add_attachment_clicked):
101 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
102 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
103 Adapted to the new function names.
105 2007-07-25 Murray Cumming <murrayc@murrayc.com>
107 (modest_platform_set_update_interval): Set the alarm recurrence
108 fields so that auto-update does not just happen the first time.
109 This should have fixed projects.maemo.org bug NB#63938.
111 When this happens you can see a printf when the D-Bus method is
113 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
115 However, I do not actually seem to get new POP messages even when
116 clicking the refresh button manually. A restart gets them.
117 This might be a problem in today's tinymail only.
119 2007-07-24 Murray Cumming <murrayc@murrayc.com>
121 * src/maemo/modest-maemo-global-settings-dialog.c:
122 (current_connection):
123 Avoid a crash (probably only in scratchbox) when strcmp()ing a
124 NULL when closing the dialog.
126 2007-07-24 Murray Cumming <murrayc@murrayc.com>
128 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
129 Remove the hacky send/receive that didn't work, and instead
130 refilter the treemodel to make the deleted email really vanish from
131 the UI (though the delete-from-menu code does has commented out
132 the code that does that). This fixes projects.maemo.org bug
135 2007-07-24 Murray Cumming <murrayc@murrayc.com>
137 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
138 Try a couple of tricks to force the treeview to update (
139 poke the folder, and do a send/receive refresh), but the deleted
140 email still appears with a strike-through instead of really being
143 2007-07-23 Murray Cumming <murrayc@murrayc.com>
145 * src/dbus_api/modest-dbus-callbacks.c:
146 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
147 because their ID is not human-readable (see the comment about
148 improvements needed to the osso-email-interface API) and
149 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
151 2007-07-23 Murray Cumming <murrayc@murrayc.com>
153 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
154 (add_folders_to_list), (on_dbus_method_get_folders),
155 (modest_dbus_req_filter):
156 * src/maemo/modest-maemo-utils.c:
157 (on_camel_account_get_supported_secure_authentication):
158 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
159 (on_header_view_focus_in):
160 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
161 * src/modest-formatter.c: (modest_formatter_create_body_part):
162 * src/modest-mail-operation.c: (recurse_folders),
163 (update_account_thread), (get_msgs_full_thread),
164 (modest_mail_operation_get_msgs_full),
165 (modest_mail_operation_xfer_msgs):
166 * src/modest-search.c: (search_mime_part_and_child_parts),
167 (modest_search_account), (modest_search_all_accounts):
168 * src/modest-tny-account.c:
169 (modest_tny_account_get_special_folder), (recurse_folders):
170 * src/modest-tny-local-folders-account.c:
171 (modest_tny_local_folders_account_query_passes):
172 * src/modest-tny-msg.c: (copy_mime_part),
173 (modest_tny_msg_find_body_part_from_mime_part):
174 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
175 (modest_tny_send_queue_try_to_send):
176 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
177 (_modest_ui_actions_open), (download_uncached_messages),
178 (reply_forward), (modest_ui_actions_on_copy),
179 (modest_ui_actions_on_details), (has_retrieved_msgs),
180 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
182 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
183 (_selected_msg_marked_as), (_msg_download_completed),
184 (_selected_msg_sent_in_progress):
185 * src/widgets/modest-attachments-view.c:
186 (modest_attachments_view_set_message):
187 * src/widgets/modest-msg-view.c: (find_cid_image):
188 * tests/check_folder-transfer.c: (find_folders):
189 * tests/check_update-account.c: (func):
190 * tests/dbus_api/test_get_folders.c: (main):
191 Checked all uses of tny_iterator_get_current(), making sure
192 that the object is unreferenced (3 or 4 places did not),
193 and adding checks for NULL.
195 2007-07-23 Murray Cumming <murrayc@murrayc.com>
197 * src/dbus_api/modest-dbus-callbacks.c:
198 (on_idle_open_default_inbox): Make sure that the application UI is
200 * src/maemo/easysetup/modest-easysetup-wizard.c:
201 (on_entry_invalid_character): Show the word whitespace instead
202 of (null) in the banner when whitespace was entered.
203 (show_error): Add a comment that this does not work in
204 Maemo Bora, though we do not know why.
206 2007-07-23 Murray Cumming <murrayc@murrayc.com>
208 * src/modest-tny-account.c:
209 (modest_tny_account_get_special_folder): Use an if instead of
210 an assert for when the parent account name is NULL, because this
211 might be causing a crash in projects.maemo.org bug 63192.
212 * src/modest-mail-operation.c:
213 (modest_mail_operation_send_new_mail_cb),
214 (modest_mail_operation_remove_folder): unref the folder that is
215 returned from modest_tny_account_get_special_folder().
217 2007-07-23 Murray Cumming <murrayc@murrayc.com>
219 * src/modest-ui-actions.c:
220 (modest_ui_actions_on_password_requested):
221 Show mail_ib_login_cancelled info banner when the user cancels
222 the protected password dialog, to fix projects.maemo.org
225 2007-07-23 Murray Cumming <murrayc@murrayc.com>
227 * src/maemo/modest-account-settings-dialog.c:
228 (create_page_outgoing): Put this page in a GtkScrolledWindow,
229 matching the UI mock-up in the UI spec, and allowing access
230 to all widgets even when the on-screen keyboard is active.
232 2007-07-23 Murray Cumming <murrayc@murrayc.com>
234 Reverted this previous commit from Johannes,
235 because the scrollbars are always visible and because
236 I think we only need it on onepage of the account
237 settings, not the account wizard.
238 (I wrote the wrong instructions in the bug.)
240 * src/maemo/easysetup/modest-easysetup-wizard.c:
241 Added scrollbars to account wizard dialog.
242 Fixed projects.maemo.org NB #62744
244 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
246 * src/maemo/easysetup/modest-easysetup-wizard.c:
247 (create_page_user_details):
248 Use auto-cap for name (projects.maemo.org NB#63716)
249 * src/widgets/modest-account-view.c: (on_account_busy_changed):
251 2007-07-22 Armin Burgmeier <armin@openismus.com>
253 * src/maemo/modest-ui-actions.c: Use current account instead of
254 default account for creating viewer windows, so that the viewer
255 window knows to which account the viewed message belongs.
257 * src/maemo/modest-msg-view-window.c: Destroy the window when the
258 corresponding account is deleted. This fixes projects.maemo.org bug
261 2007-07-18 Armin Burgmeier <armin@openismus.com>
263 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
264 the dialog close after entering an invalid port number and clicking
265 OK. This fixes projects.maemo.org bug NB#63602.
267 2007-07-18 Armin Burgmeier <armin@openismus.com>
269 * src/modest-tny-account-store.c:
270 (get_server_accounts): Set parent modest account name for each
271 connection-specific transport account so that special folders of such
272 an account can be looked up. This fixes a crash when changing account
273 settings. This might also be related to projects.maemo.org bug
276 2007-07-16 Armin Burgmeier <armin@openismus.com>
278 * src/modest-ui-actions.c: Added a button to create a folder to the
279 move-to dialog. This fixes projects.maemo.org bug NB#.
281 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
283 * src/maemo/easysetup/modest-easysetup-wizard.c:
284 Added scrollbars to account wizard dialog.
285 Fixed projects.maemo.org NB #62744
287 2007-07-16 Murray Cumming <murrayc@murrayc.com>
289 * src/widgets/modest-msg-view.h:
290 * src/widgets/modest-msg-view.c:
291 Added modest_msg_view_get_message_is_empty() but this needs
293 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
294 Check if there is any text in the message yet.
295 But this needs to be implemented properly.
296 (modest_msg_edit_window_toggle_find_toolbar):
297 * src/maemo/modest-msg-view-window.c:
298 (modest_msg_view_window_toggle_find_toolbar):
299 Show a banner warning if there is no text to search, when
300 trying to start a search. This partially fixes
301 projects.maemo.org bug NB#62350.
303 2007-07-13 Murray Cumming <murrayc@murrayc.com>
305 * src/modest-mail-operation.c: (update_account_thread):
306 Initialized num_new_headers to fix the build.
308 2007-07-13 Murray Cumming <murrayc@murrayc.com>
310 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
311 Ignore modest accounts whose server accounts don't exist in gconf.
312 This prevents us trying to create TnyAccount instances for those
313 server accounts when the server account has been removed from gconf,
314 but the parent modest account has not yet been removed from modest.
315 I don't know why this is only noticeable now. It was probably just
316 a harmeless g_warning() anyway.
318 2007-07-13 Murray Cumming <murrayc@murrayc.com>
320 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
321 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
323 2007-07-12 Armin Burgmeier <armin@openismus.com>
325 * src/maemo/modest-main-window.c: Make default account appear bold
326 in view, tools/send & receive and toolbar/send & receive SCM menus.
327 This fixes projects.maemo.org bug NB#59010.
329 2007-07-12 Murray Cumming <murrayc@murrayc.com>
331 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
332 Add a short-cut, by checking if the folder store is an account.
333 This ensures that the Sort menu item and toolbar is dimmed for
334 the local-folders account root item, fixing
335 projects.maemo.org bug NB#62545.
337 2007-07-12 Murray Cumming <murrayc@murrayc.com>
339 * src/modest-tny-account-store.c: (get_password):
340 Show the password dialog (via the signal) only in the mainloop, via
341 an idle handler that we wait for. This could theoretically prevent
342 hangs, though I worry that it could introduce some too.
344 2007-07-12 Murray Cumming <murrayc@murrayc.com>
346 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
347 * src/maemo/modest-platform.c:
348 (modest_platform_connect_and_wait):
349 Take a TnyAccount* parameter and try to set it to online
350 (a TnyCamel-only API), because tinymail sets accounts to offline
351 when the user cancels a password dialog, and doesn't ask again until
352 it has been set to online.
353 However, this is commented out because it causes a hang now.
355 (modest_platform_connect_and_wait_if_network_account):
356 * src/modest-mail-operation.c:
357 (modest_mail_operation_update_account):
358 * src/modest-platform.h:
359 * src/modest-ui-actions.c: (_modest_ui_actions_open),
360 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
362 2007-07-12 Armin Burgmeier <armin@openismus.com>
364 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
366 * src/modest-mail-operation.c:
367 * src/modest-ui-actions.c: Check for already existing folder before
368 querying the server, show error message from camel if the request
369 still fails. This fixes projects.maemo.org bug NB#58701.
371 2007-07-12 Murray Cumming <murrayc@murrayc.com>
373 * src/modest-tny-account-store.h:
374 * src/modest-tny-account-store.c:
375 Added modest_tny_account_store_forget_password_in_memory(),
376 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
377 when creating a new account, so that new passwords will be used, instead of
378 us thinking that it's a second request as a result of a failed password again.
380 2007-07-12 Murray Cumming <murrayc@murrayc.com>
382 * src/dbus_api/modest-dbus-callbacks.c:
383 (on_idle_open_message): If the message is in drafts then open it
384 in an edit window instead of a view window. This fixes
385 projects.maemo.org bug NB#63005.
387 2007-07-12 Murray Cumming <murrayc@murrayc.com>
389 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
390 Avoided a harmless g_warning().
392 2007-07-12 Murray Cumming <murrayc@murrayc.com>
394 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
395 Pass the modest account name, not the TnyAccount display name to
396 modest_msg_view_window_new() so that the reply feature works,
397 fixing projects.maemo.org bug NB#62892.
399 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
400 (modest_msg_view_window_new_with_header_model):
401 * src/maemo/modest-msg-view-window.c:
402 (modest_msg_view_window_new_with_header_model),
403 (modest_msg_view_window_new):
404 * src/modest-ui-actions.c: (reply_forward):
405 * src/widgets/modest-msg-view-window.h:
406 * src/widgets/modest-window.c: (modest_window_set_active_account):
407 Rename an account parameter to modest_account_name to make this clearer.
409 2007-07-11 Murray Cumming <murrayc@murrayc.com>
411 * src/modest-ui-actions.h:
412 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
413 modest_do_message_delete().
414 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
415 Call modest_do_message_delete(), hoping that this would cause messages
416 to be really deleted from search instead of just marked with strike through.
417 Does not seem to help.
419 2007-07-11 Armin Burgmeier <armin@openismus.com>
421 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
422 priv->reselect to FALSE prior to calling
423 modest_folder_view_select_first_inbox_or_local() to prevent endless
424 recursion and thus a crash on startup.
426 2007-07-11 Armin Burgmeier <armin@openismus.com>
428 * src/maemo/modest-account-settings-dialog.h: Include
429 <gtk/gtknotebook.h> to fix the build (at least for me).
431 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
432 Use "New FolderN" as default suggested name if "New folder" already
433 exists, with N being the first free number, though never exceed "New
434 folder99" in which case we just fall back to "New Folder" even though
435 it already exists. This fixes projects.maemo.org bug NB#58663.
437 2007-07-11 Murray Cumming <murrayc@murrayc.com>
439 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
440 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
441 projects.maemo.org bug NB#62778.
443 2007-07-11 Murray Cumming <murrayc@murrayc.com>
445 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
446 Ignore the wrong (for now) secure-smtp setting in the presets -
447 just default to requiring secure authentication for SMTP, because
450 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
452 * src/widgets/modest-folder-view.c: (filter_row)
453 Do not show drafts folder (see UI specs)
455 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
457 * src/modest-ui-actions.c:
458 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
459 place and also not necessary.
461 * src/widgets/modest-folder-view.c: (filter_row)
462 Guess folder type and hide Sent & Outbox if necessary.
463 Fixed project.maemo.org NB#57328
465 2007-07-11 Murray Cumming <murrayc@murrayc.com>
467 * src/modest-ui-actions.h:
468 * src/modest-ui-actions.c:
469 (modest_ui_actions_on_delete_message):
470 Move some code into a new
471 modest_ui_actions_refresh_message_window_after_delete()
472 function so we can use it from elsewhere.
474 * src/dbus_api/modest-dbus-callbacks.c:
475 (on_idle_delete_message), (on_delete_message): Used an idle
476 handler, as we do for the other D-Bus method handlers.
477 Call modest_ui_actions_refresh_message_window_after_delete()
478 if the deleted message was open in a window. This fixed
479 projects.maemo.org bug NB#62862.
481 2007-07-11 Murray Cumming <murrayc@murrayc.com>
483 * src/modest-main.c: (main): Only show the UI at the start if
484 the showui command line option was given. For instance,
485 run-standalone src/modest showui
486 Otherwise, we wait for the top_application D-Bus method to
487 be sent by hildon-desktop when the application is selected
489 This allows us to run without a UI when osso-global-search
490 uses our D-Bus methods.
492 2007-07-11 Murray Cumming <murrayc@murrayc.com>
494 * src/dbus_api/modest-dbus-api.h: Added a define for a
495 top-application D-Bus method.
496 * src/dbus_api/modest-dbus-callbacks.c:
497 (on_top_application),
498 (modest_dbus_req_handler): Handle the top-application D-Bus
499 method, which might be an undocumented D-Bus signal sent by
500 hildon-desktop when it starts the application from the menu.
501 But I am not sure and I need to test it on the device, because
502 my scratchbox does not have the application in the menu now.
503 This method shows the main window, so that it can be invisible
504 when started, for instance, just for email searching from
507 * src/maemo/modest-main-window.c: (restore_settings),
508 (modest_main_window_new): Do not show the window immediately
509 upon creation. We show it later.
510 * src/modest-widget-memory.c: (save_settings_paned):
511 Try (unsuccessfully) to avoid saving the paned position when
512 it is not even visible.
513 (restore_settings_paned): Do not allow a silly paned position.
514 This seems necessary when not showing the window at first.
516 * tests/dbus_api/Makefile.am:
517 * tests/dbus_api/test_top_application.c: (main): Test for the
520 2007-07-10 Murray Cumming <murrayc@murrayc.com>
522 * src/modest-ui-dimming-rules.c:
523 (modest_ui_dimming_rules_on_new_msg),
524 (modest_ui_dimming_rules_on_reply_msg),
525 (modest_ui_dimming_rules_on_delete_msg),
526 (modest_ui_dimming_rules_on_details),
527 (modest_ui_dimming_rules_on_view_window_move_to),
528 (modest_ui_dimming_rules_on_view_previous),
529 (modest_ui_dimming_rules_on_view_next),
530 (_invalid_folder_for_purge): Added checks before
531 casting the window. This looks like an actual
532 logic error in _invalid_folder_for_purge(), because it
533 tries to use a ModestMainWindow as a message window.
535 2007-07-10 Murray Cumming <murrayc@murrayc.com>
537 * src/maemo/modest-account-settings-dialog.c:
538 (show_error): Use the same implementation as in
539 modest-easysetup-wizard.c:
540 (on_entry_invalid_character): The logical ID contains a %s.
541 Guessed what it should be.
542 (on_entry_max), (check_data), (on_response): Adapt to
543 changed show_error().
544 (create_page_account_details): Really call
545 modest_validating_entry_set_func() on the correct widgets.
546 * src/maemo/easysetup/modest-easysetup-wizard.c:
547 (on_entry_invalid_character): Fix the logical ID here too.
548 (create_page_account_details),
549 (create_page_user_details):
551 modest_validating_entry_set_func() on the correct widgets.
553 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
554 Do not try to use the account if it is NULL.
556 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
558 * src/modest-ui-actions.c: (create_move_to_dialog),
559 (modest_ui_actions_on_main_window_move_to),
560 (modest_ui_actions_on_msg_view_window_move_to):
561 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
562 (filter_row), (modest_folder_view_show_non_move_folders):
563 * src/widgets/modest-folder-view.h:
565 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
566 the Sent folder yet as it does not report the correct folder type.
568 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
570 * src/maemo/modest-msg-edit-window.c: (init_window):
573 2007-07-10 Murray Cumming <murrayc@murrayc.com>
575 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
576 Take a parent widget instead of a parent window, and
577 implement this with hildon_banner_show_information() instead.
578 Non-Maemo builds can just ifdef that there.
579 This fixed projects.maemo.org bug NB#62766.
581 (on_entry_invalid_character): Use show_error() again instead
582 of using hildon directly, and use the _CS() macro to use the correct
584 (create_account), (check_for_supported_auth_methods), (on_entry_max):
585 Pass a widget instead od a window to show_error().
587 2007-07-10 Murray Cumming <murrayc@murrayc.com>
589 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
590 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
591 This allows us to show the server name in the error message, fixing
592 projects.maemo.org bug NB#62904.
593 Also, use the appropriate logical ID message for the account protocol.
595 2007-07-10 Murray Cumming <murrayc@murrayc.com>
597 * src/modest-tny-account-store.c: (on_idle_wrong_password):
598 A compilation fix, though the build wasn't broken for me.
600 2007-07-09 Murray Cumming <murrayc@murrayc.com>
602 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
603 Do not try to unref a NULL folder store, to avoid a runtime warning.
604 This seems to happen sometimes when changing accounts settings.
606 2007-07-09 Murray Cumming <murrayc@murrayc.com>
608 * src/modest-tny-account-store.c:
609 (modest_tny_account_store_instance_init),
610 (modest_tny_account_store_finalize),
611 (on_account_settings_hide), (on_idle_wrong_password):
612 Use a GHashTable to ensure that we only show one account settings
613 dialog per modest account. This avoids us having a dialog open for
614 both the store and transport accounts, or due to repeated get_password()
615 calls that shouldn't happen anyway.
617 2007-07-09 Murray Cumming <murrayc@murrayc.com>
619 * src/maemo/modest-maemo-utils.c: (on_hide),
620 (modest_maemo_show_dialog_and_forget): Handle the response, because
621 the window is not even hidden by default.
623 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
624 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
625 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
626 which seems to prevent some modality problems.
628 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
629 Ignore user cancellation errors.
631 * src/modest-account-mgr-helpers.h:
632 * src/modest-account-mgr-helpers.c:
633 Added modest_server_account_get_password() and
634 modest_server_account_get_has_password() to avoid direct use of
637 * src/maemo/modest-account-settings-dialog.h:
638 * src/maemo/modest-account-settings-dialog.c:
639 (modest_account_settings_dialog_init): Store the notebook so we can
641 Added modest_account_settings_dialog_switch_to_user_info().
643 * src/modest-tny-account-store.c:
644 (get_password): When the password in the account settings is wrong (we think),
645 show the relevant page of the account settings dialog, in the mainloop.
646 However, we currently get many of these at once because cancel does not
648 (forget_password): Do not forget the password
649 from the account settings, because this causes side-effects when
650 tinymail seems to call it at strange time, maybe because of how we
651 are cancelling get_password().
652 (modest_tny_account_store_alert): Ignore user cancellations.
654 2007-07-09 Murray Cumming <murrayc@murrayc.com>
656 * src/maemo/modest-maemo-utils.h:
657 * src/maemo/modest-maemo-utils.c:
658 Added modest_maemo_show_information_note_and_forget() for use instead of
659 gtk_dialog_run() when the response is not needed, to avoid an extra
660 mainloop which could cause a hang.
662 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
663 Use the logical IDs for the error message, though they are not
664 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
665 because gtk_dialog_run() caused a hang here (the window did not close).
666 This fixes projects.maemo.org bug NB#62646.
668 2007-07-09 Murray Cumming <murrayc@murrayc.com>
670 * src/modest-account-mgr-helpers.h:
671 * src/modest-account-mgr-helpers.c:
672 Added modest_account_mgr_get_store_protocol().
674 * src/maemo/modest-account-view-window.c:
675 (on_delete_button_clicked): Show different warning text depending on
676 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
677 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
680 2007-07-09 Murray Cumming <murrayc@murrayc.com>
682 * src/maemo/modest-msg-edit-window.c:
683 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
684 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
686 2007-07-07 Armin Burgmeier <armin@openismus.com>
688 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
689 ckdg_ib_maximum_characters_reached from correct package.
691 * src/modest-ui-actions.c: Show an error message when a folder could
692 not be created. Tinymail does not give us specific error codes about
693 what has gone wrong, so we assume that a folder with that name
694 already exists, though there might be other reasons.
696 2007-07-06 Murray Cumming <murrayc@murrayc.com>
698 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
699 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
700 give a more exact error message that can be partly translated.
702 2007-07-05 Murray Cumming <murrayc@murrayc.com>
704 * src/maemo/modest-address-book.c:
705 (select_email_addrs_for_contact): Specify a default window size for the
706 select-email-address dialog, so that it is probably big enough for the
707 title. This should fix projects.maemo.org bug NB#62277.
709 2007-07-05 Murray Cumming <murrayc@murrayc.com>
711 * src/maemo/easysetup/modest-easysetup-wizard.c:
712 (create_page_complete_easysetup): Use
713 gtk_widget_set_size() request to ensure that the text wraps
716 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
718 * src/maemo/easysetup/modest-easysetup-wizard.c:
719 (on_entry_invalid_character), (create_page_account_details),
720 (create_page_user_details):
721 Use new API of ModestValidatingEntry. But for some reason the banner is
722 not shown. I will have to investigate that further.
724 * src/widgets/modest-validating-entry.c: (on_insert_text),
725 (modest_validating_entry_set_func):
726 * src/widgets/modest-validating-entry.h:
727 Added a new callback function to be able to react to prevented
728 characters whitespaces to e.g show a banner.
730 2007-07-05 Armin Burgmeier <armin@openismus.com>
732 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
733 notification of HildonNumberEditor instead of remembering the port
734 number. Thanks to Johannes for pointing this out.
736 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
738 * src/maemo/easysetup/modest-easysetup-wizard.c:
739 Check if there are any user changes before showing a confirmation
740 dialog (projects.maemo.org NB#60946)
742 2007-07-05 Armin Burgmeier <armin@openismus.com>
744 * src/maemo/modest-account-settings-dialog.c: Remember custom port
745 number at the beginning of the dialog and set the modified flag at the
746 end if the port number has changed. This is necessary because
747 HildonNumberEditor does not support notification when the value has
750 2007-07-05 Murray Cumming <murrayc@murrayc.com>
752 * src/modest-ui-actions.c:
753 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
754 a connection before asking anything else. Correct the check for the destination
755 folder so that it succeeds when online.
756 This fixed projects.maemo.org bug NB#61645.
758 2007-07-05 Murray Cumming <murrayc@murrayc.com>
760 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
761 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
762 to fix projects.maemo.org bug NB#62439.
764 2007-07-05 Murray Cumming <murrayc@murrayc.com>
766 * src/modest-tny-account.c: (on_connection_status_changed):
767 Really do not use tny_device_force_offline() here. See the previous comment.
769 2007-07-04 Murray Cumming <murrayc@murrayc.com>
771 * src/modest-tny-account.c: (on_connection_status_changed):
772 Do not use tny_device_force_offline() when tinymail says that something
773 went wrong with the connection. It seems to report this unnecessarily.
775 2007-07-04 Murray Cumming <murrayc@murrayc.com>
777 * src/maemo/modest-connection-specific-smtp-window.c:
778 (modest_connection_specific_smtp_window_init):
779 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
780 does not seem to have any effect in osso 1.1 (though it works in
781 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
783 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
785 * src/maemo/modest-connection-specific-smtp-window.c:
786 Fix UI specification problems with projects.meamo.org NB#60479
788 2007-07-04 Murray Cumming <murrayc@murrayc.com>
790 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
791 clue when this has failed, because the error dialog is not always shown
792 (at least in earlier version).
794 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
795 GError message, because the generic error dialog is not helpful.
797 'This message is not currently available (can't let a new connection go online)'
798 when trying to open an IMAP message.
800 (_modest_ui_actions_open): Offer a connection when some messages would
801 have to be downloaded and we are offline.
803 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
805 * src/widgets/modest-folder-view.c:
806 Don't check for MERGE type anymore as we use the correct type
808 NOTE: For the last two changes you need to update your tinymail copy
809 because of API changes!
811 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
813 * src/modest-tny-local-folders-account.c:
814 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
815 (see projects.maemo.org NB#61580)
817 2007-07-04 Murray Cumming <murrayc@murrayc.com>
819 * src/modest-tny-account.c: (on_connection_status_changed):
820 Commented out the call to modest_platform_connect_and_wait() because this
821 seems to always hang, and I would like to know if this is the only thing
822 that causes a hang when showing the connection dialog.
823 It is not very useful anyway.
825 2007-07-04 Murray Cumming <murrayc@murrayc.com>
827 * src/maemo/modest-msg-view-window.c:
828 (modest_msg_view_window_select_next_message):
830 * src/modest-platform.h:
831 * src/maemo/modest-platform.c:
832 Added modest_platform_connect_and_wait(), which calls
833 tny_maemo_conic_device_connect() always in the main thread, by calling it
834 in an idle handler and waiting for the idle handler to run. It should be
835 in the main thread because it uses GTK+ UI code. It just returns TRUE
836 if the device is already online.
838 There is some nasty code to ensure that subsequent calls to
839 modest_platform_connect_and_wait() just wait for the first one to finish,
840 by checking repeatedly in another idle handler. This is necessary,
841 because other threads (or even the main thread, via another idle handler)
842 can call modest_platform_connect_and_wait() while
843 modest_platform_connect_and_wait() is running.
845 (modest_platform_connect_and_wait_if_network_account),
846 (modest_platform_connect_and_wait_if_network_folderstore):
847 Convenience functions that calls modest_platform_connect_and_wait() if
848 the account or folder might want network access.
850 * src/modest-mail-operation.c:
851 (modest_mail_operation_update_account):
852 * src/modest-ui-actions.c: (download_uncached_messages),
853 (modest_ui_actions_on_rename_folder), (delete_folder),
854 (modest_ui_actions_on_main_window_move_to),
855 (modest_ui_actions_on_msg_view_window_move_to):
856 * src/widgets/modest-folder-view.c:
857 (drag_and_drop_from_folder_view):
858 Offer a connection if we are offline.
860 * src/modest-tny-account.c: (on_connection_status_changed):
861 Document this as only handling errors during network operations in progress,
862 and replace the idle code with a simple call to
863 modest_platform_connect_and_wait(), which does this instead.
865 2007-07-03 Murray Cumming <murrayc@murrayc.com>
867 * src/modest-tny-account.c:
868 (modest_tny_account_get_special_folder): (util_on_idle),
869 Handle the GError so we can see when tny_folder_store_get_folders()
870 fails, as it currently does while something else is connecting.
872 Added util_run_in_main_thread_and_wait()
873 which uses an idlen handler and mainloop to ensure that the function
874 is called in the main thread.
875 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
876 to make sure that we call attempt the connection in the mainloop only,
877 which might solve some hangs.
879 2007-07-03 Murray Cumming <murrayc@murrayc.com>
881 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
882 be found by their display name. This is never useful.
883 * src/modest-tny-account-store.c: (on_account_removed): Find the account
884 by its ID, instead of trying to use its ID as its display name.
886 * src/modest-tny-account-store.h:
887 * src/modest-tny-account.c:
888 (modest_tny_account_get_special_folder): Add a g_warning() when
889 tny_folder_store_get_folders() returns an empty list for the maildir.
891 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
892 Add a g_warning() when this returns NULL, because that it not allowed
895 2007-07-02 Armin Burgmeier <armin@openismus.com>
897 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
898 note when trying to cancel the wizard. This fixes projects.maemo.org
901 2007-07-02 Murray Cumming <murrayc@murrayc.com>
903 * src/modest-tny-account.h:
904 * src/modest-tny-account.c:
905 (modest_tny_account_new_from_server_account),
906 (modest_tny_account_new_from_server_account_name),
907 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
908 because this must now be set before setting the proto. This is usd in
909 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
910 warning in camel_session_get_service() caused by
911 tny_camel_transport_account_prepare().
913 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
916 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
918 * src/maemo/modest-connection-specific-smtp-edit-window.c:
920 (modest_connection_specific_smtp_edit_window_init):
922 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
925 2007-06-29 Murray Cumming <murrayc@murrayc.com>
927 * src/modest-tny-account.c:
928 (modest_tny_account_new_from_server_account):
929 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
930 now uses to request a connection when it needs one, and which it uses
931 to tell us that something is wrong with the connection, so we can force
932 the accounts offline to prevent further problems.
935 * src/modest-init.c: (init_default_settings):
936 * src/modest-mail-operation.c:
937 (modest_mail_operation_update_account):
938 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
939 This should not be necessary anymore. Do not set the conf key that
940 determined this (it was always TRUE and not set anywhere else).
942 * src/modest-ui-actions.h: Remove unused and unimplemented
943 modest_ui_actions_on_online_toggle_toggled().
945 2007-06-29 Murray Cumming <murrayc@murrayc.com
947 * src/maemo/modest-main-window.c: (connect_signals):
948 Don't connect to delete_event twice. Maybe this was harmless.
950 2007-06-29 Murray Cumming <murrayc@murrayc.com
952 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
953 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
954 Debug output to give some more clue when a folder move is not allowed.
956 2007-06-28 Murray Cumming <murrayc@murrayc.com
958 * src/modest-tny-account.c: (on_modest_file_system_info),
959 (modest_tny_account_get_mmc_account_name):
960 Always call the callback, without checking whether the name has changed.
961 * src/widgets/modest-folder-view.c: (strings_are_equal),
962 (on_model_foreach_set_name), (on_get_mmc_account_name),
963 (text_cell_data): Compare the name here, and use the name from
964 the account rather than from the
965 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
966 if the name was changed after the account was added to the model.
967 That's a tinymail bug but not one that I want to fix now.
969 This finally fixes projects.maemo.org bug NB#59301.
971 2007-06-27 Armin Burgmeier <armin@openismus.com>
973 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
976 2007-06-27 Murray Cumming <murrayc@murrayc.com
978 * src/modest-tny-account.h:
979 * src/modest-tny-account.c:
980 Added modest_tny_account_get_mmc_account_name(), to set the memory
981 card name asynchronously for the given account and then notify.
982 (modest_tny_account_new_for_local_folders): Use this new function instead
983 of using hildon_file_system_info_async_new() directly.
985 * src/widgets/modest-folder-view.c: (text_cell_data):
986 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
987 gtk_tree_model_row_changed() when it is available.
989 This should fix projects.maemo.org bug NB#59301.
991 2007-06-27 Murray Cumming <murrayc@murrayc.com
993 * src/modest-mail-operation.c: (update_account_thread),
994 (get_msgs_full_thread): Fix typo failures in the revert
997 2007-06-27 Murray Cumming <murrayc@murrayc.com
999 * src/maemo/modest-maemo-global-settings-dialog.c:
1000 (idle_select_default_focus):
1001 * src/modest-mail-operation.c: (idle_notify_progress),
1002 (idle_notify_progress_once), (set_last_updated_idle),
1003 (update_account_thread), (get_msgs_full_thread):
1004 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1005 * src/widgets/modest-header-view.c:
1006 (idle_notify_headers_count_changed_destroy),
1007 (idle_notify_headers_count_changed):
1008 Reverted the additions of gdk_threads_enter/leave(), in case this
1009 helps with a startup hang on the device.
1011 2007-06-26 Armin Burgmeier <armin@openismus.com>
1013 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1014 for supported secure authentication methods from server by
1015 gtk_dialog_run(), saving CPU time and a potential race condition.
1017 2007-06-26 Armin Burgmeier <armin@openismus.com>
1019 * src/maemo/modest-maemo-utils.h:
1020 * src/maemo/modest-maemo-utils.c: Added a
1021 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1022 only error code to tell the calling code when the user canceled the
1025 * src/maemo/modest-account-settings-dialog.h:
1026 * src/maemo/modest-account-settings-dialog.c:
1027 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1028 message if the retrieval of secure authentication methods was canceled
1029 by the user. Perform the check before saving anything to configuration
1030 to not end up with half-committed configuration changes, do not show
1031 a "Saving to configuration failed" note when authentication methods
1032 could not be retrieved.
1034 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1037 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1039 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1040 Only return the first level of folders under accounts, because the
1041 osso-global-search UI spec doesn't want the rest.
1042 This fixed projects.maemo.org bug NB#61811.
1044 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1046 * src/modest-tny-account-store.c:
1047 * src/modest-tny-account-store.h:
1048 Added modest_tny_account_is_memory_card_account().
1049 * src/maemo/modest-main-window.c: (create_details_widget):
1050 Show the same information items for the memory card as we show for the
1051 local-folders, to fix projects.maemo.org bug NB#59307.
1053 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1055 * src/modest-tny-account-store.c: (get_password):
1056 Added some checks for NULL to maybe prevent crashes, though I think
1057 it was Philip's last commit that actually prevented the crash here
1058 when creating a first new account.
1059 But the new account is still not usable (no messages are shown)
1060 until a restart of the application.
1062 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1064 * src/maemo/modest-maemo-global-settings-dialog.c:
1065 (idle_select_default_focus):
1066 * src/modest-mail-operation.c: (idle_notify_progress),
1067 (idle_notify_progress_once), (idle_notify_update_account_queue),
1068 (set_last_updated_idle), (update_account_thread),
1069 (notify_get_msgs_full), (get_msgs_full_destroyer),
1070 (get_msgs_full_thread):
1071 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1072 * src/widgets/modest-header-view.c:
1073 (idle_notify_headers_count_changed_destroy),
1074 (idle_notify_headers_count_changed):
1075 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1076 all idle handlers, because some other thread could be blocking
1077 the GDK lock, so that it can do GUI stuff.
1079 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1081 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1082 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1083 (on_idle_send_receive), (on_idle_open_default_inbox):
1084 * src/maemo/modest-msg-edit-window.c:
1085 (modest_msg_edit_window_attach_file_noninteractive):
1086 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1087 to prevent a hang. I don't quite understand why these are necessary,
1088 beause we should already be in the main loop. I guess something outside
1089 of the main loop is taking the lock.
1091 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1092 we are really using URIs, and use files that are more likely to exist.
1094 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1096 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1097 necessary because configure.ac now defines different variables.
1099 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1101 * libmodest-dbus-client/libmodest-dbus-client.c:
1102 * libmodest-dbus-client/libmodest-dbus-client.h:
1103 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1104 libmodest_dbus_client_compose_mail() is what things actually use.
1106 * src/dbus_api/modest-dbus-api.h:
1107 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1108 * tests/dbus_api/Makefile.am:
1109 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1112 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1114 * src/modest-init.c: (modest_init_local_folders):
1115 For memory-card (or other non local-folders) maildir accounts,
1116 always create an Archive folder, so that there is somewhere to put
1117 messages. This should be less confusing, because the user does not need
1118 to guess that the need to create a folder.
1120 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1122 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1123 Fixed icon size by using (50, 50) which is the same as defined by
1126 2007-06-25 Armin Burgmeier <armin@openismus.com>
1128 * src/widgets/modest-window-mgr.c:
1129 * src/modest-init.c:
1130 * configure.ac: Correctly recognize hildon-notify presence and fixed
1131 the build without it being installed.
1133 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1135 * libmodest-dbus-client/libmodest-dbus-client.c:
1136 (libmodest_dbus_client_search): Fix the build. Sorry.
1137 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1138 (reply_forward_cb): Initialize variables to fix the build.
1140 * src/modest-tny-account-store.c:
1141 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1142 comparison (a silly typo) so that email search results can be opened
1143 when there are more than one account.
1145 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1147 * libmodest-dbus-client/libmodest-dbus-client.c:
1148 (libmodest_dbus_client_search),
1149 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1150 instead of 1 second, because the search gets folders and messages from
1151 the server, which can take a long time. When it times out,
1152 osso-global-search will report no results.
1154 We need to specify whether we should search only cached information
1155 (maybe with a user preference), and the osso-email-search-plugin
1156 API should really be improved to allow that option, and to allow results
1157 to be delivered asynchronously in batches.
1159 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1161 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1162 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1163 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1165 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1167 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1168 that is an empty string. D-Bus seems to give us these instead of NULL.
1170 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1172 * src/dbus_api/modest-dbus-callbacks.c:
1173 * src/maemo/easysetup/modest-easysetup-wizard.h:
1174 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1175 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1176 (modest_connection_specific_smtp_edit_window_init):
1177 * src/maemo/modest-maemo-global-settings-dialog.c:
1179 * src/maemo/modest-maemo-utils.c:
1180 (modest_maemo_utils_setup_images_filechooser):
1181 * src/maemo/modest-main-window.c: (create_details_widget):
1182 * src/maemo/modest-msg-edit-window.c:
1183 (modest_msg_edit_window_attach_file_noninteractive),
1184 (modest_msg_edit_window_color_button_change),
1185 (modest_msg_edit_window_set_zoom):
1186 * src/modest-mail-operation.c: (update_account_thread):
1187 * src/modest-tny-account-store.c:
1188 * src/modest-tny-account.c:
1189 * src/widgets/modest-global-settings-dialog.c:
1190 * src/widgets/modest-window.h:
1192 Fixed build on bora!
1194 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1196 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1197 * src/modest-search.c: (modest_search_folder),
1198 (modest_search_all_accounts): Actually search only in the specified folder,
1199 doing a simple match on the folder ID.
1200 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1201 and added some documentation.
1203 2007-06-22 Armin Burgmeier <armin@openismus.com>
1205 * src/maemo/modest-maemo-utils.h:
1206 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1207 modest_maemo_utils_get_supported_secure_authentication_methods.
1209 * src/maemo/easysetup/modest-easysetup-wizard.c:
1210 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1211 one occured, not just "Server does not support secure authentication".
1213 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1215 * src/modest-tny-account-store.c: (get_password):
1216 Restored the call to tny_account_set_user() because Philip seems to have
1217 stopped this from crashing (by not using the freed string). It still does
1218 not work, but now we can test it.
1220 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1222 * src/maemo/modest-msg-edit-window.c: (init_window):
1223 Comment out use of an uninitialzed GtkScrolledWindow variable,
1224 to fix the build and stop a crash. Yet again.
1226 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1228 * src/modest-tny-account-store.c: (get_password):
1229 Remove the call to tny_account_set_user() because this actually crashes.
1230 As mentioned in the last commit, it is known to not work anyway.
1232 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1234 * src/modest-tny-account-store.c: (get_password):
1235 Use tny_account_set_username() to tell tinymail that the username might
1236 have changed too. But tinymail ignores this: see projects.maemo.org
1238 * src/modest-ui-actions.c:
1239 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1240 reset the connection when changing the username, and improve the comments.
1241 Save the changed username to gconf at least, so it is used when Modest is
1244 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1246 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1247 Do not use a query, so that we get all folders, including for POP and
1248 local-folders. They work as search criteria too.
1249 This fixes projects.maemo.org bug NB#57740.
1251 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1253 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1254 Comment out the use of hildon_notification_set_sound() because it is
1255 not declared, to fix the build. Warnings are serious, people.
1257 2007-06-21 Armin Burgmeier <armin@openismus.com>
1259 * src/maemo/modest-maemo-utils.h:
1260 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1261 modest_maemo_utils_get_supported_secure_authentication_methods()
1262 to query authentication methods for a specific user. This should fix
1263 projects.maemo.org bug NB#61369.
1265 * src/maemo/easysetup/modest-easysetup-wizard.c:
1266 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1269 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1271 * libmodest-dbus-client/libmodest-dbus-client.h:
1272 * libmodest-dbus-client/libmodest-dbus-client.c:
1273 (modest_dbus_message_iter_get_search_hit),
1274 (libmodest_dbus_client_search):
1275 Reorganised and commented this.
1276 Removed modest_search_hit_free() from the public API because it
1279 Added libmodest_dbus_client_get_folders() and
1280 modest_folder_result_list_free().
1282 * src/dbus_api/modest-dbus-api.h:
1283 * src/dbus_api/modest-dbus-callbacks.c:
1284 (modest_dbus_req_filter): Commented. Moved most code to
1285 on_dbus_method_search() and added on_dbus_method_get_folders().
1287 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1288 of the extra D-Bus handler.
1290 * tests/dbus_api/Makefile.am:
1291 * tests/dbus_api/test_get_folders.c: New test for
1292 libmodest_dbus_client_get_folders(). This seems to return an empty list
1293 at the moment. That could be the same error that causes the message list
1294 to be empty sometimes.
1295 This should help with projects.maemo.org bug NB#57740.
1297 2007-06-21 Armin Burgmeier <armin@openismus.com>
1299 * src/modest-mail-operation.c: Do not call
1300 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1301 notify the operation's end after having set the status to CANCELED for
1302 the operation queue to listen on. This fixes a deadlock when there
1303 were mail operations in the queue during its finalization.
1305 * src/modest-singletons.c: Reordered uninitialization of the account
1306 manager to happen after the mail operation queue was uninitialized
1307 because the mail operation's in the queue might still try to access
1308 the account manager (see modest_mail_operation_notify_end()). This
1309 fixes a potential crash when terminating the application.
1311 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1313 * src/modest-search.c:
1314 (search_mime_part_and_child_parts): Moved some code here so we
1315 can search recursively in child folders.
1316 (modest_search_folder): Search in the message as a mime part, instead
1317 of just its child mime parts.
1318 (read_chunk), (search_mime_part_ogs):
1319 Check how many bytes were read, to prevent an endless loop.
1320 Searching in message bodies now works. This finishes the fix for
1321 projects.maemo.org bug NB#61007.
1323 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1325 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1326 Add a g_warning when the item is not a folder.
1328 * src/modest-ui-dimming-rules.c:
1329 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1330 when selected item is not a folder (for instance, an account), because
1331 the UI spec only talks about folders.
1332 I am not sure what the UI spec wants, so this might not totally fix
1333 projects.maemo.org bug NB#60794.
1335 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1337 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1338 (load_from_file): Sort the list. The unsorted list would be more noticeable
1339 in non-English locales.
1341 * src/maemo/modest-msg-edit-window.c:
1342 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1343 warning and fix the build.
1345 * src/maemo/modest-progress-bar-widget.c:
1346 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1347 avoid a g_warning, and probably to avoid a crash.
1349 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1351 * src/modest-search.c: (modest_search_folder): Check for a GError
1352 when calling tny_folder_get_headers(), to show that this is not the cause
1355 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1357 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1358 Actually set the body query instead of the subject query.
1360 * src/modest-search.c: (search_mime_part_ogs),
1361 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1362 which would probably cause it to fail if we got this far.
1364 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1365 to simplify the code.
1366 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1367 be causing search-in-body to fail.
1369 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1371 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1373 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1374 Better debug message when the folder cannot be found.
1375 This should help with fixing projects.maemo.org bug #61287.
1376 * src/modest-search.c: (add_hit): Do not leak the furl string.
1378 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1380 * src/modest-ui-actions.c:
1381 (modest_ui_actions_on_folder_selection_changed):
1382 Do not special-case TNY_MERGE_FOLDER here, because
1383 modest_tny_folder_get_account() already does that. This fixes
1384 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1385 shown when the Outbox was selected).
1387 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1389 * libmodest-dbus-client/libmodest-dbus-client.c:
1390 (_dbus_iter_get_string_or_null): Initialize the string variable in
1391 case this helps with Dirk's crash.
1393 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1395 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1396 though it is not implemented yet (this function is maybe not even used),
1397 to avoid breaking ABI in future.
1398 * libmodest-dbus-client/libmodest-dbus-client.c:
1399 (get_attachments_string): Moved some code into this generic function.
1400 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1401 sends email. It is maybe not used.
1402 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1403 (on_send_mail): Use attachments.
1405 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1406 * src/maemo/modest-msg-edit-window.c:
1407 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1408 a filename before using it, to fix projects.maemo.org bug NB#58233.
1410 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1412 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1413 Initialize the continue_download variable to fix the build, and probably
1414 to fix randome behaviour.
1416 2007-06-18 Armin Burgmeier <armin@openismus.com>
1418 * src/modest-tny-send-queue.h:
1419 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1420 the queue so we can later show it in the UI. Replaced
1421 modest_tny_send_queue_msg_is_being_sent() by
1422 modest_tny_send_queue_get_msg_status().
1424 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1426 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1427 gpointer. This probably was not harmful, but just to be sure.
1429 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1431 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1432 Fix the build, but leave the function broken on Bora, because
1433 hildon_uri_action_get_service() does not exist.
1434 osso_uri_action_get_service() does not exist either, it seems.
1436 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1438 * src/modest-tny-account.c:
1439 (modest_tny_account_new_from_server_account):
1440 Uncommented the url debug output again, because it is useful for
1441 debugging, as I said in the comment.
1443 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1445 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1447 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1448 for Mameo Bora, to fix the build.
1450 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1453 Fixed build with hildon < 0.99
1455 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1456 Check if the selected account is busy instead of checking all accounts
1458 * src/modest-account-mgr-priv.h:
1459 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1460 (modest_account_mgr_init), (compare_account_name),
1461 (modest_account_mgr_set_account_busy),
1462 (modest_account_mgr_account_is_busy):
1463 * src/modest-account-mgr.h:
1464 Added busy information to the account manager. It possible to
1465 set an account to busy or not busy now.
1467 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1468 (modest_mail_operation_update_account),
1469 (modest_mail_operation_notify_end):
1470 Set the account to busy/not busy depending on the operation state.
1472 * src/widgets/modest-account-view.c:
1473 (modest_account_view_finalize), (get_last_updated_string),
1474 (update_account_view), (on_account_busy_changed), (init_view):
1475 Show string "Refreshing..." if the account is currently busy.
1477 All this fixes projects.maemo.org bug NB#59711
1479 2007-06-14 Armin Burgmeier <armin@openismus.com>
1481 * src/widgets/modest-attachments-view.h:
1482 * src/widgets/modest-attachments-view.c: Added
1483 modest_attachments_view_has_attachments() and fixed coordinate
1484 transformation in get_att_view_at_coords(). This fixes attachment
1487 * src/widgets/modest-msg-view.c: Make use of
1488 modest_attachments_view_has_attachments() to decide whether to show
1489 attachments in the header.
1491 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1493 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1494 (on_change), (on_combo_security_changed),
1495 (modest_connection_specific_smtp_edit_window_init),
1496 (modest_connection_specific_smtp_edit_window_set_connection),
1497 (modest_connection_specific_smtp_edit_window_is_dirty):
1498 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1499 * src/maemo/modest-connection-specific-smtp-window.c:
1502 Show an comfirmation dialog for the smpt-edit-window if there are
1503 unsaved changes and the user hits cancel.
1504 (projects.maemo.org bug NB#60479)
1506 2007-06-14 Armin Burgmeier <armin@openismus.com>
1508 * src/maemo/easysetup/modest-easysetup-wizard.c:
1509 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1510 address" info in banner instead of node, and select all the text as
1511 per UI spec. This fixes projects.maemo.org bug NB#60550.
1513 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1515 reviewed by: <delete if not using a buddy>
1517 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1518 * src/modest-ui-actions.c: (folder_refreshed_cb):
1520 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1522 * src/widgets/modest-folder-view.c: (filter_row):
1523 Explictly filter out the per-account outbox accounts. I don't know why
1524 these only sometimes show up, but now they should never show up in the UI.
1525 This should fix projects.maemo.org bug NB#60160.
1527 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1529 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1530 when the toolbar does not exist yet.
1531 * src/modest-widget-memory.c: (save_settings_header_view):
1532 Added g_warnings() to help us to discover when we are trying to set
1533 an empty columns list in gconf.
1535 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1537 * src/modest-init.h:
1538 * src/modest-init.c:
1539 Added modest_init_get_default_header_view_column_ids().
1541 * src/modest-widget-memory.c: (restore_settings_header_view):
1542 Use the new function to get defaults, if the gconf key is empty,
1543 instead of not creating any columns. This seems to fix the
1544 empty right-hand pane problems.
1546 * src/widgets/modest-header-view.h: Improved documentation.
1548 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1550 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1551 Revert the use of the display name as the account name, because this
1552 is generally wrong and would break the code that follows.
1554 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1556 * src/maemo/easysetup/modest-easysetup-wizard.c:
1557 (check_for_supported_auth_methods), (on_before_next),
1560 More correct fix for projects.maemo.org bug NB# 58991
1561 Do not longer accept AUTH_PASSWORD as secure method and choose
1562 correct method when creating the account.
1564 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1566 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1567 Fixed projects.maemo.org bug NB# 58991
1569 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1571 * src/modest-init.c: (modest_init_init_core),
1572 (modest_init_local_folders): Fixed compilation errors.
1574 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1576 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1577 Remove unnecessary lib/include, though it is good in principle when needed.
1579 * src/modest-init.c: (modest_init_one_local_folder),
1580 (modest_init_local_folders):
1581 * src/modest-init.h: Initialize the .modest library for memory cards,
1582 instead of just doing nothing for them. This should allow us to create
1583 folders there, fixing projects.maemo.org bug NB#59297.
1585 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1587 * libmodest-dbus-client/libmodest-dbus-client.c:
1588 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1589 (libmodest_dbus_client_compose_mail),
1590 (libmodest_dbus_client_open_message),
1591 (libmodest_dbus_client_send_and_receive),
1592 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1594 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1595 (on_idle_open_message), (modest_dbus_req_handler),
1596 (search_result_to_message), (modest_dbus_req_filter):
1597 * src/modest-search.c: (add_hit), (modest_search_folder),
1598 (modest_search_all_accounts): Improved debug messages.
1600 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1602 * src/modest-tny-account-store.c:
1603 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1606 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1609 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1611 * src/modest-tny-account-store.c: (get_server_accounts):
1612 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1613 even when there are no accounts, so that the Outbox folder is always
1614 visible. This fixes projects.maemo.org bug NB#60158.
1616 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1618 * src/maemo/modest-main-window.c: (create_details_widget):
1619 Use the mcen_va_never logical ID.
1621 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1623 * src/dbus_api/modest-dbus-api.h:
1624 * src/dbus_api/modest-dbus-callbacks.c:
1625 (on_idle_open_default_inbox), (on_open_default_inbox),
1626 (modest_dbus_req_handler):
1627 Added a new OpenDefaultInbox method.
1629 * libmodest-dbus-client/libmodest-dbus-client.h:
1630 * libmodest-dbus-client/libmodest-dbus-client.c:
1631 Added libmodest_dbus_client_open_default_inbox() to call the new
1632 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1633 though it should maybe be used by a new osso-email-interface function.
1635 * tests/dbus_api/Makefile.am:
1636 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1639 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1641 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1642 NULL, so that the signals get all the keys. This should not actually
1643 change any behaviour because we currently update everything when anything
1646 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1648 * src/widgets/modest-folder-view.c: (text_cell_data),
1649 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1650 (find_inbox_iter): If tinymail tells us that the folder is
1651 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1652 This causes the inbox to be selected at startup, fixing part of
1653 projects.maemo.org bug NB#56305.
1655 * src/modest-ui-dimming-rules.c:
1656 (modest_ui_dimming_rules_on_tools_smtp_servers):
1657 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1658 the SMTP servers menu item.
1659 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1660 that the SMTP Servers menu item is dimmed when there are no accounts,
1661 as a future version of the UI spec will require. This fixes
1662 projects.maemo.org bug NB#56305.
1664 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1666 * src/maemo/modest-maemo-utils.c:
1667 (modest_maemo_utils_get_supported_secure_authentication_methods):
1668 Added label to dialog instead of unreadable title
1670 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1671 (modest_main_window_new):
1672 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1675 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1676 * src/modest-account-mgr.h:
1677 Added method to avoid code duplication
1679 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1680 (modest_ui_actions_on_send_receive):
1681 Use modest_account_mgr_has_accounts
1683 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1685 * src/maemo/easysetup/modest-presets.c:
1686 (modest_presets_get_info_server_security): Do not report secure auth
1688 * src/modest-protocol-info.c: Use the defines for the gconf key names
1689 for secure authentication. This was not working because we were writing
1690 Password and reading password, and the check was case sensitive.
1691 With this, gmail now works for receiving and sending when created via
1694 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1696 * src/maemo/easysetup/modest-presets.c:
1697 (modest_presets_get_info_server_security): Correct the key name for
1698 SecureSmtp, because it seems to be case-sensitive.
1699 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1700 Do not try to get the 0th notebook page if there are 0 pages, to
1701 avoid a g_warning().
1703 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1705 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1706 Prevent use of the new notification feature for now, because it currently
1707 shows one dialog for each new email, which is annoying.
1709 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1711 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1712 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1713 when no country was selected, so that we show the global ones.
1714 * src/maemo/easysetup/modest-presets.c:
1715 (modest_presets_get_providers): Return only the global providers, not
1716 all providers when mmc=0 was requested.
1718 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1720 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1721 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1722 provider ID in the combo.
1724 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1725 Do not show the page numbers, because it would be confusing when we add
1726 the 2 extra pages for the custom setup, when the user chooses the "Other"
1727 provider. This fixes projects.maemo.org bug NB#59028
1729 * src/modest-init.c: (modest_init_init_core),
1730 (modest_init_local_folders):
1731 * src/modest-init.h:
1732 * src/modest-tny-account.c:
1733 (modest_tny_account_new_for_local_folders): Do not create default folders
1734 for the memory card. This should fix projects.maemo.org bug NB#59328.
1736 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1738 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1739 Free the changed_conf_keys string items. They are already freed in the
1740 idle handler if that runs first.
1742 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1744 * src/modest-ui-actions.c:
1745 (modest_ui_actions_on_password_requested): Check that the server name
1746 is not NULL, because I just saw a password dialog with (null) as the
1749 * src/modest-tny-folder.[h|c]: Added
1750 modest_tny_folder_is_memory_card_folder().
1751 * src/modest-ui-dimming-rules.c:
1752 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1753 menu item for memory cards, as per the UI spec (section 7.4). This should
1754 fix projects.maemo.org bug NB#59297.
1756 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1758 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1759 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1760 is another problem with the code, see Murray's comment at line 772)
1762 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1764 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1765 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1766 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1767 (load_from_file), (easysetup_country_combo_box_init),
1768 (easysetup_country_combo_box_get_active_country_ids),
1769 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1770 instead of just one ID, to avoid duplicate country names in the UI.
1772 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1773 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1774 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1775 a single ID, avoiding duplicate providers.
1776 * src/maemo/easysetup/modest-easysetup-wizard.c:
1777 (on_combo_account_country): Adapt to use a list.
1779 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1781 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1782 keys changed in the last X seconds.
1784 * src/modest-account-mgr.h:
1785 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1786 (on_key_change), (modest_account_mgr_class_init),
1787 (modest_account_mgr_init), (modest_account_mgr_finalize):
1788 As the keys are changed, save them in a GSList* and signal that GSList*
1789 further every X seconds, to batch changes, to allow us to do just one
1790 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1791 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1793 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1794 changed signal signature.
1796 * src/modest-conf.c: (modest_conf_set_list),
1797 (modest_conf_on_change): Reenable notification.
1799 (modest_conf_maemo_fake_on_change): Comment out the hack that
1800 notified immediately instead of asynchronously.
1802 * src/widgets/modest-account-view.h:
1803 * src/widgets/modest-account-view.c:
1804 (update_account_view): Select the previously-selected account ID,
1805 if possible. This fixes projects.maemo.org bug NB#56933.
1807 (on_account_changed), (on_account_removed),
1808 (modest_account_view_select_account):
1810 Remove the block/unblock functions
1811 because they were not useful.
1813 * src/maemo/modest-account-view-window.c:
1814 (on_delete_button_clicked), (on_edit_button_clicked),
1815 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1817 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1819 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1820 Improve the error dialog to show Incorrect Account Settings, which seems
1821 clearer, and say that the internal error message (to be removed from the
1822 dialog later) is often misleading.
1823 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1825 * src/modest-tny-account.c:
1826 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1827 URL because this is so useful for debugging on the device.
1829 * src/widgets/modest-serversecurity-combo-box.c:
1830 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1832 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1834 * src/modest-mail-operation.c:
1835 (modest_mail_operation_send_new_mail):
1836 Added a comment about a nasty but apparently harmless message. Details
1837 added to the wiki g_warnings() page.
1839 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1841 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1842 (modest_tny_send_queue_class_init):
1843 Do not use the priv struct because it is empty, to avoid g_warnings
1844 about a non-existant priv struct.
1846 * src/modest-tny-account-store.c:
1847 (modest_tny_account_store_get_server_account),
1848 (modest_tny_account_store_get_transport_account_for_open_connection
1849 ): Do not try to get transport server accounts for local folders,
1850 because they don't have any. This avoids a g_warning().
1852 * src/maemo/modest-main-window.c:
1853 (modest_main_window_notify_send_receive_initied),
1854 (on_configuration_key_changed):
1855 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1856 * src/modest-defs.h:
1857 * src/modest-mail-operation.c:
1858 (modest_mail_operation_update_account):
1859 * src/modest-tny-account-store.h:
1860 * src/modest-tny-account.c:
1861 (modest_tny_account_get_special_folder),
1862 (modest_tny_account_new_for_local_folders),
1863 (modest_tny_account_new_for_per_account_local_outbox_folder):
1864 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1865 * src/modest-tny-local-folders-account.c:
1866 (add_account_folders_to_merged_folder):
1867 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1868 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1869 (modest_ui_actions_on_send):
1870 * src/widgets/modest-folder-view.c: (update_model):
1871 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1872 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1873 modest_tny_account_store_get_tny_account_by_account() to
1874 modest_tny_account_store_get_server_account() to make the code clearer.
1876 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1878 * src/dbus_api/modest-dbus-api.h:
1879 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1880 * src/maemo/modest-msg-edit-window.c:
1881 (modest_msg_edit_window_attach_file_noninteractive):
1882 added g_warning in case the file to be attached does not exist
1883 * tests/dbus_api/test_compose_mail.c: (main):
1884 removed obsolete comment, added generic files as test case
1886 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1888 * src/modest-tny-account-store.c: (get_server_accounts):
1889 Create the local folders account only once, not once for each outbox, and
1890 not only when there are some outboxes.
1892 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1894 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1895 code that is causing a crash at startup. Sergio says that he is fixing this.
1897 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1899 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1900 * src/maemo/modest-account-settings-dialog.c:
1901 (create_page_outgoing),
1902 (modest_account_settings_dialog_set_account_name),
1903 (save_configuration):
1904 - Fixed handling of the "Use secure authentication" toggle to comply with
1905 the ui specification. See also projects.maemo.org bug NB#58400
1907 - Restore the Secure connection setting combo correctly when loading
1910 * src/maemo/modest-maemo-utils.c:
1911 (on_camel_account_get_supported_secure_authentication),
1912 (modest_maemo_utils_get_supported_secure_authentication_methods):
1913 Fixed a crasher if operation is canceled
1915 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1916 (modest_protocol_info_auth_is_secure):
1917 * src/modest-protocol-info.h:
1919 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1920 the sense of the "Use secure authentication" toggle.
1922 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1924 * src/modest-tny-account-store.h:
1925 * src/modest-tny-account-store.c:
1926 Added modest_tny_account_store_get_local_folders_account().
1928 * src/modest-tny-folder.h:
1929 * src/modest-tny-folder.c:
1930 (modest_tny_folder_get_account):
1931 Added this replacement for tny_folder_get_account() which returns
1932 the local-folders account for TnyMergeFolders, to avoid the
1933 warning about the unimplemented get_account_func() vfunc().
1935 (modest_tny_folder_get_rules),
1936 * src/modest-ui-actions.c:
1937 (modest_ui_actions_on_folder_selection_changed):
1938 * src/modest-mail-operation.c:
1939 (modest_mail_operation_remove_folder),
1940 (modest_mail_operation_xfer_folder),
1941 (modest_mail_operation_rename_folder),
1942 (modest_mail_operation_get_msg),
1943 (modest_mail_operation_get_msgs_full),
1944 (modest_mail_operation_remove_msg),
1945 (modest_mail_operation_xfer_msgs),
1946 (modest_mail_operation_refresh_folder):
1947 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1949 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1951 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1952 (modest_server_account_set_security):
1953 * src/modest-defs.h: Add comments explaining that our
1954 UI spec means TLS when it says Normal, so these do not look like errors.
1956 * src/modest-tny-account.c:
1957 (modest_tny_account_new_from_server_account): Use the new tinymail
1958 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1959 for TLS. This should fix projects.maemo.org bug NB#58460.
1961 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1963 * src/maemo/easysetup/modest-easysetup-wizard.c:
1964 (create_account): Correct the position of the gconf sanity check warning.
1965 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1966 of using the g_idle_add() hack, because this does not seem to be necessary
1967 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1968 caused by something other than maemo's gconf.
1969 This fixes projects.maemo.org bug #59022.
1971 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1973 * src/modest-account-mgr-helpers.c:
1974 (modest_account_mgr_get_default_account): Do not check that the account
1975 exists if there is no default account (NULL), to fix a runtime warning.
1977 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1979 * src/widgets/modest-folder-view.c: (update_model):
1980 Do not unref the treemodel before we have finished with it.
1981 This prevents a valgrind warning and an occasional crash at startup.
1983 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1985 * libmodest-dbus-client/libmodest-dbus-client.h:
1986 added libmodest_dbus_client_compose_mail()
1987 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1989 added functions needed for SendAsMail() functionality
1990 * src/maemo/modest-msg-edit-window.c:
1991 (modest_msg_edit_window_attach_file_noninteractive):
1992 non interactively attaching files to message edit window
1993 * src/widgets/modest-msg-edit-window.h:
1994 * tests/dbus_api/Makefile.am:
1995 added test_compose_mail.c
1996 * tests/dbus_api/test_compose_mail.c: (main):
1998 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2000 * src/modest-account-view.c:
2001 Fixed bug projects.maemo.org bug NB#59307
2003 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2005 * src/maemo/easysetup/modest-easysetup-wizard.c:
2006 (get_serverport_incoming), (on_before_next), (create_account):
2007 * src/maemo/modest-account-settings-dialog.c:
2008 (modest_account_settings_dialog_set_account_name):
2009 * src/maemo/modest-maemo-utils.c:
2010 (on_camel_account_get_supported_secure_authentication_status),
2011 (on_camel_account_get_supported_secure_authentication),
2012 (on_secure_auth_cancel),
2013 (modest_maemo_utils_get_supported_secure_authentication_methods):
2015 Implemented security authentication for settings and easysetup.
2017 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2019 * src/maemo/modest-main-window.c: (create_details_widget):
2020 Show the total size for memory card accounts too, instead of showing
2021 the name again. Fixes bug projects.maemo.org bug NB#59307.
2023 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2026 * src/modest-tny-simple-folder-store.c:
2027 * src/modest-tny-simple-folder-store.h: Removed.
2029 * src/modest-tny-local-folders-account.h
2030 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2031 for the local-folders maildir, with an extra TnyMergedFolder containing
2032 the folders of the per-account outbox store accounts.
2033 * src/modest-tny-account-store.c: (get_server_accounts):
2034 Add the outboxes to the special local folders account after creating it.
2036 * src/modest-tny-account.c:
2037 (modest_tny_account_new_for_local_folders): Create the derived
2038 account when creating the main local-folders account.
2040 * src/maemo/modest-main-window.c: (create_details_widget),
2041 (modest_main_window_set_contents_style):
2042 Adapted to the use of the derived account instead of the folder store.
2044 * src/modest-ui-actions.c:
2045 (modest_ui_actions_on_folder_selection_changed):
2046 * src/modest-ui-dimming-rules.c:
2047 (modest_ui_dimming_rules_on_new_folder):
2048 * src/widgets/modest-folder-view.c: (text_cell_data),
2049 (icon_cell_data), (filter_row), (update_model),
2050 (get_cmp_rows_type_pos):
2053 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2054 Do not get the priv struct, because no priv struct has been set,
2055 to avoid a runtime warning.
2057 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2058 #ifelse with #else, to fix a warning, to fix the build.
2061 2007-06-05 Christian Kellner <ckellner@openismus.com>
2063 * libmodest-dbus-client/libmodest-dbus-client.c:
2064 Fix small typo in doc (why do you always see them
2065 AFTER committing stuff?)
2068 2007-06-05 Christian Kellner <ckellner@openismus.com>
2070 * libmodest-dbus-client/libmodest-dbus-client.c:
2071 (libmodest_dbus_client_search):
2072 Initialize hit list with NULL. Also set folder list
2073 to "" if NULL was supplied.
2076 2007-06-03 Christian Kellner <ckellner@openismus.com>
2078 * libmodest-dbus-client/libmodest-dbus-client.c:
2079 (modest_search_hit_list_free):
2080 Make it save to call it with NULL.
2082 * src/dbus_api/modest-dbus-callbacks.c:
2083 * src/modest-search.c:
2084 Return full ModestSearchHits as the search result list not TnyHeader
2085 since can't be around withouth the correspoding TnyFolder.
2087 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2089 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2090 Added currently commented code to check for secure auth
2092 * src/maemo/modest-account-settings-dialog.c: (on_response),
2093 (save_configuration), (show_ok):
2094 Fixed projects.maemo.org bugs NB #59248 and #59251
2096 * src/maemo/modest-maemo-utils.c:
2097 (on_camel_account_get_supported_secure_authentication_status),
2098 (on_camel_account_get_supported_secure_authentication),
2099 (modest_maemo_utils_get_supported_secure_authentication_methods):
2100 * src/maemo/modest-maemo-utils.h:
2101 Moved get_supported_secure_authentication() method here to be able
2102 to use it from easysetup wizard.
2104 * src/modest-pair.c: (on_pair_compare_as_string):
2105 Should compare string with first part of pair and not
2106 strcmp pairs which will crash.
2108 * src/modest-protocol-info.c:
2109 (modest_protocol_info_protocol_is_store):
2110 * src/modest-protocol-info.h:
2111 Added modest_protocol_info_get_auth_protocol_name()
2113 2007-06-03 Armin Burgmeier <armin@openismus.com>
2115 * src/modest-mail-operation.c:
2116 (modest_mail_operation_get_msgs_full): Set priv->account also when
2117 only retrieving a single message. This avoids a crash when canceling
2120 (modest_mail_operation_notify_end): Do not explicitely remove the
2121 operation from the queue but only emit the progress_changed signal.
2122 The queue itself listens to that signal to remove the operation when
2123 it is finished. This reduces coupling and removes a potential deadlock
2124 when modest_mail_operation_notify_end() is called from the queue
2125 itself. If that is a problem performance-wise, I would suggest to
2126 implement a status-changed signal or something.
2128 * src/modest-mail-operation-queue.c: Make sure to never call a
2129 function from another file while the queue is locked. This (hopefully)
2130 fixes another deadlock when exiting the application while retrieving
2133 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2135 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2136 Fixed build if libogs is not available
2138 2007-06-03 Christian Kellner <ckellner@openismus.com>
2140 * libmodest-dbus-client/libmodest-dbus-client.h:
2141 * libmodest-dbus-client/libmodest-dbus-client.c:
2142 (libmodest_dbus_client_delete_message):
2143 Implement deletion of messages (Client side).
2145 (modest_search_hit_free),
2146 (modest_search_hit_list_free):
2147 Utility functions to free the result hits.
2149 * src/dbus_api/modest-dbus-api.h:
2150 * src/dbus_api/modest-dbus-callbacks.c:
2151 (on_delete_message),
2152 (modest_dbus_req_handler):
2153 Implement deletion of messages (Server side).
2155 * tests/dbus_api/test_search.c: (main):
2158 * tests/dbus_api/Makefile.am:
2159 * tests/dbus_api/test_delete_message:
2160 Add little test for the message deletion logic
2162 2007-06-03 Armin Burgmeier <armin@openismus.com>
2164 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2165 when the operation queue was not empty. projects.maemo.org bug
2168 2007-06-03 Armin Burgmeier <armin@openismus.com>
2170 * src/widgets/modest-account-view.c
2171 (on_account_default_toggled): Toggle default account column
2172 explicitely instead of waiting for gconf notification (which is
2173 currently ignored). This should fix projects.maemo.org bug NB#56910
2174 for now. It should probably be removed when gconf notifications are
2177 2007-06-03 Christian Kellner <ckellner@openismus.com>
2179 * libmodest-dbus-client/libmodest-dbus-client.c:
2180 Removed debugging spew.
2182 * src/dbus_api/modest-dbus-callbacks.c:
2183 Added debugging info.
2185 * src/modest-search.c:
2186 (modest_search_all_accounts):
2187 Use tny_account_store_get_accounts () on the account store
2188 to get all accounts which is the way to get all accounts.
2190 * tests/dbus_api/test_search.c: (main):
2191 Make it possible to supply the search term on the command line.
2193 2007-06-03 Christian Kellner <ckellner@openismus.com>
2195 * libmodest-dbus-client/libmodest-dbus-client.c:
2196 * libmodest-dbus-client/libmodest-dbus-client.h:
2197 Implement searching for mesages over raw dbus. (Client side)
2199 * src/dbus_api/Makefile.am:
2200 * src/dbus_api/modest-dbus-api.h:
2201 * src/dbus_api/modest-dbus-callbacks.c:
2202 * src/dbus_api/modest-dbus-callbacks.h:
2203 Search framework (Server side). Also implement on_idle_open_message().
2205 * src/maemo/modest-platform.c: (modest_platform_init):
2206 Prepare for raw dbus/osso rpc interaction.
2208 * src/modest-search.h:
2209 Changed minsize from unspecific guint to guint32.
2211 * src/modest-search.c:
2213 Added strange hack which magically made tnymail work.
2215 (modest_search_folder),
2216 (modest_search_account),
2217 (modest_search_all_accounts):
2218 Implement helper functions to search all accounts, specific account
2221 * tests/dbus_api/Makefile.am:
2222 * tests/dbus_api/test_open_message.c:
2223 Read url to open from commandline.
2225 * tests/dbus_api/test_search.c:
2226 Implement small test for dbus search stuff
2228 2007-06-02 Armin Burgmeier <armin@openismus.com>
2230 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2231 include account type and account title. This fixes projects.maemo.org
2234 * src/maemo/modest-account-view-window.c: Set a title for the window.
2236 2007-06-02 Armin Burgmeier <armin@openismus.com>
2238 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2239 incoming and outgoing server name based on email address and server
2240 types as long as the names have not been edited manually. This fixes
2241 projects.maemo.org bug NB#58671.
2243 2007-06-02 Armin Burgmeier <armin@openismus.com>
2245 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2246 server type cannot be changed in future to the incoming details page
2247 when creating an account. This fixes projects.maemo.org bug NB#59029.
2249 2007-06-02 Armin Burgmeier <armin@openismus.com>
2251 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2252 and assigned max width chars so that they wrap instead of being
2253 truncated. Fixes projects.maemo.org bug NB#56126.
2255 2007-06-02 Armin Burgmeier <armin@openismus.com>
2257 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2258 introductory note to the connection specific smtp servers dialog, as
2259 section 8.12 of the email UI specification requires. This fixes
2260 projects.maemo.org bug NB#59212.
2262 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2264 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2265 Check for running mail operations, and offer to cancel them, as per the UI
2266 spec. This fixes projects.maemo.org bug NB#59041 .
2267 However, I suspect that tinymail may still use the network connection
2268 in ways that we cannot detect or cancel. But it should at least adapt to
2269 changes fairly well.
2271 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2273 * src/modest-tny-account-store.c: (recreate_all_accounts),
2274 (get_cached_accounts), (get_server_accounts): Do more sensible
2275 ref-counting of the temporarily-cached outbox accounts list. This seems
2276 to fix a crash when entering the password when the password was wrong.
2278 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2280 * src/gnome/modest-main-window.c: (connect_signals):
2281 * src/modest-tny-account-store.c: (get_password),
2282 (modest_tny_account_store_alert): Added comments and clues and
2283 commented-out code about how we currently fail to deal with connection
2284 errors and wrong passwords, and how we should.
2286 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2288 * src/widgets/modest-retrieve-combo-box.c:
2289 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2290 This fixes projects.maemo.org bug NB#58472 .
2292 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2294 * src/maemo/easysetup/modest-easysetup-wizard.c:
2295 (create_page_complete_easysetup):
2296 (create_page_complete_custom): Correct the last commit,
2297 putting the correct sentences in the correct pages.
2299 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2301 * src/maemo/easysetup/modest-easysetup-wizard.c:
2302 (create_page_complete_custom): Show the second sentence of text
2303 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2306 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2308 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2309 Set the leave-on-server conf key by default. This fixes
2310 projects.maemo.org bug NB#59258 .
2312 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2314 * src/maemo/modest-account-view-window.c:
2315 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2316 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2319 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2321 * src/maemo/easysetup/modest-easysetup-wizard.c:
2322 (create_caption_new_with_asterisk):
2323 * src/maemo/modest-account-settings-dialog.c:
2324 (create_caption_new_with_asterisk):
2325 Uncomment the code to add the asterisk, because they are no longer in the
2326 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2327 (update_incoming_server_title): Add an asterisk here too.
2329 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2331 * src/maemo/modest-maemo-global-settings-dialog.c:
2332 (current_connection): Check that we are even connected before trying to
2333 get the current connection name, to prevent a warning.
2335 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2336 Change the comments because tny_maemo_conic_device_connect() is now meant to
2338 * src/modest-mail-operation.c:
2339 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2340 make sure we have a connection and fail if we can't connect.
2342 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2344 * src/maemo/modest-main-window.c:
2345 (on_account_store_connecting_finished): Do not try to get the
2346 connection ID if we are not really connected. I am surprised that
2347 this signal handler is called when we are not connected.
2349 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2351 * src/modest-error.h:
2352 * src/modest-ui-actions.c:
2353 (modest_ui_actions_get_msgs_full_error_handler):
2354 Renamed an enum, added comments, added an enum
2355 for retrieve-limit errors.
2357 * src/modest-mail-operation.c: (foreach_add_item),
2358 (internal_folder_observer_update), (update_account_thread),
2359 (modest_mail_operation_get_msgs_full):
2360 (modest_mail_operation_update_account),
2361 Added comments about how this works, and some code that should
2362 (but does not) check the retrieve-limit. See the TODO comment.
2364 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2366 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2367 Initialize help_id to fix the build. Warnings are good.
2369 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2371 * src/widgets/modest-hbox-cell-renderer.c:
2372 (modest_hbox_cell_renderer_append):
2373 * src/widgets/modest-vbox-cell-renderer.c:
2374 (modest_vbox_cell_renderer_append):
2375 Fix the last commit by doing an extra ref.
2377 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2379 * src/widgets/modest-hbox-cell-renderer.c:
2380 (modest_hbox_cell_renderer_append):
2381 * src/widgets/modest-vbox-cell-renderer.c:
2382 (modest_vbox_cell_renderer_append):
2383 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2384 to fix the build with Maemo Bora.
2385 However, there seems to be a remaining crash, probably due to reference
2388 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2390 * src/modest-tny-account.c:
2391 (modest_tny_account_new_for_local_folders):
2392 Use hildon_file_system_info_async_new() to get a better name for
2393 the memory card account, setting it as the account name.
2394 The timing seems to work, but this is probably
2395 not the best place to do this. See the TODO comment.
2396 * src/maemo/modest-main-window.c: (create_details_widget):
2397 * src/widgets/modest-folder-view.c: (text_cell_data):
2398 Use the tny account name instead of hardcoding a name.
2400 2007-05-30 Christian Kellner <ckellner@openismus.com>
2402 * src/modest-search.c: (modest_search):
2403 Correctly set part_search_func even if we have already parsed
2404 the query and thus a valid OgsTextSearcher object.
2406 2007-05-30 Christian Kellner <ckellner@openismus.com>
2409 Search and check for libogs.
2412 Incooparte the ogs build env.
2414 * src/modest-mime-part-search-stream.c:
2415 * src/modest-mime-part-search-stream.h:
2416 Removed since we do the real searching now in modest-search.c.
2418 * src/modest-search.c:
2419 * src/modest-search.h:
2420 Implement support for ogs. We use that if available and requested
2421 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2422 should now handle the corner case when the search term is spread
2423 across multiple reads.
2424 Also the logic in modest_search () was corrected to search all
2425 requested fields until one is found.
2427 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2429 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2431 * src/modest-init.h:
2432 * src/modest-init.c: Made modest_init_local_folders() take a
2433 path and be public so we can iniitialize maildir folders on
2436 * src/modest-local-folder-info.h:
2437 * src/modest-local-folder-info.c:
2438 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2440 * src/modest-tny-account.c:
2441 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2442 still means the standard local-folders path on the local volume.
2444 * src/modest-tny-account-store.c:
2445 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2446 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2447 all accounts when that happens.
2448 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2449 this too, so it shows up in the treeview.
2451 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2453 * src/maemo/modest-maemo-global-settings-dialog.c:
2454 (current_connection):
2455 * src/widgets/modest-global-settings-dialog.c:
2456 (current_connection_default):
2457 Use the enum values instead of 0, 1 and -1,
2458 to make the code clearer.
2460 * src/modest-account-mgr-helpers.c:
2461 (modest_account_mgr_get_connection_specific_smtp): Make this code
2464 * src/modest-runtime.h:
2465 * src/modest-runtime.c:
2466 Added modest_runtime_remove_all_send_queues().
2467 * src/maemo/modest-main-window.c:
2468 (on_account_store_connecting_finished): Recreate the send queues,
2469 using the appropriate transport accounts for this new connection.
2470 Some futher adapting might be needed if the old send queues are not
2471 automatically stopped at this point.
2473 * src/modest-tny-account-store.c: (get_server_accounts):
2474 Create the connection-specific transport accounts, so that they can
2475 be found later by their ID.
2477 * src/modest-tny-account.h:
2478 * src/modest-tny-account.c:
2479 Added modest_tny_account_new_from_server_account_name().
2480 modest_tny_account_new_from_server_account(): Do not create the
2481 send queues here, because they will be
2482 recreated anyway when the connection changes for the first time.
2484 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2486 * src/modest-local-folder-info.h:
2487 * src/modest-local-folder-info.c:
2488 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2489 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2490 tbox_folder): Take a modest account name instead of a server TnyAccount,
2491 so we can have per-modest-account rather than per-transport-account
2493 We must make sure that we change or recreate the exisitng send queues
2494 when the connection changes for connection-specific transport accounts.
2496 * src/modest-tny-account-store.c:
2497 (create_per_account_local_outbox_folders): Create outboxed per modest
2498 account, not per transport account.
2500 * src/modest-tny-account.h:
2501 * src/modest-tny-account.c:
2502 (modest_tny_account_get_special_folder): For outboxes, get the
2503 parent modest account name. The account is ignored for other folders.
2504 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2505 modest account name rather than a server TnyAccount.
2507 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2509 * src/modest-tny-account.c:
2510 (modest_tny_account_new_from_server_account):
2511 Call modest_runtime_get_send_queue() immediately after creating transport
2512 accounts, so that they start trying to send email from the outbox as soon
2513 as possible at startup. This is probably what we want.
2515 * src/modest-mail-operation.c: (update_account_thread):
2516 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2517 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2518 * src/modest-tny-send-queue.h:
2519 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2520 (modest_ui_actions_on_send):
2521 Added comments about how sending works, though it needs some more work.
2523 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2525 * src/modest-tny-account.c:
2526 (modest_tny_account_get_special_folder): Add TODO because this fails when
2527 the network is busy.
2528 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2529 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2530 Do not try to show this window when there is no active account. The UI
2531 specs does not tell us what to do in this case.
2533 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2537 * src/maemo/Makefile.am:
2538 * src/widgets/Makefile.am: Some dist fixes.
2540 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2542 * src/maemo/modest-connection-specific-smtp-window.c:
2543 (on_button_edit): Make the code clearer, to prevent a double free.
2545 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2547 * src/maemo/modest-account-settings-dialog.c:
2548 (modest_account_settings_dialog_set_account_name),
2549 Check the connection-specific smtp servers checkbox if there are any.
2551 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2552 (modest_connection_specific_smtp_edit_window_init):
2553 Start with a suitable port number.
2555 * src/modest-account-mgr-helpers.h:
2556 * src/modest-account-mgr-helpers.c: Added
2557 modest_account_mgr_get_has_connection_specific_smtp().
2559 (modest_account_mgr_set_connection_specific_smtp),
2560 (modest_account_mgr_remove_connection_specific_smtp),
2561 (modest_account_mgr_get_has_connection_specific_smtp),
2562 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2563 connection-specific smtp server accounts in the account, rather than
2564 the server account conf dir.
2566 This fixes bug projects.maemo.org bug NB#58263 .
2568 * src/modest-tny-account-store.c:
2569 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2570 if there are no server accounts yet, to prevent an infinite loop when there
2571 are no accounts. Document that one must be called before the other.
2573 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2575 * src/modest-account-mgr-helpers.c:
2576 (modest_account_mgr_get_default_account): Make sure that at least
2577 one account is always the default, if there are any enabled accounts.
2578 This is just a sanity check that shouldn't be necessary.
2580 * src/modest-account-mgr-priv.c:
2581 (_modest_account_mgr_account_from_key): Unescape the conf key to
2582 get the real account name. For instance, this is an issue if a space
2583 was in the account name, which can happen because the account name
2584 is generated from the display name.
2585 (_modest_account_mgr_get_account_keyname): Always escape the
2587 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2588 Unescape the conf keys to get the real account names.
2590 For instance, previously the is-default radio button in the accounts
2591 list was not checked for any accounts at first. This fixes that,
2592 and might fix several similar bugs.
2594 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2596 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2597 Removed some debug printfs.
2599 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2601 Modest on-disk outbox directories are now here, for instance:
2602 $HOME/.modest/outboxes/<account-id-1>/outbox
2603 $HOME/.modest/outboxes/<account-id-2>/outbox
2605 $HOME/.modest/local-folders/outbox
2606 so we can have a separate outbox for each account.
2607 But they are shown as one outbox in the GtkTreeView, by using a
2608 TnyMergeFolder in a ModestTnySimpleFolderStore.
2611 * src/modest-tny-simple-folder-store.c:
2612 * src/modest-tny-simple-folder-store.h:
2613 Added ModestTnySimpleFolderStore, used to contain folders from
2614 other folder stores, such as other accounts.
2616 * src/modest-tny-outbox-account.h:
2617 * src/modest-tny-outbox-account.c:
2618 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2619 used for the per-account local outbox folders.
2621 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2622 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2623 only use this (internally) now for the non-outbox local folders.
2625 * src/modest-init.h:
2626 * src/modest-init.c: Added modest_init_one_local_folder(), for
2627 setting up the directory structure for each local folder.
2629 * src/modest-local-folder-info.c:
2630 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2631 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2633 * src/modest-local-folder-info.h:
2634 * src/modest-tny-account-store.c: (on_account_removed),
2635 (on_account_changed), (create_per_account_local_outbox_folders),
2636 (get_server_accounts), (modest_tny_account_store_get_accounts),
2637 (modest_tny_account_store_get_tny_account_by_account),
2638 (modest_tny_folder_store_is_virtual_local_folders):
2640 * src/modest-tny-account.h:
2641 * src/modest-tny-account.c:
2642 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2643 to create an on-disk per-account local outbox folder for each
2645 (create_per_account_local_outbox_folders): Create a local outbox folder
2646 for each transport account.
2647 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2648 for all local folders.
2650 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2651 instead of using g_object_get/set() directly. It is clearer.
2653 (modest_tny_folder_store_get_message_count),
2654 (modest_tny_folder_store_get_local_size
2655 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2656 because we now use these with non-acount folder stores.
2658 (modest_tny_account_get_special_folder),
2659 (modest_tny_account_new_from_server_account),
2660 (modest_tny_account_new_from_account):
2661 (recurse_folders): Adjust to the new outbox system.
2663 * src/modest-tny-folder.h:
2664 * src/modest-tny-folder.c:
2665 (modest_tny_folder_is_local_folder),
2666 (modest_tny_folder_get_local_folder_type),
2667 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2669 * src/widgets/modest-main-window.h:
2670 * src/maemo/modest-main-window.c: (create_details_widget),
2671 (modest_main_window_set_contents_style): Show details for any folder store,
2674 (modest_tny_folder_get_rules):
2675 Remove the const. C does not support constness enough for this.
2677 * src/modest-ui-actions.c:
2678 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2679 make all outboxes appear as one, in the usual local-folders tree node.
2681 (set_active_account_from_tny_account),
2682 (modest_ui_actions_on_folder_selection_changed):
2683 * src/widgets/modest-folder-view.c: (text_cell_data),
2684 (icon_cell_data), (filter_row),
2685 (add_account_folders_to_merged_folder),
2686 (add_account_folders_to_simple_folder_store), (),
2687 (get_cmp_rows_type_pos), (cmp_rows),
2688 (modest_folder_view_set_account_id_of_visible_server_account):
2689 Adjust to the new outbox system, using generic folder stores and folders
2690 in the GtkTreeModel.
2692 2007-05-23 Christian Kellner <ckellner@openismus.com>
2694 * src/modest-mail-operation.c:
2695 (modest_mail_operation_update_account):
2696 Use info->max_size instead of unintialized local var [small
2697 build fix]. (Added TODO to review that change since I don't
2700 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2702 * libmodest-dbus-client/libmodest-dbus-client.c:
2703 (libmodest_dbus_client_compose_mail): function added
2704 * src/dbus_api/modest-dbus-api.h:
2705 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2706 (on_compose_mail): Implementation of the SendAsMail functionality
2708 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2710 * src/modest-account-mgr.c:
2711 (modest_account_mgr_add_server_account): Set the secure-connection
2712 conf key for transport accounts as well as store accounts. I don't know
2713 why the if was there. For instance, this makes sure that we use SSL
2714 for the gmail preset from the easysetup wizard.
2716 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2718 * src/gnome/modest-main-window.c:
2719 (on_account_store_connecting_finished), (connect_signals):
2720 * src/maemo/modest-main-window.c:
2721 (on_account_store_connecting_finished), (connect_signals),
2722 (modest_main_window_new):
2723 Handle TnyAccountStore::connecting-finished instead of
2724 TnyDevice::connection-changed, because we cannot actually perform
2725 operations on accounts until TnyAccountStore has itself responded to
2726 the TnyDevice::connection-changed signal. This prevents a GError from
2728 Do not try to update at startup, because we (at least on scratchbox)
2729 already do an update at startup when the device goes online.
2730 This prevents a GError from tinymail.
2731 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2732 Added TODO about stopping simultaneous operations.
2734 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2736 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2737 * src/modest-mail-operation-queue.c:
2738 (modest_mail_operation_queue_remove):
2739 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2740 about where they happened.
2742 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2744 * src/modest-ui-actions.c:
2745 (modest_ui_actions_on_password_requested): Make sure that the remember
2746 output parameter is always TRUE.
2748 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2750 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2751 Show a OK/Cancel dialog if the error is a question, though we still do not
2752 know anything more about what we are asking the user.
2753 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2754 Fix an uninitialized variable (helper). This is a logic error, however.
2756 2007-05-21 Christian Kellner <ckellner@openismus.com>
2758 * src/modest-search.h:
2759 Correct bit shifting in the ModestSearchFlags enum.
2761 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2763 * src/modest-tny-account.c:
2764 (modest_tny_account_new_from_server_account): Do not use the lsub and
2765 check-all hard-coded IMAP options when using POP.
2767 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2769 * src/modest-tny-account.c:
2770 (modest_tny_account_new_from_server_account):
2771 Use NULL for the secure-auth method for POP when Password auth has been
2772 specified by the user, as we already do for IMAP. "auth=Login" causes
2773 an error from camel or the server.
2775 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2777 * src/maemo/modest-account-settings-dialog.c:
2778 (create_page_account_details),
2779 (modest_account_settings_dialog_set_account_name):
2780 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2781 for the leave-on-server checkbox, rathr than just the checkbox, when
2782 the protocol is not POP.
2784 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2786 * src/widgets/modest-account-view.c:
2787 * src/widgets/modest-account-view.h:
2788 Added modest_account_view_select_account() which will be useful later
2789 to asynchronously re-select the edited account.
2791 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2793 * src/maemo/modest-account-settings-dialog.c:
2794 (modest_account_settings_dialog_set_account_name):
2795 Automatically choose the port numbers based on the secure authentication
2796 methods, if they have not been chosen before.
2797 This fixes projects.maemo.org bug NB#56273 .
2799 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2801 * src/maemo/modest-main-window-ui.h:
2802 * src/modest-ui-actions.c:
2803 * src/modest-ui-actions.h:
2804 Connect the Tools/SMTP Servers menu item to
2805 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2806 SMTP servers dialog, as in the UI specification and saves changes when it
2807 is closed. This fixed projects.maemo.org bug NB#56305 .
2809 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2811 * src/maemo/modest-connection-specific-smtp-window.c:
2812 (modest_connection_specific_smtp_window_init):
2813 Use gtk_window_set_default_size() to make this window big enough, so
2814 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2816 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2818 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2819 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2820 (modest_connection_specific_smtp_edit_window_init),
2821 Do not try to connect to a combobox signal before the combobox exists.
2822 This fixes the cras in projects.maemo.org bug NB#56288 .
2823 (modest_connection_specific_smtp_edit_window_get_settings):
2824 Remove the server_account_name parameter which was being checked for NULL
2825 though it was not used.
2827 * src/maemo/modest-connection-specific-smtp-window.c:
2828 (modest_connection_specific_smtp_window_fill_with_connections),
2829 (on_button_edit), (modest_connection_specific_smtp_window_init):
2830 Correct the number of treemodel columns to prevent a warning.
2831 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2832 libconic does not work.
2834 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2836 * src/modest-tny-account.c:
2837 (modest_tny_account_new_from_server_account):
2838 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2839 SMTP when "None" was chosen by the user. However, with my SMTP server that
2840 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2843 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2845 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2846 to explain the memory management issue with the ID in the ModestPair.
2848 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2849 (add_sending_page), (modest_account_assistant_finalize):
2850 * src/gnome/modest-gnome-global-settings-dialog.c:
2851 (create_updating_page), (create_composing_page):
2852 * src/gnome/modest-msg-edit-window.c: (get_transports),
2853 (init_window), (modest_msg_edit_window_finalize),
2854 (modest_msg_edit_window_get_msg_data):
2855 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2856 * src/gnome/modest-transport-widget.c:
2857 (modest_transport_widget_finalize), (smtp_configuration):
2858 * src/maemo/modest-maemo-global-settings-dialog.c:
2859 (create_updating_page), (create_composing_page):
2860 * src/maemo/modest-msg-edit-window.c: (get_transports),
2861 (init_window), (modest_msg_edit_window_finalize),
2862 (modest_msg_edit_window_get_msg_data),
2863 (modest_msg_edit_window_free_msg_data):
2864 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2865 (modest_store_widget_finalize):
2866 * src/maemo/modest-transport-widget.c:
2867 (modest_transport_widget_finalize), (smtp_configuration):
2868 * src/modest-main.c: (send_mail):
2869 * src/widgets/modest-combo-box.h:
2870 * src/widgets/modest-global-settings-dialog-priv.h:
2871 * src/widgets/modest-global-settings-dialog.c:
2872 (modest_global_settings_dialog_finalize):
2873 * src/widgets/modest-msg-edit-window.h:
2874 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2875 as long as the combo box, to prevent use of freed memory for the ID.
2877 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2879 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2880 get_accounts(), to make this clearer. Do not check for the enabled gconf
2881 key, because we do not use this for server accounts (at least, not yet).
2882 This allows us to send email again.
2884 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2886 * src/maemo/modest-platform.c:
2887 (on_modest_conf_update_interval_changed), (modest_platform_init):
2888 Only respond to this particular key change. All these strcmp()s cannot be
2891 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2893 * src/maemo/modest-maemo-global-settings-dialog.c:
2894 (current_connection): Prevent a crash in scratchbox when
2895 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2896 * src/maemo/modest-platform.c:
2897 (on_modest_conf_update_interval_changed), (modest_platform_init):
2898 Get the update interval from gconf and reset it when the gconf key changes.
2900 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2902 * src/modest-protocol-info.c:
2903 * src/modest-protocol-info.h: Adde enum-specific get functions,
2904 instead of using a ModestProtocolType enum parameter.
2906 * src/gnome/modest-account-assistant.c:
2907 * src/gnome/modest-store-widget.c:
2908 * src/gnome/modest-store-widget.h:
2909 * src/gnome/modest-transport-widget.c:
2910 * src/gnome/modest-transport-widget.h:
2911 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2912 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2913 * src/maemo/easysetup/modest-easysetup-wizard.c:
2914 * src/maemo/modest-account-settings-dialog.c:
2915 * src/maemo/modest-account-settings-dialog.h:
2916 * src/maemo/modest-store-widget.c:
2917 * src/maemo/modest-store-widget.h:
2918 * src/maemo/modest-transport-widget.c:
2919 * src/maemo/modest-transport-widget.h:
2920 * src/modest-account-mgr-helpers.c:
2921 * src/modest-account-mgr-helpers.h:
2922 * src/modest-account-mgr.c:
2923 * src/modest-account-mgr.h:
2924 * src/modest-tny-account.c:
2925 * src/modest-tny-folder.c:
2926 * src/widgets/modest-account-view.c:
2927 * src/widgets/modest-retrieve-combo-box.c:
2928 * src/widgets/modest-retrieve-combo-box.h:
2929 * src/widgets/modest-secureauth-combo-box.c:
2930 * src/widgets/modest-serversecurity-combo-box.c:
2931 * src/widgets/modest-serversecurity-combo-box.h:
2932 * tests/check_account-mgr.c:
2933 Use the specific functions, and use the re-renamed enum values for GNOME too.
2935 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2937 * src/modest-pair.h:
2938 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2939 so we can get the second based on the first.
2941 * src/maemo/modest-account-settings-dialog.h:
2942 * src/maemo/modest-account-settings-dialog.c:
2943 Added get_supported_secure_authentication_methods(), though it is mostly
2944 commented-out for now until the necessary API is committed to tinymail.
2945 (modest_account_settings_dialog_set_account_name),
2946 (save_configuration): Request the supported authentication methods from the
2947 server, so we can choose a working method.
2949 * src/modest-tny-account-store.h:
2950 * src/modest-tny-account-store.c:
2951 (modest_tny_account_store_get_session): Rename from
2952 tny_account_store_get_session().
2954 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2956 * src/modest-protocol-info.h: Split the ModestProtocol enum
2957 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2958 There was no need to have these unrelated values in one enum.
2960 * src/: many files: Adapted to changed enum. This makes the code a bit
2961 clearer, and the compiler could catch some errors.
2963 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2965 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2966 Show the detailed internal camel error message when an error happens
2967 during the configuration, so that our testers can give us more clues.
2968 For instance, in projects.maemo.org bug NB#56910 .
2970 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2972 * src/modest-tny-account.c:
2973 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2974 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2976 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2978 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2979 * src/maemo/modest-account-settings-dialog.c:
2980 (modest_account_settings_dialog_set_account_name),
2981 (save_configuration): For the incoming secure authentication checkbox,
2982 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2983 the UI specification. PLAIN does not seem to be supported for most IMAP
2984 servers anyway, and I am not sure what it would mean.
2985 However, we probably need to discover which of the secure-authentication
2986 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2987 * src/modest-account-mgr-helpers.c:
2988 (modest_account_mgr_get_server_account_data):
2990 * src/modest-tny-account.c:
2991 (modest_tny_account_new_from_server_account):
2992 Use tny_account_set_mech() to set secure-authentication methods,
2993 with some special-casing for IMAP, based on my observations of how
2996 * src/modest-account-mgr-helpers.h:
2997 * src/modest-account-mgr.c:
2998 * src/modest-defs.h: Comment that the URI is only used for local folders.
3000 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3002 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3003 parameter const, just to be neat.
3004 * src/modest-text-utils.c: (modest_text_utils_inline):
3005 End g_strconcat() with NULL, as its documentation says. This is almost
3006 certainly the cause of my crash at startup on the device. Interestingly,
3007 valgrind doesn't tell us about these errors.
3009 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3011 * scripts/build-packages: Added more precise comments about how to use
3012 this script, though I still get this error:
3013 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3014 error building tinymail
3016 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3018 * src/maemo/modest-main-window.c: (on_account_update):
3019 Very slight cleanup, hoping to make it simpler to discover what causes
3020 a crash here sometimes.
3022 * src/modest-tny-account.c:
3023 (modest_tny_account_new_from_server_account): Set the port. Added
3024 comments about the options and a TODO comment because I need to find out
3025 how to specify the secure authentication method.
3027 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3029 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3030 changed CFlags paths form modest to libmodest
3032 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3034 * src/modest-account-mgr-helpers.c:
3035 (modest_account_mgr_get_server_account_data),
3036 (modest_account_mgr_free_server_account_data):
3037 * src/modest-account-mgr-helpers.h:
3038 * src/modest-account-mgr.c:
3039 (modest_account_mgr_add_server_account):
3040 * src/modest-defs.h:
3041 * src/modest-tny-account.c:
3042 (modest_tny_account_new_from_server_account):
3043 Determine the options for tny_camel_account_add_option() here,
3044 based on the settings, rather than storing them directly in gconf.
3046 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3048 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3049 Show a more friendly error dialog now that we expect (from the tinymail
3050 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3052 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3054 * src/maemo/modest-main-window.c: (on_account_update): Check that
3055 account_name is not NULL, to prevent a crash at startup that I am
3056 seeing on the N800. I do wonder why it is NULL.
3058 * src/maemo/easysetup/modest-easysetup-wizard.c:
3059 (create_page_user_details):
3060 * src/maemo/modest-account-settings-dialog.c:
3061 (create_page_user_details), (create_page_outgoing):
3062 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3063 (modest_connection_specific_smtp_edit_window_init):
3064 * src/modest-ui-actions.c:
3065 (modest_ui_actions_on_password_requested):
3066 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3067 might do something useful with the on-screen keyboard.
3069 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3071 * src/maemo/modest-main-window.c: (on_account_update):
3072 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3073 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3075 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3077 * src/modest-tny-account-store.c: (on_account_changed):
3078 Correct the signature of this signal handler.
3080 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3082 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3083 Show a HildonNote instead of a GtkDialog for Maemo.
3085 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3087 * src/widgets/modest-account-view.h:
3088 * src/widgets/modest-account-view.c: (on_account_changed),
3089 (on_account_removed). Added a boolean flag, set/unset by
3090 modest_account_view_block_conf_updates(),
3091 modest_account_view_unblock_conf_updates() to prevent unnecessary
3092 updates, but this is not very useful because the gconf notifications are
3093 so delays (maybe only on Maemo Bora).
3094 So auto-updating is turned off, and these functions do an explicit
3095 update when necessary.
3096 However, something else is still doing too much work when adding/removing
3097 accounts, probably in another part of the application.
3099 * src/maemo/modest-account-view-window.c:
3100 (on_delete_button_clicked), (on_edit_button_clicked),
3101 (on_new_button_clicked): Use the new functions.
3103 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3105 * src/modest-account-mgr-helpers.c:
3106 (modest_account_mgr_set_first_account_as_default):
3107 Sort the list of names alphabetically-by-title, so we choose the first one
3109 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3110 alphabetically by the title.
3112 This fixes projects.maemo.org bug NB#56418 .
3114 * src/modest-account-mgr-priv.c:
3115 (_modest_account_mgr_account_from_key):
3116 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3117 avoid a valgrind error, and possible random behaviour.
3119 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3121 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3122 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3123 tinymail documentation to say that this can be expected.
3124 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3125 pretty, and should not happen, but I would prefer to know when it does.
3127 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3129 * configure.ac: When using the older hildon version, probably on Bora,
3130 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3132 * src/widgets/modest-attachment-view.c:
3133 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3136 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3138 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3139 Implemented the prototype. Can be tested with
3140 tests/dbus_api/test_open_message:
3142 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3144 * src/modest-tny-account-store.c:
3145 (modest_tny_account_store_instance_init), (get_password):
3146 * src/modest-ui-actions.c:
3147 (modest_ui_actions_on_password_requested):
3148 Do not store the password in gconf, because this function is called
3149 for non-remembered passwords. Actually use the cached (in the hash map)
3150 password instead of releasing it.
3151 The password will now not be remembered if it is asked via the protected
3152 password dialog, as per the UI spec.
3154 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3156 * src/modest-defs.h:
3157 * src/modest-account-mgr-helpers.h:
3158 * src/modest-account-mgr-helpers.c:
3159 Added modest_server_account_get_username_has_succeeded(),
3160 modest_server_account_set_username_has_succeeded().
3161 (modest_server_account_set_username),
3162 Reset the has-succeeded flag if the username changes.
3164 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3165 * src/maemo/modest-connection-specific-smtp-window.c:
3166 (modest_connection_specific_smtp_window_save_server_accounts):
3167 Use modest_server_account_set_username() instead of using
3168 modest_conf_set_string() directly, so that the has-succeeded flag is always
3171 * src/modest-ui-actions.c:
3172 (modest_ui_actions_on_password_requested): Dim the username entry if
3173 the username has ever worked, as per the UI spec.
3175 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3177 * src/modest-tny-account-store.c: (get_password):
3178 * src/modest-ui-actions.c:
3179 (modest_ui_actions_on_password_requested):
3180 Allow the username to be changed too, though there is more work to
3181 be done on exactly how this behaves.
3183 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3185 * src/modest-account-mgr-helpers.h:
3186 * src/modest-account-mgr-helpers.c:
3187 Added modest_account_mgr_get_display_name(),
3188 modest_server_account_get_username(),
3189 modest_server_account_set_username(),
3190 modest_server_account_set_password(),
3191 modest_server_account_get_hostname() functions so we do not need to
3192 use the conf API directly.
3194 * src/maemo/modest-main-window.c: (connect_signals):
3195 Actually connect ot the ModestAccountStore::request-password signal,
3196 so that we show the dialog when the password is requested by Tinymail,
3197 for isntance if it is empty.
3199 * src/modest-marshal.list:
3200 * src/modest-tny-account-store.c:
3201 (modest_tny_account_store_class_init), (get_password),
3202 (modest_tny_account_store_alert):
3203 * src/modest-tny-account-store.h:
3204 * src/modest-ui-actions.h:
3205 * src/modest-ui-actions.c:
3206 (modest_ui_actions_on_password_requested):
3207 Change the signal parameters, so it is obvious that we are providing
3208 the non human-readable server name, and receiving both the username
3209 and password, though changing of the username is not yet implemented.
3210 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3211 for the GNOME version.
3213 This should fix the projects.maemo.org bug NB#56209, though it does not
3214 work on Bora, because the gconf_client_get() for the password fails
3215 immediately after we save it with gconf_client_set().
3217 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3220 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3221 caused an undefined symbol error:
3222 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3224 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3226 * src/modest-tny-account-store.c:
3227 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3228 using a GError instead of a string message, so we can translate it in
3231 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3233 * src/maemo/modest-address-book.c:
3234 (modest_address_book_check_names):
3235 * src/maemo/modest-msg-view-window.c:
3236 (modest_msg_view_window_clipboard_owner_change):
3237 * src/modest-init.c: (modest_init_init_ui):
3238 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3239 (update_folders_cb), (modest_mail_operation_update_account):
3240 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3241 (modest_ui_actions_on_msg_attachment_clicked),
3242 (modest_ui_actions_on_msg_recpt_activated):
3243 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3244 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3245 (modest_msg_view_search_next):
3246 * src/widgets/modest-recpt-editor.c:
3247 (modest_recpt_editor_on_button_release_event),
3248 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3249 g_message(). At this point we should only be seeing interesting errors on
3250 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3252 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3254 (modest_wizard_dialog_force_title_update):
3255 * src/maemo/easysetup/modest-wizard-dialog.h:
3256 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3257 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3258 can update the title when appropriate. Otherwise the title is wrong if the
3259 pages are added after adding the notebook to the dialog.
3260 This must be a problem in HildonWizardDialog too.
3261 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3263 * src/maemo/easysetup/modest-easysetup-wizard.c:
3264 (create_subsequent_customsetup_pages),
3265 (create_subsequent_easysetup_pages):
3266 Call modest_wizard_dialog_force_title_update() so that the title is
3267 correct even with GTK+ < 2.10.
3268 This fixes projects.maemo.org bug NB#56145 .
3270 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3272 * src/maemo/modest-platform.c:
3273 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3274 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3277 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3279 * src/widgets/modest-window.h:
3280 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3281 and modest_window_save_state(), which invokes it.
3283 * src/widgets/modest-window-mgr.h:
3284 * src/widgets/modest-window-mgr.c:
3285 Added modest_window_mgr_save_state_for_all_windows(), which calls
3286 the save_state vfunc on all registered windows, if implemented.
3288 * src/gnome/modest-msg-edit-window.c:
3289 * src/gnome/modest-msg-view-window.c:
3290 * src/maemo/modest-msg-edit-window.c:
3291 * src/maemo/modest-msg-view-window.c:
3292 * src/maemo/modest-main-window.c:
3293 Specify the existing save_settings functions as implementations of
3294 ModestWindow::save_state_func().
3296 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3297 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3298 enabling hibernation, for instance.
3300 We may need to do the same thing for restoring settings.
3303 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3305 * src/widgets/modest-window-mgr.c:
3306 * src/widgets/modest-window-mgr.h:
3307 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3308 modest_window_mgr_get_hibernation_is_prevented().
3310 * src/maemo/modest-main-window.c:
3311 (on_hildon_program_is_topmost_notify): Prevent hibernation
3312 (possible when the application goes to the background in the WM),
3313 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3315 * src/maemo/easysetup/modest-easysetup-wizard.c:
3316 (modest_easysetup_wizard_dialog_init):
3317 * src/maemo/modest-account-settings-dialog.c:
3318 (modest_account_settings_dialog_init):
3319 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3320 (modest_connection_specific_smtp_edit_window_init):
3321 * src/maemo/modest-connection-specific-smtp-window.c:
3322 (modest_connection_specific_smtp_window_init):
3323 * src/maemo/modest-signature-editor-dialog.c:
3324 (modest_signature_editor_dialog_init):
3325 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3326 prevent hibernation while any of these account settings dialogs are open.
3328 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3330 * src/maemo/Makefile.am:
3331 * src/maemo/modest-osso-state-saving.c:
3332 * src/maemo/modest-osso-state-saving.h: Added
3333 modest_osso_load_state() and modest_osso_save_state() though they do
3334 nothing now. They should iterate through all the open windows and load/save
3336 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3337 save state when closing.
3339 * src/maemo/modest-main-window.c:
3340 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3341 Add a notification handler for the HildonProgram::is-topmost property,
3342 so we can allow hibernation when the application goes into the background.
3343 But we still need to detect when the accounts setup windows are open so
3344 we can stop hibernation when they are open.
3345 To do this, I also added the main window the HildonProgram. This might have
3346 other side-effects/benefits, and should maybe be done for other windows.
3348 * src/maemo/modest-osso-autosave-callbacks.h:
3349 * src/maemo/modest-osso-autosave-callbacks.c:
3350 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3351 though it does not do anything yet, and we might never need this to do
3352 anything. For instance, we already save drafts.
3354 * src/maemo/modest-platform.c: (modest_platform_init):
3355 Specify the libosso auto-save callback.
3357 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3359 * src/maemo/modest-platform.c:
3360 (modest_platform_set_update_interval):
3361 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3362 aparently stays valid between application instances, so we can use this
3363 to remove and reset it later. According to a maemo-developers email from
3366 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3368 * configure.ac: Depend on libalarm for Maemo.
3370 * src/dbus_api/modest-dbus-api.h:
3371 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3372 (on_send_receive), (modest_dbus_req_handler):
3373 Handle a SEND_RECEIVE D-Bus method.
3375 * libmodest-dbus-client/libmodest-dbus-client.c:
3376 (libmodest_dbus_client_send_and_receive):
3377 * libmodest-dbus-client/libmodest-dbus-client.h:
3378 Add C convenience functions for calling the new D-Bus method.
3380 * src/modest-platform.h:
3381 * src/gnome/modest-platform.c:
3382 * src/maemo/modest-platform.c:
3383 Added modest_platform_set_update_interval(), which uses the
3384 alarmd API on Maemo.
3385 (modest_platform_init),
3386 Call modest_platform_set_update_interval(), using a hard-coded
3387 interval for now (until the global settings dialog is implemented),
3388 though I am not sure that this makes sense yet.
3390 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3392 * src/dbus_api/modest-dbus-callbacks.c:
3393 (modest_osso_cb_hw_state_handler):
3394 * src/dbus_api/modest-dbus-callbacks.h:
3395 * src/maemo/modest-platform.c: (modest_platform_init):
3396 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3397 in case this has some effect on the ability for Maemo to ping the
3400 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3402 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3403 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3404 warning. It is probably a logic error, but I need to fix the build.
3406 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3408 * src/modest-account-mgr.h:
3409 * src/modest-account-mgr.c:
3410 (modest_account_mgr_account_names): Add a gboolean enabled_only
3411 parameter, so we can get lists of onlt the enabled accounts.
3413 (modest_account_mgr_add_account),,
3414 (modest_account_mgr_account_with_display_name_exists):
3415 * src/maemo/modest-msg-edit-window.c: (get_transports):
3416 * src/modest-account-mgr-helpers.c:
3417 (modest_account_mgr_set_first_account_as_default):
3418 * src/modest-init.c: (init_default_account_maybe):
3419 * src/modest-tny-account-store.c: (get_accounts):
3420 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3421 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3422 * tests/check_account-mgr.c: (START_TEST):
3423 Provide the extra parameter, as appropriate.
3425 * src/widgets/modest-account-view.c: (update_account_view):
3426 Do not show disabled accounts (meaning that there is no way to
3427 enable/disable accounts in the UI (the feature is not in our UI
3428 specification), so we can use this internally only to mark unfinished
3429 or temporary account data.
3431 * src/maemo/easysetup/modest-easysetup-wizard.c:
3432 (create_account): Add boolean enable parameter, so we can specify FALSE
3433 to create the temporary account.
3434 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3435 (on_before_next): When finishing, when there is a temporary account, just
3437 Also, use a timeout to delay the showing of the dialog until gconf is likely
3438 to return correct information, due to a maemo gconf bug that is fixed in
3439 osso 1.1, but not yet in Bora.
3440 However, the dialog stays on screen after it is destroyed.
3442 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3443 for invalid data when cancelling. Use a hildon note instead of a dialog
3444 to complain about invalid data. Do not show the account-saved note if the
3445 account is disabled (a temporary account that will not really be saved for use
3448 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3450 * src/modest-account-mgr-helpers.h:
3451 * src/modest-account-mgr-helpers.c:
3452 Added modest_account_mgr_unset_default_account(),
3453 Added modest_account_mgr_set_first_account_as_default().
3455 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3456 If it was the default account, unset the default account name.
3458 * src/maemo/modest-account-view-window.c:
3459 (on_delete_button_clicked): If it was the default account,
3460 set the first remaining account as the default instead.
3462 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3463 a NULL account or a NULL default account, to prevent a crash. This should
3464 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3467 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3469 * src/widgets/modest-recpt-editor.c:
3470 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3471 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3472 TODO comment for this. This fixes the build.
3474 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3475 be the best place for it. This will in future update all auto-update accounts,
3476 rather than just the current/default account, when that gconf key exists.
3477 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3478 if there are no accounts, before calling do_send_receive().
3479 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3481 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3482 * src/maemo/modest-main-window-ui.h:
3483 * src/maemo/modest-main-window.c: (on_connection_changed),
3484 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3485 directly, becaue the signal handler does more.
3487 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3489 * src/modest-account-mgr-helpers.c:
3490 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3491 for the case that the account does not exist.
3493 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3494 (equivalent to the modest account name) rather than the tinymail account name
3495 (equivalent to the modest account title - human readable) to get the account data.
3496 Check for null account data to prevent the crash, and add a TODO comment saying that
3497 this needs fixing because it is using the server account name instead of the account name.
3499 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3501 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3502 * src/maemo/modest-account-settings-dialog.c: (show_error),
3504 Use hildon_note_new_information() for informative and error messages,
3505 which seems to be expected for Maemo applications (no documentation that I know of
3506 says this). I am surprised that there is no distinction between info and error
3509 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3511 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3512 it is easy to find where this is used.
3514 * src/maemo/easysetup/modest-easysetup-wizard.c:
3515 (create_page_welcome), (create_page_account_details),
3516 (create_page_user_details), (create_page_complete_easysetup),
3517 (create_page_custom_incoming), (create_page_custom_outgoing),
3518 (create_page_complete_custom):
3519 * src/maemo/modest-account-settings-dialog.c:
3520 (create_page_account_details), (create_page_user_details),
3521 (create_page_incoming), (create_page_outgoing):
3522 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3523 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3524 (modest_connection_specific_smtp_edit_window_init):
3525 * src/maemo/modest-connection-specific-smtp-window.c:
3526 (modest_connection_specific_smtp_window_init):
3527 * src/maemo/modest-signature-editor-dialog.c:
3528 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3529 and scrolling policy as per the Email Application Layout Guide, if I have
3532 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3534 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3535 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3536 which were empty, because these vfuncs have been removed from TnyAccountStore.
3537 This fixes the build.
3539 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3541 * src/maemo/modest-main-window.c:
3542 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3543 showing/hiding it. Added TODO because it probably should not be NULL.
3544 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3545 because unnecessary g_warnings() make degugging difficult.
3547 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3549 * src/maemo/modest-msg-edit-window.c:
3550 (modest_msg_edit_window_select_color),
3551 (modest_msg_edit_window_select_background_color): 2 const corrections and
3552 moving 2 #endifs before closing brackets, to fix the build.
3554 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3556 * src/maemo/easysetup/modest-easysetup-wizard.h:
3557 * src/maemo/easysetup/modest-easysetup-wizard.c:
3558 (modest_easysetup_wizard_dialog_finalize),
3559 (on_button_edit_advanced_settings), (create_page_complete_custom),
3560 (on_response), (create_account):
3561 Implement the Advanced Settings edit button, by saving the account information,
3562 for the Advanded Settings dialog to use directly from gconf, and removing it
3563 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3564 Bug #5533 in the projects.maemo.org bugzilla.
3566 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3568 * src/maemo/modest-msg-view-window.c:
3569 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3570 when opening a message window.
3572 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3574 * src/maemo/easysetup/modest-easysetup-wizard.c:
3575 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3578 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3579 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3580 gconf settings. I probably added more checks than necessary, but that is safer.
3582 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3583 variable to fix the build, but this seems to be used when it is still NULL.
3585 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3587 * src/modest-platform.h:
3588 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3589 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3590 * src/modest-main.c: Implement this function so we can avoid using
3591 maemo-specific API from cross-platform code.
3593 * src/modest-tny-account-store.c:
3594 (get_smtp_specific_transport_account_for_open_connection):
3595 * src/modest-ui-actions.c: (check_for_connection),
3596 (modest_ui_actions_on_item_not_found):
3597 Use modest_platform_connect_and_wait() and put #idefs around other
3598 maemo-specific code, because only maemo currently has a way to
3599 identify connection names.
3601 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3603 * src/modest-tny-account-store.h:
3604 * src/modest-tny-account-store.c:
3605 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3606 the connection-specific SMTP server settings in the configuration.
3608 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3610 * src/maemo/modest-main-window.c: (on_connection_changed),
3612 * src/modest-main.c: (main), (start_ui), (send_mail):
3613 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3614 that is what is intended.
3616 * src/modest-ui-actions.c: (action_send), (action_receive),
3617 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3618 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3619 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3620 SMTP server is used when it is specified.
3622 (modest_ui_actions_on_send_receive):
3623 Check that a connection is open before proceeding.
3624 Receive and then send, instead of vice-versa, as per the specification.
3626 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3628 * src/modest-mail-operation.c:
3629 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3630 though I guess it should be something other than NULL.
3632 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3634 * src/maemo/easysetup/modest-easysetup-wizard.c:
3635 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3636 combo twice, to avoid an g_warning and to make it visible again.
3637 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3638 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3639 (already intended) dereference when detaching, because we then recreate the menu.
3640 But I am not sure why the warning was happening, and it is possible that this is a memory
3643 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3645 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3646 and uri_parse_mailto() utility functions.
3647 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3649 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3651 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3653 * src/dbus_api/modest-dbus-api.h:
3654 * src/dbus_api/modest-dbus-callbacks.c:
3655 Use an idle callback to execute the modest code in the application's own thread.
3656 Remove the helloworld example method.
3657 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3658 parsed, and the open-message method is not implemented because this is not yet implemented in
3660 * libmodest-dbus-client/libmodest-dbus-client.c:
3661 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3662 (libmodest_dbus_client_open_message):
3663 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3665 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3666 body without crashing.
3668 * tests/dbus_api/Makefile.am:
3669 * tests/dbus_api/test_mail_to.c:
3670 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3672 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3674 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3675 Added file to fix the build. Sorry.
3677 * src/dbus_api/Makefile.am:
3678 * src/dbus_api/modest-dbus-api.h:
3679 * src/dbus_api/modest-dbus-callbacks.h:
3680 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3681 (modest_dbus_req_handler):
3682 Put constants in a separate header so it can be reused by the
3683 client library, without duplication
3685 * libmodest-dbus-client/Makefile.am:
3686 * libmodest-dbus-client/libmodest-dbus-client.c:
3687 (libmodest_dbus_client_call_helloworld),
3688 (libmodfest_dbus_client_send_mail),
3689 (libmodfest_dbus_client_mailto),
3690 (libmodfest_dbus_client_open_message):
3691 * libmodest-dbus-client/libmodest-dbus-client.h:
3692 (Partly) Implement a send_mail D-Bus method.
3694 * tests/dbus_api/Makefile.am:
3695 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3696 the send_email D-Bus method.
3698 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3702 * libmodest-dbus-client/Makefile.am:
3703 * libmodest-dbus-client/libmodest-dbus-client.c:
3704 * libmodest-dbus-client/libmodest-dbus-client.h:
3705 * tests/dbus_api/Makefile.am:
3706 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3707 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3709 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3711 * src/maemo/easysetup/modest-easysetup-wizard.c:
3712 (create_page_account_details):
3713 * src/maemo/modest-account-settings-dialog.c:
3714 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3715 widgets, because this might not be the default in future versions of the Maemo GTK+.
3716 However, I can not not get capitalization to work even in a simple test case.
3718 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3720 * src/maemo/easysetup/modest-easysetup-wizard.c:
3721 (create_page_custom_incoming), (create_page_custom_outgoing):
3722 * src/maemo/modest-account-settings-dialog.c:
3723 (create_page_account_details), (create_page_incoming),
3724 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3725 instead of using gtk_check_button_with_label(), so they are aligned like the other
3726 widgets, as per the UI spec.
3728 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3730 * src/maemo/easysetup/modest-easysetup-wizard.c:
3731 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3732 * src/widgets/modest-validating-entry.c:
3733 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3734 Modest prefix instead of an EasySetup prefix.
3736 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3738 * src/widgets/modest-validating-entry.h:
3739 * src/widgets/modest-validating-entry.c: (on_insert_text),
3740 Added easysetup_validating_entry_set_max_func(), used to set a callback
3741 to call when the max number of characters is reached. GtkEntry has a max-length
3742 already but is silent about it.
3744 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3745 (create_page_account_details), (create_page_user_details),
3747 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3748 (create_page_account_details), (create_page_user_details),
3749 (create_page_outgoing):
3750 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3751 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3752 the UI spec, when the user tries to enter more than the max number of characters.
3754 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3756 * src/maemo/easysetup/modest-easysetup-wizard.c:
3757 (create_page_user_details), (create_page_custom_incoming),
3758 (create_page_custom_outgoing):
3759 * src/maemo/modest-account-settings-dialog.c:
3760 (create_page_user_details), (create_page_incoming),
3761 (create_page_outgoing):
3762 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3763 (modest_connection_specific_smtp_edit_window_init):
3764 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3765 not appropriate. Bad Maemo-specific defaults!.
3767 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3769 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3770 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3771 (modest_signature_editor_dialog_set_settings):
3772 Disable the label and textview when the checkbox is disabled, and use the
3773 specified (UI spec) default signature text.
3775 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3777 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3778 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3780 * src/modest-defs.h:
3781 * src/modest-account-mgr-helpers.h:
3782 * src/modest-account-mgr-helpers.c:
3783 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3785 * src/maemo/Makefile.am:
3786 * src/maemo/modest-signature-editor-dialog.c:
3787 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3790 * src/maemo/modest-account-settings-dialog.h:
3791 * src/maemo/modest-account-settings-dialog.c:
3792 (modest_account_settings_dialog_finalize), (on_button_signature),
3793 (save_configuration): Use the new dialog when the Edit button is pressed, and
3794 save the changes if necessary, as per the UI spec.
3796 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3798 * src/maemo/Makefile.am:
3799 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3800 based on maemo-develoers email from Dirk.
3802 * src/maemo/easysetup/modest-easysetup-wizard.c:
3803 (create_page_welcome), (create_page_account_details),
3804 (create_page_user_details), (create_page_complete_easysetup),
3805 (create_page_custom_incoming), (create_page_custom_outgoing),
3806 (create_page_complete_custom),
3807 (modest_easysetup_wizard_dialog_init):
3808 * src/maemo/modest-account-settings-dialog.c:
3809 (create_page_account_details), (create_page_user_details),
3810 (create_page_incoming), (create_page_outgoing),
3811 (modest_account_settings_dialog_init):
3812 * src/maemo/modest-connection-specific-smtp-window.c:
3813 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3815 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3817 * src/maemo/easysetup/modest-easysetup-wizard.c:
3818 (create_page_account_details), (create_page_custom_outgoing),
3819 (create_page_complete_custom):
3820 * src/maemo/modest-account-settings-dialog.c:
3821 (create_page_user_details), (create_page_incoming),
3822 (create_page_outgoing):
3823 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3824 (modest_connection_specific_smtp_edit_window_init):
3825 Use the correct (UI spec) port min/max, and use horizontal separators,
3828 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3830 * src/maemo/easysetup/modest-easysetup-wizard.c:
3831 (set_default_custom_servernames):
3832 * src/maemo/modest-account-settings-dialog.c:
3833 (create_page_incoming), (on_combo_outgoing_security_changed),
3834 (on_combo_incoming_security_changed), (create_page_outgoing),
3835 (modest_account_settings_dialog_set_account_name),
3836 (save_configuration):
3837 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3838 (on_combo_security_changed),
3839 (modest_connection_specific_smtp_edit_window_init),
3840 (modest_connection_specific_smtp_edit_window_set_connection),
3841 (modest_connection_specific_smtp_edit_window_get_settings):
3842 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3845 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3848 * src/maemo/easysetup/modest-easysetup-wizard.c:
3849 (create_page_custom_outgoing), (create_page_complete_custom):
3850 * src/maemo/modest-account-settings-dialog.c:
3851 (create_page_user_details), (create_page_outgoing):
3852 * src/maemo/modest-account-view-window.c: (button_box_new):
3853 Use changed logical IDs as per the most recent UI spec:
3854 mcen_bd_emailsetup_edit -> mcen_bd_edit
3855 mcen_bd_emailsetup_delete -> mcen_bd_delete
3856 mcen_bd_emailsetup_close -> mcen_bd_close
3858 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3862 * src/dbus_api/Makefile.am:
3863 * src/dbus_api/modest-dbus-callbacks.c:
3864 * src/dbus_api/modest-dbus-callbacks.h:
3865 * src/maemo/modest-platform.c: (modest_platform_init):
3866 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3868 * tests/Makefile.am:
3869 * tests/dbus_api/Makefile.am:
3870 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3872 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3874 * src/maemo/modest-account-settings-dialog.c:
3875 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3876 Removed unnecessary includes.
3878 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3880 * src/maemo/easysetup/modest-easysetup-wizard.c:
3881 * src/maemo/modest-account-settings-dialog.c:
3882 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3883 * src/widgets/Makefile.am:
3884 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3885 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3886 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3887 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3888 * src/widgets/modest-secureauth-combo-box.c:
3889 * src/widgets/modest-secureauth-combo-box.h:
3890 * src/widgets/modest-serversecurity-combo-box.c:
3891 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3892 made the GObject names more consistent with the rest of the Modest code.
3894 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3896 * src/maemo/easysetup/Makefile.am:
3897 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3898 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3899 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3900 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3901 * src/maemo/easysetup/modest-easysetup-wizard.c:
3902 * src/maemo/easysetup/modest-validating-entry.c:
3903 * src/maemo/easysetup/modest-validating-entry.h:
3904 * src/maemo/modest-account-settings-dialog.c:
3905 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3906 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3907 widgets/ because they are used outside of easysetup too. After checking in,
3908 svn will allow me to rename them too.
3910 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3912 * src/gnome/modest-msg-edit-window.c:
3913 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3914 linker error, to fix the build on the GNOME platform.
3915 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3916 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3917 ifdefed out to avoid a warning.
3919 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3921 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3922 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3923 some alternative for GTK+ 2.6.
3925 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3927 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3929 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3930 specified for EmailAccountsDialog in UI spec.
3932 * src/maemo/easysetup/modest-easysetup-wizard.c:
3933 * src/maemo/easysetup/modest-easysetup-wizard.h:
3934 * src/maemo/modest-account-settings-dialog.c:
3935 * src/maemo/modest-account-settings-dialog.h:
3936 Reuse a member window widget for the connection-specific SMTP server accounts,
3937 so we can tell it to create/save the accounts only if we actually save changes.
3939 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3940 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3941 (modest_connection_specific_smtp_edit_window_get_settings):
3942 Return a struct instance for temporarily remembering the entered data.
3944 * src/maemo/modest-connection-specific-smtp-window.h:
3945 * src/maemo/modest-connection-specific-smtp-window.c:
3946 (modest_connection_specific_smtp_window_finalize),
3947 (modest_connection_specific_smtp_window_fill_with_connections),
3949 (modest_connection_specific_smtp_window_save_server_accounts),
3950 (update_model_server_names): Do not actually save data until asked,
3951 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3953 (on_selection_changed),
3954 (modest_connection_specific_smtp_window_init): Disable the edit
3955 button when nothing is selected.
3957 * src/modest-account-mgr-helpers.c:
3958 * src/modest-account-mgr-helpers.h:
3959 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3962 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3964 * src/modest-account-mgr-helpers.h:
3965 * src/modest-account-mgr-helpers.c:
3966 (modest_account_mgr_get_unused_account_name),
3967 (modest_account_mgr_get_unused_account_display_name): Added these
3968 utility functions, to avoid code duplication.
3970 * src/maemo/easysetup/modest-easysetup-wizard.c:
3971 (create_page_account_details), (create_account):
3972 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3973 (on_combo_security_changed),
3974 (modest_connection_specific_smtp_edit_window_init),
3975 (modest_connection_specific_smtp_edit_window_save_settings):
3976 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3977 * src/maemo/modest-connection-specific-smtp-window.c:
3978 (modest_connection_specific_smtp_window_finalize),
3979 (modest_connection_specific_smtp_window_fill_with_connections),
3980 (on_button_edit), (modest_connection_specific_smtp_window_init):
3981 * src/maemo/modest-connection-specific-smtp-window.h:
3982 Implementing saving of connection-specific server accounts.
3984 But I need to refactor this so we can save the data for each
3985 possible connection-specific account and only actually create the server accounts
3986 when the easysetup finished, or the OK button is pressed on the account settings
3989 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3991 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3992 (on_combo_security_changed):
3993 (modest_connection_specific_smtp_edit_window_init):
3994 Auto-fill the port number as in the account settings.
3996 (modest_connection_specific_smtp_edit_window_set_connection):
3997 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3998 * src/maemo/modest-connection-specific-smtp-window.c:
3999 (fill_with_connections), (on_button_edit),
4000 (modest_connection_specific_smtp_window_init):
4001 Turn the edit window into a dialog to simplify the code, and
4002 set a WM hint as in a GtkDialog, because only a popup can be on top of
4003 another window in Maemo, and popups usually have no WM decoration.
4005 * src/modest-defs.h:
4006 * src/modest-account-mgr-helpers.c:
4007 (modest_account_mgr_set_connection_specific_smtp),
4008 (modest_account_mgr_remove_connection_specific_smtp),
4009 (modest_account_mgr_get_connection_specific_smtp):
4010 * src/modest-account-mgr-helpers.h: Some functions to write the
4011 connection-specific SMTP server information. Not yet used.
4014 * src/widgets/modest-folder-view.c: (text_cell_data):
4015 Fix a warning about an uninitialized variable.
4016 (on_configuration_key_changed): Put an #ifdef around the use
4017 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4019 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4021 * src/maemo/modest-account-settings-dialog.h:
4022 * src/maemo/modest-account-settings-dialog.c:
4023 Added connect_for_modified() utility function to mark the new modified boolean.
4025 (create_page_account_details), (create_page_user_details),
4026 (create_page_incoming), (create_page_outgoing), (on_response),
4027 (modest_account_settings_dialog_init),
4028 (modest_account_settings_dialog_set_account_name):
4029 Only warn about unsaved changes when there are actually unsaved changes.
4031 * src/modest-account-mgr-helpers.c:
4032 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4033 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4034 to get the data from there in future.
4036 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4038 * src/modest-defs.h:
4040 * src/modest-account-mgr-helpers.h:
4041 * src/modest-account-mgr-helpers.c:
4042 Store the security account setting in a single conf key instead of using
4043 the options list, so that the list is left for just the to-be-removed camel hack,
4044 and because gconf_client_set_list() is failing for some reason.
4046 * src/modest-account-mgr.c:
4047 (modest_account_mgr_add_server_account):
4048 * src/maemo/modest-account-settings-dialog.c:
4049 (modest_account_settings_dialog_set_account_name),
4050 (save_configuration): Use the renamed functions.
4053 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4055 * src/widgets/Makefile.am:
4056 * src/widgets/modest-limit-retrieve-combo-box.c:
4057 * src/widgets/modest-limit-retrieve-combo-box.h:
4058 * src/widgets/modest-retrieve-combo-box.c:
4059 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4060 the account settings dialog.
4062 * src/modest-defs.h:
4063 * src/modest-account-mgr-helpers.h:
4064 * src/modest-account-mgr-helpers.c:
4065 (modest_server_account_get_option_secure_auth),
4066 (modest_server_account_set_option_secure_auth):
4067 * src/modest-account-mgr.c:
4068 (modest_account_mgr_add_server_account):
4069 Use the existing AUTH_MECH conf key for the secure-auth setting,
4070 instead of putting it in the list options, because this was actually used already.
4072 * src/maemo/modest-account-settings-dialog.c:
4073 (create_page_account_details),
4074 (modest_account_settings_dialog_set_account_name),
4075 (save_configuration):
4076 * src/maemo/modest-account-settings-dialog.h:
4077 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4078 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4080 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4082 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4083 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4084 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4086 * src/modest-defs.h:
4087 * src/maemo/modest-account-settings-dialog.c:
4088 (create_page_incoming), (on_combo_outgoing_security_changed),
4089 (on_combo_incoming_security_changed), (create_page_outgoing),
4090 (modest_account_settings_dialog_set_account_name),
4091 (save_configuration): Load/Save the port number, and change it when the
4092 security combo changes, to suitable defaults.
4094 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4096 * src/modest-account-mgr.c:
4097 (modest_account_mgr_add_server_account): Set the security and secure-auth
4098 options, and add a comment saying that the other camel-specific options should be
4101 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4103 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4105 * src/modest-tny-account-store.c: (account_list_free),
4106 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4107 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4110 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4112 * src/modest-protocol-info.c:
4113 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4114 is required by our UI spec. Maybe something in our implementation will use this eventually.
4115 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4116 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4117 instead of the previous 0 placeholder.
4119 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4120 secure-auth settings.
4121 * src/modest-account-mgr-helpers.h:
4122 * src/modest-account-mgr-helpers.c:
4123 (modest_server_account_data_get_option_secure_auth),
4124 (modest_server_account_set_option_secure_auth),
4125 (modest_server_account_data_get_option_security),
4126 (modest_server_account_set_option_security): Added this API for getting and setting the security
4127 and secure-auth settings.
4129 * src/maemo/modest-account-settings-dialog.h:
4130 * src/maemo/modest-account-settings-dialog.c:
4131 (modest_account_settings_dialog_finalize), (check_data),
4132 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4133 about changing titles.
4134 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4135 (save_configuration): Save the security and secure-auth settings.
4137 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4138 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4140 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4142 * src/modest-defs.h:
4143 * src/modest-account-mgr.c:
4144 (modest_account_mgr_add_server_account):
4145 Added and used defines for the options key and value pair strings,
4146 that are used so far, though they do not seem to correspond to anything in our
4147 UI specs or ModestProtocol enum.
4149 * src/modest-account-mgr-helpers.h:
4150 * src/modest-account-mgr-helpers.c:
4151 (compare_option_strings_for_name),
4152 (modest_server_account_data_get_option_value),
4153 (modest_server_account_data_get_option_bool),
4154 (modest_account_mgr_get_server_account_option):
4155 Added helper functions for parsing the options GSList.
4157 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4159 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4160 display name is based on the supplied account name.
4161 * src/modest-account-mgr.c:
4162 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4163 with an inefficient, but good-enough, implementation.
4165 * src/maemo/easysetup/modest-easysetup-wizard.c:
4166 (create_page_account_details), (on_before_next), (create_account):
4167 Check for existing display names rather than (non-user-visible) account names, and just
4168 create and set a unique account name at the end.
4170 * src/maemo/modest-account-settings-dialog.c:
4171 (modest_account_settings_dialog_init),
4172 (modest_account_settings_dialog_set_account_name),
4173 (create_page_incoming): Show the display name, instead of the account name.
4174 (on_response): Do some (not all) extra checks, as in the UI spec.
4175 (save_configuration): Save the display name if it was changed.
4177 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4179 * po/en_GB.po: Added needed logical ID and translation.
4180 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4181 (init_view): Made the is-default column clicking work.
4183 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4186 * src/maemo/easysetup/Makefile.am:
4187 * src/maemo/easysetup/modest-easysetup-wizard.c:
4188 (modest_easysetup_wizard_dialog_init):
4189 * src/maemo/easysetup/provider-data-test.keyfile:
4190 * src/maemo/easysetup/provider-data.keyfile:
4191 Moved the provider data file to the new modest-providers-data package and used it from there.
4193 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4195 * src/modest-local-folder-info.c:
4196 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4197 N_() was already used on the static strings, but this just marks it for translation without
4198 using the translation.
4200 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4202 * src/maemo/modest-account-settings-dialog.c:
4203 (create_page_incoming),
4204 (modest_account_settings_dialog_set_account_name):
4205 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4206 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4207 I will do this if nobody else gets there first.
4209 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4211 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4212 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4213 save the security stuff.
4215 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4217 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4218 Set the email address and user fullname, which I now see must be
4221 * src/maemo/modest-account-settings-dialog.h:
4222 * src/maemo/modest-account-settings-dialog.c:
4224 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4225 leave-on-server and authentication.
4226 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4229 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4232 * src/maemo/modest-account-settings-dialog.c:
4233 * src/maemo/modest-account-settings-dialog.h:
4234 Most (but not all) of the widgets are now present as specified by the UI spec.
4235 No changes are yet saved, and some details are not properly shown yet.
4237 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4239 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4241 * src/maemo/Makefile.am:
4242 * src/maemo/modest-account-settings-dialog.c:
4243 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4244 an existing account. Doesn't do much yet.
4246 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4247 Open the accounts settings dialog when Edit is clicked.
4249 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4251 * src/maemo/easysetup/Makefile.am:
4252 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4254 * src/maemo/easysetup/modest-easysetup-wizard.c:
4255 (modest_easysetup_wizard_dialog_init):
4256 Try to get the source directory from the build system,
4257 instead of hard-coding "./" into the source code, when opening our local
4258 copies of the configuration files.
4259 But this still fails when opening the wizard from the Accounts window,
4260 maybe because the working directory seems to change at runtime.
4261 So the wizard will fail the second time unless you copy the files into their
4262 proper locations - see the stdout warnings for the paths.
4264 (create_page_account_details),(on_before_next):
4265 Check for existing non-server accounts instead of server accounts,
4266 so the default account name is useful again, and to prevent trying to
4269 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4270 Show the wizard when New is clicked.
4272 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4273 (init_view): Show the column headers, and show the columns that are
4274 specified in the UI specs. However, something in Maemo's GTK+ prevents
4275 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4276 change the default account. This is despite unsetting the special properties.
4278 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4280 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4281 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4282 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4283 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4284 to make that clearer.
4285 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4287 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4289 * src/maemo/modest-account-view-window.c:
4290 (modest_account_view_window_init),
4291 (modest_account_view_window_new):
4292 Use the same buttons as specified in the
4293 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4294 the existing widgets, which never had a chance of working.
4295 Put the ModestAccountView treeview in a scrolled window.
4296 Do not repeat the initialization in both _init() and _new().
4298 * src/widgets/modest-account-view.c: (update_account_view):
4299 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4300 this widget and window shows no accounts.
4302 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4304 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4306 * src/maemo/easysetup/modest-easysetup-wizard.c:
4307 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4308 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4309 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4312 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4313 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4314 accounts exist yet, as in the UI spec.
4316 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4318 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4320 * src/maemo/Makefile.am:
4321 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4322 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4323 New window for editing connection-specific smtp details.
4324 Not fully implemented.
4326 * src/maemo/modest-connection-specific-smtp-window.c:
4327 (modest_connection_specific_smtp_window_finalize) :
4328 unref the tree model.
4329 (on_button_edit): Show the edit window.
4331 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4333 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4336 * src/maemo/Makefile.am:
4337 * src/maemo/modest-connection-specific-smtp-window.c:
4338 * src/maemo/modest-connection-specific-smtp-window.h:
4339 New window for showing the list of connections, for connection-specific
4340 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4341 * src/maemo/easysetup/modest-easysetup-wizard.c:
4342 (create_page_custom_outgoing): Show the new window when the button is clicked.
4344 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4346 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4347 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4348 * src/maemo/modest-msg-edit-window.c:
4349 (modest_msg_edit_window_insert_image):
4350 * src/modest-conf.c: (modest_conf_key_escape):
4351 * src/modest-mail-operation.c:
4352 (modest_mail_operation_send_new_mail):
4353 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4354 (modest_ui_actions_on_new_account):
4355 * src/widgets/modest-attachment-view.c: (update_filename_request):
4356 * src/widgets/modest-mail-header-view.c:
4357 Corrected warnings that were breaking the build, by commenting out unused variables,
4358 and a function, and by including a header.
4360 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4362 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4363 so we can #ifdef around platform-specific code when necessary.
4364 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4365 to allow this to build for the GNOME platform too.
4367 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4369 * src/maemo/easysetup/modest-easysetup-wizard.c:
4370 Added util_increment_name() and used it in create_page_account_details()
4371 to make sure that the default account name is always a new name.
4373 (modest_easysetup_wizard_dialog_init),
4374 (set_default_custom_servernames): Some minor memory management fixes.
4376 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4380 * src/modest-runtime.c: (init_i18n): Restored the translation
4381 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4382 are defined in config.h, and the translations are installed.
4384 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4385 is defined for translation.
4387 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4389 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4391 * src/maemo/easysetup/modest-easysetup-wizard.c:
4392 (modest_easysetup_wizard_dialog_init):
4393 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4394 Use realistic paths (though they should use $prefix generically) to the
4395 mcc_mapping and provider-data.keyfile files which might work when they
4396 are installed by the future version of the operator-wizard package,
4397 and then fallback to paths in our source code, with an explanatory
4400 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4404 * src/maemo/Makefile.am:
4405 * src/maemo/easysetup/: Added files from the previously-exernal
4406 osso-modest-easysetup.
4407 * src/maemo/modest-main-window-ui.h:
4408 * src/modest-ui-actions.c:
4409 * src/modest-ui-actions.h:
4410 Added modest_ui_actions_on_new_account() as a signal handler for the
4411 New Account menu item. It shows the easysetup wizard.
4412 * po/en_GB.po: Added additional needed logical IDs and translations.