1 2007-07-11 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4 Ignore the wrong (for now) secure-smtp setting in the presets -
5 just default to requiring secure authentication for SMTP, because
8 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
10 * src/widgets/modest-folder-view.c: (filter_row)
11 Do not show drafts folder (see UI specs)
13 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
15 * src/modest-ui-actions.c:
16 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
17 place and also not necessary.
19 * src/widgets/modest-folder-view.c: (filter_row)
20 Guess folder type and hide Sent & Outbox if necessary.
21 Fixed project.maemo.org NB#57328
23 2007-07-11 Murray Cumming <murrayc@murrayc.com>
25 * src/modest-ui-actions.h:
26 * src/modest-ui-actions.c:
27 (modest_ui_actions_on_delete_message):
28 Move some code into a new
29 modest_ui_actions_refresh_message_window_after_delete()
30 function so we can use it from elsewhere.
32 * src/dbus_api/modest-dbus-callbacks.c:
33 (on_idle_delete_message), (on_delete_message): Used an idle
34 handler, as we do for the other D-Bus method handlers.
35 Call modest_ui_actions_refresh_message_window_after_delete()
36 if the deleted message was open in a window. This fixed
37 projects.maemo.org bug NB#62862.
39 2007-07-11 Murray Cumming <murrayc@murrayc.com>
41 * src/modest-main.c: (main): Only show the UI at the start if
42 the showui command line option was given. For instance,
43 run-standalone src/modest showui
44 Otherwise, we wait for the top_application D-Bus method to
45 be sent by hildon-desktop when the application is selected
47 This allows us to run without a UI when osso-global-search
48 uses our D-Bus methods.
50 2007-07-11 Murray Cumming <murrayc@murrayc.com>
52 * src/dbus_api/modest-dbus-api.h: Added a define for a
53 top-application D-Bus method.
54 * src/dbus_api/modest-dbus-callbacks.c:
56 (modest_dbus_req_handler): Handle the top-application D-Bus
57 method, which might be an undocumented D-Bus signal sent by
58 hildon-desktop when it starts the application from the menu.
59 But I am not sure and I need to test it on the device, because
60 my scratchbox does not have the application in the menu now.
61 This method shows the main window, so that it can be invisible
62 when started, for instance, just for email searching from
65 * src/maemo/modest-main-window.c: (restore_settings),
66 (modest_main_window_new): Do not show the window immediately
67 upon creation. We show it later.
68 * src/modest-widget-memory.c: (save_settings_paned):
69 Try (unsuccessfully) to avoid saving the paned position when
70 it is not even visible.
71 (restore_settings_paned): Do not allow a silly paned position.
72 This seems necessary when not showing the window at first.
74 * tests/dbus_api/Makefile.am:
75 * tests/dbus_api/test_top_application.c: (main): Test for the
78 2007-07-10 Murray Cumming <murrayc@murrayc.com>
80 * src/modest-ui-dimming-rules.c:
81 (modest_ui_dimming_rules_on_new_msg),
82 (modest_ui_dimming_rules_on_reply_msg),
83 (modest_ui_dimming_rules_on_delete_msg),
84 (modest_ui_dimming_rules_on_details),
85 (modest_ui_dimming_rules_on_view_window_move_to),
86 (modest_ui_dimming_rules_on_view_previous),
87 (modest_ui_dimming_rules_on_view_next),
88 (_invalid_folder_for_purge): Added checks before
89 casting the window. This looks like an actual
90 logic error in _invalid_folder_for_purge(), because it
91 tries to use a ModestMainWindow as a message window.
93 2007-07-10 Murray Cumming <murrayc@murrayc.com>
95 * src/maemo/modest-account-settings-dialog.c:
96 (show_error): Use the same implementation as in
97 modest-easysetup-wizard.c:
98 (on_entry_invalid_character): The logical ID contains a %s.
99 Guessed what it should be.
100 (on_entry_max), (check_data), (on_response): Adapt to
101 changed show_error().
102 (create_page_account_details): Really call
103 modest_validating_entry_set_func() on the correct widgets.
104 * src/maemo/easysetup/modest-easysetup-wizard.c:
105 (on_entry_invalid_character): Fix the logical ID here too.
106 (create_page_account_details),
107 (create_page_user_details):
109 modest_validating_entry_set_func() on the correct widgets.
111 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
112 Do not try to use the account if it is NULL.
114 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
116 * src/modest-ui-actions.c: (create_move_to_dialog),
117 (modest_ui_actions_on_main_window_move_to),
118 (modest_ui_actions_on_msg_view_window_move_to):
119 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
120 (filter_row), (modest_folder_view_show_non_move_folders):
121 * src/widgets/modest-folder-view.h:
123 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
124 the Sent folder yet as it does not report the correct folder type.
126 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
128 * src/maemo/modest-msg-edit-window.c: (init_window):
131 2007-07-10 Murray Cumming <murrayc@murrayc.com>
133 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
134 Take a parent widget instead of a parent window, and
135 implement this with hildon_banner_show_information() instead.
136 Non-Maemo builds can just ifdef that there.
137 This fixed projects.maemo.org bug NB#62766.
139 (on_entry_invalid_character): Use show_error() again instead
140 of using hildon directly, and use the _CS() macro to use the correct
142 (create_account), (check_for_supported_auth_methods), (on_entry_max):
143 Pass a widget instead od a window to show_error().
145 2007-07-10 Murray Cumming <murrayc@murrayc.com>
147 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
148 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
149 This allows us to show the server name in the error message, fixing
150 projects.maemo.org bug NB#62904.
151 Also, use the appropriate logical ID message for the account protocol.
153 2007-07-10 Murray Cumming <murrayc@murrayc.com>
155 * src/modest-tny-account-store.c: (on_idle_wrong_password):
156 A compilation fix, though the build wasn't broken for me.
158 2007-07-09 Murray Cumming <murrayc@murrayc.com>
160 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
161 Do not try to unref a NULL folder store, to avoid a runtime warning.
162 This seems to happen sometimes when changing accounts settings.
164 2007-07-09 Murray Cumming <murrayc@murrayc.com>
166 * src/modest-tny-account-store.c:
167 (modest_tny_account_store_instance_init),
168 (modest_tny_account_store_finalize),
169 (on_account_settings_hide), (on_idle_wrong_password):
170 Use a GHashTable to ensure that we only show one account settings
171 dialog per modest account. This avoids us having a dialog open for
172 both the store and transport accounts, or due to repeated get_password()
173 calls that shouldn't happen anyway.
175 2007-07-09 Murray Cumming <murrayc@murrayc.com>
177 * src/maemo/modest-maemo-utils.c: (on_hide),
178 (modest_maemo_show_dialog_and_forget): Handle the response, because
179 the window is not even hidden by default.
181 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
182 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
183 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
184 which seems to prevent some modality problems.
186 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
187 Ignore user cancellation errors.
189 * src/modest-account-mgr-helpers.h:
190 * src/modest-account-mgr-helpers.c:
191 Added modest_server_account_get_password() and
192 modest_server_account_get_has_password() to avoid direct use of
195 * src/maemo/modest-account-settings-dialog.h:
196 * src/maemo/modest-account-settings-dialog.c:
197 (modest_account_settings_dialog_init): Store the notebook so we can
199 Added modest_account_settings_dialog_switch_to_user_info().
201 * src/modest-tny-account-store.c:
202 (get_password): When the password in the account settings is wrong (we think),
203 show the relevant page of the account settings dialog, in the mainloop.
204 However, we currently get many of these at once because cancel does not
206 (forget_password): Do not forget the password
207 from the account settings, because this causes side-effects when
208 tinymail seems to call it at strange time, maybe because of how we
209 are cancelling get_password().
210 (modest_tny_account_store_alert): Ignore user cancellations.
212 2007-07-09 Murray Cumming <murrayc@murrayc.com>
214 * src/maemo/modest-maemo-utils.h:
215 * src/maemo/modest-maemo-utils.c:
216 Added modest_maemo_show_information_note_and_forget() for use instead of
217 gtk_dialog_run() when the response is not needed, to avoid an extra
218 mainloop which could cause a hang.
220 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
221 Use the logical IDs for the error message, though they are not
222 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
223 because gtk_dialog_run() caused a hang here (the window did not close).
224 This fixes projects.maemo.org bug NB#62646.
226 2007-07-09 Murray Cumming <murrayc@murrayc.com>
228 * src/modest-account-mgr-helpers.h:
229 * src/modest-account-mgr-helpers.c:
230 Added modest_account_mgr_get_store_protocol().
232 * src/maemo/modest-account-view-window.c:
233 (on_delete_button_clicked): Show different warning text depending on
234 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
235 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
238 2007-07-09 Murray Cumming <murrayc@murrayc.com>
240 * src/maemo/modest-msg-edit-window.c:
241 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
242 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
244 2007-07-07 Armin Burgmeier <armin@openismus.com>
246 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
247 ckdg_ib_maximum_characters_reached from correct package.
249 * src/modest-ui-actions.c: Show an error message when a folder could
250 not be created. Tinymail does not give us specific error codes about
251 what has gone wrong, so we assume that a folder with that name
252 already exists, though there might be other reasons.
254 2007-07-06 Murray Cumming <murrayc@murrayc.com>
256 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
257 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
258 give a more exact error message that can be partly translated.
260 2007-07-05 Murray Cumming <murrayc@murrayc.com>
262 * src/maemo/modest-address-book.c:
263 (select_email_addrs_for_contact): Specify a default window size for the
264 select-email-address dialog, so that it is probably big enough for the
265 title. This should fix projects.maemo.org bug NB#62277.
267 2007-07-05 Murray Cumming <murrayc@murrayc.com>
269 * src/maemo/easysetup/modest-easysetup-wizard.c:
270 (create_page_complete_easysetup): Use
271 gtk_widget_set_size() request to ensure that the text wraps
274 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
276 * src/maemo/easysetup/modest-easysetup-wizard.c:
277 (on_entry_invalid_character), (create_page_account_details),
278 (create_page_user_details):
279 Use new API of ModestValidatingEntry. But for some reason the banner is
280 not shown. I will have to investigate that further.
282 * src/widgets/modest-validating-entry.c: (on_insert_text),
283 (modest_validating_entry_set_func):
284 * src/widgets/modest-validating-entry.h:
285 Added a new callback function to be able to react to prevented
286 characters whitespaces to e.g show a banner.
288 2007-07-05 Armin Burgmeier <armin@openismus.com>
290 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
291 notification of HildonNumberEditor instead of remembering the port
292 number. Thanks to Johannes for pointing this out.
294 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
296 * src/maemo/easysetup/modest-easysetup-wizard.c:
297 Check if there are any user changes before showing a confirmation
298 dialog (projects.maemo.org NB#60946)
300 2007-07-05 Armin Burgmeier <armin@openismus.com>
302 * src/maemo/modest-account-settings-dialog.c: Remember custom port
303 number at the beginning of the dialog and set the modified flag at the
304 end if the port number has changed. This is necessary because
305 HildonNumberEditor does not support notification when the value has
308 2007-07-05 Murray Cumming <murrayc@murrayc.com>
310 * src/modest-ui-actions.c:
311 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
312 a connection before asking anything else. Correct the check for the destination
313 folder so that it succeeds when online.
314 This fixed projects.maemo.org bug NB#61645.
316 2007-07-05 Murray Cumming <murrayc@murrayc.com>
318 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
319 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
320 to fix projects.maemo.org bug NB#62439.
322 2007-07-05 Murray Cumming <murrayc@murrayc.com>
324 * src/modest-tny-account.c: (on_connection_status_changed):
325 Really do not use tny_device_force_offline() here. See the previous comment.
327 2007-07-04 Murray Cumming <murrayc@murrayc.com>
329 * src/modest-tny-account.c: (on_connection_status_changed):
330 Do not use tny_device_force_offline() when tinymail says that something
331 went wrong with the connection. It seems to report this unnecessarily.
333 2007-07-04 Murray Cumming <murrayc@murrayc.com>
335 * src/maemo/modest-connection-specific-smtp-window.c:
336 (modest_connection_specific_smtp_window_init):
337 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
338 does not seem to have any effect in osso 1.1 (though it works in
339 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
341 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
343 * src/maemo/modest-connection-specific-smtp-window.c:
344 Fix UI specification problems with projects.meamo.org NB#60479
346 2007-07-04 Murray Cumming <murrayc@murrayc.com>
348 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
349 clue when this has failed, because the error dialog is not always shown
350 (at least in earlier version).
352 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
353 GError message, because the generic error dialog is not helpful.
355 'This message is not currently available (can't let a new connection go online)'
356 when trying to open an IMAP message.
358 (_modest_ui_actions_open): Offer a connection when some messages would
359 have to be downloaded and we are offline.
361 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
363 * src/widgets/modest-folder-view.c:
364 Don't check for MERGE type anymore as we use the correct type
366 NOTE: For the last two changes you need to update your tinymail copy
367 because of API changes!
369 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
371 * src/modest-tny-local-folders-account.c:
372 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
373 (see projects.maemo.org NB#61580)
375 2007-07-04 Murray Cumming <murrayc@murrayc.com>
377 * src/modest-tny-account.c: (on_connection_status_changed):
378 Commented out the call to modest_platform_connect_and_wait() because this
379 seems to always hang, and I would like to know if this is the only thing
380 that causes a hang when showing the connection dialog.
381 It is not very useful anyway.
383 2007-07-04 Murray Cumming <murrayc@murrayc.com>
385 * src/maemo/modest-msg-view-window.c:
386 (modest_msg_view_window_select_next_message):
388 * src/modest-platform.h:
389 * src/maemo/modest-platform.c:
390 Added modest_platform_connect_and_wait(), which calls
391 tny_maemo_conic_device_connect() always in the main thread, by calling it
392 in an idle handler and waiting for the idle handler to run. It should be
393 in the main thread because it uses GTK+ UI code. It just returns TRUE
394 if the device is already online.
396 There is some nasty code to ensure that subsequent calls to
397 modest_platform_connect_and_wait() just wait for the first one to finish,
398 by checking repeatedly in another idle handler. This is necessary,
399 because other threads (or even the main thread, via another idle handler)
400 can call modest_platform_connect_and_wait() while
401 modest_platform_connect_and_wait() is running.
403 (modest_platform_connect_and_wait_if_network_account),
404 (modest_platform_connect_and_wait_if_network_folderstore):
405 Convenience functions that calls modest_platform_connect_and_wait() if
406 the account or folder might want network access.
408 * src/modest-mail-operation.c:
409 (modest_mail_operation_update_account):
410 * src/modest-ui-actions.c: (download_uncached_messages),
411 (modest_ui_actions_on_rename_folder), (delete_folder),
412 (modest_ui_actions_on_main_window_move_to),
413 (modest_ui_actions_on_msg_view_window_move_to):
414 * src/widgets/modest-folder-view.c:
415 (drag_and_drop_from_folder_view):
416 Offer a connection if we are offline.
418 * src/modest-tny-account.c: (on_connection_status_changed):
419 Document this as only handling errors during network operations in progress,
420 and replace the idle code with a simple call to
421 modest_platform_connect_and_wait(), which does this instead.
423 2007-07-03 Murray Cumming <murrayc@murrayc.com>
425 * src/modest-tny-account.c:
426 (modest_tny_account_get_special_folder): (util_on_idle),
427 Handle the GError so we can see when tny_folder_store_get_folders()
428 fails, as it currently does while something else is connecting.
430 Added util_run_in_main_thread_and_wait()
431 which uses an idlen handler and mainloop to ensure that the function
432 is called in the main thread.
433 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
434 to make sure that we call attempt the connection in the mainloop only,
435 which might solve some hangs.
437 2007-07-03 Murray Cumming <murrayc@murrayc.com>
439 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
440 be found by their display name. This is never useful.
441 * src/modest-tny-account-store.c: (on_account_removed): Find the account
442 by its ID, instead of trying to use its ID as its display name.
444 * src/modest-tny-account-store.h:
445 * src/modest-tny-account.c:
446 (modest_tny_account_get_special_folder): Add a g_warning() when
447 tny_folder_store_get_folders() returns an empty list for the maildir.
449 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
450 Add a g_warning() when this returns NULL, because that it not allowed
453 2007-07-02 Armin Burgmeier <armin@openismus.com>
455 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
456 note when trying to cancel the wizard. This fixes projects.maemo.org
459 2007-07-02 Murray Cumming <murrayc@murrayc.com>
461 * src/modest-tny-account.h:
462 * src/modest-tny-account.c:
463 (modest_tny_account_new_from_server_account),
464 (modest_tny_account_new_from_server_account_name),
465 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
466 because this must now be set before setting the proto. This is usd in
467 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
468 warning in camel_session_get_service() caused by
469 tny_camel_transport_account_prepare().
471 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
474 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
476 * src/maemo/modest-connection-specific-smtp-edit-window.c:
478 (modest_connection_specific_smtp_edit_window_init):
480 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
483 2007-06-29 Murray Cumming <murrayc@murrayc.com>
485 * src/modest-tny-account.c:
486 (modest_tny_account_new_from_server_account):
487 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
488 now uses to request a connection when it needs one, and which it uses
489 to tell us that something is wrong with the connection, so we can force
490 the accounts offline to prevent further problems.
493 * src/modest-init.c: (init_default_settings):
494 * src/modest-mail-operation.c:
495 (modest_mail_operation_update_account):
496 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
497 This should not be necessary anymore. Do not set the conf key that
498 determined this (it was always TRUE and not set anywhere else).
500 * src/modest-ui-actions.h: Remove unused and unimplemented
501 modest_ui_actions_on_online_toggle_toggled().
503 2007-06-29 Murray Cumming <murrayc@murrayc.com
505 * src/maemo/modest-main-window.c: (connect_signals):
506 Don't connect to delete_event twice. Maybe this was harmless.
508 2007-06-29 Murray Cumming <murrayc@murrayc.com
510 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
511 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
512 Debug output to give some more clue when a folder move is not allowed.
514 2007-06-28 Murray Cumming <murrayc@murrayc.com
516 * src/modest-tny-account.c: (on_modest_file_system_info),
517 (modest_tny_account_get_mmc_account_name):
518 Always call the callback, without checking whether the name has changed.
519 * src/widgets/modest-folder-view.c: (strings_are_equal),
520 (on_model_foreach_set_name), (on_get_mmc_account_name),
521 (text_cell_data): Compare the name here, and use the name from
522 the account rather than from the
523 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
524 if the name was changed after the account was added to the model.
525 That's a tinymail bug but not one that I want to fix now.
527 This finally fixes projects.maemo.org bug NB#59301.
529 2007-06-27 Armin Burgmeier <armin@openismus.com>
531 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
534 2007-06-27 Murray Cumming <murrayc@murrayc.com
536 * src/modest-tny-account.h:
537 * src/modest-tny-account.c:
538 Added modest_tny_account_get_mmc_account_name(), to set the memory
539 card name asynchronously for the given account and then notify.
540 (modest_tny_account_new_for_local_folders): Use this new function instead
541 of using hildon_file_system_info_async_new() directly.
543 * src/widgets/modest-folder-view.c: (text_cell_data):
544 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
545 gtk_tree_model_row_changed() when it is available.
547 This should fix projects.maemo.org bug NB#59301.
549 2007-06-27 Murray Cumming <murrayc@murrayc.com
551 * src/modest-mail-operation.c: (update_account_thread),
552 (get_msgs_full_thread): Fix typo failures in the revert
555 2007-06-27 Murray Cumming <murrayc@murrayc.com
557 * src/maemo/modest-maemo-global-settings-dialog.c:
558 (idle_select_default_focus):
559 * src/modest-mail-operation.c: (idle_notify_progress),
560 (idle_notify_progress_once), (set_last_updated_idle),
561 (update_account_thread), (get_msgs_full_thread):
562 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
563 * src/widgets/modest-header-view.c:
564 (idle_notify_headers_count_changed_destroy),
565 (idle_notify_headers_count_changed):
566 Reverted the additions of gdk_threads_enter/leave(), in case this
567 helps with a startup hang on the device.
569 2007-06-26 Armin Burgmeier <armin@openismus.com>
571 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
572 for supported secure authentication methods from server by
573 gtk_dialog_run(), saving CPU time and a potential race condition.
575 2007-06-26 Armin Burgmeier <armin@openismus.com>
577 * src/maemo/modest-maemo-utils.h:
578 * src/maemo/modest-maemo-utils.c: Added a
579 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
580 only error code to tell the calling code when the user canceled the
583 * src/maemo/modest-account-settings-dialog.h:
584 * src/maemo/modest-account-settings-dialog.c:
585 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
586 message if the retrieval of secure authentication methods was canceled
587 by the user. Perform the check before saving anything to configuration
588 to not end up with half-committed configuration changes, do not show
589 a "Saving to configuration failed" note when authentication methods
590 could not be retrieved.
592 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
595 2007-06-26 Murray Cumming <murrayc@murrayc.com>
597 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
598 Only return the first level of folders under accounts, because the
599 osso-global-search UI spec doesn't want the rest.
600 This fixed projects.maemo.org bug NB#61811.
602 2007-06-26 Murray Cumming <murrayc@murrayc.com>
604 * src/modest-tny-account-store.c:
605 * src/modest-tny-account-store.h:
606 Added modest_tny_account_is_memory_card_account().
607 * src/maemo/modest-main-window.c: (create_details_widget):
608 Show the same information items for the memory card as we show for the
609 local-folders, to fix projects.maemo.org bug NB#59307.
611 2007-06-26 Murray Cumming <murrayc@murrayc.com>
613 * src/modest-tny-account-store.c: (get_password):
614 Added some checks for NULL to maybe prevent crashes, though I think
615 it was Philip's last commit that actually prevented the crash here
616 when creating a first new account.
617 But the new account is still not usable (no messages are shown)
618 until a restart of the application.
620 2007-06-26 Murray Cumming <murrayc@murrayc.com>
622 * src/maemo/modest-maemo-global-settings-dialog.c:
623 (idle_select_default_focus):
624 * src/modest-mail-operation.c: (idle_notify_progress),
625 (idle_notify_progress_once), (idle_notify_update_account_queue),
626 (set_last_updated_idle), (update_account_thread),
627 (notify_get_msgs_full), (get_msgs_full_destroyer),
628 (get_msgs_full_thread):
629 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
630 * src/widgets/modest-header-view.c:
631 (idle_notify_headers_count_changed_destroy),
632 (idle_notify_headers_count_changed):
633 Use gdk_threads_enter() and gdk_threads_enter_leave() in
634 all idle handlers, because some other thread could be blocking
635 the GDK lock, so that it can do GUI stuff.
637 2007-06-26 Murray Cumming <murrayc@murrayc.com>
639 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
640 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
641 (on_idle_send_receive), (on_idle_open_default_inbox):
642 * src/maemo/modest-msg-edit-window.c:
643 (modest_msg_edit_window_attach_file_noninteractive):
644 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
645 to prevent a hang. I don't quite understand why these are necessary,
646 beause we should already be in the main loop. I guess something outside
647 of the main loop is taking the lock.
649 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
650 we are really using URIs, and use files that are more likely to exist.
652 2007-06-26 Murray Cumming <murrayc@murrayc.com>
654 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
655 necessary because configure.ac now defines different variables.
657 2007-06-26 Murray Cumming <murrayc@murrayc.com>
659 * libmodest-dbus-client/libmodest-dbus-client.c:
660 * libmodest-dbus-client/libmodest-dbus-client.h:
661 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
662 libmodest_dbus_client_compose_mail() is what things actually use.
664 * src/dbus_api/modest-dbus-api.h:
665 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
666 * tests/dbus_api/Makefile.am:
667 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
670 2007-06-26 Murray Cumming <murrayc@murrayc.com>
672 * src/modest-init.c: (modest_init_local_folders):
673 For memory-card (or other non local-folders) maildir accounts,
674 always create an Archive folder, so that there is somewhere to put
675 messages. This should be less confusing, because the user does not need
676 to guess that the need to create a folder.
678 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
680 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
681 Fixed icon size by using (50, 50) which is the same as defined by
684 2007-06-25 Armin Burgmeier <armin@openismus.com>
686 * src/widgets/modest-window-mgr.c:
688 * configure.ac: Correctly recognize hildon-notify presence and fixed
689 the build without it being installed.
691 2007-06-25 Murray Cumming <murrayc@murrayc.com>
693 * libmodest-dbus-client/libmodest-dbus-client.c:
694 (libmodest_dbus_client_search): Fix the build. Sorry.
695 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
696 (reply_forward_cb): Initialize variables to fix the build.
698 * src/modest-tny-account-store.c:
699 (modest_tny_account_store_get_tny_account_by): Fix the account URI
700 comparison (a silly typo) so that email search results can be opened
701 when there are more than one account.
703 2007-06-25 Murray Cumming <murrayc@murrayc.com>
705 * libmodest-dbus-client/libmodest-dbus-client.c:
706 (libmodest_dbus_client_search),
707 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
708 instead of 1 second, because the search gets folders and messages from
709 the server, which can take a long time. When it times out,
710 osso-global-search will report no results.
712 We need to specify whether we should search only cached information
713 (maybe with a user preference), and the osso-email-search-plugin
714 API should really be improved to allow that option, and to allow results
715 to be delivered asynchronously in batches.
717 2007-06-25 Murray Cumming <murrayc@murrayc.com>
719 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
720 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
721 GTK_ICON_SIZE_DIALOG is probably the wrong size.
723 2007-06-25 Murray Cumming <murrayc@murrayc.com>
725 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
726 that is an empty string. D-Bus seems to give us these instead of NULL.
728 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
730 * src/dbus_api/modest-dbus-callbacks.c:
731 * src/maemo/easysetup/modest-easysetup-wizard.h:
732 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
733 * src/maemo/modest-connection-specific-smtp-edit-window.c:
734 (modest_connection_specific_smtp_edit_window_init):
735 * src/maemo/modest-maemo-global-settings-dialog.c:
737 * src/maemo/modest-maemo-utils.c:
738 (modest_maemo_utils_setup_images_filechooser):
739 * src/maemo/modest-main-window.c: (create_details_widget):
740 * src/maemo/modest-msg-edit-window.c:
741 (modest_msg_edit_window_attach_file_noninteractive),
742 (modest_msg_edit_window_color_button_change),
743 (modest_msg_edit_window_set_zoom):
744 * src/modest-mail-operation.c: (update_account_thread):
745 * src/modest-tny-account-store.c:
746 * src/modest-tny-account.c:
747 * src/widgets/modest-global-settings-dialog.c:
748 * src/widgets/modest-window.h:
752 2007-06-25 Murray Cumming <murrayc@murrayc.com>
754 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
755 * src/modest-search.c: (modest_search_folder),
756 (modest_search_all_accounts): Actually search only in the specified folder,
757 doing a simple match on the folder ID.
758 * src/modest-search.h: Added a folder field to the ModestSearch struct,
759 and added some documentation.
761 2007-06-22 Armin Burgmeier <armin@openismus.com>
763 * src/maemo/modest-maemo-utils.h:
764 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
765 modest_maemo_utils_get_supported_secure_authentication_methods.
767 * src/maemo/easysetup/modest-easysetup-wizard.c:
768 * src/maemo/modest-account-settings-dialog.c: Show correct error if
769 one occured, not just "Server does not support secure authentication".
771 2007-06-22 Murray Cumming <murrayc@murrayc.com>
773 * src/modest-tny-account-store.c: (get_password):
774 Restored the call to tny_account_set_user() because Philip seems to have
775 stopped this from crashing (by not using the freed string). It still does
776 not work, but now we can test it.
778 2007-06-22 Murray Cumming <murrayc@murrayc.com>
780 * src/maemo/modest-msg-edit-window.c: (init_window):
781 Comment out use of an uninitialzed GtkScrolledWindow variable,
782 to fix the build and stop a crash. Yet again.
784 2007-06-22 Murray Cumming <murrayc@murrayc.com>
786 * src/modest-tny-account-store.c: (get_password):
787 Remove the call to tny_account_set_user() because this actually crashes.
788 As mentioned in the last commit, it is known to not work anyway.
790 2007-06-22 Murray Cumming <murrayc@murrayc.com>
792 * src/modest-tny-account-store.c: (get_password):
793 Use tny_account_set_username() to tell tinymail that the username might
794 have changed too. But tinymail ignores this: see projects.maemo.org
796 * src/modest-ui-actions.c:
797 (modest_ui_actions_on_password_requested): Remove the useless attempt to
798 reset the connection when changing the username, and improve the comments.
799 Save the changed username to gconf at least, so it is used when Modest is
802 2007-06-21 Murray Cumming <murrayc@murrayc.com>
804 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
805 Do not use a query, so that we get all folders, including for POP and
806 local-folders. They work as search criteria too.
807 This fixes projects.maemo.org bug NB#57740.
809 2007-06-21 Murray Cumming <murrayc@murrayc.com>
811 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
812 Comment out the use of hildon_notification_set_sound() because it is
813 not declared, to fix the build. Warnings are serious, people.
815 2007-06-21 Armin Burgmeier <armin@openismus.com>
817 * src/maemo/modest-maemo-utils.h:
818 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
819 modest_maemo_utils_get_supported_secure_authentication_methods()
820 to query authentication methods for a specific user. This should fix
821 projects.maemo.org bug NB#61369.
823 * src/maemo/easysetup/modest-easysetup-wizard.c:
824 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
827 2007-06-21 Murray Cumming <murrayc@murrayc.com>
829 * libmodest-dbus-client/libmodest-dbus-client.h:
830 * libmodest-dbus-client/libmodest-dbus-client.c:
831 (modest_dbus_message_iter_get_search_hit),
832 (libmodest_dbus_client_search):
833 Reorganised and commented this.
834 Removed modest_search_hit_free() from the public API because it
837 Added libmodest_dbus_client_get_folders() and
838 modest_folder_result_list_free().
840 * src/dbus_api/modest-dbus-api.h:
841 * src/dbus_api/modest-dbus-callbacks.c:
842 (modest_dbus_req_filter): Commented. Moved most code to
843 on_dbus_method_search() and added on_dbus_method_get_folders().
845 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
846 of the extra D-Bus handler.
848 * tests/dbus_api/Makefile.am:
849 * tests/dbus_api/test_get_folders.c: New test for
850 libmodest_dbus_client_get_folders(). This seems to return an empty list
851 at the moment. That could be the same error that causes the message list
852 to be empty sometimes.
853 This should help with projects.maemo.org bug NB#57740.
855 2007-06-21 Armin Burgmeier <armin@openismus.com>
857 * src/modest-mail-operation.c: Do not call
858 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
859 notify the operation's end after having set the status to CANCELED for
860 the operation queue to listen on. This fixes a deadlock when there
861 were mail operations in the queue during its finalization.
863 * src/modest-singletons.c: Reordered uninitialization of the account
864 manager to happen after the mail operation queue was uninitialized
865 because the mail operation's in the queue might still try to access
866 the account manager (see modest_mail_operation_notify_end()). This
867 fixes a potential crash when terminating the application.
869 2007-06-21 Murray Cumming <murrayc@murrayc.com>
871 * src/modest-search.c:
872 (search_mime_part_and_child_parts): Moved some code here so we
873 can search recursively in child folders.
874 (modest_search_folder): Search in the message as a mime part, instead
875 of just its child mime parts.
876 (read_chunk), (search_mime_part_ogs):
877 Check how many bytes were read, to prevent an endless loop.
878 Searching in message bodies now works. This finishes the fix for
879 projects.maemo.org bug NB#61007.
881 2007-06-20 Murray Cumming <murrayc@murrayc.com>
883 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
884 Add a g_warning when the item is not a folder.
886 * src/modest-ui-dimming-rules.c:
887 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
888 when selected item is not a folder (for instance, an account), because
889 the UI spec only talks about folders.
890 I am not sure what the UI spec wants, so this might not totally fix
891 projects.maemo.org bug NB#60794.
893 2007-06-20 Murray Cumming <murrayc@murrayc.com>
895 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
896 (load_from_file): Sort the list. The unsorted list would be more noticeable
897 in non-English locales.
899 * src/maemo/modest-msg-edit-window.c:
900 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
901 warning and fix the build.
903 * src/maemo/modest-progress-bar-widget.c:
904 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
905 avoid a g_warning, and probably to avoid a crash.
907 2007-06-20 Murray Cumming <murrayc@murrayc.com>
909 * src/modest-search.c: (modest_search_folder): Check for a GError
910 when calling tny_folder_get_headers(), to show that this is not the cause
913 2007-06-20 Murray Cumming <murrayc@murrayc.com>
915 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
916 Actually set the body query instead of the subject query.
918 * src/modest-search.c: (search_mime_part_ogs),
919 (search_mime_part_strcmp): Remove extra space from the text/* regex,
920 which would probably cause it to fail if we got this far.
922 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
923 to simplify the code.
924 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
925 be causing search-in-body to fail.
927 2007-06-20 Murray Cumming <murrayc@murrayc.com>
929 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
931 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
932 Better debug message when the folder cannot be found.
933 This should help with fixing projects.maemo.org bug #61287.
934 * src/modest-search.c: (add_hit): Do not leak the furl string.
936 2007-06-20 Murray Cumming <murrayc@murrayc.com>
938 * src/modest-ui-actions.c:
939 (modest_ui_actions_on_folder_selection_changed):
940 Do not special-case TNY_MERGE_FOLDER here, because
941 modest_tny_folder_get_account() already does that. This fixes
942 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
943 shown when the Outbox was selected).
945 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
947 * libmodest-dbus-client/libmodest-dbus-client.c:
948 (_dbus_iter_get_string_or_null): Initialize the string variable in
949 case this helps with Dirk's crash.
951 2007-06-19 Murray Cumming <murrayc@murrayc.com>
953 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
954 though it is not implemented yet (this function is maybe not even used),
955 to avoid breaking ABI in future.
956 * libmodest-dbus-client/libmodest-dbus-client.c:
957 (get_attachments_string): Moved some code into this generic function.
958 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
959 sends email. It is maybe not used.
960 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
961 (on_send_mail): Use attachments.
963 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
964 * src/maemo/modest-msg-edit-window.c:
965 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
966 a filename before using it, to fix projects.maemo.org bug NB#58233.
968 2007-06-19 Murray Cumming <murrayc@murrayc.com>
970 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
971 Initialize the continue_download variable to fix the build, and probably
972 to fix randome behaviour.
974 2007-06-18 Armin Burgmeier <armin@openismus.com>
976 * src/modest-tny-send-queue.h:
977 * src/modest-tny-send-queue.c: Keep track of the status of messages in
978 the queue so we can later show it in the UI. Replaced
979 modest_tny_send_queue_msg_is_being_sent() by
980 modest_tny_send_queue_get_msg_status().
982 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
984 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
985 gpointer. This probably was not harmful, but just to be sure.
987 2007-06-18 Murray Cumming <murrayc@murrayc.com>
989 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
990 Fix the build, but leave the function broken on Bora, because
991 hildon_uri_action_get_service() does not exist.
992 osso_uri_action_get_service() does not exist either, it seems.
994 2007-06-18 Murray Cumming <murrayc@murrayc.com>
996 * src/modest-tny-account.c:
997 (modest_tny_account_new_from_server_account):
998 Uncommented the url debug output again, because it is useful for
999 debugging, as I said in the comment.
1001 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1003 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1005 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1006 for Mameo Bora, to fix the build.
1008 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1011 Fixed build with hildon < 0.99
1013 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1014 Check if the selected account is busy instead of checking all accounts
1016 * src/modest-account-mgr-priv.h:
1017 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1018 (modest_account_mgr_init), (compare_account_name),
1019 (modest_account_mgr_set_account_busy),
1020 (modest_account_mgr_account_is_busy):
1021 * src/modest-account-mgr.h:
1022 Added busy information to the account manager. It possible to
1023 set an account to busy or not busy now.
1025 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1026 (modest_mail_operation_update_account),
1027 (modest_mail_operation_notify_end):
1028 Set the account to busy/not busy depending on the operation state.
1030 * src/widgets/modest-account-view.c:
1031 (modest_account_view_finalize), (get_last_updated_string),
1032 (update_account_view), (on_account_busy_changed), (init_view):
1033 Show string "Refreshing..." if the account is currently busy.
1035 All this fixes projects.maemo.org bug NB#59711
1037 2007-06-14 Armin Burgmeier <armin@openismus.com>
1039 * src/widgets/modest-attachments-view.h:
1040 * src/widgets/modest-attachments-view.c: Added
1041 modest_attachments_view_has_attachments() and fixed coordinate
1042 transformation in get_att_view_at_coords(). This fixes attachment
1045 * src/widgets/modest-msg-view.c: Make use of
1046 modest_attachments_view_has_attachments() to decide whether to show
1047 attachments in the header.
1049 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1051 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1052 (on_change), (on_combo_security_changed),
1053 (modest_connection_specific_smtp_edit_window_init),
1054 (modest_connection_specific_smtp_edit_window_set_connection),
1055 (modest_connection_specific_smtp_edit_window_is_dirty):
1056 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1057 * src/maemo/modest-connection-specific-smtp-window.c:
1060 Show an comfirmation dialog for the smpt-edit-window if there are
1061 unsaved changes and the user hits cancel.
1062 (projects.maemo.org bug NB#60479)
1064 2007-06-14 Armin Burgmeier <armin@openismus.com>
1066 * src/maemo/easysetup/modest-easysetup-wizard.c:
1067 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1068 address" info in banner instead of node, and select all the text as
1069 per UI spec. This fixes projects.maemo.org bug NB#60550.
1071 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1073 reviewed by: <delete if not using a buddy>
1075 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1076 * src/modest-ui-actions.c: (folder_refreshed_cb):
1078 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1080 * src/widgets/modest-folder-view.c: (filter_row):
1081 Explictly filter out the per-account outbox accounts. I don't know why
1082 these only sometimes show up, but now they should never show up in the UI.
1083 This should fix projects.maemo.org bug NB#60160.
1085 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1087 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1088 when the toolbar does not exist yet.
1089 * src/modest-widget-memory.c: (save_settings_header_view):
1090 Added g_warnings() to help us to discover when we are trying to set
1091 an empty columns list in gconf.
1093 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1095 * src/modest-init.h:
1096 * src/modest-init.c:
1097 Added modest_init_get_default_header_view_column_ids().
1099 * src/modest-widget-memory.c: (restore_settings_header_view):
1100 Use the new function to get defaults, if the gconf key is empty,
1101 instead of not creating any columns. This seems to fix the
1102 empty right-hand pane problems.
1104 * src/widgets/modest-header-view.h: Improved documentation.
1106 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1108 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1109 Revert the use of the display name as the account name, because this
1110 is generally wrong and would break the code that follows.
1112 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1114 * src/maemo/easysetup/modest-easysetup-wizard.c:
1115 (check_for_supported_auth_methods), (on_before_next),
1118 More correct fix for projects.maemo.org bug NB# 58991
1119 Do not longer accept AUTH_PASSWORD as secure method and choose
1120 correct method when creating the account.
1122 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1124 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1125 Fixed projects.maemo.org bug NB# 58991
1127 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1129 * src/modest-init.c: (modest_init_init_core),
1130 (modest_init_local_folders): Fixed compilation errors.
1132 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1134 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1135 Remove unnecessary lib/include, though it is good in principle when needed.
1137 * src/modest-init.c: (modest_init_one_local_folder),
1138 (modest_init_local_folders):
1139 * src/modest-init.h: Initialize the .modest library for memory cards,
1140 instead of just doing nothing for them. This should allow us to create
1141 folders there, fixing projects.maemo.org bug NB#59297.
1143 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1145 * libmodest-dbus-client/libmodest-dbus-client.c:
1146 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1147 (libmodest_dbus_client_compose_mail),
1148 (libmodest_dbus_client_open_message),
1149 (libmodest_dbus_client_send_and_receive),
1150 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1152 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1153 (on_idle_open_message), (modest_dbus_req_handler),
1154 (search_result_to_message), (modest_dbus_req_filter):
1155 * src/modest-search.c: (add_hit), (modest_search_folder),
1156 (modest_search_all_accounts): Improved debug messages.
1158 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1160 * src/modest-tny-account-store.c:
1161 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1164 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1167 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1169 * src/modest-tny-account-store.c: (get_server_accounts):
1170 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1171 even when there are no accounts, so that the Outbox folder is always
1172 visible. This fixes projects.maemo.org bug NB#60158.
1174 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1176 * src/maemo/modest-main-window.c: (create_details_widget):
1177 Use the mcen_va_never logical ID.
1179 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1181 * src/dbus_api/modest-dbus-api.h:
1182 * src/dbus_api/modest-dbus-callbacks.c:
1183 (on_idle_open_default_inbox), (on_open_default_inbox),
1184 (modest_dbus_req_handler):
1185 Added a new OpenDefaultInbox method.
1187 * libmodest-dbus-client/libmodest-dbus-client.h:
1188 * libmodest-dbus-client/libmodest-dbus-client.c:
1189 Added libmodest_dbus_client_open_default_inbox() to call the new
1190 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1191 though it should maybe be used by a new osso-email-interface function.
1193 * tests/dbus_api/Makefile.am:
1194 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1197 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1199 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1200 NULL, so that the signals get all the keys. This should not actually
1201 change any behaviour because we currently update everything when anything
1204 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1206 * src/widgets/modest-folder-view.c: (text_cell_data),
1207 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1208 (find_inbox_iter): If tinymail tells us that the folder is
1209 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1210 This causes the inbox to be selected at startup, fixing part of
1211 projects.maemo.org bug NB#56305.
1213 * src/modest-ui-dimming-rules.c:
1214 (modest_ui_dimming_rules_on_tools_smtp_servers):
1215 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1216 the SMTP servers menu item.
1217 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1218 that the SMTP Servers menu item is dimmed when there are no accounts,
1219 as a future version of the UI spec will require. This fixes
1220 projects.maemo.org bug NB#56305.
1222 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1224 * src/maemo/modest-maemo-utils.c:
1225 (modest_maemo_utils_get_supported_secure_authentication_methods):
1226 Added label to dialog instead of unreadable title
1228 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1229 (modest_main_window_new):
1230 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1233 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1234 * src/modest-account-mgr.h:
1235 Added method to avoid code duplication
1237 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1238 (modest_ui_actions_on_send_receive):
1239 Use modest_account_mgr_has_accounts
1241 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1243 * src/maemo/easysetup/modest-presets.c:
1244 (modest_presets_get_info_server_security): Do not report secure auth
1246 * src/modest-protocol-info.c: Use the defines for the gconf key names
1247 for secure authentication. This was not working because we were writing
1248 Password and reading password, and the check was case sensitive.
1249 With this, gmail now works for receiving and sending when created via
1252 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1254 * src/maemo/easysetup/modest-presets.c:
1255 (modest_presets_get_info_server_security): Correct the key name for
1256 SecureSmtp, because it seems to be case-sensitive.
1257 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1258 Do not try to get the 0th notebook page if there are 0 pages, to
1259 avoid a g_warning().
1261 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1263 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1264 Prevent use of the new notification feature for now, because it currently
1265 shows one dialog for each new email, which is annoying.
1267 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1269 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1270 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1271 when no country was selected, so that we show the global ones.
1272 * src/maemo/easysetup/modest-presets.c:
1273 (modest_presets_get_providers): Return only the global providers, not
1274 all providers when mmc=0 was requested.
1276 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1278 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1279 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1280 provider ID in the combo.
1282 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1283 Do not show the page numbers, because it would be confusing when we add
1284 the 2 extra pages for the custom setup, when the user chooses the "Other"
1285 provider. This fixes projects.maemo.org bug NB#59028
1287 * src/modest-init.c: (modest_init_init_core),
1288 (modest_init_local_folders):
1289 * src/modest-init.h:
1290 * src/modest-tny-account.c:
1291 (modest_tny_account_new_for_local_folders): Do not create default folders
1292 for the memory card. This should fix projects.maemo.org bug NB#59328.
1294 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1296 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1297 Free the changed_conf_keys string items. They are already freed in the
1298 idle handler if that runs first.
1300 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1302 * src/modest-ui-actions.c:
1303 (modest_ui_actions_on_password_requested): Check that the server name
1304 is not NULL, because I just saw a password dialog with (null) as the
1307 * src/modest-tny-folder.[h|c]: Added
1308 modest_tny_folder_is_memory_card_folder().
1309 * src/modest-ui-dimming-rules.c:
1310 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1311 menu item for memory cards, as per the UI spec (section 7.4). This should
1312 fix projects.maemo.org bug NB#59297.
1314 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1316 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1317 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1318 is another problem with the code, see Murray's comment at line 772)
1320 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1322 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1323 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1324 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1325 (load_from_file), (easysetup_country_combo_box_init),
1326 (easysetup_country_combo_box_get_active_country_ids),
1327 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1328 instead of just one ID, to avoid duplicate country names in the UI.
1330 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1331 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1332 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1333 a single ID, avoiding duplicate providers.
1334 * src/maemo/easysetup/modest-easysetup-wizard.c:
1335 (on_combo_account_country): Adapt to use a list.
1337 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1339 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1340 keys changed in the last X seconds.
1342 * src/modest-account-mgr.h:
1343 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1344 (on_key_change), (modest_account_mgr_class_init),
1345 (modest_account_mgr_init), (modest_account_mgr_finalize):
1346 As the keys are changed, save them in a GSList* and signal that GSList*
1347 further every X seconds, to batch changes, to allow us to do just one
1348 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1349 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1351 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1352 changed signal signature.
1354 * src/modest-conf.c: (modest_conf_set_list),
1355 (modest_conf_on_change): Reenable notification.
1357 (modest_conf_maemo_fake_on_change): Comment out the hack that
1358 notified immediately instead of asynchronously.
1360 * src/widgets/modest-account-view.h:
1361 * src/widgets/modest-account-view.c:
1362 (update_account_view): Select the previously-selected account ID,
1363 if possible. This fixes projects.maemo.org bug NB#56933.
1365 (on_account_changed), (on_account_removed),
1366 (modest_account_view_select_account):
1368 Remove the block/unblock functions
1369 because they were not useful.
1371 * src/maemo/modest-account-view-window.c:
1372 (on_delete_button_clicked), (on_edit_button_clicked),
1373 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1375 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1377 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1378 Improve the error dialog to show Incorrect Account Settings, which seems
1379 clearer, and say that the internal error message (to be removed from the
1380 dialog later) is often misleading.
1381 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1383 * src/modest-tny-account.c:
1384 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1385 URL because this is so useful for debugging on the device.
1387 * src/widgets/modest-serversecurity-combo-box.c:
1388 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1390 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1392 * src/modest-mail-operation.c:
1393 (modest_mail_operation_send_new_mail):
1394 Added a comment about a nasty but apparently harmless message. Details
1395 added to the wiki g_warnings() page.
1397 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1399 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1400 (modest_tny_send_queue_class_init):
1401 Do not use the priv struct because it is empty, to avoid g_warnings
1402 about a non-existant priv struct.
1404 * src/modest-tny-account-store.c:
1405 (modest_tny_account_store_get_server_account),
1406 (modest_tny_account_store_get_transport_account_for_open_connection
1407 ): Do not try to get transport server accounts for local folders,
1408 because they don't have any. This avoids a g_warning().
1410 * src/maemo/modest-main-window.c:
1411 (modest_main_window_notify_send_receive_initied),
1412 (on_configuration_key_changed):
1413 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1414 * src/modest-defs.h:
1415 * src/modest-mail-operation.c:
1416 (modest_mail_operation_update_account):
1417 * src/modest-tny-account-store.h:
1418 * src/modest-tny-account.c:
1419 (modest_tny_account_get_special_folder),
1420 (modest_tny_account_new_for_local_folders),
1421 (modest_tny_account_new_for_per_account_local_outbox_folder):
1422 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1423 * src/modest-tny-local-folders-account.c:
1424 (add_account_folders_to_merged_folder):
1425 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1426 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1427 (modest_ui_actions_on_send):
1428 * src/widgets/modest-folder-view.c: (update_model):
1429 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1430 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1431 modest_tny_account_store_get_tny_account_by_account() to
1432 modest_tny_account_store_get_server_account() to make the code clearer.
1434 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1436 * src/dbus_api/modest-dbus-api.h:
1437 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1438 * src/maemo/modest-msg-edit-window.c:
1439 (modest_msg_edit_window_attach_file_noninteractive):
1440 added g_warning in case the file to be attached does not exist
1441 * tests/dbus_api/test_compose_mail.c: (main):
1442 removed obsolete comment, added generic files as test case
1444 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1446 * src/modest-tny-account-store.c: (get_server_accounts):
1447 Create the local folders account only once, not once for each outbox, and
1448 not only when there are some outboxes.
1450 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1452 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1453 code that is causing a crash at startup. Sergio says that he is fixing this.
1455 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1457 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1458 * src/maemo/modest-account-settings-dialog.c:
1459 (create_page_outgoing),
1460 (modest_account_settings_dialog_set_account_name),
1461 (save_configuration):
1462 - Fixed handling of the "Use secure authentication" toggle to comply with
1463 the ui specification. See also projects.maemo.org bug NB#58400
1465 - Restore the Secure connection setting combo correctly when loading
1468 * src/maemo/modest-maemo-utils.c:
1469 (on_camel_account_get_supported_secure_authentication),
1470 (modest_maemo_utils_get_supported_secure_authentication_methods):
1471 Fixed a crasher if operation is canceled
1473 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1474 (modest_protocol_info_auth_is_secure):
1475 * src/modest-protocol-info.h:
1477 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1478 the sense of the "Use secure authentication" toggle.
1480 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1482 * src/modest-tny-account-store.h:
1483 * src/modest-tny-account-store.c:
1484 Added modest_tny_account_store_get_local_folders_account().
1486 * src/modest-tny-folder.h:
1487 * src/modest-tny-folder.c:
1488 (modest_tny_folder_get_account):
1489 Added this replacement for tny_folder_get_account() which returns
1490 the local-folders account for TnyMergeFolders, to avoid the
1491 warning about the unimplemented get_account_func() vfunc().
1493 (modest_tny_folder_get_rules),
1494 * src/modest-ui-actions.c:
1495 (modest_ui_actions_on_folder_selection_changed):
1496 * src/modest-mail-operation.c:
1497 (modest_mail_operation_remove_folder),
1498 (modest_mail_operation_xfer_folder),
1499 (modest_mail_operation_rename_folder),
1500 (modest_mail_operation_get_msg),
1501 (modest_mail_operation_get_msgs_full),
1502 (modest_mail_operation_remove_msg),
1503 (modest_mail_operation_xfer_msgs),
1504 (modest_mail_operation_refresh_folder):
1505 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1507 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1509 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1510 (modest_server_account_set_security):
1511 * src/modest-defs.h: Add comments explaining that our
1512 UI spec means TLS when it says Normal, so these do not look like errors.
1514 * src/modest-tny-account.c:
1515 (modest_tny_account_new_from_server_account): Use the new tinymail
1516 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1517 for TLS. This should fix projects.maemo.org bug NB#58460.
1519 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1521 * src/maemo/easysetup/modest-easysetup-wizard.c:
1522 (create_account): Correct the position of the gconf sanity check warning.
1523 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1524 of using the g_idle_add() hack, because this does not seem to be necessary
1525 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1526 caused by something other than maemo's gconf.
1527 This fixes projects.maemo.org bug #59022.
1529 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1531 * src/modest-account-mgr-helpers.c:
1532 (modest_account_mgr_get_default_account): Do not check that the account
1533 exists if there is no default account (NULL), to fix a runtime warning.
1535 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1537 * src/widgets/modest-folder-view.c: (update_model):
1538 Do not unref the treemodel before we have finished with it.
1539 This prevents a valgrind warning and an occasional crash at startup.
1541 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1543 * libmodest-dbus-client/libmodest-dbus-client.h:
1544 added libmodest_dbus_client_compose_mail()
1545 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1547 added functions needed for SendAsMail() functionality
1548 * src/maemo/modest-msg-edit-window.c:
1549 (modest_msg_edit_window_attach_file_noninteractive):
1550 non interactively attaching files to message edit window
1551 * src/widgets/modest-msg-edit-window.h:
1552 * tests/dbus_api/Makefile.am:
1553 added test_compose_mail.c
1554 * tests/dbus_api/test_compose_mail.c: (main):
1556 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1558 * src/modest-account-view.c:
1559 Fixed bug projects.maemo.org bug NB#59307
1561 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1563 * src/maemo/easysetup/modest-easysetup-wizard.c:
1564 (get_serverport_incoming), (on_before_next), (create_account):
1565 * src/maemo/modest-account-settings-dialog.c:
1566 (modest_account_settings_dialog_set_account_name):
1567 * src/maemo/modest-maemo-utils.c:
1568 (on_camel_account_get_supported_secure_authentication_status),
1569 (on_camel_account_get_supported_secure_authentication),
1570 (on_secure_auth_cancel),
1571 (modest_maemo_utils_get_supported_secure_authentication_methods):
1573 Implemented security authentication for settings and easysetup.
1575 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1577 * src/maemo/modest-main-window.c: (create_details_widget):
1578 Show the total size for memory card accounts too, instead of showing
1579 the name again. Fixes bug projects.maemo.org bug NB#59307.
1581 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1584 * src/modest-tny-simple-folder-store.c:
1585 * src/modest-tny-simple-folder-store.h: Removed.
1587 * src/modest-tny-local-folders-account.h
1588 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1589 for the local-folders maildir, with an extra TnyMergedFolder containing
1590 the folders of the per-account outbox store accounts.
1591 * src/modest-tny-account-store.c: (get_server_accounts):
1592 Add the outboxes to the special local folders account after creating it.
1594 * src/modest-tny-account.c:
1595 (modest_tny_account_new_for_local_folders): Create the derived
1596 account when creating the main local-folders account.
1598 * src/maemo/modest-main-window.c: (create_details_widget),
1599 (modest_main_window_set_contents_style):
1600 Adapted to the use of the derived account instead of the folder store.
1602 * src/modest-ui-actions.c:
1603 (modest_ui_actions_on_folder_selection_changed):
1604 * src/modest-ui-dimming-rules.c:
1605 (modest_ui_dimming_rules_on_new_folder):
1606 * src/widgets/modest-folder-view.c: (text_cell_data),
1607 (icon_cell_data), (filter_row), (update_model),
1608 (get_cmp_rows_type_pos):
1611 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1612 Do not get the priv struct, because no priv struct has been set,
1613 to avoid a runtime warning.
1615 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1616 #ifelse with #else, to fix a warning, to fix the build.
1619 2007-06-05 Christian Kellner <ckellner@openismus.com>
1621 * libmodest-dbus-client/libmodest-dbus-client.c:
1622 Fix small typo in doc (why do you always see them
1623 AFTER committing stuff?)
1626 2007-06-05 Christian Kellner <ckellner@openismus.com>
1628 * libmodest-dbus-client/libmodest-dbus-client.c:
1629 (libmodest_dbus_client_search):
1630 Initialize hit list with NULL. Also set folder list
1631 to "" if NULL was supplied.
1634 2007-06-03 Christian Kellner <ckellner@openismus.com>
1636 * libmodest-dbus-client/libmodest-dbus-client.c:
1637 (modest_search_hit_list_free):
1638 Make it save to call it with NULL.
1640 * src/dbus_api/modest-dbus-callbacks.c:
1641 * src/modest-search.c:
1642 Return full ModestSearchHits as the search result list not TnyHeader
1643 since can't be around withouth the correspoding TnyFolder.
1645 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1647 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1648 Added currently commented code to check for secure auth
1650 * src/maemo/modest-account-settings-dialog.c: (on_response),
1651 (save_configuration), (show_ok):
1652 Fixed projects.maemo.org bugs NB #59248 and #59251
1654 * src/maemo/modest-maemo-utils.c:
1655 (on_camel_account_get_supported_secure_authentication_status),
1656 (on_camel_account_get_supported_secure_authentication),
1657 (modest_maemo_utils_get_supported_secure_authentication_methods):
1658 * src/maemo/modest-maemo-utils.h:
1659 Moved get_supported_secure_authentication() method here to be able
1660 to use it from easysetup wizard.
1662 * src/modest-pair.c: (on_pair_compare_as_string):
1663 Should compare string with first part of pair and not
1664 strcmp pairs which will crash.
1666 * src/modest-protocol-info.c:
1667 (modest_protocol_info_protocol_is_store):
1668 * src/modest-protocol-info.h:
1669 Added modest_protocol_info_get_auth_protocol_name()
1671 2007-06-03 Armin Burgmeier <armin@openismus.com>
1673 * src/modest-mail-operation.c:
1674 (modest_mail_operation_get_msgs_full): Set priv->account also when
1675 only retrieving a single message. This avoids a crash when canceling
1678 (modest_mail_operation_notify_end): Do not explicitely remove the
1679 operation from the queue but only emit the progress_changed signal.
1680 The queue itself listens to that signal to remove the operation when
1681 it is finished. This reduces coupling and removes a potential deadlock
1682 when modest_mail_operation_notify_end() is called from the queue
1683 itself. If that is a problem performance-wise, I would suggest to
1684 implement a status-changed signal or something.
1686 * src/modest-mail-operation-queue.c: Make sure to never call a
1687 function from another file while the queue is locked. This (hopefully)
1688 fixes another deadlock when exiting the application while retrieving
1691 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1693 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1694 Fixed build if libogs is not available
1696 2007-06-03 Christian Kellner <ckellner@openismus.com>
1698 * libmodest-dbus-client/libmodest-dbus-client.h:
1699 * libmodest-dbus-client/libmodest-dbus-client.c:
1700 (libmodest_dbus_client_delete_message):
1701 Implement deletion of messages (Client side).
1703 (modest_search_hit_free),
1704 (modest_search_hit_list_free):
1705 Utility functions to free the result hits.
1707 * src/dbus_api/modest-dbus-api.h:
1708 * src/dbus_api/modest-dbus-callbacks.c:
1709 (on_delete_message),
1710 (modest_dbus_req_handler):
1711 Implement deletion of messages (Server side).
1713 * tests/dbus_api/test_search.c: (main):
1716 * tests/dbus_api/Makefile.am:
1717 * tests/dbus_api/test_delete_message:
1718 Add little test for the message deletion logic
1720 2007-06-03 Armin Burgmeier <armin@openismus.com>
1722 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1723 when the operation queue was not empty. projects.maemo.org bug
1726 2007-06-03 Armin Burgmeier <armin@openismus.com>
1728 * src/widgets/modest-account-view.c
1729 (on_account_default_toggled): Toggle default account column
1730 explicitely instead of waiting for gconf notification (which is
1731 currently ignored). This should fix projects.maemo.org bug NB#56910
1732 for now. It should probably be removed when gconf notifications are
1735 2007-06-03 Christian Kellner <ckellner@openismus.com>
1737 * libmodest-dbus-client/libmodest-dbus-client.c:
1738 Removed debugging spew.
1740 * src/dbus_api/modest-dbus-callbacks.c:
1741 Added debugging info.
1743 * src/modest-search.c:
1744 (modest_search_all_accounts):
1745 Use tny_account_store_get_accounts () on the account store
1746 to get all accounts which is the way to get all accounts.
1748 * tests/dbus_api/test_search.c: (main):
1749 Make it possible to supply the search term on the command line.
1751 2007-06-03 Christian Kellner <ckellner@openismus.com>
1753 * libmodest-dbus-client/libmodest-dbus-client.c:
1754 * libmodest-dbus-client/libmodest-dbus-client.h:
1755 Implement searching for mesages over raw dbus. (Client side)
1757 * src/dbus_api/Makefile.am:
1758 * src/dbus_api/modest-dbus-api.h:
1759 * src/dbus_api/modest-dbus-callbacks.c:
1760 * src/dbus_api/modest-dbus-callbacks.h:
1761 Search framework (Server side). Also implement on_idle_open_message().
1763 * src/maemo/modest-platform.c: (modest_platform_init):
1764 Prepare for raw dbus/osso rpc interaction.
1766 * src/modest-search.h:
1767 Changed minsize from unspecific guint to guint32.
1769 * src/modest-search.c:
1771 Added strange hack which magically made tnymail work.
1773 (modest_search_folder),
1774 (modest_search_account),
1775 (modest_search_all_accounts):
1776 Implement helper functions to search all accounts, specific account
1779 * tests/dbus_api/Makefile.am:
1780 * tests/dbus_api/test_open_message.c:
1781 Read url to open from commandline.
1783 * tests/dbus_api/test_search.c:
1784 Implement small test for dbus search stuff
1786 2007-06-02 Armin Burgmeier <armin@openismus.com>
1788 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1789 include account type and account title. This fixes projects.maemo.org
1792 * src/maemo/modest-account-view-window.c: Set a title for the window.
1794 2007-06-02 Armin Burgmeier <armin@openismus.com>
1796 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1797 incoming and outgoing server name based on email address and server
1798 types as long as the names have not been edited manually. This fixes
1799 projects.maemo.org bug NB#58671.
1801 2007-06-02 Armin Burgmeier <armin@openismus.com>
1803 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1804 server type cannot be changed in future to the incoming details page
1805 when creating an account. This fixes projects.maemo.org bug NB#59029.
1807 2007-06-02 Armin Burgmeier <armin@openismus.com>
1809 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1810 and assigned max width chars so that they wrap instead of being
1811 truncated. Fixes projects.maemo.org bug NB#56126.
1813 2007-06-02 Armin Burgmeier <armin@openismus.com>
1815 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1816 introductory note to the connection specific smtp servers dialog, as
1817 section 8.12 of the email UI specification requires. This fixes
1818 projects.maemo.org bug NB#59212.
1820 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1822 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1823 Check for running mail operations, and offer to cancel them, as per the UI
1824 spec. This fixes projects.maemo.org bug NB#59041 .
1825 However, I suspect that tinymail may still use the network connection
1826 in ways that we cannot detect or cancel. But it should at least adapt to
1827 changes fairly well.
1829 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1831 * src/modest-tny-account-store.c: (recreate_all_accounts),
1832 (get_cached_accounts), (get_server_accounts): Do more sensible
1833 ref-counting of the temporarily-cached outbox accounts list. This seems
1834 to fix a crash when entering the password when the password was wrong.
1836 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1838 * src/gnome/modest-main-window.c: (connect_signals):
1839 * src/modest-tny-account-store.c: (get_password),
1840 (modest_tny_account_store_alert): Added comments and clues and
1841 commented-out code about how we currently fail to deal with connection
1842 errors and wrong passwords, and how we should.
1844 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1846 * src/widgets/modest-retrieve-combo-box.c:
1847 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1848 This fixes projects.maemo.org bug NB#58472 .
1850 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1852 * src/maemo/easysetup/modest-easysetup-wizard.c:
1853 (create_page_complete_easysetup):
1854 (create_page_complete_custom): Correct the last commit,
1855 putting the correct sentences in the correct pages.
1857 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1859 * src/maemo/easysetup/modest-easysetup-wizard.c:
1860 (create_page_complete_custom): Show the second sentence of text
1861 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1864 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1866 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1867 Set the leave-on-server conf key by default. This fixes
1868 projects.maemo.org bug NB#59258 .
1870 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1872 * src/maemo/modest-account-view-window.c:
1873 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1874 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1877 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1879 * src/maemo/easysetup/modest-easysetup-wizard.c:
1880 (create_caption_new_with_asterisk):
1881 * src/maemo/modest-account-settings-dialog.c:
1882 (create_caption_new_with_asterisk):
1883 Uncomment the code to add the asterisk, because they are no longer in the
1884 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1885 (update_incoming_server_title): Add an asterisk here too.
1887 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1889 * src/maemo/modest-maemo-global-settings-dialog.c:
1890 (current_connection): Check that we are even connected before trying to
1891 get the current connection name, to prevent a warning.
1893 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1894 Change the comments because tny_maemo_conic_device_connect() is now meant to
1896 * src/modest-mail-operation.c:
1897 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1898 make sure we have a connection and fail if we can't connect.
1900 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1902 * src/maemo/modest-main-window.c:
1903 (on_account_store_connecting_finished): Do not try to get the
1904 connection ID if we are not really connected. I am surprised that
1905 this signal handler is called when we are not connected.
1907 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1909 * src/modest-error.h:
1910 * src/modest-ui-actions.c:
1911 (modest_ui_actions_get_msgs_full_error_handler):
1912 Renamed an enum, added comments, added an enum
1913 for retrieve-limit errors.
1915 * src/modest-mail-operation.c: (foreach_add_item),
1916 (internal_folder_observer_update), (update_account_thread),
1917 (modest_mail_operation_get_msgs_full):
1918 (modest_mail_operation_update_account),
1919 Added comments about how this works, and some code that should
1920 (but does not) check the retrieve-limit. See the TODO comment.
1922 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1924 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1925 Initialize help_id to fix the build. Warnings are good.
1927 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1929 * src/widgets/modest-hbox-cell-renderer.c:
1930 (modest_hbox_cell_renderer_append):
1931 * src/widgets/modest-vbox-cell-renderer.c:
1932 (modest_vbox_cell_renderer_append):
1933 Fix the last commit by doing an extra ref.
1935 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1937 * src/widgets/modest-hbox-cell-renderer.c:
1938 (modest_hbox_cell_renderer_append):
1939 * src/widgets/modest-vbox-cell-renderer.c:
1940 (modest_vbox_cell_renderer_append):
1941 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1942 to fix the build with Maemo Bora.
1943 However, there seems to be a remaining crash, probably due to reference
1946 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1948 * src/modest-tny-account.c:
1949 (modest_tny_account_new_for_local_folders):
1950 Use hildon_file_system_info_async_new() to get a better name for
1951 the memory card account, setting it as the account name.
1952 The timing seems to work, but this is probably
1953 not the best place to do this. See the TODO comment.
1954 * src/maemo/modest-main-window.c: (create_details_widget):
1955 * src/widgets/modest-folder-view.c: (text_cell_data):
1956 Use the tny account name instead of hardcoding a name.
1958 2007-05-30 Christian Kellner <ckellner@openismus.com>
1960 * src/modest-search.c: (modest_search):
1961 Correctly set part_search_func even if we have already parsed
1962 the query and thus a valid OgsTextSearcher object.
1964 2007-05-30 Christian Kellner <ckellner@openismus.com>
1967 Search and check for libogs.
1970 Incooparte the ogs build env.
1972 * src/modest-mime-part-search-stream.c:
1973 * src/modest-mime-part-search-stream.h:
1974 Removed since we do the real searching now in modest-search.c.
1976 * src/modest-search.c:
1977 * src/modest-search.h:
1978 Implement support for ogs. We use that if available and requested
1979 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1980 should now handle the corner case when the search term is spread
1981 across multiple reads.
1982 Also the logic in modest_search () was corrected to search all
1983 requested fields until one is found.
1985 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1987 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1989 * src/modest-init.h:
1990 * src/modest-init.c: Made modest_init_local_folders() take a
1991 path and be public so we can iniitialize maildir folders on
1994 * src/modest-local-folder-info.h:
1995 * src/modest-local-folder-info.c:
1996 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1998 * src/modest-tny-account.c:
1999 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2000 still means the standard local-folders path on the local volume.
2002 * src/modest-tny-account-store.c:
2003 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2004 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2005 all accounts when that happens.
2006 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2007 this too, so it shows up in the treeview.
2009 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2011 * src/maemo/modest-maemo-global-settings-dialog.c:
2012 (current_connection):
2013 * src/widgets/modest-global-settings-dialog.c:
2014 (current_connection_default):
2015 Use the enum values instead of 0, 1 and -1,
2016 to make the code clearer.
2018 * src/modest-account-mgr-helpers.c:
2019 (modest_account_mgr_get_connection_specific_smtp): Make this code
2022 * src/modest-runtime.h:
2023 * src/modest-runtime.c:
2024 Added modest_runtime_remove_all_send_queues().
2025 * src/maemo/modest-main-window.c:
2026 (on_account_store_connecting_finished): Recreate the send queues,
2027 using the appropriate transport accounts for this new connection.
2028 Some futher adapting might be needed if the old send queues are not
2029 automatically stopped at this point.
2031 * src/modest-tny-account-store.c: (get_server_accounts):
2032 Create the connection-specific transport accounts, so that they can
2033 be found later by their ID.
2035 * src/modest-tny-account.h:
2036 * src/modest-tny-account.c:
2037 Added modest_tny_account_new_from_server_account_name().
2038 modest_tny_account_new_from_server_account(): Do not create the
2039 send queues here, because they will be
2040 recreated anyway when the connection changes for the first time.
2042 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2044 * src/modest-local-folder-info.h:
2045 * src/modest-local-folder-info.c:
2046 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2047 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2048 tbox_folder): Take a modest account name instead of a server TnyAccount,
2049 so we can have per-modest-account rather than per-transport-account
2051 We must make sure that we change or recreate the exisitng send queues
2052 when the connection changes for connection-specific transport accounts.
2054 * src/modest-tny-account-store.c:
2055 (create_per_account_local_outbox_folders): Create outboxed per modest
2056 account, not per transport account.
2058 * src/modest-tny-account.h:
2059 * src/modest-tny-account.c:
2060 (modest_tny_account_get_special_folder): For outboxes, get the
2061 parent modest account name. The account is ignored for other folders.
2062 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2063 modest account name rather than a server TnyAccount.
2065 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2067 * src/modest-tny-account.c:
2068 (modest_tny_account_new_from_server_account):
2069 Call modest_runtime_get_send_queue() immediately after creating transport
2070 accounts, so that they start trying to send email from the outbox as soon
2071 as possible at startup. This is probably what we want.
2073 * src/modest-mail-operation.c: (update_account_thread):
2074 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2075 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2076 * src/modest-tny-send-queue.h:
2077 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2078 (modest_ui_actions_on_send):
2079 Added comments about how sending works, though it needs some more work.
2081 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2083 * src/modest-tny-account.c:
2084 (modest_tny_account_get_special_folder): Add TODO because this fails when
2085 the network is busy.
2086 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2087 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2088 Do not try to show this window when there is no active account. The UI
2089 specs does not tell us what to do in this case.
2091 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2095 * src/maemo/Makefile.am:
2096 * src/widgets/Makefile.am: Some dist fixes.
2098 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2100 * src/maemo/modest-connection-specific-smtp-window.c:
2101 (on_button_edit): Make the code clearer, to prevent a double free.
2103 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2105 * src/maemo/modest-account-settings-dialog.c:
2106 (modest_account_settings_dialog_set_account_name),
2107 Check the connection-specific smtp servers checkbox if there are any.
2109 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2110 (modest_connection_specific_smtp_edit_window_init):
2111 Start with a suitable port number.
2113 * src/modest-account-mgr-helpers.h:
2114 * src/modest-account-mgr-helpers.c: Added
2115 modest_account_mgr_get_has_connection_specific_smtp().
2117 (modest_account_mgr_set_connection_specific_smtp),
2118 (modest_account_mgr_remove_connection_specific_smtp),
2119 (modest_account_mgr_get_has_connection_specific_smtp),
2120 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2121 connection-specific smtp server accounts in the account, rather than
2122 the server account conf dir.
2124 This fixes bug projects.maemo.org bug NB#58263 .
2126 * src/modest-tny-account-store.c:
2127 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2128 if there are no server accounts yet, to prevent an infinite loop when there
2129 are no accounts. Document that one must be called before the other.
2131 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2133 * src/modest-account-mgr-helpers.c:
2134 (modest_account_mgr_get_default_account): Make sure that at least
2135 one account is always the default, if there are any enabled accounts.
2136 This is just a sanity check that shouldn't be necessary.
2138 * src/modest-account-mgr-priv.c:
2139 (_modest_account_mgr_account_from_key): Unescape the conf key to
2140 get the real account name. For instance, this is an issue if a space
2141 was in the account name, which can happen because the account name
2142 is generated from the display name.
2143 (_modest_account_mgr_get_account_keyname): Always escape the
2145 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2146 Unescape the conf keys to get the real account names.
2148 For instance, previously the is-default radio button in the accounts
2149 list was not checked for any accounts at first. This fixes that,
2150 and might fix several similar bugs.
2152 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2154 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2155 Removed some debug printfs.
2157 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2159 Modest on-disk outbox directories are now here, for instance:
2160 $HOME/.modest/outboxes/<account-id-1>/outbox
2161 $HOME/.modest/outboxes/<account-id-2>/outbox
2163 $HOME/.modest/local-folders/outbox
2164 so we can have a separate outbox for each account.
2165 But they are shown as one outbox in the GtkTreeView, by using a
2166 TnyMergeFolder in a ModestTnySimpleFolderStore.
2169 * src/modest-tny-simple-folder-store.c:
2170 * src/modest-tny-simple-folder-store.h:
2171 Added ModestTnySimpleFolderStore, used to contain folders from
2172 other folder stores, such as other accounts.
2174 * src/modest-tny-outbox-account.h:
2175 * src/modest-tny-outbox-account.c:
2176 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2177 used for the per-account local outbox folders.
2179 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2180 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2181 only use this (internally) now for the non-outbox local folders.
2183 * src/modest-init.h:
2184 * src/modest-init.c: Added modest_init_one_local_folder(), for
2185 setting up the directory structure for each local folder.
2187 * src/modest-local-folder-info.c:
2188 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2189 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2191 * src/modest-local-folder-info.h:
2192 * src/modest-tny-account-store.c: (on_account_removed),
2193 (on_account_changed), (create_per_account_local_outbox_folders),
2194 (get_server_accounts), (modest_tny_account_store_get_accounts),
2195 (modest_tny_account_store_get_tny_account_by_account),
2196 (modest_tny_folder_store_is_virtual_local_folders):
2198 * src/modest-tny-account.h:
2199 * src/modest-tny-account.c:
2200 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2201 to create an on-disk per-account local outbox folder for each
2203 (create_per_account_local_outbox_folders): Create a local outbox folder
2204 for each transport account.
2205 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2206 for all local folders.
2208 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2209 instead of using g_object_get/set() directly. It is clearer.
2211 (modest_tny_folder_store_get_message_count),
2212 (modest_tny_folder_store_get_local_size
2213 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2214 because we now use these with non-acount folder stores.
2216 (modest_tny_account_get_special_folder),
2217 (modest_tny_account_new_from_server_account),
2218 (modest_tny_account_new_from_account):
2219 (recurse_folders): Adjust to the new outbox system.
2221 * src/modest-tny-folder.h:
2222 * src/modest-tny-folder.c:
2223 (modest_tny_folder_is_local_folder),
2224 (modest_tny_folder_get_local_folder_type),
2225 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2227 * src/widgets/modest-main-window.h:
2228 * src/maemo/modest-main-window.c: (create_details_widget),
2229 (modest_main_window_set_contents_style): Show details for any folder store,
2232 (modest_tny_folder_get_rules):
2233 Remove the const. C does not support constness enough for this.
2235 * src/modest-ui-actions.c:
2236 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2237 make all outboxes appear as one, in the usual local-folders tree node.
2239 (set_active_account_from_tny_account),
2240 (modest_ui_actions_on_folder_selection_changed):
2241 * src/widgets/modest-folder-view.c: (text_cell_data),
2242 (icon_cell_data), (filter_row),
2243 (add_account_folders_to_merged_folder),
2244 (add_account_folders_to_simple_folder_store), (),
2245 (get_cmp_rows_type_pos), (cmp_rows),
2246 (modest_folder_view_set_account_id_of_visible_server_account):
2247 Adjust to the new outbox system, using generic folder stores and folders
2248 in the GtkTreeModel.
2250 2007-05-23 Christian Kellner <ckellner@openismus.com>
2252 * src/modest-mail-operation.c:
2253 (modest_mail_operation_update_account):
2254 Use info->max_size instead of unintialized local var [small
2255 build fix]. (Added TODO to review that change since I don't
2258 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2260 * libmodest-dbus-client/libmodest-dbus-client.c:
2261 (libmodest_dbus_client_compose_mail): function added
2262 * src/dbus_api/modest-dbus-api.h:
2263 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2264 (on_compose_mail): Implementation of the SendAsMail functionality
2266 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2268 * src/modest-account-mgr.c:
2269 (modest_account_mgr_add_server_account): Set the secure-connection
2270 conf key for transport accounts as well as store accounts. I don't know
2271 why the if was there. For instance, this makes sure that we use SSL
2272 for the gmail preset from the easysetup wizard.
2274 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2276 * src/gnome/modest-main-window.c:
2277 (on_account_store_connecting_finished), (connect_signals):
2278 * src/maemo/modest-main-window.c:
2279 (on_account_store_connecting_finished), (connect_signals),
2280 (modest_main_window_new):
2281 Handle TnyAccountStore::connecting-finished instead of
2282 TnyDevice::connection-changed, because we cannot actually perform
2283 operations on accounts until TnyAccountStore has itself responded to
2284 the TnyDevice::connection-changed signal. This prevents a GError from
2286 Do not try to update at startup, because we (at least on scratchbox)
2287 already do an update at startup when the device goes online.
2288 This prevents a GError from tinymail.
2289 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2290 Added TODO about stopping simultaneous operations.
2292 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2294 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2295 * src/modest-mail-operation-queue.c:
2296 (modest_mail_operation_queue_remove):
2297 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2298 about where they happened.
2300 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2302 * src/modest-ui-actions.c:
2303 (modest_ui_actions_on_password_requested): Make sure that the remember
2304 output parameter is always TRUE.
2306 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2308 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2309 Show a OK/Cancel dialog if the error is a question, though we still do not
2310 know anything more about what we are asking the user.
2311 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2312 Fix an uninitialized variable (helper). This is a logic error, however.
2314 2007-05-21 Christian Kellner <ckellner@openismus.com>
2316 * src/modest-search.h:
2317 Correct bit shifting in the ModestSearchFlags enum.
2319 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2321 * src/modest-tny-account.c:
2322 (modest_tny_account_new_from_server_account): Do not use the lsub and
2323 check-all hard-coded IMAP options when using POP.
2325 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2327 * src/modest-tny-account.c:
2328 (modest_tny_account_new_from_server_account):
2329 Use NULL for the secure-auth method for POP when Password auth has been
2330 specified by the user, as we already do for IMAP. "auth=Login" causes
2331 an error from camel or the server.
2333 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2335 * src/maemo/modest-account-settings-dialog.c:
2336 (create_page_account_details),
2337 (modest_account_settings_dialog_set_account_name):
2338 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2339 for the leave-on-server checkbox, rathr than just the checkbox, when
2340 the protocol is not POP.
2342 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2344 * src/widgets/modest-account-view.c:
2345 * src/widgets/modest-account-view.h:
2346 Added modest_account_view_select_account() which will be useful later
2347 to asynchronously re-select the edited account.
2349 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2351 * src/maemo/modest-account-settings-dialog.c:
2352 (modest_account_settings_dialog_set_account_name):
2353 Automatically choose the port numbers based on the secure authentication
2354 methods, if they have not been chosen before.
2355 This fixes projects.maemo.org bug NB#56273 .
2357 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2359 * src/maemo/modest-main-window-ui.h:
2360 * src/modest-ui-actions.c:
2361 * src/modest-ui-actions.h:
2362 Connect the Tools/SMTP Servers menu item to
2363 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2364 SMTP servers dialog, as in the UI specification and saves changes when it
2365 is closed. This fixed projects.maemo.org bug NB#56305 .
2367 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2369 * src/maemo/modest-connection-specific-smtp-window.c:
2370 (modest_connection_specific_smtp_window_init):
2371 Use gtk_window_set_default_size() to make this window big enough, so
2372 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2374 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2376 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2377 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2378 (modest_connection_specific_smtp_edit_window_init),
2379 Do not try to connect to a combobox signal before the combobox exists.
2380 This fixes the cras in projects.maemo.org bug NB#56288 .
2381 (modest_connection_specific_smtp_edit_window_get_settings):
2382 Remove the server_account_name parameter which was being checked for NULL
2383 though it was not used.
2385 * src/maemo/modest-connection-specific-smtp-window.c:
2386 (modest_connection_specific_smtp_window_fill_with_connections),
2387 (on_button_edit), (modest_connection_specific_smtp_window_init):
2388 Correct the number of treemodel columns to prevent a warning.
2389 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2390 libconic does not work.
2392 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2394 * src/modest-tny-account.c:
2395 (modest_tny_account_new_from_server_account):
2396 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2397 SMTP when "None" was chosen by the user. However, with my SMTP server that
2398 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2401 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2403 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2404 to explain the memory management issue with the ID in the ModestPair.
2406 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2407 (add_sending_page), (modest_account_assistant_finalize):
2408 * src/gnome/modest-gnome-global-settings-dialog.c:
2409 (create_updating_page), (create_composing_page):
2410 * src/gnome/modest-msg-edit-window.c: (get_transports),
2411 (init_window), (modest_msg_edit_window_finalize),
2412 (modest_msg_edit_window_get_msg_data):
2413 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2414 * src/gnome/modest-transport-widget.c:
2415 (modest_transport_widget_finalize), (smtp_configuration):
2416 * src/maemo/modest-maemo-global-settings-dialog.c:
2417 (create_updating_page), (create_composing_page):
2418 * src/maemo/modest-msg-edit-window.c: (get_transports),
2419 (init_window), (modest_msg_edit_window_finalize),
2420 (modest_msg_edit_window_get_msg_data),
2421 (modest_msg_edit_window_free_msg_data):
2422 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2423 (modest_store_widget_finalize):
2424 * src/maemo/modest-transport-widget.c:
2425 (modest_transport_widget_finalize), (smtp_configuration):
2426 * src/modest-main.c: (send_mail):
2427 * src/widgets/modest-combo-box.h:
2428 * src/widgets/modest-global-settings-dialog-priv.h:
2429 * src/widgets/modest-global-settings-dialog.c:
2430 (modest_global_settings_dialog_finalize):
2431 * src/widgets/modest-msg-edit-window.h:
2432 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2433 as long as the combo box, to prevent use of freed memory for the ID.
2435 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2437 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2438 get_accounts(), to make this clearer. Do not check for the enabled gconf
2439 key, because we do not use this for server accounts (at least, not yet).
2440 This allows us to send email again.
2442 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2444 * src/maemo/modest-platform.c:
2445 (on_modest_conf_update_interval_changed), (modest_platform_init):
2446 Only respond to this particular key change. All these strcmp()s cannot be
2449 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2451 * src/maemo/modest-maemo-global-settings-dialog.c:
2452 (current_connection): Prevent a crash in scratchbox when
2453 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2454 * src/maemo/modest-platform.c:
2455 (on_modest_conf_update_interval_changed), (modest_platform_init):
2456 Get the update interval from gconf and reset it when the gconf key changes.
2458 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2460 * src/modest-protocol-info.c:
2461 * src/modest-protocol-info.h: Adde enum-specific get functions,
2462 instead of using a ModestProtocolType enum parameter.
2464 * src/gnome/modest-account-assistant.c:
2465 * src/gnome/modest-store-widget.c:
2466 * src/gnome/modest-store-widget.h:
2467 * src/gnome/modest-transport-widget.c:
2468 * src/gnome/modest-transport-widget.h:
2469 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2470 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2471 * src/maemo/easysetup/modest-easysetup-wizard.c:
2472 * src/maemo/modest-account-settings-dialog.c:
2473 * src/maemo/modest-account-settings-dialog.h:
2474 * src/maemo/modest-store-widget.c:
2475 * src/maemo/modest-store-widget.h:
2476 * src/maemo/modest-transport-widget.c:
2477 * src/maemo/modest-transport-widget.h:
2478 * src/modest-account-mgr-helpers.c:
2479 * src/modest-account-mgr-helpers.h:
2480 * src/modest-account-mgr.c:
2481 * src/modest-account-mgr.h:
2482 * src/modest-tny-account.c:
2483 * src/modest-tny-folder.c:
2484 * src/widgets/modest-account-view.c:
2485 * src/widgets/modest-retrieve-combo-box.c:
2486 * src/widgets/modest-retrieve-combo-box.h:
2487 * src/widgets/modest-secureauth-combo-box.c:
2488 * src/widgets/modest-serversecurity-combo-box.c:
2489 * src/widgets/modest-serversecurity-combo-box.h:
2490 * tests/check_account-mgr.c:
2491 Use the specific functions, and use the re-renamed enum values for GNOME too.
2493 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2495 * src/modest-pair.h:
2496 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2497 so we can get the second based on the first.
2499 * src/maemo/modest-account-settings-dialog.h:
2500 * src/maemo/modest-account-settings-dialog.c:
2501 Added get_supported_secure_authentication_methods(), though it is mostly
2502 commented-out for now until the necessary API is committed to tinymail.
2503 (modest_account_settings_dialog_set_account_name),
2504 (save_configuration): Request the supported authentication methods from the
2505 server, so we can choose a working method.
2507 * src/modest-tny-account-store.h:
2508 * src/modest-tny-account-store.c:
2509 (modest_tny_account_store_get_session): Rename from
2510 tny_account_store_get_session().
2512 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2514 * src/modest-protocol-info.h: Split the ModestProtocol enum
2515 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2516 There was no need to have these unrelated values in one enum.
2518 * src/: many files: Adapted to changed enum. This makes the code a bit
2519 clearer, and the compiler could catch some errors.
2521 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2523 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2524 Show the detailed internal camel error message when an error happens
2525 during the configuration, so that our testers can give us more clues.
2526 For instance, in projects.maemo.org bug NB#56910 .
2528 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2530 * src/modest-tny-account.c:
2531 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2532 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2534 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2536 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2537 * src/maemo/modest-account-settings-dialog.c:
2538 (modest_account_settings_dialog_set_account_name),
2539 (save_configuration): For the incoming secure authentication checkbox,
2540 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2541 the UI specification. PLAIN does not seem to be supported for most IMAP
2542 servers anyway, and I am not sure what it would mean.
2543 However, we probably need to discover which of the secure-authentication
2544 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2545 * src/modest-account-mgr-helpers.c:
2546 (modest_account_mgr_get_server_account_data):
2548 * src/modest-tny-account.c:
2549 (modest_tny_account_new_from_server_account):
2550 Use tny_account_set_mech() to set secure-authentication methods,
2551 with some special-casing for IMAP, based on my observations of how
2554 * src/modest-account-mgr-helpers.h:
2555 * src/modest-account-mgr.c:
2556 * src/modest-defs.h: Comment that the URI is only used for local folders.
2558 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2560 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2561 parameter const, just to be neat.
2562 * src/modest-text-utils.c: (modest_text_utils_inline):
2563 End g_strconcat() with NULL, as its documentation says. This is almost
2564 certainly the cause of my crash at startup on the device. Interestingly,
2565 valgrind doesn't tell us about these errors.
2567 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2569 * scripts/build-packages: Added more precise comments about how to use
2570 this script, though I still get this error:
2571 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2572 error building tinymail
2574 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2576 * src/maemo/modest-main-window.c: (on_account_update):
2577 Very slight cleanup, hoping to make it simpler to discover what causes
2578 a crash here sometimes.
2580 * src/modest-tny-account.c:
2581 (modest_tny_account_new_from_server_account): Set the port. Added
2582 comments about the options and a TODO comment because I need to find out
2583 how to specify the secure authentication method.
2585 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2587 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2588 changed CFlags paths form modest to libmodest
2590 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2592 * src/modest-account-mgr-helpers.c:
2593 (modest_account_mgr_get_server_account_data),
2594 (modest_account_mgr_free_server_account_data):
2595 * src/modest-account-mgr-helpers.h:
2596 * src/modest-account-mgr.c:
2597 (modest_account_mgr_add_server_account):
2598 * src/modest-defs.h:
2599 * src/modest-tny-account.c:
2600 (modest_tny_account_new_from_server_account):
2601 Determine the options for tny_camel_account_add_option() here,
2602 based on the settings, rather than storing them directly in gconf.
2604 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2606 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2607 Show a more friendly error dialog now that we expect (from the tinymail
2608 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2610 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2612 * src/maemo/modest-main-window.c: (on_account_update): Check that
2613 account_name is not NULL, to prevent a crash at startup that I am
2614 seeing on the N800. I do wonder why it is NULL.
2616 * src/maemo/easysetup/modest-easysetup-wizard.c:
2617 (create_page_user_details):
2618 * src/maemo/modest-account-settings-dialog.c:
2619 (create_page_user_details), (create_page_outgoing):
2620 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2621 (modest_connection_specific_smtp_edit_window_init):
2622 * src/modest-ui-actions.c:
2623 (modest_ui_actions_on_password_requested):
2624 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2625 might do something useful with the on-screen keyboard.
2627 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2629 * src/maemo/modest-main-window.c: (on_account_update):
2630 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2631 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2633 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2635 * src/modest-tny-account-store.c: (on_account_changed):
2636 Correct the signature of this signal handler.
2638 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2640 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2641 Show a HildonNote instead of a GtkDialog for Maemo.
2643 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2645 * src/widgets/modest-account-view.h:
2646 * src/widgets/modest-account-view.c: (on_account_changed),
2647 (on_account_removed). Added a boolean flag, set/unset by
2648 modest_account_view_block_conf_updates(),
2649 modest_account_view_unblock_conf_updates() to prevent unnecessary
2650 updates, but this is not very useful because the gconf notifications are
2651 so delays (maybe only on Maemo Bora).
2652 So auto-updating is turned off, and these functions do an explicit
2653 update when necessary.
2654 However, something else is still doing too much work when adding/removing
2655 accounts, probably in another part of the application.
2657 * src/maemo/modest-account-view-window.c:
2658 (on_delete_button_clicked), (on_edit_button_clicked),
2659 (on_new_button_clicked): Use the new functions.
2661 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2663 * src/modest-account-mgr-helpers.c:
2664 (modest_account_mgr_set_first_account_as_default):
2665 Sort the list of names alphabetically-by-title, so we choose the first one
2667 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2668 alphabetically by the title.
2670 This fixes projects.maemo.org bug NB#56418 .
2672 * src/modest-account-mgr-priv.c:
2673 (_modest_account_mgr_account_from_key):
2674 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2675 avoid a valgrind error, and possible random behaviour.
2677 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2679 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2680 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2681 tinymail documentation to say that this can be expected.
2682 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2683 pretty, and should not happen, but I would prefer to know when it does.
2685 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2687 * configure.ac: When using the older hildon version, probably on Bora,
2688 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2690 * src/widgets/modest-attachment-view.c:
2691 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2694 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2696 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2697 Implemented the prototype. Can be tested with
2698 tests/dbus_api/test_open_message:
2700 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2702 * src/modest-tny-account-store.c:
2703 (modest_tny_account_store_instance_init), (get_password):
2704 * src/modest-ui-actions.c:
2705 (modest_ui_actions_on_password_requested):
2706 Do not store the password in gconf, because this function is called
2707 for non-remembered passwords. Actually use the cached (in the hash map)
2708 password instead of releasing it.
2709 The password will now not be remembered if it is asked via the protected
2710 password dialog, as per the UI spec.
2712 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2714 * src/modest-defs.h:
2715 * src/modest-account-mgr-helpers.h:
2716 * src/modest-account-mgr-helpers.c:
2717 Added modest_server_account_get_username_has_succeeded(),
2718 modest_server_account_set_username_has_succeeded().
2719 (modest_server_account_set_username),
2720 Reset the has-succeeded flag if the username changes.
2722 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2723 * src/maemo/modest-connection-specific-smtp-window.c:
2724 (modest_connection_specific_smtp_window_save_server_accounts):
2725 Use modest_server_account_set_username() instead of using
2726 modest_conf_set_string() directly, so that the has-succeeded flag is always
2729 * src/modest-ui-actions.c:
2730 (modest_ui_actions_on_password_requested): Dim the username entry if
2731 the username has ever worked, as per the UI spec.
2733 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2735 * src/modest-tny-account-store.c: (get_password):
2736 * src/modest-ui-actions.c:
2737 (modest_ui_actions_on_password_requested):
2738 Allow the username to be changed too, though there is more work to
2739 be done on exactly how this behaves.
2741 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2743 * src/modest-account-mgr-helpers.h:
2744 * src/modest-account-mgr-helpers.c:
2745 Added modest_account_mgr_get_display_name(),
2746 modest_server_account_get_username(),
2747 modest_server_account_set_username(),
2748 modest_server_account_set_password(),
2749 modest_server_account_get_hostname() functions so we do not need to
2750 use the conf API directly.
2752 * src/maemo/modest-main-window.c: (connect_signals):
2753 Actually connect ot the ModestAccountStore::request-password signal,
2754 so that we show the dialog when the password is requested by Tinymail,
2755 for isntance if it is empty.
2757 * src/modest-marshal.list:
2758 * src/modest-tny-account-store.c:
2759 (modest_tny_account_store_class_init), (get_password),
2760 (modest_tny_account_store_alert):
2761 * src/modest-tny-account-store.h:
2762 * src/modest-ui-actions.h:
2763 * src/modest-ui-actions.c:
2764 (modest_ui_actions_on_password_requested):
2765 Change the signal parameters, so it is obvious that we are providing
2766 the non human-readable server name, and receiving both the username
2767 and password, though changing of the username is not yet implemented.
2768 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2769 for the GNOME version.
2771 This should fix the projects.maemo.org bug NB#56209, though it does not
2772 work on Bora, because the gconf_client_get() for the password fails
2773 immediately after we save it with gconf_client_set().
2775 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2778 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2779 caused an undefined symbol error:
2780 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2782 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2784 * src/modest-tny-account-store.c:
2785 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2786 using a GError instead of a string message, so we can translate it in
2789 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2791 * src/maemo/modest-address-book.c:
2792 (modest_address_book_check_names):
2793 * src/maemo/modest-msg-view-window.c:
2794 (modest_msg_view_window_clipboard_owner_change):
2795 * src/modest-init.c: (modest_init_init_ui):
2796 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2797 (update_folders_cb), (modest_mail_operation_update_account):
2798 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2799 (modest_ui_actions_on_msg_attachment_clicked),
2800 (modest_ui_actions_on_msg_recpt_activated):
2801 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2802 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2803 (modest_msg_view_search_next):
2804 * src/widgets/modest-recpt-editor.c:
2805 (modest_recpt_editor_on_button_release_event),
2806 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2807 g_message(). At this point we should only be seeing interesting errors on
2808 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2810 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2812 (modest_wizard_dialog_force_title_update):
2813 * src/maemo/easysetup/modest-wizard-dialog.h:
2814 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2815 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2816 can update the title when appropriate. Otherwise the title is wrong if the
2817 pages are added after adding the notebook to the dialog.
2818 This must be a problem in HildonWizardDialog too.
2819 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2821 * src/maemo/easysetup/modest-easysetup-wizard.c:
2822 (create_subsequent_customsetup_pages),
2823 (create_subsequent_easysetup_pages):
2824 Call modest_wizard_dialog_force_title_update() so that the title is
2825 correct even with GTK+ < 2.10.
2826 This fixes projects.maemo.org bug NB#56145 .
2828 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2830 * src/maemo/modest-platform.c:
2831 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2832 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2835 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2837 * src/widgets/modest-window.h:
2838 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2839 and modest_window_save_state(), which invokes it.
2841 * src/widgets/modest-window-mgr.h:
2842 * src/widgets/modest-window-mgr.c:
2843 Added modest_window_mgr_save_state_for_all_windows(), which calls
2844 the save_state vfunc on all registered windows, if implemented.
2846 * src/gnome/modest-msg-edit-window.c:
2847 * src/gnome/modest-msg-view-window.c:
2848 * src/maemo/modest-msg-edit-window.c:
2849 * src/maemo/modest-msg-view-window.c:
2850 * src/maemo/modest-main-window.c:
2851 Specify the existing save_settings functions as implementations of
2852 ModestWindow::save_state_func().
2854 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2855 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2856 enabling hibernation, for instance.
2858 We may need to do the same thing for restoring settings.
2861 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2863 * src/widgets/modest-window-mgr.c:
2864 * src/widgets/modest-window-mgr.h:
2865 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2866 modest_window_mgr_get_hibernation_is_prevented().
2868 * src/maemo/modest-main-window.c:
2869 (on_hildon_program_is_topmost_notify): Prevent hibernation
2870 (possible when the application goes to the background in the WM),
2871 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2873 * src/maemo/easysetup/modest-easysetup-wizard.c:
2874 (modest_easysetup_wizard_dialog_init):
2875 * src/maemo/modest-account-settings-dialog.c:
2876 (modest_account_settings_dialog_init):
2877 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2878 (modest_connection_specific_smtp_edit_window_init):
2879 * src/maemo/modest-connection-specific-smtp-window.c:
2880 (modest_connection_specific_smtp_window_init):
2881 * src/maemo/modest-signature-editor-dialog.c:
2882 (modest_signature_editor_dialog_init):
2883 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2884 prevent hibernation while any of these account settings dialogs are open.
2886 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2888 * src/maemo/Makefile.am:
2889 * src/maemo/modest-osso-state-saving.c:
2890 * src/maemo/modest-osso-state-saving.h: Added
2891 modest_osso_load_state() and modest_osso_save_state() though they do
2892 nothing now. They should iterate through all the open windows and load/save
2894 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2895 save state when closing.
2897 * src/maemo/modest-main-window.c:
2898 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2899 Add a notification handler for the HildonProgram::is-topmost property,
2900 so we can allow hibernation when the application goes into the background.
2901 But we still need to detect when the accounts setup windows are open so
2902 we can stop hibernation when they are open.
2903 To do this, I also added the main window the HildonProgram. This might have
2904 other side-effects/benefits, and should maybe be done for other windows.
2906 * src/maemo/modest-osso-autosave-callbacks.h:
2907 * src/maemo/modest-osso-autosave-callbacks.c:
2908 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2909 though it does not do anything yet, and we might never need this to do
2910 anything. For instance, we already save drafts.
2912 * src/maemo/modest-platform.c: (modest_platform_init):
2913 Specify the libosso auto-save callback.
2915 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2917 * src/maemo/modest-platform.c:
2918 (modest_platform_set_update_interval):
2919 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2920 aparently stays valid between application instances, so we can use this
2921 to remove and reset it later. According to a maemo-developers email from
2924 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2926 * configure.ac: Depend on libalarm for Maemo.
2928 * src/dbus_api/modest-dbus-api.h:
2929 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2930 (on_send_receive), (modest_dbus_req_handler):
2931 Handle a SEND_RECEIVE D-Bus method.
2933 * libmodest-dbus-client/libmodest-dbus-client.c:
2934 (libmodest_dbus_client_send_and_receive):
2935 * libmodest-dbus-client/libmodest-dbus-client.h:
2936 Add C convenience functions for calling the new D-Bus method.
2938 * src/modest-platform.h:
2939 * src/gnome/modest-platform.c:
2940 * src/maemo/modest-platform.c:
2941 Added modest_platform_set_update_interval(), which uses the
2942 alarmd API on Maemo.
2943 (modest_platform_init),
2944 Call modest_platform_set_update_interval(), using a hard-coded
2945 interval for now (until the global settings dialog is implemented),
2946 though I am not sure that this makes sense yet.
2948 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2950 * src/dbus_api/modest-dbus-callbacks.c:
2951 (modest_osso_cb_hw_state_handler):
2952 * src/dbus_api/modest-dbus-callbacks.h:
2953 * src/maemo/modest-platform.c: (modest_platform_init):
2954 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2955 in case this has some effect on the ability for Maemo to ping the
2958 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2960 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2961 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2962 warning. It is probably a logic error, but I need to fix the build.
2964 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2966 * src/modest-account-mgr.h:
2967 * src/modest-account-mgr.c:
2968 (modest_account_mgr_account_names): Add a gboolean enabled_only
2969 parameter, so we can get lists of onlt the enabled accounts.
2971 (modest_account_mgr_add_account),,
2972 (modest_account_mgr_account_with_display_name_exists):
2973 * src/maemo/modest-msg-edit-window.c: (get_transports):
2974 * src/modest-account-mgr-helpers.c:
2975 (modest_account_mgr_set_first_account_as_default):
2976 * src/modest-init.c: (init_default_account_maybe):
2977 * src/modest-tny-account-store.c: (get_accounts):
2978 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2979 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2980 * tests/check_account-mgr.c: (START_TEST):
2981 Provide the extra parameter, as appropriate.
2983 * src/widgets/modest-account-view.c: (update_account_view):
2984 Do not show disabled accounts (meaning that there is no way to
2985 enable/disable accounts in the UI (the feature is not in our UI
2986 specification), so we can use this internally only to mark unfinished
2987 or temporary account data.
2989 * src/maemo/easysetup/modest-easysetup-wizard.c:
2990 (create_account): Add boolean enable parameter, so we can specify FALSE
2991 to create the temporary account.
2992 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2993 (on_before_next): When finishing, when there is a temporary account, just
2995 Also, use a timeout to delay the showing of the dialog until gconf is likely
2996 to return correct information, due to a maemo gconf bug that is fixed in
2997 osso 1.1, but not yet in Bora.
2998 However, the dialog stays on screen after it is destroyed.
3000 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3001 for invalid data when cancelling. Use a hildon note instead of a dialog
3002 to complain about invalid data. Do not show the account-saved note if the
3003 account is disabled (a temporary account that will not really be saved for use
3006 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3008 * src/modest-account-mgr-helpers.h:
3009 * src/modest-account-mgr-helpers.c:
3010 Added modest_account_mgr_unset_default_account(),
3011 Added modest_account_mgr_set_first_account_as_default().
3013 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3014 If it was the default account, unset the default account name.
3016 * src/maemo/modest-account-view-window.c:
3017 (on_delete_button_clicked): If it was the default account,
3018 set the first remaining account as the default instead.
3020 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3021 a NULL account or a NULL default account, to prevent a crash. This should
3022 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3025 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3027 * src/widgets/modest-recpt-editor.c:
3028 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3029 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3030 TODO comment for this. This fixes the build.
3032 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3033 be the best place for it. This will in future update all auto-update accounts,
3034 rather than just the current/default account, when that gconf key exists.
3035 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3036 if there are no accounts, before calling do_send_receive().
3037 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3039 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3040 * src/maemo/modest-main-window-ui.h:
3041 * src/maemo/modest-main-window.c: (on_connection_changed),
3042 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3043 directly, becaue the signal handler does more.
3045 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3047 * src/modest-account-mgr-helpers.c:
3048 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3049 for the case that the account does not exist.
3051 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3052 (equivalent to the modest account name) rather than the tinymail account name
3053 (equivalent to the modest account title - human readable) to get the account data.
3054 Check for null account data to prevent the crash, and add a TODO comment saying that
3055 this needs fixing because it is using the server account name instead of the account name.
3057 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3059 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3060 * src/maemo/modest-account-settings-dialog.c: (show_error),
3062 Use hildon_note_new_information() for informative and error messages,
3063 which seems to be expected for Maemo applications (no documentation that I know of
3064 says this). I am surprised that there is no distinction between info and error
3067 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3069 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3070 it is easy to find where this is used.
3072 * src/maemo/easysetup/modest-easysetup-wizard.c:
3073 (create_page_welcome), (create_page_account_details),
3074 (create_page_user_details), (create_page_complete_easysetup),
3075 (create_page_custom_incoming), (create_page_custom_outgoing),
3076 (create_page_complete_custom):
3077 * src/maemo/modest-account-settings-dialog.c:
3078 (create_page_account_details), (create_page_user_details),
3079 (create_page_incoming), (create_page_outgoing):
3080 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3081 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3082 (modest_connection_specific_smtp_edit_window_init):
3083 * src/maemo/modest-connection-specific-smtp-window.c:
3084 (modest_connection_specific_smtp_window_init):
3085 * src/maemo/modest-signature-editor-dialog.c:
3086 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3087 and scrolling policy as per the Email Application Layout Guide, if I have
3090 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3092 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3093 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3094 which were empty, because these vfuncs have been removed from TnyAccountStore.
3095 This fixes the build.
3097 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3099 * src/maemo/modest-main-window.c:
3100 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3101 showing/hiding it. Added TODO because it probably should not be NULL.
3102 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3103 because unnecessary g_warnings() make degugging difficult.
3105 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3107 * src/maemo/modest-msg-edit-window.c:
3108 (modest_msg_edit_window_select_color),
3109 (modest_msg_edit_window_select_background_color): 2 const corrections and
3110 moving 2 #endifs before closing brackets, to fix the build.
3112 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3114 * src/maemo/easysetup/modest-easysetup-wizard.h:
3115 * src/maemo/easysetup/modest-easysetup-wizard.c:
3116 (modest_easysetup_wizard_dialog_finalize),
3117 (on_button_edit_advanced_settings), (create_page_complete_custom),
3118 (on_response), (create_account):
3119 Implement the Advanced Settings edit button, by saving the account information,
3120 for the Advanded Settings dialog to use directly from gconf, and removing it
3121 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3122 Bug #5533 in the projects.maemo.org bugzilla.
3124 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3126 * src/maemo/modest-msg-view-window.c:
3127 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3128 when opening a message window.
3130 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3132 * src/maemo/easysetup/modest-easysetup-wizard.c:
3133 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3136 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3137 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3138 gconf settings. I probably added more checks than necessary, but that is safer.
3140 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3141 variable to fix the build, but this seems to be used when it is still NULL.
3143 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3145 * src/modest-platform.h:
3146 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3147 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3148 * src/modest-main.c: Implement this function so we can avoid using
3149 maemo-specific API from cross-platform code.
3151 * src/modest-tny-account-store.c:
3152 (get_smtp_specific_transport_account_for_open_connection):
3153 * src/modest-ui-actions.c: (check_for_connection),
3154 (modest_ui_actions_on_item_not_found):
3155 Use modest_platform_connect_and_wait() and put #idefs around other
3156 maemo-specific code, because only maemo currently has a way to
3157 identify connection names.
3159 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3161 * src/modest-tny-account-store.h:
3162 * src/modest-tny-account-store.c:
3163 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3164 the connection-specific SMTP server settings in the configuration.
3166 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3168 * src/maemo/modest-main-window.c: (on_connection_changed),
3170 * src/modest-main.c: (main), (start_ui), (send_mail):
3171 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3172 that is what is intended.
3174 * src/modest-ui-actions.c: (action_send), (action_receive),
3175 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3176 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3177 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3178 SMTP server is used when it is specified.
3180 (modest_ui_actions_on_send_receive):
3181 Check that a connection is open before proceeding.
3182 Receive and then send, instead of vice-versa, as per the specification.
3184 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3186 * src/modest-mail-operation.c:
3187 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3188 though I guess it should be something other than NULL.
3190 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3192 * src/maemo/easysetup/modest-easysetup-wizard.c:
3193 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3194 combo twice, to avoid an g_warning and to make it visible again.
3195 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3196 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3197 (already intended) dereference when detaching, because we then recreate the menu.
3198 But I am not sure why the warning was happening, and it is possible that this is a memory
3201 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3203 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3204 and uri_parse_mailto() utility functions.
3205 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3207 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3209 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3211 * src/dbus_api/modest-dbus-api.h:
3212 * src/dbus_api/modest-dbus-callbacks.c:
3213 Use an idle callback to execute the modest code in the application's own thread.
3214 Remove the helloworld example method.
3215 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3216 parsed, and the open-message method is not implemented because this is not yet implemented in
3218 * libmodest-dbus-client/libmodest-dbus-client.c:
3219 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3220 (libmodest_dbus_client_open_message):
3221 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3223 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3224 body without crashing.
3226 * tests/dbus_api/Makefile.am:
3227 * tests/dbus_api/test_mail_to.c:
3228 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3230 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3232 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3233 Added file to fix the build. Sorry.
3235 * src/dbus_api/Makefile.am:
3236 * src/dbus_api/modest-dbus-api.h:
3237 * src/dbus_api/modest-dbus-callbacks.h:
3238 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3239 (modest_dbus_req_handler):
3240 Put constants in a separate header so it can be reused by the
3241 client library, without duplication
3243 * libmodest-dbus-client/Makefile.am:
3244 * libmodest-dbus-client/libmodest-dbus-client.c:
3245 (libmodest_dbus_client_call_helloworld),
3246 (libmodfest_dbus_client_send_mail),
3247 (libmodfest_dbus_client_mailto),
3248 (libmodfest_dbus_client_open_message):
3249 * libmodest-dbus-client/libmodest-dbus-client.h:
3250 (Partly) Implement a send_mail D-Bus method.
3252 * tests/dbus_api/Makefile.am:
3253 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3254 the send_email D-Bus method.
3256 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3260 * libmodest-dbus-client/Makefile.am:
3261 * libmodest-dbus-client/libmodest-dbus-client.c:
3262 * libmodest-dbus-client/libmodest-dbus-client.h:
3263 * tests/dbus_api/Makefile.am:
3264 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3265 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3267 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3269 * src/maemo/easysetup/modest-easysetup-wizard.c:
3270 (create_page_account_details):
3271 * src/maemo/modest-account-settings-dialog.c:
3272 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3273 widgets, because this might not be the default in future versions of the Maemo GTK+.
3274 However, I can not not get capitalization to work even in a simple test case.
3276 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3278 * src/maemo/easysetup/modest-easysetup-wizard.c:
3279 (create_page_custom_incoming), (create_page_custom_outgoing):
3280 * src/maemo/modest-account-settings-dialog.c:
3281 (create_page_account_details), (create_page_incoming),
3282 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3283 instead of using gtk_check_button_with_label(), so they are aligned like the other
3284 widgets, as per the UI spec.
3286 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3288 * src/maemo/easysetup/modest-easysetup-wizard.c:
3289 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3290 * src/widgets/modest-validating-entry.c:
3291 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3292 Modest prefix instead of an EasySetup prefix.
3294 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3296 * src/widgets/modest-validating-entry.h:
3297 * src/widgets/modest-validating-entry.c: (on_insert_text),
3298 Added easysetup_validating_entry_set_max_func(), used to set a callback
3299 to call when the max number of characters is reached. GtkEntry has a max-length
3300 already but is silent about it.
3302 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3303 (create_page_account_details), (create_page_user_details),
3305 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3306 (create_page_account_details), (create_page_user_details),
3307 (create_page_outgoing):
3308 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3309 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3310 the UI spec, when the user tries to enter more than the max number of characters.
3312 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3314 * src/maemo/easysetup/modest-easysetup-wizard.c:
3315 (create_page_user_details), (create_page_custom_incoming),
3316 (create_page_custom_outgoing):
3317 * src/maemo/modest-account-settings-dialog.c:
3318 (create_page_user_details), (create_page_incoming),
3319 (create_page_outgoing):
3320 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3321 (modest_connection_specific_smtp_edit_window_init):
3322 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3323 not appropriate. Bad Maemo-specific defaults!.
3325 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3327 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3328 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3329 (modest_signature_editor_dialog_set_settings):
3330 Disable the label and textview when the checkbox is disabled, and use the
3331 specified (UI spec) default signature text.
3333 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3335 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3336 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3338 * src/modest-defs.h:
3339 * src/modest-account-mgr-helpers.h:
3340 * src/modest-account-mgr-helpers.c:
3341 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3343 * src/maemo/Makefile.am:
3344 * src/maemo/modest-signature-editor-dialog.c:
3345 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3348 * src/maemo/modest-account-settings-dialog.h:
3349 * src/maemo/modest-account-settings-dialog.c:
3350 (modest_account_settings_dialog_finalize), (on_button_signature),
3351 (save_configuration): Use the new dialog when the Edit button is pressed, and
3352 save the changes if necessary, as per the UI spec.
3354 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3356 * src/maemo/Makefile.am:
3357 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3358 based on maemo-develoers email from Dirk.
3360 * src/maemo/easysetup/modest-easysetup-wizard.c:
3361 (create_page_welcome), (create_page_account_details),
3362 (create_page_user_details), (create_page_complete_easysetup),
3363 (create_page_custom_incoming), (create_page_custom_outgoing),
3364 (create_page_complete_custom),
3365 (modest_easysetup_wizard_dialog_init):
3366 * src/maemo/modest-account-settings-dialog.c:
3367 (create_page_account_details), (create_page_user_details),
3368 (create_page_incoming), (create_page_outgoing),
3369 (modest_account_settings_dialog_init):
3370 * src/maemo/modest-connection-specific-smtp-window.c:
3371 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3373 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3375 * src/maemo/easysetup/modest-easysetup-wizard.c:
3376 (create_page_account_details), (create_page_custom_outgoing),
3377 (create_page_complete_custom):
3378 * src/maemo/modest-account-settings-dialog.c:
3379 (create_page_user_details), (create_page_incoming),
3380 (create_page_outgoing):
3381 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3382 (modest_connection_specific_smtp_edit_window_init):
3383 Use the correct (UI spec) port min/max, and use horizontal separators,
3386 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3388 * src/maemo/easysetup/modest-easysetup-wizard.c:
3389 (set_default_custom_servernames):
3390 * src/maemo/modest-account-settings-dialog.c:
3391 (create_page_incoming), (on_combo_outgoing_security_changed),
3392 (on_combo_incoming_security_changed), (create_page_outgoing),
3393 (modest_account_settings_dialog_set_account_name),
3394 (save_configuration):
3395 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3396 (on_combo_security_changed),
3397 (modest_connection_specific_smtp_edit_window_init),
3398 (modest_connection_specific_smtp_edit_window_set_connection),
3399 (modest_connection_specific_smtp_edit_window_get_settings):
3400 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3403 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3406 * src/maemo/easysetup/modest-easysetup-wizard.c:
3407 (create_page_custom_outgoing), (create_page_complete_custom):
3408 * src/maemo/modest-account-settings-dialog.c:
3409 (create_page_user_details), (create_page_outgoing):
3410 * src/maemo/modest-account-view-window.c: (button_box_new):
3411 Use changed logical IDs as per the most recent UI spec:
3412 mcen_bd_emailsetup_edit -> mcen_bd_edit
3413 mcen_bd_emailsetup_delete -> mcen_bd_delete
3414 mcen_bd_emailsetup_close -> mcen_bd_close
3416 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3420 * src/dbus_api/Makefile.am:
3421 * src/dbus_api/modest-dbus-callbacks.c:
3422 * src/dbus_api/modest-dbus-callbacks.h:
3423 * src/maemo/modest-platform.c: (modest_platform_init):
3424 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3426 * tests/Makefile.am:
3427 * tests/dbus_api/Makefile.am:
3428 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3430 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3432 * src/maemo/modest-account-settings-dialog.c:
3433 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3434 Removed unnecessary includes.
3436 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3438 * src/maemo/easysetup/modest-easysetup-wizard.c:
3439 * src/maemo/modest-account-settings-dialog.c:
3440 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3441 * src/widgets/Makefile.am:
3442 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3443 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3444 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3445 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3446 * src/widgets/modest-secureauth-combo-box.c:
3447 * src/widgets/modest-secureauth-combo-box.h:
3448 * src/widgets/modest-serversecurity-combo-box.c:
3449 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3450 made the GObject names more consistent with the rest of the Modest code.
3452 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3454 * src/maemo/easysetup/Makefile.am:
3455 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3456 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3457 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3458 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3459 * src/maemo/easysetup/modest-easysetup-wizard.c:
3460 * src/maemo/easysetup/modest-validating-entry.c:
3461 * src/maemo/easysetup/modest-validating-entry.h:
3462 * src/maemo/modest-account-settings-dialog.c:
3463 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3464 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3465 widgets/ because they are used outside of easysetup too. After checking in,
3466 svn will allow me to rename them too.
3468 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3470 * src/gnome/modest-msg-edit-window.c:
3471 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3472 linker error, to fix the build on the GNOME platform.
3473 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3474 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3475 ifdefed out to avoid a warning.
3477 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3479 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3480 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3481 some alternative for GTK+ 2.6.
3483 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3485 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3487 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3488 specified for EmailAccountsDialog in UI spec.
3490 * src/maemo/easysetup/modest-easysetup-wizard.c:
3491 * src/maemo/easysetup/modest-easysetup-wizard.h:
3492 * src/maemo/modest-account-settings-dialog.c:
3493 * src/maemo/modest-account-settings-dialog.h:
3494 Reuse a member window widget for the connection-specific SMTP server accounts,
3495 so we can tell it to create/save the accounts only if we actually save changes.
3497 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3498 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3499 (modest_connection_specific_smtp_edit_window_get_settings):
3500 Return a struct instance for temporarily remembering the entered data.
3502 * src/maemo/modest-connection-specific-smtp-window.h:
3503 * src/maemo/modest-connection-specific-smtp-window.c:
3504 (modest_connection_specific_smtp_window_finalize),
3505 (modest_connection_specific_smtp_window_fill_with_connections),
3507 (modest_connection_specific_smtp_window_save_server_accounts),
3508 (update_model_server_names): Do not actually save data until asked,
3509 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3511 (on_selection_changed),
3512 (modest_connection_specific_smtp_window_init): Disable the edit
3513 button when nothing is selected.
3515 * src/modest-account-mgr-helpers.c:
3516 * src/modest-account-mgr-helpers.h:
3517 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3520 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3522 * src/modest-account-mgr-helpers.h:
3523 * src/modest-account-mgr-helpers.c:
3524 (modest_account_mgr_get_unused_account_name),
3525 (modest_account_mgr_get_unused_account_display_name): Added these
3526 utility functions, to avoid code duplication.
3528 * src/maemo/easysetup/modest-easysetup-wizard.c:
3529 (create_page_account_details), (create_account):
3530 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3531 (on_combo_security_changed),
3532 (modest_connection_specific_smtp_edit_window_init),
3533 (modest_connection_specific_smtp_edit_window_save_settings):
3534 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3535 * src/maemo/modest-connection-specific-smtp-window.c:
3536 (modest_connection_specific_smtp_window_finalize),
3537 (modest_connection_specific_smtp_window_fill_with_connections),
3538 (on_button_edit), (modest_connection_specific_smtp_window_init):
3539 * src/maemo/modest-connection-specific-smtp-window.h:
3540 Implementing saving of connection-specific server accounts.
3542 But I need to refactor this so we can save the data for each
3543 possible connection-specific account and only actually create the server accounts
3544 when the easysetup finished, or the OK button is pressed on the account settings
3547 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3549 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3550 (on_combo_security_changed):
3551 (modest_connection_specific_smtp_edit_window_init):
3552 Auto-fill the port number as in the account settings.
3554 (modest_connection_specific_smtp_edit_window_set_connection):
3555 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3556 * src/maemo/modest-connection-specific-smtp-window.c:
3557 (fill_with_connections), (on_button_edit),
3558 (modest_connection_specific_smtp_window_init):
3559 Turn the edit window into a dialog to simplify the code, and
3560 set a WM hint as in a GtkDialog, because only a popup can be on top of
3561 another window in Maemo, and popups usually have no WM decoration.
3563 * src/modest-defs.h:
3564 * src/modest-account-mgr-helpers.c:
3565 (modest_account_mgr_set_connection_specific_smtp),
3566 (modest_account_mgr_remove_connection_specific_smtp),
3567 (modest_account_mgr_get_connection_specific_smtp):
3568 * src/modest-account-mgr-helpers.h: Some functions to write the
3569 connection-specific SMTP server information. Not yet used.
3572 * src/widgets/modest-folder-view.c: (text_cell_data):
3573 Fix a warning about an uninitialized variable.
3574 (on_configuration_key_changed): Put an #ifdef around the use
3575 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3577 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3579 * src/maemo/modest-account-settings-dialog.h:
3580 * src/maemo/modest-account-settings-dialog.c:
3581 Added connect_for_modified() utility function to mark the new modified boolean.
3583 (create_page_account_details), (create_page_user_details),
3584 (create_page_incoming), (create_page_outgoing), (on_response),
3585 (modest_account_settings_dialog_init),
3586 (modest_account_settings_dialog_set_account_name):
3587 Only warn about unsaved changes when there are actually unsaved changes.
3589 * src/modest-account-mgr-helpers.c:
3590 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3591 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3592 to get the data from there in future.
3594 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3596 * src/modest-defs.h:
3598 * src/modest-account-mgr-helpers.h:
3599 * src/modest-account-mgr-helpers.c:
3600 Store the security account setting in a single conf key instead of using
3601 the options list, so that the list is left for just the to-be-removed camel hack,
3602 and because gconf_client_set_list() is failing for some reason.
3604 * src/modest-account-mgr.c:
3605 (modest_account_mgr_add_server_account):
3606 * src/maemo/modest-account-settings-dialog.c:
3607 (modest_account_settings_dialog_set_account_name),
3608 (save_configuration): Use the renamed functions.
3611 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3613 * src/widgets/Makefile.am:
3614 * src/widgets/modest-limit-retrieve-combo-box.c:
3615 * src/widgets/modest-limit-retrieve-combo-box.h:
3616 * src/widgets/modest-retrieve-combo-box.c:
3617 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3618 the account settings dialog.
3620 * src/modest-defs.h:
3621 * src/modest-account-mgr-helpers.h:
3622 * src/modest-account-mgr-helpers.c:
3623 (modest_server_account_get_option_secure_auth),
3624 (modest_server_account_set_option_secure_auth):
3625 * src/modest-account-mgr.c:
3626 (modest_account_mgr_add_server_account):
3627 Use the existing AUTH_MECH conf key for the secure-auth setting,
3628 instead of putting it in the list options, because this was actually used already.
3630 * src/maemo/modest-account-settings-dialog.c:
3631 (create_page_account_details),
3632 (modest_account_settings_dialog_set_account_name),
3633 (save_configuration):
3634 * src/maemo/modest-account-settings-dialog.h:
3635 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3636 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3638 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3640 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3641 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3642 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3644 * src/modest-defs.h:
3645 * src/maemo/modest-account-settings-dialog.c:
3646 (create_page_incoming), (on_combo_outgoing_security_changed),
3647 (on_combo_incoming_security_changed), (create_page_outgoing),
3648 (modest_account_settings_dialog_set_account_name),
3649 (save_configuration): Load/Save the port number, and change it when the
3650 security combo changes, to suitable defaults.
3652 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3654 * src/modest-account-mgr.c:
3655 (modest_account_mgr_add_server_account): Set the security and secure-auth
3656 options, and add a comment saying that the other camel-specific options should be
3659 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3661 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3663 * src/modest-tny-account-store.c: (account_list_free),
3664 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3665 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3668 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3670 * src/modest-protocol-info.c:
3671 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3672 is required by our UI spec. Maybe something in our implementation will use this eventually.
3673 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3674 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3675 instead of the previous 0 placeholder.
3677 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3678 secure-auth settings.
3679 * src/modest-account-mgr-helpers.h:
3680 * src/modest-account-mgr-helpers.c:
3681 (modest_server_account_data_get_option_secure_auth),
3682 (modest_server_account_set_option_secure_auth),
3683 (modest_server_account_data_get_option_security),
3684 (modest_server_account_set_option_security): Added this API for getting and setting the security
3685 and secure-auth settings.
3687 * src/maemo/modest-account-settings-dialog.h:
3688 * src/maemo/modest-account-settings-dialog.c:
3689 (modest_account_settings_dialog_finalize), (check_data),
3690 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3691 about changing titles.
3692 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3693 (save_configuration): Save the security and secure-auth settings.
3695 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3696 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3698 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3700 * src/modest-defs.h:
3701 * src/modest-account-mgr.c:
3702 (modest_account_mgr_add_server_account):
3703 Added and used defines for the options key and value pair strings,
3704 that are used so far, though they do not seem to correspond to anything in our
3705 UI specs or ModestProtocol enum.
3707 * src/modest-account-mgr-helpers.h:
3708 * src/modest-account-mgr-helpers.c:
3709 (compare_option_strings_for_name),
3710 (modest_server_account_data_get_option_value),
3711 (modest_server_account_data_get_option_bool),
3712 (modest_account_mgr_get_server_account_option):
3713 Added helper functions for parsing the options GSList.
3715 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3717 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3718 display name is based on the supplied account name.
3719 * src/modest-account-mgr.c:
3720 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3721 with an inefficient, but good-enough, implementation.
3723 * src/maemo/easysetup/modest-easysetup-wizard.c:
3724 (create_page_account_details), (on_before_next), (create_account):
3725 Check for existing display names rather than (non-user-visible) account names, and just
3726 create and set a unique account name at the end.
3728 * src/maemo/modest-account-settings-dialog.c:
3729 (modest_account_settings_dialog_init),
3730 (modest_account_settings_dialog_set_account_name),
3731 (create_page_incoming): Show the display name, instead of the account name.
3732 (on_response): Do some (not all) extra checks, as in the UI spec.
3733 (save_configuration): Save the display name if it was changed.
3735 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3737 * po/en_GB.po: Added needed logical ID and translation.
3738 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3739 (init_view): Made the is-default column clicking work.
3741 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3744 * src/maemo/easysetup/Makefile.am:
3745 * src/maemo/easysetup/modest-easysetup-wizard.c:
3746 (modest_easysetup_wizard_dialog_init):
3747 * src/maemo/easysetup/provider-data-test.keyfile:
3748 * src/maemo/easysetup/provider-data.keyfile:
3749 Moved the provider data file to the new modest-providers-data package and used it from there.
3751 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3753 * src/modest-local-folder-info.c:
3754 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3755 N_() was already used on the static strings, but this just marks it for translation without
3756 using the translation.
3758 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3760 * src/maemo/modest-account-settings-dialog.c:
3761 (create_page_incoming),
3762 (modest_account_settings_dialog_set_account_name):
3763 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3764 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3765 I will do this if nobody else gets there first.
3767 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3769 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3770 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3771 save the security stuff.
3773 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3775 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3776 Set the email address and user fullname, which I now see must be
3779 * src/maemo/modest-account-settings-dialog.h:
3780 * src/maemo/modest-account-settings-dialog.c:
3782 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3783 leave-on-server and authentication.
3784 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3787 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3790 * src/maemo/modest-account-settings-dialog.c:
3791 * src/maemo/modest-account-settings-dialog.h:
3792 Most (but not all) of the widgets are now present as specified by the UI spec.
3793 No changes are yet saved, and some details are not properly shown yet.
3795 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3797 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3799 * src/maemo/Makefile.am:
3800 * src/maemo/modest-account-settings-dialog.c:
3801 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3802 an existing account. Doesn't do much yet.
3804 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3805 Open the accounts settings dialog when Edit is clicked.
3807 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3809 * src/maemo/easysetup/Makefile.am:
3810 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3812 * src/maemo/easysetup/modest-easysetup-wizard.c:
3813 (modest_easysetup_wizard_dialog_init):
3814 Try to get the source directory from the build system,
3815 instead of hard-coding "./" into the source code, when opening our local
3816 copies of the configuration files.
3817 But this still fails when opening the wizard from the Accounts window,
3818 maybe because the working directory seems to change at runtime.
3819 So the wizard will fail the second time unless you copy the files into their
3820 proper locations - see the stdout warnings for the paths.
3822 (create_page_account_details),(on_before_next):
3823 Check for existing non-server accounts instead of server accounts,
3824 so the default account name is useful again, and to prevent trying to
3827 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3828 Show the wizard when New is clicked.
3830 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3831 (init_view): Show the column headers, and show the columns that are
3832 specified in the UI specs. However, something in Maemo's GTK+ prevents
3833 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3834 change the default account. This is despite unsetting the special properties.
3836 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3838 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3839 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3840 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3841 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3842 to make that clearer.
3843 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3845 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3847 * src/maemo/modest-account-view-window.c:
3848 (modest_account_view_window_init),
3849 (modest_account_view_window_new):
3850 Use the same buttons as specified in the
3851 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3852 the existing widgets, which never had a chance of working.
3853 Put the ModestAccountView treeview in a scrolled window.
3854 Do not repeat the initialization in both _init() and _new().
3856 * src/widgets/modest-account-view.c: (update_account_view):
3857 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3858 this widget and window shows no accounts.
3860 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3862 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3864 * src/maemo/easysetup/modest-easysetup-wizard.c:
3865 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3866 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3867 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3870 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3871 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3872 accounts exist yet, as in the UI spec.
3874 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3876 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3878 * src/maemo/Makefile.am:
3879 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3880 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3881 New window for editing connection-specific smtp details.
3882 Not fully implemented.
3884 * src/maemo/modest-connection-specific-smtp-window.c:
3885 (modest_connection_specific_smtp_window_finalize) :
3886 unref the tree model.
3887 (on_button_edit): Show the edit window.
3889 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3891 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3894 * src/maemo/Makefile.am:
3895 * src/maemo/modest-connection-specific-smtp-window.c:
3896 * src/maemo/modest-connection-specific-smtp-window.h:
3897 New window for showing the list of connections, for connection-specific
3898 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3899 * src/maemo/easysetup/modest-easysetup-wizard.c:
3900 (create_page_custom_outgoing): Show the new window when the button is clicked.
3902 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3904 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3905 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3906 * src/maemo/modest-msg-edit-window.c:
3907 (modest_msg_edit_window_insert_image):
3908 * src/modest-conf.c: (modest_conf_key_escape):
3909 * src/modest-mail-operation.c:
3910 (modest_mail_operation_send_new_mail):
3911 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3912 (modest_ui_actions_on_new_account):
3913 * src/widgets/modest-attachment-view.c: (update_filename_request):
3914 * src/widgets/modest-mail-header-view.c:
3915 Corrected warnings that were breaking the build, by commenting out unused variables,
3916 and a function, and by including a header.
3918 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3920 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3921 so we can #ifdef around platform-specific code when necessary.
3922 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3923 to allow this to build for the GNOME platform too.
3925 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3927 * src/maemo/easysetup/modest-easysetup-wizard.c:
3928 Added util_increment_name() and used it in create_page_account_details()
3929 to make sure that the default account name is always a new name.
3931 (modest_easysetup_wizard_dialog_init),
3932 (set_default_custom_servernames): Some minor memory management fixes.
3934 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3938 * src/modest-runtime.c: (init_i18n): Restored the translation
3939 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3940 are defined in config.h, and the translations are installed.
3942 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3943 is defined for translation.
3945 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3947 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3949 * src/maemo/easysetup/modest-easysetup-wizard.c:
3950 (modest_easysetup_wizard_dialog_init):
3951 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3952 Use realistic paths (though they should use $prefix generically) to the
3953 mcc_mapping and provider-data.keyfile files which might work when they
3954 are installed by the future version of the operator-wizard package,
3955 and then fallback to paths in our source code, with an explanatory
3958 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3962 * src/maemo/Makefile.am:
3963 * src/maemo/easysetup/: Added files from the previously-exernal
3964 osso-modest-easysetup.
3965 * src/maemo/modest-main-window-ui.h:
3966 * src/modest-ui-actions.c:
3967 * src/modest-ui-actions.h:
3968 Added modest_ui_actions_on_new_account() as a signal handler for the
3969 New Account menu item. It shows the easysetup wizard.
3970 * po/en_GB.po: Added additional needed logical IDs and translations.