1 2007-07-25 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-maemo-utils.h:
4 * src/maemo/modest-maemo-utils.c: Added
5 modest_maemo_show_information_note_in_main_context_and_forget().
6 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
7 Use the new function to show simple error dialogs in the main
8 context, though question dialogs are still in the current context,
9 which is unfortunately usually not the main context. This should
12 2007-07-25 Murray Cumming <murrayc@murrayc.com>
14 * src/modest-tny-account-store.c: (get_password):
15 Never save the entered username and password in gconf,
16 because the UI spec says we should not. This helps
17 slightly with projects.maemo.org bug NB#63671.
19 2007-07-25 Murray Cumming <murrayc@murrayc.com>
21 * src/widgets/modest-msg-edit-window.h:
22 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
23 Moved some code here to make it simpler.
24 (modest_msg_edit_window_attach_file_one): Renamed from
25 modest_msg_edit_window_attach_file_interactive().
26 (modest_msg_edit_window_offer_attach_file): Renamed from
27 modest_msg_edit_window_attach_file() and used
28 modest_msg_edit_window_attach_file_one() instead of
29 copy/pasting the code. The old code for one was not using
30 GnomeVFS. This allows use of smb:// URLs when using send-as
31 from external applications, fixing bug NB#63741.
33 (modest_msg_edit_window_insert_image),
34 (modest_msg_edit_window_add_attachment_clicked):
35 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
36 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
37 Adapted to the new function names.
39 2007-07-25 Murray Cumming <murrayc@murrayc.com>
41 (modest_platform_set_update_interval): Set the alarm recurrence
42 fields so that auto-update does not just happen the first time.
43 This should have fixed projects.maemo.org bug NB#63938.
45 When this happens you can see a printf when the D-Bus method is
47 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
49 However, I do not actually seem to get new POP messages even when
50 clicking the refresh button manually. A restart gets them.
51 This might be a problem in today's tinymail only.
53 2007-07-24 Murray Cumming <murrayc@murrayc.com>
55 * src/maemo/modest-maemo-global-settings-dialog.c:
57 Avoid a crash (probably only in scratchbox) when strcmp()ing a
58 NULL when closing the dialog.
60 2007-07-24 Murray Cumming <murrayc@murrayc.com>
62 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
63 Remove the hacky send/receive that didn't work, and instead
64 refilter the treemodel to make the deleted email really vanish from
65 the UI (though the delete-from-menu code does has commented out
66 the code that does that). This fixes projects.maemo.org bug
69 2007-07-24 Murray Cumming <murrayc@murrayc.com>
71 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
72 Try a couple of tricks to force the treeview to update (
73 poke the folder, and do a send/receive refresh), but the deleted
74 email still appears with a strike-through instead of really being
77 2007-07-23 Murray Cumming <murrayc@murrayc.com>
79 * src/dbus_api/modest-dbus-callbacks.c:
80 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
81 because their ID is not human-readable (see the comment about
82 improvements needed to the osso-email-interface API) and
83 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
85 2007-07-23 Murray Cumming <murrayc@murrayc.com>
87 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
88 (add_folders_to_list), (on_dbus_method_get_folders),
89 (modest_dbus_req_filter):
90 * src/maemo/modest-maemo-utils.c:
91 (on_camel_account_get_supported_secure_authentication):
92 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
93 (on_header_view_focus_in):
94 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
95 * src/modest-formatter.c: (modest_formatter_create_body_part):
96 * src/modest-mail-operation.c: (recurse_folders),
97 (update_account_thread), (get_msgs_full_thread),
98 (modest_mail_operation_get_msgs_full),
99 (modest_mail_operation_xfer_msgs):
100 * src/modest-search.c: (search_mime_part_and_child_parts),
101 (modest_search_account), (modest_search_all_accounts):
102 * src/modest-tny-account.c:
103 (modest_tny_account_get_special_folder), (recurse_folders):
104 * src/modest-tny-local-folders-account.c:
105 (modest_tny_local_folders_account_query_passes):
106 * src/modest-tny-msg.c: (copy_mime_part),
107 (modest_tny_msg_find_body_part_from_mime_part):
108 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
109 (modest_tny_send_queue_try_to_send):
110 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
111 (_modest_ui_actions_open), (download_uncached_messages),
112 (reply_forward), (modest_ui_actions_on_copy),
113 (modest_ui_actions_on_details), (has_retrieved_msgs),
114 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
116 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
117 (_selected_msg_marked_as), (_msg_download_completed),
118 (_selected_msg_sent_in_progress):
119 * src/widgets/modest-attachments-view.c:
120 (modest_attachments_view_set_message):
121 * src/widgets/modest-msg-view.c: (find_cid_image):
122 * tests/check_folder-transfer.c: (find_folders):
123 * tests/check_update-account.c: (func):
124 * tests/dbus_api/test_get_folders.c: (main):
125 Checked all uses of tny_iterator_get_current(), making sure
126 that the object is unreferenced (3 or 4 places did not),
127 and adding checks for NULL.
129 2007-07-23 Murray Cumming <murrayc@murrayc.com>
131 * src/dbus_api/modest-dbus-callbacks.c:
132 (on_idle_open_default_inbox): Make sure that the application UI is
134 * src/maemo/easysetup/modest-easysetup-wizard.c:
135 (on_entry_invalid_character): Show the word whitespace instead
136 of (null) in the banner when whitespace was entered.
137 (show_error): Add a comment that this does not work in
138 Maemo Bora, though we do not know why.
140 2007-07-23 Murray Cumming <murrayc@murrayc.com>
142 * src/modest-tny-account.c:
143 (modest_tny_account_get_special_folder): Use an if instead of
144 an assert for when the parent account name is NULL, because this
145 might be causing a crash in projects.maemo.org bug 63192.
146 * src/modest-mail-operation.c:
147 (modest_mail_operation_send_new_mail_cb),
148 (modest_mail_operation_remove_folder): unref the folder that is
149 returned from modest_tny_account_get_special_folder().
151 2007-07-23 Murray Cumming <murrayc@murrayc.com>
153 * src/modest-ui-actions.c:
154 (modest_ui_actions_on_password_requested):
155 Show mail_ib_login_cancelled info banner when the user cancels
156 the protected password dialog, to fix projects.maemo.org
159 2007-07-23 Murray Cumming <murrayc@murrayc.com>
161 * src/maemo/modest-account-settings-dialog.c:
162 (create_page_outgoing): Put this page in a GtkScrolledWindow,
163 matching the UI mock-up in the UI spec, and allowing access
164 to all widgets even when the on-screen keyboard is active.
166 2007-07-23 Murray Cumming <murrayc@murrayc.com>
168 Reverted this previous commit from Johannes,
169 because the scrollbars are always visible and because
170 I think we only need it on onepage of the account
171 settings, not the account wizard.
172 (I wrote the wrong instructions in the bug.)
174 * src/maemo/easysetup/modest-easysetup-wizard.c:
175 Added scrollbars to account wizard dialog.
176 Fixed projects.maemo.org NB #62744
178 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
180 * src/maemo/easysetup/modest-easysetup-wizard.c:
181 (create_page_user_details):
182 Use auto-cap for name (projects.maemo.org NB#63716)
183 * src/widgets/modest-account-view.c: (on_account_busy_changed):
185 2007-07-22 Armin Burgmeier <armin@openismus.com>
187 * src/maemo/modest-ui-actions.c: Use current account instead of
188 default account for creating viewer windows, so that the viewer
189 window knows to which account the viewed message belongs.
191 * src/maemo/modest-msg-view-window.c: Destroy the window when the
192 corresponding account is deleted. This fixes projects.maemo.org bug
195 2007-07-18 Armin Burgmeier <armin@openismus.com>
197 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
198 the dialog close after entering an invalid port number and clicking
199 OK. This fixes projects.maemo.org bug NB#63602.
201 2007-07-18 Armin Burgmeier <armin@openismus.com>
203 * src/modest-tny-account-store.c:
204 (get_server_accounts): Set parent modest account name for each
205 connection-specific transport account so that special folders of such
206 an account can be looked up. This fixes a crash when changing account
207 settings. This might also be related to projects.maemo.org bug
210 2007-07-16 Armin Burgmeier <armin@openismus.com>
212 * src/modest-ui-actions.c: Added a button to create a folder to the
213 move-to dialog. This fixes projects.maemo.org bug NB#.
215 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
217 * src/maemo/easysetup/modest-easysetup-wizard.c:
218 Added scrollbars to account wizard dialog.
219 Fixed projects.maemo.org NB #62744
221 2007-07-16 Murray Cumming <murrayc@murrayc.com>
223 * src/widgets/modest-msg-view.h:
224 * src/widgets/modest-msg-view.c:
225 Added modest_msg_view_get_message_is_empty() but this needs
227 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
228 Check if there is any text in the message yet.
229 But this needs to be implemented properly.
230 (modest_msg_edit_window_toggle_find_toolbar):
231 * src/maemo/modest-msg-view-window.c:
232 (modest_msg_view_window_toggle_find_toolbar):
233 Show a banner warning if there is no text to search, when
234 trying to start a search. This partially fixes
235 projects.maemo.org bug NB#62350.
237 2007-07-13 Murray Cumming <murrayc@murrayc.com>
239 * src/modest-mail-operation.c: (update_account_thread):
240 Initialized num_new_headers to fix the build.
242 2007-07-13 Murray Cumming <murrayc@murrayc.com>
244 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
245 Ignore modest accounts whose server accounts don't exist in gconf.
246 This prevents us trying to create TnyAccount instances for those
247 server accounts when the server account has been removed from gconf,
248 but the parent modest account has not yet been removed from modest.
249 I don't know why this is only noticeable now. It was probably just
250 a harmeless g_warning() anyway.
252 2007-07-13 Murray Cumming <murrayc@murrayc.com>
254 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
255 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
257 2007-07-12 Armin Burgmeier <armin@openismus.com>
259 * src/maemo/modest-main-window.c: Make default account appear bold
260 in view, tools/send & receive and toolbar/send & receive SCM menus.
261 This fixes projects.maemo.org bug NB#59010.
263 2007-07-12 Murray Cumming <murrayc@murrayc.com>
265 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
266 Add a short-cut, by checking if the folder store is an account.
267 This ensures that the Sort menu item and toolbar is dimmed for
268 the local-folders account root item, fixing
269 projects.maemo.org bug NB#62545.
271 2007-07-12 Murray Cumming <murrayc@murrayc.com>
273 * src/modest-tny-account-store.c: (get_password):
274 Show the password dialog (via the signal) only in the mainloop, via
275 an idle handler that we wait for. This could theoretically prevent
276 hangs, though I worry that it could introduce some too.
278 2007-07-12 Murray Cumming <murrayc@murrayc.com>
280 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
281 * src/maemo/modest-platform.c:
282 (modest_platform_connect_and_wait):
283 Take a TnyAccount* parameter and try to set it to online
284 (a TnyCamel-only API), because tinymail sets accounts to offline
285 when the user cancels a password dialog, and doesn't ask again until
286 it has been set to online.
287 However, this is commented out because it causes a hang now.
289 (modest_platform_connect_and_wait_if_network_account):
290 * src/modest-mail-operation.c:
291 (modest_mail_operation_update_account):
292 * src/modest-platform.h:
293 * src/modest-ui-actions.c: (_modest_ui_actions_open),
294 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
296 2007-07-12 Armin Burgmeier <armin@openismus.com>
298 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
300 * src/modest-mail-operation.c:
301 * src/modest-ui-actions.c: Check for already existing folder before
302 querying the server, show error message from camel if the request
303 still fails. This fixes projects.maemo.org bug NB#58701.
305 2007-07-12 Murray Cumming <murrayc@murrayc.com>
307 * src/modest-tny-account-store.h:
308 * src/modest-tny-account-store.c:
309 Added modest_tny_account_store_forget_password_in_memory(),
310 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
311 when creating a new account, so that new passwords will be used, instead of
312 us thinking that it's a second request as a result of a failed password again.
314 2007-07-12 Murray Cumming <murrayc@murrayc.com>
316 * src/dbus_api/modest-dbus-callbacks.c:
317 (on_idle_open_message): If the message is in drafts then open it
318 in an edit window instead of a view window. This fixes
319 projects.maemo.org bug NB#63005.
321 2007-07-12 Murray Cumming <murrayc@murrayc.com>
323 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
324 Avoided a harmless g_warning().
326 2007-07-12 Murray Cumming <murrayc@murrayc.com>
328 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
329 Pass the modest account name, not the TnyAccount display name to
330 modest_msg_view_window_new() so that the reply feature works,
331 fixing projects.maemo.org bug NB#62892.
333 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
334 (modest_msg_view_window_new_with_header_model):
335 * src/maemo/modest-msg-view-window.c:
336 (modest_msg_view_window_new_with_header_model),
337 (modest_msg_view_window_new):
338 * src/modest-ui-actions.c: (reply_forward):
339 * src/widgets/modest-msg-view-window.h:
340 * src/widgets/modest-window.c: (modest_window_set_active_account):
341 Rename an account parameter to modest_account_name to make this clearer.
343 2007-07-11 Murray Cumming <murrayc@murrayc.com>
345 * src/modest-ui-actions.h:
346 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
347 modest_do_message_delete().
348 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
349 Call modest_do_message_delete(), hoping that this would cause messages
350 to be really deleted from search instead of just marked with strike through.
351 Does not seem to help.
353 2007-07-11 Armin Burgmeier <armin@openismus.com>
355 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
356 priv->reselect to FALSE prior to calling
357 modest_folder_view_select_first_inbox_or_local() to prevent endless
358 recursion and thus a crash on startup.
360 2007-07-11 Armin Burgmeier <armin@openismus.com>
362 * src/maemo/modest-account-settings-dialog.h: Include
363 <gtk/gtknotebook.h> to fix the build (at least for me).
365 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
366 Use "New FolderN" as default suggested name if "New folder" already
367 exists, with N being the first free number, though never exceed "New
368 folder99" in which case we just fall back to "New Folder" even though
369 it already exists. This fixes projects.maemo.org bug NB#58663.
371 2007-07-11 Murray Cumming <murrayc@murrayc.com>
373 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
374 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
375 projects.maemo.org bug NB#62778.
377 2007-07-11 Murray Cumming <murrayc@murrayc.com>
379 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
380 Ignore the wrong (for now) secure-smtp setting in the presets -
381 just default to requiring secure authentication for SMTP, because
384 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
386 * src/widgets/modest-folder-view.c: (filter_row)
387 Do not show drafts folder (see UI specs)
389 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
391 * src/modest-ui-actions.c:
392 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
393 place and also not necessary.
395 * src/widgets/modest-folder-view.c: (filter_row)
396 Guess folder type and hide Sent & Outbox if necessary.
397 Fixed project.maemo.org NB#57328
399 2007-07-11 Murray Cumming <murrayc@murrayc.com>
401 * src/modest-ui-actions.h:
402 * src/modest-ui-actions.c:
403 (modest_ui_actions_on_delete_message):
404 Move some code into a new
405 modest_ui_actions_refresh_message_window_after_delete()
406 function so we can use it from elsewhere.
408 * src/dbus_api/modest-dbus-callbacks.c:
409 (on_idle_delete_message), (on_delete_message): Used an idle
410 handler, as we do for the other D-Bus method handlers.
411 Call modest_ui_actions_refresh_message_window_after_delete()
412 if the deleted message was open in a window. This fixed
413 projects.maemo.org bug NB#62862.
415 2007-07-11 Murray Cumming <murrayc@murrayc.com>
417 * src/modest-main.c: (main): Only show the UI at the start if
418 the showui command line option was given. For instance,
419 run-standalone src/modest showui
420 Otherwise, we wait for the top_application D-Bus method to
421 be sent by hildon-desktop when the application is selected
423 This allows us to run without a UI when osso-global-search
424 uses our D-Bus methods.
426 2007-07-11 Murray Cumming <murrayc@murrayc.com>
428 * src/dbus_api/modest-dbus-api.h: Added a define for a
429 top-application D-Bus method.
430 * src/dbus_api/modest-dbus-callbacks.c:
431 (on_top_application),
432 (modest_dbus_req_handler): Handle the top-application D-Bus
433 method, which might be an undocumented D-Bus signal sent by
434 hildon-desktop when it starts the application from the menu.
435 But I am not sure and I need to test it on the device, because
436 my scratchbox does not have the application in the menu now.
437 This method shows the main window, so that it can be invisible
438 when started, for instance, just for email searching from
441 * src/maemo/modest-main-window.c: (restore_settings),
442 (modest_main_window_new): Do not show the window immediately
443 upon creation. We show it later.
444 * src/modest-widget-memory.c: (save_settings_paned):
445 Try (unsuccessfully) to avoid saving the paned position when
446 it is not even visible.
447 (restore_settings_paned): Do not allow a silly paned position.
448 This seems necessary when not showing the window at first.
450 * tests/dbus_api/Makefile.am:
451 * tests/dbus_api/test_top_application.c: (main): Test for the
454 2007-07-10 Murray Cumming <murrayc@murrayc.com>
456 * src/modest-ui-dimming-rules.c:
457 (modest_ui_dimming_rules_on_new_msg),
458 (modest_ui_dimming_rules_on_reply_msg),
459 (modest_ui_dimming_rules_on_delete_msg),
460 (modest_ui_dimming_rules_on_details),
461 (modest_ui_dimming_rules_on_view_window_move_to),
462 (modest_ui_dimming_rules_on_view_previous),
463 (modest_ui_dimming_rules_on_view_next),
464 (_invalid_folder_for_purge): Added checks before
465 casting the window. This looks like an actual
466 logic error in _invalid_folder_for_purge(), because it
467 tries to use a ModestMainWindow as a message window.
469 2007-07-10 Murray Cumming <murrayc@murrayc.com>
471 * src/maemo/modest-account-settings-dialog.c:
472 (show_error): Use the same implementation as in
473 modest-easysetup-wizard.c:
474 (on_entry_invalid_character): The logical ID contains a %s.
475 Guessed what it should be.
476 (on_entry_max), (check_data), (on_response): Adapt to
477 changed show_error().
478 (create_page_account_details): Really call
479 modest_validating_entry_set_func() on the correct widgets.
480 * src/maemo/easysetup/modest-easysetup-wizard.c:
481 (on_entry_invalid_character): Fix the logical ID here too.
482 (create_page_account_details),
483 (create_page_user_details):
485 modest_validating_entry_set_func() on the correct widgets.
487 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
488 Do not try to use the account if it is NULL.
490 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
492 * src/modest-ui-actions.c: (create_move_to_dialog),
493 (modest_ui_actions_on_main_window_move_to),
494 (modest_ui_actions_on_msg_view_window_move_to):
495 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
496 (filter_row), (modest_folder_view_show_non_move_folders):
497 * src/widgets/modest-folder-view.h:
499 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
500 the Sent folder yet as it does not report the correct folder type.
502 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
504 * src/maemo/modest-msg-edit-window.c: (init_window):
507 2007-07-10 Murray Cumming <murrayc@murrayc.com>
509 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
510 Take a parent widget instead of a parent window, and
511 implement this with hildon_banner_show_information() instead.
512 Non-Maemo builds can just ifdef that there.
513 This fixed projects.maemo.org bug NB#62766.
515 (on_entry_invalid_character): Use show_error() again instead
516 of using hildon directly, and use the _CS() macro to use the correct
518 (create_account), (check_for_supported_auth_methods), (on_entry_max):
519 Pass a widget instead od a window to show_error().
521 2007-07-10 Murray Cumming <murrayc@murrayc.com>
523 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
524 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
525 This allows us to show the server name in the error message, fixing
526 projects.maemo.org bug NB#62904.
527 Also, use the appropriate logical ID message for the account protocol.
529 2007-07-10 Murray Cumming <murrayc@murrayc.com>
531 * src/modest-tny-account-store.c: (on_idle_wrong_password):
532 A compilation fix, though the build wasn't broken for me.
534 2007-07-09 Murray Cumming <murrayc@murrayc.com>
536 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
537 Do not try to unref a NULL folder store, to avoid a runtime warning.
538 This seems to happen sometimes when changing accounts settings.
540 2007-07-09 Murray Cumming <murrayc@murrayc.com>
542 * src/modest-tny-account-store.c:
543 (modest_tny_account_store_instance_init),
544 (modest_tny_account_store_finalize),
545 (on_account_settings_hide), (on_idle_wrong_password):
546 Use a GHashTable to ensure that we only show one account settings
547 dialog per modest account. This avoids us having a dialog open for
548 both the store and transport accounts, or due to repeated get_password()
549 calls that shouldn't happen anyway.
551 2007-07-09 Murray Cumming <murrayc@murrayc.com>
553 * src/maemo/modest-maemo-utils.c: (on_hide),
554 (modest_maemo_show_dialog_and_forget): Handle the response, because
555 the window is not even hidden by default.
557 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
558 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
559 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
560 which seems to prevent some modality problems.
562 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
563 Ignore user cancellation errors.
565 * src/modest-account-mgr-helpers.h:
566 * src/modest-account-mgr-helpers.c:
567 Added modest_server_account_get_password() and
568 modest_server_account_get_has_password() to avoid direct use of
571 * src/maemo/modest-account-settings-dialog.h:
572 * src/maemo/modest-account-settings-dialog.c:
573 (modest_account_settings_dialog_init): Store the notebook so we can
575 Added modest_account_settings_dialog_switch_to_user_info().
577 * src/modest-tny-account-store.c:
578 (get_password): When the password in the account settings is wrong (we think),
579 show the relevant page of the account settings dialog, in the mainloop.
580 However, we currently get many of these at once because cancel does not
582 (forget_password): Do not forget the password
583 from the account settings, because this causes side-effects when
584 tinymail seems to call it at strange time, maybe because of how we
585 are cancelling get_password().
586 (modest_tny_account_store_alert): Ignore user cancellations.
588 2007-07-09 Murray Cumming <murrayc@murrayc.com>
590 * src/maemo/modest-maemo-utils.h:
591 * src/maemo/modest-maemo-utils.c:
592 Added modest_maemo_show_information_note_and_forget() for use instead of
593 gtk_dialog_run() when the response is not needed, to avoid an extra
594 mainloop which could cause a hang.
596 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
597 Use the logical IDs for the error message, though they are not
598 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
599 because gtk_dialog_run() caused a hang here (the window did not close).
600 This fixes projects.maemo.org bug NB#62646.
602 2007-07-09 Murray Cumming <murrayc@murrayc.com>
604 * src/modest-account-mgr-helpers.h:
605 * src/modest-account-mgr-helpers.c:
606 Added modest_account_mgr_get_store_protocol().
608 * src/maemo/modest-account-view-window.c:
609 (on_delete_button_clicked): Show different warning text depending on
610 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
611 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
614 2007-07-09 Murray Cumming <murrayc@murrayc.com>
616 * src/maemo/modest-msg-edit-window.c:
617 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
618 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
620 2007-07-07 Armin Burgmeier <armin@openismus.com>
622 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
623 ckdg_ib_maximum_characters_reached from correct package.
625 * src/modest-ui-actions.c: Show an error message when a folder could
626 not be created. Tinymail does not give us specific error codes about
627 what has gone wrong, so we assume that a folder with that name
628 already exists, though there might be other reasons.
630 2007-07-06 Murray Cumming <murrayc@murrayc.com>
632 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
633 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
634 give a more exact error message that can be partly translated.
636 2007-07-05 Murray Cumming <murrayc@murrayc.com>
638 * src/maemo/modest-address-book.c:
639 (select_email_addrs_for_contact): Specify a default window size for the
640 select-email-address dialog, so that it is probably big enough for the
641 title. This should fix projects.maemo.org bug NB#62277.
643 2007-07-05 Murray Cumming <murrayc@murrayc.com>
645 * src/maemo/easysetup/modest-easysetup-wizard.c:
646 (create_page_complete_easysetup): Use
647 gtk_widget_set_size() request to ensure that the text wraps
650 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
652 * src/maemo/easysetup/modest-easysetup-wizard.c:
653 (on_entry_invalid_character), (create_page_account_details),
654 (create_page_user_details):
655 Use new API of ModestValidatingEntry. But for some reason the banner is
656 not shown. I will have to investigate that further.
658 * src/widgets/modest-validating-entry.c: (on_insert_text),
659 (modest_validating_entry_set_func):
660 * src/widgets/modest-validating-entry.h:
661 Added a new callback function to be able to react to prevented
662 characters whitespaces to e.g show a banner.
664 2007-07-05 Armin Burgmeier <armin@openismus.com>
666 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
667 notification of HildonNumberEditor instead of remembering the port
668 number. Thanks to Johannes for pointing this out.
670 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
672 * src/maemo/easysetup/modest-easysetup-wizard.c:
673 Check if there are any user changes before showing a confirmation
674 dialog (projects.maemo.org NB#60946)
676 2007-07-05 Armin Burgmeier <armin@openismus.com>
678 * src/maemo/modest-account-settings-dialog.c: Remember custom port
679 number at the beginning of the dialog and set the modified flag at the
680 end if the port number has changed. This is necessary because
681 HildonNumberEditor does not support notification when the value has
684 2007-07-05 Murray Cumming <murrayc@murrayc.com>
686 * src/modest-ui-actions.c:
687 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
688 a connection before asking anything else. Correct the check for the destination
689 folder so that it succeeds when online.
690 This fixed projects.maemo.org bug NB#61645.
692 2007-07-05 Murray Cumming <murrayc@murrayc.com>
694 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
695 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
696 to fix projects.maemo.org bug NB#62439.
698 2007-07-05 Murray Cumming <murrayc@murrayc.com>
700 * src/modest-tny-account.c: (on_connection_status_changed):
701 Really do not use tny_device_force_offline() here. See the previous comment.
703 2007-07-04 Murray Cumming <murrayc@murrayc.com>
705 * src/modest-tny-account.c: (on_connection_status_changed):
706 Do not use tny_device_force_offline() when tinymail says that something
707 went wrong with the connection. It seems to report this unnecessarily.
709 2007-07-04 Murray Cumming <murrayc@murrayc.com>
711 * src/maemo/modest-connection-specific-smtp-window.c:
712 (modest_connection_specific_smtp_window_init):
713 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
714 does not seem to have any effect in osso 1.1 (though it works in
715 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
717 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
719 * src/maemo/modest-connection-specific-smtp-window.c:
720 Fix UI specification problems with projects.meamo.org NB#60479
722 2007-07-04 Murray Cumming <murrayc@murrayc.com>
724 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
725 clue when this has failed, because the error dialog is not always shown
726 (at least in earlier version).
728 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
729 GError message, because the generic error dialog is not helpful.
731 'This message is not currently available (can't let a new connection go online)'
732 when trying to open an IMAP message.
734 (_modest_ui_actions_open): Offer a connection when some messages would
735 have to be downloaded and we are offline.
737 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
739 * src/widgets/modest-folder-view.c:
740 Don't check for MERGE type anymore as we use the correct type
742 NOTE: For the last two changes you need to update your tinymail copy
743 because of API changes!
745 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
747 * src/modest-tny-local-folders-account.c:
748 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
749 (see projects.maemo.org NB#61580)
751 2007-07-04 Murray Cumming <murrayc@murrayc.com>
753 * src/modest-tny-account.c: (on_connection_status_changed):
754 Commented out the call to modest_platform_connect_and_wait() because this
755 seems to always hang, and I would like to know if this is the only thing
756 that causes a hang when showing the connection dialog.
757 It is not very useful anyway.
759 2007-07-04 Murray Cumming <murrayc@murrayc.com>
761 * src/maemo/modest-msg-view-window.c:
762 (modest_msg_view_window_select_next_message):
764 * src/modest-platform.h:
765 * src/maemo/modest-platform.c:
766 Added modest_platform_connect_and_wait(), which calls
767 tny_maemo_conic_device_connect() always in the main thread, by calling it
768 in an idle handler and waiting for the idle handler to run. It should be
769 in the main thread because it uses GTK+ UI code. It just returns TRUE
770 if the device is already online.
772 There is some nasty code to ensure that subsequent calls to
773 modest_platform_connect_and_wait() just wait for the first one to finish,
774 by checking repeatedly in another idle handler. This is necessary,
775 because other threads (or even the main thread, via another idle handler)
776 can call modest_platform_connect_and_wait() while
777 modest_platform_connect_and_wait() is running.
779 (modest_platform_connect_and_wait_if_network_account),
780 (modest_platform_connect_and_wait_if_network_folderstore):
781 Convenience functions that calls modest_platform_connect_and_wait() if
782 the account or folder might want network access.
784 * src/modest-mail-operation.c:
785 (modest_mail_operation_update_account):
786 * src/modest-ui-actions.c: (download_uncached_messages),
787 (modest_ui_actions_on_rename_folder), (delete_folder),
788 (modest_ui_actions_on_main_window_move_to),
789 (modest_ui_actions_on_msg_view_window_move_to):
790 * src/widgets/modest-folder-view.c:
791 (drag_and_drop_from_folder_view):
792 Offer a connection if we are offline.
794 * src/modest-tny-account.c: (on_connection_status_changed):
795 Document this as only handling errors during network operations in progress,
796 and replace the idle code with a simple call to
797 modest_platform_connect_and_wait(), which does this instead.
799 2007-07-03 Murray Cumming <murrayc@murrayc.com>
801 * src/modest-tny-account.c:
802 (modest_tny_account_get_special_folder): (util_on_idle),
803 Handle the GError so we can see when tny_folder_store_get_folders()
804 fails, as it currently does while something else is connecting.
806 Added util_run_in_main_thread_and_wait()
807 which uses an idlen handler and mainloop to ensure that the function
808 is called in the main thread.
809 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
810 to make sure that we call attempt the connection in the mainloop only,
811 which might solve some hangs.
813 2007-07-03 Murray Cumming <murrayc@murrayc.com>
815 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
816 be found by their display name. This is never useful.
817 * src/modest-tny-account-store.c: (on_account_removed): Find the account
818 by its ID, instead of trying to use its ID as its display name.
820 * src/modest-tny-account-store.h:
821 * src/modest-tny-account.c:
822 (modest_tny_account_get_special_folder): Add a g_warning() when
823 tny_folder_store_get_folders() returns an empty list for the maildir.
825 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
826 Add a g_warning() when this returns NULL, because that it not allowed
829 2007-07-02 Armin Burgmeier <armin@openismus.com>
831 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
832 note when trying to cancel the wizard. This fixes projects.maemo.org
835 2007-07-02 Murray Cumming <murrayc@murrayc.com>
837 * src/modest-tny-account.h:
838 * src/modest-tny-account.c:
839 (modest_tny_account_new_from_server_account),
840 (modest_tny_account_new_from_server_account_name),
841 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
842 because this must now be set before setting the proto. This is usd in
843 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
844 warning in camel_session_get_service() caused by
845 tny_camel_transport_account_prepare().
847 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
850 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
852 * src/maemo/modest-connection-specific-smtp-edit-window.c:
854 (modest_connection_specific_smtp_edit_window_init):
856 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
859 2007-06-29 Murray Cumming <murrayc@murrayc.com>
861 * src/modest-tny-account.c:
862 (modest_tny_account_new_from_server_account):
863 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
864 now uses to request a connection when it needs one, and which it uses
865 to tell us that something is wrong with the connection, so we can force
866 the accounts offline to prevent further problems.
869 * src/modest-init.c: (init_default_settings):
870 * src/modest-mail-operation.c:
871 (modest_mail_operation_update_account):
872 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
873 This should not be necessary anymore. Do not set the conf key that
874 determined this (it was always TRUE and not set anywhere else).
876 * src/modest-ui-actions.h: Remove unused and unimplemented
877 modest_ui_actions_on_online_toggle_toggled().
879 2007-06-29 Murray Cumming <murrayc@murrayc.com
881 * src/maemo/modest-main-window.c: (connect_signals):
882 Don't connect to delete_event twice. Maybe this was harmless.
884 2007-06-29 Murray Cumming <murrayc@murrayc.com
886 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
887 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
888 Debug output to give some more clue when a folder move is not allowed.
890 2007-06-28 Murray Cumming <murrayc@murrayc.com
892 * src/modest-tny-account.c: (on_modest_file_system_info),
893 (modest_tny_account_get_mmc_account_name):
894 Always call the callback, without checking whether the name has changed.
895 * src/widgets/modest-folder-view.c: (strings_are_equal),
896 (on_model_foreach_set_name), (on_get_mmc_account_name),
897 (text_cell_data): Compare the name here, and use the name from
898 the account rather than from the
899 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
900 if the name was changed after the account was added to the model.
901 That's a tinymail bug but not one that I want to fix now.
903 This finally fixes projects.maemo.org bug NB#59301.
905 2007-06-27 Armin Burgmeier <armin@openismus.com>
907 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
910 2007-06-27 Murray Cumming <murrayc@murrayc.com
912 * src/modest-tny-account.h:
913 * src/modest-tny-account.c:
914 Added modest_tny_account_get_mmc_account_name(), to set the memory
915 card name asynchronously for the given account and then notify.
916 (modest_tny_account_new_for_local_folders): Use this new function instead
917 of using hildon_file_system_info_async_new() directly.
919 * src/widgets/modest-folder-view.c: (text_cell_data):
920 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
921 gtk_tree_model_row_changed() when it is available.
923 This should fix projects.maemo.org bug NB#59301.
925 2007-06-27 Murray Cumming <murrayc@murrayc.com
927 * src/modest-mail-operation.c: (update_account_thread),
928 (get_msgs_full_thread): Fix typo failures in the revert
931 2007-06-27 Murray Cumming <murrayc@murrayc.com
933 * src/maemo/modest-maemo-global-settings-dialog.c:
934 (idle_select_default_focus):
935 * src/modest-mail-operation.c: (idle_notify_progress),
936 (idle_notify_progress_once), (set_last_updated_idle),
937 (update_account_thread), (get_msgs_full_thread):
938 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
939 * src/widgets/modest-header-view.c:
940 (idle_notify_headers_count_changed_destroy),
941 (idle_notify_headers_count_changed):
942 Reverted the additions of gdk_threads_enter/leave(), in case this
943 helps with a startup hang on the device.
945 2007-06-26 Armin Burgmeier <armin@openismus.com>
947 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
948 for supported secure authentication methods from server by
949 gtk_dialog_run(), saving CPU time and a potential race condition.
951 2007-06-26 Armin Burgmeier <armin@openismus.com>
953 * src/maemo/modest-maemo-utils.h:
954 * src/maemo/modest-maemo-utils.c: Added a
955 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
956 only error code to tell the calling code when the user canceled the
959 * src/maemo/modest-account-settings-dialog.h:
960 * src/maemo/modest-account-settings-dialog.c:
961 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
962 message if the retrieval of secure authentication methods was canceled
963 by the user. Perform the check before saving anything to configuration
964 to not end up with half-committed configuration changes, do not show
965 a "Saving to configuration failed" note when authentication methods
966 could not be retrieved.
968 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
971 2007-06-26 Murray Cumming <murrayc@murrayc.com>
973 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
974 Only return the first level of folders under accounts, because the
975 osso-global-search UI spec doesn't want the rest.
976 This fixed projects.maemo.org bug NB#61811.
978 2007-06-26 Murray Cumming <murrayc@murrayc.com>
980 * src/modest-tny-account-store.c:
981 * src/modest-tny-account-store.h:
982 Added modest_tny_account_is_memory_card_account().
983 * src/maemo/modest-main-window.c: (create_details_widget):
984 Show the same information items for the memory card as we show for the
985 local-folders, to fix projects.maemo.org bug NB#59307.
987 2007-06-26 Murray Cumming <murrayc@murrayc.com>
989 * src/modest-tny-account-store.c: (get_password):
990 Added some checks for NULL to maybe prevent crashes, though I think
991 it was Philip's last commit that actually prevented the crash here
992 when creating a first new account.
993 But the new account is still not usable (no messages are shown)
994 until a restart of the application.
996 2007-06-26 Murray Cumming <murrayc@murrayc.com>
998 * src/maemo/modest-maemo-global-settings-dialog.c:
999 (idle_select_default_focus):
1000 * src/modest-mail-operation.c: (idle_notify_progress),
1001 (idle_notify_progress_once), (idle_notify_update_account_queue),
1002 (set_last_updated_idle), (update_account_thread),
1003 (notify_get_msgs_full), (get_msgs_full_destroyer),
1004 (get_msgs_full_thread):
1005 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1006 * src/widgets/modest-header-view.c:
1007 (idle_notify_headers_count_changed_destroy),
1008 (idle_notify_headers_count_changed):
1009 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1010 all idle handlers, because some other thread could be blocking
1011 the GDK lock, so that it can do GUI stuff.
1013 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1015 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1016 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1017 (on_idle_send_receive), (on_idle_open_default_inbox):
1018 * src/maemo/modest-msg-edit-window.c:
1019 (modest_msg_edit_window_attach_file_noninteractive):
1020 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1021 to prevent a hang. I don't quite understand why these are necessary,
1022 beause we should already be in the main loop. I guess something outside
1023 of the main loop is taking the lock.
1025 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1026 we are really using URIs, and use files that are more likely to exist.
1028 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1030 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1031 necessary because configure.ac now defines different variables.
1033 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1035 * libmodest-dbus-client/libmodest-dbus-client.c:
1036 * libmodest-dbus-client/libmodest-dbus-client.h:
1037 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1038 libmodest_dbus_client_compose_mail() is what things actually use.
1040 * src/dbus_api/modest-dbus-api.h:
1041 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1042 * tests/dbus_api/Makefile.am:
1043 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1046 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1048 * src/modest-init.c: (modest_init_local_folders):
1049 For memory-card (or other non local-folders) maildir accounts,
1050 always create an Archive folder, so that there is somewhere to put
1051 messages. This should be less confusing, because the user does not need
1052 to guess that the need to create a folder.
1054 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1056 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1057 Fixed icon size by using (50, 50) which is the same as defined by
1060 2007-06-25 Armin Burgmeier <armin@openismus.com>
1062 * src/widgets/modest-window-mgr.c:
1063 * src/modest-init.c:
1064 * configure.ac: Correctly recognize hildon-notify presence and fixed
1065 the build without it being installed.
1067 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1069 * libmodest-dbus-client/libmodest-dbus-client.c:
1070 (libmodest_dbus_client_search): Fix the build. Sorry.
1071 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1072 (reply_forward_cb): Initialize variables to fix the build.
1074 * src/modest-tny-account-store.c:
1075 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1076 comparison (a silly typo) so that email search results can be opened
1077 when there are more than one account.
1079 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1081 * libmodest-dbus-client/libmodest-dbus-client.c:
1082 (libmodest_dbus_client_search),
1083 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1084 instead of 1 second, because the search gets folders and messages from
1085 the server, which can take a long time. When it times out,
1086 osso-global-search will report no results.
1088 We need to specify whether we should search only cached information
1089 (maybe with a user preference), and the osso-email-search-plugin
1090 API should really be improved to allow that option, and to allow results
1091 to be delivered asynchronously in batches.
1093 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1095 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1096 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1097 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1099 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1101 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1102 that is an empty string. D-Bus seems to give us these instead of NULL.
1104 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1106 * src/dbus_api/modest-dbus-callbacks.c:
1107 * src/maemo/easysetup/modest-easysetup-wizard.h:
1108 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1109 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1110 (modest_connection_specific_smtp_edit_window_init):
1111 * src/maemo/modest-maemo-global-settings-dialog.c:
1113 * src/maemo/modest-maemo-utils.c:
1114 (modest_maemo_utils_setup_images_filechooser):
1115 * src/maemo/modest-main-window.c: (create_details_widget):
1116 * src/maemo/modest-msg-edit-window.c:
1117 (modest_msg_edit_window_attach_file_noninteractive),
1118 (modest_msg_edit_window_color_button_change),
1119 (modest_msg_edit_window_set_zoom):
1120 * src/modest-mail-operation.c: (update_account_thread):
1121 * src/modest-tny-account-store.c:
1122 * src/modest-tny-account.c:
1123 * src/widgets/modest-global-settings-dialog.c:
1124 * src/widgets/modest-window.h:
1126 Fixed build on bora!
1128 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1130 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1131 * src/modest-search.c: (modest_search_folder),
1132 (modest_search_all_accounts): Actually search only in the specified folder,
1133 doing a simple match on the folder ID.
1134 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1135 and added some documentation.
1137 2007-06-22 Armin Burgmeier <armin@openismus.com>
1139 * src/maemo/modest-maemo-utils.h:
1140 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1141 modest_maemo_utils_get_supported_secure_authentication_methods.
1143 * src/maemo/easysetup/modest-easysetup-wizard.c:
1144 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1145 one occured, not just "Server does not support secure authentication".
1147 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1149 * src/modest-tny-account-store.c: (get_password):
1150 Restored the call to tny_account_set_user() because Philip seems to have
1151 stopped this from crashing (by not using the freed string). It still does
1152 not work, but now we can test it.
1154 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1156 * src/maemo/modest-msg-edit-window.c: (init_window):
1157 Comment out use of an uninitialzed GtkScrolledWindow variable,
1158 to fix the build and stop a crash. Yet again.
1160 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1162 * src/modest-tny-account-store.c: (get_password):
1163 Remove the call to tny_account_set_user() because this actually crashes.
1164 As mentioned in the last commit, it is known to not work anyway.
1166 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1168 * src/modest-tny-account-store.c: (get_password):
1169 Use tny_account_set_username() to tell tinymail that the username might
1170 have changed too. But tinymail ignores this: see projects.maemo.org
1172 * src/modest-ui-actions.c:
1173 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1174 reset the connection when changing the username, and improve the comments.
1175 Save the changed username to gconf at least, so it is used when Modest is
1178 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1180 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1181 Do not use a query, so that we get all folders, including for POP and
1182 local-folders. They work as search criteria too.
1183 This fixes projects.maemo.org bug NB#57740.
1185 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1187 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1188 Comment out the use of hildon_notification_set_sound() because it is
1189 not declared, to fix the build. Warnings are serious, people.
1191 2007-06-21 Armin Burgmeier <armin@openismus.com>
1193 * src/maemo/modest-maemo-utils.h:
1194 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1195 modest_maemo_utils_get_supported_secure_authentication_methods()
1196 to query authentication methods for a specific user. This should fix
1197 projects.maemo.org bug NB#61369.
1199 * src/maemo/easysetup/modest-easysetup-wizard.c:
1200 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1203 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1205 * libmodest-dbus-client/libmodest-dbus-client.h:
1206 * libmodest-dbus-client/libmodest-dbus-client.c:
1207 (modest_dbus_message_iter_get_search_hit),
1208 (libmodest_dbus_client_search):
1209 Reorganised and commented this.
1210 Removed modest_search_hit_free() from the public API because it
1213 Added libmodest_dbus_client_get_folders() and
1214 modest_folder_result_list_free().
1216 * src/dbus_api/modest-dbus-api.h:
1217 * src/dbus_api/modest-dbus-callbacks.c:
1218 (modest_dbus_req_filter): Commented. Moved most code to
1219 on_dbus_method_search() and added on_dbus_method_get_folders().
1221 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1222 of the extra D-Bus handler.
1224 * tests/dbus_api/Makefile.am:
1225 * tests/dbus_api/test_get_folders.c: New test for
1226 libmodest_dbus_client_get_folders(). This seems to return an empty list
1227 at the moment. That could be the same error that causes the message list
1228 to be empty sometimes.
1229 This should help with projects.maemo.org bug NB#57740.
1231 2007-06-21 Armin Burgmeier <armin@openismus.com>
1233 * src/modest-mail-operation.c: Do not call
1234 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1235 notify the operation's end after having set the status to CANCELED for
1236 the operation queue to listen on. This fixes a deadlock when there
1237 were mail operations in the queue during its finalization.
1239 * src/modest-singletons.c: Reordered uninitialization of the account
1240 manager to happen after the mail operation queue was uninitialized
1241 because the mail operation's in the queue might still try to access
1242 the account manager (see modest_mail_operation_notify_end()). This
1243 fixes a potential crash when terminating the application.
1245 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1247 * src/modest-search.c:
1248 (search_mime_part_and_child_parts): Moved some code here so we
1249 can search recursively in child folders.
1250 (modest_search_folder): Search in the message as a mime part, instead
1251 of just its child mime parts.
1252 (read_chunk), (search_mime_part_ogs):
1253 Check how many bytes were read, to prevent an endless loop.
1254 Searching in message bodies now works. This finishes the fix for
1255 projects.maemo.org bug NB#61007.
1257 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1259 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1260 Add a g_warning when the item is not a folder.
1262 * src/modest-ui-dimming-rules.c:
1263 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1264 when selected item is not a folder (for instance, an account), because
1265 the UI spec only talks about folders.
1266 I am not sure what the UI spec wants, so this might not totally fix
1267 projects.maemo.org bug NB#60794.
1269 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1271 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1272 (load_from_file): Sort the list. The unsorted list would be more noticeable
1273 in non-English locales.
1275 * src/maemo/modest-msg-edit-window.c:
1276 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1277 warning and fix the build.
1279 * src/maemo/modest-progress-bar-widget.c:
1280 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1281 avoid a g_warning, and probably to avoid a crash.
1283 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1285 * src/modest-search.c: (modest_search_folder): Check for a GError
1286 when calling tny_folder_get_headers(), to show that this is not the cause
1289 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1291 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1292 Actually set the body query instead of the subject query.
1294 * src/modest-search.c: (search_mime_part_ogs),
1295 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1296 which would probably cause it to fail if we got this far.
1298 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1299 to simplify the code.
1300 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1301 be causing search-in-body to fail.
1303 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1305 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1307 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1308 Better debug message when the folder cannot be found.
1309 This should help with fixing projects.maemo.org bug #61287.
1310 * src/modest-search.c: (add_hit): Do not leak the furl string.
1312 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1314 * src/modest-ui-actions.c:
1315 (modest_ui_actions_on_folder_selection_changed):
1316 Do not special-case TNY_MERGE_FOLDER here, because
1317 modest_tny_folder_get_account() already does that. This fixes
1318 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1319 shown when the Outbox was selected).
1321 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1323 * libmodest-dbus-client/libmodest-dbus-client.c:
1324 (_dbus_iter_get_string_or_null): Initialize the string variable in
1325 case this helps with Dirk's crash.
1327 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1329 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1330 though it is not implemented yet (this function is maybe not even used),
1331 to avoid breaking ABI in future.
1332 * libmodest-dbus-client/libmodest-dbus-client.c:
1333 (get_attachments_string): Moved some code into this generic function.
1334 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1335 sends email. It is maybe not used.
1336 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1337 (on_send_mail): Use attachments.
1339 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1340 * src/maemo/modest-msg-edit-window.c:
1341 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1342 a filename before using it, to fix projects.maemo.org bug NB#58233.
1344 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1346 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1347 Initialize the continue_download variable to fix the build, and probably
1348 to fix randome behaviour.
1350 2007-06-18 Armin Burgmeier <armin@openismus.com>
1352 * src/modest-tny-send-queue.h:
1353 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1354 the queue so we can later show it in the UI. Replaced
1355 modest_tny_send_queue_msg_is_being_sent() by
1356 modest_tny_send_queue_get_msg_status().
1358 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1360 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1361 gpointer. This probably was not harmful, but just to be sure.
1363 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1365 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1366 Fix the build, but leave the function broken on Bora, because
1367 hildon_uri_action_get_service() does not exist.
1368 osso_uri_action_get_service() does not exist either, it seems.
1370 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1372 * src/modest-tny-account.c:
1373 (modest_tny_account_new_from_server_account):
1374 Uncommented the url debug output again, because it is useful for
1375 debugging, as I said in the comment.
1377 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1379 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1381 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1382 for Mameo Bora, to fix the build.
1384 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1387 Fixed build with hildon < 0.99
1389 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1390 Check if the selected account is busy instead of checking all accounts
1392 * src/modest-account-mgr-priv.h:
1393 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1394 (modest_account_mgr_init), (compare_account_name),
1395 (modest_account_mgr_set_account_busy),
1396 (modest_account_mgr_account_is_busy):
1397 * src/modest-account-mgr.h:
1398 Added busy information to the account manager. It possible to
1399 set an account to busy or not busy now.
1401 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1402 (modest_mail_operation_update_account),
1403 (modest_mail_operation_notify_end):
1404 Set the account to busy/not busy depending on the operation state.
1406 * src/widgets/modest-account-view.c:
1407 (modest_account_view_finalize), (get_last_updated_string),
1408 (update_account_view), (on_account_busy_changed), (init_view):
1409 Show string "Refreshing..." if the account is currently busy.
1411 All this fixes projects.maemo.org bug NB#59711
1413 2007-06-14 Armin Burgmeier <armin@openismus.com>
1415 * src/widgets/modest-attachments-view.h:
1416 * src/widgets/modest-attachments-view.c: Added
1417 modest_attachments_view_has_attachments() and fixed coordinate
1418 transformation in get_att_view_at_coords(). This fixes attachment
1421 * src/widgets/modest-msg-view.c: Make use of
1422 modest_attachments_view_has_attachments() to decide whether to show
1423 attachments in the header.
1425 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1427 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1428 (on_change), (on_combo_security_changed),
1429 (modest_connection_specific_smtp_edit_window_init),
1430 (modest_connection_specific_smtp_edit_window_set_connection),
1431 (modest_connection_specific_smtp_edit_window_is_dirty):
1432 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1433 * src/maemo/modest-connection-specific-smtp-window.c:
1436 Show an comfirmation dialog for the smpt-edit-window if there are
1437 unsaved changes and the user hits cancel.
1438 (projects.maemo.org bug NB#60479)
1440 2007-06-14 Armin Burgmeier <armin@openismus.com>
1442 * src/maemo/easysetup/modest-easysetup-wizard.c:
1443 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1444 address" info in banner instead of node, and select all the text as
1445 per UI spec. This fixes projects.maemo.org bug NB#60550.
1447 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1449 reviewed by: <delete if not using a buddy>
1451 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1452 * src/modest-ui-actions.c: (folder_refreshed_cb):
1454 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1456 * src/widgets/modest-folder-view.c: (filter_row):
1457 Explictly filter out the per-account outbox accounts. I don't know why
1458 these only sometimes show up, but now they should never show up in the UI.
1459 This should fix projects.maemo.org bug NB#60160.
1461 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1463 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1464 when the toolbar does not exist yet.
1465 * src/modest-widget-memory.c: (save_settings_header_view):
1466 Added g_warnings() to help us to discover when we are trying to set
1467 an empty columns list in gconf.
1469 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1471 * src/modest-init.h:
1472 * src/modest-init.c:
1473 Added modest_init_get_default_header_view_column_ids().
1475 * src/modest-widget-memory.c: (restore_settings_header_view):
1476 Use the new function to get defaults, if the gconf key is empty,
1477 instead of not creating any columns. This seems to fix the
1478 empty right-hand pane problems.
1480 * src/widgets/modest-header-view.h: Improved documentation.
1482 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1484 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1485 Revert the use of the display name as the account name, because this
1486 is generally wrong and would break the code that follows.
1488 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1490 * src/maemo/easysetup/modest-easysetup-wizard.c:
1491 (check_for_supported_auth_methods), (on_before_next),
1494 More correct fix for projects.maemo.org bug NB# 58991
1495 Do not longer accept AUTH_PASSWORD as secure method and choose
1496 correct method when creating the account.
1498 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1500 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1501 Fixed projects.maemo.org bug NB# 58991
1503 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1505 * src/modest-init.c: (modest_init_init_core),
1506 (modest_init_local_folders): Fixed compilation errors.
1508 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1510 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1511 Remove unnecessary lib/include, though it is good in principle when needed.
1513 * src/modest-init.c: (modest_init_one_local_folder),
1514 (modest_init_local_folders):
1515 * src/modest-init.h: Initialize the .modest library for memory cards,
1516 instead of just doing nothing for them. This should allow us to create
1517 folders there, fixing projects.maemo.org bug NB#59297.
1519 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1521 * libmodest-dbus-client/libmodest-dbus-client.c:
1522 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1523 (libmodest_dbus_client_compose_mail),
1524 (libmodest_dbus_client_open_message),
1525 (libmodest_dbus_client_send_and_receive),
1526 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1528 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1529 (on_idle_open_message), (modest_dbus_req_handler),
1530 (search_result_to_message), (modest_dbus_req_filter):
1531 * src/modest-search.c: (add_hit), (modest_search_folder),
1532 (modest_search_all_accounts): Improved debug messages.
1534 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1536 * src/modest-tny-account-store.c:
1537 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1540 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1543 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1545 * src/modest-tny-account-store.c: (get_server_accounts):
1546 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1547 even when there are no accounts, so that the Outbox folder is always
1548 visible. This fixes projects.maemo.org bug NB#60158.
1550 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1552 * src/maemo/modest-main-window.c: (create_details_widget):
1553 Use the mcen_va_never logical ID.
1555 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1557 * src/dbus_api/modest-dbus-api.h:
1558 * src/dbus_api/modest-dbus-callbacks.c:
1559 (on_idle_open_default_inbox), (on_open_default_inbox),
1560 (modest_dbus_req_handler):
1561 Added a new OpenDefaultInbox method.
1563 * libmodest-dbus-client/libmodest-dbus-client.h:
1564 * libmodest-dbus-client/libmodest-dbus-client.c:
1565 Added libmodest_dbus_client_open_default_inbox() to call the new
1566 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1567 though it should maybe be used by a new osso-email-interface function.
1569 * tests/dbus_api/Makefile.am:
1570 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1573 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1575 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1576 NULL, so that the signals get all the keys. This should not actually
1577 change any behaviour because we currently update everything when anything
1580 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1582 * src/widgets/modest-folder-view.c: (text_cell_data),
1583 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1584 (find_inbox_iter): If tinymail tells us that the folder is
1585 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1586 This causes the inbox to be selected at startup, fixing part of
1587 projects.maemo.org bug NB#56305.
1589 * src/modest-ui-dimming-rules.c:
1590 (modest_ui_dimming_rules_on_tools_smtp_servers):
1591 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1592 the SMTP servers menu item.
1593 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1594 that the SMTP Servers menu item is dimmed when there are no accounts,
1595 as a future version of the UI spec will require. This fixes
1596 projects.maemo.org bug NB#56305.
1598 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1600 * src/maemo/modest-maemo-utils.c:
1601 (modest_maemo_utils_get_supported_secure_authentication_methods):
1602 Added label to dialog instead of unreadable title
1604 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1605 (modest_main_window_new):
1606 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1609 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1610 * src/modest-account-mgr.h:
1611 Added method to avoid code duplication
1613 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1614 (modest_ui_actions_on_send_receive):
1615 Use modest_account_mgr_has_accounts
1617 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1619 * src/maemo/easysetup/modest-presets.c:
1620 (modest_presets_get_info_server_security): Do not report secure auth
1622 * src/modest-protocol-info.c: Use the defines for the gconf key names
1623 for secure authentication. This was not working because we were writing
1624 Password and reading password, and the check was case sensitive.
1625 With this, gmail now works for receiving and sending when created via
1628 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1630 * src/maemo/easysetup/modest-presets.c:
1631 (modest_presets_get_info_server_security): Correct the key name for
1632 SecureSmtp, because it seems to be case-sensitive.
1633 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1634 Do not try to get the 0th notebook page if there are 0 pages, to
1635 avoid a g_warning().
1637 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1639 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1640 Prevent use of the new notification feature for now, because it currently
1641 shows one dialog for each new email, which is annoying.
1643 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1645 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1646 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1647 when no country was selected, so that we show the global ones.
1648 * src/maemo/easysetup/modest-presets.c:
1649 (modest_presets_get_providers): Return only the global providers, not
1650 all providers when mmc=0 was requested.
1652 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1654 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1655 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1656 provider ID in the combo.
1658 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1659 Do not show the page numbers, because it would be confusing when we add
1660 the 2 extra pages for the custom setup, when the user chooses the "Other"
1661 provider. This fixes projects.maemo.org bug NB#59028
1663 * src/modest-init.c: (modest_init_init_core),
1664 (modest_init_local_folders):
1665 * src/modest-init.h:
1666 * src/modest-tny-account.c:
1667 (modest_tny_account_new_for_local_folders): Do not create default folders
1668 for the memory card. This should fix projects.maemo.org bug NB#59328.
1670 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1672 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1673 Free the changed_conf_keys string items. They are already freed in the
1674 idle handler if that runs first.
1676 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1678 * src/modest-ui-actions.c:
1679 (modest_ui_actions_on_password_requested): Check that the server name
1680 is not NULL, because I just saw a password dialog with (null) as the
1683 * src/modest-tny-folder.[h|c]: Added
1684 modest_tny_folder_is_memory_card_folder().
1685 * src/modest-ui-dimming-rules.c:
1686 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1687 menu item for memory cards, as per the UI spec (section 7.4). This should
1688 fix projects.maemo.org bug NB#59297.
1690 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1692 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1693 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1694 is another problem with the code, see Murray's comment at line 772)
1696 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1698 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1699 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1700 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1701 (load_from_file), (easysetup_country_combo_box_init),
1702 (easysetup_country_combo_box_get_active_country_ids),
1703 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1704 instead of just one ID, to avoid duplicate country names in the UI.
1706 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1707 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1708 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1709 a single ID, avoiding duplicate providers.
1710 * src/maemo/easysetup/modest-easysetup-wizard.c:
1711 (on_combo_account_country): Adapt to use a list.
1713 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1715 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1716 keys changed in the last X seconds.
1718 * src/modest-account-mgr.h:
1719 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1720 (on_key_change), (modest_account_mgr_class_init),
1721 (modest_account_mgr_init), (modest_account_mgr_finalize):
1722 As the keys are changed, save them in a GSList* and signal that GSList*
1723 further every X seconds, to batch changes, to allow us to do just one
1724 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1725 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1727 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1728 changed signal signature.
1730 * src/modest-conf.c: (modest_conf_set_list),
1731 (modest_conf_on_change): Reenable notification.
1733 (modest_conf_maemo_fake_on_change): Comment out the hack that
1734 notified immediately instead of asynchronously.
1736 * src/widgets/modest-account-view.h:
1737 * src/widgets/modest-account-view.c:
1738 (update_account_view): Select the previously-selected account ID,
1739 if possible. This fixes projects.maemo.org bug NB#56933.
1741 (on_account_changed), (on_account_removed),
1742 (modest_account_view_select_account):
1744 Remove the block/unblock functions
1745 because they were not useful.
1747 * src/maemo/modest-account-view-window.c:
1748 (on_delete_button_clicked), (on_edit_button_clicked),
1749 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1751 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1753 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1754 Improve the error dialog to show Incorrect Account Settings, which seems
1755 clearer, and say that the internal error message (to be removed from the
1756 dialog later) is often misleading.
1757 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1759 * src/modest-tny-account.c:
1760 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1761 URL because this is so useful for debugging on the device.
1763 * src/widgets/modest-serversecurity-combo-box.c:
1764 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1766 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1768 * src/modest-mail-operation.c:
1769 (modest_mail_operation_send_new_mail):
1770 Added a comment about a nasty but apparently harmless message. Details
1771 added to the wiki g_warnings() page.
1773 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1775 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1776 (modest_tny_send_queue_class_init):
1777 Do not use the priv struct because it is empty, to avoid g_warnings
1778 about a non-existant priv struct.
1780 * src/modest-tny-account-store.c:
1781 (modest_tny_account_store_get_server_account),
1782 (modest_tny_account_store_get_transport_account_for_open_connection
1783 ): Do not try to get transport server accounts for local folders,
1784 because they don't have any. This avoids a g_warning().
1786 * src/maemo/modest-main-window.c:
1787 (modest_main_window_notify_send_receive_initied),
1788 (on_configuration_key_changed):
1789 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1790 * src/modest-defs.h:
1791 * src/modest-mail-operation.c:
1792 (modest_mail_operation_update_account):
1793 * src/modest-tny-account-store.h:
1794 * src/modest-tny-account.c:
1795 (modest_tny_account_get_special_folder),
1796 (modest_tny_account_new_for_local_folders),
1797 (modest_tny_account_new_for_per_account_local_outbox_folder):
1798 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1799 * src/modest-tny-local-folders-account.c:
1800 (add_account_folders_to_merged_folder):
1801 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1802 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1803 (modest_ui_actions_on_send):
1804 * src/widgets/modest-folder-view.c: (update_model):
1805 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1806 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1807 modest_tny_account_store_get_tny_account_by_account() to
1808 modest_tny_account_store_get_server_account() to make the code clearer.
1810 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1812 * src/dbus_api/modest-dbus-api.h:
1813 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1814 * src/maemo/modest-msg-edit-window.c:
1815 (modest_msg_edit_window_attach_file_noninteractive):
1816 added g_warning in case the file to be attached does not exist
1817 * tests/dbus_api/test_compose_mail.c: (main):
1818 removed obsolete comment, added generic files as test case
1820 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1822 * src/modest-tny-account-store.c: (get_server_accounts):
1823 Create the local folders account only once, not once for each outbox, and
1824 not only when there are some outboxes.
1826 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1828 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1829 code that is causing a crash at startup. Sergio says that he is fixing this.
1831 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1833 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1834 * src/maemo/modest-account-settings-dialog.c:
1835 (create_page_outgoing),
1836 (modest_account_settings_dialog_set_account_name),
1837 (save_configuration):
1838 - Fixed handling of the "Use secure authentication" toggle to comply with
1839 the ui specification. See also projects.maemo.org bug NB#58400
1841 - Restore the Secure connection setting combo correctly when loading
1844 * src/maemo/modest-maemo-utils.c:
1845 (on_camel_account_get_supported_secure_authentication),
1846 (modest_maemo_utils_get_supported_secure_authentication_methods):
1847 Fixed a crasher if operation is canceled
1849 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1850 (modest_protocol_info_auth_is_secure):
1851 * src/modest-protocol-info.h:
1853 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1854 the sense of the "Use secure authentication" toggle.
1856 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1858 * src/modest-tny-account-store.h:
1859 * src/modest-tny-account-store.c:
1860 Added modest_tny_account_store_get_local_folders_account().
1862 * src/modest-tny-folder.h:
1863 * src/modest-tny-folder.c:
1864 (modest_tny_folder_get_account):
1865 Added this replacement for tny_folder_get_account() which returns
1866 the local-folders account for TnyMergeFolders, to avoid the
1867 warning about the unimplemented get_account_func() vfunc().
1869 (modest_tny_folder_get_rules),
1870 * src/modest-ui-actions.c:
1871 (modest_ui_actions_on_folder_selection_changed):
1872 * src/modest-mail-operation.c:
1873 (modest_mail_operation_remove_folder),
1874 (modest_mail_operation_xfer_folder),
1875 (modest_mail_operation_rename_folder),
1876 (modest_mail_operation_get_msg),
1877 (modest_mail_operation_get_msgs_full),
1878 (modest_mail_operation_remove_msg),
1879 (modest_mail_operation_xfer_msgs),
1880 (modest_mail_operation_refresh_folder):
1881 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1883 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1885 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1886 (modest_server_account_set_security):
1887 * src/modest-defs.h: Add comments explaining that our
1888 UI spec means TLS when it says Normal, so these do not look like errors.
1890 * src/modest-tny-account.c:
1891 (modest_tny_account_new_from_server_account): Use the new tinymail
1892 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1893 for TLS. This should fix projects.maemo.org bug NB#58460.
1895 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1897 * src/maemo/easysetup/modest-easysetup-wizard.c:
1898 (create_account): Correct the position of the gconf sanity check warning.
1899 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1900 of using the g_idle_add() hack, because this does not seem to be necessary
1901 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1902 caused by something other than maemo's gconf.
1903 This fixes projects.maemo.org bug #59022.
1905 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1907 * src/modest-account-mgr-helpers.c:
1908 (modest_account_mgr_get_default_account): Do not check that the account
1909 exists if there is no default account (NULL), to fix a runtime warning.
1911 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1913 * src/widgets/modest-folder-view.c: (update_model):
1914 Do not unref the treemodel before we have finished with it.
1915 This prevents a valgrind warning and an occasional crash at startup.
1917 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1919 * libmodest-dbus-client/libmodest-dbus-client.h:
1920 added libmodest_dbus_client_compose_mail()
1921 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1923 added functions needed for SendAsMail() functionality
1924 * src/maemo/modest-msg-edit-window.c:
1925 (modest_msg_edit_window_attach_file_noninteractive):
1926 non interactively attaching files to message edit window
1927 * src/widgets/modest-msg-edit-window.h:
1928 * tests/dbus_api/Makefile.am:
1929 added test_compose_mail.c
1930 * tests/dbus_api/test_compose_mail.c: (main):
1932 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1934 * src/modest-account-view.c:
1935 Fixed bug projects.maemo.org bug NB#59307
1937 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1939 * src/maemo/easysetup/modest-easysetup-wizard.c:
1940 (get_serverport_incoming), (on_before_next), (create_account):
1941 * src/maemo/modest-account-settings-dialog.c:
1942 (modest_account_settings_dialog_set_account_name):
1943 * src/maemo/modest-maemo-utils.c:
1944 (on_camel_account_get_supported_secure_authentication_status),
1945 (on_camel_account_get_supported_secure_authentication),
1946 (on_secure_auth_cancel),
1947 (modest_maemo_utils_get_supported_secure_authentication_methods):
1949 Implemented security authentication for settings and easysetup.
1951 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1953 * src/maemo/modest-main-window.c: (create_details_widget):
1954 Show the total size for memory card accounts too, instead of showing
1955 the name again. Fixes bug projects.maemo.org bug NB#59307.
1957 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1960 * src/modest-tny-simple-folder-store.c:
1961 * src/modest-tny-simple-folder-store.h: Removed.
1963 * src/modest-tny-local-folders-account.h
1964 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1965 for the local-folders maildir, with an extra TnyMergedFolder containing
1966 the folders of the per-account outbox store accounts.
1967 * src/modest-tny-account-store.c: (get_server_accounts):
1968 Add the outboxes to the special local folders account after creating it.
1970 * src/modest-tny-account.c:
1971 (modest_tny_account_new_for_local_folders): Create the derived
1972 account when creating the main local-folders account.
1974 * src/maemo/modest-main-window.c: (create_details_widget),
1975 (modest_main_window_set_contents_style):
1976 Adapted to the use of the derived account instead of the folder store.
1978 * src/modest-ui-actions.c:
1979 (modest_ui_actions_on_folder_selection_changed):
1980 * src/modest-ui-dimming-rules.c:
1981 (modest_ui_dimming_rules_on_new_folder):
1982 * src/widgets/modest-folder-view.c: (text_cell_data),
1983 (icon_cell_data), (filter_row), (update_model),
1984 (get_cmp_rows_type_pos):
1987 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1988 Do not get the priv struct, because no priv struct has been set,
1989 to avoid a runtime warning.
1991 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1992 #ifelse with #else, to fix a warning, to fix the build.
1995 2007-06-05 Christian Kellner <ckellner@openismus.com>
1997 * libmodest-dbus-client/libmodest-dbus-client.c:
1998 Fix small typo in doc (why do you always see them
1999 AFTER committing stuff?)
2002 2007-06-05 Christian Kellner <ckellner@openismus.com>
2004 * libmodest-dbus-client/libmodest-dbus-client.c:
2005 (libmodest_dbus_client_search):
2006 Initialize hit list with NULL. Also set folder list
2007 to "" if NULL was supplied.
2010 2007-06-03 Christian Kellner <ckellner@openismus.com>
2012 * libmodest-dbus-client/libmodest-dbus-client.c:
2013 (modest_search_hit_list_free):
2014 Make it save to call it with NULL.
2016 * src/dbus_api/modest-dbus-callbacks.c:
2017 * src/modest-search.c:
2018 Return full ModestSearchHits as the search result list not TnyHeader
2019 since can't be around withouth the correspoding TnyFolder.
2021 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2023 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2024 Added currently commented code to check for secure auth
2026 * src/maemo/modest-account-settings-dialog.c: (on_response),
2027 (save_configuration), (show_ok):
2028 Fixed projects.maemo.org bugs NB #59248 and #59251
2030 * src/maemo/modest-maemo-utils.c:
2031 (on_camel_account_get_supported_secure_authentication_status),
2032 (on_camel_account_get_supported_secure_authentication),
2033 (modest_maemo_utils_get_supported_secure_authentication_methods):
2034 * src/maemo/modest-maemo-utils.h:
2035 Moved get_supported_secure_authentication() method here to be able
2036 to use it from easysetup wizard.
2038 * src/modest-pair.c: (on_pair_compare_as_string):
2039 Should compare string with first part of pair and not
2040 strcmp pairs which will crash.
2042 * src/modest-protocol-info.c:
2043 (modest_protocol_info_protocol_is_store):
2044 * src/modest-protocol-info.h:
2045 Added modest_protocol_info_get_auth_protocol_name()
2047 2007-06-03 Armin Burgmeier <armin@openismus.com>
2049 * src/modest-mail-operation.c:
2050 (modest_mail_operation_get_msgs_full): Set priv->account also when
2051 only retrieving a single message. This avoids a crash when canceling
2054 (modest_mail_operation_notify_end): Do not explicitely remove the
2055 operation from the queue but only emit the progress_changed signal.
2056 The queue itself listens to that signal to remove the operation when
2057 it is finished. This reduces coupling and removes a potential deadlock
2058 when modest_mail_operation_notify_end() is called from the queue
2059 itself. If that is a problem performance-wise, I would suggest to
2060 implement a status-changed signal or something.
2062 * src/modest-mail-operation-queue.c: Make sure to never call a
2063 function from another file while the queue is locked. This (hopefully)
2064 fixes another deadlock when exiting the application while retrieving
2067 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2069 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2070 Fixed build if libogs is not available
2072 2007-06-03 Christian Kellner <ckellner@openismus.com>
2074 * libmodest-dbus-client/libmodest-dbus-client.h:
2075 * libmodest-dbus-client/libmodest-dbus-client.c:
2076 (libmodest_dbus_client_delete_message):
2077 Implement deletion of messages (Client side).
2079 (modest_search_hit_free),
2080 (modest_search_hit_list_free):
2081 Utility functions to free the result hits.
2083 * src/dbus_api/modest-dbus-api.h:
2084 * src/dbus_api/modest-dbus-callbacks.c:
2085 (on_delete_message),
2086 (modest_dbus_req_handler):
2087 Implement deletion of messages (Server side).
2089 * tests/dbus_api/test_search.c: (main):
2092 * tests/dbus_api/Makefile.am:
2093 * tests/dbus_api/test_delete_message:
2094 Add little test for the message deletion logic
2096 2007-06-03 Armin Burgmeier <armin@openismus.com>
2098 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2099 when the operation queue was not empty. projects.maemo.org bug
2102 2007-06-03 Armin Burgmeier <armin@openismus.com>
2104 * src/widgets/modest-account-view.c
2105 (on_account_default_toggled): Toggle default account column
2106 explicitely instead of waiting for gconf notification (which is
2107 currently ignored). This should fix projects.maemo.org bug NB#56910
2108 for now. It should probably be removed when gconf notifications are
2111 2007-06-03 Christian Kellner <ckellner@openismus.com>
2113 * libmodest-dbus-client/libmodest-dbus-client.c:
2114 Removed debugging spew.
2116 * src/dbus_api/modest-dbus-callbacks.c:
2117 Added debugging info.
2119 * src/modest-search.c:
2120 (modest_search_all_accounts):
2121 Use tny_account_store_get_accounts () on the account store
2122 to get all accounts which is the way to get all accounts.
2124 * tests/dbus_api/test_search.c: (main):
2125 Make it possible to supply the search term on the command line.
2127 2007-06-03 Christian Kellner <ckellner@openismus.com>
2129 * libmodest-dbus-client/libmodest-dbus-client.c:
2130 * libmodest-dbus-client/libmodest-dbus-client.h:
2131 Implement searching for mesages over raw dbus. (Client side)
2133 * src/dbus_api/Makefile.am:
2134 * src/dbus_api/modest-dbus-api.h:
2135 * src/dbus_api/modest-dbus-callbacks.c:
2136 * src/dbus_api/modest-dbus-callbacks.h:
2137 Search framework (Server side). Also implement on_idle_open_message().
2139 * src/maemo/modest-platform.c: (modest_platform_init):
2140 Prepare for raw dbus/osso rpc interaction.
2142 * src/modest-search.h:
2143 Changed minsize from unspecific guint to guint32.
2145 * src/modest-search.c:
2147 Added strange hack which magically made tnymail work.
2149 (modest_search_folder),
2150 (modest_search_account),
2151 (modest_search_all_accounts):
2152 Implement helper functions to search all accounts, specific account
2155 * tests/dbus_api/Makefile.am:
2156 * tests/dbus_api/test_open_message.c:
2157 Read url to open from commandline.
2159 * tests/dbus_api/test_search.c:
2160 Implement small test for dbus search stuff
2162 2007-06-02 Armin Burgmeier <armin@openismus.com>
2164 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2165 include account type and account title. This fixes projects.maemo.org
2168 * src/maemo/modest-account-view-window.c: Set a title for the window.
2170 2007-06-02 Armin Burgmeier <armin@openismus.com>
2172 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2173 incoming and outgoing server name based on email address and server
2174 types as long as the names have not been edited manually. This fixes
2175 projects.maemo.org bug NB#58671.
2177 2007-06-02 Armin Burgmeier <armin@openismus.com>
2179 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2180 server type cannot be changed in future to the incoming details page
2181 when creating an account. This fixes projects.maemo.org bug NB#59029.
2183 2007-06-02 Armin Burgmeier <armin@openismus.com>
2185 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2186 and assigned max width chars so that they wrap instead of being
2187 truncated. Fixes projects.maemo.org bug NB#56126.
2189 2007-06-02 Armin Burgmeier <armin@openismus.com>
2191 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2192 introductory note to the connection specific smtp servers dialog, as
2193 section 8.12 of the email UI specification requires. This fixes
2194 projects.maemo.org bug NB#59212.
2196 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2198 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2199 Check for running mail operations, and offer to cancel them, as per the UI
2200 spec. This fixes projects.maemo.org bug NB#59041 .
2201 However, I suspect that tinymail may still use the network connection
2202 in ways that we cannot detect or cancel. But it should at least adapt to
2203 changes fairly well.
2205 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2207 * src/modest-tny-account-store.c: (recreate_all_accounts),
2208 (get_cached_accounts), (get_server_accounts): Do more sensible
2209 ref-counting of the temporarily-cached outbox accounts list. This seems
2210 to fix a crash when entering the password when the password was wrong.
2212 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2214 * src/gnome/modest-main-window.c: (connect_signals):
2215 * src/modest-tny-account-store.c: (get_password),
2216 (modest_tny_account_store_alert): Added comments and clues and
2217 commented-out code about how we currently fail to deal with connection
2218 errors and wrong passwords, and how we should.
2220 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2222 * src/widgets/modest-retrieve-combo-box.c:
2223 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2224 This fixes projects.maemo.org bug NB#58472 .
2226 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2228 * src/maemo/easysetup/modest-easysetup-wizard.c:
2229 (create_page_complete_easysetup):
2230 (create_page_complete_custom): Correct the last commit,
2231 putting the correct sentences in the correct pages.
2233 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2235 * src/maemo/easysetup/modest-easysetup-wizard.c:
2236 (create_page_complete_custom): Show the second sentence of text
2237 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2240 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2242 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2243 Set the leave-on-server conf key by default. This fixes
2244 projects.maemo.org bug NB#59258 .
2246 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2248 * src/maemo/modest-account-view-window.c:
2249 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2250 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2253 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2255 * src/maemo/easysetup/modest-easysetup-wizard.c:
2256 (create_caption_new_with_asterisk):
2257 * src/maemo/modest-account-settings-dialog.c:
2258 (create_caption_new_with_asterisk):
2259 Uncomment the code to add the asterisk, because they are no longer in the
2260 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2261 (update_incoming_server_title): Add an asterisk here too.
2263 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2265 * src/maemo/modest-maemo-global-settings-dialog.c:
2266 (current_connection): Check that we are even connected before trying to
2267 get the current connection name, to prevent a warning.
2269 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2270 Change the comments because tny_maemo_conic_device_connect() is now meant to
2272 * src/modest-mail-operation.c:
2273 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2274 make sure we have a connection and fail if we can't connect.
2276 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2278 * src/maemo/modest-main-window.c:
2279 (on_account_store_connecting_finished): Do not try to get the
2280 connection ID if we are not really connected. I am surprised that
2281 this signal handler is called when we are not connected.
2283 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2285 * src/modest-error.h:
2286 * src/modest-ui-actions.c:
2287 (modest_ui_actions_get_msgs_full_error_handler):
2288 Renamed an enum, added comments, added an enum
2289 for retrieve-limit errors.
2291 * src/modest-mail-operation.c: (foreach_add_item),
2292 (internal_folder_observer_update), (update_account_thread),
2293 (modest_mail_operation_get_msgs_full):
2294 (modest_mail_operation_update_account),
2295 Added comments about how this works, and some code that should
2296 (but does not) check the retrieve-limit. See the TODO comment.
2298 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2300 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2301 Initialize help_id to fix the build. Warnings are good.
2303 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2305 * src/widgets/modest-hbox-cell-renderer.c:
2306 (modest_hbox_cell_renderer_append):
2307 * src/widgets/modest-vbox-cell-renderer.c:
2308 (modest_vbox_cell_renderer_append):
2309 Fix the last commit by doing an extra ref.
2311 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2313 * src/widgets/modest-hbox-cell-renderer.c:
2314 (modest_hbox_cell_renderer_append):
2315 * src/widgets/modest-vbox-cell-renderer.c:
2316 (modest_vbox_cell_renderer_append):
2317 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2318 to fix the build with Maemo Bora.
2319 However, there seems to be a remaining crash, probably due to reference
2322 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2324 * src/modest-tny-account.c:
2325 (modest_tny_account_new_for_local_folders):
2326 Use hildon_file_system_info_async_new() to get a better name for
2327 the memory card account, setting it as the account name.
2328 The timing seems to work, but this is probably
2329 not the best place to do this. See the TODO comment.
2330 * src/maemo/modest-main-window.c: (create_details_widget):
2331 * src/widgets/modest-folder-view.c: (text_cell_data):
2332 Use the tny account name instead of hardcoding a name.
2334 2007-05-30 Christian Kellner <ckellner@openismus.com>
2336 * src/modest-search.c: (modest_search):
2337 Correctly set part_search_func even if we have already parsed
2338 the query and thus a valid OgsTextSearcher object.
2340 2007-05-30 Christian Kellner <ckellner@openismus.com>
2343 Search and check for libogs.
2346 Incooparte the ogs build env.
2348 * src/modest-mime-part-search-stream.c:
2349 * src/modest-mime-part-search-stream.h:
2350 Removed since we do the real searching now in modest-search.c.
2352 * src/modest-search.c:
2353 * src/modest-search.h:
2354 Implement support for ogs. We use that if available and requested
2355 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2356 should now handle the corner case when the search term is spread
2357 across multiple reads.
2358 Also the logic in modest_search () was corrected to search all
2359 requested fields until one is found.
2361 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2363 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2365 * src/modest-init.h:
2366 * src/modest-init.c: Made modest_init_local_folders() take a
2367 path and be public so we can iniitialize maildir folders on
2370 * src/modest-local-folder-info.h:
2371 * src/modest-local-folder-info.c:
2372 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2374 * src/modest-tny-account.c:
2375 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2376 still means the standard local-folders path on the local volume.
2378 * src/modest-tny-account-store.c:
2379 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2380 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2381 all accounts when that happens.
2382 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2383 this too, so it shows up in the treeview.
2385 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2387 * src/maemo/modest-maemo-global-settings-dialog.c:
2388 (current_connection):
2389 * src/widgets/modest-global-settings-dialog.c:
2390 (current_connection_default):
2391 Use the enum values instead of 0, 1 and -1,
2392 to make the code clearer.
2394 * src/modest-account-mgr-helpers.c:
2395 (modest_account_mgr_get_connection_specific_smtp): Make this code
2398 * src/modest-runtime.h:
2399 * src/modest-runtime.c:
2400 Added modest_runtime_remove_all_send_queues().
2401 * src/maemo/modest-main-window.c:
2402 (on_account_store_connecting_finished): Recreate the send queues,
2403 using the appropriate transport accounts for this new connection.
2404 Some futher adapting might be needed if the old send queues are not
2405 automatically stopped at this point.
2407 * src/modest-tny-account-store.c: (get_server_accounts):
2408 Create the connection-specific transport accounts, so that they can
2409 be found later by their ID.
2411 * src/modest-tny-account.h:
2412 * src/modest-tny-account.c:
2413 Added modest_tny_account_new_from_server_account_name().
2414 modest_tny_account_new_from_server_account(): Do not create the
2415 send queues here, because they will be
2416 recreated anyway when the connection changes for the first time.
2418 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2420 * src/modest-local-folder-info.h:
2421 * src/modest-local-folder-info.c:
2422 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2423 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2424 tbox_folder): Take a modest account name instead of a server TnyAccount,
2425 so we can have per-modest-account rather than per-transport-account
2427 We must make sure that we change or recreate the exisitng send queues
2428 when the connection changes for connection-specific transport accounts.
2430 * src/modest-tny-account-store.c:
2431 (create_per_account_local_outbox_folders): Create outboxed per modest
2432 account, not per transport account.
2434 * src/modest-tny-account.h:
2435 * src/modest-tny-account.c:
2436 (modest_tny_account_get_special_folder): For outboxes, get the
2437 parent modest account name. The account is ignored for other folders.
2438 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2439 modest account name rather than a server TnyAccount.
2441 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2443 * src/modest-tny-account.c:
2444 (modest_tny_account_new_from_server_account):
2445 Call modest_runtime_get_send_queue() immediately after creating transport
2446 accounts, so that they start trying to send email from the outbox as soon
2447 as possible at startup. This is probably what we want.
2449 * src/modest-mail-operation.c: (update_account_thread):
2450 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2451 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2452 * src/modest-tny-send-queue.h:
2453 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2454 (modest_ui_actions_on_send):
2455 Added comments about how sending works, though it needs some more work.
2457 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2459 * src/modest-tny-account.c:
2460 (modest_tny_account_get_special_folder): Add TODO because this fails when
2461 the network is busy.
2462 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2463 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2464 Do not try to show this window when there is no active account. The UI
2465 specs does not tell us what to do in this case.
2467 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2471 * src/maemo/Makefile.am:
2472 * src/widgets/Makefile.am: Some dist fixes.
2474 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2476 * src/maemo/modest-connection-specific-smtp-window.c:
2477 (on_button_edit): Make the code clearer, to prevent a double free.
2479 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2481 * src/maemo/modest-account-settings-dialog.c:
2482 (modest_account_settings_dialog_set_account_name),
2483 Check the connection-specific smtp servers checkbox if there are any.
2485 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2486 (modest_connection_specific_smtp_edit_window_init):
2487 Start with a suitable port number.
2489 * src/modest-account-mgr-helpers.h:
2490 * src/modest-account-mgr-helpers.c: Added
2491 modest_account_mgr_get_has_connection_specific_smtp().
2493 (modest_account_mgr_set_connection_specific_smtp),
2494 (modest_account_mgr_remove_connection_specific_smtp),
2495 (modest_account_mgr_get_has_connection_specific_smtp),
2496 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2497 connection-specific smtp server accounts in the account, rather than
2498 the server account conf dir.
2500 This fixes bug projects.maemo.org bug NB#58263 .
2502 * src/modest-tny-account-store.c:
2503 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2504 if there are no server accounts yet, to prevent an infinite loop when there
2505 are no accounts. Document that one must be called before the other.
2507 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2509 * src/modest-account-mgr-helpers.c:
2510 (modest_account_mgr_get_default_account): Make sure that at least
2511 one account is always the default, if there are any enabled accounts.
2512 This is just a sanity check that shouldn't be necessary.
2514 * src/modest-account-mgr-priv.c:
2515 (_modest_account_mgr_account_from_key): Unescape the conf key to
2516 get the real account name. For instance, this is an issue if a space
2517 was in the account name, which can happen because the account name
2518 is generated from the display name.
2519 (_modest_account_mgr_get_account_keyname): Always escape the
2521 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2522 Unescape the conf keys to get the real account names.
2524 For instance, previously the is-default radio button in the accounts
2525 list was not checked for any accounts at first. This fixes that,
2526 and might fix several similar bugs.
2528 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2530 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2531 Removed some debug printfs.
2533 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2535 Modest on-disk outbox directories are now here, for instance:
2536 $HOME/.modest/outboxes/<account-id-1>/outbox
2537 $HOME/.modest/outboxes/<account-id-2>/outbox
2539 $HOME/.modest/local-folders/outbox
2540 so we can have a separate outbox for each account.
2541 But they are shown as one outbox in the GtkTreeView, by using a
2542 TnyMergeFolder in a ModestTnySimpleFolderStore.
2545 * src/modest-tny-simple-folder-store.c:
2546 * src/modest-tny-simple-folder-store.h:
2547 Added ModestTnySimpleFolderStore, used to contain folders from
2548 other folder stores, such as other accounts.
2550 * src/modest-tny-outbox-account.h:
2551 * src/modest-tny-outbox-account.c:
2552 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2553 used for the per-account local outbox folders.
2555 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2556 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2557 only use this (internally) now for the non-outbox local folders.
2559 * src/modest-init.h:
2560 * src/modest-init.c: Added modest_init_one_local_folder(), for
2561 setting up the directory structure for each local folder.
2563 * src/modest-local-folder-info.c:
2564 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2565 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2567 * src/modest-local-folder-info.h:
2568 * src/modest-tny-account-store.c: (on_account_removed),
2569 (on_account_changed), (create_per_account_local_outbox_folders),
2570 (get_server_accounts), (modest_tny_account_store_get_accounts),
2571 (modest_tny_account_store_get_tny_account_by_account),
2572 (modest_tny_folder_store_is_virtual_local_folders):
2574 * src/modest-tny-account.h:
2575 * src/modest-tny-account.c:
2576 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2577 to create an on-disk per-account local outbox folder for each
2579 (create_per_account_local_outbox_folders): Create a local outbox folder
2580 for each transport account.
2581 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2582 for all local folders.
2584 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2585 instead of using g_object_get/set() directly. It is clearer.
2587 (modest_tny_folder_store_get_message_count),
2588 (modest_tny_folder_store_get_local_size
2589 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2590 because we now use these with non-acount folder stores.
2592 (modest_tny_account_get_special_folder),
2593 (modest_tny_account_new_from_server_account),
2594 (modest_tny_account_new_from_account):
2595 (recurse_folders): Adjust to the new outbox system.
2597 * src/modest-tny-folder.h:
2598 * src/modest-tny-folder.c:
2599 (modest_tny_folder_is_local_folder),
2600 (modest_tny_folder_get_local_folder_type),
2601 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2603 * src/widgets/modest-main-window.h:
2604 * src/maemo/modest-main-window.c: (create_details_widget),
2605 (modest_main_window_set_contents_style): Show details for any folder store,
2608 (modest_tny_folder_get_rules):
2609 Remove the const. C does not support constness enough for this.
2611 * src/modest-ui-actions.c:
2612 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2613 make all outboxes appear as one, in the usual local-folders tree node.
2615 (set_active_account_from_tny_account),
2616 (modest_ui_actions_on_folder_selection_changed):
2617 * src/widgets/modest-folder-view.c: (text_cell_data),
2618 (icon_cell_data), (filter_row),
2619 (add_account_folders_to_merged_folder),
2620 (add_account_folders_to_simple_folder_store), (),
2621 (get_cmp_rows_type_pos), (cmp_rows),
2622 (modest_folder_view_set_account_id_of_visible_server_account):
2623 Adjust to the new outbox system, using generic folder stores and folders
2624 in the GtkTreeModel.
2626 2007-05-23 Christian Kellner <ckellner@openismus.com>
2628 * src/modest-mail-operation.c:
2629 (modest_mail_operation_update_account):
2630 Use info->max_size instead of unintialized local var [small
2631 build fix]. (Added TODO to review that change since I don't
2634 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2636 * libmodest-dbus-client/libmodest-dbus-client.c:
2637 (libmodest_dbus_client_compose_mail): function added
2638 * src/dbus_api/modest-dbus-api.h:
2639 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2640 (on_compose_mail): Implementation of the SendAsMail functionality
2642 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2644 * src/modest-account-mgr.c:
2645 (modest_account_mgr_add_server_account): Set the secure-connection
2646 conf key for transport accounts as well as store accounts. I don't know
2647 why the if was there. For instance, this makes sure that we use SSL
2648 for the gmail preset from the easysetup wizard.
2650 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2652 * src/gnome/modest-main-window.c:
2653 (on_account_store_connecting_finished), (connect_signals):
2654 * src/maemo/modest-main-window.c:
2655 (on_account_store_connecting_finished), (connect_signals),
2656 (modest_main_window_new):
2657 Handle TnyAccountStore::connecting-finished instead of
2658 TnyDevice::connection-changed, because we cannot actually perform
2659 operations on accounts until TnyAccountStore has itself responded to
2660 the TnyDevice::connection-changed signal. This prevents a GError from
2662 Do not try to update at startup, because we (at least on scratchbox)
2663 already do an update at startup when the device goes online.
2664 This prevents a GError from tinymail.
2665 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2666 Added TODO about stopping simultaneous operations.
2668 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2670 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2671 * src/modest-mail-operation-queue.c:
2672 (modest_mail_operation_queue_remove):
2673 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2674 about where they happened.
2676 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2678 * src/modest-ui-actions.c:
2679 (modest_ui_actions_on_password_requested): Make sure that the remember
2680 output parameter is always TRUE.
2682 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2684 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2685 Show a OK/Cancel dialog if the error is a question, though we still do not
2686 know anything more about what we are asking the user.
2687 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2688 Fix an uninitialized variable (helper). This is a logic error, however.
2690 2007-05-21 Christian Kellner <ckellner@openismus.com>
2692 * src/modest-search.h:
2693 Correct bit shifting in the ModestSearchFlags enum.
2695 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2697 * src/modest-tny-account.c:
2698 (modest_tny_account_new_from_server_account): Do not use the lsub and
2699 check-all hard-coded IMAP options when using POP.
2701 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2703 * src/modest-tny-account.c:
2704 (modest_tny_account_new_from_server_account):
2705 Use NULL for the secure-auth method for POP when Password auth has been
2706 specified by the user, as we already do for IMAP. "auth=Login" causes
2707 an error from camel or the server.
2709 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2711 * src/maemo/modest-account-settings-dialog.c:
2712 (create_page_account_details),
2713 (modest_account_settings_dialog_set_account_name):
2714 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2715 for the leave-on-server checkbox, rathr than just the checkbox, when
2716 the protocol is not POP.
2718 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2720 * src/widgets/modest-account-view.c:
2721 * src/widgets/modest-account-view.h:
2722 Added modest_account_view_select_account() which will be useful later
2723 to asynchronously re-select the edited account.
2725 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2727 * src/maemo/modest-account-settings-dialog.c:
2728 (modest_account_settings_dialog_set_account_name):
2729 Automatically choose the port numbers based on the secure authentication
2730 methods, if they have not been chosen before.
2731 This fixes projects.maemo.org bug NB#56273 .
2733 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2735 * src/maemo/modest-main-window-ui.h:
2736 * src/modest-ui-actions.c:
2737 * src/modest-ui-actions.h:
2738 Connect the Tools/SMTP Servers menu item to
2739 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2740 SMTP servers dialog, as in the UI specification and saves changes when it
2741 is closed. This fixed projects.maemo.org bug NB#56305 .
2743 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2745 * src/maemo/modest-connection-specific-smtp-window.c:
2746 (modest_connection_specific_smtp_window_init):
2747 Use gtk_window_set_default_size() to make this window big enough, so
2748 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2750 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2752 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2753 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2754 (modest_connection_specific_smtp_edit_window_init),
2755 Do not try to connect to a combobox signal before the combobox exists.
2756 This fixes the cras in projects.maemo.org bug NB#56288 .
2757 (modest_connection_specific_smtp_edit_window_get_settings):
2758 Remove the server_account_name parameter which was being checked for NULL
2759 though it was not used.
2761 * src/maemo/modest-connection-specific-smtp-window.c:
2762 (modest_connection_specific_smtp_window_fill_with_connections),
2763 (on_button_edit), (modest_connection_specific_smtp_window_init):
2764 Correct the number of treemodel columns to prevent a warning.
2765 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2766 libconic does not work.
2768 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2770 * src/modest-tny-account.c:
2771 (modest_tny_account_new_from_server_account):
2772 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2773 SMTP when "None" was chosen by the user. However, with my SMTP server that
2774 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2777 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2779 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2780 to explain the memory management issue with the ID in the ModestPair.
2782 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2783 (add_sending_page), (modest_account_assistant_finalize):
2784 * src/gnome/modest-gnome-global-settings-dialog.c:
2785 (create_updating_page), (create_composing_page):
2786 * src/gnome/modest-msg-edit-window.c: (get_transports),
2787 (init_window), (modest_msg_edit_window_finalize),
2788 (modest_msg_edit_window_get_msg_data):
2789 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2790 * src/gnome/modest-transport-widget.c:
2791 (modest_transport_widget_finalize), (smtp_configuration):
2792 * src/maemo/modest-maemo-global-settings-dialog.c:
2793 (create_updating_page), (create_composing_page):
2794 * src/maemo/modest-msg-edit-window.c: (get_transports),
2795 (init_window), (modest_msg_edit_window_finalize),
2796 (modest_msg_edit_window_get_msg_data),
2797 (modest_msg_edit_window_free_msg_data):
2798 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2799 (modest_store_widget_finalize):
2800 * src/maemo/modest-transport-widget.c:
2801 (modest_transport_widget_finalize), (smtp_configuration):
2802 * src/modest-main.c: (send_mail):
2803 * src/widgets/modest-combo-box.h:
2804 * src/widgets/modest-global-settings-dialog-priv.h:
2805 * src/widgets/modest-global-settings-dialog.c:
2806 (modest_global_settings_dialog_finalize):
2807 * src/widgets/modest-msg-edit-window.h:
2808 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2809 as long as the combo box, to prevent use of freed memory for the ID.
2811 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2813 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2814 get_accounts(), to make this clearer. Do not check for the enabled gconf
2815 key, because we do not use this for server accounts (at least, not yet).
2816 This allows us to send email again.
2818 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2820 * src/maemo/modest-platform.c:
2821 (on_modest_conf_update_interval_changed), (modest_platform_init):
2822 Only respond to this particular key change. All these strcmp()s cannot be
2825 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2827 * src/maemo/modest-maemo-global-settings-dialog.c:
2828 (current_connection): Prevent a crash in scratchbox when
2829 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2830 * src/maemo/modest-platform.c:
2831 (on_modest_conf_update_interval_changed), (modest_platform_init):
2832 Get the update interval from gconf and reset it when the gconf key changes.
2834 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2836 * src/modest-protocol-info.c:
2837 * src/modest-protocol-info.h: Adde enum-specific get functions,
2838 instead of using a ModestProtocolType enum parameter.
2840 * src/gnome/modest-account-assistant.c:
2841 * src/gnome/modest-store-widget.c:
2842 * src/gnome/modest-store-widget.h:
2843 * src/gnome/modest-transport-widget.c:
2844 * src/gnome/modest-transport-widget.h:
2845 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2846 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2847 * src/maemo/easysetup/modest-easysetup-wizard.c:
2848 * src/maemo/modest-account-settings-dialog.c:
2849 * src/maemo/modest-account-settings-dialog.h:
2850 * src/maemo/modest-store-widget.c:
2851 * src/maemo/modest-store-widget.h:
2852 * src/maemo/modest-transport-widget.c:
2853 * src/maemo/modest-transport-widget.h:
2854 * src/modest-account-mgr-helpers.c:
2855 * src/modest-account-mgr-helpers.h:
2856 * src/modest-account-mgr.c:
2857 * src/modest-account-mgr.h:
2858 * src/modest-tny-account.c:
2859 * src/modest-tny-folder.c:
2860 * src/widgets/modest-account-view.c:
2861 * src/widgets/modest-retrieve-combo-box.c:
2862 * src/widgets/modest-retrieve-combo-box.h:
2863 * src/widgets/modest-secureauth-combo-box.c:
2864 * src/widgets/modest-serversecurity-combo-box.c:
2865 * src/widgets/modest-serversecurity-combo-box.h:
2866 * tests/check_account-mgr.c:
2867 Use the specific functions, and use the re-renamed enum values for GNOME too.
2869 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2871 * src/modest-pair.h:
2872 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2873 so we can get the second based on the first.
2875 * src/maemo/modest-account-settings-dialog.h:
2876 * src/maemo/modest-account-settings-dialog.c:
2877 Added get_supported_secure_authentication_methods(), though it is mostly
2878 commented-out for now until the necessary API is committed to tinymail.
2879 (modest_account_settings_dialog_set_account_name),
2880 (save_configuration): Request the supported authentication methods from the
2881 server, so we can choose a working method.
2883 * src/modest-tny-account-store.h:
2884 * src/modest-tny-account-store.c:
2885 (modest_tny_account_store_get_session): Rename from
2886 tny_account_store_get_session().
2888 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2890 * src/modest-protocol-info.h: Split the ModestProtocol enum
2891 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2892 There was no need to have these unrelated values in one enum.
2894 * src/: many files: Adapted to changed enum. This makes the code a bit
2895 clearer, and the compiler could catch some errors.
2897 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2899 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2900 Show the detailed internal camel error message when an error happens
2901 during the configuration, so that our testers can give us more clues.
2902 For instance, in projects.maemo.org bug NB#56910 .
2904 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2906 * src/modest-tny-account.c:
2907 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2908 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2910 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2912 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2913 * src/maemo/modest-account-settings-dialog.c:
2914 (modest_account_settings_dialog_set_account_name),
2915 (save_configuration): For the incoming secure authentication checkbox,
2916 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2917 the UI specification. PLAIN does not seem to be supported for most IMAP
2918 servers anyway, and I am not sure what it would mean.
2919 However, we probably need to discover which of the secure-authentication
2920 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2921 * src/modest-account-mgr-helpers.c:
2922 (modest_account_mgr_get_server_account_data):
2924 * src/modest-tny-account.c:
2925 (modest_tny_account_new_from_server_account):
2926 Use tny_account_set_mech() to set secure-authentication methods,
2927 with some special-casing for IMAP, based on my observations of how
2930 * src/modest-account-mgr-helpers.h:
2931 * src/modest-account-mgr.c:
2932 * src/modest-defs.h: Comment that the URI is only used for local folders.
2934 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2936 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2937 parameter const, just to be neat.
2938 * src/modest-text-utils.c: (modest_text_utils_inline):
2939 End g_strconcat() with NULL, as its documentation says. This is almost
2940 certainly the cause of my crash at startup on the device. Interestingly,
2941 valgrind doesn't tell us about these errors.
2943 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2945 * scripts/build-packages: Added more precise comments about how to use
2946 this script, though I still get this error:
2947 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2948 error building tinymail
2950 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2952 * src/maemo/modest-main-window.c: (on_account_update):
2953 Very slight cleanup, hoping to make it simpler to discover what causes
2954 a crash here sometimes.
2956 * src/modest-tny-account.c:
2957 (modest_tny_account_new_from_server_account): Set the port. Added
2958 comments about the options and a TODO comment because I need to find out
2959 how to specify the secure authentication method.
2961 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2963 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2964 changed CFlags paths form modest to libmodest
2966 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2968 * src/modest-account-mgr-helpers.c:
2969 (modest_account_mgr_get_server_account_data),
2970 (modest_account_mgr_free_server_account_data):
2971 * src/modest-account-mgr-helpers.h:
2972 * src/modest-account-mgr.c:
2973 (modest_account_mgr_add_server_account):
2974 * src/modest-defs.h:
2975 * src/modest-tny-account.c:
2976 (modest_tny_account_new_from_server_account):
2977 Determine the options for tny_camel_account_add_option() here,
2978 based on the settings, rather than storing them directly in gconf.
2980 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2982 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2983 Show a more friendly error dialog now that we expect (from the tinymail
2984 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2986 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2988 * src/maemo/modest-main-window.c: (on_account_update): Check that
2989 account_name is not NULL, to prevent a crash at startup that I am
2990 seeing on the N800. I do wonder why it is NULL.
2992 * src/maemo/easysetup/modest-easysetup-wizard.c:
2993 (create_page_user_details):
2994 * src/maemo/modest-account-settings-dialog.c:
2995 (create_page_user_details), (create_page_outgoing):
2996 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2997 (modest_connection_specific_smtp_edit_window_init):
2998 * src/modest-ui-actions.c:
2999 (modest_ui_actions_on_password_requested):
3000 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3001 might do something useful with the on-screen keyboard.
3003 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3005 * src/maemo/modest-main-window.c: (on_account_update):
3006 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3007 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3009 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3011 * src/modest-tny-account-store.c: (on_account_changed):
3012 Correct the signature of this signal handler.
3014 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3016 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3017 Show a HildonNote instead of a GtkDialog for Maemo.
3019 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3021 * src/widgets/modest-account-view.h:
3022 * src/widgets/modest-account-view.c: (on_account_changed),
3023 (on_account_removed). Added a boolean flag, set/unset by
3024 modest_account_view_block_conf_updates(),
3025 modest_account_view_unblock_conf_updates() to prevent unnecessary
3026 updates, but this is not very useful because the gconf notifications are
3027 so delays (maybe only on Maemo Bora).
3028 So auto-updating is turned off, and these functions do an explicit
3029 update when necessary.
3030 However, something else is still doing too much work when adding/removing
3031 accounts, probably in another part of the application.
3033 * src/maemo/modest-account-view-window.c:
3034 (on_delete_button_clicked), (on_edit_button_clicked),
3035 (on_new_button_clicked): Use the new functions.
3037 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3039 * src/modest-account-mgr-helpers.c:
3040 (modest_account_mgr_set_first_account_as_default):
3041 Sort the list of names alphabetically-by-title, so we choose the first one
3043 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3044 alphabetically by the title.
3046 This fixes projects.maemo.org bug NB#56418 .
3048 * src/modest-account-mgr-priv.c:
3049 (_modest_account_mgr_account_from_key):
3050 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3051 avoid a valgrind error, and possible random behaviour.
3053 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3055 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3056 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3057 tinymail documentation to say that this can be expected.
3058 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3059 pretty, and should not happen, but I would prefer to know when it does.
3061 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3063 * configure.ac: When using the older hildon version, probably on Bora,
3064 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3066 * src/widgets/modest-attachment-view.c:
3067 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3070 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3072 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3073 Implemented the prototype. Can be tested with
3074 tests/dbus_api/test_open_message:
3076 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3078 * src/modest-tny-account-store.c:
3079 (modest_tny_account_store_instance_init), (get_password):
3080 * src/modest-ui-actions.c:
3081 (modest_ui_actions_on_password_requested):
3082 Do not store the password in gconf, because this function is called
3083 for non-remembered passwords. Actually use the cached (in the hash map)
3084 password instead of releasing it.
3085 The password will now not be remembered if it is asked via the protected
3086 password dialog, as per the UI spec.
3088 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3090 * src/modest-defs.h:
3091 * src/modest-account-mgr-helpers.h:
3092 * src/modest-account-mgr-helpers.c:
3093 Added modest_server_account_get_username_has_succeeded(),
3094 modest_server_account_set_username_has_succeeded().
3095 (modest_server_account_set_username),
3096 Reset the has-succeeded flag if the username changes.
3098 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3099 * src/maemo/modest-connection-specific-smtp-window.c:
3100 (modest_connection_specific_smtp_window_save_server_accounts):
3101 Use modest_server_account_set_username() instead of using
3102 modest_conf_set_string() directly, so that the has-succeeded flag is always
3105 * src/modest-ui-actions.c:
3106 (modest_ui_actions_on_password_requested): Dim the username entry if
3107 the username has ever worked, as per the UI spec.
3109 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3111 * src/modest-tny-account-store.c: (get_password):
3112 * src/modest-ui-actions.c:
3113 (modest_ui_actions_on_password_requested):
3114 Allow the username to be changed too, though there is more work to
3115 be done on exactly how this behaves.
3117 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3119 * src/modest-account-mgr-helpers.h:
3120 * src/modest-account-mgr-helpers.c:
3121 Added modest_account_mgr_get_display_name(),
3122 modest_server_account_get_username(),
3123 modest_server_account_set_username(),
3124 modest_server_account_set_password(),
3125 modest_server_account_get_hostname() functions so we do not need to
3126 use the conf API directly.
3128 * src/maemo/modest-main-window.c: (connect_signals):
3129 Actually connect ot the ModestAccountStore::request-password signal,
3130 so that we show the dialog when the password is requested by Tinymail,
3131 for isntance if it is empty.
3133 * src/modest-marshal.list:
3134 * src/modest-tny-account-store.c:
3135 (modest_tny_account_store_class_init), (get_password),
3136 (modest_tny_account_store_alert):
3137 * src/modest-tny-account-store.h:
3138 * src/modest-ui-actions.h:
3139 * src/modest-ui-actions.c:
3140 (modest_ui_actions_on_password_requested):
3141 Change the signal parameters, so it is obvious that we are providing
3142 the non human-readable server name, and receiving both the username
3143 and password, though changing of the username is not yet implemented.
3144 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3145 for the GNOME version.
3147 This should fix the projects.maemo.org bug NB#56209, though it does not
3148 work on Bora, because the gconf_client_get() for the password fails
3149 immediately after we save it with gconf_client_set().
3151 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3154 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3155 caused an undefined symbol error:
3156 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3158 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3160 * src/modest-tny-account-store.c:
3161 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3162 using a GError instead of a string message, so we can translate it in
3165 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3167 * src/maemo/modest-address-book.c:
3168 (modest_address_book_check_names):
3169 * src/maemo/modest-msg-view-window.c:
3170 (modest_msg_view_window_clipboard_owner_change):
3171 * src/modest-init.c: (modest_init_init_ui):
3172 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3173 (update_folders_cb), (modest_mail_operation_update_account):
3174 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3175 (modest_ui_actions_on_msg_attachment_clicked),
3176 (modest_ui_actions_on_msg_recpt_activated):
3177 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3178 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3179 (modest_msg_view_search_next):
3180 * src/widgets/modest-recpt-editor.c:
3181 (modest_recpt_editor_on_button_release_event),
3182 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3183 g_message(). At this point we should only be seeing interesting errors on
3184 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3186 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3188 (modest_wizard_dialog_force_title_update):
3189 * src/maemo/easysetup/modest-wizard-dialog.h:
3190 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3191 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3192 can update the title when appropriate. Otherwise the title is wrong if the
3193 pages are added after adding the notebook to the dialog.
3194 This must be a problem in HildonWizardDialog too.
3195 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3197 * src/maemo/easysetup/modest-easysetup-wizard.c:
3198 (create_subsequent_customsetup_pages),
3199 (create_subsequent_easysetup_pages):
3200 Call modest_wizard_dialog_force_title_update() so that the title is
3201 correct even with GTK+ < 2.10.
3202 This fixes projects.maemo.org bug NB#56145 .
3204 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3206 * src/maemo/modest-platform.c:
3207 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3208 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3211 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3213 * src/widgets/modest-window.h:
3214 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3215 and modest_window_save_state(), which invokes it.
3217 * src/widgets/modest-window-mgr.h:
3218 * src/widgets/modest-window-mgr.c:
3219 Added modest_window_mgr_save_state_for_all_windows(), which calls
3220 the save_state vfunc on all registered windows, if implemented.
3222 * src/gnome/modest-msg-edit-window.c:
3223 * src/gnome/modest-msg-view-window.c:
3224 * src/maemo/modest-msg-edit-window.c:
3225 * src/maemo/modest-msg-view-window.c:
3226 * src/maemo/modest-main-window.c:
3227 Specify the existing save_settings functions as implementations of
3228 ModestWindow::save_state_func().
3230 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3231 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3232 enabling hibernation, for instance.
3234 We may need to do the same thing for restoring settings.
3237 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3239 * src/widgets/modest-window-mgr.c:
3240 * src/widgets/modest-window-mgr.h:
3241 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3242 modest_window_mgr_get_hibernation_is_prevented().
3244 * src/maemo/modest-main-window.c:
3245 (on_hildon_program_is_topmost_notify): Prevent hibernation
3246 (possible when the application goes to the background in the WM),
3247 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3249 * src/maemo/easysetup/modest-easysetup-wizard.c:
3250 (modest_easysetup_wizard_dialog_init):
3251 * src/maemo/modest-account-settings-dialog.c:
3252 (modest_account_settings_dialog_init):
3253 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3254 (modest_connection_specific_smtp_edit_window_init):
3255 * src/maemo/modest-connection-specific-smtp-window.c:
3256 (modest_connection_specific_smtp_window_init):
3257 * src/maemo/modest-signature-editor-dialog.c:
3258 (modest_signature_editor_dialog_init):
3259 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3260 prevent hibernation while any of these account settings dialogs are open.
3262 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3264 * src/maemo/Makefile.am:
3265 * src/maemo/modest-osso-state-saving.c:
3266 * src/maemo/modest-osso-state-saving.h: Added
3267 modest_osso_load_state() and modest_osso_save_state() though they do
3268 nothing now. They should iterate through all the open windows and load/save
3270 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3271 save state when closing.
3273 * src/maemo/modest-main-window.c:
3274 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3275 Add a notification handler for the HildonProgram::is-topmost property,
3276 so we can allow hibernation when the application goes into the background.
3277 But we still need to detect when the accounts setup windows are open so
3278 we can stop hibernation when they are open.
3279 To do this, I also added the main window the HildonProgram. This might have
3280 other side-effects/benefits, and should maybe be done for other windows.
3282 * src/maemo/modest-osso-autosave-callbacks.h:
3283 * src/maemo/modest-osso-autosave-callbacks.c:
3284 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3285 though it does not do anything yet, and we might never need this to do
3286 anything. For instance, we already save drafts.
3288 * src/maemo/modest-platform.c: (modest_platform_init):
3289 Specify the libosso auto-save callback.
3291 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3293 * src/maemo/modest-platform.c:
3294 (modest_platform_set_update_interval):
3295 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3296 aparently stays valid between application instances, so we can use this
3297 to remove and reset it later. According to a maemo-developers email from
3300 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3302 * configure.ac: Depend on libalarm for Maemo.
3304 * src/dbus_api/modest-dbus-api.h:
3305 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3306 (on_send_receive), (modest_dbus_req_handler):
3307 Handle a SEND_RECEIVE D-Bus method.
3309 * libmodest-dbus-client/libmodest-dbus-client.c:
3310 (libmodest_dbus_client_send_and_receive):
3311 * libmodest-dbus-client/libmodest-dbus-client.h:
3312 Add C convenience functions for calling the new D-Bus method.
3314 * src/modest-platform.h:
3315 * src/gnome/modest-platform.c:
3316 * src/maemo/modest-platform.c:
3317 Added modest_platform_set_update_interval(), which uses the
3318 alarmd API on Maemo.
3319 (modest_platform_init),
3320 Call modest_platform_set_update_interval(), using a hard-coded
3321 interval for now (until the global settings dialog is implemented),
3322 though I am not sure that this makes sense yet.
3324 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3326 * src/dbus_api/modest-dbus-callbacks.c:
3327 (modest_osso_cb_hw_state_handler):
3328 * src/dbus_api/modest-dbus-callbacks.h:
3329 * src/maemo/modest-platform.c: (modest_platform_init):
3330 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3331 in case this has some effect on the ability for Maemo to ping the
3334 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3336 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3337 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3338 warning. It is probably a logic error, but I need to fix the build.
3340 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3342 * src/modest-account-mgr.h:
3343 * src/modest-account-mgr.c:
3344 (modest_account_mgr_account_names): Add a gboolean enabled_only
3345 parameter, so we can get lists of onlt the enabled accounts.
3347 (modest_account_mgr_add_account),,
3348 (modest_account_mgr_account_with_display_name_exists):
3349 * src/maemo/modest-msg-edit-window.c: (get_transports):
3350 * src/modest-account-mgr-helpers.c:
3351 (modest_account_mgr_set_first_account_as_default):
3352 * src/modest-init.c: (init_default_account_maybe):
3353 * src/modest-tny-account-store.c: (get_accounts):
3354 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3355 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3356 * tests/check_account-mgr.c: (START_TEST):
3357 Provide the extra parameter, as appropriate.
3359 * src/widgets/modest-account-view.c: (update_account_view):
3360 Do not show disabled accounts (meaning that there is no way to
3361 enable/disable accounts in the UI (the feature is not in our UI
3362 specification), so we can use this internally only to mark unfinished
3363 or temporary account data.
3365 * src/maemo/easysetup/modest-easysetup-wizard.c:
3366 (create_account): Add boolean enable parameter, so we can specify FALSE
3367 to create the temporary account.
3368 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3369 (on_before_next): When finishing, when there is a temporary account, just
3371 Also, use a timeout to delay the showing of the dialog until gconf is likely
3372 to return correct information, due to a maemo gconf bug that is fixed in
3373 osso 1.1, but not yet in Bora.
3374 However, the dialog stays on screen after it is destroyed.
3376 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3377 for invalid data when cancelling. Use a hildon note instead of a dialog
3378 to complain about invalid data. Do not show the account-saved note if the
3379 account is disabled (a temporary account that will not really be saved for use
3382 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3384 * src/modest-account-mgr-helpers.h:
3385 * src/modest-account-mgr-helpers.c:
3386 Added modest_account_mgr_unset_default_account(),
3387 Added modest_account_mgr_set_first_account_as_default().
3389 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3390 If it was the default account, unset the default account name.
3392 * src/maemo/modest-account-view-window.c:
3393 (on_delete_button_clicked): If it was the default account,
3394 set the first remaining account as the default instead.
3396 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3397 a NULL account or a NULL default account, to prevent a crash. This should
3398 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3401 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3403 * src/widgets/modest-recpt-editor.c:
3404 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3405 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3406 TODO comment for this. This fixes the build.
3408 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3409 be the best place for it. This will in future update all auto-update accounts,
3410 rather than just the current/default account, when that gconf key exists.
3411 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3412 if there are no accounts, before calling do_send_receive().
3413 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3415 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3416 * src/maemo/modest-main-window-ui.h:
3417 * src/maemo/modest-main-window.c: (on_connection_changed),
3418 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3419 directly, becaue the signal handler does more.
3421 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3423 * src/modest-account-mgr-helpers.c:
3424 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3425 for the case that the account does not exist.
3427 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3428 (equivalent to the modest account name) rather than the tinymail account name
3429 (equivalent to the modest account title - human readable) to get the account data.
3430 Check for null account data to prevent the crash, and add a TODO comment saying that
3431 this needs fixing because it is using the server account name instead of the account name.
3433 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3435 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3436 * src/maemo/modest-account-settings-dialog.c: (show_error),
3438 Use hildon_note_new_information() for informative and error messages,
3439 which seems to be expected for Maemo applications (no documentation that I know of
3440 says this). I am surprised that there is no distinction between info and error
3443 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3445 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3446 it is easy to find where this is used.
3448 * src/maemo/easysetup/modest-easysetup-wizard.c:
3449 (create_page_welcome), (create_page_account_details),
3450 (create_page_user_details), (create_page_complete_easysetup),
3451 (create_page_custom_incoming), (create_page_custom_outgoing),
3452 (create_page_complete_custom):
3453 * src/maemo/modest-account-settings-dialog.c:
3454 (create_page_account_details), (create_page_user_details),
3455 (create_page_incoming), (create_page_outgoing):
3456 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3457 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3458 (modest_connection_specific_smtp_edit_window_init):
3459 * src/maemo/modest-connection-specific-smtp-window.c:
3460 (modest_connection_specific_smtp_window_init):
3461 * src/maemo/modest-signature-editor-dialog.c:
3462 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3463 and scrolling policy as per the Email Application Layout Guide, if I have
3466 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3468 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3469 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3470 which were empty, because these vfuncs have been removed from TnyAccountStore.
3471 This fixes the build.
3473 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3475 * src/maemo/modest-main-window.c:
3476 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3477 showing/hiding it. Added TODO because it probably should not be NULL.
3478 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3479 because unnecessary g_warnings() make degugging difficult.
3481 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3483 * src/maemo/modest-msg-edit-window.c:
3484 (modest_msg_edit_window_select_color),
3485 (modest_msg_edit_window_select_background_color): 2 const corrections and
3486 moving 2 #endifs before closing brackets, to fix the build.
3488 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3490 * src/maemo/easysetup/modest-easysetup-wizard.h:
3491 * src/maemo/easysetup/modest-easysetup-wizard.c:
3492 (modest_easysetup_wizard_dialog_finalize),
3493 (on_button_edit_advanced_settings), (create_page_complete_custom),
3494 (on_response), (create_account):
3495 Implement the Advanced Settings edit button, by saving the account information,
3496 for the Advanded Settings dialog to use directly from gconf, and removing it
3497 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3498 Bug #5533 in the projects.maemo.org bugzilla.
3500 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3502 * src/maemo/modest-msg-view-window.c:
3503 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3504 when opening a message window.
3506 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3508 * src/maemo/easysetup/modest-easysetup-wizard.c:
3509 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3512 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3513 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3514 gconf settings. I probably added more checks than necessary, but that is safer.
3516 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3517 variable to fix the build, but this seems to be used when it is still NULL.
3519 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3521 * src/modest-platform.h:
3522 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3523 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3524 * src/modest-main.c: Implement this function so we can avoid using
3525 maemo-specific API from cross-platform code.
3527 * src/modest-tny-account-store.c:
3528 (get_smtp_specific_transport_account_for_open_connection):
3529 * src/modest-ui-actions.c: (check_for_connection),
3530 (modest_ui_actions_on_item_not_found):
3531 Use modest_platform_connect_and_wait() and put #idefs around other
3532 maemo-specific code, because only maemo currently has a way to
3533 identify connection names.
3535 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3537 * src/modest-tny-account-store.h:
3538 * src/modest-tny-account-store.c:
3539 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3540 the connection-specific SMTP server settings in the configuration.
3542 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3544 * src/maemo/modest-main-window.c: (on_connection_changed),
3546 * src/modest-main.c: (main), (start_ui), (send_mail):
3547 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3548 that is what is intended.
3550 * src/modest-ui-actions.c: (action_send), (action_receive),
3551 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3552 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3553 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3554 SMTP server is used when it is specified.
3556 (modest_ui_actions_on_send_receive):
3557 Check that a connection is open before proceeding.
3558 Receive and then send, instead of vice-versa, as per the specification.
3560 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3562 * src/modest-mail-operation.c:
3563 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3564 though I guess it should be something other than NULL.
3566 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3568 * src/maemo/easysetup/modest-easysetup-wizard.c:
3569 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3570 combo twice, to avoid an g_warning and to make it visible again.
3571 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3572 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3573 (already intended) dereference when detaching, because we then recreate the menu.
3574 But I am not sure why the warning was happening, and it is possible that this is a memory
3577 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3579 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3580 and uri_parse_mailto() utility functions.
3581 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3583 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3585 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3587 * src/dbus_api/modest-dbus-api.h:
3588 * src/dbus_api/modest-dbus-callbacks.c:
3589 Use an idle callback to execute the modest code in the application's own thread.
3590 Remove the helloworld example method.
3591 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3592 parsed, and the open-message method is not implemented because this is not yet implemented in
3594 * libmodest-dbus-client/libmodest-dbus-client.c:
3595 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3596 (libmodest_dbus_client_open_message):
3597 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3599 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3600 body without crashing.
3602 * tests/dbus_api/Makefile.am:
3603 * tests/dbus_api/test_mail_to.c:
3604 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3606 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3608 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3609 Added file to fix the build. Sorry.
3611 * src/dbus_api/Makefile.am:
3612 * src/dbus_api/modest-dbus-api.h:
3613 * src/dbus_api/modest-dbus-callbacks.h:
3614 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3615 (modest_dbus_req_handler):
3616 Put constants in a separate header so it can be reused by the
3617 client library, without duplication
3619 * libmodest-dbus-client/Makefile.am:
3620 * libmodest-dbus-client/libmodest-dbus-client.c:
3621 (libmodest_dbus_client_call_helloworld),
3622 (libmodfest_dbus_client_send_mail),
3623 (libmodfest_dbus_client_mailto),
3624 (libmodfest_dbus_client_open_message):
3625 * libmodest-dbus-client/libmodest-dbus-client.h:
3626 (Partly) Implement a send_mail D-Bus method.
3628 * tests/dbus_api/Makefile.am:
3629 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3630 the send_email D-Bus method.
3632 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3636 * libmodest-dbus-client/Makefile.am:
3637 * libmodest-dbus-client/libmodest-dbus-client.c:
3638 * libmodest-dbus-client/libmodest-dbus-client.h:
3639 * tests/dbus_api/Makefile.am:
3640 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3641 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3643 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3645 * src/maemo/easysetup/modest-easysetup-wizard.c:
3646 (create_page_account_details):
3647 * src/maemo/modest-account-settings-dialog.c:
3648 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3649 widgets, because this might not be the default in future versions of the Maemo GTK+.
3650 However, I can not not get capitalization to work even in a simple test case.
3652 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3654 * src/maemo/easysetup/modest-easysetup-wizard.c:
3655 (create_page_custom_incoming), (create_page_custom_outgoing):
3656 * src/maemo/modest-account-settings-dialog.c:
3657 (create_page_account_details), (create_page_incoming),
3658 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3659 instead of using gtk_check_button_with_label(), so they are aligned like the other
3660 widgets, as per the UI spec.
3662 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3664 * src/maemo/easysetup/modest-easysetup-wizard.c:
3665 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3666 * src/widgets/modest-validating-entry.c:
3667 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3668 Modest prefix instead of an EasySetup prefix.
3670 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3672 * src/widgets/modest-validating-entry.h:
3673 * src/widgets/modest-validating-entry.c: (on_insert_text),
3674 Added easysetup_validating_entry_set_max_func(), used to set a callback
3675 to call when the max number of characters is reached. GtkEntry has a max-length
3676 already but is silent about it.
3678 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3679 (create_page_account_details), (create_page_user_details),
3681 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3682 (create_page_account_details), (create_page_user_details),
3683 (create_page_outgoing):
3684 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3685 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3686 the UI spec, when the user tries to enter more than the max number of characters.
3688 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3690 * src/maemo/easysetup/modest-easysetup-wizard.c:
3691 (create_page_user_details), (create_page_custom_incoming),
3692 (create_page_custom_outgoing):
3693 * src/maemo/modest-account-settings-dialog.c:
3694 (create_page_user_details), (create_page_incoming),
3695 (create_page_outgoing):
3696 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3697 (modest_connection_specific_smtp_edit_window_init):
3698 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3699 not appropriate. Bad Maemo-specific defaults!.
3701 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3703 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3704 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3705 (modest_signature_editor_dialog_set_settings):
3706 Disable the label and textview when the checkbox is disabled, and use the
3707 specified (UI spec) default signature text.
3709 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3711 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3712 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3714 * src/modest-defs.h:
3715 * src/modest-account-mgr-helpers.h:
3716 * src/modest-account-mgr-helpers.c:
3717 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3719 * src/maemo/Makefile.am:
3720 * src/maemo/modest-signature-editor-dialog.c:
3721 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3724 * src/maemo/modest-account-settings-dialog.h:
3725 * src/maemo/modest-account-settings-dialog.c:
3726 (modest_account_settings_dialog_finalize), (on_button_signature),
3727 (save_configuration): Use the new dialog when the Edit button is pressed, and
3728 save the changes if necessary, as per the UI spec.
3730 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3732 * src/maemo/Makefile.am:
3733 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3734 based on maemo-develoers email from Dirk.
3736 * src/maemo/easysetup/modest-easysetup-wizard.c:
3737 (create_page_welcome), (create_page_account_details),
3738 (create_page_user_details), (create_page_complete_easysetup),
3739 (create_page_custom_incoming), (create_page_custom_outgoing),
3740 (create_page_complete_custom),
3741 (modest_easysetup_wizard_dialog_init):
3742 * src/maemo/modest-account-settings-dialog.c:
3743 (create_page_account_details), (create_page_user_details),
3744 (create_page_incoming), (create_page_outgoing),
3745 (modest_account_settings_dialog_init):
3746 * src/maemo/modest-connection-specific-smtp-window.c:
3747 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3749 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3751 * src/maemo/easysetup/modest-easysetup-wizard.c:
3752 (create_page_account_details), (create_page_custom_outgoing),
3753 (create_page_complete_custom):
3754 * src/maemo/modest-account-settings-dialog.c:
3755 (create_page_user_details), (create_page_incoming),
3756 (create_page_outgoing):
3757 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3758 (modest_connection_specific_smtp_edit_window_init):
3759 Use the correct (UI spec) port min/max, and use horizontal separators,
3762 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3764 * src/maemo/easysetup/modest-easysetup-wizard.c:
3765 (set_default_custom_servernames):
3766 * src/maemo/modest-account-settings-dialog.c:
3767 (create_page_incoming), (on_combo_outgoing_security_changed),
3768 (on_combo_incoming_security_changed), (create_page_outgoing),
3769 (modest_account_settings_dialog_set_account_name),
3770 (save_configuration):
3771 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3772 (on_combo_security_changed),
3773 (modest_connection_specific_smtp_edit_window_init),
3774 (modest_connection_specific_smtp_edit_window_set_connection),
3775 (modest_connection_specific_smtp_edit_window_get_settings):
3776 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3779 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3782 * src/maemo/easysetup/modest-easysetup-wizard.c:
3783 (create_page_custom_outgoing), (create_page_complete_custom):
3784 * src/maemo/modest-account-settings-dialog.c:
3785 (create_page_user_details), (create_page_outgoing):
3786 * src/maemo/modest-account-view-window.c: (button_box_new):
3787 Use changed logical IDs as per the most recent UI spec:
3788 mcen_bd_emailsetup_edit -> mcen_bd_edit
3789 mcen_bd_emailsetup_delete -> mcen_bd_delete
3790 mcen_bd_emailsetup_close -> mcen_bd_close
3792 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3796 * src/dbus_api/Makefile.am:
3797 * src/dbus_api/modest-dbus-callbacks.c:
3798 * src/dbus_api/modest-dbus-callbacks.h:
3799 * src/maemo/modest-platform.c: (modest_platform_init):
3800 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3802 * tests/Makefile.am:
3803 * tests/dbus_api/Makefile.am:
3804 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3806 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3808 * src/maemo/modest-account-settings-dialog.c:
3809 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3810 Removed unnecessary includes.
3812 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3814 * src/maemo/easysetup/modest-easysetup-wizard.c:
3815 * src/maemo/modest-account-settings-dialog.c:
3816 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3817 * src/widgets/Makefile.am:
3818 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3819 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3820 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3821 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3822 * src/widgets/modest-secureauth-combo-box.c:
3823 * src/widgets/modest-secureauth-combo-box.h:
3824 * src/widgets/modest-serversecurity-combo-box.c:
3825 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3826 made the GObject names more consistent with the rest of the Modest code.
3828 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3830 * src/maemo/easysetup/Makefile.am:
3831 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3832 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3833 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3834 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3835 * src/maemo/easysetup/modest-easysetup-wizard.c:
3836 * src/maemo/easysetup/modest-validating-entry.c:
3837 * src/maemo/easysetup/modest-validating-entry.h:
3838 * src/maemo/modest-account-settings-dialog.c:
3839 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3840 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3841 widgets/ because they are used outside of easysetup too. After checking in,
3842 svn will allow me to rename them too.
3844 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3846 * src/gnome/modest-msg-edit-window.c:
3847 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3848 linker error, to fix the build on the GNOME platform.
3849 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3850 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3851 ifdefed out to avoid a warning.
3853 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3855 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3856 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3857 some alternative for GTK+ 2.6.
3859 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3861 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3863 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3864 specified for EmailAccountsDialog in UI spec.
3866 * src/maemo/easysetup/modest-easysetup-wizard.c:
3867 * src/maemo/easysetup/modest-easysetup-wizard.h:
3868 * src/maemo/modest-account-settings-dialog.c:
3869 * src/maemo/modest-account-settings-dialog.h:
3870 Reuse a member window widget for the connection-specific SMTP server accounts,
3871 so we can tell it to create/save the accounts only if we actually save changes.
3873 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3874 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3875 (modest_connection_specific_smtp_edit_window_get_settings):
3876 Return a struct instance for temporarily remembering the entered data.
3878 * src/maemo/modest-connection-specific-smtp-window.h:
3879 * src/maemo/modest-connection-specific-smtp-window.c:
3880 (modest_connection_specific_smtp_window_finalize),
3881 (modest_connection_specific_smtp_window_fill_with_connections),
3883 (modest_connection_specific_smtp_window_save_server_accounts),
3884 (update_model_server_names): Do not actually save data until asked,
3885 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3887 (on_selection_changed),
3888 (modest_connection_specific_smtp_window_init): Disable the edit
3889 button when nothing is selected.
3891 * src/modest-account-mgr-helpers.c:
3892 * src/modest-account-mgr-helpers.h:
3893 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3896 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3898 * src/modest-account-mgr-helpers.h:
3899 * src/modest-account-mgr-helpers.c:
3900 (modest_account_mgr_get_unused_account_name),
3901 (modest_account_mgr_get_unused_account_display_name): Added these
3902 utility functions, to avoid code duplication.
3904 * src/maemo/easysetup/modest-easysetup-wizard.c:
3905 (create_page_account_details), (create_account):
3906 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3907 (on_combo_security_changed),
3908 (modest_connection_specific_smtp_edit_window_init),
3909 (modest_connection_specific_smtp_edit_window_save_settings):
3910 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3911 * src/maemo/modest-connection-specific-smtp-window.c:
3912 (modest_connection_specific_smtp_window_finalize),
3913 (modest_connection_specific_smtp_window_fill_with_connections),
3914 (on_button_edit), (modest_connection_specific_smtp_window_init):
3915 * src/maemo/modest-connection-specific-smtp-window.h:
3916 Implementing saving of connection-specific server accounts.
3918 But I need to refactor this so we can save the data for each
3919 possible connection-specific account and only actually create the server accounts
3920 when the easysetup finished, or the OK button is pressed on the account settings
3923 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3925 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3926 (on_combo_security_changed):
3927 (modest_connection_specific_smtp_edit_window_init):
3928 Auto-fill the port number as in the account settings.
3930 (modest_connection_specific_smtp_edit_window_set_connection):
3931 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3932 * src/maemo/modest-connection-specific-smtp-window.c:
3933 (fill_with_connections), (on_button_edit),
3934 (modest_connection_specific_smtp_window_init):
3935 Turn the edit window into a dialog to simplify the code, and
3936 set a WM hint as in a GtkDialog, because only a popup can be on top of
3937 another window in Maemo, and popups usually have no WM decoration.
3939 * src/modest-defs.h:
3940 * src/modest-account-mgr-helpers.c:
3941 (modest_account_mgr_set_connection_specific_smtp),
3942 (modest_account_mgr_remove_connection_specific_smtp),
3943 (modest_account_mgr_get_connection_specific_smtp):
3944 * src/modest-account-mgr-helpers.h: Some functions to write the
3945 connection-specific SMTP server information. Not yet used.
3948 * src/widgets/modest-folder-view.c: (text_cell_data):
3949 Fix a warning about an uninitialized variable.
3950 (on_configuration_key_changed): Put an #ifdef around the use
3951 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3953 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3955 * src/maemo/modest-account-settings-dialog.h:
3956 * src/maemo/modest-account-settings-dialog.c:
3957 Added connect_for_modified() utility function to mark the new modified boolean.
3959 (create_page_account_details), (create_page_user_details),
3960 (create_page_incoming), (create_page_outgoing), (on_response),
3961 (modest_account_settings_dialog_init),
3962 (modest_account_settings_dialog_set_account_name):
3963 Only warn about unsaved changes when there are actually unsaved changes.
3965 * src/modest-account-mgr-helpers.c:
3966 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3967 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3968 to get the data from there in future.
3970 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3972 * src/modest-defs.h:
3974 * src/modest-account-mgr-helpers.h:
3975 * src/modest-account-mgr-helpers.c:
3976 Store the security account setting in a single conf key instead of using
3977 the options list, so that the list is left for just the to-be-removed camel hack,
3978 and because gconf_client_set_list() is failing for some reason.
3980 * src/modest-account-mgr.c:
3981 (modest_account_mgr_add_server_account):
3982 * src/maemo/modest-account-settings-dialog.c:
3983 (modest_account_settings_dialog_set_account_name),
3984 (save_configuration): Use the renamed functions.
3987 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3989 * src/widgets/Makefile.am:
3990 * src/widgets/modest-limit-retrieve-combo-box.c:
3991 * src/widgets/modest-limit-retrieve-combo-box.h:
3992 * src/widgets/modest-retrieve-combo-box.c:
3993 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3994 the account settings dialog.
3996 * src/modest-defs.h:
3997 * src/modest-account-mgr-helpers.h:
3998 * src/modest-account-mgr-helpers.c:
3999 (modest_server_account_get_option_secure_auth),
4000 (modest_server_account_set_option_secure_auth):
4001 * src/modest-account-mgr.c:
4002 (modest_account_mgr_add_server_account):
4003 Use the existing AUTH_MECH conf key for the secure-auth setting,
4004 instead of putting it in the list options, because this was actually used already.
4006 * src/maemo/modest-account-settings-dialog.c:
4007 (create_page_account_details),
4008 (modest_account_settings_dialog_set_account_name),
4009 (save_configuration):
4010 * src/maemo/modest-account-settings-dialog.h:
4011 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4012 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4014 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4016 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4017 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4018 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4020 * src/modest-defs.h:
4021 * src/maemo/modest-account-settings-dialog.c:
4022 (create_page_incoming), (on_combo_outgoing_security_changed),
4023 (on_combo_incoming_security_changed), (create_page_outgoing),
4024 (modest_account_settings_dialog_set_account_name),
4025 (save_configuration): Load/Save the port number, and change it when the
4026 security combo changes, to suitable defaults.
4028 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4030 * src/modest-account-mgr.c:
4031 (modest_account_mgr_add_server_account): Set the security and secure-auth
4032 options, and add a comment saying that the other camel-specific options should be
4035 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4037 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4039 * src/modest-tny-account-store.c: (account_list_free),
4040 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4041 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4044 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4046 * src/modest-protocol-info.c:
4047 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4048 is required by our UI spec. Maybe something in our implementation will use this eventually.
4049 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4050 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4051 instead of the previous 0 placeholder.
4053 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4054 secure-auth settings.
4055 * src/modest-account-mgr-helpers.h:
4056 * src/modest-account-mgr-helpers.c:
4057 (modest_server_account_data_get_option_secure_auth),
4058 (modest_server_account_set_option_secure_auth),
4059 (modest_server_account_data_get_option_security),
4060 (modest_server_account_set_option_security): Added this API for getting and setting the security
4061 and secure-auth settings.
4063 * src/maemo/modest-account-settings-dialog.h:
4064 * src/maemo/modest-account-settings-dialog.c:
4065 (modest_account_settings_dialog_finalize), (check_data),
4066 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4067 about changing titles.
4068 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4069 (save_configuration): Save the security and secure-auth settings.
4071 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4072 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4074 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4076 * src/modest-defs.h:
4077 * src/modest-account-mgr.c:
4078 (modest_account_mgr_add_server_account):
4079 Added and used defines for the options key and value pair strings,
4080 that are used so far, though they do not seem to correspond to anything in our
4081 UI specs or ModestProtocol enum.
4083 * src/modest-account-mgr-helpers.h:
4084 * src/modest-account-mgr-helpers.c:
4085 (compare_option_strings_for_name),
4086 (modest_server_account_data_get_option_value),
4087 (modest_server_account_data_get_option_bool),
4088 (modest_account_mgr_get_server_account_option):
4089 Added helper functions for parsing the options GSList.
4091 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4093 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4094 display name is based on the supplied account name.
4095 * src/modest-account-mgr.c:
4096 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4097 with an inefficient, but good-enough, implementation.
4099 * src/maemo/easysetup/modest-easysetup-wizard.c:
4100 (create_page_account_details), (on_before_next), (create_account):
4101 Check for existing display names rather than (non-user-visible) account names, and just
4102 create and set a unique account name at the end.
4104 * src/maemo/modest-account-settings-dialog.c:
4105 (modest_account_settings_dialog_init),
4106 (modest_account_settings_dialog_set_account_name),
4107 (create_page_incoming): Show the display name, instead of the account name.
4108 (on_response): Do some (not all) extra checks, as in the UI spec.
4109 (save_configuration): Save the display name if it was changed.
4111 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4113 * po/en_GB.po: Added needed logical ID and translation.
4114 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4115 (init_view): Made the is-default column clicking work.
4117 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4120 * src/maemo/easysetup/Makefile.am:
4121 * src/maemo/easysetup/modest-easysetup-wizard.c:
4122 (modest_easysetup_wizard_dialog_init):
4123 * src/maemo/easysetup/provider-data-test.keyfile:
4124 * src/maemo/easysetup/provider-data.keyfile:
4125 Moved the provider data file to the new modest-providers-data package and used it from there.
4127 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4129 * src/modest-local-folder-info.c:
4130 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4131 N_() was already used on the static strings, but this just marks it for translation without
4132 using the translation.
4134 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4136 * src/maemo/modest-account-settings-dialog.c:
4137 (create_page_incoming),
4138 (modest_account_settings_dialog_set_account_name):
4139 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4140 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4141 I will do this if nobody else gets there first.
4143 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4145 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4146 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4147 save the security stuff.
4149 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4151 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4152 Set the email address and user fullname, which I now see must be
4155 * src/maemo/modest-account-settings-dialog.h:
4156 * src/maemo/modest-account-settings-dialog.c:
4158 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4159 leave-on-server and authentication.
4160 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4163 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4166 * src/maemo/modest-account-settings-dialog.c:
4167 * src/maemo/modest-account-settings-dialog.h:
4168 Most (but not all) of the widgets are now present as specified by the UI spec.
4169 No changes are yet saved, and some details are not properly shown yet.
4171 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4173 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4175 * src/maemo/Makefile.am:
4176 * src/maemo/modest-account-settings-dialog.c:
4177 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4178 an existing account. Doesn't do much yet.
4180 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4181 Open the accounts settings dialog when Edit is clicked.
4183 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4185 * src/maemo/easysetup/Makefile.am:
4186 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4188 * src/maemo/easysetup/modest-easysetup-wizard.c:
4189 (modest_easysetup_wizard_dialog_init):
4190 Try to get the source directory from the build system,
4191 instead of hard-coding "./" into the source code, when opening our local
4192 copies of the configuration files.
4193 But this still fails when opening the wizard from the Accounts window,
4194 maybe because the working directory seems to change at runtime.
4195 So the wizard will fail the second time unless you copy the files into their
4196 proper locations - see the stdout warnings for the paths.
4198 (create_page_account_details),(on_before_next):
4199 Check for existing non-server accounts instead of server accounts,
4200 so the default account name is useful again, and to prevent trying to
4203 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4204 Show the wizard when New is clicked.
4206 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4207 (init_view): Show the column headers, and show the columns that are
4208 specified in the UI specs. However, something in Maemo's GTK+ prevents
4209 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4210 change the default account. This is despite unsetting the special properties.
4212 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4214 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4215 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4216 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4217 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4218 to make that clearer.
4219 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4221 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4223 * src/maemo/modest-account-view-window.c:
4224 (modest_account_view_window_init),
4225 (modest_account_view_window_new):
4226 Use the same buttons as specified in the
4227 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4228 the existing widgets, which never had a chance of working.
4229 Put the ModestAccountView treeview in a scrolled window.
4230 Do not repeat the initialization in both _init() and _new().
4232 * src/widgets/modest-account-view.c: (update_account_view):
4233 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4234 this widget and window shows no accounts.
4236 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4238 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4240 * src/maemo/easysetup/modest-easysetup-wizard.c:
4241 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4242 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4243 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4246 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4247 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4248 accounts exist yet, as in the UI spec.
4250 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4252 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4254 * src/maemo/Makefile.am:
4255 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4256 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4257 New window for editing connection-specific smtp details.
4258 Not fully implemented.
4260 * src/maemo/modest-connection-specific-smtp-window.c:
4261 (modest_connection_specific_smtp_window_finalize) :
4262 unref the tree model.
4263 (on_button_edit): Show the edit window.
4265 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4267 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4270 * src/maemo/Makefile.am:
4271 * src/maemo/modest-connection-specific-smtp-window.c:
4272 * src/maemo/modest-connection-specific-smtp-window.h:
4273 New window for showing the list of connections, for connection-specific
4274 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4275 * src/maemo/easysetup/modest-easysetup-wizard.c:
4276 (create_page_custom_outgoing): Show the new window when the button is clicked.
4278 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4280 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4281 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4282 * src/maemo/modest-msg-edit-window.c:
4283 (modest_msg_edit_window_insert_image):
4284 * src/modest-conf.c: (modest_conf_key_escape):
4285 * src/modest-mail-operation.c:
4286 (modest_mail_operation_send_new_mail):
4287 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4288 (modest_ui_actions_on_new_account):
4289 * src/widgets/modest-attachment-view.c: (update_filename_request):
4290 * src/widgets/modest-mail-header-view.c:
4291 Corrected warnings that were breaking the build, by commenting out unused variables,
4292 and a function, and by including a header.
4294 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4296 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4297 so we can #ifdef around platform-specific code when necessary.
4298 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4299 to allow this to build for the GNOME platform too.
4301 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4303 * src/maemo/easysetup/modest-easysetup-wizard.c:
4304 Added util_increment_name() and used it in create_page_account_details()
4305 to make sure that the default account name is always a new name.
4307 (modest_easysetup_wizard_dialog_init),
4308 (set_default_custom_servernames): Some minor memory management fixes.
4310 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4314 * src/modest-runtime.c: (init_i18n): Restored the translation
4315 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4316 are defined in config.h, and the translations are installed.
4318 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4319 is defined for translation.
4321 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4323 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4325 * src/maemo/easysetup/modest-easysetup-wizard.c:
4326 (modest_easysetup_wizard_dialog_init):
4327 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4328 Use realistic paths (though they should use $prefix generically) to the
4329 mcc_mapping and provider-data.keyfile files which might work when they
4330 are installed by the future version of the operator-wizard package,
4331 and then fallback to paths in our source code, with an explanatory
4334 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4338 * src/maemo/Makefile.am:
4339 * src/maemo/easysetup/: Added files from the previously-exernal
4340 osso-modest-easysetup.
4341 * src/maemo/modest-main-window-ui.h:
4342 * src/modest-ui-actions.c:
4343 * src/modest-ui-actions.h:
4344 Added modest_ui_actions_on_new_account() as a signal handler for the
4345 New Account menu item. It shows the easysetup wizard.
4346 * po/en_GB.po: Added additional needed logical IDs and translations.