1 2007-06-25 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
4 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
5 GTK_ICON_SIZE_DIALOG is probably the wrong size.
7 2007-06-25 Murray Cumming <murrayc@murrayc.com>
9 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
10 that is an empty string. D-Bus seems to give us these instead of NULL.
12 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
14 * src/dbus_api/modest-dbus-callbacks.c:
15 * src/maemo/easysetup/modest-easysetup-wizard.h:
16 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
17 * src/maemo/modest-connection-specific-smtp-edit-window.c:
18 (modest_connection_specific_smtp_edit_window_init):
19 * src/maemo/modest-maemo-global-settings-dialog.c:
21 * src/maemo/modest-maemo-utils.c:
22 (modest_maemo_utils_setup_images_filechooser):
23 * src/maemo/modest-main-window.c: (create_details_widget):
24 * src/maemo/modest-msg-edit-window.c:
25 (modest_msg_edit_window_attach_file_noninteractive),
26 (modest_msg_edit_window_color_button_change),
27 (modest_msg_edit_window_set_zoom):
28 * src/modest-mail-operation.c: (update_account_thread):
29 * src/modest-tny-account-store.c:
30 * src/modest-tny-account.c:
31 * src/widgets/modest-global-settings-dialog.c:
32 * src/widgets/modest-window.h:
36 2007-06-25 Murray Cumming <murrayc@murrayc.com>
38 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
39 * src/modest-search.c: (modest_search_folder),
40 (modest_search_all_accounts): Actually search only in the specified folder,
41 doing a simple match on the folder ID.
42 * src/modest-search.h: Added a folder field to the ModestSearch struct,
43 and added some documentation.
45 2007-06-22 Armin Burgmeier <armin@openismus.com>
47 * src/maemo/modest-maemo-utils.h:
48 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
49 modest_maemo_utils_get_supported_secure_authentication_methods.
51 * src/maemo/easysetup/modest-easysetup-wizard.c:
52 * src/maemo/modest-account-settings-dialog.c: Show correct error if
53 one occured, not just "Server does not support secure authentication".
55 2007-06-22 Murray Cumming <murrayc@murrayc.com>
57 * src/modest-tny-account-store.c: (get_password):
58 Restored the call to tny_account_set_user() because Philip seems to have
59 stopped this from crashing (by not using the freed string). It still does
60 not work, but now we can test it.
62 2007-06-22 Murray Cumming <murrayc@murrayc.com>
64 * src/maemo/modest-msg-edit-window.c: (init_window):
65 Comment out use of an uninitialzed GtkScrolledWindow variable,
66 to fix the build and stop a crash. Yet again.
68 2007-06-22 Murray Cumming <murrayc@murrayc.com>
70 * src/modest-tny-account-store.c: (get_password):
71 Remove the call to tny_account_set_user() because this actually crashes.
72 As mentioned in the last commit, it is known to not work anyway.
74 2007-06-22 Murray Cumming <murrayc@murrayc.com>
76 * src/modest-tny-account-store.c: (get_password):
77 Use tny_account_set_username() to tell tinymail that the username might
78 have changed too. But tinymail ignores this: see projects.maemo.org
80 * src/modest-ui-actions.c:
81 (modest_ui_actions_on_password_requested): Remove the useless attempt to
82 reset the connection when changing the username, and improve the comments.
83 Save the changed username to gconf at least, so it is used when Modest is
86 2007-06-21 Murray Cumming <murrayc@murrayc.com>
88 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
89 Do not use a query, so that we get all folders, including for POP and
90 local-folders. They work as search criteria too.
91 This fixes projects.maemo.org bug NB#57740.
93 2007-06-21 Murray Cumming <murrayc@murrayc.com>
95 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
96 Comment out the use of hildon_notification_set_sound() because it is
97 not declared, to fix the build. Warnings are serious, people.
99 2007-06-21 Armin Burgmeier <armin@openismus.com>
101 * src/maemo/modest-maemo-utils.h:
102 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
103 modest_maemo_utils_get_supported_secure_authentication_methods()
104 to query authentication methods for a specific user. This should fix
105 projects.maemo.org bug NB#61369.
107 * src/maemo/easysetup/modest-easysetup-wizard.c:
108 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
111 2007-06-21 Murray Cumming <murrayc@murrayc.com>
113 * libmodest-dbus-client/libmodest-dbus-client.h:
114 * libmodest-dbus-client/libmodest-dbus-client.c:
115 (modest_dbus_message_iter_get_search_hit),
116 (libmodest_dbus_client_search):
117 Reorganised and commented this.
118 Removed modest_search_hit_free() from the public API because it
121 Added libmodest_dbus_client_get_folders() and
122 modest_folder_result_list_free().
124 * src/dbus_api/modest-dbus-api.h:
125 * src/dbus_api/modest-dbus-callbacks.c:
126 (modest_dbus_req_filter): Commented. Moved most code to
127 on_dbus_method_search() and added on_dbus_method_get_folders().
129 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
130 of the extra D-Bus handler.
132 * tests/dbus_api/Makefile.am:
133 * tests/dbus_api/test_get_folders.c: New test for
134 libmodest_dbus_client_get_folders(). This seems to return an empty list
135 at the moment. That could be the same error that causes the message list
136 to be empty sometimes.
137 This should help with projects.maemo.org bug NB#57740.
139 2007-06-21 Armin Burgmeier <armin@openismus.com>
141 * src/modest-mail-operation.c: Do not call
142 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
143 notify the operation's end after having set the status to CANCELED for
144 the operation queue to listen on. This fixes a deadlock when there
145 were mail operations in the queue during its finalization.
147 * src/modest-singletons.c: Reordered uninitialization of the account
148 manager to happen after the mail operation queue was uninitialized
149 because the mail operation's in the queue might still try to access
150 the account manager (see modest_mail_operation_notify_end()). This
151 fixes a potential crash when terminating the application.
153 2007-06-21 Murray Cumming <murrayc@murrayc.com>
155 * src/modest-search.c:
156 (search_mime_part_and_child_parts): Moved some code here so we
157 can search recursively in child folders.
158 (modest_search_folder): Search in the message as a mime part, instead
159 of just its child mime parts.
160 (read_chunk), (search_mime_part_ogs):
161 Check how many bytes were read, to prevent an endless loop.
162 Searching in message bodies now works. This finishes the fix for
163 projects.maemo.org bug NB#61007.
165 2007-06-20 Murray Cumming <murrayc@murrayc.com>
167 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
168 Add a g_warning when the item is not a folder.
170 * src/modest-ui-dimming-rules.c:
171 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
172 when selected item is not a folder (for instance, an account), because
173 the UI spec only talks about folders.
174 I am not sure what the UI spec wants, so this might not totally fix
175 projects.maemo.org bug NB#60794.
177 2007-06-20 Murray Cumming <murrayc@murrayc.com>
179 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
180 (load_from_file): Sort the list. The unsorted list would be more noticeable
181 in non-English locales.
183 * src/maemo/modest-msg-edit-window.c:
184 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
185 warning and fix the build.
187 * src/maemo/modest-progress-bar-widget.c:
188 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
189 avoid a g_warning, and probably to avoid a crash.
191 2007-06-20 Murray Cumming <murrayc@murrayc.com>
193 * src/modest-search.c: (modest_search_folder): Check for a GError
194 when calling tny_folder_get_headers(), to show that this is not the cause
197 2007-06-20 Murray Cumming <murrayc@murrayc.com>
199 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
200 Actually set the body query instead of the subject query.
202 * src/modest-search.c: (search_mime_part_ogs),
203 (search_mime_part_strcmp): Remove extra space from the text/* regex,
204 which would probably cause it to fail if we got this far.
206 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
207 to simplify the code.
208 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
209 be causing search-in-body to fail.
211 2007-06-20 Murray Cumming <murrayc@murrayc.com>
213 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
215 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
216 Better debug message when the folder cannot be found.
217 This should help with fixing projects.maemo.org bug #61287.
218 * src/modest-search.c: (add_hit): Do not leak the furl string.
220 2007-06-20 Murray Cumming <murrayc@murrayc.com>
222 * src/modest-ui-actions.c:
223 (modest_ui_actions_on_folder_selection_changed):
224 Do not special-case TNY_MERGE_FOLDER here, because
225 modest_tny_folder_get_account() already does that. This fixes
226 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
227 shown when the Outbox was selected).
229 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
231 * libmodest-dbus-client/libmodest-dbus-client.c:
232 (_dbus_iter_get_string_or_null): Initialize the string variable in
233 case this helps with Dirk's crash.
235 2007-06-19 Murray Cumming <murrayc@murrayc.com>
237 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
238 though it is not implemented yet (this function is maybe not even used),
239 to avoid breaking ABI in future.
240 * libmodest-dbus-client/libmodest-dbus-client.c:
241 (get_attachments_string): Moved some code into this generic function.
242 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
243 sends email. It is maybe not used.
244 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
245 (on_send_mail): Use attachments.
247 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
248 * src/maemo/modest-msg-edit-window.c:
249 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
250 a filename before using it, to fix projects.maemo.org bug NB#58233.
252 2007-06-19 Murray Cumming <murrayc@murrayc.com>
254 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
255 Initialize the continue_download variable to fix the build, and probably
256 to fix randome behaviour.
258 2007-06-18 Armin Burgmeier <armin@openismus.com>
260 * src/modest-tny-send-queue.h:
261 * src/modest-tny-send-queue.c: Keep track of the status of messages in
262 the queue so we can later show it in the UI. Replaced
263 modest_tny_send_queue_msg_is_being_sent() by
264 modest_tny_send_queue_get_msg_status().
266 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
268 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
269 gpointer. This probably was not harmful, but just to be sure.
271 2007-06-18 Murray Cumming <murrayc@murrayc.com>
273 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
274 Fix the build, but leave the function broken on Bora, because
275 hildon_uri_action_get_service() does not exist.
276 osso_uri_action_get_service() does not exist either, it seems.
278 2007-06-18 Murray Cumming <murrayc@murrayc.com>
280 * src/modest-tny-account.c:
281 (modest_tny_account_new_from_server_account):
282 Uncommented the url debug output again, because it is useful for
283 debugging, as I said in the comment.
285 2007-06-18 Murray Cumming <murrayc@murrayc.com>
287 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
289 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
290 for Mameo Bora, to fix the build.
292 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
295 Fixed build with hildon < 0.99
297 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
298 Check if the selected account is busy instead of checking all accounts
300 * src/modest-account-mgr-priv.h:
301 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
302 (modest_account_mgr_init), (compare_account_name),
303 (modest_account_mgr_set_account_busy),
304 (modest_account_mgr_account_is_busy):
305 * src/modest-account-mgr.h:
306 Added busy information to the account manager. It possible to
307 set an account to busy or not busy now.
309 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
310 (modest_mail_operation_update_account),
311 (modest_mail_operation_notify_end):
312 Set the account to busy/not busy depending on the operation state.
314 * src/widgets/modest-account-view.c:
315 (modest_account_view_finalize), (get_last_updated_string),
316 (update_account_view), (on_account_busy_changed), (init_view):
317 Show string "Refreshing..." if the account is currently busy.
319 All this fixes projects.maemo.org bug NB#59711
321 2007-06-14 Armin Burgmeier <armin@openismus.com>
323 * src/widgets/modest-attachments-view.h:
324 * src/widgets/modest-attachments-view.c: Added
325 modest_attachments_view_has_attachments() and fixed coordinate
326 transformation in get_att_view_at_coords(). This fixes attachment
329 * src/widgets/modest-msg-view.c: Make use of
330 modest_attachments_view_has_attachments() to decide whether to show
331 attachments in the header.
333 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
335 * src/maemo/modest-connection-specific-smtp-edit-window.c:
336 (on_change), (on_combo_security_changed),
337 (modest_connection_specific_smtp_edit_window_init),
338 (modest_connection_specific_smtp_edit_window_set_connection),
339 (modest_connection_specific_smtp_edit_window_is_dirty):
340 * src/maemo/modest-connection-specific-smtp-edit-window.h:
341 * src/maemo/modest-connection-specific-smtp-window.c:
344 Show an comfirmation dialog for the smpt-edit-window if there are
345 unsaved changes and the user hits cancel.
346 (projects.maemo.org bug NB#60479)
348 2007-06-14 Armin Burgmeier <armin@openismus.com>
350 * src/maemo/easysetup/modest-easysetup-wizard.c:
351 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
352 address" info in banner instead of node, and select all the text as
353 per UI spec. This fixes projects.maemo.org bug NB#60550.
355 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
357 reviewed by: <delete if not using a buddy>
359 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
360 * src/modest-ui-actions.c: (folder_refreshed_cb):
362 2007-06-14 Murray Cumming <murrayc@murrayc.com>
364 * src/widgets/modest-folder-view.c: (filter_row):
365 Explictly filter out the per-account outbox accounts. I don't know why
366 these only sometimes show up, but now they should never show up in the UI.
367 This should fix projects.maemo.org bug NB#60160.
369 2007-06-14 Murray Cumming <murrayc@murrayc.com>
371 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
372 when the toolbar does not exist yet.
373 * src/modest-widget-memory.c: (save_settings_header_view):
374 Added g_warnings() to help us to discover when we are trying to set
375 an empty columns list in gconf.
377 2007-06-14 Murray Cumming <murrayc@murrayc.com>
381 Added modest_init_get_default_header_view_column_ids().
383 * src/modest-widget-memory.c: (restore_settings_header_view):
384 Use the new function to get defaults, if the gconf key is empty,
385 instead of not creating any columns. This seems to fix the
386 empty right-hand pane problems.
388 * src/widgets/modest-header-view.h: Improved documentation.
390 2007-06-13 Murray Cumming <murrayc@murrayc.com>
392 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
393 Revert the use of the display name as the account name, because this
394 is generally wrong and would break the code that follows.
396 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
398 * src/maemo/easysetup/modest-easysetup-wizard.c:
399 (check_for_supported_auth_methods), (on_before_next),
402 More correct fix for projects.maemo.org bug NB# 58991
403 Do not longer accept AUTH_PASSWORD as secure method and choose
404 correct method when creating the account.
406 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
408 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
409 Fixed projects.maemo.org bug NB# 58991
411 2007-06-13 Murray Cumming <murrayc@murrayc.com>
413 * src/modest-init.c: (modest_init_init_core),
414 (modest_init_local_folders): Fixed compilation errors.
416 2007-06-13 Murray Cumming <murrayc@murrayc.com>
418 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
419 Remove unnecessary lib/include, though it is good in principle when needed.
421 * src/modest-init.c: (modest_init_one_local_folder),
422 (modest_init_local_folders):
423 * src/modest-init.h: Initialize the .modest library for memory cards,
424 instead of just doing nothing for them. This should allow us to create
425 folders there, fixing projects.maemo.org bug NB#59297.
427 2007-06-13 Murray Cumming <murrayc@murrayc.com>
429 * libmodest-dbus-client/libmodest-dbus-client.c:
430 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
431 (libmodest_dbus_client_compose_mail),
432 (libmodest_dbus_client_open_message),
433 (libmodest_dbus_client_send_and_receive),
434 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
436 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
437 (on_idle_open_message), (modest_dbus_req_handler),
438 (search_result_to_message), (modest_dbus_req_filter):
439 * src/modest-search.c: (add_hit), (modest_search_folder),
440 (modest_search_all_accounts): Improved debug messages.
442 * tests/dbus_api/test_open_message.c: (main): Improved comments.
444 * src/modest-tny-account-store.c:
445 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
448 2007-06-13 Murray Cumming <murrayc@murrayc.com>
451 2007-06-12 Murray Cumming <murrayc@murrayc.com>
453 * src/modest-tny-account-store.c: (get_server_accounts):
454 Call modest_tny_local_folders_account_add_merged_outbox_folders()
455 even when there are no accounts, so that the Outbox folder is always
456 visible. This fixes projects.maemo.org bug NB#60158.
458 2007-06-12 Murray Cumming <murrayc@murrayc.com>
460 * src/maemo/modest-main-window.c: (create_details_widget):
461 Use the mcen_va_never logical ID.
463 2007-06-12 Murray Cumming <murrayc@murrayc.com>
465 * src/dbus_api/modest-dbus-api.h:
466 * src/dbus_api/modest-dbus-callbacks.c:
467 (on_idle_open_default_inbox), (on_open_default_inbox),
468 (modest_dbus_req_handler):
469 Added a new OpenDefaultInbox method.
471 * libmodest-dbus-client/libmodest-dbus-client.h:
472 * libmodest-dbus-client/libmodest-dbus-client.c:
473 Added libmodest_dbus_client_open_default_inbox() to call the new
474 dbus method. This should be useful to projects.maemo.org bug NB#57214,
475 though it should maybe be used by a new osso-email-interface function.
477 * tests/dbus_api/Makefile.am:
478 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
481 2007-06-12 Murray Cumming <murrayc@murrayc.com>
483 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
484 NULL, so that the signals get all the keys. This should not actually
485 change any behaviour because we currently update everything when anything
488 2007-06-12 Murray Cumming <murrayc@murrayc.com>
490 * src/widgets/modest-folder-view.c: (text_cell_data),
491 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
492 (find_inbox_iter): If tinymail tells us that the folder is
493 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
494 This causes the inbox to be selected at startup, fixing part of
495 projects.maemo.org bug NB#56305.
497 * src/modest-ui-dimming-rules.c:
498 (modest_ui_dimming_rules_on_tools_smtp_servers):
499 * src/modest-ui-dimming-rules.h: Added a callback function to dim
500 the SMTP servers menu item.
501 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
502 that the SMTP Servers menu item is dimmed when there are no accounts,
503 as a future version of the UI spec will require. This fixes
504 projects.maemo.org bug NB#56305.
506 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
508 * src/maemo/modest-maemo-utils.c:
509 (modest_maemo_utils_get_supported_secure_authentication_methods):
510 Added label to dialog instead of unreadable title
512 * src/maemo/modest-main-window.c: (sync_accounts_cb),
513 (modest_main_window_new):
514 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
517 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
518 * src/modest-account-mgr.h:
519 Added method to avoid code duplication
521 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
522 (modest_ui_actions_on_send_receive):
523 Use modest_account_mgr_has_accounts
525 2007-06-11 Murray Cumming <murrayc@murrayc.com>
527 * src/maemo/easysetup/modest-presets.c:
528 (modest_presets_get_info_server_security): Do not report secure auth
530 * src/modest-protocol-info.c: Use the defines for the gconf key names
531 for secure authentication. This was not working because we were writing
532 Password and reading password, and the check was case sensitive.
533 With this, gmail now works for receiving and sending when created via
536 2007-06-11 Murray Cumming <murrayc@murrayc.com>
538 * src/maemo/easysetup/modest-presets.c:
539 (modest_presets_get_info_server_security): Correct the key name for
540 SecureSmtp, because it seems to be case-sensitive.
541 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
542 Do not try to get the 0th notebook page if there are 0 pages, to
545 2007-06-11 Murray Cumming <murrayc@murrayc.com>
547 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
548 Prevent use of the new notification feature for now, because it currently
549 shows one dialog for each new email, which is annoying.
551 2007-06-11 Murray Cumming <murrayc@murrayc.com>
553 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
554 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
555 when no country was selected, so that we show the global ones.
556 * src/maemo/easysetup/modest-presets.c:
557 (modest_presets_get_providers): Return only the global providers, not
558 all providers when mmc=0 was requested.
560 2007-06-11 Murray Cumming <murrayc@murrayc.com>
562 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
563 (easysetup_provider_combo_box_fill): Remove debug code that showed the
564 provider ID in the combo.
566 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
567 Do not show the page numbers, because it would be confusing when we add
568 the 2 extra pages for the custom setup, when the user chooses the "Other"
569 provider. This fixes projects.maemo.org bug NB#59028
571 * src/modest-init.c: (modest_init_init_core),
572 (modest_init_local_folders):
574 * src/modest-tny-account.c:
575 (modest_tny_account_new_for_local_folders): Do not create default folders
576 for the memory card. This should fix projects.maemo.org bug NB#59328.
578 2007-06-11 Murray Cumming <murrayc@murrayc.com>
580 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
581 Free the changed_conf_keys string items. They are already freed in the
582 idle handler if that runs first.
584 2007-06-11 Murray Cumming <murrayc@murrayc.com>
586 * src/modest-ui-actions.c:
587 (modest_ui_actions_on_password_requested): Check that the server name
588 is not NULL, because I just saw a password dialog with (null) as the
591 * src/modest-tny-folder.[h|c]: Added
592 modest_tny_folder_is_memory_card_folder().
593 * src/modest-ui-dimming-rules.c:
594 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
595 menu item for memory cards, as per the UI spec (section 7.4). This should
596 fix projects.maemo.org bug NB#59297.
598 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
600 * src/maemo/modest-main-window.c: (sync_accounts_cb):
601 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
602 is another problem with the code, see Murray's comment at line 772)
604 2007-06-08 Murray Cumming <murrayc@murrayc.com>
606 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
607 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
608 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
609 (load_from_file), (easysetup_country_combo_box_init),
610 (easysetup_country_combo_box_get_active_country_ids),
611 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
612 instead of just one ID, to avoid duplicate country names in the UI.
614 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
615 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
616 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
617 a single ID, avoiding duplicate providers.
618 * src/maemo/easysetup/modest-easysetup-wizard.c:
619 (on_combo_account_country): Adapt to use a list.
621 2007-06-08 Murray Cumming <murrayc@murrayc.com>
623 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
624 keys changed in the last X seconds.
626 * src/modest-account-mgr.h:
627 * src/modest-account-mgr.c: (on_timeout_notify_changes),
628 (on_key_change), (modest_account_mgr_class_init),
629 (modest_account_mgr_init), (modest_account_mgr_finalize):
630 As the keys are changed, save them in a GSList* and signal that GSList*
631 further every X seconds, to batch changes, to allow us to do just one
632 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
633 bug NB#56941 and other (UI-blocking) delays when changing account settings.
635 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
636 changed signal signature.
638 * src/modest-conf.c: (modest_conf_set_list),
639 (modest_conf_on_change): Reenable notification.
641 (modest_conf_maemo_fake_on_change): Comment out the hack that
642 notified immediately instead of asynchronously.
644 * src/widgets/modest-account-view.h:
645 * src/widgets/modest-account-view.c:
646 (update_account_view): Select the previously-selected account ID,
647 if possible. This fixes projects.maemo.org bug NB#56933.
649 (on_account_changed), (on_account_removed),
650 (modest_account_view_select_account):
652 Remove the block/unblock functions
653 because they were not useful.
655 * src/maemo/modest-account-view-window.c:
656 (on_delete_button_clicked), (on_edit_button_clicked),
657 (on_new_button_clicked): Remove the use of the non-working block/unblock.
659 2007-06-08 Murray Cumming <murrayc@murrayc.com>
661 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
662 Improve the error dialog to show Incorrect Account Settings, which seems
663 clearer, and say that the internal error message (to be removed from the
664 dialog later) is often misleading.
665 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
667 * src/modest-tny-account.c:
668 (modest_tny_account_new_from_server_account): Uncomment the printf of the
669 URL because this is so useful for debugging on the device.
671 * src/widgets/modest-serversecurity-combo-box.c:
672 (modest_serversecurity_combo_box_fill): Correct a logical ID.
674 2007-06-08 Murray Cumming <murrayc@murrayc.com>
676 * src/modest-mail-operation.c:
677 (modest_mail_operation_send_new_mail):
678 Added a comment about a nasty but apparently harmless message. Details
679 added to the wiki g_warnings() page.
681 2007-06-08 Murray Cumming <murrayc@murrayc.com>
683 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
684 (modest_tny_send_queue_class_init):
685 Do not use the priv struct because it is empty, to avoid g_warnings
686 about a non-existant priv struct.
688 * src/modest-tny-account-store.c:
689 (modest_tny_account_store_get_server_account),
690 (modest_tny_account_store_get_transport_account_for_open_connection
691 ): Do not try to get transport server accounts for local folders,
692 because they don't have any. This avoids a g_warning().
694 * src/maemo/modest-main-window.c:
695 (modest_main_window_notify_send_receive_initied),
696 (on_configuration_key_changed):
697 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
699 * src/modest-mail-operation.c:
700 (modest_mail_operation_update_account):
701 * src/modest-tny-account-store.h:
702 * src/modest-tny-account.c:
703 (modest_tny_account_get_special_folder),
704 (modest_tny_account_new_for_local_folders),
705 (modest_tny_account_new_for_per_account_local_outbox_folder):
706 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
707 * src/modest-tny-local-folders-account.c:
708 (add_account_folders_to_merged_folder):
709 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
710 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
711 (modest_ui_actions_on_send):
712 * src/widgets/modest-folder-view.c: (update_model):
713 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
714 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
715 modest_tny_account_store_get_tny_account_by_account() to
716 modest_tny_account_store_get_server_account() to make the code clearer.
718 2007-06-07 Marcus Bauer <marcusb@openismus.com>
720 * src/dbus_api/modest-dbus-api.h:
721 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
722 * src/maemo/modest-msg-edit-window.c:
723 (modest_msg_edit_window_attach_file_noninteractive):
724 added g_warning in case the file to be attached does not exist
725 * tests/dbus_api/test_compose_mail.c: (main):
726 removed obsolete comment, added generic files as test case
728 2007-06-07 Murray Cumming <murrayc@murrayc.com>
730 * src/modest-tny-account-store.c: (get_server_accounts):
731 Create the local folders account only once, not once for each outbox, and
732 not only when there are some outboxes.
734 2007-06-07 Murray Cumming <murrayc@murrayc.com>
736 * src/widgets/modest-folder-view.c: (update_model): Comment out some
737 code that is causing a crash at startup. Sergio says that he is fixing this.
739 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
741 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
742 * src/maemo/modest-account-settings-dialog.c:
743 (create_page_outgoing),
744 (modest_account_settings_dialog_set_account_name),
745 (save_configuration):
746 - Fixed handling of the "Use secure authentication" toggle to comply with
747 the ui specification. See also projects.maemo.org bug NB#58400
749 - Restore the Secure connection setting combo correctly when loading
752 * src/maemo/modest-maemo-utils.c:
753 (on_camel_account_get_supported_secure_authentication),
754 (modest_maemo_utils_get_supported_secure_authentication_methods):
755 Fixed a crasher if operation is canceled
757 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
758 (modest_protocol_info_auth_is_secure):
759 * src/modest-protocol-info.h:
761 Added two new methods to determine if a protocol/auth method is secure/encrypted in
762 the sense of the "Use secure authentication" toggle.
764 2007-06-07 Murray Cumming <murrayc@murrayc.com>
766 * src/modest-tny-account-store.h:
767 * src/modest-tny-account-store.c:
768 Added modest_tny_account_store_get_local_folders_account().
770 * src/modest-tny-folder.h:
771 * src/modest-tny-folder.c:
772 (modest_tny_folder_get_account):
773 Added this replacement for tny_folder_get_account() which returns
774 the local-folders account for TnyMergeFolders, to avoid the
775 warning about the unimplemented get_account_func() vfunc().
777 (modest_tny_folder_get_rules),
778 * src/modest-ui-actions.c:
779 (modest_ui_actions_on_folder_selection_changed):
780 * src/modest-mail-operation.c:
781 (modest_mail_operation_remove_folder),
782 (modest_mail_operation_xfer_folder),
783 (modest_mail_operation_rename_folder),
784 (modest_mail_operation_get_msg),
785 (modest_mail_operation_get_msgs_full),
786 (modest_mail_operation_remove_msg),
787 (modest_mail_operation_xfer_msgs),
788 (modest_mail_operation_refresh_folder):
789 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
791 2007-06-07 Murray Cumming <murrayc@murrayc.com>
793 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
794 (modest_server_account_set_security):
795 * src/modest-defs.h: Add comments explaining that our
796 UI spec means TLS when it says Normal, so these do not look like errors.
798 * src/modest-tny-account.c:
799 (modest_tny_account_new_from_server_account): Use the new tinymail
800 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
801 for TLS. This should fix projects.maemo.org bug NB#58460.
803 2007-06-06 Murray Cumming <murrayc@murrayc.com>
805 * src/maemo/easysetup/modest-easysetup-wizard.c:
806 (create_account): Correct the position of the gconf sanity check warning.
807 (on_button_edit_advanced_settings): Show the dialog immediately, instead
808 of using the g_idle_add() hack, because this does not seem to be necessary
809 on osso 1.1. It might even work on Maemo Bora if the problems were actually
810 caused by something other than maemo's gconf.
811 This fixes projects.maemo.org bug #59022.
813 2007-06-06 Murray Cumming <murrayc@murrayc.com>
815 * src/modest-account-mgr-helpers.c:
816 (modest_account_mgr_get_default_account): Do not check that the account
817 exists if there is no default account (NULL), to fix a runtime warning.
819 2007-06-06 Murray Cumming <murrayc@murrayc.com>
821 * src/widgets/modest-folder-view.c: (update_model):
822 Do not unref the treemodel before we have finished with it.
823 This prevents a valgrind warning and an occasional crash at startup.
825 2007-06-06 Marcus Bauer <marcusb@openismus.com>
827 * libmodest-dbus-client/libmodest-dbus-client.h:
828 added libmodest_dbus_client_compose_mail()
829 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
831 added functions needed for SendAsMail() functionality
832 * src/maemo/modest-msg-edit-window.c:
833 (modest_msg_edit_window_attach_file_noninteractive):
834 non interactively attaching files to message edit window
835 * src/widgets/modest-msg-edit-window.h:
836 * tests/dbus_api/Makefile.am:
837 added test_compose_mail.c
838 * tests/dbus_api/test_compose_mail.c: (main):
840 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
842 * src/modest-account-view.c:
843 Fixed bug projects.maemo.org bug NB#59307
845 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
847 * src/maemo/easysetup/modest-easysetup-wizard.c:
848 (get_serverport_incoming), (on_before_next), (create_account):
849 * src/maemo/modest-account-settings-dialog.c:
850 (modest_account_settings_dialog_set_account_name):
851 * src/maemo/modest-maemo-utils.c:
852 (on_camel_account_get_supported_secure_authentication_status),
853 (on_camel_account_get_supported_secure_authentication),
854 (on_secure_auth_cancel),
855 (modest_maemo_utils_get_supported_secure_authentication_methods):
857 Implemented security authentication for settings and easysetup.
859 2007-06-05 Murray Cumming <murrayc@murrayc.com>
861 * src/maemo/modest-main-window.c: (create_details_widget):
862 Show the total size for memory card accounts too, instead of showing
863 the name again. Fixes bug projects.maemo.org bug NB#59307.
865 2007-06-05 Murray Cumming <murrayc@murrayc.com>
868 * src/modest-tny-simple-folder-store.c:
869 * src/modest-tny-simple-folder-store.h: Removed.
871 * src/modest-tny-local-folders-account.h
872 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
873 for the local-folders maildir, with an extra TnyMergedFolder containing
874 the folders of the per-account outbox store accounts.
875 * src/modest-tny-account-store.c: (get_server_accounts):
876 Add the outboxes to the special local folders account after creating it.
878 * src/modest-tny-account.c:
879 (modest_tny_account_new_for_local_folders): Create the derived
880 account when creating the main local-folders account.
882 * src/maemo/modest-main-window.c: (create_details_widget),
883 (modest_main_window_set_contents_style):
884 Adapted to the use of the derived account instead of the folder store.
886 * src/modest-ui-actions.c:
887 (modest_ui_actions_on_folder_selection_changed):
888 * src/modest-ui-dimming-rules.c:
889 (modest_ui_dimming_rules_on_new_folder):
890 * src/widgets/modest-folder-view.c: (text_cell_data),
891 (icon_cell_data), (filter_row), (update_model),
892 (get_cmp_rows_type_pos):
895 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
896 Do not get the priv struct, because no priv struct has been set,
897 to avoid a runtime warning.
899 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
900 #ifelse with #else, to fix a warning, to fix the build.
903 2007-06-05 Christian Kellner <ckellner@openismus.com>
905 * libmodest-dbus-client/libmodest-dbus-client.c:
906 Fix small typo in doc (why do you always see them
907 AFTER committing stuff?)
910 2007-06-05 Christian Kellner <ckellner@openismus.com>
912 * libmodest-dbus-client/libmodest-dbus-client.c:
913 (libmodest_dbus_client_search):
914 Initialize hit list with NULL. Also set folder list
915 to "" if NULL was supplied.
918 2007-06-03 Christian Kellner <ckellner@openismus.com>
920 * libmodest-dbus-client/libmodest-dbus-client.c:
921 (modest_search_hit_list_free):
922 Make it save to call it with NULL.
924 * src/dbus_api/modest-dbus-callbacks.c:
925 * src/modest-search.c:
926 Return full ModestSearchHits as the search result list not TnyHeader
927 since can't be around withouth the correspoding TnyFolder.
929 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
931 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
932 Added currently commented code to check for secure auth
934 * src/maemo/modest-account-settings-dialog.c: (on_response),
935 (save_configuration), (show_ok):
936 Fixed projects.maemo.org bugs NB #59248 and #59251
938 * src/maemo/modest-maemo-utils.c:
939 (on_camel_account_get_supported_secure_authentication_status),
940 (on_camel_account_get_supported_secure_authentication),
941 (modest_maemo_utils_get_supported_secure_authentication_methods):
942 * src/maemo/modest-maemo-utils.h:
943 Moved get_supported_secure_authentication() method here to be able
944 to use it from easysetup wizard.
946 * src/modest-pair.c: (on_pair_compare_as_string):
947 Should compare string with first part of pair and not
948 strcmp pairs which will crash.
950 * src/modest-protocol-info.c:
951 (modest_protocol_info_protocol_is_store):
952 * src/modest-protocol-info.h:
953 Added modest_protocol_info_get_auth_protocol_name()
955 2007-06-03 Armin Burgmeier <armin@openismus.com>
957 * src/modest-mail-operation.c:
958 (modest_mail_operation_get_msgs_full): Set priv->account also when
959 only retrieving a single message. This avoids a crash when canceling
962 (modest_mail_operation_notify_end): Do not explicitely remove the
963 operation from the queue but only emit the progress_changed signal.
964 The queue itself listens to that signal to remove the operation when
965 it is finished. This reduces coupling and removes a potential deadlock
966 when modest_mail_operation_notify_end() is called from the queue
967 itself. If that is a problem performance-wise, I would suggest to
968 implement a status-changed signal or something.
970 * src/modest-mail-operation-queue.c: Make sure to never call a
971 function from another file while the queue is locked. This (hopefully)
972 fixes another deadlock when exiting the application while retrieving
975 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
977 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
978 Fixed build if libogs is not available
980 2007-06-03 Christian Kellner <ckellner@openismus.com>
982 * libmodest-dbus-client/libmodest-dbus-client.h:
983 * libmodest-dbus-client/libmodest-dbus-client.c:
984 (libmodest_dbus_client_delete_message):
985 Implement deletion of messages (Client side).
987 (modest_search_hit_free),
988 (modest_search_hit_list_free):
989 Utility functions to free the result hits.
991 * src/dbus_api/modest-dbus-api.h:
992 * src/dbus_api/modest-dbus-callbacks.c:
994 (modest_dbus_req_handler):
995 Implement deletion of messages (Server side).
997 * tests/dbus_api/test_search.c: (main):
1000 * tests/dbus_api/Makefile.am:
1001 * tests/dbus_api/test_delete_message:
1002 Add little test for the message deletion logic
1004 2007-06-03 Armin Burgmeier <armin@openismus.com>
1006 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1007 when the operation queue was not empty. projects.maemo.org bug
1010 2007-06-03 Armin Burgmeier <armin@openismus.com>
1012 * src/widgets/modest-account-view.c
1013 (on_account_default_toggled): Toggle default account column
1014 explicitely instead of waiting for gconf notification (which is
1015 currently ignored). This should fix projects.maemo.org bug NB#56910
1016 for now. It should probably be removed when gconf notifications are
1019 2007-06-03 Christian Kellner <ckellner@openismus.com>
1021 * libmodest-dbus-client/libmodest-dbus-client.c:
1022 Removed debugging spew.
1024 * src/dbus_api/modest-dbus-callbacks.c:
1025 Added debugging info.
1027 * src/modest-search.c:
1028 (modest_search_all_accounts):
1029 Use tny_account_store_get_accounts () on the account store
1030 to get all accounts which is the way to get all accounts.
1032 * tests/dbus_api/test_search.c: (main):
1033 Make it possible to supply the search term on the command line.
1035 2007-06-03 Christian Kellner <ckellner@openismus.com>
1037 * libmodest-dbus-client/libmodest-dbus-client.c:
1038 * libmodest-dbus-client/libmodest-dbus-client.h:
1039 Implement searching for mesages over raw dbus. (Client side)
1041 * src/dbus_api/Makefile.am:
1042 * src/dbus_api/modest-dbus-api.h:
1043 * src/dbus_api/modest-dbus-callbacks.c:
1044 * src/dbus_api/modest-dbus-callbacks.h:
1045 Search framework (Server side). Also implement on_idle_open_message().
1047 * src/maemo/modest-platform.c: (modest_platform_init):
1048 Prepare for raw dbus/osso rpc interaction.
1050 * src/modest-search.h:
1051 Changed minsize from unspecific guint to guint32.
1053 * src/modest-search.c:
1055 Added strange hack which magically made tnymail work.
1057 (modest_search_folder),
1058 (modest_search_account),
1059 (modest_search_all_accounts):
1060 Implement helper functions to search all accounts, specific account
1063 * tests/dbus_api/Makefile.am:
1064 * tests/dbus_api/test_open_message.c:
1065 Read url to open from commandline.
1067 * tests/dbus_api/test_search.c:
1068 Implement small test for dbus search stuff
1070 2007-06-02 Armin Burgmeier <armin@openismus.com>
1072 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1073 include account type and account title. This fixes projects.maemo.org
1076 * src/maemo/modest-account-view-window.c: Set a title for the window.
1078 2007-06-02 Armin Burgmeier <armin@openismus.com>
1080 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1081 incoming and outgoing server name based on email address and server
1082 types as long as the names have not been edited manually. This fixes
1083 projects.maemo.org bug NB#58671.
1085 2007-06-02 Armin Burgmeier <armin@openismus.com>
1087 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1088 server type cannot be changed in future to the incoming details page
1089 when creating an account. This fixes projects.maemo.org bug NB#59029.
1091 2007-06-02 Armin Burgmeier <armin@openismus.com>
1093 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1094 and assigned max width chars so that they wrap instead of being
1095 truncated. Fixes projects.maemo.org bug NB#56126.
1097 2007-06-02 Armin Burgmeier <armin@openismus.com>
1099 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1100 introductory note to the connection specific smtp servers dialog, as
1101 section 8.12 of the email UI specification requires. This fixes
1102 projects.maemo.org bug NB#59212.
1104 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1106 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1107 Check for running mail operations, and offer to cancel them, as per the UI
1108 spec. This fixes projects.maemo.org bug NB#59041 .
1109 However, I suspect that tinymail may still use the network connection
1110 in ways that we cannot detect or cancel. But it should at least adapt to
1111 changes fairly well.
1113 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1115 * src/modest-tny-account-store.c: (recreate_all_accounts),
1116 (get_cached_accounts), (get_server_accounts): Do more sensible
1117 ref-counting of the temporarily-cached outbox accounts list. This seems
1118 to fix a crash when entering the password when the password was wrong.
1120 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1122 * src/gnome/modest-main-window.c: (connect_signals):
1123 * src/modest-tny-account-store.c: (get_password),
1124 (modest_tny_account_store_alert): Added comments and clues and
1125 commented-out code about how we currently fail to deal with connection
1126 errors and wrong passwords, and how we should.
1128 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1130 * src/widgets/modest-retrieve-combo-box.c:
1131 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1132 This fixes projects.maemo.org bug NB#58472 .
1134 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1136 * src/maemo/easysetup/modest-easysetup-wizard.c:
1137 (create_page_complete_easysetup):
1138 (create_page_complete_custom): Correct the last commit,
1139 putting the correct sentences in the correct pages.
1141 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1143 * src/maemo/easysetup/modest-easysetup-wizard.c:
1144 (create_page_complete_custom): Show the second sentence of text
1145 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1148 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1150 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1151 Set the leave-on-server conf key by default. This fixes
1152 projects.maemo.org bug NB#59258 .
1154 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1156 * src/maemo/modest-account-view-window.c:
1157 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1158 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1161 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1163 * src/maemo/easysetup/modest-easysetup-wizard.c:
1164 (create_caption_new_with_asterisk):
1165 * src/maemo/modest-account-settings-dialog.c:
1166 (create_caption_new_with_asterisk):
1167 Uncomment the code to add the asterisk, because they are no longer in the
1168 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1169 (update_incoming_server_title): Add an asterisk here too.
1171 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1173 * src/maemo/modest-maemo-global-settings-dialog.c:
1174 (current_connection): Check that we are even connected before trying to
1175 get the current connection name, to prevent a warning.
1177 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1178 Change the comments because tny_maemo_conic_device_connect() is now meant to
1180 * src/modest-mail-operation.c:
1181 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1182 make sure we have a connection and fail if we can't connect.
1184 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1186 * src/maemo/modest-main-window.c:
1187 (on_account_store_connecting_finished): Do not try to get the
1188 connection ID if we are not really connected. I am surprised that
1189 this signal handler is called when we are not connected.
1191 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1193 * src/modest-error.h:
1194 * src/modest-ui-actions.c:
1195 (modest_ui_actions_get_msgs_full_error_handler):
1196 Renamed an enum, added comments, added an enum
1197 for retrieve-limit errors.
1199 * src/modest-mail-operation.c: (foreach_add_item),
1200 (internal_folder_observer_update), (update_account_thread),
1201 (modest_mail_operation_get_msgs_full):
1202 (modest_mail_operation_update_account),
1203 Added comments about how this works, and some code that should
1204 (but does not) check the retrieve-limit. See the TODO comment.
1206 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1208 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1209 Initialize help_id to fix the build. Warnings are good.
1211 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1213 * src/widgets/modest-hbox-cell-renderer.c:
1214 (modest_hbox_cell_renderer_append):
1215 * src/widgets/modest-vbox-cell-renderer.c:
1216 (modest_vbox_cell_renderer_append):
1217 Fix the last commit by doing an extra ref.
1219 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1221 * src/widgets/modest-hbox-cell-renderer.c:
1222 (modest_hbox_cell_renderer_append):
1223 * src/widgets/modest-vbox-cell-renderer.c:
1224 (modest_vbox_cell_renderer_append):
1225 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1226 to fix the build with Maemo Bora.
1227 However, there seems to be a remaining crash, probably due to reference
1230 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1232 * src/modest-tny-account.c:
1233 (modest_tny_account_new_for_local_folders):
1234 Use hildon_file_system_info_async_new() to get a better name for
1235 the memory card account, setting it as the account name.
1236 The timing seems to work, but this is probably
1237 not the best place to do this. See the TODO comment.
1238 * src/maemo/modest-main-window.c: (create_details_widget):
1239 * src/widgets/modest-folder-view.c: (text_cell_data):
1240 Use the tny account name instead of hardcoding a name.
1242 2007-05-30 Christian Kellner <ckellner@openismus.com>
1244 * src/modest-search.c: (modest_search):
1245 Correctly set part_search_func even if we have already parsed
1246 the query and thus a valid OgsTextSearcher object.
1248 2007-05-30 Christian Kellner <ckellner@openismus.com>
1251 Search and check for libogs.
1254 Incooparte the ogs build env.
1256 * src/modest-mime-part-search-stream.c:
1257 * src/modest-mime-part-search-stream.h:
1258 Removed since we do the real searching now in modest-search.c.
1260 * src/modest-search.c:
1261 * src/modest-search.h:
1262 Implement support for ogs. We use that if available and requested
1263 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1264 should now handle the corner case when the search term is spread
1265 across multiple reads.
1266 Also the logic in modest_search () was corrected to search all
1267 requested fields until one is found.
1269 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1271 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1273 * src/modest-init.h:
1274 * src/modest-init.c: Made modest_init_local_folders() take a
1275 path and be public so we can iniitialize maildir folders on
1278 * src/modest-local-folder-info.h:
1279 * src/modest-local-folder-info.c:
1280 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1282 * src/modest-tny-account.c:
1283 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1284 still means the standard local-folders path on the local volume.
1286 * src/modest-tny-account-store.c:
1287 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1288 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1289 all accounts when that happens.
1290 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1291 this too, so it shows up in the treeview.
1293 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1295 * src/maemo/modest-maemo-global-settings-dialog.c:
1296 (current_connection):
1297 * src/widgets/modest-global-settings-dialog.c:
1298 (current_connection_default):
1299 Use the enum values instead of 0, 1 and -1,
1300 to make the code clearer.
1302 * src/modest-account-mgr-helpers.c:
1303 (modest_account_mgr_get_connection_specific_smtp): Make this code
1306 * src/modest-runtime.h:
1307 * src/modest-runtime.c:
1308 Added modest_runtime_remove_all_send_queues().
1309 * src/maemo/modest-main-window.c:
1310 (on_account_store_connecting_finished): Recreate the send queues,
1311 using the appropriate transport accounts for this new connection.
1312 Some futher adapting might be needed if the old send queues are not
1313 automatically stopped at this point.
1315 * src/modest-tny-account-store.c: (get_server_accounts):
1316 Create the connection-specific transport accounts, so that they can
1317 be found later by their ID.
1319 * src/modest-tny-account.h:
1320 * src/modest-tny-account.c:
1321 Added modest_tny_account_new_from_server_account_name().
1322 modest_tny_account_new_from_server_account(): Do not create the
1323 send queues here, because they will be
1324 recreated anyway when the connection changes for the first time.
1326 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1328 * src/modest-local-folder-info.h:
1329 * src/modest-local-folder-info.c:
1330 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1331 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1332 tbox_folder): Take a modest account name instead of a server TnyAccount,
1333 so we can have per-modest-account rather than per-transport-account
1335 We must make sure that we change or recreate the exisitng send queues
1336 when the connection changes for connection-specific transport accounts.
1338 * src/modest-tny-account-store.c:
1339 (create_per_account_local_outbox_folders): Create outboxed per modest
1340 account, not per transport account.
1342 * src/modest-tny-account.h:
1343 * src/modest-tny-account.c:
1344 (modest_tny_account_get_special_folder): For outboxes, get the
1345 parent modest account name. The account is ignored for other folders.
1346 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1347 modest account name rather than a server TnyAccount.
1349 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1351 * src/modest-tny-account.c:
1352 (modest_tny_account_new_from_server_account):
1353 Call modest_runtime_get_send_queue() immediately after creating transport
1354 accounts, so that they start trying to send email from the outbox as soon
1355 as possible at startup. This is probably what we want.
1357 * src/modest-mail-operation.c: (update_account_thread):
1358 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1359 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1360 * src/modest-tny-send-queue.h:
1361 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1362 (modest_ui_actions_on_send):
1363 Added comments about how sending works, though it needs some more work.
1365 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1367 * src/modest-tny-account.c:
1368 (modest_tny_account_get_special_folder): Add TODO because this fails when
1369 the network is busy.
1370 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1371 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1372 Do not try to show this window when there is no active account. The UI
1373 specs does not tell us what to do in this case.
1375 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1379 * src/maemo/Makefile.am:
1380 * src/widgets/Makefile.am: Some dist fixes.
1382 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1384 * src/maemo/modest-connection-specific-smtp-window.c:
1385 (on_button_edit): Make the code clearer, to prevent a double free.
1387 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1389 * src/maemo/modest-account-settings-dialog.c:
1390 (modest_account_settings_dialog_set_account_name),
1391 Check the connection-specific smtp servers checkbox if there are any.
1393 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1394 (modest_connection_specific_smtp_edit_window_init):
1395 Start with a suitable port number.
1397 * src/modest-account-mgr-helpers.h:
1398 * src/modest-account-mgr-helpers.c: Added
1399 modest_account_mgr_get_has_connection_specific_smtp().
1401 (modest_account_mgr_set_connection_specific_smtp),
1402 (modest_account_mgr_remove_connection_specific_smtp),
1403 (modest_account_mgr_get_has_connection_specific_smtp),
1404 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1405 connection-specific smtp server accounts in the account, rather than
1406 the server account conf dir.
1408 This fixes bug projects.maemo.org bug NB#58263 .
1410 * src/modest-tny-account-store.c:
1411 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1412 if there are no server accounts yet, to prevent an infinite loop when there
1413 are no accounts. Document that one must be called before the other.
1415 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1417 * src/modest-account-mgr-helpers.c:
1418 (modest_account_mgr_get_default_account): Make sure that at least
1419 one account is always the default, if there are any enabled accounts.
1420 This is just a sanity check that shouldn't be necessary.
1422 * src/modest-account-mgr-priv.c:
1423 (_modest_account_mgr_account_from_key): Unescape the conf key to
1424 get the real account name. For instance, this is an issue if a space
1425 was in the account name, which can happen because the account name
1426 is generated from the display name.
1427 (_modest_account_mgr_get_account_keyname): Always escape the
1429 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1430 Unescape the conf keys to get the real account names.
1432 For instance, previously the is-default radio button in the accounts
1433 list was not checked for any accounts at first. This fixes that,
1434 and might fix several similar bugs.
1436 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1438 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1439 Removed some debug printfs.
1441 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1443 Modest on-disk outbox directories are now here, for instance:
1444 $HOME/.modest/outboxes/<account-id-1>/outbox
1445 $HOME/.modest/outboxes/<account-id-2>/outbox
1447 $HOME/.modest/local-folders/outbox
1448 so we can have a separate outbox for each account.
1449 But they are shown as one outbox in the GtkTreeView, by using a
1450 TnyMergeFolder in a ModestTnySimpleFolderStore.
1453 * src/modest-tny-simple-folder-store.c:
1454 * src/modest-tny-simple-folder-store.h:
1455 Added ModestTnySimpleFolderStore, used to contain folders from
1456 other folder stores, such as other accounts.
1458 * src/modest-tny-outbox-account.h:
1459 * src/modest-tny-outbox-account.c:
1460 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1461 used for the per-account local outbox folders.
1463 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1464 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1465 only use this (internally) now for the non-outbox local folders.
1467 * src/modest-init.h:
1468 * src/modest-init.c: Added modest_init_one_local_folder(), for
1469 setting up the directory structure for each local folder.
1471 * src/modest-local-folder-info.c:
1472 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1473 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1475 * src/modest-local-folder-info.h:
1476 * src/modest-tny-account-store.c: (on_account_removed),
1477 (on_account_changed), (create_per_account_local_outbox_folders),
1478 (get_server_accounts), (modest_tny_account_store_get_accounts),
1479 (modest_tny_account_store_get_tny_account_by_account),
1480 (modest_tny_folder_store_is_virtual_local_folders):
1482 * src/modest-tny-account.h:
1483 * src/modest-tny-account.c:
1484 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1485 to create an on-disk per-account local outbox folder for each
1487 (create_per_account_local_outbox_folders): Create a local outbox folder
1488 for each transport account.
1489 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1490 for all local folders.
1492 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1493 instead of using g_object_get/set() directly. It is clearer.
1495 (modest_tny_folder_store_get_message_count),
1496 (modest_tny_folder_store_get_local_size
1497 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1498 because we now use these with non-acount folder stores.
1500 (modest_tny_account_get_special_folder),
1501 (modest_tny_account_new_from_server_account),
1502 (modest_tny_account_new_from_account):
1503 (recurse_folders): Adjust to the new outbox system.
1505 * src/modest-tny-folder.h:
1506 * src/modest-tny-folder.c:
1507 (modest_tny_folder_is_local_folder),
1508 (modest_tny_folder_get_local_folder_type),
1509 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1511 * src/widgets/modest-main-window.h:
1512 * src/maemo/modest-main-window.c: (create_details_widget),
1513 (modest_main_window_set_contents_style): Show details for any folder store,
1516 (modest_tny_folder_get_rules):
1517 Remove the const. C does not support constness enough for this.
1519 * src/modest-ui-actions.c:
1520 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1521 make all outboxes appear as one, in the usual local-folders tree node.
1523 (set_active_account_from_tny_account),
1524 (modest_ui_actions_on_folder_selection_changed):
1525 * src/widgets/modest-folder-view.c: (text_cell_data),
1526 (icon_cell_data), (filter_row),
1527 (add_account_folders_to_merged_folder),
1528 (add_account_folders_to_simple_folder_store), (),
1529 (get_cmp_rows_type_pos), (cmp_rows),
1530 (modest_folder_view_set_account_id_of_visible_server_account):
1531 Adjust to the new outbox system, using generic folder stores and folders
1532 in the GtkTreeModel.
1534 2007-05-23 Christian Kellner <ckellner@openismus.com>
1536 * src/modest-mail-operation.c:
1537 (modest_mail_operation_update_account):
1538 Use info->max_size instead of unintialized local var [small
1539 build fix]. (Added TODO to review that change since I don't
1542 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1544 * libmodest-dbus-client/libmodest-dbus-client.c:
1545 (libmodest_dbus_client_compose_mail): function added
1546 * src/dbus_api/modest-dbus-api.h:
1547 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1548 (on_compose_mail): Implementation of the SendAsMail functionality
1550 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1552 * src/modest-account-mgr.c:
1553 (modest_account_mgr_add_server_account): Set the secure-connection
1554 conf key for transport accounts as well as store accounts. I don't know
1555 why the if was there. For instance, this makes sure that we use SSL
1556 for the gmail preset from the easysetup wizard.
1558 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1560 * src/gnome/modest-main-window.c:
1561 (on_account_store_connecting_finished), (connect_signals):
1562 * src/maemo/modest-main-window.c:
1563 (on_account_store_connecting_finished), (connect_signals),
1564 (modest_main_window_new):
1565 Handle TnyAccountStore::connecting-finished instead of
1566 TnyDevice::connection-changed, because we cannot actually perform
1567 operations on accounts until TnyAccountStore has itself responded to
1568 the TnyDevice::connection-changed signal. This prevents a GError from
1570 Do not try to update at startup, because we (at least on scratchbox)
1571 already do an update at startup when the device goes online.
1572 This prevents a GError from tinymail.
1573 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1574 Added TODO about stopping simultaneous operations.
1576 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1578 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1579 * src/modest-mail-operation-queue.c:
1580 (modest_mail_operation_queue_remove):
1581 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1582 about where they happened.
1584 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1586 * src/modest-ui-actions.c:
1587 (modest_ui_actions_on_password_requested): Make sure that the remember
1588 output parameter is always TRUE.
1590 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1592 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1593 Show a OK/Cancel dialog if the error is a question, though we still do not
1594 know anything more about what we are asking the user.
1595 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1596 Fix an uninitialized variable (helper). This is a logic error, however.
1598 2007-05-21 Christian Kellner <ckellner@openismus.com>
1600 * src/modest-search.h:
1601 Correct bit shifting in the ModestSearchFlags enum.
1603 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1605 * src/modest-tny-account.c:
1606 (modest_tny_account_new_from_server_account): Do not use the lsub and
1607 check-all hard-coded IMAP options when using POP.
1609 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1611 * src/modest-tny-account.c:
1612 (modest_tny_account_new_from_server_account):
1613 Use NULL for the secure-auth method for POP when Password auth has been
1614 specified by the user, as we already do for IMAP. "auth=Login" causes
1615 an error from camel or the server.
1617 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1619 * src/maemo/modest-account-settings-dialog.c:
1620 (create_page_account_details),
1621 (modest_account_settings_dialog_set_account_name):
1622 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1623 for the leave-on-server checkbox, rathr than just the checkbox, when
1624 the protocol is not POP.
1626 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1628 * src/widgets/modest-account-view.c:
1629 * src/widgets/modest-account-view.h:
1630 Added modest_account_view_select_account() which will be useful later
1631 to asynchronously re-select the edited account.
1633 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1635 * src/maemo/modest-account-settings-dialog.c:
1636 (modest_account_settings_dialog_set_account_name):
1637 Automatically choose the port numbers based on the secure authentication
1638 methods, if they have not been chosen before.
1639 This fixes projects.maemo.org bug NB#56273 .
1641 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1643 * src/maemo/modest-main-window-ui.h:
1644 * src/modest-ui-actions.c:
1645 * src/modest-ui-actions.h:
1646 Connect the Tools/SMTP Servers menu item to
1647 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1648 SMTP servers dialog, as in the UI specification and saves changes when it
1649 is closed. This fixed projects.maemo.org bug NB#56305 .
1651 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1653 * src/maemo/modest-connection-specific-smtp-window.c:
1654 (modest_connection_specific_smtp_window_init):
1655 Use gtk_window_set_default_size() to make this window big enough, so
1656 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1658 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1660 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1661 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1662 (modest_connection_specific_smtp_edit_window_init),
1663 Do not try to connect to a combobox signal before the combobox exists.
1664 This fixes the cras in projects.maemo.org bug NB#56288 .
1665 (modest_connection_specific_smtp_edit_window_get_settings):
1666 Remove the server_account_name parameter which was being checked for NULL
1667 though it was not used.
1669 * src/maemo/modest-connection-specific-smtp-window.c:
1670 (modest_connection_specific_smtp_window_fill_with_connections),
1671 (on_button_edit), (modest_connection_specific_smtp_window_init):
1672 Correct the number of treemodel columns to prevent a warning.
1673 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1674 libconic does not work.
1676 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1678 * src/modest-tny-account.c:
1679 (modest_tny_account_new_from_server_account):
1680 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1681 SMTP when "None" was chosen by the user. However, with my SMTP server that
1682 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1685 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1687 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1688 to explain the memory management issue with the ID in the ModestPair.
1690 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1691 (add_sending_page), (modest_account_assistant_finalize):
1692 * src/gnome/modest-gnome-global-settings-dialog.c:
1693 (create_updating_page), (create_composing_page):
1694 * src/gnome/modest-msg-edit-window.c: (get_transports),
1695 (init_window), (modest_msg_edit_window_finalize),
1696 (modest_msg_edit_window_get_msg_data):
1697 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1698 * src/gnome/modest-transport-widget.c:
1699 (modest_transport_widget_finalize), (smtp_configuration):
1700 * src/maemo/modest-maemo-global-settings-dialog.c:
1701 (create_updating_page), (create_composing_page):
1702 * src/maemo/modest-msg-edit-window.c: (get_transports),
1703 (init_window), (modest_msg_edit_window_finalize),
1704 (modest_msg_edit_window_get_msg_data),
1705 (modest_msg_edit_window_free_msg_data):
1706 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1707 (modest_store_widget_finalize):
1708 * src/maemo/modest-transport-widget.c:
1709 (modest_transport_widget_finalize), (smtp_configuration):
1710 * src/modest-main.c: (send_mail):
1711 * src/widgets/modest-combo-box.h:
1712 * src/widgets/modest-global-settings-dialog-priv.h:
1713 * src/widgets/modest-global-settings-dialog.c:
1714 (modest_global_settings_dialog_finalize):
1715 * src/widgets/modest-msg-edit-window.h:
1716 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1717 as long as the combo box, to prevent use of freed memory for the ID.
1719 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1721 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1722 get_accounts(), to make this clearer. Do not check for the enabled gconf
1723 key, because we do not use this for server accounts (at least, not yet).
1724 This allows us to send email again.
1726 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1728 * src/maemo/modest-platform.c:
1729 (on_modest_conf_update_interval_changed), (modest_platform_init):
1730 Only respond to this particular key change. All these strcmp()s cannot be
1733 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1735 * src/maemo/modest-maemo-global-settings-dialog.c:
1736 (current_connection): Prevent a crash in scratchbox when
1737 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1738 * src/maemo/modest-platform.c:
1739 (on_modest_conf_update_interval_changed), (modest_platform_init):
1740 Get the update interval from gconf and reset it when the gconf key changes.
1742 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1744 * src/modest-protocol-info.c:
1745 * src/modest-protocol-info.h: Adde enum-specific get functions,
1746 instead of using a ModestProtocolType enum parameter.
1748 * src/gnome/modest-account-assistant.c:
1749 * src/gnome/modest-store-widget.c:
1750 * src/gnome/modest-store-widget.h:
1751 * src/gnome/modest-transport-widget.c:
1752 * src/gnome/modest-transport-widget.h:
1753 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1754 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1755 * src/maemo/easysetup/modest-easysetup-wizard.c:
1756 * src/maemo/modest-account-settings-dialog.c:
1757 * src/maemo/modest-account-settings-dialog.h:
1758 * src/maemo/modest-store-widget.c:
1759 * src/maemo/modest-store-widget.h:
1760 * src/maemo/modest-transport-widget.c:
1761 * src/maemo/modest-transport-widget.h:
1762 * src/modest-account-mgr-helpers.c:
1763 * src/modest-account-mgr-helpers.h:
1764 * src/modest-account-mgr.c:
1765 * src/modest-account-mgr.h:
1766 * src/modest-tny-account.c:
1767 * src/modest-tny-folder.c:
1768 * src/widgets/modest-account-view.c:
1769 * src/widgets/modest-retrieve-combo-box.c:
1770 * src/widgets/modest-retrieve-combo-box.h:
1771 * src/widgets/modest-secureauth-combo-box.c:
1772 * src/widgets/modest-serversecurity-combo-box.c:
1773 * src/widgets/modest-serversecurity-combo-box.h:
1774 * tests/check_account-mgr.c:
1775 Use the specific functions, and use the re-renamed enum values for GNOME too.
1777 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1779 * src/modest-pair.h:
1780 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1781 so we can get the second based on the first.
1783 * src/maemo/modest-account-settings-dialog.h:
1784 * src/maemo/modest-account-settings-dialog.c:
1785 Added get_supported_secure_authentication_methods(), though it is mostly
1786 commented-out for now until the necessary API is committed to tinymail.
1787 (modest_account_settings_dialog_set_account_name),
1788 (save_configuration): Request the supported authentication methods from the
1789 server, so we can choose a working method.
1791 * src/modest-tny-account-store.h:
1792 * src/modest-tny-account-store.c:
1793 (modest_tny_account_store_get_session): Rename from
1794 tny_account_store_get_session().
1796 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1798 * src/modest-protocol-info.h: Split the ModestProtocol enum
1799 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1800 There was no need to have these unrelated values in one enum.
1802 * src/: many files: Adapted to changed enum. This makes the code a bit
1803 clearer, and the compiler could catch some errors.
1805 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1807 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1808 Show the detailed internal camel error message when an error happens
1809 during the configuration, so that our testers can give us more clues.
1810 For instance, in projects.maemo.org bug NB#56910 .
1812 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1814 * src/modest-tny-account.c:
1815 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1816 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1818 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1820 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1821 * src/maemo/modest-account-settings-dialog.c:
1822 (modest_account_settings_dialog_set_account_name),
1823 (save_configuration): For the incoming secure authentication checkbox,
1824 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1825 the UI specification. PLAIN does not seem to be supported for most IMAP
1826 servers anyway, and I am not sure what it would mean.
1827 However, we probably need to discover which of the secure-authentication
1828 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1829 * src/modest-account-mgr-helpers.c:
1830 (modest_account_mgr_get_server_account_data):
1832 * src/modest-tny-account.c:
1833 (modest_tny_account_new_from_server_account):
1834 Use tny_account_set_mech() to set secure-authentication methods,
1835 with some special-casing for IMAP, based on my observations of how
1838 * src/modest-account-mgr-helpers.h:
1839 * src/modest-account-mgr.c:
1840 * src/modest-defs.h: Comment that the URI is only used for local folders.
1842 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1844 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1845 parameter const, just to be neat.
1846 * src/modest-text-utils.c: (modest_text_utils_inline):
1847 End g_strconcat() with NULL, as its documentation says. This is almost
1848 certainly the cause of my crash at startup on the device. Interestingly,
1849 valgrind doesn't tell us about these errors.
1851 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1853 * scripts/build-packages: Added more precise comments about how to use
1854 this script, though I still get this error:
1855 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1856 error building tinymail
1858 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1860 * src/maemo/modest-main-window.c: (on_account_update):
1861 Very slight cleanup, hoping to make it simpler to discover what causes
1862 a crash here sometimes.
1864 * src/modest-tny-account.c:
1865 (modest_tny_account_new_from_server_account): Set the port. Added
1866 comments about the options and a TODO comment because I need to find out
1867 how to specify the secure authentication method.
1869 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1871 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1872 changed CFlags paths form modest to libmodest
1874 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1876 * src/modest-account-mgr-helpers.c:
1877 (modest_account_mgr_get_server_account_data),
1878 (modest_account_mgr_free_server_account_data):
1879 * src/modest-account-mgr-helpers.h:
1880 * src/modest-account-mgr.c:
1881 (modest_account_mgr_add_server_account):
1882 * src/modest-defs.h:
1883 * src/modest-tny-account.c:
1884 (modest_tny_account_new_from_server_account):
1885 Determine the options for tny_camel_account_add_option() here,
1886 based on the settings, rather than storing them directly in gconf.
1888 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1890 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1891 Show a more friendly error dialog now that we expect (from the tinymail
1892 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1894 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1896 * src/maemo/modest-main-window.c: (on_account_update): Check that
1897 account_name is not NULL, to prevent a crash at startup that I am
1898 seeing on the N800. I do wonder why it is NULL.
1900 * src/maemo/easysetup/modest-easysetup-wizard.c:
1901 (create_page_user_details):
1902 * src/maemo/modest-account-settings-dialog.c:
1903 (create_page_user_details), (create_page_outgoing):
1904 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1905 (modest_connection_specific_smtp_edit_window_init):
1906 * src/modest-ui-actions.c:
1907 (modest_ui_actions_on_password_requested):
1908 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1909 might do something useful with the on-screen keyboard.
1911 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1913 * src/maemo/modest-main-window.c: (on_account_update):
1914 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1915 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1917 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1919 * src/modest-tny-account-store.c: (on_account_changed):
1920 Correct the signature of this signal handler.
1922 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1924 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1925 Show a HildonNote instead of a GtkDialog for Maemo.
1927 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1929 * src/widgets/modest-account-view.h:
1930 * src/widgets/modest-account-view.c: (on_account_changed),
1931 (on_account_removed). Added a boolean flag, set/unset by
1932 modest_account_view_block_conf_updates(),
1933 modest_account_view_unblock_conf_updates() to prevent unnecessary
1934 updates, but this is not very useful because the gconf notifications are
1935 so delays (maybe only on Maemo Bora).
1936 So auto-updating is turned off, and these functions do an explicit
1937 update when necessary.
1938 However, something else is still doing too much work when adding/removing
1939 accounts, probably in another part of the application.
1941 * src/maemo/modest-account-view-window.c:
1942 (on_delete_button_clicked), (on_edit_button_clicked),
1943 (on_new_button_clicked): Use the new functions.
1945 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1947 * src/modest-account-mgr-helpers.c:
1948 (modest_account_mgr_set_first_account_as_default):
1949 Sort the list of names alphabetically-by-title, so we choose the first one
1951 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1952 alphabetically by the title.
1954 This fixes projects.maemo.org bug NB#56418 .
1956 * src/modest-account-mgr-priv.c:
1957 (_modest_account_mgr_account_from_key):
1958 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1959 avoid a valgrind error, and possible random behaviour.
1961 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1963 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1964 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1965 tinymail documentation to say that this can be expected.
1966 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1967 pretty, and should not happen, but I would prefer to know when it does.
1969 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1971 * configure.ac: When using the older hildon version, probably on Bora,
1972 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1974 * src/widgets/modest-attachment-view.c:
1975 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1978 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1980 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1981 Implemented the prototype. Can be tested with
1982 tests/dbus_api/test_open_message:
1984 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1986 * src/modest-tny-account-store.c:
1987 (modest_tny_account_store_instance_init), (get_password):
1988 * src/modest-ui-actions.c:
1989 (modest_ui_actions_on_password_requested):
1990 Do not store the password in gconf, because this function is called
1991 for non-remembered passwords. Actually use the cached (in the hash map)
1992 password instead of releasing it.
1993 The password will now not be remembered if it is asked via the protected
1994 password dialog, as per the UI spec.
1996 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1998 * src/modest-defs.h:
1999 * src/modest-account-mgr-helpers.h:
2000 * src/modest-account-mgr-helpers.c:
2001 Added modest_server_account_get_username_has_succeeded(),
2002 modest_server_account_set_username_has_succeeded().
2003 (modest_server_account_set_username),
2004 Reset the has-succeeded flag if the username changes.
2006 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2007 * src/maemo/modest-connection-specific-smtp-window.c:
2008 (modest_connection_specific_smtp_window_save_server_accounts):
2009 Use modest_server_account_set_username() instead of using
2010 modest_conf_set_string() directly, so that the has-succeeded flag is always
2013 * src/modest-ui-actions.c:
2014 (modest_ui_actions_on_password_requested): Dim the username entry if
2015 the username has ever worked, as per the UI spec.
2017 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2019 * src/modest-tny-account-store.c: (get_password):
2020 * src/modest-ui-actions.c:
2021 (modest_ui_actions_on_password_requested):
2022 Allow the username to be changed too, though there is more work to
2023 be done on exactly how this behaves.
2025 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2027 * src/modest-account-mgr-helpers.h:
2028 * src/modest-account-mgr-helpers.c:
2029 Added modest_account_mgr_get_display_name(),
2030 modest_server_account_get_username(),
2031 modest_server_account_set_username(),
2032 modest_server_account_set_password(),
2033 modest_server_account_get_hostname() functions so we do not need to
2034 use the conf API directly.
2036 * src/maemo/modest-main-window.c: (connect_signals):
2037 Actually connect ot the ModestAccountStore::request-password signal,
2038 so that we show the dialog when the password is requested by Tinymail,
2039 for isntance if it is empty.
2041 * src/modest-marshal.list:
2042 * src/modest-tny-account-store.c:
2043 (modest_tny_account_store_class_init), (get_password),
2044 (modest_tny_account_store_alert):
2045 * src/modest-tny-account-store.h:
2046 * src/modest-ui-actions.h:
2047 * src/modest-ui-actions.c:
2048 (modest_ui_actions_on_password_requested):
2049 Change the signal parameters, so it is obvious that we are providing
2050 the non human-readable server name, and receiving both the username
2051 and password, though changing of the username is not yet implemented.
2052 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2053 for the GNOME version.
2055 This should fix the projects.maemo.org bug NB#56209, though it does not
2056 work on Bora, because the gconf_client_get() for the password fails
2057 immediately after we save it with gconf_client_set().
2059 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2062 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2063 caused an undefined symbol error:
2064 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2066 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2068 * src/modest-tny-account-store.c:
2069 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2070 using a GError instead of a string message, so we can translate it in
2073 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2075 * src/maemo/modest-address-book.c:
2076 (modest_address_book_check_names):
2077 * src/maemo/modest-msg-view-window.c:
2078 (modest_msg_view_window_clipboard_owner_change):
2079 * src/modest-init.c: (modest_init_init_ui):
2080 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2081 (update_folders_cb), (modest_mail_operation_update_account):
2082 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2083 (modest_ui_actions_on_msg_attachment_clicked),
2084 (modest_ui_actions_on_msg_recpt_activated):
2085 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2086 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2087 (modest_msg_view_search_next):
2088 * src/widgets/modest-recpt-editor.c:
2089 (modest_recpt_editor_on_button_release_event),
2090 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2091 g_message(). At this point we should only be seeing interesting errors on
2092 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2094 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2096 (modest_wizard_dialog_force_title_update):
2097 * src/maemo/easysetup/modest-wizard-dialog.h:
2098 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2099 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2100 can update the title when appropriate. Otherwise the title is wrong if the
2101 pages are added after adding the notebook to the dialog.
2102 This must be a problem in HildonWizardDialog too.
2103 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2105 * src/maemo/easysetup/modest-easysetup-wizard.c:
2106 (create_subsequent_customsetup_pages),
2107 (create_subsequent_easysetup_pages):
2108 Call modest_wizard_dialog_force_title_update() so that the title is
2109 correct even with GTK+ < 2.10.
2110 This fixes projects.maemo.org bug NB#56145 .
2112 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2114 * src/maemo/modest-platform.c:
2115 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2116 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2119 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2121 * src/widgets/modest-window.h:
2122 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2123 and modest_window_save_state(), which invokes it.
2125 * src/widgets/modest-window-mgr.h:
2126 * src/widgets/modest-window-mgr.c:
2127 Added modest_window_mgr_save_state_for_all_windows(), which calls
2128 the save_state vfunc on all registered windows, if implemented.
2130 * src/gnome/modest-msg-edit-window.c:
2131 * src/gnome/modest-msg-view-window.c:
2132 * src/maemo/modest-msg-edit-window.c:
2133 * src/maemo/modest-msg-view-window.c:
2134 * src/maemo/modest-main-window.c:
2135 Specify the existing save_settings functions as implementations of
2136 ModestWindow::save_state_func().
2138 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2139 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2140 enabling hibernation, for instance.
2142 We may need to do the same thing for restoring settings.
2145 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2147 * src/widgets/modest-window-mgr.c:
2148 * src/widgets/modest-window-mgr.h:
2149 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2150 modest_window_mgr_get_hibernation_is_prevented().
2152 * src/maemo/modest-main-window.c:
2153 (on_hildon_program_is_topmost_notify): Prevent hibernation
2154 (possible when the application goes to the background in the WM),
2155 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2157 * src/maemo/easysetup/modest-easysetup-wizard.c:
2158 (modest_easysetup_wizard_dialog_init):
2159 * src/maemo/modest-account-settings-dialog.c:
2160 (modest_account_settings_dialog_init):
2161 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2162 (modest_connection_specific_smtp_edit_window_init):
2163 * src/maemo/modest-connection-specific-smtp-window.c:
2164 (modest_connection_specific_smtp_window_init):
2165 * src/maemo/modest-signature-editor-dialog.c:
2166 (modest_signature_editor_dialog_init):
2167 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2168 prevent hibernation while any of these account settings dialogs are open.
2170 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2172 * src/maemo/Makefile.am:
2173 * src/maemo/modest-osso-state-saving.c:
2174 * src/maemo/modest-osso-state-saving.h: Added
2175 modest_osso_load_state() and modest_osso_save_state() though they do
2176 nothing now. They should iterate through all the open windows and load/save
2178 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2179 save state when closing.
2181 * src/maemo/modest-main-window.c:
2182 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2183 Add a notification handler for the HildonProgram::is-topmost property,
2184 so we can allow hibernation when the application goes into the background.
2185 But we still need to detect when the accounts setup windows are open so
2186 we can stop hibernation when they are open.
2187 To do this, I also added the main window the HildonProgram. This might have
2188 other side-effects/benefits, and should maybe be done for other windows.
2190 * src/maemo/modest-osso-autosave-callbacks.h:
2191 * src/maemo/modest-osso-autosave-callbacks.c:
2192 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2193 though it does not do anything yet, and we might never need this to do
2194 anything. For instance, we already save drafts.
2196 * src/maemo/modest-platform.c: (modest_platform_init):
2197 Specify the libosso auto-save callback.
2199 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2201 * src/maemo/modest-platform.c:
2202 (modest_platform_set_update_interval):
2203 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2204 aparently stays valid between application instances, so we can use this
2205 to remove and reset it later. According to a maemo-developers email from
2208 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2210 * configure.ac: Depend on libalarm for Maemo.
2212 * src/dbus_api/modest-dbus-api.h:
2213 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2214 (on_send_receive), (modest_dbus_req_handler):
2215 Handle a SEND_RECEIVE D-Bus method.
2217 * libmodest-dbus-client/libmodest-dbus-client.c:
2218 (libmodest_dbus_client_send_and_receive):
2219 * libmodest-dbus-client/libmodest-dbus-client.h:
2220 Add C convenience functions for calling the new D-Bus method.
2222 * src/modest-platform.h:
2223 * src/gnome/modest-platform.c:
2224 * src/maemo/modest-platform.c:
2225 Added modest_platform_set_update_interval(), which uses the
2226 alarmd API on Maemo.
2227 (modest_platform_init),
2228 Call modest_platform_set_update_interval(), using a hard-coded
2229 interval for now (until the global settings dialog is implemented),
2230 though I am not sure that this makes sense yet.
2232 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2234 * src/dbus_api/modest-dbus-callbacks.c:
2235 (modest_osso_cb_hw_state_handler):
2236 * src/dbus_api/modest-dbus-callbacks.h:
2237 * src/maemo/modest-platform.c: (modest_platform_init):
2238 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2239 in case this has some effect on the ability for Maemo to ping the
2242 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2244 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2245 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2246 warning. It is probably a logic error, but I need to fix the build.
2248 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2250 * src/modest-account-mgr.h:
2251 * src/modest-account-mgr.c:
2252 (modest_account_mgr_account_names): Add a gboolean enabled_only
2253 parameter, so we can get lists of onlt the enabled accounts.
2255 (modest_account_mgr_add_account),,
2256 (modest_account_mgr_account_with_display_name_exists):
2257 * src/maemo/modest-msg-edit-window.c: (get_transports):
2258 * src/modest-account-mgr-helpers.c:
2259 (modest_account_mgr_set_first_account_as_default):
2260 * src/modest-init.c: (init_default_account_maybe):
2261 * src/modest-tny-account-store.c: (get_accounts):
2262 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2263 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2264 * tests/check_account-mgr.c: (START_TEST):
2265 Provide the extra parameter, as appropriate.
2267 * src/widgets/modest-account-view.c: (update_account_view):
2268 Do not show disabled accounts (meaning that there is no way to
2269 enable/disable accounts in the UI (the feature is not in our UI
2270 specification), so we can use this internally only to mark unfinished
2271 or temporary account data.
2273 * src/maemo/easysetup/modest-easysetup-wizard.c:
2274 (create_account): Add boolean enable parameter, so we can specify FALSE
2275 to create the temporary account.
2276 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2277 (on_before_next): When finishing, when there is a temporary account, just
2279 Also, use a timeout to delay the showing of the dialog until gconf is likely
2280 to return correct information, due to a maemo gconf bug that is fixed in
2281 osso 1.1, but not yet in Bora.
2282 However, the dialog stays on screen after it is destroyed.
2284 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2285 for invalid data when cancelling. Use a hildon note instead of a dialog
2286 to complain about invalid data. Do not show the account-saved note if the
2287 account is disabled (a temporary account that will not really be saved for use
2290 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2292 * src/modest-account-mgr-helpers.h:
2293 * src/modest-account-mgr-helpers.c:
2294 Added modest_account_mgr_unset_default_account(),
2295 Added modest_account_mgr_set_first_account_as_default().
2297 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2298 If it was the default account, unset the default account name.
2300 * src/maemo/modest-account-view-window.c:
2301 (on_delete_button_clicked): If it was the default account,
2302 set the first remaining account as the default instead.
2304 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2305 a NULL account or a NULL default account, to prevent a crash. This should
2306 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2309 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2311 * src/widgets/modest-recpt-editor.c:
2312 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2313 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2314 TODO comment for this. This fixes the build.
2316 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2317 be the best place for it. This will in future update all auto-update accounts,
2318 rather than just the current/default account, when that gconf key exists.
2319 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2320 if there are no accounts, before calling do_send_receive().
2321 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2323 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2324 * src/maemo/modest-main-window-ui.h:
2325 * src/maemo/modest-main-window.c: (on_connection_changed),
2326 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2327 directly, becaue the signal handler does more.
2329 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2331 * src/modest-account-mgr-helpers.c:
2332 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2333 for the case that the account does not exist.
2335 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2336 (equivalent to the modest account name) rather than the tinymail account name
2337 (equivalent to the modest account title - human readable) to get the account data.
2338 Check for null account data to prevent the crash, and add a TODO comment saying that
2339 this needs fixing because it is using the server account name instead of the account name.
2341 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2343 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2344 * src/maemo/modest-account-settings-dialog.c: (show_error),
2346 Use hildon_note_new_information() for informative and error messages,
2347 which seems to be expected for Maemo applications (no documentation that I know of
2348 says this). I am surprised that there is no distinction between info and error
2351 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2353 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2354 it is easy to find where this is used.
2356 * src/maemo/easysetup/modest-easysetup-wizard.c:
2357 (create_page_welcome), (create_page_account_details),
2358 (create_page_user_details), (create_page_complete_easysetup),
2359 (create_page_custom_incoming), (create_page_custom_outgoing),
2360 (create_page_complete_custom):
2361 * src/maemo/modest-account-settings-dialog.c:
2362 (create_page_account_details), (create_page_user_details),
2363 (create_page_incoming), (create_page_outgoing):
2364 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2365 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2366 (modest_connection_specific_smtp_edit_window_init):
2367 * src/maemo/modest-connection-specific-smtp-window.c:
2368 (modest_connection_specific_smtp_window_init):
2369 * src/maemo/modest-signature-editor-dialog.c:
2370 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2371 and scrolling policy as per the Email Application Layout Guide, if I have
2374 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2376 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2377 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2378 which were empty, because these vfuncs have been removed from TnyAccountStore.
2379 This fixes the build.
2381 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2383 * src/maemo/modest-main-window.c:
2384 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2385 showing/hiding it. Added TODO because it probably should not be NULL.
2386 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2387 because unnecessary g_warnings() make degugging difficult.
2389 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2391 * src/maemo/modest-msg-edit-window.c:
2392 (modest_msg_edit_window_select_color),
2393 (modest_msg_edit_window_select_background_color): 2 const corrections and
2394 moving 2 #endifs before closing brackets, to fix the build.
2396 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2398 * src/maemo/easysetup/modest-easysetup-wizard.h:
2399 * src/maemo/easysetup/modest-easysetup-wizard.c:
2400 (modest_easysetup_wizard_dialog_finalize),
2401 (on_button_edit_advanced_settings), (create_page_complete_custom),
2402 (on_response), (create_account):
2403 Implement the Advanced Settings edit button, by saving the account information,
2404 for the Advanded Settings dialog to use directly from gconf, and removing it
2405 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2406 Bug #5533 in the projects.maemo.org bugzilla.
2408 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2410 * src/maemo/modest-msg-view-window.c:
2411 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2412 when opening a message window.
2414 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2416 * src/maemo/easysetup/modest-easysetup-wizard.c:
2417 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2420 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2421 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2422 gconf settings. I probably added more checks than necessary, but that is safer.
2424 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2425 variable to fix the build, but this seems to be used when it is still NULL.
2427 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2429 * src/modest-platform.h:
2430 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2431 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2432 * src/modest-main.c: Implement this function so we can avoid using
2433 maemo-specific API from cross-platform code.
2435 * src/modest-tny-account-store.c:
2436 (get_smtp_specific_transport_account_for_open_connection):
2437 * src/modest-ui-actions.c: (check_for_connection),
2438 (modest_ui_actions_on_item_not_found):
2439 Use modest_platform_connect_and_wait() and put #idefs around other
2440 maemo-specific code, because only maemo currently has a way to
2441 identify connection names.
2443 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2445 * src/modest-tny-account-store.h:
2446 * src/modest-tny-account-store.c:
2447 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2448 the connection-specific SMTP server settings in the configuration.
2450 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2452 * src/maemo/modest-main-window.c: (on_connection_changed),
2454 * src/modest-main.c: (main), (start_ui), (send_mail):
2455 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2456 that is what is intended.
2458 * src/modest-ui-actions.c: (action_send), (action_receive),
2459 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2460 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2461 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2462 SMTP server is used when it is specified.
2464 (modest_ui_actions_on_send_receive):
2465 Check that a connection is open before proceeding.
2466 Receive and then send, instead of vice-versa, as per the specification.
2468 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2470 * src/modest-mail-operation.c:
2471 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2472 though I guess it should be something other than NULL.
2474 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2476 * src/maemo/easysetup/modest-easysetup-wizard.c:
2477 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2478 combo twice, to avoid an g_warning and to make it visible again.
2479 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2480 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2481 (already intended) dereference when detaching, because we then recreate the menu.
2482 But I am not sure why the warning was happening, and it is possible that this is a memory
2485 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2487 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2488 and uri_parse_mailto() utility functions.
2489 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2491 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2493 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2495 * src/dbus_api/modest-dbus-api.h:
2496 * src/dbus_api/modest-dbus-callbacks.c:
2497 Use an idle callback to execute the modest code in the application's own thread.
2498 Remove the helloworld example method.
2499 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2500 parsed, and the open-message method is not implemented because this is not yet implemented in
2502 * libmodest-dbus-client/libmodest-dbus-client.c:
2503 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2504 (libmodest_dbus_client_open_message):
2505 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2507 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2508 body without crashing.
2510 * tests/dbus_api/Makefile.am:
2511 * tests/dbus_api/test_mail_to.c:
2512 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2514 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2516 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2517 Added file to fix the build. Sorry.
2519 * src/dbus_api/Makefile.am:
2520 * src/dbus_api/modest-dbus-api.h:
2521 * src/dbus_api/modest-dbus-callbacks.h:
2522 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2523 (modest_dbus_req_handler):
2524 Put constants in a separate header so it can be reused by the
2525 client library, without duplication
2527 * libmodest-dbus-client/Makefile.am:
2528 * libmodest-dbus-client/libmodest-dbus-client.c:
2529 (libmodest_dbus_client_call_helloworld),
2530 (libmodfest_dbus_client_send_mail),
2531 (libmodfest_dbus_client_mailto),
2532 (libmodfest_dbus_client_open_message):
2533 * libmodest-dbus-client/libmodest-dbus-client.h:
2534 (Partly) Implement a send_mail D-Bus method.
2536 * tests/dbus_api/Makefile.am:
2537 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2538 the send_email D-Bus method.
2540 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2544 * libmodest-dbus-client/Makefile.am:
2545 * libmodest-dbus-client/libmodest-dbus-client.c:
2546 * libmodest-dbus-client/libmodest-dbus-client.h:
2547 * tests/dbus_api/Makefile.am:
2548 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2549 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2551 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2553 * src/maemo/easysetup/modest-easysetup-wizard.c:
2554 (create_page_account_details):
2555 * src/maemo/modest-account-settings-dialog.c:
2556 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2557 widgets, because this might not be the default in future versions of the Maemo GTK+.
2558 However, I can not not get capitalization to work even in a simple test case.
2560 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2562 * src/maemo/easysetup/modest-easysetup-wizard.c:
2563 (create_page_custom_incoming), (create_page_custom_outgoing):
2564 * src/maemo/modest-account-settings-dialog.c:
2565 (create_page_account_details), (create_page_incoming),
2566 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2567 instead of using gtk_check_button_with_label(), so they are aligned like the other
2568 widgets, as per the UI spec.
2570 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2572 * src/maemo/easysetup/modest-easysetup-wizard.c:
2573 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2574 * src/widgets/modest-validating-entry.c:
2575 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2576 Modest prefix instead of an EasySetup prefix.
2578 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2580 * src/widgets/modest-validating-entry.h:
2581 * src/widgets/modest-validating-entry.c: (on_insert_text),
2582 Added easysetup_validating_entry_set_max_func(), used to set a callback
2583 to call when the max number of characters is reached. GtkEntry has a max-length
2584 already but is silent about it.
2586 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2587 (create_page_account_details), (create_page_user_details),
2589 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2590 (create_page_account_details), (create_page_user_details),
2591 (create_page_outgoing):
2592 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2593 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2594 the UI spec, when the user tries to enter more than the max number of characters.
2596 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2598 * src/maemo/easysetup/modest-easysetup-wizard.c:
2599 (create_page_user_details), (create_page_custom_incoming),
2600 (create_page_custom_outgoing):
2601 * src/maemo/modest-account-settings-dialog.c:
2602 (create_page_user_details), (create_page_incoming),
2603 (create_page_outgoing):
2604 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2605 (modest_connection_specific_smtp_edit_window_init):
2606 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2607 not appropriate. Bad Maemo-specific defaults!.
2609 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2611 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2612 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2613 (modest_signature_editor_dialog_set_settings):
2614 Disable the label and textview when the checkbox is disabled, and use the
2615 specified (UI spec) default signature text.
2617 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2619 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2620 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2622 * src/modest-defs.h:
2623 * src/modest-account-mgr-helpers.h:
2624 * src/modest-account-mgr-helpers.c:
2625 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2627 * src/maemo/Makefile.am:
2628 * src/maemo/modest-signature-editor-dialog.c:
2629 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2632 * src/maemo/modest-account-settings-dialog.h:
2633 * src/maemo/modest-account-settings-dialog.c:
2634 (modest_account_settings_dialog_finalize), (on_button_signature),
2635 (save_configuration): Use the new dialog when the Edit button is pressed, and
2636 save the changes if necessary, as per the UI spec.
2638 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2640 * src/maemo/Makefile.am:
2641 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2642 based on maemo-develoers email from Dirk.
2644 * src/maemo/easysetup/modest-easysetup-wizard.c:
2645 (create_page_welcome), (create_page_account_details),
2646 (create_page_user_details), (create_page_complete_easysetup),
2647 (create_page_custom_incoming), (create_page_custom_outgoing),
2648 (create_page_complete_custom),
2649 (modest_easysetup_wizard_dialog_init):
2650 * src/maemo/modest-account-settings-dialog.c:
2651 (create_page_account_details), (create_page_user_details),
2652 (create_page_incoming), (create_page_outgoing),
2653 (modest_account_settings_dialog_init):
2654 * src/maemo/modest-connection-specific-smtp-window.c:
2655 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2657 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2659 * src/maemo/easysetup/modest-easysetup-wizard.c:
2660 (create_page_account_details), (create_page_custom_outgoing),
2661 (create_page_complete_custom):
2662 * src/maemo/modest-account-settings-dialog.c:
2663 (create_page_user_details), (create_page_incoming),
2664 (create_page_outgoing):
2665 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2666 (modest_connection_specific_smtp_edit_window_init):
2667 Use the correct (UI spec) port min/max, and use horizontal separators,
2670 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2672 * src/maemo/easysetup/modest-easysetup-wizard.c:
2673 (set_default_custom_servernames):
2674 * src/maemo/modest-account-settings-dialog.c:
2675 (create_page_incoming), (on_combo_outgoing_security_changed),
2676 (on_combo_incoming_security_changed), (create_page_outgoing),
2677 (modest_account_settings_dialog_set_account_name),
2678 (save_configuration):
2679 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2680 (on_combo_security_changed),
2681 (modest_connection_specific_smtp_edit_window_init),
2682 (modest_connection_specific_smtp_edit_window_set_connection),
2683 (modest_connection_specific_smtp_edit_window_get_settings):
2684 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2687 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2690 * src/maemo/easysetup/modest-easysetup-wizard.c:
2691 (create_page_custom_outgoing), (create_page_complete_custom):
2692 * src/maemo/modest-account-settings-dialog.c:
2693 (create_page_user_details), (create_page_outgoing):
2694 * src/maemo/modest-account-view-window.c: (button_box_new):
2695 Use changed logical IDs as per the most recent UI spec:
2696 mcen_bd_emailsetup_edit -> mcen_bd_edit
2697 mcen_bd_emailsetup_delete -> mcen_bd_delete
2698 mcen_bd_emailsetup_close -> mcen_bd_close
2700 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2704 * src/dbus_api/Makefile.am:
2705 * src/dbus_api/modest-dbus-callbacks.c:
2706 * src/dbus_api/modest-dbus-callbacks.h:
2707 * src/maemo/modest-platform.c: (modest_platform_init):
2708 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2710 * tests/Makefile.am:
2711 * tests/dbus_api/Makefile.am:
2712 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2714 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2716 * src/maemo/modest-account-settings-dialog.c:
2717 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2718 Removed unnecessary includes.
2720 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2722 * src/maemo/easysetup/modest-easysetup-wizard.c:
2723 * src/maemo/modest-account-settings-dialog.c:
2724 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2725 * src/widgets/Makefile.am:
2726 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2727 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2728 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2729 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2730 * src/widgets/modest-secureauth-combo-box.c:
2731 * src/widgets/modest-secureauth-combo-box.h:
2732 * src/widgets/modest-serversecurity-combo-box.c:
2733 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2734 made the GObject names more consistent with the rest of the Modest code.
2736 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2738 * src/maemo/easysetup/Makefile.am:
2739 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2740 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2741 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2742 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2743 * src/maemo/easysetup/modest-easysetup-wizard.c:
2744 * src/maemo/easysetup/modest-validating-entry.c:
2745 * src/maemo/easysetup/modest-validating-entry.h:
2746 * src/maemo/modest-account-settings-dialog.c:
2747 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2748 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2749 widgets/ because they are used outside of easysetup too. After checking in,
2750 svn will allow me to rename them too.
2752 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2754 * src/gnome/modest-msg-edit-window.c:
2755 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2756 linker error, to fix the build on the GNOME platform.
2757 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2758 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2759 ifdefed out to avoid a warning.
2761 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2763 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2764 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2765 some alternative for GTK+ 2.6.
2767 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2769 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2771 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2772 specified for EmailAccountsDialog in UI spec.
2774 * src/maemo/easysetup/modest-easysetup-wizard.c:
2775 * src/maemo/easysetup/modest-easysetup-wizard.h:
2776 * src/maemo/modest-account-settings-dialog.c:
2777 * src/maemo/modest-account-settings-dialog.h:
2778 Reuse a member window widget for the connection-specific SMTP server accounts,
2779 so we can tell it to create/save the accounts only if we actually save changes.
2781 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2782 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2783 (modest_connection_specific_smtp_edit_window_get_settings):
2784 Return a struct instance for temporarily remembering the entered data.
2786 * src/maemo/modest-connection-specific-smtp-window.h:
2787 * src/maemo/modest-connection-specific-smtp-window.c:
2788 (modest_connection_specific_smtp_window_finalize),
2789 (modest_connection_specific_smtp_window_fill_with_connections),
2791 (modest_connection_specific_smtp_window_save_server_accounts),
2792 (update_model_server_names): Do not actually save data until asked,
2793 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2795 (on_selection_changed),
2796 (modest_connection_specific_smtp_window_init): Disable the edit
2797 button when nothing is selected.
2799 * src/modest-account-mgr-helpers.c:
2800 * src/modest-account-mgr-helpers.h:
2801 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2804 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2806 * src/modest-account-mgr-helpers.h:
2807 * src/modest-account-mgr-helpers.c:
2808 (modest_account_mgr_get_unused_account_name),
2809 (modest_account_mgr_get_unused_account_display_name): Added these
2810 utility functions, to avoid code duplication.
2812 * src/maemo/easysetup/modest-easysetup-wizard.c:
2813 (create_page_account_details), (create_account):
2814 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2815 (on_combo_security_changed),
2816 (modest_connection_specific_smtp_edit_window_init),
2817 (modest_connection_specific_smtp_edit_window_save_settings):
2818 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2819 * src/maemo/modest-connection-specific-smtp-window.c:
2820 (modest_connection_specific_smtp_window_finalize),
2821 (modest_connection_specific_smtp_window_fill_with_connections),
2822 (on_button_edit), (modest_connection_specific_smtp_window_init):
2823 * src/maemo/modest-connection-specific-smtp-window.h:
2824 Implementing saving of connection-specific server accounts.
2826 But I need to refactor this so we can save the data for each
2827 possible connection-specific account and only actually create the server accounts
2828 when the easysetup finished, or the OK button is pressed on the account settings
2831 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2833 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2834 (on_combo_security_changed):
2835 (modest_connection_specific_smtp_edit_window_init):
2836 Auto-fill the port number as in the account settings.
2838 (modest_connection_specific_smtp_edit_window_set_connection):
2839 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2840 * src/maemo/modest-connection-specific-smtp-window.c:
2841 (fill_with_connections), (on_button_edit),
2842 (modest_connection_specific_smtp_window_init):
2843 Turn the edit window into a dialog to simplify the code, and
2844 set a WM hint as in a GtkDialog, because only a popup can be on top of
2845 another window in Maemo, and popups usually have no WM decoration.
2847 * src/modest-defs.h:
2848 * src/modest-account-mgr-helpers.c:
2849 (modest_account_mgr_set_connection_specific_smtp),
2850 (modest_account_mgr_remove_connection_specific_smtp),
2851 (modest_account_mgr_get_connection_specific_smtp):
2852 * src/modest-account-mgr-helpers.h: Some functions to write the
2853 connection-specific SMTP server information. Not yet used.
2856 * src/widgets/modest-folder-view.c: (text_cell_data):
2857 Fix a warning about an uninitialized variable.
2858 (on_configuration_key_changed): Put an #ifdef around the use
2859 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2861 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2863 * src/maemo/modest-account-settings-dialog.h:
2864 * src/maemo/modest-account-settings-dialog.c:
2865 Added connect_for_modified() utility function to mark the new modified boolean.
2867 (create_page_account_details), (create_page_user_details),
2868 (create_page_incoming), (create_page_outgoing), (on_response),
2869 (modest_account_settings_dialog_init),
2870 (modest_account_settings_dialog_set_account_name):
2871 Only warn about unsaved changes when there are actually unsaved changes.
2873 * src/modest-account-mgr-helpers.c:
2874 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2875 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2876 to get the data from there in future.
2878 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2880 * src/modest-defs.h:
2882 * src/modest-account-mgr-helpers.h:
2883 * src/modest-account-mgr-helpers.c:
2884 Store the security account setting in a single conf key instead of using
2885 the options list, so that the list is left for just the to-be-removed camel hack,
2886 and because gconf_client_set_list() is failing for some reason.
2888 * src/modest-account-mgr.c:
2889 (modest_account_mgr_add_server_account):
2890 * src/maemo/modest-account-settings-dialog.c:
2891 (modest_account_settings_dialog_set_account_name),
2892 (save_configuration): Use the renamed functions.
2895 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2897 * src/widgets/Makefile.am:
2898 * src/widgets/modest-limit-retrieve-combo-box.c:
2899 * src/widgets/modest-limit-retrieve-combo-box.h:
2900 * src/widgets/modest-retrieve-combo-box.c:
2901 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2902 the account settings dialog.
2904 * src/modest-defs.h:
2905 * src/modest-account-mgr-helpers.h:
2906 * src/modest-account-mgr-helpers.c:
2907 (modest_server_account_get_option_secure_auth),
2908 (modest_server_account_set_option_secure_auth):
2909 * src/modest-account-mgr.c:
2910 (modest_account_mgr_add_server_account):
2911 Use the existing AUTH_MECH conf key for the secure-auth setting,
2912 instead of putting it in the list options, because this was actually used already.
2914 * src/maemo/modest-account-settings-dialog.c:
2915 (create_page_account_details),
2916 (modest_account_settings_dialog_set_account_name),
2917 (save_configuration):
2918 * src/maemo/modest-account-settings-dialog.h:
2919 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2920 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2922 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2924 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2925 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2926 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2928 * src/modest-defs.h:
2929 * src/maemo/modest-account-settings-dialog.c:
2930 (create_page_incoming), (on_combo_outgoing_security_changed),
2931 (on_combo_incoming_security_changed), (create_page_outgoing),
2932 (modest_account_settings_dialog_set_account_name),
2933 (save_configuration): Load/Save the port number, and change it when the
2934 security combo changes, to suitable defaults.
2936 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2938 * src/modest-account-mgr.c:
2939 (modest_account_mgr_add_server_account): Set the security and secure-auth
2940 options, and add a comment saying that the other camel-specific options should be
2943 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2945 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2947 * src/modest-tny-account-store.c: (account_list_free),
2948 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2949 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2952 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2954 * src/modest-protocol-info.c:
2955 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2956 is required by our UI spec. Maybe something in our implementation will use this eventually.
2957 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2958 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2959 instead of the previous 0 placeholder.
2961 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2962 secure-auth settings.
2963 * src/modest-account-mgr-helpers.h:
2964 * src/modest-account-mgr-helpers.c:
2965 (modest_server_account_data_get_option_secure_auth),
2966 (modest_server_account_set_option_secure_auth),
2967 (modest_server_account_data_get_option_security),
2968 (modest_server_account_set_option_security): Added this API for getting and setting the security
2969 and secure-auth settings.
2971 * src/maemo/modest-account-settings-dialog.h:
2972 * src/maemo/modest-account-settings-dialog.c:
2973 (modest_account_settings_dialog_finalize), (check_data),
2974 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2975 about changing titles.
2976 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2977 (save_configuration): Save the security and secure-auth settings.
2979 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2980 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2982 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2984 * src/modest-defs.h:
2985 * src/modest-account-mgr.c:
2986 (modest_account_mgr_add_server_account):
2987 Added and used defines for the options key and value pair strings,
2988 that are used so far, though they do not seem to correspond to anything in our
2989 UI specs or ModestProtocol enum.
2991 * src/modest-account-mgr-helpers.h:
2992 * src/modest-account-mgr-helpers.c:
2993 (compare_option_strings_for_name),
2994 (modest_server_account_data_get_option_value),
2995 (modest_server_account_data_get_option_bool),
2996 (modest_account_mgr_get_server_account_option):
2997 Added helper functions for parsing the options GSList.
2999 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3001 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3002 display name is based on the supplied account name.
3003 * src/modest-account-mgr.c:
3004 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3005 with an inefficient, but good-enough, implementation.
3007 * src/maemo/easysetup/modest-easysetup-wizard.c:
3008 (create_page_account_details), (on_before_next), (create_account):
3009 Check for existing display names rather than (non-user-visible) account names, and just
3010 create and set a unique account name at the end.
3012 * src/maemo/modest-account-settings-dialog.c:
3013 (modest_account_settings_dialog_init),
3014 (modest_account_settings_dialog_set_account_name),
3015 (create_page_incoming): Show the display name, instead of the account name.
3016 (on_response): Do some (not all) extra checks, as in the UI spec.
3017 (save_configuration): Save the display name if it was changed.
3019 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3021 * po/en_GB.po: Added needed logical ID and translation.
3022 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3023 (init_view): Made the is-default column clicking work.
3025 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3028 * src/maemo/easysetup/Makefile.am:
3029 * src/maemo/easysetup/modest-easysetup-wizard.c:
3030 (modest_easysetup_wizard_dialog_init):
3031 * src/maemo/easysetup/provider-data-test.keyfile:
3032 * src/maemo/easysetup/provider-data.keyfile:
3033 Moved the provider data file to the new modest-providers-data package and used it from there.
3035 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3037 * src/modest-local-folder-info.c:
3038 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3039 N_() was already used on the static strings, but this just marks it for translation without
3040 using the translation.
3042 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3044 * src/maemo/modest-account-settings-dialog.c:
3045 (create_page_incoming),
3046 (modest_account_settings_dialog_set_account_name):
3047 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3048 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3049 I will do this if nobody else gets there first.
3051 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3053 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3054 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3055 save the security stuff.
3057 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3059 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3060 Set the email address and user fullname, which I now see must be
3063 * src/maemo/modest-account-settings-dialog.h:
3064 * src/maemo/modest-account-settings-dialog.c:
3066 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3067 leave-on-server and authentication.
3068 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3071 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3074 * src/maemo/modest-account-settings-dialog.c:
3075 * src/maemo/modest-account-settings-dialog.h:
3076 Most (but not all) of the widgets are now present as specified by the UI spec.
3077 No changes are yet saved, and some details are not properly shown yet.
3079 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3081 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3083 * src/maemo/Makefile.am:
3084 * src/maemo/modest-account-settings-dialog.c:
3085 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3086 an existing account. Doesn't do much yet.
3088 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3089 Open the accounts settings dialog when Edit is clicked.
3091 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3093 * src/maemo/easysetup/Makefile.am:
3094 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3096 * src/maemo/easysetup/modest-easysetup-wizard.c:
3097 (modest_easysetup_wizard_dialog_init):
3098 Try to get the source directory from the build system,
3099 instead of hard-coding "./" into the source code, when opening our local
3100 copies of the configuration files.
3101 But this still fails when opening the wizard from the Accounts window,
3102 maybe because the working directory seems to change at runtime.
3103 So the wizard will fail the second time unless you copy the files into their
3104 proper locations - see the stdout warnings for the paths.
3106 (create_page_account_details),(on_before_next):
3107 Check for existing non-server accounts instead of server accounts,
3108 so the default account name is useful again, and to prevent trying to
3111 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3112 Show the wizard when New is clicked.
3114 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3115 (init_view): Show the column headers, and show the columns that are
3116 specified in the UI specs. However, something in Maemo's GTK+ prevents
3117 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3118 change the default account. This is despite unsetting the special properties.
3120 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3122 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3123 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3124 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3125 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3126 to make that clearer.
3127 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3129 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3131 * src/maemo/modest-account-view-window.c:
3132 (modest_account_view_window_init),
3133 (modest_account_view_window_new):
3134 Use the same buttons as specified in the
3135 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3136 the existing widgets, which never had a chance of working.
3137 Put the ModestAccountView treeview in a scrolled window.
3138 Do not repeat the initialization in both _init() and _new().
3140 * src/widgets/modest-account-view.c: (update_account_view):
3141 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3142 this widget and window shows no accounts.
3144 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3146 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3148 * src/maemo/easysetup/modest-easysetup-wizard.c:
3149 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3150 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3151 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3154 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3155 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3156 accounts exist yet, as in the UI spec.
3158 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3160 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3162 * src/maemo/Makefile.am:
3163 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3164 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3165 New window for editing connection-specific smtp details.
3166 Not fully implemented.
3168 * src/maemo/modest-connection-specific-smtp-window.c:
3169 (modest_connection_specific_smtp_window_finalize) :
3170 unref the tree model.
3171 (on_button_edit): Show the edit window.
3173 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3175 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3178 * src/maemo/Makefile.am:
3179 * src/maemo/modest-connection-specific-smtp-window.c:
3180 * src/maemo/modest-connection-specific-smtp-window.h:
3181 New window for showing the list of connections, for connection-specific
3182 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3183 * src/maemo/easysetup/modest-easysetup-wizard.c:
3184 (create_page_custom_outgoing): Show the new window when the button is clicked.
3186 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3188 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3189 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3190 * src/maemo/modest-msg-edit-window.c:
3191 (modest_msg_edit_window_insert_image):
3192 * src/modest-conf.c: (modest_conf_key_escape):
3193 * src/modest-mail-operation.c:
3194 (modest_mail_operation_send_new_mail):
3195 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3196 (modest_ui_actions_on_new_account):
3197 * src/widgets/modest-attachment-view.c: (update_filename_request):
3198 * src/widgets/modest-mail-header-view.c:
3199 Corrected warnings that were breaking the build, by commenting out unused variables,
3200 and a function, and by including a header.
3202 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3204 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3205 so we can #ifdef around platform-specific code when necessary.
3206 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3207 to allow this to build for the GNOME platform too.
3209 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3211 * src/maemo/easysetup/modest-easysetup-wizard.c:
3212 Added util_increment_name() and used it in create_page_account_details()
3213 to make sure that the default account name is always a new name.
3215 (modest_easysetup_wizard_dialog_init),
3216 (set_default_custom_servernames): Some minor memory management fixes.
3218 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3222 * src/modest-runtime.c: (init_i18n): Restored the translation
3223 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3224 are defined in config.h, and the translations are installed.
3226 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3227 is defined for translation.
3229 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3231 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3233 * src/maemo/easysetup/modest-easysetup-wizard.c:
3234 (modest_easysetup_wizard_dialog_init):
3235 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3236 Use realistic paths (though they should use $prefix generically) to the
3237 mcc_mapping and provider-data.keyfile files which might work when they
3238 are installed by the future version of the operator-wizard package,
3239 and then fallback to paths in our source code, with an explanatory
3242 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3246 * src/maemo/Makefile.am:
3247 * src/maemo/easysetup/: Added files from the previously-exernal
3248 osso-modest-easysetup.
3249 * src/maemo/modest-main-window-ui.h:
3250 * src/modest-ui-actions.c:
3251 * src/modest-ui-actions.h:
3252 Added modest_ui_actions_on_new_account() as a signal handler for the
3253 New Account menu item. It shows the easysetup wizard.
3254 * po/en_GB.po: Added additional needed logical IDs and translations.