1 2007-07-12 Armin Burgmeier <armin@openismus.com>
3 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
5 * src/modest-mail-operation.c:
6 * src/modest-ui-actions.c: Check for already existing folder before
7 querying the server, show error message from camel if the request
8 still fails. This fixes projects.maemo.org bug NB#58701.
10 2007-07-12 Murray Cumming <murrayc@murrayc.com>
12 * src/modest-tny-account-store.h:
13 * src/modest-tny-account-store.c:
14 Added modest_tny_account_store_forget_password_in_memory(),
15 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
16 when creating a new account, so that new passwords will be used, instead of
17 us thinking that it's a second request as a result of a failed password again.
19 2007-07-12 Murray Cumming <murrayc@murrayc.com>
21 * src/dbus_api/modest-dbus-callbacks.c:
22 (on_idle_open_message): If the message is in drafts then open it
23 in an edit window instead of a view window. This fixes
24 projects.maemo.org bug NB#63005.
26 2007-07-12 Murray Cumming <murrayc@murrayc.com>
28 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
29 Avoided a harmless g_warning().
31 2007-07-12 Murray Cumming <murrayc@murrayc.com>
33 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
34 Pass the modest account name, not the TnyAccount display name to
35 modest_msg_view_window_new() so that the reply feature works,
36 fixing projects.maemo.org bug NB#62892.
38 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
39 (modest_msg_view_window_new_with_header_model):
40 * src/maemo/modest-msg-view-window.c:
41 (modest_msg_view_window_new_with_header_model),
42 (modest_msg_view_window_new):
43 * src/modest-ui-actions.c: (reply_forward):
44 * src/widgets/modest-msg-view-window.h:
45 * src/widgets/modest-window.c: (modest_window_set_active_account):
46 Rename an account parameter to modest_account_name to make this clearer.
48 2007-07-11 Murray Cumming <murrayc@murrayc.com>
50 * src/modest-ui-actions.h:
51 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
52 modest_do_message_delete().
53 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
54 Call modest_do_message_delete(), hoping that this would cause messages
55 to be really deleted from search instead of just marked with strike through.
56 Does not seem to help.
58 2007-07-11 Armin Burgmeier <armin@openismus.com>
60 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
61 priv->reselect to FALSE prior to calling
62 modest_folder_view_select_first_inbox_or_local() to prevent endless
63 recursion and thus a crash on startup.
65 2007-07-11 Armin Burgmeier <armin@openismus.com>
67 * src/maemo/modest-account-settings-dialog.h: Include
68 <gtk/gtknotebook.h> to fix the build (at least for me).
70 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
71 Use "New FolderN" as default suggested name if "New folder" already
72 exists, with N being the first free number, though never exceed "New
73 folder99" in which case we just fall back to "New Folder" even though
74 it already exists. This fixes projects.maemo.org bug NB#58663.
76 2007-07-11 Murray Cumming <murrayc@murrayc.com>
78 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
79 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
80 projects.maemo.org bug NB#62778.
82 2007-07-11 Murray Cumming <murrayc@murrayc.com>
84 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
85 Ignore the wrong (for now) secure-smtp setting in the presets -
86 just default to requiring secure authentication for SMTP, because
89 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
91 * src/widgets/modest-folder-view.c: (filter_row)
92 Do not show drafts folder (see UI specs)
94 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
96 * src/modest-ui-actions.c:
97 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
98 place and also not necessary.
100 * src/widgets/modest-folder-view.c: (filter_row)
101 Guess folder type and hide Sent & Outbox if necessary.
102 Fixed project.maemo.org NB#57328
104 2007-07-11 Murray Cumming <murrayc@murrayc.com>
106 * src/modest-ui-actions.h:
107 * src/modest-ui-actions.c:
108 (modest_ui_actions_on_delete_message):
109 Move some code into a new
110 modest_ui_actions_refresh_message_window_after_delete()
111 function so we can use it from elsewhere.
113 * src/dbus_api/modest-dbus-callbacks.c:
114 (on_idle_delete_message), (on_delete_message): Used an idle
115 handler, as we do for the other D-Bus method handlers.
116 Call modest_ui_actions_refresh_message_window_after_delete()
117 if the deleted message was open in a window. This fixed
118 projects.maemo.org bug NB#62862.
120 2007-07-11 Murray Cumming <murrayc@murrayc.com>
122 * src/modest-main.c: (main): Only show the UI at the start if
123 the showui command line option was given. For instance,
124 run-standalone src/modest showui
125 Otherwise, we wait for the top_application D-Bus method to
126 be sent by hildon-desktop when the application is selected
128 This allows us to run without a UI when osso-global-search
129 uses our D-Bus methods.
131 2007-07-11 Murray Cumming <murrayc@murrayc.com>
133 * src/dbus_api/modest-dbus-api.h: Added a define for a
134 top-application D-Bus method.
135 * src/dbus_api/modest-dbus-callbacks.c:
136 (on_top_application),
137 (modest_dbus_req_handler): Handle the top-application D-Bus
138 method, which might be an undocumented D-Bus signal sent by
139 hildon-desktop when it starts the application from the menu.
140 But I am not sure and I need to test it on the device, because
141 my scratchbox does not have the application in the menu now.
142 This method shows the main window, so that it can be invisible
143 when started, for instance, just for email searching from
146 * src/maemo/modest-main-window.c: (restore_settings),
147 (modest_main_window_new): Do not show the window immediately
148 upon creation. We show it later.
149 * src/modest-widget-memory.c: (save_settings_paned):
150 Try (unsuccessfully) to avoid saving the paned position when
151 it is not even visible.
152 (restore_settings_paned): Do not allow a silly paned position.
153 This seems necessary when not showing the window at first.
155 * tests/dbus_api/Makefile.am:
156 * tests/dbus_api/test_top_application.c: (main): Test for the
159 2007-07-10 Murray Cumming <murrayc@murrayc.com>
161 * src/modest-ui-dimming-rules.c:
162 (modest_ui_dimming_rules_on_new_msg),
163 (modest_ui_dimming_rules_on_reply_msg),
164 (modest_ui_dimming_rules_on_delete_msg),
165 (modest_ui_dimming_rules_on_details),
166 (modest_ui_dimming_rules_on_view_window_move_to),
167 (modest_ui_dimming_rules_on_view_previous),
168 (modest_ui_dimming_rules_on_view_next),
169 (_invalid_folder_for_purge): Added checks before
170 casting the window. This looks like an actual
171 logic error in _invalid_folder_for_purge(), because it
172 tries to use a ModestMainWindow as a message window.
174 2007-07-10 Murray Cumming <murrayc@murrayc.com>
176 * src/maemo/modest-account-settings-dialog.c:
177 (show_error): Use the same implementation as in
178 modest-easysetup-wizard.c:
179 (on_entry_invalid_character): The logical ID contains a %s.
180 Guessed what it should be.
181 (on_entry_max), (check_data), (on_response): Adapt to
182 changed show_error().
183 (create_page_account_details): Really call
184 modest_validating_entry_set_func() on the correct widgets.
185 * src/maemo/easysetup/modest-easysetup-wizard.c:
186 (on_entry_invalid_character): Fix the logical ID here too.
187 (create_page_account_details),
188 (create_page_user_details):
190 modest_validating_entry_set_func() on the correct widgets.
192 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
193 Do not try to use the account if it is NULL.
195 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
197 * src/modest-ui-actions.c: (create_move_to_dialog),
198 (modest_ui_actions_on_main_window_move_to),
199 (modest_ui_actions_on_msg_view_window_move_to):
200 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
201 (filter_row), (modest_folder_view_show_non_move_folders):
202 * src/widgets/modest-folder-view.h:
204 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
205 the Sent folder yet as it does not report the correct folder type.
207 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
209 * src/maemo/modest-msg-edit-window.c: (init_window):
212 2007-07-10 Murray Cumming <murrayc@murrayc.com>
214 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
215 Take a parent widget instead of a parent window, and
216 implement this with hildon_banner_show_information() instead.
217 Non-Maemo builds can just ifdef that there.
218 This fixed projects.maemo.org bug NB#62766.
220 (on_entry_invalid_character): Use show_error() again instead
221 of using hildon directly, and use the _CS() macro to use the correct
223 (create_account), (check_for_supported_auth_methods), (on_entry_max):
224 Pass a widget instead od a window to show_error().
226 2007-07-10 Murray Cumming <murrayc@murrayc.com>
228 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
229 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
230 This allows us to show the server name in the error message, fixing
231 projects.maemo.org bug NB#62904.
232 Also, use the appropriate logical ID message for the account protocol.
234 2007-07-10 Murray Cumming <murrayc@murrayc.com>
236 * src/modest-tny-account-store.c: (on_idle_wrong_password):
237 A compilation fix, though the build wasn't broken for me.
239 2007-07-09 Murray Cumming <murrayc@murrayc.com>
241 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
242 Do not try to unref a NULL folder store, to avoid a runtime warning.
243 This seems to happen sometimes when changing accounts settings.
245 2007-07-09 Murray Cumming <murrayc@murrayc.com>
247 * src/modest-tny-account-store.c:
248 (modest_tny_account_store_instance_init),
249 (modest_tny_account_store_finalize),
250 (on_account_settings_hide), (on_idle_wrong_password):
251 Use a GHashTable to ensure that we only show one account settings
252 dialog per modest account. This avoids us having a dialog open for
253 both the store and transport accounts, or due to repeated get_password()
254 calls that shouldn't happen anyway.
256 2007-07-09 Murray Cumming <murrayc@murrayc.com>
258 * src/maemo/modest-maemo-utils.c: (on_hide),
259 (modest_maemo_show_dialog_and_forget): Handle the response, because
260 the window is not even hidden by default.
262 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
263 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
264 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
265 which seems to prevent some modality problems.
267 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
268 Ignore user cancellation errors.
270 * src/modest-account-mgr-helpers.h:
271 * src/modest-account-mgr-helpers.c:
272 Added modest_server_account_get_password() and
273 modest_server_account_get_has_password() to avoid direct use of
276 * src/maemo/modest-account-settings-dialog.h:
277 * src/maemo/modest-account-settings-dialog.c:
278 (modest_account_settings_dialog_init): Store the notebook so we can
280 Added modest_account_settings_dialog_switch_to_user_info().
282 * src/modest-tny-account-store.c:
283 (get_password): When the password in the account settings is wrong (we think),
284 show the relevant page of the account settings dialog, in the mainloop.
285 However, we currently get many of these at once because cancel does not
287 (forget_password): Do not forget the password
288 from the account settings, because this causes side-effects when
289 tinymail seems to call it at strange time, maybe because of how we
290 are cancelling get_password().
291 (modest_tny_account_store_alert): Ignore user cancellations.
293 2007-07-09 Murray Cumming <murrayc@murrayc.com>
295 * src/maemo/modest-maemo-utils.h:
296 * src/maemo/modest-maemo-utils.c:
297 Added modest_maemo_show_information_note_and_forget() for use instead of
298 gtk_dialog_run() when the response is not needed, to avoid an extra
299 mainloop which could cause a hang.
301 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
302 Use the logical IDs for the error message, though they are not
303 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
304 because gtk_dialog_run() caused a hang here (the window did not close).
305 This fixes projects.maemo.org bug NB#62646.
307 2007-07-09 Murray Cumming <murrayc@murrayc.com>
309 * src/modest-account-mgr-helpers.h:
310 * src/modest-account-mgr-helpers.c:
311 Added modest_account_mgr_get_store_protocol().
313 * src/maemo/modest-account-view-window.c:
314 (on_delete_button_clicked): Show different warning text depending on
315 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
316 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
319 2007-07-09 Murray Cumming <murrayc@murrayc.com>
321 * src/maemo/modest-msg-edit-window.c:
322 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
323 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
325 2007-07-07 Armin Burgmeier <armin@openismus.com>
327 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
328 ckdg_ib_maximum_characters_reached from correct package.
330 * src/modest-ui-actions.c: Show an error message when a folder could
331 not be created. Tinymail does not give us specific error codes about
332 what has gone wrong, so we assume that a folder with that name
333 already exists, though there might be other reasons.
335 2007-07-06 Murray Cumming <murrayc@murrayc.com>
337 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
338 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
339 give a more exact error message that can be partly translated.
341 2007-07-05 Murray Cumming <murrayc@murrayc.com>
343 * src/maemo/modest-address-book.c:
344 (select_email_addrs_for_contact): Specify a default window size for the
345 select-email-address dialog, so that it is probably big enough for the
346 title. This should fix projects.maemo.org bug NB#62277.
348 2007-07-05 Murray Cumming <murrayc@murrayc.com>
350 * src/maemo/easysetup/modest-easysetup-wizard.c:
351 (create_page_complete_easysetup): Use
352 gtk_widget_set_size() request to ensure that the text wraps
355 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
357 * src/maemo/easysetup/modest-easysetup-wizard.c:
358 (on_entry_invalid_character), (create_page_account_details),
359 (create_page_user_details):
360 Use new API of ModestValidatingEntry. But for some reason the banner is
361 not shown. I will have to investigate that further.
363 * src/widgets/modest-validating-entry.c: (on_insert_text),
364 (modest_validating_entry_set_func):
365 * src/widgets/modest-validating-entry.h:
366 Added a new callback function to be able to react to prevented
367 characters whitespaces to e.g show a banner.
369 2007-07-05 Armin Burgmeier <armin@openismus.com>
371 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
372 notification of HildonNumberEditor instead of remembering the port
373 number. Thanks to Johannes for pointing this out.
375 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
377 * src/maemo/easysetup/modest-easysetup-wizard.c:
378 Check if there are any user changes before showing a confirmation
379 dialog (projects.maemo.org NB#60946)
381 2007-07-05 Armin Burgmeier <armin@openismus.com>
383 * src/maemo/modest-account-settings-dialog.c: Remember custom port
384 number at the beginning of the dialog and set the modified flag at the
385 end if the port number has changed. This is necessary because
386 HildonNumberEditor does not support notification when the value has
389 2007-07-05 Murray Cumming <murrayc@murrayc.com>
391 * src/modest-ui-actions.c:
392 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
393 a connection before asking anything else. Correct the check for the destination
394 folder so that it succeeds when online.
395 This fixed projects.maemo.org bug NB#61645.
397 2007-07-05 Murray Cumming <murrayc@murrayc.com>
399 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
400 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
401 to fix projects.maemo.org bug NB#62439.
403 2007-07-05 Murray Cumming <murrayc@murrayc.com>
405 * src/modest-tny-account.c: (on_connection_status_changed):
406 Really do not use tny_device_force_offline() here. See the previous comment.
408 2007-07-04 Murray Cumming <murrayc@murrayc.com>
410 * src/modest-tny-account.c: (on_connection_status_changed):
411 Do not use tny_device_force_offline() when tinymail says that something
412 went wrong with the connection. It seems to report this unnecessarily.
414 2007-07-04 Murray Cumming <murrayc@murrayc.com>
416 * src/maemo/modest-connection-specific-smtp-window.c:
417 (modest_connection_specific_smtp_window_init):
418 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
419 does not seem to have any effect in osso 1.1 (though it works in
420 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
422 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
424 * src/maemo/modest-connection-specific-smtp-window.c:
425 Fix UI specification problems with projects.meamo.org NB#60479
427 2007-07-04 Murray Cumming <murrayc@murrayc.com>
429 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
430 clue when this has failed, because the error dialog is not always shown
431 (at least in earlier version).
433 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
434 GError message, because the generic error dialog is not helpful.
436 'This message is not currently available (can't let a new connection go online)'
437 when trying to open an IMAP message.
439 (_modest_ui_actions_open): Offer a connection when some messages would
440 have to be downloaded and we are offline.
442 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
444 * src/widgets/modest-folder-view.c:
445 Don't check for MERGE type anymore as we use the correct type
447 NOTE: For the last two changes you need to update your tinymail copy
448 because of API changes!
450 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
452 * src/modest-tny-local-folders-account.c:
453 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
454 (see projects.maemo.org NB#61580)
456 2007-07-04 Murray Cumming <murrayc@murrayc.com>
458 * src/modest-tny-account.c: (on_connection_status_changed):
459 Commented out the call to modest_platform_connect_and_wait() because this
460 seems to always hang, and I would like to know if this is the only thing
461 that causes a hang when showing the connection dialog.
462 It is not very useful anyway.
464 2007-07-04 Murray Cumming <murrayc@murrayc.com>
466 * src/maemo/modest-msg-view-window.c:
467 (modest_msg_view_window_select_next_message):
469 * src/modest-platform.h:
470 * src/maemo/modest-platform.c:
471 Added modest_platform_connect_and_wait(), which calls
472 tny_maemo_conic_device_connect() always in the main thread, by calling it
473 in an idle handler and waiting for the idle handler to run. It should be
474 in the main thread because it uses GTK+ UI code. It just returns TRUE
475 if the device is already online.
477 There is some nasty code to ensure that subsequent calls to
478 modest_platform_connect_and_wait() just wait for the first one to finish,
479 by checking repeatedly in another idle handler. This is necessary,
480 because other threads (or even the main thread, via another idle handler)
481 can call modest_platform_connect_and_wait() while
482 modest_platform_connect_and_wait() is running.
484 (modest_platform_connect_and_wait_if_network_account),
485 (modest_platform_connect_and_wait_if_network_folderstore):
486 Convenience functions that calls modest_platform_connect_and_wait() if
487 the account or folder might want network access.
489 * src/modest-mail-operation.c:
490 (modest_mail_operation_update_account):
491 * src/modest-ui-actions.c: (download_uncached_messages),
492 (modest_ui_actions_on_rename_folder), (delete_folder),
493 (modest_ui_actions_on_main_window_move_to),
494 (modest_ui_actions_on_msg_view_window_move_to):
495 * src/widgets/modest-folder-view.c:
496 (drag_and_drop_from_folder_view):
497 Offer a connection if we are offline.
499 * src/modest-tny-account.c: (on_connection_status_changed):
500 Document this as only handling errors during network operations in progress,
501 and replace the idle code with a simple call to
502 modest_platform_connect_and_wait(), which does this instead.
504 2007-07-03 Murray Cumming <murrayc@murrayc.com>
506 * src/modest-tny-account.c:
507 (modest_tny_account_get_special_folder): (util_on_idle),
508 Handle the GError so we can see when tny_folder_store_get_folders()
509 fails, as it currently does while something else is connecting.
511 Added util_run_in_main_thread_and_wait()
512 which uses an idlen handler and mainloop to ensure that the function
513 is called in the main thread.
514 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
515 to make sure that we call attempt the connection in the mainloop only,
516 which might solve some hangs.
518 2007-07-03 Murray Cumming <murrayc@murrayc.com>
520 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
521 be found by their display name. This is never useful.
522 * src/modest-tny-account-store.c: (on_account_removed): Find the account
523 by its ID, instead of trying to use its ID as its display name.
525 * src/modest-tny-account-store.h:
526 * src/modest-tny-account.c:
527 (modest_tny_account_get_special_folder): Add a g_warning() when
528 tny_folder_store_get_folders() returns an empty list for the maildir.
530 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
531 Add a g_warning() when this returns NULL, because that it not allowed
534 2007-07-02 Armin Burgmeier <armin@openismus.com>
536 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
537 note when trying to cancel the wizard. This fixes projects.maemo.org
540 2007-07-02 Murray Cumming <murrayc@murrayc.com>
542 * src/modest-tny-account.h:
543 * src/modest-tny-account.c:
544 (modest_tny_account_new_from_server_account),
545 (modest_tny_account_new_from_server_account_name),
546 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
547 because this must now be set before setting the proto. This is usd in
548 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
549 warning in camel_session_get_service() caused by
550 tny_camel_transport_account_prepare().
552 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
555 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
557 * src/maemo/modest-connection-specific-smtp-edit-window.c:
559 (modest_connection_specific_smtp_edit_window_init):
561 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
564 2007-06-29 Murray Cumming <murrayc@murrayc.com>
566 * src/modest-tny-account.c:
567 (modest_tny_account_new_from_server_account):
568 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
569 now uses to request a connection when it needs one, and which it uses
570 to tell us that something is wrong with the connection, so we can force
571 the accounts offline to prevent further problems.
574 * src/modest-init.c: (init_default_settings):
575 * src/modest-mail-operation.c:
576 (modest_mail_operation_update_account):
577 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
578 This should not be necessary anymore. Do not set the conf key that
579 determined this (it was always TRUE and not set anywhere else).
581 * src/modest-ui-actions.h: Remove unused and unimplemented
582 modest_ui_actions_on_online_toggle_toggled().
584 2007-06-29 Murray Cumming <murrayc@murrayc.com
586 * src/maemo/modest-main-window.c: (connect_signals):
587 Don't connect to delete_event twice. Maybe this was harmless.
589 2007-06-29 Murray Cumming <murrayc@murrayc.com
591 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
592 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
593 Debug output to give some more clue when a folder move is not allowed.
595 2007-06-28 Murray Cumming <murrayc@murrayc.com
597 * src/modest-tny-account.c: (on_modest_file_system_info),
598 (modest_tny_account_get_mmc_account_name):
599 Always call the callback, without checking whether the name has changed.
600 * src/widgets/modest-folder-view.c: (strings_are_equal),
601 (on_model_foreach_set_name), (on_get_mmc_account_name),
602 (text_cell_data): Compare the name here, and use the name from
603 the account rather than from the
604 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
605 if the name was changed after the account was added to the model.
606 That's a tinymail bug but not one that I want to fix now.
608 This finally fixes projects.maemo.org bug NB#59301.
610 2007-06-27 Armin Burgmeier <armin@openismus.com>
612 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
615 2007-06-27 Murray Cumming <murrayc@murrayc.com
617 * src/modest-tny-account.h:
618 * src/modest-tny-account.c:
619 Added modest_tny_account_get_mmc_account_name(), to set the memory
620 card name asynchronously for the given account and then notify.
621 (modest_tny_account_new_for_local_folders): Use this new function instead
622 of using hildon_file_system_info_async_new() directly.
624 * src/widgets/modest-folder-view.c: (text_cell_data):
625 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
626 gtk_tree_model_row_changed() when it is available.
628 This should fix projects.maemo.org bug NB#59301.
630 2007-06-27 Murray Cumming <murrayc@murrayc.com
632 * src/modest-mail-operation.c: (update_account_thread),
633 (get_msgs_full_thread): Fix typo failures in the revert
636 2007-06-27 Murray Cumming <murrayc@murrayc.com
638 * src/maemo/modest-maemo-global-settings-dialog.c:
639 (idle_select_default_focus):
640 * src/modest-mail-operation.c: (idle_notify_progress),
641 (idle_notify_progress_once), (set_last_updated_idle),
642 (update_account_thread), (get_msgs_full_thread):
643 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
644 * src/widgets/modest-header-view.c:
645 (idle_notify_headers_count_changed_destroy),
646 (idle_notify_headers_count_changed):
647 Reverted the additions of gdk_threads_enter/leave(), in case this
648 helps with a startup hang on the device.
650 2007-06-26 Armin Burgmeier <armin@openismus.com>
652 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
653 for supported secure authentication methods from server by
654 gtk_dialog_run(), saving CPU time and a potential race condition.
656 2007-06-26 Armin Burgmeier <armin@openismus.com>
658 * src/maemo/modest-maemo-utils.h:
659 * src/maemo/modest-maemo-utils.c: Added a
660 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
661 only error code to tell the calling code when the user canceled the
664 * src/maemo/modest-account-settings-dialog.h:
665 * src/maemo/modest-account-settings-dialog.c:
666 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
667 message if the retrieval of secure authentication methods was canceled
668 by the user. Perform the check before saving anything to configuration
669 to not end up with half-committed configuration changes, do not show
670 a "Saving to configuration failed" note when authentication methods
671 could not be retrieved.
673 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
676 2007-06-26 Murray Cumming <murrayc@murrayc.com>
678 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
679 Only return the first level of folders under accounts, because the
680 osso-global-search UI spec doesn't want the rest.
681 This fixed projects.maemo.org bug NB#61811.
683 2007-06-26 Murray Cumming <murrayc@murrayc.com>
685 * src/modest-tny-account-store.c:
686 * src/modest-tny-account-store.h:
687 Added modest_tny_account_is_memory_card_account().
688 * src/maemo/modest-main-window.c: (create_details_widget):
689 Show the same information items for the memory card as we show for the
690 local-folders, to fix projects.maemo.org bug NB#59307.
692 2007-06-26 Murray Cumming <murrayc@murrayc.com>
694 * src/modest-tny-account-store.c: (get_password):
695 Added some checks for NULL to maybe prevent crashes, though I think
696 it was Philip's last commit that actually prevented the crash here
697 when creating a first new account.
698 But the new account is still not usable (no messages are shown)
699 until a restart of the application.
701 2007-06-26 Murray Cumming <murrayc@murrayc.com>
703 * src/maemo/modest-maemo-global-settings-dialog.c:
704 (idle_select_default_focus):
705 * src/modest-mail-operation.c: (idle_notify_progress),
706 (idle_notify_progress_once), (idle_notify_update_account_queue),
707 (set_last_updated_idle), (update_account_thread),
708 (notify_get_msgs_full), (get_msgs_full_destroyer),
709 (get_msgs_full_thread):
710 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
711 * src/widgets/modest-header-view.c:
712 (idle_notify_headers_count_changed_destroy),
713 (idle_notify_headers_count_changed):
714 Use gdk_threads_enter() and gdk_threads_enter_leave() in
715 all idle handlers, because some other thread could be blocking
716 the GDK lock, so that it can do GUI stuff.
718 2007-06-26 Murray Cumming <murrayc@murrayc.com>
720 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
721 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
722 (on_idle_send_receive), (on_idle_open_default_inbox):
723 * src/maemo/modest-msg-edit-window.c:
724 (modest_msg_edit_window_attach_file_noninteractive):
725 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
726 to prevent a hang. I don't quite understand why these are necessary,
727 beause we should already be in the main loop. I guess something outside
728 of the main loop is taking the lock.
730 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
731 we are really using URIs, and use files that are more likely to exist.
733 2007-06-26 Murray Cumming <murrayc@murrayc.com>
735 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
736 necessary because configure.ac now defines different variables.
738 2007-06-26 Murray Cumming <murrayc@murrayc.com>
740 * libmodest-dbus-client/libmodest-dbus-client.c:
741 * libmodest-dbus-client/libmodest-dbus-client.h:
742 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
743 libmodest_dbus_client_compose_mail() is what things actually use.
745 * src/dbus_api/modest-dbus-api.h:
746 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
747 * tests/dbus_api/Makefile.am:
748 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
751 2007-06-26 Murray Cumming <murrayc@murrayc.com>
753 * src/modest-init.c: (modest_init_local_folders):
754 For memory-card (or other non local-folders) maildir accounts,
755 always create an Archive folder, so that there is somewhere to put
756 messages. This should be less confusing, because the user does not need
757 to guess that the need to create a folder.
759 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
761 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
762 Fixed icon size by using (50, 50) which is the same as defined by
765 2007-06-25 Armin Burgmeier <armin@openismus.com>
767 * src/widgets/modest-window-mgr.c:
769 * configure.ac: Correctly recognize hildon-notify presence and fixed
770 the build without it being installed.
772 2007-06-25 Murray Cumming <murrayc@murrayc.com>
774 * libmodest-dbus-client/libmodest-dbus-client.c:
775 (libmodest_dbus_client_search): Fix the build. Sorry.
776 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
777 (reply_forward_cb): Initialize variables to fix the build.
779 * src/modest-tny-account-store.c:
780 (modest_tny_account_store_get_tny_account_by): Fix the account URI
781 comparison (a silly typo) so that email search results can be opened
782 when there are more than one account.
784 2007-06-25 Murray Cumming <murrayc@murrayc.com>
786 * libmodest-dbus-client/libmodest-dbus-client.c:
787 (libmodest_dbus_client_search),
788 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
789 instead of 1 second, because the search gets folders and messages from
790 the server, which can take a long time. When it times out,
791 osso-global-search will report no results.
793 We need to specify whether we should search only cached information
794 (maybe with a user preference), and the osso-email-search-plugin
795 API should really be improved to allow that option, and to allow results
796 to be delivered asynchronously in batches.
798 2007-06-25 Murray Cumming <murrayc@murrayc.com>
800 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
801 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
802 GTK_ICON_SIZE_DIALOG is probably the wrong size.
804 2007-06-25 Murray Cumming <murrayc@murrayc.com>
806 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
807 that is an empty string. D-Bus seems to give us these instead of NULL.
809 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
811 * src/dbus_api/modest-dbus-callbacks.c:
812 * src/maemo/easysetup/modest-easysetup-wizard.h:
813 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
814 * src/maemo/modest-connection-specific-smtp-edit-window.c:
815 (modest_connection_specific_smtp_edit_window_init):
816 * src/maemo/modest-maemo-global-settings-dialog.c:
818 * src/maemo/modest-maemo-utils.c:
819 (modest_maemo_utils_setup_images_filechooser):
820 * src/maemo/modest-main-window.c: (create_details_widget):
821 * src/maemo/modest-msg-edit-window.c:
822 (modest_msg_edit_window_attach_file_noninteractive),
823 (modest_msg_edit_window_color_button_change),
824 (modest_msg_edit_window_set_zoom):
825 * src/modest-mail-operation.c: (update_account_thread):
826 * src/modest-tny-account-store.c:
827 * src/modest-tny-account.c:
828 * src/widgets/modest-global-settings-dialog.c:
829 * src/widgets/modest-window.h:
833 2007-06-25 Murray Cumming <murrayc@murrayc.com>
835 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
836 * src/modest-search.c: (modest_search_folder),
837 (modest_search_all_accounts): Actually search only in the specified folder,
838 doing a simple match on the folder ID.
839 * src/modest-search.h: Added a folder field to the ModestSearch struct,
840 and added some documentation.
842 2007-06-22 Armin Burgmeier <armin@openismus.com>
844 * src/maemo/modest-maemo-utils.h:
845 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
846 modest_maemo_utils_get_supported_secure_authentication_methods.
848 * src/maemo/easysetup/modest-easysetup-wizard.c:
849 * src/maemo/modest-account-settings-dialog.c: Show correct error if
850 one occured, not just "Server does not support secure authentication".
852 2007-06-22 Murray Cumming <murrayc@murrayc.com>
854 * src/modest-tny-account-store.c: (get_password):
855 Restored the call to tny_account_set_user() because Philip seems to have
856 stopped this from crashing (by not using the freed string). It still does
857 not work, but now we can test it.
859 2007-06-22 Murray Cumming <murrayc@murrayc.com>
861 * src/maemo/modest-msg-edit-window.c: (init_window):
862 Comment out use of an uninitialzed GtkScrolledWindow variable,
863 to fix the build and stop a crash. Yet again.
865 2007-06-22 Murray Cumming <murrayc@murrayc.com>
867 * src/modest-tny-account-store.c: (get_password):
868 Remove the call to tny_account_set_user() because this actually crashes.
869 As mentioned in the last commit, it is known to not work anyway.
871 2007-06-22 Murray Cumming <murrayc@murrayc.com>
873 * src/modest-tny-account-store.c: (get_password):
874 Use tny_account_set_username() to tell tinymail that the username might
875 have changed too. But tinymail ignores this: see projects.maemo.org
877 * src/modest-ui-actions.c:
878 (modest_ui_actions_on_password_requested): Remove the useless attempt to
879 reset the connection when changing the username, and improve the comments.
880 Save the changed username to gconf at least, so it is used when Modest is
883 2007-06-21 Murray Cumming <murrayc@murrayc.com>
885 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
886 Do not use a query, so that we get all folders, including for POP and
887 local-folders. They work as search criteria too.
888 This fixes projects.maemo.org bug NB#57740.
890 2007-06-21 Murray Cumming <murrayc@murrayc.com>
892 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
893 Comment out the use of hildon_notification_set_sound() because it is
894 not declared, to fix the build. Warnings are serious, people.
896 2007-06-21 Armin Burgmeier <armin@openismus.com>
898 * src/maemo/modest-maemo-utils.h:
899 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
900 modest_maemo_utils_get_supported_secure_authentication_methods()
901 to query authentication methods for a specific user. This should fix
902 projects.maemo.org bug NB#61369.
904 * src/maemo/easysetup/modest-easysetup-wizard.c:
905 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
908 2007-06-21 Murray Cumming <murrayc@murrayc.com>
910 * libmodest-dbus-client/libmodest-dbus-client.h:
911 * libmodest-dbus-client/libmodest-dbus-client.c:
912 (modest_dbus_message_iter_get_search_hit),
913 (libmodest_dbus_client_search):
914 Reorganised and commented this.
915 Removed modest_search_hit_free() from the public API because it
918 Added libmodest_dbus_client_get_folders() and
919 modest_folder_result_list_free().
921 * src/dbus_api/modest-dbus-api.h:
922 * src/dbus_api/modest-dbus-callbacks.c:
923 (modest_dbus_req_filter): Commented. Moved most code to
924 on_dbus_method_search() and added on_dbus_method_get_folders().
926 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
927 of the extra D-Bus handler.
929 * tests/dbus_api/Makefile.am:
930 * tests/dbus_api/test_get_folders.c: New test for
931 libmodest_dbus_client_get_folders(). This seems to return an empty list
932 at the moment. That could be the same error that causes the message list
933 to be empty sometimes.
934 This should help with projects.maemo.org bug NB#57740.
936 2007-06-21 Armin Burgmeier <armin@openismus.com>
938 * src/modest-mail-operation.c: Do not call
939 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
940 notify the operation's end after having set the status to CANCELED for
941 the operation queue to listen on. This fixes a deadlock when there
942 were mail operations in the queue during its finalization.
944 * src/modest-singletons.c: Reordered uninitialization of the account
945 manager to happen after the mail operation queue was uninitialized
946 because the mail operation's in the queue might still try to access
947 the account manager (see modest_mail_operation_notify_end()). This
948 fixes a potential crash when terminating the application.
950 2007-06-21 Murray Cumming <murrayc@murrayc.com>
952 * src/modest-search.c:
953 (search_mime_part_and_child_parts): Moved some code here so we
954 can search recursively in child folders.
955 (modest_search_folder): Search in the message as a mime part, instead
956 of just its child mime parts.
957 (read_chunk), (search_mime_part_ogs):
958 Check how many bytes were read, to prevent an endless loop.
959 Searching in message bodies now works. This finishes the fix for
960 projects.maemo.org bug NB#61007.
962 2007-06-20 Murray Cumming <murrayc@murrayc.com>
964 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
965 Add a g_warning when the item is not a folder.
967 * src/modest-ui-dimming-rules.c:
968 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
969 when selected item is not a folder (for instance, an account), because
970 the UI spec only talks about folders.
971 I am not sure what the UI spec wants, so this might not totally fix
972 projects.maemo.org bug NB#60794.
974 2007-06-20 Murray Cumming <murrayc@murrayc.com>
976 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
977 (load_from_file): Sort the list. The unsorted list would be more noticeable
978 in non-English locales.
980 * src/maemo/modest-msg-edit-window.c:
981 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
982 warning and fix the build.
984 * src/maemo/modest-progress-bar-widget.c:
985 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
986 avoid a g_warning, and probably to avoid a crash.
988 2007-06-20 Murray Cumming <murrayc@murrayc.com>
990 * src/modest-search.c: (modest_search_folder): Check for a GError
991 when calling tny_folder_get_headers(), to show that this is not the cause
994 2007-06-20 Murray Cumming <murrayc@murrayc.com>
996 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
997 Actually set the body query instead of the subject query.
999 * src/modest-search.c: (search_mime_part_ogs),
1000 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1001 which would probably cause it to fail if we got this far.
1003 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1004 to simplify the code.
1005 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1006 be causing search-in-body to fail.
1008 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1010 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1012 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1013 Better debug message when the folder cannot be found.
1014 This should help with fixing projects.maemo.org bug #61287.
1015 * src/modest-search.c: (add_hit): Do not leak the furl string.
1017 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1019 * src/modest-ui-actions.c:
1020 (modest_ui_actions_on_folder_selection_changed):
1021 Do not special-case TNY_MERGE_FOLDER here, because
1022 modest_tny_folder_get_account() already does that. This fixes
1023 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1024 shown when the Outbox was selected).
1026 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1028 * libmodest-dbus-client/libmodest-dbus-client.c:
1029 (_dbus_iter_get_string_or_null): Initialize the string variable in
1030 case this helps with Dirk's crash.
1032 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1034 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1035 though it is not implemented yet (this function is maybe not even used),
1036 to avoid breaking ABI in future.
1037 * libmodest-dbus-client/libmodest-dbus-client.c:
1038 (get_attachments_string): Moved some code into this generic function.
1039 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1040 sends email. It is maybe not used.
1041 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1042 (on_send_mail): Use attachments.
1044 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1045 * src/maemo/modest-msg-edit-window.c:
1046 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1047 a filename before using it, to fix projects.maemo.org bug NB#58233.
1049 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1051 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1052 Initialize the continue_download variable to fix the build, and probably
1053 to fix randome behaviour.
1055 2007-06-18 Armin Burgmeier <armin@openismus.com>
1057 * src/modest-tny-send-queue.h:
1058 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1059 the queue so we can later show it in the UI. Replaced
1060 modest_tny_send_queue_msg_is_being_sent() by
1061 modest_tny_send_queue_get_msg_status().
1063 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1065 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1066 gpointer. This probably was not harmful, but just to be sure.
1068 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1070 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1071 Fix the build, but leave the function broken on Bora, because
1072 hildon_uri_action_get_service() does not exist.
1073 osso_uri_action_get_service() does not exist either, it seems.
1075 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1077 * src/modest-tny-account.c:
1078 (modest_tny_account_new_from_server_account):
1079 Uncommented the url debug output again, because it is useful for
1080 debugging, as I said in the comment.
1082 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1084 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1086 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1087 for Mameo Bora, to fix the build.
1089 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1092 Fixed build with hildon < 0.99
1094 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1095 Check if the selected account is busy instead of checking all accounts
1097 * src/modest-account-mgr-priv.h:
1098 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1099 (modest_account_mgr_init), (compare_account_name),
1100 (modest_account_mgr_set_account_busy),
1101 (modest_account_mgr_account_is_busy):
1102 * src/modest-account-mgr.h:
1103 Added busy information to the account manager. It possible to
1104 set an account to busy or not busy now.
1106 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1107 (modest_mail_operation_update_account),
1108 (modest_mail_operation_notify_end):
1109 Set the account to busy/not busy depending on the operation state.
1111 * src/widgets/modest-account-view.c:
1112 (modest_account_view_finalize), (get_last_updated_string),
1113 (update_account_view), (on_account_busy_changed), (init_view):
1114 Show string "Refreshing..." if the account is currently busy.
1116 All this fixes projects.maemo.org bug NB#59711
1118 2007-06-14 Armin Burgmeier <armin@openismus.com>
1120 * src/widgets/modest-attachments-view.h:
1121 * src/widgets/modest-attachments-view.c: Added
1122 modest_attachments_view_has_attachments() and fixed coordinate
1123 transformation in get_att_view_at_coords(). This fixes attachment
1126 * src/widgets/modest-msg-view.c: Make use of
1127 modest_attachments_view_has_attachments() to decide whether to show
1128 attachments in the header.
1130 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1132 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1133 (on_change), (on_combo_security_changed),
1134 (modest_connection_specific_smtp_edit_window_init),
1135 (modest_connection_specific_smtp_edit_window_set_connection),
1136 (modest_connection_specific_smtp_edit_window_is_dirty):
1137 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1138 * src/maemo/modest-connection-specific-smtp-window.c:
1141 Show an comfirmation dialog for the smpt-edit-window if there are
1142 unsaved changes and the user hits cancel.
1143 (projects.maemo.org bug NB#60479)
1145 2007-06-14 Armin Burgmeier <armin@openismus.com>
1147 * src/maemo/easysetup/modest-easysetup-wizard.c:
1148 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1149 address" info in banner instead of node, and select all the text as
1150 per UI spec. This fixes projects.maemo.org bug NB#60550.
1152 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1154 reviewed by: <delete if not using a buddy>
1156 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1157 * src/modest-ui-actions.c: (folder_refreshed_cb):
1159 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1161 * src/widgets/modest-folder-view.c: (filter_row):
1162 Explictly filter out the per-account outbox accounts. I don't know why
1163 these only sometimes show up, but now they should never show up in the UI.
1164 This should fix projects.maemo.org bug NB#60160.
1166 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1168 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1169 when the toolbar does not exist yet.
1170 * src/modest-widget-memory.c: (save_settings_header_view):
1171 Added g_warnings() to help us to discover when we are trying to set
1172 an empty columns list in gconf.
1174 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1176 * src/modest-init.h:
1177 * src/modest-init.c:
1178 Added modest_init_get_default_header_view_column_ids().
1180 * src/modest-widget-memory.c: (restore_settings_header_view):
1181 Use the new function to get defaults, if the gconf key is empty,
1182 instead of not creating any columns. This seems to fix the
1183 empty right-hand pane problems.
1185 * src/widgets/modest-header-view.h: Improved documentation.
1187 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1189 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1190 Revert the use of the display name as the account name, because this
1191 is generally wrong and would break the code that follows.
1193 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1195 * src/maemo/easysetup/modest-easysetup-wizard.c:
1196 (check_for_supported_auth_methods), (on_before_next),
1199 More correct fix for projects.maemo.org bug NB# 58991
1200 Do not longer accept AUTH_PASSWORD as secure method and choose
1201 correct method when creating the account.
1203 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1205 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1206 Fixed projects.maemo.org bug NB# 58991
1208 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1210 * src/modest-init.c: (modest_init_init_core),
1211 (modest_init_local_folders): Fixed compilation errors.
1213 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1215 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1216 Remove unnecessary lib/include, though it is good in principle when needed.
1218 * src/modest-init.c: (modest_init_one_local_folder),
1219 (modest_init_local_folders):
1220 * src/modest-init.h: Initialize the .modest library for memory cards,
1221 instead of just doing nothing for them. This should allow us to create
1222 folders there, fixing projects.maemo.org bug NB#59297.
1224 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1226 * libmodest-dbus-client/libmodest-dbus-client.c:
1227 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1228 (libmodest_dbus_client_compose_mail),
1229 (libmodest_dbus_client_open_message),
1230 (libmodest_dbus_client_send_and_receive),
1231 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1233 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1234 (on_idle_open_message), (modest_dbus_req_handler),
1235 (search_result_to_message), (modest_dbus_req_filter):
1236 * src/modest-search.c: (add_hit), (modest_search_folder),
1237 (modest_search_all_accounts): Improved debug messages.
1239 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1241 * src/modest-tny-account-store.c:
1242 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1245 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1248 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1250 * src/modest-tny-account-store.c: (get_server_accounts):
1251 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1252 even when there are no accounts, so that the Outbox folder is always
1253 visible. This fixes projects.maemo.org bug NB#60158.
1255 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1257 * src/maemo/modest-main-window.c: (create_details_widget):
1258 Use the mcen_va_never logical ID.
1260 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1262 * src/dbus_api/modest-dbus-api.h:
1263 * src/dbus_api/modest-dbus-callbacks.c:
1264 (on_idle_open_default_inbox), (on_open_default_inbox),
1265 (modest_dbus_req_handler):
1266 Added a new OpenDefaultInbox method.
1268 * libmodest-dbus-client/libmodest-dbus-client.h:
1269 * libmodest-dbus-client/libmodest-dbus-client.c:
1270 Added libmodest_dbus_client_open_default_inbox() to call the new
1271 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1272 though it should maybe be used by a new osso-email-interface function.
1274 * tests/dbus_api/Makefile.am:
1275 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1278 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1280 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1281 NULL, so that the signals get all the keys. This should not actually
1282 change any behaviour because we currently update everything when anything
1285 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1287 * src/widgets/modest-folder-view.c: (text_cell_data),
1288 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1289 (find_inbox_iter): If tinymail tells us that the folder is
1290 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1291 This causes the inbox to be selected at startup, fixing part of
1292 projects.maemo.org bug NB#56305.
1294 * src/modest-ui-dimming-rules.c:
1295 (modest_ui_dimming_rules_on_tools_smtp_servers):
1296 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1297 the SMTP servers menu item.
1298 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1299 that the SMTP Servers menu item is dimmed when there are no accounts,
1300 as a future version of the UI spec will require. This fixes
1301 projects.maemo.org bug NB#56305.
1303 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1305 * src/maemo/modest-maemo-utils.c:
1306 (modest_maemo_utils_get_supported_secure_authentication_methods):
1307 Added label to dialog instead of unreadable title
1309 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1310 (modest_main_window_new):
1311 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1314 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1315 * src/modest-account-mgr.h:
1316 Added method to avoid code duplication
1318 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1319 (modest_ui_actions_on_send_receive):
1320 Use modest_account_mgr_has_accounts
1322 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1324 * src/maemo/easysetup/modest-presets.c:
1325 (modest_presets_get_info_server_security): Do not report secure auth
1327 * src/modest-protocol-info.c: Use the defines for the gconf key names
1328 for secure authentication. This was not working because we were writing
1329 Password and reading password, and the check was case sensitive.
1330 With this, gmail now works for receiving and sending when created via
1333 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1335 * src/maemo/easysetup/modest-presets.c:
1336 (modest_presets_get_info_server_security): Correct the key name for
1337 SecureSmtp, because it seems to be case-sensitive.
1338 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1339 Do not try to get the 0th notebook page if there are 0 pages, to
1340 avoid a g_warning().
1342 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1344 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1345 Prevent use of the new notification feature for now, because it currently
1346 shows one dialog for each new email, which is annoying.
1348 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1350 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1351 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1352 when no country was selected, so that we show the global ones.
1353 * src/maemo/easysetup/modest-presets.c:
1354 (modest_presets_get_providers): Return only the global providers, not
1355 all providers when mmc=0 was requested.
1357 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1359 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1360 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1361 provider ID in the combo.
1363 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1364 Do not show the page numbers, because it would be confusing when we add
1365 the 2 extra pages for the custom setup, when the user chooses the "Other"
1366 provider. This fixes projects.maemo.org bug NB#59028
1368 * src/modest-init.c: (modest_init_init_core),
1369 (modest_init_local_folders):
1370 * src/modest-init.h:
1371 * src/modest-tny-account.c:
1372 (modest_tny_account_new_for_local_folders): Do not create default folders
1373 for the memory card. This should fix projects.maemo.org bug NB#59328.
1375 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1377 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1378 Free the changed_conf_keys string items. They are already freed in the
1379 idle handler if that runs first.
1381 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1383 * src/modest-ui-actions.c:
1384 (modest_ui_actions_on_password_requested): Check that the server name
1385 is not NULL, because I just saw a password dialog with (null) as the
1388 * src/modest-tny-folder.[h|c]: Added
1389 modest_tny_folder_is_memory_card_folder().
1390 * src/modest-ui-dimming-rules.c:
1391 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1392 menu item for memory cards, as per the UI spec (section 7.4). This should
1393 fix projects.maemo.org bug NB#59297.
1395 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1397 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1398 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1399 is another problem with the code, see Murray's comment at line 772)
1401 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1403 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1404 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1405 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1406 (load_from_file), (easysetup_country_combo_box_init),
1407 (easysetup_country_combo_box_get_active_country_ids),
1408 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1409 instead of just one ID, to avoid duplicate country names in the UI.
1411 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1412 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1413 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1414 a single ID, avoiding duplicate providers.
1415 * src/maemo/easysetup/modest-easysetup-wizard.c:
1416 (on_combo_account_country): Adapt to use a list.
1418 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1420 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1421 keys changed in the last X seconds.
1423 * src/modest-account-mgr.h:
1424 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1425 (on_key_change), (modest_account_mgr_class_init),
1426 (modest_account_mgr_init), (modest_account_mgr_finalize):
1427 As the keys are changed, save them in a GSList* and signal that GSList*
1428 further every X seconds, to batch changes, to allow us to do just one
1429 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1430 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1432 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1433 changed signal signature.
1435 * src/modest-conf.c: (modest_conf_set_list),
1436 (modest_conf_on_change): Reenable notification.
1438 (modest_conf_maemo_fake_on_change): Comment out the hack that
1439 notified immediately instead of asynchronously.
1441 * src/widgets/modest-account-view.h:
1442 * src/widgets/modest-account-view.c:
1443 (update_account_view): Select the previously-selected account ID,
1444 if possible. This fixes projects.maemo.org bug NB#56933.
1446 (on_account_changed), (on_account_removed),
1447 (modest_account_view_select_account):
1449 Remove the block/unblock functions
1450 because they were not useful.
1452 * src/maemo/modest-account-view-window.c:
1453 (on_delete_button_clicked), (on_edit_button_clicked),
1454 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1456 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1458 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1459 Improve the error dialog to show Incorrect Account Settings, which seems
1460 clearer, and say that the internal error message (to be removed from the
1461 dialog later) is often misleading.
1462 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1464 * src/modest-tny-account.c:
1465 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1466 URL because this is so useful for debugging on the device.
1468 * src/widgets/modest-serversecurity-combo-box.c:
1469 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1471 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1473 * src/modest-mail-operation.c:
1474 (modest_mail_operation_send_new_mail):
1475 Added a comment about a nasty but apparently harmless message. Details
1476 added to the wiki g_warnings() page.
1478 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1480 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1481 (modest_tny_send_queue_class_init):
1482 Do not use the priv struct because it is empty, to avoid g_warnings
1483 about a non-existant priv struct.
1485 * src/modest-tny-account-store.c:
1486 (modest_tny_account_store_get_server_account),
1487 (modest_tny_account_store_get_transport_account_for_open_connection
1488 ): Do not try to get transport server accounts for local folders,
1489 because they don't have any. This avoids a g_warning().
1491 * src/maemo/modest-main-window.c:
1492 (modest_main_window_notify_send_receive_initied),
1493 (on_configuration_key_changed):
1494 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1495 * src/modest-defs.h:
1496 * src/modest-mail-operation.c:
1497 (modest_mail_operation_update_account):
1498 * src/modest-tny-account-store.h:
1499 * src/modest-tny-account.c:
1500 (modest_tny_account_get_special_folder),
1501 (modest_tny_account_new_for_local_folders),
1502 (modest_tny_account_new_for_per_account_local_outbox_folder):
1503 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1504 * src/modest-tny-local-folders-account.c:
1505 (add_account_folders_to_merged_folder):
1506 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1507 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1508 (modest_ui_actions_on_send):
1509 * src/widgets/modest-folder-view.c: (update_model):
1510 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1511 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1512 modest_tny_account_store_get_tny_account_by_account() to
1513 modest_tny_account_store_get_server_account() to make the code clearer.
1515 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1517 * src/dbus_api/modest-dbus-api.h:
1518 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1519 * src/maemo/modest-msg-edit-window.c:
1520 (modest_msg_edit_window_attach_file_noninteractive):
1521 added g_warning in case the file to be attached does not exist
1522 * tests/dbus_api/test_compose_mail.c: (main):
1523 removed obsolete comment, added generic files as test case
1525 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1527 * src/modest-tny-account-store.c: (get_server_accounts):
1528 Create the local folders account only once, not once for each outbox, and
1529 not only when there are some outboxes.
1531 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1533 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1534 code that is causing a crash at startup. Sergio says that he is fixing this.
1536 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1538 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1539 * src/maemo/modest-account-settings-dialog.c:
1540 (create_page_outgoing),
1541 (modest_account_settings_dialog_set_account_name),
1542 (save_configuration):
1543 - Fixed handling of the "Use secure authentication" toggle to comply with
1544 the ui specification. See also projects.maemo.org bug NB#58400
1546 - Restore the Secure connection setting combo correctly when loading
1549 * src/maemo/modest-maemo-utils.c:
1550 (on_camel_account_get_supported_secure_authentication),
1551 (modest_maemo_utils_get_supported_secure_authentication_methods):
1552 Fixed a crasher if operation is canceled
1554 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1555 (modest_protocol_info_auth_is_secure):
1556 * src/modest-protocol-info.h:
1558 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1559 the sense of the "Use secure authentication" toggle.
1561 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1563 * src/modest-tny-account-store.h:
1564 * src/modest-tny-account-store.c:
1565 Added modest_tny_account_store_get_local_folders_account().
1567 * src/modest-tny-folder.h:
1568 * src/modest-tny-folder.c:
1569 (modest_tny_folder_get_account):
1570 Added this replacement for tny_folder_get_account() which returns
1571 the local-folders account for TnyMergeFolders, to avoid the
1572 warning about the unimplemented get_account_func() vfunc().
1574 (modest_tny_folder_get_rules),
1575 * src/modest-ui-actions.c:
1576 (modest_ui_actions_on_folder_selection_changed):
1577 * src/modest-mail-operation.c:
1578 (modest_mail_operation_remove_folder),
1579 (modest_mail_operation_xfer_folder),
1580 (modest_mail_operation_rename_folder),
1581 (modest_mail_operation_get_msg),
1582 (modest_mail_operation_get_msgs_full),
1583 (modest_mail_operation_remove_msg),
1584 (modest_mail_operation_xfer_msgs),
1585 (modest_mail_operation_refresh_folder):
1586 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1588 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1590 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1591 (modest_server_account_set_security):
1592 * src/modest-defs.h: Add comments explaining that our
1593 UI spec means TLS when it says Normal, so these do not look like errors.
1595 * src/modest-tny-account.c:
1596 (modest_tny_account_new_from_server_account): Use the new tinymail
1597 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1598 for TLS. This should fix projects.maemo.org bug NB#58460.
1600 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1602 * src/maemo/easysetup/modest-easysetup-wizard.c:
1603 (create_account): Correct the position of the gconf sanity check warning.
1604 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1605 of using the g_idle_add() hack, because this does not seem to be necessary
1606 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1607 caused by something other than maemo's gconf.
1608 This fixes projects.maemo.org bug #59022.
1610 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1612 * src/modest-account-mgr-helpers.c:
1613 (modest_account_mgr_get_default_account): Do not check that the account
1614 exists if there is no default account (NULL), to fix a runtime warning.
1616 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1618 * src/widgets/modest-folder-view.c: (update_model):
1619 Do not unref the treemodel before we have finished with it.
1620 This prevents a valgrind warning and an occasional crash at startup.
1622 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1624 * libmodest-dbus-client/libmodest-dbus-client.h:
1625 added libmodest_dbus_client_compose_mail()
1626 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1628 added functions needed for SendAsMail() functionality
1629 * src/maemo/modest-msg-edit-window.c:
1630 (modest_msg_edit_window_attach_file_noninteractive):
1631 non interactively attaching files to message edit window
1632 * src/widgets/modest-msg-edit-window.h:
1633 * tests/dbus_api/Makefile.am:
1634 added test_compose_mail.c
1635 * tests/dbus_api/test_compose_mail.c: (main):
1637 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1639 * src/modest-account-view.c:
1640 Fixed bug projects.maemo.org bug NB#59307
1642 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1644 * src/maemo/easysetup/modest-easysetup-wizard.c:
1645 (get_serverport_incoming), (on_before_next), (create_account):
1646 * src/maemo/modest-account-settings-dialog.c:
1647 (modest_account_settings_dialog_set_account_name):
1648 * src/maemo/modest-maemo-utils.c:
1649 (on_camel_account_get_supported_secure_authentication_status),
1650 (on_camel_account_get_supported_secure_authentication),
1651 (on_secure_auth_cancel),
1652 (modest_maemo_utils_get_supported_secure_authentication_methods):
1654 Implemented security authentication for settings and easysetup.
1656 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1658 * src/maemo/modest-main-window.c: (create_details_widget):
1659 Show the total size for memory card accounts too, instead of showing
1660 the name again. Fixes bug projects.maemo.org bug NB#59307.
1662 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1665 * src/modest-tny-simple-folder-store.c:
1666 * src/modest-tny-simple-folder-store.h: Removed.
1668 * src/modest-tny-local-folders-account.h
1669 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1670 for the local-folders maildir, with an extra TnyMergedFolder containing
1671 the folders of the per-account outbox store accounts.
1672 * src/modest-tny-account-store.c: (get_server_accounts):
1673 Add the outboxes to the special local folders account after creating it.
1675 * src/modest-tny-account.c:
1676 (modest_tny_account_new_for_local_folders): Create the derived
1677 account when creating the main local-folders account.
1679 * src/maemo/modest-main-window.c: (create_details_widget),
1680 (modest_main_window_set_contents_style):
1681 Adapted to the use of the derived account instead of the folder store.
1683 * src/modest-ui-actions.c:
1684 (modest_ui_actions_on_folder_selection_changed):
1685 * src/modest-ui-dimming-rules.c:
1686 (modest_ui_dimming_rules_on_new_folder):
1687 * src/widgets/modest-folder-view.c: (text_cell_data),
1688 (icon_cell_data), (filter_row), (update_model),
1689 (get_cmp_rows_type_pos):
1692 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1693 Do not get the priv struct, because no priv struct has been set,
1694 to avoid a runtime warning.
1696 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1697 #ifelse with #else, to fix a warning, to fix the build.
1700 2007-06-05 Christian Kellner <ckellner@openismus.com>
1702 * libmodest-dbus-client/libmodest-dbus-client.c:
1703 Fix small typo in doc (why do you always see them
1704 AFTER committing stuff?)
1707 2007-06-05 Christian Kellner <ckellner@openismus.com>
1709 * libmodest-dbus-client/libmodest-dbus-client.c:
1710 (libmodest_dbus_client_search):
1711 Initialize hit list with NULL. Also set folder list
1712 to "" if NULL was supplied.
1715 2007-06-03 Christian Kellner <ckellner@openismus.com>
1717 * libmodest-dbus-client/libmodest-dbus-client.c:
1718 (modest_search_hit_list_free):
1719 Make it save to call it with NULL.
1721 * src/dbus_api/modest-dbus-callbacks.c:
1722 * src/modest-search.c:
1723 Return full ModestSearchHits as the search result list not TnyHeader
1724 since can't be around withouth the correspoding TnyFolder.
1726 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1728 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1729 Added currently commented code to check for secure auth
1731 * src/maemo/modest-account-settings-dialog.c: (on_response),
1732 (save_configuration), (show_ok):
1733 Fixed projects.maemo.org bugs NB #59248 and #59251
1735 * src/maemo/modest-maemo-utils.c:
1736 (on_camel_account_get_supported_secure_authentication_status),
1737 (on_camel_account_get_supported_secure_authentication),
1738 (modest_maemo_utils_get_supported_secure_authentication_methods):
1739 * src/maemo/modest-maemo-utils.h:
1740 Moved get_supported_secure_authentication() method here to be able
1741 to use it from easysetup wizard.
1743 * src/modest-pair.c: (on_pair_compare_as_string):
1744 Should compare string with first part of pair and not
1745 strcmp pairs which will crash.
1747 * src/modest-protocol-info.c:
1748 (modest_protocol_info_protocol_is_store):
1749 * src/modest-protocol-info.h:
1750 Added modest_protocol_info_get_auth_protocol_name()
1752 2007-06-03 Armin Burgmeier <armin@openismus.com>
1754 * src/modest-mail-operation.c:
1755 (modest_mail_operation_get_msgs_full): Set priv->account also when
1756 only retrieving a single message. This avoids a crash when canceling
1759 (modest_mail_operation_notify_end): Do not explicitely remove the
1760 operation from the queue but only emit the progress_changed signal.
1761 The queue itself listens to that signal to remove the operation when
1762 it is finished. This reduces coupling and removes a potential deadlock
1763 when modest_mail_operation_notify_end() is called from the queue
1764 itself. If that is a problem performance-wise, I would suggest to
1765 implement a status-changed signal or something.
1767 * src/modest-mail-operation-queue.c: Make sure to never call a
1768 function from another file while the queue is locked. This (hopefully)
1769 fixes another deadlock when exiting the application while retrieving
1772 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1774 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1775 Fixed build if libogs is not available
1777 2007-06-03 Christian Kellner <ckellner@openismus.com>
1779 * libmodest-dbus-client/libmodest-dbus-client.h:
1780 * libmodest-dbus-client/libmodest-dbus-client.c:
1781 (libmodest_dbus_client_delete_message):
1782 Implement deletion of messages (Client side).
1784 (modest_search_hit_free),
1785 (modest_search_hit_list_free):
1786 Utility functions to free the result hits.
1788 * src/dbus_api/modest-dbus-api.h:
1789 * src/dbus_api/modest-dbus-callbacks.c:
1790 (on_delete_message),
1791 (modest_dbus_req_handler):
1792 Implement deletion of messages (Server side).
1794 * tests/dbus_api/test_search.c: (main):
1797 * tests/dbus_api/Makefile.am:
1798 * tests/dbus_api/test_delete_message:
1799 Add little test for the message deletion logic
1801 2007-06-03 Armin Burgmeier <armin@openismus.com>
1803 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1804 when the operation queue was not empty. projects.maemo.org bug
1807 2007-06-03 Armin Burgmeier <armin@openismus.com>
1809 * src/widgets/modest-account-view.c
1810 (on_account_default_toggled): Toggle default account column
1811 explicitely instead of waiting for gconf notification (which is
1812 currently ignored). This should fix projects.maemo.org bug NB#56910
1813 for now. It should probably be removed when gconf notifications are
1816 2007-06-03 Christian Kellner <ckellner@openismus.com>
1818 * libmodest-dbus-client/libmodest-dbus-client.c:
1819 Removed debugging spew.
1821 * src/dbus_api/modest-dbus-callbacks.c:
1822 Added debugging info.
1824 * src/modest-search.c:
1825 (modest_search_all_accounts):
1826 Use tny_account_store_get_accounts () on the account store
1827 to get all accounts which is the way to get all accounts.
1829 * tests/dbus_api/test_search.c: (main):
1830 Make it possible to supply the search term on the command line.
1832 2007-06-03 Christian Kellner <ckellner@openismus.com>
1834 * libmodest-dbus-client/libmodest-dbus-client.c:
1835 * libmodest-dbus-client/libmodest-dbus-client.h:
1836 Implement searching for mesages over raw dbus. (Client side)
1838 * src/dbus_api/Makefile.am:
1839 * src/dbus_api/modest-dbus-api.h:
1840 * src/dbus_api/modest-dbus-callbacks.c:
1841 * src/dbus_api/modest-dbus-callbacks.h:
1842 Search framework (Server side). Also implement on_idle_open_message().
1844 * src/maemo/modest-platform.c: (modest_platform_init):
1845 Prepare for raw dbus/osso rpc interaction.
1847 * src/modest-search.h:
1848 Changed minsize from unspecific guint to guint32.
1850 * src/modest-search.c:
1852 Added strange hack which magically made tnymail work.
1854 (modest_search_folder),
1855 (modest_search_account),
1856 (modest_search_all_accounts):
1857 Implement helper functions to search all accounts, specific account
1860 * tests/dbus_api/Makefile.am:
1861 * tests/dbus_api/test_open_message.c:
1862 Read url to open from commandline.
1864 * tests/dbus_api/test_search.c:
1865 Implement small test for dbus search stuff
1867 2007-06-02 Armin Burgmeier <armin@openismus.com>
1869 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1870 include account type and account title. This fixes projects.maemo.org
1873 * src/maemo/modest-account-view-window.c: Set a title for the window.
1875 2007-06-02 Armin Burgmeier <armin@openismus.com>
1877 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1878 incoming and outgoing server name based on email address and server
1879 types as long as the names have not been edited manually. This fixes
1880 projects.maemo.org bug NB#58671.
1882 2007-06-02 Armin Burgmeier <armin@openismus.com>
1884 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1885 server type cannot be changed in future to the incoming details page
1886 when creating an account. This fixes projects.maemo.org bug NB#59029.
1888 2007-06-02 Armin Burgmeier <armin@openismus.com>
1890 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1891 and assigned max width chars so that they wrap instead of being
1892 truncated. Fixes projects.maemo.org bug NB#56126.
1894 2007-06-02 Armin Burgmeier <armin@openismus.com>
1896 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1897 introductory note to the connection specific smtp servers dialog, as
1898 section 8.12 of the email UI specification requires. This fixes
1899 projects.maemo.org bug NB#59212.
1901 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1903 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1904 Check for running mail operations, and offer to cancel them, as per the UI
1905 spec. This fixes projects.maemo.org bug NB#59041 .
1906 However, I suspect that tinymail may still use the network connection
1907 in ways that we cannot detect or cancel. But it should at least adapt to
1908 changes fairly well.
1910 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1912 * src/modest-tny-account-store.c: (recreate_all_accounts),
1913 (get_cached_accounts), (get_server_accounts): Do more sensible
1914 ref-counting of the temporarily-cached outbox accounts list. This seems
1915 to fix a crash when entering the password when the password was wrong.
1917 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1919 * src/gnome/modest-main-window.c: (connect_signals):
1920 * src/modest-tny-account-store.c: (get_password),
1921 (modest_tny_account_store_alert): Added comments and clues and
1922 commented-out code about how we currently fail to deal with connection
1923 errors and wrong passwords, and how we should.
1925 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1927 * src/widgets/modest-retrieve-combo-box.c:
1928 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1929 This fixes projects.maemo.org bug NB#58472 .
1931 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1933 * src/maemo/easysetup/modest-easysetup-wizard.c:
1934 (create_page_complete_easysetup):
1935 (create_page_complete_custom): Correct the last commit,
1936 putting the correct sentences in the correct pages.
1938 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1940 * src/maemo/easysetup/modest-easysetup-wizard.c:
1941 (create_page_complete_custom): Show the second sentence of text
1942 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1945 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1947 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1948 Set the leave-on-server conf key by default. This fixes
1949 projects.maemo.org bug NB#59258 .
1951 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1953 * src/maemo/modest-account-view-window.c:
1954 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1955 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1958 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1960 * src/maemo/easysetup/modest-easysetup-wizard.c:
1961 (create_caption_new_with_asterisk):
1962 * src/maemo/modest-account-settings-dialog.c:
1963 (create_caption_new_with_asterisk):
1964 Uncomment the code to add the asterisk, because they are no longer in the
1965 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1966 (update_incoming_server_title): Add an asterisk here too.
1968 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1970 * src/maemo/modest-maemo-global-settings-dialog.c:
1971 (current_connection): Check that we are even connected before trying to
1972 get the current connection name, to prevent a warning.
1974 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1975 Change the comments because tny_maemo_conic_device_connect() is now meant to
1977 * src/modest-mail-operation.c:
1978 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1979 make sure we have a connection and fail if we can't connect.
1981 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1983 * src/maemo/modest-main-window.c:
1984 (on_account_store_connecting_finished): Do not try to get the
1985 connection ID if we are not really connected. I am surprised that
1986 this signal handler is called when we are not connected.
1988 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1990 * src/modest-error.h:
1991 * src/modest-ui-actions.c:
1992 (modest_ui_actions_get_msgs_full_error_handler):
1993 Renamed an enum, added comments, added an enum
1994 for retrieve-limit errors.
1996 * src/modest-mail-operation.c: (foreach_add_item),
1997 (internal_folder_observer_update), (update_account_thread),
1998 (modest_mail_operation_get_msgs_full):
1999 (modest_mail_operation_update_account),
2000 Added comments about how this works, and some code that should
2001 (but does not) check the retrieve-limit. See the TODO comment.
2003 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2005 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2006 Initialize help_id to fix the build. Warnings are good.
2008 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2010 * src/widgets/modest-hbox-cell-renderer.c:
2011 (modest_hbox_cell_renderer_append):
2012 * src/widgets/modest-vbox-cell-renderer.c:
2013 (modest_vbox_cell_renderer_append):
2014 Fix the last commit by doing an extra ref.
2016 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2018 * src/widgets/modest-hbox-cell-renderer.c:
2019 (modest_hbox_cell_renderer_append):
2020 * src/widgets/modest-vbox-cell-renderer.c:
2021 (modest_vbox_cell_renderer_append):
2022 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2023 to fix the build with Maemo Bora.
2024 However, there seems to be a remaining crash, probably due to reference
2027 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2029 * src/modest-tny-account.c:
2030 (modest_tny_account_new_for_local_folders):
2031 Use hildon_file_system_info_async_new() to get a better name for
2032 the memory card account, setting it as the account name.
2033 The timing seems to work, but this is probably
2034 not the best place to do this. See the TODO comment.
2035 * src/maemo/modest-main-window.c: (create_details_widget):
2036 * src/widgets/modest-folder-view.c: (text_cell_data):
2037 Use the tny account name instead of hardcoding a name.
2039 2007-05-30 Christian Kellner <ckellner@openismus.com>
2041 * src/modest-search.c: (modest_search):
2042 Correctly set part_search_func even if we have already parsed
2043 the query and thus a valid OgsTextSearcher object.
2045 2007-05-30 Christian Kellner <ckellner@openismus.com>
2048 Search and check for libogs.
2051 Incooparte the ogs build env.
2053 * src/modest-mime-part-search-stream.c:
2054 * src/modest-mime-part-search-stream.h:
2055 Removed since we do the real searching now in modest-search.c.
2057 * src/modest-search.c:
2058 * src/modest-search.h:
2059 Implement support for ogs. We use that if available and requested
2060 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2061 should now handle the corner case when the search term is spread
2062 across multiple reads.
2063 Also the logic in modest_search () was corrected to search all
2064 requested fields until one is found.
2066 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2068 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2070 * src/modest-init.h:
2071 * src/modest-init.c: Made modest_init_local_folders() take a
2072 path and be public so we can iniitialize maildir folders on
2075 * src/modest-local-folder-info.h:
2076 * src/modest-local-folder-info.c:
2077 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2079 * src/modest-tny-account.c:
2080 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2081 still means the standard local-folders path on the local volume.
2083 * src/modest-tny-account-store.c:
2084 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2085 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2086 all accounts when that happens.
2087 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2088 this too, so it shows up in the treeview.
2090 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2092 * src/maemo/modest-maemo-global-settings-dialog.c:
2093 (current_connection):
2094 * src/widgets/modest-global-settings-dialog.c:
2095 (current_connection_default):
2096 Use the enum values instead of 0, 1 and -1,
2097 to make the code clearer.
2099 * src/modest-account-mgr-helpers.c:
2100 (modest_account_mgr_get_connection_specific_smtp): Make this code
2103 * src/modest-runtime.h:
2104 * src/modest-runtime.c:
2105 Added modest_runtime_remove_all_send_queues().
2106 * src/maemo/modest-main-window.c:
2107 (on_account_store_connecting_finished): Recreate the send queues,
2108 using the appropriate transport accounts for this new connection.
2109 Some futher adapting might be needed if the old send queues are not
2110 automatically stopped at this point.
2112 * src/modest-tny-account-store.c: (get_server_accounts):
2113 Create the connection-specific transport accounts, so that they can
2114 be found later by their ID.
2116 * src/modest-tny-account.h:
2117 * src/modest-tny-account.c:
2118 Added modest_tny_account_new_from_server_account_name().
2119 modest_tny_account_new_from_server_account(): Do not create the
2120 send queues here, because they will be
2121 recreated anyway when the connection changes for the first time.
2123 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2125 * src/modest-local-folder-info.h:
2126 * src/modest-local-folder-info.c:
2127 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2128 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2129 tbox_folder): Take a modest account name instead of a server TnyAccount,
2130 so we can have per-modest-account rather than per-transport-account
2132 We must make sure that we change or recreate the exisitng send queues
2133 when the connection changes for connection-specific transport accounts.
2135 * src/modest-tny-account-store.c:
2136 (create_per_account_local_outbox_folders): Create outboxed per modest
2137 account, not per transport account.
2139 * src/modest-tny-account.h:
2140 * src/modest-tny-account.c:
2141 (modest_tny_account_get_special_folder): For outboxes, get the
2142 parent modest account name. The account is ignored for other folders.
2143 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2144 modest account name rather than a server TnyAccount.
2146 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2148 * src/modest-tny-account.c:
2149 (modest_tny_account_new_from_server_account):
2150 Call modest_runtime_get_send_queue() immediately after creating transport
2151 accounts, so that they start trying to send email from the outbox as soon
2152 as possible at startup. This is probably what we want.
2154 * src/modest-mail-operation.c: (update_account_thread):
2155 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2156 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2157 * src/modest-tny-send-queue.h:
2158 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2159 (modest_ui_actions_on_send):
2160 Added comments about how sending works, though it needs some more work.
2162 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2164 * src/modest-tny-account.c:
2165 (modest_tny_account_get_special_folder): Add TODO because this fails when
2166 the network is busy.
2167 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2168 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2169 Do not try to show this window when there is no active account. The UI
2170 specs does not tell us what to do in this case.
2172 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2176 * src/maemo/Makefile.am:
2177 * src/widgets/Makefile.am: Some dist fixes.
2179 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2181 * src/maemo/modest-connection-specific-smtp-window.c:
2182 (on_button_edit): Make the code clearer, to prevent a double free.
2184 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2186 * src/maemo/modest-account-settings-dialog.c:
2187 (modest_account_settings_dialog_set_account_name),
2188 Check the connection-specific smtp servers checkbox if there are any.
2190 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2191 (modest_connection_specific_smtp_edit_window_init):
2192 Start with a suitable port number.
2194 * src/modest-account-mgr-helpers.h:
2195 * src/modest-account-mgr-helpers.c: Added
2196 modest_account_mgr_get_has_connection_specific_smtp().
2198 (modest_account_mgr_set_connection_specific_smtp),
2199 (modest_account_mgr_remove_connection_specific_smtp),
2200 (modest_account_mgr_get_has_connection_specific_smtp),
2201 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2202 connection-specific smtp server accounts in the account, rather than
2203 the server account conf dir.
2205 This fixes bug projects.maemo.org bug NB#58263 .
2207 * src/modest-tny-account-store.c:
2208 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2209 if there are no server accounts yet, to prevent an infinite loop when there
2210 are no accounts. Document that one must be called before the other.
2212 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2214 * src/modest-account-mgr-helpers.c:
2215 (modest_account_mgr_get_default_account): Make sure that at least
2216 one account is always the default, if there are any enabled accounts.
2217 This is just a sanity check that shouldn't be necessary.
2219 * src/modest-account-mgr-priv.c:
2220 (_modest_account_mgr_account_from_key): Unescape the conf key to
2221 get the real account name. For instance, this is an issue if a space
2222 was in the account name, which can happen because the account name
2223 is generated from the display name.
2224 (_modest_account_mgr_get_account_keyname): Always escape the
2226 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2227 Unescape the conf keys to get the real account names.
2229 For instance, previously the is-default radio button in the accounts
2230 list was not checked for any accounts at first. This fixes that,
2231 and might fix several similar bugs.
2233 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2235 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2236 Removed some debug printfs.
2238 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2240 Modest on-disk outbox directories are now here, for instance:
2241 $HOME/.modest/outboxes/<account-id-1>/outbox
2242 $HOME/.modest/outboxes/<account-id-2>/outbox
2244 $HOME/.modest/local-folders/outbox
2245 so we can have a separate outbox for each account.
2246 But they are shown as one outbox in the GtkTreeView, by using a
2247 TnyMergeFolder in a ModestTnySimpleFolderStore.
2250 * src/modest-tny-simple-folder-store.c:
2251 * src/modest-tny-simple-folder-store.h:
2252 Added ModestTnySimpleFolderStore, used to contain folders from
2253 other folder stores, such as other accounts.
2255 * src/modest-tny-outbox-account.h:
2256 * src/modest-tny-outbox-account.c:
2257 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2258 used for the per-account local outbox folders.
2260 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2261 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2262 only use this (internally) now for the non-outbox local folders.
2264 * src/modest-init.h:
2265 * src/modest-init.c: Added modest_init_one_local_folder(), for
2266 setting up the directory structure for each local folder.
2268 * src/modest-local-folder-info.c:
2269 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2270 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2272 * src/modest-local-folder-info.h:
2273 * src/modest-tny-account-store.c: (on_account_removed),
2274 (on_account_changed), (create_per_account_local_outbox_folders),
2275 (get_server_accounts), (modest_tny_account_store_get_accounts),
2276 (modest_tny_account_store_get_tny_account_by_account),
2277 (modest_tny_folder_store_is_virtual_local_folders):
2279 * src/modest-tny-account.h:
2280 * src/modest-tny-account.c:
2281 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2282 to create an on-disk per-account local outbox folder for each
2284 (create_per_account_local_outbox_folders): Create a local outbox folder
2285 for each transport account.
2286 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2287 for all local folders.
2289 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2290 instead of using g_object_get/set() directly. It is clearer.
2292 (modest_tny_folder_store_get_message_count),
2293 (modest_tny_folder_store_get_local_size
2294 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2295 because we now use these with non-acount folder stores.
2297 (modest_tny_account_get_special_folder),
2298 (modest_tny_account_new_from_server_account),
2299 (modest_tny_account_new_from_account):
2300 (recurse_folders): Adjust to the new outbox system.
2302 * src/modest-tny-folder.h:
2303 * src/modest-tny-folder.c:
2304 (modest_tny_folder_is_local_folder),
2305 (modest_tny_folder_get_local_folder_type),
2306 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2308 * src/widgets/modest-main-window.h:
2309 * src/maemo/modest-main-window.c: (create_details_widget),
2310 (modest_main_window_set_contents_style): Show details for any folder store,
2313 (modest_tny_folder_get_rules):
2314 Remove the const. C does not support constness enough for this.
2316 * src/modest-ui-actions.c:
2317 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2318 make all outboxes appear as one, in the usual local-folders tree node.
2320 (set_active_account_from_tny_account),
2321 (modest_ui_actions_on_folder_selection_changed):
2322 * src/widgets/modest-folder-view.c: (text_cell_data),
2323 (icon_cell_data), (filter_row),
2324 (add_account_folders_to_merged_folder),
2325 (add_account_folders_to_simple_folder_store), (),
2326 (get_cmp_rows_type_pos), (cmp_rows),
2327 (modest_folder_view_set_account_id_of_visible_server_account):
2328 Adjust to the new outbox system, using generic folder stores and folders
2329 in the GtkTreeModel.
2331 2007-05-23 Christian Kellner <ckellner@openismus.com>
2333 * src/modest-mail-operation.c:
2334 (modest_mail_operation_update_account):
2335 Use info->max_size instead of unintialized local var [small
2336 build fix]. (Added TODO to review that change since I don't
2339 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2341 * libmodest-dbus-client/libmodest-dbus-client.c:
2342 (libmodest_dbus_client_compose_mail): function added
2343 * src/dbus_api/modest-dbus-api.h:
2344 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2345 (on_compose_mail): Implementation of the SendAsMail functionality
2347 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2349 * src/modest-account-mgr.c:
2350 (modest_account_mgr_add_server_account): Set the secure-connection
2351 conf key for transport accounts as well as store accounts. I don't know
2352 why the if was there. For instance, this makes sure that we use SSL
2353 for the gmail preset from the easysetup wizard.
2355 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2357 * src/gnome/modest-main-window.c:
2358 (on_account_store_connecting_finished), (connect_signals):
2359 * src/maemo/modest-main-window.c:
2360 (on_account_store_connecting_finished), (connect_signals),
2361 (modest_main_window_new):
2362 Handle TnyAccountStore::connecting-finished instead of
2363 TnyDevice::connection-changed, because we cannot actually perform
2364 operations on accounts until TnyAccountStore has itself responded to
2365 the TnyDevice::connection-changed signal. This prevents a GError from
2367 Do not try to update at startup, because we (at least on scratchbox)
2368 already do an update at startup when the device goes online.
2369 This prevents a GError from tinymail.
2370 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2371 Added TODO about stopping simultaneous operations.
2373 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2375 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2376 * src/modest-mail-operation-queue.c:
2377 (modest_mail_operation_queue_remove):
2378 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2379 about where they happened.
2381 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2383 * src/modest-ui-actions.c:
2384 (modest_ui_actions_on_password_requested): Make sure that the remember
2385 output parameter is always TRUE.
2387 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2389 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2390 Show a OK/Cancel dialog if the error is a question, though we still do not
2391 know anything more about what we are asking the user.
2392 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2393 Fix an uninitialized variable (helper). This is a logic error, however.
2395 2007-05-21 Christian Kellner <ckellner@openismus.com>
2397 * src/modest-search.h:
2398 Correct bit shifting in the ModestSearchFlags enum.
2400 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2402 * src/modest-tny-account.c:
2403 (modest_tny_account_new_from_server_account): Do not use the lsub and
2404 check-all hard-coded IMAP options when using POP.
2406 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2408 * src/modest-tny-account.c:
2409 (modest_tny_account_new_from_server_account):
2410 Use NULL for the secure-auth method for POP when Password auth has been
2411 specified by the user, as we already do for IMAP. "auth=Login" causes
2412 an error from camel or the server.
2414 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2416 * src/maemo/modest-account-settings-dialog.c:
2417 (create_page_account_details),
2418 (modest_account_settings_dialog_set_account_name):
2419 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2420 for the leave-on-server checkbox, rathr than just the checkbox, when
2421 the protocol is not POP.
2423 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2425 * src/widgets/modest-account-view.c:
2426 * src/widgets/modest-account-view.h:
2427 Added modest_account_view_select_account() which will be useful later
2428 to asynchronously re-select the edited account.
2430 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2432 * src/maemo/modest-account-settings-dialog.c:
2433 (modest_account_settings_dialog_set_account_name):
2434 Automatically choose the port numbers based on the secure authentication
2435 methods, if they have not been chosen before.
2436 This fixes projects.maemo.org bug NB#56273 .
2438 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2440 * src/maemo/modest-main-window-ui.h:
2441 * src/modest-ui-actions.c:
2442 * src/modest-ui-actions.h:
2443 Connect the Tools/SMTP Servers menu item to
2444 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2445 SMTP servers dialog, as in the UI specification and saves changes when it
2446 is closed. This fixed projects.maemo.org bug NB#56305 .
2448 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2450 * src/maemo/modest-connection-specific-smtp-window.c:
2451 (modest_connection_specific_smtp_window_init):
2452 Use gtk_window_set_default_size() to make this window big enough, so
2453 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2455 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2457 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2458 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2459 (modest_connection_specific_smtp_edit_window_init),
2460 Do not try to connect to a combobox signal before the combobox exists.
2461 This fixes the cras in projects.maemo.org bug NB#56288 .
2462 (modest_connection_specific_smtp_edit_window_get_settings):
2463 Remove the server_account_name parameter which was being checked for NULL
2464 though it was not used.
2466 * src/maemo/modest-connection-specific-smtp-window.c:
2467 (modest_connection_specific_smtp_window_fill_with_connections),
2468 (on_button_edit), (modest_connection_specific_smtp_window_init):
2469 Correct the number of treemodel columns to prevent a warning.
2470 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2471 libconic does not work.
2473 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2475 * src/modest-tny-account.c:
2476 (modest_tny_account_new_from_server_account):
2477 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2478 SMTP when "None" was chosen by the user. However, with my SMTP server that
2479 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2482 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2484 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2485 to explain the memory management issue with the ID in the ModestPair.
2487 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2488 (add_sending_page), (modest_account_assistant_finalize):
2489 * src/gnome/modest-gnome-global-settings-dialog.c:
2490 (create_updating_page), (create_composing_page):
2491 * src/gnome/modest-msg-edit-window.c: (get_transports),
2492 (init_window), (modest_msg_edit_window_finalize),
2493 (modest_msg_edit_window_get_msg_data):
2494 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2495 * src/gnome/modest-transport-widget.c:
2496 (modest_transport_widget_finalize), (smtp_configuration):
2497 * src/maemo/modest-maemo-global-settings-dialog.c:
2498 (create_updating_page), (create_composing_page):
2499 * src/maemo/modest-msg-edit-window.c: (get_transports),
2500 (init_window), (modest_msg_edit_window_finalize),
2501 (modest_msg_edit_window_get_msg_data),
2502 (modest_msg_edit_window_free_msg_data):
2503 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2504 (modest_store_widget_finalize):
2505 * src/maemo/modest-transport-widget.c:
2506 (modest_transport_widget_finalize), (smtp_configuration):
2507 * src/modest-main.c: (send_mail):
2508 * src/widgets/modest-combo-box.h:
2509 * src/widgets/modest-global-settings-dialog-priv.h:
2510 * src/widgets/modest-global-settings-dialog.c:
2511 (modest_global_settings_dialog_finalize):
2512 * src/widgets/modest-msg-edit-window.h:
2513 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2514 as long as the combo box, to prevent use of freed memory for the ID.
2516 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2518 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2519 get_accounts(), to make this clearer. Do not check for the enabled gconf
2520 key, because we do not use this for server accounts (at least, not yet).
2521 This allows us to send email again.
2523 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2525 * src/maemo/modest-platform.c:
2526 (on_modest_conf_update_interval_changed), (modest_platform_init):
2527 Only respond to this particular key change. All these strcmp()s cannot be
2530 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2532 * src/maemo/modest-maemo-global-settings-dialog.c:
2533 (current_connection): Prevent a crash in scratchbox when
2534 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2535 * src/maemo/modest-platform.c:
2536 (on_modest_conf_update_interval_changed), (modest_platform_init):
2537 Get the update interval from gconf and reset it when the gconf key changes.
2539 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2541 * src/modest-protocol-info.c:
2542 * src/modest-protocol-info.h: Adde enum-specific get functions,
2543 instead of using a ModestProtocolType enum parameter.
2545 * src/gnome/modest-account-assistant.c:
2546 * src/gnome/modest-store-widget.c:
2547 * src/gnome/modest-store-widget.h:
2548 * src/gnome/modest-transport-widget.c:
2549 * src/gnome/modest-transport-widget.h:
2550 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2551 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2552 * src/maemo/easysetup/modest-easysetup-wizard.c:
2553 * src/maemo/modest-account-settings-dialog.c:
2554 * src/maemo/modest-account-settings-dialog.h:
2555 * src/maemo/modest-store-widget.c:
2556 * src/maemo/modest-store-widget.h:
2557 * src/maemo/modest-transport-widget.c:
2558 * src/maemo/modest-transport-widget.h:
2559 * src/modest-account-mgr-helpers.c:
2560 * src/modest-account-mgr-helpers.h:
2561 * src/modest-account-mgr.c:
2562 * src/modest-account-mgr.h:
2563 * src/modest-tny-account.c:
2564 * src/modest-tny-folder.c:
2565 * src/widgets/modest-account-view.c:
2566 * src/widgets/modest-retrieve-combo-box.c:
2567 * src/widgets/modest-retrieve-combo-box.h:
2568 * src/widgets/modest-secureauth-combo-box.c:
2569 * src/widgets/modest-serversecurity-combo-box.c:
2570 * src/widgets/modest-serversecurity-combo-box.h:
2571 * tests/check_account-mgr.c:
2572 Use the specific functions, and use the re-renamed enum values for GNOME too.
2574 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2576 * src/modest-pair.h:
2577 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2578 so we can get the second based on the first.
2580 * src/maemo/modest-account-settings-dialog.h:
2581 * src/maemo/modest-account-settings-dialog.c:
2582 Added get_supported_secure_authentication_methods(), though it is mostly
2583 commented-out for now until the necessary API is committed to tinymail.
2584 (modest_account_settings_dialog_set_account_name),
2585 (save_configuration): Request the supported authentication methods from the
2586 server, so we can choose a working method.
2588 * src/modest-tny-account-store.h:
2589 * src/modest-tny-account-store.c:
2590 (modest_tny_account_store_get_session): Rename from
2591 tny_account_store_get_session().
2593 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2595 * src/modest-protocol-info.h: Split the ModestProtocol enum
2596 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2597 There was no need to have these unrelated values in one enum.
2599 * src/: many files: Adapted to changed enum. This makes the code a bit
2600 clearer, and the compiler could catch some errors.
2602 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2604 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2605 Show the detailed internal camel error message when an error happens
2606 during the configuration, so that our testers can give us more clues.
2607 For instance, in projects.maemo.org bug NB#56910 .
2609 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2611 * src/modest-tny-account.c:
2612 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2613 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2615 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2617 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2618 * src/maemo/modest-account-settings-dialog.c:
2619 (modest_account_settings_dialog_set_account_name),
2620 (save_configuration): For the incoming secure authentication checkbox,
2621 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2622 the UI specification. PLAIN does not seem to be supported for most IMAP
2623 servers anyway, and I am not sure what it would mean.
2624 However, we probably need to discover which of the secure-authentication
2625 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2626 * src/modest-account-mgr-helpers.c:
2627 (modest_account_mgr_get_server_account_data):
2629 * src/modest-tny-account.c:
2630 (modest_tny_account_new_from_server_account):
2631 Use tny_account_set_mech() to set secure-authentication methods,
2632 with some special-casing for IMAP, based on my observations of how
2635 * src/modest-account-mgr-helpers.h:
2636 * src/modest-account-mgr.c:
2637 * src/modest-defs.h: Comment that the URI is only used for local folders.
2639 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2641 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2642 parameter const, just to be neat.
2643 * src/modest-text-utils.c: (modest_text_utils_inline):
2644 End g_strconcat() with NULL, as its documentation says. This is almost
2645 certainly the cause of my crash at startup on the device. Interestingly,
2646 valgrind doesn't tell us about these errors.
2648 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2650 * scripts/build-packages: Added more precise comments about how to use
2651 this script, though I still get this error:
2652 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2653 error building tinymail
2655 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2657 * src/maemo/modest-main-window.c: (on_account_update):
2658 Very slight cleanup, hoping to make it simpler to discover what causes
2659 a crash here sometimes.
2661 * src/modest-tny-account.c:
2662 (modest_tny_account_new_from_server_account): Set the port. Added
2663 comments about the options and a TODO comment because I need to find out
2664 how to specify the secure authentication method.
2666 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2668 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2669 changed CFlags paths form modest to libmodest
2671 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2673 * src/modest-account-mgr-helpers.c:
2674 (modest_account_mgr_get_server_account_data),
2675 (modest_account_mgr_free_server_account_data):
2676 * src/modest-account-mgr-helpers.h:
2677 * src/modest-account-mgr.c:
2678 (modest_account_mgr_add_server_account):
2679 * src/modest-defs.h:
2680 * src/modest-tny-account.c:
2681 (modest_tny_account_new_from_server_account):
2682 Determine the options for tny_camel_account_add_option() here,
2683 based on the settings, rather than storing them directly in gconf.
2685 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2687 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2688 Show a more friendly error dialog now that we expect (from the tinymail
2689 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2691 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2693 * src/maemo/modest-main-window.c: (on_account_update): Check that
2694 account_name is not NULL, to prevent a crash at startup that I am
2695 seeing on the N800. I do wonder why it is NULL.
2697 * src/maemo/easysetup/modest-easysetup-wizard.c:
2698 (create_page_user_details):
2699 * src/maemo/modest-account-settings-dialog.c:
2700 (create_page_user_details), (create_page_outgoing):
2701 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2702 (modest_connection_specific_smtp_edit_window_init):
2703 * src/modest-ui-actions.c:
2704 (modest_ui_actions_on_password_requested):
2705 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2706 might do something useful with the on-screen keyboard.
2708 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2710 * src/maemo/modest-main-window.c: (on_account_update):
2711 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2712 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2714 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2716 * src/modest-tny-account-store.c: (on_account_changed):
2717 Correct the signature of this signal handler.
2719 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2721 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2722 Show a HildonNote instead of a GtkDialog for Maemo.
2724 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2726 * src/widgets/modest-account-view.h:
2727 * src/widgets/modest-account-view.c: (on_account_changed),
2728 (on_account_removed). Added a boolean flag, set/unset by
2729 modest_account_view_block_conf_updates(),
2730 modest_account_view_unblock_conf_updates() to prevent unnecessary
2731 updates, but this is not very useful because the gconf notifications are
2732 so delays (maybe only on Maemo Bora).
2733 So auto-updating is turned off, and these functions do an explicit
2734 update when necessary.
2735 However, something else is still doing too much work when adding/removing
2736 accounts, probably in another part of the application.
2738 * src/maemo/modest-account-view-window.c:
2739 (on_delete_button_clicked), (on_edit_button_clicked),
2740 (on_new_button_clicked): Use the new functions.
2742 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2744 * src/modest-account-mgr-helpers.c:
2745 (modest_account_mgr_set_first_account_as_default):
2746 Sort the list of names alphabetically-by-title, so we choose the first one
2748 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2749 alphabetically by the title.
2751 This fixes projects.maemo.org bug NB#56418 .
2753 * src/modest-account-mgr-priv.c:
2754 (_modest_account_mgr_account_from_key):
2755 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2756 avoid a valgrind error, and possible random behaviour.
2758 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2760 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2761 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2762 tinymail documentation to say that this can be expected.
2763 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2764 pretty, and should not happen, but I would prefer to know when it does.
2766 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2768 * configure.ac: When using the older hildon version, probably on Bora,
2769 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2771 * src/widgets/modest-attachment-view.c:
2772 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2775 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2777 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2778 Implemented the prototype. Can be tested with
2779 tests/dbus_api/test_open_message:
2781 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2783 * src/modest-tny-account-store.c:
2784 (modest_tny_account_store_instance_init), (get_password):
2785 * src/modest-ui-actions.c:
2786 (modest_ui_actions_on_password_requested):
2787 Do not store the password in gconf, because this function is called
2788 for non-remembered passwords. Actually use the cached (in the hash map)
2789 password instead of releasing it.
2790 The password will now not be remembered if it is asked via the protected
2791 password dialog, as per the UI spec.
2793 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2795 * src/modest-defs.h:
2796 * src/modest-account-mgr-helpers.h:
2797 * src/modest-account-mgr-helpers.c:
2798 Added modest_server_account_get_username_has_succeeded(),
2799 modest_server_account_set_username_has_succeeded().
2800 (modest_server_account_set_username),
2801 Reset the has-succeeded flag if the username changes.
2803 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2804 * src/maemo/modest-connection-specific-smtp-window.c:
2805 (modest_connection_specific_smtp_window_save_server_accounts):
2806 Use modest_server_account_set_username() instead of using
2807 modest_conf_set_string() directly, so that the has-succeeded flag is always
2810 * src/modest-ui-actions.c:
2811 (modest_ui_actions_on_password_requested): Dim the username entry if
2812 the username has ever worked, as per the UI spec.
2814 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2816 * src/modest-tny-account-store.c: (get_password):
2817 * src/modest-ui-actions.c:
2818 (modest_ui_actions_on_password_requested):
2819 Allow the username to be changed too, though there is more work to
2820 be done on exactly how this behaves.
2822 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2824 * src/modest-account-mgr-helpers.h:
2825 * src/modest-account-mgr-helpers.c:
2826 Added modest_account_mgr_get_display_name(),
2827 modest_server_account_get_username(),
2828 modest_server_account_set_username(),
2829 modest_server_account_set_password(),
2830 modest_server_account_get_hostname() functions so we do not need to
2831 use the conf API directly.
2833 * src/maemo/modest-main-window.c: (connect_signals):
2834 Actually connect ot the ModestAccountStore::request-password signal,
2835 so that we show the dialog when the password is requested by Tinymail,
2836 for isntance if it is empty.
2838 * src/modest-marshal.list:
2839 * src/modest-tny-account-store.c:
2840 (modest_tny_account_store_class_init), (get_password),
2841 (modest_tny_account_store_alert):
2842 * src/modest-tny-account-store.h:
2843 * src/modest-ui-actions.h:
2844 * src/modest-ui-actions.c:
2845 (modest_ui_actions_on_password_requested):
2846 Change the signal parameters, so it is obvious that we are providing
2847 the non human-readable server name, and receiving both the username
2848 and password, though changing of the username is not yet implemented.
2849 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2850 for the GNOME version.
2852 This should fix the projects.maemo.org bug NB#56209, though it does not
2853 work on Bora, because the gconf_client_get() for the password fails
2854 immediately after we save it with gconf_client_set().
2856 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2859 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2860 caused an undefined symbol error:
2861 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2863 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2865 * src/modest-tny-account-store.c:
2866 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2867 using a GError instead of a string message, so we can translate it in
2870 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2872 * src/maemo/modest-address-book.c:
2873 (modest_address_book_check_names):
2874 * src/maemo/modest-msg-view-window.c:
2875 (modest_msg_view_window_clipboard_owner_change):
2876 * src/modest-init.c: (modest_init_init_ui):
2877 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2878 (update_folders_cb), (modest_mail_operation_update_account):
2879 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2880 (modest_ui_actions_on_msg_attachment_clicked),
2881 (modest_ui_actions_on_msg_recpt_activated):
2882 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2883 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2884 (modest_msg_view_search_next):
2885 * src/widgets/modest-recpt-editor.c:
2886 (modest_recpt_editor_on_button_release_event),
2887 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2888 g_message(). At this point we should only be seeing interesting errors on
2889 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2891 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2893 (modest_wizard_dialog_force_title_update):
2894 * src/maemo/easysetup/modest-wizard-dialog.h:
2895 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2896 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2897 can update the title when appropriate. Otherwise the title is wrong if the
2898 pages are added after adding the notebook to the dialog.
2899 This must be a problem in HildonWizardDialog too.
2900 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2902 * src/maemo/easysetup/modest-easysetup-wizard.c:
2903 (create_subsequent_customsetup_pages),
2904 (create_subsequent_easysetup_pages):
2905 Call modest_wizard_dialog_force_title_update() so that the title is
2906 correct even with GTK+ < 2.10.
2907 This fixes projects.maemo.org bug NB#56145 .
2909 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2911 * src/maemo/modest-platform.c:
2912 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2913 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2916 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2918 * src/widgets/modest-window.h:
2919 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2920 and modest_window_save_state(), which invokes it.
2922 * src/widgets/modest-window-mgr.h:
2923 * src/widgets/modest-window-mgr.c:
2924 Added modest_window_mgr_save_state_for_all_windows(), which calls
2925 the save_state vfunc on all registered windows, if implemented.
2927 * src/gnome/modest-msg-edit-window.c:
2928 * src/gnome/modest-msg-view-window.c:
2929 * src/maemo/modest-msg-edit-window.c:
2930 * src/maemo/modest-msg-view-window.c:
2931 * src/maemo/modest-main-window.c:
2932 Specify the existing save_settings functions as implementations of
2933 ModestWindow::save_state_func().
2935 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2936 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2937 enabling hibernation, for instance.
2939 We may need to do the same thing for restoring settings.
2942 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2944 * src/widgets/modest-window-mgr.c:
2945 * src/widgets/modest-window-mgr.h:
2946 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2947 modest_window_mgr_get_hibernation_is_prevented().
2949 * src/maemo/modest-main-window.c:
2950 (on_hildon_program_is_topmost_notify): Prevent hibernation
2951 (possible when the application goes to the background in the WM),
2952 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2954 * src/maemo/easysetup/modest-easysetup-wizard.c:
2955 (modest_easysetup_wizard_dialog_init):
2956 * src/maemo/modest-account-settings-dialog.c:
2957 (modest_account_settings_dialog_init):
2958 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2959 (modest_connection_specific_smtp_edit_window_init):
2960 * src/maemo/modest-connection-specific-smtp-window.c:
2961 (modest_connection_specific_smtp_window_init):
2962 * src/maemo/modest-signature-editor-dialog.c:
2963 (modest_signature_editor_dialog_init):
2964 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2965 prevent hibernation while any of these account settings dialogs are open.
2967 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2969 * src/maemo/Makefile.am:
2970 * src/maemo/modest-osso-state-saving.c:
2971 * src/maemo/modest-osso-state-saving.h: Added
2972 modest_osso_load_state() and modest_osso_save_state() though they do
2973 nothing now. They should iterate through all the open windows and load/save
2975 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2976 save state when closing.
2978 * src/maemo/modest-main-window.c:
2979 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2980 Add a notification handler for the HildonProgram::is-topmost property,
2981 so we can allow hibernation when the application goes into the background.
2982 But we still need to detect when the accounts setup windows are open so
2983 we can stop hibernation when they are open.
2984 To do this, I also added the main window the HildonProgram. This might have
2985 other side-effects/benefits, and should maybe be done for other windows.
2987 * src/maemo/modest-osso-autosave-callbacks.h:
2988 * src/maemo/modest-osso-autosave-callbacks.c:
2989 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2990 though it does not do anything yet, and we might never need this to do
2991 anything. For instance, we already save drafts.
2993 * src/maemo/modest-platform.c: (modest_platform_init):
2994 Specify the libosso auto-save callback.
2996 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2998 * src/maemo/modest-platform.c:
2999 (modest_platform_set_update_interval):
3000 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3001 aparently stays valid between application instances, so we can use this
3002 to remove and reset it later. According to a maemo-developers email from
3005 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3007 * configure.ac: Depend on libalarm for Maemo.
3009 * src/dbus_api/modest-dbus-api.h:
3010 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3011 (on_send_receive), (modest_dbus_req_handler):
3012 Handle a SEND_RECEIVE D-Bus method.
3014 * libmodest-dbus-client/libmodest-dbus-client.c:
3015 (libmodest_dbus_client_send_and_receive):
3016 * libmodest-dbus-client/libmodest-dbus-client.h:
3017 Add C convenience functions for calling the new D-Bus method.
3019 * src/modest-platform.h:
3020 * src/gnome/modest-platform.c:
3021 * src/maemo/modest-platform.c:
3022 Added modest_platform_set_update_interval(), which uses the
3023 alarmd API on Maemo.
3024 (modest_platform_init),
3025 Call modest_platform_set_update_interval(), using a hard-coded
3026 interval for now (until the global settings dialog is implemented),
3027 though I am not sure that this makes sense yet.
3029 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3031 * src/dbus_api/modest-dbus-callbacks.c:
3032 (modest_osso_cb_hw_state_handler):
3033 * src/dbus_api/modest-dbus-callbacks.h:
3034 * src/maemo/modest-platform.c: (modest_platform_init):
3035 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3036 in case this has some effect on the ability for Maemo to ping the
3039 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3041 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3042 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3043 warning. It is probably a logic error, but I need to fix the build.
3045 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3047 * src/modest-account-mgr.h:
3048 * src/modest-account-mgr.c:
3049 (modest_account_mgr_account_names): Add a gboolean enabled_only
3050 parameter, so we can get lists of onlt the enabled accounts.
3052 (modest_account_mgr_add_account),,
3053 (modest_account_mgr_account_with_display_name_exists):
3054 * src/maemo/modest-msg-edit-window.c: (get_transports):
3055 * src/modest-account-mgr-helpers.c:
3056 (modest_account_mgr_set_first_account_as_default):
3057 * src/modest-init.c: (init_default_account_maybe):
3058 * src/modest-tny-account-store.c: (get_accounts):
3059 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3060 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3061 * tests/check_account-mgr.c: (START_TEST):
3062 Provide the extra parameter, as appropriate.
3064 * src/widgets/modest-account-view.c: (update_account_view):
3065 Do not show disabled accounts (meaning that there is no way to
3066 enable/disable accounts in the UI (the feature is not in our UI
3067 specification), so we can use this internally only to mark unfinished
3068 or temporary account data.
3070 * src/maemo/easysetup/modest-easysetup-wizard.c:
3071 (create_account): Add boolean enable parameter, so we can specify FALSE
3072 to create the temporary account.
3073 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3074 (on_before_next): When finishing, when there is a temporary account, just
3076 Also, use a timeout to delay the showing of the dialog until gconf is likely
3077 to return correct information, due to a maemo gconf bug that is fixed in
3078 osso 1.1, but not yet in Bora.
3079 However, the dialog stays on screen after it is destroyed.
3081 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3082 for invalid data when cancelling. Use a hildon note instead of a dialog
3083 to complain about invalid data. Do not show the account-saved note if the
3084 account is disabled (a temporary account that will not really be saved for use
3087 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3089 * src/modest-account-mgr-helpers.h:
3090 * src/modest-account-mgr-helpers.c:
3091 Added modest_account_mgr_unset_default_account(),
3092 Added modest_account_mgr_set_first_account_as_default().
3094 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3095 If it was the default account, unset the default account name.
3097 * src/maemo/modest-account-view-window.c:
3098 (on_delete_button_clicked): If it was the default account,
3099 set the first remaining account as the default instead.
3101 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3102 a NULL account or a NULL default account, to prevent a crash. This should
3103 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3106 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3108 * src/widgets/modest-recpt-editor.c:
3109 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3110 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3111 TODO comment for this. This fixes the build.
3113 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3114 be the best place for it. This will in future update all auto-update accounts,
3115 rather than just the current/default account, when that gconf key exists.
3116 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3117 if there are no accounts, before calling do_send_receive().
3118 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3120 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3121 * src/maemo/modest-main-window-ui.h:
3122 * src/maemo/modest-main-window.c: (on_connection_changed),
3123 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3124 directly, becaue the signal handler does more.
3126 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3128 * src/modest-account-mgr-helpers.c:
3129 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3130 for the case that the account does not exist.
3132 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3133 (equivalent to the modest account name) rather than the tinymail account name
3134 (equivalent to the modest account title - human readable) to get the account data.
3135 Check for null account data to prevent the crash, and add a TODO comment saying that
3136 this needs fixing because it is using the server account name instead of the account name.
3138 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3140 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3141 * src/maemo/modest-account-settings-dialog.c: (show_error),
3143 Use hildon_note_new_information() for informative and error messages,
3144 which seems to be expected for Maemo applications (no documentation that I know of
3145 says this). I am surprised that there is no distinction between info and error
3148 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3150 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3151 it is easy to find where this is used.
3153 * src/maemo/easysetup/modest-easysetup-wizard.c:
3154 (create_page_welcome), (create_page_account_details),
3155 (create_page_user_details), (create_page_complete_easysetup),
3156 (create_page_custom_incoming), (create_page_custom_outgoing),
3157 (create_page_complete_custom):
3158 * src/maemo/modest-account-settings-dialog.c:
3159 (create_page_account_details), (create_page_user_details),
3160 (create_page_incoming), (create_page_outgoing):
3161 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3162 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3163 (modest_connection_specific_smtp_edit_window_init):
3164 * src/maemo/modest-connection-specific-smtp-window.c:
3165 (modest_connection_specific_smtp_window_init):
3166 * src/maemo/modest-signature-editor-dialog.c:
3167 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3168 and scrolling policy as per the Email Application Layout Guide, if I have
3171 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3173 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3174 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3175 which were empty, because these vfuncs have been removed from TnyAccountStore.
3176 This fixes the build.
3178 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3180 * src/maemo/modest-main-window.c:
3181 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3182 showing/hiding it. Added TODO because it probably should not be NULL.
3183 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3184 because unnecessary g_warnings() make degugging difficult.
3186 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3188 * src/maemo/modest-msg-edit-window.c:
3189 (modest_msg_edit_window_select_color),
3190 (modest_msg_edit_window_select_background_color): 2 const corrections and
3191 moving 2 #endifs before closing brackets, to fix the build.
3193 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3195 * src/maemo/easysetup/modest-easysetup-wizard.h:
3196 * src/maemo/easysetup/modest-easysetup-wizard.c:
3197 (modest_easysetup_wizard_dialog_finalize),
3198 (on_button_edit_advanced_settings), (create_page_complete_custom),
3199 (on_response), (create_account):
3200 Implement the Advanced Settings edit button, by saving the account information,
3201 for the Advanded Settings dialog to use directly from gconf, and removing it
3202 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3203 Bug #5533 in the projects.maemo.org bugzilla.
3205 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3207 * src/maemo/modest-msg-view-window.c:
3208 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3209 when opening a message window.
3211 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3213 * src/maemo/easysetup/modest-easysetup-wizard.c:
3214 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3217 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3218 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3219 gconf settings. I probably added more checks than necessary, but that is safer.
3221 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3222 variable to fix the build, but this seems to be used when it is still NULL.
3224 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3226 * src/modest-platform.h:
3227 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3228 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3229 * src/modest-main.c: Implement this function so we can avoid using
3230 maemo-specific API from cross-platform code.
3232 * src/modest-tny-account-store.c:
3233 (get_smtp_specific_transport_account_for_open_connection):
3234 * src/modest-ui-actions.c: (check_for_connection),
3235 (modest_ui_actions_on_item_not_found):
3236 Use modest_platform_connect_and_wait() and put #idefs around other
3237 maemo-specific code, because only maemo currently has a way to
3238 identify connection names.
3240 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3242 * src/modest-tny-account-store.h:
3243 * src/modest-tny-account-store.c:
3244 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3245 the connection-specific SMTP server settings in the configuration.
3247 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3249 * src/maemo/modest-main-window.c: (on_connection_changed),
3251 * src/modest-main.c: (main), (start_ui), (send_mail):
3252 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3253 that is what is intended.
3255 * src/modest-ui-actions.c: (action_send), (action_receive),
3256 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3257 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3258 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3259 SMTP server is used when it is specified.
3261 (modest_ui_actions_on_send_receive):
3262 Check that a connection is open before proceeding.
3263 Receive and then send, instead of vice-versa, as per the specification.
3265 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3267 * src/modest-mail-operation.c:
3268 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3269 though I guess it should be something other than NULL.
3271 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3273 * src/maemo/easysetup/modest-easysetup-wizard.c:
3274 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3275 combo twice, to avoid an g_warning and to make it visible again.
3276 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3277 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3278 (already intended) dereference when detaching, because we then recreate the menu.
3279 But I am not sure why the warning was happening, and it is possible that this is a memory
3282 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3284 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3285 and uri_parse_mailto() utility functions.
3286 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3288 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3290 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3292 * src/dbus_api/modest-dbus-api.h:
3293 * src/dbus_api/modest-dbus-callbacks.c:
3294 Use an idle callback to execute the modest code in the application's own thread.
3295 Remove the helloworld example method.
3296 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3297 parsed, and the open-message method is not implemented because this is not yet implemented in
3299 * libmodest-dbus-client/libmodest-dbus-client.c:
3300 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3301 (libmodest_dbus_client_open_message):
3302 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3304 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3305 body without crashing.
3307 * tests/dbus_api/Makefile.am:
3308 * tests/dbus_api/test_mail_to.c:
3309 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3311 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3313 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3314 Added file to fix the build. Sorry.
3316 * src/dbus_api/Makefile.am:
3317 * src/dbus_api/modest-dbus-api.h:
3318 * src/dbus_api/modest-dbus-callbacks.h:
3319 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3320 (modest_dbus_req_handler):
3321 Put constants in a separate header so it can be reused by the
3322 client library, without duplication
3324 * libmodest-dbus-client/Makefile.am:
3325 * libmodest-dbus-client/libmodest-dbus-client.c:
3326 (libmodest_dbus_client_call_helloworld),
3327 (libmodfest_dbus_client_send_mail),
3328 (libmodfest_dbus_client_mailto),
3329 (libmodfest_dbus_client_open_message):
3330 * libmodest-dbus-client/libmodest-dbus-client.h:
3331 (Partly) Implement a send_mail D-Bus method.
3333 * tests/dbus_api/Makefile.am:
3334 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3335 the send_email D-Bus method.
3337 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3341 * libmodest-dbus-client/Makefile.am:
3342 * libmodest-dbus-client/libmodest-dbus-client.c:
3343 * libmodest-dbus-client/libmodest-dbus-client.h:
3344 * tests/dbus_api/Makefile.am:
3345 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3346 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3348 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3350 * src/maemo/easysetup/modest-easysetup-wizard.c:
3351 (create_page_account_details):
3352 * src/maemo/modest-account-settings-dialog.c:
3353 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3354 widgets, because this might not be the default in future versions of the Maemo GTK+.
3355 However, I can not not get capitalization to work even in a simple test case.
3357 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3359 * src/maemo/easysetup/modest-easysetup-wizard.c:
3360 (create_page_custom_incoming), (create_page_custom_outgoing):
3361 * src/maemo/modest-account-settings-dialog.c:
3362 (create_page_account_details), (create_page_incoming),
3363 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3364 instead of using gtk_check_button_with_label(), so they are aligned like the other
3365 widgets, as per the UI spec.
3367 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3369 * src/maemo/easysetup/modest-easysetup-wizard.c:
3370 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3371 * src/widgets/modest-validating-entry.c:
3372 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3373 Modest prefix instead of an EasySetup prefix.
3375 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3377 * src/widgets/modest-validating-entry.h:
3378 * src/widgets/modest-validating-entry.c: (on_insert_text),
3379 Added easysetup_validating_entry_set_max_func(), used to set a callback
3380 to call when the max number of characters is reached. GtkEntry has a max-length
3381 already but is silent about it.
3383 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3384 (create_page_account_details), (create_page_user_details),
3386 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3387 (create_page_account_details), (create_page_user_details),
3388 (create_page_outgoing):
3389 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3390 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3391 the UI spec, when the user tries to enter more than the max number of characters.
3393 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3395 * src/maemo/easysetup/modest-easysetup-wizard.c:
3396 (create_page_user_details), (create_page_custom_incoming),
3397 (create_page_custom_outgoing):
3398 * src/maemo/modest-account-settings-dialog.c:
3399 (create_page_user_details), (create_page_incoming),
3400 (create_page_outgoing):
3401 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3402 (modest_connection_specific_smtp_edit_window_init):
3403 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3404 not appropriate. Bad Maemo-specific defaults!.
3406 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3408 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3409 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3410 (modest_signature_editor_dialog_set_settings):
3411 Disable the label and textview when the checkbox is disabled, and use the
3412 specified (UI spec) default signature text.
3414 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3416 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3417 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3419 * src/modest-defs.h:
3420 * src/modest-account-mgr-helpers.h:
3421 * src/modest-account-mgr-helpers.c:
3422 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3424 * src/maemo/Makefile.am:
3425 * src/maemo/modest-signature-editor-dialog.c:
3426 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3429 * src/maemo/modest-account-settings-dialog.h:
3430 * src/maemo/modest-account-settings-dialog.c:
3431 (modest_account_settings_dialog_finalize), (on_button_signature),
3432 (save_configuration): Use the new dialog when the Edit button is pressed, and
3433 save the changes if necessary, as per the UI spec.
3435 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3437 * src/maemo/Makefile.am:
3438 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3439 based on maemo-develoers email from Dirk.
3441 * src/maemo/easysetup/modest-easysetup-wizard.c:
3442 (create_page_welcome), (create_page_account_details),
3443 (create_page_user_details), (create_page_complete_easysetup),
3444 (create_page_custom_incoming), (create_page_custom_outgoing),
3445 (create_page_complete_custom),
3446 (modest_easysetup_wizard_dialog_init):
3447 * src/maemo/modest-account-settings-dialog.c:
3448 (create_page_account_details), (create_page_user_details),
3449 (create_page_incoming), (create_page_outgoing),
3450 (modest_account_settings_dialog_init):
3451 * src/maemo/modest-connection-specific-smtp-window.c:
3452 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3454 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3456 * src/maemo/easysetup/modest-easysetup-wizard.c:
3457 (create_page_account_details), (create_page_custom_outgoing),
3458 (create_page_complete_custom):
3459 * src/maemo/modest-account-settings-dialog.c:
3460 (create_page_user_details), (create_page_incoming),
3461 (create_page_outgoing):
3462 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3463 (modest_connection_specific_smtp_edit_window_init):
3464 Use the correct (UI spec) port min/max, and use horizontal separators,
3467 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3469 * src/maemo/easysetup/modest-easysetup-wizard.c:
3470 (set_default_custom_servernames):
3471 * src/maemo/modest-account-settings-dialog.c:
3472 (create_page_incoming), (on_combo_outgoing_security_changed),
3473 (on_combo_incoming_security_changed), (create_page_outgoing),
3474 (modest_account_settings_dialog_set_account_name),
3475 (save_configuration):
3476 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3477 (on_combo_security_changed),
3478 (modest_connection_specific_smtp_edit_window_init),
3479 (modest_connection_specific_smtp_edit_window_set_connection),
3480 (modest_connection_specific_smtp_edit_window_get_settings):
3481 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3484 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3487 * src/maemo/easysetup/modest-easysetup-wizard.c:
3488 (create_page_custom_outgoing), (create_page_complete_custom):
3489 * src/maemo/modest-account-settings-dialog.c:
3490 (create_page_user_details), (create_page_outgoing):
3491 * src/maemo/modest-account-view-window.c: (button_box_new):
3492 Use changed logical IDs as per the most recent UI spec:
3493 mcen_bd_emailsetup_edit -> mcen_bd_edit
3494 mcen_bd_emailsetup_delete -> mcen_bd_delete
3495 mcen_bd_emailsetup_close -> mcen_bd_close
3497 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3501 * src/dbus_api/Makefile.am:
3502 * src/dbus_api/modest-dbus-callbacks.c:
3503 * src/dbus_api/modest-dbus-callbacks.h:
3504 * src/maemo/modest-platform.c: (modest_platform_init):
3505 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3507 * tests/Makefile.am:
3508 * tests/dbus_api/Makefile.am:
3509 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3511 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3513 * src/maemo/modest-account-settings-dialog.c:
3514 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3515 Removed unnecessary includes.
3517 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3519 * src/maemo/easysetup/modest-easysetup-wizard.c:
3520 * src/maemo/modest-account-settings-dialog.c:
3521 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3522 * src/widgets/Makefile.am:
3523 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3524 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3525 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3526 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3527 * src/widgets/modest-secureauth-combo-box.c:
3528 * src/widgets/modest-secureauth-combo-box.h:
3529 * src/widgets/modest-serversecurity-combo-box.c:
3530 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3531 made the GObject names more consistent with the rest of the Modest code.
3533 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3535 * src/maemo/easysetup/Makefile.am:
3536 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3537 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3538 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3539 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3540 * src/maemo/easysetup/modest-easysetup-wizard.c:
3541 * src/maemo/easysetup/modest-validating-entry.c:
3542 * src/maemo/easysetup/modest-validating-entry.h:
3543 * src/maemo/modest-account-settings-dialog.c:
3544 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3545 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3546 widgets/ because they are used outside of easysetup too. After checking in,
3547 svn will allow me to rename them too.
3549 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3551 * src/gnome/modest-msg-edit-window.c:
3552 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3553 linker error, to fix the build on the GNOME platform.
3554 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3555 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3556 ifdefed out to avoid a warning.
3558 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3560 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3561 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3562 some alternative for GTK+ 2.6.
3564 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3566 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3568 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3569 specified for EmailAccountsDialog in UI spec.
3571 * src/maemo/easysetup/modest-easysetup-wizard.c:
3572 * src/maemo/easysetup/modest-easysetup-wizard.h:
3573 * src/maemo/modest-account-settings-dialog.c:
3574 * src/maemo/modest-account-settings-dialog.h:
3575 Reuse a member window widget for the connection-specific SMTP server accounts,
3576 so we can tell it to create/save the accounts only if we actually save changes.
3578 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3579 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3580 (modest_connection_specific_smtp_edit_window_get_settings):
3581 Return a struct instance for temporarily remembering the entered data.
3583 * src/maemo/modest-connection-specific-smtp-window.h:
3584 * src/maemo/modest-connection-specific-smtp-window.c:
3585 (modest_connection_specific_smtp_window_finalize),
3586 (modest_connection_specific_smtp_window_fill_with_connections),
3588 (modest_connection_specific_smtp_window_save_server_accounts),
3589 (update_model_server_names): Do not actually save data until asked,
3590 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3592 (on_selection_changed),
3593 (modest_connection_specific_smtp_window_init): Disable the edit
3594 button when nothing is selected.
3596 * src/modest-account-mgr-helpers.c:
3597 * src/modest-account-mgr-helpers.h:
3598 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3601 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3603 * src/modest-account-mgr-helpers.h:
3604 * src/modest-account-mgr-helpers.c:
3605 (modest_account_mgr_get_unused_account_name),
3606 (modest_account_mgr_get_unused_account_display_name): Added these
3607 utility functions, to avoid code duplication.
3609 * src/maemo/easysetup/modest-easysetup-wizard.c:
3610 (create_page_account_details), (create_account):
3611 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3612 (on_combo_security_changed),
3613 (modest_connection_specific_smtp_edit_window_init),
3614 (modest_connection_specific_smtp_edit_window_save_settings):
3615 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3616 * src/maemo/modest-connection-specific-smtp-window.c:
3617 (modest_connection_specific_smtp_window_finalize),
3618 (modest_connection_specific_smtp_window_fill_with_connections),
3619 (on_button_edit), (modest_connection_specific_smtp_window_init):
3620 * src/maemo/modest-connection-specific-smtp-window.h:
3621 Implementing saving of connection-specific server accounts.
3623 But I need to refactor this so we can save the data for each
3624 possible connection-specific account and only actually create the server accounts
3625 when the easysetup finished, or the OK button is pressed on the account settings
3628 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3630 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3631 (on_combo_security_changed):
3632 (modest_connection_specific_smtp_edit_window_init):
3633 Auto-fill the port number as in the account settings.
3635 (modest_connection_specific_smtp_edit_window_set_connection):
3636 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3637 * src/maemo/modest-connection-specific-smtp-window.c:
3638 (fill_with_connections), (on_button_edit),
3639 (modest_connection_specific_smtp_window_init):
3640 Turn the edit window into a dialog to simplify the code, and
3641 set a WM hint as in a GtkDialog, because only a popup can be on top of
3642 another window in Maemo, and popups usually have no WM decoration.
3644 * src/modest-defs.h:
3645 * src/modest-account-mgr-helpers.c:
3646 (modest_account_mgr_set_connection_specific_smtp),
3647 (modest_account_mgr_remove_connection_specific_smtp),
3648 (modest_account_mgr_get_connection_specific_smtp):
3649 * src/modest-account-mgr-helpers.h: Some functions to write the
3650 connection-specific SMTP server information. Not yet used.
3653 * src/widgets/modest-folder-view.c: (text_cell_data):
3654 Fix a warning about an uninitialized variable.
3655 (on_configuration_key_changed): Put an #ifdef around the use
3656 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3658 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3660 * src/maemo/modest-account-settings-dialog.h:
3661 * src/maemo/modest-account-settings-dialog.c:
3662 Added connect_for_modified() utility function to mark the new modified boolean.
3664 (create_page_account_details), (create_page_user_details),
3665 (create_page_incoming), (create_page_outgoing), (on_response),
3666 (modest_account_settings_dialog_init),
3667 (modest_account_settings_dialog_set_account_name):
3668 Only warn about unsaved changes when there are actually unsaved changes.
3670 * src/modest-account-mgr-helpers.c:
3671 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3672 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3673 to get the data from there in future.
3675 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3677 * src/modest-defs.h:
3679 * src/modest-account-mgr-helpers.h:
3680 * src/modest-account-mgr-helpers.c:
3681 Store the security account setting in a single conf key instead of using
3682 the options list, so that the list is left for just the to-be-removed camel hack,
3683 and because gconf_client_set_list() is failing for some reason.
3685 * src/modest-account-mgr.c:
3686 (modest_account_mgr_add_server_account):
3687 * src/maemo/modest-account-settings-dialog.c:
3688 (modest_account_settings_dialog_set_account_name),
3689 (save_configuration): Use the renamed functions.
3692 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3694 * src/widgets/Makefile.am:
3695 * src/widgets/modest-limit-retrieve-combo-box.c:
3696 * src/widgets/modest-limit-retrieve-combo-box.h:
3697 * src/widgets/modest-retrieve-combo-box.c:
3698 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3699 the account settings dialog.
3701 * src/modest-defs.h:
3702 * src/modest-account-mgr-helpers.h:
3703 * src/modest-account-mgr-helpers.c:
3704 (modest_server_account_get_option_secure_auth),
3705 (modest_server_account_set_option_secure_auth):
3706 * src/modest-account-mgr.c:
3707 (modest_account_mgr_add_server_account):
3708 Use the existing AUTH_MECH conf key for the secure-auth setting,
3709 instead of putting it in the list options, because this was actually used already.
3711 * src/maemo/modest-account-settings-dialog.c:
3712 (create_page_account_details),
3713 (modest_account_settings_dialog_set_account_name),
3714 (save_configuration):
3715 * src/maemo/modest-account-settings-dialog.h:
3716 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3717 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3719 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3721 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3722 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3723 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3725 * src/modest-defs.h:
3726 * src/maemo/modest-account-settings-dialog.c:
3727 (create_page_incoming), (on_combo_outgoing_security_changed),
3728 (on_combo_incoming_security_changed), (create_page_outgoing),
3729 (modest_account_settings_dialog_set_account_name),
3730 (save_configuration): Load/Save the port number, and change it when the
3731 security combo changes, to suitable defaults.
3733 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3735 * src/modest-account-mgr.c:
3736 (modest_account_mgr_add_server_account): Set the security and secure-auth
3737 options, and add a comment saying that the other camel-specific options should be
3740 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3742 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3744 * src/modest-tny-account-store.c: (account_list_free),
3745 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3746 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3749 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3751 * src/modest-protocol-info.c:
3752 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3753 is required by our UI spec. Maybe something in our implementation will use this eventually.
3754 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3755 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3756 instead of the previous 0 placeholder.
3758 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3759 secure-auth settings.
3760 * src/modest-account-mgr-helpers.h:
3761 * src/modest-account-mgr-helpers.c:
3762 (modest_server_account_data_get_option_secure_auth),
3763 (modest_server_account_set_option_secure_auth),
3764 (modest_server_account_data_get_option_security),
3765 (modest_server_account_set_option_security): Added this API for getting and setting the security
3766 and secure-auth settings.
3768 * src/maemo/modest-account-settings-dialog.h:
3769 * src/maemo/modest-account-settings-dialog.c:
3770 (modest_account_settings_dialog_finalize), (check_data),
3771 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3772 about changing titles.
3773 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3774 (save_configuration): Save the security and secure-auth settings.
3776 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3777 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3779 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3781 * src/modest-defs.h:
3782 * src/modest-account-mgr.c:
3783 (modest_account_mgr_add_server_account):
3784 Added and used defines for the options key and value pair strings,
3785 that are used so far, though they do not seem to correspond to anything in our
3786 UI specs or ModestProtocol enum.
3788 * src/modest-account-mgr-helpers.h:
3789 * src/modest-account-mgr-helpers.c:
3790 (compare_option_strings_for_name),
3791 (modest_server_account_data_get_option_value),
3792 (modest_server_account_data_get_option_bool),
3793 (modest_account_mgr_get_server_account_option):
3794 Added helper functions for parsing the options GSList.
3796 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3798 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3799 display name is based on the supplied account name.
3800 * src/modest-account-mgr.c:
3801 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3802 with an inefficient, but good-enough, implementation.
3804 * src/maemo/easysetup/modest-easysetup-wizard.c:
3805 (create_page_account_details), (on_before_next), (create_account):
3806 Check for existing display names rather than (non-user-visible) account names, and just
3807 create and set a unique account name at the end.
3809 * src/maemo/modest-account-settings-dialog.c:
3810 (modest_account_settings_dialog_init),
3811 (modest_account_settings_dialog_set_account_name),
3812 (create_page_incoming): Show the display name, instead of the account name.
3813 (on_response): Do some (not all) extra checks, as in the UI spec.
3814 (save_configuration): Save the display name if it was changed.
3816 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3818 * po/en_GB.po: Added needed logical ID and translation.
3819 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3820 (init_view): Made the is-default column clicking work.
3822 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3825 * src/maemo/easysetup/Makefile.am:
3826 * src/maemo/easysetup/modest-easysetup-wizard.c:
3827 (modest_easysetup_wizard_dialog_init):
3828 * src/maemo/easysetup/provider-data-test.keyfile:
3829 * src/maemo/easysetup/provider-data.keyfile:
3830 Moved the provider data file to the new modest-providers-data package and used it from there.
3832 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3834 * src/modest-local-folder-info.c:
3835 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3836 N_() was already used on the static strings, but this just marks it for translation without
3837 using the translation.
3839 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3841 * src/maemo/modest-account-settings-dialog.c:
3842 (create_page_incoming),
3843 (modest_account_settings_dialog_set_account_name):
3844 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3845 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3846 I will do this if nobody else gets there first.
3848 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3850 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3851 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3852 save the security stuff.
3854 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3856 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3857 Set the email address and user fullname, which I now see must be
3860 * src/maemo/modest-account-settings-dialog.h:
3861 * src/maemo/modest-account-settings-dialog.c:
3863 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3864 leave-on-server and authentication.
3865 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3868 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3871 * src/maemo/modest-account-settings-dialog.c:
3872 * src/maemo/modest-account-settings-dialog.h:
3873 Most (but not all) of the widgets are now present as specified by the UI spec.
3874 No changes are yet saved, and some details are not properly shown yet.
3876 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3878 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3880 * src/maemo/Makefile.am:
3881 * src/maemo/modest-account-settings-dialog.c:
3882 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3883 an existing account. Doesn't do much yet.
3885 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3886 Open the accounts settings dialog when Edit is clicked.
3888 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3890 * src/maemo/easysetup/Makefile.am:
3891 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3893 * src/maemo/easysetup/modest-easysetup-wizard.c:
3894 (modest_easysetup_wizard_dialog_init):
3895 Try to get the source directory from the build system,
3896 instead of hard-coding "./" into the source code, when opening our local
3897 copies of the configuration files.
3898 But this still fails when opening the wizard from the Accounts window,
3899 maybe because the working directory seems to change at runtime.
3900 So the wizard will fail the second time unless you copy the files into their
3901 proper locations - see the stdout warnings for the paths.
3903 (create_page_account_details),(on_before_next):
3904 Check for existing non-server accounts instead of server accounts,
3905 so the default account name is useful again, and to prevent trying to
3908 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3909 Show the wizard when New is clicked.
3911 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3912 (init_view): Show the column headers, and show the columns that are
3913 specified in the UI specs. However, something in Maemo's GTK+ prevents
3914 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3915 change the default account. This is despite unsetting the special properties.
3917 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3919 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3920 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3921 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3922 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3923 to make that clearer.
3924 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3926 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3928 * src/maemo/modest-account-view-window.c:
3929 (modest_account_view_window_init),
3930 (modest_account_view_window_new):
3931 Use the same buttons as specified in the
3932 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3933 the existing widgets, which never had a chance of working.
3934 Put the ModestAccountView treeview in a scrolled window.
3935 Do not repeat the initialization in both _init() and _new().
3937 * src/widgets/modest-account-view.c: (update_account_view):
3938 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3939 this widget and window shows no accounts.
3941 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3943 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3945 * src/maemo/easysetup/modest-easysetup-wizard.c:
3946 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3947 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3948 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3951 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3952 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3953 accounts exist yet, as in the UI spec.
3955 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3957 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3959 * src/maemo/Makefile.am:
3960 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3961 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3962 New window for editing connection-specific smtp details.
3963 Not fully implemented.
3965 * src/maemo/modest-connection-specific-smtp-window.c:
3966 (modest_connection_specific_smtp_window_finalize) :
3967 unref the tree model.
3968 (on_button_edit): Show the edit window.
3970 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3972 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3975 * src/maemo/Makefile.am:
3976 * src/maemo/modest-connection-specific-smtp-window.c:
3977 * src/maemo/modest-connection-specific-smtp-window.h:
3978 New window for showing the list of connections, for connection-specific
3979 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3980 * src/maemo/easysetup/modest-easysetup-wizard.c:
3981 (create_page_custom_outgoing): Show the new window when the button is clicked.
3983 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3985 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3986 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3987 * src/maemo/modest-msg-edit-window.c:
3988 (modest_msg_edit_window_insert_image):
3989 * src/modest-conf.c: (modest_conf_key_escape):
3990 * src/modest-mail-operation.c:
3991 (modest_mail_operation_send_new_mail):
3992 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3993 (modest_ui_actions_on_new_account):
3994 * src/widgets/modest-attachment-view.c: (update_filename_request):
3995 * src/widgets/modest-mail-header-view.c:
3996 Corrected warnings that were breaking the build, by commenting out unused variables,
3997 and a function, and by including a header.
3999 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4001 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4002 so we can #ifdef around platform-specific code when necessary.
4003 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4004 to allow this to build for the GNOME platform too.
4006 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4008 * src/maemo/easysetup/modest-easysetup-wizard.c:
4009 Added util_increment_name() and used it in create_page_account_details()
4010 to make sure that the default account name is always a new name.
4012 (modest_easysetup_wizard_dialog_init),
4013 (set_default_custom_servernames): Some minor memory management fixes.
4015 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4019 * src/modest-runtime.c: (init_i18n): Restored the translation
4020 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4021 are defined in config.h, and the translations are installed.
4023 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4024 is defined for translation.
4026 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4028 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4030 * src/maemo/easysetup/modest-easysetup-wizard.c:
4031 (modest_easysetup_wizard_dialog_init):
4032 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4033 Use realistic paths (though they should use $prefix generically) to the
4034 mcc_mapping and provider-data.keyfile files which might work when they
4035 are installed by the future version of the operator-wizard package,
4036 and then fallback to paths in our source code, with an explanatory
4039 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4043 * src/maemo/Makefile.am:
4044 * src/maemo/easysetup/: Added files from the previously-exernal
4045 osso-modest-easysetup.
4046 * src/maemo/modest-main-window-ui.h:
4047 * src/modest-ui-actions.c:
4048 * src/modest-ui-actions.h:
4049 Added modest_ui_actions_on_new_account() as a signal handler for the
4050 New Account menu item. It shows the easysetup wizard.
4051 * po/en_GB.po: Added additional needed logical IDs and translations.